On Fr, 2014-12-05 at 15:22 +0800, Gonglei wrote:
> On 2014/12/5 15:17, Gerd Hoffmann wrote:
>
> > On Fr, 2014-12-05 at 11:31 +0800, arei.gong...@huawei.com wrote:
> >> From: Gonglei
> >>
> >> If errors happen for middle items of channel_list,
> >> qmp_query_spice_channels() return NULL, and varri
On 2014/12/5 15:17, Gerd Hoffmann wrote:
> On Fr, 2014-12-05 at 11:31 +0800, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> If errors happen for middle items of channel_list,
>> qmp_query_spice_channels() return NULL, and varriable
>> cur_item going out of scope leaks the storage it points
saucy has seen the end of its life and is no longer receiving any
updates. Marking the saucy task for this ticket as "Won't Fix".
** Changed in: qemu (Ubuntu Saucy)
Status: New => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscrib
On Fr, 2014-12-05 at 11:31 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> If errors happen for middle items of channel_list,
> qmp_query_spice_channels() return NULL, and varriable
> cur_item going out of scope leaks the storage it points to.
> Let's check for errors in advance avoid m
On Thu, 12/04 15:49, Max Reitz wrote:
> Test 039 used qemu-io -c abort for simulating a qemu crash; however,
> abort() generally results in a core dump and ulimit -c 0 is no reliable
> way of preventing that. Use "abort -S 9" instead to have it crash
> without a core dump.
This needs to be fixed t
On Thu, 12/04 15:49, Max Reitz wrote:
> _filter_qemu_io already filters out the process ID when qemu-io is
> aborted; the same should be done when it is killed.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/common.filter | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
On Thu, 12/04 15:49, Max Reitz wrote:
> abort() has the sometimes undesirable side-effect of generating a core
> dump. If that is not needed, SIGKILL has the same effect of abruptly
> crash qemu; without a core dump.
>
> Thus, -c abort is not always useful to simulate a qemu-io crash;
> therefore,
On Thu, 12/04 15:00, Markus Armbruster wrote:
> Markus Armbruster (3):
> util: Drop superfluous conditionals around g_free()
> Fuse g_malloc(); memset() into g_new0()
> util: Use g_new() & friends where that makes obvious sense
>
> util/hbitmap.c | 4 ++--
> util/iov.c | 4 ++--
> uti
On Thu, 12/04 14:12, Markus Armbruster wrote:
> Markus Armbruster (3):
> scsi: Drop superfluous conditionals around g_free()
> scsi: Fuse g_malloc(); memset() into g_malloc0()
> scsi: Use g_new() & friends where that makes obvious sense
>
> hw/scsi/lsi53c895a.c | 2 +-
> hw/scsi/megasas.
On Thu, 12/04 14:59, Max Reitz wrote:
> On 2014-12-04 at 03:29, Fam Zheng wrote:
> >Also add version info for other transaction types.
> >
> >Signed-off-by: Fam Zheng
> >---
> > blockdev.c | 81
> >
> > qapi-schema.json | 7 +
>
On Thu, Nov 27, 2014 at 06:00:38PM +0100, Paolo Bonzini wrote:
> You're right. It's just that the API should be private to
> qemu-timer.c, it is not meant for external usage---and it is messy
> because get_clock_realtime() is for QEMU_CLOCK_HOST.
Somehow this got horrendously lost.
> In addition
On Thu, 12/04 14:43, Max Reitz wrote:
> >+if (!bs) {
> >+error_set(errp, QERR_DEVICE_NOT_FOUND, device);
> >+return;
> >+}
> >+
> >+target_bs = bdrv_find(target);
> >+if (!target_bs) {
> >+error_set(errp, QERR_DEVICE_NOT_FOUND, target);
> >+return;
>
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> On 04/12/2014 12:02, Pavel Dovgaluk wrote:
> >> > Why do you need to do this if !cpu_can_do_io(cpu)?
> > We save number of executed instruction when saving interrupt or exception
> > event.
> > It leads to the call of cpu_get_instructions_counte
On 2014/12/5 12:59, Eric Blake wrote:
> On 12/04/2014 08:31 PM, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> If errors happen for middle items of channel_list,
>> qmp_query_spice_channels() return NULL, and varriable
>
> s/return/returns/
> s/varriable/the variable/
>
>> cur_item going
On 12/04/2014 08:31 PM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> If errors happen for middle items of channel_list,
> qmp_query_spice_channels() return NULL, and varriable
s/return/returns/
s/varriable/the variable/
> cur_item going out of scope leaks the storage it points to.
> Let's
On 12/04/2014 06:12 AM, Markus Armbruster wrote:
> Markus Armbruster (3):
> scsi: Drop superfluous conditionals around g_free()
> scsi: Fuse g_malloc(); memset() into g_malloc0()
> scsi: Use g_new() & friends where that makes obvious sense
Series:
Reviewed-by: Eric Blake
>
> hw/scsi/lsi
From: Gonglei
Signed-off-by: Gonglei
---
hw/display/vga-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c
index db922f1..53739e4 100644
--- a/hw/display/vga-pci.c
+++ b/hw/display/vga-pci.c
@@ -321,6 +321,7 @@ static void secondary_class_init(
From: Gonglei
If errors happen for middle items of channel_list,
qmp_query_spice_channels() return NULL, and varriable
cur_item going out of scope leaks the storage it points to.
Let's check for errors in advance avoid memory leak.
Suggested-by: Paolo Bonzini
Signed-off-by: Gonglei
---
ui/spi
On behalf of the QEMU Team, I'd like to announce the availability of the
sixth release candidate for the QEMU 2.2 release. This release is meant
for testing purposes and should not be used in a production environment.
http://wiki.qemu.org/download/qemu-2.2.0-rc5.tar.bz2
The only changes in thi
On Thu, 12/04 08:43, Bryan D. Payne wrote:
> >
> > This doesn't stop the client from using a different alignment than we
> > expect.
> > It's necessary to be explicit as a binary protocol.
> >
>
> Ok, I'll move ahead with packing the data and sort out the backwards compat
> issues on the client si
On 12/04/2014 07:00 AM, Markus Armbruster wrote:
> Markus Armbruster (3):
> util: Drop superfluous conditionals around g_free()
> Fuse g_malloc(); memset() into g_new0()
> util: Use g_new() & friends where that makes obvious sense
Series:
Reviewed-by: Eric Blake
Up to the maintainer if the
On 12/04/2014 11:40 AM, Bryan D. Payne wrote:
>>
>> Off the top of my head, I know the -tpm command line options (related to
>> the 'query-tpm' QMP command) do this; look at hw/tpm/tpm_passthrough.c
>> for that implementation.
>
>
> So now I do see what you are talking about. But I don't think i
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1349277
Title:
AArch64 emulation ignores SPSel=0 when taking (or returning from) an
exception
** Also affects: qemu (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1349277
Title:
AArch64 emulation ignores SPSel=0 when taking (or returning f
On Thu, Dec 4, 2014 at 8:13 PM, Peter Maydell wrote:
> On 3 December 2014 at 20:17, Christoffer Dall
> wrote:
>> When resetting a VCPU we currently call both kvm_arm_vcpu_init() and
>> write_kvmstate_to_list(), both of which can fail, but we never check the
>> return value.
>>
>> The only choice
Uploaded fixed package for Vivid:
https://launchpad.net/ubuntu/+source/qemu/2.1+dfsg-7ubuntu3
Please let me know if this fixes the issue.
** Changed in: qemu (Ubuntu)
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, wh
The attachment "Proposed fix" seems to be a patch. If it isn't, please
remove the "patch" flag from the attachment, remove the "patch" tag, and
if you are a member of the ~ubuntu-reviewers, unsubscribe the team.
[This is an automated message performed by a Launchpad user owned by
~brian-murray, f
** Changed in: qemu (Ubuntu)
Assignee: (unassigned) => Chris J Arges (arges)
** Changed in: qemu (Ubuntu)
Status: New => In Progress
** Changed in: qemu (Ubuntu)
Importance: Undecided => Medium
--
You received this bug notification because you are a member of qemu-
devel-ml, whic
On 12/04/2014 08:56 AM, Markus Armbruster wrote:
>
> @device is a sub-optimal name for this single parameter. Either we
> accept that and move on, or we deprecate it in favor of a new parameter
> with a better name. I guess the better name isn't worth that much
> trouble, in particular since th
On 12/04/2014 02:26 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> backends/rng-random.c| 6 +-
> hw/tpm/tpm_passthrough.c | 4 +---
> util/uri.c | 43 +--
> 3 files changed, 19 insertions(+), 34 deletions(-)
On 12/04/2014 03:39 AM, Markus Armbruster wrote:
> As per standard operating procedure, I expanded tabs in the lines I
> touched. No visual difference, except in patches.
>
> What do you want me to do?
>
> 1. Don't expand tabs, ignore checkpatch.pl whining
>
> 2. Expand tabs in touched lines (
On 3 December 2014 at 20:17, Christoffer Dall
wrote:
> When resetting a VCPU we currently call both kvm_arm_vcpu_init() and
> write_kvmstate_to_list(), both of which can fail, but we never check the
> return value.
>
> The only choice here is to print an error an exit if the calls fail.
I like th
On 12/04/2014 02:51 AM, Max Reitz wrote:
>> Side note:
>>
>> Now that we can produce MUCH smaller images where the reftable can
>> easily require enough contiguous clusters to require the creation of at
>> least one refblock that cannot be self-referential, it would probably be
>> good to modify a
SCSI devices have multiple kinds of queries they need to respond
to, as defined in the "cmd inquiry" section in MMC-6 and SPC-3.
Relevent sections:
MMC-6 revision 2g:
Non-VPD response data and pointer to SPC-3;
Section 6.8 "Inquiry Command"
SPC-3 revision 23:
Inquiry command and
Newer kernels support a device attribute on the GIC which allows us to
tell it how many IRQs this GIC instance is configured with; use it, if
it exists.
Signed-off-by: Peter Maydell
---
hw/intc/arm_gic_kvm.c | 20
1 file changed, 20 insertions(+)
diff --git a/hw/intc/arm_gi
>
> Off the top of my head, I know the -tpm command line options (related to
> the 'query-tpm' QMP command) do this; look at hw/tpm/tpm_passthrough.c
> for that implementation.
So now I do see what you are talking about. But I don't think it applies
to this patch. I'm not using qemu_open in thi
Markus Armbruster writes:
> Eric Blake writes:
>
>> On 12/03/2014 03:30 AM, Kevin Wolf wrote:
>>> [ CCed Benoît and Max, this is blockdev work ]
>>> [ CCed Jeff, we're also talking about op blockers ]
>>>
>>> Not stripping quoted text for their convenience.
>>
>> I still intend to go through th
>
> Off the top of my head, I know the -tpm command line options (related to
> the 'query-tpm' QMP command) do this; look at hw/tpm/tpm_passthrough.c
> for that implementation.
>
Thanks, I'll check that out.
Cheers,
-bryan
On 19/11/2014 17:29, Maciej W. Rozycki wrote:
> qemu-mips32-addr.diff
> Index: qemu-git-trunk/target-mips/cpu.h
> ===
> --- qemu-git-trunk.orig/target-mips/cpu.h 2014-11-12 07:41:26.597542010
> +
> +++ qemu-git-trunk/target-mi
>
> Can you explain again why the existing commands to read guest memory
> (from the top of my head: dump-guest-memory, memsave, pmemsave) are
> insufficient? How does your solution improve on them? What exactly can
> it do what these commands can't? What exactly can't it do what these
> command
On Thu, 4 Dec 2014 18:20:05 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Dec 02, 2014 at 02:00:18PM +0100, Cornelia Huck wrote:
> > From: Thomas Huth
> >
> > Handle the virtio-ccw revision according to what the guest sets.
> > When revision 1 is selected, we have a virtio-1 standard device
> > w
>
> This doesn't stop the client from using a different alignment than we
> expect.
> It's necessary to be explicit as a binary protocol.
>
Ok, I'll move ahead with packing the data and sort out the backwards compat
issues on the client side.
-bryan
On Thu, Dec 04, 2014 at 11:26:58AM -0500, Don Slutz wrote:
[...]
> >those warnings less scary.
>
> It was not so much that hvmloader is the one to change (but having it check
> for room first might be good), but more that a change to xen would be good
> (like changing the wording or maybe only out
On 12/03/14 09:50, Stefano Stabellini wrote:
On Wed, 3 Dec 2014, Don Slutz wrote:
On 12/03/14 07:20, Stefano Stabellini wrote:
On Wed, 3 Dec 2014, Wei Liu wrote:
On Tue, Dec 02, 2014 at 03:23:29PM -0500, Don Slutz wrote:
[...]
hw_error("xc_domain_getinfo failed");
}
-i
On Tue, Dec 02, 2014 at 02:00:18PM +0100, Cornelia Huck wrote:
> From: Thomas Huth
>
> Handle the virtio-ccw revision according to what the guest sets.
> When revision 1 is selected, we have a virtio-1 standard device
> with byteswapping for the virtio rings.
>
> When a channel gets disabled, we
Fam Zheng writes:
> On Tue, 12/02 20:06, Markus Armbruster wrote:
>> == block-core.json ==
>>
>> * block-commit
>>
>> @device names a backend, @top and @base each name one of its nodes via
>> file name matching.
>>
>> TODO: support specifying the two nodes via node name.
>>
>> Why do
Kevin Wolf writes:
> [ CCed Benoît and Max, this is blockdev work ]
> [ CCed Jeff, we're also talking about op blockers ]
>
> Not stripping quoted text for their convenience.
>
> Am 02.12.2014 um 20:06 hat Markus Armbruster geschrieben:
>> = Introduction =
>>
>> The block layer and its monitor c
On 04/12/2014 12:02, Pavel Dovgaluk wrote:
>> > Why do you need to do this if !cpu_can_do_io(cpu)?
> We save number of executed instruction when saving interrupt or exception
> event.
> It leads to the call of cpu_get_instructions_counter() from cpu_exec function
> (through several replay functi
On Thu, Dec 4, 2014 at 11:39 PM, Kevin Wolf wrote:
> Am 04.12.2014 um 16:22 hat Ming Lei geschrieben:
>> On Thu, Dec 4, 2014 at 10:37 PM, Kevin Wolf wrote:
>> > Am 26.11.2014 um 15:46 hat Kevin Wolf geschrieben:
>> >> When getting an error while submitting requests, we must be careful to
>> >> wa
Am 04.12.2014 um 16:22 hat Ming Lei geschrieben:
> On Thu, Dec 4, 2014 at 10:37 PM, Kevin Wolf wrote:
> > Am 26.11.2014 um 15:46 hat Kevin Wolf geschrieben:
> >> When getting an error while submitting requests, we must be careful to
> >> wake up only inactive coroutines. Therefore we must special-
On Thu, Dec 4, 2014 at 10:37 PM, Kevin Wolf wrote:
> Am 26.11.2014 um 15:46 hat Kevin Wolf geschrieben:
>> When getting an error while submitting requests, we must be careful to
>> wake up only inactive coroutines. Therefore we must special-case the
>> currently active coroutine and communicate an
Hi all
guest will hang when call system function in migration thread. The cpu usage of
vcpu thread is 100%.
the code like this:
static void *migration_thread(void *opaque)
{
MigrationState *s = opaque;
int64_t initial_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
int64_t setup_star
On 04.12.2014 16:03, Kevin Wolf wrote:
Am 04.12.2014 um 15:42 hat Peter Lieven geschrieben:
On 04.12.2014 15:12, Kevin Wolf wrote:
Am 02.12.2014 um 15:33 hat Peter Lieven geschrieben:
this patch finally introduce multiread support to virtio-blk while
multiwrite support was there for a long tim
On 12/03/2014 03:07 PM, Bryan D. Payne wrote:
>>
>> In addition to Fam's review, I have a question - does this code properly
>> use qemu_open() so that I can use 'add-fd' to pass in a pre-opened
>> socket fd into fdset 1, then call pmemaccess with '/dev/fdset/1'? If
>> not, can you please fix it t
Am 04.12.2014 um 15:42 hat Peter Lieven geschrieben:
> On 04.12.2014 15:12, Kevin Wolf wrote:
> >Am 02.12.2014 um 15:33 hat Peter Lieven geschrieben:
> >>this patch finally introduce multiread support to virtio-blk while
> >>multiwrite support was there for a long time read support was missing.
> >
abort() has the sometimes undesirable side-effect of generating a core
dump. If that is not needed, SIGKILL has the same effect of abruptly
crash qemu; without a core dump.
Thus, -c abort is not always useful to simulate a qemu-io crash;
therefore, this patch adds a new sigraise command which allo
Test 039 used qemu-io -c abort for simulating a qemu crash; however,
abort() generally results in a core dump and ulimit -c 0 is no reliable
way of preventing that. Use "abort -S 9" instead to have it crash
without a core dump.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/039 | 12 +++
_filter_qemu_io already filters out the process ID when qemu-io is
aborted; the same should be done when it is killed.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/common.filter | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-i
Test 039 used to fail because qemu-io -c abort may generate core dumps
even with ulimit -c 0 (and the output then contains "(core dumped)").
Fix this by adding a new qemu-io command "sigraise" which invokes
raise(). Using this command to raise SIGKILL for example does not result
in a core dump, but
On 04.12.2014 15:12, Kevin Wolf wrote:
Am 02.12.2014 um 15:33 hat Peter Lieven geschrieben:
this patch finally introduce multiread support to virtio-blk while
multiwrite support was there for a long time read support was missing.
To achieve this the patch does serveral things which might need f
Public bug reported:
We are trying to convert a VMDK image to VHDX image for deploy to HyperV Server
( SCVMM 2012 SP1) using qemu-img.
We tried converting the image using both 'fixed' as well as 'dynamic' format.
We found that both the disks occupy the same size of 50GB. When the same is
done w
Am 26.11.2014 um 15:46 hat Kevin Wolf geschrieben:
> When getting an error while submitting requests, we must be careful to
> wake up only inactive coroutines. Therefore we must special-case the
> currently active coroutine and communicate an error for that request
> using the ordinary return value
On 2014-12-04 at 00:28, Fam Zheng wrote:
v4: Add Don's and Max's rev-by in 1, 3, 5, 6.
2/6: Add VMFSSPARSE (Max)
4/6: Don't set errno, and add a comment.
Fam Zheng (6):
vmdk: Use g_random_int to generate CID
vmdk: Fix comment to match code of extent lines
vmdk: Clean up descri
On 2014-12-04 at 03:29, Fam Zheng wrote:
This applies cases on drive-backup on blockdev-backup, except cases with
target format and mode.
Also add a case to check source == target.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/055 | 211 +
t
On Thu, 4 Dec 2014 07:28:32 +0800
Fam Zheng wrote:
> Since a too small file cannot be a valid VMDK image, and also since the
> buffer's first 4 bytes will be unconditionally examined by
> vmdk_open_sparse, let's error out the small file case to be clear.
>
> Signed-off-by: Fam Zheng
> ---
Revi
On Thu, 4 Dec 2014 07:28:30 +0800
Fam Zheng wrote:
> commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent
> type but the comment above the changed code is left out. Update the
> comment so they are consistent.
>
> Signed-off-by: Fam Zheng
> ---
Reviewed-by: Don Koch
> bl
Am 02.12.2014 um 15:33 hat Peter Lieven geschrieben:
> this patch finally introduce multiread support to virtio-blk while
> multiwrite support was there for a long time read support was missing.
>
> To achieve this the patch does serveral things which might need futher
> explaination:
>
> - the
Oops, subject lacks "util: " prefix. Perhaps it can be fixed up on
commit.
Signed-off-by: Markus Armbruster
---
util/uri.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/util/uri.c b/util/uri.c
index 01dc09e..918d235 100644
--- a/util/uri.c
+++ b/util/uri.c
@@ -1004,8 +1004,7 @@ URI *
uri_new(void) {
URI *ret;
-ret = (URI *) g_malloc(s
Markus Armbruster (3):
util: Drop superfluous conditionals around g_free()
Fuse g_malloc(); memset() into g_new0()
util: Use g_new() & friends where that makes obvious sense
util/hbitmap.c | 4 ++--
util/iov.c | 4 ++--
util/uri.c | 51 +++--
Signed-off-by: Markus Armbruster
---
util/uri.c | 48 ++--
1 file changed, 22 insertions(+), 26 deletions(-)
diff --git a/util/uri.c b/util/uri.c
index bbf2832..01dc09e 100644
--- a/util/uri.c
+++ b/util/uri.c
@@ -225,7 +225,7 @@ rfc3986_parse_scheme(U
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
This commit only touches allocations with size arguments of the form
si
On 2014-12-04 at 03:29, Fam Zheng wrote:
Also add version info for other transaction types.
Signed-off-by: Fam Zheng
---
blockdev.c | 81
qapi-schema.json | 7 +
2 files changed, 88 insertions(+)
diff --git a/blockdev.c b/
Signed-off-by: Markus Armbruster
---
target-i386/cpu.c | 2 +-
target-i386/kvm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index e9df33e..e132c7e 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1530,7 +1530,7 @@ static
Hi PMM,
On 2 December 2014 at 21:29, Peter Maydell wrote:
> On 28 November 2014 at 13:06, Pranavkumar Sawargaonkar
> wrote:
>> In KVM ARM64 one can choose to run guest in 32bit mode i.e EL1 in AARCH32
>> mode.
>> This patch adds qemu support for running guest EL1 in AARCH32 mode with
>> virt as
Signed-off-by: Markus Armbruster
---
hw/i386/pc_sysfw.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
index 75913c5..662d997 100644
--- a/hw/i386/pc_sysfw.c
+++ b/hw/i386/pc_sysfw.c
@@ -204,9 +204,7 @@ static void old_pc_system_rom_
Markus Armbruster (4):
x86: Drop superfluous conditionals around g_free()
x86: Fuse g_malloc(); memset() into g_malloc0()
x86: Use g_new() & friends where that makes obvious sense
x86: Drop some superfluous casts from void *
hw/i386/pc.c| 3 +--
hw/i386/pc_sysfw.c | 4 +
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
This commit only touches allocations with size arguments of the form
si
Coccinelle semantic patch:
@@
expression LHS, SZ;
@@
- LHS = g_malloc(SZ);
- memset(LHS, 0, SZ);
+ LHS = g_malloc0(SZ);
Signed-off-by: Markus Armbruster
---
target-i386/arch_dump.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
On 2014-12-04 at 03:29, Fam Zheng wrote:
Similar to drive-backup, but this command uses a device id as target
instead of creating/opening an image file.
Also add blocker on target bs, since the target is also a named device
now.
Add check and report error for bs == target which became possible
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
This commit only touches allocations with size arguments of the form
si
Markus Armbruster (2):
net: Fuse g_malloc(); memset() into g_new0()
net: Use g_new() & friends where that makes obvious sense
net/l2tpv3.c | 9 -
net/queue.c | 2 +-
net/slirp.c | 2 +-
3 files changed, 6 insertions(+), 7 deletions(-)
--
1.9.3
Signed-off-by: Markus Armbruster
---
net/l2tpv3.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/l2tpv3.c b/net/l2tpv3.c
index 3b805a7..6014c43 100644
--- a/net/l2tpv3.c
+++ b/net/l2tpv3.c
@@ -695,8 +695,7 @@ int net_init_l2tpv3(const NetClientOptions *opts,
go
On 4 December 2014 at 12:13, Gerd Hoffmann wrote:
> Hi,
>
> Last minute pull req for 2.2, carrying a security
> fix for cirrus bitblit ops.
Applied, thanks. We'll need to do an rc5 now; is there
anything else in the pipeline?
thanks
-- PMM
Signed-off-by: Markus Armbruster
---
hw/scsi/scsi-generic.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
index 6b9e4e1..e53470f 100644
--- a/hw/scsi/scsi-generic.c
+++ b/hw/scsi/scsi-generic.c
@@ -298,8 +298,7 @@ static
Coccinelle semantic patch:
@@
expression LHS, SZ;
@@
- LHS = g_malloc(SZ);
- memset(LHS, 0, SZ);
+ LHS = g_malloc0(SZ);
Signed-off-by: Markus Armbruster
---
hw/scsi/megasas.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/s
Markus Armbruster (3):
scsi: Drop superfluous conditionals around g_free()
scsi: Fuse g_malloc(); memset() into g_malloc0()
scsi: Use g_new() & friends where that makes obvious sense
hw/scsi/lsi53c895a.c | 2 +-
hw/scsi/megasas.c | 6 ++
hw/scsi/scsi-generic.c | 6 ++
hw/scs
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
This commit only touches allocations with size arguments of the form
si
On 2014-12-04 at 13:55, Markus Armbruster wrote:
g_new(T, 1) is safer than g_malloc(sizeof(T)), because it returns T *
rather than void *, which lets the compiler catch more type errors.
Missed in commit 02c4f26.
Signed-off-by: Markus Armbruster
---
aio-posix.c | 2 +-
aio-win32.c | 4 ++--
g_new(T, 1) is safer than g_malloc(sizeof(T)), because it returns T *
rather than void *, which lets the compiler catch more type errors.
Missed in commit 02c4f26.
Signed-off-by: Markus Armbruster
---
aio-posix.c | 2 +-
aio-win32.c | 4 ++--
async.c | 2 +-
3 files changed, 4 insertions(+)
Fam Zheng writes:
> On Thu, 12/04 11:39, Markus Armbruster wrote:
>> Fam Zheng writes:
>>
>> > On Thu, 12/04 10:26, Markus Armbruster wrote:
>> >> Signed-off-by: Markus Armbruster
>> >> ---
>> >> backends/rng-random.c| 6 +-
>> >> hw/tpm/tpm_passthrough.c | 4 +---
>> >> util/uri.c
On 2014/12/4 20:10, Daniel P. Berrange wrote:
> On Thu, Dec 04, 2014 at 08:07:14PM +0800, Gonglei wrote:
>> On 2014/12/4 17:53, Daniel P. Berrange wrote:
>>
>>> We do now provide Windows builds of viewer-viewer + remote-viewer
>>> in a single MSI installer for Win 32 & 64 bit
>>>
>>> http://virt
Issues:
* Doesn't check pitches correctly in case it is negative.
* Doesn't check width at all.
Turn macro into functions while being at it, also factor out the check
for one region which we then can simply call twice for src + dst.
This is CVE-2014-8106.
Reported-by: Paolo Bonzini
Signed-off
the git repository at:
git://git.kraxel.org/qemu tags/pull-cve-2014-8106-20141204-1
for you to fetch changes up to bf25983345ca44aec3dd92c57142be45452bd38a:
cirrus: don't overflow CirrusVGAState->cirrus_bltbuf (2014-12-01 10:25:4
This is CVE-2014-8106.
Signed-off-by: Gerd Hoffmann
---
hw/display/cirrus_vga.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
index d54fb06..2725264 100644
--- a/hw/display/cirrus_vga.c
+++ b/hw/display/cirrus_vga.c
@@ -293,6 +293,10 @@
On Thu, Dec 04, 2014 at 08:07:14PM +0800, Gonglei wrote:
> On 2014/12/4 17:53, Daniel P. Berrange wrote:
>
> > We do now provide Windows builds of viewer-viewer + remote-viewer
> > in a single MSI installer for Win 32 & 64 bit
> >
> > http://virt-manager.org/download/
>
> Hi,
>
> I had instal
On 2014/12/4 17:53, Daniel P. Berrange wrote:
> We do now provide Windows builds of viewer-viewer + remote-viewer
> in a single MSI installer for Win 32 & 64 bit
>
> http://virt-manager.org/download/
Hi,
I had installed virt-viewer-x86-1.0.msi on my windows machine,
and I connected the guest
On Mon, 3 Nov 2014 13:50:24 +0100
Thomas Huth wrote:
> On Wed, 22 Oct 2014 15:16:29 -0400
> Don Slutz wrote:
>
> > On 10/22/14 08:28, Thomas Huth wrote:
> > > Linus likely does not want to get e-mails about QEMU, so let's
> > > just remove this option.
> > >
> > > Suggested-by: Michael S. Tsirk
On Thu, 12/04 11:39, Markus Armbruster wrote:
> Fam Zheng writes:
>
> > On Thu, 12/04 10:26, Markus Armbruster wrote:
> >> Signed-off-by: Markus Armbruster
> >> ---
> >> backends/rng-random.c| 6 +-
> >> hw/tpm/tpm_passthrough.c | 4 +---
> >> util/uri.c | 43 +++
From: Gonglei
We can use it for checking when we change traditional
boot order dynamically and propagate error message
to the monitor.
Signed-off-by: Gonglei
---
bootdevice.c| 10 +-
include/sysemu/sysemu.h | 2 +-
vl.c| 15 +--
3 files chan
1 - 100 of 125 matches
Mail list logo
