Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

On Do, 2014-11-13 at 11:16 -0700, Al Stone wrote: > On 11/13/2014 01:10 AM, Gerd Hoffmann wrote: > > Hi, > > > >> My understanding from an IRC conversation yesterday was that at > >> least some of these ACPI blobs contain data which has to be constructed > >> at the point it is requested (ie is

Re: [Qemu-devel] [PATCH] functional ARM semihosting under GDB

On 14 Nov 2014, at 02:25, Liviu Ionescu wrote: > (gdb) system_reset in fact this is (gdb) mon system_reset Liviu

Re: [Qemu-devel] Better Cortex-M support?

On 14 Nov 2014, at 03:01, Alistair Francis wrote: > I haven't looked into CMSIS or using SysTick, so I can't confirm that > they work. I don't have any experience with using either, so I can't > really be of much help with those. when you'll have some time, perhaps it would be useful to install

[Qemu-devel] iothread object hotplug ?

Hi, I would like to known if it's possible to hot-add|hot-plug an iothread object on a running guest ? (I would like to be able to hotplug new virtio devices on new iothread at the same time) Regards, Alexandre

Re: [Qemu-devel] [PATCH] Add bootloader name to multiboot implementation

On Wed Oct 29, 2014 at 23:52:03 -0600, Drew DeVault wrote: > The name is set to "qemu". > > Signed-off-by: Drew DeVault > --- > For the future, it may be useful to add a command line flag for setting this > to > some user-specified value. I also considered naming it "qemu-system-i386" or > "qemu

[Qemu-devel] [PATCH] vmdk: Leave bdi intact if -ENOTSUP in vmdk_get_info

When extent types don't match, we return -ENOTSUP. In this case, be polite to the caller and don't modify bdi. Signed-off-by: Fam Zheng --- block/vmdk.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 673d3f5..2cbfd3e 10

Re: [Qemu-devel] [Bug 1392504] [NEW] USB Passthrough is not working anymore

On 2014/11/14 6:12, Leen Keus wrote: > Public bug reported: > > After upgrading from Ubuntu 14.04 to Ubuntu 14.10 USB passthrough in > QEMU (version is now 2.1.0 - Debian2.1+dfsg-4ubuntu6.1) is not working > any more. Already tried to remove and attach the USB devices. I use 1 > USB2 HDD + 1 US

[Qemu-devel] [PATCH] gtk: fix possible memory leak about local_err

local_err in gd_vc_gfx_init() is not freed, and we don't use it, so remove it. Signed-off-by: zhanghailiang --- ui/gtk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 38bf463..9496b8d 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1666,10 +1666,9 @@ st

Re: [Qemu-devel] [PATCH] l2tpv3: fix possible double free

On 2014/11/14 9:39, zhanghailiang wrote: > freeaddrinfo(result) does not assign result = NULL, after frees it. > There will be a double free when it goes error case. > It is reported by covertiy. > > Signed-off-by: zhanghailiang > --- > net/l2tpv3.c | 1 + > 1 file changed, 1 insertion(+) Rev

[Qemu-devel] [PATCH v2] libcacard: fix resource leak

In function connect_to_qemu(), getaddrinfo() will allocate memory that is stored into server, it should be freed by using freeaddrinfo() before connect_to_qemu() return. Signed-off-by: zhanghailiang --- v2: - fix typo in title ;) --- libcacard/vscclient.c | 7 ++- 1 file changed, 6 insertion

[Qemu-devel] [PATCH] libcacard: fix resource lead

Signed-off-by: zhanghailiang --- libcacard/vscclient.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index 80111df..fa6041d 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -597,7 +597,7 @@ connect_to_qemu(

Re: [Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a 'guest_writable' callback for users

On (Thu) 13 Nov 2014 [15:47:12], Gerd Hoffmann wrote: > On Di, 2014-10-28 at 20:21 +0530, Amit Shah wrote: > > Users of virtio-serial may want to know when a port becomes writable. A > > port can stop accepting writes if the guest port is open but not being > > read from. In this case, data gets

[Qemu-devel] [PATCH] l2tpv3: fix possible double free

freeaddrinfo(result) does not assign result = NULL, after frees it. There will be a double free when it goes error case. It is reported by covertiy. Signed-off-by: zhanghailiang --- net/l2tpv3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 528d95b..f9e0c9

Re: [Qemu-devel] Better Cortex-M support?

On Thu, Nov 13, 2014 at 5:48 PM, Liviu Ionescu wrote: > > On 13 Nov 2014, at 02:11, Alistair Francis wrote: > >> I am trying to model the Netduino Plus 2 (STM32F4xx - Cortex-M4) board... >> upstreamed to mainline by using the Netduino 2 board (STM32F2xx - >> Cortex-M3). > > ok, great work! > > ho

Re: [Qemu-devel] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

On Thu, Nov 13, 2014 at 08:06:55PM +0530, Aravinda Prasad wrote: > > > On Thursday 13 November 2014 06:14 PM, David Gibson wrote: > > On Thu, Nov 13, 2014 at 05:18:16PM +0530, Aravinda Prasad wrote: > >> On Thursday 13 November 2014 04:02 PM, David Gibson wrote: > >>> On Thu, Nov 13, 2014 at 11:2

Re: [Qemu-devel] [PATCH] functional ARM semihosting under GDB

to test the patch, you can download an unit test application from: https://dl.dropboxusercontent.com/u/78151643/gcm.elf there are two use cases: 1) standalone (usually unit tests integrated in a continuous integration system) $ ./qemu-system-arm -machine lm3s6965evb -image gcm.elf -se

Re: [Qemu-devel] runtime configurable semihosting

On 13 November 2014 22:23, Liviu Ionescu wrote: > > On 14 Nov 2014, at 00:16, Peter Maydell wrote: > >> Right, but what does it mean to say 'gdb' that's different from >> 'auto' ? > > auto sends either to gdb or qemu, gdb always sends to gdb, native always to > qemu. > >> What happens in that ca

[Qemu-devel] [Bug 1392504] [NEW] USB Passthrough is not working anymore

Public bug reported: After upgrading from Ubuntu 14.04 to Ubuntu 14.10 USB passthrough in QEMU (version is now 2.1.0 - Debian2.1+dfsg-4ubuntu6.1) is not working any more. Already tried to remove and attach the USB devices. I use 1 USB2 HDD + 1 USB3 HDD to a virtual linux machine; 1 USB2 HDD to a

[Qemu-devel] [Bug 1392468] [NEW] qemu uses a bitmap icon

Public bug reported: qemu currently uses the icon in pc-bios/qemu-icon.bmp, which, obviously, is a bitmap file. It is loaded such that white pixels will be transparent. This can cause nasty artifacts in the display. Unless there is a specific reason to use bitmaps, I'd suggest moving to, e.g., a

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

On 11/13/2014 01:10 AM, Gerd Hoffmann wrote: > Hi, > >> My understanding from an IRC conversation yesterday was that at >> least some of these ACPI blobs contain data which has to be constructed >> at the point it is requested (ie is not fixed at the point when >> QEMU starts up), because OVMF w

Re: [Qemu-devel] runtime configurable semihosting

On 14 Nov 2014, at 00:16, Peter Maydell wrote: > Right, but what does it mean to say 'gdb' that's different from > 'auto' ? auto sends either to gdb or qemu, gdb always sends to gdb, native always to qemu. > What happens in that case if you don't have a gdb > attached? according to my tests,

Re: [Qemu-devel] runtime configurable semihosting

On 13 November 2014 21:51, Liviu Ionescu wrote: > > On 13 Nov 2014, at 23:38, Peter Maydell wrote: > >> On 13 November 2014 21:23, Liviu Ionescu wrote: > >> ...I'm confused, I think. I thought 'gdb' was an option you added? > > that's correct, but only part of the whole image, in fact I added >

Re: [Qemu-devel] runtime configurable semihosting

On 13 Nov 2014, at 23:38, Peter Maydell wrote: > On 13 November 2014 21:23, Liviu Ionescu wrote: > ...I'm confused, I think. I thought 'gdb' was an option you added? that's correct, but only part of the whole image, in fact I added "-semihosting-target auto|native|gdb"; however my patch only

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

Stefan Hajnoczi November 13, 2014 at 12:55 PM One more thing about email configuration: the character set encoding of your emails seems to be incorrect. GMail is rendering a superscript 1 (like "to the power of one") when you wanted a single quote: https://en.wikip

Re: [Qemu-devel] runtime configurable semihosting

On 13 November 2014 21:23, Liviu Ionescu wrote: > > On 13 Nov 2014, at 19:52, Peter Maydell wrote: > >> ... I'm not sure how useful "gdb" is as distinct from >> "auto" (what do you do with the semihosting requests if no >> gdb is connected in this case?). > > well, I also had some doubts about "g

Re: [Qemu-devel] runtime configurable semihosting

On 13 Nov 2014, at 23:23, Liviu Ionescu wrote: > ... "gdb", but since I never used this configuration... btw, can anyone suggest how to configure things to test this kind of 'semihosting forwarding'? does the standard GDB support this, or a custom one is required? from the source code I saw

Re: [Qemu-devel] runtime configurable semihosting

On 13 Nov 2014, at 19:52, Peter Maydell wrote: > ... I'm not sure how useful "gdb" is as distinct from > "auto" (what do you do with the semihosting requests if no > gdb is connected in this case?). well, I also had some doubts about "gdb", but since I never used this configuration, I preferre

Re: [Qemu-devel] State of ARM FIQ in Qemu

On 13 November 2014 10:46, Peter Maydell wrote: > On 13 November 2014 16:26, Tim Sander wrote: > > This is the gcc inline assembly syntax from my kernel module written in > c: > > asm("mrc p15, 0, %0, c12, c0, 0" : "=r"(vbar) : : "cc"); > > asm("mrc p15, 0, %0, c12, c0, 1" : "=r"(mvbar) : : "cc"

Re: [Qemu-devel] [PATCH v3 for-xen-4.5] xen_disk: fix unmapping of persistent grants

On Thu, Nov 13, 2014 at 06:42:09PM +0100, Roger Pau Monne wrote: > This patch fixes two issues with persistent grants and the disk PV backend > (Qdisk): > > - Keep track of memory regions where persistent grants have been mapped >since we need to unmap them as a whole. It is not possible to u

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

On 13/11/2014 19:16, Al Stone wrote: >> > [root@fedora ~]# cat /proc/ioports >> > [ ... ] >> > 0600-063f : :00:01.3 >> > 0600-0603 : ACPI PM1a_EVT_BLK >> > 0604-0605 : ACPI PM1a_CNT_BLK >> > 0608-060b : ACPI PM_TMR >> > 0700-070f : :00:01.3 >> > 0700-0707 : piix4_smbu

Re: [Qemu-devel] [Bug 1258168] Re: QEMU fails to build on CentOS 5.10 with --disable-pie reporting "/usr/bin/ld: -f may not be used without -shared "

On 13/11/2014 19:14, Don Slutz wrote: > + case "$*" in > + echo libtool --mode=link --tag=CC cc -Werror -m64 -g > -Wc,-fstack-protector-all -o config-temp/libqemu-conf.la > config-temp/qemu-conf.lo > + libtool --mode=link --tag=CC cc -Werror -m64 -g -Wc,-fstack-protector-all > -o config-temp/l

Re: [Qemu-devel] [PATCH v3 for-xen-4.5] xen_disk: fix unmapping of persistent grants

On 11/13/2014 05:42 PM, Roger Pau Monne wrote: This patch fixes two issues with persistent grants and the disk PV backend (Qdisk): - Keep track of memory regions where persistent grants have been mapped since we need to unmap them as a whole. It is not possible to unmap a single grant

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] PPC: e500 pci host: Add support for ATMUs

> Am 13.11.2014 um 16:08 schrieb "bharat.bhus...@freescale.com" > : > > > >> -Original Message- >> From: qemu-ppc-bounces+bharat.bhushan=freescale@nongnu.org >> [mailto:qemu-ppc- >> bounces+bharat.bhushan=freescale@nongnu.org] On Behalf Of Alexander Graf >> Sent: Thursday, N

Re: [Qemu-devel] [PATCH 0/9] valgrind/i386/s390x: memcheck false positives

Am 13.11.2014 um 15:34 schrieb Paolo Bonzini: > On 30/10/2014 10:36, Christian Borntraeger wrote: >> This series avoids most memcheck false positives in KVM ioctls on s390x >> and x86_64. >> >> Please review and consider for 2.2 or later. Some of these things could >> also be fixed in valgrind, but

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

On Thu, Nov 13, 2014 at 5:32 PM, Gary Hook wrote: > On 11/13/14, 11:03 AM, "Eric Blake" wrote: > >>On 11/13/2014 09:44 AM, Gary Hook wrote: >> >>[metacomment] >> >>> On 11/13/14, 6:46 AM, "Markus Armbruster" >>>mailto:arm...@redhat.com>> wrote: >>> >>> Stefan Hajnoczi mailto:stefa...@gmail.com>>

Re: [Qemu-devel] [Bug 1258168] Re: QEMU fails to build on CentOS 5.10 with --disable-pie reporting "/usr/bin/ld: -f may not be used without -shared "

On 13/11/2014 19:05, Don Slutz wrote: > No change. > > LINK qemu-bridge-helper > CCqmp-marshal.o > lt LINK vscclient > /usr/bin/ld: -f may not be used without -shared > collect2: ld returned 1 exit status > make: *** [vscclient] Error 1 > make: *** Waiting for unfinished jobs > dcs-

Re: [Qemu-devel] [PATCH] Add bootloader name to multiboot implementation

Sorry for the delay. The patch looks good; unfortunately we cannot apply it now because QEMU 2.2 is in hard freeze. Thanks for your contribution! Paolo On 13/11/2014 18:46, Drew DeVault wrote: > cc-ing a few people I found in the blame for the relevant files. Mind > taking a look at this patch?

[Qemu-devel] [RFC 4/4] qdev: Make subclasses inherit properties from superclass

Instead of scanning all parent classes every time we walk the list of properties, just make DeviceState subclasses inherit the property list from the parent class. Signed-off-by: Eduardo Habkost --- hw/core/qdev-properties.c | 15 +-- hw/core/qdev.c| 42 +++---

[Qemu-devel] [RFC 1/4] qdev: Variable name style fix

Use 'DeviceClass *dc' instead of 'klass'. Signed-off-by: Eduardo Habkost --- hw/core/qdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 413b413..5c6a109 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -1150,12 +1150,12

[Qemu-devel] [RFC 2/4] qdev: Wrap DeviceClass.props setting into a function

The property array will become a linked list. Wrap the DeviceClass.props setting into a function so later we can change how it is set. Coccinelle semantic patch: @@ typedef ObjectClass; identifier class_init_func, klass, data, dc; expression proplist; @@ static void class_init_func(ObjectClass *k

[Qemu-devel] [RFC 3/4] qdev: Make DeviceClass.props a linked list

This will allow the list to be easily extended by class_init functions, instead of requiring a static array to be defined at build time. It will also allow subclasses to easily inherit the properties from parent classes, instead of requiring code to walk all parent classes to find a property. Sig

[Qemu-devel] [RFC 0/4] qdev: Simplify property registration/walking

This series is an attempt to simplify the way properties are added to classes, and the way code walks the list of properties for a device class. Now instead of requiring code to manually check the parent classes, the property lists are automatically copied from the parent class, and subclasses jus

Re: [Qemu-devel] [Bug 1258168] Re: QEMU fails to build on CentOS 5.10 with --disable-pie reporting "/usr/bin/ld: -f may not be used without -shared "

No change. LINK qemu-bridge-helper CCqmp-marshal.o lt LINK vscclient /usr/bin/ld: -f may not be used without -shared collect2: ld returned 1 exit status make: *** [vscclient] Error 1 make: *** Waiting for unfinished jobs dcs-xen-53:~/qemu/out/bug-1258168> -Don Slutz On 11/13/14

Re: [Qemu-devel] [PATCH 0/2] ahci: small cleanups

On 11/13/2014 05:24 AM, Stefan Hajnoczi wrote: Two small cleanups for QEMU 2.3: 1. Avoid DEBUG_AHCI bitrot 2. Use FIS type constants instead of magic numbers See commit descriptions for details. Stefan Hajnoczi (2): ahci: avoid #ifdef DEBUG_AHCI bitrot ahci: replace SATA FIS type magic

[Qemu-devel] [PATCH v3 for-xen-4.5] xen_disk: fix unmapping of persistent grants

This patch fixes two issues with persistent grants and the disk PV backend (Qdisk): - Keep track of memory regions where persistent grants have been mapped since we need to unmap them as a whole. It is not possible to unmap a single grant if it has been batch-mapped. A new check has also be

Re: [Qemu-devel] [Bug 1258168] Re: QEMU fails to build on CentOS 5.10 with --disable-pie reporting "/usr/bin/ld: -f may not be used without -shared "

Here is a fixed version. I missed the -rpath /usr/local/lib in the libtool_prog function: diff --git a/configure b/configure index 47048f0..b7bf30a 100755 --- a/configure +++ b/configure @@ -140,8 +140,10 @@ do_libtool() { } libtool_prog() { -do_libtool --mode=compile $QEMU_CFLAGS -c -fPI

Re: [Qemu-devel] runtime configurable semihosting

On 13 November 2014 17:48, Christopher Covington wrote: > Hi Liviu, > > On 11/12/2014 02:17 PM, Liviu Ionescu wrote: >> >>> semihosting ... be runtime configurable on this, I think. >> >> I took a quick look at the syntax of command options and monitor commands, >> and I would suggest the followi

Re: [Qemu-devel] runtime configurable semihosting

Hi Liviu, On 11/12/2014 02:17 PM, Liviu Ionescu wrote: > >> semihosting ... be runtime configurable on this, I think. > > I took a quick look at the syntax of command options and monitor commands, > and I would suggest the following: > > - extend the option "-semihosting" with an optional "tar

Re: [Qemu-devel] [PATCH] Add bootloader name to multiboot implementation

cc-ing a few people I found in the blame for the relevant files. Mind taking a look at this patch? Thanks! On 11/04/2014 12:49 PM, Drew DeVault wrote: Ping: http://patchwork.ozlabs.org/patch/404885/ Does anyone know someone I can cc on this? This part of the code doesn't have a dedicated main

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

On 11/13/14, 11:03 AM, "Eric Blake" wrote: >On 11/13/2014 09:44 AM, Gary Hook wrote: > >[metacomment] > >> On 11/13/14, 6:46 AM, "Markus Armbruster" >>mailto:arm...@redhat.com>> wrote: >> >> Stefan Hajnoczi mailto:stefa...@gmail.com>> writes: >> >> On Wed, Nov 12, 2014 at 06:48:18PM +, Ga

[Qemu-devel] [PATCH 1/1] arm_gic: gic_update should always update all cores.

This patch fixes so that gic_update always updates all the cores with new pending irq states. If the function returns early it is possible to get interrupts that has already been acknowledged. Signed-off-by: Johan Karlsson diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c index 270ce05..f1641

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

On 11/13/2014 09:44 AM, Gary Hook wrote: [metacomment] > On 11/13/14, 6:46 AM, "Markus Armbruster" > mailto:arm...@redhat.com>> wrote: > > Stefan Hajnoczi mailto:stefa...@gmail.com>> writes: > > On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: Your quoting style leaves a lot to be d

[Qemu-devel] [Bug 1258168] Re: QEMU fails to build on CentOS 5.10 with --disable-pie reporting "/usr/bin/ld: -f may not be used without -shared "

btool= fi dcs-xen-53:~/qemu/out/bug-1258168>git log -2 commit cceddd04255cdacacf91562d43fdb7afcec91242 Author: Paolo Bonzini Date: Thu Nov 13 16:34:16 2014 + configure: test patch for 1258168 commit b56cb288954d900dec79cc55128efa61bebf6178 Merge: e08d300 953ea14 Author: Peter Maydell Date: Thu Nov 13 13:02:31 2

Re: [Qemu-devel] State of ARM FIQ in Qemu

On 13 November 2014 16:26, Tim Sander wrote: > This is the gcc inline assembly syntax from my kernel module written in c: > asm("mrc p15, 0, %0, c12, c0, 0" : "=r"(vbar) : : "cc"); > asm("mrc p15, 0, %0, c12, c0, 1" : "=r"(mvbar) : : "cc"); <- not implemented? > asm("mrc p15, 4, %0, c12, c0, 0" :

Re: [Qemu-devel] [PATCH v1 RFC 4/9] qemu-iotests: fix test 039

On 2014-11-13 at 11:36, Mao Chuan Li wrote: For successful execution of case 039, core dump need be disabled. Just running "ulimit -c 0" command is not enough when the /proc/sys/kernel/core_pattern indicates to pipe the dump to another application. So we must erase the pattern in addition to the

Re: [Qemu-devel] [PULL 00/13] x86 and SCSI patches for QEMU 2.2.0-rc2

On 13 November 2014 15:40, Paolo Bonzini wrote: > The following changes since commit 6e76d125f244e10676b917208f2a074729820246: > > Update version for v2.2.0-rc0 release (2014-11-05 15:21:04 +) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstre

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

On 11/13/14, 6:46 AM, "Markus Armbruster" mailto:arm...@redhat.com>> wrote: Stefan Hajnoczi mailto:stefa...@gmail.com>> writes: On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: -return qemu_ftell(f) - last_ftell; +delta_ftell = qemu_ftell(f) - last_ftell; +return( (delta_ft

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

On 11/13/14, 5:20 AM, "Stefan Hajnoczi" mailto:stefa...@gmail.com>> wrote: On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: -return qemu_ftell(f) - last_ftell; +delta_ftell = qemu_ftell(f) - last_ftell; +return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 ); Good fin

Re: [Qemu-devel] State of ARM FIQ in Qemu

Am Donnerstag, 13. November 2014, 09:09:33 schrieb Greg Bellows: > On 13 November 2014 07:58, Tim Sander wrote: > > Am Mittwoch, 12. November 2014, 10:00:03 schrieb Greg Bellows: > > > On 12 November 2014 07:56, Tim Sander wrote: > > > > Hi Greg > > > > > > > > > > Bad mode in data abort handler

Re: [Qemu-devel] [PATCH v2 for-xen-4.5] xen_disk: fix unmapping of persistent grants

El 13/11/14 a les 16.36, Stefano Stabellini ha escrit: > On Thu, 13 Nov 2014, Roger Pau Monne wrote: >> @@ -421,7 +451,17 @@ static int ioreq_map(struct ioreq *ioreq) >> } >> } >> } >> -if (ioreq->blkdev->feature_persistent) { >> +if (ioreq->blkdev->feature_persis

[Qemu-devel] [PATCH v2 4/4] target-tricore: Add instructions of RCR opcode format

Add instructions of RCR opcode format. Add helper for madd32/64_ssov and madd32/64_suov. Add helper for msub32/64_ssov and msub32/64_suov. Add microcode generator function madd/msub for 32bit and 64bit, which calculate a mul and a add/sub. OPC2_32_RCR_MSUB_U_32 -> OPC2_32_RCR_MSUB_U_32. Signed-of

[Qemu-devel] [PATCH v2 3/4] target-tricore: Add instructions of RLC opcode format

Add instructions of RLC opcode format. Add helper psw_write/read. Add microcode generator gen_mtcr/mfcr, which loads/stores a value to a core special function register, which are defined in csfr.def Signed-off-by: Bastian Koppelmann --- target-tricore/csfr.def | 124 +++

[Qemu-devel] [PATCH v2 2/4] target-tricore: Add instructions of RCPW, RCRR and RCRW opcode format

Add instructions of RCPW, RCRR and RCRW opcode format. Add microcode generator function gen_insert. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 132 +++-- 1 file changed, 129 insertions(+), 3 deletions(-) diff --git a/target-tricore

[Qemu-devel] [PATCH v2 1/4] target-tricore: Make TRICORE_FEATURES implying others.

Since all the TriCore instructionsets are subsets of each other (1.3 C 1.3.1 C 1.6), make the features implying each other, e.g 1.6 also has 1.3.1 and 1.3. This way we only need to check our features for the instructionset, where a instruction was first introduced. Signed-off-by: Bastian Koppelm

[Qemu-devel] [PATCH v2 0/4] Add TriCore RCPW, RCRR, RCRW, RLC and RCR instructions

Hi, this patch depends on the previous TriCore patches (https://patchwork.ozlabs.org/patch/405459/) and will hopefully end up in 2.3 QEMU. Other than adding the RCPW, RCRR, RCRW, RLC and RCR instructions, it cleans up how ISA versions in the feature bitmask are handled, to simplify the checks,

Re: [Qemu-devel] [PATCH 0/4] Add TriCore RCPW, RCRR, RCRW, RLC and RCR instructions

On 11/13/2014 03:06 PM, Bastian Koppelmann wrote: Hi, this patch depends on the previous TriCore patches (https://patchwork.ozlabs.org/patch/405459/) and will hopefully end up in 2.3 QEMU. Other than adding the RCPW, RCRR, RCRW, RLC and RCR instructions, it cleans up how ISA versions in the f

Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure

On 11/13/2014 08:47 AM, Eric Blake wrote: > The two calls are both necessary, in order to learn which extant type > offset belongs to, and to tell where that extant ends; and the behaviors > are distinguishable (if both lseek() succeed, we have both numbers we > want; if both fail with ENXIO, we k

Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure

On 11/13/2014 08:49 AM, Eric Blake wrote: > On 11/13/2014 08:44 AM, Max Reitz wrote: > >>> (By the way, I really wish Solaris had implemented a variant that >>> queried, but did NOT change the file offset - maybe Linux can add that >>> as an extension, and give it sane semantics of not special cas

Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure

On 11/13/2014 08:44 AM, Max Reitz wrote: >> (By the way, I really wish Solaris had implemented a variant that >> queried, but did NOT change the file offset - maybe Linux can add that >> as an extension, and give it sane semantics of not special casing >> trailing holes...) > > Are you asking for

Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure

On 11/13/2014 08:29 AM, Eric Blake wrote: >>> lseek() with SEEK_DATA starting in a hole when there is no data until >>> EOF is actually the part that isn't documented in the man page, but >>> ENXIO is what I'm seeing here on RHEL 7. >> >> Here's the (proposed) POSIX wording: >> >> http://austingro

Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure

On 2014-11-13 at 16:29, Eric Blake wrote: On 11/13/2014 07:52 AM, Eric Blake wrote: On 11/13/2014 06:03 AM, Kevin Wolf wrote: Am 13.11.2014 um 11:17 hat Markus Armbruster geschrieben: When SEEK_HOLE tells us we're in a hole, we try SEEK_DATA to find its end. When that fails, we pretend the ho

[Qemu-devel] [PULL 13/13] acpi: accurate overflow check

From: Pavel Dovgalyuk Compare clock in ns, because acpi_pm_tmr_update uses rounded to ns value instead of ticks. Signed-off-by: Pavel Dovgalyuk [This lets Windows boot in icount mode. - Paolo] Signed-off-by: Paolo Bonzini --- hw/acpi/core.c | 7 +-- 1 file changed, 5 insertions(+), 2 dele

[Qemu-devel] [PULL 12/13] smbios: change 'ram_addr_t' variables to 'uint64_t'

From: SeokYeon Hwang ram_addr_t should not be used except if referring to a RAMBlobk. Using 'uint64_t' avoids a -Wconstant-conversion warning, which clang >= 3.4 produces in "smbios_get_tables()". Signed-off-by: SeokYeon Hwang Signed-off-by: Paolo Bonzini --- hw/i386/smbios.c | 10 +-

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] PPC: e500 pci host: Add support for ATMUs

> -Original Message- > From: qemu-ppc-bounces+bharat.bhushan=freescale@nongnu.org > [mailto:qemu-ppc- > bounces+bharat.bhushan=freescale@nongnu.org] On Behalf Of Alexander Graf > Sent: Thursday, November 13, 2014 3:27 AM > To: qemu-...@nongnu.org > Cc: Yoder Stuart-B08248; qemu-d

[Qemu-devel] [PULL 09/13] apic_common: migrate missing fields

From: Pavel Dovgalyuk This patch adds missed sipi_vector and wait_for_sipi fields to a new subsection of the vmstate of the apic_common module. Saving and loading of these fields makes migration of the apic state deterministic. Signed-off-by: Pavel Dovgalyuk [Initialize the field in pre_load an

[Qemu-devel] [PULL 07/13] virtio-scsi: Fix comment for VirtIOSCSIReq

From: Fam Zheng The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading comment. Suggested-by: Markus Armbruster Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- include/hw/virtio/virtio-scsi.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includ

[Qemu-devel] [PULL 11/13] kvmclock: Add comment explaining why we need cpu_clean_all_dirty()

From: Eduardo Habkost Try to explain why commit 317b0a6d8ba44e9bf8f9c3dbd776c4536843d82c needed a cpu_clean_all_dirty() call just after calling cpu_synchronize_all_states(). Signed-off-by: Eduardo Habkost Cc: Andrey Korolyov Cc: Marcin Gibuła Cc: Marcelo Tosatti Cc: Paolo Bonzini Signed-of

[Qemu-devel] [PULL 10/13] target-i386: fix Coverity complaints about overflows

sipi_vector is an int; it is shifted by 12 and passed as a 64-bit value, which makes Coverity think that we wanted (uint64_t)sipi_vector << 12. But actually it must be between 0 and 255. Make this explicit. Signed-off-by: Paolo Bonzini --- target-i386/cpu.h | 2 +- 1 file changed, 1 insertion(

[Qemu-devel] [PULL 05/13] esp: Do not overwrite ESP_TCHI after reset

From: Hannes Reinecke After a reset ESP_TCHI should contain the unique ID of the chip. This value will be overwritten with the current tranfer count if the transfer count has previously been set. So we should always return the chip id if ESP_TCHI has never been written to. Signed-off-by: Hannes

[Qemu-devel] [PULL 04/13] virtio-scsi: dataplane: fix allocation for 'cmd_vrings'

From: Ming Lei The size of each element should be sizeof(VirtIOSCSIVring *). Signed-off-by: Ming Lei Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi-dataplane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/h

[Qemu-devel] [PULL 06/13] virtio-scsi: dataplane: suppress guest notification

From: Ming Lei This patch uses vring_should_notify() to suppress guest notification, and looks notification frequency can be decreased from ~33K/sec to ~2K/sec in my test environment. Suggested-by: Stefan Hajnoczi Signed-off-by: Ming Lei Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi-d

[Qemu-devel] [PULL 03/13] esp: fix coding standards

Reported-by: Mark Cave-Ayland Signed-off-by: Paolo Bonzini --- hw/scsi/esp-pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index 77b8647..00b7297 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -268,8 +268,9 @@ static vo

[Qemu-devel] [PULL 00/13] x86 and SCSI patches for QEMU 2.2.0-rc2

The following changes since commit 6e76d125f244e10676b917208f2a074729820246: Update version for v2.2.0-rc0 release (2014-11-05 15:21:04 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 3ef0eab178e5120a0e1c079d1

[Qemu-devel] [PULL 08/13] target-i386: eliminate dead code and hoist common code out of "if"

ist != 0 is checked in the first "if", so it cannot be true in the "else if" part. While at it, simplify the code and move the ESP alignment out of the conditionals. Reported by Coverity. Signed-off-by: Paolo Bonzini --- target-i386/seg_helper.c | 17 - 1 file changed, 4 insert

[Qemu-devel] [PULL 01/13] esp-pci: fixup deadlock with linux

From: Hannes Reinecke A linux guest will be issuing messages: [ 32.124042] DC390: Deadlock in DataIn_0: DMA aborted unfinished: 00 bytes remain!! [ 32.126348] DC390: DataIn_0: DMA State: 0 and the HBA will fail to work properly. Reason is the emulation is not setting the 'DMA transfer

[Qemu-devel] [PULL 02/13] virtio-scsi: work around bug in old BIOSes

Old BIOSes left some padding by mistake after the req_size/resp_size. New QEMU does not like it, thinking it is a bidirectional command. As a workaround, we can check if the ANY_LAYOUT bit is set; if not, we always consider the first buffer as the virtio-scsi request/response, because, back when Q

Re: [Qemu-devel] [PATCH v2 for-xen-4.5] xen_disk: fix unmapping of persistent grants

On Thu, 13 Nov 2014, Roger Pau Monne wrote: > This patch fixes two issues with persistent grants and the disk PV backend > (Qdisk): > > - Keep track of memory regions where persistent grants have been mapped >since we need to unmap them as a whole. It is not possible to unmap a >single gr

Re: [Qemu-devel] qemu arm gic assert failed.

On Thu, Nov 13, 2014 at 4:25 PM, Johan Karlsson wrote: >> -Original Message- >> From: Christoffer Dall [mailto:christoffer.d...@linaro.org] >> Sent: den 13 november 2014 15:28 >> On Thu, Nov 13, 2014 at 1:44 PM, Johan Karlsson >> wrote: >> > Hi, >> > Enabled DEBUG_GIC in arm_gic.c >> > >>

Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure

On 11/13/2014 07:52 AM, Eric Blake wrote: > On 11/13/2014 06:03 AM, Kevin Wolf wrote: >> Am 13.11.2014 um 11:17 hat Markus Armbruster geschrieben: >>> When SEEK_HOLE tells us we're in a hole, we try SEEK_DATA to find its >>> end. When that fails, we pretend the hole extends to the end of file. >>>

Re: [Qemu-devel] qemu arm gic assert failed.

> -Original Message- > From: Christoffer Dall [mailto:christoffer.d...@linaro.org] > Sent: den 13 november 2014 15:28 > On Thu, Nov 13, 2014 at 1:44 PM, Johan Karlsson > wrote: > > Hi, > > Enabled DEBUG_GIC in arm_gic.c > > > > Use case: > > Core0 wakes up core1 using irq and then core1 a

Re: [Qemu-devel] [PATCH] mips: Fix the 64-bit case for microMIPS MOVE16 and MOVEP

On Thu, 13 Nov 2014, Leon Alrae wrote: > It might be a good idea to split these changes into separate patches to > have more precise indication about touched subsystem (even though all > the changes were done in MIPS context). For example "target-mips" and > "linux-user" rather than just "mips".

Re: [Qemu-devel] [PATCH 2.3 4/8] tcg: Introduce tcg_op_buf_count and tcg_op_buf_full

On 11/11/2014 04:24 PM, Richard Henderson wrote: The method by which we count the number of ops emitted is going to change. Abstract that away into some inlines. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 14 +++--- target-arm/translate-a64.c| 9 +++--

Re: [Qemu-devel] State of ARM FIQ in Qemu

On 13 November 2014 07:58, Tim Sander wrote: > Am Mittwoch, 12. November 2014, 10:00:03 schrieb Greg Bellows: > > On 12 November 2014 07:56, Tim Sander wrote: > > > Hi Greg > > > > > > > > Bad mode in data abort handler detected > > > > > Internal error: Oops - bad mode: 0 [#1] PREEMPT SMP ARM >

Re: [Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a 'guest_writable' callback for users

On Do, 2014-11-13 at 14:52 +, Peter Maydell wrote: > On 13 November 2014 14:47, Gerd Hoffmann wrote: > > On Di, 2014-10-28 at 20:21 +0530, Amit Shah wrote: > >> Users of virtio-serial may want to know when a port becomes writable. A > >> port can stop accepting writes if the guest port is ope

[Qemu-devel] [PATCH v2 for-xen-4.5] xen_disk: fix unmapping of persistent grants

This patch fixes two issues with persistent grants and the disk PV backend (Qdisk): - Keep track of memory regions where persistent grants have been mapped since we need to unmap them as a whole. It is not possible to unmap a single grant if it has been batch-mapped. - Unmap persistent gra

Re: [Qemu-devel] [PATCH 2.3 3/8] tcg: Move emit of INDEX_op_end into gen_tb_end

On 11/11/2014 04:24 PM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 2 ++ target-alpha/translate.c | 2 +- target-arm/translate-a64.c| 1 - target-arm/translate.c| 1 - target-cris/translate.c | 2 +- target-i386/tr

[Qemu-devel] [PATCH] target-arm: handle address translations that start at level 3

The ARMv8 address translation system defines that a page table walk starts at a level which depends on the translation granule size and the number of bits of virtual address that need to be resolved. Where the translation granule is 64KB and the guest sets the TCR.TxSZ field to between 35 and 39, i

Re: [Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a 'guest_writable' callback for users

On 13 November 2014 14:47, Gerd Hoffmann wrote: > On Di, 2014-10-28 at 20:21 +0530, Amit Shah wrote: >> Users of virtio-serial may want to know when a port becomes writable. A >> port can stop accepting writes if the guest port is open but not being >> read from. In this case, data gets queued u

Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure

On 11/13/2014 06:03 AM, Kevin Wolf wrote: > Am 13.11.2014 um 11:17 hat Markus Armbruster geschrieben: >> When SEEK_HOLE tells us we're in a hole, we try SEEK_DATA to find its >> end. When that fails, we pretend the hole extends to the end of file. >> Wrong. > > Wrong only in some cases, see below

Re: [Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a 'guest_writable' callback for users

On Di, 2014-10-28 at 20:21 +0530, Amit Shah wrote: > Users of virtio-serial may want to know when a port becomes writable. A > port can stop accepting writes if the guest port is open but not being > read from. In this case, data gets queued up in the virtqueue, and > after the vq is full, writes

  1   2   3   >