Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-23 Thread Paolo Bonzini
On 10/24/2014 03:27 AM, Chao Peng wrote: > On Thu, Oct 23, 2014 at 05:49:23PM -0200, Eduardo Habkost wrote: >> On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: >> [...] >>> @@ -707,6 +714,24 @@ typedef union { >>> } XMMReg; >>> >>> typedef union { >>> +uint8_t _b[32]; >>> +u

Re: [Qemu-devel] [PATCH] arm: fix TB alignment check

2014-10-23 Thread Pavel Dovgaluk
> From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard > Henderson > On 10/21/2014 05:14 AM, Pavel Dovgalyuk wrote: > > Sometimes page faults happen during the translation of the target > > instructions. > > To avoid the faults in the middle of the TB we have to stop translatio

Re: [Qemu-devel] [PATCH V6 0/8] cpu/acpi: convert cpu hot plug to hotplug_handler API

2014-10-23 Thread Gu Zheng
Hi, This series has been reviewed by Igor, could you please apply it? Thanks, Gu On 10/22/2014 11:24 AM, Gu Zheng wrote: > Previously we use cpu_added_notifiers to register cpu hotplug notifier > callback > which is not able to pass/handle errors, so we switch it to unified hotplug > handler API

Re: [Qemu-devel] [PATCH v6] Support vhd type VHD_DIFFERENCING

2014-10-23 Thread Xiaodong Gong
hi kevin & stefan, It sames like hard to get a reviewed-by right now. The reasons are QEMU from upstream + Xen is not popular now and vpc from QEMU + KVM is also not popular, I think. VHD DEFERRING will be a key feature, when turn Xen to KVM in a big product environment. So it is good to have it

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-23 Thread Chao Peng
On Thu, Oct 23, 2014 at 05:49:23PM -0200, Eduardo Habkost wrote: > On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: > [...] > > @@ -707,6 +714,24 @@ typedef union { > > } XMMReg; > > > > typedef union { > > +uint8_t _b[32]; > > +uint16_t _w[16]; > > +uint32_t _l[8]; > > +

[Qemu-devel] [Bug 1384892] Re: RTL8168 NIC VFIO not working anymore since QEMU 2.1

2014-10-23 Thread Alex Williamson
In general, rtl is a terrible choice for a device assignment NIC in my experience. Intel NICs are much better and worth the extra cost. However, QEMU2.1 did attempt to add a quirk for RTL8168 that allows the Windows driver to work correctly in a guest. In my testing, the Linux driver never made u

Re: [Qemu-devel] [PATCH] libqos: Convert malloc-pc allocator to a generic allocator

2014-10-23 Thread John Snow
On 10/18/2014 05:24 AM, Marc Marí wrote: The allocator in malloc-pc has been extracted, so it can be used in every arch. This operation showed that both the alloc and free functions can be also generic. Because of this, the QGuestAllocator has been removed from is function to wrap the alloc and

[Qemu-devel] [Bug 1384892] [NEW] RTL8168 NIC VFIO not working anymore since QEMU 2.1

2014-10-23 Thread Florian Wickert
Public bug reported: After upgrading QEMU from 2.0 to 2.1 (and libiscsi from 1.7.0 to 1.12 as a dependency) my two RTL8168 NICs stopped working. The NICs do not respond to any command and even the LEDs on the network connection turn off, a few seconds after the VM started. To get them back runni

Re: [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-23 Thread Michael S. Tsirkin
On Tue, Oct 07, 2014 at 04:39:56PM +0200, Cornelia Huck wrote: > This patchset aims to get us some way to implement virtio-1 compliant > and transitional devices in qemu. Branch available at > > git://github.com/cohuck/qemu virtio-1 > > I've mainly focused on: > - endianness handling > - extended

[Qemu-devel] [PULL 26/32] block: Respect underlying file's EOF

2014-10-23 Thread Kevin Wolf
From: Max Reitz When falling through to the underlying file in bdrv_co_get_block_status(), if it returns that the query offset is beyond the file end (by setting *pnum to 0), return the range to be zero and do not let the number of sectors for which information could be obtained be overwritten.

[Qemu-devel] [PULL 30/32] iotests: Add test for qcow2 L1 table update

2014-10-23 Thread Kevin Wolf
From: Max Reitz Updating the L1 table should not result in random data being written. This adds a test for that. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/107 | 61 ++ tests/qemu-iotests/1

[Qemu-devel] [PULL 28/32] iotests: Add test for map commands

2014-10-23 Thread Kevin Wolf
From: Max Reitz Add a test for qemu-img map and qemu-io -c map on truncated files. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/102 | 64 ++ tests/qemu-iotests/102.out | 10 tests/qemu-iotests/group | 1 +

[Qemu-devel] [PULL 21/32] iotests: Fix test outputs

2014-10-23 Thread Kevin Wolf
From: Max Reitz 039, 060 and 061 all create images with referenced clusters having a refcount of 0. Because previous commits changed handling of such errors, these tests now have a different output. Fix it. Furthermore, 060 created a refblock with a refcount greater than one which now results in

[Qemu-devel] [PULL 20/32] qcow2: Clean up after refcount rebuild

2014-10-23 Thread Kevin Wolf
From: Max Reitz Because the old refcount structure will be leaked after having rebuilt it, we need to recalculate the refcounts and run a leak-fixing operation afterwards (if leaks should be fixed at all). Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 45

[Qemu-devel] [PULL 15/32] qcow2: Let inc_refcounts() resize the reftable

2014-10-23 Thread Kevin Wolf
From: Max Reitz Now that the refcount table can be passed around by reference, do that for inc_refcounts() (and subsequently check_refcounts_l1() and check_refcounts_l2()) and use it for resizing it when a cluster after the image end is encountered. Signed-off-by: Max Reitz Signed-off-by: Kevin

[Qemu-devel] [PULL 32/32] qemu-img: Print error if check failed

2014-10-23 Thread Kevin Wolf
From: Max Reitz Currently, if bdrv_check() fails either by returning -errno or having check_errors set, qemu-img check just exits with 1 after having told the user that there were no errors on the image. This is bad. Instead of printing the check result if there were internal errors which were s

[Qemu-devel] [PULL 16/32] qcow2: Reuse refcount table in calculate_refcounts()

2014-10-23 Thread Kevin Wolf
From: Max Reitz We will later call calculate_refcounts multiple times, so reuse the refcount table if possible. Signed-off-by: Max Reitz Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 12 +++- 1 file changed, 7 insertions(+),

[Qemu-devel] [PULL 29/32] qcow2: Do not overflow when writing an L1 sector

2014-10-23 Thread Kevin Wolf
From: Max Reitz While writing an L1 table sector, qcow2_write_l1_entry() copies the respective range from s->l1_table to the local "buf" array. The size of s->l1_table does not have to be a multiple of L1_ENTRIES_PER_SECTOR; thus, limit the index which is used for copying all entries to the L1 si

[Qemu-devel] [PULL 14/32] qcow2: Let inc_refcounts() return -errno

2014-10-23 Thread Kevin Wolf
From: Max Reitz As of a future patch, inc_refcounts() will have to throw errors which are generally signaled by returning -errno. Therefore, let it return an integer which is either 0 for success or -errno and handle the -errno case in all callers. Signed-off-by: Max Reitz Signed-off-by: Kevin

[Qemu-devel] [PULL 27/32] qemu-io: Respect early image end for map

2014-10-23 Thread Kevin Wolf
From: Max Reitz bdrv_is_allocated() may report zero clusters which most probably means the image (file) is shorter than expected. Respect this case in order to avoid an infinite loop. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf Signed-of

[Qemu-devel] [PULL 24/32] docs/qcow2: Correct refcount_block_entries

2014-10-23 Thread Kevin Wolf
From: Max Reitz A refblock entry may have a different size than 16 bits, it may even be smaller than a byte. Correct the refcount_block_entries calculation accordingly. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- docs/specs/qcow2.txt | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[Qemu-devel] [PULL 23/32] qcow2: Drop REFCOUNT_SHIFT

2014-10-23 Thread Kevin Wolf
From: Max Reitz With BDRVQcowState.refcount_block_bits, we don't need REFCOUNT_SHIFT anymore. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 32 ++-- block/qcow2.c | 2 +- block/qcow2.h |

[Qemu-devel] [PULL 09/32] qcow2: Split qcow2_check_refcounts()

2014-10-23 Thread Kevin Wolf
From: Max Reitz Put the code for calculating the reference counts and comparing them during qemu-img check into own functions. Signed-off-by: Max Reitz Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 153 ++

[Qemu-devel] [PULL 22/32] iotests: Add test for potentially damaging repairs

2014-10-23 Thread Kevin Wolf
From: Max Reitz There are certain cases where repairing a qcow2 image might actually damage it further (or rather, where repairing it has in fact damaged it further with the old qcow2 check implementation). This should not happen, so add a test for these cases. Furthermore, the repair function n

[Qemu-devel] [PULL 07/32] qcow2: Calculate refcount block entry count

2014-10-23 Thread Kevin Wolf
From: Max Reitz The size of a refblock entry is (in theory) variable; calculate therefore the number of entries per refblock and the according bit shift (1 << x == entry count) when opening an image. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qcow2.c

[Qemu-devel] [PULL 12/32] qcow2: Use int64_t for in-memory reftable size

2014-10-23 Thread Kevin Wolf
From: Max Reitz Use int64_t for the entry count of the in-memory refcount table throughout the check functions. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/qcow2-refcount.c b/bloc

[Qemu-devel] [PULL 19/32] qcow2: Rebuild refcount structure during check

2014-10-23 Thread Kevin Wolf
From: Max Reitz The previous commit introduced the "rebuild" variable to qcow2's implementation of the image consistency check. Now make use of this by adding a function which creates a completely new refcount structure based solely on the in-memory information gathered before. The old refcount

[Qemu-devel] [PULL 06/32] block: Add qemu_{,try_}blockalign0()

2014-10-23 Thread Kevin Wolf
From: Max Reitz These functions call their non-0-counterparts and then fill the allocated buffer with 0 (if the allocation has been successful). Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block.c | 16 include/block/block.h |

[Qemu-devel] [PULL 31/32] block: char devices on FreeBSD are not behind a pager

2014-10-23 Thread Kevin Wolf
From: Roger Pau Monne Introduce a new flag to mark devices that require requests to be aligned and replace the usage of BDRV_O_NOCACHE and O_DIRECT with this flag when appropriate. If a character device is used as a backend on a FreeBSD host set this flag unconditionally. Signed-off-by: Roger P

[Qemu-devel] [PULL 11/32] qcow2: Pull check_refblocks() up

2014-10-23 Thread Kevin Wolf
From: Max Reitz Pull check_refblocks() before calculate_refcounts() so we can drop its static declaration. Signed-off-by: Max Reitz Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 102 -

[Qemu-devel] [PULL 17/32] qcow2: Fix refcount blocks beyond image end

2014-10-23 Thread Kevin Wolf
From: Max Reitz If the qcow2 check function detects a refcount block located beyond the image end, grow the image appropriately. This cannot break anything and is the logical fix for such a case. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 67 ++

[Qemu-devel] [PULL 25/32] docs/qcow2: Limit refcount_order to [0, 6]

2014-10-23 Thread Kevin Wolf
From: Max Reitz Specify the upper limit of refcount_order to be 6 (that is, refcount_bits = 64). Any larger value does not make much sense when all offsets, sizes, cluster counts etc. "only" have a width of 64 bit as well, and very large values would be very difficult to support. Therefore, just

[Qemu-devel] [PULL 04/32] block/vdi: Use {DIV_,}ROUND_UP

2014-10-23 Thread Kevin Wolf
From: Max Reitz There are macros for these operations, so make use of them. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/vdi.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 9604721..19701ee

[Qemu-devel] [PULL 10/32] qcow2: Use sizeof(**refcount_table)

2014-10-23 Thread Kevin Wolf
From: Max Reitz When implementing variable refcounts, we want to be able to easily find all the places in qemu which are tied to a certain refcount order. Replace sizeof(uint16_t) in the check code by sizeof(**refcount_table) so we can later find it more easily. Signed-off-by: Max Reitz Reviewe

[Qemu-devel] [PULL 13/32] qcow2: Split fail code in L1 and L2 checks

2014-10-23 Thread Kevin Wolf
From: Max Reitz Instead of printing out an error message, incrementing check_errors and returning a fixed -errno, just do cleanups and return -ret, with ret set by the code which threw the exception (jumped to the fail label). Also, increment check_errors on error in check_refcounts_l2(). Signe

[Qemu-devel] [PULL 18/32] qcow2: Do not perform potentially damaging repairs

2014-10-23 Thread Kevin Wolf
From: Max Reitz If a referenced cluster has a refcount of 0, increasing its refcount may result in clusters being allocated for the refcount structures. This may overwrite the referenced cluster, therefore we cannot simply increase the refcount then. In such cases, we can either try to replicate

[Qemu-devel] [PULL 00/32] Block patches

2014-10-23 Thread Kevin Wolf
The following changes since commit e40830afa1cff3ffdc37bdfdd40d80860074636c: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2014-10-22-tag' into staging (2014-10-22 21:42:33 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for yo

[Qemu-devel] [PULL 02/32] MAINTAINERS: qemu-iotests belongs to the block layer

2014-10-23 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b8e6117..9a7818d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -717,6 +717,7 @@ F: block/ F: hw/block/ F: qemu-img* F: qemu-io* +F: tests/qemu-iotests/ T: git git://re

[Qemu-devel] [PULL 08/32] qcow2: Fix leaks in dirty images

2014-10-23 Thread Kevin Wolf
From: Max Reitz When opening dirty images, qcow2's repair function should not only repair errors but leaks as well. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/qcow2.c | 2 +- 1 file changed, 1 inser

[Qemu-devel] [PULL 05/32] block: qemu-iotests change _supported_proto to file once more.

2014-10-23 Thread Kevin Wolf
From: Peter Lieven In preparation to possible automatic regression and performance testing for the block layer I found that the iotests don't work for all protocols anymore. In commit 1f7bf7d0 I started to change supported protocols from generic to file for various tests. Unfortunately, some tes

[Qemu-devel] [PULL 03/32] MAINTAINERS: add the image fuzzer to the block layer

2014-10-23 Thread Kevin Wolf
From: Paolo Bonzini More work for the block device maintainers! Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a7818d..95553d9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -717,6 +717

[Qemu-devel] [PULL 01/32] MAINTAINERS: add aio to block layer

2014-10-23 Thread Kevin Wolf
From: Paolo Bonzini AioContext falls under the block layer, mark it as such. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8eed800..b8e6117 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [Qemu-devel] [PATCH] i386: fix icount processing for repz instructions

2014-10-23 Thread Paolo Bonzini
On 10/23/2014 07:05 PM, Richard Henderson wrote: > On 10/21/2014 06:03 AM, Pavel Dovgalyuk wrote: >> +dc->repz_opt = dc->jmp_opt >> +/* Do not optimize repz jumps at all in icount mode, >> because >> + rep movsS instructions are execured with differe

Re: [Qemu-devel] [PATCH v4 14/47] Return path: Control commands

2014-10-23 Thread Paolo Bonzini
On 10/23/2014 06:23 PM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: >>> QEMU_VM_CMD_INVALID = 0, /* Must be 0 */ >>> +QEMU_VM_CMD_OPENRP,/* Tell the dest to open the Return path */

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-23 Thread Eduardo Habkost
On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: [...] > @@ -707,6 +714,24 @@ typedef union { > } XMMReg; > > typedef union { > +uint8_t _b[32]; > +uint16_t _w[16]; > +uint32_t _l[8]; > +uint64_t _q[4]; > +float32 _s[8]; > +float64 _d[4]; > +} YMMReg; > + > +ty

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/3] bitops: Header dependency fixes

2014-10-23 Thread Michael Tokarev
On 10/23/2014 04:32 PM, Eduardo Habkost wrote: > On Thu, Oct 23, 2014 at 10:35:47AM +0400, Michael Tokarev wrote: >> On 09/26/2014 11:46 PM, Eduardo Habkost wrote: >>> This series adds a missing include, kills a circular header dependency, and >>> avoid including qemu-common.h from a header to avoi

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-10-23 Thread Serge Hallyn
Thanks for the information. Looks like we can apply these in debian too. ** Also affects: qemu (Ubuntu Utopic) Importance: High Status: Triaged ** Also affects: qemu (Ubuntu Vivid) Importance: Undecided Status: New -- You received this bug notification because you are a mem

[Qemu-devel] is it possible to use a disk with multiple iothreads ?

2014-10-23 Thread Alexandre DERUMIER
Hi, I was reading this interesting presentation, http://vmsplice.net/~stefan/stefanha-kvm-forum-2014.pdf and I have a specific question. I'm currently evaluate ceph/rbd storage performance through qemu, and the current bottleneck seem to be the cpu usage of the iothread. (rbd procotol cpu

Re: [Qemu-devel] [PULL 0/7] QMP queue

2014-10-23 Thread Peter Maydell
On 23 October 2014 16:19, Luiz Capitulino wrote: > The following changes since commit e40830afa1cff3ffdc37bdfdd40d80860074636c: > > Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2014-10-22-tag' > into staging (2014-10-22 21:42:33 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-23 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > +/* Source side RP state */ > > +struct MigrationRetPathState { > > +uint32_t latest_ack; > > +QemuThreadrp_thread; > > +bool error; > > Should the QemuFil

Re: [Qemu-devel] [PATCH 1/2] block: JSON filenames and relative backing files

2014-10-23 Thread Max Reitz
On 23.10.2014 19:42, Eric Blake wrote: On 10/23/2014 08:56 AM, Max Reitz wrote: When using a relative backing file name, qemu needs to know the directory of the top image file. For JSON filenames, such a directory cannot be easily determined (e.g. how do you determine the directory of a qcow2 BD

Re: [Qemu-devel] [PATCH v5] snapshot: use local variable to bdrv_pwrite_sync L1 table

2014-10-23 Thread Max Reitz
On 22.10.2014 14:39, Zhang Haoyu wrote: Use local variable to bdrv_pwrite_sync L1 table, needless to make conversion of cached L1 table between big-endian and host style. Signed-off-by: Zhang Haoyu Reviewed-by: Max Reitz --- v4 -> v5: - delete superfluous check of "l1_size2 != 0" after qemu

Re: [Qemu-devel] [PATCH 0/2] block: JSON filenames and relative backing files

2014-10-23 Thread Eric Blake
On 10/23/2014 08:56 AM, Max Reitz wrote: > Sometimes, qemu does not have a filename to work with (it then generates > a JSON filename), so it does not know which directory to use for a > backing file specified by a relative filename. > > In this case, qemu should not somehow try to append the back

Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for relative backing file names

2014-10-23 Thread Eric Blake
On 10/23/2014 08:56 AM, Max Reitz wrote: > Sometimes, qemu does not have a filename to work with, so it does not > know which directory to use for a backing file specified by a relative > filename. Add a test which tests that qemu exits with an appropriate > error message. > > Signed-off-by: Max R

Re: [Qemu-devel] [PATCH v5] snapshot: use local variable to bdrv_pwrite_sync L1 table

2014-10-23 Thread Max Reitz
On 22.10.2014 14:39, Zhang Haoyu wrote: Use local variable to bdrv_pwrite_sync L1 table, needless to make conversion of cached L1 table between big-endian and host style. Signed-off-by: Zhang Haoyu Reviewed-by: Max Reitz --- v4 -> v5: - delete superfluous check of "l1_size2 != 0" after qemu

Re: [Qemu-devel] [PATCH 1/2] block: JSON filenames and relative backing files

2014-10-23 Thread Eric Blake
On 10/23/2014 08:56 AM, Max Reitz wrote: > When using a relative backing file name, qemu needs to know the > directory of the top image file. For JSON filenames, such a directory > cannot be easily determined (e.g. how do you determine the directory of > a qcow2 BDS directly on top of a quorum BDS?

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-23 Thread Richard Henderson
On 10/23/2014 05:06 AM, Peter Maydell wrote: > On 23 October 2014 12:55, wrote: >> From: Riku Voipio >> >> On AArch64 the si_addr field of siginfo_t is truncated to 32 bits >> because the fault address passes through an uint32_t variable. This >> is fixed by changing the variable to uint64_t. >>

Re: [Qemu-devel] [PATCH] MAINTAINERS: add myself for X86

2014-10-23 Thread Richard Henderson
On 10/21/2014 06:16 AM, Paolo Bonzini wrote: > Still not moving it beyond "Odd fixes". Richard Henderson also has > reviewed a bunch of X86 TCG patches, so add him as well. All we want > is to avoid that patches fall on the floor. > > Signed-off-by: Paolo Bonzini > --- > MAINTAINERS | 4 +++- >

Re: [Qemu-devel] [PATCH] i386: fix icount processing for repz instructions

2014-10-23 Thread Richard Henderson
On 10/21/2014 06:03 AM, Pavel Dovgalyuk wrote: > +dc->repz_opt = dc->jmp_opt > +/* Do not optimize repz jumps at all in icount mode, > because > + rep movsS instructions are execured with different > paths > + in repz_opt and !re

[Qemu-devel] [PATCH] gtk: avoid gd_widget_reparent with gtk 3.14+

2014-10-23 Thread Gerd Hoffmann
gtk_widget_reparent is depricated in gtk 3.14, stop using it. Signed-off-by: Gerd Hoffmann --- Notes: v2: - use g_object_ref instead of gtk_widget_ref, drop ifdefs ui/gtk.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 524

[Qemu-devel] [PATCH] gtk: avoid gd_widget_reparent with gtk 3.14+

2014-10-23 Thread Gerd Hoffmann
gtk_widget_reparent is depricated in gtk 3.14, stop using it. Signed-off-by: Gerd Hoffmann --- Notes: v2: - use g_object_ref instead of gtk_widget_ref, drop ifdefs ui/gtk.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index

Re: [Qemu-devel] [PATCH] arm: fix TB alignment check

2014-10-23 Thread Richard Henderson
On 10/23/2014 09:25 AM, Peter Maydell wrote: > On 23 October 2014 17:15, Richard Henderson wrote: >> [1] Why 32 when the maximum insn size is more like 15 bytes, I don't know. >> But >> it likely doesn't matter since I'd expect such large TB's to fill up the >> opcode >> buffer first. There wo

Re: [Qemu-devel] [PATCH 2/2] gtk: avoid gd_widget_reparent with gtk 3.14+

2014-10-23 Thread Daniel P. Berrange
On Thu, Oct 23, 2014 at 06:26:21PM +0200, Paolo Bonzini wrote: > > > On 10/23/2014 05:25 PM, Gerd Hoffmann wrote: > > gtk_widget_reparent is depricated in gtk 3.14. Unfortunaly the > > gtk_widget_{ref,unref} functions needed to to the same manually > > without having the widget destroyed while i

Re: [Qemu-devel] [PATCH 2/2] gtk: avoid gd_widget_reparent with gtk 3.14+

2014-10-23 Thread Paolo Bonzini
On 10/23/2014 05:25 PM, Gerd Hoffmann wrote: > gtk_widget_reparent is depricated in gtk 3.14. Unfortunaly the > gtk_widget_{ref,unref} functions needed to to the same manually > without having the widget destroyed while it has no parent are > pretty new. So there is no way around #ifdef'ing the

Re: [Qemu-devel] [PATCH] arm: fix TB alignment check

2014-10-23 Thread Peter Maydell
On 23 October 2014 17:15, Richard Henderson wrote: > [1] Why 32 when the maximum insn size is more like 15 bytes, I don't know. > But > it likely doesn't matter since I'd expect such large TB's to fill up the > opcode > buffer first. There would have to be a lot of nops on that page. Do we ac

Re: [Qemu-devel] [PATCH v4 14/47] Return path: Control commands

2014-10-23 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > QEMU_VM_CMD_INVALID = 0, /* Must be 0 */ > > +QEMU_VM_CMD_OPENRP,/* Tell the dest to open the Return path */ > > OPEN_RETURN_PATH? > > > +QEMU_VM_CMD_REQACK,

Re: [Qemu-devel] [PATCH] arm: fix TB alignment check

2014-10-23 Thread Richard Henderson
On 10/21/2014 05:14 AM, Pavel Dovgalyuk wrote: > Sometimes page faults happen during the translation of the target > instructions. > To avoid the faults in the middle of the TB we have to stop translation at > the end of the page. Current implementation of ARM translation assumes that > instructio

[Qemu-devel] [PATCH 1/2] gtk: drop gtk_widget_set_double_buffered call

2014-10-23 Thread Gerd Hoffmann
Dunno why it is here. Removing it seems to have no ill side effects. It is depricated in 3.14+. In some cases it has no effect since 3.10 according to the docs: https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-set-double-buffered Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 1

[Qemu-devel] [PATCH 2/2] gtk: avoid gd_widget_reparent with gtk 3.14+

2014-10-23 Thread Gerd Hoffmann
gtk_widget_reparent is depricated in gtk 3.14. Unfortunaly the gtk_widget_{ref,unref} functions needed to to the same manually without having the widget destroyed while it has no parent are pretty new. So there is no way around #ifdef'ing the code, otherwise it breaks with older gtk versions, Si

[Qemu-devel] [PULL 2/7] dump: Propagate errors into qmp_dump_guest_memory()

2014-10-23 Thread Luiz Capitulino
From: zhanghailiang The code calls dump_error() on error, and even passes it a suitable message. However, the message is thrown away, and its callers pass up only success/failure. All qmp_dump_guest_memory() can do is set a generic error. Propagate the errors properly, so qmp_dump_guest_memory

[Qemu-devel] [PULL 7/7] monitor: delete device_del_bus_completion

2014-10-23 Thread Luiz Capitulino
From: Zhu Guihua device_del_bus_completion() that gathers devices from buses is unused; delete it. Signed-off-by: Zhu Guihua Reviewed-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov Signed-off-by: Luiz Capitulino --- monitor.c | 20 1 file changed, 20 deletions(-) diff

[Qemu-devel] [PULL 3/7] dump: Turn some functions to void to make code cleaner

2014-10-23 Thread Luiz Capitulino
From: zhanghailiang Functions shouldn't return an error code and an Error object at the same time. Turn all these functions that returning Error object to void. We also judge if a function success or fail by reference to the local_err. Signed-off-by: zhanghailiang Reviewed-by: Eric Blake Signe

[Qemu-devel] [PULL 6/7] monitor: add del completion for peripheral device

2014-10-23 Thread Luiz Capitulino
From: Zhu Guihua Add peripheral_device_del_completion() to let peripheral device del completion be possible. Signed-off-by: Zhu Guihua Reviewed-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov Signed-off-by: Luiz Capitulino --- monitor.c | 26 ++ 1 file changed, 26 in

[Qemu-devel] [PULL 0/7] QMP queue

2014-10-23 Thread Luiz Capitulino
The following changes since commit e40830afa1cff3ffdc37bdfdd40d80860074636c: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2014-10-22-tag' into staging (2014-10-22 21:42:33 +0100) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git tags/for-upstream

[Qemu-devel] [PULL 5/7] qdev: add qdev_build_hotpluggable_device_list helper

2014-10-23 Thread Luiz Capitulino
From: Zhu Guihua For peripheral device del completion, add a function to build a list for hotpluggable devices. Signed-off-by: Zhu Guihua Reviewed-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov Signed-off-by: Luiz Capitulino --- hw/core/qdev.c | 13 + include/hw/qdev-co

[Qemu-devel] [PULL 1/7] virtio-balloon: Tweak recent fix for integer overflow

2014-10-23 Thread Luiz Capitulino
From: Markus Armbruster Commit 1f9296b avoids "other kinds of overflow" by limiting the polling interval to UINT_MAX. The computations to protect are done in 64 bits. This is indeed safe when unsigned is 32 bits, as it commonly is. It isn't when unsigned is 64 bits. Purely theoretical; I'm no

[Qemu-devel] [PULL 4/7] MAINTAINERS: add entry for qobject files

2014-10-23 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8eed800..b4fac85 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -829,6 +829,12 @@ S: Supported F: qapi-schema.json T: git git://repo.or.cz/qemu/qmp-unstable.gi

Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed

2014-10-23 Thread Max Reitz
On 2014-10-23 at 15:29, Max Reitz wrote: Currently, if bdrv_check() fails either by returning -errno or having check_errors set, qemu-img check just exits with 1 after having told the user that there were no errors on the image. This is bad. Instead of printing the check result if there were int

Re: [Qemu-devel] [PATCH] vfio: check if host device supports INTx

2014-10-23 Thread Alex Williamson
On Thu, 2014-10-23 at 10:21 +0200, Frank Blaschka wrote: > On Wed, Oct 22, 2014 at 11:17:11AM -0600, Alex Williamson wrote: > > On Wed, 2014-10-22 at 17:13 +0200, Frank Blaschka wrote: > > > From: Frank Blaschka > > > > > > Let the kernel announce if INTx is available. Yes, there are platforms >

[Qemu-devel] [PATCH 2/2] iotests: Add test for relative backing file names

2014-10-23 Thread Max Reitz
Sometimes, qemu does not have a filename to work with, so it does not know which directory to use for a backing file specified by a relative filename. Add a test which tests that qemu exits with an appropriate error message. Signed-off-by: Max Reitz --- tests/qemu-iotests/110 | 87 ++

[Qemu-devel] [PATCH 0/2] block: JSON filenames and relative backing files

2014-10-23 Thread Max Reitz
Sometimes, qemu does not have a filename to work with (it then generates a JSON filename), so it does not know which directory to use for a backing file specified by a relative filename. In this case, qemu should not somehow try to append the backing file's name to the JSON object, but rather just

[Qemu-devel] [PATCH 1/2] block: JSON filenames and relative backing files

2014-10-23 Thread Max Reitz
When using a relative backing file name, qemu needs to know the directory of the top image file. For JSON filenames, such a directory cannot be easily determined (e.g. how do you determine the directory of a qcow2 BDS directly on top of a quorum BDS?). Therefore, do not allow relative filenames for

Re: [Qemu-devel] [PATCH v7 04/32] target-arm: rename arm_current_pl to arm_current_el

2014-10-23 Thread Peter Maydell
On 21 October 2014 17:55, Greg Bellows wrote: > Renamed the arm_current_pl CPU function to more accurately represent that it > returns the ARMv8 EL rather than ARMv7 PL. > > Signed-off-by: Greg Bellows > Reviewed-by: Peter Maydell > @@ -1485,7 +1485,7 @@ static void disas_exc(DisasContext *s, u

Re: [Qemu-devel] [PULL 00/24] SCSI, maintainers and more - 2014-10-17

2014-10-23 Thread Paolo Bonzini
On 10/23/2014 04:32 PM, Peter Maydell wrote: > On 23 October 2014 14:33, Paolo Bonzini wrote: >> The following changes since commit 5f77ef69a195098baddfdc6d189f1b4a94587378: >> >> glib: add compatibility interface for g_strcmp0() (2014-10-16 23:02:31 >> +0100) >> >> are available in the git r

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-23 Thread Paolo Bonzini
On 10/23/2014 05:02 AM, Chao Peng wrote: > Add AVX512 feature bits, register definition and corresponding > xsave/vmstate support. > > Signed-off-by: Chao Peng > --- > target-i386/cpu.c | 10 -- > target-i386/cpu.h | 61 ++ > target-i386/kvm.c

Re: [Qemu-devel] [PULL 00/24] SCSI, maintainers and more - 2014-10-17

2014-10-23 Thread Peter Maydell
On 23 October 2014 14:33, Paolo Bonzini wrote: > The following changes since commit 5f77ef69a195098baddfdc6d189f1b4a94587378: > > glib: add compatibility interface for g_strcmp0() (2014-10-16 23:02:31 > +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git t

Re: [Qemu-devel] [PATCH v4 47/47] End of migration for postcopy

2014-10-23 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > +mis->postcopy_ram_state); > > +if (mis->postcopy_ram_state == POSTCOPY_RAM_INCOMING_ADVISE) { > > +/* > > + * Where a migration had postcopy enabled (and

Re: [Qemu-devel] [PATCH v7 00/32] target-arm: add Security Extensions for CPUs

2014-10-23 Thread Peter Maydell
On 21 October 2014 17:55, Greg Bellows wrote: > Version 7 of the ARM processor security extension (TrustZone) support. > This patchset includes changes to support the processor security extensions > on ARMv7 aarch32 with hooks for later enabling v8 aarch64/32. > > Summary of changes from v6 -> v7:

Re: [Qemu-devel] [PATCH] MAINTAINERS: add myself under 'general project admin' section

2014-10-23 Thread Markus Armbruster
Peter Maydell writes: > Signed-off-by: Peter Maydell Acked-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed

2014-10-23 Thread Markus Armbruster
Max Reitz writes: > Currently, if bdrv_check() fails either by returning -errno or having > check_errors set, qemu-img check just exits with 1 after having told the > user that there were no errors on the image. This is bad. > > Instead of printing the check result if there were internal errors w

Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed

2014-10-23 Thread Eric Blake
On 10/23/2014 07:59 AM, Max Reitz wrote: > On 2014-10-23 at 15:51, Eric Blake wrote: >> On 10/23/2014 07:29 AM, Max Reitz wrote: >>> Currently, if bdrv_check() fails either by returning -errno or having >>> check_errors set, qemu-img check just exits with 1 after having told the >>> user that there

Re: [Qemu-devel] [PATCH v7 06/32] target-arm: A32: Emulate the SMC instruction

2014-10-23 Thread Peter Maydell
On 21 October 2014 17:55, Greg Bellows wrote: > From: Fabian Aggeler > > Implements SMC instruction in AArch32 using the A32 syndrome. When executing > SMC instruction from monitor CPU mode SCR.NS bit is reset. > > Signed-off-by: Sergey Fedorov > Signed-off-by: Fabian Aggeler > Signed-off-by: G

Re: [Qemu-devel] [PATCH v13 07/14] block/mirror: Improve progress report

2014-10-23 Thread Eric Blake
On 10/23/2014 04:52 AM, Kevin Wolf wrote: > Am 22.10.2014 um 14:51 hat Max Reitz geschrieben: >> Instead of taking the total length of the block device as the block >> job's length, use the number of dirty sectors. The progress is now the >> number of sectors mirrored to the target block device. No

Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed

2014-10-23 Thread Max Reitz
On 2014-10-23 at 15:51, Eric Blake wrote: On 10/23/2014 07:29 AM, Max Reitz wrote: Currently, if bdrv_check() fails either by returning -errno or having check_errors set, qemu-img check just exits with 1 after having told the user that there were no errors on the image. This is bad. Instead of

Re: [Qemu-devel] [PATCH] MAINTAINERS: add myself under 'general project admin' section

2014-10-23 Thread Kevin Wolf
Am 15.10.2014 um 22:30 hat Peter Maydell geschrieben: > Signed-off-by: Peter Maydell > --- > Update the 'general project admin' section to include me as > well as Anthony, given that I've been in practice doing a > bunch of said admin, and the general consensus at the QEMU > Summit yesterday seeme

Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed

2014-10-23 Thread Eric Blake
On 10/23/2014 07:29 AM, Max Reitz wrote: > Currently, if bdrv_check() fails either by returning -errno or having > check_errors set, qemu-img check just exits with 1 after having told the > user that there were no errors on the image. This is bad. > > Instead of printing the check result if there

[Qemu-devel] [PULL 24/24] get_maintainer.pl: restrict cases where it falls back to --git

2014-10-23 Thread Paolo Bonzini
The list emitted by --git-fallback often leads inexperienced contributors to add pointless CCs. While not discouraging usage of --git-fallback, we want to: 1) disable the fallback if only some files lack a maintainer $ scripts/get_maintainer.pl -f util/cutils.c hw/ide/core.c Kevin Wolf

[Qemu-devel] [PULL 18/24] MAINTAINERS: add myself for X86

2014-10-23 Thread Paolo Bonzini
Still not moving it beyond "Odd fixes". Richard Henderson also has reviewed a bunch of X86 TCG patches, so add him as well. All we want is to avoid that patches fall on the floor. Signed-off-by: Paolo Bonzini --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 11/24] qdev: gpio: delete NamedGPIOList::out

2014-10-23 Thread Paolo Bonzini
From: Peter Crosthwaite All users of GPIO outputs are fully QOMified, using QOM properties to access the GPIO data. Delete. Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 1 - include/hw/qdev-core.h | 1 - 2 files change

[Qemu-devel] [PULL 23/24] get_maintainer.pl: move git loop under "if ($email) {"

2014-10-23 Thread Paolo Bonzini
All checks in the loop are guarded by that condition, and there is a handy "if" just below. Simplify the code. Reviewed-by: Markus Armbruster Signed-off-by: Paolo Bonzini --- scripts/get_maintainer.pl | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/scri

  1   2   3   >