Re: [Qemu-devel] [PATCH 1/8] virtio-gpu/2d: add hardware spec include file

2014-10-02 Thread Dave Airlie
On 30 September 2014 17:55, Gerd Hoffmann wrote: > > On Di, 2014-09-30 at 10:27 +1000, Dave Airlie wrote: >> > Triggered by the framebuffer endian issues we have with stdvga I've >> > started to check where we stand with virtio-gpu and whenever we have to >> > fix something in the virtio protocol

Re: [Qemu-devel] [RFC PATCH] block/migration: Disable cache invalidate for incoming migration

2014-10-02 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/2014 12:52 AM, Stefan Hajnoczi wrote: > On Thu, Oct 02, 2014 at 06:52:52PM +1000, Alexey Kardashevskiy wrote: >> When migrated using libvirt with "--copy-storage-all", at the end >> of migration there is race between NBD mirroring task trying

Re: [Qemu-devel] [PATCH 2/2] spapr_nvram: Enable migration

2014-10-02 Thread David Gibson
On Thu, Oct 02, 2014 at 07:56:03PM +1000, Alexey Kardashevskiy wrote: > The only case when sPAPR NVRAM migrates now is if is backed by a file and > copy-storage migration is performed. In other cases NVRAM does not > migrate regardless whether it is backed by a file or not. > > This enables shadow

Re: [Qemu-devel] [PATCH 1/2] vmstate: Allow dynamic allocation for VBUFFER during migration

2014-10-02 Thread David Gibson
On Thu, Oct 02, 2014 at 07:56:02PM +1000, Alexey Kardashevskiy wrote: > This extends use of VMS_ALLOC flag from arrays to VBUFFER as well. > > This defines VMSTATE_VBUFFER_ALLOC_UINT32 which makes use of VMS_ALLOC > and uses uint32_t type for a size. > > Signed-off-by: Alexey Kardashevskiy Revi

Re: [Qemu-devel] [PATCH 1/2] vmstate: Allow dynamic allocation for VBUFFER during migration

2014-10-02 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/02/2014 07:56 PM, Alexey Kardashevskiy wrote: > This extends use of VMS_ALLOC flag from arrays to VBUFFER as well. > > This defines VMSTATE_VBUFFER_ALLOC_UINT32 which makes use of > VMS_ALLOC and uses uint32_t type for a size. Adding Juan to c

[Qemu-devel] [Bug 1376798] Re: Qemu does not hotplug (usb) devices

2014-10-02 Thread Peter Wu
Not a bug, Linux increases the Device ID each time a new device gets hotplugged. If you need to use this option, pair it with already connected drivers by parsing the output of lsusb for instance. You can still use combinations of hostbus, vendorid, productid, etc. ** Changed in: qemu Stat

[Qemu-devel] [Bug 1376938] Re: detect-zeroes=unmap fails to discard in some cases

2014-10-02 Thread Peter Wu
Note that `cat /dev/zero` followed by `blkdiscard` has no issues. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1376938 Title: detect-zeroes=unmap fails to discard in some cases Status in QEMU:

[Qemu-devel] [Bug 1376938] [NEW] detect-zeroes=unmap fails to discard in some cases

2014-10-02 Thread Peter Wu
Public bug reported: Under certain circumstances, QEMU 2.1.2 fails to discard the underlaying block. The command to start QEMU is: qemu-system-x86_64 -machine pc,accel=kvm -m 2G -smp 2 -vga std -usb -usbdevice tablet -drive if=none,id=ff,aio=native,discard=unmap,detect- zeroes=unmap,file=/tmp/tes

[Qemu-devel] WiFi inside VMs?

2014-10-02 Thread Васил Рангелов
Hello. I'd like to ask if it would be possible to add support for at least one model of WiFi device on guest machines? I realize the feature request has been discussed previously (here: http://lists.nongnu.org/archive/html/qemu-devel/2007-03/msg00575.html ), but my reason for wanting it is sligh

Re: [Qemu-devel] WiFi inside VMs?

2014-10-02 Thread Васил Рангелов
Hi. A USB/PCI device that is passed through to the VM would get a real WiFi inside a VM, but doing THAT would place the VM in a *real* wireless network. The problem is that's not the goal. The goal is to introduce a WiFi into a *virtual* wireless network, i.e. a WiFi network between this VM an

Re: [Qemu-devel] WiFi inside VMs?

2014-10-02 Thread Nikolay Nikolaev
Hello, On Thu, Oct 2, 2014 at 10:14 PM, Васил Рангелов wrote: > Hello. > > I'd like to ask if it would be possible to add support for at least one > model of WiFi device on guest machines? USB and/or PCI passthorugh might help here, or am I getting something wrong? > > > I realize the feature r

[Qemu-devel] WiFi inside VMs?

2014-10-02 Thread Васил Рангелов
Hello. I'd like to ask if it would be possible to add support for at least one model of WiFi device on guest machines? I realize the feature request has been discussed previously (here: http://lists.nongnu.org/archive/html/qemu-devel/2007-03/msg00575.html ), but my reason for wanting it is sligh

[Qemu-devel] [PATCH v2 0/1] Add support for Xen access to vmport

2014-10-02 Thread Don Slutz
Changes v1 to v2: More info in commit message. Stefano Stabellini the registers being passes explicitely by Xen rather than "hiding" them into other ioreq fields. Added vmware_ioreq_t Paolo Bonzini & Alexander Graf Fixup env access Added cpu_by_ioreq_id. Set c

[Qemu-devel] [PATCH v2 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-02 Thread Don Slutz
This adds synchronisation of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU. This is to avoid a 2nd and 3rd exchange between QEMU and Xen to fetch and put these 6 vcpu registers used by the code in vmport.c and vmmouse.c Add new array to XenIOState that allows

Re: [Qemu-devel] IDs in QOM

2014-10-02 Thread Paolo Bonzini
Il 02/10/2014 16:59, Markus Armbruster ha scritto: > Andreas Färber writes: > >> Am 02.10.2014 um 16:21 schrieb Markus Armbruster: >>> Andreas Färber writes: >>> Am 02.10.2014 um 15:21 schrieb Stefan Hajnoczi: > On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: >> M

[Qemu-devel] is x-data-plane considered "stable" ?

2014-10-02 Thread Scott Sullivan
Can anyone tell me if in any QEMU release x-data-plane is considered "stable"? If its unclear, I am referring to the feature introduced in QEMU 1.4 for high performance disk I/O called virtio-blk data plane. http://blog.vmsplice.net/2013/03/new-in-qemu-14-high-performance-virtio.html I've tried

Re: [Qemu-devel] [PATCH 6/6] blockdev-test: Test device_del after drive_del

2014-10-02 Thread Markus Armbruster
Eric Blake writes: > On 10/02/2014 08:51 AM, Markus Armbruster wrote: >> Executed in this order, drive_del and device_del's automatic drive >> deletion take notoriously tricky special paths. >> >> Signed-off-by: Markus Armbruster >> --- >> tests/drive_del-test.c | 32 ++

Re: [Qemu-devel] [PATCH 2/6] blockdev-test: Use single rather than double quotes in QMP

2014-10-02 Thread Markus Armbruster
Eric Blake writes: > On 10/02/2014 08:51 AM, Markus Armbruster wrote: >> QMP accepts both single and double quotes. This is the only test >> using double quotes. They need to be quoted in C strings. Replace >> them by single quotes. > > Ooh, the use of single quotes on input is undocumented, a

Re: [Qemu-devel] [PATCH 1/6] drive_del-test: Merge of qdev-monitor-test, blockdev-test

2014-10-02 Thread Markus Armbruster
Eric Blake writes: > On 10/02/2014 08:51 AM, Markus Armbruster wrote: >> Each of qdev-monitor-test and blockdev-test has just one test case, >> and both are about drive_del. >> >> Signed-off-by: Markus Armbruster >> --- >> tests/Makefile | 5 +-- >> tests/bloc

[Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-02 Thread minyard
From: Corey Minyard Adds a "reconnect" option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after the given number of seconds. Signed-off-by: Corey Minyard --- qapi-sc

[Qemu-devel] [PATCH 6/6] qemu-char: Print the remote and local addresses for a socket

2014-10-02 Thread minyard
From: Corey Minyard It seems that it might be a good idea to know what is at the remote end of a socket for tracking down issues. So add that to the socket filename. Signed-off-by: Corey Minyard Reviewed-by: Paolo Bonzini --- qemu-char.c | 27 ++- 1 file changed, 18 i

[Qemu-devel] [PATCH v5 0/6] Add reconnecting to client sockets

2014-10-02 Thread minyard
One more time, with the rework added to qemu_chr_finish_socket_connection() that I should have seen. It didn't generate any errors, so there was no point in having error returns from it. Also added an assert to qemu_chr_socket_restart_timer(). Thanks, -corey

[Qemu-devel] [PATCH 1/6] qemu-char: Make the filename size for a chardev a #define

2014-10-02 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard Reviewed-by: Paolo Bonzini --- qemu-char.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 8623c70..f9d2a02 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -84,6 +84,7 @@ #def

[Qemu-devel] [PATCH 3/6] qemu-char: Move some items into TCPCharDriver

2014-10-02 Thread minyard
From: Corey Minyard This keeps them from having to be passed around and makes them available for later functions, like printing and reconnecting. Signed-off-by: Corey Minyard Reviewed-by: Paolo Bonzini --- qemu-char.c | 65 - 1 file

[Qemu-devel] [PATCH 2/6] qemu-char: Rework qemu_chr_open_socket() for reconnect

2014-10-02 Thread minyard
From: Corey Minyard Move all socket configuration to qmp_chardev_open_socket(). qemu_chr_open_socket_fd() just opens the socket. This is getting ready for the reconnect code, which will call open_sock_fd() on a reconnect attempt. Signed-off-by: Corey Minyard Reviewed-by: Paolo Bonzini --- qe

[Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected

2014-10-02 Thread minyard
From: Corey Minyard This way we can tell if the socket is connected or not. It also splits the string conversions out into separate functions to make this more convenient. Signed-off-by: Corey Minyard Reviewed-by: Paolo Bonzini --- qemu-char.c | 110 +++---

Re: [Qemu-devel] [PATCH v3 16/21] target-mips: add new Floating Point instructions

2014-10-02 Thread Yongbok Kim
Hi, Overall looking good but has issues with not freeing tcg_temps and some style problem which failed with the checkpatch.pl script. Otherwise Reviewed-by: Yongbok Kim Regards, Yongbok On 27/06/2014 16:22, Leon Alrae wrote: In terms of encoding MIPS32R6 MIN.fmt, MAX.fmt, MINA.fmt, MAXA.fm

[Qemu-devel] [Bug 1376675] Re: Qemu UI generally broken (both SDL and Gtk)

2014-10-02 Thread ManDay
*** This bug is a duplicate of bug 1294898 *** https://bugs.launchpad.net/bugs/1294898 ** This bug has been marked a duplicate of bug 1294898 gtk: menubar visible in fullscreen mode with gtk3 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-10-02 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 03:51:44PM +0200, Paolo Bonzini wrote: > The GNU Makefile standards have "make install" and "make > install-strip" targets. It would be nice to add "make install-strip" > and at the same time flip the default from --enable-strip to > --disable-strip. Makes sense. Stefan

Re: [Qemu-devel] [PATCH 6/6] blockdev-test: Test device_del after drive_del

2014-10-02 Thread Eric Blake
On 10/02/2014 08:51 AM, Markus Armbruster wrote: > Executed in this order, drive_del and device_del's automatic drive > deletion take notoriously tricky special paths. > > Signed-off-by: Markus Armbruster > --- > tests/drive_del-test.c | 32 > 1 file changed, 32

Re: [Qemu-devel] [PATCH v5] Support vhd type VHD_DIFFERENCING

2014-10-02 Thread Stefan Hajnoczi
On Fri, Sep 26, 2014 at 09:43:18PM +0800, Xiaodong Gong wrote: > Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu > can't read snapshot volume of vhd, and can't support other storage > features of vhd file. > > This patch add read parent information in function "vpc_open", read >

[Qemu-devel] [Bug 1376798] [NEW] Qemu does not hotplug (usb) devices

2014-10-02 Thread ManDay
Public bug reported: Qemu passes through all devices on Bus 3 with host-usb all right when issued so on the command line such as ... -device usb-ehci,id=USBCtrl -device host- usb,bus=USBCtrl.0,hostaddr=5 but it does not pass through the devices newly hotplugged to the host after Qemu has already

Re: [Qemu-devel] [PATCH 5/6] blockdev-test: Factor out some common code into helpers

2014-10-02 Thread Eric Blake
On 10/02/2014 08:51 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/drive_del-test.c | 60 > +- > 1 file changed, 30 insertions(+), 30 deletions(-) > > diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c > in

Re: [Qemu-devel] [PATCH 4/6] blockdev-test: Simplify by using g_assert_cmpstr()

2014-10-02 Thread Eric Blake
On 10/02/2014 08:51 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/drive_del-test.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http:

Re: [Qemu-devel] [PATCH 1/6] drive_del-test: Merge of qdev-monitor-test, blockdev-test

2014-10-02 Thread Eric Blake
On 10/02/2014 08:51 AM, Markus Armbruster wrote: > Each of qdev-monitor-test and blockdev-test has just one test case, > and both are about drive_del. > > Signed-off-by: Markus Armbruster > --- > tests/Makefile | 5 +-- > tests/blockdev-test.c

Re: [Qemu-devel] [PATCH 3/6] blockdev-test: Clean up bogus drive_add argument

2014-10-02 Thread Eric Blake
On 10/02/2014 08:51 AM, Markus Armbruster wrote: > The first argument should be a PCI address, which pci-addr=auto isn't. > Doesn't really matter, as drive_add ignores its first argument when > its second argument has if=none. Clean it up anyway. > > Signed-off-by: Markus Armbruster > --- > tes

Re: [Qemu-devel] [PATCH v2 1/2] main-loop: Pass AioContext into qemu_poll_ns

2014-10-02 Thread Stefan Hajnoczi
On Tue, Sep 30, 2014 at 11:35:17AM +0800, Fam Zheng wrote: > diff --git a/main-loop.c b/main-loop.c > index d2e64f1..4641ef4 100644 > --- a/main-loop.c > +++ b/main-loop.c > @@ -234,7 +234,8 @@ static int os_host_main_loop_wait(int64_t timeout) > spin_counter++; > } > > -ret = q

Re: [Qemu-devel] [PATCH 2/6] blockdev-test: Use single rather than double quotes in QMP

2014-10-02 Thread Eric Blake
On 10/02/2014 08:51 AM, Markus Armbruster wrote: > QMP accepts both single and double quotes. This is the only test > using double quotes. They need to be quoted in C strings. Replace > them by single quotes. Ooh, the use of single quotes on input is undocumented, and a violation of JSON. We al

Re: [Qemu-devel] Question on qemu threads

2014-10-02 Thread Stefan Hajnoczi
On Tue, Sep 30, 2014 at 01:44:48PM -0400, Al Patel wrote: > In the current system, what are the extra threads? The set of thread is dynamic because worker threads are started and terminated depending on guest activity. You cannot make assumptions about threads and QEMU provides monitor commands t

Re: [Qemu-devel] [PATCH 07/11] block: let backup blockjob run in BDS AioContext

2014-10-02 Thread Stefan Hajnoczi
On Wed, Oct 01, 2014 at 09:38:39PM +0200, Max Reitz wrote: > On 01.10.2014 19:01, Stefan Hajnoczi wrote: > >The backup block job must run in the BlockDriverState AioContext so that > >it works with dataplane. > > > >The basics of acquiring the AioContext are easy in blockdev.c. > > > >The completio

Re: [Qemu-devel] IDs in QOM

2014-10-02 Thread Markus Armbruster
Andreas Färber writes: > Am 02.10.2014 um 16:21 schrieb Markus Armbruster: >> Andreas Färber writes: >> >>> Am 02.10.2014 um 15:21 schrieb Stefan Hajnoczi: On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: > Markus Armbruster writes: This discussion seems or

Re: [Qemu-devel] [PATCH 05/11] blockjob: add block_job_defer_to_main_loop()

2014-10-02 Thread Stefan Hajnoczi
On Wed, Oct 01, 2014 at 09:06:36PM +0200, Max Reitz wrote: > On 01.10.2014 19:01, Stefan Hajnoczi wrote: > >+typedef struct { > >+BlockJob *job; > >+QEMUBH *bh; > >+AioContext *aio_context; > >+BlockJobDeferToMainLoopFn *fn; > >+void *opaque; > >+} BlockJobDeferToMainLoopData; >

Re: [Qemu-devel] [PULL 0/2] input patch queue

2014-10-02 Thread Peter Maydell
08: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20140929' into staging (2014-09-30 > 11:02:06 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-input-20141002-1 > > for you to fet

[Qemu-devel] [PATCH 5/6] blockdev-test: Factor out some common code into helpers

2014-10-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/drive_del-test.c | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c index 2baf0b7..463479d 100644 --- a/tests/drive_del-test.c +++ b/tes

Re: [Qemu-devel] [RFC PATCH] block/migration: Disable cache invalidate for incoming migration

2014-10-02 Thread Stefan Hajnoczi
On Thu, Oct 02, 2014 at 06:52:52PM +1000, Alexey Kardashevskiy wrote: > When migrated using libvirt with "--copy-storage-all", at the end of > migration there is race between NBD mirroring task trying to do flush > and migration completion, both end up invalidating cache. Since qcow2 > driver does

[Qemu-devel] [PATCH 3/6] blockdev-test: Clean up bogus drive_add argument

2014-10-02 Thread Markus Armbruster
The first argument should be a PCI address, which pci-addr=auto isn't. Doesn't really matter, as drive_add ignores its first argument when its second argument has if=none. Clean it up anyway. Signed-off-by: Markus Armbruster --- tests/drive_del-test.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PATCH 2/6] blockdev-test: Use single rather than double quotes in QMP

2014-10-02 Thread Markus Armbruster
QMP accepts both single and double quotes. This is the only test using double quotes. They need to be quoted in C strings. Replace them by single quotes. Signed-off-by: Markus Armbruster --- tests/drive_del-test.c | 32 1 file changed, 16 insertions(+), 16 del

[Qemu-devel] [PATCH 4/6] blockdev-test: Simplify by using g_assert_cmpstr()

2014-10-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/drive_del-test.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c index 67309fd..2baf0b7 100644 --- a/tests/drive_del-test.c +++ b/tests/drive_del-test.c @@ -17,7 +17,6 @@ stati

[Qemu-devel] [PATCH 6/6] blockdev-test: Test device_del after drive_del

2014-10-02 Thread Markus Armbruster
Executed in this order, drive_del and device_del's automatic drive deletion take notoriously tricky special paths. Signed-off-by: Markus Armbruster --- tests/drive_del-test.c | 32 1 file changed, 32 insertions(+) diff --git a/tests/drive_del-test.c b/tests/driv

[Qemu-devel] [PATCH 0/6] Improve drive_del test coverage

2014-10-02 Thread Markus Armbruster
The meat is in the last patch, the others are just cleanup. Markus Armbruster (6): drive_del-test: Merge of qdev-monitor-test, blockdev-test blockdev-test: Use single rather than double quotes in QMP blockdev-test: Clean up bogus drive_add argument blockdev-test: Simplify by using g_assert

[Qemu-devel] [PATCH 1/6] drive_del-test: Merge of qdev-monitor-test, blockdev-test

2014-10-02 Thread Markus Armbruster
Each of qdev-monitor-test and blockdev-test has just one test case, and both are about drive_del. Signed-off-by: Markus Armbruster --- tests/Makefile | 5 +-- tests/blockdev-test.c | 59 - tests/{qdev-monitor-tes

Re: [Qemu-devel] [PATCH v3 0/6] Q35: Implement -cdrom/-hda sugar

2014-10-02 Thread Stefan Hajnoczi
On Wed, Oct 01, 2014 at 02:19:23PM -0400, John Snow wrote: > The Q35 board initialization does not currently bother to look > for any drives added by the various syntactical sugar shorthands > to be added to the AHCI HBA. These include -hda through -hdd, > -cdrom, and -drive if=ide shorthands. > >

[Qemu-devel] Memory hotplug and ancient kernels

2014-10-02 Thread Andrey Korolyov
Hi, with kernel with an obsolete version (< 3.8) DIMM configuration is not working as defined in a boot-up values, though it is possible to add dimm during runtime and it will be recognized just well. ACPI tables and the of DMI for kernels which are recognizing on-boot modules and for ones which a

Re: [Qemu-devel] IDs in QOM

2014-10-02 Thread Andreas Färber
Am 02.10.2014 um 16:21 schrieb Markus Armbruster: > Andreas Färber writes: > >> Am 02.10.2014 um 15:21 schrieb Stefan Hajnoczi: >>> On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: Markus Armbruster writes: >>> >>> This discussion seems orthogonal to your patch. But I'm n

Re: [Qemu-devel] IDs in QOM

2014-10-02 Thread Markus Armbruster
Andreas Färber writes: > Am 02.10.2014 um 15:21 schrieb Stefan Hajnoczi: >> On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: >>> Markus Armbruster writes: >> >> This discussion seems orthogonal to your patch. But I'm not applying it >> yet to give more time for discussion/rev

Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from QemuOpts

2014-10-02 Thread Stefan Hajnoczi
On Thu, Oct 02, 2014 at 03:42:21PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Tue, Sep 30, 2014 at 01:59:30PM +0200, Markus Armbruster wrote: > >> +bool id_wellformed(const char *id) > >> +{ > >> +int i; > >> + > >> +if (!qemu_isalpha(id[0])) { > >> +return

Re: [Qemu-devel] IDs in QOM

2014-10-02 Thread Stefan Hajnoczi
On Thu, Oct 02, 2014 at 03:26:28PM +0200, Andreas Färber wrote: > Am 02.10.2014 um 15:21 schrieb Stefan Hajnoczi: > > On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: > >> Markus Armbruster writes: > > > > This discussion seems orthogonal to your patch. But I'm not applying it

Re: [Qemu-devel] [PULL 0/1] pixman: fix qemu_default_pixman_format (32bpp non-native endian)

2014-10-02 Thread Peter Maydell
et-arm-20140929' into staging (2014-09-30 > 11:02:06 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-console-20141002-1 > > for you to fetch changes up to 89ec031b09c81821e349c364575fad652395cf94: > > pixman: fix qem

Re: [Qemu-devel] NBD TLS support in QEMU

2014-10-02 Thread Wouter Verhelst
On Thu, Oct 02, 2014 at 01:00:04PM +0200, Paolo Bonzini wrote: > Il 01/10/2014 22:23, Wouter Verhelst ha scritto: > > Hi, > > > > On Fri, Sep 05, 2014 at 03:26:09PM +0200, Wouter Verhelst wrote: > >> Tunneling the entire protocol inside an SSL connection doesn't fix that; > >> if an attacker is ab

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-10-02 Thread Gal Hammer
On 02/10/2014 15:49, Michael S. Tsirkin wrote: On Wed, Sep 17, 2014 at 02:39:52PM +0300, Gal Hammer wrote: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table. The GUID is set using a n

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 03:43:35PM +0200, Paolo Bonzini wrote: > Il 02/10/2014 15:41, Michael S. Tsirkin ha scritto: > > On Thu, Oct 02, 2014 at 03:30:57PM +0200, Paolo Bonzini wrote: > >> These patches do fix John's scenario, but that is not the main issue. > >> They are not an _attempt_ to fix it

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Paolo Bonzini
Il 02/10/2014 15:41, Michael S. Tsirkin ha scritto: > On Thu, Oct 02, 2014 at 03:30:57PM +0200, Paolo Bonzini wrote: >> These patches do fix John's scenario, but that is not the main issue. >> They are not an _attempt_ to fix it, they just do so more or less by >> chance. Their real purpose is fix

Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from QemuOpts

2014-10-02 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Tue, Sep 30, 2014 at 01:59:30PM +0200, Markus Armbruster wrote: >> +bool id_wellformed(const char *id) >> +{ >> +int i; >> + >> +if (!qemu_isalpha(id[0])) { >> +return 0; > > false would be a bit nicer since the other return cases use true/false. Miss

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 03:30:57PM +0200, Paolo Bonzini wrote: > Il 02/10/2014 14:11, Michael S. Tsirkin ha scritto: > > Summarizing what you say, there are two issues around ACPI tables: > > - linuxboot uses FW CFG to for memory allocations, > > seabios ignores that, so they might conflict. > >

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Paolo Bonzini
Il 02/10/2014 14:11, Michael S. Tsirkin ha scritto: > Summarizing what you say, there are two issues around ACPI tables: > - linuxboot uses FW CFG to for memory allocations, > seabios ignores that, so they might conflict. > Let's fix either linuxboot or seabios (or both!) > and forget about i

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 04:14:05PM +0300, Gal Hammer wrote: > On 02/10/2014 15:49, Michael S. Tsirkin wrote: > >On Wed, Sep 17, 2014 at 02:39:52PM +0300, Gal Hammer wrote: > >>Based on Microsoft's sepecifications (paper can be dowloaded from > >>http://go.microsoft.com/fwlink/?LinkId=260709), add a

Re: [Qemu-devel] IDs in QOM

2014-10-02 Thread Andreas Färber
Am 02.10.2014 um 15:21 schrieb Stefan Hajnoczi: > On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: >> Markus Armbruster writes: > > This discussion seems orthogonal to your patch. But I'm not applying it > yet to give more time for discussion/review of the patch. > >> Is mangl

Re: [Qemu-devel] IDs in QOM (was: [PATCH] util: Emancipate id_wellformed() from QemuOpts)

2014-10-02 Thread Stefan Hajnoczi
On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: > Markus Armbruster writes: This discussion seems orthogonal to your patch. But I'm not applying it yet to give more time for discussion/review of the patch. > Is mangling array-ness into the name really a good idea? Isn't this

Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from QemuOpts

2014-10-02 Thread Stefan Hajnoczi
On Tue, Sep 30, 2014 at 01:59:30PM +0200, Markus Armbruster wrote: > +bool id_wellformed(const char *id) > +{ > +int i; > + > +if (!qemu_isalpha(id[0])) { > +return 0; false would be a bit nicer since the other return cases use true/false. pgpWncgsK8jId.pgp Description: PGP signa

Re: [Qemu-devel] [PATCH 0/2] make check-block/qemu-iotests fixes

2014-10-02 Thread Stefan Hajnoczi
On Tue, Sep 30, 2014 at 01:27:08PM +0200, Kevin Wolf wrote: > Kevin Wolf (2): > make check-block: Use default cache modes > qemu-iotests: Fix supported cache modes for 052 > > tests/qemu-iotests-quick.sh | 2 +- > tests/qemu-iotests/052 | 5 +++-- > 2 files changed, 4 insertions(+), 3 de

Re: [Qemu-devel] [PATCH v3 6/6] q35/ahci: Pick up -cdrom and -hda options

2014-10-02 Thread Michael S. Tsirkin
On Wed, Oct 01, 2014 at 02:19:29PM -0400, John Snow wrote: > This patch implements the backend for the Q35 board > for us to be able to pick up and use drives defined > by the -cdrom, -hda, or -drive if=ide shorthand options. > > Signed-off-by: John Snow Reviewed-by: Michael S. Tsirkin > ---

Re: [Qemu-devel] [PATCH v3 5/6] qtest/bios-tables: Correct Q35 command line

2014-10-02 Thread Michael S. Tsirkin
On Wed, Oct 01, 2014 at 02:19:28PM -0400, John Snow wrote: > If the Q35 board types are to begin recognizing > and decoding syntactic sugar for drive/device > declarations, then workarounds found within > the qtests suite need to be adjusted to prevent > any test failures after the fix. > > bios-t

Re: [Qemu-devel] [PATCH v3 3/6] pc/vl: Add units-per-default-bus property

2014-10-02 Thread Michael S. Tsirkin
On Wed, Oct 01, 2014 at 02:19:26PM -0400, John Snow wrote: > This patch adds the 'units_per_default_bus' property which > allows individual boards to declare their desired > index => (bus,unit) mapping for their default HBA, so that > boards such as Q35 can specify that its default if_ide HBA, > AH

Re: [Qemu-devel] [PATCH v5] vmdk: Fix integer overflow in offset calculation

2014-10-02 Thread Stefan Hajnoczi
On Tue, Sep 23, 2014 at 09:56:21AM +0800, Fam Zheng wrote: > This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster > allocation). > > $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k' > write failed: Invalid argument > > Reported-by: Mark Cave-Ayland > Reviewed-by: M

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-10-02 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 02:39:52PM +0300, Gal Hammer wrote: > Based on Microsoft's sepecifications (paper can be dowloaded from > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > description to the SSDT ACPI table. > > The GUID is set using a new "vmgenid" device. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Paolo Bonzini
Il 02/10/2014 14:11, Michael S. Tsirkin ha scritto: > On Thu, Sep 18, 2014 at 06:17:48PM +0200, Paolo Bonzini wrote: >> In the emergency last-minute patches of QEMU 2.1 we did two things: >> >> - fixed migration problems from 1.7 or 2.0 to 2.1 due to changes in >> ACPI table sizes >> >> - ensured

Re: [Qemu-devel] [PATCH 0/4] qemu-file: Move QEMUFileOps implementations to separate files

2014-10-02 Thread Eduardo Habkost
On Thu, Oct 02, 2014 at 08:49:12AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > With this, code that uses symbols from qemu-file.c don't need to bring extra > > dependencies because of the actual QEMUFile operation implementations. > > Each case of omitting the "extra dependen

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-02 Thread Paolo Bonzini
Il 01/10/2014 23:09, miny...@acm.org ha scritto: > From: Corey Minyard > > Adds a "reconnect" option to socket backends that gives a reconnect > timeout. This only applies to client sockets. If the other end > of a socket closes the connection, qemu will attempt to reconnect > after the given n

Re: [Qemu-devel] [PATCH 3/3] libqos: Add virtio MMIO support

2014-10-02 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 06:24:39PM +0200, Marc Marí wrote: > +QVirtioMMIODevice *qvirtio_mmio_init_device(uint64_t addr, uint32_t > page_size) > +{ > +QVirtioMMIODevice *dev; > +union { uint32_t magic; char bytes[5]; } magic_value; > +dev = g_malloc0(sizeof(*dev)); > +magic_value.b

Re: [Qemu-devel] [PULL 00/10] vga: cleanups, prepare for endianness switching

2014-10-02 Thread Peter Maydell
;remotes/pmaydell/tags/pull-target-arm-20140929' into staging (2014-09-30 > 11:02:06 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-vga-20141002-1 > > for you to fetch changes up to c3b10605147f9113b8b157d7226d3e2151

Re: [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected

2014-10-02 Thread Paolo Bonzini
Il 01/10/2014 23:09, miny...@acm.org ha scritto: > From: Corey Minyard > > This way we can tell if the socket is connected or not. It also splits > the string conversions out into separate functions to make this more > convenient. > > Signed-off-by: Corey Minyard > Reviewed-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 2/6] qemu-char: Rework qemu_chr_open_socket() for reconnect

2014-10-02 Thread Paolo Bonzini
Il 01/10/2014 23:09, miny...@acm.org ha scritto: > From: Corey Minyard > > Move all socket configuration to qmp_chardev_open_socket(). > qemu_chr_open_socket_fd() just opens the socket. This is getting ready > for the reconnect code, which will call open_sock_fd() on a reconnect > attempt. > >

Re: [Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-10-02 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 02:39:51PM +0300, Gal Hammer wrote: > Add a 16-bytes buffer to allow storing a 128-bit UUID value in an > ACPI table. > > Signed-off-by: Gal Hammer > Reviewed-by: Paolo Bonzini This one looks good. Applied, thanks! > --- > scripts/acpi_extract.py | 23 ++--

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 03:12:53PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 17, 2014 at 02:39:50PM +0300, Gal Hammer wrote: > > Hi, > > > > A two parts patch to add a QEmu support for Microsoft's Virtual Machine > > Generation ID device. > > > > The first one add a new ACPI directive which

Re: [Qemu-devel] [PATCH 2/3] libqos: Add malloc generic

2014-10-02 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 06:24:38PM +0200, Marc Marí wrote: > This malloc is a basic interface implementation that works for any platform. > It should be replaced in the future for a real malloc implementation for each > of the platforms. > > Signed-off-by: Marc Marí > --- > tests/libqos/malloc-g

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-02 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 02:39:50PM +0300, Gal Hammer wrote: > Hi, > > A two parts patch to add a QEmu support for Microsoft's Virtual Machine > Generation ID device. > > The first one add a new ACPI directive which allow to use a 16-bytes > buffer in an ACPI table. This buffer is for storing the

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Michael S. Tsirkin
On Thu, Sep 18, 2014 at 06:17:48PM +0200, Paolo Bonzini wrote: > In the emergency last-minute patches of QEMU 2.1 we did two things: > > - fixed migration problems from 1.7 or 2.0 to 2.1 due to changes in > ACPI table sizes > > - ensured that future versions will not break migration compatibili

Re: [Qemu-devel] [PATCH 1/3] libqos: Remove PCI assumptions in virtio driver

2014-10-02 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 06:24:37PM +0200, Marc Marí wrote: > @@ -60,25 +60,25 @@ static void qvirtio_pci_assign_device(QVirtioDevice *d, > void *data) > *vpcidev = (QVirtioPCIDevice *)d; > } > > -static uint8_t qvirtio_pci_config_readb(QVirtioDevice *d, void *addr) > +static uint8_t qvirti

Re: [Qemu-devel] [PATCH v5 04/23] block: Connect BlockBackend and DriveInfo

2014-10-02 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.10.2014 um 11:04 hat Markus Armbruster geschrieben: >> Make the BlockBackend own the DriveInfo. Change blockdev_init() to >> return the BlockBackend instead of the DriveInfo. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Max Reitz > >> @@ -200,11 +202,11 @@

Re: [Qemu-devel] [PATCH v5 03/23] block: Connect BlockBackend to BlockDriverState

2014-10-02 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.10.2014 um 11:04 hat Markus Armbruster geschrieben: >> Convenience function blk_new_with_bs() creates a BlockBackend with its >> BlockDriverState. Callers have to unref both. The commit after next >> will relieve them of the need to unref the BlockDriverState. >> >>

Re: [Qemu-devel] NBD TLS support in QEMU

2014-10-02 Thread Paolo Bonzini
Il 02/10/2014 13:05, Daniel P. Berrange ha scritto: > On Wed, Oct 01, 2014 at 10:23:26PM +0200, Wouter Verhelst wrote: >> Hi, >> >> On Fri, Sep 05, 2014 at 03:26:09PM +0200, Wouter Verhelst wrote: >>> Tunneling the entire protocol inside an SSL connection doesn't fix that; >>> if an attacker is abl

[Qemu-devel] [Bug 1376675] [NEW] Qemu UI generally broken (both SDL and Gtk)

2014-10-02 Thread ManDay
Public bug reported: With 2.1.2 on FC20 fedora-virt-preview, both the Gtk Interface and the SDL Interface have bugs. The Gtk Interface has only one: Fullscreen is broken, menu remains visible (w GTK3) The SDL interface is completely broken. -no-frame is not respected. Shortcuts don't work (neith

Re: [Qemu-devel] NBD TLS support in QEMU

2014-10-02 Thread Daniel P. Berrange
On Wed, Oct 01, 2014 at 10:23:26PM +0200, Wouter Verhelst wrote: > Hi, > > On Fri, Sep 05, 2014 at 03:26:09PM +0200, Wouter Verhelst wrote: > > Tunneling the entire protocol inside an SSL connection doesn't fix that; > > if an attacker is able to hijack your TCP connections and change flags, > > t

Re: [Qemu-devel] NBD TLS support in QEMU

2014-10-02 Thread Paolo Bonzini
Il 01/10/2014 22:23, Wouter Verhelst ha scritto: > Hi, > > On Fri, Sep 05, 2014 at 03:26:09PM +0200, Wouter Verhelst wrote: >> Tunneling the entire protocol inside an SSL connection doesn't fix that; >> if an attacker is able to hijack your TCP connections and change flags, >> then this attacker i

Re: [Qemu-devel] [PATCH 0/2] Here are 2 patches to enable sPAPR NVRAM migration.

2014-10-02 Thread Alexander Graf
On 02.10.14 11:56, Alexey Kardashevskiy wrote: > Please comment. Thanks! > > Changes: > v2: > * reworked to always have a copy of NVRAM in RAM and use file only for writes I like it, please get an ack from Juan on patch 1/2, then I can apply it. Alex

Re: [Qemu-devel] [PATCH v5 04/23] block: Connect BlockBackend and DriveInfo

2014-10-02 Thread Kevin Wolf
Am 02.10.2014 um 11:04 hat Markus Armbruster geschrieben: > Make the BlockBackend own the DriveInfo. Change blockdev_init() to > return the BlockBackend instead of the DriveInfo. > > Signed-off-by: Markus Armbruster > Reviewed-by: Max Reitz > @@ -200,11 +202,11 @@ DriveInfo *drive_get_next(Blo

Re: [Qemu-devel] [PATCH v5 03/23] block: Connect BlockBackend to BlockDriverState

2014-10-02 Thread Kevin Wolf
Am 02.10.2014 um 11:04 hat Markus Armbruster geschrieben: > Convenience function blk_new_with_bs() creates a BlockBackend with its > BlockDriverState. Callers have to unref both. The commit after next > will relieve them of the need to unref the BlockDriverState. > > Complication: due to the sil

Re: [Qemu-devel] [PATCH v3 18/21] target-mips: do not allow Status.FR=0 mode in 64-bit FPU

2014-10-02 Thread Yongbok Kim
Correction: it is not updating the bit but checking the bit. Reviewed-by: Yongbok Kim On 02/10/14 11:21, Yongbok Kim wrote: > There is a block of code that modifies CP0_Status_rw_bitmask.CP0St_FR > bit to read-writable in the same function. > So effectively in case of MIPS64 R6 the bit is now

Re: [Qemu-devel] [PATCH v3 18/21] target-mips: do not allow Status.FR=0 mode in 64-bit FPU

2014-10-02 Thread Yongbok Kim
There is a block of code that modifies CP0_Status_rw_bitmask.CP0St_FR bit to read-writable in the same function. So effectively in case of MIPS64 R6 the bit is now R/W which shouldn't be. You need to modify or merge the code. # if defined(TARGET_MIPS64) /* For MIPS64, init FR bit to 1 if FPU u

Re: [Qemu-devel] [RFC PATCH] block/migration: Disable cache invalidate for incoming migration

2014-10-02 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/02/2014 07:45 PM, Paolo Bonzini wrote: > Il 02/10/2014 10:52, Alexey Kardashevskiy ha scritto: >> When migrated using libvirt with "--copy-storage-all", at the end >> of migration there is race between NBD mirroring task trying to do >> flush and

  1   2   >