[Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProperty struct

2014-09-26 Thread arei.gonglei
From: Gonglei The descriptions can serve as documentation in the code, and they can be used to provide better help. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei --- include/qom/object.h | 15 +++ qom/object.c | 14 ++

[Qemu-devel] [PATCH v3 5/7] qdev: set the object property's description to the qdev property's.

2014-09-26 Thread arei.gonglei
From: Gonglei Set all static qdev properties' descriptions to object property's description. When we call object_property_add_alias() adding alias properties to the source object on the target Object, set the object property's description to the source qdev property's. Cc: Paolo Bonzini Cc: Mi

[Qemu-devel] [PATCH v3 3/7] qdev: add description field in PropertyInfo struct

2014-09-26 Thread arei.gonglei
From: Gonglei The descriptions can serve as documentation in the code, and they can be used to provide better help. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei Signed-off-by: Paolo Bonzini --- hw/core/qdev-properties-system.c | 4 hw/core/qdev

[Qemu-devel] [PATCH v3 1/7] qom: add error handler for object_property_print()

2014-09-26 Thread arei.gonglei
From: Gonglei Avoid the caller of object_property_print() leaking string argument's memory, such as qdev_print_props() when encounter errors. Cc: Paolo Bonzini Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini --- qom/object.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(

[Qemu-devel] [PATCH v3 7/7] qdev: drop legacy_name from qdev properties

2014-09-26 Thread arei.gonglei
From: Gonglei The legacy_name is useless now, the better help information provied by description field of property. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei --- hw/core/qdev-properties-system.c | 4 hw/core/qdev-properties.c| 6 -

[Qemu-devel] [PATCH v3 2/7] qom: add error handler for object alias property

2014-09-26 Thread arei.gonglei
From: Gonglei object_property_add_alias() is called at some places at present. And its parameter errp may not NULL, such as object_property_add_alias(obj, "iothread", OBJECT(&dev->vdev),"iothread", &error_abort); This patch add error handler for security. Cc: Stefa

[Qemu-devel] [PATCH v3 6/7] qmp: print descriptions of object properties

2014-09-26 Thread arei.gonglei
From: Gonglei Add a new "description" field to DevicePropertyInfo. The descriptions can serve as documentation in the code, and they can be used to provide better help. For example: $./qemu-system-x86_64 -device virtio-blk-pci,? Before this patch: virtio-blk-pci.iothread=link virtio-blk-pci.x-

[Qemu-devel] [PATCH v3 0/7] add description field in ObjectProperty and PropertyInfo struct

2014-09-26 Thread arei.gonglei
From: Gonglei ATCH 1 and PATCH 2 are bugfixes. PATCH 3~7 add a description field in both ObjectProperty and PropertyInfo struct. The descriptions can serve as documentation in the code, and they can be used to provide better help. For example: Before this patch series: $./qemu-system-x86_64 -de

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-26 Thread Gonglei (Arei)
Hi, > > > > virtio-$device-{pci, s390, ccw} all duplicate the > > qdev properties of their virtio child. This approach does > > not work well with string or pointer properties since we > > must be careful about leaking or double-freeing them. > > > > Use the QOM alias property to forward property

Re: [Qemu-devel] [PATCH v4 2/2] Tests: QEMUSizedBuffer/QEMUBuffer

2014-09-26 Thread Eric Blake
On 09/17/2014 05:26 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Modify some of tests/test-vmstate.c to use the in memory file based > on QEMUSizedBuffer to provide basic testing of QEMUSizedBuffer and > the associated memory backed QEMUFile type. > > Only some of

Re: [Qemu-devel] [PATCH v4 1/2] QEMUSizedBuffer based QEMUFile

2014-09-26 Thread Eric Blake
On 09/17/2014 05:26 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This is based on Stefan and Joel's patch that creates a QEMUFile that goes > to a memory buffer; from: > > http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg05036.html Sheesh - a year and a ha

Re: [Qemu-devel] [PATCH v2] ui/input: fix event emitting of repeated combined keys

2014-09-26 Thread Amos Kong
On Fri, Sep 26, 2014 at 01:24:05PM +0200, Gerd Hoffmann wrote: > On Fr, 2014-09-26 at 18:53 +0800, Amos Kong wrote: > > On Fri, Sep 26, 2014 at 12:36:50PM +0200, Gerd Hoffmann wrote: > > > On Fr, 2014-09-26 at 18:23 +0800, Amos Kong wrote: > > > > Currently we emit press events of combined keys fir

[Qemu-devel] [PATCH] libcacard: fix compile error on glib2-2.12.3-4.el5

2014-09-26 Thread zwu . kernel
From: Zhi Yong Wu lt LINK libcacard.la CClibcacard/vscclient.o lt LINK vscclient /usr/bin/ld: -f may not be used without -shared collect2: ld returned 1 exit status make: *** [vscclient] Error 1 Signed-off-by: Zhi Yong Wu --- libcacard/Makefile |3 ++- 1 files changed, 2 insertions(+

Re: [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in try_fiemap

2014-09-26 Thread Tony Breeds
On Fri, Sep 26, 2014 at 11:09:30AM -0600, Eric Blake wrote: > [you buried your patches in deep reply to a longer thread, making them > harder to find; in the future, you can just send a v2 as a new top-level > thread] Thanks. I'll remember that next time. Tony. pgpqvgudi2tHf.pgp Description:

[Qemu-devel] [PATCH v3 13/17] accel: Move accel init/allowed code to separate function

2014-09-26 Thread Eduardo Habkost
Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- accel.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/accel.c b/accel.c index 0f3fcee..9241967 100644 --- a/accel.c +++ b/accel.c @@ -57,6 +57,17 @@ static AccelClass *accel_find(const char *opt_

[Qemu-devel] [PATCH v3 17/17] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct

2014-09-26 Thread Eduardo Habkost
Now that we create an accel object before calling machine_init, we can simply use the accel object to save all KVMState data, instead of allocationg KVMState manually. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- kvm-all.c | 13 + 1 file changed, 9 insertions(+), 4

[Qemu-devel] [PATCH v3 11/17] accel: Move qtest accel registration to qtest.c

2014-09-26 Thread Eduardo Habkost
As qtest_availble() returns 1 only when CONFIG_POSIX is set, keep setting AccelClass.available to keep current behavior (this is different from what we did for KVM and Xen). This also allows us to make qtest_init_accel() static. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- acc

[Qemu-devel] [PATCH v3 16/17] accel: Create accel object when initializing machine

2014-09-26 Thread Eduardo Habkost
Create an actual TYPE_ACCEL object when initializing a machine. This will allow accelerator classes to implement some initialization on instance_init, and to save state on the TYPE_ACCEL object. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- Changes v2 -> v3: * Squashed "accel: Cr

[Qemu-devel] [PATCH v3 12/17] accel: Remove tcg_available() function

2014-09-26 Thread Eduardo Habkost
As the function always return 1, it is not needed anymore. Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini --- accel.c| 1 - arch_init.c| 5 - include/sysemu/arch_init.h | 1 - 3 files changed, 7 deletions(-) diff --git a/accel.c b/accel.c inde

[Qemu-devel] [PATCH v3 10/17] accel: Move Xen registration code to xen-common.c

2014-09-26 Thread Eduardo Habkost
Note that this has an user-visible side-effect: instead of reporting "Xen is not supported for this target", QEMU binaries not supporting Xen will report "xen accelerator does not exist". As xen_available() always return 1 when CONFIG_XEN is enabled, we don't need to set AccelClass.available anymo

[Qemu-devel] [PATCH v3 09/17] accel: Move KVM accel registration to kvm-all.c

2014-09-26 Thread Eduardo Habkost
Note that this has an user-visible side-effect: instead of reporting "KVM is not supported for this target", QEMU binaries not supporting KVM will report "kvm accelerator does not exist". As kvm_availble() always return 1 when CONFIG_KVM is enabled, we don't need to set AccelClass.available anymor

[Qemu-devel] [PATCH v3 15/17] accel: Pass MachineState object to accel init functions

2014-09-26 Thread Eduardo Habkost
Most of the machine options and machine state information is in the MachineState object, not on the MachineClass. This will allow init functions to use the MachineState object directly instead of qemu_get_machine_opts() or the current_machine global. Reviewed-by: Paolo Bonzini Signed-off-by: Edua

[Qemu-devel] [PATCH v3 07/17] accel: Make AccelClass.available() optional

2014-09-26 Thread Eduardo Habkost
When we move accel classes outside accel.c, the available() function won't be necessary anymore, because the classes will be registered only if the accelerator code is really enabled at build time. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- accel.c | 2 +- 1 file changed, 1 i

[Qemu-devel] [PATCH v3 08/17] accel: Report unknown accelerator as "not found" instead of "does not exist"

2014-09-26 Thread Eduardo Habkost
As the accelerator classes won't be registered anymore if they are not enabled at compile time, saying "does not exist" may be misleading, as the accelerator may be simply disabled. Change the wording to just say "not found". Suggested-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- accel.

[Qemu-devel] [PATCH v3 14/17] accel: Rename 'init' method to 'init_machine'

2014-09-26 Thread Eduardo Habkost
Today, all accelerator init functions affect some global state: * tcg_init() calls tcg_exec_init() and affects globals such as tcg_tcx, page size globals, and possibly others; * kvm_init() changes the kvm_state global, cpu_interrupt_handler, and possibly others; * xen_init() changes the xen_xc

[Qemu-devel] [PATCH v3 06/17] accel: Use QOM classes for accel types

2014-09-26 Thread Eduardo Habkost
Instead of having a static AccelType array, register a class for each accelerator type, and use class name lookup to find accelerator information. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- accel.c| 117 +++-- includ

[Qemu-devel] [PATCH v3 04/17] accel: Simplify configure_accelerator() using AccelType *acc variable

2014-09-26 Thread Eduardo Habkost
Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- accel.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/accel.c b/accel.c index 3cefd74..fc8c551 100644 --- a/accel.c +++ b/accel.c @@ -62,6 +62,7 @@ int configure_accelerator(MachineClass *mc)

[Qemu-devel] [PATCH v3 01/17] vl.c: Small coding style fix

2014-09-26 Thread Eduardo Habkost
Just to make checkpatch.pl happy when moving the code. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index dbdca59..ce606a6 100644 --- a/vl.c +++ b/vl.c @@ -2715,7 +2715,7 @@ static int configur

[Qemu-devel] [PATCH v3 05/17] accel: Move accel name lookup to separate function

2014-09-26 Thread Eduardo Habkost
Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- accel.c | 57 + 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/accel.c b/accel.c index fc8c551..c752fcc 100644 --- a/accel.c +++ b/accel.c @@ -55,11 +55,24 @@ st

[Qemu-devel] [PATCH v3 03/17] accel: Create AccelType typedef

2014-09-26 Thread Eduardo Habkost
Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- accel.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/accel.c b/accel.c index 9424796..3cefd74 100644 --- a/accel.c +++ b/accel.c @@ -40,13 +40,15 @@ static int tcg_init(MachineClass *mc) return 0; }

[Qemu-devel] [PATCH v3 02/17] accel: Move accel code to accel.c

2014-09-26 Thread Eduardo Habkost
Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- Changes v2 -> v3: Suggested-by: Paolo Bonzini : * Rename hw/core/accel.c -> accel.c, * Rename include/hw/accel.h -> include/sysemu/accel.h --- Makefile.objs | 1 + accel.c| 113 +++

[Qemu-devel] [PATCH v3 00/17] QOMify accelerator code

2014-09-26 Thread Eduardo Habkost
This is an attempt to convert the accel initialization and registration code to be QOM-based. Some use cases for this are: * Isolating KVM-specific CPU initialization and compatibility code; * Use compat_props to implement accelrator-specific compatibility code on machine-types; * Returning

[Qemu-devel] [PATCH 0/2] Virtio-9p live migration patchset

2014-09-26 Thread Boris Sukholitko
This patchset is a small rebase of the 9p live migration patches made a year ago by Benoit Canet. See http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg02190.html for the previous thread. I took the liberty to drop the second patch (waiting for completion of 9p operations) as it wasn't work

[Qemu-devel] [PATCH 2/2] virtio-9p: Remove migration blockers.

2014-09-26 Thread Boris Sukholitko
Signed-off-by: Boris Sukholitko --- hw/9pfs/virtio-9p.c | 24 hw/9pfs/virtio-9p.h | 2 -- 2 files changed, 26 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 5861a5b..2bf3c0a 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -332,19

[Qemu-devel] [PATCH 1/2] virtio-9p: Add support for 9p migration.

2014-09-26 Thread Boris Sukholitko
This patch is a rebase of Aneesh Kumar's and Benoit Canet's previous work. Signed-off-by: Boris Sukholitko --- hw/9pfs/virtio-9p-device.c | 152 + 1 file changed, 152 insertions(+) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c i

Re: [Qemu-devel] [RFC patch 0/6] vfio based pci pass-through for qemu/KVM on s390

2014-09-26 Thread Alex Williamson
On Fri, 2014-09-26 at 08:45 +0200, Frank Blaschka wrote: > On Wed, Sep 24, 2014 at 10:05:57AM -0600, Alex Williamson wrote: > > On Wed, 2014-09-24 at 10:47 +0200, Frank Blaschka wrote: > > > On Mon, Sep 22, 2014 at 02:47:31PM -0600, Alex Williamson wrote: > > > > On Fri, 2014-09-19 at 13:54 +0200,

Re: [Qemu-devel] [PATCH v7 02/11] target-arm: Add SCR_EL3

2014-09-26 Thread Edgar E. Iglesias
Oops, thanks! --- Sent from my phone On Sep 27, 2014 12:46 AM, "Peter Maydell" wrote: > On 26 September 2014 09:08, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > > static uint64_t ccsidr_read(CPUARMState *env, const ARMCPRegInfo *ri) >

[Qemu-devel] [PATCH 2/3] bitops.h: Don't include qemu-common.h

2014-09-26 Thread Eduardo Habkost
This removes the following circular dependency: bitops.h -> qemu-common.h -> target-i386/cpu.h -> target-i386/cpu-qom.h -> qom/cpu.h -> qdev-core.h -> bitmap.h -> bitops.h. Signed-off-by: Eduardo Habkost --- include/qemu/bitops.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --

[Qemu-devel] [PATCH 3/3] bitmap.h: Don't include qemu-common.h

2014-09-26 Thread Eduardo Habkost
This will avoid unexpected circular header dependencies in the future. Signed-off-by: Eduardo Habkost --- include/qemu/bitmap.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 1babd5d..8c50d70 100644 --- a/include/qemu/b

[Qemu-devel] [PATCH 1/3] tests: Add missing include to test-bitops.c

2014-09-26 Thread Eduardo Habkost
The test code needs osdep.h for the ARRAY_SIZE macro. Signed-off-by: Eduardo Habkost --- tests/test-bitops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-bitops.c b/tests/test-bitops.c index 8238eb5..47b5d3e 100644 --- a/tests/test-bitops.c +++ b/tests/test-bitops.c @@ -8,6 +8,

[Qemu-devel] [PATCH 0/3] bitops: Header dependency fixes

2014-09-26 Thread Eduardo Habkost
This series adds a missing include, kills a circular header dependency, and avoid including qemu-common.h from a header to avoid new circular dependencies. Eduardo Habkost (3): tests: Add missing include to test-bitops.c bitops.h: Don't include qemu-common.h bitmap.h: Don't include qemu-comm

Re: [Qemu-devel] [PATCH v2 10/17] accel: Move qtest accel registration to qtest.c

2014-09-26 Thread Eduardo Habkost
On Fri, Sep 26, 2014 at 05:06:43PM +0200, Paolo Bonzini wrote: > Il 29/08/2014 22:31, Eduardo Habkost ha scritto: > > As qtest_availble() returns 1 only when CONFIG_POSIX is set, keep > > setting AccelClass.available to keep current behavior (this is different > > from what we did for KVM and Xen).

[Qemu-devel] [PULL 7/9] qemu-socket: Polish errors for connect() and listen() failure

2014-09-26 Thread Luiz Capitulino
From: Markus Armbruster connect() doesn't "connect to socket", it connects a socket to an address and, if it's of type SOCK_STREAM, initiates a connection. Scratch "to". listen() does "set socket to listening mode", but it sounds awkward. Change to "listen on socket". Signed-off-by: Markus Armb

[Qemu-devel] [PULL 0/9] QMP queue

2014-09-26 Thread Luiz Capitulino
The following changes since commit 81ab11a7a524d12412a59ef49c6b270671e62ea0: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-09-26 15:41:50 +0100) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch

[Qemu-devel] [PULL 9/9] Add HMP command "info memory-devices"

2014-09-26 Thread Luiz Capitulino
From: Zhu Guihua Provides HMP equivalent of QMP query-memory-devices command. Signed-off-by: Zhu Guihua Reviewed-By: Igor Mammedov Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 2 ++ hmp.c | 38 ++ hmp.h | 1 + monitor.c

[Qemu-devel] [PULL 4/9] qapi: dealloc visitor, implement visit_start_union

2014-09-26 Thread Luiz Capitulino
From: Michael Roth If the .data field of a QAPI Union is NULL, we don't need to free any of the union fields. Make use of the new visit_start_union interface to access this information and instruct the generated code to not visit these fields when this occurs. Cc: qemu-sta...@nongnu.org Reporte

[Qemu-devel] [PULL 8/9] qemu-socket: Eliminate silly QERR_ macros

2014-09-26 Thread Luiz Capitulino
From: Markus Armbruster The QERR_ macros are leftovers from the days of "rich" error objects. They're used with error_set() and qerror_report(), and expand into the first *two* arguments. This trickiness has become pointless. Clean up. Signed-off-by: Markus Armbruster Reviewed-by: Paolo Bonzi

[Qemu-devel] [PULL 08/11] docs: add blkdebug block driver documentation

2014-09-26 Thread Kevin Wolf
From: Stefan Hajnoczi The blkdebug block driver is undocumented. Documenting it is worthwhile since it offers powerful error injection features that are used by qemu-iotests test cases. This document will make it easier for people to learn about and use blkdebug. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 11/11] qemu-iotests: Fail test if explicit test case number is unknown

2014-09-26 Thread Kevin Wolf
From: Fam Zheng When we expand a number range, we just print "$id - unknown test, ignored", this is convenient if we want to run a range of tests. When we designate a test case number explicitly, we shouldn't just ignore it if the case script doesn't exist. Print an error and fail the test. Si

[Qemu-devel] [PULL 2/9] virtio-balloon: fix integer overflow in memory stats feature

2014-09-26 Thread Luiz Capitulino
When a QMP client changes the polling interval time by setting the guest-stats-polling-interval property, the interval value is stored and manipulated as an int64_t variable. However, the balloon_stats_change_timer() function, which is used to set the actual timer with the interval value, takes an

[Qemu-devel] [PULL 6/9] qemu-iotests: Test missing "driver" key for blockdev-add

2014-09-26 Thread Luiz Capitulino
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Cc: qemu-sta...@nongnu.org Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- tests/qemu-iotests/087 | 17 + tests/qemu-iotests/087.out | 13 + 2 files changed, 30 insertions(+) diff

[Qemu-devel] [PULL 5/9] tests: add QMP input visitor test for unions with no discriminator

2014-09-26 Thread Luiz Capitulino
From: Michael Roth This is more of an exercise of the dealloc visitor, where it may erroneously use an uninitialized discriminator field as indication that union fields corresponding to that discriminator field/type are present, which can lead to attempts to free random chunks of heap memory. Cc

[Qemu-devel] [PULL 1/9] monitor: Reset HMP mon->rs in CHR_EVENT_OPEN

2014-09-26 Thread Luiz Capitulino
From: Stratos Psomadakis Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a bug in the way the HMP monitor handles its command buffer. When a client closes the connection to the monitor, tcp_chr_read() will detect the G_IO_HUP condition and call tcp_chr_disconnect() to close t

[Qemu-devel] [PULL 3/9] qapi: add visit_start_union and visit_end_union

2014-09-26 Thread Luiz Capitulino
From: Michael Roth In some cases an input visitor might bail out on filling out a struct for various reasons, such as missing fields when running in strict mode. In the case of a QAPI Union type, this may lead to cases where the .kind field which encodes the union type is uninitialized. Subsequen

[Qemu-devel] [PULL 06/11] block: Specify -drive legacy option aliases in array

2014-09-26 Thread Kevin Wolf
Instead of a series of qemu_opt_rename() calls, use an array that contains all of the renames and call qemu_opt_rename() in a loop. This will keep the code readable even when we add an error return to qemu_opt_rename(). Signed-off-by: Kevin Wolf Reviewed-by: Benoît Canet Reviewed-by: Markus Armb

[Qemu-devel] [PULL 05/11] block: Improve message for device name clashing with node name

2014-09-26 Thread Kevin Wolf
From: Markus Armbruster Suggested-by: Benoit Canet Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block.c| 3 ++- tests/qemu-iotests/087.out | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff -

[Qemu-devel] [PULL 10/11] block: Validate node-name

2014-09-26 Thread Kevin Wolf
The device_name of a BlockDriverState is currently checked because it is always used as a QemuOpts ID and qemu_opts_create() checks whether such IDs are wellformed. node-name is supposed to share the same namespace, but it isn't checked currently. This patch adds explicit checks both for device_na

[Qemu-devel] [PULL 07/11] block: Catch simultaneous usage of options and their aliases

2014-09-26 Thread Kevin Wolf
While thinking about precedence of conflicting block device options from different sources, I noticed that you can specify both an option and its legacy alias at the same time (e.g. readonly=on,read-only=off). Rather than specifying the order of precedence, we should simply forbid such combinations

[Qemu-devel] [PULL 09/11] vpc: fix beX_to_cpu() and cpu_to_beX() confusion

2014-09-26 Thread Kevin Wolf
From: Stefan Hajnoczi The beX_to_cpu() and cpu_to_beX() functions perform the same operation - they do a byteswap if the host CPU endianness is little-endian or a nothing otherwise. The point of two names for the same operation is that it documents which direction the data is being converted. T

[Qemu-devel] [PULL 02/11] blockdev: Disentangle BlockDriverState and DriveInfo creation

2014-09-26 Thread Kevin Wolf
From: Markus Armbruster blockdev_init() mixes up BlockDriverState and DriveInfo initialization Finish the BlockDriverState job before starting to mess with DriveInfo. Easier on the eyes. Signed-off-by: Markus Armbruster Reviewed-by: Max Reitz Reviewed-by: Benoît Canet Signed-off-by: Kevin Wo

[Qemu-devel] [PULL 01/11] blkdebug: show an error for invalid event names

2014-09-26 Thread Kevin Wolf
From: Stefan Hajnoczi It is easy to typo a blkdebug configuration and waste a lot of time figuring out why no rules are matching. Push the Error** down into add_rule() so we can report an error when the event name is invalid. Signed-off-by: Stefan Hajnoczi Reviewed-by: Gonglei Signed-off-by:

[Qemu-devel] [PULL 03/11] block: Keep DriveInfo alive until BlockDriverState dies

2014-09-26 Thread Kevin Wolf
From: Markus Armbruster If the BDS's refcnt > 0, drive_del() destroys the DriveInfo, but not the BDS. This can happen in three places: * Device model destruction during unplug: blockdev_auto_del() * Xen IDE unplug: pci_piix3_xen_ide_unplug() * drive_del command when no device model is attache

[Qemu-devel] [PULL 04/11] qemu-nbd: Destroy the BlockDriverState properly

2014-09-26 Thread Kevin Wolf
From: Markus Armbruster Match the bdrv_new() with a bdrv_unref(), just to be tidy. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- qemu-nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index de9963f..fa60338 100644 --- a/qemu-nbd

[Qemu-devel] [PULL 00/11] Block patches

2014-09-26 Thread Kevin Wolf
The following changes since commit 4f2280b2190e39aa6761cc8188626ed9aad350c1: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into staging (2014-09-24 13:45:13 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

Re: [Qemu-devel] [PATCH v5] Add HMP command "info memory-devices"

2014-09-26 Thread Luiz Capitulino
On Tue, 23 Sep 2014 13:35:19 +0800 Zhu Guihua wrote: > Provides HMP equivalent of QMP query-memory-devices command. > > Signed-off-by: Zhu Guihua Applied to the qmp branch, thanks. > --- > Changes since v4: > - enclose ID in double quotes. > > Changes since v3: > - optimize the time to print

Re: [Qemu-devel] [PATCH] qemu-socket: Eliminate silly QERR_ macros

2014-09-26 Thread Luiz Capitulino
On Thu, 25 Sep 2014 08:49:31 +0200 Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > They're used with error_set() and qerror_report(), and expand into the > first *two* arguments. This trickiness has become pointless. Clean > up. > > Signed-off

[Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-26 Thread Don Slutz
This adds synchronisation of the vcpu registers between Xen and QEMU. Signed-off-by: Don Slutz --- hw/misc/vmport.c | 32 include/hw/xen/xen.h | 6 ++ vl.c | 1 + xen-hvm.c| 38 -- 4 files

[Qemu-devel] [PATCH 0/1] Add support for Xen access to vmport

2014-09-26 Thread Don Slutz
Note: to use this with Xen either a version of: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation or >From f70663d9fb86914144ba340b6186cb1e67ac6eec Mon Sep 17 00:00:00 2001 From: Don Slutz Date: Fri, 26 Sep 2014 08:11:39 -0400 Subject: [PATCH 1/2] hack: force

[Qemu-devel] [PATCH v3 0/4] A number of Travis CI tweaks

2014-09-26 Thread Alex Bennée
Hi, Only one change in this set to ensure the second patch bisects cleanly. I've also added the additional Reviewed-by tags. Please apply to the trivial tree. Alex Bennée (4): .travis.yml: add more linux-user to the build matrix .travis.yml: make the make slightly more parallel .travis.yml

[Qemu-devel] [PATCH v3 1/4] .travis.yml: add more linux-user to the build matrix

2014-09-26 Thread Alex Bennée
At the same time I've grouped the $ARCH-linux-user and $ARCH-softmmu builds together (hoping FS cache helps) and grouped all $ARCH-softmmu only builds into one target. This reduces the build matrix slightly which will hopefully help with build times. Signed-off-by: Alex Bennée Reviewed-by: Alexan

[Qemu-devel] [PATCH v3 2/4] .travis.yml: make the make slightly more parallel

2014-09-26 Thread Alex Bennée
The Travis VMs have 1.5 cores so we might as well make some use of the paralellism. Signed-off-by: Alex Bennée Reviewed-by: Alexander Graf Reviewed-by: Brian Jackson --- v3 - fix escaping of ${TEST_CMD} diff --git a/.travis.yml b/.travis.yml index 72cfc9f..57cb95e 100644 --- a/.travis.yml +

[Qemu-devel] [PATCH v3 4/4] .travis.yml: remove "make check" from main matrix

2014-09-26 Thread Alex Bennée
There are problems with unreliability in "make check" which still need to be tracked down. As the tests are broadly the same for all targets if added one explicit target to the matrix to run it. However this does build all softmmu targets to ensure they at least "run" Signed-off-by: Alex Bennée R

[Qemu-devel] [PATCH v3 3/4] .travis.yml: pre-seed sub-modules for speed

2014-09-26 Thread Alex Bennée
A significant portion of the build time is spent initialising all the sub-modules we use in the source tree. Often this is almost as long as the build itself. By pre-seeding the .git/modules tree this will hopefully improve things. Signed-off-by: Alex Bennée Reviewed-by: Alexander Graf Reviewed-

[Qemu-devel] [PULL 07/12] qapi: Consistent whitespace in tests/Makefile

2014-09-26 Thread Michael Tokarev
From: Eric Blake tests/Makefile had a mix of TAB vs. 8-space indentation; given that it is a Makefile, TAB is more idiomatic even though in these particular cases the choice of whitespace didn't matter. Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --

[Qemu-devel] [Bug 1317603] Re: qemu-system-ppc does not terminate on VM exit

2014-09-26 Thread joh...@servergy.com
I am no longer working on this project, -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1317603 Title: qemu-system-ppc does not terminate on VM exit Status in QEMU: New Status in “qemu” package in

[Qemu-devel] [PULL 06/12] vmxcap: Update according to SDM of September 2014

2014-09-26 Thread Michael Tokarev
From: Adrian-Ken Rueegsegger This adds reporting of RDSEED exiting and XSAVES/XRSTORS #UD and fixes the range of VMCS revision as well as some typos. Signed-off-by: Adrian-Ken Rueegsegger Signed-off-by: Michael Tokarev --- scripts/kvm/vmxcap | 10 ++ 1 file changed, 6 insertions(+),

[Qemu-devel] [PULL 09/12] qapi: Update docs given recent event, spacing fixes

2014-09-26 Thread Michael Tokarev
From: Eric Blake Commit 21cd70d added event support but didn't document what the generated code looks like. Commit 05dfb26 removed some unwanted spaces in the generated code, but didn't reflect those changes into the documentation. Finally, the docs start with a big disclaimer about QMP not usi

[Qemu-devel] [PULL 10/12] os-posix: change tab to space avoid violating coding style

2014-09-26 Thread Michael Tokarev
From: Gonglei Cc: Eric Blake Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- os-posix.c | 79 1 file changed, 42 insertions(+), 37 deletions(-) diff --git a/os-posix.c b/os-posix.c index cb2a

[Qemu-devel] [PULL 05/12] .travis.yml: remove "make check" from main matrix

2014-09-26 Thread Michael Tokarev
From: Alex Bennée There are problems with unreliability in "make check" which still need to be tracked down. As the tests are broadly the same for all targets if added one explicit target to the matrix to run it. However this does build all softmmu targets to ensure they at least "run" Signed-of

[Qemu-devel] [PULL 12/12] os-posix: report error message when lock file failed

2014-09-26 Thread Michael Tokarev
From: Gonglei It will cause that create vm failed When manager tool is killed forcibly (kill -9 libvirtd_pid), the file not was unlink, and unlock. It's better that report the error message for users. Signed-off-by: Huangweidong Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Signed-off-by:

[Qemu-devel] [PULL 11/12] os-posix: remove confused errno

2014-09-26 Thread Michael Tokarev
From: Gonglei If we get inside the 'else if (status == 1)' conditional, then we know that read() succeeded, and therefore errno is unspecified. Printing strerror(errno) on a random value is not helpful. Cc: Eric Blake Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Signed-off-by: Michael To

[Qemu-devel] [PULL 04/12] .travis.yml: pre-seed sub-modules for speed

2014-09-26 Thread Michael Tokarev
From: Alex Bennée A significant portion of the build time is spent initialising all the sub-modules we use in the source tree. Often this is almost as long as the build itself. By pre-seeding the .git/modules tree this will hopefully improve things. Signed-off-by: Alex Bennée Reviewed-by: Alexa

[Qemu-devel] [PULL 08/12] qapi: Ignore files created during make check

2014-09-26 Thread Michael Tokarev
From: Eric Blake After an in-tree build and run of 'make check-{qapi-schema,unit}', I noticed some leftover files. Signed-off-by: Eric Blake Reviewed-by: Wenchao Xia Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- tests/.gitignore |3 +++ 1 file changed, 3 insertions(+

[Qemu-devel] [PULL 02/12] .travis.yml: add more linux-user to the build matrix

2014-09-26 Thread Michael Tokarev
From: Alex Bennée At the same time I've grouped the $ARCH-linux-user and $ARCH-softmmu builds together (hoping FS cache helps) and grouped all $ARCH-softmmu only builds into one target. This reduces the build matrix slightly which will hopefully help with build times. Signed-off-by: Alex Bennée

[Qemu-devel] [PULL 01/12] tests: avoid running duplicate qom-tests

2014-09-26 Thread Michael Tokarev
From: Michael Roth Since 3687d532 we've been unconditionally adding qom-test to our qtests for every arch. However, some archs inherit their tests from Makefile variables for other archs, such as i386/x86_64, microblaze/microblazeel, and xtensa/xtensaeb. Since these are evaluated in a lazy manner

[Qemu-devel] [PULL 03/12] .travis.yml: make the make slightly more parallel

2014-09-26 Thread Michael Tokarev
From: Alex Bennée The Travis VMs have 1.5 cores so we might as well make some use of the paralellism. Signed-off-by: Alex Bennée Reviewed-by: Alexander Graf Reviewed-by: Brian Jackson Signed-off-by: Michael Tokarev --- .travis.yml |5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 00/12] Trivial patches for 2014-09-26

2014-09-26 Thread Michael Tokarev
Here goes another trivial-patches pull request. Cleanups, travis.yml changes, coding style changes and a little bugfix for stable (avoiding running qom test twice). Please consider applying/pulling. Thanks, /mjt The following changes since commit da1c4ec88ad50c2b73d5fe960c373693f7337cc9: Me

Re: [Qemu-devel] [PATCH v1 3/3] monitor: add del completion for peripheral device

2014-09-26 Thread Luiz Capitulino
On Fri, 26 Sep 2014 13:25:45 -0400 Luiz Capitulino wrote: > On Thu, 18 Sep 2014 15:53:21 +0800 > Zhu Guihua wrote: > > > Add peripheral_device_del_completion() to let peripheral device del > > completion > > be possible. > > > > Signed-off-by: Zhu Guihua > > --- > > monitor.c | 24 +

Re: [Qemu-devel] [PATCH] qemu-socket: Polish errors for connect() and listen() failure

2014-09-26 Thread Luiz Capitulino
On Fri, 19 Sep 2014 09:27:04 +0200 Markus Armbruster wrote: > connect() doesn't "connect to socket", it connects a socket to an > address and, if it's of type SOCK_STREAM, initiates a connection. > Scratch "to". > > listen() does "set socket to listening mode", but it sounds awkward. > Change to

Re: [Qemu-devel] [PATCH v1 3/3] monitor: add del completion for peripheral device

2014-09-26 Thread Luiz Capitulino
On Thu, 18 Sep 2014 15:53:21 +0800 Zhu Guihua wrote: > Add peripheral_device_del_completion() to let peripheral device del completion > be possible. > > Signed-off-by: Zhu Guihua > --- > monitor.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/monitor.c b/m

Re: [Qemu-devel] [PATCH v2 2/2] block/raw-posix: use seek_hole ahead of fiemap

2014-09-26 Thread Eric Blake
On 09/25/2014 05:14 PM, Tony Breeds wrote: > try_fiemap() uses FIEMAP_FLAG_SYNC which has a significant performance > impact. > > Prefer seek_hole() over fiemap() to avoid this impact where possible. > seek_hole is more widely used and, arguably, has potential to be > optimised in the kernel. It

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/3] os-posix: improve the error message printing

2014-09-26 Thread Michael Tokarev
26.09.2014 12:14, arei.gong...@huawei.com wrote: > From: Gonglei > > The patches mainly improve the error message printing. > And adjust coding style of os-posix.c. > > Daemonize the QEMU process after initialization, QEMU will not detach from > standard IO until it is ready to receive connectio

Re: [Qemu-devel] [Qemu-trivial] [PATCH v5a 0/3] trivial qapi cleanups

2014-09-26 Thread Michael Tokarev
26.09.2014 19:20, Eric Blake wrote: > This is split out from [PATCH v4 00/19]: drop qapi nested structs > in order to get the trivial stuff in now, rather than holding it > up for what may be another month while I address the larger findings > against the rest of that series. Applied all 3 to -tri

Re: [Qemu-devel] [PULL 00/11] KVM (and more) patches for 2014-09-26

2014-09-26 Thread Peter Maydell
On 26 September 2014 15:37, Paolo Bonzini wrote: > The following changes since commit cc35a44cf7b522b1fd0b786562b7de4b881c41b0: > > Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging > (2014-09-15 19:44:34 +0100) > > are available in the git repository at: > > git://gi

Re: [Qemu-devel] [Qemu-trivial] Ping [PATCH] vmxcap: Update according to SDM of September 2014

2014-09-26 Thread Michael Tokarev
25.09.2014 21:07, Adrian-Ken Rueegsegger пишет: > As the patch makes simple changes to the vmxcap script that has no > maintainer listed in the MAINTAINERS file it may be a candidate for the > trivial patches team. Thus adding qemu-trivial as CC. > > Link to patchwork: > > http://patchwork.ozlabs

Re: [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in try_fiemap

2014-09-26 Thread Eric Blake
On 09/25/2014 05:14 PM, Tony Breeds wrote: > Using fiemap without FIEMAP_FLAG_SYNC is a known corrupter. > > Add the FIEMAP_FLAG_SYNC flag to the FS_IOC_FIEMAP ioctl. This has > the downside of significantly reducing performance. > > Reported-By: Michael Steffens > Signed-off-by: Tony Breeds >

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 0/4] A number of Travis CI tweaks

2014-09-26 Thread Michael Tokarev
24.09.2014 14:13, Alex Bennée wrote: > Hi, > > The patches I posted last week have been reviewed and I've given them > a good test on my tree. My last test failed but only because master > has introduced a regression. This was found by the tests in master but > missed due to the noise of GTester h

Re: [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in try_fiemap

2014-09-26 Thread Max Reitz
On 26.09.2014 01:14, Tony Breeds wrote: Using fiemap without FIEMAP_FLAG_SYNC is a known corrupter. Add the FIEMAP_FLAG_SYNC flag to the FS_IOC_FIEMAP ioctl. This has the downside of significantly reducing performance. Reported-By: Michael Steffens Signed-off-by: Tony Breeds Cc: Kevin Wolf

Re: [Qemu-devel] [PATCH v2 2/2] block/raw-posix: use seek_hole ahead of fiemap

2014-09-26 Thread Max Reitz
On 26.09.2014 01:14, Tony Breeds wrote: try_fiemap() uses FIEMAP_FLAG_SYNC which has a significant performance impact. Prefer seek_hole() over fiemap() to avoid this impact where possible. seek_hole is more widely used and, arguably, has potential to be optimised in the kernel. Reported-By: Mic

Re: [Qemu-devel] [PATCH v2 13/17] accel: Rename 'init' method to 'init_machine'

2014-09-26 Thread Eduardo Habkost
On Fri, Sep 26, 2014 at 05:09:06PM +0200, Paolo Bonzini wrote: > Il 29/08/2014 22:31, Eduardo Habkost ha scritto: > > This makes explicit the fact that the method is for machine > > initialization, not just for accelerator object initialization. > > No, it is not for machine initialization. It ju

  1   2   3   4   >