Re: [Qemu-devel] [PATCH v3 02/23] block: New BlockBackend

2014-09-21 Thread Markus Armbruster
Max Reitz writes: > On 16.09.2014 20:12, Markus Armbruster wrote: >> A block device consists of a frontend device model and a backend. >> >> A block backend has a tree of block drivers doing the actual work. >> The tree is managed by the block layer. >> >> We currently use a single abstraction Bl

Re: [Qemu-devel] [PATCH] qom: suppress conscan warning of returning null point

2014-09-21 Thread Markus Armbruster
Paolo Bonzini writes: > Il 20/09/2014 02:11, Amos Kong ha scritto: >> Conscan complains about g_malloc0() and malloc() return null. s/Conscan/Coverity/, both here and in subject. >> >> Error: NULL_RETURNS (CWE-476): >> qemu-kvm/qom/object.c:239: returned_null: Function >> "g_malloc0(gsize)

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1] vl: Fix possible freed memory accessing

2014-09-21 Thread Markus Armbruster
Michael Tokarev writes: > Applied to -trivial, thank you! Makes my 'hmp: Remove "info pcmcia"' conflict. Either revert this one before applying mine, or resolve the conflict and drop the paragraph about the bug from my commit message.

Re: [Qemu-devel] [RFC PATCH v2 09/10] virtio-scsi-dataplane: Code to run virtio-scsi on iothread

2014-09-21 Thread Fam Zheng
On Fri, 09/19 11:29, Paolo Bonzini wrote: > Il 06/08/2014 07:35, Fam Zheng ha scritto: > > +void virtio_scsi_dataplane_start(VirtIOSCSICommon *s) > > +{ > > +int i; > > +int rc; > > +BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(s))); > > +VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(

Re: [Qemu-devel] [RFC PATCH v2 09/10] virtio-scsi-dataplane: Code to run virtio-scsi on iothread

2014-09-21 Thread Fam Zheng
On Fri, 09/19 11:29, Paolo Bonzini wrote: > Il 06/08/2014 07:35, Fam Zheng ha scritto: > > diff --git a/include/hw/virtio/virtio-scsi.h > > b/include/hw/virtio/virtio-scsi.h > > index 6f92c29..b9f2197 100644 > > --- a/include/hw/virtio/virtio-scsi.h > > +++ b/include/hw/virtio/virtio-scsi.h > > @@

[Qemu-devel] [Bug 1101210] Re: qemu 1.4.2: usb keyboard not fully working

2014-09-21 Thread Bjoern Kerler
Affects as well Win8.1 as Host System and Debian as Client, tested with latest qemu 2.1.50 (fetched from git). Debian : 3.2.0-4-vexpress #1 SMP Debian 3.2.57-3 armv71 with startup parameters : h:\qemu\test\qemu-system-armw" -M vexpress-a9 -kernel vmlinuz-3.2.0-4-vexpress -initrd initrd.img-3.2.

Re: [Qemu-devel] [PATCH] virtio-balloon: Fix ballooning not working correctly when hotplug memory

2014-09-21 Thread zhanghailiang
Hi Igor, Thanks for your reviewing... On Mon, 15 Sep 2014 20:29:38 +0800 zhanghailiang wrote: When do memory balloon, it references the ram_size as the real ram size of VM, But here ram_size is not include the hotplugged memory, and the result will be confused. Steps to reproduce: (1)Start

Re: [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount

2014-09-21 Thread jun muzi
Thanks. I will give a new version in v3 of qcow2 shrink. Jun Li 2014-9-3 上午1:12于 "Greg Kurz" 写道: > On Mon, 1 Sep 2014 18:52:48 +0800 > Jun Li wrote: > > > When every item of refcount block is NULL, free refcount block and reset > the > > corresponding item of refcount table with NULL. > > > > S

Re: [Qemu-devel] [PATCH 1/2] serial: reset state at startup

2014-09-21 Thread Chen, Tiejun
On 2014/9/19 20:57, Paolo Bonzini wrote: Il 19/09/2014 11:17, Chen, Tiejun ha scritto: On 2014/9/19 16:54, Paolo Bonzini wrote: When a serial port is started, its initial state is all zero. Make it consistent with reset state instead. Signed-off-by: Paolo Bonzini --- hw/char/serial.c | 1

[Qemu-devel] [PATCH 0/6] Add reconnect capability for client sockets

2014-09-21 Thread minyard
I believe this fixes all the issues identified by the reviewers, and also avoids leaking a few data items. I also added some fixes for things that seemed sub-optimal. The biggest was that there was no way to tell from the monitor whether a socket was connected or not. Patch 4 sets the filename t

[Qemu-devel] [PATCH 6/6] qemu-char: Print the remote and local addresses for a socket

2014-09-21 Thread minyard
From: Corey Minyard It seems that it might be a good idea to know what is at the remote end of a socket for tracking down issues. So add that to the socket filename. Signed-off-by: Corey Minyard --- qemu-char.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-)

[Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected

2014-09-21 Thread minyard
From: Corey Minyard This way we can tell if the socket is connected or not. It also splits the string conversions out into separate functions to make this more convenient. Signed-off-by: Corey Minyard --- qemu-char.c | 102 1 file c

[Qemu-devel] [PATCH 2/6] qemu-char: Rework qemu_chr_open_socket() for reconnect

2014-09-21 Thread minyard
From: Corey Minyard Move all socket configuration to qmp_chardev_open_socket(). qemu_chr_open_socket_fd() just opens the socket. This is getting ready for the reconnect code, which will call open_sock_fd() on a reconnect attempt. Signed-off-by: Corey Minyard --- qemu-char.c | 123

[Qemu-devel] [PATCH 3/6] qemu-char: Move some items into TCPCharDriver

2014-09-21 Thread minyard
From: Corey Minyard This keeps them from having to be passed around and makes them available for later functions, like printing and reconnecting. Signed-off-by: Corey Minyard --- qemu-char.c | 65 - 1 file changed, 51 insertions(+), 1

[Qemu-devel] [PATCH 1/6] qemu-char: Make the filename size for a chardev a #define

2014-09-21 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard --- qemu-char.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 2a3cb9f..39fb9e4 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -84,6 +84,7 @@ #define READ_BUF_LEN 4096 #defi

[Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-21 Thread minyard
From: Corey Minyard Adds a "reconnect" option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after the given number of seconds. Signed-off-by: Corey Minyard --- qapi-sc

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-21 Thread Laszlo Ersek
On 09/22/14 00:10, Gabriel L. Somlo wrote: > dmsg_bios.log: ACPI: PCI Interrupt Link [LNKA] (IRQs 5 *10 11) > dmsg_bios.log: ACPI: PCI Interrupt Link [LNKB] (IRQs 5 *10 11) > dmsg_bios.log: ACPI: PCI Interrupt Link [LNKC] (IRQs 5 10 *11) > dmsg_bios.log: ACPI: PCI Interrupt Link [LNKD] (IRQs 5 10

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-21 Thread Gabriel L. Somlo
On Mon, Sep 15, 2014 at 08:02:04PM +0200, Laszlo Ersek wrote: > Here's an example from my i440fx Fedora 20 VM. > > (1) The dmesg says first > > ACPI: PCI Interrupt Link [LNKA] (IRQs 5 10 *11) > ACPI: PCI Interrupt Link [LNKB] (IRQs 5 10 *11) > ACPI: PCI Interrupt Link [LNKC] (IRQs 5 *10 11)

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-21 Thread Gabriel L. Somlo
On Tue, Sep 16, 2014 at 10:15:20AM +0200, Gerd Hoffmann wrote: > Hi, > > > OK, so I forgot to articulate that with the above patch, I'm seeing > > *both* uhci2 and uhci3, but not uhci1. Basically, if uhciX has an > > irq_pin less than 2, it won't show up in OSX if booted with ovmf. > > We're no

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] arch_init: Setting QEMU_ARCH enum straight

2014-09-21 Thread Michael Tokarev
21.09.2014 15:07, Bastian Koppelmann wrote: > Every QEMU_ARCH is now in (1 << n) notation, instead of a mixture of decimal > and hexadecimal. Applied to -trivial. ALso changed QEMU_ARCH_ALPHA from 1 to (1 << 0) for consistency with all others. Thank you! /mjt > enum { > QEMU_ARCH_ALL =

[Qemu-devel] [PATCH v4] Support vhd type VHD_DIFFERENCING

2014-09-21 Thread Xiaodong Gong
Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu can't read snapshot volume of vhd, and can't support other storage features of vhd file. This patch add read parent information in function "vpc_open", read bitmap in "vpc_read", and change bitmap in "vpc_write". Signed-off-by: Xi

[Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-21 Thread Alex Bligh
Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding --disable-pc-1-0-qemu-kvm, defaulting to disabled. Rename machine type pc-1.0 to pc-1.0-qemu-git. Make pc-1.0 machine type an alias of either pc-1.0-qemu-kvm or pc-1.0-qemu-git depending on the value of the config option. Sign

[Qemu-devel] [PATCH v3 1/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-09-21 Thread Alex Bligh
Add a machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm version 1.0. Signed-off-by: Alex Bligh --- hw/acpi/piix4.c | 47 +-- hw/i386/pc_piix.c | 30 ++ hw/timer/i8254_common.c | 10

[Qemu-devel] [PATCH v3 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-09-21 Thread Alex Bligh
This patch series adds inbound migrate capability from qemu-kvm version 1.0. The main ideas are those set out in Cole Robinson's patch here: http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0001-Fix-migration-from-qemu-kvm.patch?h=f20 however, rather than patching statically (and breaking inbound m

[Qemu-devel] [PATCH v2] arch_init: Setting QEMU_ARCH enum straight

2014-09-21 Thread Bastian Koppelmann
Every QEMU_ARCH is now in (1 << n) notation, instead of a mixture of decimal and hexadecimal. Signed-off-by: Bastian Koppelmann --- v1 -> v2: - As Michael suggested it is now in (1 << n) notation. include/sysemu/arch_init.h | 32 1 file changed, 16 insertio

Re: [Qemu-devel] [RFC v2 2/3] Add units-per-idebus property

2014-09-21 Thread Marcel Apfelbaum
On Fri, 2014-09-19 at 11:39 +0200, Markus Armbruster wrote: > John Snow writes: > > > Signed-off-by: John Snow > > --- > > blockdev.c| 10 -- > > device-hotplug.c | 2 +- > > hw/i386/pc_q35.c | 3 ++- > > include/hw/boards.h | 3 ++- > > includ