[Qemu-devel] [PATCH 5/5] tests: add usb hcds hotplugging qtest

2014-09-15 Thread Gerd Hoffmann
From: Gonglei Because of we now support usb hcds hotplugging, and collect all hcds hotplugging tests into one file for code sharing. Signed-off-by: Gonglei Signed-off-by: Gerd Hoffmann --- tests/Makefile | 2 ++ tests/usb-hcd-hotplug-test.c | 86

[Qemu-devel] [PATCH 2/5] usb: tag standalone uhci as hotpluggable

2014-09-15 Thread Gerd Hoffmann
uhci hostadapters in companion setups can't be hotplugged. So leave hotplug disabled for all ich9 variants (which are already tagged with unplug = true in the info struct). For the other variants we'll enable hotplug and remove the companion setup properties. Signed-off-by: Gerd Hoffmann --- h

[Qemu-devel] [PATCH 1/5] usb: tag xhci as hotpluggable

2014-09-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 73ced1f..c556367 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -3874,7 +3874,6 @@ static void xhci_class_init(ObjectClass *klass, void *da

[Qemu-devel] [PATCH 0/5] usb: make host adapters hot-pluggable

2014-09-15 Thread Gerd Hoffmann
Hi, This series the usb host adapters hot-pluggable. Problem is that we can NOT hotplug host adapters which are part of a companion setup. The way this is tackled now is to split the usb host adapter variants into two groups: * All ich9-* variants (both uhci and ehci) support companion cont

[Qemu-devel] [PATCH 3/5] usb: tag standalone ehci as hotpluggable

2014-09-15 Thread Gerd Hoffmann
Add a flag to EHCIPCIInfo saying whenever the controller supports companions or not. Make sure we only allow registering companions for ehci versions supporting that. Enable pci hotplug for the ehci variants not supporting companions. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci-pci.c | 12

[Qemu-devel] [PATCH 4/5] [wip] usb: tag ohci as hotpluggable

2014-09-15 Thread Gerd Hoffmann
FIXME: turn off hotplug for companions Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ohci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 83bec34..8113b5a 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2116,7 +2116,6 @@ static void ohci_

[Qemu-devel] [PULL 1/2] sdl2: drop sdl_zoom.h

2014-09-15 Thread Gerd Hoffmann
It isn't used. Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index fcac87b..1ad74ba 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -35,7 +35,6 @@ #include "ui/console.h" #include "ui/input.h" #include "sysemu/sysemu.h" -#include

[Qemu-devel] [PULL 0/2] sdl patch queue

2014-09-15 Thread Gerd Hoffmann
Hi, Two minor sdl2 fixes. please pull, Gerd The following changes since commit cc35a44cf7b522b1fd0b786562b7de4b881c41b0: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-09-15 19:44:34 +0100) are available in the git repository at: git://git.kraxel.or

[Qemu-devel] [PULL 2/2] sdl2: keymap fixups

2014-09-15 Thread Gerd Hoffmann
Make a few keys works correctly in SDL2. Signed-off-by: Gerd Hoffmann --- ui/sdl2-keymap.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/sdl2-keymap.h b/ui/sdl2-keymap.h index 5a12f45..cbedaa4 100644 --- a/ui/sdl2-keymap.h +++ b/ui/sdl2-keymap.h @@ -105,9 +105,10

[Qemu-devel] vhost-user:how to notify the guest?

2014-09-15 Thread Linhaifeng
Hi, I write the data to the rx-ring and write the fd to notify the guest but there is no interrupts in the guest. my notify code: uint64_t kick_it = 1; write(vring[0]->kickfd, &kick_it, sizeof(kick_it)); cat /proc/interrupts in the guest: 41: 0 PCI-MSI-EDGEvirtio0-input 42: 0

[Qemu-devel] [Bug 1247122] Re: kernel guest 3.10.6 boot failure at sha_transform

2014-09-15 Thread Christoph Eck
With Qemu 2.0.0 it works ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1247122 Title: kernel guest 3.10.6 boot failure at sha_transform Status in

[Qemu-devel] [PULL 0/1] spice: call qemu_spice_set_passwd() during init

2014-09-15 Thread Gerd Hoffmann
Hi, Spice patch queue, with a single patch this time. please pull, Gerd The following changes since commit cc35a44cf7b522b1fd0b786562b7de4b881c41b0: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-09-15 19:44:34 +0100) are available in the git repository

[Qemu-devel] [PULL 1/1] spice: call qemu_spice_set_passwd() during init

2014-09-15 Thread Gerd Hoffmann
From: Marc-André Lureau Don't call SPICE API directly to set password given in command line, but use the internal API, saving password for later calls. This solves losing password when changing expiration in qemu monitor. https://bugzilla.redhat.com/show_bug.cgi?id=1138639 Signed-off-by: Gerd

Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-15 Thread Markus Armbruster
Cc'ing Gerd for additional chardev expertise. Zifei Tong writes: > After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP > in tcp_chr_read for tcp chardev), the connection is disconnected when in > G_IO_HUP condition. > > However, it's possible that the channel is in G_IO_IN con

[Qemu-devel] [PATCH] ac97: register reset via qom

2014-09-15 Thread Gerd Hoffmann
So it gets properly unregistered on hot-unplug. Signed-off-by: Gerd Hoffmann --- hw/audio/ac97.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c index 0e22bb9..111ec0e 100644 --- a/hw/audio/ac97.c +++ b/hw/audio/ac97.c @@ -1321,9 +132

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread TeLeMan
I suggest using cpu_set_fpuc() like cpu_set_mxcsr(). On Tue, Sep 16, 2014 at 1:51 PM, TeLeMan wrote: > On Tue, Sep 16, 2014 at 1:42 PM, TeLeMan wrote: >> update_fp_status() should be used after all of env->fpuc changes : >> helper_fldcw(), helper_fninit(), helper_fldenv() >> ,helper_fxrstor(), h

[Qemu-devel] [PATCH v2 0/3] Fix confused output for alias properties

2014-09-15 Thread arei.gonglei
From: Gonglei At present, people have no way to know they should have a specific format for alias properties. Example: before output: virtio-blk-pci.physical_block_size=uint16 virtio-blk-pci.logical_block_size=uint16 virtio-blk-pci.drive=str after output applied this patch series: virtio-bl

[Qemu-devel] [PATCH v2 1/3] qom: add error handler for object alias property

2014-09-15 Thread arei.gonglei
From: Gonglei object_property_add_alias() is called at some places at present. And its parameter errp may not NULL, such as object_property_add_alias(obj, "iothread", OBJECT(&dev->vdev),"iothread", &error_abort); This patch add error handler for security. Cc: Stefa

[Qemu-devel] [PATCH v2 3/3] qmp: print real legacy_name for alias property

2014-09-15 Thread arei.gonglei
From: Gonglei In this way, we can get the real legacy_name for alias properties, and avoide confusing people because of property type. People have no way to know they should have a specific format. Note: we should also consider the scenario that source and target names are different because obje

[Qemu-devel] [PATCH v2 2/3] qom: add AliasProperty struct poniter for alias property in ObjectProperty

2014-09-15 Thread arei.gonglei
From: Gonglei In this way, we can use target object and get its qdev property legacy_name etc. Cc: Stefan Hajnoczi Cc: Paolo Bonzini Cc: Michael S. Tsirkin Signed-off-by: Gonglei --- include/qom/object.h | 8 qom/object.c | 7 ++- 2 files changed, 10 insertions(+), 5 de

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread TeLeMan
On Tue, Sep 16, 2014 at 1:42 PM, TeLeMan wrote: > update_fp_status() should be used after all of env->fpuc changes : > helper_fldcw(), helper_fninit(), helper_fldenv() > ,helper_fxrstor(), helper_fsave(), x86_cpu_reset(), cpu_post_load(). missing one: x86_cpu_gdb_write_register(). > > On Mon, Se

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread TeLeMan
update_fp_status() should be used after all of env->fpuc changes : helper_fldcw(), helper_fninit(), helper_fldenv() ,helper_fxrstor(), helper_fsave(), x86_cpu_reset(), cpu_post_load(). On Mon, Sep 15, 2014 at 7:17 PM, Pavel Dovgalyuk wrote: > This patch adds calls to update_fp_status() function f

Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-15 Thread Zifei Tong
Friendly ping. Also CC to qemu-trivial. On Sun, Sep 7, 2014 at 8:24 PM, Zifei Tong wrote: > After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP > in tcp_chr_read for tcp chardev), the connection is disconnected when in > G_IO_HUP condition. > > However, it's possible that the

Re: [Qemu-devel] [PATCH] gdbstub: Allow target CPUs to specify watchpoint STOP_BEFORE_ACCESS flag

2014-09-15 Thread Max Filippov
On Mon, Sep 15, 2014 at 9:15 PM, Peter Maydell wrote: > On 15 September 2014 20:59, Max Filippov wrote: >> I've tested xtensa part and have noticed no difference with or without >> this patch: >> gdb connected to qemu gdbstub always stops right after the watched >> instruction. >> I guess that w

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-09-15 Thread Michael Tokarev
16.09.2014 05:40, Li Liu wrote: > Thanks four your comments! Can you help do this when applying > incidentally? Or I will resend it again? http://git.corpit.ru/?p=qemu.git;a=commit;h=6dbc7173f25747b2ed9f3f322ac9697feffe4bf7 -- applied yesteday :) Thanks, /mjt

Re: [Qemu-devel] [PATCH] gdbstub: Allow target CPUs to specify watchpoint STOP_BEFORE_ACCESS flag

2014-09-15 Thread Peter Maydell
On 15 September 2014 20:59, Max Filippov wrote: > I've tested xtensa part and have noticed no difference with or without > this patch: > gdb connected to qemu gdbstub always stops right after the watched > instruction. > I guess that without this patch I should have seen gdb stopping not right >

Re: [Qemu-devel] [PATCH 06/23] qom: Add cpu_exec_interrupt hook

2014-09-15 Thread Max Filippov
On Sat, Sep 13, 2014 at 9:45 AM, Richard Henderson wrote: > Continuing the removal of ifdefs from cpu_exec. > > Cc: Andreas Färber > Signed-off-by: Richard Henderson > --- > cpu-exec.c| 14 +- > include/qom/cpu.h | 2 ++ > qom/cpu.c | 6 ++ > 3 files changed, 1

Re: [Qemu-devel] [PATCH 07/23] target-xtensa: Use cpu_exec_interrupt qom hook

2014-09-15 Thread Max Filippov
On Sat, Sep 13, 2014 at 9:45 AM, Richard Henderson wrote: > Cc: Max Filippov > Signed-off-by: Richard Henderson > --- > cpu-exec.c | 6 -- > target-xtensa/cpu-qom.h | 1 + > target-xtensa/cpu.c | 1 + > target-xtensa/helper.c | 10 ++ > 4 files changed, 12 inser

Re: [Qemu-devel] [PATCH 16/23] target-openrisc: Use cpu_exec_interrupt qom hook

2014-09-15 Thread Jia Liu
Hi Richard, Thank you! Tested-by: Jia Liu On Sat, Sep 13, 2014 at 9:45 AM, Richard Henderson wrote: > Cc: Jia Liu > Signed-off-by: Richard Henderson > --- > cpu-exec.c | 18 -- > target-openrisc/cpu.c | 1 + > target-openrisc/cpu.h | 1 + > t

Re: [Qemu-devel] [PATCH] gdbstub: Allow target CPUs to specify watchpoint STOP_BEFORE_ACCESS flag

2014-09-15 Thread Max Filippov
Hi Peter, On Fri, Sep 12, 2014 at 11:04 AM, Peter Maydell wrote: > GDB assumes that watchpoint set via the gdbstub remote protocol will > behave in the same way as hardware watchpoints for the target. In > particular, whether the CPU stops with the PC before or after the insn > which triggers the

Re: [Qemu-devel] [RESEND PATCH v3 2/8] acpi, ich9: Add memory hot unplug support for ich9.

2014-09-15 Thread Tang Chen
Hi Igor, On 09/04/2014 08:25 PM, Igor Mammedov wrote: On Wed, 27 Aug 2014 16:08:33 +0800 Tang Chen wrote: Implement ich9_pm_device_unplug_cb() to support memory hot-remove, calling acpi_memory_unplug_cb(). And itself will be called in ich9_device_unplug_cb(). Signed-off-by: Tang Chen ---

Re: [Qemu-devel] [RESEND PATCH v3 1/8] acpi, piix4: Add memory hot unplug support for piix4.

2014-09-15 Thread Tang Chen
Hi Igor, On 09/04/2014 08:15 PM, Igor Mammedov wrote: On Wed, 27 Aug 2014 16:08:32 +0800 Tang Chen wrote: From: Hu Tao Implement acpi_memory_unplug_cb(), sending an sci to guest to trigger memory hot-remove, and call it in piix4_device_unplug_cb(). Signed-off-by: Hu Tao Signed-off-by: Tan

Re: [Qemu-devel] [PATCH] vl: Print maxmem in hex format for error message

2014-09-15 Thread zhanghailiang
On 2014/9/16 10:42, Eric Blake wrote: On 09/15/2014 08:36 PM, zhanghailiang wrote: In error message, maxmem is printed in Dec but ram_size in Hex. It is better to print them in same format. Also use error_report instead of fprintf. Signed-off-by: zhanghailiang --- vl.c | 22 +++---

Re: [Qemu-devel] [Patch v1 5/8] target_arm: Parameterise the irq lines for armv7m_init

2014-09-15 Thread Alistair Francis
On Tue, Sep 16, 2014 at 1:23 AM, Peter Crosthwaite wrote: > On Sun, Sep 14, 2014 at 6:18 PM, Alistair Francis > wrote: >> This patch allows the board to specifiy the number of NVIC interrupt >> lines when using armv7m_init. >> >> Signed-off-by: Alistair Francis >> --- >> hw/arm/armv7m.c |

Re: [Qemu-devel] [PATCH] vl: Print maxmem in hex format for error message

2014-09-15 Thread Eric Blake
On 09/15/2014 08:36 PM, zhanghailiang wrote: > In error message, maxmem is printed in Dec but ram_size in Hex. > It is better to print them in same format. > Also use error_report instead of fprintf. > > Signed-off-by: zhanghailiang > --- > vl.c | 22 +++--- > 1 file changed, 11

Re: [Qemu-devel] [Patch v1 6/8] target_arm: Change the reset values based on the ELF entry

2014-09-15 Thread Alistair Francis
On Tue, Sep 16, 2014 at 1:27 AM, Peter Crosthwaite wrote: > On Sun, Sep 14, 2014 at 6:19 PM, Alistair Francis > wrote: >> The Netduino 2 machine won't run unless the reset_pc is based >> on the ELF entry point. >> >> Signed-off-by: Alistair Francis > > Looks based on one of my early attempts at

Re: [Qemu-devel] [Patch v1 4/8] target_arm: Remove memory region init from armv7m_init

2014-09-15 Thread Alistair Francis
On Tue, Sep 16, 2014 at 1:20 AM, Peter Crosthwaite wrote: > On Sun, Sep 14, 2014 at 6:18 PM, Alistair Francis > wrote: >> This patch moves the memory region init code from the >> armv7m_init function to the stellaris_init function >> >> Signed-off-by: Alistair Francis >> --- >> hw/arm/armv7m.c

[Qemu-devel] [PATCH] vl: Print maxmem in hex format for error message

2014-09-15 Thread zhanghailiang
In error message, maxmem is printed in Dec but ram_size in Hex. It is better to print them in same format. Also use error_report instead of fprintf. Signed-off-by: zhanghailiang --- vl.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/vl.c b/vl.c inde

Re: [Qemu-devel] [PATCH] aio-win32: avoid out-of-bounds access to the events array

2014-09-15 Thread TeLeMan
On Mon, Sep 15, 2014 at 8:52 PM, Paolo Bonzini wrote: > If ret is WAIT_TIMEOUT and there was an event returned by select(), > we can write to a location after the end of the array. But in > that case we can retry the WaitForMultipleObjects call with the > same set of events, so just move the even

[Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on qdev_device_help()

2014-09-15 Thread arei.gonglei
From: Gonglei Normally, qmp_device_list_properties() may return NULL when a device haven't special properties excpet Object and DeviceState properties, such as virtio-balloon-device. We just need check local_err instead of prop_list. Example: Segmentation fault (core dumped) The backtrace as

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-09-15 Thread Li Liu
On 2014/9/15 20:57, Michael Tokarev wrote: > 15.09.2014 16:50, Michael Tokarev пишет: >> 09.09.2014 15:19, john.liuli wrote: >>> From: Li Liu >>> >>> Eeay to reproduce, just try "qemu -monitor stdio -nographic" >>> and type "quit", then the terminal will be crashed. >>> >>> There are two pathes

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-15 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > At present, people have no way to know they should > > have a specific for

[Qemu-devel] [Bug 1369347] Re: Mac OS X cannot passthrough USB device to guest

2014-09-15 Thread Aaron
For future googlers, I first ran "brew uninstall qemu" then "brew install libusb". After that, download the source, "./configure", "make", "sudo make install" and you're done. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://b

[Qemu-devel] Data classification in Qemu

2014-09-15 Thread Wu Libin
Hi, everyone I’m wondering if the Qemu has the data classification function.I means it can classify the file size like 4K, 8K, 16K,…,4M,…1G, and do some cache policies with SSD. Anyone can tell me about this? I search the list and find nothing. Sorry if it already exists on the mail list. Tha

[Qemu-devel] [Bug 1369347] Re: Mac OS X cannot passthrough USB device to guest

2014-09-15 Thread Aaron
I'll give it a shot, thanks :) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1369347 Title: Mac OS X cannot passthrough USB device to guest Status in QEMU: New Bug description: I'm using Mac

Re: [Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-15 Thread Marc Marí
El Mon, 15 Sep 2014 14:47:41 -0700 Peter Maydell escribió: > On 11 September 2014 02:40, Marc Marí > wrote: > > Increase the clock step to avoid Travis failure in some builds due > > to overagressive timeout. > > > > Signed-off-by: Marc Marí > > Unfortunately Travis is still failing with this:

Re: [Qemu-devel] [PATCH v6 00/16] KVM platform device passthrough

2014-09-15 Thread Eric Auger
On 09/12/2014 01:05 AM, Christoffer Dall wrote: > On Thu, Sep 11, 2014 at 04:51:14PM -0600, Alex Williamson wrote: >> On Thu, 2014-09-11 at 15:23 -0700, Christoffer Dall wrote: >>> On Thu, Sep 11, 2014 at 04:14:09PM -0600, Alex Williamson wrote: On Tue, 2014-09-09 at 08:31 +0100, Eric Auger wr

Re: [Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-15 Thread Peter Maydell
On 11 September 2014 02:40, Marc Marí wrote: > Increase the clock step to avoid Travis failure in some builds due to > overagressive timeout. > > Signed-off-by: Marc Marí Unfortunately Travis is still failing with this: ERROR:tests/virtio-blk-test.c:209:pci_basic: assertion failed: (qvirtio_wai

Re: [Qemu-devel] [PATCH v1] async: aio_context_new(): Handle event_notifier_init failure

2014-09-15 Thread Chrysostomos Nanakos
On Mon, Sep 15, 2014 at 09:59:00PM +0200, Benoît Canet wrote: > The Monday 15 Sep 2014 à 21:03:18 (+0200), Benoît Canet wrote : > > The Sunday 14 Sep 2014 à 13:23:13 (+0300), Chrysostomos Nanakos wrote : > > > If event_notifier_init fails QEMU exits without printing > > > any error information to t

Re: [Qemu-devel] [PATCH v1] async: aio_context_new(): Handle event_notifier_init failure

2014-09-15 Thread Chrysostomos Nanakos
Hi Benoit, thanks for reviewing and replying. On Mon, Sep 15, 2014 at 09:03:18PM +0200, Benoît Canet wrote: > The Sunday 14 Sep 2014 à 13:23:13 (+0300), Chrysostomos Nanakos wrote : > > If event_notifier_init fails QEMU exits without printing > > any error information to the user. This commit adds

Re: [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes

2014-09-15 Thread Peter Maydell
On 14 September 2014 11:41, Michael S. Tsirkin wrote: > The following changes since commit 4c24f4004089a308c5de8ed720cf6bd1746aedd8: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20140912' into staging (2014-09-12 > 15:12:26 +0100) > > are available in the git repos

Re: [Qemu-devel] [RFC 02/10] AHCI: Update byte count after DMA completion

2014-09-15 Thread John Snow
On 09/13/2014 09:21 AM, Paolo Bonzini wrote: Il 13/09/2014 06:34, John Snow ha scritto: Currently, DMA read/write operations neglect to update the byte count after a successful transfer like ATAPI DMA read or PIO read/write operations do. We correct this oversight by adding another callback i

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread Richard Henderson
On 09/15/2014 04:17 AM, Pavel Dovgalyuk wrote: > @@ -1006,6 +1006,7 @@ void helper_fstenv(CPUX86State *env, target_ulong ptr, > int data32) > cpu_stw_data(env, ptr + 10, 0); > cpu_stw_data(env, ptr + 12, 0); > } > +update_fp_status(env); > } Why does this need to updat

Re: [Qemu-devel] [PATCH v1] async: aio_context_new(): Handle event_notifier_init failure

2014-09-15 Thread Benoît Canet
The Monday 15 Sep 2014 à 21:03:18 (+0200), Benoît Canet wrote : > The Sunday 14 Sep 2014 à 13:23:13 (+0300), Chrysostomos Nanakos wrote : > > If event_notifier_init fails QEMU exits without printing > > any error information to the user. This commit adds an error > > message on failure: > > > > #

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-15 Thread BALATON Zoltan
On Mon, 15 Sep 2014, Gabriel L. Somlo wrote: mappings should end up being the same. I'll look for as close an equivalent of "cat /proc/interrupts" on os x as I can find, and try to sanity-check this assumption. I think you can find these in the ioreg output. Try ioreg -lfw0 and look for IOInte

Re: [Qemu-devel] [PULL 0/2] QMP queue

2014-09-15 Thread Peter Maydell
On 12 September 2014 13:26, Luiz Capitulino wrote: > Two trivial fixes. > > The following changes since commit 6cd14054b67774cc58a51fca6660cfa1d3c08059: > > libqos virtio: Increase ISR timeout (2014-09-12 13:58:07 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/qmp

Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

2014-09-15 Thread Luiz Capitulino
On Mon, 15 Sep 2014 13:16:01 -0600 Eric Blake wrote: > On 09/15/2014 12:09 PM, Luiz Capitulino wrote: > > When a QMP client changes the polling interval time by setting > > the guest-stats-polling-interval property, the interval value > > is stored and manipuled as an int64_t variable. > > > >

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-15 Thread Gabriel L. Somlo
On Mon, Sep 15, 2014 at 08:02:04PM +0200, Laszlo Ersek wrote: > >> It is actually extremely relevant, the irq_pin field. I'm not exactly > >> sure how just yet, but it is. Maybe check the interrupt routing in OSX > >> somehow? Do you have a dmesg-like log in OSX, with a PRT dump from the > >> DSDT,

Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

2014-09-15 Thread Eric Blake
On 09/15/2014 12:09 PM, Luiz Capitulino wrote: > When a QMP client changes the polling interval time by setting > the guest-stats-polling-interval property, the interval value > is stored and manipuled as an int64_t variable. > s/manipuled/manipulated/ > However, the balloon_stats_change_timer()

[Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

2014-09-15 Thread Luiz Capitulino
When a QMP client changes the polling interval time by setting the guest-stats-polling-interval property, the interval value is stored and manipuled as an int64_t variable. However, the balloon_stats_change_timer() function, which is used to set the actual timer with the interval value, takes an i

Re: [Qemu-devel] [PATCH v1] async: aio_context_new(): Handle event_notifier_init failure

2014-09-15 Thread Benoît Canet
The Sunday 14 Sep 2014 à 13:23:13 (+0300), Chrysostomos Nanakos wrote : > If event_notifier_init fails QEMU exits without printing > any error information to the user. This commit adds an error > message on failure: > > # qemu [...] > qemu: event_notifier_init failed: Too many open files in syst

Re: [Qemu-devel] [PULL 00/22] Block patches

2014-09-15 Thread Peter Maydell
On 12 September 2014 08:56, Kevin Wolf wrote: > The following changes since commit 10601bef566461efbea81ee344ed3355ce71954a: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into > staging (2014-09-09 15:08:05 +0100) > > are available in the git repository at: > > >

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-09-15 Thread Serge Hallyn
** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: New => Triaged ** Changed in: qemu (Ubuntu) Importance: Undecided => High ** Also affects: qemu (Ubuntu Trusty) Importance: Undecided Status: New ** Changed in: qe

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-15 Thread Laszlo Ersek
On 09/15/14 17:07, Gabriel L. Somlo wrote: > On Mon, Sep 15, 2014 at 05:01:21PM +0200, Laszlo Ersek wrote: >>> diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c >>> index 289ca3b..bb230f1 100644 >>> --- a/hw/usb/hcd-ehci-pci.c >>> +++ b/hw/usb/hcd-ehci-pci.c >>> @@ -208,8 +208,8 @@ struct

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-15 Thread Michael S. Tsirkin
On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > At present, people have no way to know they should > have a specific format for alias properties. > > Example: > > before output: > > virtio-blk-pci.physical_block_size=uint16 > virtio-blk-pci.logical

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-15 Thread Michael S. Tsirkin
On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > At present, people have no way to know they should > have a specific format for alias properties. > > Example: > > before output: > > virtio-blk-pci.physical_block_size=uint16 > virtio-blk-pci.logical

Re: [Qemu-devel] [PATCH 3/3] qmp: print real legacy_name for alias property

2014-09-15 Thread Michael S. Tsirkin
On Mon, Sep 15, 2014 at 10:44:39PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > In this way, we can get the real legacy_name for > alias properties, and avoide confusing people because of > property type. People have no way to know they should > have a specific format. > > Example:

Re: [Qemu-devel] [PATCH v7 0/3] block: Introduce "null" drivers

2014-09-15 Thread Eric Blake
On 09/11/2014 12:09 AM, Fam Zheng wrote: > v7: Add Benoît's rev-by line in patch 2. > Improved help text in patch 1. (Benoît) > > v6: Don't inherit from BlockdevOptionsFile. (Stefan) > Use .bdrv_co_readv instead of .bdrv_read. (Kevin) > Sort items in qapi schema definitions in patch 2

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-15 Thread Michael S. Tsirkin
On Mon, Sep 15, 2014 at 05:57:51PM +0200, Paolo Bonzini wrote: > Il 15/09/2014 16:44, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > At present, people have no way to know they should > > have a specific format for alias properties. > > > > Example: > > > > before output: > > >

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-15 Thread Eric Blake
On 09/15/2014 09:57 AM, Paolo Bonzini wrote: > Il 15/09/2014 16:44, arei.gong...@huawei.com ha scritto: >> From: Gonglei >> >> At present, people have no way to know they should >> have a specific format for alias properties. >> >> Example: >> >> before output: >> >> virtio-blk-pci.physical_block

[Qemu-devel] [PATCH 2/4] .travis.yml: make the make slightly more parallel

2014-09-15 Thread Alex Bennée
The Travis VMs have 1.5 cores so we might as well make some use of the paralellism. Signed-off-by: Alex Bennée diff --git a/.travis.yml b/.travis.yml index 72cfc9f..f113339 100644 --- a/.travis.yml +++ b/.travis.yml @@ -41,7 +41,10 @@ before_install: - git submodule update --init --recursive

Re: [Qemu-devel] [PATCH v7 0/3] block: Introduce "null" drivers

2014-09-15 Thread Benoît Canet
The Thursday 11 Sep 2014 à 14:09:55 (+0800), Fam Zheng wrote : > v7: Add Benoît's rev-by line in patch 2. > Improved help text in patch 1. (Benoît) > > v6: Don't inherit from BlockdevOptionsFile. (Stefan) > Use .bdrv_co_readv instead of .bdrv_read. (Kevin) > Sort items in qapi schema d

Re: [Qemu-devel] [PATCH v7 03/15] target-tricore: Add softmmu support

2014-09-15 Thread Peter Maydell
On 1 September 2014 04:59, Bastian Koppelmann wrote: > Add basic softmmu support for TriCore > > +static inline void QEMU_NORETURN do_raise_exception(CPUTriCoreState *env, > +uint32_t exception, > +

[Qemu-devel] [PATCH 1/4] .travis.yml: add more linux-user to the build matrix

2014-09-15 Thread Alex Bennée
At the same time I've grouped the $ARCH-linux-user and $ARCH-softmmu builds together (hoping FS cache helps) and grouped all $ARCH-softmmu only builds into one target. This reduces the build matrix slightly which will hopefully help with build times. Signed-off-by: Alex Bennée diff --git a/.trav

[Qemu-devel] [PATCH 4/4] .travis.yml: remove "make check" from main matrix

2014-09-15 Thread Alex Bennée
There are problems with unreliability in "make check" which still need to be tracked down. As the tests are broadly the same for all targets if added one explicit target to the matrix to run it. However this does build all softmmu targets to ensure they at least "run" Signed-off-by: Alex Bennée

[Qemu-devel] [PATCH 3/4] .travis.yml: pre-seed sub-modules for speed

2014-09-15 Thread Alex Bennée
A significant portion of the build time is spent initialising all the sub-modules we use in the source tree. Often this is almost as long as the build itself. By pre-seeding the .git/modules tree this will hopefully improve things. Signed-off-by: Alex Bennée diff --git a/.travis.yml b/.travis.ym

[Qemu-devel] [PATCH 0/4] A number of Travis CI tweaks

2014-09-15 Thread Alex Bennée
Hi, While I was in-between kernel builds last week I attempted to improve the Travis build a little. Alexander Graf pointed out we were missing a number of the linux-user targets. To avoid exploding the matrix too much I've grouped builds together where they hopefully benefit from sharing some obj

Re: [Qemu-devel] [PATCH v6 00/22] block: Asynchronous request cancellation

2014-09-15 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 01:41:06PM +0800, Fam Zheng wrote: > v6: Drop bdrv_em_aiocb_info.cancel in patch 5. (Paolo) > > v5: Fix IDE callback. (Paolo) > Fix blkdebug. (Paolo) > Drop the DMA fix which is independent of this series. (Paolo) > Incorperate Yuan's patch on quorum_aio_cancel.

Re: [Qemu-devel] [PATCH v6 11/22] blkdebug: Drop blkdebug_aiocb_info.cancel

2014-09-15 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 01:41:17PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/blkdebug.c | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/block/blkdebug.c b/block/blkdebug.c > index 69b330e..08131b3 100644 > --- a/block/blkdebug.c > +

[Qemu-devel] [PATCH v3 4/4] ivshmem: Fix fd leak on error

2014-09-15 Thread Andreas Färber
Reported-by: Stefan Hajnoczi Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- hw/misc/ivshmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index ecef82a..bf585b7 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -512,6 +512,7 @@

[Qemu-devel] [PATCH v3 2/4] ivshmem: validate incoming_posn value from server

2014-09-15 Thread Andreas Färber
From: Stefan Hajnoczi Check incoming_posn to avoid out-of-bounds array accesses if the ivshmem server on the host sends invalid values. Cc: Cam Macdonell Reported-by: Sebastian Krahmer Signed-off-by: Stefan Hajnoczi [AF: Tighten upper bound check for posn in close_guest_eventfds()] Cc: qemu-s

[Qemu-devel] [PATCH v3 1/4] ivshmem: Check ivshmem_read() size argument

2014-09-15 Thread Andreas Färber
From: Stefan Hajnoczi The third argument to the fd_read() callback implemented by ivshmem_read() is the number of bytes, not a flags field. Fix this and check we received enough bytes before accessing the buffer pointer. Cc: Cam Macdonell Reported-by: Sebastian Krahmer Signed-off-by: Stefan H

[Qemu-devel] [PATCH v3 0/4] ivshmem security fixes

2014-09-15 Thread Andreas Färber
Hello, This series tightens security on incoming data for ivshmem, originally sparked by SUSE's security team (Sebastian Krahmer). I've combined them and tackled remaining review feedback. Regards, Andreas Changes from Sebastian's #2: * Rebased onto Stefan's patches * Dropped g_realloc() check (

[Qemu-devel] [PATCH v3 3/4] ivshmem: Fix potential OOB r/w access

2014-09-15 Thread Andreas Färber
From: Sebastian Krahmer Fix OOB access via malformed incoming_posn parameters and check that requested memory is actually alloc'ed. Signed-off-by: Sebastian Krahmer [AF: Rebased, cleanups, avoid fd leak] Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- hw/misc/ivshmem.c | 27 +

Re: [Qemu-devel] [PULL 0/2] Fix pixman build failure.

2014-09-15 Thread Peter Maydell
anch 'remotes/kraxel/tags/pull-console-20140905-2' > into staging (2014-09-11 11:44:17 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-console-20140915-1 > > for you to fetch changes up to 236f282c1c7bb41b0ec3b3d771ca652eb

Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt

2014-09-15 Thread John Snow
On 09/13/2014 03:50 PM, Paolo Bonzini wrote: Il 13/09/2014 15:26, Paolo Bonzini ha scritto: +if (ad->dp_intr_req) { +ahci_trigger_irq(ad->hba, ad, PORT_IRQ_SG_DONE); +ad->dp_intr_req = 0; +} Is it also needed in the error case? Especially the short-PRDT case that you

Re: [Qemu-devel] [PATCH] cpu-exec: Don't mask out external interrupts when single-stepping an invalid instruction.

2014-09-15 Thread Peter Maydell
On 15 September 2014 09:17, Andreas Färber wrote: > Am 15.09.2014 um 18:10 schrieb Peter Maydell: >> Our handling of exceptions and exception priorities for >> Cortex-M CPUs is totally wrong. We attempt to reuse the >> GIC priority handling code for interrupts, which then leaves >> the exceptions

Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt

2014-09-15 Thread John Snow
On 09/13/2014 09:26 AM, Paolo Bonzini wrote: Il 13/09/2014 06:34, John Snow ha scritto: AHCI devices support a feature where individual entries in the scatter-gather list may have interrupt request bits set, in order to receive notification partway through a command that a portion of a transfe

Re: [Qemu-devel] [PATCH] softmmu: fixing usage of cpu_st/ld* from helpers

2014-09-15 Thread Richard Henderson
On 09/15/2014 03:50 AM, Pavel Dovgalyuk wrote: > +/* inline helper ld function */ > + > +static inline DATA_TYPE > +glue(glue(helper_inline_ld, SUFFIX), MEMSUFFIX)(CPUArchState *env, > +target_ulong addr, > +

Re: [Qemu-devel] [PATCH] cpu-exec: Don't mask out external interrupts when single-stepping an invalid instruction.

2014-09-15 Thread Peter Maydell
On 15 September 2014 09:02, Martin Galvan wrote: > I did a bit more research on how Cortex-M handles nested interrupts. > In particular, I noticed if we were to have an invalid instruction > inside the exception handler itself, trying to single-step it would > again cause Qemu not to return contro

Re: [Qemu-devel] [PATCH 0/5] target-mips: Fix unused-function warnings

2014-09-15 Thread Richard Henderson
On 09/14/2014 12:45 PM, Peter Maydell wrote: > These patches fix a number of warnings in target-mips code that > clang produces; notably, clang will complain about unused > 'static inline' functions in .c files where gcc does not. > Some are genuinely totally unused; a few are unused only in some >

Re: [Qemu-devel] [PATCH] cpu-exec: Don't mask out external interrupts when single-stepping an invalid instruction.

2014-09-15 Thread Martin Galvan
I did a bit more research on how Cortex-M handles nested interrupts. In particular, I noticed if we were to have an invalid instruction inside the exception handler itself, trying to single-step it would again cause Qemu not to return control back to gdb. Reading up a bit I found out that when the

Re: [Qemu-devel] [PATCH] cpu-exec: Don't mask out external interrupts when single-stepping an invalid instruction.

2014-09-15 Thread Andreas Färber
Am 15.09.2014 um 18:10 schrieb Peter Maydell: > On 15 September 2014 09:02, Martin Galvan > wrote: >> I did a bit more research on how Cortex-M handles nested interrupts. >> In particular, I noticed if we were to have an invalid instruction >> inside the exception handler itself, trying to single-

Re: [Qemu-devel] [PATCH 1/3] qom: add error handler for object alias property

2014-09-15 Thread Paolo Bonzini
Il 15/09/2014 16:44, arei.gong...@huawei.com ha scritto: > From: Gonglei > > object_property_add_alias() is called at some > places at present. And its parameter errp may not NULL, > such as > object_property_add_alias(obj, "iothread", OBJECT(&dev->vdev),"iothread", >

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-15 Thread Paolo Bonzini
Il 15/09/2014 16:44, arei.gong...@huawei.com ha scritto: > From: Gonglei > > At present, people have no way to know they should > have a specific format for alias properties. > > Example: > > before output: > > virtio-blk-pci.physical_block_size=uint16 > virtio-blk-pci.logical_block_size=uint

Re: [Qemu-devel] request for wiki account, please

2014-09-15 Thread Stefan Hajnoczi
Done, please see private mail for details. Stefan pgp6X3NzUl2I3.pgp Description: PGP signature

Re: [Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-15 Thread Stefan Hajnoczi
On Fri, Sep 12, 2014 at 09:30:55AM +0100, Peter Maydell wrote: > On 12 September 2014 09:27, Stefan Hajnoczi wrote: > > On Thu, Sep 11, 2014 at 11:40:16AM +0200, Marc Marí wrote: > >> Increase the clock step to avoid Travis failure in some builds due to > >> overagressive timeout. > >> > >> Signed

Re: [Qemu-devel] [PATCH v2 02/23] block: New BlockBackend

2014-09-15 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > >> Benoît Canet writes: >> --- a/block.c +++ b/block.c @@ -2119,10 +2119,11 @@ static void bdrv_delete(BlockDriverState *bs) bdrv_close(bs); >>> >>> +drive_info_del(drive_get_by_blockdev(bs))

Re: [Qemu-devel] [PATCH] aio-win32: fix uninitialized use of have_select_revents

2014-09-15 Thread Stefan Hajnoczi
On Fri, Sep 12, 2014 at 12:08:49PM +0200, Paolo Bonzini wrote: > Always initialize it with the return value of aio_prepare. > > Reported-by: TeLeMan > Signed-off-by: Paolo Bonzini > --- > aio-win32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, applied to my block tree:

Re: [Qemu-devel] [PATCH v2 0/1] ide/atapi: Mark non-data commands as complete

2014-09-15 Thread Stefan Hajnoczi
On Fri, Sep 12, 2014 at 11:51:11PM -0400, John Snow wrote: > v2: > > - Instead of using ide_set_inactive, use ide_stop_transfer > - ATAPI helpers use either ide_atapi_cmd_ok or ide_atapi_cmd_error, >instead of ide_stop_transfer directly. > > John Snow (1): > ide/atapi: Mark non-data comma

  1   2   3   >