Re: [Qemu-devel] [PATCH 1/2] monitor: Reset HMP mon->rs on CHR_EVENT_CLOSED

2014-09-11 Thread Markus Armbruster
Stratos Psomadakis writes: > Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a > bug in the way the HMP monitor handles its input. When a client closes > the connection to the monitor, tcp_chr_read() will catch the HUP > 'signal' and call tcp_chr_disconnect() to close the se

Re: [Qemu-devel] [PATCH 0/2] Monitor-related fixes

2014-09-11 Thread Markus Armbruster
You neglected to cc maintainers. Stratos Psomadakis writes: > Hi, > > the first patch fixes an issue with HMP monitors, which was exposed > with v2.1.0 (commits cdaa86a and 812c10). Copying Luiz. > The second one fixes a typo in a helper C program used in > qemu-iotests. Copying Kevin and Ste

Re: [Qemu-devel] [PATCH 1/2] vl: Fix the confused logic for '-m' option

2014-09-11 Thread Li Liu
On 2014/9/12 13:58, zhanghailiang wrote: > It should be valid for the follow configure: > -m 256,slots=0 > -m 256,maxmem=256M > -m 256,slots=0,maxmem=256M > -m 256,slots=x,maxmem=y where x > 0 and y > 256M > > Fix the confused code logic and use error_report instead of fprintf. > > Printing th

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-11 Thread Gerd Hoffmann
Hi, > With OVMF, I have EHCI with the high-speed (and working) > keyboard+mouse, but ONLY ONE UHCI device (UHCI3). UHCI1 UHCI2 do not > get detected. Now *that* is really strange, especially as UHCI1 is pci function 0, without probing that successfully you wouldn't see the other pci functions (1

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-11 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and > take effect after rebooting > > Am 11.09.2014 um 07:58 schrieb Gonglei (Arei): > >>> ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 > -drive \ > >>> file=/home/win7_32_2U,if=none,id=drive-ide0-0-0 -devi

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: >> EOF >> --- >> If you have feedback or questions, let us know. The process can be >> tweaked as time goes on so we can continue to improve. > > Great mail. Yup. Let's see how it works out. > Now we need a wiki entry describing the process. > Also we need something remin

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Markus Armbruster
Eric Blake writes: > On 09/11/2014 01:34 PM, Benoît Canet wrote: >> The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote : >>> Benoît Canet writes: >>> > + blk_bs(blk_by_legacy_dinfo(dinfo))); This seems to be a fairly common patter

Re: [Qemu-devel] [RFC PATCH 04/17] COLO info: use colo info to tell migration target colo is enabled

2014-09-11 Thread Hongyang Yang
在 08/01/2014 10:43 PM, Dr. David Alan Gilbert 写道: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: migrate colo info to migration target to tell the target colo is enabled. If I understand this correctly this means that you send a 'colo info' device information for migrations that don't have C

Re: [Qemu-devel] ui causes latest master build failure on rhel6

2014-09-11 Thread Gerd Hoffmann
> > pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA. > > We don't check for a minimum version. > > RHEL-6 is probably older. Uhm, well, it isn't (any more): [root@rhel6 ~]# rpm -q pixman pixman-0.26.2-5.1.el6_5.x86_64 Seems to be rebased somewhen (used to be 0.16 for RHEL-6.0 IIRC

Re: [Qemu-devel] [RFC PATCH 16/17] COLO ram cache: implement colo ram cache on slaver

2014-09-11 Thread Hongyang Yang
在 08/01/2014 11:10 PM, Dr. David Alan Gilbert 写道: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: The ram cache was initially the same as PVM's memory. At checkpoint, we cache the dirty memory of PVM into ram cache (so that ram cache always the same as PVM's memory at every checkpoint), flush c

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-09-11 Thread Hongyang Yang
在 08/01/2014 11:03 PM, Dr. David Alan Gilbert 写道: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: implement colo checkpoint protocol. Checkpoint synchronzing points. Primary Secondary NEW @ Suspend

[Qemu-devel] [PATCH 1/2] vl: Fix the confused logic for '-m' option

2014-09-11 Thread zhanghailiang
It should be valid for the follow configure: -m 256,slots=0 -m 256,maxmem=256M -m 256,slots=0,maxmem=256M -m 256,slots=x,maxmem=y where x > 0 and y > 256M Fix the confused code logic and use error_report instead of fprintf. Printing the maxmem in hex, same with ram_size. Signed-off-by: zhanghai

[Qemu-devel] [PATCH 2/2] rdma: Fix incorrect description in comments

2014-09-11 Thread zhanghailiang
Since we have supported memory hotplug, VM's ram include pc.ram and hotplug-memory. Fix the confused description for rdma migration: pc.ram -> VM's ram Signed-off-by: zhanghailiang --- docs/rdma.txt| 6 +++--- migration-rdma.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [RESEND PATCH v3 5/8] pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support.

2014-09-11 Thread zhanghailiang
On 2014/9/4 21:28, Igor Mammedov wrote: On Wed, 27 Aug 2014 16:08:36 +0800 Tang Chen wrote: From: Hu Tao Implement unrealize function for pc-dimm device. It delete subregion from s/delete/removes/ hotplug region, and delete ram address range from guest ram list. Signed-off-by: Hu Tao Sign

Re: [Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump

2014-09-11 Thread Alex Williamson
On Fri, 2014-09-12 at 10:12 +0530, Nikunj A Dadhania wrote: > The PCI MMIO might be disabled or the device in the reset state. > Make sure we do not dump these memory regions. > > Signed-off-by: Nikunj A Dadhania > --- If you don't want to dump a memory region then add the ability to set a no-du

[Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump

2014-09-11 Thread Nikunj A Dadhania
The PCI MMIO might be disabled or the device in the reset state. Make sure we do not dump these memory regions. Signed-off-by: Nikunj A Dadhania --- hw/misc/vfio.c| 2 +- include/exec/memory.h | 27 +++ memory.c | 16 memory_mapping.

Re: [Qemu-devel] [PATCH 4/3] qemu-iotests: Test missing "driver" key for blockdev-add

2014-09-11 Thread Eric Blake
On 09/11/2014 09:04 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/087 | 17 + > tests/qemu-iotests/087.out | 13 + > 2 files changed, 30 insertions(+) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libv

Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled

2014-09-11 Thread Alexey Kardashevskiy
On 09/11/2014 09:02 PM, Alexey Kardashevskiy wrote: > On 09/11/2014 08:38 PM, Gerd Hoffmann wrote: >> Hi, >> >>> Another question - I noticed that XHCI migration is broken in quite recent >>> upstream QEMU, smells like memory corruption. Is it just me or just PPC or >>> is it known issue? >> >> 2

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-11 Thread Fam Zheng
On Tue, 09/09 14:28, Benoît Canet wrote: > On Tue, Sep 09, 2014 at 01:56:46PM +0200, Kevin Wolf wrote: > > Am 22.08.2014 um 18:11 hat Benoît Canet geschrieben: > > > Since the block layer code is starting to modify the BDS graph right in > > > the > > > middle of BDS chains (block-mirror's replace

Re: [Qemu-devel] [question] virtio-blk performance degradation happened with virito-serial

2014-09-11 Thread Zhang Haoyu
>>> > > If virtio-blk and virtio-serial share an IRQ, the guest operating >>> > > system has to check each virtqueue for activity. Maybe there is some >>> > > inefficiency doing that. >>> > > AFAIK virtio-serial registers 64 virtqueues (on 31 ports + console) >>> > > even if everything is unused

Re: [Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to PC_MACHINE

2014-09-11 Thread Gu Zheng
Hi Igor, On 09/10/2014 09:55 PM, Igor Mammedov wrote: > On Wed, 3 Sep 2014 17:06:16 +0800 > Gu Zheng wrote: > >> Add cpu hotplug handler to PC_MACHINE, which will perform the acpi >> cpu hotplug callback via hotplug_handler API. >> >> Signed-off-by: Gu Zheng >> --- >> hw/i386/pc.c | 26

Re: [Qemu-devel] [PATCH 2/2] Revert "virtio: don't call device on !vm_running"

2014-09-11 Thread Jason Wang
On 09/12/2014 12:18 AM, Michael S. Tsirkin wrote: > This reverts commit a1bc7b827e422e1ff065640d8ec5347c4aadfcd8. > virtio: don't call device on !vm_running > It turns out that virtio net assumes that vm_running > is updated before device status callback in many places, > so this change leads t

Re: [Qemu-devel] [PATCH 1/2] virtio-net: drop assert on vm stop

2014-09-11 Thread Jason Wang
On 09/12/2014 12:18 AM, Michael S. Tsirkin wrote: > On vm stop, vm_running state set to stopped > before device is notified, so callbacks can get envoked with > vm_running = false; and this is not an error. This is consistent with virtio-blk which also has such kinds of callbacks. This fixes the i

Re: [Qemu-devel] [PATCH 0/3] qapi: fix crash in dealloc visitor for union types

2014-09-11 Thread Fam Zheng
On Thu, 09/11 18:20, Michael Roth wrote: > This series introduces visit_start_enum and visit_end_enum as a way > of allowing visitors to trigger generated code to bail out on visiting > union fields if the visitor implementation deems doing so to be unsafe. > > See patch 1 for the circumstances th

[Qemu-devel] [PATCH 4/3] qemu-iotests: Test missing "driver" key for blockdev-add

2014-09-11 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/087 | 17 + tests/qemu-iotests/087.out | 13 + 2 files changed, 30 insertions(+) diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087 index 82c56b1..d7454d1 100755 --- a/tests/qemu-iotests/087 +++ b/tests/qem

Re: [Qemu-devel] [PATCH 2/3] qapi: dealloc visitor, implement visit_start_union

2014-09-11 Thread Eric Blake
On 09/11/2014 05:20 PM, Michael Roth wrote: > If the .data field of a QAPI Union is NULL, we don't need to free > any of the union fields.. intentional double dot? > > Make use of the new visit_start_union interface to access this > information and instruct the generated code to not visit these

Re: [Qemu-devel] [PATCH 1/3] qapi: add visit_start_union and visit_end_union

2014-09-11 Thread Eric Blake
On 09/11/2014 05:20 PM, Michael Roth wrote: > In some cases an input visitor might bail out on filling out a > struct for various reasons, such as missing fields when running > in strict mode. In the case of a QAPI Union type, this may lead > to cases where the .kind field which encodes the union t

Re: [Qemu-devel] [PATCH 1/5] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-09-11 Thread Gu Zheng
Hi Igor, On 09/11/2014 06:12 PM, Igor Mammedov wrote: > On Thu, 11 Sep 2014 11:04:10 +0800 > Gu Zheng wrote: > >> Hi Igor, >> On 09/10/2014 09:28 PM, Igor Mammedov wrote: >> >>> On Wed, 3 Sep 2014 17:06:13 +0800 >>> Gu Zheng wrote: >>> Signed-off-by: Gu Zheng --- hw/acpi/

Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-11 Thread TeLeMan
On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini wrote: > Uses the same select/WSAEventSelect scheme as main-loop.c. > WSAEventSelect() is edge-triggered, so it cannot be used > directly, but it is still used as a way to exit from a > blocking g_poll(). > > Before g_poll() is called, we poll sockets

Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-11 Thread TeLeMan
On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini wrote: > Uses the same select/WSAEventSelect scheme as main-loop.c. > WSAEventSelect() is edge-triggered, so it cannot be used > directly, but it is still used as a way to exit from a > blocking g_poll(). > > Before g_poll() is called, we poll sockets

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-11 Thread Gu Zheng
Hi Bharata, On 09/11/2014 08:37 PM, Bharata B Rao wrote: > On Thu, Sep 11, 2014 at 3:23 PM, Gu Zheng wrote: >> On 09/11/2014 05:35 PM, Bharata B Rao wrote: >> >>> On Thu, Aug 28, 2014 at 9:06 AM, Gu Zheng wrote: After ACPI get a signal to eject a vCPU, the vCPU must be removed from CP

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-11 Thread Hongyang Yang
在 09/11/2014 09:50 AM, Michael R. Hines 写道: On 09/10/2014 11:43 PM, Walid Nouri wrote: Hello Michael, Hello Paolo i have „studied“ the available documentation/Information and tried to get an idea of the QEMU live block operation possibilities. I think the MC protocol doesn’t need synchronous

Re: [Qemu-devel] [PATCH 0/2] vfio: Another try to fix ROM BAR endianness

2014-09-11 Thread Alexey Kardashevskiy
On 09/12/2014 07:20 AM, Alex Williamson wrote: > On Tue, 2014-09-09 at 21:34 +1000, Alexey Kardashevskiy wrote: >> I did some tests on LE/BE guest/host combinations and came up with >> these 2 patches. Please comment. Thanks. > > Have you tried BE guest/LE host? Yes. > IIRC, the g3beige tcg g

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-11 Thread Hongyang Yang
在 09/12/2014 01:44 AM, Dr. David Alan Gilbert 写道: (I've cc'd in Fam, Stefan, and Kevin for Block stuff, and Yang and Eddie for Colo) * Walid Nouri (walid.no...@gmail.com) wrote: Hello Michael, Hello Paolo i have ???studied??? the available documentation/Information and tried to

Re: [Qemu-devel] [PATCH] cpu-exec: Don't mask out external interrupts when single-stepping an invalid instruction.

2014-09-11 Thread Richard Henderson
On 09/11/2014 03:13 PM, Peter Maydell wrote: >> The long story: Qemu generates an exception_with_syndrome instruction >> when it realizes the instruction it's trying to translate is invalid. >> That instruction in turn modifies cs->exception_index and calls >> cpu_loop_exit. >> Normally, the value

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-11 Thread Gabriel L. Somlo
On Thu, Sep 11, 2014 at 11:34:03PM +0200, Alexander Graf wrote: > >> With Chameleon (and SeaBIOS), I see all three UHCIs (with no attached > >> devices), and EHCI (with the now-high-speed keyboard and mouse). > >> > >> With OVMF, I have EHCI with the high-speed (and working) > >> keyboard+mouse, b

[Qemu-devel] [PATCH 0/3] qapi: fix crash in dealloc visitor for union types

2014-09-11 Thread Michael Roth
This series introduces visit_start_enum and visit_end_enum as a way of allowing visitors to trigger generated code to bail out on visiting union fields if the visitor implementation deems doing so to be unsafe. See patch 1 for the circumstances that cause the segfault in the dealloc visitor. This

[Qemu-devel] [PATCH 3/3] tests: add QMP input visitor test for unions with no discriminator

2014-09-11 Thread Michael Roth
This more of an exercise of the dealloc visitor, where it may erroneously use an uninitialized discriminator field as indication that union fields corresponding to that discriminator field/type are present, which can lead to attempts to free random chunks of heap memory. Cc: qemu-sta...@nongnu.org

[Qemu-devel] [PATCH 2/3] qapi: dealloc visitor, implement visit_start_union

2014-09-11 Thread Michael Roth
If the .data field of a QAPI Union is NULL, we don't need to free any of the union fields.. Make use of the new visit_start_union interface to access this information and instruct the generated code to not visit these fields when this occurs. Cc: qemu-sta...@nongnu.org Reported-by: Fam Zheng Sug

[Qemu-devel] [PATCH 1/3] qapi: add visit_start_union and visit_end_union

2014-09-11 Thread Michael Roth
In some cases an input visitor might bail out on filling out a struct for various reasons, such as missing fields when running in strict mode. In the case of a QAPI Union type, this may lead to cases where the .kind field which encodes the union type is uninitialized. Subsequently, other visitors,

Re: [Qemu-devel] [PATCH 0/1] Add support for DRM IOCTLs to QEMU user mode virtualization.

2014-09-11 Thread Aaditya Chandrasekhar Azad
Hi qemu devs, I was wondering if anyone would be willing to test this patch with intel or, if it will be useful, I can add support nouveau, radeon, vmxgfx / any other mesa + drm gfx driver. I won't be able to easily test the latter config, but given the nature of this patch, adding those IOCTLs sh

Re: [Qemu-devel] [PATCH v6 00/16] KVM platform device passthrough

2014-09-11 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 04:51:14PM -0600, Alex Williamson wrote: > On Thu, 2014-09-11 at 15:23 -0700, Christoffer Dall wrote: > > On Thu, Sep 11, 2014 at 04:14:09PM -0600, Alex Williamson wrote: > > > On Tue, 2014-09-09 at 08:31 +0100, Eric Auger wrote: > > > > This RFC series aims at enabling KVM

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-11 Thread Michael Roth
Quoting Paolo Bonzini (2014-09-11 09:35:58) > Il 11/09/2014 16:26, Michael Roth ha scritto: > > Also, the .kind field of a QAPI Union type is something we generate for use > > by the generated visitor code. In the case of an unspecified discriminator > > we generated the enum type for that field in

Re: [Qemu-devel] [PATCH v6 00/16] KVM platform device passthrough

2014-09-11 Thread Alex Williamson
On Thu, 2014-09-11 at 15:23 -0700, Christoffer Dall wrote: > On Thu, Sep 11, 2014 at 04:14:09PM -0600, Alex Williamson wrote: > > On Tue, 2014-09-09 at 08:31 +0100, Eric Auger wrote: > > > This RFC series aims at enabling KVM platform device passthrough. > > > It implements a VFIO platform device,

Re: [Qemu-devel] [PATCH v6 00/16] KVM platform device passthrough

2014-09-11 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 04:14:09PM -0600, Alex Williamson wrote: > On Tue, 2014-09-09 at 08:31 +0100, Eric Auger wrote: > > This RFC series aims at enabling KVM platform device passthrough. > > It implements a VFIO platform device, derived from VFIO PCI device. > > > > The VFIO platform device use

Re: [Qemu-devel] [PATCH v6 00/16] KVM platform device passthrough

2014-09-11 Thread Alex Williamson
On Tue, 2014-09-09 at 08:31 +0100, Eric Auger wrote: > This RFC series aims at enabling KVM platform device passthrough. > It implements a VFIO platform device, derived from VFIO PCI device. > > The VFIO platform device uses the host VFIO platform driver which must > be bound to the assigned devic

Re: [Qemu-devel] [PATCH] cpu-exec: Don't mask out external interrupts when single-stepping an invalid instruction.

2014-09-11 Thread Peter Maydell
[cc'ing RTH who may have a better grasp on how the builtin single step is supposed to work.] On 11 September 2014 22:02, Martin Galvan wrote: > When using Gdb to remote-debug a program, if we try to single-step an > invalid instruction, > Qemu will never return control to the remote Gdb. > The so

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-11 Thread Walid Nouri
Am 11.09.2014 19:44, schrieb Dr. David Alan Gilbert: For keeping the complete system state consistent on the secondary system there must be a possibility for MC to commit/discard block device state changes. In normal operation the mirrored block device state changes (block buffer) are committed

[Qemu-devel] [PATCH] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation

2014-09-11 Thread damarion
From: Damjan Marion Header length check should happen only if backend is kernel. For user backend there is no reason to reset this bit. vhost-user code does not define .has_vnet_hdr_len so VIRTIO_NET_F_MRG_RXBUF cannot be negotiated even if both sides support it. Signed-off-by: Damjan Marion -

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-11 Thread Alexander Graf
> Am 11.09.2014 um 22:46 schrieb Laszlo Ersek : > >> On 09/11/14 22:16, Gabriel L. Somlo wrote: >>> On Thu, Sep 11, 2014 at 06:40:38PM +0200, Paolo Bonzini wrote: >>> Il 11/09/2014 18:35, Gabriel L. Somlo ha scritto: >> Can you configure Chamaleon to avoid the boot prompt? Yes. After do

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-11 Thread Benoît Canet
> EOF > --- > If you have feedback or questions, let us know. The process can be > tweaked as time goes on so we can continue to improve. Great mail. Now we need a wiki entry describing the process. Also we need something reminding who is the maintainer of the current week. Best regards Benoît

Re: [Qemu-devel] [PATCH 0/2] vfio: Another try to fix ROM BAR endianness

2014-09-11 Thread Alex Williamson
On Tue, 2014-09-09 at 21:34 +1000, Alexey Kardashevskiy wrote: > I did some tests on LE/BE guest/host combinations and came up with > these 2 patches. Please comment. Thanks. Have you tried BE guest/LE host? IIRC, the g3beige tcg guest on x86 host used to work with a vfio-pci NIC. The ROM is of

[Qemu-devel] [PATCH] cpu-exec: Don't mask out external interrupts when single-stepping an invalid instruction.

2014-09-11 Thread Martin Galvan
When using Gdb to remote-debug a program, if we try to single-step an invalid instruction, Qemu will never return control to the remote Gdb. The source of this problem is external interrupts being masked out in cpu_exec if cpu->singlestep_enabled has the SSTEP_NOIRQ flag set. To solve this I've add

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-11 Thread Laszlo Ersek
On 09/11/14 22:16, Gabriel L. Somlo wrote: > On Thu, Sep 11, 2014 at 06:40:38PM +0200, Paolo Bonzini wrote: >> Il 11/09/2014 18:35, Gabriel L. Somlo ha scritto: > Can you configure Chamaleon to avoid the boot prompt? >>> Yes. After doing that, usb starts working once OS X is fully booted. >>> >

Re: [Qemu-devel] [PATCH 04/23] block: Connect BlockBackend and DriveInfo

2014-09-11 Thread Eric Blake
On 09/11/2014 12:03 PM, Markus Armbruster wrote: > Benoît Canet writes: > >> The Wednesday 10 Sep 2014 à 10:13:33 (+0200), Markus Armbruster wrote : >>> Make the BlockBackend own the DriveInfo. Change blockdev_init() to >>> return the BlockBackend instead of the DriveInfo. >>> >>> Signed-off-by:

[Qemu-devel] New requirement for getting block layer patches merged

2014-09-11 Thread Stefan Hajnoczi
The time it takes for block layer patches to be reviewed and merged is a concern. Kevin and I want to discuss this issue, which was raised by Benoit, on the mailing list. The volume of patches is so high that Kevin and I cannot review them all in a timely manner. We are adjusting the process as

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-11 Thread Gabriel L. Somlo
On Thu, Sep 11, 2014 at 06:40:38PM +0200, Paolo Bonzini wrote: > Il 11/09/2014 18:35, Gabriel L. Somlo ha scritto: > >> > Can you configure Chamaleon to avoid the boot prompt? > > Yes. After doing that, usb starts working once OS X is fully booted. > > > > Works with either piix or q35 just fine.

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Eric Blake
On 09/11/2014 01:34 PM, Benoît Canet wrote: > The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote : >> Benoît Canet writes: >> + blk_bs(blk_by_legacy_dinfo(dinfo))); >>> >>> This seems to be a fairly common pattern: "blk_bs(blk_by_legacy_dinf

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Benoît Canet
The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote : > Benoît Canet writes: > > >> + blk_bs(blk_by_legacy_dinfo(dinfo))); > > > > This seems to be a fairly common pattern: "blk_bs(blk_by_legacy_dinfo())". > > How about a helper function ? > > Y

[Qemu-devel] [PATCH 1/2] target-ppc : Allow fc[tf]id[*] mnemonics for non TARGET_PPC64

2014-09-11 Thread Pierre Mallard
This patch remove limitation for fc[tf]id[*] on 32 bits targets and add a new insn flag for signed integer 64 conversion PPC2_FP_CVT_S64 --- target-ppc/cpu.h|5 - target-ppc/fpu_helper.c |6 -- target-ppc/helper.h |4 +--- target-ppc/translate.c |

Re: [Qemu-devel] [PATCH 00/23] Split BlockBackend off BDS with an axe

2014-09-11 Thread Markus Armbruster
Review led to a couple of changes with ripple effects on later patches. I suggest y'all await my v2 before you continue. Thanks a lot for the review so far!

[Qemu-devel] [PATCH 2/2] target-ppc : Add new processor type 440x5wDFPU

2014-09-11 Thread Pierre Mallard
This patch add a new processor type 440x5wDFPU for Virtex 5 PPC440 with an external APU FPU in double precision mode --- target-ppc/cpu-models.c |3 +++ target-ppc/translate_init.c | 38 ++ 2 files changed, 41 insertions(+) diff --git a/target-ppc/cpu

Re: [Qemu-devel] [PATCH 11/23] block: Rename BlockDriverAIOCB* to BlockAIOCB*

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > I think you should rebase this on top of Fam's null driver. This patch is prone to conflicts, but I expect them to be trivial. I'll rebase onto whatever is current when we're ready to merge.

[Qemu-devel] [PATCH 0/2] Enabling floating point instruction to 440x5 CPUs

2014-09-11 Thread Pierre Mallard
This patch series enable floating point instruction in 440x5 CPUs which have the capabilities to have optional APU FPU in double precision mode. 1) Allow fc[tf]id[*] mnemonics for non TARGET_PPC64 with a new insn2 flag 2) Create a new 440x5 implementing floating point instructions Pierre Mallard

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > I have trouble to review this as I don't understand the qdevs parts. > Maybe someone else could have a look at it. The patch is big, but all it really does is replacing dinfo->bdrv by blk_bs(blk_legacy_dinfo(dinfo)) Line wrapping muddies the waters a bit. I al

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: >> + blk_bs(blk_by_legacy_dinfo(dinfo))); > > This seems to be a fairly common pattern: "blk_bs(blk_by_legacy_dinfo())". > How about a helper function ? Yes, except the pattern is going to evaporate in patch 14 :)

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Thursday 11 Sep 2014 à 07:00:41 (-0600), Eric Blake wrote : >> On 09/11/2014 05:34 AM, Benoît Canet wrote: >> > The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : >> >> device_name[] is can become non-empty only in bdrv_new_named() and >> >> bdrv_mo

[Qemu-devel] [Bug 1361912] Re: qemu-mips64 Segmentation fault

2014-09-11 Thread Hill
I can see the problem with any simple program: 1. cat t.c #include int main() { printf("Hello QEMU.\n"); } 2. mips64-gcc -static t.c -o t 3. qemu-mips64 t qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault (core dumped) I built QEMU on Ubuntu 12.04 with the s

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : >> device_name[] is can become non-empty only in bdrv_new_named() and >> bdrv_move_feature_fields(). The latter is used only to undo damage >> done by bdrv_swap(). The former is called only by blk_new

Re: [Qemu-devel] [virtio-dev] Re: [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-11 Thread Paolo Bonzini
> On Do, 2014-09-11 at 16:20 +0100, Peter Maydell wrote: > > On 11 September 2014 16:09, Gerd Hoffmann wrote: > > > This patch adds the header file with structs and defines for > > > the virtio based gpu device. Covers 2d operations only. > > > > Please don't cc subscriber only mailing lists > >

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Markus Armbruster
Eric Blake writes: > On 09/10/2014 02:13 AM, Markus Armbruster wrote: >> device_name[] is can become non-empty only in bdrv_new_named() and > > s/is // Fixing, thanks! >> bdrv_move_feature_fields(). The latter is used only to undo damage >> done by bdrv_swap(). The former is called only by bl

Re: [Qemu-devel] [PATCH 07/23] block: Eliminate bdrv_iterate(), use bdrv_next()

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 à 10:13:36 (+0200), Markus Armbruster wrote : [...] >> --- a/monitor.c >> +++ b/monitor.c >> @@ -4208,24 +4208,6 @@ static void file_completion(Monitor *mon, const char >> *input) >> closedir(ffs); >> } >> >> -typedef struct MonitorBlockCo

Re: [Qemu-devel] [PATCH v5] virtio-pci: enable bus master for old guests

2014-09-11 Thread Greg Kurz
On Thu, 11 Sep 2014 21:20:03 +0300 "Michael S. Tsirkin" wrote: > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > pci: Use bus master address space for delivering MSI/MSI-X messages > breaks virtio-net for rhel6.[56] x86 guests because they don't > enable bus mastering for virtio PCI devices

[Qemu-devel] [Bug 1361912] Re: qemu-mips64 Segmentation fault

2014-09-11 Thread Leon Alrae
I forgot to add that qemu-mips64 works for me, that's why I asked for the details to reproduce the issue (i.e. what is "lang", what tools you used to build it, command line etc.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:/

Re: [Qemu-devel] [PATCH 05/23] block: Make BlockBackend own its BlockDriverState

2014-09-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.09.2014 um 10:13 hat Markus Armbruster geschrieben: >> On BlockBackend destruction, unref its BlockDriverState. Replaces the >> callers' unrefs. >> >> Signed-off-by: Markus Armbruster >> --- >> block/block-backend.c | 9 ++--- >> blockdev.c| 11 +++-

[Qemu-devel] [PATCH v5] virtio-pci: enable bus master for old guests

2014-09-11 Thread Michael S. Tsirkin
commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address space for delivering MSI/MSI-X messages breaks virtio-net for rhel6.[56] x86 guests because they don't enable bus mastering for virtio PCI devices. For the same reason, rhel6.[56] ppc64 guests cannot boot on a virtio-bl

Re: [Qemu-devel] ui causes latest master build failure on rhel6

2014-09-11 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 05:21:13PM +0200, Gerd Hoffmann wrote: > On Do, 2014-09-11 at 17:59 +0300, Michael S. Tsirkin wrote: > > I observe two errors with latest master: > > > > ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’: > > ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ undecla

[Qemu-devel] [PATCH v4] virtio-pci: enable bus master for old guests

2014-09-11 Thread Michael S. Tsirkin
commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address space for delivering MSI/MSI-X messages breaks virtio-net for rhel6.[56] x86 guests because they don't enable bus mastering for virtio PCI devices. For the same reason, rhel6.[56] ppc64 guests cannot boot on a virtio-bl

Re: [Qemu-devel] [PATCH 3/3] xenfb: Add "feature-no-abs-rescale" for Windows PV frontend

2014-09-11 Thread Stefano Stabellini
On Thu, 11 Sep 2014, Owen Smith wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 11 September 2014 02:23 > > To: Owen Smith > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Stefano Stabellini > > Subject: Re: [PATCH 3/3] x

Re: [Qemu-devel] [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

2014-09-11 Thread Stefano Stabellini
On Thu, 11 Sep 2014, Owen Smith wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 11 September 2014 02:01 > > To: Owen Smith > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Stefano Stabellini > > Subject: Re: [PATCH 2/3] x

Re: [Qemu-devel] [PATCH 04/23] block: Connect BlockBackend and DriveInfo

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 à 10:13:33 (+0200), Markus Armbruster wrote : >> Make the BlockBackend own the DriveInfo. Change blockdev_init() to >> return the BlockBackend instead of the DriveInfo. >> >> Signed-off-by: Markus Armbruster >> --- >> block/block-backend.c

[Qemu-devel] [PATCH v3] virtio-pci: enable bus master for old guests

2014-09-11 Thread Michael S. Tsirkin
commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address space for delivering MSI/MSI-X messages breaks virtio-net for rhel6.[56] x86 guests because they don't enable bus mastering for virtio PCI devices. For the same reason, rhel6.[56] ppc64 guests cannot boot on a virtio-bl

Re: [Qemu-devel] [PATCH v2] virtio-pci: enable bus master for old guests

2014-09-11 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 06:00:39PM +0200, Greg Kurz wrote: > On Wed, 10 Sep 2014 20:30:47 +0300 > "Michael S. Tsirkin" wrote: > > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > > pci: Use bus master address space for delivering MSI/MSI-X messages > > breaks virtio-net for rhel6.[56] x86

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-11 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 08:47:01PM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 11, 2014 at 06:45:33PM +0200, Greg Kurz wrote: > > From: Michael S. Tsirkin > > > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > > pci: Use bus master address space for delivering MSI/MSI-X messages > > bre

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-11 Thread Dr. David Alan Gilbert
(I've cc'd in Fam, Stefan, and Kevin for Block stuff, and Yang and Eddie for Colo) * Walid Nouri (walid.no...@gmail.com) wrote: > Hello Michael, Hello Paolo > i have ???studied??? the available documentation/Information and tried to > get an idea of the QEMU live block operation pos

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-11 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 06:45:33PM +0200, Greg Kurz wrote: > From: Michael S. Tsirkin > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > pci: Use bus master address space for delivering MSI/MSI-X messages > breaks virtio-net for rhel6.[56] x86 guests because they don't > enable bus masteri

Re: [Qemu-devel] [PATCH 04/23] block: Connect BlockBackend and DriveInfo

2014-09-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.09.2014 um 10:13 hat Markus Armbruster geschrieben: >> Make the BlockBackend own the DriveInfo. Change blockdev_init() to >> return the BlockBackend instead of the DriveInfo. >> >> Signed-off-by: Markus Armbruster >> --- >> block/block-backend.c | 38 +++

Re: [Qemu-devel] [Bug 1361912] Re: qemu-mips64 Segmentation fault

2014-09-11 Thread Hill
This is a error in user mode, I think it should be very easy to reproduce. On Thu, Sep 11, 2014 at 4:55 AM, Leon Alrae wrote: > Could you please provide backtrace and give more details to reproduce > the issue? > > -- > You received this bug notification because you are subscribed to the bug > r

Re: [Qemu-devel] [edk2] OVMF, Q35 and USB keyboard/mouse

2014-09-11 Thread Paolo Bonzini
Il 11/09/2014 19:11, Gabriel L. Somlo ha scritto: > On Thu, Sep 11, 2014 at 06:40:38PM +0200, Paolo Bonzini wrote: >> Il 11/09/2014 18:35, Gabriel L. Somlo ha scritto: > Can you configure Chamaleon to avoid the boot prompt? >>> Yes. After doing that, usb starts working once OS X is fully booted

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-11 Thread Gabriel L. Somlo
On Thu, Sep 11, 2014 at 06:40:38PM +0200, Paolo Bonzini wrote: > Il 11/09/2014 18:35, Gabriel L. Somlo ha scritto: > >> > Can you configure Chamaleon to avoid the boot prompt? > > Yes. After doing that, usb starts working once OS X is fully booted. > > > > Works with either piix or q35 just fine.

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Benoît Canet
> + blk_bs(blk_by_legacy_dinfo(dinfo))); This seems to be a fairly common pattern: "blk_bs(blk_by_legacy_dinfo())". How about a helper function ?

Re: [Qemu-devel] [BUG] Guest kernel divide error in kvm_unlock_kick

2014-09-11 Thread Chris Webb
Paolo Bonzini wrote: > This is a hypercall that should have kicked VCPU 3 (see rcx). > > Can you please apply this patch and gather a trace of the host > (using "trace-cmd -e kvm qemu-kvm ")? Sure, no problem. I've built the trace-cmd tool against udis86 (I hope) and have put the resulting trac

Re: [Qemu-devel] [PATCH v2] virtio-pci: enable bus master for old guests

2014-09-11 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 06:00:39PM +0200, Greg Kurz wrote: > On Wed, 10 Sep 2014 20:30:47 +0300 > "Michael S. Tsirkin" wrote: > > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > > pci: Use bus master address space for delivering MSI/MSI-X messages > > breaks virtio-net for rhel6.[56] x86

[Qemu-devel] [PATCH v3 1/4] hw/arm/boot: load DTB as a ROM image

2014-09-11 Thread Ard Biesheuvel
In order to make the device tree blob (DTB) available in memory not only at first boot, but also after system reset, use rom_blob_add_fixed() to install it into memory. Reviewed-by: Peter Maydell Signed-off-by: Ard Biesheuvel --- hw/arm/boot.c | 5 - 1 file changed, 4 insertions(+), 1 delet

[Qemu-devel] [PATCH v3 4/4] hw/arm/boot: enable DTB support when booting ELF images

2014-09-11 Thread Ard Biesheuvel
Add support for loading DTB images when booting ELF images using -kernel. If there are no conflicts with the placement of the ELF segments, the DTB image is loaded at the base of RAM. Signed-off-by: Ard Biesheuvel --- hw/arm/boot.c | 22 -- 1 file changed, 20 insertions(+), 2

[Qemu-devel] [PATCH v3 2/4] hw/arm/boot: pass an address limit to and return size from load_dtb()

2014-09-11 Thread Ard Biesheuvel
Add an address limit input parameter to load_dtb() so that we can tell load_dtb() how much memory the dtb is allowed to consume. If the dtb doesn't fit, return 0, otherwise return the actual size of the loaded dtb. Reviewed-by: Peter Maydell Signed-off-by: Ard Biesheuvel --- hw/arm/boot.c | 34

[Qemu-devel] [PATCH v3 3/4] hw/arm/boot: load device tree to base of DRAM if no -kernel option was passed

2014-09-11 Thread Ard Biesheuvel
If we are running the 'virt' machine, we may have a device tree blob but no kernel to supply it to if no -kernel option was passed. In that case, copy it to the base of RAM where it can be picked up by a bootloader. Signed-off-by: Ard Biesheuvel --- hw/arm/boot.c | 10 ++ 1 file changed,

[Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-11 Thread Greg Kurz
From: Michael S. Tsirkin commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address space for delivering MSI/MSI-X messages breaks virtio-net for rhel6.[56] x86 guests because they don't enable bus mastering for virtio PCI devices. For the same reason, rhel6.[56] ppc64 guests

[Qemu-devel] [PATCH v3 0/4] ARM: load_dtb() changes for -bios and ELF images

2014-09-11 Thread Ard Biesheuvel
I split off these patches from the series I sent last week. Peter's NOR flash patch has been merged in the mean time, and the CPU reset patch needs to be discussed more widely before we can move forward with it. So what remains are changes in the DTB handling in hw/arm/boot.c, to load a DTB even w

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-11 Thread Paolo Bonzini
Il 11/09/2014 18:35, Gabriel L. Somlo ha scritto: >> > Can you configure Chamaleon to avoid the boot prompt? > Yes. After doing that, usb starts working once OS X is fully booted. > > Works with either piix or q35 just fine. > > Does this mean it's likely to be an OVMF uhci/ehci issue specific to

  1   2   3   >