Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-10 Thread Fam Zheng
On Wed, 09/10 10:13, Markus Armbruster wrote: > Creating an anonymous BDS can't fail. Make that obvious. > > Signed-off-by: Markus Armbruster > --- > block.c | 26 +++--- > block/iscsi.c | 2 +- > block/vvfat.c | 2 +- > blockdev.c

Re: [Qemu-devel] ballooning not working on hotplugged pc-dimm

2014-09-10 Thread zhanghailiang
On 2014/9/11 14:27, Michael R. Hines wrote: On 09/11/2014 02:22 PM, Paolo Bonzini wrote: Il 11/09/2014 03:57, Michael R. Hines ha scritto: Why does hotplugging use a different name? This also affects RDMA live migration - we are explicitly looking up "pc.ram" ram blocks and pinning them for me

Re: [Qemu-devel] ballooning not working on hotplugged pc-dimm

2014-09-10 Thread Michael R. Hines
On 09/11/2014 02:22 PM, Paolo Bonzini wrote: Il 11/09/2014 03:57, Michael R. Hines ha scritto: Why does hotplugging use a different name? This also affects RDMA live migration - we are explicitly looking up "pc.ram" ram blocks and pinning them for memory registration with Linux. Are we? I can

Re: [Qemu-devel] ballooning not working on hotplugged pc-dimm

2014-09-10 Thread Paolo Bonzini
Il 11/09/2014 03:57, Michael R. Hines ha scritto: >> > > Why does hotplugging use a different name? > > This also affects RDMA live migration - we are explicitly looking up > "pc.ram" ram blocks and pinning them for memory registration with Linux. Are we? I cannot see any code that special case

[Qemu-devel] [PATCH v7 3/3] qapi: Sort items in BlockdevOptions definition

2014-09-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qapi/block-core.json | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 35191b4..5adef27 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1483,4

Re: [Qemu-devel] [question] virtio-blk performance degradationhappenedwith virito-serial

2014-09-10 Thread Amit Shah
On (Sun) 07 Sep 2014 [17:46:26], Zhang Haoyu wrote: > Hi, Paolo, Amit, > any ideas? I'll check this, thanks for testing with Linux guests. Amit

[Qemu-devel] [PATCH v7 2/3] qapi: Sort BlockdevDriver enum data list

2014-09-10 Thread Fam Zheng
Reviewed-by: Benoît Canet Signed-off-by: Fam Zheng --- qapi/block-core.json | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index bf0cb23..35191b4 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1147,11 +

[Qemu-devel] [PATCH v7 1/3] block: Introduce "null" drivers

2014-09-10 Thread Fam Zheng
This is an analogue to Linux null_blk. It can be used for testing or benchmarking block device emulation and general block layer functionalities such as coroutines and throttling, where disk IO is not necessary or wanted. Use null-aio:// for AIO version, and null-co:// for coroutine version. Sign

[Qemu-devel] [PATCH v7 0/3] block: Introduce "null" drivers

2014-09-10 Thread Fam Zheng
v7: Add Benoît's rev-by line in patch 2. Improved help text in patch 1. (Benoît) v6: Don't inherit from BlockdevOptionsFile. (Stefan) Use .bdrv_co_readv instead of .bdrv_read. (Kevin) Sort items in qapi schema definitions in patch 2 & 3. Fam Zheng (3): block: Introduce "null" drive

Re: [Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery during eoi broadcast

2014-09-10 Thread Jan Kiszka
On 2014-09-11 07:06, Zhang Haoyu wrote: > Currently, we call ioapic_service() immediately when we find the irq is still > active during eoi broadcast. But for real hardware, there's some dealy between > the EOI writing and irq delivery (system bus latency?). So we need to emulate > this behavior. O

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-10 Thread Gonglei (Arei)
> > 主题: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take > > effect after rebooting > > > > From: Gonglei > > > > Sometimes, we want to modify boot order of a guest, but no need to > shutdown > > it. We can call dynamic changing bootindex of a guest, which can be assured > > taki

Re: [Qemu-devel] [PATCH v6 1/3] block: Introduce "null" drivers

2014-09-10 Thread Fam Zheng
On Wed, 09/10 15:27, Benoît Canet wrote: > The Wednesday 10 Sep 2014 à 11:08:46 (+0800), Fam Zheng wrote : > > This is an analogue to Linux null_blk. It can be used for testing or > > benchmarking block device emulation and general block layer > > functionalities such as coroutines and throttling,

Re: [Qemu-devel] [PATCH v6 3/3] qapi: Sort items in BlockdevOptions definition

2014-09-10 Thread Fam Zheng
On Wed, 09/10 15:32, Benoît Canet wrote: > The Wednesday 10 Sep 2014 à 11:08:48 (+0800), Fam Zheng wrote : > > Signed-off-by: Fam Zheng > > --- > > qapi/block-core.json | 38 +++--- > > 1 file changed, 19 insertions(+), 19 deletions(-) > > > > diff --git a/qapi/bl

[Qemu-devel] [PATCH v6 19/22] win32-aio: Drop win32_aiocb_info.cancel

2014-09-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/win32-aio.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/block/win32-aio.c b/block/win32-aio.c index 5030e32..eed86f7 100644 --- a/block/win32-aio.c +++ b/block/win32-aio.c @@ -106,22 +106,8 @@ static void win32_aio_completion_cb(EventNotif

[Qemu-devel] [PATCH v6 22/22] block: Rename qemu_aio_release -> qemu_aio_unref

2014-09-10 Thread Fam Zheng
Suggested-by: Benoît Canet Signed-off-by: Fam Zheng --- block.c | 8 block/archipelago.c | 4 ++-- block/blkdebug.c| 2 +- block/blkverify.c | 2 +- block/curl.c| 10 +- block/iscsi.c | 6 +++--- block/linux-aio.c | 4 ++-- block/qed.c

[Qemu-devel] [PATCH v6 21/22] block: Drop AIOCBInfo.cancel

2014-09-10 Thread Fam Zheng
Now that all the implementations are converted to asynchronous version and we can emulate synchronous cancellation with it. Let's drop the unused member. Signed-off-by: Fam Zheng --- block.c | 24 ++-- include/block/aio.h | 1 - 2 files changed, 10 insertions(+),

[Qemu-devel] [PATCH v6 17/22] rbd: Drop rbd_aiocb_info.cancel

2014-09-10 Thread Fam Zheng
And also drop the now unused "cancelled" field. Signed-off-by: Fam Zheng --- block/rbd.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index ea969e7..349d465 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -77,7 +77,6 @@ typed

[Qemu-devel] [PATCH v6 20/22] ide: Convert trim_aiocb_info.cancel to .cancel_async

2014-09-10 Thread Fam Zheng
We know that either bh is scheduled or ide_issue_trim_cb will be called again, so we just set i, j and ret to the right values. In both cases, ide_trim_bh_cb will be called. Also forward the cancellation to the iocb->aiocb which we get from bdrv_aio_discard. Signed-off-by: Fam Zheng --- hw/ide/

[Qemu-devel] [PATCH v6 16/22] quorum: Convert quorum_aiocb_info.cancel to .cancel_async

2014-09-10 Thread Fam Zheng
Before, we cancel all the child requests with bdrv_aio_cancel, then free the acb.. Now we just kick off asynchronous cancellation of child requests and return, we know quorum_aio_cb will be called later, so in the end quorum_aio_finalize will take care of calling the caller's cb. Signed-off-by: F

[Qemu-devel] [PATCH v6 18/22] sheepdog: Convert sd_aiocb_info.cancel to .cancel_async

2014-09-10 Thread Fam Zheng
Also drop the now unused SheepdogAIOCB.finished field. Note that this aio is internal to sheepdog driver and has NULL cb and opaque, and should be unused at all. Signed-off-by: Fam Zheng --- block/sheepdog.c | 46 +++--- 1 file changed, 19 insertions(+), 2

[Qemu-devel] [PATCH v6 14/22] qed: Drop qed_aiocb_info.cancel

2014-09-10 Thread Fam Zheng
Also drop the now unused ->finished field. Signed-off-by: Fam Zheng --- block/qed.c | 21 - 1 file changed, 21 deletions(-) diff --git a/block/qed.c b/block/qed.c index ba395af..07cdb47 100644 --- a/block/qed.c +++ b/block/qed.c @@ -18,22 +18,8 @@ #include "qapi/qmp/qerror.

[Qemu-devel] [PATCH v6 15/22] quorum: fix quorum_aio_cancel()

2014-09-10 Thread Fam Zheng
From: Liu Yuan For a fifo read pattern, we only have one running aio (possible other cases that has less number than num_children in the future), so we need to check if .acb is NULL against bdrv_aio_cancel() to avoid segfault. Cc: Eric Blake Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi

[Qemu-devel] [PATCH v6 09/22] iscsi: Convert iscsi_aiocb_info.cancel to .cancel_async

2014-09-10 Thread Fam Zheng
Also drop the unused field "canceled". Signed-off-by: Fam Zheng --- block/iscsi.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 3e19202..a0aca5f 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -88,7 +88,6 @@ typedef s

[Qemu-devel] [PATCH v6 08/22] dma: Convert dma_aiocb_info.cancel to .cancel_async

2014-09-10 Thread Fam Zheng
Just forward the request to bdrv_aio_cancel_async. Signed-off-by: Fam Zheng --- dma-helpers.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index 499b52b..5a46e5c 100644 --- a/dma-helpers.c +++ b/dma-helpers.c @@ -73,7 +73

[Qemu-devel] [PATCH v6 12/22] blkverify: Drop blkverify_aiocb_info.cancel

2014-09-10 Thread Fam Zheng
Also the finished pointer is not used any more. Signed-off-by: Fam Zheng --- block/blkverify.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index 163064c..460393f 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -29,7 +29,

[Qemu-devel] [PATCH v6 07/22] linux-aio: Convert laio_aiocb_info.cancel to .cancel_async

2014-09-10 Thread Fam Zheng
Just call io_cancel (2), if it fails, it means the request is not canceled, so the event loop will eventually call qemu_laio_process_completion. In qemu_laio_process_completion, change to call the cb unconditionally. It is required by bdrv_aio_cancel_async. Signed-off-by: Fam Zheng --- block/li

[Qemu-devel] [PATCH v6 13/22] curl: Drop curl_aiocb_info.cancel

2014-09-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/curl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/block/curl.c b/block/curl.c index 938f9d9..6f5d6ae 100644 --- a/block/curl.c +++ b/block/curl.c @@ -613,14 +613,8 @@ out_noclean: return -EINVAL; } -static void curl_aio_cancel(BlockDriverAI

[Qemu-devel] [PATCH v6 06/22] thread-pool: Convert thread_pool_aiocb_info.cancel to cancel_async

2014-09-10 Thread Fam Zheng
The .cancel_async shares the same the first half with .cancel: try to steal the request if not submitted yet. In this case set the elem to THREAD_DONE status and ret to -ECANCELED, which means thread_pool_completion_bh will call the cb with -ECANCELED. If the request is already submitted, do nothi

[Qemu-devel] [PATCH v6 11/22] blkdebug: Drop blkdebug_aiocb_info.cancel

2014-09-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/blkdebug.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 69b330e..08131b3 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -52,11 +52,8 @@ typedef struct BlkdebugSuspendedReq

[Qemu-devel] [PATCH v6 03/22] block: Add bdrv_aio_cancel_async

2014-09-10 Thread Fam Zheng
This is the async version of bdrv_aio_cancel, which doesn't block the caller. It guarantees that the cb is called either before returning or some time later. bdrv_aio_cancel can base on bdrv_aio_cancel_async, later we can convert all .io_cancel implementations to .io_cancel_async, and the aio_poll

[Qemu-devel] [PATCH v6 05/22] block: Drop bdrv_em_aiocb_info.cancel

2014-09-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/block.c b/block.c index 6193883..349bb13 100644 --- a/block.c +++ b/block.c @@ -4675,18 +4675,8 @@ typedef struct BlockDriverAIOCBSync { int is_write; } BlockDriverAIOCBSync; -static void b

[Qemu-devel] [PATCH v6 04/22] block: Drop bdrv_em_co_aiocb_info.cancel

2014-09-10 Thread Fam Zheng
Also drop the now unused ->done pointer. Signed-off-by: Fam Zheng --- block.c | 21 - 1 file changed, 21 deletions(-) diff --git a/block.c b/block.c index 371082b..6193883 100644 --- a/block.c +++ b/block.c @@ -4757,22 +4757,8 @@ typedef struct BlockDriverAIOCBCoroutine {

[Qemu-devel] [PATCH v6 10/22] archipelago: Drop archipelago_aiocb_info.cancel

2014-09-10 Thread Fam Zheng
The cancelled flag is no longer useful. Later the request will complete as before, and cb will be called. Signed-off-by: Fam Zheng --- block/archipelago.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/block/archipelago.c b/block/archipelago.c index 22a7daa

[Qemu-devel] [PATCH v6 01/22] ide/ahci: Check for -ECANCELED in aio callbacks

2014-09-10 Thread Fam Zheng
Before, bdrv_aio_cancel will either complete the request (like normal) and call CB with an actual return code, or skip calling the request (for example when the IO req is not submitted by thread pool yet). We will change bdrv_aio_cancel to do it differently: always call CB before return, with eith

[Qemu-devel] [PATCH v6 02/22] block: Add refcnt in BlockDriverAIOCB

2014-09-10 Thread Fam Zheng
This will be useful in synchronous cancel emulation with bdrv_aio_cancel_async. Signed-off-by: Fam Zheng --- block.c | 12 +++- include/block/aio.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index d06dd51..c1ee860 100644 --- a/bl

[Qemu-devel] [PATCH v6 00/22] block: Asynchronous request cancellation

2014-09-10 Thread Fam Zheng
v6: Drop bdrv_em_aiocb_info.cancel in patch 5. (Paolo) v5: Fix IDE callback. (Paolo) Fix blkdebug. (Paolo) Drop the DMA fix which is independent of this series. (Paolo) Incorperate Yuan's patch on quorum_aio_cancel. (Benoît) Commit message wording fix. (Benoît) Rename qemu_aio_

[Qemu-devel] [PATCH] block: Split BLOCK_OP_TYPE_COMMIT to BLOCK_OP_TYPE_COMMIT_{SOURCE, TARGET}

2014-09-10 Thread Fam Zheng
Like BLOCK_OP_TYPE_BACKUP_SOURCE and BLOCK_OP_TYPE_BACKUP_TARGET, block-commit involves two asymmetric devices. This change is not user-visible (yet), because commit only works with device names. But once we enable backing reference in blockdev-add, or specifying node-name in block-commit command

[Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery during eoi broadcast

2014-09-10 Thread Zhang Haoyu
Currently, we call ioapic_service() immediately when we find the irq is still active during eoi broadcast. But for real hardware, there's some dealy between the EOI writing and irq delivery (system bus latency?). So we need to emulate this behavior. Otherwise, for a guest who haven't register a pro

[Qemu-devel] [PATCH 3/3] qemu-iotests: Test blockdev-backup in 055

2014-09-10 Thread Fam Zheng
This applies cases on drive-backup on blockdev-backup, except cases with target format and mode. Also add a case to check source == target. Signed-off-by: Fam Zheng --- tests/qemu-iotests/055 | 277 ++--- tests/qemu-iotests/055.out | 4 +- 2 files c

[Qemu-devel] [PATCH 2/3] block: Add blockdev-backup to transaction

2014-09-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 48 qapi-schema.json | 3 +++ 2 files changed, 51 insertions(+) diff --git a/blockdev.c b/blockdev.c index 516de7f..58565d7 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1424,6 +1424,49 @@ static voi

[Qemu-devel] [PATCH 0/3] qmp: Add "blockdev-backup"

2014-09-10 Thread Fam Zheng
The existing drive-backup command accepts a target file path, but that interface provides little flexibility on the properties of target block device, compared to what is possible with "blockdev-add", "drive_add" or "-drive". This is also a building block to allow image fleecing (creating a point

[Qemu-devel] [PATCH 1/3] qmp: Add command 'blockdev-backup'

2014-09-10 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible but is an illegal case with introduction of

Re: [Qemu-devel] [Xen-devel] [RFC Patch v3 23/22] Introduce "xen-load-devices-state"

2014-09-10 Thread Wen Congyang
On 09/11/2014 03:15 AM, Stefano Stabellini wrote: > On Tue, 9 Sep 2014, Wen Congyang wrote: >> At 09/06/2014 05:57 AM, Stefano Stabellini Write: >>> On Fri, 5 Sep 2014, Wen Congyang wrote: introduce a "xen-load-devices-state" QAPI command that can be used to load the state of all devices,

[Qemu-devel] [PATCH 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-10 Thread Jan Vesely
Signed-off-by: Jan Vesely --- hw/usb/dev-hid.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 67a57f1..b3d02b2 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @@ -566,9 +566,22 @@ static v

[Qemu-devel] [PATCH v3 2/3] usb-hid: Add high speed mouse configuration

2014-09-10 Thread Jan Vesely
v2: add usb_mouse_properties use macros for bmAttributes v3: rebase Signed-off-by: Jan Vesely --- hw/usb/dev-hid.c | 71 +++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index b3d02b2..6

[Qemu-devel] [PATCH 3/3] usb-hid: Add high speed keyboard configuration

2014-09-10 Thread Jan Vesely
Signed-off-by: Jan Vesely --- hw/usb/dev-hid.c | 66 +++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 643b013..ac7e393 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @@ -226,6 +22

Re: [Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration

2014-09-10 Thread Jan Vesely
Hi Gerd, sorry for taking so long to get back to this. My schedule has been super busy past couple of months. I have rebased the patches and moved the usb version desc selection to hid_initfn as you suggested. I also made the changes follow the tablet example as closely as possible I tested the p

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Fam Zheng
On Wed, 09/10 22:17, Eric Blake wrote: > On 09/10/2014 06:53 PM, Fam Zheng wrote: > > On Wed, 09/10 17:32, Paolo Bonzini wrote: > >> Il 10/09/2014 17:02, Fam Zheng ha scritto: > A bit hackish, but I don't have any better idea. > > Hmm... what about adding a new member to the visitors

Re: [Qemu-devel] [PATCH] tests: add QMP input visitor test for unions with no discriminator

2014-09-10 Thread Eric Blake
On 09/10/2014 07:02 PM, Michael Roth wrote: > This more an exercise of the dealloc visitor, where it may erroneously This is more of an exercise... > use an uninitialized discriminator field as indication that union > fields corresponding to that disciminator field/type are present, discriminato

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Eric Blake
On 09/10/2014 06:53 PM, Fam Zheng wrote: > On Wed, 09/10 17:32, Paolo Bonzini wrote: >> Il 10/09/2014 17:02, Fam Zheng ha scritto: A bit hackish, but I don't have any better idea. Hmm... what about adding a new member to the visitors for "invalid enum" value? The dealloc visito

Re: [Qemu-devel] [RFC V2 04/10] x86: add x86_cpu_unrealizefn() for cpu apic remove

2014-09-10 Thread Gu Zheng
Hi Igor, On 09/09/2014 09:58 PM, Igor Mammedov wrote: > On Thu, 28 Aug 2014 11:36:36 +0800 > Gu Zheng wrote: > >> From: Chen Fan >> >> Implement x86_cpu_unrealizefn() for corresponding x86_cpu_realizefn(), >> which is mostly used to clean the apic related allocation and vmstates >> at here. >>

Re: [Qemu-devel] [PATCH 1/5] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-09-10 Thread Gu Zheng
Hi Igor, On 09/10/2014 09:28 PM, Igor Mammedov wrote: > On Wed, 3 Sep 2014 17:06:13 +0800 > Gu Zheng wrote: > >> >> Signed-off-by: Gu Zheng >> --- >> hw/acpi/cpu_hotplug.c | 17 + >> include/hw/acpi/cpu_hotplug.h |3 +++ >> 2 files changed, 20 insertions(+), 0 de

Re: [Qemu-devel] [PATCH 0/5] cpu/acpi: convert cpu hot plug to hotplug_handler API

2014-09-10 Thread Gu Zheng
Hi Igor, Thanks very much for your review and suggestion. On 09/10/2014 10:12 PM, Igor Mammedov wrote: > On Wed, 3 Sep 2014 17:06:12 +0800 > Gu Zheng wrote: > >> >> Gu Zheng (5): >> acpi/cpu: add cpu hotplug callback function to match hotplug_handler >> API >> acpi:ich9: convert cpu hot

Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW

2014-09-10 Thread Alexey Kardashevskiy
On 09/11/2014 07:17 AM, Alexander Graf wrote: > > > On 10.09.14 17:00, Alexey Kardashevskiy wrote: >> On 09/10/2014 11:03 PM, Alexander Graf wrote: >>> >>> >>> On 29.08.14 12:12, Alexey Kardashevskiy wrote: This implements DDW for VFIO. Host kernel support is required for this. Aft

Re: [Qemu-devel] [RFC PATCH v3 13/18] spapr_pci: Enable DDW

2014-09-10 Thread Alexey Kardashevskiy
On 09/11/2014 07:16 AM, Alexander Graf wrote: > > > On 10.09.14 16:58, Alexey Kardashevskiy wrote: >> On 09/10/2014 11:01 PM, Alexander Graf wrote: >>> >>> >>> On 29.08.14 12:12, Alexey Kardashevskiy wrote: This implements DDW for emulated PHB. This advertises the query/create/remo

Re: [Qemu-devel] [PATCH v2] blkdebug: make the fault injection functionality callable from QMP

2014-09-10 Thread Hitoshi Mitake
Hi Stefan, Eric, Sorry for my late reply. At Tue, 2 Sep 2014 16:29:14 +0100, Stefan Hajnoczi wrote: > > [1 ] > On Thu, Aug 28, 2014 at 03:18:48PM +0900, Hitoshi Mitake wrote: > > At Wed, 27 Aug 2014 06:43:49 -0600, > > Eric Blake wrote: > > > > > > [1 ] > > > On 08/26/2014 11:34 PM, Hitoshi M

Re: [Qemu-devel] ballooning not working on hotplugged pc-dimm

2014-09-10 Thread Michael R. Hines
On 09/10/2014 05:00 PM, zhanghailiang wrote: On 2014/9/9 11:05, Alexandre DERUMIER wrote: Hello, I was playing with pc-dimm hotplug, and I notice that balloning is not working on memory space of pc-dimm devices. example: qemu -m size=1024,slots=255,maxmem=15000M #free -m : 1024M -> qmp ba

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-10 Thread Michael R. Hines
On 09/10/2014 11:43 PM, Walid Nouri wrote: Hello Michael, Hello Paolo i have „studied“ the available documentation/Information and tried to get an idea of the QEMU live block operation possibilities. I think the MC protocol doesn’t need synchronous block device replication because primary and

Re: [Qemu-devel] [PATCH 3/3] xenfb: Add "feature-no-abs-rescale" for Windows PV frontend

2014-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2014, Owen smith wrote: > Windows PV frontend requires absolute mouse values in the range > [0, 0x7fff]. Add a feature to not rescale the axes to DisplaySurface > size. Also allows Windows PV frontend to connect without a vfb > device. Moves the rescaling of axes to a seperate functi

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 3/4] target-ppc: Build error log

2014-09-10 Thread Alexey Kardashevskiy
On 09/05/2014 06:28 PM, Aravinda Prasad wrote: > > > On Friday 05 September 2014 01:34 PM, Alexander Graf wrote: >> >> >> On 04.09.14 13:13, Aravinda Prasad wrote: >>> Whenever there is a physical memory error due to bit >>> flips, which cannot be corrected by hardware, the error >>> is passed on

Re: [Qemu-devel] [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

2014-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2014, Owen smith wrote: > The vkbd device should be able to use a grant reference to map the > shared page. > > Signed-off-by: Owen smith > --- > hw/display/xenfb.c | 39 +-- > 1 file changed, 29 insertions(+), 10 deletions(-) > > diff --git a/

[Qemu-devel] [PATCH] tests: add QMP input visitor test for unions with no discriminator

2014-09-10 Thread Michael Roth
This more an exercise of the dealloc visitor, where it may erroneously use an uninitialized discriminator field as indication that union fields corresponding to that disciminator field/type are present, which can lead to attempts to free random chunks of heap memory. Signed-off-by: Michael Roth -

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Michael Roth
Quoting Fam Zheng (2014-09-10 07:30:39) > We shouldn't do anything in the switch block in enum's visit_type_ > function, when the enum data's ->kind is not valid at all. This happens > when the dealloc visitor is called, after qmp input visitor returned > error. Comment is kind of confusing. Enum

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Fam Zheng
On Wed, 09/10 17:32, Paolo Bonzini wrote: > Il 10/09/2014 17:02, Fam Zheng ha scritto: > > > A bit hackish, but I don't have any better idea. > > > > > > Hmm... what about adding a new member to the visitors for "invalid enum" > > > value? The dealloc visitor could override it to do nothing, whil

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-10 Thread Fam Zheng
On Wed, 09/10 09:14, Eric Blake wrote: > On 09/10/2014 02:54 AM, Fam Zheng wrote: > > >> Let's think of a situation that recursive blockers protect but > >> backing_blocker does not: > >> > >> a <- b <- c <- d > >> > >> c is the backing file and is therefore protected by the op blocker. > >> > >>

Re: [Qemu-devel] [PATCH 1/3] xenfb: Unregister keyboard event handler correctly

2014-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2014, Owen smith wrote: > Keyboard event handler was replaced with a new handler on disconnect. > Use the unregister function to remove keyboard handler. > > Signed-off-by: Owen smith > --- > hw/display/xenfb.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [edk2] OVMF, Q35 and USB keyboard/mouse

2014-09-10 Thread Paolo Bonzini
Il 10/09/2014 16:06, Gabriel L. Somlo ha scritto: > If it's in QEMU, it's only tickled by the OVMF + OSX combination. > Fedora works (around it) fine, and everyone's happy when using > SeaBIOS (and Chameleon, in OSX's case). > > BTW, when I do something like this: > > -usb -device ich9-usb-uhci1,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] Enabling floating point instruction to 440x5 CPUs

2014-09-10 Thread Pierre Mallard
On Wed, Sep 10, 2014 at 7:15 PM, Tom Musta wrote: > > (1) Eliminate the TARGET_PPC64 checks for all six FP Doubleword Integer > Conversion instructions. > There is also fcfids and fcfidus which leads to 8 instructions (fcfid, fcfids, fcfidu, fcfidus and fctid, fctidz, fctidu, fctiduz), is this r

Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:30 (+0200), Markus Armbruster wrote : > Creating an anonymous BDS can't fail. Make that obvious. > > Signed-off-by: Markus Armbruster > --- > block.c | 26 +++--- > block/iscsi.c | 2 +- > block/vvfat.c | 2 +-

Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW

2014-09-10 Thread Alexander Graf
On 10.09.14 17:00, Alexey Kardashevskiy wrote: > On 09/10/2014 11:03 PM, Alexander Graf wrote: >> >> >> On 29.08.14 12:12, Alexey Kardashevskiy wrote: >>> This implements DDW for VFIO. Host kernel support is required for this. >>> >>> After this patch DDW will be enabled on all machines but pseri

Re: [Qemu-devel] [RFC PATCH v3 13/18] spapr_pci: Enable DDW

2014-09-10 Thread Alexander Graf
On 10.09.14 16:58, Alexey Kardashevskiy wrote: > On 09/10/2014 11:01 PM, Alexander Graf wrote: >> >> >> On 29.08.14 12:12, Alexey Kardashevskiy wrote: >>> This implements DDW for emulated PHB. >>> >>> This advertises the query/create/remove RTAS tokens in device tree. >>> This does not advertise

[Qemu-devel] [ANNOUNCE] QEMU 2.1.1 Stable released

2014-09-10 Thread Michael Roth
Hi everyone, I am pleased to announce that the QEMU v2.1.1 stable release is now available at: http://wiki.qemu.org/download/qemu-2.1.1.tar.bz2 v2.1.1 is now tagged in the official qemu.git repository, and the stable-2.1 branch has been updated accordingly: http://git.qemu.org/?p=qemu.git;a

Re: [Qemu-devel] [Xen-devel] [RFC Patch v3 23/22] Introduce "xen-load-devices-state"

2014-09-10 Thread Stefano Stabellini
On Tue, 9 Sep 2014, Wen Congyang wrote: > At 09/06/2014 05:57 AM, Stefano Stabellini Write: > > On Fri, 5 Sep 2014, Wen Congyang wrote: > >> introduce a "xen-load-devices-state" QAPI command that can be used to load > >> the state of all devices, but not the RAM or the block devices of the > >> VM.

[Qemu-devel] [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

2014-09-10 Thread Owen smith
The vkbd device should be able to use a grant reference to map the shared page. Signed-off-by: Owen smith --- hw/display/xenfb.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 2c39753..c4

[Qemu-devel] [PATCH 0/3] xenfb: Add support for Windows PV frontend

2014-09-10 Thread Owen smith
This patch series contains improvments for the Xen vkbd backend to support a Windows PV frontend mouse and keyboard. This allows VNC connections to have an absolute pointer without the USB tablet device enabled, and any unneccessary polling associated with the USB devices. This patch series conta

[Qemu-devel] [PATCH 1/3] xenfb: Unregister keyboard event handler correctly

2014-09-10 Thread Owen smith
Keyboard event handler was replaced with a new handler on disconnect. Use the unregister function to remove keyboard handler. Signed-off-by: Owen smith --- hw/display/xenfb.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.

[Qemu-devel] [PATCH 3/3] xenfb: Add "feature-no-abs-rescale" for Windows PV frontend

2014-09-10 Thread Owen smith
Windows PV frontend requires absolute mouse values in the range [0, 0x7fff]. Add a feature to not rescale the axes to DisplaySurface size. Also allows Windows PV frontend to connect without a vfb device. Moves the rescaling of axes to a seperate function with additional null-pointer checks. Signed

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] Enabling floating point instruction to 440x5 CPUs

2014-09-10 Thread Pierre Mallard
Thanks for your review Alexander and Tom. All your proposition looks fine to me. Xilinx Virtex5 is not ISA compliant and does not support unsigned conversions, that's why I left all unsigned version as it was but you are right, PPC_FLOAT_64 is such a bad name ! Adding this flag to all CPU seems ok

[Qemu-devel] [PATCH v2] virtio-pci: enable bus master for old guests

2014-09-10 Thread Michael S. Tsirkin
commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address space for delivering MSI/MSI-X messages breaks virtio-net for rhel6.[56] x86 guests because they don't enable bus mastering for virtio PCI devices Old guests forgot to enable bus mastering, enable it automatically when

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] Enabling floating point instruction to 440x5 CPUs

2014-09-10 Thread Tom Musta
On 9/10/2014 4:20 AM, Alexander Graf wrote: > > > On 10.09.14 07:03, Pierre Mallard wrote: >> This patch series enable floating point instruction in 440x5 CPUs >> which have the capabilities to have optional APU FPU. >> >> 1) Add floating point standard insns flag to 440x5 in case there is an ap

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] target-ppc : Add PPC_FLOAT_64 type to fctid, fctidz and fcfid and remove their TARGET_PPC64 restriction

2014-09-10 Thread Tom Musta
On 9/10/2014 4:19 AM, Alexander Graf wrote: > > > On 10.09.14 07:03, Pierre Mallard wrote: >> Apply the new PPC_FLOAT_64 flag to fctid[z] and fcfid. >> May also be applyed to fctidu[z] and fcfid[su][z], but since they are not >> mentionned in xilinx documentation it might not be needed yet. >>

Re: [Qemu-devel] [PATCH v3 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-09-10 Thread Greg Bellows
No problem, just wanted to point it out in case it helps. Greg On 10 September 2014 11:13, Ard Biesheuvel wrote: > On 10 September 2014 17:42, Greg Bellows wrote: > > We also have v4 of the TZ patches which do provide 32-bit EL3 support, > but > > not EL2. Maybe good to align with this code a

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] target-ppc : Add PPC_FLOAT_64 flag to instructions type

2014-09-10 Thread Tom Musta
On 9/10/2014 4:18 AM, Alexander Graf wrote: > > > On 10.09.14 07:03, Pierre Mallard wrote: >> This patch declare a new floating point instruction flag PPC_FLOAT_64 to be >> used >> by fcfid, fctid[z] operations. Note that due to limited number of bit, >> FSEL and FRES points now to same value,

Re: [Qemu-devel] [PATCH v3 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-09-10 Thread Peter Maydell
On 10 September 2014 17:13, Ard Biesheuvel wrote: > As far as I can tell, there is very little overlap, only patch 8/33 > contains some stuff that we added as well. > I expect PSCI handling and emulation of hvc and/or smc to be mutually > exclusive, nothing we won't be able to handle with a couple

Re: [Qemu-devel] [PATCH v3 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-09-10 Thread Ard Biesheuvel
On 10 September 2014 17:42, Greg Bellows wrote: > We also have v4 of the TZ patches which do provide 32-bit EL3 support, but > not EL2. Maybe good to align with this code as well. > > http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg07347.html > As far as I can tell, there is very little

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-10 Thread Eric Blake
On 09/10/2014 02:13 AM, Markus Armbruster wrote: > device_name[] is can become non-empty only in bdrv_new_named() and s/is // > bdrv_move_feature_fields(). The latter is used only to undo damage > done by bdrv_swap(). The former is called only by blk_new_with_bs(). > Therefore, when a BlockDriv

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-10 Thread Benoît Canet
On Wed, Sep 10, 2014 at 09:14:35AM -0600, Eric Blake wrote: > On 09/10/2014 02:54 AM, Fam Zheng wrote: > > >> Let's think of a situation that recursive blockers protect but > >> backing_blocker does not: > >> > >> a <- b <- c <- d > >> > >> c is the backing file and is therefore protected by the o

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-10 Thread Walid Nouri
Hello Michael, Hello Paolo i have „studied“ the available documentation/Information and tried to get an idea of the QEMU live block operation possibilities. I think the MC protocol doesn’t need synchronous block device replication because primary and secondary VM are not synchronous. The stat

Re: [Qemu-devel] [PATCH v3 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-09-10 Thread Greg Bellows
We also have v4 of the TZ patches which do provide 32-bit EL3 support, but not EL2. Maybe good to align with this code as well. http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg07347.html On 9 September 2014 16:59, Peter Maydell wrote: > On 9 September 2014 22:51, Ard Biesheuvel > wro

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Paolo Bonzini
Il 10/09/2014 17:02, Fam Zheng ha scritto: > > A bit hackish, but I don't have any better idea. > > > > Hmm... what about adding a new member to the visitors for "invalid enum" > > value? The dealloc visitor could override it to do nothing, while the > > default could abort or set an error. Woul

Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:30 (+0200), Markus Armbruster wrote : > Creating an anonymous BDS can't fail. Make that obvious. > > Signed-off-by: Markus Armbruster > --- > block.c | 26 +++--- > block/iscsi.c | 2 +- > block/vvfat.c | 2 +-

Re: [Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding

2014-09-10 Thread Alexander Graf
> Am 10.09.2014 um 16:39 schrieb Paolo Bonzini : > > Il 10/09/2014 16:38, Alexander Graf ha scritto: I don't think so, but maybe I misunderstood what Alex wrote. >> I still think it shouldn't be inside the sysbus files. You can use sysbus >> devices without a platform bus. > > If you want

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-10 Thread Eric Blake
On 09/10/2014 02:54 AM, Fam Zheng wrote: >> Let's think of a situation that recursive blockers protect but >> backing_blocker does not: >> >> a <- b <- c <- d >> >> c is the backing file and is therefore protected by the op blocker. >> >> The block-commit command works with node-names, however, so

Re: [Qemu-devel] [PATCH 1/2] target-mips: Add synci instruction test

2014-09-10 Thread Yongbok Kim
Tested-by: Yongbok Kim -Original Message- From: qemu-devel-bounces+yongbok.kim=imgtec@nongnu.org [mailto:qemu-devel-bounces+yongbok.kim=imgtec@nongnu.org] On Behalf Of Dongxue Zhang Sent: Tuesday, July 29, 2014 2:48 PM To: qemu-devel@nongnu.org Cc: peter.mayd...@linaro.org; Don

Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Update OPC_SYNCI

2014-09-10 Thread Yongbok Kim
Reviewed-by: Yongbok Kim Note that there is a microMIPS version of SYNCI, it would be even better if you could update it as well. Best Regards, Yongbok Kim -Original Message- From: qemu-devel-bounces+yongbok.kim=imgtec@nongnu.org [mailto:qemu-devel-bounces+yongbok.kim=imgtec@

Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-10 Thread Eric Blake
On 09/10/2014 02:13 AM, Markus Armbruster wrote: > Creating an anonymous BDS can't fail. Make that obvious. > > Signed-off-by: Markus Armbruster > --- > block.c | 26 +++--- > block/iscsi.c | 2 +- > block/vvfat.c | 2 +- > blockdev.c

Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-10 Thread Eric Blake
On 09/10/2014 05:03 AM, Benoît Canet wrote: > The Wednesday 10 Sep 2014 à 10:13:30 (+0200), Markus Armbruster wrote : >> Creating an anonymous BDS can't fail. Make that obvious. >> >> Signed-off-by: Markus Armbruster >> --- >> /* create a new block device (by default it is empty) */ >> -BlockDr

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Fam Zheng
On Wed, 09/10 15:01, Paolo Bonzini wrote: > Il 10/09/2014 14:30, Fam Zheng ha scritto: > > We shouldn't do anything in the switch block in enum's visit_type_ > > function, when the enum data's ->kind is not valid at all. This happens > > when the dealloc visitor is called, after qmp input visitor r

Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW

2014-09-10 Thread Alexey Kardashevskiy
On 09/10/2014 11:03 PM, Alexander Graf wrote: > > > On 29.08.14 12:12, Alexey Kardashevskiy wrote: >> This implements DDW for VFIO. Host kernel support is required for this. >> >> After this patch DDW will be enabled on all machines but pseries-2.1. > > I fail to see the code that restricts DDW

Re: [Qemu-devel] [RFC PATCH v3 13/18] spapr_pci: Enable DDW

2014-09-10 Thread Alexey Kardashevskiy
On 09/10/2014 11:01 PM, Alexander Graf wrote: > > > On 29.08.14 12:12, Alexey Kardashevskiy wrote: >> This implements DDW for emulated PHB. >> >> This advertises the query/create/remove RTAS tokens in device tree. >> This does not advertise the reset RTAS token though, will be added later. >> >>

  1   2   3   4   >