Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver

2014-08-28 Thread Markus Armbruster
Fam Zheng writes: > On Thu, 08/28 16:23, Eric Blake wrote: >> On 08/27/2014 11:53 PM, Fam Zheng wrote: >> > This is an analogue to Linux null_blk. It can be used for testing block >> > device emulation and general block layer functionalities such as >> > coroutines and throttling, where disk IO i

Re: [Qemu-devel] [PATCH] block: Loose dataplane dependency

2014-08-28 Thread Paolo Bonzini
Il 29/08/2014 03:25, Fam Zheng ha scritto: > Before virtio-blk dataplane is switched to use block layer, it used to > rely on the presence of linux-aio. Now the dependency is Linux, where > the vring code has "#include ". Can you instead move linux/virtio_ring.h to include/hw/virtio, with __uNN ty

Re: [Qemu-devel] [PATCH v4 0/8] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset

2014-08-28 Thread Jan Kiszka
On 2014-08-28 23:12, Michael S. Tsirkin wrote: > On Sat, Aug 16, 2014 at 01:55:36PM +0800, Le Tan wrote: >> Hi, >> >> These patches are intended to introduce Intel IOMMU (VT-d) emulation to q35 >> chipset. The major job in these patches is to add support for emulating Intel >> IOMMU according to th

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread David Gibson
On Fri, Aug 29, 2014 at 12:18:44AM +0200, Alexander Graf wrote: > > > On 28.08.14 20:20, Aravinda Prasad wrote: > > > > > > On Thursday 28 August 2014 04:10 PM, Alexander Graf wrote: > >> > >> > >> On 25.08.14 15:45, Aravinda Prasad wrote: > >>> Extend rtas-blob to accommodate error log. Error

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread David Gibson
On Fri, Aug 29, 2014 at 03:33:59AM +0200, Alexander Graf wrote: > > > > Am 29.08.2014 um 03:06 schrieb Benjamin Herrenschmidt : > > > >> On Fri, 2014-08-29 at 02:40 +0200, Alexander Graf wrote: > >> > >>> On 29.08.14 00:25, Benjamin Herrenschmidt wrote: > On Fri, 2014-08-29 at 00:18 +0200,

Re: [Qemu-devel] [question] e1000 interrupt storm happenedbecauseofitscorrespondingioapic->irr bit always set

2014-08-28 Thread Jason Wang
On 08/29/2014 12:07 PM, Zhang, Yang Z wrote: > Zhang Haoyu wrote on 2014-08-29: >> > Hi, Yang, Gleb, Michael, >> > Could you help review below patch please? > I don't quite understand the background. Why ioacpi->irr is setting before > EOI? It should be driver's responsibility to clear the interru

Re: [Qemu-devel] [question] e1000 interrupt storm happenedbecauseofitscorrespondingioapic->irr bit always set

2014-08-28 Thread Zhang, Yang Z
Zhang Haoyu wrote on 2014-08-29: > Hi, Yang, Gleb, Michael, > Could you help review below patch please? I don't quite understand the background. Why ioacpi->irr is setting before EOI? It should be driver's responsibility to clear the interrupt before issuing EOI. > > Thanks, > Zhang Haoyu > >>

[Qemu-devel] [PATCH V2] acpi-build: Set FORCE_APIC_CLUSTER_MODEL bit for FADT flags

2014-08-28 Thread zhanghailiang
If we start Windows 2008 R2 DataCenter with number of cpu less than 8, The system will use APIC Flat Logical destination mode as default configuration, Which has an upper limit of 8 CPUs. The fault is that VM can not show all processors within Task Manager if we hot-add cpus when the number of cpu

Re: [Qemu-devel] USB PCI host bus adapter hot plug

2014-08-28 Thread Gonglei (Arei)
Hi, Gerd > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, August 28, 2014 4:36 PM > Subject: Re: [Qemu-devel] USB PCI host bus adapter hot plug > > Hi, > > > > The last missing bit (beside the make check failures) needed to finally > > > merge this is turning off hotplug in c

Re: [Qemu-devel] [question] e1000 interrupt storm happenedbecauseofitscorrespondingioapic->irr bit always set

2014-08-28 Thread Zhang Haoyu
Hi, Yang, Gleb, Michael, Could you help review below patch please? Thanks, Zhang Haoyu >> Hi Jason, >> I tested below patch, it's okay, the e1000 interrupt storm disappeared. >> But I am going to make a bit change on it, could you help review it? >> >>> Currently, we call ioapic_service() immedia

Re: [Qemu-devel] [question] e1000 interrupt storm happenedbecauseofits correspondingioapic->irr bit always set

2014-08-28 Thread Jason Wang
On 08/28/2014 08:55 PM, Zhang Haoyu wrote: > Hi Jason, > I tested below patch, it's okay, the e1000 interrupt storm disappeared. > But I am going to make a bit change on it, could you help review it? > >> Currently, we call ioapic_service() immediately when we find the irq is still >> active during

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Benjamin Herrenschmidt
On Fri, 2014-08-29 at 03:33 +0200, Alexander Graf wrote: > I fail to see a problem, yeah :). Imagine the same thing on x86 with > its completely messed up instruction set. Would you still advocate for > in-qemu code or would you prefer to have a compiler between you and > the ugly opcodes? You mea

[Qemu-devel] Running programs that dynamically generate code

2014-08-28 Thread Byron Hawkins
Hi, I'm working on a research project to optimize binary translation for target applications that dynamically generate code, such as browser JIT engines. When I run the octane benchmark in Chrome v8 under QEMU (i.e., qemu-x86_64), it shows significant overhead compared to a native run. Can someone

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Alexander Graf
> Am 29.08.2014 um 03:06 schrieb Benjamin Herrenschmidt : > >> On Fri, 2014-08-29 at 02:40 +0200, Alexander Graf wrote: >> >>> On 29.08.14 00:25, Benjamin Herrenschmidt wrote: On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote: I strongly disagree with David. Legally there is no

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-28 Thread Chen, Tiejun
On 2014/8/28 8:56, Chen, Tiejun wrote: + */ +dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), +"xen-igd-passthrough-isa-bridge"); +if (dev) { +r = xen_host_pci_device_get(&hdev, 0, 0, PCI_DEVFN(0x1f, 0), 0); +if (!r) { +pci_con

[Qemu-devel] [PATCH] block: Loose dataplane dependency

2014-08-28 Thread Fam Zheng
Before virtio-blk dataplane is switched to use block layer, it used to rely on the presence of linux-aio. Now the dependency is Linux, where the vring code has "#include ". Signed-off-by: Fam Zheng --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-08-28 Thread Chen, Tiejun
On 2014/8/28 9:44, Chen, Tiejun wrote: On 2014/8/27 21:03, Michael S. Tsirkin wrote: On Wed, Aug 27, 2014 at 05:13:07PM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the

Re: [Qemu-devel] [PATCH] block: Always compile virtio-blk dataplane

2014-08-28 Thread Fam Zheng
On Thu, 08/28 14:56, Stefan Hajnoczi wrote: > On Tue, Aug 26, 2014 at 02:57:19PM +0800, Fam Zheng wrote: > > Dataplane doesn't depend on linux-aio any more, so we don't need the > > compiling condition now. > > > > Configure options are kept but just print a message. > > > > Signed-off-by: Fam Zh

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Benjamin Herrenschmidt
On Fri, 2014-08-29 at 02:40 +0200, Alexander Graf wrote: > > On 29.08.14 00:25, Benjamin Herrenschmidt wrote: > > On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote: > >> I strongly disagree with David. Legally there is no difference between a > >> .bin file that contains code and an array ma

[Qemu-devel] [PATCH v4] block: Introduce "null" driver

2014-08-28 Thread Fam Zheng
This is an analogue to Linux null_blk. It can be used for testing or benchmarking block device emulation and general block layer functionalities such as coroutines and throttling, where disk IO is not necessary or wanted. Use null:// for AIO version, and null-co:// for coroutine version. Signed-o

Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver

2014-08-28 Thread Fam Zheng
On Thu, 08/28 16:23, Eric Blake wrote: > On 08/27/2014 11:53 PM, Fam Zheng wrote: > > This is an analogue to Linux null_blk. It can be used for testing block > > device emulation and general block layer functionalities such as > > coroutines and throttling, where disk IO is not necessary or wanted.

Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver

2014-08-28 Thread Fam Zheng
On Thu, 08/28 17:22, Benoît Canet wrote: > The Thursday 28 Aug 2014 à 13:53:11 (+0800), Fam Zheng wrote : > > This is an analogue to Linux null_blk. It can be used for testing block > > device emulation and general block layer functionalities such as > > coroutines and throttling, where disk IO is

Re: [Qemu-devel] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-08-28 Thread zhanghailiang
On 2014/8/28 1:35, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v2.1.1: https://github.com/mdroth/qemu/commits/stable-2.1-staging The release is planned for 2014-09-08: http://wiki.qemu.org/Planning/2.1 Please respond here or CC qemu-sta...@nong

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Alexander Graf
On 29.08.14 00:25, Benjamin Herrenschmidt wrote: > On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote: >> I strongly disagree with David. Legally there is no difference between a >> .bin file that contains code and an array made of instructions. And the >> more target code we can keep outsid

Re: [Qemu-devel] What tests should "make check-block" run?

2014-08-28 Thread Fam Zheng
On Thu, 08/28 12:05, Stefan Hajnoczi wrote: > On Thu, Aug 21, 2014 at 02:16:36PM +0100, Peter Maydell wrote: > > On 21 August 2014 14:12, Stefan Hajnoczi wrote: > > > On Thu, Aug 21, 2014 at 02:27:00PM +0200, Markus Armbruster wrote: > > >> Should we have a variant of "make check-block" for testin

Re: [Qemu-devel] [PATCH memory v2 3/3] memory: Lazy init name from QOM name as needed

2014-08-28 Thread Peter Crosthwaite
On Fri, Aug 29, 2014 at 12:57 AM, Paolo Bonzini wrote: > Il 28/08/2014 16:27, Peter Crosthwaite ha scritto: >> Yeh, so a solution to that was to patch qom to drop the [*] for >> singletons added via arrayified property adders. One possible semantic >> that I can think of is the 0th element always

[Qemu-devel] [Bug 1362755] Re: QEmu +2 does not route VLAN tagged packets, that are originated within the Hypervisor itself.

2014-08-28 Thread Thiago Martins
** Description changed: Guys, Trusty QEmu 2.0 Hypervisor fails to create a consistent virtual network. It does not route tagged VLAN packets. That's it, it is impossible to use Trusty acting as a QEmu 2.0 Hypervisor (metapakage `ubuntu-virt-server`), to make a basic virtual tagge

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Benjamin Herrenschmidt
On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote: > I strongly disagree with David. Legally there is no difference between a > .bin file that contains code and an array made of instructions. And the > more target code we can keep outside of QEMU the better. Ugh ... having a separate file wi

Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver

2014-08-28 Thread Eric Blake
On 08/27/2014 11:53 PM, Fam Zheng wrote: > This is an analogue to Linux null_blk. It can be used for testing block > device emulation and general block layer functionalities such as > coroutines and throttling, where disk IO is not necessary or wanted. > > Use null:// for AIO version, and null-co:

Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver

2014-08-28 Thread Eric Blake
On 08/28/2014 04:15 PM, Eric Blake wrote: > On 08/28/2014 01:42 PM, Paolo Bonzini wrote: >> Il 28/08/2014 17:52, Eric Blake ha scritto: >>> have a '*coroutine':'bool' flag here that chooses between the null: and >>> the null-co: protocol. (I suspect we would do the same when finaly >>> adding glus

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Alexander Graf
On 28.08.14 20:20, Aravinda Prasad wrote: > > > On Thursday 28 August 2014 04:10 PM, Alexander Graf wrote: >> >> >> On 25.08.14 15:45, Aravinda Prasad wrote: >>> Extend rtas-blob to accommodate error log. Error log >>> structure is saved in rtas space upon a machine check >>> exception. >>> >>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-28 Thread Alexander Graf
On 28.08.14 19:42, Aravinda Prasad wrote: > > > On Thursday 28 August 2014 02:07 PM, Alexander Graf wrote: >> >> >> On 28.08.14 08:38, Aravinda Prasad wrote: >>> >>> >>> On Wednesday 27 August 2014 04:07 PM, Alexander Graf wrote: On 25.08.14 15:45, Aravinda Prasad wrote: > Th

Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver

2014-08-28 Thread Eric Blake
On 08/28/2014 01:42 PM, Paolo Bonzini wrote: > Il 28/08/2014 17:52, Eric Blake ha scritto: >> have a '*coroutine':'bool' flag here that chooses between the null: and >> the null-co: protocol. (I suspect we would do the same when finaly >> adding gluster to BlockdevOptions: rather than having 'glus

[Qemu-devel] [Bug 1359394] Re: virtio block device hangs after "virtio_blk virtio3: requests:id 0 is not a head!"

2014-08-28 Thread Slava Pestov
You mean a kernel stack trace when the message was printed? I don't have that but I guess I could add a dump_stack() call in there. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1359394 Title: virt

Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions

2014-08-28 Thread Michael S. Tsirkin
On Thu, Aug 28, 2014 at 10:33:02PM +0100, Peter Maydell wrote: > On 28 August 2014 22:21, Michael Roth wrote: > > But I guess there's still a separate issue, where there's a high liklihood > > that > > a 0 address would conflict with some hard-wired IO address? Wouldn't this > > be a > > guest b

Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions

2014-08-28 Thread Peter Maydell
On 28 August 2014 22:21, Michael Roth wrote: > But I guess there's still a separate issue, where there's a high liklihood > that > a 0 address would conflict with some hard-wired IO address? Wouldn't this be a > guest bug though? Even if it's a guest bug, we should act like the hardware does if

Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions

2014-08-28 Thread Michael Roth
Quoting Michael S. Tsirkin (2014-08-27 08:47:51) > On Mon, Aug 18, 2014 at 07:21:54PM -0500, Michael Roth wrote: > > Some kernels program a 0 address for io regions. PCI 3.0 spec > > section 6.2.5.1 doesn't seem to disallow this. > > > > Signed-off-by: Michael Roth > > Yes the PCI spec does not

Re: [Qemu-devel] [PATCH v4 0/8] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset

2014-08-28 Thread Michael S. Tsirkin
On Sat, Aug 16, 2014 at 01:55:36PM +0800, Le Tan wrote: > Hi, > > These patches are intended to introduce Intel IOMMU (VT-d) emulation to q35 > chipset. The major job in these patches is to add support for emulating Intel > IOMMU according to the VT-d specification, including basic responses to CS

[Qemu-devel] [PATCH v2 6/8] target-i386: x87 exception pointers using TCG.

2014-08-28 Thread Jaume Marti Farriol
Hello, This patch contains the main changes. It contains modifcations to the target-i386/translate.c file. Those modifications are meant to generate TCG instructions to maintain the correct value for the variables fpop, fpip, fpdp, fpds and fpcs in the cpu state. Best regards, Jaume translat

[Qemu-devel] [PATCH v2 8/8] target-i386: x87 exception pointers using TCG.

2014-08-28 Thread Jaume Marti Farriol
Hello, This patch contains changes to the tests/tcg/test-i386.c file to test the storage of the x87 exception pointers by instructions fnstenv and fxsave. Best regards, Jaume test-i386.c | 66 1 file changed, 62 insertions(+), 4 de

[Qemu-devel] [PATCH v2 4/8] target-i386: x87 exception pointers using TCG.

2014-08-28 Thread Jaume Marti Farriol
Hello, This patch contains a required modification due to the change of the size from 16 bits to 32 bits of the fpop variable in the CPUX86State struct. Best regards, Jaume machine.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) signed-off: jaume.mar...@gmail.com diff --git a/targe

[Qemu-devel] [PATCH v2 3/8] target-i386: x87 exception pointers using TCG.

2014-08-28 Thread Jaume Marti Farriol
Hello, This patch includes changes in the helper parameters, for the instructions involved in saving to memory and restoring the x87 exception pointers. The changes are to include a new parameter to indicate if the processor is running in protected more. Best regards, Jaume helper.h | 12 ++

[Qemu-devel] [PATCH v2 1/8] target-i386: x87 exception pointers using TCG.

2014-08-28 Thread Jaume Marti Farriol
Hello, In this patch I just add new fields in the CPUX86State struct to store the exception pointers. Also I remove unnecessary parameters from cpu_x86_fsave and cpu_x86_frstor helpers. Best regards, Jaume cpu.h |9 + 1 file changed, 5 insertions(+), 4 deletions(-) signed-off: ja

[Qemu-devel] [PATCH v2 7/8] target-i386: x87 exception pointers using TCG.

2014-08-28 Thread Jaume Marti Farriol
Hello, This patch contains changes in target-i386/translate.c file to include a new parameter in some functions containing one byte of the instruction that together with the modrm value is used to identify the non control x87 instructions. This set of instructions are the ones that update the x

[Qemu-devel] [PATCH v2 5/8] target-i386: x87 exception pointers using TCG.

2014-08-28 Thread Jaume Marti Farriol
Hello, This patch just removes an unnecessary parameter. Best regards, Jaume signal.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) signed-off: jaume.mar...@gmail.com diff --git a/linux-user/signal.c b/linux-user/signal.c index 1141054..73f8f6b 100644 --- a/linux-user/signal.c +

[Qemu-devel] [PATCH v2 2/8] target-i386: x87 exception pointers using TCG.

2014-08-28 Thread Jaume Marti Farriol
Hello, This patch modifies the helpers for the fpu instructions involved in saving to memory and restoring the x87 exception pointers. Best regards, Jaume fpu_helper.c | 218 --- 1 file changed, 166 insertions(+), 52 deletions(-) signed

[Qemu-devel] [PATCH v2 0/8] target-i386: x87 exception pointers using TCG.

2014-08-28 Thread Jaume Marti Farriol
Hello, I submit a patch to fix bugs 661696 and 1248376. This is the second version of this patch, this version requires less TCG operations to execute. As mentioned in a previous email, the patch implements, for TCG, the specifications provided in Intel and AMD programmer's manuals regarding th

[Qemu-devel] [Bug 1362755] Re: QEmu +2 does not route VLAN tagged packets, that are originated within the Hypervisor itself.

2014-08-28 Thread Thiago Martins
** Description changed: Guys, Trusty QEmu 2.0 Hypervisor fails to create a consistent virtual network. It does not route tagged VLAN packets. That's it, it is impossible to use Trusty acting as a QEmu 2.0 Hypervisor (metapakage `ubuntu-virt-server`), to make a basic virtual tagge

Re: [Qemu-devel] [Bug 1362755] [NEW] QEmu +2 does not route VLAN tagged packets, that are originated within the Hypervisor itself.

2014-08-28 Thread Vlad Yasevich
On 08/28/2014 02:40 PM, Thiago Martins wrote: > Public bug reported: > > Guys, > > Trusty QEmu 2.0 Hypervisor fails to create a consistent virtual network. > It does not route tagged VLAN packets. > The have a been a bunch of rather recent changes to the kernel to support guest VLANs correctly.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] target-ppc: Build error log

2014-08-28 Thread Benjamin Herrenschmidt
On Thu, 2014-08-28 at 22:47 +0530, Aravinda Prasad wrote: > Should we avoid having error log in 0x7000? As per above only > ibm,nmi-register-2 places error log in 0x7000 which will be terminated > in future? The question is which variant Linux uses and which variant are other OSes we might be inte

Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver

2014-08-28 Thread Paolo Bonzini
Il 28/08/2014 17:52, Eric Blake ha scritto: > have a '*coroutine':'bool' flag here that chooses between the null: and > the null-co: protocol. (I suspect we would do the same when finaly > adding gluster to BlockdevOptions: rather than having 'gluster+tcp' and > 'gluster+udp', it would be a single

Re: [Qemu-devel] [PATCH 02/17] ppc: avoid excessive TLB flushing

2014-08-28 Thread Paolo Bonzini
Il 28/08/2014 19:30, Peter Maydell ha scritto: > On 28 August 2014 18:14, Paolo Bonzini wrote: >> PowerPC TCG flushes the TLB on every IR/DR change, which basically >> means on every user<->kernel context switch. Use the 6-element >> TLB array as a cache, where each MMU index is mapped to a diffe

[Qemu-devel] [Bug 1362755] [NEW] QEmu +2 does not route VLAN tagged packets, that are originated within the Hypervisor itself.

2014-08-28 Thread Thiago Martins
Public bug reported: Guys, Trusty QEmu 2.0 Hypervisor fails to create a consistent virtual network. It does not route tagged VLAN packets. That's it, it is impossible to use Trusty acting as a QEmu 2.0 Hypervisor (metapakage `ubuntu-virt-server`), to make a basic virtual tagged network within it

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Aravinda Prasad
On Thursday 28 August 2014 04:10 PM, Alexander Graf wrote: > > > On 25.08.14 15:45, Aravinda Prasad wrote: >> Extend rtas-blob to accommodate error log. Error log >> structure is saved in rtas space upon a machine check >> exception. >> >> Signed-off-by: Aravinda Prasad > > I can't say I'm a

Re: [Qemu-devel] [RFT/RFH PATCH 00/16] PPC speedup patches for TCG

2014-08-28 Thread Tom Musta
On 8/28/2014 12:14 PM, Paolo Bonzini wrote: > Hi everyone, > > these patches provide a speedup around 20% when running PPC softmmu > emulation on x86 machines (10% for user-mode emulation). There are > actually two separate speedups here: > > * avoiding TLB flushing on every kernel<->user transi

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check

2014-08-28 Thread Aravinda Prasad
On Thursday 28 August 2014 02:12 PM, Alexander Graf wrote: > > > On 28.08.14 08:56, Aravinda Prasad wrote: >> >> >> On Wednesday 27 August 2014 04:10 PM, Alexander Graf wrote: >>> >>> >>> On 25.08.14 15:45, Aravinda Prasad wrote: It is possible for multi-processors to experience machine >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-28 Thread Aravinda Prasad
On Thursday 28 August 2014 02:07 PM, Alexander Graf wrote: > > > On 28.08.14 08:38, Aravinda Prasad wrote: >> >> >> On Wednesday 27 August 2014 04:07 PM, Alexander Graf wrote: >>> >>> >>> On 25.08.14 15:45, Aravinda Prasad wrote: This patch adds FWNMI support in qemu for powerKVM gues

Re: [Qemu-devel] [PATCH 02/17] ppc: avoid excessive TLB flushing

2014-08-28 Thread Peter Maydell
On 28 August 2014 18:14, Paolo Bonzini wrote: > PowerPC TCG flushes the TLB on every IR/DR change, which basically > means on every user<->kernel context switch. Use the 6-element > TLB array as a cache, where each MMU index is mapped to a different > state of the IR/DR/PR/HV bits. > > This bring

[Qemu-devel] [PATCH 12/17] ppc: use movcond for isel

2014-08-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-ppc/translate.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 67f13f7..48c7b66 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -789,27

Re: [Qemu-devel] [PATCH V2 0/3] image-fuzzer: Support refcount structures in the qcow2 image generator

2014-08-28 Thread M.Kustova
ping http://patchwork.ozlabs.org/patch/381345/ http://patchwork.ozlabs.org/patch/381344/ http://patchwork.ozlabs.org/patch/381343/ BR, M.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] target-ppc: Build error log

2014-08-28 Thread Aravinda Prasad
On Thursday 28 August 2014 04:03 PM, Benjamin Herrenschmidt wrote: > On Thu, 2014-08-28 at 12:29 +0200, Alexander Graf wrote: >> >> On 28.08.14 12:21, Benjamin Herrenschmidt wrote: >>> On Thu, 2014-08-28 at 10:36 +0200, Alexander Graf wrote: >>> So why not put it at 0x7000 then? >>> >>> Beca

Re: [Qemu-devel] [PATCH 0/2] image-fuzzer: Extend test coverage

2014-08-28 Thread M.Kustova
ping http://patchwork.ozlabs.org/patch/381137 http://patchwork.ozlabs.org/patch/381138 On Tue, Aug 19, 2014 at 1:38 AM, Maria Kustova wrote: > This patch series contains changes improving test coverage. > > Maria Kustova (2): > runner: Expand the list of default test commands > fuzz: Make fu

[Qemu-devel] [PATCH 14/17] ppc: introduce ppc_get_crf and ppc_set_crf

2014-08-28 Thread Paolo Bonzini
These two functions will group together four CR bits into a single value, once we change the representation of condition registers. Signed-off-by: Paolo Bonzini --- linux-user/elfload.c | 2 +- linux-user/main.c| 2 +- linux-user/signal.c | 4 ++-- monitor.c|

[Qemu-devel] [PATCH 17/17] ppc: dump all 32 CR bits

2014-08-28 Thread Paolo Bonzini
This is more precise when bits have been modified with CR boolean operations. Signed-off-by: Paolo Bonzini --- target-ppc/translate.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index dd19b39..35e7a8b 1

[Qemu-devel] [PATCH 15/17] ppc: store CR registers in 32 1-bit registers

2014-08-28 Thread Paolo Bonzini
This makes comparisons much smaller and faster. The speedup is approximately 10% on user-mode emulation on x86 host, 3-4% on PPC. Note that CRF_* constants are flipped to match PowerPC's big bit-endianness. Previously, the CR register was effectively stored in mixed endianness, so now there is l

[Qemu-devel] [PATCH 08/17] ppc: introduce helpers for mfocrf/mtocrf

2014-08-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-ppc/helper.h | 3 +++ target-ppc/int_helper.c | 22 ++ target-ppc/translate.c | 31 --- 3 files changed, 29 insertions(+), 27 deletions(-) diff --git a/target-ppc/helper.h b/target-ppc/helper.h index 50

[Qemu-devel] [PATCH 11/17] ppc: rename gen_set_cr6_from_fpscr

2014-08-28 Thread Paolo Bonzini
It sets CR1, not CR6 (and the spec agrees). Signed-off-by: Paolo Bonzini --- target-ppc/translate.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 8def0ae..67f13f7 100644 --- a/target-ppc/translate.c +++ b/

[Qemu-devel] [PATCH 13/17] ppc: compute mask from BI using right shift

2014-08-28 Thread Paolo Bonzini
This will match the code we use in fpu_helper.c when we flip CRF_* bit-endianness. Signed-off-by: Paolo Bonzini --- target-ppc/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 48c7b66..4ce7af4 100644 --- a

[Qemu-devel] [PATCH 06/17] ppc: use CRF_* in int_helper.c

2014-08-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-ppc/int_helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c index f6e8846..9c1c5cd 100644 --- a/target-ppc/int_helper.c +++ b/target-ppc/int_helper.c @@ -2303,25 +2303,2

[Qemu-devel] [PATCH 07/17] ppc: fix result of DLMZB when no zero bytes are found

2014-08-28 Thread Paolo Bonzini
It must return 8 and place 8 in XER, but the current code uses i directly which is 9 at this point of the code. Signed-off-by: Paolo Bonzini --- target-ppc/int_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c index 9c1c5cd..7955bf7 10

[Qemu-devel] [PATCH 10/17] ppc: introduce gen_op_mfcr/gen_op_mtcr

2014-08-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-ppc/translate.c | 60 +++--- 1 file changed, 42 insertions(+), 18 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index afbd336..8def0ae 100644 --- a/target-ppc/translate.c +++ b/target-

[Qemu-devel] [PATCH 05/17] ppc: use CRF_* in fpu_helper.c

2014-08-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-ppc/fpu_helper.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper.c index da93d12..0fe006a 100644 --- a/target-ppc/fpu_helper.c +++ b/target-ppc/fpu_helper

[Qemu-devel] [PATCH 03/17] ppc: fix monitor access to CR

2014-08-28 Thread Paolo Bonzini
This was off-by-one. Signed-off-by: Paolo Bonzini --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 34cee74..ec73dd4 100644 --- a/monitor.c +++ b/monitor.c @@ -2968,7 +2968,7 @@ static target_long monitor_get_ccr (const struct MonitorD

[Qemu-devel] [PATCH 09/17] ppc: reorganize gen_compute_fprf

2014-08-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-ppc/translate.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 0a85a23..afbd336 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -253,21 +

[Qemu-devel] [PATCH 04/17] ppc: use ARRAY_SIZE in gdbstub.c

2014-08-28 Thread Paolo Bonzini
Match the idiom used by linux-user/signal.c and linux-user/elfload.c. Signed-off-by: Paolo Bonzini --- target-ppc/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-ppc/gdbstub.c b/target-ppc/gdbstub.c index 14675f4..bad49ae 100644 --- a/target-ppc/gdbstub.c

[Qemu-devel] [PATCH 16/17] ppc: inline ppc_get_crf/ppc_set_crf when clearer

2014-08-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- linux-user/elfload.c| 4 ++-- linux-user/main.c | 5 - linux-user/signal.c | 8 monitor.c | 2 +- target-ppc/fpu_helper.c | 12 ++-- target-ppc/gdbstub.c| 8 target-ppc/int_helper.c | 31 ++

[Qemu-devel] [PATCH 02/17] ppc: avoid excessive TLB flushing

2014-08-28 Thread Paolo Bonzini
PowerPC TCG flushes the TLB on every IR/DR change, which basically means on every user<->kernel context switch. Use the 6-element TLB array as a cache, where each MMU index is mapped to a different state of the IR/DR/PR/HV bits. This brings the number of TLB flushes down from ~90 to ~5 fo

[Qemu-devel] [PATCH 01/17] ppc: do not look at the MMU index

2014-08-28 Thread Paolo Bonzini
The MMU index is an internal detail that should not be needed by the translator. Look at the MSR directly. Signed-off-by: Paolo Bonzini --- target-ppc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index c07bb01..5

[Qemu-devel] [RFT/RFH PATCH 00/16] PPC speedup patches for TCG

2014-08-28 Thread Paolo Bonzini
Hi everyone, these patches provide a speedup around 20% when running PPC softmmu emulation on x86 machines (10% for user-mode emulation). There are actually two separate speedups here: * avoiding TLB flushing on every kernel<->user transition (patches 1-2) * rewriting CR handling to use 32 1-bi

Re: [Qemu-devel] block IO latency tracker without using QMP socket.

2014-08-28 Thread Markus Armbruster
Benoît Canet writes: > The Thursday 28 Aug 2014 à 13:36:35 (+0100), Stefan Hajnoczi wrote : >> On Wed, Aug 27, 2014 at 04:58:12PM +0200, Anshul Makkar wrote: >> > I am writing a block IO latency tracker. >> > >> > As obvious, I am calculating the latency by tracking the interval between >> > st

Re: [Qemu-devel] [PULL 0/8] SCSI and memory changes for 2014-08-28

2014-08-28 Thread Peter Maydell
On 28 August 2014 15:13, Paolo Bonzini wrote: > The following changes since commit 2656eb7c599e306b95bad82b1372fc49ba3088f6: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20140819' into staging (2014-08-20 > 09:55:42 +0100) > > are available in the git repository at

Re: [Qemu-devel] What tests should "make check-block" run?

2014-08-28 Thread Peter Maydell
On 28 August 2014 16:24, Markus Armbruster wrote: > * Have a file INSTALL describing how to build and install this beast. > Autoconf comes with one fit for autoconfiscated projects. QEMU isn't, > but it's vaguely similar, so autoconf's INSTALL could serve as a > starting point. Yes please,

Re: [Qemu-devel] [PATCH v4 07/10] qcow2: Rebuild refcount structure during check

2014-08-28 Thread Benoît Canet
On Wed, Aug 27, 2014 at 10:18:23PM +0200, Max Reitz wrote: > The previous commit introduced the "rebuild" variable to qcow2's > implementation of the image consistency check. Now make use of this by > adding a function which creates a completely new refcount structure > based solely on the in-memor

Re: [Qemu-devel] [PULL 00/14] KVM changes for 2014-08-28

2014-08-28 Thread Peter Maydell
On 28 August 2014 15:08, Paolo Bonzini wrote: > The following changes since commit 2656eb7c599e306b95bad82b1372fc49ba3088f6: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20140819' into staging (2014-08-20 > 09:55:42 +0100) > > are available in the git repository at

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-08-28 Thread Joakim Tjernlund
Any resolution for how to handle P flag yet? Jocke Joakim Tjernlund/Transmode wrote on 2014/08/25 17:02:42: > > Riku Voipio wrote on 2014/08/25 16:49:17: > > > > On Mon, Aug 25, 2014 at 04:30:40PM +0200, Joakim Tjernlund wrote: > > > Riku Voipio wrote on 2014/08/25 15:55:55: > > > > > > > >

[Qemu-devel] [PATCH v3 30/47] postcopy: Incoming initialisation

2014-08-28 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- arch_init.c | 11 +++ include/migration/migration.h | 1 + migration.c | 1 + 3 files changed, 13 insertions(+) diff --git a/arch_init.c b/arch_init.c index 2c587aa..d4144e4 1

Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver

2014-08-28 Thread Eric Blake
On 08/28/2014 09:22 AM, Benoît Canet wrote: > The Thursday 28 Aug 2014 à 13:53:11 (+0800), Fam Zheng wrote : >> This is an analogue to Linux null_blk. It can be used for testing block >> device emulation and general block layer functionalities such as >> coroutines and throttling, where disk IO is

[Qemu-devel] [RFC] Use of host vector operations in host helper functions

2014-08-28 Thread Richard Henderson
Most of the time, guest vector operations are rare enough that it doesn't really matter that we implement them with a loop around integer operations. But for target-alpha, there's one vector comparison operation that appears in every guest string operation, and is used heavily enough that it's in

[Qemu-devel] [PATCH v8 4/4] sclp-s390: Add memory hotplug SCLPs

2014-08-28 Thread Matthew Rosato
Add memory information to read SCP info and add handlers for Read Storage Element Information, Attach Storage Element, Assign Storage and Unassign Storage. Signed-off-by: Matthew Rosato --- hw/s390x/sclp.c| 259 ++-- target-s390x/cpu.h | 15

Re: [Qemu-devel] [question] how to check if savevm is completed?

2014-08-28 Thread Stefan Hajnoczi
On Fri, Jul 18, 2014 at 10:32:33AM +0800, Zhang Haoyu wrote: > >> I run savevm by qemu-monitor, but how to check if savevm is completed? I > >> haven't find the query interface. > > > >That is because savevm is synchronous. It blocks until the operation is > >complete. You cannot use the QEMU mo

[Qemu-devel] [PATCH v8 3/4] s390-virtio: Apply same memory boundaries as virtio-ccw

2014-08-28 Thread Matthew Rosato
Although s390-virtio won't support memory hotplug, it should enforce the same memory boundaries so that it can use shared codepaths (like read_SCP_info). Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a

Re: [Qemu-devel] [PULL 0/6] Fixes for buildbot failures

2014-08-28 Thread Benoît Canet
The Thursday 28 Aug 2014 à 13:44:21 (+0100), Stefan Hajnoczi wrote : > The following changes since commit c47c61be8dcd91689c8fc6db924d684c3b39: > > Merge remote-tracking branch > 'remotes/awilliam/tags/vfio-pci-for-qemu-20140825.0' into staging (2014-08-26 > 10:42:06 +0100) > > are availa

[Qemu-devel] [PATCH v8 2/4] virtio-ccw: Include standby memory when calculating storage increment

2014-08-28 Thread Matthew Rosato
When determining the memory increment size, use the maxmem size if it was specified. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 46 qemu-options.hx|3 ++- target-s390x/cpu.h |3 +++ 3 files changed, 43

Re: [Qemu-devel] [PULL 0/6] Fixes for buildbot failures

2014-08-28 Thread Peter Maydell
On 28 August 2014 13:44, Stefan Hajnoczi wrote: > The following changes since commit c47c61be8dcd91689c8fc6db924d684c3b39: > > Merge remote-tracking branch > 'remotes/awilliam/tags/vfio-pci-for-qemu-20140825.0' into staging (2014-08-26 > 10:42:06 +0100) > > are available in the git reposit

[Qemu-devel] [PATCH v8 0/4] s390: Support for Hotplug of Standby Memory

2014-08-28 Thread Matthew Rosato
This patchset adds support in s390 for a pool of standby memory, which can be set online/offline by the guest (ie, via chmem). The standby pool of memory is allocated as the difference between the initial memory setting and the maxmem setting. As part of this work, additional results are provided

[Qemu-devel] [PATCH v3 35/47] Postcopy: Create a fault handler thread before marking the ram as userfault

2014-08-28 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 3 +++ postcopy-ram.c| 23 +++ 2 files changed, 26 insertions(+) diff --git a/include/migration/migration.h b/include/migration/migration.h index dbdf78

Re: [Qemu-devel] What tests should "make check-block" run?

2014-08-28 Thread Jeff Cody
On Thu, Aug 28, 2014 at 12:05:56PM +0100, Stefan Hajnoczi wrote: > On Thu, Aug 21, 2014 at 02:16:36PM +0100, Peter Maydell wrote: > > On 21 August 2014 14:12, Stefan Hajnoczi wrote: > > > On Thu, Aug 21, 2014 at 02:27:00PM +0200, Markus Armbruster wrote: > > >> Should we have a variant of "make ch

[Qemu-devel] [PATCH v3 44/47] Postcopy; Handle userfault requests

2014-08-28 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" userfaultfd is a Linux syscall that gives an fd that receives a stream of notifications of accesses to pages marked as MADV_USERFAULT, and allows the program to acknowledge those stalls and tell the accessing thread to carry on. Signed-off-by: Dr. David Alan Gilber

[Qemu-devel] [PATCH v8 1/4] sclp-s390: Add device to manage s390 memory hotplug

2014-08-28 Thread Matthew Rosato
Add sclpMemoryHotplugDev to contain associated data structures, etc. Signed-off-by: Matthew Rosato --- hw/s390x/sclp.c | 30 ++ include/hw/s390x/sclp.h | 20 2 files changed, 50 insertions(+) diff --git a/hw/s390x/sclp.c b/hw/s390x/sc

Re: [Qemu-devel] What tests should "make check-block" run?

2014-08-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Aug 21, 2014 at 02:16:36PM +0100, Peter Maydell wrote: >> On 21 August 2014 14:12, Stefan Hajnoczi wrote: >> > On Thu, Aug 21, 2014 at 02:27:00PM +0200, Markus Armbruster wrote: >> >> Should we have a variant of "make check-block" for testing other >> >> (format

  1   2   3   >