Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check

2014-08-27 Thread Aravinda Prasad
On Wednesday 27 August 2014 04:10 PM, Alexander Graf wrote: > > > On 25.08.14 15:45, Aravinda Prasad wrote: >> It is possible for multi-processors to experience machine >> check at or about the same time. As per PAPR, subsequent >> processors serialize waiting for the first processor to >> issu

Re: [Qemu-devel] [PATCH v3 1/3] nfs: Fix leak of opts in nfs_file_open

2014-08-27 Thread Benoît Canet
The Thursday 28 Aug 2014 à 13:56:10 (+0800), Fam Zheng wrote : > Signed-off-by: Fam Zheng > --- > block/nfs.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/block/nfs.c b/block/nfs.c > index 93d87f3..194f301 100644 > --- a/block/nfs.c > +++ b/block/nfs.c > @@

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-27 Thread Aravinda Prasad
On Wednesday 27 August 2014 04:07 PM, Alexander Graf wrote: > > > On 25.08.14 15:45, Aravinda Prasad wrote: >> This patch adds FWNMI support in qemu for powerKVM >> guests by handling the ibm,nmi-register rtas call. >> Whenever OS issues ibm,nmi-register RTAS call, the >> machine check notifica

Re: [Qemu-devel] [PATCH v2] blkdebug: make the fault injection functionality callable from QMP

2014-08-27 Thread Hitoshi Mitake
At Wed, 27 Aug 2014 06:43:49 -0600, Eric Blake wrote: > > [1 ] > On 08/26/2014 11:34 PM, Hitoshi Mitake wrote: > > >>> {"execute": "blkdebug-set-rules", "arguments": {"device": "ide0-hd0", > >>> "rules":[{"event": "write_aio", "type": "inject-error", "immediately": > >> > >> Why 'write_aoi'? New

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] target-ppc: Build error log

2014-08-27 Thread Aravinda Prasad
On Wednesday 27 August 2014 03:20 PM, Alexander Graf wrote: > > > On 25.08.14 15:45, Aravinda Prasad wrote: >> Whenever there is a physical memory error due to bit >> flips, which cannot be corrected by hardware, the error >> is passed on to the kernel. If the memory address in >> error belongs

[Qemu-devel] [PATCH v3 2/3] blkverify: Fix leak of opts in blkverify_open

2014-08-27 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Benoît Canet --- block/blkverify.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blkverify.c b/block/blkverify.c index 7c78ca4..163064c 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -158,6 +158,7 @@ static int blkverify_open(BlockDriv

[Qemu-devel] [PATCH v3 0/3] block: Fix leaks of opts in block drivers

2014-08-27 Thread Fam Zheng
Remember to call qemu_opts_del before function returning. v3: Fix nfs return code again! (Benoit) v2: Drop qcow2 fix since it's duplicated with Max's "[PATCH 0/4] qapi/block-core: Add "new" qcow2 options" series. (Max) Fix nfs return code. (Benoit) Add Beniot's rev-by lines in other p

[Qemu-devel] [PATCH v3 1/3] nfs: Fix leak of opts in nfs_file_open

2014-08-27 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/nfs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 93d87f3..194f301 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -393,16 +393,20 @@ static int nfs_file_open(BlockDriverState *bs, QDict *options,

[Qemu-devel] [PATCH v3 3/3] quorum: Fix leak of opts in quorum_open

2014-08-27 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Benoît Canet --- block/quorum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 0de07bb..ffe8bd9 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -796,7 +796,7 @@ static int quorum_open(BlockDriv

[Qemu-devel] [PATCH v3] block: Introduce "null" driver

2014-08-27 Thread Fam Zheng
This is an analogue to Linux null_blk. It can be used for testing block device emulation and general block layer functionalities such as coroutines and throttling, where disk IO is not necessary or wanted. Use null:// for AIO version, and null-co:// for coroutine version. Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH v2 1/3] nfs: Fix leak of opts in nfs_file_open

2014-08-27 Thread Fam Zheng
On Thu, 08/28 06:48, Benoît Canet wrote: > The Thursday 28 Aug 2014 à 12:12:36 (+0800), Fam Zheng wrote : > > Signed-off-by: Fam Zheng > > --- > > block/nfs.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/block/nfs.c b/block/nfs.c > > index 93d87f3..8740c

[Qemu-devel] [PATCH] qmp: using genneric string paring function for 'qom-set'

2014-08-27 Thread arei.gonglei
From: Gonglei At present, 'qom-set' only can set string type property, which will restrict this qmp command's function. Using genneric string paring function can handle different types, such as int/bool/string etc. Signed-off-by: Gonglei --- Example: # ./scripts/qmp/qom-set nic1.realized false

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-27 Thread Hu Tao
On Tue, Aug 26, 2014 at 11:44:26AM +0100, Stefan Hajnoczi wrote: > On Mon, Aug 25, 2014 at 09:35:15AM +0800, Hu Tao wrote: > > On Fri, Aug 22, 2014 at 12:54:29PM +0200, Kevin Wolf wrote: > > > Am 28.07.2014 um 10:48 hat Hu Tao geschrieben: > > > > ping... > > > > > > > > All the 6 patches have rev

Re: [Qemu-devel] [PATCH] hmp: Add info machines

2014-08-27 Thread zhanghailiang
On 2014/8/28 10:43, Amos Kong wrote: On Thu, Aug 28, 2014 at 9:44 AM, zhanghailiang< zhang.zhanghaili...@huawei.com> wrote: On 2014/8/27 18:00, Paolo Bonzini wrote: Il 27/08/2014 11:24, zhanghailiang ha scritto: This is the hmp counterpart of qmp query_machines Signed-off-by: zhanghailian

Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting

2014-08-27 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Subject: Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take > effect after rebooting > > Hi, > > > 1. Does have ready-to-wear interface to get QOM path by qdev id,? > > You can simply use the id directly. Try this: > > qemu

Re: [Qemu-devel] [PATCH v2 1/3] nfs: Fix leak of opts in nfs_file_open

2014-08-27 Thread Benoît Canet
The Thursday 28 Aug 2014 à 12:12:36 (+0800), Fam Zheng wrote : > Signed-off-by: Fam Zheng > --- > block/nfs.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/block/nfs.c b/block/nfs.c > index 93d87f3..8740c1a 100644 > --- a/block/nfs.c > +++ b/block/nfs.c > @@ -3

Re: [Qemu-devel] [PATCH v2] block: Introduce "null" driver

2014-08-27 Thread Benoît Canet
The Thursday 28 Aug 2014 à 12:02:36 (+0800), Fam Zheng wrote : > This is an analogue to Linux null_blk. It can be used for testing block > device emulation and general block layer functionalities such as > coroutines and throttling, where disk IO is not necessary or wanted. > > Use null:// for AIO

[Qemu-devel] [PATCH v2 3/3] quorum: Fix leak of opts in quorum_open

2014-08-27 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Benoît Canet --- block/quorum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 0de07bb..ffe8bd9 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -796,7 +796,7 @@ static int quorum_open(BlockDriv

[Qemu-devel] [PATCH v2 1/3] nfs: Fix leak of opts in nfs_file_open

2014-08-27 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/nfs.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 93d87f3..8740c1a 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -393,15 +393,19 @@ static int nfs_file_open(BlockDriverState *bs, QDict *options, in

[Qemu-devel] [PATCH v2 2/3] blkverify: Fix leak of opts in blkverify_open

2014-08-27 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Benoît Canet --- block/blkverify.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blkverify.c b/block/blkverify.c index 7c78ca4..163064c 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -158,6 +158,7 @@ static int blkverify_open(BlockDriv

[Qemu-devel] [PATCH v2 0/3] block: Fix leaks of opts in block drivers

2014-08-27 Thread Fam Zheng
Remember to call qemu_opts_del before function returning. v2: Drop qcow2 fix since it's duplicated with Max's "[PATCH 0/4] qapi/block-core: Add "new" qcow2 options" series. (Max) Fix nfs return code. (Benoit) Add Beniot's rev-by lines in other patches. (Thanks for reviewing) Fam Zhe

Re: [Qemu-devel] [PATCH 1/4] nfs: Fix leak of opts in nfs_file_open

2014-08-27 Thread Fam Zheng
On Wed, 08/27 16:46, Benoît Canet wrote: > The Wednesday 27 Aug 2014 à 14:02:33 (+0800), Fam Zheng wrote : > > Signed-off-by: Fam Zheng > > --- > > block/nfs.c | 7 +-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/block/nfs.c b/block/nfs.c > > index 93d87f3..36e80

Re: [Qemu-devel] [PATCH 4/4] qcow2: Fix leak of opts in qcow2_open

2014-08-27 Thread Fam Zheng
On Wed, 08/27 19:40, Max Reitz wrote: > On 27.08.2014 08:02, Fam Zheng wrote: > >Not all the error paths release opts, fix it by moving it after the fail > >label. > > > >Signed-off-by: Fam Zheng > >--- > > block/qcow2.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > This is

[Qemu-devel] [RFC V2 02/10] qom/cpu: move register_vmstate to common CPUClass.realizefn

2014-08-27 Thread Gu Zheng
Move cpu vmstate register from cpu_exec_init into cpu_common_realizefn, apic vmstate register into x86_cpu_apic_realize. And use the cc->get_arch_id as the instance id that suggested by Igor to fix the migration issue. Besides, also use cc->get_arch_id as the cpu index of HMP/QMP command output to

[Qemu-devel] [PATCH v2] block: Introduce "null" driver

2014-08-27 Thread Fam Zheng
This is an analogue to Linux null_blk. It can be used for testing block device emulation and general block layer functionalities such as coroutines and throttling, where disk IO is not necessary or wanted. Use null:// for AIO version, and null-co:// for coroutine version. Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH 4/4] qcow2: Fix leak of opts in qcow2_open

2014-08-27 Thread Fam Zheng
On Wed, 08/27 16:40, Benoît Canet wrote: > The Wednesday 27 Aug 2014 à 14:02:36 (+0800), Fam Zheng wrote : > > Not all the error paths release opts, fix it by moving it after the fail > > label. > > > > Signed-off-by: Fam Zheng > > --- > > block/qcow2.c | 5 ++--- > > 1 file changed, 2 insertion

[Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-08-27 Thread Gu Zheng
After ACPI get a signal to eject a vCPU, the vCPU must be removed from CPU list,before the vCPU really removed, then release the all related vCPU objects. But we do not close KVM vcpu fd, just record it into a list, in order to reuse it. Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- cpus

[Qemu-devel] [RFC V2 09/10] cpu hotplug: implement function cpu_status_write() for vcpu ejection

2014-08-27 Thread Gu Zheng
From: Chen Fan When OS ejected a vcpu (like: echo 1 > /sys/bus/acpi/devices/LNXCPUXX/eject), it would call acpi EJ0 method, the firmware need to write the new cpumap, QEMU would know which vcpu need to be ejected. TODO: -confirm the hotplug result via OST if guest support it. Signed-off-by: Che

[Qemu-devel] [RFC V2 03/10] cpu: add device_add foo-x86_64-cpu support

2014-08-27 Thread Gu Zheng
From: Chen Fan Add support to device_add foo-x86_64-cpu, and additional checks of apic id are added into x86_cpuid_set_apic_id() and x86_cpu_apic_create() for duplicate. Besides, in order to support "device/device_add foo-x86_64-cpu" which without specified apic id, we add a new function get_free

[Qemu-devel] [RFC V2 08/10] i386: implement pc interface cpu_common_unrealizefn() in qom/cpu.c

2014-08-27 Thread Gu Zheng
From: Chen Fan add interface cpu_common_unrealizefn() for emiting vcpu unplug notifier to ACPI, then ACPI could send sci interrupt to OS for hot-remove vcpu. Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- qom/cpu.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) d

[Qemu-devel] [RFC V2 04/10] x86: add x86_cpu_unrealizefn() for cpu apic remove

2014-08-27 Thread Gu Zheng
From: Chen Fan Implement x86_cpu_unrealizefn() for corresponding x86_cpu_realizefn(), which is mostly used to clean the apic related allocation and vmstates at here. Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- hw/i386/kvm/apic.c |8 +++ hw/intc/apic.c

[Qemu-devel] [RFC V2 07/10] qom cpu: add UNPLUG cpu notify support

2014-08-27 Thread Gu Zheng
Introduce a common cpu hotplug notifier(CPUNotifier) to support UNPLUG cpu notify. Signed-off-by: Gu Zheng Signed-off-by: Chen Fan --- hw/acpi/cpu_hotplug.c | 15 +++ hw/acpi/ich9.c|5 - hw/acpi/piix4.c | 11 +++ include/hw/a

[Qemu-devel] [RFC V2 06/10] qom cpu: rename variable 'cpu_added_notifier' to 'cpu_hotplug_notifier'

2014-08-27 Thread Gu Zheng
From: Chen Fan Rename variable 'cpu_added_notifier' to 'cpu_hotplug_notifier' for adding remove vcpu notifier support. Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- hw/acpi/ich9.c |8 hw/acpi/piix4.c | 10 +- hw/i386/pc.c|2 +- inc

[Qemu-devel] [RFC V2 05/10] i386: add cpu device_del support

2014-08-27 Thread Gu Zheng
In order to add cpu(i386) device_del support, introduce the cpu hot unplug hanlde(x86_cpu_unplug) which will trigger the unrealize routine, and just register it to the cpu class unplug handle. Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- target-i386/cpu.c | 22 ++ 1

[Qemu-devel] [RFC V2 01/10] cpu: introduce CpuTopoInfo structure for argument simplification

2014-08-27 Thread Gu Zheng
From: Chen Fan Reviewed-by: Eduardo Habkost Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- target-i386/topology.h | 33 + 1 files changed, 17 insertions(+), 16 deletions(-) diff --git a/target-i386/topology.h b/target-i386/topology.h index 07a6c5f..e9ff

[Qemu-devel] [RFC V2 00/10] cpu: add device_add foo-x86_64-cpu and i386 cpu hot remove support

2014-08-27 Thread Gu Zheng
This series is based on the previous patchset from Chen Fan: https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html https://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg04266.html Patch 1~3: add device_add foo-x86_64-cpu support These three patches try to make cpu hotplug wi

Re: [Qemu-devel] [PATCH] hmp: Add info machines

2014-08-27 Thread Amos Kong
On Thu, Aug 28, 2014 at 9:44 AM, zhanghailiang < zhang.zhanghaili...@huawei.com> wrote: > On 2014/8/27 18:00, Paolo Bonzini wrote: > >> Il 27/08/2014 11:24, zhanghailiang ha scritto: >> >>> This is the hmp counterpart of qmp query_machines >>> >>> Signed-off-by: zhanghailiang >>> --- >>> hmp-com

Re: [Qemu-devel] [PATCH] hmp: Add info machines

2014-08-27 Thread zhanghailiang
On 2014/8/27 18:00, Paolo Bonzini wrote: Il 27/08/2014 11:24, zhanghailiang ha scritto: This is the hmp counterpart of qmp query_machines Signed-off-by: zhanghailiang --- hmp-commands.hx | 2 ++ hmp.c | 22 ++ hmp.h | 1 + monitor.c | 7

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-08-27 Thread Chen, Tiejun
On 2014/8/27 21:03, Michael S. Tsirkin wrote: On Wed, Aug 27, 2014 at 05:13:07PM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen --

Re: [Qemu-devel] [PATCH v7 0/8] memory API improvements and bug fixes for memory backends

2014-08-27 Thread Hu Tao
ping...

Re: [Qemu-devel] [PATCH] acpi-build: Set FORCE_APIC_CLUSTER_MODEL bit of FADT flags

2014-08-27 Thread zhanghailiang
On 2014/8/27 21:59, Michael S. Tsirkin wrote: On Thu, Aug 21, 2014 at 04:37:29PM +0800, zhanghailiang wrote: If we start Windows 2008 R2 DataCenter with number of cpu less than 8, The system will use APIC Flat Logical destination mode as default configuration, Which has an upper limit of 8 CPUs.

Re: [Qemu-devel] [RESEND v2 0/3] Fix some memory leaks about query memdev

2014-08-27 Thread chen.fan.f...@cn.fujitsu.com
ping ? On Mon, 2014-08-18 at 14:46 +0800, Chen Fan wrote: > when using valgrind to test the command "query memdev", I had > found some memory leaks. the test result: > > ==13802== 4 bytes in 1 blocks are definitely lost in loss record 125 of 8,508 > ==13802==at 0x4A08934: malloc (vg_replace_

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-27 Thread Chen, Tiejun
+ */ +dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), +"xen-igd-passthrough-isa-bridge"); +if (dev) { +r = xen_host_pci_device_get(&hdev, 0, 0, PCI_DEVFN(0x1f, 0), 0); +if (!r) { +pci_config_set_vendor_id(dev->config, hdev.vendor

Re: [Qemu-devel] [PATCH V4] net: Forbid dealing with packets when VM is not running

2014-08-27 Thread zhanghailiang
On 2014/8/27 19:59, Michael S. Tsirkin wrote: On Wed, Aug 27, 2014 at 01:53:21PM +0200, Michael S. Tsirkin wrote: On Tue, Aug 26, 2014 at 04:06:17PM +0800, zhanghailiang wrote: For all NICs(except virtio-net) emulated by qemu, Such as e1000, rtl8139, pcnet and ne2k_pci, Qemu can still receive p

Re: [Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-27 Thread Fam Zheng
On Wed, 08/27 18:31, Richard W.M. Jones wrote: > Signed-off-by: Richard W.M. Jones It would be better to add the cover letter explanation as the commit message of the patch too. > --- > block/curl.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/block/curl.c b

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] Support ppc64le binfmt registration

2014-08-27 Thread Serge E. Hallyn
Quoting Serge E. Hallyn (se...@hallyn.com): > Quoting Alexander Graf (ag...@suse.de): > > > > > > On 27.08.14 23:35, Peter Maydell wrote: > > > On 27 August 2014 22:30, Alexander Graf wrote: > > >> > > >> > > >> On 27.08.14 21:01, Peter Maydell wrote: > > >>> [adding qemu-ppc] > > >>> > > >>> On

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] Support ppc64le binfmt registration

2014-08-27 Thread Serge E. Hallyn
Quoting Alexander Graf (ag...@suse.de): > > > On 27.08.14 23:35, Peter Maydell wrote: > > On 27 August 2014 22:30, Alexander Graf wrote: > >> > >> > >> On 27.08.14 21:01, Peter Maydell wrote: > >>> [adding qemu-ppc] > >>> > >>> On 27 August 2014 19:45, Serge E. Hallyn wrote: > Quoting Pete

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] Support ppc64le binfmt registration

2014-08-27 Thread Alexander Graf
On 27.08.14 23:35, Peter Maydell wrote: > On 27 August 2014 22:30, Alexander Graf wrote: >> >> >> On 27.08.14 21:01, Peter Maydell wrote: >>> [adding qemu-ppc] >>> >>> On 27 August 2014 19:45, Serge E. Hallyn wrote: Quoting Peter Maydell (peter.mayd...@linaro.org): > On 27 August 2014

Re: [Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 19:31, Richard W.M. Jones ha scritto: > Signed-off-by: Richard W.M. Jones > --- > block/curl.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/block/curl.c b/block/curl.c > index 46f1082..8b69f28 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@

Re: [Qemu-devel] [BUG] Guest freezes when resuming from S3

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 22:02, Luiz Capitulino ha scritto: > > commit c046e8c4a26c902ca1b4f5bdf668a2da6bc75f54 > Author: Michael S. Tsirkin > Date: Wed Sep 11 13:33:31 2013 +0300 > > piix4: disable io on reset > > On the hand, testing the commit before this one works and that one doesn't. > But I'v

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] Support ppc64le binfmt registration

2014-08-27 Thread Peter Maydell
On 27 August 2014 22:30, Alexander Graf wrote: > > > On 27.08.14 21:01, Peter Maydell wrote: >> [adding qemu-ppc] >> >> On 27 August 2014 19:45, Serge E. Hallyn wrote: >>> Quoting Peter Maydell (peter.mayd...@linaro.org): On 27 August 2014 18:55, Serge E. Hallyn wrote: > This is a part

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] Support ppc64le binfmt registration

2014-08-27 Thread Alexander Graf
On 27.08.14 21:01, Peter Maydell wrote: > [adding qemu-ppc] > > On 27 August 2014 19:45, Serge E. Hallyn wrote: >> Quoting Peter Maydell (peter.mayd...@linaro.org): >>> On 27 August 2014 18:55, Serge E. Hallyn wrote: This is a part of a patch proposed by jaejunh at https://bugs.launc

[Qemu-devel] [PATCH 22/25] pcihp: fix possible array out of bounds

2014-08-27 Thread Michael Roth
From: Gonglei Prevent out-of-bounds array access on acpi_pcihp_pci_status. Signed-off-by: Gonglei Reviewed-by: Peter Crosthwaite Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Cc: qemu-sta...@nongnu.org Reviewed-by: Marcel Apfelbaum (cherry picked from commit fa365d7cd111

Re: [Qemu-devel] Using cache=writeback safely on qemu 1.4.0 and later

2014-08-27 Thread Paolo Bonzini
> > Just the lack of fdatasyncs. > > I also did not see any fdatasyncs when using cache=none - would that also be > explained by this bug? Yes, cache=none and cache=writeback are the same as far as the _disk_ cache is concerned, and you need fdatasyncs to flush the disk cache too. Paolo

[Qemu-devel] [PATCH v4 08/10] qcow2: Clean up after refcount rebuild

2014-08-27 Thread Max Reitz
Because the old refcount structure will be leaked after having rebuilt it, we need to recalculate the refcounts and run a leak-fixing operation afterwards (if leaks should be fixed at all). Signed-off-by: Max Reitz Reviewed-by: Benoît Canet --- block/qcow2-refcount.c | 35 ++

[Qemu-devel] [PATCH v4 07/10] qcow2: Rebuild refcount structure during check

2014-08-27 Thread Max Reitz
The previous commit introduced the "rebuild" variable to qcow2's implementation of the image consistency check. Now make use of this by adding a function which creates a completely new refcount structure based solely on the in-memory information gathered before. The old refcount structure will be

[Qemu-devel] [PATCH v4 06/10] qcow2: Do not perform potentially damaging repairs

2014-08-27 Thread Max Reitz
If a referenced cluster has a refcount of 0, increasing its refcount may result in clusters being allocated for the refcount structures. This may overwrite the referenced cluster, therefore we cannot simply increase the refcount then. In such cases, we can either try to replicate all the refcount

[Qemu-devel] [PATCH v4 10/10] iotests: Add test for potentially damaging repairs

2014-08-27 Thread Max Reitz
There are certain cases where repairing a qcow2 image might actually damage it further (or rather, where repairing it has in fact damaged it further with the old qcow2 check implementation). This should not happen, so add a test for these cases. Furthermore, the repair function now repairs refbloc

[Qemu-devel] [PATCH v4 05/10] qcow2: Fix refcount blocks beyond image end

2014-08-27 Thread Max Reitz
If the qcow2 check function detects a refcount block located beyond the image end, grow the image appropriately. This cannot break anything and is the logical fix for such a case. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 62 ++ 1 file

[Qemu-devel] [PATCH v4 09/10] iotests: Fix test outputs

2014-08-27 Thread Max Reitz
039, 060 and 061 all create images with referenced clusters having a refcount of 0. Because previous commits changed handling of such errors, these tests now have a different output. Fix it. Furthermore, 060 created a refblock with a refcount greater than one which now results in having to rebuild

[Qemu-devel] [PATCH v4 03/10] qcow2: Pull check_refblocks() up

2014-08-27 Thread Max Reitz
Pull check_refblocks() before calculate_refcounts() so we can drop its static declaration. Signed-off-by: Max Reitz Reviewed-by: Benoît Canet --- block/qcow2-refcount.c | 102 - 1 file changed, 49 insertions(+), 53 deletions(-) diff --git a/block

[Qemu-devel] [PATCH v4 04/10] qcow2: Reuse refcount table in calculate_refcounts()

2014-08-27 Thread Max Reitz
We will later call calculate_refcounts multiple times, so reuse the refcount table if possible. Signed-off-by: Max Reitz Reviewed-by: Benoît Canet --- block/qcow2-refcount.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-ref

[Qemu-devel] [PATCH v4 01/10] qcow2: Fix leaks in dirty images

2014-08-27 Thread Max Reitz
When opening dirty images, qcow2's repair function should not only repair errors but leaks as well. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Benoît Canet --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c ind

[Qemu-devel] [PATCH v4 02/10] qcow2: Split qcow2_check_refcounts()

2014-08-27 Thread Max Reitz
Put the code for calculating the reference counts and comparing them during qemu-img check into own functions. Signed-off-by: Max Reitz Reviewed-by: Benoît Canet --- block/qcow2-refcount.c | 153 - 1 file changed, 102 insertions(+), 51 deletions(-

[Qemu-devel] [PATCH v4 00/10] qcow2: Fix image repairing

2014-08-27 Thread Max Reitz
As can be seen in the final patch of this series, there are certain cases where the current repair implementation of qcow2 actually damages the image further because it allocates new clusters for the refcount structure which overlap with existing but according to the on-disk refcounts (which are as

[Qemu-devel] [BUG] Guest freezes when resuming from S3

2014-08-27 Thread Luiz Capitulino
Hi, I won't have time to keep debugging this so I'll just report what I have. The basic problem is: you suspend a Linux guest to RAM, and the screen (or maybe the guest) freezes when resuming. Here's some debugging info: v1.6.0: last fully working version v1.7.0: doesn't exactly freeze, but the

Re: [Qemu-devel] pert stat in KVM guest can not get LLC-loads hardware cache event

2014-08-27 Thread Liang, Kan
> > Inside the guest, I am using "perf stat -e dTLB-load-misses -e > > dTLB-loads -e L1-dcache-loads -e L1-dcache-load-misses -e > > L1-dcache-prefetch-misses ", followed by the parsec command. > > The misses/hit radio is the first number after "#". For your case, 0.00% is the misses/hit radi

Re: [Qemu-devel] Suspend/Hibernation support status in RHEL7

2014-08-27 Thread Luiz Capitulino
On Wed, 27 Aug 2014 15:07:48 -0400 Luiz Capitulino wrote: > Hi, > > After having debugged a hibernation BZ reported by QE, I got confused > about the support status of suspend/hibernate in RHEL7. Please, disregard. Internal email :(

[Qemu-devel] Suspend/Hibernation support status in RHEL7

2014-08-27 Thread Luiz Capitulino
Hi, After having debugged a hibernation BZ reported by QE, I got confused about the support status of suspend/hibernate in RHEL7. What I had in mind was that S3 was supported but S4 was not. Amit confirmed that S4 is not supported in RHEL7, but: 1. We document, or at least imply, that both S3 a

Re: [Qemu-devel] [PATCH 1/1] Support ppc64le binfmt registration

2014-08-27 Thread Peter Maydell
[adding qemu-ppc] On 27 August 2014 19:45, Serge E. Hallyn wrote: > Quoting Peter Maydell (peter.mayd...@linaro.org): >> On 27 August 2014 18:55, Serge E. Hallyn wrote: >> > This is a part of a patch proposed by jaejunh at >> > https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1358268 >> > whi

Re: [Qemu-devel] Using cache=writeback safely on qemu 1.4.0 and later

2014-08-27 Thread Andrew Martin
- Original Message - > From: "Paolo Bonzini" > To: "Andrew Martin" > Cc: "Stefan Hajnoczi" , "qemu-devel" > > Sent: Wednesday, August 27, 2014 9:34:27 AM > Subject: Re: Using cache=writeback safely on qemu 1.4.0 and later > > Il 27/08/2014 16:23, Andrew Martin ha scritto: > > Thanks fo

Re: [Qemu-devel] [PATCH 1/1] Support ppc64le binfmt registration

2014-08-27 Thread Serge E. Hallyn
Quoting Peter Maydell (peter.mayd...@linaro.org): > On 27 August 2014 18:55, Serge E. Hallyn wrote: > > This is a part of a patch proposed by jaejunh at > > https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1358268 > > which enables running ppc64le binaries through qemu-user. > > I'm confused -

Re: [Qemu-devel] [PATCH v3 07/10] qcow2: Rebuild refcount structure during check

2014-08-27 Thread Max Reitz
On 25.08.2014 19:40, Benoît Canet wrote: On Fri, Aug 22, 2014 at 06:31:41PM +0200, Max Reitz wrote: The previous commit introduced the "rebuild" variable to qcow2's implementation of the image consistency check. Now make use of this by adding a function which creates a completely new refcount st

Re: [Qemu-devel] [PATCH 1/1] Support ppc64le binfmt registration

2014-08-27 Thread Peter Maydell
On 27 August 2014 18:55, Serge E. Hallyn wrote: > This is a part of a patch proposed by jaejunh at > https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1358268 > which enables running ppc64le binaries through qemu-user. I'm confused -- wouldn't these be handled by the existing "ppc64le" support?

[Qemu-devel] [PATCH 1/1] Support ppc64le binfmt registration

2014-08-27 Thread Serge E. Hallyn
This is a part of a patch proposed by jaejunh at https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1358268 which enables running ppc64le binaries through qemu-user. Not sure if it's the right way to do it, but it does allow me to chroot into a ppc64el rootfs on amd64 host. Signed-off-by: Serge

Re: [Qemu-devel] pert stat in KVM guest can not get LLC-loads hardware cache event

2014-08-27 Thread Steven
Inside the guest, I am using "perf stat -e dTLB-load-misses -e dTLB-loads -e L1-dcache-loads -e L1-dcache-load-misses -e L1-dcache-prefetch-misses ", followed by the parsec command. Thanks. - Hui On Wed, Aug 27, 2014 at 12:28 PM, Liang, Kan wrote: > >> > Hi, Kan, >> > >> > The dTLB-load-misses

[Qemu-devel] [PATCH 25/25] thread-pool: avoid deadlock in nested aio_poll() calls

2014-08-27 Thread Michael Roth
From: Stefan Hajnoczi The thread pool has a race condition if two elements complete before thread_pool_completion_bh() runs: If element A's callback waits for element B using aio_poll() it will deadlock since pool->completion_bh is not marked scheduled when the nested aio_poll() runs. Fix

[Qemu-devel] [PATCH 20/25] vmxnet3: Pad short frames to minimum size (60 bytes)

2014-08-27 Thread Michael Roth
From: Ben Draper When running VMware ESXi under qemu-kvm the guest discards frames that are too short. Short ARP Requests will be dropped, this prevents guests on the same bridge as VMware ESXi from communicating. This patch simply adds the padding on the network device itself. Signed-off-by: Be

[Qemu-devel] [PATCH 14/25] target-arm: Rename QEMU PSCI v0.1 definitions

2014-08-27 Thread Michael Roth
From: Christoffer Dall The function IDs for PSCI v0.1 are exported by KVM and defined as KVM_PSCI_FN_. To build using these defines in non-KVM code, QEMU defines these IDs locally and check their correctness against the KVM headers when those are available. However, the naming scheme used for Q

[Qemu-devel] [PATCH 24/25] thread-pool: avoid per-thread-pool EventNotifier

2014-08-27 Thread Michael Roth
From: Stefan Hajnoczi EventNotifier is implemented using an eventfd or pipe. It therefore consumes file descriptors, which can be limited by rlimits and should therefore be used sparingly. Switch from EventNotifier to QEMUBH in thread-pool.c. Originally EventNotifier was used because qemu_bh_s

[Qemu-devel] [PATCH 18/25] qemu-iotests: add test case 101 for short file I/O

2014-08-27 Thread Michael Roth
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf (cherry picked from commit 8d9eb33ca0bbb8bca0f1775623ed3cf5f39760cd) Conflicts: tests/qemu-iotests/group *fix up context mismatches due to lack of 099 and 103 tests Signed-off-by: Michael Roth --- tests/

[Qemu-devel] [PATCH 23/25] pc: reserve more memory for ACPI for new machine types

2014-08-27 Thread Michael Roth
From: "Michael S. Tsirkin" commit 868270f23d8db2cce83e4f082fe75e8625a5fbf9 acpi-build: tweak acpi migration limits broke kernel loading with -kernel/-initrd: it doubled the size of ACPI tables but did not reserve enough memory. As a result, issues on boot and halt are observed. Fix this up

Re: [Qemu-devel] [PATCH 4/4] qcow2: Fix leak of opts in qcow2_open

2014-08-27 Thread Max Reitz
On 27.08.2014 08:02, Fam Zheng wrote: Not all the error paths release opts, fix it by moving it after the fail label. Signed-off-by: Fam Zheng --- block/qcow2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) This is pretty much the same patch as 'qcow2: Fix leak of QemuOpts in

[Qemu-devel] [PATCH 19/25] blkdebug: Delete BH in bdrv_aio_cancel

2014-08-27 Thread Michael Roth
From: Fam Zheng Otherwise error_callback_bh will access the already released acb. Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf (cherry picked from commit cbf95a0b117461473f05ab3cce4d01ba2b29e60a) Signed-off-by: Michael Roth --- block/blkdebug.c | 4 1 fi

[Qemu-devel] [PATCH 16/25] block/iscsi: fix memory corruption on iscsi resize

2014-08-27 Thread Michael Roth
From: Peter Lieven bs->total_sectors is not yet updated at this point. resulting in memory corruption if the volume has grown and data is written to the newly availble areas. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Signed-off-by: Kevin Wolf (cherry picked from commit d832fb4d66e

[Qemu-devel] [PATCH 15/25] arm/virt: Use PSCI v0.2 function IDs in the DT when KVM uses PSCI v0.2

2014-08-27 Thread Michael Roth
From: Christoffer Dall The current code supplies the PSCI v0.1 function IDs in the DT even when KVM uses PSCI v0.2. This will break guest kernels that only support PSCI v0.1 as they will use the IDs provided in the DT. Guest kernels with PSCI v0.2 support are not affected by this patch, because

[Qemu-devel] [PATCH 09/25] pc-dimm: fix up error message

2014-08-27 Thread Michael Roth
From: "Michael S. Tsirkin" - int should be printed using %d - print actual wrong value for property Cc: qemu-sta...@nongnu.org Signed-off-by: Michael S. Tsirkin (cherry picked from commit 988eba0f681bd4f82e9e02998da8106f165ed82c) Signed-off-by: Michael Roth --- hw/mem/pc-dimm.c | 5 +++-- 1 f

[Qemu-devel] [PATCH 21/25] hostmem: set MPOL_MF_MOVE

2014-08-27 Thread Michael Roth
From: "Michael S. Tsirkin" When memory is allocated on a wrong node, MPOL_MF_STRICT doesn't move it - it just fails the allocation. A simple way to reproduce the failure is with mlock=on realtime feature. The code comment actually says: "ensure policy won't be ignored" so setting MPOL_MF_MOVE se

[Qemu-devel] [PATCH 17/25] raw-posix: fix O_DIRECT short reads

2014-08-27 Thread Michael Roth
From: Stefan Hajnoczi The following O_DIRECT read from a <512 byte file fails: $ truncate -s 320 test.img $ qemu-io -n -c 'read -P 0 0 512' test.img qemu-io: can't open device test.img: Could not read image for determining its format: Invalid argument Note that qemu-io completes successf

[Qemu-devel] [PATCH 11/25] acpi: align RSDP

2014-08-27 Thread Michael Roth
From: "Michael S. Tsirkin" RSDP should be aligned at a 16-byte boundary. This would by chance at the moment, fix up acpi build to make it robust. Cc: qemu-sta...@nongnu.org Signed-off-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek (cherry picked from commit d67aadccfa0bd3330a7b8e7e0a1726117b

[Qemu-devel] [PATCH 10/25] numa: show hex number in error message for consistency and prefix them with 0x

2014-08-27 Thread Michael Roth
From: Hu Tao The error messages before and after patch are: before: qemu-system-x86_64: total memory for NUMA nodes (134217728) should equal RAM size (2000) after: qemu-system-x86_64: total memory for NUMA nodes (0x800) should equal RAM size (0x2000) Cc: qemu-sta...@nongnu.org Si

[Qemu-devel] [PATCH 01/25] qmp: hide "hotplugged" device property from device-list-properties

2014-08-27 Thread Michael Roth
From: Stefan Hajnoczi The "hotplugged" device property was not reported before commit f4eb32b590bf58c1c67570775eb78beb09964fad ("qmp: show QOM properties in device-list-properties"). Fix this difference. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake (cherry picked from commit 4115dd6

[Qemu-devel] [PATCH 13/25] target-arm: Fix return address for A64 BRK instructions

2014-08-27 Thread Michael Roth
From: Peter Maydell When we take an exception resulting from a BRK instruction, the architecture requires that the "preferred return address" reported to the exception handler is the address of the BRK itself, not the following instruction (like undefined insns, and in contrast with SVC, HVC and

[Qemu-devel] [PATCH 04/25] l2tpv3 (configure): it is linux-specific

2014-08-27 Thread Michael Roth
From: Michael Tokarev Some non-linux systems, for example a system with FreeBSD kernel and glibc, may declare struct mmsghdr (in glibc) but may not have linux-specific header file linux/ip.h. The actual implementation in qemu includes this linux-specific header file unconditionally, so compilati

[Qemu-devel] [PATCH 05/25] ide: only constrain read/write requests to drive size, not other types

2014-08-27 Thread Michael Roth
From: Michael Tokarev Commit 58ac321135a introduced a check to ide dma processing which constrains all requests to drive size. However, apparently, some valid requests (like TRIM) does not fit in this constraint, and fails in 2.1. So check the range only for reads and writes. Cc: qemu-sta...@n

[Qemu-devel] [PATCH 12/25] virtio-blk: fix reference a pointer which might be freed

2014-08-27 Thread Michael Roth
From: zhanghailiang In function virtio_blk_handle_request, it may freed memory pointed by req, So do not access member of req after calling this function. Cc: qemu-sta...@nongnu.org Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: zhanghailiang Signed-off-by: Kevin

[Qemu-devel] [PATCH 06/25] pci: Use bus master address space for delivering MSI/MSI-X messages

2014-08-27 Thread Michael Roth
From: Jan Kiszka The spec says (and real HW confirms this) that, if the bus master bit is 0, the device will not generate any PCI accesses. MSI and MSI-X messages fall among these, so we should use the corresponding address space to deliver them. This will prevent delivery if bus master support i

[Qemu-devel] [PATCH 03/25] vfio: Fix MSI-X vector expansion

2014-08-27 Thread Michael Roth
From: Alex Williamson When new MSI-X vectors are enabled we need to disable MSI-X and re-enable it with the correct number of vectors. That means we need to reprogram the eventfd triggers for each vector. Prior to f4d45d47 vector->use tracked whether a vector was masked or unmasked and we could

[Qemu-devel] [PATCH 08/25] pc-dimm: validate node property

2014-08-27 Thread Michael Roth
From: Hu Tao If user specifies a node number that exceeds the available numa nodes in emulated system for pc-dimm device, the device will report an invalid _PXM to OSPM. Fix this by checking the node property value. Cc: qemu-sta...@nongnu.org Signed-off-by: Hu Tao Reviewed-by: Michael S. Tsirki

[Qemu-devel] [PATCH 07/25] hw:i386: typo fix: MEMORY_HOPTLUG_DEVICE -> MEMORY_HOTPLUG_DEVICE

2014-08-27 Thread Michael Roth
From: Hu Tao Cc: qemu-sta...@nongnu.org Signed-off-by: Hu Tao Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit 41d2f71376fe401a1fdb7deda023769207511790) Signed-off-by: Michael Roth --- hw/i386/acpi-dsdt.dsl | 4 ++-- hw/i386/acpi-dsdt.he

  1   2   3   >