Re: [Qemu-devel] [PATCH] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-08-26 Thread Markus Armbruster
"john.liuli" writes: > From: Li Liu > > Eeay to reproduce, just try "qemu -monitor stdio -nographic" > and type "quit", then the terminal will be crashed. > > There are two pathes try to call tcgetattr of stdio in vl.c: > > 1) Monitor_parse(optarg, "readline"); >. >qemu_opts_foreach(

Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

2014-08-26 Thread Markus Armbruster
Eric Blake writes: > On 08/26/2014 08:38 PM, Fam Zheng wrote: >> On Tue, 08/26 21:48, Richard W.M. Jones wrote: >>> Some servers (notably VMware ESX) accept range requests, but don't >>> send back the Accept-Ranges: bytes header in their initial response. >>> >>> For these servers you can set ove

Re: [Qemu-devel] [PATCH 3/3] qemu-img: always goto out in img_snapshot() error paths

2014-08-26 Thread Markus Armbruster
Stefan Hajnoczi writes: > The out label has the qemu_progress_end() and other cleanup calls. > Always goto out in error paths so the cleanup happens. > > Note that bdrv_unref(NULL) is safe. We just need to initialize bs to > NULL at the top of the function. > > We can now remove the obsolete bs_

Re: [Qemu-devel] [PATCH 1/3] qemu-img: fix img_commit() error return value

2014-08-26 Thread Markus Armbruster
John Snow writes: > On 08/26/2014 03:31 PM, Eric Blake wrote: >> On 08/26/2014 12:17 PM, Stefan Hajnoczi wrote: >>> The img_commit() return value is a process exit code. Use 1 for failure >>> instead of -1. The other failure paths in this function already use 1. >>> >>> Signed-off-by: Stefan Ha

[Qemu-devel] [PATCH] block: Introduce "null" driver

2014-08-26 Thread Fam Zheng
This is an analogue to Linux null_blk. It can be used for testing block device emulation and general block layer functionalities such as coroutines and throttling, where disk IO is not necessary or wanted. Signed-off-by: Fam Zheng --- block/Makefile.objs | 1 + block/null.c| 172 ++

Re: [Qemu-devel] [PATCH v4 5/5] qemu-iotests: Add 093 for IO throttling

2014-08-26 Thread Fam Zheng
On Tue, 08/26 14:50, Stefan Hajnoczi wrote: > On Thu, Jun 05, 2014 at 04:47:46PM +0800, Fam Zheng wrote: > > +def setUp(self): > > +qemu_img('create', '-f', iotests.imgfmt, test_img, "1G") > > +#self.vm = iotests.VM().add_drive(test_img, "bps=1024,bps_max=1") > > Commented out

[Qemu-devel] sparc64/virtio: unable to init msix vectors to 2

2014-08-26 Thread Mark Cave-Ayland
Hi all, When creating a qemu-system-sparc64 machine with a virtio interface, both QEMU 2.1.0 and current git master emit the above warning: $ ./qemu-system-sparc64 -drive file=/tmp/file.txt,if=virtio,index=0 -nographic qemu-system-sparc64: -drive file=/tmp/file.txt,if=virtio,index=0: unable

[Qemu-devel] [PATCH 4/4] qcow2: Fix leak of opts in qcow2_open

2014-08-26 Thread Fam Zheng
Not all the error paths release opts, fix it by moving it after the fail label. Signed-off-by: Fam Zheng --- block/qcow2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index f9e045f..b4c4a6e 100644 --- a/block/qcow2.c +++ b/block/qcow2.c

[Qemu-devel] [PATCH 3/4] quorum: Fix leak of opts in quorum_open

2014-08-26 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/quorum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 0de07bb..ffe8bd9 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -796,7 +796,7 @@ static int quorum_open(BlockDriverState *bs, QDict *option

[Qemu-devel] [PATCH 2/4] blkverify: Fix leak of opts in blkverify_open

2014-08-26 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/blkverify.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blkverify.c b/block/blkverify.c index 7c78ca4..163064c 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -158,6 +158,7 @@ static int blkverify_open(BlockDriverState *bs, QDict *option

[Qemu-devel] [PATCH 0/4] block: Fix leaks of opts in block drivers

2014-08-26 Thread Fam Zheng
Remember to call qemu_opts_del before function returning. Fam Zheng (4): nfs: Fix leak of opts in nfs_file_open blkverify: Fix leak of opts in blkverify_open quorum: Fix leak of opts in quorum_open qcow2: Fix leak of opts in qcow2_open block/blkverify.c | 1 + block/nfs.c | 7

[Qemu-devel] [PATCH 1/4] nfs: Fix leak of opts in nfs_file_open

2014-08-26 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/nfs.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 93d87f3..36e8057 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -393,15 +393,18 @@ static int nfs_file_open(BlockDriverState *bs, QDict *options, int

[Qemu-devel] [PATCH] MAINTAINERS: Add VMWare devices maintainer

2014-08-26 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 59940f9..1b3e2be 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -678,6 +678,12 @@ S: Maintained F: hw/*/xilinx_* F: include/hw/xilinx.h +Vmware +M: Dmitry Fl

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-08-26 Thread Chris Friesen
On 08/25/2014 03:50 PM, Chris Friesen wrote: I think I might have a glimmering of what's going on. Someone please correct me if I get something wrong. I think that VIRTIO_PCI_QUEUE_MAX doesn't really mean anything with respect to max inflight operations, and neither does virtio-blk calling vir

Re: [Qemu-devel] [PATCH v2] blkdebug: make the fault injection functionality callable from QMP

2014-08-26 Thread Hitoshi Mitake
At Tue, 26 Aug 2014 20:54:57 -0600, Eric Blake wrote: > > On 08/26/2014 07:59 PM, Hitoshi Mitake wrote: > > This patch makes the fault injection functionality of blkdebug > > callable from QMP. Motivation of this change is for testing and > > debugging distributed systems. Ordinal distributed syst

Re: [Qemu-devel] [PATCH V4] net: Forbid dealing with packets when VM is not running

2014-08-26 Thread Jason Wang
On 08/26/2014 04:06 PM, zhanghailiang wrote: > For all NICs(except virtio-net) emulated by qemu, > Such as e1000, rtl8139, pcnet and ne2k_pci, > Qemu can still receive packets when VM is not running. > > If this happened in *migration's* last PAUSE VM stage, but > before the end of the migration, t

Re: [Qemu-devel] [question] e1000 interrupt storm happened becauseof its correspondingioapic->irr bit always set

2014-08-26 Thread Jason Wang
On 08/26/2014 05:28 PM, Zhang Haoyu wrote: > Hi, all > > I use a qemu-1.4.1/qemu-2.0.0 to run win7 guest, and encounter e1000 NIC > interrupt storm, > because "if (!ent->fields.mask && (ioapic->irr & (1 << i)))" is always > true in __kvm_ioapic_update_eoi(). > > A

[Qemu-devel] [PATCH] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-08-26 Thread john.liuli
From: Li Liu Eeay to reproduce, just try "qemu -monitor stdio -nographic" and type "quit", then the terminal will be crashed. There are two pathes try to call tcgetattr of stdio in vl.c: 1) Monitor_parse(optarg, "readline"); . qemu_opts_foreach(qemu_find_opts("chardev"),

Re: [Qemu-devel] [PULL 3/3] vnc: fix screen updates

2014-08-26 Thread Zhang Haoyu
>Bug was added by 38ee14f4f33f8836fc0e209ca59c6ae8c6edf380. >vnc_jobs_join call is missing in one code path. > >Reported-by: Anthony PERARD >Signed-off-by: Gerd Hoffmann >--- > ui/vnc.c | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/ui/vnc.c b/ui/vnc.c >index 6c9d4f3..aac93f0 100644 >-

[Qemu-devel] pert stat in KVM guest can not get LLC-loads hardware cache event

2014-08-26 Thread Steven
Dear KVM developers: I am trying use perf stat inside a VM to obtain some hardware cache performance counter values. The perf stat can report some numbers for L1 and TLB related counters. But for the LLC-loads and LLC-load-misses, the numbers are always 0. It seems that the these offcore events are

Re: [Qemu-devel] [RFC PATCH V5 0/3] Support xen HVM direct kernel boot

2014-08-26 Thread Chun Yan Liu
>>> On 8/27/2014 at 05:02 AM, in message <1409086964.28009.45.ca...@citrix.com>, Ian Campbell wrote: > On Mon, 2014-08-04 at 18:26 +0100, Stefano Stabellini wrote: > > The patches are both in QEMU and qemu-upstream-unstable. > > You can go ahead with the tools patches. > > Done. There was

Re: [Qemu-devel] [PATCH v4 2/5] qtest: Add scripts/qtest/qtest.py

2014-08-26 Thread Fam Zheng
On Tue, 08/26 14:21, Stefan Hajnoczi wrote: > On Thu, Jun 05, 2014 at 04:47:43PM +0800, Fam Zheng wrote: > > diff --git a/scripts/qtest b/scripts/qtest > > deleted file mode 100755 > > index 4ef6c1c..000 > > --- a/scripts/qtest > > +++ /dev/null > > @@ -1,5 +0,0 @@ > > -#!/bin/sh > > - > > -exp

[Qemu-devel] [PATCH] scripts: Remove scripts/qtest

2014-08-26 Thread Fam Zheng
This is a dummy file with no user, drop it. Signed-off-by: Fam Zheng --- scripts/qtest | 5 - 1 file changed, 5 deletions(-) delete mode 100755 scripts/qtest diff --git a/scripts/qtest b/scripts/qtest deleted file mode 100755 index 4ef6c1c..000 --- a/scripts/qtest +++ /dev/null @@ -1,5

Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

2014-08-26 Thread Eric Blake
On 08/26/2014 08:38 PM, Fam Zheng wrote: > On Tue, 08/26 21:48, Richard W.M. Jones wrote: >> Some servers (notably VMware ESX) accept range requests, but don't >> send back the Accept-Ranges: bytes header in their initial response. >> >> For these servers you can set override_accept_ranges to 'on'

Re: [Qemu-devel] [PATCH v2] blkdebug: make the fault injection functionality callable from QMP

2014-08-26 Thread Eric Blake
On 08/26/2014 07:59 PM, Hitoshi Mitake wrote: > This patch makes the fault injection functionality of blkdebug > callable from QMP. Motivation of this change is for testing and > debugging distributed systems. Ordinal distributed systems must handle > hardware faults because of its reason for exist

[Qemu-devel] [PATCH v3 7/8] block: Implement bdrv_em_co_aiocb_info.cancel_async

2014-08-26 Thread Fam Zheng
Nothing to do here. Signed-off-by: Fam Zheng --- block.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block.c b/block.c index f4c77ec..ac1cfb4 100644 --- a/block.c +++ b/block.c @@ -4746,9 +4746,16 @@ static void bdrv_aio_co_cancel_em(BlockDriverAIOCB *blockacb) } } +stati

[Qemu-devel] [PATCH v3 4/8] linux-aio: Implement .cancel_async

2014-08-26 Thread Fam Zheng
Just call io_cancel (2), if it fails, it means the request is not canceled, so the event loop will eventually call qemu_laio_process_completion. In qemu_laio_process_completion, change to call the cb unconditionally. It is required by .cancel_async, and also acceptable by .cancel. Signed-off-by:

[Qemu-devel] [PATCH v3 6/8] dma: Implement .cancel_async

2014-08-26 Thread Fam Zheng
Just forward the request to bdrv_aio_cancel_async. Use a flag to fix the ret value in completion code. Also check memory address before calling dma_memory_unmap. Signed-off-by: Fam Zheng --- dma-helpers.c | 24 1 file changed, 24 insertions(+) diff --git a/dma-helpers.c

[Qemu-devel] [PATCH v3 2/8] block: Add bdrv_aio_cancel_async

2014-08-26 Thread Fam Zheng
This is the async version of bdrv_aio_cancel, which doesn't block the caller. It guarantees that the cb is called either before returning or some time later. Signed-off-by: Fam Zheng --- block.c | 26 ++ include/block/aio.h | 1 + include/block/block.h |

[Qemu-devel] [PATCH v3 5/8] thread-pool: Implement .cancel_async

2014-08-26 Thread Fam Zheng
The .cancel_async reuses the first half of .cancel: try to steal the request if not submitted yet. In this case set the elem to a special status THREAD_CANCELED_ASYNC, which means thread_pool_completion_bh should call the cb with -ECANCELED. If the request is already submitted, do nothing, as we k

[Qemu-devel] [PATCH v3 8/8] iscsi: Implement .cancel_async in acb info

2014-08-26 Thread Fam Zheng
Factor out the cancellation submission part in iscsi_aio_cancel, which is all what is needed for .cancel_async. The cb passed to iscsi_task_mgmt_abort_task_async, iscsi_abort_task_cb, will be called later, so for iscsi_bh_cb. In iscsi_bh_cb, acb->canceled is not set if canceled by .cancel_async, s

[Qemu-devel] [PATCH v3 0/8] block: Asynchronous request cancellation

2014-08-26 Thread Fam Zheng
v3: Drop "RFC". Improvements according to Paolo's comments: 05: Just use THREAD_DONE and ret = -ECANCELED in thread-pool.c 06: Don't check dbs->cancelled for twice. Don't set dbs->acb to NULL. v2: Drop the unfinished scsi part, which was broken in v1. (Paolo) Add refcnt in

[Qemu-devel] [PATCH v3 3/8] tests: Add testing code for bdrv_aio_cancel_async

2014-08-26 Thread Fam Zheng
Before, done_cb is only called if the request is submitted by thread pool. Now in the async test, done_cb is always called. So update the test criteria accordingly. Signed-off-by: Fam Zheng --- tests/test-thread-pool.c | 39 +++ 1 file changed, 31 insertions(+

[Qemu-devel] [PATCH v3 1/8] block: Add refcnt in BlockDriverAIOCB

2014-08-26 Thread Fam Zheng
This will be useful in situations like asynchronous cancel emulation. Signed-off-by: Fam Zheng --- block.c | 12 +++- include/block/aio.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index e9380f6..f8e342f 100644 --- a/block.c +++

Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

2014-08-26 Thread Fam Zheng
On Tue, 08/26 21:48, Richard W.M. Jones wrote: > Some servers (notably VMware ESX) accept range requests, but don't > send back the Accept-Ranges: bytes header in their initial response. > > For these servers you can set override_accept_ranges to 'on' which > forces this block driver to send range

Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting

2014-08-26 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, August 26, 2014 7:25 PM > Subject: Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take > effect after rebooting > > Gerd Hoffmann writes: > > > On Di, 2014-08-26 at 09:07 +, Gonglei (Arei) wrote: > >> Hi,

[Qemu-devel] [PATCH v2] blkdebug: make the fault injection functionality callable from QMP

2014-08-26 Thread Hitoshi Mitake
This patch makes the fault injection functionality of blkdebug callable from QMP. Motivation of this change is for testing and debugging distributed systems. Ordinal distributed systems must handle hardware faults because of its reason for existence, but testing whether the systems can hanle such f

[Qemu-devel] [PATCH v12 12/14] iotests: Add _filter_qemu_img_map

2014-08-26 Thread Max Reitz
As different image formats most probably map guest addresses to different host addresses, add a filter to filter the host addresses out; also, the image filename should be filtered. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/common.filter | 7 +++ 1 file changed

[Qemu-devel] [PATCH v12 13/14] iotests: Add test for backing-chain commits

2014-08-26 Thread Max Reitz
Add a test for qemu-img commit on backing chains with more than two images. This test also checks whether the top image is emptied (unless this is prevented by specifying either -d or -b) and does therefore not work for qed and vmdk which requires it to be separate from 020. Signed-off-by: Max Rei

[Qemu-devel] [PATCH v12 10/14] qemu-img: Enable progress output for commit

2014-08-26 Thread Max Reitz
Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 24 ++-- qemu-img.texi| 2 +- 3 files changed, 25 insertions(+), 5 deletions(-

[Qemu-devel] [PATCH v12 09/14] qemu-img: Empty image after commit

2014-08-26 Thread Max Reitz
After the top image has been committed, it should be emptied unless specified otherwise. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 34 +++--- qemu-img.texi| 6 +- 3 files changed, 38 insertions(+), 6

[Qemu-devel] [PATCH v12 11/14] qemu-img: Specify backing file for commit

2014-08-26 Thread Max Reitz
Introduce a new parameter for qemu-img commit which may be used to explicitly specify the backing file into which an image should be committed if the backing chain has more than a single layer. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 2

[Qemu-devel] [PATCH v12 06/14] iotests: Omit length/offset test in 040 and 041

2014-08-26 Thread Max Reitz
As of a follow-up patch to this one, the length of a mirror block job will no longer directly depend on the size of the block device; therefore, drop these checks from this test. Instead, just check whether the final offset equals the block job length. As 041 uses the wait_until_completed function

[Qemu-devel] [PATCH v12 08/14] qemu-img: Implement commit like QMP

2014-08-26 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. As qemu-img itself has no access to QMP (since this would basically require just everything being linked into qemu-img), imitate QMP's implementation of block-comm

[Qemu-devel] [PATCH v12 14/14] iotests: Add test for qcow2's bdrv_make_empty

2014-08-26 Thread Max Reitz
Add a test for qcow2's fast bdrv_make_empty implementation on images without internal snapshots. Signed-off-by: Max Reitz --- tests/qemu-iotests/098 | 78 ++ tests/qemu-iotests/098.out | 45 ++ tests/qemu-iotests/group |

[Qemu-devel] [PATCH v12 05/14] blockjob: Add "ready" field

2014-08-26 Thread Max Reitz
When a block job signals readiness, this is currently reported only through QMP. If qemu wants to use block jobs for internal tasks, there needs to be another way to correctly detect when a block job may be completed. For this reason, introduce a bool "ready" which is set when the block job may be

[Qemu-devel] [PATCH v12 01/14] qcow2: Allow "full" discard

2014-08-26 Thread Max Reitz
Normally, discarded sectors should read back as zero. However, there are cases in which a sector (or rather cluster) should be discarded as if they were never written in the first place, that is, reading them should fall through to the backing file again. Signed-off-by: Max Reitz Reviewed-by: Eri

[Qemu-devel] [PATCH v12 04/14] blockjob: Introduce block_job_complete_sync()

2014-08-26 Thread Max Reitz
Implement block_job_complete_sync() by doing the exact same thing as block_job_cancel_sync() does, only with calling block_job_complete() instead of block_job_cancel(). Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- blockjob.c | 39 --- in

[Qemu-devel] [PATCH v12 07/14] block/mirror: Improve progress report

2014-08-26 Thread Max Reitz
Instead of taking the total length of the block device as the block job's length, use the number of dirty sectors. The progress is now the number of sectors mirrored to the target block device. Note that this may result in the job's length increasing during operation, which is however in fact desir

[Qemu-devel] [PATCH v12 00/14] qemu-img: Implement commit like QMP

2014-08-26 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. For the "commit" command, this is relatively easy, so implement it first (in the hope that indeed others will follow). As qemu-img does not have access to QMP (du

[Qemu-devel] [PATCH v12 03/14] qcow2: Optimize bdrv_make_empty()

2014-08-26 Thread Max Reitz
bdrv_make_empty() is currently only called if the current image represents an external snapshot that has been committed to its base image; it is therefore unlikely to have internal snapshots. In this case, bdrv_make_empty() can be greatly sped up by emptying the L1 and refcount table (while having

[Qemu-devel] [PATCH v12 02/14] qcow2: Implement bdrv_make_empty()

2014-08-26 Thread Max Reitz
Implement this function by making all clusters in the image file fall through to the backing file (by using the recently extended discard). Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- block/qcow2.c | 27 +++ 1 file changed, 27 insertions

Re: [Qemu-devel] [RFC PATCH V5 0/3] Support xen HVM direct kernel boot

2014-08-26 Thread Ian Campbell
On Mon, 2014-08-04 at 18:26 +0100, Stefano Stabellini wrote: > The patches are both in QEMU and qemu-upstream-unstable. > You can go ahead with the tools patches. Done. There was some fuzz on the first patch (no doubt due to the delay in apply, sorry) which I resolved, Chunyan please do check I di

Re: [Qemu-devel] [PATCH 0/3] qemu-img: error path fixes

2014-08-26 Thread John Snow
On 08/26/2014 02:17 PM, Stefan Hajnoczi wrote: I noticed a few minor issues when looking at cache flag parsing. This series cleans them up. Stefan Hajnoczi (3): qemu-img: fix img_commit() error return value qemu-img: fix img_compare() flags error path qemu-img: always goto out in img

[Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

2014-08-26 Thread Richard W.M. Jones
Some servers (notably VMware ESX) accept range requests, but don't send back the Accept-Ranges: bytes header in their initial response. For these servers you can set override_accept_ranges to 'on' which forces this block driver to send range requests anyway. Signed-off-by: Richard W.M. Jones ---

[Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range

2014-08-26 Thread Richard W.M. Jones
If you use this patch + Daniel Henrique Barboza's patch that adds a timeout, then you can access guest files on VMware ESX servers. Rich.

Re: [Qemu-devel] [PATCH v3] block.curl: adding 'timeout' option

2014-08-26 Thread Richard W.M. Jones
On Wed, Aug 13, 2014 at 12:44:27PM -0300, Daniel Henrique Barboza wrote: > The curl hardcoded timeout (5 seconds) sometimes is not long > enough depending on the remote server configuration and network > traffic. The user should be able to set how much long he is > willing to wait for the connectio

[Qemu-devel] [PATCH] curl: The macro that you have to uncomment to get debugging is DEBUG_CURL.

2014-08-26 Thread Richard W.M. Jones
Signed-off-by: Richard W.M. Jones --- block/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index 2698ae3..46f1082 100644 --- a/block/curl.c +++ b/block/curl.c @@ -26,7 +26,7 @@ #include "qapi/qmp/qbool.h" #include -// #define DEBUG +//

[Qemu-devel] [Bug 1361618] Re: sparc cg3 1152x900 display abnormal

2014-08-26 Thread Mark Cave-Ayland
Due to the OpenBIOS ROM being larger than OBP, it is currently unable to allocate enough memory for the larger 1152x900 framebuffer (and sadly it's not a simple fix to shrink down the memory requirements). Fortunately if you are using the real Sun ROM ss5.bin then you can just use a real Sun cgthr

Re: [Qemu-devel] [RFC PATCH 2/2] VFIO: Clear stale MSIx table during EEH reset

2014-08-26 Thread Alex Williamson
On Wed, 2014-08-20 at 19:52 +1000, Gavin Shan wrote: > The PCI device MSIx table is cleaned out in hardware after EEH PE > reset. However, we still hold the stale MSIx entries in QEMU, which > should be cleared accordingly. Otherwise, we will run into another > (recursive) EEH error and the PCI dev

Re: [Qemu-devel] [PATCH 1/3] qemu-img: fix img_commit() error return value

2014-08-26 Thread John Snow
On 08/26/2014 03:31 PM, Eric Blake wrote: On 08/26/2014 12:17 PM, Stefan Hajnoczi wrote: The img_commit() return value is a process exit code. Use 1 for failure instead of -1. The other failure paths in this function already use 1. Signed-off-by: Stefan Hajnoczi --- qemu-img.c | 2 +- 1

Re: [Qemu-devel] [PATCH 2/5] target-ppc: Register and handle HCALL to receive updated RTAS region

2014-08-26 Thread Benjamin Herrenschmidt
On Tue, 2014-08-26 at 17:24 +1000, David Gibson wrote: > > Beware that SLOF needs to call RTAS for its own reasons... > > > > So it would be instanciated twice. > > I don't see that that would cause a big problem, or am I missing > something? Well, not necessarily, just pointing out that SLOF wi

Re: [Qemu-devel] [RFC PATCH 1/2] VFIO: Drop vfio_container_do_ioctl()

2014-08-26 Thread Alex Williamson
On Tue, 2014-08-26 at 20:27 +1000, Alexey Kardashevskiy wrote: > On 08/20/2014 07:52 PM, Gavin Shan wrote: > > The patch drops vfio_container_do_ioctl() and merges its logic to > > parent function call vfio_container_ioctl() so that the subsequent > > patches can reused the found VFIO group in vfio

Re: [Qemu-devel] [PATCH v6 00/15] TriCore architecture guest implementation

2014-08-26 Thread Richard Henderson
On 08/22/2014 09:52 AM, Bastian Koppelmann wrote: > Hi, > > my aim is to add Infineon's TriCore architecture to QEMU. This series of > patches adds the target stubs, a basic testboard and a softmmu for system > mode emulation. Furthermore it adds all the 16 bit long instructions of the > archit

Re: [Qemu-devel] [PATCH 1/3] qemu-img: fix img_commit() error return value

2014-08-26 Thread Eric Blake
On 08/26/2014 12:17 PM, Stefan Hajnoczi wrote: > The img_commit() return value is a process exit code. Use 1 for failure > instead of -1. The other failure paths in this function already use 1. > > Signed-off-by: Stefan Hajnoczi > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions

2014-08-26 Thread Michael Roth
Quoting Alexey Kardashevskiy (2014-08-26 04:14:27) > On 08/19/2014 10:21 AM, Michael Roth wrote: > > Some kernels program a 0 address for io regions. PCI 3.0 spec > > section 6.2.5.1 doesn't seem to disallow this. > > > I remember there was discussion about it but I forgot :) Why does it have > t

Re: [Qemu-devel] [PATCH 3/3] qemu-img: always goto out in img_snapshot() error paths

2014-08-26 Thread Max Reitz
On 26.08.2014 20:17, Stefan Hajnoczi wrote: The out label has the qemu_progress_end() and other cleanup calls. Always goto out in error paths so the cleanup happens. Note that bdrv_unref(NULL) is safe. We just need to initialize bs to NULL at the top of the function. We can now remove the obso

Re: [Qemu-devel] [PATCH 2/3] qemu-img: fix img_compare() flags error path

2014-08-26 Thread Max Reitz
On 26.08.2014 20:17, Stefan Hajnoczi wrote: If img_compare() fails to parse the cache flags the goto out3 code path will call qemu_progress_end(). Make sure we actually call qemu_progress_init() first. Reported-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- qemu-img.c | 6 +++---

Re: [Qemu-devel] [PATCH 02/12] spapr_pci: populate DRC dt entries for PHBs

2014-08-26 Thread Michael Roth
Quoting Alexander Graf (2014-08-26 06:29:42) > On 19.08.14 02:21, Michael Roth wrote: > > Reserve 32 entries of type PCI in each PHB's initial FDT. This > > advertises to guests that each PHB is DR-capable device with > > physical hotpluggable slots. This is necessary for allowing > > hotplugging o

Re: [Qemu-devel] [PATCH 1/3] qemu-img: fix img_commit() error return value

2014-08-26 Thread Max Reitz
On 26.08.2014 20:17, Stefan Hajnoczi wrote: The img_commit() return value is a process exit code. Use 1 for failure instead of -1. The other failure paths in this function already use 1. Signed-off-by: Stefan Hajnoczi --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) R

[Qemu-devel] [PATCH 2/3] qemu-img: fix img_compare() flags error path

2014-08-26 Thread Stefan Hajnoczi
If img_compare() fails to parse the cache flags the goto out3 code path will call qemu_progress_end(). Make sure we actually call qemu_progress_init() first. Reported-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- qemu-img.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 3/3] qemu-img: always goto out in img_snapshot() error paths

2014-08-26 Thread Stefan Hajnoczi
The out label has the qemu_progress_end() and other cleanup calls. Always goto out in error paths so the cleanup happens. Note that bdrv_unref(NULL) is safe. We just need to initialize bs to NULL at the top of the function. We can now remove the obsolete bs_old_backing = NULL and bs_new_backing

[Qemu-devel] [PATCH 0/3] qemu-img: error path fixes

2014-08-26 Thread Stefan Hajnoczi
I noticed a few minor issues when looking at cache flag parsing. This series cleans them up. Stefan Hajnoczi (3): qemu-img: fix img_commit() error return value qemu-img: fix img_compare() flags error path qemu-img: always goto out in img_snapshot() error paths qemu-img.c | 23 ++--

[Qemu-devel] [PATCH 1/3] qemu-img: fix img_commit() error return value

2014-08-26 Thread Stefan Hajnoczi
The img_commit() return value is a process exit code. Use 1 for failure instead of -1. The other failure paths in this function already use 1. Signed-off-by: Stefan Hajnoczi --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index c843420

Re: [Qemu-devel] [PATCH v3 05/10] qcow2: Fix refcount blocks beyond image end

2014-08-26 Thread Max Reitz
On 26.08.2014 15:07, Eric Blake wrote: On 08/22/2014 10:31 AM, Max Reitz wrote: If the qcow2 check function detects a refcount block located beyond the image end, grow the image appropriately. This cannot break anything and is the logical fix for such a case. Does the testsuite cover this one?

Re: [Qemu-devel] [PATCH v3 09/10] iotests: Fix test outputs

2014-08-26 Thread Max Reitz
On 26.08.2014 15:09, Eric Blake wrote: On 08/22/2014 10:31 AM, Max Reitz wrote: 039, 060 and 061 all create images with referenced clusters having a refcount of 0. Because previous commits changed handling of such errors, these tests now have a different output. Fix it. Furthermore, 060 created

Re: [Qemu-devel] [PATCH v2 0/6] target-i386: Make most CPU models work with "enforce" out of the box

2014-08-26 Thread Eduardo Habkost
On Tue, Aug 26, 2014 at 02:56:21PM +0200, Paolo Bonzini wrote: > Il 25/08/2014 22:45, Eduardo Habkost ha scritto: > > > > TCG users expect the default CPU model to contain most TCG-supported > > features > > (and it makes sense). See, for example, commit > > f1e00a9cf326acc1f2386a72525af8859852e1

Re: [Qemu-devel] [PATCH v3 10/10] iotests: Add test for potentially damaging repairs

2014-08-26 Thread Max Reitz
On 22.08.2014 21:55, Eric Blake wrote: On 08/22/2014 10:31 AM, Max Reitz wrote: There are certain cases where repairing a qcow2 image might actually damage it further (or rather, where repairing it has in fact damaged it further with the old qcow2 check implementation). This should not happen, s

Re: [Qemu-devel] [PATCH 02/12] spapr_pci: populate DRC dt entries for PHBs

2014-08-26 Thread Michael Roth
Quoting Alexey Kardashevskiy (2014-08-26 04:09:36) > On 08/19/2014 10:21 AM, Michael Roth wrote: > > Reserve 32 entries of type PCI in each PHB's initial FDT. This > > advertises to guests that each PHB is DR-capable device with > > physical hotpluggable slots. This is necessary for allowing > > ho

Re: [Qemu-devel] [PATCH 02/12] spapr_pci: populate DRC dt entries for PHBs

2014-08-26 Thread Michael Roth
Quoting Alexey Kardashevskiy (2014-08-26 03:32:58) > On 08/19/2014 10:21 AM, Michael Roth wrote: > > Reserve 32 entries of type PCI in each PHB's initial FDT. This > > advertises to guests that each PHB is DR-capable device with > > physical hotpluggable slots. This is necessary for allowing > > ho

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-08-26 Thread Alexander Graf
On 26.08.14 18:47, Michael Roth wrote: > Quoting Alexander Graf (2014-08-26 06:11:24) >> On 19.08.14 02:21, Michael Roth wrote: >>> From: Nathan Fontenot >>> >>> This add entries to the root OF node to advertise our PHBs as being >>> DR-capable in according with PAPR specification. >>> >>> Each

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-08-26 Thread Michael Roth
Quoting Alexander Graf (2014-08-26 06:11:24) > On 19.08.14 02:21, Michael Roth wrote: > > From: Nathan Fontenot > > > > This add entries to the root OF node to advertise our PHBs as being > > DR-capable in according with PAPR specification. > > > > Each PHB is given a name of PHB, advertised as

[Qemu-devel] [PATCH] spapr_pci: turn IOMMU root into an I/O region

2014-08-26 Thread Greg Kurz
On sPAPR, virtio devices are connected to the PCI bus and use MSI-X. Commit cc943c36faa192cd4b32af8fe5edb31894017d35 has modified MSI-X so that writes are made using the bus master address space. Unfortunately, the MSI-X notification hits unassigned_mem_write and never reaches the guest... The most

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-08-26 Thread Michael Roth
Quoting Michael Roth (2014-08-26 10:25:13) > Quoting Alexey Kardashevskiy (2014-08-26 03:24:08) > > On 08/26/2014 05:55 PM, Alexey Kardashevskiy wrote: > > > On 08/19/2014 10:21 AM, Michael Roth wrote: > > >> From: Nathan Fontenot > > >> > > >> This add entries to the root OF node to advertise our

[Qemu-devel] [PATCH] hw/arm/boot: load device tree to base of DRAM if no -kernel option was passed

2014-08-26 Thread Ard Biesheuvel
If we are running the 'virt' machine, we may have a device tree blob but no kernel to supply it to if no -kernel option was passed. In that case, copy it to the base of DRAM where it can be picked up by a bootloader executing from NOR flash. Signed-off-by: Ard Biesheuvel --- hw/arm/boot.c | 8 ++

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-08-26 Thread Michael Roth
Quoting Alexey Kardashevskiy (2014-08-26 03:24:08) > On 08/26/2014 05:55 PM, Alexey Kardashevskiy wrote: > > On 08/19/2014 10:21 AM, Michael Roth wrote: > >> From: Nathan Fontenot > >> > >> This add entries to the root OF node to advertise our PHBs as being > >> DR-capable in according with PAPR s

Re: [Qemu-devel] [PATCH] block: Always compile virtio-blk dataplane

2014-08-26 Thread Benoît Canet
The Tuesday 26 Aug 2014 à 14:57:19 (+0800), Fam Zheng wrote : > Dataplane doesn't depend on linux-aio any more, so we don't need the > compiling condition now. > > Configure options are kept but just print a message. > > Signed-off-by: Fam Zheng > --- > configure | 21 ++---

Re: [Qemu-devel] [PATCH] coroutine: Drop co_sleep_ns

2014-08-26 Thread Benoît Canet
The Tuesday 26 Aug 2014 à 15:15:43 (+0800), Fam Zheng wrote : > block_job_sleep_ns is the only user. Since we are moving towards > AioContext aware code, it's better to use the explict version and drop s/explict/explicit/g ?G > the old one. > > Signed-off-by: Fam Zheng > --- > blockjob.c

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-08-26 Thread Michael Roth
Quoting Alexey Kardashevskiy (2014-08-26 02:55:05) > On 08/19/2014 10:21 AM, Michael Roth wrote: > > From: Nathan Fontenot > > > > This add entries to the root OF node to advertise our PHBs as being > > DR-capable in according with PAPR specification. > > > > Each PHB is given a name of PHB, adv

Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-26 Thread Knut Omang
On Mon, 2014-08-25 at 11:23 +, Gonglei (Arei) wrote: > > -Original Message- > > From: Knut Omang [mailto:knut.om...@oracle.com] > > Sent: Monday, August 25, 2014 7:02 PM > > Subject: Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports > > and > > downstream ports > > >

Re: [Qemu-devel] [PATCH v4 06/33] target-arm: make arm_current_pl() return PL3

2014-08-26 Thread Peter Maydell
On 1 July 2014 00:09, wrote: > From: Fabian Aggeler > > Make arm_current_pl() return PL3 for secure PL1 and monitor mode. > Increase MMU modes since mmu_index is directly infered from arm_ > current_pl(). Changes assertion in arm_el_is_aa64() to allow EL3. > @@ -963,9 +963,12 @@ static inline i

Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-26 Thread Andrey Korolyov
On Tue, Aug 26, 2014 at 1:32 PM, tangchen wrote: > Hi , > > Would anybody help to review this patch ? > > Thanks. :) > > > On 08/19/2014 09:55 AM, Tang Chen wrote: >> >> If user doesn't specify numa options, nb_numa_nodes will be 0. But >> PCDIMMDevice->node >> is also initialized to 0. As a resul

Re: [Qemu-devel] [12/16] linux-user: support {name_to, open_by}_handle_at syscalls

2014-08-26 Thread Paul Burton
On Tue, Aug 26, 2014 at 03:30:41PM +0300, Riku Voipio wrote: > Hi Paul, > > On Sun, Jun 15, 2014 at 05:18:29PM +0100, Paul Burton wrote: > > Implement support for the name_to_handle_at and open_by_handle_at > > syscalls, allowing their use by the target program. > > What was your testcase for th

Re: [Qemu-devel] [PATCH v1 1/5] Netduino_USART: Add the Netduino Plus 2 USART Controller

2014-08-26 Thread Alistair Francis
On Sun, Aug 24, 2014 at 12:09 PM, Peter Crosthwaite wrote: > On Sun, Aug 24, 2014 at 10:13 AM, Alistair Francis > wrote: >> This patch adds the Netduino Plus 2 USART controller >> (UART also uses the same controller). >> >> It can be used for reading and writing to the guest. >> > > Do you just

Re: [Qemu-devel] [PATCH v4 5/5] qemu-iotests: Add 093 for IO throttling

2014-08-26 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 04:47:46PM +0800, Fam Zheng wrote: > +def setUp(self): > +qemu_img('create', '-f', iotests.imgfmt, test_img, "1G") > +#self.vm = iotests.VM().add_drive(test_img, "bps=1024,bps_max=1") Commented out lines should be dropped > +self.vm = iotests.VM

[Qemu-devel] [Bug 1361618] [NEW] sparc cg3 1152x900 display abnormal

2014-08-26 Thread szxray
Public bug reported: when I use -vga cg3 -g 1152x900 with qemu-system-sparc, the display is abnormal I had try qemu-2.1.0 on win2003 with openBIOS or OBP qemu-system-sparc.exe -vga cg3 -g 1152x900 or qemu-system-sparc.exe -vga cg3 -g 1152x900 -bios ss5.bin I also try qemu-2.0.2 on debian

Re: [Qemu-devel] [PATCH v4 2/5] qtest: Add scripts/qtest/qtest.py

2014-08-26 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 04:47:43PM +0800, Fam Zheng wrote: > diff --git a/scripts/qtest b/scripts/qtest > deleted file mode 100755 > index 4ef6c1c..000 > --- a/scripts/qtest > +++ /dev/null > @@ -1,5 +0,0 @@ > -#!/bin/sh > - > -export QTEST_QEMU_BINARY=$1 > -shift > -"$@" Why delete this? The

Re: [Qemu-devel] [PATCH v1 5/6] qom/cpu: Add Memory Region Property

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 02:59, Peter Crosthwaite ha scritto: > Which is used to construct a per-CPU address space. The Address space > will be created at realize time. > > Signed-off-by: Peter Crosthwaite > --- > > include/qom/cpu.h | 1 + > qom/cpu.c | 11 +++ > 2 files changed, 12 inse

[Qemu-devel] [PULL] Update OpenBIOS images to r1316

2014-08-26 Thread Mark Cave-Ayland
Hi Peter, The following commit updates the OpenBIOS images to SVN r1316 (primarily at the request of Alex who has some dependent PPC patches queued). Please pull. ATB, Mark. The following changes since commit c47c61be8dcd91689c8fc6db924d684c3b39: Merge remote-tracking branch 'remotes

Re: [Qemu-devel] [PATCH target-arm v4 2/7] arm: Implement PMCCNTR 32b read-modify-write

2014-08-26 Thread Alistair Francis
On Tue, Aug 26, 2014 at 2:10 PM, Peter Crosthwaite wrote: > The register is now 64bit, however a 32 bit write to the register > should leave the higher bits unchanged. The open coded write handler > does not implement this, so we need to read-modify-write accordingly. > > Signed-off-by: Peter Cros

  1   2   3   >