Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-21 Thread Gonglei (Arei)
> From: Marcel Apfelbaum [mailto:marce...@redhat.com] > Sent: Friday, August 22, 2014 2:34 PM > Subject: Re: [PATCH v2 2/2] pci: add check for pcie root ports and downstream > ports > > On Thu, 2014-08-21 at 17:47 +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > If ARI Forwarding i

Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-21 Thread Marcel Apfelbaum
On Thu, 2014-08-21 at 17:47 +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > If ARI Forwarding is disabled, according to PCIe spec > section 7.3.1, only slot 0 with the device attached to > logic bus representing the link from downstream > ports and root ports. > > So, adding check for

Re: [Qemu-devel] What tests should "make check-block" run?

2014-08-21 Thread Fam Zheng
On Thu, 08/21 23:00, Peter Crosthwaite wrote: > On Thu, Aug 21, 2014 at 10:52 PM, Paolo Bonzini wrote: > > Il 21/08/2014 14:27, Markus Armbruster ha scritto: > >> Current "make check-block" runs tests/qemu-iotests-quick.sh, which tests > >> format qcow2, protocol file, group quick with cache=none.

Re: [Qemu-devel] [RFC PATCH 9/9] scsi: Cancel request asynchronously

2014-08-21 Thread Fam Zheng
On Thu, 08/21 14:19, Paolo Bonzini wrote: > Il 21/08/2014 13:56, Fam Zheng ha scritto: > > We are blocking the whole VM, which means that an irresponsive storage > > backend will hang the whole guest. Let's switch to bdrv_aio_cancel_async > > to improve this. > > Unforuntately, the TMF must only r

Re: [Qemu-devel] [RFC PATCH 4/9] linux-aio: Implement .cancel_async

2014-08-21 Thread Fam Zheng
On Thu, 08/21 17:31, Stefan Hajnoczi wrote: > On Thu, Aug 21, 2014 at 07:56:51PM +0800, Fam Zheng wrote: > > @@ -110,6 +109,22 @@ static void qemu_laio_completion_cb(EventNotifier *e) > > } > > } > > > > +static void laio_cancel_async(BlockDriverAIOCB *blockacb) > > +{ > > +struct qemu_

[Qemu-devel] [PATCH] blkdebug: Delete BH in bdrv_aio_cancel

2014-08-21 Thread Fam Zheng
Otherwise error_callback_bh will access the already released acb. Signed-off-by: Fam Zheng --- block/blkdebug.c | 4 1 file changed, 4 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index 1586ed9..dac7666 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -449,6 +449,1

Re: [Qemu-devel] [RFC PATCH 6/9] blkdebug: Implement .cancel_async

2014-08-21 Thread Fam Zheng
On Thu, 08/21 17:52, Stefan Hajnoczi wrote: > On Thu, Aug 21, 2014 at 07:56:53PM +0800, Fam Zheng wrote: > > @@ -446,12 +439,25 @@ static void error_callback_bh(void *opaque) > > qemu_aio_release(acb); > > } > > > > +static void blkdebug_aio_cancel_async(BlockDriverAIOCB *blockacb) > > +{ >

Re: [Qemu-devel] [RFC PATCH 8/9] block: Implement stub bdrv_em_co_aiocb_info.cancel_async

2014-08-21 Thread Fam Zheng
On Thu, 08/21 18:01, Stefan Hajnoczi wrote: > On Thu, Aug 21, 2014 at 07:56:55PM +0800, Fam Zheng wrote: > > diff --git a/block.c b/block.c > > index 1cc8926..1860e4b 100644 > > --- a/block.c > > +++ b/block.c > > @@ -4750,9 +4750,14 @@ static void bdrv_aio_co_cancel_em(BlockDriverAIOCB > > *block

Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

2014-08-21 Thread Amit Shah
On (Thu) 21 Aug 2014 [23:57:46], Peter Lieven wrote: > > Am 11.07.2014 um 14:52 schrieb Amit Shah : > > > On (Wed) 09 Jul 2014 [12:00:13], Peter Maydell wrote: > >> On 9 July 2014 11:56, Amit Shah wrote: > >>> On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote: > OK; we're treating those

[Qemu-devel] [PATCH trivial] Fix debug print warning

2014-08-21 Thread arei.gonglei
From: Gonglei Steps: 1.enable qemu debug print, using simply scprit as below: grep "//#define DEBUG" * -rl | xargs sed -i "s/\/\/#define DEBUG/#define DEBUG/g" 2. make -j 3. get some warning: hw/i2c/pm_smbus.c: In function 'smb_ioport_writeb': hw/i2c/pm_smbus.c:142: warning: format '%04x' expe

Re: [Qemu-devel] QEMU dies on any attempt to load a Linux kernel module when using a 9P rootfs

2014-08-21 Thread Richard Yao
I use it all the time, but I have not updated to a more recent kernel yet. I am at LinuxCon, so I am unlikely to try it until I get home. > On Aug 21, 2014, at 2:50 PM, Christopher Covington > wrote: > > Hi Richard, > >> On 11/25/2013 10:49 AM, Richard Yao wrote: >> I booted a Gentoo Linux in

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-21 Thread Jason Wang
On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote: > On 2014/8/21 12:29, Jason Wang wrote: >> > On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote: >>> >> On 2014/8/19 12:56, Jason Wang wrote: >>> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue >>> >> call it before setting >>> Zhan

[Qemu-devel] [question] one vhost kthread servers mulitiple tx/rx queues which blong to one virtio-net device

2014-08-21 Thread Zhang Haoyu
Hi, Krishna, Shirley How got get the latest patch of M:N Implementation of mulitiqueue, I am going to test the the combination of "M:N Implementation of mulitiqueue" and "vhost: add polling mode". Thanks, Zhang Haoyu

[Qemu-devel] [PATCH v2] scsi-generic: remove superfluous DPRINTF avoid to break compiling

2014-08-21 Thread arei.gonglei
From: Gonglei variables lun and tag had been eliminated, break compiling when enable debug switch. Meanwhile traces provide the same information with this DPRINTF, so remove it. Signed-off-by: Gonglei --- v2: - as Paolo's suggestion, remove the superfluous DPRINTF. - change patch topic and c

Re: [Qemu-devel] [PATCH v2 1/2] qdev: Introduce a function to get qbus's parent

2014-08-21 Thread Gonglei (Arei)
> From: Hu Tao [mailto:hu...@cn.fujitsu.com] > On Thu, Aug 21, 2014 at 05:47:45PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > We need to use qbus's parent and get its name. > > > > Signed-off-by: Gonglei > > --- > > hw/core/qdev.c | 7 +++ > > include/hw/qdev-core

[Qemu-devel] [PATCH] spapr-vlan: Don't touch last entry in buffer list

2014-08-21 Thread Anton Blanchard
The last 8 bytes of the buffer list is defined to contain the number of dropped frames. At the moment we use it to store rx entries, which trips up ethtool -S: rx_no_buffer: 9223380832981355136 Fix this by skipping the last buffer list entry. Signed-off-by: Anton Blanchard --- diff --git a/hw/

[Qemu-devel] [Bug 1359243] Re: [BSOD 0xc000000d] Can't boot windows with qemu

2014-08-21 Thread Flavio Elawi
forgot to add other specs: Ubuntu 14.04 kernel 3.13.0-34-generic qemu: 2.1.1 (from ppa:jacob/virtualisation) qemu-kvm: 2.1.1 (from ppa:jacob/virtualisation) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/

[Qemu-devel] [Bug 1359243] Re: [BSOD 0xc000000d] Can't boot windows with qemu

2014-08-21 Thread Flavio Elawi
i am having the same problem Intel(R) Core(TM) i5-3470 CPU @ 3.20GHz -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1359243 Title: [BSOD 0xc00d] Can't boot windows with qemu Status in QEMU: N

Re: [Qemu-devel] [RFC PATCH 1/9] block: Add bdrv_aio_cancel_async

2014-08-21 Thread Fam Zheng
On Thu, 08/21 14:14, Paolo Bonzini wrote: > Il 21/08/2014 13:56, Fam Zheng ha scritto: > > +BlockDriverAIOCB *save = g_new(BlockDriverAIOCB, 1); > > +save->cb = acb->cb; > > +save->opaque = acb->opaque; > > +acb->cb= bdrv_aio_c

Re: [Qemu-devel] [PATCH v2 1/2] qdev: Introduce a function to get qbus's parent

2014-08-21 Thread Hu Tao
On Thu, Aug 21, 2014 at 05:47:45PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > We need to use qbus's parent and get its name. > > Signed-off-by: Gonglei > --- > hw/core/qdev.c | 7 +++ > include/hw/qdev-core.h | 1 + > 2 files changed, 8 insertions(+) > > diff --git

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-21 Thread Chen, Tiejun
On 2014/8/22 0:16, Konrad Rzeszutek Wilk wrote: On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: Currenjly this ISA bridge should be fixed at 1f.0, and pass the Currently Fixed. real vendor/device ids as the driver expect. Could you add a bit more description to this patch

Re: [Qemu-devel] [PATCH v2] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted

2014-08-21 Thread Fam Zheng
On Thu, 08/21 14:36, Markus Armbruster wrote: > Instead of bdrv_getlength(). > > Commit 57322b7 did this all over block, but one more bdrv_getlength() > has crept in since. > > Signed-off-by: Markus Armbruster > --- > v2: Actually use bdrv_nb_sectors() as advertized [Fam] > Passes ./check -T -vm

[Qemu-devel] [PATCH V5] spapr: Fix stale HTAB during live migration

2014-08-21 Thread Samuel Mendoza-Jonas
If a guest reboots during a running migration, changes to the hash page table are not necessarily updated on the destination. Opening a new file descriptor to the HTAB forces the migration handler to resend the entire table. Signed-off-by: Samuel Mendoza-Jonas --- Changes in v5: Use mutex on when

[Qemu-devel] issue: linking 64bit glib when building for cpu=i386

2014-08-21 Thread John Snow
I was running a series of tests on 32 and 64 bit hosts to test for endianness and variable width issues when I noticed that I couldn't properly perform a build of "make check" against a 32bit target from a 64bit host: ../../configure --cpu=i386 && make -j4 && make check This produces some war

Re: [Qemu-devel] [PATCH v4 0/4] Improve handling of GICD_ICFGR

2014-08-21 Thread Adam Lackorzynski
On Mon Aug 18, 2014 at 16:30:51 +0200, Adam Lackorzynski wrote: > The following patches address the behavior of the GICD_ICFGR register > in the ARM GIC. Any takers or comments? > Changes to v3: > - Tag patchset with proper version > > Changes to v2: > - Replace 16 with GIC_NR_SGIS in setup >

Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

2014-08-21 Thread Peter Lieven
Am 11.07.2014 um 14:52 schrieb Amit Shah : > On (Wed) 09 Jul 2014 [12:00:13], Peter Maydell wrote: >> On 9 July 2014 11:56, Amit Shah wrote: >>> On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote: OK; we're treating those as bugs so yes, I think this is 2.1 material. Has somebody oth

Re: [Qemu-devel] [PATCH 2/3] hw/core/loader: implement load_uimage_at

2014-08-21 Thread Alexander Graf
> Am 21.08.2014 um 22:56 schrieb Max Filippov : > > Hi Alex, > >> On Thu, Aug 21, 2014 at 1:16 PM, Alexander Graf wrote: >>> On 12.08.14 06:22, Max Filippov wrote: >>> load_uimage_at loads kernel image at the specified address instead of >>> the address recorded in the uImage header. >>> >>>

Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check

2014-08-21 Thread Benoît Canet
On Thu, Aug 21, 2014 at 01:13:20PM -0600, Eric Blake wrote: > On 08/21/2014 12:57 PM, Benoît Canet wrote: > > On Fri, Aug 15, 2014 at 05:16:19PM +0200, Max Reitz wrote: > >> Put the code for calculating the reference counts during qemu-img check > >> into an own function. > >> > >> Also, do not use

Re: [Qemu-devel] [PATCH 2/3] hw/core/loader: implement load_uimage_at

2014-08-21 Thread Max Filippov
Hi Alex, On Thu, Aug 21, 2014 at 1:16 PM, Alexander Graf wrote: > On 12.08.14 06:22, Max Filippov wrote: >> load_uimage_at loads kernel image at the specified address instead of >> the address recorded in the uImage header. >> >> Cc: qemu-sta...@nongnu.org >> Signed-off-by: Max Filippov > > Plea

Re: [Qemu-devel] [PATCH v5 15/15] target-tricore: Add instructions of SR opcode format

2014-08-21 Thread Richard Henderson
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: > +/* SR-format */ > +case OPCM_16_SR_SYSTEM: > +decode_sr_system(env, ctx); > + break; > +case OPCM_16_SR_ACCU: > +decode_sr_accu(env, ctx); > + break; Formatting is off; checkpatch should have caught this.

Re: [Qemu-devel] [PATCH v5 10/15] target-tricore: Add instructions of SB opcode format

2014-08-21 Thread Richard Henderson
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: > @@ -679,9 +768,11 @@ gen_intermediate_code_internal(TRICORECPU *cpu, struct > TranslationBlock *tb, > num_insns++; > > if (tcg_ctx.gen_opc_ptr >= gen_opc_end) { > +gen_goto_tb(&ctx, 0, ctx.next_pc); >

Re: [Qemu-devel] [PATCH v5 09/15] target-tricore: Add instructions of SRRS and SLRO opcode format

2014-08-21 Thread Richard Henderson
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: > Add instructions of SSRS and SLRO opcode format. > Add micro-op generator functions for offset loads. > > Signed-off-by: Bastian Koppelmann > --- > v4 -> v5: > - decode_16Bit_opc: Add if to handle ADDSC.A opcode being 6 bit instead > of 7 b

Re: [Qemu-devel] [PATCH v5 07/15] target-tricore: Add instructions of SRR opcode format

2014-08-21 Thread Richard Henderson
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: > Add instructions of SRR opcode format. > Add helper for add/sub_ssov. > > Signed-off-by: Bastian Koppelmann > --- > v4 -> v5: > - gen_sub_d now saves result of substraction into tcg temp to handle ret > = r1 cases. > - gen_mul_i32s now

Re: [Qemu-devel] [PATCH v5 06/15] target-tricore: Add instructions of SRC opcode format

2014-08-21 Thread Richard Henderson
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: > +static void gen_shaci(TCGv ret, TCGv r1, int32_t shift_count) > +{ > +uint32_t msk, msk_start; > +TCGv temp = tcg_temp_new(); > +TCGv temp2 = tcg_temp_new(); > +TCGv t_0 = tcg_const_i32(0); > + > +if (shift_count == 0) { > +

Re: [Qemu-devel] [PATCH v3 0/6] Improve global validation test cases, move validation to a single function

2014-08-21 Thread Eduardo Habkost
Ping? On Fri, Aug 08, 2014 at 04:03:25PM -0300, Eduardo Habkost wrote: > New version of what was previously a single patch, submitted as: > Subject: [PATCH v2] qdev: Move global validation to a single function > > Now the test cases run in a subprocess, and we are ensuring the warning > messag

[Qemu-devel] [PATCH] target-i386: Reject invalid CPU feature names on the command-line

2014-08-21 Thread Eduardo Habkost
Instead of simply printing a warning, report an error when invalid CPU options are provided on the CPU model string. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 21750

Re: [Qemu-devel] [PATCH] target-i386: Support migratable=no properly

2014-08-21 Thread Eduardo Habkost
Forgot to add qemu-devel to "To:". Adding it. On Wed, Aug 20, 2014 at 05:30:12PM -0300, Eduardo Habkost wrote: > When the "migratable" property was implemented, the behavior was tested > by changing the default on the code, but actually using the option on > the command-line (e.g. "-cpu host,migra

[Qemu-devel] Mentors wanted for Outreach Program for Women October 2014

2014-08-21 Thread Stefan Hajnoczi
Dear mentors and core contributors, Outreach Program for Women is starting the next round in October 2014. OPW funds women to work on open source software for 12 weeks with the help of mentors: https://wiki.gnome.org/OutreachProgramForWomen/ We just completed a successful round of OPW and Google S

Re: [Qemu-devel] QEMU dies on any attempt to load a Linux kernel module when using a 9P rootfs

2014-08-21 Thread Christopher Covington
Hi Richard, On 11/25/2013 10:49 AM, Richard Yao wrote: > I booted a Gentoo Linux installation in QEMU with a 9P rootfs as follows: > > sudo qemu-kvm -cpu host -m 1024 -kernel > /mnt/test/usr/src/linux-3.13-rc1/arch/x86/boot/bzImage -append > 'root=/dev/root rootfstype=9p rootflags=trans=virtio,ve

[Qemu-devel] [Bug 1359930] [NEW] [ARMv5] Integrator/CP regression when reading FPSID instruction

2014-08-21 Thread Jakub Jermar
Public bug reported: There seems to be a regression in QEMU 2.1.0 which demonstrates itself when running the attached HelenOS Integrator/CP (i.e. ARMv5) image. The offending instruction seems to be: vmrs r0, fpsid Upon its execution, HelenOS kernel receives an Undefined instruction exception (

[Qemu-devel] [Bug 1359930] Re: [ARMv5] Integrator/CP regression when reading FPSID instruction

2014-08-21 Thread Jakub Jermar
Here is the respective HelenOS kernel with debug symbols. ** Attachment added: "HelenOS kernel with debug symbols" https://bugs.launchpad.net/helenos/+bug/1359930/+attachment/4183966/+files/kernel.raw -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH bugfix v1 1/3] xen: hvm: Abstract away memory region name ref (fix broken build)

2014-08-21 Thread Stefano Stabellini
On Wed, 20 Aug 2014, Peter Maydell wrote: > On 20 August 2014 09:53, Stefan Weil wrote: > > Am 20.08.2014 um 07:07 schrieb Peter Crosthwaite: > >> The mr->name field is removed. This slipped through compile testing. > >> Fix. > >> > >> Signed-off-by: Peter Crosthwaite > >> --- > >> > >> xen-hvm.

Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check

2014-08-21 Thread Eric Blake
On 08/21/2014 12:57 PM, Benoît Canet wrote: > On Fri, Aug 15, 2014 at 05:16:19PM +0200, Max Reitz wrote: >> Put the code for calculating the reference counts during qemu-img check >> into an own function. >> >> Also, do not use g_realloc() for increasing the size of the in-memory >> refcount table,

Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check

2014-08-21 Thread Benoît Canet
On Fri, Aug 15, 2014 at 05:16:19PM +0200, Max Reitz wrote: > Put the code for calculating the reference counts during qemu-img check > into an own function. > > Also, do not use g_realloc() for increasing the size of the in-memory > refcount table, but rather g_try_realloc(). > > Signed-off-by: M

Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check

2014-08-21 Thread Benoît Canet
On Fri, Aug 15, 2014 at 05:16:19PM +0200, Max Reitz wrote: > Put the code for calculating the reference counts during qemu-img check > into an own function. > > Also, do not use g_realloc() for increasing the size of the in-memory > refcount table, but rather g_try_realloc(). > > Signed-off-by: M

Re: [Qemu-devel] [PATCH 1/4] qcow2: Fix leak of QemuOpts in qcow2_open()

2014-08-21 Thread Benoît Canet
The Wednesday 20 Aug 2014 à 19:59:33 (+0200), Max Reitz wrote : > Currently, the QemuOpts object opts is leaked if anything fails from its > creation up to and including the image repair block. Fix this by freeing > that object in the fail path. > > Signed-off-by: Max Reitz > --- > block/qcow2.c

[Qemu-devel] [PATCH v3] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-21 Thread Lluís Vilanova
Also removes old "trace-event", "trace-file" and "info trace-events" HMP commands. Signed-off-by: Lluís Vilanova --- monitor.c | 24 +++- qapi-schema.json|3 ++ qapi/trace.json | 44 + qmp-commands.hx | 27 ++

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-21 Thread Andrey Korolyov
On Thu, Aug 21, 2014 at 8:44 PM, Paolo Bonzini wrote: > Il 21/08/2014 18:41, Andrey Korolyov ha scritto: >> Sorry, the test series revealed that the problem is still here, but >> with lower hit ratio with modified 2.1-HEAD using selected argument >> set. The actual root of the issue is in '-cpu >>

[Qemu-devel] [PATCH v4 7/8] ahci: Add test_hba_enable to ahci-test.

2014-08-21 Thread John Snow
This test engages the HBA functionality and initializes values to sane defaults to allow for minimal HBA functionality. Buffers are allocated and pointers are updated to allow minimal I/O commands to complete as expected. Error registers and responses are sanity checked for specification adherence

[Qemu-devel] [PATCH v4 4/8] ahci: add test_pci_enable to ahci-test.

2014-08-21 Thread John Snow
This adds a test wherein we engage the PCI AHCI device and ensure that the memory region for the HBA functionality is now accessible. Under Q35 environments, additional PCI configuration is performed to ensure that the HBA functionality will become usable. Signed-off-by: John Snow --- tests/ahc

[Qemu-devel] [PATCH v4 2/8] ahci: MSI capability should be at 0x80, not 0x50.

2014-08-21 Thread John Snow
In the Intel ICH9 data sheet, the MSI capability offset in the PCI configuration space for ICH9 AHCI devices is specified to be 0x80. Further, the PCI capability pointer should always point to 0x80 in ICH9 devices, despite the fact that AHCI 1.3 specifies that it should be pointing to PMCAP (Which

[Qemu-devel] [PATCH v4 8/8] ahci: Add test_identify case to ahci-test.

2014-08-21 Thread John Snow
Utilizing all of the bring-up code in pci_enable and hba_enable, this test issues a simple IDENTIFY command via the HBA and retrieves the response via the PIO receive mechanisms of the HBA. Bugs: The DPS interrupt (Descriptor Processed Status) does not currently get set. This will need to be adjus

[Qemu-devel] [PATCH v4 0/8] AHCI test suite framework

2014-08-21 Thread John Snow
This submission does not re-send earlier patches in the series which have already been merged into QEMU, which were primarily staging fixes and small tweaks to support this smaller set of patches. This patch series introduces a number of small fixes and tweaks to help support an AHCI test suite th

[Qemu-devel] [PATCH v4 6/8] ahci: Add test_hba_spec to ahci-test.

2014-08-21 Thread John Snow
Add a test routine that checks the boot-up values of the HBA configuration memory space against the AHCI 1.3 specification and Intel ICH9 data sheet (for Q35 machines) for adherence and sane values. The HBA is not yet engaged or put into the idle state. Signed-off-by: John Snow --- tests/ahci-t

[Qemu-devel] [PATCH v4 1/8] ahci: Adding basic functionality qtest.

2014-08-21 Thread John Snow
Currently, there is no qtest to test the functionality of the AHCI functionality present within the Q35 machine type. This patch adds a skeleton for an AHCI test suite, and adds a simple sanity-check test case where we identify that the AHCI device is present, then disengage the virtual machine.

[Qemu-devel] [PATCH v4 5/8] ahci: properly shadow the TFD register

2014-08-21 Thread John Snow
In a real AHCI device, several S/ATA registers are mirrored or shadowed within the AHCI register set. These registers are not updated synchronously for each read access, but are instead updated after a Device-to-Host Register FIS packet is received. The D2H FIS contains the values from these regist

[Qemu-devel] [PATCH v4 3/8] ahci: Add test_pci_spec to ahci-test.

2014-08-21 Thread John Snow
Adds a specification adherence test for AHCI where the boot-up values for the PCI configuration space are compared against the AHCI 1.3 specification. This test does not itself attempt to engage the device. Signed-off-by: John Snow --- tests/ahci-test.c | 305 +++

Re: [Qemu-devel] [PATCH v2] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted

2014-08-21 Thread Benoît Canet
The Thursday 21 Aug 2014 à 14:36:19 (+0200), Markus Armbruster wrote : > Instead of bdrv_getlength(). > > Commit 57322b7 did this all over block, but one more bdrv_getlength() > has crept in since. > > Signed-off-by: Markus Armbruster > --- > v2: Actually use bdrv_nb_sectors() as advertized [Fam

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: add test case 101 for short file I/O

2014-08-21 Thread Benoît Canet
The Thursday 21 Aug 2014 à 13:44:08 (+0100), Stefan Hajnoczi wrote : > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/101 | 58 > ++ > tests/qemu-iotests/101.out | 10 > tests/qemu-iotests/group | 1 + > 3 files changed, 69 i

Re: [Qemu-devel] [PATCH 1/2] raw-posix: fix O_DIRECT short reads

2014-08-21 Thread Benoît Canet
The Thursday 21 Aug 2014 à 13:44:07 (+0100), Stefan Hajnoczi wrote : > The following O_DIRECT read from a <512 byte file fails: > > $ truncate -s 320 test.img > $ qemu-io -n -c 'read -P 0 0 512' test.img > qemu-io: can't open device test.img: Could not read image for determining > its forma

Re: [Qemu-devel] [RFC PATCH 8/9] block: Implement stub bdrv_em_co_aiocb_info.cancel_async

2014-08-21 Thread Stefan Hajnoczi
On Thu, Aug 21, 2014 at 07:56:55PM +0800, Fam Zheng wrote: > diff --git a/block.c b/block.c > index 1cc8926..1860e4b 100644 > --- a/block.c > +++ b/block.c > @@ -4750,9 +4750,14 @@ static void bdrv_aio_co_cancel_em(BlockDriverAIOCB > *blockacb) > } > } > > +static void bdrv_aio_co_cancel_e

Re: [Qemu-devel] [RFC PATCH 6/9] blkdebug: Implement .cancel_async

2014-08-21 Thread Stefan Hajnoczi
On Thu, Aug 21, 2014 at 07:56:53PM +0800, Fam Zheng wrote: > @@ -446,12 +439,25 @@ static void error_callback_bh(void *opaque) > qemu_aio_release(acb); > } > > +static void blkdebug_aio_cancel_async(BlockDriverAIOCB *blockacb) > +{ > +BlkdebugAIOCB *acb = container_of(blockacb, Blkdebug

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-21 Thread Paolo Bonzini
Il 21/08/2014 18:41, Andrey Korolyov ha scritto: > Sorry, the test series revealed that the problem is still here, but > with lower hit ratio with modified 2.1-HEAD using selected argument > set. The actual root of the issue is in '-cpu > qemu64,hv_time,hv_relaxed,hv_vapic,hv_spinlocks=0x1000' > Wi

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-21 Thread Andrey Korolyov
On Thu, Aug 21, 2014 at 7:48 PM, Andrey Korolyov wrote: > On Sat, Aug 9, 2014 at 10:35 AM, Paolo Bonzini wrote: >> >>> > Yeah, I need to sit down and look at the code more closely... Perhaps a >>> > cpu_mark_all_dirty() is enough. >>> >>> Hi Paolo, >>> >>> cpu_clean_all_dirty, you mean? Has the

Re: [Qemu-devel] [RFC PATCH 4/9] linux-aio: Implement .cancel_async

2014-08-21 Thread Stefan Hajnoczi
On Thu, Aug 21, 2014 at 07:56:51PM +0800, Fam Zheng wrote: > @@ -110,6 +109,22 @@ static void qemu_laio_completion_cb(EventNotifier *e) > } > } > > +static void laio_cancel_async(BlockDriverAIOCB *blockacb) > +{ > +struct qemu_laiocb *laiocb = (struct qemu_laiocb *)blockacb; > +stru

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-21 Thread Konrad Rzeszutek Wilk
On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: > Currenjly this ISA bridge should be fixed at 1f.0, and pass the Currently > real vendor/device ids as the driver expect. Could you add a bit more description to this patch please? Explain the rationale, etc. > > Signed-off-by: Tieju

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-21 Thread Andrey Korolyov
On Sat, Aug 9, 2014 at 10:35 AM, Paolo Bonzini wrote: > >> > Yeah, I need to sit down and look at the code more closely... Perhaps a >> > cpu_mark_all_dirty() is enough. >> >> Hi Paolo, >> >> cpu_clean_all_dirty, you mean? Has the same effect. >> >> Marcin's patch to add cpu_synchronize_state_alw

Re: [Qemu-devel] [PATCH 1/1] hw/arm/virt: increase max SMP CPU support to 8 for ARM virt

2014-08-21 Thread Wei Huang
On 08/21/2014 09:59 AM, Joel Schopp wrote: On 08/21/2014 09:51 AM, Wei Huang wrote: Current ARM virt model supports up to 4 CPUs. Given that many recent ARM servers contain 8 or more cores, it is time to bump up max guest CPUs to 8. This patch was tested with a VM runnng 3.15 Linux kernel. All

Re: [Qemu-devel] [PATCH 1/1] hw/arm/virt: increase max SMP CPU support to 8 for ARM virt

2014-08-21 Thread Joel Schopp
On 08/21/2014 09:51 AM, Wei Huang wrote: Current ARM virt model supports up to 4 CPUs. Given that many recent ARM servers contain 8 or more cores, it is time to bump up max guest CPUs to 8. This patch was tested with a VM runnng 3.15 Linux kernel. All 8 VCPUs showed up. Signed-off-by: Wei Huang

[Qemu-devel] [PATCH 1/1] hw/arm/virt: increase max SMP CPU support to 8 for ARM virt

2014-08-21 Thread Wei Huang
Current ARM virt model supports up to 4 CPUs. Given that many recent ARM servers contain 8 or more cores, it is time to bump up max guest CPUs to 8. This patch was tested with a VM runnng 3.15 Linux kernel. All 8 VCPUs showed up. Signed-off-by: Wei Huang --- hw/arm/virt.c | 2 +- 1 file changed,

Re: [Qemu-devel] What tests should "make check-block" run?

2014-08-21 Thread Kevin Wolf
Am 21.08.2014 um 14:52 hat Paolo Bonzini geschrieben: > Il 21/08/2014 14:27, Markus Armbruster ha scritto: > > Current "make check-block" runs tests/qemu-iotests-quick.sh, which tests > > format qcow2, protocol file, group quick with cache=none. Runs 55 tests > > and takes about 2 minutes for me o

Re: [Qemu-devel] [PATCH] scsi-generic: fix debug print compiling error

2014-08-21 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH] scsi-generic: fix debug print compiling > error > > Il 21/08/2014 14:19, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > variables lun and tag had been eliminated, broke compiling > > when enable debug switch. > > > > Signed-off-by: Gonglei > >

Re: [Qemu-devel] [PATCH v11 03/14] qcow2: Optimize bdrv_make_empty()

2014-08-21 Thread Kevin Wolf
Am 20.08.2014 um 20:17 hat Max Reitz geschrieben: > bdrv_make_empty() is currently only called if the current image > represents an external snapshot that has been committed to its base > image; it is therefore unlikely to have internal snapshots. In this > case, bdrv_make_empty() can be greatly sp

Re: [Qemu-devel] [RFC PATCH 1/9] block: Add bdrv_aio_cancel_async

2014-08-21 Thread Stefan Hajnoczi
On Thu, Aug 21, 2014 at 07:56:48PM +0800, Fam Zheng wrote: > +/* Async version of aio cancel. The caller is not blocked if the acb > implements > + * cancel_async, otherwise fall back to bdrv_aio_cancel. In both cases, > acb->cb > + * is guarenteed to be called, before or after function returns.

Re: [Qemu-devel] [PATCH] scsi-generic: fix debug print compiling error

2014-08-21 Thread Paolo Bonzini
Il 21/08/2014 14:19, arei.gong...@huawei.com ha scritto: > From: Gonglei > > variables lun and tag had been eliminated, broke compiling > when enable debug switch. > > Signed-off-by: Gonglei > --- > hw/scsi/scsi-generic.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-21 Thread Peter Maydell
On 21 August 2014 14:15, Christopher Covington wrote: > On 08/21/2014 08:33 AM, Peter Maydell wrote: >> I think the ELF loading thing is a separate issue -- if we're loading >> an ELF file we should honour its entry point address instead of >> trying to load from the vector table. (The question of

Re: [Qemu-devel] What tests should "make check-block" run?

2014-08-21 Thread Peter Maydell
On 21 August 2014 14:12, Stefan Hajnoczi wrote: > On Thu, Aug 21, 2014 at 02:27:00PM +0200, Markus Armbruster wrote: >> Should we have a variant of "make check-block" for testing other >> (format, protocol) combinations? > > I don't think variants are useful. If you need control, use ./check. Th

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-21 Thread Christopher Covington
On 08/21/2014 08:33 AM, Peter Maydell wrote: > On 21 August 2014 04:37, Peter Crosthwaite > wrote: >> On Thu, Aug 21, 2014 at 11:40 AM, Alistair Francis >> wrote: >>> On Thu, Aug 21, 2014 at 11:36 AM, Alistair Francis >>> wrote: This allows the board to set the reset address, which is re

Re: [Qemu-devel] What tests should "make check-block" run?

2014-08-21 Thread Stefan Hajnoczi
On Thu, Aug 21, 2014 at 02:27:00PM +0200, Markus Armbruster wrote: > Should "make check-block" run more tests? Which ones? Let's add image format specific test cases to "make check-block" (e.g. VHDX and VMDK). For these formats we would not run the standard tests, only the format-specific test c

[Qemu-devel] [PATCH v2] monitor: fix debug print compiling error

2014-08-21 Thread arei.gonglei
From: Gonglei error: 'i' undeclared (first use in this function) Signed-off-by: Gonglei --- v2: avoid to mix code and declarations, add a pair of {}, thanks Peter. --- monitor.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 34cee74..667

Re: [Qemu-devel] What tests should "make check-block" run?

2014-08-21 Thread Peter Crosthwaite
On Thu, Aug 21, 2014 at 10:52 PM, Paolo Bonzini wrote: > Il 21/08/2014 14:27, Markus Armbruster ha scritto: >> Current "make check-block" runs tests/qemu-iotests-quick.sh, which tests >> format qcow2, protocol file, group quick with cache=none. Runs 55 tests >> and takes about 2 minutes for me on

Re: [Qemu-devel] Using cache=writeback safely on qemu 1.4.0 and later

2014-08-21 Thread Stefan Hajnoczi
On Wed, Aug 20, 2014 at 12:20 AM, Andrew Martin wrote: > - Original Message - >> From: "Stefan Hajnoczi" >> To: "Andrew Martin" >> Cc: qemu-devel@nongnu.org >> Sent: Tuesday, August 19, 2014 9:59:25 AM >> Subject: Re: [Qemu-devel] Using cache=writeback safely on qemu 1.4.0 and >> later

Re: [Qemu-devel] [PATCH] monitor: fix debug print compiling error

2014-08-21 Thread Gonglei (Arei)
> -Original Message- > From: peter.crosthwa...@petalogix.com > [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite > Sent: Thursday, August 21, 2014 8:54 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org Developers; Huangweidong (C); Luiz Capitulino > Subject: Re: [Qem

Re: [Qemu-devel] [PATCH] monitor: fix debug print compiling error

2014-08-21 Thread Peter Crosthwaite
On Thu, Aug 21, 2014 at 10:47 PM, wrote: > From: Gonglei > > error: 'i' undeclared (first use in this function) > > Signed-off-by: Gonglei > --- > monitor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/monitor.c b/monitor.c > index 34cee74..6a233e7 100644 > --- a/monitor.c > +++ b/

Re: [Qemu-devel] What tests should "make check-block" run?

2014-08-21 Thread Paolo Bonzini
Il 21/08/2014 14:27, Markus Armbruster ha scritto: > Current "make check-block" runs tests/qemu-iotests-quick.sh, which tests > format qcow2, protocol file, group quick with cache=none. Runs 55 tests > and takes about 2 minutes for me on a not particularly fast test box > (spinning rust). Perhaps

Re: [Qemu-devel] [PULL 00/01] seccomp: add semctl() to the syscall whitelist

2014-08-21 Thread Paolo Bonzini
Il 21/08/2014 14:42, Peter Maydell ha scritto: >> > seccomp: add semctl() to the syscall whitelist (2014-08-21 10:29:16 >> > +0200) > Applied, thanks. PS: git@github... isn't a valid git remote > name for other people; I'd appreciate it if you could fix the > scripts/workflow you use to create t

[Qemu-devel] [PATCH] xhci: fix debug print compiling error

2014-08-21 Thread arei.gonglei
From: Gonglei after commit 003e15a180373048f0c1f4df0bfe303746eb2676 the DPRINTF will broke compiling, adjust its location. Signed-off-by: Gonglei --- hw/usb/hcd-xhci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 58c4b11.

[Qemu-devel] [PATCH] monitor: fix debug print compiling error

2014-08-21 Thread arei.gonglei
From: Gonglei error: 'i' undeclared (first use in this function) Signed-off-by: Gonglei --- monitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/monitor.c b/monitor.c index 34cee74..6a233e7 100644 --- a/monitor.c +++ b/monitor.c @@ -4747,6 +4747,7 @@ static void monitor_find_completio

[Qemu-devel] [PATCH 2/2] qemu-iotests: add test case 101 for short file I/O

2014-08-21 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/101 | 58 ++ tests/qemu-iotests/101.out | 10 tests/qemu-iotests/group | 1 + 3 files changed, 69 insertions(+) create mode 100755 tests/qemu-iotests/101 create mode 100644 tests/qe

[Qemu-devel] [PATCH 0/2] raw-posix: fix O_DIRECT short reads

2014-08-21 Thread Stefan Hajnoczi
This series fixes qemu-iotests ./check -nocache -vmdk 059. It also adds a dedicated test case for O_DIRECT short reads. Stefan Hajnoczi (2): raw-posix: fix O_DIRECT short reads qemu-iotests: add test case 101 for short file I/O block/raw-posix.c | 9 +++ tests/qemu-iotests/101

[Qemu-devel] [PATCH 1/2] raw-posix: fix O_DIRECT short reads

2014-08-21 Thread Stefan Hajnoczi
The following O_DIRECT read from a <512 byte file fails: $ truncate -s 320 test.img $ qemu-io -n -c 'read -P 0 0 512' test.img qemu-io: can't open device test.img: Could not read image for determining its format: Invalid argument Note that qemu-io completes successfully without the -n (O_D

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-21 Thread Peter Crosthwaite
On Thu, Aug 21, 2014 at 10:40 PM, Peter Maydell wrote: > On 21 August 2014 13:37, Peter Crosthwaite > wrote: >> On Thu, Aug 21, 2014 at 10:33 PM, Peter Maydell >> wrote: >>> I think the ELF loading thing is a separate issue -- if we're loading >>> an ELF file we should honour its entry point ad

Re: [Qemu-devel] [PULL 00/01] seccomp: add semctl() to the syscall whitelist

2014-08-21 Thread Peter Maydell
On 21 August 2014 09:39, Eduardo Otubo wrote: > The following changes since commit 2656eb7c599e306b95bad82b1372fc49ba3088f6: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20140819' into staging (2014-08-20 > 09:55:42 +0100) > > are available in the git repository at

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-21 Thread Peter Maydell
On 21 August 2014 13:37, Peter Crosthwaite wrote: > On Thu, Aug 21, 2014 at 10:33 PM, Peter Maydell > wrote: >> I think the ELF loading thing is a separate issue -- if we're loading >> an ELF file we should honour its entry point address instead of >> trying to load from the vector table. (The qu

[Qemu-devel] [PATCH V2] net: Fix dealing with packets when runstate changes

2014-08-21 Thread zhanghailiang
For all NICs(except virtio-net) emulated by qemu, Such as e1000, rtl8139, pcnet and ne2k_pci, Qemu can still receive packets when VM is not running. If this happened in *migration's* last PAUSE VM stage, The new dirty RAM related to the packets will be missed, And this will lead serious network fau

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-21 Thread Alistair Francis
On Thu, Aug 21, 2014 at 10:24 PM, Peter Maydell wrote: > On 21 August 2014 13:09, Alistair Francis wrote: >> On Thu, Aug 21, 2014 at 7:14 PM, Peter Maydell >> wrote: >>> This isn't making a great deal of sense to me. If you >>> mean that the board design allows some sort of >>> programmable or

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-21 Thread Peter Crosthwaite
On Thu, Aug 21, 2014 at 10:33 PM, Peter Maydell wrote: > On 21 August 2014 04:37, Peter Crosthwaite > wrote: >> On Thu, Aug 21, 2014 at 11:40 AM, Alistair Francis >> wrote: >>> On Thu, Aug 21, 2014 at 11:36 AM, Alistair Francis >>> wrote: This allows the board to set the reset address,

[Qemu-devel] [PATCH v2] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted

2014-08-21 Thread Markus Armbruster
Instead of bdrv_getlength(). Commit 57322b7 did this all over block, but one more bdrv_getlength() has crept in since. Signed-off-by: Markus Armbruster --- v2: Actually use bdrv_nb_sectors() as advertized [Fam] Passes ./check -T -vmdk -g quick block/vmdk.c | 11 +-- 1 file changed, 5 i

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-21 Thread Peter Crosthwaite
On Thu, Aug 21, 2014 at 10:24 PM, Peter Maydell wrote: > On 21 August 2014 13:09, Alistair Francis wrote: >> On Thu, Aug 21, 2014 at 7:14 PM, Peter Maydell >> wrote: >>> This isn't making a great deal of sense to me. If you >>> mean that the board design allows some sort of >>> programmable or

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-21 Thread Peter Maydell
On 21 August 2014 04:37, Peter Crosthwaite wrote: > On Thu, Aug 21, 2014 at 11:40 AM, Alistair Francis > wrote: >> On Thu, Aug 21, 2014 at 11:36 AM, Alistair Francis >> wrote: >>> This allows the board to set the reset address, which is required >>> for some boards (the Netduino Plus 2 for exa

  1   2   >