Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Jason Wang
On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote: > On 2014/8/21 12:29, Jason Wang wrote: >> On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote: >>> On 2014/8/19 12:56, Jason Wang wrote: commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue >>> call it before setting Zhang Jie, please te

Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted

2014-08-20 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 08/20 19:07, Markus Armbruster wrote: >> Instead of bdrv_getlength(). >> >> Commit 57322b7 did this all over block, but one more bdrv_getlength() >> has crept in since. >> >> Signed-off-by: Markus Armbruster >> --- >> block/vmdk.c | 11 +-- >> 1 file change

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Zhangjie (HZ)
On 2014/8/21 12:29, Jason Wang wrote: > On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote: >> On 2014/8/19 12:56, Jason Wang wrote: >>> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue >> call it before setting >>> Zhang Jie, please test this patch to see if it fixes the issue. >>> +st

Re: [Qemu-devel] [PATCH] pc: reserve more memory for ACPI for new machine types

2014-08-20 Thread Luiz Capitulino
On Wed, 20 Aug 2014 22:55:38 +0200 "Michael S. Tsirkin" wrote: > commit 868270f23d8db2cce83e4f082fe75e8625a5fbf9 > acpi-build: tweak acpi migration limits > broke kernel loading with -kernel/-initrd: it doubled > the size of ACPI tables but did not reserve > enough memory. > > As a result, i

Re: [Qemu-devel] [BUG] Possible ACPI regression in v2.1.0

2014-08-20 Thread Luiz Capitulino
On Wed, 20 Aug 2014 23:00:57 +0200 "Michael S. Tsirkin" wrote: > On Wed, Aug 20, 2014 at 04:41:25PM -0400, Luiz Capitulino wrote: > > > > Starting a QEMU instance manually configured to boot a Fedora installation > > kernel with the -kernel/-initrd command-line options cause ACPI to brake > > in

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Jason Wang
On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote: > On 2014/8/19 12:56, Jason Wang wrote: >> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > call it before setting >> Zhang Jie, please test this patch to see if it fixes the issue. >> +static void vhost_net_set_vq_index(struct vhost_

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-20 Thread Alistair Francis
On Thu, Aug 21, 2014 at 1:37 PM, Peter Crosthwaite wrote: > On Thu, Aug 21, 2014 at 11:40 AM, Alistair Francis > wrote: >> Add Konstanty >> >> >> On Thu, Aug 21, 2014 at 11:36 AM, Alistair Francis >> wrote: >>> This allows the board to set the reset address, which is required >>> for some boar

Re: [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util

2014-08-20 Thread Fam Zheng
On Wed, 08/20 15:32, Paolo Bonzini wrote: > > In any case, if we need it I think there's no need to keep the argument > to iqn_generate. How about multiple initiators? Should they use the same iqn? Fam

Re: [Qemu-devel] [PATCH v2 1/3] qdev: using error_abort instead of using local_err

2014-08-20 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v2 1/3] qdev: using error_abort instead of > using local_err > > On Thu, Aug 21, 2014 at 12:11 PM, wrote: > > From: Gonglei > > > > This error can not happen normally. If it happens indicates > > something very wrong, we should abort QEMU. moreover, The > > us

Re: [Qemu-devel] [PATCH v2 1/3] qdev: using error_abort instead of using local_err

2014-08-20 Thread Peter Crosthwaite
On Thu, Aug 21, 2014 at 12:11 PM, wrote: > From: Gonglei > > This error can not happen normally. If it happens indicates > something very wrong, we should abort QEMU. moreover, The > user can only refer to /machine/peripheral, not > /machine/unattached. > > Signed-off-by: Gonglei Reviewed-by:

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-20 Thread Peter Crosthwaite
On Thu, Aug 21, 2014 at 11:40 AM, Alistair Francis wrote: > Add Konstanty > > > On Thu, Aug 21, 2014 at 11:36 AM, Alistair Francis > wrote: >> This allows the board to set the reset address, which is required >> for some boards (the Netduino Plus 2 for example) >> The change is armv7m specific

Re: [Qemu-devel] [PATCH bugfix v1 3/3] qom: object.h: Update object_get_canon_path* doc

2014-08-20 Thread Peter Crosthwaite
On Thu, Aug 21, 2014 at 1:58 AM, Paolo Bonzini wrote: > Il 20/08/2014 11:07, Peter Maydell ha scritto: >> The other thing you need to say is that the returned string is >> only valid for as long as the object remains a child property >> of its parent. (Is that right? I'm not clear. It also sounds

Re: [Qemu-devel] [PATCH 5/6] build-sys: Change libqemuutil.a to qemuutil.o and link whole object

2014-08-20 Thread Fam Zheng
On Wed, 08/20 15:29, Paolo Bonzini wrote: > Il 20/08/2014 12:01, Fam Zheng ha scritto: > > + > > +qemuutil.o: CC_REL_FLAGS := -Wl,-r > > Why the target-specific rule? > > > +qemuutil.o: $(util-obj-y) > > + $(call quiet-command,$(CC) -nostdlib $(CC_REL_FLAGS) -o $@ $^," LD -r > > $(TARGET_DIR

Re: [Qemu-devel] [RFC PATCH v2 10/13] linux headers update for DDW

2014-08-20 Thread Alexey Kardashevskiy
On 08/21/2014 05:44 AM, Alex Williamson wrote: > On Wed, 2014-08-20 at 17:49 +1000, Alexey Kardashevskiy wrote: >> On 08/19/2014 03:42 AM, Alex Williamson wrote: >>> On Fri, 2014-08-15 at 20:12 +1000, Alexey Kardashevskiy wrote: Since the changes are not in upstream yet, no tag or branch is sp

[Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-08-20 Thread arei.gonglei
From: Gonglei At present, this function doesn't have partial cleanup implemented, which will cause resource leak in some scenarios. Example: 1. Assuming that "dc->realize(dev, &local_err)" execute successful and local_err == NULL; 2. Executing device hotplug in hotplug_handler_plug(), but fa

[Qemu-devel] [PATCH v2 0/3] Refactor device_set_realized to avoid resource leak.

2014-08-20 Thread arei.gonglei
From: Gonglei after committing [PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API If devcie hotplugging failed, will casuse resource leak. This patch series include address resouce leak and two other issuses. v2 -> v1: - rewrite patch 1/3, using error_abort instea

[Qemu-devel] [PATCH v2 1/3] qdev: using error_abort instead of using local_err

2014-08-20 Thread arei.gonglei
From: Gonglei This error can not happen normally. If it happens indicates something very wrong, we should abort QEMU. moreover, The user can only refer to /machine/peripheral, not /machine/unattached. Signed-off-by: Gonglei --- hw/core/qdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[Qemu-devel] [PATCH v2 3/3] pcie: don't assert when hotplug a PCIe device with 'function != 0'

2014-08-20 Thread arei.gonglei
From: Gonglei It's enough to report an error. Assert() is not acceptable because the error is not a fatal error. Signed-off-by: Gonglei --- hw/pci/pcie.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index a123c01..7b46140 100644 --- a/h

Re: [Qemu-devel] [PATCH] pci_bridge: manually destroy memory regions within PCIBridgeWindows

2014-08-20 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, August 20, 2014 11:50 PM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; Gonglei (Arei); knut.om...@oracle.com; > m...@redhat.com > Subject: [PATCH] pci_br

Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-20 Thread Alistair Francis
Add Konstanty On Thu, Aug 21, 2014 at 11:36 AM, Alistair Francis wrote: > This allows the board to set the reset address, which is required > for some boards (the Netduino Plus 2 for example) > > Signed-off-by: Alistair Francis > --- > At the moment nothing requires this change, but I have a ma

[Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr a property

2014-08-20 Thread Alistair Francis
This allows the board to set the reset address, which is required for some boards (the Netduino Plus 2 for example) Signed-off-by: Alistair Francis --- At the moment nothing requires this change, but I have a machine model that I'm working on that requires this Thanks to Peter C for spotting thi

[Qemu-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-20 Thread Tiejun Chen
Currenjly this ISA bridge should be fixed at 1f.0, and pass the real vendor/device ids as the driver expect. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 7

[Qemu-devel] [PATCH 0/2] qemu:xen: implement isa bridge specific to IGD passthrough

2014-08-20 Thread Tiejun Chen
This is a subset to support IGD passthrough with qemu/xen, and this should be based on http://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg02166.html We will register to create isa bridge specific to IGD passthrough. Tiejun

[Qemu-devel] [PATCH 1/2] hw:xen:xen_pt: register isa bridge specific to IGD passthrough

2014-08-20 Thread Tiejun Chen
We need this instance to passthrough some config fields of PCH. Signed-off-by: Tiejun Chen --- hw/xen/xen_pt.c | 21 + 1 file changed, 21 insertions(+) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index c1bf357..bf72719 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@

Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted

2014-08-20 Thread Fam Zheng
On Wed, 08/20 19:07, Markus Armbruster wrote: > Instead of bdrv_getlength(). > > Commit 57322b7 did this all over block, but one more bdrv_getlength() > has crept in since. > > Signed-off-by: Markus Armbruster > --- > block/vmdk.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions

Re: [Qemu-devel] [Bug 1359243] Re: BSOD 0xc000000d]Can't boot windows with qemu

2014-08-20 Thread zhanghailiang
On 2014/8/20 22:51, Gannet wrote: ** Summary changed: - BSOD 0xc00d]Can't boot any windows with qemu + BSOD 0xc00d]Can't boot windows with qemu ** Summary changed: - BSOD 0xc00d]Can't boot windows with qemu + [BSOD 0xc00d]Can't boot windows with qemu ** Summary changed: - [BS

Re: [Qemu-devel] [PATCH v8] slirp/misc: Use the GLib memory allocation APIs

2014-08-20 Thread zhanghailiang
On 2014/8/20 23:03, Michael Tokarev wrote: 20.08.2014 18:57, Michael Tokarev пишет: 19.08.2014 12:30, zhanghailiang wrote: Here we don't check the return value of malloc() which may fail. Use the g_new() instead, which will abort the program when there is not enough memory. Also, use g_strdup

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-08-20 Thread Konrad Rzeszutek Wilk
On Wed, Aug 20, 2014 at 02:11:48PM +0200, Fabio Fantoni wrote: > Il 12/05/2014 16:32, Ross Philipson ha scritto: > >On 05/12/2014 05:05 AM, Ian Campbell wrote: > >>On Fri, 2014-05-09 at 13:32 -0400, Ross Philipson wrote: > >>>On 05/09/2014 12:34 PM, Paul Durrant wrote: > >-Original Message-

Re: [Qemu-devel] Recent SeaBIOS too big for QEMU -initrd

2014-08-20 Thread Kevin O'Connor
On Wed, Aug 20, 2014 at 11:27:41AM +0100, Stefan Hajnoczi wrote: > The QEMU -initrd option loads the initrd at the top of RAM. There is > a 64 KB safety region for ACPI tables in hw/i386/pc.c:load_linux(): > > initrd_max = max_ram_size-ACPI_DATA_SIZE-1; > > QEMU's bios-256k.bin SeaBIOS build r

Re: [Qemu-devel] [PATCH 1/1] loader: g_realloc(p, 0) frees and returns NULL, simplify

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 08:38:11PM +0200, Markus Armbruster wrote: > Once upon a time, it was decided that qemu_realloc(ptr, 0) should > abort. Switching to glib retired that bright idea. A bit of code > that was added to cope with it (commit 3e372cf) is still around. Bury > it. > > See also co

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 12:18:33PM +0200, Michael S. Tsirkin wrote: > On Wed, Aug 20, 2014 at 05:23:21PM +0800, Zhangjie (HZ) wrote: > > On 2014/8/19 12:56, Jason Wang wrote: > > > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > > call it before setting > > > Zhang Jie, please

[Qemu-devel] [Bug 1359243] Re: [BSOD 0xc000000d] Can't boot windows with qemu

2014-08-20 Thread Gannet
>Please try with "-cpu core2duo" or "-cpu host". It is not helped. BSOD also. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1359243 Title: [BSOD 0xc00d] Can't boot windows with qemu Status in

Re: [Qemu-devel] [BUG] Possible ACPI regression in v2.1.0

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 04:41:25PM -0400, Luiz Capitulino wrote: > > Starting a QEMU instance manually configured to boot a Fedora installation > kernel with the -kernel/-initrd command-line options cause ACPI to brake > in the guest with the following messages: Thanks. Please try [PATCH] pc: res

Re: [Qemu-devel] Recent SeaBIOS too big for QEMU -initrd

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 11:27:41AM +0100, Stefan Hajnoczi wrote: > The QEMU -initrd option loads the initrd at the top of RAM. There is > a 64 KB safety region for ACPI tables in hw/i386/pc.c:load_linux(): > > initrd_max = max_ram_size-ACPI_DATA_SIZE-1; > > QEMU's bios-256k.bin SeaBIOS build r

[Qemu-devel] [PATCH] pc: reserve more memory for ACPI for new machine types

2014-08-20 Thread Michael S. Tsirkin
commit 868270f23d8db2cce83e4f082fe75e8625a5fbf9 acpi-build: tweak acpi migration limits broke kernel loading with -kernel/-initrd: it doubled the size of ACPI tables but did not reserve enough memory. As a result, issues on boot and halt are observed. Fix this up by doubling reserved memory f

[Qemu-devel] [Bug 1359394] [NEW] virtio block device hangs after "virtio_blk virtio3: requests:id 0 is not a head!"

2014-08-20 Thread Slava Pestov
Public bug reported: The virtual machine is running block layer workloads, interrupted by unclean reboots (echo b > /proc/sysrq-trigger). Kernel version is 3.14. Sometimes, I get this message on boot: "virtio_blk virtio3: requests:id 0 is not a head!" Then, I/O to the virtio block devices just

[Qemu-devel] [BUG] Possible ACPI regression in v2.1.0

2014-08-20 Thread Luiz Capitulino
Starting a QEMU instance manually configured to boot a Fedora installation kernel with the -kernel/-initrd command-line options cause ACPI to brake in the guest with the following messages: [0.00] ACPI: uC\xffcdT 3ffe1854 2009587B (v49 \xffb2?a\xffdf?? \xffca\xfff

[Qemu-devel] [Bug 1359383] [NEW] kernel panic at smpboot.c:134 when rebooting qemu with multiple cores

2014-08-20 Thread Slava Pestov
Public bug reported: Hi all, I can reproduce this with kernel 3.14 and 3.17rc1. I suspect it is a qemu issue, but I'm not sure. The test case is the following script: qemu-system-x86_64 -machine accel=kvm -pidfile /tmp/pid$$ -m 512M -smp 8,sockets=8 -kernel vmlinuz -append "init=/sbin/reboot -f

Re: [Qemu-devel] [RFC] qapi: New command query-mtree

2014-08-20 Thread Eric Blake
On 08/20/2014 01:09 PM, Eric Blake wrote: > On 08/20/2014 11:46 AM, Marc Marí wrote: >> Add command query-mtree to get the memory tree of the guest. >> >> As we were looking for a flexible solution on accessing the guest memory from >> qtests, Stefan came with the idea to implement this new qmp com

Re: [Qemu-devel] [PATCH v5 06/10] hw/vfio: create common module

2014-08-20 Thread Joel Schopp
On 08/20/2014 02:41 PM, Alex Williamson wrote: > On Wed, 2014-08-20 at 14:12 -0500, Joel Schopp wrote: >>> +int vfio_get_device(VFIOGroup *group, const char *name, >>> + VFIODevice *vbasedev) >>> +{ >>> +struct vfio_device_info dev_info = { .argsz = sizeof(dev_info) }; >>

Re: [Qemu-devel] [RFC] qapi: New command query-mtree

2014-08-20 Thread Marc Marí
El Wed, 20 Aug 2014 13:09:20 -0600 Eric Blake escribió: > On 08/20/2014 11:46 AM, Marc Marí wrote: > > Add command query-mtree to get the memory tree of the guest. > > > > As we were looking for a flexible solution on accessing the guest > > memory from qtests, Stefan came with the idea to implem

Re: [Qemu-devel] [PATCH] pci_bridge: manually destroy memory regions within PCIBridgeWindows

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 05:50:05PM +0200, Paolo Bonzini wrote: > The regions are destroyed and recreated on configuration space accesses. > We need to destroy them before the containing PCIBridgeWindows object > is freed. > > Reported-by: Gonglei > Reported-by: Knut Omang > Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH v2] pcihp: fix possible array out of bounds

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 01:52:30PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Prevent out-of-bounds array access on > acpi_pcihp_pci_status. > > Signed-off-by: Gonglei > Reviewed-by: Peter Crosthwaite Applied, thanks! > --- > v2: > - change commit message. > - add 'Reviewed-

Re: [Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options

2014-08-20 Thread Eric Blake
On 08/20/2014 01:38 PM, Max Reitz wrote: >>> +# Structure of flags for each metadata structure. Setting a field to >>> 'true' >>> +# makes qemu guard that structure against unintended overwriting. >>> The default >>> +# value is chosen according to the template given. >>> +# >>> +# @template: Spec

Re: [Qemu-devel] [RFC PATCH v2 10/13] linux headers update for DDW

2014-08-20 Thread Alex Williamson
On Wed, 2014-08-20 at 17:49 +1000, Alexey Kardashevskiy wrote: > On 08/19/2014 03:42 AM, Alex Williamson wrote: > > On Fri, 2014-08-15 at 20:12 +1000, Alexey Kardashevskiy wrote: > >> Since the changes are not in upstream yet, no tag or branch is specified > >> here. > >> > >> Signed-off-by: Alexe

Re: [Qemu-devel] [PATCH v5 06/10] hw/vfio: create common module

2014-08-20 Thread Alex Williamson
On Wed, 2014-08-20 at 14:12 -0500, Joel Schopp wrote: > > +int vfio_get_device(VFIOGroup *group, const char *name, > > + VFIODevice *vbasedev) > > +{ > > +struct vfio_device_info dev_info = { .argsz = sizeof(dev_info) }; > > +struct vfio_region_info reg_info = { .argsz

Re: [Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options

2014-08-20 Thread Max Reitz
On 20.08.2014 21:36, Eric Blake wrote: On 08/20/2014 11:59 AM, Max Reitz wrote: qcow2 supports more than four options by now, add the new options (overlap check mode and metadata cache size) Signed-off-by: Max Reitz --- qapi/block-core.json | 79 ++

Re: [Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options

2014-08-20 Thread Eric Blake
On 08/20/2014 11:59 AM, Max Reitz wrote: > qcow2 supports more than four options by now, add the new options > (overlap check mode and metadata cache size) > > Signed-off-by: Max Reitz > --- > qapi/block-core.json | 79 > +++- > 1 file changed, 78

Re: [Qemu-devel] [PATCH 3/4] qcow2: Add overlap-check.template option

2014-08-20 Thread Max Reitz
On 20.08.2014 21:22, Eric Blake wrote: On 08/20/2014 11:59 AM, Max Reitz wrote: Being able to set the overlap-check option to a string and then refine it via the overlap-check.* options is a nice idea for the command line but does not work so well for non-flattened dicts. In that case, one can o

Re: [Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-20 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Markus Armbruster writes: >> >>> Lluís Vilanova writes: Also removes old "trace-event", "trace-file" and "info trace-events" HMP commands. >> >>> We gain the ability to control trace via QMP, but lose the ability to >>> control it

Re: [Qemu-devel] [PATCH 3/4] qcow2: Add overlap-check.template option

2014-08-20 Thread Eric Blake
On 08/20/2014 01:22 PM, Eric Blake wrote: > On 08/20/2014 11:59 AM, Max Reitz wrote: >> Being able to set the overlap-check option to a string and then refine >> it via the overlap-check.* options is a nice idea for the command line >> but does not work so well for non-flattened dicts. In that case

Re: [Qemu-devel] [PATCH 4/4] qcow2: Check L1/L2/reftable entries for alignment

2014-08-20 Thread Max Reitz
On 20.08.2014 12:51, Kevin Wolf wrote: Am 16.08.2014 um 23:16 hat Max Reitz geschrieben: Offsets taken from the L1, L2 and refcount tables are generally assumed to be correctly aligned. However, this cannot be guaranteed if the image has been written to by something different than qemu, thus che

Re: [Qemu-devel] [PATCH 3/4] qcow2: Add overlap-check.template option

2014-08-20 Thread Eric Blake
On 08/20/2014 11:59 AM, Max Reitz wrote: > Being able to set the overlap-check option to a string and then refine > it via the overlap-check.* options is a nice idea for the command line > but does not work so well for non-flattened dicts. In that case, one can > only specify either but not both, s

Re: [Qemu-devel] [PATCH 1/4] qcow2: Add qcow2_signal_corruption()

2014-08-20 Thread Max Reitz
On 20.08.2014 12:10, Kevin Wolf wrote: Am 16.08.2014 um 23:16 hat Max Reitz geschrieben: Add a helper function for easily marking an image corrupt while outputting an informative message to stderr and via QAPI. Signed-off-by: Max Reitz --- block/qcow2.c | 28 bl

Re: [Qemu-devel] [PATCH] pci_bridge: manually destroy memory regions within PCIBridgeWindows

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 05:50:05PM +0200, Paolo Bonzini wrote: > The regions are destroyed and recreated on configuration space accesses. > We need to destroy them before the containing PCIBridgeWindows object > is freed. > > Reported-by: Gonglei > Reported-by: Knut Omang > Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH 2/4] qapi: Allow enums in anonymous unions

2014-08-20 Thread Eric Blake
On 08/20/2014 11:59 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > scripts/qapi-types.py | 2 ++ > scripts/qapi-visit.py | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake (On a tangentially related note, I'd still like to get to the point where we can

Re: [Qemu-devel] [PATCH v5 06/10] hw/vfio: create common module

2014-08-20 Thread Joel Schopp
> +int vfio_get_device(VFIOGroup *group, const char *name, > + VFIODevice *vbasedev) > +{ > +struct vfio_device_info dev_info = { .argsz = sizeof(dev_info) }; > +struct vfio_region_info reg_info = { .argsz = sizeof(reg_info) }; > +struct vfio_irq_info irq_info = {

Re: [Qemu-devel] [PATCH 1/4] block: Correct bs->growable

2014-08-20 Thread Max Reitz
On 20.08.2014 13:40, Kevin Wolf wrote: Am 12.07.2014 um 00:23 hat Max Reitz geschrieben: Currently, the field "growable" in a BDS is set iff the BDS is opened in protocol mode (with O_BDRV_PROTOCOL). However, not every protocol block driver allows growing: NBD, for instance, does not. On the oth

Re: [Qemu-devel] [PATCH 1/4] qcow2: Fix leak of QemuOpts in qcow2_open()

2014-08-20 Thread Eric Blake
On 08/20/2014 11:59 AM, Max Reitz wrote: > Currently, the QemuOpts object opts is leaked if anything fails from its > creation up to and including the image repair block. Fix this by freeing > that object in the fail path. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 5 +++-- > 1 file ch

Re: [Qemu-devel] [RFC] qapi: New command query-mtree

2014-08-20 Thread Eric Blake
On 08/20/2014 11:46 AM, Marc Marí wrote: > Add command query-mtree to get the memory tree of the guest. > > As we were looking for a flexible solution on accessing the guest memory from > qtests, Stefan came with the idea to implement this new qmp command. > > This way, the result can be parsed,

[Qemu-devel] [PATCH v11 08/14] qemu-img: Empty image after commit

2014-08-20 Thread Max Reitz
After the top image has been committed, it should be emptied unless specified otherwise. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 34 +++--- qemu-img.texi| 6 +- 3 files changed, 38 insertions(+), 6

Re: [Qemu-devel] [PATCH 2/6] blkdebug: Implement bdrv_refresh_filename()

2014-08-20 Thread Max Reitz
On 20.08.2014 17:14, Kevin Wolf wrote: Am 18.07.2014 um 20:24 hat Max Reitz geschrieben: Because blkdebug cannot simply create a configuration file, simply refuse to reconstruct a plain filename and only generate an options QDict from the rules instead. Signed-off-by: Max Reitz --- Instead of

Re: [Qemu-devel] [PATCH v10 00/14] qemu-img: Implement commit like QMP

2014-08-20 Thread Max Reitz
On 20.08.2014 13:45, Kevin Wolf wrote: Am 15.08.2014 um 17:22 hat Max Reitz geschrieben: On 22.07.2014 23:29, Max Reitz wrote: qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. For the "commit" command, this i

Re: [Qemu-devel] [PATCH 1/6] block: Add bdrv_refresh_filename()

2014-08-20 Thread Max Reitz
On 20.08.2014 17:07, Kevin Wolf wrote: Am 18.07.2014 um 20:24 hat Max Reitz geschrieben: Some block devices may not have a filename in their BDS; and for some, there may not even be a normal filename at all. To work around this, add a function which tries to construct a valid filename for the BD

Re: [Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-20 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Also removes old "trace-event", "trace-file" and "info trace-events" HMP >>> commands. > >> We gain the ability to control trace via QMP, but lose the ability to >> control it via HMP, correct? > > Right. I can ke

Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted

2014-08-20 Thread Eric Blake
On 08/20/2014 11:07 AM, Markus Armbruster wrote: > Instead of bdrv_getlength(). > > Commit 57322b7 did this all over block, but one more bdrv_getlength() > has crept in since. > > Signed-off-by: Markus Armbruster > --- > block/vmdk.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deleti

Re: [Qemu-devel] [PATCH 1/1] loader: g_realloc(p, 0) frees and returns NULL, simplify

2014-08-20 Thread Eric Blake
On 08/20/2014 12:38 PM, Markus Armbruster wrote: > Once upon a time, it was decided that qemu_realloc(ptr, 0) should > abort. Switching to glib retired that bright idea. A bit of code > that was added to cope with it (commit 3e372cf) is still around. Bury > it. > > See also commit 6528499. > >

[Qemu-devel] [PATCH v11 09/14] qemu-img: Enable progress output for commit

2014-08-20 Thread Max Reitz
Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 24 ++-- qemu-img.texi| 2 +- 3 files changed, 25 insertions(+), 5 deletions(-

[Qemu-devel] [PATCH v11 04/14] blockjob: Introduce block_job_complete_sync()

2014-08-20 Thread Max Reitz
Implement block_job_complete_sync() by doing the exact same thing as block_job_cancel_sync() does, only with calling block_job_complete() instead of block_job_cancel(). Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- blockjob.c | 39 --- in

[Qemu-devel] [PATCH 1/1] loader: g_realloc(p, 0) frees and returns NULL, simplify

2014-08-20 Thread Markus Armbruster
Once upon a time, it was decided that qemu_realloc(ptr, 0) should abort. Switching to glib retired that bright idea. A bit of code that was added to cope with it (commit 3e372cf) is still around. Bury it. See also commit 6528499. Signed-off-by: Markus Armbruster --- include/hw/elf_ops.h | 15

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Eric Blake
On 08/20/2014 08:57 AM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Il 20/08/2014 13:36, Michael S. Tsirkin ha scritto: >>> >>> For pci bridges, unless you set bus_name, bus name will >>> match device itself. See this code: >>> >>> * If we don't specify the name, the bus will be ad

Re: [Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-20 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Also removes old "trace-event", "trace-file" and "info trace-events" HMP >> commands. > We gain the ability to control trace via QMP, but lose the ability to > control it via HMP, correct? Right. I can keep the HMP commands, but doing so req

[Qemu-devel] [PATCH v11 10/14] qemu-img: Specify backing file for commit

2014-08-20 Thread Max Reitz
Introduce a new parameter for qemu-img commit which may be used to explicitly specify the backing file into which an image should be committed if the backing chain has more than a single layer. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 2

[Qemu-devel] [PATCH v11 13/14] iotests: Add test for qcow2's bdrv_make_empty

2014-08-20 Thread Max Reitz
Add a test for qcow2's fast bdrv_make_empty implementation on images without internal snapshots. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/098 | 75 ++ tests/qemu-iotests/098.out | 26 tests/qemu-iote

[Qemu-devel] [PATCH v11 11/14] iotests: Add _filter_qemu_img_map

2014-08-20 Thread Max Reitz
As different image formats most probably map guest addresses to different host addresses, add a filter to filter the host addresses out; also, the image filename should be filtered. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/common.filter | 7 +++ 1 file changed

[Qemu-devel] [PATCH v11 07/14] qemu-img: Implement commit like QMP

2014-08-20 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. As qemu-img itself has no access to QMP (since this would basically require just everything being linked into qemu-img), imitate QMP's implementation of block-comm

[Qemu-devel] [PATCH v11 05/14] blockjob: Add "ready" field

2014-08-20 Thread Max Reitz
When a block job signals readiness, this is currently reported only through QMP. If qemu wants to use block jobs for internal tasks, there needs to be another way to correctly detect when a block job may be completed. For this reason, introduce a bool "ready" which is set when the block job may be

[Qemu-devel] [PATCH v11 03/14] qcow2: Optimize bdrv_make_empty()

2014-08-20 Thread Max Reitz
bdrv_make_empty() is currently only called if the current image represents an external snapshot that has been committed to its base image; it is therefore unlikely to have internal snapshots. In this case, bdrv_make_empty() can be greatly sped up by creating an empty L1 table and dropping all data

[Qemu-devel] [PATCH v11 12/14] iotests: Add test for backing-chain commits

2014-08-20 Thread Max Reitz
Add a test for qemu-img commit on backing chains with more than two images. This test also checks whether the top image is emptied (unless this is prevented by specifying either -d or -b) and does therefore not work for qed and vmdk which requires it to be separate from 020. Signed-off-by: Max Rei

[Qemu-devel] [PATCH v11 02/14] qcow2: Implement bdrv_make_empty()

2014-08-20 Thread Max Reitz
Implement this function by making all clusters in the image file fall through to the backing file (by using the recently extended discard). Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- block/qcow2.c | 27 +++ 1 file changed, 27 insertions

[Qemu-devel] [PATCH v11 14/14] iotests: Omit length/offset test in 040 and 041

2014-08-20 Thread Max Reitz
As the length of a mirror block job no longer directly depends on the size of the block device, drop those checks from this test. Instead, just check whether the final offset equals the block job length. As 041 uses the wait_until_completed function from iotests.py, the same applies there as well

[Qemu-devel] [PATCH v11 06/14] block/mirror: Improve progress report

2014-08-20 Thread Max Reitz
Instead of taking the total length of the block device as the block job's length, use the number of dirty sectors. The progress is now the number of sectors mirrored to the target block device. Note that this may result in the job's length increasing during operation, which is however in fact desir

[Qemu-devel] [PATCH v11 01/14] qcow2: Allow "full" discard

2014-08-20 Thread Max Reitz
Normally, discarded sectors should read back as zero. However, there are cases in which a sector (or rather cluster) should be discarded as if they were never written in the first place, that is, reading them should fall through to the backing file again. Signed-off-by: Max Reitz Reviewed-by: Eri

[Qemu-devel] [PATCH v11 00/14] qemu-img: Implement commit like QMP

2014-08-20 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. For the "commit" command, this is relatively easy, so implement it first (in the hope that indeed others will follow). As qemu-img does not have access to QMP (du

[Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options

2014-08-20 Thread Max Reitz
qcow2 supports more than four options by now, add the new options (overlap check mode and metadata cache size) Signed-off-by: Max Reitz --- qapi/block-core.json | 79 +++- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/qapi/block-cor

[Qemu-devel] [PATCH 1/4] qcow2: Fix leak of QemuOpts in qcow2_open()

2014-08-20 Thread Max Reitz
Currently, the QemuOpts object opts is leaked if anything fails from its creation up to and including the image repair block. Fix this by freeing that object in the fail path. Signed-off-by: Max Reitz --- block/qcow2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/bloc

[Qemu-devel] [PATCH 3/4] qcow2: Add overlap-check.template option

2014-08-20 Thread Max Reitz
Being able to set the overlap-check option to a string and then refine it via the overlap-check.* options is a nice idea for the command line but does not work so well for non-flattened dicts. In that case, one can only specify either but not both, so add a field to overlap-check.* which does the s

[Qemu-devel] [PATCH 2/4] qapi: Allow enums in anonymous unions

2014-08-20 Thread Max Reitz
Signed-off-by: Max Reitz --- scripts/qapi-types.py | 2 ++ scripts/qapi-visit.py | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index b463232..d2f815b 100644 --- a/scripts/qapi-types.py +++ b/scripts/qapi-types.py @@ -177,6 +17

[Qemu-devel] [PATCH 0/4] qapi/block-core: Add "new" qcow2 options

2014-08-20 Thread Max Reitz
This is a follow-up series to my previous series "[PATCH v2 0/4] qcow2: Allow runtime specification of cache sizes" which adds missing qcow2 runtime options to the appropriate structure in qapi/block-core (overlap check mode and metadata cache size). Max Reitz (4): qcow2: Fix leak of QemuOpts i

[Qemu-devel] [RFC] qapi: New command query-mtree

2014-08-20 Thread Marc Marí
Add command query-mtree to get the memory tree of the guest. As we were looking for a flexible solution on accessing the guest memory from qtests, Stefan came with the idea to implement this new qmp command. This way, the result can be parsed, and the RAM direction extracted, so only a generic qt

[Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted

2014-08-20 Thread Markus Armbruster
Instead of bdrv_getlength(). Commit 57322b7 did this all over block, but one more bdrv_getlength() has crept in since. Signed-off-by: Markus Armbruster --- block/vmdk.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 01412a8..3b7

Re: [Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-20 Thread Markus Armbruster
Lluís Vilanova writes: > Also removes old "trace-event", "trace-file" and "info trace-events" HMP > commands. We gain the ability to control trace via QMP, but lose the ability to control it via HMP, correct? > > Signed-off-by: Lluís Vilanova > --- > hmp-commands.hx | 35 ---

[Qemu-devel] [Bug 1359243] Re: [BSOD 0xc000000d] Can't boot windows with qemu

2014-08-20 Thread Paolo Bonzini
Please try with "-cpu core2duo" or "-cpu host". -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1359243 Title: [BSOD 0xc00d] Can't boot windows with qemu Status in QEMU: New Bug description:

Re: [Qemu-devel] [PATCH v5 05/15] target-tricore: Add masks and opcodes for decoding

2014-08-20 Thread Richard Henderson
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: > Add masks and opcodes for decoding TriCore instructions. > > Signed-off-by: Bastian Koppelmann > --- > target-tricore/translate.c |1 + > target-tricore/tricore-opcodes.h | 1406 > ++ > 2 files cha

Re: [Qemu-devel] [PATCH bugfix v1 3/3] qom: object.h: Update object_get_canon_path* doc

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 11:07, Peter Maydell ha scritto: > The other thing you need to say is that the returned string is > only valid for as long as the object remains a child property > of its parent. (Is that right? I'm not clear. It also sounds like > a really awkward lifetime management requirement, whi

Re: [Qemu-devel] [PATCH] aarch64: raise max_cpus to 8

2014-08-20 Thread Peter Maydell
On 20 August 2014 16:08, Joel Schopp wrote: > > On 08/19/2014 05:43 PM, Peter Maydell wrote: >> On 19 August 2014 22:33, Joel Schopp wrote: >>> I'm running on a system with 8 cpus and it would be nice to have qemu >>> support all of them. The attached patch does that and has been tested. >>> >>>

Re: [Qemu-devel] [PATCH v5 04/15] target-tricore: Add initialization for translation and activate target

2014-08-20 Thread Richard Henderson
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: > Add tcg and cpu model initialization. > Add gen_intermediate_code function. > Activate target in configure and add softmmu config. > > Signed-off-by: Bastian Koppelmann > --- > v4 -> v5: > - gen_intermediate_code_internal: Move calculation o

Re: [Qemu-devel] Commit d8d95814609e89e5438a3318a647ec322fc4ff16 seems to break ioh3420

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 16:10, Knut Omang ha scritto: > I am struggling with the latest master and > > -device ioh3420,slot=0,id=pcie_port.0 > > as argument. I bisected it down to: My fault indeed. I just sent a fix and re-reviewed my patch to look for similar breakage (but didn't find any). Paolo

[Qemu-devel] [PATCH] pci_bridge: manually destroy memory regions within PCIBridgeWindows

2014-08-20 Thread Paolo Bonzini
The regions are destroyed and recreated on configuration space accesses. We need to destroy them before the containing PCIBridgeWindows object is freed. Reported-by: Gonglei Reported-by: Knut Omang Signed-off-by: Paolo Bonzini --- hw/pci/pci_bridge.c | 6 ++ 1 file changed, 6 insertions(+)

[Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-20 Thread Lluís Vilanova
Also removes old "trace-event", "trace-file" and "info trace-events" HMP commands. Signed-off-by: Lluís Vilanova --- hmp-commands.hx | 35 --- monitor.c | 61 qapi-schema.json|3 ++ qmp-commands.hx | 27

  1   2   3   >