Re: [Qemu-devel] [PATCH] linux-user: Add binfmt wrapper

2014-07-15 Thread Riku Voipio
On Tue, Jul 15, 2014 at 05:11:48PM +0200, Joakim Tjernlund wrote: > Riku Voipio wrote on 2014/07/15 16:12:26: > > On Mon, Jul 14, 2014 at 05:38:49PM +0200, Joakim Tjernlund wrote: > > > Alexander Graf wrote on 2014/07/14 17:21:33: > > > > On 14.07.14 16:38, Joakim Tjernlund wrote: > > > > > The p

Re: [Qemu-devel] [PATCH v3 1/2] block/quorum: add simple read pattern support

2014-07-15 Thread Liu Yuan
On Tue, Jul 15, 2014 at 06:14:32AM -0600, Eric Blake wrote: > On 07/15/2014 12:34 AM, Liu Yuan wrote: > > This patch adds single read pattern to quorum driver and quorum vote is > > default > > pattern. > > > > For now we do a quorum vote on all the reads, it is designed for unreliable > > underl

Re: [Qemu-devel] [PATCH] cadence_uart: check for serial backend before using it.

2014-07-15 Thread Peter Crosthwaite
On Wed, Jul 16, 2014 at 1:18 AM, wrote: > From: KONRAD Frederic > > This checks that s->chr is not NULL before using it. > > Signed-off-by: KONRAD Frederic > --- > hw/char/cadence_uart.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/hw/char/cadence_u

Re: [Qemu-devel] [PATCH v3 2/2] qapi: add read-pattern support for quorum

2014-07-15 Thread Liu Yuan
On Wed, Jul 16, 2014 at 10:22:20AM +0800, Liu Yuan wrote: > On Tue, Jul 15, 2014 at 06:22:14AM -0600, Eric Blake wrote: > > On 07/15/2014 12:34 AM, Liu Yuan wrote: > > > Cc: Eric Blake > > > Signed-off-by: Liu Yuan > > > --- > > > qapi/block-core.json | 19 ++- > > > 1 file chang

Re: [Qemu-devel] [PATCH v3 2/2] qapi: add read-pattern support for quorum

2014-07-15 Thread Liu Yuan
On Tue, Jul 15, 2014 at 06:22:14AM -0600, Eric Blake wrote: > On 07/15/2014 12:34 AM, Liu Yuan wrote: > > Cc: Eric Blake > > Signed-off-by: Liu Yuan > > --- > > qapi/block-core.json | 19 ++- > > 1 file changed, 18 insertions(+), 1 deletion(-) > > > > diff --git a/qapi/block-cor

Re: [Qemu-devel] [PATCH v12 3/4] headers: Update kernel header

2014-07-15 Thread Gavin Shan
On Wed, Jul 16, 2014 at 11:32:13AM +1000, Alexey Kardashevskiy wrote: >On 07/16/2014 11:16 AM, Gavin Shan wrote: >> On Wed, Jul 16, 2014 at 11:09:44AM +1000, Alexey Kardashevskiy wrote: >>> On 07/16/2014 10:20 AM, Gavin Shan wrote: This updates kernel header (vfio.h) for EEH support on VFIO PC

Re: [Qemu-devel] [PATCH v12 3/4] headers: Update kernel header

2014-07-15 Thread Alexey Kardashevskiy
On 07/16/2014 11:16 AM, Gavin Shan wrote: > On Wed, Jul 16, 2014 at 11:09:44AM +1000, Alexey Kardashevskiy wrote: >> On 07/16/2014 10:20 AM, Gavin Shan wrote: >>> This updates kernel header (vfio.h) for EEH support on VFIO PCI >>> devices. >> >> Has this reached kernel upstream? The way linux heade

Re: [Qemu-devel] [PATCH v12 2/4] sPAPR: Implement EEH RTAS calls

2014-07-15 Thread Alexey Kardashevskiy
On 07/16/2014 11:12 AM, Gavin Shan wrote: > On Wed, Jul 16, 2014 at 11:06:21AM +1000, Alexey Kardashevskiy wrote: >> On 07/16/2014 10:20 AM, Gavin Shan wrote: >>> The emulation for EEH RTAS requests from guest isn't covered >>> by QEMU yet and the patch implements them. >>> >>> The patch defines co

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-15 Thread Marcelo Tosatti
On Wed, Jul 16, 2014 at 03:40:47AM +0400, Andrey Korolyov wrote: > On Wed, Jul 16, 2014 at 2:01 AM, Paolo Bonzini wrote: > > Il 15/07/2014 23:25, Andrey Korolyov ha scritto: > > > >> On Wed, Jul 16, 2014 at 1:09 AM, Marcelo Tosatti > >> wrote: > >>> > >>> On Tue, Jul 15, 2014 at 06:01:08PM +0400,

Re: [Qemu-devel] [PATCH v12 3/4] headers: Update kernel header

2014-07-15 Thread Gavin Shan
On Wed, Jul 16, 2014 at 11:09:44AM +1000, Alexey Kardashevskiy wrote: >On 07/16/2014 10:20 AM, Gavin Shan wrote: >> This updates kernel header (vfio.h) for EEH support on VFIO PCI >> devices. > >Has this reached kernel upstream? The way linux headers update normally >happens is you have to run scri

Re: [Qemu-devel] [PATCH v12 2/4] sPAPR: Implement EEH RTAS calls

2014-07-15 Thread Gavin Shan
On Wed, Jul 16, 2014 at 11:06:21AM +1000, Alexey Kardashevskiy wrote: >On 07/16/2014 10:20 AM, Gavin Shan wrote: >> The emulation for EEH RTAS requests from guest isn't covered >> by QEMU yet and the patch implements them. >> >> The patch defines constants used by EEH RTAS calls and adds >> callba

Re: [Qemu-devel] [PATCH v12 3/4] headers: Update kernel header

2014-07-15 Thread Alexey Kardashevskiy
On 07/16/2014 10:20 AM, Gavin Shan wrote: > This updates kernel header (vfio.h) for EEH support on VFIO PCI > devices. Has this reached kernel upstream? The way linux headers update normally happens is you have to run scripts/update-linux-headers.sh against some linux kernel tag which you know tha

Re: [Qemu-devel] [PATCH v12 2/4] sPAPR: Implement EEH RTAS calls

2014-07-15 Thread Alexey Kardashevskiy
On 07/16/2014 10:20 AM, Gavin Shan wrote: > The emulation for EEH RTAS requests from guest isn't covered > by QEMU yet and the patch implements them. > > The patch defines constants used by EEH RTAS calls and adds > callback sPAPRPHBClass::eeh_handler, which is going to be used > this way: > >

[Qemu-devel] [ANNOUNCE] QEMU 2.1.0-rc2 is now available

2014-07-15 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 2.1 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.1.0-rc2.tar.bz2 You can help im

[Qemu-devel] [PATCH v12 4/4] sPAPR: Implement sPAPRPHBClass::eeh_handler

2014-07-15 Thread Gavin Shan
The patch implements sPAPRPHBClass::eeh_handler so that the EEH RTAS requests can be routed to VFIO for further handling. Signed-off-by: Gavin Shan --- hw/misc/vfio.c | 1 + hw/ppc/spapr_pci_vfio.c | 56 + 2 files changed, 57 insertions(+

[Qemu-devel] [PATCH v12 3/4] headers: Update kernel header

2014-07-15 Thread Gavin Shan
This updates kernel header (vfio.h) for EEH support on VFIO PCI devices. Signed-off-by: Gavin Shan --- linux-headers/linux/vfio.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index 26c218e..95b591b

[Qemu-devel] [PATCH v12 1/4] spapr_pci: Make find_phb()/find_dev() public

2014-07-15 Thread Gavin Shan
From: Alexey Kardashevskiy This makes find_phb()/find_dev() public and changed its names to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to be used from other parts of QEMU such as VFIO DDW (dynamic DMA window) or VFIO PCI error injection or VFIO EEH handling - in all these cases t

[Qemu-devel] [PATCH v12 0/4] EEH Support for VFIO Devices

2014-07-15 Thread Gavin Shan
The series of patches adds support EEH for VFIO PCI devices on sPAPR platform. It requires corresponding host kernel support. It has been rebased to Alex Graf's QEMU repository: QEMU: git://github.com/agraf/qemu.git (branch: ppc-next) Kernel: http://patchwork.ozlabs.org/patch/357665/ ht

[Qemu-devel] [PATCH v12 2/4] sPAPR: Implement EEH RTAS calls

2014-07-15 Thread Gavin Shan
The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls and adds callback sPAPRPHBClass::eeh_handler, which is going to be used this way: * RTAS calls are received in spapr_pci.c, sanity check is

Re: [Qemu-devel] [PATCH v3 for-2.1 1/1] virtio-serial-bus: keep port 0 reserved for virtconsole even on unplug

2014-07-15 Thread Amos Kong
On Tue, Jul 15, 2014 at 03:31:32PM +0530, Amit Shah wrote: > We keep port 0 reserved for compat with older guests, where only > virtio-console was expected. Even if a system is started without a > virtio-console port, port #0 is kept aside. However, after a > virtconsole port is unplugged, port i

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-15 Thread Marcelo Tosatti
On Wed, Jul 16, 2014 at 03:40:47AM +0400, Andrey Korolyov wrote: > On Wed, Jul 16, 2014 at 2:01 AM, Paolo Bonzini wrote: > > Il 15/07/2014 23:25, Andrey Korolyov ha scritto: > > > >> On Wed, Jul 16, 2014 at 1:09 AM, Marcelo Tosatti > >> wrote: > >>> > >>> On Tue, Jul 15, 2014 at 06:01:08PM +0400,

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-15 Thread Andrey Korolyov
On Wed, Jul 16, 2014 at 2:01 AM, Paolo Bonzini wrote: > Il 15/07/2014 23:25, Andrey Korolyov ha scritto: > >> On Wed, Jul 16, 2014 at 1:09 AM, Marcelo Tosatti >> wrote: >>> >>> On Tue, Jul 15, 2014 at 06:01:08PM +0400, Andrey Korolyov wrote: On Tue, Jul 15, 2014 at 10:52 AM, Andrey Koro

Re: [Qemu-devel] can't boot debian wheezy sparc in qemu

2014-07-15 Thread Mark Cave-Ayland
On 14/07/14 19:19, Dennis Luehring wrote: i've followed the avices on Artyom Tarasenko's blog to install debian wheezy sparc on qemu but qemu won't boot the graphical installation with -nographic the debian default installation seems to work is this a known bug? these are my installation step

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 23:25, Andrey Korolyov ha scritto: On Wed, Jul 16, 2014 at 1:09 AM, Marcelo Tosatti wrote: On Tue, Jul 15, 2014 at 06:01:08PM +0400, Andrey Korolyov wrote: On Tue, Jul 15, 2014 at 10:52 AM, Andrey Korolyov wrote: On Tue, Jul 15, 2014 at 9:03 AM, Amit Shah wrote: On (Sun) 13 J

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-15 Thread Andrey Korolyov
On Wed, Jul 16, 2014 at 1:09 AM, Marcelo Tosatti wrote: > On Tue, Jul 15, 2014 at 06:01:08PM +0400, Andrey Korolyov wrote: >> On Tue, Jul 15, 2014 at 10:52 AM, Andrey Korolyov wrote: >> > On Tue, Jul 15, 2014 at 9:03 AM, Amit Shah wrote: >> >> On (Sun) 13 Jul 2014 [16:28:56], Andrey Korolyov wro

Re: [Qemu-devel] [PATCH v2] scsi-bus: fix to allow some special SCSI commands

2014-07-15 Thread TAMUKI Shoichi
Hello, From: Paolo Bonzini Subject: Re: [PATCH v2] scsi-bus: fix to allow some special SCSI commands Date: Tue, 15 Jul 2014 19:05:25 +0200 > > Currently, some special SCSI commands sent from the initiator in a > > guest do not reach the target device. To avoid this, extended (0x7e,) > > variabl

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-15 Thread Marcelo Tosatti
On Tue, Jul 15, 2014 at 06:01:08PM +0400, Andrey Korolyov wrote: > On Tue, Jul 15, 2014 at 10:52 AM, Andrey Korolyov wrote: > > On Tue, Jul 15, 2014 at 9:03 AM, Amit Shah wrote: > >> On (Sun) 13 Jul 2014 [16:28:56], Andrey Korolyov wrote: > >>> Hello, > >>> > >>> the issue is not specific to the

Re: [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 23:05, Andrey Korolyov ha scritto: On Wed, Jul 16, 2014 at 12:43 AM, Paolo Bonzini wrote: Il 15/07/2014 22:34, Marcelo Tosatti ha scritto: The backtrace in the following message is for a different problem, correct? http://www.mail-archive.com/qemu-devel@nongnu.org/msg246161.htm

Re: [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation

2014-07-15 Thread Andrey Korolyov
On Wed, Jul 16, 2014 at 12:43 AM, Paolo Bonzini wrote: > Il 15/07/2014 22:34, Marcelo Tosatti ha scritto: > >> The backtrace in the following message is for a different problem, >> correct? >> >> http://www.mail-archive.com/qemu-devel@nongnu.org/msg246161.html >> >> >> > > Correct. > > Paolo Sorr

Re: [Qemu-devel] Current State of Block Filter

2014-07-15 Thread Benoît Canet
The Tuesday 15 Jul 2014 à 10:49:31 (-0400), Wolfgang Richter wrote : > The way I see block filter currently implemented is as a special block > device > with `is_filter` set to true. > > Is this a correct characterization of the current incarnation? Yes, > > If so, I was wondering if it is poss

Re: [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 22:34, Marcelo Tosatti ha scritto: The backtrace in the following message is for a different problem, correct? http://www.mail-archive.com/qemu-devel@nongnu.org/msg246161.html Correct. Paolo

Re: [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 22:31, Marcelo Tosatti ha scritto: > This patch (or some form of updating env->tsc, see changelog) > is necessary. Yes, I was going to revert Alex's too. > I was just about to reproduce it. > > Andrey, can you please provide the qemu command line ? > > Can you attempt to start VM

Re: [Qemu-devel] [PATCH v2 3/3] trace: instrument and trace tcg tb flush activity

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 22:29, Peter Maydell ha scritto: > > I think it's not a big deal if you always enable the counting, and perhaps > show them in "info jit". We don't enable any other tracepoints by default; why would we want to enable just this one which is in a hot codepath?? I'm not referring to

Re: [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation

2014-07-15 Thread Marcelo Tosatti
On Tue, Jul 15, 2014 at 05:31:22PM -0300, Marcelo Tosatti wrote: > On Tue, Jul 15, 2014 at 10:15:14PM +0200, Paolo Bonzini wrote: > > Il 15/07/2014 22:03, Marcin Gibuła ha scritto: > > >>This causes a hang during migration, so I'll revert the patch from 2.1. > > > > > >For me this patch series fixe

Re: [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation

2014-07-15 Thread Marcelo Tosatti
On Tue, Jul 15, 2014 at 10:15:14PM +0200, Paolo Bonzini wrote: > Il 15/07/2014 22:03, Marcin Gibuła ha scritto: > >>This causes a hang during migration, so I'll revert the patch from 2.1. > > > >For me this patch series fixed all hangs I had with migration (at least > >with qemu 2.0). > > Unfortun

Re: [Qemu-devel] [PATCH] tests/Makefile: Only run vhost-user-test on Linux

2014-07-15 Thread Peter Maydell
On 15 July 2014 21:15, Paolo Bonzini wrote: > Il 15/07/2014 19:35, Peter Maydell ha scritto: > >> vhost-user-test uses the linux/vhost.h header, so it must only be >> enabled if CONFIG_LINUX is defined. (Previously it was enabled >> for CONFIG_POSIX, which broke 'make check' on MacOSX.) >> >> Sign

Re: [Qemu-devel] [PATCH v2 3/3] trace: instrument and trace tcg tb flush activity

2014-07-15 Thread Peter Maydell
On 15 July 2014 21:11, Paolo Bonzini wrote: > Il 15/07/2014 16:16, Alex Bennée ha scritto: > >>> > I think this is premature optimization... >> >> How do you mean? It's not really an optimization as much as an >> instrumentation. It should compile away to nothing if you don't have >> tracing enabl

Re: [Qemu-devel] [PATCH] tests/Makefile: Only run vhost-user-test on Linux

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 19:35, Peter Maydell ha scritto: vhost-user-test uses the linux/vhost.h header, so it must only be enabled if CONFIG_LINUX is defined. (Previously it was enabled for CONFIG_POSIX, which broke 'make check' on MacOSX.) Signed-off-by: Peter Maydell --- I'm going to commit this for th

Re: [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 22:03, Marcin Gibuła ha scritto: This causes a hang during migration, so I'll revert the patch from 2.1. For me this patch series fixed all hangs I had with migration (at least with qemu 2.0). Unfortunately, someone else bisected their hangs exactly to this patch: http://permal

Re: [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock

2014-07-15 Thread Marcin Gibuła
W dniu 2014-07-15 17:17, Paolo Bonzini pisze: Il 15/07/2014 16:44, Stefan Hajnoczi ha scritto: v2: * Leave BH scheduled so that the code can be simplified [Paolo] These patches convert thread-pool.c from EventNotifier to QEMUBH. They then solve the deadlock when nested aio_poll() calls are mad

Re: [Qemu-devel] qemu qmp [info usb] and [info hostusb]

2014-07-15 Thread Pascal Heinrich
The only problem I have is to get already bind device id's so I can unbind them. I do not find a qmp command where the binded usb devices show up. With query-pci I do not get all devices. I implemented a new command "query-usb" and copied the logic from hw/usb/bus.c But it seems that the QTAILQ

Re: [Qemu-devel] [PATCH v2 3/3] trace: instrument and trace tcg tb flush activity

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 16:16, Alex Bennée ha scritto: > I think this is premature optimization... How do you mean? It's not really an optimization as much as an instrumentation. It should compile away to nothing if you don't have tracing enabled in your build. I think it's not a big deal if you always

Re: [Qemu-devel] hw/arm: add Lego NXT board

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 20:55, Alexander Graf ha scritto: 3. I do not circumvent the GPL! The whole software in the loop simulator is itself GPL Software. The reason I emulate the sensor values outside of qemu is simple. This is exactly what happens in the real world. The MCU or even the sensors do not k

Re: [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation

2014-07-15 Thread Marcin Gibuła
@@ -65,6 +66,7 @@ static uint64_t kvmclock_current_nsec(KVMClockState *s) cpu_physical_memory_read(kvmclock_struct_pa, &time, sizeof(time)); +assert(time.tsc_timestamp <= migration_tsc); delta = migration_tsc - time.tsc_timestamp; if (time.tsc_shift < 0) { delta >>= -

Re: [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation

2014-07-15 Thread Paolo Bonzini
Il 03/06/2014 18:34, Marcelo Tosatti ha scritto: Ensure proper env->tsc value for kvmclock_current_nsec calculation. Reported-by: Marcin Gibuła Signed-off-by: Marcelo Tosatti diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index 6f4ed28a..bef2504 100644 --- a/hw/i386/kvm/clock.c +++ b

Re: [Qemu-devel] [PATCH v2] kvmclock: Ensure time in migration never goes backward

2014-07-15 Thread Paolo Bonzini
Il 16/05/2014 17:15, Alexander Graf ha scritto: When we migrate we ask the kernel about its current belief on what the guest time would be. However, I've seen cases where the kvmclock guest structure indicates a time more recent than the kvm returned time. To make sure we never go backwards, cal

Re: [Qemu-devel] [PATCH 136/156] kvmclock: Ensure time in migration never goes backward

2014-07-15 Thread Paolo Bonzini
Il 08/07/2014 19:18, Michael Roth ha scritto: From: Alexander Graf When we migrate we ask the kernel about its current belief on what the guest time would be. However, I've seen cases where the kvmclock guest structure indicates a time more recent than the kvm returned time. To make sure we ne

Re: [Qemu-devel] hw/arm: add Lego NXT board

2014-07-15 Thread Alexander Graf
On 07/15/2014 12:48 AM, Peter Maydell wrote: > Right, but this is an optional part of Paolo's proposal as I understand > it. You could just have your fake sensors be implemented by some > userspace process on the other end of a filedescriptor, as you do now > but with i2c rather than custom protoco

Re: [Qemu-devel] hw/arm: add Lego NXT board

2014-07-15 Thread Alexander Graf
On 07/15/2014 12:53 PM, Paolo Bonzini wrote: Il 15/07/2014 12:26, Alexander Graf ha scritto: Thanks for the idea. I still don't get why it should be better to fake an I2C device rather than a universal memory IO. Because this would not be fake, the idea was to emulate the actual sensor/actuato

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-07-15 Thread Mike Lowe
I need to amend comment #39, moving from 3.13.0-30 to 3.13.0-27 did not eliminate the problem. It would seem that it takes a couple of hours following a reboot for the symptoms to manifest with 3.13.0-27. -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH for-2.1 0/2] Module cleanups

2014-07-15 Thread Peter Maydell
On 15 July 2014 15:04, Andreas Färber wrote: > This mini-series resolves an error message emitted when a module is absent. > It was prompted by a downstream user bug report about the new message. > > Proposing this for rc2 as Peter would like to keep the rc3 delta low. > > Regards, > Andreas > > A

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-15 Thread Andrey Korolyov
On Tue, Jul 15, 2014 at 9:32 PM, Andrey Korolyov wrote: > On Tue, Jul 15, 2014 at 7:57 PM, Paolo Bonzini wrote: >> Il 13/07/2014 17:29, Andrey Korolyov ha scritto: >> >>> Small follow-up: issue have probabilistic nature, as it looks - by >>> limited number of runs, it is reproducible within three

[Qemu-devel] [PATCH] tests/Makefile: Only run vhost-user-test on Linux

2014-07-15 Thread Peter Maydell
vhost-user-test uses the linux/vhost.h header, so it must only be enabled if CONFIG_LINUX is defined. (Previously it was enabled for CONFIG_POSIX, which broke 'make check' on MacOSX.) Signed-off-by: Peter Maydell --- I'm going to commit this for the 2.1-rc2 tag I'm about to do, since it's such a

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-15 Thread Andrey Korolyov
On Tue, Jul 15, 2014 at 7:57 PM, Paolo Bonzini wrote: > Il 13/07/2014 17:29, Andrey Korolyov ha scritto: > >> Small follow-up: issue have probabilistic nature, as it looks - by >> limited number of runs, it is reproducible within three cases: >> 1) live migration went well, I/O locked up, >> 2)

Re: [Qemu-devel] [PULL 01/12] qtest: enable vhost-user-test

2014-07-15 Thread Peter Maydell
On 7 July 2014 13:40, Michael S. Tsirkin wrote: > From: Nikolay Nikolaev > > Use qtest-obj-y to get the right library order. CONFIG_POSIX ensures > mingw compilation won't break. > > Signed-off-by: Nikolay Nikolaev > Acked-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > > MST: whi

Re: [Qemu-devel] [PULL for-2.1 0/5] linux-user fixes for 2.1

2014-07-15 Thread Peter Maydell
On 15 July 2014 15:24, wrote: > From: Riku Voipio > > The following changes since commit 0a9934eef166836c8100fce72f7f837cb8b2ed2b: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2014-07-14 17:01:45 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH v2] scsi-bus: fix to allow some special SCSI commands

2014-07-15 Thread Paolo Bonzini
Il 12/07/2014 12:21, TAMUKI Shoichi ha scritto: Currently, some special SCSI commands sent from the initiator in a guest do not reach the target device. To avoid this, extended (0x7e,) variable length (0x7f,) and vendor specific (0xc0..0xff) opcodes are now treated as valid CDBs. Originally, th

Re: [Qemu-devel] [PATCH v2 15/15] target-tricore: Add instructions of SR opcode format

2014-07-15 Thread Richard Henderson
On 07/14/2014 10:41 AM, Bastian Koppelmann wrote: > +static bool cdc_zero(target_ulong *psw) > +{ > +int cdc = *psw & MASK_PSW_CDC; > +/* Returns TRUE if PSW.CDC.COUNT == 0 or if PSW.CDC == > + 7'b111, otherwise returns FALSE. */ > +if (cdc == 0x7f) { > +return true; >

Re: [Qemu-devel] [PATCH v2 14/15] target-tricore: Add instructions of SLR, SSRO and SRO opcode format

2014-07-15 Thread Richard Henderson
On 07/14/2014 10:41 AM, Bastian Koppelmann wrote: > Add instructions of SLR, SSRO and SRO opcode format. > > Signed-off-by: Bastian Koppelmann > --- > v1 -> v2: > - Add one decode function for all SLR instructions. > - Add one decode function for all SRO instructions. > - Remove dupli

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-15 Thread Paolo Bonzini
Il 13/07/2014 17:29, Andrey Korolyov ha scritto: Small follow-up: issue have probabilistic nature, as it looks - by limited number of runs, it is reproducible within three cases: 1) live migration went well, I/O locked up, 2) live migration failed by timeout, I/O locked up, 3) live migration w

Re: [Qemu-devel] [PATCH v2 13/15] target-tricore: Add instructions of SC opcode format

2014-07-15 Thread Richard Henderson
On 07/14/2014 10:41 AM, Bastian Koppelmann wrote: > Add instructions of SC opcode format. > Add helper for begin interrupt service routine. > > Signed-off-by: Bastian Koppelmann > --- > v1 -> v2: > - Add save_context_lower. (see patch v2 10/15) > - Remove printfs in helper_bisr. > - A

Re: [Qemu-devel] [PATCH v2 12/15] target-tricore: Add instructions of SBR opcode format

2014-07-15 Thread Richard Henderson
On 07/14/2014 10:41 AM, Bastian Koppelmann wrote: > Add instructions of SBR opcode format. > Add gen_loop micro-op generator function. > > Signed-off-by: Bastian Koppelmann > --- > v1 -> v2: > - Change gen_loop() to subtract first and then compare to -1. > - Change gen_loop() using next_p

Re: [Qemu-devel] [PULL 2.1 0/5] ppc patch queue 2014-07-15

2014-07-15 Thread Peter Maydell
On 15 July 2014 15:15, Alexander Graf wrote: > Hi Peter, > > This is my current patch queue for ppc for 2.1. Please pull. > > Alex > > > The following changes since commit 0e16297461264b3ea8f7282d1195cf53aa8a707c: > > libqos: Fix PC PCI endianness glitches (2014-07-15 14:18:15 +0100) > > are av

Re: [Qemu-devel] [PATCH for-2.1 0/2] Module cleanups

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 17:39, Fam Zheng ha scritto: On Tue, 07/15 16:04, Andreas Färber wrote: Hello, This mini-series resolves an error message emitted when a module is absent. It was prompted by a downstream user bug report about the new message. Proposing this for rc2 as Peter would like to keep the

Re: [Qemu-devel] [PATCH v2 06/15] target-tricore: Add instructions of SRC opcode format

2014-07-15 Thread Richard Henderson
On 07/15/2014 06:19 AM, Bastian Koppelmann wrote: > >>> +tcg_gen_addi_tl(cpu_gpr_d[r1], cpu_gpr_d[r1], const4); >> Are you planning to come back to implement V and AV bits later? > Would you recommend implementing this as a helper? It seems rather complex. > Especially with half-word and b

Re: [Qemu-devel] [PATCH for-2.1 0/2] Module cleanups

2014-07-15 Thread Fam Zheng
On Tue, 07/15 16:04, Andreas Färber wrote: > Hello, > > This mini-series resolves an error message emitted when a module is absent. > It was prompted by a downstream user bug report about the new message. > > Proposing this for rc2 as Peter would like to keep the rc3 delta low. > > Regards, > An

Re: [Qemu-devel] [PATCH v2 11/15] target-tricore: Add instructions of SBC and SBRN opcode format

2014-07-15 Thread Richard Henderson
On 07/14/2014 10:41 AM, Bastian Koppelmann wrote: > Add instructions of SBC and SBRN opcode format. > > Signed-off-by: Bastian Koppelmann > --- > v1 -> v2: > - Change compare to 0 at instructions JZ_T and JNZ_T. > - Group SBC instructions to one case. > - Group SBRN instructions to on

Re: [Qemu-devel] [PATCH v2 10/15] target-tricore: Add instructions of SB opcode format

2014-07-15 Thread Richard Henderson
On 07/14/2014 10:41 AM, Bastian Koppelmann wrote: > +static void gen_compute_branch(DisasContext *ctx, uint32_t opc, > + int r1, int r2 , int32_t constant , int32_t offset) > +{ > + > +switch (opc) { Watch whitespace, both vertical and horizontal here. > +/* SB-format jumps

Re: [Qemu-devel] [PATCH v2 2/2] thread-pool: avoid deadlock in nested aio_poll() calls

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 16:44, Stefan Hajnoczi ha scritto: The thread pool has a race condition if two elements complete before thread_pool_completion_bh() runs: If element A's callback waits for element B using aio_poll() it will deadlock since pool->completion_bh is not marked scheduled when the n

Re: [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 16:44, Stefan Hajnoczi ha scritto: v2: * Leave BH scheduled so that the code can be simplified [Paolo] These patches convert thread-pool.c from EventNotifier to QEMUBH. They then solve the deadlock when nested aio_poll() calls are made. Please speak out whether you want this in

[Qemu-devel] [PATCH] cadence_uart: check for serial backend before using it.

2014-07-15 Thread fred . konrad
From: KONRAD Frederic This checks that s->chr is not NULL before using it. Signed-off-by: KONRAD Frederic --- hw/char/cadence_uart.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c index dbbc167..a5736cb 10064

Re: [Qemu-devel] [PATCH v2 09/15] target-tricore: Add instructions of SRRS and SLRO opcode format

2014-07-15 Thread Richard Henderson
On 07/14/2014 10:41 AM, Bastian Koppelmann wrote: > Add instructions of SSRS and SLRO opcode format. > Add micro-op generator functions for offset loads. > > Signed-off-by: Bastian Koppelmann > --- > v1 -> v2: > - Replace OP_MEM_INDIRECT with gen_offset_ld/st functions using TCGMemOp. > -

Re: [Qemu-devel] [PATCH for-2.1? 2/2] thread-pool: avoid deadlock in nested aio_poll() calls

2014-07-15 Thread Paolo Bonzini
Il 15/07/2014 16:37, Stefan Hajnoczi ha scritto: > This is of course missing here: > >break; Let's keep goto restart so we don't use the BH for each completion callback. We just need the BH scheduled once to protect against the deadlock. Ah, I missed this remark. Then you could a

Re: [Qemu-devel] [PATCH v2 08/15] target-tricore: Add instructions of SSR opcode format

2014-07-15 Thread Richard Henderson
On 07/14/2014 10:41 AM, Bastian Koppelmann wrote: > Add instructions of SSR opcode format. > > Signed-off-by: Bastian Koppelmann > --- > v1 -> v2: > - Remove AND in ST_B and ST_H instructions. > - Load/Store instructions now use new TCGMemOp. > - Move SSR instructions to one decode fu

Re: [Qemu-devel] [PATCH] linux-user: Add binfmt wrapper

2014-07-15 Thread Joakim Tjernlund
Riku Voipio wrote on 2014/07/15 16:12:26: > On Mon, Jul 14, 2014 at 05:38:49PM +0200, Joakim Tjernlund wrote: > > Alexander Graf wrote on 2014/07/14 17:21:33: > > > On 14.07.14 16:38, Joakim Tjernlund wrote: > > > > The popular binfmt-wrapper patch adds an additional > > > > executable which mang

Re: [Qemu-devel] [PATCH v2 07/15] target-tricore: Add instructions of SRR opcode format

2014-07-15 Thread Richard Henderson
On 07/14/2014 10:41 AM, Bastian Koppelmann wrote: > +if ((arg & 0x8000) | (arg & 0x4000)) { \ > +env->PSW |= MASK_USB_AV;\ > +env->PSW |= MASK_USB_SAV; \ > +} else {\ > +env->PSW &

Re: [Qemu-devel] [PATCH v7 1/4] cpus: Define callback for QEMU "nmi" command

2014-07-15 Thread Peter Maydell
On 15 July 2014 15:50, Eric Blake wrote: > On 06/12/2014 09:36 PM, Alexey Kardashevskiy wrote: >> This introduces an NMI (Non Maskable Interrupt) interface with >> a single nmi_monitor_handler() method. A machine or a device can >> implement it. This searches for an QOM object with this interface

Re: [Qemu-devel] [PATCH] Tap: fix vcpu long time io blocking on tap

2014-07-15 Thread Stefan Hajnoczi
On Mon, Jul 14, 2014 at 10:44:58AM +, Wangkai (Kevin,C) wrote: > Here the detail network: > > ++ > | The host add tap1 and eth10 to bridge 'br1'| ++ > | ++ | | s

[Qemu-devel] [PATCH v2 2/2] thread-pool: avoid deadlock in nested aio_poll() calls

2014-07-15 Thread Stefan Hajnoczi
The thread pool has a race condition if two elements complete before thread_pool_completion_bh() runs: If element A's callback waits for element B using aio_poll() it will deadlock since pool->completion_bh is not marked scheduled when the nested aio_poll() runs. Fix this by marking the BH

Re: [Qemu-devel] [PATCH v7 1/4] cpus: Define callback for QEMU "nmi" command

2014-07-15 Thread Eric Blake
On 06/12/2014 09:36 PM, Alexey Kardashevskiy wrote: > This introduces an NMI (Non Maskable Interrupt) interface with > a single nmi_monitor_handler() method. A machine or a device can > implement it. This searches for an QOM object with this interface > and if it is implemented, calls it. The callb

Re: [Qemu-devel] [PULL for-2.1 0/3] Block patches

2014-07-15 Thread Peter Maydell
On 15 July 2014 14:55, Stefan Hajnoczi wrote: > The following changes since commit 7a6d04e73fdd571234e05dcad96895fafb3f22f0: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2014-07-14 13:09:29 +0100) > > are available in the git repository at: > > > git://gi

[Qemu-devel] Current State of Block Filter

2014-07-15 Thread Wolfgang Richter
The way I see block filter currently implemented is as a special block device with `is_filter` set to true. Is this a correct characterization of the current incarnation? If so, I was wondering if it is possible to "insert" a block filter layer on top of an existing block device once QEMU is exec

[Qemu-devel] [PATCH v2 1/2] thread-pool: avoid per-thread-pool EventNotifier

2014-07-15 Thread Stefan Hajnoczi
EventNotifier is implemented using an eventfd or pipe. It therefore consumes file descriptors, which can be limited by rlimits and should therefore be used sparingly. Switch from EventNotifier to QEMUBH in thread-pool.c. Originally EventNotifier was used because qemu_bh_schedule() was not thread

[Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock

2014-07-15 Thread Stefan Hajnoczi
v2: * Leave BH scheduled so that the code can be simplified [Paolo] These patches convert thread-pool.c from EventNotifier to QEMUBH. They then solve the deadlock when nested aio_poll() calls are made. Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of the nested aio_p

Re: [Qemu-devel] [PATCH] linux-user: Add binfmt wrapper

2014-07-15 Thread Joakim Tjernlund
Riku Voipio wrote on 2014/07/15 16:12:26: > > On Mon, Jul 14, 2014 at 05:38:49PM +0200, Joakim Tjernlund wrote: > > Alexander Graf wrote on 2014/07/14 17:21:33: > > > On 14.07.14 16:38, Joakim Tjernlund wrote: > > > > The popular binfmt-wrapper patch adds an additional > > > > executable which m

Re: [Qemu-devel] [PATCH for-2.1? 2/2] thread-pool: avoid deadlock in nested aio_poll() calls

2014-07-15 Thread Stefan Hajnoczi
On Mon, Jul 14, 2014 at 12:49:38PM +0200, Paolo Bonzini wrote: > Il 14/07/2014 10:36, Paolo Bonzini ha scritto: > > > > > >to > > > >/* In case elem->common.cb() makes a nested aio_poll() call, > > * next may become invalid as well. Instead of just > > * restart

[Qemu-devel] [PULL for-2.1 5/5] linux-user: use TARGET_SA_ONSTACK in get_sigframe

2014-07-15 Thread riku . voipio
From: Riku Voipio As reported by Laurent, which should use TARGET_SA_ONSTACK on arm, microblaze and openrisc targets like we do on all others. Practical matter is minimal as for almost all archs SA_ONSTACK is 0x0800: http://lxr.free-electrons.com/ident?i=SA_ONSTACK Reported-by: Laurent Desn

[Qemu-devel] [PULL for-2.1 2/5] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-15 Thread riku . voipio
From: Joakim Tjernlund Signed-off-by: Joakim Tjernlund Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5a272d3..dcf1323 100644 --- a/linux-

[Qemu-devel] [PULL for-2.1 4/5] alloca one extra byte sockets

2014-07-15 Thread riku . voipio
From: Joakim Tjernlund target_to_host_sockaddr() may increase the lenth with 1 byte for AF_UNIX sockets so allocate 1 extra byte. Signed-off-by: Joakim Tjernlund Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 6 +++--- 1 file changed, 3 insertions(+), 3 dele

[Qemu-devel] [PULL for-2.1 3/5] linux-user: handle AF_PACKET sockaddrs in target_to_host_sockaddr

2014-07-15 Thread riku . voipio
From: Joakim Tjernlund Implement conversion of the AF_PACKET sockaddr subtype in target_to_host_sockaddr. Signed-off-by: Joakim Tjernlund Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 7 +++ linux-user/syscall_defs.h | 10 ++ 2 files chang

[Qemu-devel] [PULL for-2.1 1/5] SIOCGIFINDEX: fix typo

2014-07-15 Thread riku . voipio
From: Joakim Tjernlund Wrong type was used in ioctl definition. Signed-off-by: Joakim Tjernlund Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/ioctls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index 07

[Qemu-devel] [PULL for-2.1 0/5] linux-user fixes for 2.1

2014-07-15 Thread riku . voipio
From: Riku Voipio The following changes since commit 0a9934eef166836c8100fce72f7f837cb8b2ed2b: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-07-14 17:01:45 +0100) are available in the git repository at: git://git.linaro.org/people/riku.voipio/qemu.gi

Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly

2014-07-15 Thread Stefan Hajnoczi
On Mon, Jul 14, 2014 at 11:06:08AM +0800, Hu Tao wrote: > On Sat, Jul 12, 2014 at 11:17:40AM +0800, Liu Yuan wrote: > > Cc: Kevin Wolf > > Signed-off-by: Liu Yuan > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index

Re: [Qemu-devel] [PATCH v2 3/3] trace: instrument and trace tcg tb flush activity

2014-07-15 Thread Alex Bennée
Paolo Bonzini writes: > Il 15/07/2014 13:42, Alex Bennée ha scritto: >> +trace_inc_counter(&cpu->tb_jmp_cache_stats.misses); >> tb = tb_find_slow(env, pc, cs_base, flags); >> +} else { >> +trace_inc_counter(&cpu->tb_jmp_cache_stats.hits); >> } > > I think this is

Re: [Qemu-devel] [PATCH for-2.1? 2/2] thread-pool: avoid deadlock in nested aio_poll() calls

2014-07-15 Thread Stefan Hajnoczi
On Mon, Jul 14, 2014 at 10:36:21AM +0200, Paolo Bonzini wrote: > Il 11/07/2014 13:20, Stefan Hajnoczi ha scritto: > >The thread pool has a race condition if two elements complete before > >thread_pool_completion_bh() runs: > > > > If element A's callback waits for element B using aio_poll() it wil

Re: [Qemu-devel] [PATCH] configure: explicitly state version requirements to devel packages

2014-07-15 Thread Stefan Hajnoczi
On Thu, Jun 26, 2014 at 05:34:50PM +0800, Hu Tao wrote: > Signed-off-by: Hu Tao > --- > configure | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan pgpLP4zNqrEeZ.pgp Descriptio

[Qemu-devel] [PULL 2.1 0/5] ppc patch queue 2014-07-15

2014-07-15 Thread Alexander Graf
Hi Peter, This is my current patch queue for ppc for 2.1. Please pull. Alex The following changes since commit 0e16297461264b3ea8f7282d1195cf53aa8a707c: libqos: Fix PC PCI endianness glitches (2014-07-15 14:18:15 +0100) are available in the git repository at: git://github.com/agraf/qemu

[Qemu-devel] [PULL 2/5] ppc: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2014-07-15 Thread Alexander Graf
From: "Shreyas B. Prabhu" Commit 0b183fc871:"memory: move mem_path handling to memory_region_allocate_system_memory" split memory_region_init_ram and memory_region_init_ram_from_file. Also it moved mem-path handling a step up from memory_region_init_ram to memory_region_allocate_system_memory. T

[Qemu-devel] [PULL 3/5] spapr: Move RMA memory region registration code

2014-07-15 Thread Alexander Graf
From: Alexey Kardashevskiy PPC970 does not support VRMA (virtual RMA) so real memory required for SLOF to execute must be allocated by the KVM_ALLOCATE_RMA ioctl. Later this memory is used as a part of the guest RAM area. The RMA allocating code also registers a memory region for this piece of RA

[Qemu-devel] [PULL 4/5] spapr: Enable use of huge pages

2014-07-15 Thread Alexander Graf
From: Alexey Kardashevskiy 0b183fc87 "memory: move mem_path handling to memory_region_allocate_system_memory" disabled -mempath use for all machines that do not use memory_region_allocate_system_memory() to register RAM. Since SPAPR uses memory_region_init_ram(), the huge pages support was disabl

  1   2   >