Re: [Qemu-devel] [PATCH 1/1] Sun4m : TCX framebuffer hardware acceleration

2014-07-12 Thread Olivier Danet
On 09/07/2014 01:40, Mark Cave-Ayland wrote: > On 29/05/14 20:48, Olivier Danet wrote: > >> Hello Mark >> >> - Don't you like green ? >> It looks fine for me : http://temlib.org/pub/boot_netbsd6.jpg >> >> - "checkpatch.pl" did not find anything wrong with this patch. I will adjust >> style and sp

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Joakim Tjernlund
Peter Maydell wrote on 2014/07/12 19:38:26: > > On 12 July 2014 18:30, Joakim Tjernlund wrote: > > Peter Maydell wrote on 2014/07/12 17:47:56: > >> That would work with the current kernel implementation, but > >> the API definition (as described in the socket(7) manpage) > >> says we should pa

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Peter Maydell
On 12 July 2014 18:30, Joakim Tjernlund wrote: > Peter Maydell wrote on 2014/07/12 17:47:56: >> That would work with the current kernel implementation, but >> the API definition (as described in the socket(7) manpage) >> says we should pass a NUL-terminated string to the kernel, >> so it's more r

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Joakim Tjernlund
Peter Maydell wrote on 2014/07/12 17:47:56: > From: Peter Maydell > To: Joakim Tjernlund , > Cc: QEMU Developers > Date: 2014/07/12 17:48 > Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE) > > On 12 July 2014 16:13, Joakim Tjernlund wrote: > > Peter Maydel

Re: [Qemu-devel] [PATCH] SIOCGIFINDEX: fix typo

2014-07-12 Thread Peter Maydell
On 11 July 2014 02:02, Joakim Tjernlund wrote: > Wrong type was used in ioctl definition. > > Signed-off-by: Joakim Tjernlund > --- > > However, this does not fix my dhcp problem: > > jocke-ppc ~ # busybox udhcpc -v > Adapter index 24 > MAC fe:22:44:22:55:77 > udhcpc (v1.21.0) started > Executing

Re: [Qemu-devel] [PATCH 2/2 v3] linux-user: handle AF_PACKET sockaddrs in target_to_host_sockaddr

2014-07-12 Thread Peter Maydell
On 12 July 2014 14:47, Joakim Tjernlund wrote: > Implement conversion of the AF_PACKET sockaddr subtype > in target_to_host_sockaddr. > > Signed-off-by: Joakim Tjernlund > --- > linux-user/syscall.c | 7 +++ > linux-user/syscall_defs.h | 10 ++ > 2 files changed, 17 insertions(

Re: [Qemu-devel] [PATCH 1/2 v3] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Peter Maydell
On 12 July 2014 14:47, Joakim Tjernlund wrote: [cc'ing Riku who's the linux-user maintainer.] > Signed-off-by: Joakim Tjernlund > --- > linux-user/syscall.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 57c1664

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Peter Maydell
On 12 July 2014 16:13, Joakim Tjernlund wrote: > Peter Maydell wrote on 2014/07/11 19:02:30: >> > >> > hmm, should we not pass through as is to the kernel? >> > Since we don't copy anything we could just remove this >> > check and let the kernel decide policy? >> >> I thought about that, but ther

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Joakim Tjernlund
Peter Maydell wrote on 2014/07/11 19:02:30: > > > > hmm, should we not pass through as is to the kernel? > > Since we don't copy anything we could just remove this > > check and let the kernel decide policy? > > I thought about that, but there's a corner case: > the kernel does the clamping of th

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-12 Thread Joakim Tjernlund
Alexander Graf wrote on 2014/07/12 12:41:05: > > On 12.07.14 12:40, Peter Maydell wrote: > > On 12 July 2014 10:39, Alexander Graf wrote: > >> On 12.07.14 10:58, Peter Maydell wrote: > >>> On 12 July 2014 01:39, Alexander Graf wrote: > What do the other platforms do on illegal instructions

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Joakim Tjernlund
Peter Maydell wrote on 2014/07/12 12:42:48: > > On 12 July 2014 10:48, Joakim Tjernlund wrote: > > Peter Maydell wrote on 2014/07/12 11:01:55: > > OK, 2 new patches sent > > Thanks. > > > I hope these will all make it to the impending release? > > I'm not sure at this point; they are bug fi

[Qemu-devel] [PATCH 1/2 v3] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Joakim Tjernlund
Signed-off-by: Joakim Tjernlund --- linux-user/syscall.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 57c1664..3ef046a 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1497,6 +1497,25 @@ set_timeout:

[Qemu-devel] [PATCH 2/2 v3] linux-user: handle AF_PACKET sockaddrs in target_to_host_sockaddr

2014-07-12 Thread Joakim Tjernlund
Implement conversion of the AF_PACKET sockaddr subtype in target_to_host_sockaddr. Signed-off-by: Joakim Tjernlund --- linux-user/syscall.c | 7 +++ linux-user/syscall_defs.h | 10 ++ 2 files changed, 17 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c in

Re: [Qemu-devel] [PATCH 2/2 v2] linux-user: impl. sockaddr_ll

2014-07-12 Thread Peter Maydell
On 12 July 2014 10:46, Joakim Tjernlund wrote: > Used by AF_PACKET sockets > --- > linux-user/syscall.c | 7 +++ > linux-user/syscall_defs.h | 10 ++ > 2 files changed, 17 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 5a07d9c..a87fe74 100644

Re: [Qemu-devel] [PATCH 1/2 v2] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Peter Maydell
On 12 July 2014 10:46, Joakim Tjernlund wrote: > --- > linux-user/syscall.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 57c1664..5a07d9c 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -149

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Peter Maydell
On 12 July 2014 10:48, Joakim Tjernlund wrote: > Peter Maydell wrote on 2014/07/12 11:01:55: > OK, 2 new patches sent Thanks. > I hope these will all make it to the impending release? I'm not sure at this point; they are bug fixes, and reasonably small ones, but we're in freeze and only a few

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-12 Thread Alexander Graf
On 12.07.14 12:40, Peter Maydell wrote: On 12 July 2014 10:39, Alexander Graf wrote: On 12.07.14 10:58, Peter Maydell wrote: On 12 July 2014 01:39, Alexander Graf wrote: What do the other platforms do on illegal instructions during user mode? Any way we can get consistency across the board?

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-12 Thread Peter Maydell
On 12 July 2014 10:39, Alexander Graf wrote: > > On 12.07.14 10:58, Peter Maydell wrote: >> >> On 12 July 2014 01:39, Alexander Graf wrote: >>> >>> What do the other platforms do on illegal instructions during user mode? >>> Any way we can get consistency across the board? >> >> Mostly it looks l

[Qemu-devel] [PATCH v2] scsi-bus: fix to allow some special SCSI commands

2014-07-12 Thread TAMUKI Shoichi
Currently, some special SCSI commands sent from the initiator in a guest do not reach the target device. To avoid this, extended (0x7e,) variable length (0x7f,) and vendor specific (0xc0..0xff) opcodes are now treated as valid CDBs. Originally, the most significant 3 bits of a SCSI opcode specifi

Re: [Qemu-devel] [PATCH] scsi-bus: fix to allow some special SCSI commands

2014-07-12 Thread TAMUKI Shoichi
Hello, From: Paolo Bonzini Subject: Re: [PATCH] scsi-bus: fix to allow some special SCSI commands Date: Fri, 11 Jul 2014 11:02:41 +0200 > > @@ -563,7 +565,8 @@ SCSIRequest *scsi_req_new(SCSIDevice *d, uint32_t tag, > > uint32_t lun, > > SCSIRequest *req; > > SCSICommand cmd; > > > > -

Re: [Qemu-devel] [Intel-gfx] [Xen-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-07-12 Thread Daniel Vetter
On Fri, Jul 11, 2014 at 08:30:59PM +, Tian, Kevin wrote: > > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > > Sent: Friday, July 11, 2014 12:42 PM > > > > On Fri, Jul 11, 2014 at 08:29:56AM +0200, Daniel Vetter wrote: > > > On Thu, Jul 10, 2014 at 09:08:24PM +, Tian, Kevin w

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Joakim Tjernlund
Peter Maydell wrote on 2014/07/12 11:01:55: > > On 12 July 2014 09:31, Joakim Tjernlund wrote: > > Peter Maydell wrote on 2014/07/11 19:02:30: > >> I thought about that, but there's a corner case: > >> the kernel does the clamping of the optlen before the > >> copy_from_user(), which means if

[Qemu-devel] [PATCH 1/2 v2] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Joakim Tjernlund
--- linux-user/syscall.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 57c1664..5a07d9c 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1497,6 +1497,25 @@ set_timeout: unlock_user_struct(

[Qemu-devel] [PATCH 2/2 v2] linux-user: impl. sockaddr_ll

2014-07-12 Thread Joakim Tjernlund
Used by AF_PACKET sockets --- linux-user/syscall.c | 7 +++ linux-user/syscall_defs.h | 10 ++ 2 files changed, 17 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5a07d9c..a87fe74 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1140,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-12 Thread Alexander Graf
On 12.07.14 10:58, Peter Maydell wrote: On 12 July 2014 01:39, Alexander Graf wrote: What do the other platforms do on illegal instructions during user mode? Any way we can get consistency across the board? Mostly it looks like they just silently generate the SIGILL. Consistency has never bee

Re: [Qemu-devel] [PATCH v2 1/2 for-2.1] vhost-user: Fix VHOST_SET_MEM_TABLE processing

2014-07-12 Thread Nikolay Nikolaev
On Sat, Jul 12, 2014 at 4:42 AM, Nikolay Nikolaev wrote: > > qemu_get_ram_fd doesn't accept a guest physical address. ram_addr_t are > opaque values that are assigned in qemu_ram_alloc. > > Find the ram_addr_t corresponding to the userspace_addr using > qemu_ram_addr_from_host, > and then call qe

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Peter Maydell
On 12 July 2014 09:31, Joakim Tjernlund wrote: > Peter Maydell wrote on 2014/07/11 19:02:30: >> I thought about that, but there's a corner case: >> the kernel does the clamping of the optlen before the >> copy_from_user(), which means if you have: >> [interface name] [unreadable memory] >> and o

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-12 Thread Peter Maydell
On 12 July 2014 01:39, Alexander Graf wrote: > What do the other platforms do on illegal instructions during user mode? > Any way we can get consistency across the board? Mostly it looks like they just silently generate the SIGILL. Consistency has never been our strong point :-) thanks -- PMM

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-12 Thread Joakim Tjernlund
Peter Maydell wrote on 2014/07/11 19:02:30: > From: Peter Maydell > To: Joakim Tjernlund , > Cc: QEMU Developers > Date: 2014/07/11 19:02 > Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE) > Snip > > >> > >> Also, the kernel implementation handles overlong

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-12 Thread Joakim Tjernlund
Alexander Graf wrote on 2014/07/12 02:39:21: > > > On 11.07.14 20:22, Peter Maydell wrote: > > On 11 July 2014 19:15, Joakim Tjernlund wrote: > >> Peter Maydell wrote on 2014/07/11 19:14:25: > >>> On 11 July 2014 16:18, Joakim Tjernlund > >> wrote: > ppc logs every type of Invalid ins