Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-01 Thread Markus Armbruster
Paolo Bonzini writes: > Il 01/07/2014 19:08, Eric Blake ha scritto: >> On 06/27/2014 11:24 AM, Markus Armbruster wrote: >>> Commit bcada37 dropped the (up to now undocumented) members type, len, >>> offset, speed, breaking tests/qemu-iotests/040 and 041. >>> >>> Restore and document them. This f

Re: [Qemu-devel] [SeaBIOS] [PATCH v3] hw/pci: reserve IO and mem for pci express downstream ports with no devices attached

2014-07-01 Thread Gerd Hoffmann
On Mo, 2014-06-23 at 18:29 +0300, Marcel Apfelbaum wrote: > Commit c6e298e1f12e0f4ca02b6da5e42919ae055f6830 > hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached > > introduced support for hot-plugging devices behind pci-2-pci bridges. > Extend hotplug support also for pc

Re: [Qemu-devel] [PATCH v2 2.1 3/3] docs/qmp: Fix documentation of BLOCK_JOB_READY to match code

2014-07-01 Thread Markus Armbruster
Eric Blake writes: > On 06/27/2014 11:24 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> docs/qmp/qmp-events.txt | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt >> index 22fea

Re: [Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent BLOCK_JOB_ERROR regression

2014-07-01 Thread Markus Armbruster
Paolo Bonzini writes: > Il 01/07/2014 16:42, Wenchao Xia ha scritto: >>> diff --git a/qapi/block-core.json b/qapi/block-core.json >>> index 822fe16..fd5b579 100644 >>> --- a/qapi/block-core.json >>> +++ b/qapi/block-core.json >>> @@ -1544,7 +1544,7 @@ >>> { 'event': 'BLOCK_JOB_ERROR', >>> '

Re: [Qemu-devel] [PATCH 4/6] sysbus: Make devices spawnable via -device

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 23:49, Alexander Graf ha scritto: + +static void machine_init_notify(Notifier *notifier, void *data) +{ +Object *machine = qdev_get_machine(); +Object *container; + +if (object_property_find(machine, "has-dynamic-sysbus", NULL)) { +/* Our machine can handle dynam

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Gonglei (Arei)
> -Original Message- > From: Anton Ivanov (antivano) [mailto:antiv...@cisco.com] > Sent: Tuesday, July 01, 2014 11:06 PM > To: Stefan Hajnoczi; Gonglei (Arei) > Cc: qemu-devel; Peter Maydell; Huangweidong (C); chenliang (T); Luonengjun; > Stefan Hajnoczi; Paolo Bonzini > Subject: Re:

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-01 Thread Al Viro
On Wed, Jul 02, 2014 at 06:50:27AM +0100, Al Viro wrote: > AFAICS, it leaves two possibilities - EV45 (AS200) vs. EV6 (DS10) and EV67 > (qemu) _or_ some change in the kernel. I'll build 3.x kernel for DS10 and > post the results; shouldn't take long... Actually, it's simpler - note that on *all*

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-01 Thread Al Viro
On Wed, Jul 02, 2014 at 05:05:08AM +0100, Al Viro wrote: > OK, DS10 resurrected and so far seems to be stable (I'll know by tomorrow; > there's a possibility that chipset heatsink is dodgy, but so far it seems > to be doing OK). That gives us a EV6 box. > > Which glibc version it is? I don't see

Re: [Qemu-devel] [PULL for-2.1 13/24] qemu-img create: add 'nocow' option

2014-07-01 Thread Chun Yan Liu
>>> On 7/2/2014 at 11:10 AM, in message <53b37840.1020...@redhat.com>, Eric >>> Blake wrote: > On 07/01/2014 02:48 AM, Stefan Hajnoczi wrote: > > From: Chunyan Liu > > > > Add 'nocow' option so that users could have a chance to set NOCOW flag to > > newly created files. It's useful on bt

[Qemu-devel] [PATCH] Fix nocow typos in manpage

2014-07-01 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- qemu-doc.texi | 4 ++-- qemu-img.texi | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index ad92c85..551619a 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -590,7 +590,7 @@ check -r all} is required, which ma

Re: [Qemu-devel] [PATCH 3/6] sysbus: Add user map hints

2014-07-01 Thread Peter Crosthwaite
On Wed, Jul 2, 2014 at 7:49 AM, Alexander Graf wrote: > We want to give the user the ability to tell our machine file where he wants > to have devices mapped to. This patch adds code to create these hints > dynamically and expose them as object properties that can only be modified > before device

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-01 Thread Al Viro
On Tue, Jul 01, 2014 at 11:30:19AM -0700, Richard Henderson wrote: > On 07/01/2014 11:23 AM, Peter Maydell wrote: > > On 1 July 2014 18:50, Al Viro wrote: > >> Which glibc version? Better yet, could you throw preprocessed source > >> my way? UP1000 box is not in a good shape and I'd rather avoid

Re: [Qemu-devel] [Bug] block: virtio-blk-dataplane causes segfault

2014-07-01 Thread Chai Wen
On 07/02/2014 11:24 AM, Chai Wen wrote: > Hi > > I tested the latest release v2.1 qemu feature virtio-dataplane. > And it seems that there is a little bug in it. > Please see the following below for detail, thanks. > Oh, Just saw Stefan's fix. Please ignore. Stefan Hajnoczi (4): virtio-blk:

Re: [Qemu-devel] [PATCH 2/6] qom: Allow to make integer qom properties writeable

2014-07-01 Thread Peter Crosthwaite
On Wed, Jul 2, 2014 at 7:49 AM, Alexander Graf wrote: > We have helper functions to easily expose integers as QOM object properties. > However, these are read only. I think this is a good idea, and _ptr properties should have some write-ability. > Let's introduce some easy helpers that would > j

Re: [Qemu-devel] [PATCH 1/6] qom: macroify integer property helpers

2014-07-01 Thread Peter Crosthwaite
On Wed, Jul 2, 2014 at 7:49 AM, Alexander Graf wrote: > We have a bunch of nice helpers that allow us to easily register an integer > field as QOM property. However, we have those duplicated for every integer > size available. > > This is very cumbersome (and prone to bugs) to work with and extend

[Qemu-devel] [Bug] block: virtio-blk-dataplane causes segfault

2014-07-01 Thread Chai Wen
Hi I tested the latest release v2.1 qemu feature virtio-dataplane. And it seems that there is a little bug in it. Please see the following below for detail, thanks. git: git.qemu.org/qemu.git branch: master top commit: commit 92259b7f434b382fc865d1f65f7d5adeed295749 Author: Peter Maydell Date:

Re: [Qemu-devel] [PULL for-2.1 13/24] qemu-img create: add 'nocow' option

2014-07-01 Thread Eric Blake
On 07/01/2014 02:48 AM, Stefan Hajnoczi wrote: > From: Chunyan Liu > > Add 'nocow' option so that users could have a chance to set NOCOW flag to > newly created files. It's useful on btrfs file system to enhance performance. > > Btrfs has low performance when hosting VM images, even more when th

Re: [Qemu-devel] [PATCH V3] qemu-img create: add 'nocow' option

2014-07-01 Thread Chun Yan Liu
>>> On 7/2/2014 at 05:02 AM, in message <53b321cc.7070...@redhat.com>, Eric >>> Blake wrote: > On 06/23/2014 03:17 AM, Chunyan Liu wrote: > > Add 'nocow' option so that users could have a chance to set NOCOW flag to > > newly created files. It's useful on btrfs file system to enhance > per

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-01 Thread Ming Lei
On Wed, Jul 2, 2014 at 8:46 AM, Ming Lei wrote: > On Wed, Jul 2, 2014 at 12:56 AM, Paolo Bonzini wrote: >> Il 01/07/2014 17:21, Kevin Wolf ha scritto: >> >> Does this bs->file forwarding work for more than the raw driver? For >> example, if drv is an image format driver that needs to read

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-01 Thread Chen, Tiejun
On 2014/7/2 2:20, Stefano Stabellini wrote: On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: On Tue, Jul 01, 2014 at 05:47:39PM +0100, Stefano Stabellini wrote: On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: On Mon, Jun 30, 2014 at 03:31:05PM -0400, Ross Philipson wrote: On 06/30/2014 03:22 PM, S

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Gonglei (Arei)
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Wednesday, July 02, 2014 1:27 AM > To: Gonglei (Arei) > Cc: QEMU Developers; Anton Ivanov (antivano); Stefan Hajnoczi; Paolo Bonzini; > Huangweidong (C); Luonengjun; chenliang (T) > Subject: Re: [PATCH v2]

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-01 Thread Chen, Tiejun
On 2014/7/1 20:33, Michael S. Tsirkin wrote: On Tue, Jul 01, 2014 at 05:46:58PM +0800, Chen, Tiejun wrote: On 2014/7/1 17:12, Michael S. Tsirkin wrote: On Tue, Jul 01, 2014 at 10:40:42AM +0800, Chen, Tiejun wrote: On 2014/6/30 19:28, Michael S. Tsirkin wrote: On Mon, Jun 30, 2014 at 06:20:22P

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-07-01 Thread Ming Lei
On Wed, Jul 2, 2014 at 12:49 AM, Paolo Bonzini wrote: > Il 01/07/2014 16:49, Ming Lei ha scritto: > >> Let me provide some data when running randread(bs 4k, libaio) >> from VM for 10sec: >> >> 1), qemu.git/master >> - write(): 731K >> - rt_sigprocmask(): 417K >> - read(): 21K >> - ppoll(): 10K >>

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-01 Thread Ming Lei
On Wed, Jul 2, 2014 at 12:56 AM, Paolo Bonzini wrote: > Il 01/07/2014 17:21, Kevin Wolf ha scritto: > > Does this bs->file forwarding work for more than the raw driver? For > example, if drv is an image format driver that needs to read some > metadata from the image before it can submi

[Qemu-devel] [PATCH] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space()

2014-07-01 Thread Le Tan
In function do_pci_register_device() in file hw/pci/pci.c, move the assignment of pci_dev->devfn to the position before the call to pci_device_iommu_address_space(pci_dev) which will use the value of pci_dev->devfn. Signed-off-by: Le Tan --- hw/pci/pci.c |2 +- 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH 5/6] PPC: e500: Support dynamically spawned sysbus devices

2014-07-01 Thread Scott Wood
On Tue, 2014-07-01 at 23:49 +0200, Alexander Graf wrote: > For e500 our approach to supporting dynamically spawned sysbus devices is to > create a simple bus from the guest's point of view within which we map those > devices dynamically. > > We allocate memory regions always within the "platform"

Re: [Qemu-devel] [PATCH 6/6] e500: Add support for eTSEC in device tree

2014-07-01 Thread Scott Wood
On Tue, 2014-07-01 at 23:49 +0200, Alexander Graf wrote: > This patch adds support to expose eTSEC devices in the dynamically created > guest facing device tree. This allows us to expose eTSEC devices into guests > without changes in the machine file. > > Because we can now tell the guest about eT

[Qemu-devel] [ANNOUNCE] QEMU 2.1.0-rc0 is now available

2014-07-01 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 2.1 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.1.0-rc0.tar.bz2 You can help impr

Re: [Qemu-devel] [PULL for-2.1 21/24] block: add QAPI command to allow live backing file change

2014-07-01 Thread Eric Blake
On 07/01/2014 02:48 AM, Stefan Hajnoczi wrote: > From: Jeff Cody > > This allows a user to make a live change to the backing file recorded in > an open image. > > + > +/* final sanity check */ > +if (!bdrv_chain_contains(bs, image_bs)) { > +error_setg(errp, "'%s' and image file

Re: [Qemu-devel] [PULL for-2.1 24/24] block: add backing-file option to block-stream

2014-07-01 Thread Eric Blake
On 07/01/2014 02:50 PM, Eric Blake wrote: > On 07/01/2014 02:48 AM, Stefan Hajnoczi wrote: >> From: Jeff Cody >> >> On some image chains, QEMU may not always be able to resolve the >> filenames properly, when updating the backing file of an image >> after a block job. >> > >> >> Reviewed-by: Eric

[Qemu-devel] [PATCH 3/6] sysbus: Add user map hints

2014-07-01 Thread Alexander Graf
We want to give the user the ability to tell our machine file where he wants to have devices mapped to. This patch adds code to create these hints dynamically and expose them as object properties that can only be modified before device realization. Signed-off-by: Alexander Graf --- hw/core/sysbu

[Qemu-devel] [PATCH 4/6] sysbus: Make devices spawnable via -device

2014-07-01 Thread Alexander Graf
Now that we can properly map sysbus devices that haven't been connected to something forcefully by C code, we can allow the -device command line option to spawn them. For machines that don't implement dynamic sysbus assignment in their board files we add a new property "has-dynamic-sysbus" to the

[Qemu-devel] [PATCH 1/6] qom: macroify integer property helpers

2014-07-01 Thread Alexander Graf
We have a bunch of nice helpers that allow us to easily register an integer field as QOM property. However, we have those duplicated for every integer size available. This is very cumbersome (and prone to bugs) to work with and extend, so let's strip out the only difference there is (the size) and

[Qemu-devel] [PATCH 0/6] Dynamic sysbus device allocation support

2014-07-01 Thread Alexander Graf
Platforms without ISA and/or PCI have had a seriously hard time in the dynamic device creation world of QEMU. Devices on these were modeled as SysBus devices which can only be instantiated in machine files, not through -device. Why is that so? For Sysbus devices we didn't know who should be respo

[Qemu-devel] [PATCH 2/6] qom: Allow to make integer qom properties writeable

2014-07-01 Thread Alexander Graf
We have helper functions to easily expose integers as QOM object properties. However, these are read only. Let's introduce some easy helpers that would just write to the values. We also add a new parameter to the property registration that allows us to specify the setter function. If we need speci

[Qemu-devel] [PATCH 6/6] e500: Add support for eTSEC in device tree

2014-07-01 Thread Alexander Graf
This patch adds support to expose eTSEC devices in the dynamically created guest facing device tree. This allows us to expose eTSEC devices into guests without changes in the machine file. Because we can now tell the guest about eTSEC devices this patch allows the user to specify eTSEC devices via

[Qemu-devel] [PATCH 5/6] PPC: e500: Support dynamically spawned sysbus devices

2014-07-01 Thread Alexander Graf
For e500 our approach to supporting dynamically spawned sysbus devices is to create a simple bus from the guest's point of view within which we map those devices dynamically. We allocate memory regions always within the "platform" hole in address space and map IRQs to predetermined IRQ lines that

Re: [Qemu-devel] [PATCH for-2.1 1/2] mirror: Fix qiov size for short requests

2014-07-01 Thread Eric Blake
On 07/01/2014 10:52 AM, Eric Blake wrote: > On 07/01/2014 08:52 AM, Kevin Wolf wrote: >> When mirroring an image of a size that is not a multiple of the >> mirror job granularity, the last request would have the right nb_sectors >> argument, but a qiov that is rounded up to the next multiple of the

Re: [Qemu-devel] [PATCH V3] qemu-img create: add 'nocow' option

2014-07-01 Thread Eric Blake
On 06/23/2014 03:17 AM, Chunyan Liu wrote: > Add 'nocow' option so that users could have a chance to set NOCOW flag to > newly created files. It's useful on btrfs file system to enhance performance. > > Btrfs has low performance when hosting VM images, even more when the guest > in those VM are al

Re: [Qemu-devel] [PATCH 2/2 v5] numa: enable sparse node numbering on ppc

2014-07-01 Thread Nishanth Aravamudan
On 01.07.2014 [17:39:57 -0300], Eduardo Habkost wrote: > On Tue, Jul 01, 2014 at 01:13:28PM -0700, Nishanth Aravamudan wrote: > [...] > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > > index 12472c6..cdefafe 100644 > > --- a/hw/i386/pc.c > > +++ b/hw/i386/pc.c > > @@ -1121,6 +1121,18 @@ PcGuestInfo *

Re: [Qemu-devel] [PULL for-2.1 24/24] block: add backing-file option to block-stream

2014-07-01 Thread Eric Blake
On 07/01/2014 02:48 AM, Stefan Hajnoczi wrote: > From: Jeff Cody > > On some image chains, QEMU may not always be able to resolve the > filenames properly, when updating the backing file of an image > after a block job. > > > Reviewed-by: Eric Blake > Signed-off-by: Jeff Cody > Signed-off-by

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-07-01 Thread Eric Blake
On 06/26/2014 09:50 PM, Hu Tao wrote: > On Thu, Jun 26, 2014 at 10:55:33AM -0600, Eric Blake wrote: >> On 06/26/2014 12:13 AM, Hu Tao wrote: >>> We already have ROUND_UP but there are similar macros and ROUND_UP-like >>> lines all around, replace them with ROUND_UP and clean up similar macros. >>>

Re: [Qemu-devel] [PATCH 1/2] Rename nb_numa_nodes to num_numa_nodes

2014-07-01 Thread Eduardo Habkost
On Tue, Jul 01, 2014 at 01:11:08PM -0700, Nishanth Aravamudan wrote: > As suggested by Eduardo Habkost, rename nb_numa_nodes to num_numa_nodes > throughout the code, as that reflects the use of the variable more > clearly. > > Signed-off-by: Nishanth Aravamudan Reviewed-by: Eduardo Habkost --

Re: [Qemu-devel] [PATCH 2/2 v5] numa: enable sparse node numbering on ppc

2014-07-01 Thread Eduardo Habkost
On Tue, Jul 01, 2014 at 01:13:28PM -0700, Nishanth Aravamudan wrote: [...] > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 12472c6..cdefafe 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1121,6 +1121,18 @@ PcGuestInfo *pc_guest_info_init(ram_addr_t > below_4g_mem_size, > guest_info

[Qemu-devel] [Bug 950692] Re: High CPU usage in Host (revisited)

2014-07-01 Thread Mahesh
I see similar problem when few I/Os are pumped and the VM goes non-responsive. The host sees nearly 100% CPU utilization. top - 08:58:57 up 18:42, 2 users, load average: 0.99, 0.98, 0.95 Tasks: 355 total, 1 running, 354 sleeping, 0 stopped, 0 zombie %Cpu(s): 1.5 us, 2.7 sy, 0.0 ni, 95.8

[Qemu-devel] [PATCH 2/2 v5] numa: enable sparse node numbering on ppc

2014-07-01 Thread Nishanth Aravamudan
Sparse node numbering occurs on powerpc in practice under PowerVM. In order to emulate the same NUMA topology under qemu, the assumption that NUMA nodes are linearly ordered has to be removed. qemu was recently modified to reject requests for sparse NUMA node numbering. Leverage the present field

[Qemu-devel] [PATCH 1/2] Rename nb_numa_nodes to num_numa_nodes

2014-07-01 Thread Nishanth Aravamudan
As suggested by Eduardo Habkost, rename nb_numa_nodes to num_numa_nodes throughout the code, as that reflects the use of the variable more clearly. Signed-off-by: Nishanth Aravamudan diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2cf22b1..12472c6 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-01 Thread Ross Philipson
On 07/01/2014 02:06 PM, Michael S. Tsirkin wrote: On Tue, Jul 01, 2014 at 01:39:04PM -0400, Ross Philipson wrote: [snip] What class does your ISA bridge device have? #define PCI_CLASS_BRIDGE_ISA 0x0601 Also I don't like the idea of tying Tiejun's patch series, that covers

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-01 Thread Peter Maydell
On 1 July 2014 19:30, Richard Henderson wrote: > On 07/01/2014 11:23 AM, Peter Maydell wrote: >> Would a 164LX be a useful (ie non-duplicate) extra resource >> for testing this stuff? That has a 21164 (EV5) in it. I haven't >> tried to boot it for some years, but I can have a try at >> resurrectin

[Qemu-devel] [PATCH v3] e1000: clean up phyreg_writeops/set_phy_ctrl

2014-07-01 Thread Gabriel L. Somlo
Make phyreg_writeops responsible for actually writing their respective phy registers. The only current instance of phyreg_writeops is set_phy_ctrl(), which we modify to actually write the register, while also correctly handling reserved and self-clearing bits. have_autoneg() does not need to check

Re: [Qemu-devel] [PATCH]Fix a error in mc146818rtc.c

2014-07-01 Thread Alex Bligh
On 1 Jul 2014, at 02:12, Lb peace wrote: > 1)“ it's an automated output of perl simply changing one calling convention > to another”.What do you mean... I > can not find the point :) I'd thought this was the huge patch which was generated by perl to change the API, but it's not. > 2) The pro

Re: [Qemu-devel] [v5][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough

2014-07-01 Thread Michael S. Tsirkin
On Tue, Jul 01, 2014 at 09:34:14PM +0300, Michael S. Tsirkin wrote: > On Tue, Jul 01, 2014 at 05:49:50PM +0100, Stefano Stabellini wrote: > > On Tue, 1 Jul 2014, Chen, Tiejun wrote: > > > On 2014/7/1 3:42, Stefano Stabellini wrote: > > > > On Mon, 30 Jun 2014, Chen, Tiejun wrote: > > > > > On 2014/

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-01 Thread Michael S. Tsirkin
On Tue, Jul 01, 2014 at 07:20:26PM +0100, Stefano Stabellini wrote: > On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: > > On Tue, Jul 01, 2014 at 05:47:39PM +0100, Stefano Stabellini wrote: > > > On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: > > > > On Mon, Jun 30, 2014 at 03:31:05PM -0400, Ross Phil

Re: [Qemu-devel] [v5][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough

2014-07-01 Thread Michael S. Tsirkin
On Tue, Jul 01, 2014 at 05:49:50PM +0100, Stefano Stabellini wrote: > On Tue, 1 Jul 2014, Chen, Tiejun wrote: > > On 2014/7/1 3:42, Stefano Stabellini wrote: > > > On Mon, 30 Jun 2014, Chen, Tiejun wrote: > > > > On 2014/6/29 20:14, Michael S. Tsirkin wrote: > > > > > On Sun, Jun 29, 2014 at 03:56:

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-01 Thread Richard Henderson
On 07/01/2014 11:23 AM, Peter Maydell wrote: > On 1 July 2014 18:50, Al Viro wrote: >> Which glibc version? Better yet, could you throw preprocessed source >> my way? UP1000 box is not in a good shape and I'd rather avoid trying to run >> full glibc builds on it ;-/ > > Would a 164LX be a usefu

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-01 Thread Peter Maydell
On 1 July 2014 18:50, Al Viro wrote: > Which glibc version? Better yet, could you throw preprocessed source > my way? UP1000 box is not in a good shape and I'd rather avoid trying to run > full glibc builds on it ;-/ Would a 164LX be a useful (ie non-duplicate) extra resource for testing this s

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-01 Thread Stefano Stabellini
On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: > On Tue, Jul 01, 2014 at 05:47:39PM +0100, Stefano Stabellini wrote: > > On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: > > > On Mon, Jun 30, 2014 at 03:31:05PM -0400, Ross Philipson wrote: > > > > On 06/30/2014 03:22 PM, Stefano Stabellini wrote: > > >

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-01 Thread Michael S. Tsirkin
On Tue, Jul 01, 2014 at 01:39:04PM -0400, Ross Philipson wrote: > On 07/01/2014 01:02 PM, Michael S. Tsirkin wrote: > >On Tue, Jul 01, 2014 at 05:47:39PM +0100, Stefano Stabellini wrote: > >>On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: > >>>On Mon, Jun 30, 2014 at 03:31:05PM -0400, Ross Philipson

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-01 Thread Al Viro
On Tue, Jul 01, 2014 at 10:03:06AM -0700, Richard Henderson wrote: > On 06/30/2014 01:56 PM, Al Viro wrote: > > On Mon, Jun 30, 2014 at 11:39:43AM -0700, Richard Henderson wrote: > > > >> Looks good. > >> > >> I've split it up into a couple of smaller patches, made some sylistic > >> tweaks > >>

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-01 Thread Ross Philipson
On 07/01/2014 01:02 PM, Michael S. Tsirkin wrote: On Tue, Jul 01, 2014 at 05:47:39PM +0100, Stefano Stabellini wrote: On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: On Mon, Jun 30, 2014 at 03:31:05PM -0400, Ross Philipson wrote: On 06/30/2014 03:22 PM, Stefano Stabellini wrote: On Mon, 30 Jun

Re: [Qemu-devel] [RFC PATCH 08/22] Monitor commands

2014-07-01 Thread Eric Blake
On 07/01/2014 05:23 AM, Pavel Dovgaluk wrote: > This patch adds commands to control replay from the monitor. > > Signed-off-by: Pavel Dovgalyuk > --- What are the counterpart QMP commands? It is seldom right to add an HMP command unless the same thing can be done via QMP. > @@ -2596,6 +2734,7

Re: [Qemu-devel] [RFC PATCH 02/22]

2014-07-01 Thread Eric Blake
On 07/01/2014 05:18 AM, Pavel Dovgaluk wrote: > These patches modify virtual hardware to make them deterministic. > We also implemented saving/restoring for several devices or fixed vm state > of them to save the fields that we needed for deterministically restoring > behavior of the devices. > >

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Peter Maydell
On 1 July 2014 13:58, wrote: > From: Gonglei > > because mmsghdr struct is introduced on Linux kernel 3.3+. > add check for mmsghdr struct, it only gets built on hosts that > support mmsghdr. > > Reported-by: chenliang > Signed-off-by: Gonglei Applied to master (with a tweaked commit message)

Re: [Qemu-devel] [PULL 3/3] configure: Fix -lm test, so that tools can be compiled on hosts that require -lm

2014-07-01 Thread Eric Blake
On 07/01/2014 02:26 AM, Peter Maydell wrote: > On 1 July 2014 09:22, Paolo Bonzini wrote: >> From: Alexey Kardashevskiy >> >> The existing test whether "-lm" needs to be included or not is >> insufficient as it reports false negative on Fedora20/ppc64. >> This happens because sin(0.0) is a consta

Re: [Qemu-devel] [PATCH v3 4/4] dataplane: submit I/O at batch

2014-07-01 Thread Eric Blake
On 07/01/2014 10:35 AM, Ming Lei wrote: > Before commit 580b6b2aa2(dataplane: use the Qemu block > layer for I/O), dataplane for virtio-blk submits block > I/O at batch. s/at/as a/ > > This commit 580b6b2aa2 replaces the custom linux AIO > implementation(including I/O batch) with Qemu block s/(

Re: [Qemu-devel] [PATCH v2 2.1 3/3] docs/qmp: Fix documentation of BLOCK_JOB_READY to match code

2014-07-01 Thread Eric Blake
On 06/27/2014 11:24 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > docs/qmp/qmp-events.txt | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt > index 22fea58..44be891 100644 > --- a/doc

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 19:08, Eric Blake ha scritto: On 06/27/2014 11:24 AM, Markus Armbruster wrote: Commit bcada37 dropped the (up to now undocumented) members type, len, offset, speed, breaking tests/qemu-iotests/040 and 041. Restore and document them. This fixes 040, and partially fixes 041. Signe

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-01 Thread Eric Blake
On 06/27/2014 11:24 AM, Markus Armbruster wrote: > Commit bcada37 dropped the (up to now undocumented) members type, len, > offset, speed, breaking tests/qemu-iotests/040 and 041. > > Restore and document them. This fixes 040, and partially fixes 041. > > Signed-off-by: Markus Armbruster > Test

Re: [Qemu-devel] [PATCH v3 0/3] linux-aio: introduce submit I/O at batch

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 18:35, Ming Lei ha scritto: Hi, The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O) introduces ~40% throughput regression on virtio-blk dataplane, and one of causes is that submitting I/O at batch is removed. This patchset trys to introduce this mechanism on block,

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-01 Thread Richard Henderson
On 06/30/2014 01:56 PM, Al Viro wrote: > On Mon, Jun 30, 2014 at 11:39:43AM -0700, Richard Henderson wrote: > >> Looks good. >> >> I've split it up into a couple of smaller patches, made some sylistic tweaks >> and pushed it to >> >> git://github.com/rth7680/qemu.git axp-next >> >> I'm starting

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-01 Thread Michael S. Tsirkin
On Tue, Jul 01, 2014 at 05:47:39PM +0100, Stefano Stabellini wrote: > On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: > > On Mon, Jun 30, 2014 at 03:31:05PM -0400, Ross Philipson wrote: > > > On 06/30/2014 03:22 PM, Stefano Stabellini wrote: > > > >On Mon, 30 Jun 2014, Michael S. Tsirkin wrote: > > >

[Qemu-devel] [PATCH v3 3/4] linux-aio: implement io plug and unplug

2014-07-01 Thread Ming Lei
This patch implements .bdrv_io_plug and .bdrv_io_unplug callbacks for linux-aio Block Drivers, so that submitting I/O at batch can be supported on linux-aio. Signed-off-by: Ming Lei --- block/linux-aio.c | 86 +++-- block/raw-aio.h |2 ++ b

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 17:21, Kevin Wolf ha scritto: Does this bs->file forwarding work for more than the raw driver? For example, if drv is an image format driver that needs to read some metadata from the image before it can submit the payload, does this still do what you were intending? Sorry for not

Re: [Qemu-devel] [PATCH for-2.1 1/2] mirror: Fix qiov size for short requests

2014-07-01 Thread Eric Blake
On 07/01/2014 08:52 AM, Kevin Wolf wrote: > When mirroring an image of a size that is not a multiple of the > mirror job granularity, the last request would have the right nb_sectors > argument, but a qiov that is rounded up to the next multiple of the > granularity. Don't do this. > > This fixes

Re: [Qemu-devel] [v5][PATCH 2/5] xen, gfx passthrough: create pseudo intel isa bridge

2014-07-01 Thread Stefano Stabellini
On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: > On Mon, Jun 30, 2014 at 08:34:46PM +0100, Stefano Stabellini wrote: > > On Fri, 27 Jun 2014, Chen, Tiejun wrote: > > > On 2014/6/25 17:58, Chen, Tiejun wrote: > > > > On 2014/6/25 17:44, Michael S. Tsirkin wrote: > > > > > On Wed, Jun 25, 2014 at 05:2

Re: [Qemu-devel] [v5][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough

2014-07-01 Thread Stefano Stabellini
On Tue, 1 Jul 2014, Chen, Tiejun wrote: > On 2014/7/1 3:42, Stefano Stabellini wrote: > > On Mon, 30 Jun 2014, Chen, Tiejun wrote: > > > On 2014/6/29 20:14, Michael S. Tsirkin wrote: > > > > On Sun, Jun 29, 2014 at 03:56:10PM +0800, Chen, Tiejun wrote: > > > > > On 2014/6/27 19:26, Paolo Bonzini wr

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 16:49, Ming Lei ha scritto: Let me provide some data when running randread(bs 4k, libaio) from VM for 10sec: 1), qemu.git/master - write(): 731K - rt_sigprocmask(): 417K - read(): 21K - ppoll(): 10K - io_submit(): 5K - io_getevents(): 4K 2), qemu 2.0 - write(): 9K - read(): 28K -

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-01 Thread Stefano Stabellini
On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: > On Mon, Jun 30, 2014 at 03:31:05PM -0400, Ross Philipson wrote: > > On 06/30/2014 03:22 PM, Stefano Stabellini wrote: > > >On Mon, 30 Jun 2014, Michael S. Tsirkin wrote: > > >>On Mon, Jun 30, 2014 at 03:24:58PM +0800, Chen, Tiejun wrote: > > >>>On 201

[Qemu-devel] [PATCH v3 4/4] dataplane: submit I/O at batch

2014-07-01 Thread Ming Lei
Before commit 580b6b2aa2(dataplane: use the Qemu block layer for I/O), dataplane for virtio-blk submits block I/O at batch. This commit 580b6b2aa2 replaces the custom linux AIO implementation(including I/O batch) with Qemu block layer, but this commit causes ~40% throughput regression on virtio-bl

Re: [Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent BLOCK_JOB_ERROR regression

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 16:42, Wenchao Xia ha scritto: >> diff --git a/qapi/block-core.json b/qapi/block-core.json >> index 822fe16..fd5b579 100644 >> --- a/qapi/block-core.json >> +++ b/qapi/block-core.json >> @@ -1544,7 +1544,7 @@ >> { 'event': 'BLOCK_JOB_ERROR', >> 'data': { 'device' : 'str', >>

[Qemu-devel] [PATCH v2] target-mips: fix broken MIPS16 and microMIPS

2014-07-01 Thread Yongbok Kim
Commit 240ce26a broke MIPS16 and microMIPS support as it didn't care those branches and jumps don't have delay slot in MIPS16 and microMIPS. This patch introduces a new argument delayslot_size to the gen_compute_branch() indicating size of delay slot {0, 2, 4}. And the information is used to call

[Qemu-devel] [PATCH v3 2/4] block/raw_bsd.c: support io plug and unplug for raw format image

2014-07-01 Thread Ming Lei
This patch defines .bdrv_io_plug and .bdrv_io_unplug callbacks, so that we can support to submit IO at batch for linux-aio. Signed-off-by: Ming Lei --- block/raw_bsd.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 492

[Qemu-devel] [PATCH v3 1/4] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-01 Thread Ming Lei
This patch introduces these two APIs so that following patches can support queuing I/O requests and submitting them at batch for improving I/O performance. Reviewed-by: Paolo Bonzini Signed-off-by: Ming Lei --- block.c | 17 + include/block/block.h |3

[Qemu-devel] [PATCH v3 0/3] linux-aio: introduce submit I/O at batch

2014-07-01 Thread Ming Lei
Hi, The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O) introduces ~40% throughput regression on virtio-blk dataplane, and one of causes is that submitting I/O at batch is removed. This patchset trys to introduce this mechanism on block, at least, linux-aio can benefit from that.

[Qemu-devel] [RFC] icount: warp in the main_loop.

2014-07-01 Thread fred . konrad
From: KONRAD Frederic This fixes a bug where QEMU stall in icount mode. It happens when a simple timer callback is created on VIRTUAL CLOCK modding itself regularly. The actual warping mechanism is called once and then the time didn't grow anymore. Signed-off-by: KONRAD Frederic --- main-loo

Re: [Qemu-devel] [PULL 0/4] usb patch queue

2014-07-01 Thread Peter Maydell
r/tags/qom-devices-for-2.1' > into staging (2014-07-01 11:00:53 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-usb-20140701-1 > > for you to fetch changes up to c1129f6bffb6fc756f53c06bc554a7997b1f4be4: > &

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Peter Maydell
On 1 July 2014 16:58, Anton Ivanov (antivano) wrote: > On 01/07/14 16:34, Peter Maydell wrote: >> We don't need to support this optional feature on RHEL5, we >> just need not to die horribly trying to compile it when we're >> on an older system, that's all. This patch should be enough for >> this,

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Anton Ivanov (antivano)
On 01/07/14 16:34, Peter Maydell wrote: > On 1 July 2014 16:26, Anton Ivanov (antivano) wrote: >> On 01/07/14 16:14, Peter Maydell wrote: >>> On 1 July 2014 16:06, Anton Ivanov (antivano) wrote: As far as general purpose linuxes, the relevant libc headers are present in Ubuntul LTS 12.x

Re: [Qemu-devel] [RFC PATCH V3 6/6] monitor: Add drift info to 'info jit'

2014-07-01 Thread Sebastian Tanase
- Mail original - > De: "Frederic Konrad" > À: "Sebastian Tanase" , qemu-devel@nongnu.org > Cc: kw...@redhat.com, "peter maydell" , > a...@alex.org.uk, wenchaoq...@gmail.com, > quint...@redhat.com, m...@tls.msk.ru, m...@redhat.com, stefa...@redhat.com, > arm...@redhat.com, lcapitul...@

Re: [Qemu-devel] [RFC PATCH V3 0/6] icount: Implement delay algorithm between guest and host clocks

2014-07-01 Thread Sebastian Tanase
- Mail original - > De: "Paolo Bonzini" > À: "Sebastian Tanase" , qemu-devel@nongnu.org > Cc: aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, "peter maydell" > , > mich...@walle.cc, a...@alex.org.uk, stefa...@redhat.com, > lcapitul...@redhat.com, crobi...@redhat.com, > arm...@

Re: [Qemu-devel] [RFC PATCH V3 5/6] cpu_exec: Print to console if the guest is late

2014-07-01 Thread Sebastian Tanase
- Mail original - > De: "Paolo Bonzini" > À: "Sebastian Tanase" , qemu-devel@nongnu.org > Cc: aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, "peter maydell" > , > mich...@walle.cc, a...@alex.org.uk, stefa...@redhat.com, > lcapitul...@redhat.com, crobi...@redhat.com, > arm...@

Re: [Qemu-devel] [RFC PATCH V3 4/6] cpu_exec: Add sleeping algorithm

2014-07-01 Thread Sebastian Tanase
- Mail original - > De: "Paolo Bonzini" > À: "Sebastian Tanase" , qemu-devel@nongnu.org > Cc: aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, "peter maydell" > , > mich...@walle.cc, a...@alex.org.uk, stefa...@redhat.com, > lcapitul...@redhat.com, crobi...@redhat.com, > arm...@

Re: [Qemu-devel] [RFC PATCH v4] numa: enable sparse node numbering on ppc

2014-07-01 Thread Nishanth Aravamudan
On 01.07.2014 [12:24:48 -0300], Eduardo Habkost wrote: > On Mon, Jun 30, 2014 at 02:34:56PM -0700, Nishanth Aravamudan wrote: > [...] > > } > > + assert(numa_info[i].present); > > numa_info[i].node_mem = ram_size - usedmem; > > } > > Tab here. > > > > [.

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Peter Maydell
On 1 July 2014 16:26, Anton Ivanov (antivano) wrote: > On 01/07/14 16:14, Peter Maydell wrote: >> On 1 July 2014 16:06, Anton Ivanov (antivano) wrote: >>> As far as general purpose linuxes, the relevant libc headers are present >>> in Ubuntul LTS 12.x and onwards, Debian 7.x, Fedora, and all othe

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Anton Ivanov (antivano)
On 01/07/14 16:14, Peter Maydell wrote: > On 1 July 2014 16:06, Anton Ivanov (antivano) wrote: >> As far as general purpose linuxes, the relevant libc headers are present >> in Ubuntul LTS 12.x and onwards, Debian 7.x, Fedora, and all other major >> distros. I do not have a RHEL handy to check, bu

Re: [Qemu-devel] [RFC PATCH V3 2/6] icount: Add align option to icount

2014-07-01 Thread Sebastian Tanase
- Mail original - > De: "Paolo Bonzini" > À: "Sebastian Tanase" , qemu-devel@nongnu.org > Cc: aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, "peter maydell" > , > mich...@walle.cc, a...@alex.org.uk, stefa...@redhat.com, > lcapitul...@redhat.com, crobi...@redhat.com, > arm...@

[Qemu-devel] [PATCH v2 4/4] virtio-blk: embed VirtQueueElement in VirtIOBlockReq

2014-07-01 Thread Stefan Hajnoczi
The memory allocation between hw/block/virtio-blk.c, hw/block/dataplane/virtio-blk.c, and hw/virtio/dataplane/vring.c is messy. Structs are allocated in different files than they are freed in. This is risky and makes memory leaks easier. Embed VirtQueueElement in VirtIOBlockReq to reduce the amou

[Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified virtio-blk request handling

2014-07-01 Thread Stefan Hajnoczi
This series fixes issues recently introduced when unifying virtio-blk dataplane's request handling with non-dataplane virtio-blk. The problems include broken memory allocation for dataplane requests and a performance regression for non-dataplane. See the patches for details. Stefan Hajnoczi (4):

[Qemu-devel] [PATCH v2 1/4] virtio-blk: avoid dataplane VirtIOBlockReq early free

2014-07-01 Thread Stefan Hajnoczi
VirtIOBlockReq is freed later by virtio_blk_free_request() in hw/block/virtio-blk.c. Remove this extraneous g_slice_free(). This patch fixes the following segfault: 0x556373af in virtio_blk_rw_complete (opaque=0x565ff5e0, ret=0) at hw/block/virtio-blk.c:99 99 bdrv_acct_

[Qemu-devel] [PATCH v2 2/4] dataplane: do not free VirtQueueElement in vring_push()

2014-07-01 Thread Stefan Hajnoczi
VirtQueueElement is allocated in vring_pop() so it seems to make sense that vring_push() should free it. Alas, virtio-blk frees VirtQueueElement itself in virtio_blk_free_request(). This patch solves a double-free assertion in glib's g_slice_free(). Rename vring_free_element() to vring_unmap_ele

  1   2   3   4   >