Re: [Qemu-devel] [PATCH 1/3 v3] ppc: spapr-rtas - implement os-term rtas call

2014-06-26 Thread Alexey Kardashevskiy
On 06/27/2014 04:47 PM, Nikunj A Dadhania wrote: > PAPR compliant guest calls this in absence of kdump. This finally > reaches the guest and can be handled according to the policies set by > higher level tools(like taking dump) for further analysis by tools like > crash. > > Linux kernel calls thi

[Qemu-devel] [PATCH 1/3 v3] ppc: spapr-rtas - implement os-term rtas call

2014-06-26 Thread Nikunj A Dadhania
PAPR compliant guest calls this in absence of kdump. This finally reaches the guest and can be handled according to the policies set by higher level tools(like taking dump) for further analysis by tools like crash. Linux kernel calls this only when the extended version of os,term is implemented to

[Qemu-devel] [PATCH 2/3] spapr: add uuid/host details to device tree

2014-06-26 Thread Nikunj A Dadhania
Useful for identifying the guest/host uniquely within the guest. Adding following properties to the guest root node. vm,uuid - uuid of the guest host-model - Host model number host-serial - Host machine serial number hypervisor type - Tells its "kvm" Signed-off-by: Nikunj A Dadhania --- hw/ppc/

[Qemu-devel] [PATCH 3/3] ppc/spapr: Fix MAX_CPUS to 255

2014-06-26 Thread Nikunj A Dadhania
MAX_CPUS 256 is inconsistent with qemu supporting upto 255 cpus. This MAX_CPUS number was percolated back to "virsh capabilities" with wrong max_cpus. Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/s

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-26 Thread Kevin Wolf
Am 27.06.2014 um 06:59 hat Paolo Bonzini geschrieben: > Il 27/06/2014 03:15, Ming Lei ha scritto: > >On Thu, Jun 26, 2014 at 11:57 PM, Paolo Bonzini wrote: > >>We can implement (advisory) calls like bdrv_plug/bdrv_unplug in order to > >>restore the previous levels of performance. > > > >Yes, that

Re: [Qemu-devel] Reverse execution and deterministic replay

2014-06-26 Thread Pavel Dovgaluk
> -Original Message- > From: peter.crosthwa...@petalogix.com > [mailto:peter.crosthwa...@petalogix.com] On Behalf Of > Peter Crosthwaite > Sent: Friday, June 27, 2014 10:11 AM > To: Pavel Dovgaluk; Fréderic Konrad > Cc: qemu-devel@nongnu.org Developers; Paolo Bonzini > Subject: Re: [Qemu-d

Re: [Qemu-devel] Reverse execution and deterministic replay

2014-06-26 Thread Peter Crosthwaite
Hi Pavel, On Fri, Jun 27, 2014 at 3:18 PM, Pavel Dovgaluk wrote: > Hello! > > We want to publish set of patches related to the reverse execution and > deterministic replay of qemu. > Our implementation of deterministic replay can be used for deterministic and > reverse debugging of > guest code

Re: [Qemu-devel] [PATCH 5/5 v5] ppc: Add hw breakpoint watchpoint support

2014-06-26 Thread bharat.bhus...@freescale.com
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, June 26, 2014 3:52 PM > To: Bhushan Bharat-R65777 > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; ma...@linux.vnet.ibm.com > Subject: Re: [PATCH 5/5 v5] ppc: Add hw breakpoint watchpoint support > > >

Re: [Qemu-devel] [PATCH] tcg/ppc: Fix failure in tcg_out_mem_long

2014-06-26 Thread Cedric Le Goater
On 06/27/2014 06:26 AM, Richard Henderson wrote: > With rt != r0 on loads, we use rt for scratch. If we need an index > register different from base, we can't use rt, but r0 is usable. That fixes the problem : a x86_64 fedora 20 TCG guest now runs under a the latest qemu, (trusty ppc64le host)

Re: [Qemu-devel] About AddressSpace in intel-iommu emulation

2014-06-26 Thread Le Tan
2014-06-27 12:55 GMT+08:00 Paolo Bonzini : > Il 27/06/2014 04:08, Le Tan ha scritto: > >> 1. In struct IOMMUTLBEntry, I think the addr_mask field should be the >> mask of the page offset, right? But I see different usages of this >> field. In spapr_tce_translate_iommu(), the addr_mask field is assi

[Qemu-devel] Reverse execution and deterministic replay

2014-06-26 Thread Pavel Dovgaluk
Hello! We want to publish set of patches related to the reverse execution and deterministic replay of qemu. Our implementation of deterministic replay can be used for deterministic and reverse debugging of guest code through gdb remote interface. Execution recording writes non-deterministic eve

Re: [Qemu-devel] [PATCH v3] vhost-user: fix regions provied with VHOST_USER_SET_MEM_TABLE message

2014-06-26 Thread Nikolay Nikolaev
On Fri, Jun 27, 2014 at 12:01 AM, Damjan Marion wrote: > Old code was affected by memory gaps which resulted in buffer pointers > pointing to address outside of the mapped regions. > > Here we are introducing following changes: > - new function qemu_get_ram_block_host_ptr() returns host pointer

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-26 Thread Paolo Bonzini
Il 27/06/2014 03:15, Ming Lei ha scritto: On Thu, Jun 26, 2014 at 11:57 PM, Paolo Bonzini wrote: We can implement (advisory) calls like bdrv_plug/bdrv_unplug in order to restore the previous levels of performance. Yes, that is also what I am thinking, or interfaces like bdrv_queue_io() and bd

Re: [Qemu-devel] About AddressSpace in intel-iommu emulation

2014-06-26 Thread Paolo Bonzini
Il 27/06/2014 04:08, Le Tan ha scritto: 1. In struct IOMMUTLBEntry, I think the addr_mask field should be the mask of the page offset, right? But I see different usages of this field. In spapr_tce_translate_iommu(), the addr_mask field is assigned with the mask of the page offset. However, in pbm

Re: [Qemu-devel] [PATCH for-2.1 v3 1/2] virtio-serial: report frontend connection state via monitor

2014-06-26 Thread Amit Shah
On (Thu) 26 Jun 2014 [17:50:02], Laszlo Ersek wrote: > Libvirt wants to know about the guest-side connection state of some > virtio-serial ports (in particular the one(s) assigned to guest agent(s)). > Report such states with a new monitor event. > > RHBZ: https://bugzilla.redhat.com/show_bug.cgi?

[Qemu-devel] [PATCH] tcg/ppc: Fix failure in tcg_out_mem_long

2014-06-26 Thread Richard Henderson
With rt != r0 on loads, we use rt for scratch. If we need an index register different from base, we can't use rt, but r0 is usable. Signed-off-by: Richard Henderson --- This ought to fix the problem that Greg reported. That we need to use --enable-debug-tcg to see the assert, and that I didn't

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-06-26 Thread Hu Tao
On Thu, Jun 26, 2014 at 10:55:33AM -0600, Eric Blake wrote: > On 06/26/2014 12:13 AM, Hu Tao wrote: > > We already have ROUND_UP but there are similar macros and ROUND_UP-like > > lines all around, replace them with ROUND_UP and clean up similar macros. > > > > Signed-off-by: Hu Tao > > --- > >

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-06-26 Thread Hu Tao
On Thu, Jun 26, 2014 at 05:52:45AM -0600, Eric Blake wrote: > On 06/26/2014 12:13 AM, Hu Tao wrote: > > We already have ROUND_UP but there are similar macros and ROUND_UP-like > > lines all around, replace them with ROUND_UP and clean up similar macros. > > Not a review (yet), but a question - how

Re: [Qemu-devel] [PATCH V3] qemu-img create: add 'nocow' option

2014-06-26 Thread Chun Yan Liu
Hi, Stefan & Kevin, Could you help to have a look at this version? We've discussed about this last November and now switch it to QemuOpts. Thanks, Chunyan >>> On 6/23/2014 at 05:17 PM, in message <1403515022-24802-1-git-send-email-cy...@suse.com>, Chunyan Liu wrote: > Add 'nocow' option so tha

Re: [Qemu-devel] [PATCH 3/3] numa: Reject configuration if not all node IDs are present

2014-06-26 Thread Hu Tao
On Thu, Jun 26, 2014 at 06:33:20PM -0300, Eduardo Habkost wrote: > We don't support sparse NUMA node IDs yet, so this changes QEMU to > reject configs where not all nodes are present. > > Signed-off-by: Eduardo Habkost > --- > numa.c | 17 - > 1 file changed, 16 insertions(+), 1

Re: [Qemu-devel] [PATCH 2/3] numa: Reject duplicate node IDs

2014-06-26 Thread Hu Tao
On Thu, Jun 26, 2014 at 06:33:19PM -0300, Eduardo Habkost wrote: > The same nodeid shouldn't appear multiple times in the command-line. > > In addition to detecting command-line mistakes, this will fix a bug > where nb_numa_nodes may become larger than MAX_NODES (and cause > out-of-bounds access o

[Qemu-devel] Some mistakes(?)in wiki

2014-06-26 Thread Lb peace
http://wiki.qemu.org/Features/ResetAPI: system reseta hardware mechanism for setting or returning all hardware states to the initial conditions.* Use caseIn qemu, system_system_reset(). cold reset(power on reset)system reset following the application of power. * Use caseIn qemu, system_reset()

Re: [Qemu-devel] [PATCH 1/3] numa: Keep track of NUMA nodes present on the command-line

2014-06-26 Thread Hu Tao
On Thu, Jun 26, 2014 at 06:33:18PM -0300, Eduardo Habkost wrote: > Based on "enable sparse node numbering" patch from Nishanth Aravamudan, > but without the code to actually support sparse node IDs. This just adds > the code to keep track of present/non-present nodes on the command-line, > without

Re: [Qemu-devel] About AddressSpace in intel-iommu emulation

2014-06-26 Thread Le Tan
2014-06-26 22:05 GMT+08:00 Paolo Bonzini : > Il 26/06/2014 16:01, Le Tan ha scritto: > >> Hi Paolo, >> I am adding intel-iommu emulation to q35 for the GSoC project. I am >> confused about AddressSpace and I believe that you can help me. :) >> 1. For intel-iommu emulation, I have to read the transl

[Qemu-devel] A grammar mistake in wiki

2014-06-26 Thread Lb peace
http://wiki.qemu.org/Features/PostCopyLiveMigration in description: “This is is yet” should be changed to "This is "Or "It is "

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-26 Thread Ming Lei
On Thu, Jun 26, 2014 at 11:57 PM, Paolo Bonzini wrote: > This is indeed a difference between the ioq-based and block-based backends. > ioq could submit more than one request with the same io_submit system call. > Yes, I have been thinking that is advantage of qemu virtio dataplane, but it isn't a

Re: [Qemu-devel] [PATCH v1 1/1] timer: candence_ttc: Convert to realize()

2014-06-26 Thread Alistair Francis
On Thu, Jun 26, 2014 at 11:29 PM, Peter Maydell wrote: > On 24 June 2014 05:41, Peter Crosthwaite wrote: >> Subject should read: >> >> "convert to Object::init()" >> >> On Tue, Jun 24, 2014 at 2:24 PM, Alistair Francis >> wrote: >>> SysBusDevice::init is deprecated. Convert to Object::init >>> a

Re: [Qemu-devel] [PATCH v2 5/7] target-arm: Remove old code and replace with new functions

2014-06-26 Thread Alistair Francis
On Thu, Jun 26, 2014 at 9:38 PM, Peter Crosthwaite wrote: > On Thu, Jun 26, 2014 at 3:02 PM, Alistair Francis > wrote: >> Remove the old PMCCNTR code and replace it with calls to the new >> pmccntr_sync() function and the CCNT_ENABLED macro > > arm_ccnt_enabled() function. > >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH v2 0/4] Fix pxa2xx/strongarm missing vmstate

2014-06-26 Thread Peter Crosthwaite
On Thu, Jun 26, 2014 at 9:42 PM, Peter Maydell wrote: > This patchseries fixes some cases for pxa2xx and strongarm > where we'd defined a vmstate struct but forgotten to actually > register it (caught by new warnings in clang 3.4). > > As a prerequisite (suggested by Peter Crosthwaite) we clean >

Re: [Qemu-devel] [PATCH v1 1/1] char: cadence_uart: Convert to realize()

2014-06-26 Thread Peter Crosthwaite
On Tue, Jun 24, 2014 at 4:06 PM, Alistair Francis wrote: > SysBusDevice::init is deprecated. Convert to Object::init and > Device::realize as prescribed by QOM conventions. > > Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite CC Peter for target-arm. Regards, Peter > --- > > h

[Qemu-devel] [PATCH] ahci.c: mask the interrupt on complete flag to allow ahci.c to read the correct size for the PRDT

2014-06-26 Thread Reza Jelveh
Signed-off-by: Reza Jelveh --- hw/ide/ahci.c | 11 --- hw/ide/ahci.h | 2 ++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 9bae22e..ee3613f 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -639,6 +639,11 @@ static void ahci_write_fis

Re: [Qemu-devel] [PATCH for 2.1 v3 0/2] block: Fix unset "filename" for certain drivers

2014-06-26 Thread Eric Blake
On 06/26/2014 03:38 PM, Max Reitz wrote: > For some protocol block drivers, the "filename" attribute in their BDSs > is unset due to bdrv_file_open() removing it from the options QDict > before bdrv_open_common() is able to copy it into the BDS. Fix this by > not removing it until until bdrv_open_c

Re: [Qemu-devel] [PATCH for 2.1 0/3] Validate NUMA node IDs (reject duplicate/missing node IDs properly)

2014-06-26 Thread Eric Blake
On 06/26/2014 03:33 PM, Eduardo Habkost wrote: > This is just a cleanup to make sure QEMU validate the NUMA node IDs on the Yay - this counts as a bug fix, so good for inclusion in 2.1. > command-line. After that, we may eventually change the code to accept sparse > node IDs under some circumstan

Re: [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1

2014-06-26 Thread Max Reitz
On 26.06.2014 23:46, Eric Blake wrote: On 06/26/2014 03:17 PM, Max Reitz wrote: On 25.06.2014 16:35, Kevin Wolf wrote: This is the first part of an attempt for disentangling bdrv_open(). At the end of this series, bdrv_open() code is somewhat easier to read, but the real changes (including some

Re: [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1

2014-06-26 Thread Eric Blake
On 06/26/2014 03:17 PM, Max Reitz wrote: > On 25.06.2014 16:35, Kevin Wolf wrote: >> This is the first part of an attempt for disentangling bdrv_open(). At >> the end >> of this series, bdrv_open() code is somewhat easier to read, but the real >> changes (including some bug fixes and changes of beh

Re: [Qemu-devel] [PATCH v4 0/6] iotests: Allow out-of-tree run

2014-06-26 Thread Max Reitz
On 07.06.2014 23:21, Max Reitz wrote: On 24.05.2014 23:24, Max Reitz wrote: This series enables qemu-iotests to be run in a build tree outside of the source tree. It also makes the tests use the command for invoking the Python interpreter specified through configure instead of always using "/usr

[Qemu-devel] [PATCH v3 2/2] iotests: Add test for set "filename" for NBD

2014-06-26 Thread Max Reitz
Add a new test for qemu-iotests which checks whether the "filename" (and consequently the "file") attribute is set for images which are opened over NBD. Signed-off-by: Max Reitz --- tests/qemu-iotests/097 | 72 ++ tests/qemu-iotests/097.out | 13 ++

[Qemu-devel] [PATCH v3 1/2] block: Do not prematurely remove "filename"

2014-06-26 Thread Max Reitz
If "filename" is removed from the options QDict before entering bdrv_open_common(), it cannot be stored in the BDS. Therefore, wait until it has been copied there and remove it from the options only afterwards. This fixes "filename" in the BDS being empty for block drivers which do not need the f

[Qemu-devel] [PATCH v3 0/2] block: Fix unset "filename" for certain drivers

2014-06-26 Thread Max Reitz
For some protocol block drivers, the "filename" attribute in their BDSs is unset due to bdrv_file_open() removing it from the options QDict before bdrv_open_common() is able to copy it into the BDS. Fix this by not removing it until until bdrv_open_common() has indeed copied it. v3: - Patch 1: R

[Qemu-devel] [PATCH 2/3] numa: Reject duplicate node IDs

2014-06-26 Thread Eduardo Habkost
The same nodeid shouldn't appear multiple times in the command-line. In addition to detecting command-line mistakes, this will fix a bug where nb_numa_nodes may become larger than MAX_NODES (and cause out-of-bounds access on the numa_info array). Signed-off-by: Eduardo Habkost --- numa.c | 5 ++

[Qemu-devel] [PATCH 0/3] Validate NUMA node IDs (reject duplicate/missing node IDs properly)

2014-06-26 Thread Eduardo Habkost
This is just a cleanup to make sure QEMU validate the NUMA node IDs on the command-line. After that, we may eventually change the code to accept sparse node IDs under some circumstances (but I am not sure that would be material for QEMU 2.1). Cc: Nishanth Aravamudan Cc: "Michael S. Tsirkin" Cc:

[Qemu-devel] [PATCH 1/3] numa: Keep track of NUMA nodes present on the command-line

2014-06-26 Thread Eduardo Habkost
Based on "enable sparse node numbering" patch from Nishanth Aravamudan, but without the code to actually support sparse node IDs. This just adds the code to keep track of present/non-present nodes on the command-line, without changing any behavior. Signed-off-by: Nishanth Aravamudan [Rename max_n

[Qemu-devel] [PATCH 3/3] numa: Reject configuration if not all node IDs are present

2014-06-26 Thread Eduardo Habkost
We don't support sparse NUMA node IDs yet, so this changes QEMU to reject configs where not all nodes are present. Signed-off-by: Eduardo Habkost --- numa.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/numa.c b/numa.c index e93407a..96fe5dd 100644 --- a/n

Re: [Qemu-devel] [old BUG]: -watchdog-action pause hangs QEMU

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 22:19, Luiz Capitulino ha scritto: Here goes a gdb backtrace: #0 0x7f298ce31759 in syscall () from /lib64/libc.so.6 #1 0x7f29939b0b56 in futex_wait (ev=0x7f2994548f18, val=4294967295) at /home/lcapitulino/work/src/upstream/qmp-unstable/util/qemu-thread-posix.c:304 #2

Re: [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1

2014-06-26 Thread Max Reitz
On 25.06.2014 16:35, Kevin Wolf wrote: This is the first part of an attempt for disentangling bdrv_open(). At the end of this series, bdrv_open() code is somewhat easier to read, but the real changes (including some bug fixes and changes of behaviour) haven't happened yet. Just sending out the f

[Qemu-devel] [PATCH v3] vhost-user: fix regions provied with VHOST_USER_SET_MEM_TABLE message

2014-06-26 Thread Damjan Marion
Old code was affected by memory gaps which resulted in buffer pointers pointing to address outside of the mapped regions. Here we are introducing following changes: - new function qemu_get_ram_block_host_ptr() returns host pointer to the ram block, it is needed to calculate offset of specific

[Qemu-devel] [old BUG]: -watchdog-action pause hangs QEMU

2014-06-26 Thread Luiz Capitulino
Hi Richard, If setup qemu to use a watchdog with action pause, like this: # qemu [...] -watchdog i6300esb -watchdog-action pause qemu will completely hang when the watchdog fires. I started trying to bisect, but I went as down as qemu v1.7.0 and the bug exists there. Here goes a gdb backtrace:

Re: [Qemu-devel] [PATCH v2 1/2] block: Do not prematurely remove "filename"

2014-06-26 Thread Max Reitz
On 26.06.2014 22:01, Max Reitz wrote: On 26.06.2014 21:46, Eric Blake wrote: On 06/26/2014 01:09 PM, Max Reitz wrote: If "filename" is removed from the options QDict before entering bdrv_open_common(), it cannot be stored in the BDS. Therefore, wait until it has been copied there and remove it

Re: [Qemu-devel] [PATCH for-2.1 v3 0/2] help libvirt know what's up with qga

2014-06-26 Thread Laszlo Ersek
On 06/26/14 22:16, Laszlo Ersek wrote: > 2014-06-26 15:41:37.895+: 1637: debug : > qemuMonitorJSONIOProcessLine:172 : QEMU_MONITOR_RECV_EVENT: > mon=0x7f2e2400cfd0 event={"timestamp": {"seconds": 1403797297, > "microseconds": 895242}, "event": "VSERPORT_CHANGE", "data": {"open": > true, "id":

Re: [Qemu-devel] [PATCH for-2.1 v3 0/2] help libvirt know what's up with qga

2014-06-26 Thread Laszlo Ersek
On 06/26/14 18:37, Eric Blake wrote: > On 06/26/2014 09:50 AM, Laszlo Ersek wrote: >> Changes in v3: patch 1 creates the event with a "bool" field called >> "open" in the data portion, instead of introducing a two-valued enum. >> Patch 2 is left intact. Retested. >> >> Laszlo Ersek (2): >> virtio

Re: [Qemu-devel] Why I advise against using ivshmem

2014-06-26 Thread Cam Macdonell
Hello, Just to add my two bits. I will fully support getting all the necessary parts of ivshmem into tree where appropriate, both qemu and a driver in Linux. I understand those concerns. I do not have the time to fully maintain ivshmem at the level needed, but I will help as much as I can. Sor

Re: [Qemu-devel] [PATCH v2 1/2] block: Do not prematurely remove "filename"

2014-06-26 Thread Max Reitz
On 26.06.2014 21:46, Eric Blake wrote: On 06/26/2014 01:09 PM, Max Reitz wrote: If "filename" is removed from the options QDict before entering bdrv_open_common(), it cannot be stored in the BDS. Therefore, wait until it has been copied there and remove it from the options only afterwards. This

Re: [Qemu-devel] [PULL] Merge ppc32/ppc64 tcg backends

2014-06-26 Thread Richard Henderson
On 06/26/2014 06:51 AM, Andreas Färber wrote: > I assume this pull broke ppc64 support on Mac OS X. It now says #error > "Unsupported abi" (1734) plus errors about LINK_AREA_SIZE (1763) and > LR_OFFSET (1775), all in tcg/ppc/tcg-target.c. It used to build and work > okay before. Yep, Peter's got a

Re: [Qemu-devel] [RFC UNTESTED] tcg/ppc: Fix support for 64-bit PPC MacOSX hosts

2014-06-26 Thread Richard Henderson
On 06/26/2014 08:37 AM, Peter Maydell wrote: > +++ b/tcg/ppc/tcg-target.c > @@ -1716,6 +1716,9 @@ static void tcg_out_qemu_st(TCGContext *s, const TCGArg > *args, bool is_64) > # define LINK_AREA_SIZE(6 * SZR) > # define LR_OFFSET (1 * SZR) > # define TCG_TAR

Re: [Qemu-devel] [PATCH v2 1/2] block: Do not prematurely remove "filename"

2014-06-26 Thread Eric Blake
On 06/26/2014 01:09 PM, Max Reitz wrote: > If "filename" is removed from the options QDict before entering > bdrv_open_common(), it cannot be stored in the BDS. Therefore, wait > until it has been copied there and remove it from the options only > afterwards. > > This fixes "filename" in the BDS b

Re: [Qemu-devel] [RFC PATCH v3] numa: enable sparse node numbering

2014-06-26 Thread Eduardo Habkost
On Tue, Jun 24, 2014 at 10:40:38AM -0700, Nishanth Aravamudan wrote: > Sparse node numbering occurs on powerpc in practice under PowerVM. In > order to emulate the same NUMA topology under qemu, the assumption that > NUMA nodes are linearly ordered has to be removed. qemu actually already > support

[Qemu-devel] [PATCH v2 1/2] block: Do not prematurely remove "filename"

2014-06-26 Thread Max Reitz
If "filename" is removed from the options QDict before entering bdrv_open_common(), it cannot be stored in the BDS. Therefore, wait until it has been copied there and remove it from the options only afterwards. This fixes "filename" in the BDS being empty for block drivers which do not need the fi

[Qemu-devel] [PATCH v2 2/2] iotests: Add test for set "filename" for NBD

2014-06-26 Thread Max Reitz
Add a new test for qemu-iotests which checks whether the "filename" (and consequently the "file") attribute is set for images which are opened over NBD. Signed-off-by: Max Reitz --- tests/qemu-iotests/097 | 72 ++ tests/qemu-iotests/097.out | 13 ++

[Qemu-devel] [PATCH v2 0/2] block: Fix unset "filename" for certain drivers

2014-06-26 Thread Max Reitz
For some protocol block drivers, the "filename" attribute in their BDSs is unset due to bdrv_file_open() removing it from the options QDict before bdrv_open_common() is able to copy it into the BDS. Fix this by not removing it until until bdrv_open_common() has indeed copied it. v2: - Patch 1: O

Re: [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers

2014-06-26 Thread Max Reitz
On 23.06.2014 10:35, Stefan Hajnoczi wrote: On Wed, Jun 18, 2014 at 12:14:08AM +0200, Max Reitz wrote: For some protocol block drivers, the "filename" attribute in their BDSs is unset due to bdrv_file_open() removing it from the options QDict before bdrv_open_common() is able to copy it into the

Re: [Qemu-devel] [RFC PATCH v3] numa: enable sparse node numbering

2014-06-26 Thread Eduardo Habkost
On Thu, Jun 26, 2014 at 10:58:07AM -0700, Nishanth Aravamudan wrote: > On 26.06.2014 [17:09:25 +0800], Hu Tao wrote: > > On Wed, Jun 25, 2014 at 09:23:17PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Jun 25, 2014 at 01:52:56PM -0300, Eduardo Habkost wrote: > > > > On Wed, Jun 25, 2014 at 09:13:5

Re: [Qemu-devel] [RFC PATCH v3] numa: enable sparse node numbering

2014-06-26 Thread Nishanth Aravamudan
On 26.06.2014 [17:09:25 +0800], Hu Tao wrote: > On Wed, Jun 25, 2014 at 09:23:17PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 25, 2014 at 01:52:56PM -0300, Eduardo Habkost wrote: > > > On Wed, Jun 25, 2014 at 09:13:59AM -0700, Nishanth Aravamudan wrote: > > > > On 25.06.2014 [13:21:34 +0200],

[Qemu-devel] [PATCH] target-arm: Implement vCPU reset via KVM_ARM_VCPU_INIT for 32-bit CPUs

2014-06-26 Thread Peter Maydell
Implement kvm_arm_vcpu_init() as a simple call to arm_arm_vcpu_init() (which uses the KVM_ARM_VCPU_INIT vcpu ioctl to tell the kernel to re-initialize the vCPU), rather than via the complicated code which saves a copy of the register state on first init and then writes it back to the kernel. This i

[Qemu-devel] [Bug 1334397] Re: cmos RTC alarms no longer wake system from suspend

2014-06-26 Thread John Stultz
I went back and tried the 1.7 and 1.6 releases, and they both seem to have been broken as well wrt cmos alarms waking from suspend. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1334397 Title: cmos

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-06-26 Thread Don Slutz
On 06/26/14 04:23, Chen, Tiejun wrote: On 2014/6/26 10:00, Chen, Tiejun wrote: On 2014/6/26 7:04, Slutz, Donald Christopher wrote: On 06/24/14 22:49, Chen, Tiejun wrote: On 2014/5/19 19:22, Gerd Hoffmann wrote: Hi, Gerd, Sorry I return this discussion again. As we discussed here, we

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-06-26 Thread Eric Blake
On 06/26/2014 12:13 AM, Hu Tao wrote: > We already have ROUND_UP but there are similar macros and ROUND_UP-like > lines all around, replace them with ROUND_UP and clean up similar macros. > > Signed-off-by: Hu Tao > --- All of these conversions are correct, so: Reviewed-by: Eric Blake However,

Re: [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API

2014-06-26 Thread Fam Zheng
Subject better have a component prefix "[PATCH] tests: Functions bus_foreach and device_find from libqos virtio API". See also "git log tests/". Fam On Thu, 06/26 16:34, Marc Marí wrote: > Virtio header has been changed to compile and work with a real device. > Functions bus_foreach and device_

Re: [Qemu-devel] [PATCH for-2.1 v3 0/2] help libvirt know what's up with qga

2014-06-26 Thread Eric Blake
On 06/26/2014 09:50 AM, Laszlo Ersek wrote: > Changes in v3: patch 1 creates the event with a "bool" field called > "open" in the data portion, instead of introducing a two-valued enum. > Patch 2 is left intact. Retested. > > Laszlo Ersek (2): > virtio-serial: report frontend connection state vi

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-26 Thread Eric Blake
On 06/26/2014 07:25 AM, Paolo Bonzini wrote: > Il 26/06/2014 15:17, Luiz Capitulino ha scritto: >>> > We're really close to hard freeze and by extension the release. Do >>> > _not_ strive for perfection. Get something that is mostly okay and is >>> > an obvious patch. We'll then have 3 weeks to

Re: [Qemu-devel] [PATCH] qmp: add qmp-events.txt back

2014-06-26 Thread Eric Blake
On 06/26/2014 07:43 AM, Luiz Capitulino wrote: > Fair enough. Here goes the patch. As each commit dropped a section of the > file, it was easier just to re-add it. ACKs wanted. > > Subject: [PATCH] qmp: add qmp-events.txt back > > The conversion of events to the QAPI, resulted in the removal of

Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 18:25, Eric Blake ha scritto: Actually, there is a second new event on queue right now: https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg06561.html Ok. FWIW, I consider that series a bugfix so it can go in after hard freeze. Same for the patch that lets management recon

[Qemu-devel] [Bug 1334397] Re: cmos RTC alarms no longer wake system from suspend

2014-06-26 Thread John Stultz
If a fix has already been committed, is there a branch or tag in the qemu git repo I should validate this with? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1334397 Title: cmos RTC alarms no longe

Re: [Qemu-devel] [PATCH v3 03/11] target-arm: implement SCTLR.B, drop bswap_code

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 16:53, Peter Maydell ha scritto: >> This will break running BE32 binaries with "-cpu any" >> (which sets all the features we know about, including >> ARM_FEATURE_V7). > > Yes, this was on purpose. I would expect that anybody running BE32 binaries is probably running them with -cpu

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-26 Thread Paolo Bonzini
This is indeed a difference between the ioq-based and block-based backends. ioq could submit more than one request with the same io_submit system call. We can implement (advisory) calls like bdrv_plug/bdrv_unplug in order to restore the previous levels of performance. Note that some fallout

Re: [Qemu-devel] [PATCH v5 1/4] block: Support Archipelago as a QEMU block backend

2014-06-26 Thread Chrysostomos Nanakos
On Thu, Jun 26, 2014 at 09:06:03AM -0600, Eric Blake wrote: > On 06/23/2014 06:32 AM, Chrysostomos Nanakos wrote: > > VM Image on Archipelago volume is specified like this: > > > > file=archipelago:[/mport=[:vport=][: > > segment=]] > > > > or > > > > file.driver=archipelago,file.volume=[,file.m

Re: [Qemu-devel] [PATCH 1/2] docs: update ivshmem device spec

2014-06-26 Thread Cam Macdonell
Hi Vince, Yes, I did see the patches for the new server. I will review within the week. Cheers, Cam On Thu, Jun 26, 2014 at 9:37 AM, Vincent JARDIN wrote: > Hi Cam, > > FYI, David did implement a new server. > http://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg04978.html > > which

[Qemu-devel] [PATCH for-2.1 v3 0/2] help libvirt know what's up with qga

2014-06-26 Thread Laszlo Ersek
Changes in v3: patch 1 creates the event with a "bool" field called "open" in the data portion, instead of introducing a two-valued enum. Patch 2 is left intact. Retested. Laszlo Ersek (2): virtio-serial: report frontend connection state via monitor char: report frontend open/closed state in '

[Qemu-devel] [PATCH for-2.1 v3 2/2] char: report frontend open/closed state in 'query-chardev'

2014-06-26 Thread Laszlo Ersek
In addition to the on-line reporting added in the previous patch, allow libvirt to query frontend state independently of events. Libvirt's path to identify the guest agent channel it cares about differs between the event added in the previous patch and the QMP response field added here. The event

[Qemu-devel] [PATCH for-2.1 v3 1/2] virtio-serial: report frontend connection state via monitor

2014-06-26 Thread Laszlo Ersek
Libvirt wants to know about the guest-side connection state of some virtio-serial ports (in particular the one(s) assigned to guest agent(s)). Report such states with a new monitor event. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1080376 Signed-off-by: Laszlo Ersek --- Notes: v3:

Re: [Qemu-devel] [RFC PATCH v5 00/13] Reverse execution.

2014-06-26 Thread Sebastian Tanase
Hello, I'll be sending a new version (V3) of the patches on Monday. The patches add QemuOpts handling to the "-icount option". If you want I can only send the part of the patch that adds QemuOpts support. Best regards, Sebastian Tanase - Mail original - > De: "Paolo Bonzini" > À: "Fr

Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR

2014-06-26 Thread Luiz Capitulino
On Thu, 26 Jun 2014 17:58:21 +0200 Markus Armbruster wrote: > Paolo Bonzini writes: > > > Il 26/06/2014 17:37, Markus Armbruster ha scritto: > >> Paolo Bonzini writes: > >> > >>> From: Wenchao Xia > >>> > >>> Signed-off-by: Wenchao Xia > >>> Signed-off-by: Paolo Bonzini > >> > >> This bro

Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR

2014-06-26 Thread Markus Armbruster
Paolo Bonzini writes: > Il 26/06/2014 17:37, Markus Armbruster ha scritto: >> Paolo Bonzini writes: >> >>> From: Wenchao Xia >>> >>> Signed-off-by: Wenchao Xia >>> Signed-off-by: Paolo Bonzini >> >> This broke tests/qemu-iotests/041. Apparently, the BLOCK_JOB_ERROR >> event changed from >>

Re: [Qemu-devel] [PATCH 2.1 00/36] Pending monitor patches for 2.1

2014-06-26 Thread Luiz Capitulino
On Thu, 26 Jun 2014 17:50:08 +0200 Markus Armbruster wrote: > Paolo Bonzini writes: > > > This includes: > > > > - Max's dependency fixes for QAPI scripts > > > > - Wenchao's QAPI event series > > > > - my thread-safety fixes, rebased onto QAPI events > > The QAPI event series messed up two ou

Re: [Qemu-devel] [PATCH 2.1 00/36] Pending monitor patches for 2.1

2014-06-26 Thread Markus Armbruster
Paolo Bonzini writes: > This includes: > > - Max's dependency fixes for QAPI scripts > > - Wenchao's QAPI event series > > - my thread-safety fixes, rebased onto QAPI events The QAPI event series messed up two out of three event types tested in qemu-iotests, if I count them correctly. How can w

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-26 Thread Ming Lei
On Thu, Jun 26, 2014 at 11:43 PM, Paolo Bonzini wrote: > Il 26/06/2014 17:37, Ming Lei ha scritto: > >> On Thu, Jun 26, 2014 at 11:29 PM, Paolo Bonzini >> wrote: >>> >>> Il 26/06/2014 17:14, Ming Lei ha scritto: >>> Hi Stefan, I found VM block I/O thoughput is decreased by more tha

[Qemu-devel] VNC memory corruption during resolution change

2014-06-26 Thread Peter Lieven
Hi all, while playing around with the vmware vga driver I noticed that there seems to be a race condition when the resolution is changed. I was able to trigger this also with std vga. Attached valgrind produces always an output similar to this: ==3346== Thread 1: ==3346== Invalid read of size 8

Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR

2014-06-26 Thread Luiz Capitulino
On Thu, 26 Jun 2014 17:40:57 +0200 Paolo Bonzini wrote: > Il 26/06/2014 17:37, Markus Armbruster ha scritto: > > Paolo Bonzini writes: > > > >> From: Wenchao Xia > >> > >> Signed-off-by: Wenchao Xia > >> Signed-off-by: Paolo Bonzini > > > > This broke tests/qemu-iotests/041. Apparently, th

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 17:37, Ming Lei ha scritto: On Thu, Jun 26, 2014 at 11:29 PM, Paolo Bonzini wrote: Il 26/06/2014 17:14, Ming Lei ha scritto: Hi Stefan, I found VM block I/O thoughput is decreased by more than 40% on my laptop, and looks much worsen in my server environment, and it is caused by

Re: [Qemu-devel] [PATCH] coroutine-win32.c: Add noinline attribute to work around gcc bug

2014-06-26 Thread Peter Maydell
On 23 June 2014 16:55, Richard Henderson wrote: > It's also > > Reviewed-by: Richard Henderson Thanks; applied to master. -- PMM

Re: [Qemu-devel] [PATCH 1/2] docs: update ivshmem device spec

2014-06-26 Thread Vincent JARDIN
Hi Cam, FYI, David did implement a new server. http://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg04978.html which is easier to maintain. Please, could you review his patch? He'll be back from holiday within 1 week. Best regards, Vincent PS: thanks for your comments

Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 17:37, Markus Armbruster ha scritto: > Paolo Bonzini writes: > >> From: Wenchao Xia >> >> Signed-off-by: Wenchao Xia >> Signed-off-by: Paolo Bonzini > > This broke tests/qemu-iotests/041. Apparently, the BLOCK_JOB_ERROR > event changed from > > {'timestamp': {'seconds': 14

Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-26 Thread Michael S. Tsirkin
On Thu, Jun 26, 2014 at 03:30:11PM +0200, Paolo Bonzini wrote: > Il 26/06/2014 13:36, Michael S. Tsirkin ha scritto: > >>It should be this way in real hardware too > >But it isn't. > > That's why I mentioned that this hack should become architecturally > specified (since it can work on real hardwa

Re: [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 16:34, Marc Marí ha scritto: +static void qvirtio_pci_foreach(uint16_t device_type, +void (*func)(QVirtioDevice *d, void *data), void *data) +{ +QVirtioPCIForeachData d = { .func = func, +.device_type = device_type, +

Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR

2014-06-26 Thread Markus Armbruster
Paolo Bonzini writes: > From: Wenchao Xia > > Signed-off-by: Wenchao Xia > Signed-off-by: Paolo Bonzini This broke tests/qemu-iotests/041. Apparently, the BLOCK_JOB_ERROR event changed from {'timestamp': {'seconds': 1403796871, 'microseconds': 446502}, 'data': {'device': 'drive0',

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-26 Thread Ming Lei
On Thu, Jun 26, 2014 at 11:29 PM, Paolo Bonzini wrote: > Il 26/06/2014 17:14, Ming Lei ha scritto: > >> Hi Stefan, >> >> I found VM block I/O thoughput is decreased by more than 40% >> on my laptop, and looks much worsen in my server environment, >> and it is caused by your commit 580b6b2aa2: >> >

[Qemu-devel] [RFC UNTESTED] tcg/ppc: Fix support for 64-bit PPC MacOSX hosts

2014-06-26 Thread Peter Maydell
Add back in the support for 64-bit PPC MacOSX hosts that was broken in the recent merge of the 32-bit and 64-bit TCG backends. Signed-off-by: Peter Maydell --- As per subject, this is totally untested since I don't have any PPC MacOSX hosts; numbers based on the documentation at https://developer

Re: [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 17:27, Marc Marí ha scritto: If these functions are just Virtio PCI specific, it makes sense to take them out. If they are common to other transports, in my opinion is better to leave them there. Of course, a good solution has to be found to just having a global bus variable. It is

Re: [Qemu-devel] [RFC PATCH v5 00/13] Reverse execution.

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 17:11, Frederic Konrad ha scritto: Are you talking of this patch on the list: http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg03039.html ? It seems to includes the "align" options too. Is that possible to split it up? Sure, you can split it up and when the original auth

Re: [Qemu-devel] [PATCH v5 3/3] sclp-s390: Add memory hotplug SCLPs

2014-06-26 Thread Matthew Rosato
On 06/26/2014 09:14 AM, Christian Borntraeger wrote: > On 25/06/14 16:27, Matthew Rosato wrote: >> Add memory information to read SCP info and add handlers for >> Read Storage Element Information, Attach Storage Element, >> Assign Storage and Unassign Storage. >> >> Signed-off-by: Matthew Rosato >

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 17:14, Ming Lei ha scritto: Hi Stefan, I found VM block I/O thoughput is decreased by more than 40% on my laptop, and looks much worsen in my server environment, and it is caused by your commit 580b6b2aa2: dataplane: use the QEMU block layer for I/O I run fio with below

  1   2   3   >