Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-20 Thread Benjamin Herrenschmidt
On Thu, 2014-06-19 at 11:36 +0200, Gerd Hoffmann wrote: > If not -- then I prefer to play save and not use a vbe register to avoid > ending up with two incompatible bochs interface revisions. If you don't > like the pci config space option -- the mmio bar has plenty of free > space left ;) I'll f

Re: [Qemu-devel] [PATCH 4/4] console: stop using PixelFormat

2014-06-20 Thread Benjamin Herrenschmidt
On Wed, 2014-06-18 at 14:23 +0200, Gerd Hoffmann wrote: > With this patch the qemu console core stops using PixelFormat and pixman > format codes side-by-side, pixman format code is the primary way to > specify the DisplaySurface format: > > * DisplaySurface stops carrying a PixelFormat field. >

Re: [Qemu-devel] [PATCH 3/7] spapr: Refactor spapr_populate_memory()

2014-06-20 Thread Alexey Kardashevskiy
On 06/21/2014 05:10 AM, Nishanth Aravamudan wrote: > On 16.06.2014 [17:53:49 +1000], Alexey Kardashevskiy wrote: >> Current QEMU does not support memoryless NUMA nodes. >> This prepares SPAPR for that. >> >> This moves 2 calls of spapr_populate_memory_node() into >> the existing loop which handles

Re: [Qemu-devel] [PATCH 3/7] spapr: Refactor spapr_populate_memory()

2014-06-20 Thread Alexey Kardashevskiy
On 06/21/2014 08:55 AM, Nishanth Aravamudan wrote: > On 16.06.2014 [17:53:49 +1000], Alexey Kardashevskiy wrote: >> Current QEMU does not support memoryless NUMA nodes. >> This prepares SPAPR for that. >> >> This moves 2 calls of spapr_populate_memory_node() into >> the existing loop which handles

Re: [Qemu-devel] [PULL 075/118] macio: handle non-block ATAPI DMA transfers

2014-06-20 Thread BALATON Zoltan
On Fri, 20 Jun 2014, Mark Cave-Ayland wrote: And also with ATAPI debugging enabled? I suspect the problem is with the interaction between the DMA/ATAPI systems again. I forgot that one. I've now rerun with DEBUG_IDE_ATAPI enabled. Here is with the patch failing: DBDMA: writel 0x0

Re: [Qemu-devel] [PATCH v3] qmp: add ACPI_DEVICE_OST event handling

2014-06-20 Thread Wenchao Xia
于 2014/6/20 23:46, Eric Blake 写道: On 06/20/2014 02:33 AM, Igor Mammedov wrote: emits event when ACPI OSPM evaluates _OST method of ACPI device. Signed-off-by: Igor Mammedov --- v2: - use new QAPI event infrastructure from rebased PCI tree on top of today's QMP pull request --- hw/ac

Re: [Qemu-devel] [PATCH 2.1 00/36] Pending monitor patches for 2.1

2014-06-20 Thread Wenchao Xia
于 2014/6/20 23:44, Eric Blake 写道: On 06/18/2014 12:43 AM, Paolo Bonzini wrote: This includes: - Max's dependency fixes for QAPI scripts - Wenchao's QAPI event series - my thread-safety fixes, rebased onto QAPI events Paolo monitor.c| 226 ++---

Re: [Qemu-devel] [PATCH 3/7] spapr: Refactor spapr_populate_memory()

2014-06-20 Thread Nishanth Aravamudan
On 16.06.2014 [17:53:49 +1000], Alexey Kardashevskiy wrote: > Current QEMU does not support memoryless NUMA nodes. > This prepares SPAPR for that. > > This moves 2 calls of spapr_populate_memory_node() into > the existing loop which handles nodes other than than > the first one. > > Signed-off-by

Re: [Qemu-devel] [PATCH] hw/arm: add a PL031 driver to the virt machine

2014-06-20 Thread Aurelien Jarno
On Fri, Jun 20, 2014 at 11:37:01PM +0100, Peter Maydell wrote: > On 20 June 2014 23:32, Aurelien Jarno wrote: > > We currently do no have a virtio device for the real time clock. Instead > > of having to fetch the date and time from an NTP server, provide a PL031 > > device in the virt machine. >

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: Provide PL031 RTC

2014-06-20 Thread Aurelien Jarno
On Tue, Jun 10, 2014 at 03:51:47PM +0100, Peter Maydell wrote: > UEFI mandates that the platform must include an RTC, so provide > one in 'virt', using the PL031. > > Signed-off-by: Peter Maydell > --- > hw/arm/virt.c | 30 ++ > 1 file changed, 30 insertions(+) > > d

[Qemu-devel] [PATCH] target-i386: simplify AES emulation

2014-06-20 Thread Aurelien Jarno
This patch simplifies the AES code, by directly accessing the newly added S-Box, InvS-Box and InvMixColumns tables instead of recreating them by using the AES_Te and AES_Td tables. Signed-off-by: Aurelien Jarno --- target-i386/ops_sse.h | 16 1 file changed, 8 insertions(+), 8

Re: [Qemu-devel] [PATCH] hw/arm: add a PL031 driver to the virt machine

2014-06-20 Thread Peter Maydell
On 20 June 2014 23:32, Aurelien Jarno wrote: > We currently do no have a virtio device for the real time clock. Instead > of having to fetch the date and time from an NTP server, provide a PL031 > device in the virt machine. Erm, I posted a patch for this the other week: http://patchwork.ozlabs.o

[Qemu-devel] [PATCH] hw/arm: add a PL031 driver to the virt machine

2014-06-20 Thread Aurelien Jarno
We currently do no have a virtio device for the real time clock. Instead of having to fetch the date and time from an NTP server, provide a PL031 device in the virt machine. Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- hw/arm/virt.c | 33 + 1 file change

Re: [Qemu-devel] [PATCH 01/12] target-mips: add KScratch registers

2014-06-20 Thread Aurelien Jarno
On Thu, Jun 19, 2014 at 03:45:32PM +0100, Leon Alrae wrote: > KScratch Registers (CP0 Register 31, Selects 2 to 7) > > The KScratch registers are read/write registers available for scratch pad > storage by kernel mode software. They are 32-bits in width for 32-bit > processors and 64-bits for 64-b

Re: [Qemu-devel] [PATCH v4] gt64xxx_pci: Add VMStateDescription

2014-06-20 Thread Aurelien Jarno
On Fri, Jun 20, 2014 at 02:59:58PM +0100, James Hogan wrote: > From: Sanjay Lal > > Add VMStateDescription for GT64120 PCI emulation used by the Malta > platform, to allow it to work with savevm/loadvm and live migration. > > The entire register array is saved/restored using VMSTATE_UINT32_ARRAY

Re: [Qemu-devel] [PATCH v2 17/22] target-mips: add new Floating Point Comparison instructions

2014-06-20 Thread Aurelien Jarno
On Wed, Jun 11, 2014 at 04:19:47PM +0100, Leon Alrae wrote: > From: Yongbok Kim > > Signed-off-by: Yongbok Kim > Signed-off-by: Leon Alrae > --- > disas/mips.c| 44 ++ > target-mips/helper.h| 27 ++ > target-mips/op_helper.c | 111 + > t

Re: [Qemu-devel] [PATCH v4 2/2] qga: Add guest-get-fsinfo command

2014-06-20 Thread Tomoki Sekiyama
On 6/20/14 11:21 , "Eric Blake" wrote: >On 06/19/2014 06:34 PM, Tomoki Sekiyama wrote: > +} +if (S_ISBLK(st.st_mode)) { +*devmajor = major(st.st_rdev); +*devminor = minor(st.st_rdev); >>> >>> major() and minor() are not POSIX functions. While they work

Re: [Qemu-devel] [PATCH v2 16/22] target-mips: add new Floating Point instructions

2014-06-20 Thread Aurelien Jarno
On Wed, Jun 11, 2014 at 04:19:46PM +0100, Leon Alrae wrote: > In terms of encoding MIPS32R6 MIN.fmt, MAX.fmt, MINA.fmt, MAXA.fmt replaced > MIPS-3D RECIP1, RECIP2, RSQRT1, RSQRT2 instructions. > > In R6 all Floating Point instructions are supposed to be IEEE-2008 compliant > i.e. FIR.HAS2008 alway

[Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

2014-06-20 Thread Peter Maydell
Convert the socket char backend to the new style QAPI framework; this allows it to return an Error ** to callers who might not want it to print directly about socket failures. Signed-off-by: Peter Maydell --- I'm not 100% sure I have this correct -- review from somebody who understands the char b

Re: [Qemu-devel] [PATCH v2 14/22] target-mips: add Addressing and PC-relative instructions

2014-06-20 Thread Aurelien Jarno
The patch subject is a bit misleading, as it also includes the AUI family. On Wed, Jun 11, 2014 at 04:19:44PM +0100, Leon Alrae wrote: > Signed-off-by: Leon Alrae > --- > disas/mips.c| 42 +- > target-mips/translate.c | 198 > -

Re: [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD

2014-06-20 Thread Ed Maste
On 18 June 2014 11:22, Andreas Färber wrote: > Am 18.06.2014 16:41, schrieb Paolo Bonzini: >> Il 18/06/2014 14:58, Ed Maste ha scritto: >>> Signed-off-by: Ed Maste >>> --- >>> libcacard/vscclient.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/libcacard/vscclient.c b/libcacard

Re: [Qemu-devel] [PULL for-2.1 00/40] QMP queue

2014-06-20 Thread Eric Blake
On 06/20/2014 01:49 PM, Paolo Bonzini wrote: > > As I explained on IRC, many patches when rebased would have conflicts > with Igor's new event. I think this is much more complex than having > an "extraordinary" merge commit. > > I include the conflict resolution: > > - hw/acpi/memory-hotplug

[Qemu-devel] [PATCH for-2.2 v3 3/3] nbd: Follow the BDS' AIO context

2014-06-20 Thread Max Reitz
Keep the NBD server always in the same AIO context as the exported BDS by calling bdrv_add_aio_context_notifier() and implementing the required callbacks. Signed-off-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- nbd.c | 31 +++ 1 file changed, 31 insertions(+) diff

[Qemu-devel] [PATCH for-2.2 v3 2/3] block: Add AIO context notifiers

2014-06-20 Thread Max Reitz
If a long-running operation on a BDS wants to always remain in the same AIO context, it somehow needs to keep track of the BDS changing its context. This adds a function for registering callbacks on a BDS which are called whenever the BDS is attached or detached from an AIO context. Signed-off-by:

[Qemu-devel] [PATCH for-2.2 v3 1/3] nbd: Drop nbd_can_read()

2014-06-20 Thread Max Reitz
There is no variant of aio_set_fd_handler() like qemu_set_fd_handler2(), so we cannot give a can_read() callback function. Instead, unregister the nbd_read() function whenever we cannot read and re-register it as soon as we can read again. All this is hidden behind the functions nbd_set_handlers()

[Qemu-devel] [PATCH for-2.2 v3 0/3] nbd: Adapt for dataplane

2014-06-20 Thread Max Reitz
For the NBD server to work with dataplane, it needs to correctly access the exported BDS. It makes the most sense to run both in the same AioContext, therefore this series implements methods for tracking a BDS's AioContext and makes NBD make use of this for keeping the clients connected to that BDS

Re: [Qemu-devel] [PULL for-2.1 00/40] QMP queue

2014-06-20 Thread Paolo Bonzini
Il 20/06/2014 20:44, Luiz Capitulino ha scritto: > On Fri, 20 Jun 2014 19:24:48 +0100 > Peter Maydell wrote: > >> On 19 June 2014 20:39, Luiz Capitulino wrote: >>> The following changes since commit 6baa963f4dcc211801608ebe1e0482b51653350c: >>> >>> Merge remote-tracking branch 'remotes/bonzini

Re: [Qemu-devel] [PULL 075/118] macio: handle non-block ATAPI DMA transfers

2014-06-20 Thread Mark Cave-Ayland
On 20/06/14 20:17, BALATON Zoltan wrote: On Fri, 20 Jun 2014, Mark Cave-Ayland wrote: Zoltan, please can you test the attached patch to see if this still allows MorphOS to boot? Unfortunately it seems MorphOS cannot boot with this patch. It hangs while trying to read the TOC from the CD. Debu

Re: [Qemu-devel] [PULL 075/118] macio: handle non-block ATAPI DMA transfers

2014-06-20 Thread BALATON Zoltan
On Fri, 20 Jun 2014, Mark Cave-Ayland wrote: Zoltan, please can you test the attached patch to see if this still allows MorphOS to boot? Unfortunately it seems MorphOS cannot boot with this patch. It hangs while trying to read the TOC from the CD. Debug output with DEBUG_MACIO and DEBUG_DBDMA

Re: [Qemu-devel] [PULL for-2.1 00/40] QMP queue

2014-06-20 Thread Paolo Bonzini
Il 20/06/2014 20:44, Luiz Capitulino ha scritto: On Fri, 20 Jun 2014 19:24:48 +0100 Peter Maydell wrote: On 19 June 2014 20:39, Luiz Capitulino wrote: The following changes since commit 6baa963f4dcc211801608ebe1e0482b51653350c: Merge remote-tracking branch 'remotes/bonzini/scsi-next' into

Re: [Qemu-devel] [PATCH 3/7] spapr: Refactor spapr_populate_memory()

2014-06-20 Thread Nishanth Aravamudan
On 16.06.2014 [17:53:49 +1000], Alexey Kardashevskiy wrote: > Current QEMU does not support memoryless NUMA nodes. > This prepares SPAPR for that. > > This moves 2 calls of spapr_populate_memory_node() into > the existing loop which handles nodes other than than > the first one. > @@ -719,6 +70

Re: [Qemu-devel] [PULL 00/14] Pending KVM patches for 2.1

2014-06-20 Thread Peter Maydell
On 20 June 2014 13:11, Paolo Bonzini wrote: > The following changes since commit af44da87e926ff64260b95f4350d338c4fc113ca: > > Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' > into staging (2014-06-16 18:26:21 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PULL for-2.1 00/40] QMP queue

2014-06-20 Thread Luiz Capitulino
On Fri, 20 Jun 2014 19:24:48 +0100 Peter Maydell wrote: > On 19 June 2014 20:39, Luiz Capitulino wrote: > > The following changes since commit 6baa963f4dcc211801608ebe1e0482b51653350c: > > > > Merge remote-tracking branch 'remotes/bonzini/scsi-next' into staging > > (2014-06-19 16:18:04 +0100

Re: [Qemu-devel] [PATCH v10 6/6] qcow2: Add full image preallocation option

2014-06-20 Thread Max Reitz
On 20.06.2014 10:25, Hu Tao wrote: On Sat, Jun 14, 2014 at 10:37:33PM +0200, Max Reitz wrote: On 12.06.2014 05:54, Hu Tao wrote: This adds a preallocation=full mode to qcow2 image creation, which creates a non-sparse image file. Signed-off-by: Hu Tao --- block/qcow2.c | 90

Re: [Qemu-devel] [PULL for-2.1 00/40] QMP queue

2014-06-20 Thread Peter Maydell
On 19 June 2014 20:39, Luiz Capitulino wrote: > The following changes since commit 6baa963f4dcc211801608ebe1e0482b51653350c: > > Merge remote-tracking branch 'remotes/bonzini/scsi-next' into staging > (2014-06-19 16:18:04 +0100) > > are available in the git repository at: > > > git://repo.or.

Re: [Qemu-devel] [PULL v3] pc, pci, virtio, hotplug fixes, enhancements

2014-06-20 Thread Peter Maydell
On 19 June 2014 20:25, Michael S. Tsirkin wrote: > Resending. > Not reposting patches to avoid flooding the list. > > The following changes since commit 2edaf21b939eb3b7f058fbc3cb7f7e14d6262486: > > Merge remote-tracking branch 'remotes/bonzini/memory' into staging > (2014-06-18 15:08:38 +0100)

Re: [Qemu-devel] [PATCH] q35: Use PC_Q35_COMPAT_1_4 on pc-q35-1.4 compat_props

2014-06-20 Thread Eduardo Habkost
Ping? Is anybody going to apply this? On Fri, Jun 13, 2014 at 12:28:32AM -0300, Eduardo Habkost wrote: > pc-q35-1.4 was incorrectly using PC_COMPAT_1_4 instead of > PC_Q35_COMPAT_1_4. > > The only side-effect was that the hpet compat property (inherited from > PC_Q35_COMPAT_1_7) was missing. > >

Re: [Qemu-devel] problem using AHCI on xen fvm

2014-06-20 Thread Zhang, Eniac
Hi Stefano, You are a genius. Qemu2.0.0 works fine with my AHCI hack. Then I took a look at the patch. That fix is exactly what's missing in qemu 1.6.1. I ported back that one fix and all is working now. I am running full test now to make sure that's the right thing to do. Thanks for

Re: [Qemu-devel] [PATCH v2 1/3] nbd: Drop nbd_can_read()

2014-06-20 Thread Max Reitz
On 19.06.2014 05:58, Stefan Hajnoczi wrote: On Wed, Jun 18, 2014 at 09:06:41PM +0200, Max Reitz wrote: +static void nbd_update_can_read(NBDClient *client) +{ +bool can_read = client->recv_coroutine || +client->nb_requests < MAX_NBD_REQUESTS; + +if (can_read != client-

Re: [Qemu-devel] [PATCH v2 1/3] nbd: Drop nbd_can_read()

2014-06-20 Thread Max Reitz
On 19.06.2014 10:44, Paolo Bonzini wrote: Il 18/06/2014 21:06, Max Reitz ha scritto: +static void nbd_set_handlers(NBDClient *client) +{ +if (client->exp && client->exp->ctx) { +aio_set_fd_handler(client->exp->ctx, client->sock, + client->can_read ? nbd_read

Re: [Qemu-devel] [PULL 00/14] target-arm queue

2014-06-20 Thread Peter Maydell
On 19 June 2014 18:36, Peter Maydell wrote: > target-arm queue: mostly fairly minor stuff, apart from the PSCI > patches, which have been on the list for some time. > > I meant to put this out earlier in the week but got hit by an > urgent deadline... > > thanks > -- PMM > > The following changes

Re: [Qemu-devel] [PATCH v3 00/25] Merge ppc32/ppc64 tcg backends

2014-06-20 Thread Tom Musta
On 6/20/2014 9:13 AM, Richard Henderson wrote: > Tom Musta gave me a Tested-by > for v2 on an ELFv2 system; it might be worth re-doing that just in case. Done.

Re: [Qemu-devel] [PULL 0/3] vnc: cleanups and fixes

2014-06-20 Thread Peter Maydell
On 19 June 2014 12:03, Gerd Hoffmann wrote: > Hi, > > Here is the vnc patch queue, with one bugfix and two cleanups. > > please pull, > Gerd > > The following changes since commit d279279e2b5cd40dbcc863fb66a695990f304077: > > target-mips: implement UserLocal Register (2014-06-18 18:10:47 +02

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2014-06-20 Thread Luiz Capitulino
On Fri, 20 Jun 2014 16:57:11 +0100 Peter Maydell wrote: > On 20 June 2014 14:35, Luiz Capitulino wrote: > > On Fri, 20 Jun 2014 08:12:44 +0200 > > Gerd Hoffmann wrote: > > > >> Signed-off-by: Gerd Hoffmann > > > > Tested-by: Luiz Capitulino > > Thanks; applied directly to master as a buildfi

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2014-06-20 Thread Peter Maydell
On 20 June 2014 14:35, Luiz Capitulino wrote: > On Fri, 20 Jun 2014 08:12:44 +0200 > Gerd Hoffmann wrote: > >> Signed-off-by: Gerd Hoffmann > > Tested-by: Luiz Capitulino Thanks; applied directly to master as a buildfix. -- PMM

Re: [Qemu-devel] [PATCH v3] qmp: add ACPI_DEVICE_OST event handling

2014-06-20 Thread Eric Blake
On 06/20/2014 02:33 AM, Igor Mammedov wrote: > emits event when ACPI OSPM evaluates _OST method > of ACPI device. > > Signed-off-by: Igor Mammedov > --- > v2: > - use new QAPI event infrastructure > from rebased PCI tree on top of today's QMP pull request > --- > hw/acpi/memory_hotplug.c

Re: [Qemu-devel] [PATCH 2.1 00/36] Pending monitor patches for 2.1

2014-06-20 Thread Eric Blake
On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > This includes: > > - Max's dependency fixes for QAPI scripts > > - Wenchao's QAPI event series > > - my thread-safety fixes, rebased onto QAPI events > > Paolo > > monitor.c| 226 ++--- > qapi-event.json

Re: [Qemu-devel] [PATCH 3/3] tests: add human format test for string output visitor

2014-06-20 Thread Eric Blake
On 06/19/2014 11:55 PM, Hu Tao wrote: > Signed-off-by: Hu Tao > --- > tests/test-string-output-visitor.c | 109 > ++--- > 1 file changed, 90 insertions(+), 19 deletions(-) > > > +len = strlen(EnumOne_lookup[i]) + 2; > +str_human = g_malloc0(len

Re: [Qemu-devel] [PATCH 2/3] fixup! qapi/string-output-visitor: fix bugs

2014-06-20 Thread Eric Blake
On 06/19/2014 11:55 PM, Hu Tao wrote: > "0x1-0x10" looks better than "0x1-10" > > Signed-off-by: Hu Tao > --- > qapi/string-output-visitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visi

Re: [Qemu-devel] [PATCH] block: Make op blocker recursive

2014-06-20 Thread Eric Blake
On 06/19/2014 11:01 PM, Fam Zheng wrote: > On Thu, 06/19 22:20, Benoît Canet wrote: >> The Thursday 19 Jun 2014 à 14:13:20 (-0600), Eric Blake wrote : >>> On 06/19/2014 02:01 PM, Benoît Canet wrote: As the code will start to operate on arbitratry nodes we need the op blocker >>> >>> s/ar

Re: [Qemu-devel] [PATCH v4 2/2] qga: Add guest-get-fsinfo command

2014-06-20 Thread Eric Blake
On 06/19/2014 06:34 PM, Tomoki Sekiyama wrote: >>> +} >>> +if (S_ISBLK(st.st_mode)) { >>> +*devmajor = major(st.st_rdev); >>> +*devminor = minor(st.st_rdev); >> >> major() and minor() are not POSIX functions. While they work on Linux, >> and appear to have BSD origins, I s

Re: [Qemu-devel] [PULL] tcg patch queue

2014-06-20 Thread Peter Maydell
On 19 June 2014 00:33, Richard Henderson wrote: > Just one patch queued up this last couple of weeks. > > > r~ > > > The following changes since commit d279279e2b5cd40dbcc863fb66a695990f304077: > > target-mips: implement UserLocal Register (2014-06-18 18:10:47 +0200) > > are available in the git

[Qemu-devel] [PATCH v3 17/25] tcg-ppc64: Merge ppc32 qemu_ld/st

2014-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 293 +++-- 1 file changed, 209 insertions(+), 84 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 4b846a2..c55339c 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tc

[Qemu-devel] [PATCH v3 08/25] tcg-ppc64: Fix TCG_TARGET_CALL_STACK_OFFSET

2014-06-20 Thread Richard Henderson
The calling convention reserves space for the 8 register parameters on the stack, so using only 6*8=48 as the offset was wrong. We never saw this bug because we don't have any helpers with more than 5 parameters. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 2 +- 1 file changed

[Qemu-devel] [PATCH v5 01/18] migration: dump vmstate info as a json file for static analysis

2014-06-20 Thread Amit Shah
This commit adds a new command, '-dump-vmstate', that takes a filename as an argument. When executed, QEMU will dump the vmstate information for the machine type it's invoked with to the file, and quit. The JSON-format output can then be used to compare the vmstate info for different QEMU version

[Qemu-devel] [PATCH v3 03/25] tcg-ppc64: Move functions around

2014-06-20 Thread Richard Henderson
Code movement only. This will allow us to make use of the other tcg_out_* functions in tidying their implementations. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 1178 1 file changed, 589 insertions(+), 589 deletions(-) diff --

Re: [Qemu-devel] [PULL 075/118] macio: handle non-block ATAPI DMA transfers

2014-06-20 Thread Mark Cave-Ayland
On 04/06/14 13:44, Alexander Graf wrote: From: Mark Cave-Ayland Currently the macio DMA routines assume that all DMA requests are for read/write block transfers. This is not always the case for ATAPI, for example when requesting a TOC where the response is generated directly in the IDE buffer.

[Qemu-devel] [PATCH v3 06/25] tcg-ppc64: Make TCG_AREG0 and TCG_REG_CALL_STACK enum constants

2014-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.h | 46 +++--- 1 file changed, 11 insertions(+), 35 deletions(-) diff --git a/tcg/ppc64/tcg-target.h b/tcg/ppc64/tcg-target.h index f2360c8..57c6abc 100644 --- a/tcg/ppc64/tcg-target.h +++ b/tcg/ppc

Re: [Qemu-devel] [PATCH v4 2/3] block/archipelago: Add support for creating images

2014-06-20 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 05:48:47PM +0300, Chrysostomos Nanakos wrote: > +static int qemu_archipelago_create_volume(Error **errp, const char *volname, > + uint64_t size, xport mportno, > + xport vportno) > +{ > +in

Re: [Qemu-devel] [PATCH v4 1/3] block: Support Archipelago as a QEMU block backend

2014-06-20 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 05:48:46PM +0300, Chrysostomos Nanakos wrote: > +typedef struct BDRVArchipelagoState { > +int fds[2]; > +int qemu_aio_count; This field is never used. It's increment and decremented but nothing ever checks the value. It can be dropped. > +int event_reader_pos

[Qemu-devel] [PATCH v3 23/25] qemu/osdep: Remove the need for qemu_init_auxval

2014-06-20 Thread Richard Henderson
Instead of getting backup auxv data from the env pointer given to main, read it from /proc/self/auxv. We can do this at any time, so we're not tied to any ordering wrt a call to qemu_init_auxval from main. Signed-off-by: Richard Henderson --- include/qemu/osdep.h | 12 linux-user/m

[Qemu-devel] [PATCH v3 25/25] tcg-ppc: Use the return address as a base pointer

2014-06-20 Thread Richard Henderson
This can significantly reduce code size for generation of (some) 64-bit constants. With the side effect that we know for a fact that exit_tb can use the register to good effect. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c | 105 +--

[Qemu-devel] [PATCH v3 24/25] tcg-ppc: Merge cache-utils into the backend

2014-06-20 Thread Richard Henderson
As a "utility", it only supported ppc, and in a way that other tcg backends provided directly in tcg-target.h. Removing this disparity is easier now that the two ppc backends are merged. Signed-off-by: Richard Henderson --- exec.c | 1 - include/qemu/cache-utils.h | 44

[Qemu-devel] [PATCH v3 18/25] tcg-ppc64: Merge ppc32 register usage

2014-06-20 Thread Richard Henderson
Good enough to run some instructions before things go awry. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 61 -- 1 file changed, 39 insertions(+), 22 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index c

[Qemu-devel] [PATCH v3 14/25] tcg-ppc64: Fix sub2 implementation

2014-06-20 Thread Richard Henderson
All sorts of confusion on argument ordering. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 8d932eb..22cfa1e 100644 --- a/tcg/ppc64/tcg-target.c +

[Qemu-devel] [PATCH v3 22/25] tcg-ppc: Rename the tcg/ppc64 backend

2014-06-20 Thread Richard Henderson
The other tcg backends that support 32- and 64-bit modes use the 32-bit name for the port. Follow suit. Signed-off-by: Richard Henderson --- configure | 4 ++-- tcg/{ppc64 => ppc}/tcg-target.c | 0 tcg/{ppc64 => ppc}/tcg-target.h | 0 3 files changed, 2 insertions(+), 2 de

[Qemu-devel] [PATCH v3 13/25] tcg-ppc64: Merge 32-bit ABIs into the prologue / frame code

2014-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 39 --- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 635ff98..8d932eb 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-t

[Qemu-devel] [PATCH v3 19/25] tcg-ppc64: Support mulsh_i32

2014-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 5 + tcg/ppc64/tcg-target.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index a5ad140..02ee8e2 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target

[Qemu-devel] [PATCH v3 16/25] tcg-ppc64: Merge ppc32 brcond2, setcond2, muluh

2014-06-20 Thread Richard Henderson
Now passes tcg_add_target_add_op_defs assertions, but not complete enough to function. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 96 +- tcg/ppc64/tcg-target.h | 2 +- 2 files changed, 96 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PATCH v3 11/25] tcg-ppc64: Support the ppc64 elfv2 ABI

2014-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 4 1 file changed, 4 insertions(+) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 31c3a7a..d3cc237 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target.c @@ -1414,6 +1414,10 @@ static void tcg_out_qe

[Qemu-devel] [PATCH v3 12/25] tcg-ppc64: Adjust tcg_out_call for ELFv2

2014-06-20 Thread Richard Henderson
From: Ulrich Weigand The new ELFv2 ABI, used by default on powerpc64le-linux hosts, introduced some changes that are incompatible with code currently generated by the ppc64 TGC target. In particular, we no longer use function descriptors. This patch adds support for the ELFv2 ABI in the ppc64 T

[Qemu-devel] [PATCH v3 15/25] tcg-ppc64: Begin merging ppc32 with ppc64

2014-06-20 Thread Richard Henderson
Just enough to compile, assuming you edit config-host.mak manually. It will still abort at runtime, due to missing brcond2, setcond2, mulu2. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 104 +++-- tcg/ppc64/tcg-target.h | 20 +++--

[Qemu-devel] [PATCH v3 20/25] tcg-ppc64: Merge ppc32 shifts

2014-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 02ee8e2..46d5c4c 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-

[Qemu-devel] [PATCH v3 04/25] tcg-ppc64: Relax register restrictions in tcg_out_mem_long

2014-06-20 Thread Richard Henderson
In order to be able to use tcg_out_ld/st sensibly with scratch registers, assert only when we'd incorrectly clobber a scratch. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg

[Qemu-devel] [PATCH v3 10/25] tcg-ppc64: Use the correct test in tcg_out_call

2014-06-20 Thread Richard Henderson
The correct test uses the _CALL_AIX macro, not a host-specific macro. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index a198a70..31c3a7a 100644 --- a/tcg/ppc6

[Qemu-devel] [PATCH v3 09/25] tcg-ppc64: Better parameterize the stack frame

2014-06-20 Thread Richard Henderson
In preparation for supporting other ABIs. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 64 -- 1 file changed, 36 insertions(+), 28 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 44abf7b..a198a70 10

[Qemu-devel] [PATCH v3 07/25] tcg-ppc64: Move call macros out of tcg-target.h

2014-06-20 Thread Richard Henderson
These values are private to tcg.c; we don't need to expose this nonsense to the translators. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 5 + tcg/ppc64/tcg-target.h | 6 -- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64

[Qemu-devel] [PATCH v3 01/25] tcg-ppc: Use uintptr_t in ppc_tb_set_jmp_target

2014-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 2 +- tcg/ppc/tcg-target.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 3d62d9c..5e5d86e 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec

[Qemu-devel] [PATCH v3 02/25] tcg-ppc64: Avoid some hard-codings of TCG_TYPE_I64

2014-06-20 Thread Richard Henderson
Using more appropriate _PTR or _REG where possible. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index c90ddcd..2f60924 100644 --- a/tcg/pp

[Qemu-devel] [PATCH v3 05/25] tcg-ppc64: Use tcg_out_{ld, st, cmp} internally

2014-06-20 Thread Richard Henderson
Rather than using tcg_out32 and opcodes directly. This allows us to remove LD_ADDR and CMP_L macros. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/p

[Qemu-devel] [PATCH v3 00/25] Merge ppc32/ppc64 tcg backends

2014-06-20 Thread Richard Henderson
The ppc32 backend isn't getting much love and attention recently, with all of the improvements coming from me into the ppc64 backend. Let's reduce the maint burden a bit and combine them. This does have a few other patches that are not strictly related to the merge of the backends, such as additi

[Qemu-devel] [PATCH v4] gt64xxx_pci: Add VMStateDescription

2014-06-20 Thread James Hogan
From: Sanjay Lal Add VMStateDescription for GT64120 PCI emulation used by the Malta platform, to allow it to work with savevm/loadvm and live migration. The entire register array is saved/restored using VMSTATE_UINT32_ARRAY (fixed length GT_REGS = 1024). Signed-off-by: Sanjay Lal [james.ho...@

[Qemu-devel] [PATCH v2] mips_malta: Don't boot from flash with KVM

2014-06-20 Thread James Hogan
In KVM mode the flash reset region at 0xbfc0 isn't executable, which is why the minimal kernel bootloader is loaded and executed from the last 1MB of DRAM instead. Therefore if no kernel is provided on the command line and KVM is enabled, exit with an error since booting from flash will fail.

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2014-06-20 Thread Luiz Capitulino
On Fri, 20 Jun 2014 08:12:44 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Tested-by: Luiz Capitulino > --- > hw/display/qxl.c | 2 +- > ui/spice-display.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/display/qxl.c b/hw/display/qxl.c > index 7

Re: [Qemu-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-20 Thread Daniel Vetter
Well I have no clue about forwarding the intel gpu to virtualized hosts and also no idea who could review this really. There's been a bit a discussion around the iommu mapping forwarding and similar topics though. So I really wonder how well our driver works in this use case ... -Daniel On Fri, Ju

qemu-devel@nongnu.org

2014-06-20 Thread James Hogan
On 20/06/14 14:17, Andreas Färber wrote: > Hi, > > Am 20.06.2014 13:47, schrieb James Hogan: >> In KVM trap & emulate (T&E) mode the flash reset region at 0xbfc0 >> isn't executable, which is why the minimal kernel bootloader is loaded >> and executed from the last 1MB of DRAM instead. >> >> T

[Qemu-devel] [PATCH v5 13/18] tests: vmstate static checker: remove Description

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 33 +--- 1 file changed, 1 insertion(+), 32 deletions(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json index

[Qemu-devel] [PATCH v5 12/18] tests: vmstate static checker: remove Fields

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 114 +-- 1 file changed, 1 insertion(+), 113 deletions(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json inde

[Qemu-devel] [PATCH v5 16/18] tests: vmstate static checker: remove Subsections

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 15 --- 1 file changed, 15 deletions(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json index 6f8a617..b5cb1aa 100644 ---

[Qemu-devel] [PATCH v5 11/18] tests: vmstate static checker: change description name

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json index 34bfbf6..f69966d 100644 ---

[Qemu-devel] [PATCH v5 15/18] tests: vmstate static checker: remove a subsection

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 13 - 1 file changed, 13 deletions(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json index 05b8fce..6f8a617 100644 --- a/

[Qemu-devel] [PATCH v5 18/18] tests: vmstate static checker: add size mismatch inside substructure

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json index 45cccaf..75719f5 100644 ---

[Qemu-devel] [PATCH v5 07/18] tests: vmstate static checker: minimum_version_id check

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump1.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vmstate-static-checker-data/dump1.json b/tests/vmstate-static-checker-data/dump1.json index 44200fb..786ca0b 100644 ---

[Qemu-devel] [PATCH v5 10/18] tests: vmstate static checker: remove last field in a struct

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 6 -- 1 file changed, 6 deletions(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json index f6b52d0..34bfbf6 100644 --- a/tests/vms

[Qemu-devel] [PATCH v5 17/18] tests: vmstate static checker: add substructure for usb-kbd for hid section

2014-06-20 Thread Amit Shah
This shows how the script deals with substructures added to vmstate descriptions that don't change the on-wire format. Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 115 +++ 1 file changed, 64 insertions(+), 51 del

[Qemu-devel] [PATCH v5 05/18] tests: vmstate static checker: add version error in main section

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Acked-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json index 0a8b81d..f405534 100644 --- a/t

[Qemu-devel] [PATCH v5 14/18] tests: vmstate static checker: remove Description inside Fields

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json index

[Qemu-devel] [PATCH v5 09/18] tests: vmstate static checker: remove a field

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 6 -- 1 file changed, 6 deletions(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json index 4ccfd67..f6b52d0 100644 --- a/tests/vms

[Qemu-devel] [PATCH v5 04/18] tests: vmstate static checker: incompat machine types

2014-06-20 Thread Amit Shah
This commit modifies the dump2 data to flag incompatibilities in the machine types being compared. Signed-off-by: Amit Shah Acked-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vmstate-static-checker-d

[Qemu-devel] [PATCH v5 08/18] tests: vmstate static checker: remove a section

2014-06-20 Thread Amit Shah
Signed-off-by: Amit Shah Reviewed-by: Juan Quintela --- tests/vmstate-static-checker-data/dump2.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vmstate-static-checker-data/dump2.json b/tests/vmstate-static-checker-data/dump2.json index 36a9b4b..4ccfd67 100644 ---

  1   2   >