Re: [Qemu-devel] [PATCH v6 for 2.1 04/10] block: make 'top' argument to block-commit optional

2014-06-18 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:52PM -0400, Jeff Cody wrote: > Now that active layer block-commit is supported, the 'top' argument > no longer needs to be mandatory. > > Change it to optional, with the default being the active layer in the > device chain. > > Reviewed-by: Eric Blake > Reviewed-by:

[Qemu-devel] [Bug 1331932] [NEW] qemu crash in x86 reload

2014-06-18 Thread janaki-lappy
Public bug reported: Hi all, I am running qemu on an x86 host and when the host reloaded we do see a core on Qemu and the gdb dump shows as follows. Can any one please let me know if any one has come across such failures. rning: Can't read pathname for load map: Input/output error. Core was g

Re: [Qemu-devel] [PATCH v6 for 2.1 03/10] block: simplify bdrv_find_base() and bdrv_find_overlay()

2014-06-18 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:51PM -0400, Jeff Cody wrote: > This simplifies the function bdrv_find_overlay(). With this change, > bdrv_find_base() is just a subset of usage of bdrv_find_overlay(), > so this also takes advantage of that. > > Reviewed-by: Eric Blake > Reviewed-by: Benoit Canet >

Re: [Qemu-devel] [PATCH v6 for 2.1 02/10] block: add helper function to determine if a BDS is in a chain

2014-06-18 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:50PM -0400, Jeff Cody wrote: > This is a small helper function, to determine if 'base' is in the > chain of BlockDriverState 'top'. It returns true if it is in the chain, > and false otherwise. > > If either argument is NULL, it will also return false. > > Reviewed-

Re: [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers

2014-06-18 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 12:14:08AM +0200, Max Reitz wrote: > For some protocol block drivers, the "filename" attribute in their BDSs > is unset due to bdrv_file_open() removing it from the options QDict > before bdrv_open_common() is able to copy it into the BDS. Fix this by > not removing it until

Re: [Qemu-devel] [PATCH qom v2 4/4] irq: Slim conversion of qemu_irq to QOM

2014-06-18 Thread Paolo Bonzini
Il 19/06/2014 06:57, Peter Crosthwaite ha scritto: > > If the next step is to add an "owner" like the one in MemoryRegion, and > change occurrences of qemu_free_irq to object_unparent, Sure, I guess its a tree wide much like the one for Memory API though. Can we do it as follow up though and sne

Re: [Qemu-devel] [PATCH v3 07/32] target-arm: add non-secure Translation Block flag

2014-06-18 Thread Edgar E. Iglesias
On Tue, Jun 17, 2014 at 02:07:11PM +0400, Sergey Fedorov wrote: > On 17.06.2014 13:15, Edgar E. Iglesias wrote: > > Hi, I think the patch looks OK but I'm unsure if it brings any benefits > > unless we add separate TLBs for S and NS. > > > > I noticed that TTBR0 gets banked in the series, but are c

Re: [Qemu-devel] [PATCH qom v2 4/4] irq: Slim conversion of qemu_irq to QOM

2014-06-18 Thread Peter Crosthwaite
On Thu, Jun 19, 2014 at 12:40 AM, Paolo Bonzini wrote: > Il 18/06/2014 09:57, Peter Crosthwaite ha scritto: > >> @@ -63,7 +68,7 @@ qemu_irq qemu_allocate_irq(qemu_irq_handler handler, >> void *opaque, int n) >> { >> struct IRQState *irq; >> >> -irq = g_new(struct IRQState, 1); >> +ir

[Qemu-devel] [PATCH net v1 1/1] net: cadence_gem: Convert to realize()

2014-06-18 Thread Peter Crosthwaite
SysBusDevice::init is deprecated. Convert to Object::init and Device::realize as prescribed by QOM conventions. Signed-off-by: Peter Crosthwaite --- hw/net/cadence_gem.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/

Re: [Qemu-devel] [PATCH v10 0/4] Quorum maintainance operations

2014-06-18 Thread Stefan Hajnoczi
On Mon, Jun 16, 2014 at 12:00:53PM +0200, Benoît Canet wrote: > in v10: > address max comments > > Benoît Canet (4): > quorum: Add the rewrite-corrupted parameter to quorum > block: Add node-name argument to drive-mirror > block: Add replaces argument to drive-mirror > qemu-iotests

Re: [Qemu-devel] [PATCH v5 3/4] virtio-blk-test.c: change pci_nop() to virtblk_init()

2014-06-18 Thread Amos Kong
On Wed, Jun 18, 2014 at 06:43:49PM +0200, Andreas Färber wrote: > Am 18.06.2014 18:24, schrieb Amos Kong: > > I want to add a new subtest in virtio-blk-test.c, it will start > > guest without network. The original pci_init() did nothing, but > > it's good to reserve a very simple initialization tes

Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest

2014-06-18 Thread Amos Kong
On Thu, Jun 19, 2014 at 04:03:28AM +, Gonglei (Arei) wrote: > Hi, > > > -Original Message- > > From: Amos Kong [mailto:ak...@redhat.com] > > Sent: Thursday, June 19, 2014 11:58 AM > > To: Stefan Hajnoczi > > Cc: qemu-devel@nongnu.org; Gonglei (Arei); afaer...@suse.de; > > pbonz...@redh

Re: [Qemu-devel] [PATCH 2.1 30/36] qapi event: clean up

2014-06-18 Thread Eric Blake
On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > From: Wenchao Xia > > Signed-off-by: Wenchao Xia > Signed-off-by: Paolo Bonzini > --- > include/monitor/monitor.h | 40 - > monitor.c | 220 > + > stubs/Makefile.objs|

Re: [Qemu-devel] [PATCH 2.1 29/36] qapi event: convert QUORUM events

2014-06-18 Thread Eric Blake
On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > From: Wenchao Xia > > Signed-off-by: Wenchao Xia > Signed-off-by: Paolo Bonzini > --- > +++ b/monitor.c > @@ -617,6 +617,9 @@ static void monitor_qapi_event_init(void) > monitor_qapi_event_throttle(QAPI_EVENT_RTC_CHANGE, 1000); > monitor

Re: [Qemu-devel] [PATCH 2.1 23/36] qapi event: convert other BLOCK_JOB events

2014-06-18 Thread Eric Blake
On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > From: Wenchao Xia > > Since BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are > related, convert them in one patch. The block_job_event_* functions > are used to keep encapsulation of BlockJob structure. > > Signed-off-by: Wenchao Xia >

Re: [Qemu-devel] [PATCH 2.1 22/36] qapi event: convert BLOCK_IMAGE_CORRUPTED

2014-06-18 Thread Eric Blake
On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > From: Wenchao Xia > > Signed-off-by: Wenchao Xia > Signed-off-by: Paolo Bonzini > --- > +# @BLOCK_IMAGE_CORRUPTED > +# > +# Emitted when a disk image is being marked corrupt > +# > +# @device: device name > +# > +# @msg: informative message for hu

Re: [Qemu-devel] [PATCH 2.1 17/36] qapi event: convert RTC_CHANGE

2014-06-18 Thread Eric Blake
On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > From: Wenchao Xia > > This patch also eliminates build time warning caused by no caller > of monitor_qapi_event_throttle(). Stale comment, given that earlier in the series we added a workaround to avoid the warning in the first place. > > Signed-o

Re: [Qemu-devel] [PATCH 2.1 08/36] qapi: add new schema file qapi-event.json

2014-06-18 Thread Eric Blake
On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > From: Wenchao Xia > > Signed-off-by: Wenchao Xia > Signed-off-by: Paolo Bonzini > --- > Makefile | 3 ++- > qapi-event.json | 0 > qapi-schema.json | 2 ++ > 3 files changed, 4 insertions(+), 1 deletion(-) > create mode 100644 qapi-event

Re: [Qemu-devel] [PATCH 2.1 07/36] monitor: add an implemention of qapi event emit method

2014-06-18 Thread Eric Blake
On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > From: Wenchao Xia > > The monitor is now hooked on the new event mechanism, so that later > patches can convert event callers one by one. Most code are copied from > old monitor_protocol_* functions with some modification. > > Note that two build ti

Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest

2014-06-18 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Amos Kong [mailto:ak...@redhat.com] > Sent: Thursday, June 19, 2014 11:58 AM > To: Stefan Hajnoczi > Cc: qemu-devel@nongnu.org; Gonglei (Arei); afaer...@suse.de; > pbonz...@redhat.com; kw...@redhat.com > Subject: Re: [PATCH v5 4/4] virtio-blk-test.c: add ho

Re: [Qemu-devel] [PATCH v2 3/3] nbd: Follow the BDS' AIO context

2014-06-18 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 09:06:43PM +0200, Max Reitz wrote: > Keep the NBD server always in the same AIO context as the exported BDS > by calling bdrv_add_aio_context_notifier() and implementing the required > callbacks. > > Signed-off-by: Max Reitz > --- > nbd.c | 31

Re: [Qemu-devel] [PATCH v2 2/3] block: Add AIO context notifiers

2014-06-18 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 09:06:42PM +0200, Max Reitz wrote: > If a long-running operation on a BDS wants to always remain in the same > AIO context, it somehow needs to keep track of the BDS changing its > context. This adds a function for registering callbacks on a BDS which > are called whenever t

Re: [Qemu-devel] [PATCH v2 1/3] nbd: Drop nbd_can_read()

2014-06-18 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 09:06:41PM +0200, Max Reitz wrote: > +static void nbd_update_can_read(NBDClient *client) > +{ > +bool can_read = client->recv_coroutine || > +client->nb_requests < MAX_NBD_REQUESTS; > + > +if (can_read != client->can_read) { > +client->can

Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest

2014-06-18 Thread Amos Kong
On Thu, Jun 19, 2014 at 11:49:08AM +0800, Stefan Hajnoczi wrote: > On Thu, Jun 19, 2014 at 12:24:13AM +0800, Amos Kong wrote: > > +for (i = MIN_PCI_SLOT; i <= MAX_PCI_SLOT; i++) { > > +for (j = MAX_PCI_FUNC; j >= 0; j--) { > > +if (j == MAX_PCI_FUNC) { > > +q

Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest

2014-06-18 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 12:24:13AM +0800, Amos Kong wrote: > +for (i = MIN_PCI_SLOT; i <= MAX_PCI_SLOT; i++) { > +for (j = MAX_PCI_FUNC; j >= 0; j--) { > +if (j == MAX_PCI_FUNC) { > +qmp_exec_hmp_cmd("", "drive_del drv-%x.%x", i, 0); > +} Why is

Re: [Qemu-devel] [PATCH] check NULL opts in qemu_opt_get functions

2014-06-18 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 10:47:26AM +0800, Chunyan Liu wrote: > Some places will call bdrv_create_file(filename, NULL, &local_err), where > opts is NULL. Check NULL in qemu_opt_get and qemu_opt_get_*_del functions, > to avoid extra effort of checking opts before calling them every time. > > Signed-

Re: [Qemu-devel] qemu vs. spice-server-devel build failure

2014-06-18 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 12:08 AM, Gabriel L. Somlo wrote: > On up-to-date F20, once I updated spice-server-devel from > 0.12.4-3.fc20.x86_64 to 0.12.5-2.fc20.x86_64, I started > getting the following error during build: Should be fixed soon. Please see: http://lists.freedesktop.org/archives/spic

Re: [Qemu-devel] [PATCH block v1 1/2] block: m25p80: sync_page(): Deindent function body.

2014-06-18 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 06:36:03PM -0700, Peter Crosthwaite wrote: > sync_page() was conditionalizing it's whole fn body on the bdrv being > non-null. Just return for the function immediately on NULL brdv and > get rid of the big if. > > Makes implementation consistent with flash_zynq_area(). > >

Re: [Qemu-devel] [PATCH] vfio: Make BARs native endian

2014-06-18 Thread Alexey Kardashevskiy
On 06/19/2014 10:42 AM, Alexey Kardashevskiy wrote: > On 06/19/2014 04:57 AM, Alex Williamson wrote: >> On Wed, 2014-06-18 at 21:35 +1000, Alexey Kardashevskiy wrote: >>> Slow BAR access path is used when VFIO fails to mmap() BAR or TCG is used. >> >> TCG can use the mmap too > > Oh, right. I'll

[Qemu-devel] monitor/mwait support for X86_64

2014-06-18 Thread yan cui
Hi all, We want to use QEMU to test some OS features on x86_64 systems. This feature requires the monitor and mwait instructions on x86, but we do not know whether QEMU currently support this. I got a QEMU copy from http://git.qemu.org/qemu.git, and grep "monitor" in the source code tree, only

[Qemu-devel] [PATCH block v1 1/2] block: m25p80: sync_page(): Deindent function body.

2014-06-18 Thread Peter Crosthwaite
sync_page() was conditionalizing it's whole fn body on the bdrv being non-null. Just return for the function immediately on NULL brdv and get rid of the big if. Makes implementation consistent with flash_zynq_area(). Signed-off-by: Peter Crosthwaite --- hw/block/m25p80.c | 24 +

[Qemu-devel] [PATCH block v1 2/2] block: m25p80: Support read only bdrvs.

2014-06-18 Thread Peter Crosthwaite
By just never doing write-backs. This is completely invisible to the guest, as the entire storage area is implemented as device state (at realize time the entire drive is read in). Signed-off-by: Peter Crosthwaite --- hw/block/m25p80.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(

Re: [Qemu-devel] [PULL 092/103] qapi: make string output visitor parse int list

2014-06-18 Thread Hu Tao
On Wed, Jun 18, 2014 at 06:02:09PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 17, 2014 at 03:45:29PM -0600, Eric Blake wrote: > > On 06/17/2014 11:41 AM, Michael S. Tsirkin wrote: > > > From: Hu Tao > > > > > > Signed-off-by: Hu Tao > > > Acked-by: Michael S. Tsirkin > > > Tested-by: Michae

Re: [Qemu-devel] [PATCH v4 16/29] memory: move preallocation code out of exec.c

2014-06-18 Thread Hu Tao
On Wed, Jun 18, 2014 at 10:14:23PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 09, 2014 at 06:25:21PM +0800, Hu Tao wrote: > > From: Paolo Bonzini > > > > So that backends can use it. > > > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Hu Tao > > OK this breaks mingw build because you

Re: [Qemu-devel] [PATCH] vfio: Make BARs native endian

2014-06-18 Thread Alexey Kardashevskiy
On 06/19/2014 04:57 AM, Alex Williamson wrote: > On Wed, 2014-06-18 at 21:35 +1000, Alexey Kardashevskiy wrote: >> Slow BAR access path is used when VFIO fails to mmap() BAR or TCG is used. > > TCG can use the mmap too Oh, right. > >> Since this is just a transport between the guest and a devi

Re: [Qemu-devel] [PATCH] raw: Fix segfault in raw_create when opts is NULL

2014-06-18 Thread Eric Blake
On 06/18/2014 05:31 PM, Fam Zheng wrote: > Reported-by: Milos Vyletel > Signed-off-by: Fam Zheng > --- > block/raw-posix.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Chunyan's solution looks better: https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg04104.html --

Re: [Qemu-devel] [PATCH 0/7] spapr: rework memory nodes

2014-06-18 Thread Nishanth Aravamudan
On 18.06.2014 [16:33:55 -0300], Eduardo Habkost wrote: > On Wed, Jun 18, 2014 at 11:28:53AM -0700, Nishanth Aravamudan wrote: > > On 17.06.2014 [16:22:33 -0300], Eduardo Habkost wrote: > > > On Tue, Jun 17, 2014 at 11:38:16AM -0700, Nishanth Aravamudan wrote: > > > > On 17.06.2014 [11:07:00 -0300],

[Qemu-devel] [Bug 1331859] [NEW] QEMU kernel panic on Windows with arithmetic syntax error

2014-06-18 Thread Greg Bellows
Public bug reported: During attempts to bring-up QEMU 64-bit ARM support I discovered a kernel panics that only occur on Windows but work properly on Linux. The issue can be reproduced by running the following command line: $ ./arm-softmmu/qemu-system-arm -M versatilepb -kernel $IMAGES/vmlinuz-3

[Qemu-devel] [PULL] tcg patch queue

2014-06-18 Thread Richard Henderson
Just one patch queued up this last couple of weeks. r~ The following changes since commit d279279e2b5cd40dbcc863fb66a695990f304077: target-mips: implement UserLocal Register (2014-06-18 18:10:47 +0200) are available in the git repository at: git://github.com/rth7680/qemu.git tcg-next fo

[Qemu-devel] [PULL] tcg/optimize: Don't special case TCG_OPF_CALL_CLOBBER

2014-06-18 Thread Richard Henderson
With the "old" ldst ops we didn't know the real width of the result of the load, but with the "new" ldst ops we do. Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 16cebbe..34ae

[Qemu-devel] [PATCH] raw: Fix segfault in raw_create when opts is NULL

2014-06-18 Thread Fam Zheng
Reported-by: Milos Vyletel Signed-off-by: Fam Zheng --- block/raw-posix.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index dacf4fb..1f45fd8 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1282,8 +1282,10 @@ static in

Re: [Qemu-devel] qemu-img segfault on latest git

2014-06-18 Thread Fam Zheng
On Wed, 06/18 18:02, Stefan Hajnoczi wrote: > On Tue, Jun 17, 2014 at 11:08:48AM -0400, Milos Vyletel wrote: > > I hope this is the right place to report this. I've noticed that I > > can't run qemu-img convert on latest git version because it segfaults. > > I've bisected the code and identified th

Re: [Qemu-devel] [PATCH 2.1 03/36] qapi: add event helper functions

2014-06-18 Thread Wenchao Xia
于 2014/6/18 14:43, Paolo Bonzini 写道: > From: Wenchao Xia > > This file holds some functions that do not need to be generated. > > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake > Signed-off-by: Paolo Bonzini > --- > include/qapi/qmp-event.h | 27 ++ > qapi/Makefile.ob

Re: [Qemu-devel] [PATCH V6 03/29] qapi script: add event support

2014-06-18 Thread Wenchao Xia
于 2014/6/18 14:06, Paolo Bonzini 写道: Il 18/06/2014 05:33, Eric Blake ha scritto: > +# This work is licensed under the terms of the GNU GPL, version 2. > +# See the COPYING file in the top-level directory. Any reason this can't be GPLv2+ instead of GPLv2-only? I suppose because it copies parts

[Qemu-devel] [Bug 1308341] Re: Multiple CPUs causes blue screen on Windows guest (14.04 regression)

2014-06-18 Thread Steve
I was able to work around this by downgrading the kernel on a Ubuntu 14 box to 3.12.20-031220-generic #201405160935 (and of course wasn't seeing this with Ubuntu 12). I've periodically tried booting back to the standard Ubuntu 14 3.13 kernel to see if it's been fixed (and also tried 3.13-lowlatenc

Re: [Qemu-devel] [qom-cpu PATCH 2/3] target-i386: Remove unsupported bits from all CPU models

2014-06-18 Thread Eric Blake
On 06/18/2014 01:55 PM, Eduardo Habkost wrote: > The following CPU features were never supported by neither TCG or KVM, > so they are useless on the CPU model definitions, today: > The overall idea of this series makes sense to me (yes, I'd love to get libvirt to the point that we can use enforce

[Qemu-devel] [PATCH] net: fix vhost-user mingw compilation

2014-06-18 Thread Nikolay Nikolaev
Make net.o linkage expect net_init_vhost_user only when CONFIG_VHOST_NET is defined. Signed-off-by: Nikolay Nikolaev --- net/net.c |4 1 file changed, 4 insertions(+) diff --git a/net/net.c b/net/net.c index de76e30..0c30414 100644 --- a/net/net.c +++ b/net/net.c @@ -803,7 +803,9 @@ st

[Qemu-devel] [qom-cpu PATCH 2/3] target-i386: Remove unsupported bits from all CPU models

2014-06-18 Thread Eduardo Habkost
The following CPU features were never supported by neither TCG or KVM, so they are useless on the CPU model definitions, today: * CPUID_DTS (DS) * CPUID_HT * CPUID_TM * CPUID_PBE * CPUID_EXT_DTES64 * CPUID_EXT_DSCPL * CPUID_EXT_EST * CPUID_EXT_TM2 * CPUID_EXT_XTPR * CPUID_EXT_PDCM * CPU

[Qemu-devel] [qom-cpu PATCH 1/3] target-i386: Disable CPUID_ACPI by default on KVM mode

2014-06-18 Thread Eduardo Habkost
KVM never supported the CPUID_ACPI flag, so it doesn't make sense to have it enabled by default when KVM is enabled. The motivation here is exactly the same we had for the MONITOR flag. And like on the MONITOR flag case, we don't need machine-type compat code because it is currently impossible to

[Qemu-devel] [qom-cpu PATCH 3/3] target-i386: Don't enable nested VMX by default

2014-06-18 Thread Eduardo Habkost
TCG doesn't support VMX, and nested VMX is not enabled by default on the KVM kernel module. So, there's no reason to have VMX enabled by default on the core2duo and coreduo CPU models, today. Even the newer Intel CPU model definitions don't have it enabled. In this case, we need machine-type comp

[Qemu-devel] [qom-cpu PATCH 0/3] target-i386: Make most CPU models work with "enforce" out of the box

2014-06-18 Thread Eduardo Habkost
Most of the bits that make "enforce" breaks were introduced in 2010 by commit 8560efed6a72a816c0115f41ddb9d79f7ce63f28. The intention behind that commit made sense, the only problem is that we can't guarantee guest ABI stability across hosts if we simply rely on trimming of CPU features based on ho

[Qemu-devel] [Bug 1308341] Missing required logs.

2014-06-18 Thread Brad Figg
This bug is missing log files that will aid in diagnosing the problem. >From a terminal window please run: apport-collect 1308341 and then change the status of the bug to 'Confirmed'. If, due to the nature of the issue you have encountered, you are unable to run this command, please add a commen

Re: [Qemu-devel] [PATCH 0/7] spapr: rework memory nodes

2014-06-18 Thread Eduardo Habkost
On Wed, Jun 18, 2014 at 11:28:53AM -0700, Nishanth Aravamudan wrote: > On 17.06.2014 [16:22:33 -0300], Eduardo Habkost wrote: > > On Tue, Jun 17, 2014 at 11:38:16AM -0700, Nishanth Aravamudan wrote: > > > On 17.06.2014 [11:07:00 -0300], Eduardo Habkost wrote: > > > > > > > > If it is canonical and

Re: [Qemu-devel] [PATCH 0/3] Fixups for vhost-user

2014-06-18 Thread Michael S. Tsirkin
On Wed, Jun 18, 2014 at 10:15:11PM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 13, 2014 at 09:49:38AM +0300, Nikolay Nikolaev wrote: > > This is a series of fixups that replace 'memory-file' with > > 'memory-backend-file'. This is the object type used in the newest (since v4) > > NUMA series fo

Re: [Qemu-devel] [PATCH 0/3] Fixups for vhost-user

2014-06-18 Thread Michael S. Tsirkin
On Fri, Jun 13, 2014 at 09:49:38AM +0300, Nikolay Nikolaev wrote: > This is a series of fixups that replace 'memory-file' with > 'memory-backend-file'. This is the object type used in the newest (since v4) > NUMA series for the file based host memory backend. > > The patches are against git://git

Re: [Qemu-devel] [PATCH v4 16/29] memory: move preallocation code out of exec.c

2014-06-18 Thread Michael S. Tsirkin
On Mon, Jun 09, 2014 at 06:25:21PM +0800, Hu Tao wrote: > From: Paolo Bonzini > > So that backends can use it. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Hu Tao OK this breaks mingw build because you are moving code to posix file and use it unconditionally on all platforms. Pls setup m

[Qemu-devel] [PATCH v2 1/3] nbd: Drop nbd_can_read()

2014-06-18 Thread Max Reitz
There is no variant of aio_set_fd_handler() like qemu_set_fd_handler2(), so we cannot give a can_read() callback function. Instead, unregister the nbd_read() function whenever we cannot read and re-register it as soon as we can read again. All this is hidden behind the functions nbd_set_handlers()

[Qemu-devel] [Bug 1308341] Re: Multiple CPUs causes blue screen on Windows guest (14.04 regression)

2014-06-18 Thread Serge Hallyn
(Removed the task against virt-manager since hyperv is apparently *not* a safe workaround in all cases) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1308341 Title: Multiple CPUs causes blue screen

[Qemu-devel] [Bug 1308341] Re: Multiple CPUs causes blue screen on Windows guest (14.04 regression)

2014-06-18 Thread Serge Hallyn
Thanks, given that info it seems clear to be a kernel and not a qemu bug. ** Also affects: linux (Ubuntu) Importance: Undecided Status: New ** No longer affects: virt-manager (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] [PATCH v2 0/3] nbd: Adapt for dataplane

2014-06-18 Thread Max Reitz
For the NBD server to work with dataplane, it needs to correctly access the exported BDS. It makes the most sense to run both in the same AioContext, therefore this series implements methods for tracking a BDS's AioContext and makes NBD make use of this for keeping the clients connected to that BDS

[Qemu-devel] [PULL v2 039/106] pc: q35: acpi: report error to user on unsupported unplug request

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/isa/lpc_ich9.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index fb2b82d..3fe2311 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/i

[Qemu-devel] [PATCH v2 2/3] block: Add AIO context notifiers

2014-06-18 Thread Max Reitz
If a long-running operation on a BDS wants to always remain in the same AIO context, it somehow needs to keep track of the BDS changing its context. This adds a function for registering callbacks on a BDS which are called whenever the BDS is attached or detached from an AIO context. Signed-off-by:

[Qemu-devel] [PATCH v2 3/3] nbd: Follow the BDS' AIO context

2014-06-18 Thread Max Reitz
Keep the NBD server always in the same AIO context as the exported BDS by calling bdrv_add_aio_context_notifier() and implementing the required callbacks. Signed-off-by: Max Reitz --- nbd.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/nbd.c b/nbd.c index 2

[Qemu-devel] [PULL v2 083/106] hostmem: add merge and dump properties

2014-06-18 Thread Michael S. Tsirkin
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/qemu/osdep.h | 10 ++ include/sysemu/hostmem.h | 1 + backends/hostmem.c | 84 +++- 3 f

[Qemu-devel] [PULL v2 007/106] qdev: hotplug for bus-less devices

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov Add get_hotplug_handler() method to machine, and make bus-less device use it during hotplug as a means to discover a hotplug handler controller. The returned controller is used to perform hotplug actions. Signed-off-by: Igor Mammedov Acked-by: Peter Crosthwaite Reviewed-by:

Re: [Qemu-devel] [PATCH] vfio: Make BARs native endian

2014-06-18 Thread Alex Williamson
On Wed, 2014-06-18 at 21:35 +1000, Alexey Kardashevskiy wrote: > Slow BAR access path is used when VFIO fails to mmap() BAR or TCG is used. TCG can use the mmap too > Since this is just a transport between the guest and a device, there is > no need to do endianness swapping. > > This changes BAR

[Qemu-devel] [PULL v2 091/106] qapi: make string output visitor parse int list

2014-06-18 Thread Michael S. Tsirkin
From: Hu Tao Signed-off-by: Hu Tao Acked-by: Michael S. Tsirkin Tested-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin MST: split up patch --- qapi/string-output-visitor.c | 229 +++-- tests/test-string-output-visitor.c | 38 +- 2 files ch

[Qemu-devel] [PULL v2 019/106] acpi: rename cpu_hotplug_defs.h to pc-hotplug.h

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov to make it more generic, so it could be used for memory hotplug as well. Signed-off-by: Igor Mammedov Acked-by: Peter Crosthwaite Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/cpu_hotplug.h| 2 +- include/hw

[Qemu-devel] [PULL v2 036/106] virtio: Drop superfluous conditionals around g_free()

2014-06-18 Thread Michael S. Tsirkin
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Eric Blake --- hw/9pfs/virtio-9p.c | 4 +--- hw/net/virtio-net.c | 24 hw/virtio/vhost.c | 8 ++-- hw/virtio/virtio.c | 12

[Qemu-devel] [PULL v2 011/106] pc-dimm: do not allow setting an in-use memdev

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov using the same memdev backend more than once will cause assertion at MemoryRegion mapping time because it's already mapped. Prevent it by checking that the associated MemoryRegion is not mapped. Signed-off-by: Igor Mammedov Acked-by: Peter Crosthwaite Reviewed-by: Michael S

[Qemu-devel] [PULL v2 105/106] tests: simplify code

2014-06-18 Thread Michael S. Tsirkin
Use error_abort instead of open-coded assert. Cleaner and shorter. Reported-by: Eric Blake Signed-off-by: Michael S. Tsirkin Reviewed-by: Eric Blake --- tests/test-string-input-visitor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/test-string-input-visitor.c b

[Qemu-devel] [PULL v2 047/106] Add G_IO_HUP handler for socket chardev

2014-06-18 Thread Michael S. Tsirkin
From: Nikolay Nikolaev This is used to detect that the remote end has disconnected. Just call tcp_char_disconnect on receiving this event. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/sysemu/cha

[Qemu-devel] [PULL v2 101/106] qmp: add query-acpi-ospm-status command

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov ... to get ACPI OSPM status reported by ACPI devices via _OST method. Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- qapi-schema.json | 10 ++ qmp.c| 20 qmp

[Qemu-devel] [RFC 1/3] image-fuzzer: Added execution of multiple tests to the test runner

2014-06-18 Thread Maria Kustova
Apart from fixes this patch allows to run multiple tests in a row. If 'seed' argument is not specified the runner generates and executes new tests one by one till keyboard interruption. Specified seed forces the runner to execute only one test with current seed and exit. Signed-off-by: Maria Kusto

[Qemu-devel] [PULL v2 015/106] pc: exit QEMU if compat machine doesn't support memory hotlpug

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov ... if user attempts to start it with memory hotplug enabled. Signed-off-by: Igor Mammedov Acked-by: Peter Crosthwaite Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/i3

[Qemu-devel] [PULL v2 010/106] memory: add memory_region_is_mapped() API

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov which allows to check if MemoryRegion is already mapped. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/exec/memory.h | 8 memory.c | 10 +- 2 files changed, 17 insertions(+), 1 del

[Qemu-devel] [PULL v2 057/106] Add the vhost-user netdev backend to the command line

2014-06-18 Thread Michael S. Tsirkin
From: Nikolay Nikolaev The supplied chardev id will be inspected for supported options. Only a socket backend, with a set path (i.e. a Unix socket) and optionally the server parameter set, will be allowed. Other options (nowait, telnet) will make the chardev unusable and the netdev will not be in

[Qemu-devel] [PULL v2 060/106] Add qtest for vhost-user

2014-06-18 Thread Michael S. Tsirkin
From: Nikolay Nikolaev This test creates a 'server' chardev to listen for vhost-user messages. Once VHOST_USER_SET_MEM_TABLE is received it mmaps each received region, and read 1k bytes from it. The read data is compared to data from readl. The test requires hugetlbfs to be already mounted and w

[Qemu-devel] [PULL 14/15] virtio-scsi: add support for the any_layout feature

2014-06-18 Thread Paolo Bonzini
Store the request and response headers by value, and let virtio_scsi_parse_req check that there is only one of datain and dataout. Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 193 ++-- include/hw/i386/pc.h| 4 + include/hw/

[Qemu-devel] [PULL v2 051/106] vhost_net_init will use VhostNetOptions to get all its arguments

2014-06-18 Thread Michael S. Tsirkin
From: Nikolay Nikolaev vhost_dev_init will replace devfd and devpath with a single opaque argument. This is initialised with a file descriptor. When TAP is used (through vhost_net), open /dev/vhost-net and pass the fd as an opaque parameter in VhostNetOptions. The same applies to vhost-scsi - ope

[Qemu-devel] [PULL v2 050/106] Refactor virtio-net to use generic get_vhost_net

2014-06-18 Thread Michael S. Tsirkin
From: Nikolay Nikolaev This decouples virtio-net from the TAP netdev backend and allows support for other backends to be implemented. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/net/vhost_net.h

[Qemu-devel] [PULL v2 049/106] vhost_net should call the poll callback only when it is set

2014-06-18 Thread Michael S. Tsirkin
From: Nikolay Nikolaev The poll callback needs to be called when bringing up or down the vhost_net instance. As it is not mandatory for an NetClient to implement it, invoke it only when it is set. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 026/106] acpi:ich9: add memory hotplug handling

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov Add memory hotplug initialization/handling to ICH9 LPC device and enable it by default for post 2.0 machine types Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/ich9.h | 4 include/hw/i386/pc.h |

[Qemu-devel] [PULL v2 031/106] pc: add "hotplug-memory-region-size" property to PC_MACHINE

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov ... it will be used by acpi-build code and by unit tests Signed-off-by: Igor Mammedov Acked-by: Peter Crosthwaite Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 1 + hw/i386/pc.c | 19 +++ 2 files cha

Re: [Qemu-devel] [PATCH v5 3/4] virtio-blk-test.c: change pci_nop() to virtblk_init()

2014-06-18 Thread Andreas Färber
Am 18.06.2014 18:24, schrieb Amos Kong: > I want to add a new subtest in virtio-blk-test.c, it will start > guest without network. The original pci_init() did nothing, but > it's good to reserve a very simple initialization testing. > > Signed-off-by: Amos Kong > Reviewed-by: Stefan Hajnoczi > -

[Qemu-devel] [PULL v2 071/106] memory: move RAM_PREALLOC_MASK to exec.c, rename

2014-06-18 Thread Michael S. Tsirkin
From: Paolo Bonzini Prepare for adding more flags. The "_MASK" suffix is unique, kill it. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/exec/cpu-all.h | 3 --- exec.c | 9 ++--- 2 files chan

[Qemu-devel] [PULL v2 064/106] NUMA: convert -numa option to use OptsVisitor

2014-06-18 Thread Michael S. Tsirkin
From: Wanlong Gao Signed-off-by: Wanlong Gao Signed-off-by: Igor Mammedov Tested-by: Eduardo Habkost Reviewed-by: Eduardo Habkost Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- qapi-schema.json| 32 ++

[Qemu-devel] [PULL v2 028/106] pc: add acpi-device link to PCMachineState

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov the link will used later to access device implementing ACPI functions instead of adhoc lookup in QOM tree. Signed-off-by: Igor Mammedov Acked-by: Peter Crosthwaite Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 8 +++- h

[Qemu-devel] [PULL v2 069/106] memory: reorganize file-based allocation

2014-06-18 Thread Michael S. Tsirkin
From: Paolo Bonzini Split the internal interface in exec.c to a separate function, and push the check on mem_path up to memory_region_init_ram. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/exec/cpu-all.h | 3

Re: [Qemu-devel] [PATCH 0/7] spapr: rework memory nodes

2014-06-18 Thread Nishanth Aravamudan
On 17.06.2014 [16:22:33 -0300], Eduardo Habkost wrote: > On Tue, Jun 17, 2014 at 11:38:16AM -0700, Nishanth Aravamudan wrote: > > On 17.06.2014 [11:07:00 -0300], Eduardo Habkost wrote: > > > > > > If it is canonical and kosher way of using NUMA in QEMU, ok, we can use > > > > it. > > > > I just f

[Qemu-devel] [PULL v2 038/106] ich: get rid of spaces in type name

2014-06-18 Thread Michael S. Tsirkin
Names with spaces in them are nasty, let's not go there. Signed-off-by: Michael S. Tsirkin --- include/hw/i386/ich9.h | 2 +- include/hw/i386/pc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h index e191435..59ea25b 10064

[Qemu-devel] [PULL v2 008/108] qdev: expose DeviceState.hotplugged field as a property

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov so that management could detect via QOM interface if device was hotplugged Signed-off-by: Igor Mammedov Acked-by: Peter Crosthwaite Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/core/qdev.c | 17 + 1 file changed, 17 insertions(

[Qemu-devel] [PULL v2 041/106] migration: introduce self_announce_delay()

2014-06-18 Thread Michael S. Tsirkin
From: Jason Wang This patch introduces self_announce_delay() to calculate the delay for the next announce round. This could be used by other device e.g virtio-net who wants to do announcing by itself. Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [v5 PATCH] target-mips: implement UserLocal Register

2014-06-18 Thread Aurelien Jarno
On Wed, Jun 18, 2014 at 05:48:20PM +0200, Petar Jovanovic wrote: > From: Petar Jovanovic > > From MIPS documentation (Volume III): > > UserLocal Register (CP0 Register 4, Select 2) > Compliance Level: Recommended. > > The UserLocal register is a read-write register that is not interpreted by >

[Qemu-devel] [PULL 11/15] virtio-scsi: add extra argument and return type to qemu_sgl_concat

2014-06-18 Thread Paolo Bonzini
Will be used for anylayout support. Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index ec9a536..0718626 100644 --- a/hw/scsi/virtio-scsi.c +++

Re: [Qemu-devel] [PATCH v2 0/7] virtio-scsi: do not rely on iov boundaries

2014-06-18 Thread Paolo Bonzini
Il 18/06/2014 18:17, Michael S. Tsirkin ha scritto: Applied. There was a trivial conflict in the last patch, please verify the pci branch in my tree. Hmm, I have sent it through Peter too. :) Paolo

[Qemu-devel] [RFC 2/3] image-fuzzer: Initial generator of qcow2 fuzzed images

2014-06-18 Thread Maria Kustova
Qcow2 image generator is a python package providing create_image(img_path) method required by the test runner. It generates files containing fuzzed qcow2 image headers. Files are randomly variable not only in fuzzed fields but in valid structure elements like image and cluster size. Signed-off-by:

[Qemu-devel] [PULL v2 023/106] acpi:piix4: allow plug/unlug callbacks handle not only PCI devices

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov ... and report error if plugged in device is not supported. Later these callbacks will be used by memory hotplug. Signed-off-by: Igor Mammedov Acked-by: Peter Crosthwaite Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/piix4.c | 31 +

[Qemu-devel] [PULL v2 062/106] NUMA: check if the total numa memory size is equal to ram_size

2014-06-18 Thread Michael S. Tsirkin
From: Wanlong Gao If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong data to ACPI table, then the guest will ignore the wrong ACPI table and recognize all memory to one node. It's buggy, we should check it to ensure that we write t

[Qemu-devel] [PULL v2 022/106] trace: pc: add PC_DIMM slot & address allocation

2014-06-18 Thread Michael S. Tsirkin
From: Igor Mammedov Add mhp_pc_dimm_assigned_slot & mhp_pc_dimm_assigned_address events to trace which address and slot where assigned to plugged in PC_DIMM device on target-i386 machine. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i3

  1   2   3   4   5   >