[Qemu-devel] [PATCH] scsi: Report error when lun number is in use

2014-06-09 Thread Fam Zheng
In the case that the lun number is taken by another scsi device, don't release the existing device siliently, but report an error to user. Signed-off-by: Fam Zheng --- hw/scsi/scsi-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c

Re: [Qemu-devel] [PATCH v4 24/29] Introduce signed range.

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 01:59:04PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 09, 2014 at 11:42:14AM +0100, Peter Maydell wrote: > > On 9 June 2014 11:25, Hu Tao wrote: > > > Signed-off-by: Hu Tao > > > --- > > > include/qemu/range.h | 124 > > > +

Re: [Qemu-devel] [PATCH v2 3/6] json-parser: Fix two coverity defects

2014-06-09 Thread Gonglei (Arei)
> -Original Message- > From: Luiz Capitulino [mailto:lcapitul...@redhat.com] > Sent: Tuesday, June 10, 2014 4:16 AM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; av1...@comtv.ru; kra...@redhat.com; > ler...@redhat.com; qiaonuo...@cn.fujitsu.com; afaer...@suse.de; > ebl...@redhat.com; pb

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-06-09 Thread Paolo Bonzini
Il 10/06/2014 08:30, Michael Tokarev ha scritto: Hello. The question is: are the drive shortcuts - -cdrom, -hda, -hdb etc - supposed to work in -machine q35 too? Or are they merely ignored? qemu-system-x86_64 -machine q35 -cdrom foo.img this one does not boot, seabios does not see the cdrom

[Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-06-09 Thread Michael Tokarev
Hello. The question is: are the drive shortcuts - -cdrom, -hda, -hdb etc - supposed to work in -machine q35 too? Or are they merely ignored? qemu-system-x86_64 -machine q35 -cdrom foo.img this one does not boot, seabios does not see the cdrom. The same applies to qemu-system-x86_64 -machi

Re: [Qemu-devel] [RFC PATCH v3 02/13] migration: migrate icount fields.

2014-06-09 Thread Amit Shah
On (Fri) 16 May 2014 [17:00:37], fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This fixes a bug where qemu_icount and qemu_icount_bias are not migrated. > It adds a subsection "timer/icount" to vmstate_timers so icount is migrated > only > when needed. > > Signed-off-by: KONRAD F

Re: [Qemu-devel] [PATCH V2 3/3] virtio-net: announce self by guest

2014-06-09 Thread Amit Shah
On (Tue) 20 May 2014 [14:01:44], Jason Wang wrote: > It's hard to track all mac addresses and their configurations (e.g > vlan or ipv6) in qemu. Without this information, it's impossible to > build proper garp packet after migration. The only possible solution > to this is let guest (who knows all

[Qemu-devel] [PATCH v5 3/4] target-i386: Migrate to new nmi_monitor_handler() CPU callback

2014-06-09 Thread Alexey Kardashevskiy
This defines a nmi_monitor_handler() callback for i386 CPU class. This removes #ifdef I386 branch in qmp_inject_nmi so new i386's nmi() callback is going to be used for NMI. This changes code to inject NMI on the current CPU instead of injecting it on every CPU. However that does not seem to be a

Re: [Qemu-devel] [RFC PATCH v3 03/13] migration: make qemu_savevm_state public.

2014-06-09 Thread Amit Shah
On (Fri) 16 May 2014 [17:00:38], fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This makes qemu_savevm_state public for reverse-execution. > > Signed-off-by: KONRAD Frederic Reviewed-by: Amit Shah Amit

[Qemu-devel] [PATCH v5 2/4] target-s390x: Migrate to new nmi_monitor_handler() CPU callback

2014-06-09 Thread Alexey Kardashevskiy
This defines a nmi_monitor_handler() callback for s390 CPU class. This removes #ifdef s390 branch in qmp_inject_nmi so new s390's nmi_monitor_handler() callback is going to be used for NMI. Since nmi_monitor_handler()-calling code is platform independent, CPUState::cpu_index is used instead of S3

[Qemu-devel] [PATCH v5 0/4] cpus: Add generic "nmi" monitor command support

2014-06-09 Thread Alexey Kardashevskiy
This adds an "nmi" monitor command handler per CPUs. x86, s390 and ppc CPUS are supported. Please comment. Thanks. Changes: v5: * added Error** to the callback * fixed some comments v4: * now it is not nmi() but nmi_monitor_handler() to avoid confusion v3: * patches reorganized * comments from

[Qemu-devel] [PATCH v5 4/4] target-ppc: Add support for new nmi_monitor_handler() CPU callback

2014-06-09 Thread Alexey Kardashevskiy
This defines a nmi_monitor_handler() callback for POWERPC CPU class so the "nmi" HMP/QMP command gets supported for POWERPC machines. This calls POWERPC_EXCP_RESET (vector 0x100) in the guest to deliver NMI. The expected result is XMON (in-kernel debugger) invocation. Signed-off-by: Alexey Kardas

[Qemu-devel] [PATCH v5 1/4] cpus: Define callback for QEMU "nmi" command

2014-06-09 Thread Alexey Kardashevskiy
This introduces an NMI (Non Maskable Interrupt) nmi_monitor_handler() callback to the CPU class. It is called from QMP's "nmi" command and performs an action required to cause debug crash dump on in-kernel debugger invocation. The callback returns Error**. This adds support for it in qmp_inject_nm

Re: [Qemu-devel] [PATCH v7 2/3] block: Add node-name and to-replace-node-name arguments to drive-mirror

2014-06-09 Thread Benoît Canet
The Monday 09 Jun 2014 à 15:08:29 (-0600), Eric Blake wrote : > On 06/09/2014 02:46 PM, Benoît Canet wrote: > > node-name gives a name to the created BDS and registers it in the node > > graph. > > > > to-replace-node-name can be used when drive-mirror is called with sync=full. > > Why can't it

[Qemu-devel] [PULL 7/8] configure: duplicate/incorrect order of -lrt

2014-06-09 Thread Paolo Bonzini
From: Rick Liu '-lrt' flag duplication/incorrect order would cause 'undefined reference to clock_gettime' error during compilation time. Before fix: ... -o qemu-bridge-helper qemu-bridge-helper.o-lrt -pthread -lgthread-2.0 -lrt -lglib-2.0 After fix: ... -o qemu-bridge-helper qemu-bridge-he

[Qemu-devel] [PULL 8/8] configure: unset interfering variables

2014-06-09 Thread Paolo Bonzini
From: Cornelia Huck The check for big or little endianness relies on grep reporting match/non-match on the generated binary. If the user specified --binary-files=without-match in their GREP_OPTIONS, this will fail. Let's follow what autoconf does and unset GREP_OPTIONS and CLICOLOR_FORCE at the

Re: [Qemu-devel] [PATCH v5 3/3] qapi: Suppress unwanted space between type and identifier

2014-06-09 Thread Amos Kong
On Mon, Jun 02, 2014 at 05:43:58PM +0200, Markus Armbruster wrote: > Amos Kong writes: > > > We always generate a space between type and identifier in parameter > > and variable declarations, even when idiomatic C style doesn't have > > a space there. Suppress it. > > > > Signed-off-by: Amos Kon

[Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu

2014-06-09 Thread Paolo Bonzini
From: Michael Tokarev Use glib-provided thread primitives in vscclient instead of qemu ones, and do not use qemu sockets in there (open-code call to WSAStartup() for windows to initialize things). This way, vscclient becomes more stand-alone, independent on qemu internals. Signed-off-by: Michae

[Qemu-devel] [PULL 6/8] rules.mak: Rewrite unnest-vars

2014-06-09 Thread Paolo Bonzini
From: Fam Zheng The macro unnest-vars is the most important, complicated but hard to track magic in QEMU's build system. Rewrite it in a (hopefully) clearer way, with more comments, to make it easier to understand and maintain. Remove DSO_CFLAGS and module-objs-m that are not used. A bonus fix

[Qemu-devel] [PULL 3/8] libcacard: replace qemu thread primitives with glib ones

2014-06-09 Thread Paolo Bonzini
From: Michael Tokarev Replace QemuMutex with GMutex and QemuCond with GCond (with corresponding function changes), to make libcacard independent of qemu internal functions. After this step, none of libcacard internals use any qemu-provided symbols. Maybe it's a good idea to stop including qemu-

[Qemu-devel] [PULL 5/8] libcacard: improve documentation

2014-06-09 Thread Paolo Bonzini
Using the file-backed smartcard backend is black magic, but it can be useful if your only smartcard bricks itself if it is accessed the wrong way too many times. Complete the documentation to include the art of creating certificates and using them with QEMU, based on Ray Strode's useful tutorial a

[Qemu-devel] [PULL 0/8] build system and libcacard changes for 2014-06-10

2014-06-09 Thread Paolo Bonzini
The following changes since commit 7721a3044234c46cd6f5f899e7467dc9351f3c8d: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140609-1' into staging (2014-06-09 17:04:13 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git conf

[Qemu-devel] [PULL 1/8] glib-compat.h: add new thread API emulation on top of pre-2.31 API

2014-06-09 Thread Paolo Bonzini
From: Michael Tokarev Thread API changed in glib-2.31 significantly. Before that version, conditionals and mutexes were only allocated dynamically, using _new()/_free() interface. in 2.31 and up, they're allocated statically as regular variables, and old interface is deprecated. (Note: glib do

[Qemu-devel] [PULL 4/8] libcacard: actually use symbols file

2014-06-09 Thread Paolo Bonzini
From: Michael Tokarev libtool has an argument for .syms file, which is -export-symbols. There's no argument `-export-syms', and it looks like at least on linux, -export-syms is just ignored. Use the correct argument, -export-symbols, to actually get the right export list. Signed-off-by: Michael

Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

2014-06-09 Thread Paolo Bonzini
Il 05/06/2014 14:21, Wenchao Xia ha scritto: This series add support for tag/keyword 'event' in qapi-schema. A new file was created to store some helper functions in patch 2, patch 4 is the test case, patch 5 is a convert example. The implemention is done by generate API and a batch of parameter

[Qemu-devel] [PATCH v9 0/4] vfio on spapr-ppc64

2014-06-09 Thread Alexey Kardashevskiy
Yet another try with VFIO on SPAPR (server PPC64). This adds VFIO support on SPAPR for the existing VFIO-SPAPR-TCE driver in the upstream kernel. Individual patches have more detailed commit logs. Please comment. Thanks! Changes: v9: * fixed comments about VFIO_IOMMU_DISABLE * added checking s

[Qemu-devel] [PATCH v9 3/4] spapr_pci_vfio: Add spapr-pci-vfio-host-bridge to support vfio

2014-06-09 Thread Alexey Kardashevskiy
The patch adds a spapr-pci-vfio-host-bridge device type which is a PCI Host Bridge with VFIO support. The new device inherits from the spapr-pci-host-bridge device and adds an "iommu" property which is an IOMMU id. This ID represents a minimal entity for which IOMMU isolation can be guaranteed. In

[Qemu-devel] [PATCH v9 1/4] spapr_iommu: Make in-kernel TCE table optional

2014-06-09 Thread Alexey Kardashevskiy
POWER KVM supports an KVM_CAP_SPAPR_TCE capability which allows allocating TCE tables in the host kernel memory and handle H_PUT_TCE requests targeted to specific LIOBN (logical bus number) right in the host without switching to QEMU. At the moment this is used for emulated devices only and the han

[Qemu-devel] [PATCH v9 2/4] vfio: Add vfio_container_ioctl()

2014-06-09 Thread Alexey Kardashevskiy
While most operations with VFIO IOMMU driver are generic and used inside vfio.c, there are still some operations which only specific VFIO IOMMU drivers implement. The first example of it will be reading a DMA window start from the host. This adds a helper which passes an ioctl request to the conta

[Qemu-devel] [PATCH v9 4/4] vfio: Enable for SPAPR

2014-06-09 Thread Alexey Kardashevskiy
This turns the sPAPR support on and enables VFIO container use in the kernel. This extends vfio_connect_container to support VFIO_SPAPR_TCE_IOMMU type in the host kernel. This registers a memory listener which sPAPR IOMMU will notify when executing H_PUT_TCE/etc DMA calls. The listener then will

Re: [Qemu-devel] [PATCH 2/2] virtio-blk-test.c: add hotplug subtest

2014-06-09 Thread Amos Kong
On Sun, Jun 08, 2014 at 05:57:11PM +0300, Michael S. Tsirkin wrote: > On Thu, Jun 05, 2014 at 01:12:46PM +0800, Amos Kong wrote: > > On Wed, Jun 04, 2014 at 05:35:06PM +0200, Stefan Hajnoczi wrote: > > > On Tue, May 27, 2014 at 03:14:41PM +0800, Amos Kong wrote: > > > > This patch adds a new subtes

Re: [Qemu-devel] [PATCH v4 18/29] hostmem: add file-based HostMemoryBackend

2014-06-09 Thread Paolo Bonzini
> > > +#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file" > > how about naming it after what it really is? "memory-backend-hugepage" > > Later we could split it into generic superclass mmap-ed > > "memory-backend-file" and have TPH specific code moved into this backend. > > OK. Actually I do

Re: [Qemu-devel] [network performance question] only~2Gbpsthroughputbetweentwo linux guests which are running on the same hostvianetperf-tTCP_STREAM -m 1400, but xen can ac

2014-06-09 Thread Zhang Haoyu
I run ethtool -k for backend tap netdevice, find that its tso is off, Features for tap0: rx-checksumming: off [fixed] tx-checksumming: on tx-checksum-ipv4: off [fixed] tx-checksum-ip-generic: on tx-checksum-ipv6: off [fixed] tx-checksum-fcoe-crc: off [fixed]

Re: [Qemu-devel] [PATCH v4 02/29] NUMA: check if the total numa memory size is equal to ram_size

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 08:36:17PM -0600, Eric Blake wrote: > On 06/09/2014 08:29 PM, Hu Tao wrote: > > On Mon, Jun 09, 2014 at 05:02:51PM -0600, Eric Blake wrote: > >> On 06/09/2014 04:25 AM, Hu Tao wrote: > >>> From: Wanlong Gao > >>> > >>> If the total number of the assigned numa nodes memory i

Re: [Qemu-devel] [PATCH v4 02/29] NUMA: check if the total numa memory size is equal to ram_size

2014-06-09 Thread Eric Blake
On 06/09/2014 08:29 PM, Hu Tao wrote: > On Mon, Jun 09, 2014 at 05:02:51PM -0600, Eric Blake wrote: >> On 06/09/2014 04:25 AM, Hu Tao wrote: >>> From: Wanlong Gao >>> >>> If the total number of the assigned numa nodes memory is not >>> equal to the assigned ram size, it will write the wrong data >

Re: [Qemu-devel] [PATCH v4 02/29] NUMA: check if the total numa memory size is equal to ram_size

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 05:02:51PM -0600, Eric Blake wrote: > On 06/09/2014 04:25 AM, Hu Tao wrote: > > From: Wanlong Gao > > > > If the total number of the assigned numa nodes memory is not > > equal to the assigned ram size, it will write the wrong data > > to ACPI table, then the guest will ig

Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 11:24:51AM -0600, Eric Blake wrote: > On 06/09/2014 04:25 AM, Hu Tao wrote: > > Add qmp command query-memdev to query for information > > of memory devices > > > > Signed-off-by: Hu Tao > > --- > > numa.c | 72 > > +++

Re: [Qemu-devel] [PATCH v4 12/29] numa: add -numa node, memdev= option

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 11:22:05AM -0600, Eric Blake wrote: > On 06/09/2014 04:25 AM, Hu Tao wrote: > > From: Paolo Bonzini > > > > This option provides the infrastructure for binding guest NUMA nodes > > to host NUMA nodes. For example: > > > > -object memory-ram,size=1024M,policy=bind,host-n

Re: [Qemu-devel] [PATCH v4 08/29] qmp: improve error reporting for -object and object-add

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 05:57:20PM +0200, Igor Mammedov wrote: > On Mon, 9 Jun 2014 18:25:13 +0800 > Hu Tao wrote: > > > From: Paolo Bonzini > > > > Use QERR_INVALID_PARAMETER_VALUE for consistency. > > > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Hu Tao > > Reviewed-by: Eduardo Habko

[Qemu-devel] [PATCH v10 3/3] sPAPR: Implement sPAPRPHBClass::eeh_handler

2014-06-09 Thread Gavin Shan
The patch implements sPAPRPHBClass::eeh_handler so that the EEH RTAS requests can be routed to VFIO for further handling. Signed-off-by: Gavin Shan --- hw/ppc/spapr_pci_vfio.c | 56 + 1 file changed, 56 insertions(+) diff --git a/hw/ppc/spapr_pci_

Re: [Qemu-devel] [PATCH] docs/multiple-iothreads.txt: add documentation on IOThread programming

2014-06-09 Thread Fam Zheng
On Mon, 06/09 15:59, Stefan Hajnoczi wrote: > This document explains how IOThreads and the main loop are related, > especially how to write code that can run in an IOThread. Currently on Perhaps s/on/only/ ? Fam > virtio-blk-data-plane uses these techniques. The next obvious target is > virtio

[Qemu-devel] [PATCH v10 2/3] headers: Update kernel header

2014-06-09 Thread Gavin Shan
This updates kernel header (vfio.h) for EEH support on VFIO PCI devices. Signed-off-by: Gavin Shan --- linux-headers/linux/vfio.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index f0aa97d..6dfaf16

[Qemu-devel] [PATCH v10 1/3] sPAPR: Implement EEH RTAS calls

2014-06-09 Thread Gavin Shan
The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls and adds callback sPAPRPHBClass::eeh_handler, which is going to be used this way: 1. RTAS calls are received in spapr_pci.c, sanity check is d

[Qemu-devel] [PATCH v10 0/3] EEH Support for VFIO PCI Device

2014-06-09 Thread Gavin Shan
The series of patches adds support EEH for VFIO PCI devices on sPAPR platform. It requires corresponding host kernel support. Also, it is based on top of Alexey's VFIO-for-sPAPR git repository. QEMU: git://github.com/aik/qemu.git (branch: vfio) Kernel: git://github.com/aik/linux.git (branch: vfi

Re: [Qemu-devel] [PATCH v4 18/29] hostmem: add file-based HostMemoryBackend

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 01:32:46PM +0200, Igor Mammedov wrote: > On Mon, 9 Jun 2014 18:25:23 +0800 > Hu Tao wrote: > > > From: Paolo Bonzini > > > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Hu Tao > > --- > > backends/Makefile.objs | 1 + > > backends/hostmem-file.c | 107 > >

Re: [Qemu-devel] [PATCH v4 00/29] NUMA series and hostmem improvements

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 02:40:30PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 09, 2014 at 01:30:05PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jun 09, 2014 at 06:25:05PM +0800, Hu Tao wrote: > > > note: this series is based on MST's pci tree. > > > > No, please rebase on top of numa branch

Re: [Qemu-devel] [PATCH v4 11/29] hostmem: separate allocation from UserCreatable complete method

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 12:47:19PM +0200, Igor Mammedov wrote: > On Mon, 9 Jun 2014 18:25:16 +0800 > Hu Tao wrote: > > > This allows the superclass to set various policies on the memory > > region that the subclass creates. Drops hostmem-ram's complete method > > accordingly. > > > > While at fi

Re: [Qemu-devel] dataplane performance on s390

2014-06-09 Thread Fam Zheng
On Mon, 06/09 15:43, Karl Rister wrote: > Hi All > > I was asked by our development team to do a performance sniff test of the > latest dataplane code on s390 and compare it against qemu.git. Here is a > brief description of the configuration, the testing done, and then the > results. > > Config

[Qemu-devel] [RFC v1 2/2] zynq: Update Zynq to init the CPU in the a9mpcore device

2014-06-09 Thread Alistair Francis
This patch removes the initialisation of the ARM Cortex-A9 in Zynq and instead allows the a9mpcore device to init the CPU. This also updates components that rely on the CPU and GIC, as they are now initialised in a slightly different way Signed-off-by: Alistair Francis --- All other Cortex-A9 mac

[Qemu-devel] [RFC v1 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

2014-06-09 Thread Alistair Francis
This patch adds the Cortex-A9 ARM CPU to the A9MPCore. It first does a check to make sure no other CPUs exist and if they do the Cortex-A9 won't be added. This is implemented to maintain compatibility and can be removed once all machines have been updated This patch also allows the midr and reset-

Re: [Qemu-devel] [PATCH] target-arm: A64: Correct handling of UXN bit.

2014-06-09 Thread Edgar E. Iglesias
On Mon, Jun 09, 2014 at 02:40:59PM +0100, Peter Maydell wrote: > On 8 June 2014 14:53, Ian Campbell wrote: > > In v8 page tables bit 54 in the PTE is UXN in the EL0/EL1 translation > > regimes > > and XN elsewhere. In v7 the bit is always XN. Since we only emulate EL0/EL1 > > we > > can just tre

Re: [Qemu-devel] [PATCH v4 02/29] NUMA: check if the total numa memory size is equal to ram_size

2014-06-09 Thread Eric Blake
On 06/09/2014 04:25 AM, Hu Tao wrote: > From: Wanlong Gao > > If the total number of the assigned numa nodes memory is not > equal to the assigned ram size, it will write the wrong data > to ACPI table, then the guest will ignore the wrong ACPI table > and recognize all memory to one node. It's b

Re: [Qemu-devel] [PATCH] readline: Clear screen on form feed.

2014-06-09 Thread Hani Benhabiles
On Mon, Jun 09, 2014 at 04:32:32PM -0400, Luiz Capitulino wrote: > On Sun, 1 Jun 2014 12:53:35 +0100 > Hani Benhabiles wrote: > > > Signed-off-by: Hani Benhabiles > > --- > > util/readline.c | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/util/readline.c b/util/readlin

Re: [Qemu-devel] [PULL 10/10] qdev: Add test of qdev_prop_check_global

2014-06-09 Thread Eduardo Habkost
On Mon, Jun 09, 2014 at 04:10:36PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 09, 2014 at 01:19:18PM +0100, Peter Maydell wrote: > > On 5 June 2014 18:17, Michael S. Tsirkin wrote: > > > From: Don Slutz > > > > > > This will generate a warning from "make check": > > > > > > ... > > > GTESTER

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v10 15/18] Add the vhost-user netdev backend to the command line

2014-06-09 Thread Eric Blake
On 06/09/2014 03:19 PM, Nikolay Nikolaev wrote: >>> +static CharDriverState *net_vhost_parse_chardev( >>> +const NetdevVhostUserOptions *opts) >> >> Unusual indentation, but I see your dilemma of fitting 80 columns. >> > What woudl be the right approach here, is leaving it 84 colums accept

[Qemu-devel] [Bug 1317603] Re: qemu-system-ppc does not terminate on VM exit

2014-06-09 Thread Serge Hallyn
I've uploaded a build of today's qemu git HEAD to https://launchpad.net /~ubuntu-virt/+archive/virt-daily-upstream . Would it be possible to test with that? I assume you'll need to grab the source and re-build packages for ppc. ** Changed in: qemu (Ubuntu) Importance: Undecided => Medium **

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v10 15/18] Add the vhost-user netdev backend to the command line

2014-06-09 Thread Nikolay Nikolaev
On Thu, Jun 5, 2014 at 7:08 PM, Eric Blake wrote: > On 05/27/2014 06:06 AM, Nikolay Nikolaev wrote: > > The supplied chardev id will be inspected for supported options. Only > > a socket backend, with a set path (i.e. a Unix socket) and optionally > > the server parameter set, will be allowed. Ot

Re: [Qemu-devel] [PATCH v7 2/3] block: Add node-name and to-replace-node-name arguments to drive-mirror

2014-06-09 Thread Eric Blake
On 06/09/2014 02:46 PM, Benoît Canet wrote: > node-name gives a name to the created BDS and registers it in the node graph. > > to-replace-node-name can be used when drive-mirror is called with sync=full. Why can't it work with other modes? That is, if I have: base1 <- snap1 \ base2 <- snap2 >

[Qemu-devel] dataplane performance on s390

2014-06-09 Thread Karl Rister
Hi All I was asked by our development team to do a performance sniff test of the latest dataplane code on s390 and compare it against qemu.git. Here is a brief description of the configuration, the testing done, and then the results. Configuration: Host: 26 CPU LPAR, 64GB, 8 zFCP adapters

[Qemu-devel] [Bug 1320360] Re: usb passthrough not working anymore

2014-06-09 Thread Maarten
I went ahead and modified the qemu.spec to require libusb-1_0-devel instead of libusb-devel. That seems to work as according to the build output it includes /usr/include/libusb-1.0. I apologize for needing three comments to get to this point. This is all very much a learning experience for me. It

[Qemu-devel] [Bug 1320360] Re: usb passthrough not working anymore

2014-06-09 Thread Maarten
xen-devel was not an issue (that package was installed so that dependency was resolved immediately) but libusb-devel is still reported as missing, even though I have a 1.0.18 version of a libusb-1_0-devel installed. I would think it's only the package name that is different. I'm not overly familiar

[Qemu-devel] [Bug 1320360] Re: usb passthrough not working anymore

2014-06-09 Thread Maarten
Hi, I've done the following on my OpenSUSE 13.1 install where I'm in sore need of USB passthrough with QEMU 2.0.0 1) zypper source-install qemu to get the sources 2) update of libusb to 1.0.18 from the hardware:/debug/OpenSUSE_Factory repo - packages are libusb-1_0-0 and libusb-1_0-devel 3) remo

[Qemu-devel] [PATCH v7 0/3] Quorum maintainance operations

2014-06-09 Thread Benoît Canet
in v7: rebase on latest Stefan's block branch Revert to extending drive-mirror by adding two parameters [Stefan] Benoît Canet (3): quorum: Add the rewrite-corrupted parameter to quorum. block: Add node-name and to-replace-node-name arguments to drive-mirror qemu-iotests:

[Qemu-devel] [PATCH v7 1/3] quorum: Add the rewrite-corrupted parameter to quorum.

2014-06-09 Thread Benoît Canet
On read operations when this parameter is set and some replicas are corrupted while quorum can be reached quorum will proceed to rewrite the correct version of the data to fix the corrupted replicas. This will shine with SSD where the FTL will remap the same block at another place on rewrite. Sig

[Qemu-devel] [PATCH v7 3/3] qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror node-name mode.

2014-06-09 Thread Benoît Canet
The to-replace-node-name is designed to allow repairing of broken Quorum file. This patch introduce a new class TestRepairQuorum testing that the feature works. Some further work will be done on QEMU to improve the robutness of the tests. Signed-off-by: Benoit Canet --- tests/qemu-iotests/041

[Qemu-devel] [PATCH v7 2/3] block: Add node-name and to-replace-node-name arguments to drive-mirror

2014-06-09 Thread Benoît Canet
node-name gives a name to the created BDS and registers it in the node graph. to-replace-node-name can be used when drive-mirror is called with sync=full. The purpose of these fields is to be able to reconstruct and replace a broken quorum file. drive-mirror will bdrv_swap the new BDS named node

Re: [Qemu-devel] [PATCH] readline: Clear screen on form feed.

2014-06-09 Thread Luiz Capitulino
On Sun, 1 Jun 2014 12:53:35 +0100 Hani Benhabiles wrote: > Signed-off-by: Hani Benhabiles > --- > util/readline.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/util/readline.c b/util/readline.c > index 8baec55..08d07e3 100644 > --- a/util/readline.c > +++ b/util/readline.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] mac99: Change memory layout to better match PowerMac3, 1

2014-06-09 Thread BALATON Zoltan
Ping! On Sat, 12 Apr 2014, BALATON Zoltan wrote: Bring the memory map closer to a PowerMac3,1 model by removing unused areas and adding the VGA and network cards after the macio to let the latter be mapped from 0x8000 like on real hardware. (On re

Re: [Qemu-devel] [PATCH v2 3/6] json-parser: Fix two coverity defects

2014-06-09 Thread Luiz Capitulino
On Wed, 28 May 2014 21:21:37 +0800 wrote: > From: Gonglei > > Pointer "token" returned by "parser_context_pop_token(ctxt)" is never used. That's not true, "token" is used by token_is_operator(). The patch seems correct to me, but you have to fix the changelog. Also, who's going to take care o

Re: [Qemu-devel] [PATCHv2 0/8] monitor: Command completion for various commands

2014-06-09 Thread Luiz Capitulino
On Tue, 27 May 2014 23:39:29 +0100 Hani Benhabiles wrote: > A set of patches adding completion support for various hmp commands. Following > other series that were merged earlier. > > Compared to v1: > * patch 04/08: New. > * patch 05/08: Use exported list of host network devices. > > Hani Benh

Re: [Qemu-devel] [PATCH 1/3] rng-random: NULL check not needed before g_free()

2014-06-09 Thread Luiz Capitulino
On Fri, 30 May 2014 17:02:18 -0300 Eduardo Habkost wrote: > g_free() is NULL-safe. > > Signed-off-by: Eduardo Habkost This one should to go through qemu-trivial (CCed). > --- > Cc: Anthony Liguori > Cc: Luiz Capitulino > --- > backends/rng-random.c | 5 + > 1 file changed, 1 insertion(

Re: [Qemu-devel] [PATCH v5 2/3] pc & q35: Add new machine opt max-ram-below-4g

2014-06-09 Thread Don Slutz
On 06/09/14 13:33, Marcel Apfelbaum wrote: On Mon, 2014-06-09 at 17:37 +0200, Igor Mammedov wrote: On Mon, 09 Jun 2014 18:10:27 +0300 Marcel Apfelbaum wrote: Hi, On Mon, 2014-06-09 at 17:38 +0300, Michael S. Tsirkin wrote: On Mon, Jun 09, 2014 at 10:20:57AM -0400, Don Slutz wrote: On 06/08

Re: [Qemu-devel] [PATCH v5 2/3] pc & q35: Add new machine opt max-ram-below-4g

2014-06-09 Thread Don Slutz
On 06/09/14 10:38, Michael S. Tsirkin wrote: On Mon, Jun 09, 2014 at 10:20:57AM -0400, Don Slutz wrote: On 06/08/14 11:40, Michael S. Tsirkin wrote: On Fri, Jun 06, 2014 at 01:52:05PM -0400, Don Slutz wrote: This is a pc & q35 only machine opt. One use is to allow for more ram in a 32bit gues

Re: [Qemu-devel] [PATCH v5 3/3] qapi: Suppress unwanted space between type and identifier

2014-06-09 Thread Luiz Capitulino
On Mon, 02 Jun 2014 17:43:58 +0200 Markus Armbruster wrote: > Amos Kong writes: > > > We always generate a space between type and identifier in parameter > > and variable declarations, even when idiomatic C style doesn't have > > a space there. Suppress it. > > > > Signed-off-by: Amos Kong >

Re: [Qemu-devel] [PATCH v8 13/14] iotests: Add test for qcow2's bdrv_make_empty

2014-06-09 Thread Eric Blake
On 06/07/2014 12:51 PM, Max Reitz wrote: > Add a test for qcow2's fast bdrv_make_empty implementation on images > without internal snapshots. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/095 | 72 > ++ > tests/qemu-iotests/095.out | 26

Re: [Qemu-devel] [PATCH v8 12/14] iotests: Add test for backing-chain commits

2014-06-09 Thread Eric Blake
On 06/07/2014 12:51 PM, Max Reitz wrote: > Add a test for qemu-img commit on backing chains with more than two > images. This test also checks whether the top image is emptied (unless > this is prevented by specifying either -d or -b) emptied and does s/ emptied// > therefore not work for qed a

[Qemu-devel] [PATCH v2] qdev: Move global validation to a single function

2014-06-09 Thread Eduardo Habkost
This simplifies the global validation code so all its logic is contained in a single function, and fixes the following: $ qemu-system-x86_64 -global container.xxx=y hw/core/qdev-properties-system.c:450:qdev_add_one_global: Object 0x7f8d72a03d70 is not an instance of type device Aborted (cor

Re: [Qemu-devel] [PATCH v8 11/14] iotests: Add _filter_qemu_img_map

2014-06-09 Thread Eric Blake
On 06/07/2014 12:51 PM, Max Reitz wrote: > As different image formats most probably map guest addresses to > different host addresses, add a filter to filter the host addresses out; > also, the image filename should be filtered. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/common.filt

Re: [Qemu-devel] [PATCH v8 10/14] qemu-img: Specify backing file for commit

2014-06-09 Thread Eric Blake
On 06/07/2014 12:51 PM, Max Reitz wrote: > Introduce a new parameter for qemu-img commit which may be used to > explicitly specify the backing file into which an image should be > committed if the backing chain has more than a single layer. > > Signed-off-by: Max Reitz > --- > qemu-img-cmds.hx |

Re: [Qemu-devel] [PATCH] qtest: fix qtest_clock_warp() for no deadline case

2014-06-09 Thread Alex Bligh
On 9 Jun 2014, at 17:42, Sergey Fedorov wrote: > If there is no deadline across all timerlists attached to the clock > then qemu_clock_deadline_ns_all() returns -1. Cast it to unsinged so > MIN() do not treat it as minimum. > > Signed-off-by: Sergey Fedorov > --- > cpus.c | 4 ++-- > 1 file chan

Re: [Qemu-devel] [PATCH v5 2/3] pc & q35: Add new machine opt max-ram-below-4g

2014-06-09 Thread Marcel Apfelbaum
On Mon, 2014-06-09 at 17:37 +0200, Igor Mammedov wrote: > On Mon, 09 Jun 2014 18:10:27 +0300 > Marcel Apfelbaum wrote: > > > Hi, > > > > On Mon, 2014-06-09 at 17:38 +0300, Michael S. Tsirkin wrote: > > > On Mon, Jun 09, 2014 at 10:20:57AM -0400, Don Slutz wrote: > > > > On 06/08/14 11:40, Michae

[Qemu-devel] Qemu overheads

2014-06-09 Thread João Corrêa
Hi, I'm writing a scientific paper in which I'm using Qemu as a DBT tool. I would like to know if there is any available literature about benchmarking QEMU and known overheads/slowdowns decurrent from the usage of QEMU as a tool. Thank you very much. João.

[Qemu-devel] [PATCH 1/2] pc: q35: acpi: report error to user on unsupported unplug request

2014-06-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/isa/lpc_ich9.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 2adf29a..01ca071 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -610,6 +610,8 @@ static void ich9_device_plug_cb(HotplugHandler *hotplug_

Re: [Qemu-devel] [PATCH v8 09/14] qemu-img: Enable progress output for commit

2014-06-09 Thread Eric Blake
On 06/07/2014 12:51 PM, Max Reitz wrote: > Implement progress output for the commit command by querying the > progress of the block job. > > Signed-off-by: Max Reitz > --- > qemu-img-cmds.hx | 4 ++-- > qemu-img.c | 24 ++-- > qemu-img.texi| 2 +- > 3 files change

[Qemu-devel] [PATCH 2/2] pc-dimm: fix large address sorting during auto-allocation

2014-06-09 Thread Igor Mammedov
GCompareFunc(a, b) used by g_slist_insert_sorted() return 'gint', however it might be too small to fit difference between 2 addresses. So use 128bit calculate difference and normalize result to -1/0/1 return values. Reported-By: Andrey Korolyov Signed-off-by: Igor Mammedov --- hw/mem/pc-dimm.c

[Qemu-devel] [PATCH 0/2] pc: memory hotplug fixes

2014-06-09 Thread Igor Mammedov
Series is build on mst/pci tree that includes memory hotplug bits. patch 2/2, fixes incorrect address auto-allocation caused by wrong sorting order due to overflow in pc_dimm_addr_sort() comparator. Test-case is to build qemu with stderr trace backend and start qemu with following command line:

Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev

2014-06-09 Thread Eric Blake
On 06/09/2014 04:25 AM, Hu Tao wrote: > Add qmp command query-memdev to query for information > of memory devices > > Signed-off-by: Hu Tao > --- > numa.c | 72 > > qapi-schema.json | 34 ++ > qmp-command

Re: [Qemu-devel] [PATCH v4 12/29] numa: add -numa node, memdev= option

2014-06-09 Thread Eric Blake
On 06/09/2014 04:25 AM, Hu Tao wrote: > From: Paolo Bonzini > > This option provides the infrastructure for binding guest NUMA nodes > to host NUMA nodes. For example: > > -object memory-ram,size=1024M,policy=bind,host-nodes=0,id=ram-node0 \ > -numa node,nodeid=0,cpus=0,memdev=ram-node0 \ >

Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev

2014-06-09 Thread Eric Blake
On 06/09/2014 07:40 AM, Paolo Bonzini wrote: > Il 09/06/2014 15:32, Igor Mammedov ha scritto: >> > >> > +{ 'command': 'query-memdev', 'returns': ['Memdev'] } > > Could we make it union, that returns MemdevRam + MemdevFile > > > > MemdevFile will have additional file-only specific

Re: [Qemu-devel] Use-after-free during unrealize in system_reset

2014-06-09 Thread Bandan Das
Paolo Bonzini writes: > Il 08/06/2014 12:46, Michael S. Tsirkin ha scritto: >> Tested-by: Michael S. Tsirkin > > You probably tested the reversal, actually. :) > > Actually, there is a reason for it. "Unassembling" the device > (unparent) should come after "powering it down" (unrealize). Yes,

Re: [Qemu-devel] [PATCH v8 07/14] qemu-img: Implement commit like QMP

2014-06-09 Thread Eric Blake
On 06/07/2014 12:51 PM, Max Reitz wrote: > qemu-img should use QMP commands whenever possible in order to ensure > feature completeness of both online and offline image operations. As > qemu-img itself has no access to QMP (since this would basically require > just everything being linked into qemu

[Qemu-devel] [PATCH] qtest: fix qtest_clock_warp() for no deadline case

2014-06-09 Thread Sergey Fedorov
If there is no deadline across all timerlists attached to the clock then qemu_clock_deadline_ns_all() returns -1. Cast it to unsinged so MIN() do not treat it as minimum. Signed-off-by: Sergey Fedorov --- cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpu

Re: [Qemu-devel] [PULL 00/19] target-arm queue

2014-06-09 Thread Peter Maydell
racking branch 'remotes/stefanha/tags/net-pull-request' into > staging (2014-06-09 15:00:21 +0100) > > are available in the git repository at: > > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20140609-1 > > for you to fetch changes

Re: [Qemu-devel] [PULL v2 0/5] Tracing pull request

2014-06-09 Thread Peter Maydell
On 9 June 2014 16:23, Stefan Hajnoczi wrote: > v2: > * Previous version was interleaved with an older pull request and the email >thread was a mess. Resending. > > The following changes since commit 959e41473f2179850578482052fb73b913bc4e42: > > slirp/arp: do not special-case bogus IP addre

Re: [Qemu-devel] [PATCH v4 08/29] qmp: improve error reporting for -object and object-add

2014-06-09 Thread Igor Mammedov
On Mon, 9 Jun 2014 18:25:13 +0800 Hu Tao wrote: > From: Paolo Bonzini > > Use QERR_INVALID_PARAMETER_VALUE for consistency. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Hu Tao > Reviewed-by: Eduardo Habkost > --- > qmp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > d

[Qemu-devel] [PULL 1/5] trace: add pid field to simpletrace record

2014-06-09 Thread Stefan Hajnoczi
It is useful to know the QEMU process ID when working with traces from multiple VMs. Although the trace filename may contain the pid, tools that aggregate traces or even trace globally need somewhere to record the pid. There is a reserved field in the trace event header struct that we can use. I

[Qemu-devel] [PULL 09/20] target-arm: A64: Use PMULL feature bit for PMULL

2014-06-09 Thread Peter Maydell
Now that we have a separate ARM_FEATURE_V8_PMULL bit, use it for the A64 PMULL, not the AES feature bit. Signed-off-by: Peter Maydell --- linux-user/elfload.c | 2 +- target-arm/translate-a64.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/elfload.c b/li

[Qemu-devel] [PULL 00/19] target-arm queue

2014-06-09 Thread Peter Maydell
ing (2014-06-09 15:00:21 +0100) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20140609-1 for you to fetch changes up to 3b1a41381254f6080b5cfeb149c28a9237d42a0b: target-arm: Delete unused iwmmxt_msadb helper (2014-06-09

[Qemu-devel] [PATCH] hw: vmware_vga: don't return cursorx when the driver asks for cursory register

2014-06-09 Thread mischief
hello qemu-*@nongnu.org, this is my first contribution. apologies if something is incorrect. this patch fixes vmware_vga.c so that it actually returns the cursory register when asked for, instead of cursorx. Signed-off-by: Nicolas Owens --- hw/display/vmware_vga.c | 2 +- 1 file changed, 1 inse

[Qemu-devel] [PATCH v2 05/17] target-arm: Add ESR_EL2 and 3

2014-06-09 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h| 2 +- target-arm/helper.c | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index dca4661..2ee3da2 100644 --- a/target-arm/cpu.h +++ b/target-arm/cp

  1   2   3   >