Public bug reported:
Starting a VM like so:
/usr/bin/qemu-system-x86_64 -machine accel=kvm -monitor
unix:/srv/localfs/Samsung_SSD_840_PRO_Series_S1AXNSAF320206J/vg-virt/lv-
gentoosummerschool/gentoo-summerschool/gentoo-
summerschool.img.monitor,server,nowait -name gentoo-summerschool
-chardev
soc
On 06/03/2014 11:19 PM, Alexey Kardashevskiy wrote:
> On 05/30/2014 07:34 PM, Alexey Kardashevskiy wrote:
>> There are few helpers already to support array migration. However they all
>> require the destination side to preallocate arrays before migration which
>> is not always possible due to unkno
On 06/07/2014 08:47 AM, Alexey Kardashevskiy wrote:
> On 06/07/2014 02:57 AM, Alex Williamson wrote:
>> On Fri, 2014-06-06 at 13:34 +1000, Alexey Kardashevskiy wrote:
>>> This turns the sPAPR support on and enables VFIO container use
>>> in the kernel.
>>>
>>> This extends vfio_connect_container to
On 06/07/2014 08:55 AM, Alex Williamson wrote:
> On Sat, 2014-06-07 at 08:50 +1000, Alexey Kardashevskiy wrote:
>> On 06/07/2014 03:35 AM, Alex Williamson wrote:
>>> On Sat, 2014-06-07 at 02:54 +1000, Alexey Kardashevskiy wrote:
On 06/07/2014 02:48 AM, Alex Williamson wrote:
> On Fri, 2014
On Sat, 2014-06-07 at 23:08 +0100, Peter Maydell wrote:
> On 6 June 2014 14:49, Sean Bruno wrote:
> > Signed-off-by: Sean Bruno
>
> Commit message needs tweaking to be clearer that we're
> only adding strace support for syscalls here, not implementing
> new syscalls.
>
> > ---
> > bsd-user/fre
On 6 June 2014 14:49, Sean Bruno wrote:
> Signed-off-by: Sean Bruno
Other than the standard gripe about the commit message,
Reviewed-by: Peter Maydell
thanks
-- PMM
On 6 June 2014 14:49, Sean Bruno wrote:
> Add strace support for print_sysarch for all architectures for freebsd.
> NetBSD and OpenBSD are not implemented but stubbed out.
In this case you really are implementing a new syscall
("sysarch") and the commit message says it's just strace
support!
>
On 6 June 2014 14:49, Sean Bruno wrote:
> Fix syscall format for socket, fstat, fstatfs and chown.
>
> Add additional syscalls that are missing.
These aren't completely missing syscalls; please update the
commit message.
Otherwise
Reviewed-by: Peter Maydell
thanks
-- PMM
On 6 June 2014 14:49, Sean Bruno wrote:
> Signed-off-by: Sean Bruno
Commit message, strace not new implementations, etc etc.
Otherwise
Reviewed-by: Peter Maydell
thanks
-- PMM
On 6 June 2014 14:49, Sean Bruno wrote:
> Signed-off-by: Sean Bruno
Commit message needs tweaking to be clearer that we're
only adding strace support for syscalls here, not implementing
new syscalls.
> ---
> bsd-user/freebsd/strace.list | 12
> 1 file changed, 12 insertions(+)
>
>
On 6 June 2014 14:49, Sean Bruno wrote:
> Cleanup some while space and style fixes. Move struct syscallname into
"whitespace"
> qemu.h
In the subject, "style".
Otherwise
Reviewed-by: Peter Maydell
-- PMM
On 6 June 2014 14:49, Sean Bruno wrote:
> Signed-off-by: Sean Bruno
Here again the commit message is wrong: we're not implementing
a syscall, only adding strace support for an existing one; please
adjust it.
Otherwise
Reviewed-by: Peter Maydell
thanks
-- PMM
On 6 June 2014 14:49, Sean Bruno wrote:
> From: Stacey Son
>
> This change adds HOST_VARIANT_DIR so the various BSD OS dependent
> code can be seperated into its own directories rather than
"separated"
> using #ifdef's. This may also allow an BSD variant OS to host
> another BSD variant's exe
On 6 June 2014 14:49, Sean Bruno wrote:
Your commit message is inaccurate -- this patch isn't
implementing a syscall, it's just adding support to QEMU's
strace code for it. Something like
"bsd-user: Implement strace support for 'syscall' syscall"
would be better.
If you fix that, then
Reviewed-
On 6 June 2014 10:46, wrote:
> From: Riku Voipio
>
> This series is a cleanup and gcc-4.9 buildfix:
>
> linux-user/syscall.c: In function ‘host_to_target_stat64’:
> linux-user/qemu.h:301:19: error: right-hand operand of comma expression has no
> effect [-Werror=unused-value]
> ((hptr), (x)
On 6 June 2014 10:46, wrote:
> From: Riku Voipio
>
> Remove "if(__get_user" checks and their related error paths
> for all architecture's do_sigreturn. Remove the unlock_user_struct
> when the only way to end up there is from failed lock_user_struct.
>
> Signed-off-by: Riku Voipio
> ---
> linu
On 6 June 2014 10:46, wrote:
> From: Riku Voipio
>
> make most implementations of restore_sigcontext void and
> remove checking it's return value from functions calling
> restore_sigcontext.
>
> The exception is the X86 version of the function that is
> too different from others to deal in this
On 24.05.2014 23:24, Max Reitz wrote:
This series enables qemu-iotests to be run in a build tree outside of
the source tree. It also makes the tests use the command for invoking
the Python interpreter specified through configure instead of always
using "/usr/bin/env python".
Ping; I do understa
The maximum block size for AArch64 address translation is 2GB. This means
that we need a ULL suffix on our shift to avoid shifting into the sign
bit of a signed 32 bit integer.
Signed-off-by: Peter Maydell
---
target-arm/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
In disas_simd_3same_int(), none of the instructions permit is_q
to be false with size == 3 (this would be a vector operation with
a one-element vector, and the instruction set encodes those as
scalar operations). Replace the always-true ?: check with an
assert.
Signed-off-by: Peter Maydell
---
t
This patchset fixes three minor coverity-reported issues in target-arm:
two instances of a ?: expression whose conditional is always true, and
a missing ULL suffix on a "1 << ..." expression.
Peter Maydell (3):
target-arm: Add ULL suffix to calculation of page size
target-arm/translate-a64.c:
In handle_simd_shift_fpint_conv(), the combination of is_double == true,
is_scalar == false and is_q == false is an unallocated encoding; the
'both parts false' case of the nested ?: expression for calculating
maxpass is therefore unreachable and can be removed.
Signed-off-by: Peter Maydell
---
bdrv_make_empty() is currently only called if the current image
represents an external snapshot that has been committed to its base
image; it is therefore unlikely to have internal snapshots. In this
case, bdrv_make_empty() can be greatly sped up by creating an empty L1
table and dropping all data
Introduce a new parameter for qemu-img commit which may be used to
explicitly specify the backing file into which an image should be
committed if the backing chain has more than a single layer.
Signed-off-by: Max Reitz
---
qemu-img-cmds.hx | 4 ++--
qemu-img.c | 24 +--
On 06.06.2014 09:44, Paolo Bonzini wrote:
Il 05/06/2014 20:18, Max Reitz ha scritto:
Why is this design cleaner? Because NBD code doesn't have to worry
about fd handlers. It uses straightforward coroutine send/recv for
socket I/O inside nbd_read_req() and nbd_write_resp(). It's easy to
see
The Saturday 07 Jun 2014 à 21:12:04 (+0200), Max Reitz wrote :
> qapi-schema.json has been split into three smaller JSON files in qapi/.
> Add them as dependencies for the code generation in the Makefile, so
> changes to them will result in a rebuilt of all QAPI-dependent code.
>
> Signed-off-by:
Add a test for qemu-img commit on backing chains with more than two
images. This test also checks whether the top image is emptied (unless
this is prevented by specifying either -d or -b) emptied and does
therefore not work for qed and vmdk which requires it to be separate
from 020.
Signed-off-by
qapi-schema.json has been split into three smaller JSON files in qapi/.
Add them as dependencies for the code generation in the Makefile, so
changes to them will result in a rebuilt of all QAPI-dependent code.
Signed-off-by: Max Reitz
---
Makefile | 9 ++---
1 file changed, 6 insertions(+),
After the top image has been committed, it should be emptied unless
specified otherwise.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
qemu-img-cmds.hx | 4 ++--
qemu-img.c | 34 +++---
qemu-img.texi| 6 +-
3 files changed, 38 insertions(+), 6
As different image formats most probably map guest addresses to
different host addresses, add a filter to filter the host addresses out;
also, the image filename should be filtered.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/common.filter | 7 +++
1 file changed, 7 insertions(+)
diff -
Implement progress output for the commit command by querying the
progress of the block job.
Signed-off-by: Max Reitz
---
qemu-img-cmds.hx | 4 ++--
qemu-img.c | 24 ++--
qemu-img.texi| 2 +-
3 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/qemu-img-
As the length of a mirror block job no longer directly depends on the
size of the block device, drop those checks from this test. Instead,
just check whether the final offset equals the block job length.
As 041 uses the wait_until_completed function from iotests.py, the same
applies there as well
Both constants need more than 32 bit.
Signed-off-by: Stefan Weil
---
hw/pci-host/apb.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c
index 1497008..6fa2723 100644
--- a/hw/pci-host/apb.c
+++ b/hw/pci-host/apb.c
@@ -99,8 +99,8 @@
Normally, discarded sectors should read back as zero. However, there are
cases in which a sector (or rather cluster) should be discarded as if
they were never written in the first place, that is, reading them should
fall through to the backing file again.
Signed-off-by: Max Reitz
Reviewed-by: Eri
qemu-img should use QMP commands whenever possible in order to ensure
feature completeness of both online and offline image operations. As
qemu-img itself has no access to QMP (since this would basically require
just everything being linked into qemu-img), imitate QMP's
implementation of block-comm
Add a test for qcow2's fast bdrv_make_empty implementation on images
without internal snapshots.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/095 | 72 ++
tests/qemu-iotests/095.out | 26 +
tests/qemu-iotests/group | 1 +
3 fi
Implement block_job_complete_sync() by doing the exact same thing as
block_job_cancel_sync() does, only with calling block_job_complete()
instead of block_job_cancel().
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
---
blockjob.c | 39 ---
in
Implement this function by making all clusters in the image file fall
through to the backing file (by using the recently extended discard).
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/block/q
Instead of taking the total length of the block device as the block
job's length, use the number of dirty sectors. The progress is now the
number of sectors mirrored to the target block device. Note that this
may result in the job's length increasing during operation, which is
however in fact desir
When a block job signals readiness, this is currently reported only
through QMP. If qemu wants to use block jobs for internal tasks, there
needs to be another way to correctly detect when a block job may be
completed.
For this reason, introduce a bool "ready" which is set when the block
job may be
qemu-img should use QMP commands whenever possible in order to ensure
feature completeness of both online and offline image operations. For
the "commit" command, this is relatively easy, so implement it first
(in the hope that indeed others will follow).
As qemu-img does not have access to QMP (du
Remove the t_gen_mov_TN_reg and t_gen_mov_reg_TN wrappers: the
latter is completely unused, and the former only used in a few
places (which are thus inconsistent with the rest of the decoder
which directly accesses cpu_R[]).
Signed-off-by: Peter Maydell
---
My main aim here is to remove the unuse
The tcg_out* and tcg_patch* functions are utility routines that may or
may not be used by a particular backend; mark them with the 'unused'
attribute to suppress spurious warnings if they aren't used.
Signed-off-by: Peter Maydell
---
Do we want to define a QEMU_UNUSED macro in compiler.h? We don'
The functions softusb_read_pmem() and softusb_write_pmem() are unused;
remove them.
Signed-off-by: Peter Maydell
---
hw/input/milkymist-softusb.c | 25 -
1 file changed, 25 deletions(-)
diff --git a/hw/input/milkymist-softusb.c b/hw/input/milkymist-softusb.c
index 53ba71
The wrapper functions _t_gen_mov_TN_env and _t_gen_mov_env_TN are only
used via their accompanying non-underscore macros. The check they add
on offset is thus pointless, since the compiler will complain if the
struct field passed to the macro is not part of the struct. Remove the
functions and make
The function tcg_gen_lshift() is unused; remove it.
Signed-off-by: Peter Maydell
---
target-i386/translate.c | 8
1 file changed, 8 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 3aa52eb..c02f7fd 100644
--- a/target-i386/translate.c
+++ b/target-i386/
These patches correct some unused-function warnings in target-cris.
I've included some cleanup and removal of wrapper functions to
maintain symmetry between the to-reg and from-reg code.
thanks
-- PMM
Peter Maydell (2):
target-cris/translate.c: Remove t_gen_mov_TN_reg and t_gen_mov_reg_TN
ta
The ne2000-isa device defines a VMState struct for migration, but
we forgot to actually register it. Correct this deficiency by
setting dc->vmsd.
Signed-off-by: Peter Maydell
---
I think this is the last of the "oops, we didn't actually register
the vmstate" bugs that clang 3.4 warns about.
hw/
Although we defined an eepro100_mdi_mask[] array indicating which bits
in the registers are read-only, we weren't actually doing anything with
it. Make the MDI register-read code use it rather than manually making
registers 2 and 3 totally read-only and the rest totally read-write.
Signed-off-by:
The function is_parallel_epp() is unused; remove it.
Signed-off-by: Peter Maydell
---
hw/isa/pc87312.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c
index b352b49..9327c53 100644
--- a/hw/isa/pc87312.c
+++ b/hw/isa/pc87312.c
@@ -86,11 +86,6 @@ static
The IRQ_testbit() function is never used; remove it.
Signed-off-by: Peter Maydell
---
hw/intc/openpic.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c
index 17136c9..08e0e19 100644
--- a/hw/intc/openpic.c
+++ b/hw/intc/openpic.c
@@ -311,11 +311,6 @@
The stream_halted() function is never used; remove it.
Signed-off-by: Peter Maydell
---
hw/dma/xilinx_axidma.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
index cc90eb5..ee60d3f 100644
--- a/hw/dma/xilinx_axidma.c
+++ b/hw/dma/xilinx_ax
The 'on' variable is never used, and 'off' is only used
if IPV6_V6ONLY is defined; delete 'on' and move 'off' to
the point where it is used. This avoids warnings from
clang 3.4.
Signed-off-by: Peter Maydell
---
util/qemu-sockets.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --g
On 7 June 2014 17:00, Stefan Weil wrote:
> Am 07.06.2014 16:58, schrieb Peter Maydell:
>> It's clearly something to do with it getting confused by the type name,
>> because you can suppress the warning by just changing it so it has
>> an "_t" suffix, for instance. In particular notice that the set
Am 07.06.2014 17:58, schrieb Peter Maydell:
> On 7 June 2014 16:42, Stefan Weil wrote:
>> QEMU uses both *.cc and *.cpp for some files with C++ code:
>>
>> disas/libvixl/utils.cc
>> disas/libvixl/a64/disasm-a64.cc
>> disas/libvixl/a64/instructions-a64.cc
>> disas/libvixl/a64/decoder-a64.cc
>> disa
Am 07.06.2014 16:58, schrieb Peter Maydell:
> On 6 June 2014 08:17, Markus Armbruster wrote:
>> --debug values=1 produces
>>
>> 188 > . extern int vfio_container_ioctl(AddressSpace *as, int32_t groupid,
>> 188 > EEVVVNTTVVCCVVVCC
>>
>> which sugg
On 7 June 2014 16:42, Stefan Weil wrote:
> QEMU uses both *.cc and *.cpp for some files with C++ code:
>
> disas/libvixl/utils.cc
> disas/libvixl/a64/disasm-a64.cc
> disas/libvixl/a64/instructions-a64.cc
> disas/libvixl/a64/decoder-a64.cc
> disas/arm-a64.cc
> qga/vss-win32/provider.cpp
> qga/vss-w
QEMU uses both *.cc and *.cpp for some files with C++ code:
disas/libvixl/utils.cc
disas/libvixl/a64/disasm-a64.cc
disas/libvixl/a64/instructions-a64.cc
disas/libvixl/a64/decoder-a64.cc
disas/arm-a64.cc
qga/vss-win32/provider.cpp
qga/vss-win32/install.cpp
qga/vss-win32/requester.cpp
*.cpp files w
On 6 June 2014 08:17, Markus Armbruster wrote:
> --debug values=1 produces
>
> 188 > . extern int vfio_container_ioctl(AddressSpace *as, int32_t groupid,
> 188 > EEVVVNTTVVCCVVVCC
>
> which suggests it recognizes the declaration just fine.
>
> Co
Il 07/06/2014 01:50, Peter Crosthwaite ha scritto:
On Sat, Jun 7, 2014 at 12:52 AM, Paolo Bonzini wrote:
Il 06/06/2014 15:36, Peter Crosthwaite ha scritto:
However, I'd rather have the concept bake for a bit by starting with
read-only properties.
The just a matter of pulling our the setter
On 7 June 2014 02:09, Eduardo Habkost wrote:
> On Sat, Jun 07, 2014 at 12:45:26AM +0100, Peter Maydell wrote:
>> I'm with Eduardo on this one -- if the user passes us a bad
>> command line we should diagnose it helpfully and exit with
>> a failure code; abort() is for programming errors. (If nothi
61 matches
Mail list logo
