Re: [Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image

Max Reitz writes: > On 28.05.2014 16:25, Markus Armbruster wrote: >> Chiefly so I don't have to do the error checking in quadruplicate in >> the next commit. Moreover, replacing the frequently updated >> bs_sectors by an array assigned just once makes the code easier to >> understand. >> >> Sign

Re: [Qemu-devel] [PATCH v2 4/8] linux-user: arm: handle CPSR.E correctly in strex emulation

Il 29/05/2014 22:21, Peter Maydell ha scritto: On 29 May 2014 20:46, Paolo Bonzini wrote: Now that CPSR.E is set correctly, prepare for when setend will be able to change it; bswap data in and out of strex manually by comparing bswap_code to CPSR.E (we do not have the luxury of using TCGMemOps)

Re: [Qemu-devel] [PATCH 0/1] Support Archipelago as a QEMU block backend

On 05/30/2014 12:32 AM, Eric Blake wrote: On 05/29/2014 05:14 AM, Chrysostomos Nanakos wrote: Hello team, this is a patch implementing support for a new storage layer, Archipelago [1][2]. We've been using Archipelago in our IaaS public cloud production environment for over a year now, along wi

Re: [Qemu-devel] [PATCH v2 2/8] linux-user: arm: set CPSR.E correctly for BE8 mode

Il 29/05/2014 22:38, Peter Maydell ha scritto: > +#ifdef TARGET_WORDS_BIGENDIAN > +cpsr |= CPSR_E; This is wrong for BE32, where CPSR_E doesn't exist and both code and data accesses are big-endian. Is it okay for simplicity to treat CPSR.E = 1 as "big-endian code, little-endian data" in

Re: [Qemu-devel] Question about hcd-ohci and address_space_translate

Il 30/05/2014 00:33, BALATON Zoltan ha scritto: The address is in the ram area but these functions still think they are unassigned. Is this a bug? If it is how could it be fixed? Can you get the output of "info mtree" at the point where the unassigned access happens? Paolo

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

On 05/28/2014 09:35 PM, Alexander Graf wrote: > > On 28.05.14 03:18, Alexey Kardashevskiy wrote: >> On 05/28/2014 10:41 AM, Alexander Graf wrote: >>> On 28.05.14 02:34, Alexey Kardashevskiy wrote: On 05/28/2014 09:55 AM, Alexander Graf wrote: > > ... > > How do I migrate GHashTable? If

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

Il 29/05/2014 22:25, Peter Lieven ha scritto: Am 29.05.2014 21:17, schrieb Paolo Bonzini: Il 29/05/2014 20:41, Peter Lieven ha scritto: static inline unsigned geo_rand_range(double m, double n) { return exp((log(m) + (double)rand() / (RAND_MAX / (log(n) - log(m) + log(1)) + l

[Qemu-devel] [Bug 1267520] Re: Keyboard input not working when the "-k en-us" argument is specified.

I think I stumbled on this bug. I was using packer to generate qemu- based virtual machines, and identical configurations would fail (complaining about invalid keymaps when keystrokes were sent) depending on where the current directory was. It doesn't work if qemu is run from a directory containi

[Qemu-devel] [Bug 1324727] [NEW] qemu-system-arm segfaults without KVM on ARM

Public bug reported: I'm running on Odroid-XU, Debian Jessie armhf qemu built from today's head d7d3d6092cb7edc75dc49fb90c86dd5425ab4805 sudo qemu-system-arm -M vexpress-a15 -drive if=none,file=arm.img,cache=writeback,id=foo -device virtio-blk-device,drive=foo -netdev user,id=user.0 -device vi

Re: [Qemu-devel] [PATCH] trace: Replace fprintf with error_report and print location

On 05/29/2014 10:42 PM, Lluís Vilanova wrote: > Alexey Kardashevskiy writes: > >> This replaces fprintf(stderr) with error_report. >> This prints line number of the trace which does not exist or is not >> traceable. > > A little nit pick; it shows an error when some of the events in the list of >

[Qemu-devel] [Bug 1324724] [NEW] make install fails on arm host

Public bug reported: I do: ./configure --target-list=arm-softmmu make sudo make install and see: install -d -m 0755 "/usr/local/bin" libtool --quiet --mode=install install -c -m 0755 qemu-ga qemu-nbd qemu-img qemu-io fsdev/virtfs-proxy-helper "/usr/local/bin" strip "/usr/local/bin/qemu-

[Qemu-devel] Question about hcd-ohci and address_space_translate

Hello, I'm trying to port a USB driver from coreboot to OpenBIOS to fix keyboard in qemu-system-ppc64 -M mac99. The driver sets up a HCCA struct in RAM and writes its address into the mmio mapped area of the card but then QEMU complains that it cannot read this struct and I don't understand wh

Re: [Qemu-devel] [PATCH v2 2/3] e1000: allow command-line selection of card model

On Fri, May 30, 2014 at 2:00 AM, Gabriel L. Somlo wrote: > Hi Peter, > > Thanks for the QOM crash course ! > > So I did s/TYPE_E1000/TYPE_E1000_BASE/ as suggested by Stefan, and > also moved PCI_VENDOR_ID_INTEL back into e1000_class_init() and away > from e1000_devices[] as you suggested. That's g

Re: [Qemu-devel] [PATCH v3 3/9] spapr_pci: Introduce a finish_realize() callback

On 29.05.14 03:53, Alexey Kardashevskiy wrote: On 05/29/2014 01:11 AM, Alexander Graf wrote: On 27.05.14 07:36, Alexey Kardashevskiy wrote: The spapr-pci PHB initializes IOMMU for emulated devices only. The upcoming VFIO support will do it different. However both emulated and VFIO PHB types sh

Re: [Qemu-devel] [PATCH v2 03/11] block: Add overlay BDS pointer into the BlockDriverState struct

On Tue, May 27, 2014 at 09:57:19AM -0600, Eric Blake wrote: > On 05/27/2014 08:28 AM, Jeff Cody wrote: > > Now that node-names can reference an individual BlockDriverState without > > needing to navigate downwards from the 'device' level, in order to find > > the top-most image (active layer) we ne

Re: [Qemu-devel] [PATCH 0/1] Support Archipelago as a QEMU block backend

On 05/29/2014 05:14 AM, Chrysostomos Nanakos wrote: > Hello team, > > this is a patch implementing support for a new storage layer, > Archipelago [1][2]. > > We've been using Archipelago in our IaaS public cloud production > environment for over a year now, along with Google Ganeti [3] > and Ceph

Re: [Qemu-devel] [PATCH 0/2] help libvirt know what's up with qga

On 05/29/2014 02:54 PM, Laszlo Ersek wrote: >> Thinking about it a bit more, would it help to make the frontend_open a >> tri-state? It would be nice to know the difference between a guest that >> has no idea how to use the channel (has never opened it in the past; >> possibly because we're still

[Qemu-devel] [PATCH 1/1] block: Support Archipelago as a QEMU block backend

VM Image on Archipelago volume is specified like this: file=archipelago:[/mport=[:vport=]] 'archipelago' is the protocol. 'mport' is the port number on which mapperd is listening. This is optional and if not specified, QEMU will make Archipelago to use the default port. 'vport' is the port numb

[Qemu-devel] [PATCH 0/1] Support Archipelago as a QEMU block backend

Hello team, this is a patch implementing support for a new storage layer, Archipelago [1][2]. We've been using Archipelago in our IaaS public cloud production environment for over a year now, along with Google Ganeti [3] and Ceph [4]. We are currently moving from accessing Archipelago through a k

Re: [Qemu-devel] [PATCH 2/2] char: report frontend open/closed state in 'query-chardev'

On 05/29/2014 02:43 PM, Laszlo Ersek wrote: >>> +# backend (eg. with the chardev=... option) is in open or >>> +# closed state (since 2.2) >> >> Why 2.2? Are you saying it is too late to make the 2.1 soft freeze? > > I thought that reviewers would immediately quest

Re: [Qemu-devel] [PATCH 1/2] virtio-serial: report frontend connection state via monitor

On 05/29/2014 02:36 PM, Laszlo Ersek wrote: > Emitting the events unconditionally shouldn't hurt anything, I think. I > added the property for two reasons: > > - I was sure someone would ask for it. :) Someone still might :) But it may be a pre-mature optimization. > > - The property is devic

Re: [Qemu-devel] [PATCH 0/2] help libvirt know what's up with qga

On 05/29/14 22:24, Eric Blake wrote: > On 05/29/2014 01:36 PM, Laszlo Ersek wrote: >> In this series I try to implement the ideas that (I believe) were >> suggested by Gerd and Amit in >> . >> >> When the guest agent exits or dies (disconnects fr

Re: [Qemu-devel] [PATCH 2/2] char: report frontend open/closed state in 'query-chardev'

On 05/29/14 22:12, Eric Blake wrote: > On 05/29/2014 01:36 PM, Laszlo Ersek wrote: >> In addition to the on-line reporting added in the previous patch, allow >> libvirt to query frontend state independently of events. >> >> Libvirt's path to identify the guest agent channel it cares about differs >

Re: [Qemu-devel] [PATCH v2 2/8] linux-user: arm: set CPSR.E correctly for BE8 mode

On 29 May 2014 20:46, Paolo Bonzini wrote: > Set it on startup and in signal handler frames. > > Signed-off-by: Paolo Bonzini > --- > linux-user/main.c | 1 + > linux-user/signal.c | 5 + > 2 files changed, 6 insertions(+) > > diff --git a/linux-user/main.c b/linux-user/main.c > index 8821

Re: [Qemu-devel] [PATCH 1/2] virtio-serial: report frontend connection state via monitor

On 05/29/14 22:05, Eric Blake wrote: > On 05/29/2014 01:36 PM, Laszlo Ersek wrote: >> Libvirt wants to know about the guest-side connection state of some >> virtio-serial ports (in particular the one(s) assigned to guest agent(s)). >> Introduce a new property that allows libvirt to request connecti

[Qemu-devel] [PATCH v2 0/8] target-arm/linux-user-arm: implement setend, CPSR.E, SCTLR.EE

This is v2 of the series to implement CPSR.E. I've now included support for strex emulation and SCTLR.EE. I've now also tested system emulation better using an Arch Linux image. Using the Raspberry Pi optimized memcmp library and associated harness, QEMU 2.0 fails with "Illegal instruction", whi

Re: [Qemu-devel] [PATCH] tcg-i386: Fix win64 qemu store

Am 28.05.2014 23:24, schrieb Stefan Weil: > Am 28.05.2014 23:04, schrieb Richard Henderson: >> The first non-register argument isn't placed at offset 0. >> >> Cc: Stefan Weil >> Signed-off-by: Richard Henderson >> --- >> tcg/i386/tcg-target.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deleti

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

Am 29.05.2014 21:17, schrieb Paolo Bonzini: > Il 29/05/2014 20:41, Peter Lieven ha scritto: >> static inline unsigned geo_rand_range(double m, double n) { >> return exp((log(m) + (double)rand() / >>(RAND_MAX / (log(n) - log(m) + log(1)) + log(1; >> } > > Yes, exactly (except

Re: [Qemu-devel] [PATCH v2 5/8] target-arm: implement SCTLR.EE

On 29 May 2014 20:46, Paolo Bonzini wrote: > Set CPSR.E to SCTLR.EE on exception, and use SCTLR.EE also to > determine endianness for loads during TLB misses. > > Signed-off-by: Paolo Bonzini > --- > target-arm/helper.c | 38 -- > 1 file changed, 32 insertions

Re: [Qemu-devel] [PATCH 0/2] help libvirt know what's up with qga

On 05/29/2014 01:36 PM, Laszlo Ersek wrote: > In this series I try to implement the ideas that (I believe) were > suggested by Gerd and Amit in > . > > When the guest agent exits or dies (disconnects from the virtio-serial > port), the backend (

Re: [Qemu-devel] [PATCH v2 4/8] linux-user: arm: handle CPSR.E correctly in strex emulation

On 29 May 2014 20:46, Paolo Bonzini wrote: > Now that CPSR.E is set correctly, prepare for when setend will be able > to change it; bswap data in and out of strex manually by comparing > bswap_code to CPSR.E (we do not have the luxury of using TCGMemOps). > > Signed-off-by: Paolo Bonzini > --- >

Re: [Qemu-devel] [PATCH 0/2] help libvirt know what's up with qga

On 05/29/14 21:47, Eric Blake wrote: > virsh qemu-monitor-event $dom serport --no-case --regex --pretty --loop > > to set up a listening loop that will fire on all case-insensitive events > matching the regex "serport" (basically, the two events added in this > patch) that occur on $dom, until yo

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

Am 29.05.2014 21:17, schrieb Paolo Bonzini: > Il 29/05/2014 20:41, Peter Lieven ha scritto: >> static inline unsigned geo_rand_range(double m, double n) { >> return exp((log(m) + (double)rand() / >>(RAND_MAX / (log(n) - log(m) + log(1)) + log(1; >> } > > Yes, exactly (except

Re: [Qemu-devel] [PATCH 2/2] char: report frontend open/closed state in 'query-chardev'

On 05/29/2014 01:36 PM, Laszlo Ersek wrote: > In addition to the on-line reporting added in the previous patch, allow > libvirt to query frontend state independently of events. > > Libvirt's path to identify the guest agent channel it cares about differs > between the event added in the previous p

[Qemu-devel] [PATCH v2 5/8] target-arm: implement SCTLR.EE

Set CPSR.E to SCTLR.EE on exception, and use SCTLR.EE also to determine endianness for loads during TLB misses. Signed-off-by: Paolo Bonzini --- target-arm/helper.c | 38 -- 1 file changed, 32 insertions(+), 6 deletions(-) diff --git a/target-arm/helper.c b/t

Re: [Qemu-devel] [PATCH 1/2] virtio-serial: report frontend connection state via monitor

On 05/29/2014 01:36 PM, Laszlo Ersek wrote: > Libvirt wants to know about the guest-side connection state of some > virtio-serial ports (in particular the one(s) assigned to guest agent(s)). > Introduce a new property that allows libvirt to request connection state > reporting, and report the state

[Qemu-devel] [PATCH v2 6/8] target-arm: pass DisasContext to gen_aa32_ld*/st*

We'll need the DisasContext in the next patch to retrieve the desired endianness, so pass it as a whole to gen_aa32_ld*/st*. Unfortunately we cannot let those functions call get_mem_index, because of user-mode load/store instructions. Signed-off-by: Paolo Bonzini --- target-arm/translate.c | 25

[Qemu-devel] [PATCH v2 8/8] target-arm: implement setend

Since this is not a high-performance path, just use a helper to flip the E bit and force a lookup in the hash table since the flags have changed. Signed-off-by: Paolo Bonzini --- target-arm/helper.h| 1 + target-arm/op_helper.c | 5 + target-arm/translate.c | 12 ++-- 3 files c

[Qemu-devel] [PATCH v2 7/8] target-arm: introduce be8 tbflag

The tb flag for be8 mode comes from the CPSR E bit. This will let us implement setend in the next patch. Signed-off-by: Paolo Bonzini --- target-arm/cpu.h | 7 +++ target-arm/translate.c | 39 --- target-arm/translate.h | 1 + 3 files changed, 32

[Qemu-devel] [PATCH v2 4/8] linux-user: arm: handle CPSR.E correctly in strex emulation

Now that CPSR.E is set correctly, prepare for when setend will be able to change it; bswap data in and out of strex manually by comparing bswap_code to CPSR.E (we do not have the luxury of using TCGMemOps). Signed-off-by: Paolo Bonzini --- linux-user/main.c | 50 +

[Qemu-devel] [PATCH v2 3/8] linux-user: arm: pass env to get_user_code_*

This matches the idiom used by get_user_data_* in the next patch. Signed-off-by: Paolo Bonzini --- linux-user/main.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 2a04446..8eb910a 100644 --- a/linux-user/main

[Qemu-devel] [PATCH v2 1/8] linux-user: arm: fix coding style for some linux-user signal functions

Signed-off-by: Paolo Bonzini --- linux-user/signal.c | 117 +++- 1 file changed, 60 insertions(+), 57 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 5b8a01f..c652829 100644 --- a/linux-user/signal.c +++ b/linux-user/signa

Re: [Qemu-devel] [PATCH 0/2] help libvirt know what's up with qga

On 05/29/2014 01:36 PM, Laszlo Ersek wrote: > In this series I try to implement the ideas that (I believe) were > suggested by Gerd and Amit in > . > > When the guest agent exits or dies (disconnects from the virtio-serial > port), the backend (

[Qemu-devel] [PATCH v2 2/8] linux-user: arm: set CPSR.E correctly for BE8 mode

Set it on startup and in signal handler frames. Signed-off-by: Paolo Bonzini --- linux-user/main.c | 1 + linux-user/signal.c | 5 + 2 files changed, 6 insertions(+) diff --git a/linux-user/main.c b/linux-user/main.c index 882186e..2a04446 100644 --- a/linux-user/main.c +++ b/linux-user/m

Re: [Qemu-devel] [PATCH 1/1] Sun4m : TCX framebuffer hardware acceleration

On 25/05/2014 22:28, Mark Cave-Ayland wrote: > On 25/05/14 14:20, Olivier Danet wrote: > >> Here is the original patch, I have changed email settings since then, it >> should work better. >> Alas, I have not merged latest QEMU changes (your CG3/TCX patches), so it >> will probably not compile as

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

On Thu, May 29, 2014 at 04:00:36PM -0300, Marcelo Tosatti wrote: > On Wed, May 28, 2014 at 01:25:38PM -0300, Eduardo Habkost wrote: > > On Wed, May 28, 2014 at 11:14:14AM +0200, Juan Quintela wrote: > > > Eduardo Habkost wrote: > > > > On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrot

[Qemu-devel] [PATCH 2/2] char: report frontend open/closed state in 'query-chardev'

In addition to the on-line reporting added in the previous patch, allow libvirt to query frontend state independently of events. Libvirt's path to identify the guest agent channel it cares about differs between the event added in the previous patch and the QMP response field added here. The event

[Qemu-devel] [PATCH 1/2] virtio-serial: report frontend connection state via monitor

Libvirt wants to know about the guest-side connection state of some virtio-serial ports (in particular the one(s) assigned to guest agent(s)). Introduce a new property that allows libvirt to request connection state reporting, and report the state via new monitor events. RHBZ: https://bugzilla.red

[Qemu-devel] [PATCH 0/2] help libvirt know what's up with qga

In this series I try to implement the ideas that (I believe) were suggested by Gerd and Amit in . When the guest agent exits or dies (disconnects from the virtio-serial port), the backend (eg. a host-side unix domain socket) doesn't (in general,

[Qemu-devel] Commit 5b6fb069378e breaks Solaris/OpenIndiana support (icount)

Git bisection tells that 5b6fb069378e61c45c577bbec3d7ef60367f7e4c is the first bad commit that breaks support for Solaris/OpenIndiana 32-bit x86 guest with icount 1. Seems like the option rom (kvmvapic.bin) is causing problems. Currently the workaround is to not load the option rom. Command: qemu-

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

Il 29/05/2014 20:41, Peter Lieven ha scritto: static inline unsigned geo_rand_range(double m, double n) { return exp((log(m) + (double)rand() / (RAND_MAX / (log(n) - log(m) + log(1)) + log(1; } Yes, exactly (except that log(1) is zero, and was only needed in your case be

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

On Wed, May 28, 2014 at 01:25:38PM -0300, Eduardo Habkost wrote: > On Wed, May 28, 2014 at 11:14:14AM +0200, Juan Quintela wrote: > > Eduardo Habkost wrote: > > > On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrote: > > >> > > >> Migration blocker is redudant: blocking savevm is suffi

Re: [Qemu-devel] [PATCH V9 3/4] raw-posix: Add full image preallocation option

Am 29.05.2014 03:55, schrieb Hu Tao: > On Wed, May 28, 2014 at 07:36:26AM +0200, Markus Armbruster wrote: >> Peter Lieven writes: >> >>> Am 27.05.2014 um 21:24 schrieb Eric Blake : >>> On 05/27/2014 02:22 AM, Chen Fan wrote: > From: Hu Tao > > This patch adds a new option preallo

Re: [Qemu-devel] [PATCH v2 RESEND] vl.c: Unify MAX_CPUMASK_BITS and machine->max_cpus checks

Ping? Who can get this applied? Without this, the machine->max_cpus limit is ignored when using cpu-add. On Wed, May 14, 2014 at 04:18:42PM -0300, Eduardo Habkost wrote: > If a given machine have max_cpus set, not just smp_cpus needs to be > limited, but the total number of CPUs (considering CPU

Re: [Qemu-devel] [libvirt] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for

On Fri, May 23, 2014 at 11:36:56PM +0200, Paolo Bonzini wrote: > You can get the current time via the qom-get command, and then > follow the same algorithm as QEMU: > > time_t seconds; > > if (rtc_date_offset == -1) { > if (rtc_utc) { > seconds = mktimegm(tm); >

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

Am 29.05.2014 19:47, schrieb Paolo Bonzini: > Il 29/05/2014 19:31, Peter Lieven ha scritto: >> +static const unsigned iscsi_retry_times[] = {4, 16, 64, 256, 1024, 4096}; > > This is a pretty fast growth. I know, I wanted to end up with a total retry period of approx. 10 seconds before failing. As

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: improve invtsc migration blocker error message

On Thu, May 29, 2014 at 01:55:14PM -0300, Marcelo Tosatti wrote: > > Improve migration blocker error message. > > Signed-off-by: Marcelo Tosatti Reviewed-by: Eduardo Habkost -- Eduardo

[Qemu-devel] [PATCH 3/3] target-arm: add support for v8 VMULL.P64 instruction

Add support for the VMULL.P64 polynomial 64x64 to 128 bit multiplication instruction in the A32/T32 instruction sets; this is part of the v8 Crypto Extensions. To do this we have to move the neon_pmull_64_{lo,hi} helpers from helper-a64.c into neon_helper.c so they can be used by the AArch32 trans

[Qemu-devel] [PATCH 1/3] target-arm: add support for v8 SHA1 and SHA256 instructions

From: Ard Biesheuvel This adds support for the SHA1 and SHA256 instructions that are available on some v8 implementations of Aarch32. Signed-off-by: Ard Biesheuvel [PMM: * rebase * fix bad indent * add a missing UNDEF check for Q!=1 in the 3-reg SHA1/SHA256 case * use g_assert_not_reached()

[Qemu-devel] [PATCH 2/3] target-arm: Allow 3reg_wide undefreq to encode more bad size options

The current undefreq field in the neon_3reg_wide handling allows us to encode "UNDEF if size != 0" and "UNDEF if size == 0". This is no longer sufficient with the advent of 64-bit polynomial VMULL, which means we want to UNDEF if size == 1. Change the undefreq encoding to use separate bits for all

[Qemu-devel] [PATCH 0/3] ARM A32/T32: implement remaining crypto insns

This patchset implements the remaining A32/T32 instructions in the ARM v8 Crypto Extensions: SHA1, SHA256 and VMULL.P64. The bulk of this is Ard's SHA patch with a few fixups from me; the VMULL.P64 patch is mine, based on the existing A64 implementation. I hope to have time to fill in the A64 cryp

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

Il 29/05/2014 19:31, Peter Lieven ha scritto: +static const unsigned iscsi_retry_times[] = {4, 16, 64, 256, 1024, 4096}; This is a pretty fast growth. +static void iscsi_retry_timer_expired(void *opaque) +{ +struct IscsiTask *iTask = opaque; +timer_del(iTask->retry_timer); This time

Re: [Qemu-devel] qemu 2.0, deadlock in block-commit

Please try disabling I/O limits on the drive and try again. Is there anything else I could try? I've captured trace of hanged VM with following events traced: bdrv_* paio_* thread_pool_* commit_* qcow2_* and debug code that prints requests from traced_requests in bdrv_requests_pending funct

Re: [Qemu-devel] [PATCH] target-arm: add support for v8 VMULL.P64 instruction

On 27 March 2014 09:29, Ard Biesheuvel wrote: > This adds support for the VMULL.P64 polynomial 64x64 to 128 bit multiplication > instruction, which is an optional feature that is part of the v8 Crypto > Extensions. > > Signed-off-by: Ard Biesheuvel > --- I've reimplemented this to use the existi

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

> I have just posted a patch copying CP0_Config1 into DisasContext, and > moving existing accesses to this variable accordingly. This can be used > as an example how to do it. Done in v4. Thanks. Regards, Petar From: Aurelien Jarno [aurel...@aurel32.net] S

[Qemu-devel] [v4 PATCH] target-mips: implement UserLocal Register

From: Petar Jovanovic >From MIPS documentation (Volume III): UserLocal Register (CP0 Register 4, Select 2) Compliance Level: Recommended. The UserLocal register is a read-write register that is not interpreted by the hardware and conditionally readable via the RDHWR instruction. This register

[Qemu-devel] [PATCH] block/iscsi: handle BUSY condition

this patch adds handling of BUSY status reponse from an iSCSI target. Currently, we fail with -EIO in case of SCSI_STATUS_BUSY while the obvious reaction would be to retry the operation after some time. The retry time is randomly choosen from a range with exponential growth increasing with each ret

Re: [Qemu-devel] [PATCH] target-arm: add support for v8 SHA1 and SHA256 instructions

On 29 May 2014 18:46, Peter Maydell wrote: > On 25 March 2014 16:27, Ard Biesheuvel wrote: >> This adds support for the SHA1 and SHA256 instructions that are available >> on some v8 implementations of Aarch32. >> >> Signed-off-by: Ard Biesheuvel > > Apologies for the incredibly late review; I wa

Re: [Qemu-devel] [PATCH v4 07/10] trace: [tcg] Include TCG-tracing helpers

Richard Henderson writes: > On 05/29/2014 05:23 AM, Lluís Vilanova wrote: >> >> #include "helper.h" >> +#define HELPER_GEN_TRACE_PROXY 1 >> +#include "trace/generated-helpers.h" >> +#undef HELPER_GEN_TRACE_PROXY >> #include "tcg-runtime.h" >> > Continued from patch 5... you don't need the HELPE

Re: [Qemu-devel] [PATCH v4 10/10] trace: [tcg] Include TCG-tracing header on all targets

Richard Henderson writes: > On 05/29/2014 05:23 AM, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> target-alpha/translate.c |3 +++ >> target-arm/translate-a64.c|2 ++ >> target-arm/translate.c|3 +++ >> target-cris/translate.c |3 +++ >> targe

[Qemu-devel] [qom/qom-cpu PATCH] i386: improve invtsc migration blocker error message

Improve migration blocker error message. Signed-off-by: Marcelo Tosatti diff --git a/target-i386/kvm.c b/target-i386/kvm.c index f9ffa4b..cfe1271 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -711,7 +711,8 @@ int kvm_arch_init_vcpu(CPUState *cs) if (c && (c->edx & 1<<8) && invt

Re: [Qemu-devel] [PATCH] target-arm: add support for v8 SHA1 and SHA256 instructions

On 25 March 2014 16:27, Ard Biesheuvel wrote: > This adds support for the SHA1 and SHA256 instructions that are available > on some v8 implementations of Aarch32. > > Signed-off-by: Ard Biesheuvel Apologies for the incredibly late review; I was hugely busy back in March and then this slipped thr

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

On 05/27/2014 07:01 AM, Igor Mammedov wrote: > Provides framework for splitting host RAM allocation/ > policies into a separate backend that could be used > by devices. > > Initially only legacy RAM backend is provided, which > uses memory_region_init_ram() allocator and compatible > with every CL

Re: [Qemu-devel] [PATCH v4 10/10] trace: [tcg] Include TCG-tracing header on all targets

On 05/29/2014 05:23 AM, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > target-alpha/translate.c |3 +++ > target-arm/translate-a64.c|2 ++ > target-arm/translate.c|3 +++ > target-cris/translate.c |3 +++ > target-i386/translate.c |3

Re: [Qemu-devel] [PATCH v4 07/10] trace: [tcg] Include TCG-tracing helpers

On 05/29/2014 05:23 AM, Lluís Vilanova wrote: > > #include "helper.h" > +#define HELPER_GEN_TRACE_PROXY 1 > +#include "trace/generated-helpers.h" > +#undef HELPER_GEN_TRACE_PROXY > #include "tcg-runtime.h" > Continued from patch 5... you don't need the HELPER_GEN_TRACE_PROXY define, just two

Re: [Qemu-devel] [PATCH v4 05/10] trace: [tcg] Declare TCG tracing helper routines

On 05/29/2014 05:23 AM, Lluís Vilanova wrote: > +'#ifdef HELPER_GEN_TRACE_PROXY', > +'static inline void %(name)s(%(args)s)', > +'{', > +'%(code_new)s', > +'%(proxy_name)s(%(tmp_names)s);', > +'%(code_free)s', > +

Re: [Qemu-devel] [PATCH v2 2/3] e1000: allow command-line selection of card model

Hi Peter, Thanks for the QOM crash course ! So I did s/TYPE_E1000/TYPE_E1000_BASE/ as suggested by Stefan, and also moved PCI_VENDOR_ID_INTEL back into e1000_class_init() and away from e1000_devices[] as you suggested. That's going to be part of v3, as soon as we're done talking about QOM, see be

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On 29/05/14 16:38, Peter Maydell wrote: > On 29 May 2014 15:29, James Hogan wrote: >> On 29/05/14 14:26, Peter Maydell wrote: >>> On 29 May 2014 14:22, James Hogan wrote: loadvm/migration will write Config3, possibly with a different value if the snapshot being loaded is an older one wi

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

Il 29/05/2014 15:26, Andreas Färber ha scritto: Am 29.05.2014 15:21, schrieb Marcel Apfelbaum: On Thu, 2014-05-29 at 15:08 +0200, Igor Mammedov wrote: On Thu, 29 May 2014 15:56:16 +0300 Marcel Apfelbaum wrote: On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: Maybe we can hack QemuOpts

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

On Fri, May 30, 2014 at 1:25 AM, Paolo Bonzini wrote: > Il 29/05/2014 16:05, Peter Crosthwaite ha scritto: > >>> > +path = object_get_canonical_path_component(OBJECT(backend)); >>> > +memory_region_init_ram(&backend->mr, OBJECT(backend), path, >> >> Passing the full canonical path as the n

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

Il 29/05/2014 17:39, Peter Crosthwaite ha scritto: > It's not the full canonical path, it's basically the id. > Fair enough. Although its still redundant though isn't it? Should we ever clean up messages etc in memory api to include both owner and name this is going to come out: "foo/bar/baz:b

Re: [Qemu-devel] [PATCH v2] vexpress: Add support for the -bios flag to provide firmware

On 29 May 2014 15:46, Laszlo Ersek wrote: > (2) Can anyone post / link a concise, *up-to-date* command line for > upstream qemu, in connection with *upstream* edk2 build instructions, so > that I can test aarch64 UEFI stuff on an x86_64 host (with TCG)? Note that AArch64 isn't relevant to this pa

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On 29 May 2014 15:29, James Hogan wrote: > On 29/05/14 14:26, Peter Maydell wrote: >> On 29 May 2014 14:22, James Hogan wrote: >>> loadvm/migration will write Config3, possibly with a different value if >>> the snapshot being loaded is an older one without userlocal support. >> >> Migration load

Re: [Qemu-devel] [PATCH v3 11/34] memory: add memory_region_is_mapped() API

Il 29/05/2014 16:22, Peter Crosthwaite ha scritto: > > +bool memory_region_is_mapped(MemoryRegion *mr) > +{ Is it not enough to just return mr->parent? Memory mapping assertion will happen if you try and map the same twice, even if one of the mappings is not contained within an AddressSpace. Che

Re: [Qemu-devel] [PATCH v2] vexpress: Add support for the -bios flag to provide firmware

On Fri, May 30, 2014 at 12:46 AM, Laszlo Ersek wrote: > CC'ing Drew, Eric and Michal. > > On 05/29/14 14:45, Peter Crosthwaite wrote: >> On Thu, May 29, 2014 at 10:24 PM, Peter Maydell >> wrote: >>> From: Grant Likely >>> >>> Right now to run firmware inside the QEMU VExpress model requires >>>

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

Il 29/05/2014 16:05, Peter Crosthwaite ha scritto: > +path = object_get_canonical_path_component(OBJECT(backend)); > +memory_region_init_ram(&backend->mr, OBJECT(backend), path, Passing the full canonical path as the name of memory region is redundant as that information is already passe

Re: [Qemu-devel] [PATCH v2] vexpress: Add support for the -bios flag to provide firmware

CC'ing Drew, Eric and Michal. On 05/29/14 14:45, Peter Crosthwaite wrote: > On Thu, May 29, 2014 at 10:24 PM, Peter Maydell > wrote: >> From: Grant Likely >> >> Right now to run firmware inside the QEMU VExpress model requires >> padding out the firmware image to the size of the virtual flash an

Re: [Qemu-devel] [PATCH v3 00/34] pc: ACPI memory hotplug

On Tue, May 27, 2014 at 11:00 PM, Igor Mammedov wrote: > NOTE to commiter: > * update precompiled ACPI hex files for iasl-less hosts >and ACPI tables test to match new ACPI tables. > > What's new since v9: > * drop usage of error_is_set() > * exit QEMU if it's started with memory hotplug bu

Re: [Qemu-devel] [PATCH v3 11/34] memory: add memory_region_is_mapped() API

On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov wrote: > which allows to check if MemoryRegion is already mapped. > > Signed-off-by: Igor Mammedov > --- > include/exec/memory.h |8 > memory.c | 15 ++- > 2 files changed, 22 insertions(+), 1 deletions(-) >

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On 29/05/14 14:26, Peter Maydell wrote: > On 29 May 2014 14:22, James Hogan wrote: >> loadvm/migration will write Config3, possibly with a different value if >> the snapshot being loaded is an older one without userlocal support. > > Migration load always happens with a freshly reset system, > so

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On Thu, May 29, 2014 at 04:06:56PM +0200, Aurelien Jarno wrote: > On Thu, May 29, 2014 at 02:48:28PM +0100, Peter Maydell wrote: > > On 29 May 2014 14:35, Petar Jovanovic wrote: > > >> change as CP0_Config3 is a read-only register. If I am right, probably > > >> the best is to check directly env->

[Qemu-devel] [PATCH] target-mips: copy CP0_Config1 into DisasContext

In order to avoid access to the CPUMIPSState structure in the translator, keep a copy of CP0_Config1 into DisasContext. The whole register is read-only so it can be copied as a single value. Signed-off-by: Aurelien Jarno --- target-mips/translate.c | 20 +++- 1 file changed, 11

Re: [Qemu-devel] [PATCH v3 10/34] dimm: implement dimm device abstraction

On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov wrote: > From: Vasilis Liaskovitis > > Each hotplug-able memory slot is a DimmDevice. > A hot-add operation for a DIMM: > - creates a new DimmDevice and makes hotplug controller to map it into > guest address space > > Hotplug operations are done

[Qemu-devel] [V4 PATCH (resend) 2/6] target-ppc: Allow little-endian user mode.

From: Doug Kwan This allows running PPC64 little-endian in user mode if target is configured that way. In PPC64 LE user mode we set MSR.LE during initialization. Signed-off-by: Doug Kwan Signed-off-by: Tom Musta --- V2: Overhaul handling of byteswapping in code generation and mem helpers. V

[Qemu-devel] [V4 PATCH (resend) 4/6] target-ppc: Support VSX in PPC User Mode

Some modern tool chains use VSX instructions. Therefore attempt to enable the VSX MSR bit by default, just like similar bits (FP, VEC, SPE, etc.). Signed-off-by: Tom Musta --- V3: new patch target-ppc/translate_init.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/t

[Qemu-devel] [V4 PATCH (resend) 6/6] target-ppc: Store Quadword Conditional Drops Size Bit

The size and register information are encoded into the reserve_info field of CPU state in the store conditional translation code. Specifically, the size is shifted left by 5 bits (see target-ppc/translate.c gen_conditional_store). The user-mode store conditional code erroneously extracts the siz

[Qemu-devel] [V4 PATCH (resend) 5/6] target-ppc: Confirm That .bss Pages Are Valid

The existing code does a check to ensure that a .bss region is properly mmap'd. When additional mmap is required, the (guest) pages are also validated. However, this code has a bug: when host page size is larger than target page size, it is possible for the .bss pages to already be (host) mapped

[Qemu-devel] [V4 PATCH (resend) 3/6] target-ppc: Add a new user mode target for little-endian PPC64.

From: Doug Kwan Signed-off-by: Doug Kwan Signed-off-by: Tom Musta --- V3: Addressing comment from Peter Maydell. Adding libdecnumber enable. configure |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 0e516f9..3ccbe4b 100755 --- a/conf

[Qemu-devel] [V4 PATCH (resend) 1/6] target-ppc: Support little-endian PPC64 in user mode.

From: Doug Kwan Look at ELF header to determine ABI version on PPC64. This is required for executing the first instruction correctly. Also print correct machine name in uname() system call. Signed-off-by: Doug Kwan Signed-off-by: Tom Musta --- V3: Addressing Peter Maydell's comments regardi

[Qemu-devel] [V4 PATCH (resend) 0/6] Adding New Target ppc64le-linux-user

This is a follow up to the patch series initiated by Doug Kwan http://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg01936.html The resubmission of V4 cleans up some attribution issues (corrects Doug's email address in the Signed-off-by and also cites Doug as the author of the first three pa

  1   2   >