[Qemu-devel] [PATCH 3/8] RunState: added two new flags for bitmap dump and migration process

2014-05-25 Thread Sanidhya Kashyap
I have added two new flags - RUN_STATE_MIGRATE and RUN_STATE_DUMP_BITMAP. These both flags behave same as RUN_STATE_RUNNING flag. The purpose of introducing these flags is to avoid running both migration and dump bitmap process simultaneously. I haven't added many transitions to the RUN_STATE_DUMP

[Qemu-devel] [PATCH 7/8] set the frequency of the dump bitmap process

2014-05-25 Thread Sanidhya Kashyap
No particular functional change. Corrected some mistakes. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 15 +++ hmp.c| 12 hmp.h| 1 + qapi-schema.json | 10 ++ qmp-commands.hx | 23 +++ savevm.c | 13

[Qemu-devel] [PATCH 6/8] cancel mechanism for an already running dump bitmap process

2014-05-25 Thread Sanidhya Kashyap
No particular functional changes. Rectified some previous mistakes. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 14 ++ hmp.c| 5 + hmp.h| 1 + qapi-schema.json | 8 qmp-commands.hx | 20 savevm.c | 19 ++

[Qemu-devel] [PATCH 5/8] hmp interface for dirty bitmap dump

2014-05-25 Thread Sanidhya Kashyap
Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 16 hmp.c | 16 hmp.h | 1 + 3 files changed, 33 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 2e462c0..1665587 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@

[Qemu-devel] [PATCH 4/8] bitmap dump process with runstates

2014-05-25 Thread Sanidhya Kashyap
Introduced both runstates: RUN_STATE_MIGRATE and RUN_STATE_DUMP_BITMAP to both migration and bitmap dump process. I want the bitmap dump process to get canceled so whenever the state changes from RUN_STATE_BITMAP to something else. But, this does not happen when I stop the guest via stop qmp inter

[Qemu-devel] [PATCH 8/8] python script for extracting bitmap from a binary file

2014-05-25 Thread Sanidhya Kashyap
No particular functional change. This file does not need to be included in the Makefile as it will be only useful once the user has generated the bitmap file via bitmap dump process. Signed-off-by: Sanidhya Kashyap --- scripts/extract-bitmap.py | 64 ++

[Qemu-devel] [PATCH 1/8] enable sharing of the function between migration and bitmap dump

2014-05-25 Thread Sanidhya Kashyap
As advised by Eric, I have enabled sharing of the function between of the function that syncs the dirty bitmap obtained via kvm ioctl. I have tried to make the least changes to the functions by concentrating only on the function definitions. Signed-off-by: Sanidhya Kashyap --- arch_init.c

[Qemu-devel] [PATCH 0/8] Obtain dirty bitmap via VM logging

2014-05-25 Thread Sanidhya Kashyap
Hi, The following patches introduce the support of dirty bitmap logging and dumping to a specified file. Still, some work is still left in the area of runstates that I will try to work on after discussing this patch series. v1 --> v2: * Added two new run states to avoid simultaneous execution of

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-25 Thread Markus Armbruster
"Gabriel L. Somlo" writes: > On Fri, May 23, 2014 at 12:00:12PM +0300, Michael S. Tsirkin wrote: >> > 1. There's a fairly complex setup (create a boot disk, start the >> > guest, loop around waiting for the bios to finish booting, watch >> > when your disk-based boot loader runs, etc.) before sta

Re: [Qemu-devel] [PATCH] libcacard: fix wrong array expansion logic

2014-05-25 Thread Michael Tokarev
26.05.2014 10:25, Markus Armbruster wrote: > Michael Tokarev writes: > >> The currrent code in libcacard/vcard_emul_nss.c:vcard_emul_options() >> has a weird bug in variable usage around expanding opts->vreader >> array. >> >> There's a helper variable, vreaderOpt, which is first needlessly >> in

Re: [Qemu-devel] [PATCH] libcacard: fix wrong array expansion logic

2014-05-25 Thread Markus Armbruster
Michael Tokarev writes: > The currrent code in libcacard/vcard_emul_nss.c:vcard_emul_options() > has a weird bug in variable usage around expanding opts->vreader > array. > > There's a helper variable, vreaderOpt, which is first needlessly > initialized to NULL, next, conditionally, only we have

Re: [Qemu-devel] [PATCH v2 6/7] libcacard/vcard_emul_nss: Assert vreaderOpt isn't null

2014-05-25 Thread Markus Armbruster
Michael Tokarev writes: > 23.05.2014 22:16, Michael Tokarev пишет: >> 23.05.2014 22:09, Michael Tokarev wrote: >>> 23.05.2014 15:24, Markus Armbruster wrote: It's not locally obvious, and Coverity can't see it either. Signed-off-by: Markus Armbruster Reviewed-by: Alon Levy >

[Qemu-devel] Disk image fuzz testing (OPW)

2014-05-25 Thread M.Kustova
Hello, My name is Maria and I'm a participant of the Outreach Program for Women. My project is fuzz testing of support of qcow2 image format. The project git: https://github.com/maxalab/qemu_fuzzer.git It's pubic, so welcome, make yourself at home. The blog: http://eeff.catit.be/ It's empty

Re: [Qemu-devel] [PATCH v2 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-05-25 Thread Edgar E. Iglesias
On Thu, May 22, 2014 at 09:30:06PM -0500, Rob Herring wrote: > From: Rob Herring > > Add the infrastructure to handle and emulate hvc and smc exceptions. > This will enable emulation of things such as PSCI calls. This commit > does not change the behavior and will exit with unknown exception. Hi

Re: [Qemu-devel] [RFC v1 08/25] memory: MemoryRegion: Add may-overlap and priority props

2014-05-25 Thread Peter Crosthwaite
On Fri, May 16, 2014 at 11:54 AM, Peter Crosthwaite wrote: > QOM propertyify the .may-overlap and .priority fields. The setters > will re-add the memory as a subregion if needed (i.e. the values change > when the memory region is already contained). > > Signed-off-by: Peter Crosthwaite > --- > >

[Qemu-devel] [PATCH v4] block: replace fprintf(stderr, ...) with error_report()

2014-05-25 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in files block/*, block.c, block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan --- block-migration.c |6 +-- block.c

Re: [Qemu-devel] [PATCH 1/1] Sun4m : TCX framebuffer hardware acceleration

2014-05-25 Thread Mark Cave-Ayland
On 25/05/14 14:20, Olivier Danet wrote: Here is the original patch, I have changed email settings since then, it should work better. Alas, I have not merged latest QEMU changes (your CG3/TCX patches), so it will probably not compile as-is... Thanks for this - don't worry about my latest patc

Re: [Qemu-devel] [PATCH 4/7] monitor: Add host_net_add device argument completion.

2014-05-25 Thread Hani Benhabiles
On Fri, May 23, 2014 at 02:05:03PM +0200, Stefan Hajnoczi wrote: > On Tue, May 20, 2014 at 12:03:17AM +0100, Hani Benhabiles wrote: > > diff --git a/hmp-commands.hx b/hmp-commands.hx > > index 919af6e..6aaec1b 100644 > > --- a/hmp-commands.hx > > +++ b/hmp-commands.hx > > @@ -1209,9 +1209,10 @@ ETE

[Qemu-devel] [Bug 1323001] [NEW] Netlink socket support for MIPS*

2014-05-25 Thread Luca Falavigna
Public bug reported: It seems QEMU does not support Netlink socket support on MIPS* Trying to compile and run this simple program: #include #include #include int main() { int audit_fd = audit_open (); printf("fd is %d\n", audit_fd); printf("errno is %d\n", errno);

[Qemu-devel] [Bug 1256546] Re: qemu-s390x-static: segmentation fault entering chroot

2014-05-25 Thread Luca Falavigna
** Changed in: qemu (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1256546 Title: qemu-s390x-static: segmentation fault entering chroot Status

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] block: replace fprintf(stderr, ...) with error_report()

2014-05-25 Thread Michael Tokarev
25.05.2014 18:45, Le Tan wrote: > Oh, yes, I may misunderstood it. I just ran ./scripts/checkpatch.pl to > check files that I touched and fixed those I can fix. So I will send > the v4 of this patch which just fix the whitespace issues based on v2. > Is that right? Forgive my being naive. :) Pleas

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] block: replace fprintf(stderr, ...) with error_report()

2014-05-25 Thread Le Tan
Oh, yes, I may misunderstood it. I just ran ./scripts/checkpatch.pl to check files that I touched and fixed those I can fix. So I will send the v4 of this patch which just fix the whitespace issues based on v2. Is that right? Forgive my being naive. :) Thanks very much for all! Le 2014-05-25 22:3

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] block: replace fprintf(stderr, ...) with error_report()

2014-05-25 Thread Michael Tokarev
25.05.2014 18:29, Jan Kiszka wrote: > On 2014-05-25 10:44, Le Tan wrote: >> Replace fprintf(stderr,...) with error_report() in files block/*, block.c, >> block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument >> have been removed because @fmt of error_report() should not contain

Re: [Qemu-devel] [PATCH v3] block: replace fprintf(stderr, ...) with error_report()

2014-05-25 Thread Jan Kiszka
On 2014-05-25 10:44, Le Tan wrote: > Replace fprintf(stderr,...) with error_report() in files block/*, block.c, > block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument > have been removed because @fmt of error_report() should not contain newline. > Also fix some coding style iss

Re: [Qemu-devel] [Xen-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-05-25 Thread Stefano Stabellini
On Fri, 23 May 2014, Fabio Fantoni wrote: > Il 23/05/2014 18:07, Stefano Stabellini ha scritto: > > Choose pc-i440fx-1.6 instead of pc for HVM guests, so that we know for > > sure what is the machine that we are emulating. > > > > Use pc-i440fx-1.6 regardless of the xen_platform_pci option. Add th

Re: [Qemu-devel] [PATCH v3] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-05-25 Thread Jun Li
please ignore this one. On 05/18/2014 06:34 PM, Jun Li wrote: On 05/12/2014 11:15 PM, Eric Blake wrote: On 05/10/2014 10:35 AM, Jun Li wrote: From: Jun Li I see three different "[PATCH v3]" mails with this subject. To make sure we are reviewing the right version, it might help to bump to v

Re: [Qemu-devel] [PATCH v3] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-05-25 Thread Jun Li
On 05/12/2014 11:15 PM, Eric Blake wrote: On 05/10/2014 10:35 AM, Jun Li wrote: From: Jun Li I see three different "[PATCH v3]" mails with this subject. To make sure we are reviewing the right version, it might help to bump to version 4. Yes, I have send v4 of this patch and changed the co

Re: [Qemu-devel] [PATCH v6 5/7] vfio: Introduce VFIO address spaces

2014-05-25 Thread David Gibson
On Sun, May 25, 2014 at 12:16:20PM +0200, Alexander Graf wrote: > > On 24.05.14 05:12, Alexey Kardashevskiy wrote: > >On 05/24/2014 07:15 AM, Alexander Graf wrote: > >>On 23.05.14 18:16, Alexey Kardashevskiy wrote: > >>>On 05/23/2014 10:05 PM, Alexander Graf wrote: > On 23.05.14 14:03, Alexey

Re: [Qemu-devel] [PATCH 1/1] Sun4m : TCX framebuffer hardware acceleration

2014-05-25 Thread Olivier Danet
On 25/05/2014 11:50, Mark Cave-Ayland wrote: > On 16/02/14 23:15, Olivier Danet wrote: > >> The S24/TCX framebuffer is a mildly accelerated video card, with >> blitter, stippler and hardware cursor. >> * Solaris and NetBSD 6.x use all the hardware acceleration features. >> * The Xorg driver (used

Re: [Qemu-devel] [Qemu-trivial] patch: add delay= suboption to -display curses

2014-05-25 Thread Dave Mielke
[quoted lines by Michael Tokarev on 2014/05/25 at 16:41 +0400] >In addition to what Peter said, I think this suboption is named poorly. >Maybe it can be named, say, kbddelay, or keydelay, or something like that. >Just "delay" may be interpreted as _video_ delay, ie, delay updating picture >for so

Re: [Qemu-devel] [Qemu-trivial] patch: add delay= suboption to -display curses

2014-05-25 Thread Michael Tokarev
25.05.2014 03:29, Dave Mielke wrote: > Add support for the "-display curses" option to accept suboptions (-display > curses[,option...), and add the "delay=" suboption. This suboption > causes a millisecond-based delay to be inserted in between key events so that In addition to what Peter said

Re: [Qemu-devel] patch: add delay= suboption to -display curses

2014-05-25 Thread Dave Mielke
[quoted lines by Peter Maydell on 2014/05/25 at 10:11 +0100] >Ah, I see. Still, I think it makes more sense for the queue and delay >to be in the common key handling code, not in the curses frontend >specifically. The code has been moved. I can see a couple of possibilities insofar as an option

Re: [Qemu-devel] patch: add delay= suboption to -display curses

2014-05-25 Thread Dave Mielke
[quoted lines by Peter Maydell on 2014/05/25 at 10:11 +0100] >Ah, I see. Still, I think it makes more sense for the queue and delay >to be in the common key handling code, not in the curses frontend >specifically. Yes, you're right. While the curses UI is especially vulnerable to the problem, ot

Re: [Qemu-devel] [PATCH v6 5/7] vfio: Introduce VFIO address spaces

2014-05-25 Thread Alexander Graf
On 24.05.14 05:12, Alexey Kardashevskiy wrote: On 05/24/2014 07:15 AM, Alexander Graf wrote: On 23.05.14 18:16, Alexey Kardashevskiy wrote: On 05/23/2014 10:05 PM, Alexander Graf wrote: On 23.05.14 14:03, Alexey Kardashevskiy wrote: On 05/23/2014 09:28 PM, Alexander Graf wrote: On 23.05.14

Re: [Qemu-devel] [Qemu-trivial] [PATCH] libcacard: remove useless initializers

2014-05-25 Thread Alon Levy
On 05/23/2014 11:59 PM, Michael Tokarev wrote: > So, should we apply this or not? It's been waiting for quite some time, > and during this time we've found a very good example of why it should > be applied (I think anyway). I'm fine with applying it, I changed my mind. > > Thanks, > > /mjt >

Re: [Qemu-devel] [PATCH 1/1] Sun4m : TCX framebuffer hardware acceleration

2014-05-25 Thread Mark Cave-Ayland
On 16/02/14 23:15, Olivier Danet wrote: The S24/TCX framebuffer is a mildly accelerated video card, with blitter, stippler and hardware cursor. * Solaris and NetBSD 6.x use all the hardware acceleration features. * The Xorg driver (used by Linux) can use the hardware cursor only. This patch imp

[Qemu-devel] nbd: Add exports listing support

2014-05-25 Thread Hani Benhabiles
Before the patches: $ nbd-client -l localhost Negotiation: .. E: Server does not support listing exports After the patches: $ nbd-client -l localhost Negotiation: .. ide0-hd0 ide1-cd0 Hani Benhabiles (2): nbd: Handle fixed new-style clients. nbd: Handle NBD_OPT_LIST option. include/block/n

[Qemu-devel] [PATCH 2/2] nbd: Handle NBD_OPT_LIST option.

2014-05-25 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- include/block/nbd.h | 4 +++ nbd.c | 97 +++-- 2 files changed, 99 insertions(+), 2 deletions(-) diff --git a/include/block/nbd.h b/include/block/nbd.h index 95d52ab..23e9a84 100644 --- a/include/bl

[Qemu-devel] [PATCH 1/2] nbd: Handle fixed new-style clients.

2014-05-25 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- include/block/nbd.h | 6 ++ nbd.c | 12 +++- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/include/block/nbd.h b/include/block/nbd.h index 79502a0..95d52ab 100644 --- a/include/block/nbd.h +++ b/include/block/nbd.h @@

Re: [Qemu-devel] patch: add delay= suboption to -display curses

2014-05-25 Thread Peter Maydell
On 25 May 2014 02:21, Dave Mielke wrote: > [quoted lines by Peter Maydell on 2014/05/25 at 01:04 +0100] >>Why is this a problem only for the curses UI frontend, and not for >>any of the other UIs which might send key events? > > One reason is that most UIs send key events as they receive them from

Re: [Qemu-devel] [PATCH v4 00/21] target-arm: Preparations for A64 EL2 and 3

2014-05-25 Thread Peter Maydell
On 25 May 2014 01:28, Edgar E. Iglesias wrote: > Thanks for finding and fixing this. I run a script that builds qemu > and boots a bunch of kernel images for every commit in a series > but apparently it didn't catch this stuff. I'll see if I can add > more test cases to cover more. The srs bug I