Re: [Qemu-devel] [PATCH] xhci: child detach fix

2014-05-12 Thread Gerd Hoffmann
Hi, > BTW, in usb_release_port(), the detached port should be insert > the head of bus->free list table. Because of the save/restore will > cause qemu crash, after hot plug/hot unplug multi times. For example, > save the port '2' to memory file, but when we restore it, the port will > be assign

Re: [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access extern

2014-05-12 Thread Andreas Färber
Am 08.05.2014 18:09, schrieb Paolo Bonzini: > We will reference it from more files in the next patch. > > Signed-off-by: Paolo Bonzini > --- > target-alpha/cpu.h | 3 +++ > target-alpha/mem_helper.c | 4 ++-- > target-mips/cpu.h | 3 +++ > target-mips/op_helper.c| 8 ++-

Re: [Qemu-devel] [PATCH] usb: fix up post load checks

2014-05-12 Thread Gerd Hoffmann
On Di, 2014-05-13 at 03:02 +, Gonglei (Arei) wrote: > Hi, > > > -Original Message- > > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > > Behalf Of Michael S. Tsirkin > > Sent: Monday, May 12, 2014 8:16

[Qemu-devel] [Bug 1308341] Re: Multiple CPUs causes blue screen on Windows guest

2014-05-12 Thread Krzysztof Cybulski
It look like adding "hyperv" in "features" section to guest definition helps, my Win7 VM now is running for ~12h, when without "hyperv" it was like 3-4 hour. I will test it for few days and will post here again. -- You received this bug notification because

Re: [Qemu-devel] uvesafb doesn't work with seabios

2014-05-12 Thread Bernhard Walle
Hi, * Kevin O'Connor [2014-05-12 22:07]: > On Mon, May 12, 2014 at 08:53:53PM +0200, Bernhard Walle wrote: > > Am 2014-05-12 07:29, schrieb Kevin O'Connor: > > > > > >It does look like the x86emu issue. You can try applying the > > >SeaVGABIOS patch below to confirm it. > > > > The output doesn

Re: [Qemu-devel] [PATCH 01/18] migration: dump vmstate info as a json file for static analysis

2014-05-12 Thread Amit Shah
Hi, On (Mon) 12 May 2014 [06:51:54], Eric Blake wrote: > On 05/12/2014 05:16 AM, Amit Shah wrote: > > This commit adds a new command, '-dump-vmstate', that takes a filename > > as a parameter. When executed, QEMU will dump the vmstate information > > for the machine type it's invoked with to the

Re: [Qemu-devel] [PATCH] xhci: child detach fix

2014-05-12 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Gerd Hoffmann > Sent: Monday, May 12, 2014 8:50 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann > Subject: [Qemu-devel] [PATC

Re: [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-12 Thread Edgar E. Iglesias
On Mon, May 12, 2014 at 07:13:45PM +, Aggeler Fabian wrote: > Hi > > I’ve been reworking the Samsung patches as part of my Master thesis and I > wanted to send them some time this week. I am currently rebasing them when I > noticed Edgar’s patches. Is there some branch with the patches so I

Re: [Qemu-devel] [PATCH] vfio-pci: Quirk RTL8168 NIC

2014-05-12 Thread Alex Williamson
On Mon, 2014-05-12 at 14:28 -0600, Alex Williamson wrote: > On Mon, 2014-05-12 at 22:02 +0200, Francois Romieu wrote: > > Alex Williamson : > > [...] > > > device MSI will be blocked. The Linux driver doesn't make use of this > > > window, so apparently it's not required to make use of MSI-X. Th

Re: [Qemu-devel] [PATCH] usb: fix up post load checks

2014-05-12 Thread Gonglei (Arei)
Hi, > -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Michael S. Tsirkin > Sent: Monday, May 12, 2014 8:16 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann; dgilb...@redhat.co

Re: [Qemu-devel] [PATCH v4 2/3] qapi: add const prefix to 'char *' insider c_type()

2014-05-12 Thread Eric Blake
On 05/07/2014 07:14 PM, Amos Kong wrote: > It's ugly to add const prefix for parameter type by a if statement s/a if/an if/ > outsider c_type(). This patch adds a parameter to do it. s/outsider/outside/ > > Signed-off-by: Amos Kong > Suggested-by: Markus Armbruster > --- > scripts/qapi-comm

Re: [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list

2014-05-12 Thread Eric Blake
On 05/07/2014 07:14 PM, Amos Kong wrote: > The space before pointers is redundant. > > Signed-off-by: Amos Kong > --- > scripts/qapi-visit.py | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) Appears to be unchanged from v2. Missing the Reviewed-by I gave on v2 fo

Re: [Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements

2014-05-12 Thread Hu Tao
On Fri, May 09, 2014 at 11:13:50PM +0200, Paolo Bonzini wrote: > Il 09/05/2014 19:54, Eduardo Habkost ha scritto: > >On Fri, May 09, 2014 at 04:29:49PM +0800, Hu Tao wrote: > >>On Thu, May 08, 2014 at 04:51:56PM +0200, Paolo Bonzini wrote: > >>>Il 06/05/2014 11:27, Hu Tao ha scritto: > This ser

[Qemu-devel] [PATCH] virtio-blk: Allow config-wce in dataplane

2014-05-12 Thread Fam Zheng
Dataplane now uses block layer. Protect bdrv_set_enable_write_cache with aio_context_acquire and aio_context_release, so we can enable config-wce to allow guest to modify the write cache online. Signed-off-by: Fam Zheng --- This applies on top of Stefan's "dataplane: use QEMU block layer" series

Re: [Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements

2014-05-12 Thread Hu Tao
On Fri, May 09, 2014 at 02:54:15PM -0300, Eduardo Habkost wrote: > On Fri, May 09, 2014 at 04:29:49PM +0800, Hu Tao wrote: > > On Thu, May 08, 2014 at 04:51:56PM +0200, Paolo Bonzini wrote: > > > Il 06/05/2014 11:27, Hu Tao ha scritto: > > > > This series includes work on QOMifying the memory backe

Re: [Qemu-devel] [PATCH v3 07/25] curl: implement .bdrv_detach/attach_aio_context()

2014-05-12 Thread Fam Zheng
On Thu, 05/08 16:34, Stefan Hajnoczi wrote: > The curl block driver uses fd handlers, timers, and BHs. The fd > handlers and timers are managed on behalf of libcurl, which controls > them using callback functions that the block driver implements. > > The simplest way to implement .bdrv_detach/att

[Qemu-devel] [PULL 01/26] exec-all.h: Use stl_p to avoid undefined behaviour patching x86 jumps

2014-05-12 Thread Richard Henderson
From: Peter Maydell The code which patches x86 jump instructions assumes it can do an unaligned write of a uint32_t. This is actually safe on x86, but it's still undefined behaviour. We have infrastructure for doing efficient unaligned accesses which doesn't engage in undefined behaviour, so use

[Qemu-devel] [PULL 10/26] tcg-arm: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
And use tcg pointer differencing functions as appropriate. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 150 +++ tcg/arm/tcg-target.h | 1 + 2 files changed, 55 insertions(+), 96 deletions(-) diff --git

[Qemu-devel] [PULL 13/26] tcg-ia64: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
Using a 16-byte aligned structure achieves best results, both for code cleanliness and compiled code size. However, this means that we can't use the trick of encoding the slot number into the low 2 bits. Thankfully, we only ever use slot2, so make that explicit in the names of the relocation func

[Qemu-devel] [PULL 18/26] tcg-s390: Rename tgen_calli to tcg_out_call

2014-05-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index ae1be1c..0ae40e1 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s390/tcg-target.c @@ -1269,7 +1269,7 @@ static v

[Qemu-devel] [PULL 15/26] tci: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
And use tcg pointer differencing functions as appropriate. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c | 19 +-- tcg/tci/tcg-target.h | 1 + 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/tcg/tci/tcg-target.c b/tcg/tci/t

Re: [Qemu-devel] [PATCH] target-i386 update

2014-05-12 Thread Richard Henderson
queue/qmp' into staging > (2014-05-09 15:46:34 +0100) > > are available in the git repository at: > > > git://github.com/rth7680/qemu.git tags/pull-tgt-i386-20140512 > > for you to fetch changes up to dc1823ce26f0539eab098e0209400d793ef66279: > > targ

[Qemu-devel] [PATCH 00/10] tcg cleanup and optimization

2014-05-12 Thread Richard Henderson
Two unrelated changes here, but the first consists of only one patch and I'm too lazy to do two patch sets. The first change improves code for 64-bit guests on 32-bit hosts. If we can prove that one half of a 64-bit comparison is constant, we can simplify to only comparing the other half. This i

[Qemu-devel] [PULL 08/26] tcg-ppc: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
And use tcg pointer differencing functions as appropriate. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c | 195 --- tcg/ppc/tcg-target.h | 1 + 2 files changed, 94 insertions(+), 1

[Qemu-devel] [PULL 14/26] tcg-mips: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
And use tcg pointer differencing functions as appropriate. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.c | 116 -- tcg/mips/tcg-target.h | 1 + 2 files changed, 37 insertions(+), 80 deletions(-) diff --gi

[Qemu-devel] [PATCH 04/10] tcg: Use helper-gen.h in tcg-op.h

2014-05-12 Thread Richard Henderson
No need to open-code the setup of the builtin helpers. Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 175 +-- 1 file changed, 25 insertions(+), 150 deletions(-) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index 8560695..f4367a0 100644 -

[Qemu-devel] [PULL 16/26] tcg: Require TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
Now that all backends do define TCG_TARGET_INSN_UNIT_SIZE, remove the fallback definition. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/tcg.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index a3fb88c..4f4b1fa 100644 --- a/t

[Qemu-devel] [PULL 02/26] tcg: Avoid stores to unaligned addresses

2014-05-12 Thread Richard Henderson
From: Peter Maydell Avoid stores to unaligned addresses in TCG code generation, by using the usual memcpy() approach. (Using bswap.h would drag a lot of QEMU baggage into TCG, so it's simpler just to do direct memcpy() here.) Reviewed-by: Alex Bennée Signed-off-by: Peter Maydell Signed-off-by:

[Qemu-devel] [PATCH 02/10] tcg: Invert the inclusion of helper.h

2014-05-12 Thread Richard Henderson
Rather than include helper.h with N values of GEN_HELPER, include a secondary file that sets up the macros to include helper.h. This minimizes the files that must be rebuilt when changing the macros for file N. Signed-off-by: Richard Henderson --- include/exec/helper-gen.h|

[Qemu-devel] [PULL 03/26] tcg: Avoid undefined behaviour patching code at unaligned addresses

2014-05-12 Thread Richard Henderson
From: Peter Maydell To avoid C undefined behaviour when patching generated code, provide wrappers tcg_patch8/16/32/64 which use the usual memcpy trick, and use them in the i386 backend. Reviewed-by: Alex Bennée Signed-off-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/i386/tcg-ta

[Qemu-devel] [PULL 24/26] tcg: Make call address a constant parameter

2014-05-12 Thread Richard Henderson
Avoid allocating a tcg temporary to hold the constant address, and instead place it directly into the op_call arguments. At the same time, convert to the newly introduced tcg_out_call backend function, rather than invoking tcg_out_op for the call. Signed-off-by: Richard Henderson --- tcg/optimi

[Qemu-devel] [PATCH 03/10] tcg: Push tcg-runtime routines into exec/helper-*

2014-05-12 Thread Richard Henderson
Rather than special casing them, use the standard mechanisms for tcg helper generation. Signed-off-by: Richard Henderson --- include/exec/helper-gen.h | 1 + include/exec/helper-head.h | 12 include/exec/helper-proto.h | 1 + include/exec/helper-tcg.h | 1 + tcg-runtime.c

[Qemu-devel] [PULL 00/26] tcg updates

2014-05-12 Thread Richard Henderson
he following changes since commit 06b4f00d53637f2c16a62c2cbaa30bffb045cf88: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-05-09 15:46:34 +0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20140512

Re: [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-12 Thread Peter Crosthwaite
On Tue, May 13, 2014 at 5:13 AM, Aggeler Fabian wrote: > Hi > > I’ve been reworking the Samsung patches as part of my Master thesis and I > wanted to send them some time this week. I am currently rebasing them when I > noticed Edgar’s patches. Is there some branch with the patches so I could >

Re: [Qemu-devel] [PATCH] vfio-pci: Quirk RTL8168 NIC

2014-05-12 Thread Francois Romieu
Alex Williamson : [...] > device MSI will be blocked. The Linux driver doesn't make use of this > window, so apparently it's not required to make use of MSI-X. This It does not really use MSI-X (no RSS). > quirk makes the device work with the Windows driver that does use this > window for MSI-

[Qemu-devel] [Bug 1318746] Re: qemu Windows 7 BSOD when using hv-time

2014-05-12 Thread Maik Broemme
Forgot to mention. Used qemu version was 2.0.0. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1318746 Title: qemu Windows 7 BSOD when using hv-time Status in QEMU: New Bug description: When I

[Qemu-devel] [PULL 12/26] tcg-s390: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
And use tcg pointer differencing functions as appropriate. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 91 --- tcg/s390/tcg-target.h | 2 ++ 2 files changed, 45 insertions(+), 48 deletions(-) diff --git a/tcg/s390/tcg-target.c b/

[Qemu-devel] [Bug 1318746] [NEW] qemu Windows 7 BSOD when using hv-time

2014-05-12 Thread Maik Broemme
Public bug reported: When I use hv-time sub option and run CPU-Z or 3DMark (Physics Test) the Windows 7 guest stops with BSOD (SYSTEM_SERVICE_EXCEPTION). It can be easily reproduced by running CPU-Z. It will fail every second or third time you execute CPU-Z and fail during "PCI detection". If I di

[Qemu-devel] [PATCH 09/10] tcg: Remove sizemask and flags arguments to tcg_gen_callN

2014-05-12 Thread Richard Henderson
Take them from the TCGHelperInfo struct instead. Signed-off-by: Richard Henderson --- include/exec/helper-gen.h | 18 ++ include/exec/helper-head.h | 3 +-- tcg/tcg.c | 17 +++-- tcg/tcg.h | 4 ++-- 4 files changed, 16 insertions(+

[Qemu-devel] [PATCH 07/10] tcg: Register the helper info struct rather than the name

2014-05-12 Thread Richard Henderson
This will let us find all the info from the hash table. Signed-off-by: Richard Henderson --- tcg/tcg.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index b64471f..3bbf982 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -356,7 +356,7 @@ void tcg_conte

[Qemu-devel] [PATCH 08/10] tcg: Save flags and computed sizemask in TCGHelperInfo

2014-05-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/helper-tcg.h | 44 tcg/tcg.c | 7 +++ 2 files changed, 35 insertions(+), 16 deletions(-) diff --git a/include/exec/helper-tcg.h b/include/exec/helper-tcg.h index 0da6b97..d704c81 1

[Qemu-devel] [PATCH 10/10] tcg: Move size effects out of dh_arg

2014-05-12 Thread Richard Henderson
Tidying the initialization of the args arrays at the same time. Signed-off-by: Richard Henderson --- include/exec/helper-gen.h | 87 -- include/exec/helper-head.h | 2 +- 2 files changed, 39 insertions(+), 50 deletions(-) diff --git a/include/exec/h

[Qemu-devel] [PATCH 05/10] tcg: Inline tcg_gen_helperN

2014-05-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/helper-gen.h | 12 ++-- tcg/tcg-op.h | 7 --- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h index abde615..208d1d2 100644 --- a/include/exec/helper-g

[Qemu-devel] [PATCH 06/10] tcg: Move side effects out of dh_sizemask

2014-05-12 Thread Richard Henderson
Moving them into dh_arg instead. Signed-off-by: Richard Henderson --- include/exec/helper-gen.h | 18 ++ include/exec/helper-head.h | 5 ++--- 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h index 208d1d2..21

[Qemu-devel] [PATCH 01/10] tcg: Optimize brcond2 and setcond2 ne/eq

2014-05-12 Thread Richard Henderson
If either the high or low pair can be resolved, we can simplify to either a constant or to a 32-bit comparison. Signed-off-by: Richard Henderson --- tcg/optimize.c | 94 ++ 1 file changed, 94 insertions(+) diff --git a/tcg/optimize.c b/tcg

[Qemu-devel] [PATCH 1/2] nbd: Close socket on negotiation failure.

2014-05-12 Thread Hani Benhabiles
Otherwise, the nbd client may hang waiting for the server response. Signed-off-by: Hani Benhabiles --- Quick method to trigger such behaviour: (qemu) nbd_server_start localhost:10809 (qemu) nbd_server_add sd0 $ nbd-client localhost 10809 -name /dev/nbd0 Negotiation: .. (Client will hang i

[Qemu-devel] [PULL 26/26] tcg: Remove unreachable code in tcg_out_op and op_defs

2014-05-12 Thread Richard Henderson
The INDEX_op_call case has just been obsoleted; the mov and movi cases have not been reachable for years. Attempt to document this both in each tcg_out_op switch, and via TCG_OPF_NOT_PRESENT. Because of the TCG_OPF_NOT_PRESENT change, this must be done for all targets in a single commit. Signed-

[Qemu-devel] [PULL 23/26] tci: Create tcg_out_call

2014-05-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tcg/tci/tcg-target.c b/tcg/tci/tcg-target.c index 6123f9f..7425e73 100644 --- a/tcg/tci/tcg-target.c +++ b/tcg/tci/tcg-target.c @@ -549,6 +549,11 @@ static void tcg_out_movi(TCGConte

[Qemu-devel] [PULL 20/26] tcg-ppc64: Rename tcg_out_calli to tcg_out_call

2014-05-12 Thread Richard Henderson
Merge the existing tcg_out_call into tcg_out_op. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 37 - 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 4a0b7db..d80f2d9 100644 -

[Qemu-devel] [PATCH 2/2] nbd: Miscellaneous typo fixes.

2014-05-12 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- nbd.c | 2 +- qemu-nbd.c| 2 +- qemu-nbd.texi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/nbd.c b/nbd.c index e5084b6..e0d032c 100644 --- a/nbd.c +++ b/nbd.c @@ -306,7 +306,7 @@ static int nbd_send_negotiate(NBDClient *clie

[Qemu-devel] [PULL 25/26] tcg: Use tcg_target_available_regs in tcg_reg_alloc_mov

2014-05-12 Thread Richard Henderson
The move opcodes are special in that their constraints must cover all available registers. So instead of checking the constraints, just use the available registers. Signed-off-by: Richard Henderson --- tcg/tcg.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --

[Qemu-devel] [PULL 11/26] tcg-aarch64: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
And use tcg pointer differencing functions as appropriate. Acked-by: Claudio Fontana Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 121 --- tcg/aarch64/tcg-target.h | 1 + 2 files changed, 53 insertions(

[Qemu-devel] [PULL 22/26] tcg-mips: Split out tcg_out_call

2014-05-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c index eaf1745..65acc86 100644 --- a/tcg/mips/tcg-target.c +++ b/tcg/mips/tcg-target.c @@ -153,11 +153,6

[Qemu-devel] [PULL 05/26] tcg: Define tcg_insn_unit for code pointers

2014-05-12 Thread Richard Henderson
To be defined by the tcg backend based on the elemental unit of the ISA. During the transition, allow TCG_TARGET_INSN_UNIT_SIZE to be undefined, which allows us to default tcg_insn_unit to the current uint8_t. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/exec/exec-all

[Qemu-devel] [PULL 19/26] tcg-ppc: Split out tcg_out_call

2014-05-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index 32f600c..9062898 100644 --- a/tcg/ppc/tcg-target.c +++ b/tcg/ppc/tcg-target.c @@ -501,7 +501,7 @@ static void

[Qemu-devel] [PULL 21/26] tcg-sparc: Create tcg_out_call

2014-05-12 Thread Richard Henderson
Rename the existing tcg_out_calli to tcg_out_call_nodelay. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 22a98fb..4f8de1e 100644 --- a/t

[Qemu-devel] [PULL 04/26] tcg: Introduce byte pointer arithmetic helpers

2014-05-12 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg.h | 45 + 1 file changed, 45 insertions(+) diff --git a/tcg/tcg.h b/tcg/tcg.h index a6a2d06..d38c92d 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -724,6 +724,51 @@ TCGv_i32 tcg_const

[Qemu-devel] [PULL 17/26] tcg-i386: Rename tcg_out_calli to tcg_out_call

2014-05-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index eb8d2a1..48a95f8 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@ -1113,7 +1113,7 @@ static voi

[Qemu-devel] [PULL 09/26] tcg-sparc: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
And use tcg pointer differencing functions as appropriate. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 128 +++-- tcg/sparc/tcg-target.h | 1 + 2 files changed, 60 insertions(+), 69 deletions(-) diff --g

[Qemu-devel] [PULL 07/26] tcg-ppc64: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
And use tcg pointer differencing functions as appropriate. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 164 - tcg/ppc64/tcg-target.h | 1 + 2 files changed, 81 insertions(+), 84 deletions(-) diff --git

[Qemu-devel] [PULL 06/26] tcg-i386: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
And use tcg pointer differencing functions as appropriate. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 48 tcg/i386/tcg-target.h | 2 ++ 2 files changed, 26 insertions(+), 24

Re: [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-12 Thread Aggeler Fabian
Hi I’ve been reworking the Samsung patches as part of my Master thesis and I wanted to send them some time this week. I am currently rebasing them when I noticed Edgar’s patches. Is there some branch with the patches so I could rebase on them? Thanks, Fabian On 07 May 2014, at 05:46, Edgar E.

Re: [Qemu-devel] KVM call agenda for 2014-05-13

2014-05-12 Thread Peter Crosthwaite
On Mon, May 12, 2014 at 9:09 PM, Peter Maydell wrote: > On 12 May 2014 11:30, Peter Crosthwaite wrote: >> On Mon, May 12, 2014 at 7:44 PM, Peter Maydell >> wrote: >>> On 12 May 2014 10:10, Juan Quintela wrote: Please, send any topic that you are interested in covering. - QOMifyi

Re: [Qemu-devel] [PATCH v3 15/16] tci: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
On 05/09/2014 06:52 AM, Peter Maydell wrote: > though I note there are a number of functions that > use the pattern > > uint8_t *old_code_ptr = s->code_ptr; > [...emit stuff...] > old_code_ptr[1] = s->code_ptr - old_code_ptr; > > which could perhaps use tcg_insn_unit * rather than uin

[Qemu-devel] [PATCH] target-i386 update

2014-05-12 Thread Richard Henderson
ository at: git://github.com/rth7680/qemu.git tags/pull-tgt-i386-20140512 for you to fetch changes up to dc1823ce26f0539eab098e0209400d793ef66279: target-i386: Preserve the Z bit for bt/bts/btr/btc (2014-05-12 14:20:04 -0700) Fix BT

[Qemu-devel] [PATCH] target-i386: Preserve the Z bit for bt/bts/btr/btc

2014-05-12 Thread Richard Henderson
Older Intel manuals (pre-2010) and current AMD manuals describe Z as undefined, but newer Intel manuals describe Z as unchanged. Cc: qemu-sta...@nongnu.org Reviewed-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target-i386/translate.c | 40 +++- 1 fi

Re: [Qemu-devel] [PATCH] target-i386: fix handling of ZF in btx instructions

2014-05-12 Thread Richard Henderson
On 05/07/2014 02:03 AM, Peter Maydell wrote: > On 6 May 2014 14:33, Dmitry Poletaev wrote: >> Eflags for bt/bts/btr/btc instructions compute as for shift(SAR) >> instructions. According to Intel A2 manual, for btx instructions zf is >> unaffected under any condition, but for SAR group, when eval

Re: [Qemu-devel] [PATCH 4/5] qcow1: Validate image size (CVE-2014-0223)

2014-05-12 Thread Benoît Canet
The Monday 12 May 2014 à 19:04:22 (+0200), Benoît Canet wrote : > The Monday 12 May 2014 à 18:43:33 (+0200), Kevin Wolf wrote : > > Am 12.05.2014 um 17:50 hat Benoît Canet geschrieben: > > > The Monday 12 May 2014 à 15:04:10 (+0200), Kevin Wolf wrote : > > > > A huge image size could cause s->l1_si

Re: [Qemu-devel] [PATCH v3 12/16] tcg-s390: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Peter Maydell
On 12 May 2014 18:05, Richard Henderson wrote: > On 05/09/2014 06:35 AM, Peter Maydell wrote: >> Why do these lose the 'const' ? > > Because "const void *" has a conversion warning to > non-const "tcg_type_unit *". One would have to carry > the const all the way through all of the relocation > ro

Re: [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-12 Thread Peter Maydell
On 12 May 2014 20:13, Aggeler Fabian wrote: > I’ve been reworking the Samsung patches as part of my Master thesis and I > wanted to > send them some time this week. I am currently rebasing them when I noticed > Edgar’s > patches. Is there some branch with the patches so I could rebase on them?

Re: [Qemu-devel] [Qemu-ppc] macio ide question/bug report

2014-05-12 Thread Mark Cave-Ayland
On 12/05/14 20:32, BALATON Zoltan wrote: On Mon, 12 May 2014, Mark Cave-Ayland wrote: On 10/05/14 13:30, BALATON Zoltan wrote: That patch would be 80fc95d8bdaf3392106b131a97ca701fd374489a in QEMU master. I've tried reverting it and Darwin still boots (without -M mac99) up to the point where it

Re: [Qemu-devel] [PATCH 2/2 v2] ppc-e500: implement PCI INTx routing

2014-05-12 Thread Alexander Graf
On 12.05.14 17:29, Andreas Färber wrote: diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c index f672d5f..5ed59e8 100644 --- a/hw/pci-host/ppce500.c +++ b/hw/pci-host/ppce500.c [...] @@ -267,13 +269,26 @@ static int mpc85xx_pci_map_irq(PCIDevice *pci_dev, int pin) static void mp

Re: [Qemu-devel] [PATCHv4] block: optimize zero writes with bdrv_write_zeroes

2014-05-12 Thread Eric Blake
On 05/08/2014 10:22 AM, Peter Lieven wrote: > this patch tries to optimize zero write requests > by automatically using bdrv_write_zeroes if it is > supported by the format. > > This significantly speeds up file system initialization and > should speed zero write test used to test backend storage

Re: [Qemu-devel] [PATCH] vfio-pci: Quirk RTL8168 NIC

2014-05-12 Thread Alex Williamson
On Mon, 2014-05-12 at 22:02 +0200, Francois Romieu wrote: > Alex Williamson : > [...] > > device MSI will be blocked. The Linux driver doesn't make use of this > > window, so apparently it's not required to make use of MSI-X. This > > It does not really use MSI-X (no RSS). Oh right, I looked f

[Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot

2014-05-12 Thread Mike Day
When deleting the last snapshot, copying the resulting snapshot table currently fails, causing the delete operation to also fail. Fix the failure by skipping the copy and just writing the snapshot header and freeing the extra clusters. There are two specific problems in the current code. First is

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-12 Thread Alexander Graf
On 09.05.14 13:53, Paolo Bonzini wrote: Il 09/05/2014 04:28, Marcelo Tosatti ha scritto: Alex, Unability to upgrade systems is not an excuse to fix the bug in the wrong place. It may be an excuse to fix the bug in both places though. The bug in the kernel should be fixed differently though

Re: [Qemu-devel] uvesafb doesn't work with seabios

2014-05-12 Thread Kevin O'Connor
On Mon, May 12, 2014 at 08:53:53PM +0200, Bernhard Walle wrote: > Am 2014-05-12 07:29, schrieb Kevin O'Connor: > > > >It does look like the x86emu issue. You can try applying the > >SeaVGABIOS patch below to confirm it. > > The output doesn't appear. But I'm sure that I copied the correct files >

Re: [Qemu-devel] [Qemu-ppc] macio ide question/bug report

2014-05-12 Thread BALATON Zoltan
On Mon, 12 May 2014, Mark Cave-Ayland wrote: On 10/05/14 13:30, BALATON Zoltan wrote: That patch would be 80fc95d8bdaf3392106b131a97ca701fd374489a in QEMU master. I've tried reverting it and Darwin still boots (without -M mac99) up to the point where it asks to install as before but I don't know

Re: [Qemu-devel] uvesafb doesn't work with seabios

2014-05-12 Thread Bernhard Walle
Am 2014-05-12 07:29, schrieb Kevin O'Connor: It does look like the x86emu issue. You can try applying the SeaVGABIOS patch below to confirm it. The output doesn't appear. But I'm sure that I copied the correct files because modifications of other strings worked. Regards, Bernhard -Kevin

Re: [Qemu-devel] [PATCH] qemu-img fails to delete last snapshot

2014-05-12 Thread Mike Day
On Mon, May 12, 2014 at 12:39 PM, Eric Blake wrote: > This information is actually quite useful in understanding the patch, > and I would have included it prior to the --- for inclusion in git, > rather than in the reviewer-only commentary that gets stripped during > 'git am'. > >> >> block/qcow2

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-12 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 12.05.2014 19:05, schrieb Eric Blake: > [adding libvirt] > > On 05/09/2014 05:54 AM, Gerd Hoffmann wrote: >> Hi, >> >>> virt-manager/libvirt seems to default to 9 MByte of Vram for >>> cirrus, so this would break a lot of setups. >> >> It wouldn'

Re: [Qemu-devel] [RFC PATCH 00/11] Cleanup load/store functions in headers and C files

2014-05-12 Thread Richard Henderson
On 05/08/2014 09:09 AM, Paolo Bonzini wrote: > This series is a prerequisite for improving the SMAP emulation in > qemu-system-x86_64. SMAP is a Broadwell feature and testing it in the > kernel is probably the #1 reason why people are using TCG x86 nowadays. > > In order to implement some of the

Re: [Qemu-devel] [RFC PATCH 11/11] softmmu: move all load/store functions to cpu_ldst.h

2014-05-12 Thread Richard Henderson
On 05/08/2014 09:09 AM, Paolo Bonzini wrote: > diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h > index a6b7884..e5550e7 100644 > --- a/include/exec/cpu_ldst.h > +++ b/include/exec/cpu_ldst.h > @@ -28,8 +28,373 @@ > #ifndef CPU_LDST_H > #define CPU_LDST_H > > -#if !defined(CONFIG_

Re: [Qemu-devel] [PATCH V2] qapi: Let redundant includes be skipped excepted the first occurrence.

2014-05-12 Thread Eric Blake
On 05/09/2014 09:48 AM, Benoît Canet wrote: Subject line has problems. 'excepted' is not a word, and you are already asked to avoid trailing '.'. I suggest a much simpler: qapi: skip redundant includes > The purpose of this change is to help create a json file containing > common definitions; e

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Mike Day
On Mon, May 12, 2014 at 12:36 PM, Kevin Wolf wrote: > What would qemu-img rebase do with -o? It is just for (safely) changing > the backing file, not for updating options. There is qemu-img amend for > that, and it does have an -o option. A little background ... I'm writing a 4-day KVM training

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-12 Thread Eric Blake
[adding libvirt] On 05/09/2014 05:54 AM, Gerd Hoffmann wrote: > Hi, > >> virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus, >> so this would break a lot of setups. > > It wouldn't. libvirt sticks that into the xml, but it doesn't set any > qemu parameters. The libvirt param

Re: [Qemu-devel] [PATCH v3 12/16] tcg-s390: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-12 Thread Richard Henderson
On 05/09/2014 06:35 AM, Peter Maydell wrote: > On 28 April 2014 20:28, Richard Henderson wrote: >> And use tcg pointer differencing functions as appropriate. >> >> Signed-off-by: Richard Henderson >> --- >> tcg/s390/tcg-target.c | 91 >> --- >> tc

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-12 Thread Eric Blake
On 05/09/2014 05:18 AM, Dr. David Alan Gilbert wrote: > * arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: >> From: Gonglei >> >> when configure a invalid vram size for cirrus card, such as less >> 2 MB, which will crash qemu. Follow the real hardware, the cirrus >> card has 4 MB video mem

Re: [Qemu-devel] [PATCH 4/5] qcow1: Validate image size (CVE-2014-0223)

2014-05-12 Thread Benoît Canet
The Monday 12 May 2014 à 18:43:33 (+0200), Kevin Wolf wrote : > Am 12.05.2014 um 17:50 hat Benoît Canet geschrieben: > > The Monday 12 May 2014 à 15:04:10 (+0200), Kevin Wolf wrote : > > > A huge image size could cause s->l1_size to overflow. Make sure that > > > images never require a L1 table lar

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Eric Blake
On 05/12/2014 10:36 AM, Kevin Wolf wrote: >>> rebase [-q] [-f fmt] [-t cache] [-p] [-u] -b backing_file [-F >>> backing_fmt] filename >> >> 'rebase' lacks -o; so it must continue to document -b. This thread was >> started in context to the 'create' subcommand, not the 'rebase' >> subcommand. (Ar

Re: [Qemu-devel] [PATCH 4/5] qcow1: Validate image size (CVE-2014-0223)

2014-05-12 Thread Kevin Wolf
Am 12.05.2014 um 17:50 hat Benoît Canet geschrieben: > The Monday 12 May 2014 à 15:04:10 (+0200), Kevin Wolf wrote : > > A huge image size could cause s->l1_size to overflow. Make sure that > > images never require a L1 table larger than what fits in s->l1_size. > > > > This cannot only cause unbo

Re: [Qemu-devel] [PATCH] qemu-img fails to delete last snapshot

2014-05-12 Thread Eric Blake
On 05/09/2014 09:02 AM, Mike Day wrote: > When deleting the last snapshot, copying the resulting snapshot table > currently fails, causing the delete operation to also fail. Fix the > failure by skipping the copy and just writing the snapshot header and > freeing the extra clusters. > > Signed-off

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Kevin Wolf
Am 12.05.2014 um 18:32 hat Eric Blake geschrieben: > On 05/12/2014 10:05 AM, Mike Day wrote: > > On Mon, May 12, 2014 at 11:53 AM, Eric Blake wrote: > >> Ah, but it is: > >> > >> $ qemu-img create -f qcow2 -o help > >> Supported options: > >> size Virtual disk size > >> compat

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Eric Blake
On 05/12/2014 10:05 AM, Mike Day wrote: > On Mon, May 12, 2014 at 11:53 AM, Eric Blake wrote: >> Ah, but it is: >> >> $ qemu-img create -f qcow2 -o help >> Supported options: >> size Virtual disk size >> compat Compatibility level (0.10 or 1.1) >> backing_file File name o

Re: [Qemu-devel] [Qemu-ppc] macio ide question/bug report

2014-05-12 Thread Mark Cave-Ayland
On 10/05/14 13:30, BALATON Zoltan wrote: That patch would be 80fc95d8bdaf3392106b131a97ca701fd374489a in QEMU master. I've tried reverting it and Darwin still boots (without -M mac99) up to the point where it asks to install as before but I don't know how good a test is this as I'm not sure it d

Re: [Qemu-devel] [PATCH] rewamp/simplify option parsing

2014-05-12 Thread Eric Blake
On 05/12/2014 01:55 AM, Michael Tokarev wrote: s/rewamp/revamp/ in the subject > Main change is to allow get_opt_name() to accept > a set of delimiters (string) instead of a single > delimiter (char). This way it is easier to search > for the next (sub)option in an option string, so > other code

Re: [Qemu-devel] [PULL 12/17] gluster: Correctly propagate errors when volume isn't accessible

2014-05-12 Thread Eric Blake
On 05/09/2014 01:03 PM, Stefan Hajnoczi wrote: > From: Peter Krempa > > The docs for glfs_init suggest that the function sets errno on every > failure. In fact it doesn't. As other functions such as > qemu_gluster_open() in the gluster block code report their errors based > on this fact we need t

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

2014-05-12 Thread Mike Day
On Mon, May 12, 2014 at 11:53 AM, Eric Blake wrote: > Ah, but it is: > > $ qemu-img create -f qcow2 -o help > Supported options: > size Virtual disk size > compat Compatibility level (0.10 or 1.1) > backing_file File name of a base image > backing_fmt Image format of

Re: [Qemu-devel] Qemu live migration code

2014-05-12 Thread Bechir Bani
Hi , There is someone who can explain to me the role of two trace points in the file* Migration.c * The trace points are : * migrate_pending* : what are the attributes *pending size *and *max* ? * migrate_transferred*: what are the attributes *transferred* ,* time_spent* , *bandwidth* and

Re: [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState

2014-05-12 Thread Laszlo Ersek
On 05/07/14 16:42, Marcel Apfelbaum wrote: > Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields > are copied into MachineState. Removed duplicated fields from MachineState. > > All the other changes are only mechanical refactoring, no semantic changes. > > Signed-off-by: Ma

  1   2   3   >