Re: [Qemu-devel] [Spice-devel] Automatic spice port selection

2014-04-21 Thread Markus Armbruster
Copying Gerd. Fabio Fantoni writes: > 2014-04-18 9:42 GMT+02:00 Christophe Fergeau : > >> >> >> - Mail original - >> > Il 26/03/2014 17:15, Fabio Fantoni ha scritto: >> > > Time ago I have read somewhere that there is an option to >> > > automatically spice port in qemu as for vnc. >> >

Re: [Qemu-devel] [PATCH 3/4] graphic_console_init: do not receive unneeded error descriptions

2014-04-21 Thread Gerd Hoffmann
> > if (dev) { > > -object_property_set_link(OBJECT(s), OBJECT(dev), > > - "device", &local_err); > > -object_property_set_int(OBJECT(s), head, > > -"head", &local_err); > > +object_property_set_link(OBJECT(

Re: [Qemu-devel] [RFC] about don't support hotplug usb-ehci controller

2014-04-21 Thread Gerd Hoffmann
On Fr, 2014-04-18 at 09:23 +, Gonglei (Arei) wrote: > Hi, Gerd. > IMHO, the usb-ehci controller as a common PCI device, likes NIC. > If we don't use the multifunction capability of EHCI, we should support to > hot plug / unplug > Usb-ehci controller. Yes, non-multifunction usb controll

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-21 Thread Gerd Hoffmann
Hi, > Command line options are processed before machine types are > initialized. acpi is pretty much in the same boat ... /me looks ... Ah, there is a notifier where you (hopefully) can hook in easily: pc_guest_info_machine_done (see hw/i386/pc.c). cheers, Gerd

[Qemu-devel] [PATCH v3] qemu-img: Improve error messages

2014-04-21 Thread Fam Zheng
Previously, when there is a user error in argv parsing, qemu-img prints help text and exits. Add an error_exit function to print a helpful error message and a hint to run 'qemu-img --help' for more information. As a bonus, "qemu-img --help" now has a more reasonable exit code 0. In the future t

Re: [Qemu-devel] [PATCH v2] qemu-img: Improve error messages

2014-04-21 Thread Fam Zheng
On Tue, 04/22 11:31, Wang Sen wrote: > On Tue, Apr 22, 2014 at 10:04:21AM +0800, Fam Zheng wrote: > > Previously, when there is a user error in argv parsing, qemu-img prints > > help text and exits. > > > > Add an error_exit function to print a helpful error message and a hint > > to run 'qemu-img

Re: [Qemu-devel] [PATCH 0/3] target-arm: support setend instruction

2014-04-21 Thread Richard Henderson
On 04/21/2014 03:08 PM, Peter Maydell wrote: > [Tangentially: we really need a vdso for aarch64, at which point we > might as well do the aarch32 commpage with one too. IIRC RTH had > some patches for x86-64 vdso which I should fish out of the archives...] Still sitting at git://github.com/rth7

Re: [Qemu-devel] [PATCH v2] qemu-img: Improve error messages

2014-04-21 Thread Wang Sen
On Tue, Apr 22, 2014 at 10:04:21AM +0800, Fam Zheng wrote: > Previously, when there is a user error in argv parsing, qemu-img prints > help text and exits. > > Add an error_exit function to print a helpful error message and a hint > to run 'qemu-img --help' for more information. > > As a bonus, "

Re: [Qemu-devel] [PATCH 0/3] target-arm: support setend instruction

2014-04-21 Thread Paolo Bonzini
Il 21/04/2014 18:08, Peter Maydell ha scritto: Thinking more about this, we'd be wrong already for bigendian if these were wrong. The bit about the linux-user/main.c strex/ldrex still stands, though, because those use get_user*/put_user* which use the TARGET_BIGENDIAN specified endianness. Ok.

Re: [Qemu-devel] [PATCH] configure: Change --enable-tpm to --disable-tpm

2014-04-21 Thread Paolo Bonzini
Il 21/04/2014 19:09, Cole Robinson ha scritto: I don't see why tpm is disabled by default: it doesn't have any external dependencies, or change default behavior. Leaving it disabled is just going to cause it to bit rot. Enable it by default, and change --enable-tpm to --disable-tpm if people sti

Re: [Qemu-devel] [PATCH v2 0/2] HMP: support specifying dump format for dump-guest-memory

2014-04-21 Thread qiaonuohan
On 04/17/2014 04:15 PM, Qiao Nuohan wrote: The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg00018.html ChangLog: Changes from v7 to v8: 1. add a patch to fix doc of dump-guest-memory Qiao Nuohan (2): HMP: fix doc of dump-guest-memory HMP: support speci

Re: [Qemu-devel] [PATCH] configure: Change --enable-tpm to --disable-tpm

2014-04-21 Thread Fam Zheng
On Mon, 04/21 19:09, Cole Robinson wrote: > I don't see why tpm is disabled by default: it doesn't have any > external dependencies, or change default behavior. Leaving it disabled > is just going to cause it to bit rot. > > Enable it by default, and change --enable-tpm to --disable-tpm if > peopl

[Qemu-devel] [PATCH v2] qemu-img: Improve error messages

2014-04-21 Thread Fam Zheng
Previously, when there is a user error in argv parsing, qemu-img prints help text and exits. Add an error_exit function to print a helpful error message and a hint to run 'qemu-img --help' for more information. As a bonus, "qemu-img --help" now has a more reasonable exit code 0. In the future t

Re: [Qemu-devel] [PATCH] qemu-img: Improve error messages

2014-04-21 Thread Fam Zheng
On Mon, 04/21 09:21, Eric Blake wrote: > On 04/21/2014 12:23 AM, Fam Zheng wrote: > > Previously, when there is an user error in argv parsing, qemu-img prints > > s/an user/a user/ > > (The rule of thumb for selecting which article to use for a leading 'u' > is pronunciation: anything starting wi

[Qemu-devel] [PATCH trivial v2] vl: avoid closing stdout with 'writeconfig'

2014-04-21 Thread Chen Gang
'writeconfig' supports output to stdout (with '-'); when that happens, we must not close stdout, or further command line options that also use stdout will be impacted. (Although 'writeconfig' was copied from 'readconfig', the latter does not have the problem because it does not support reading from

Re: [Qemu-devel] [PATCH trivial] vl: Avoid to close stdout after finish 'writeconfig' option

2014-04-21 Thread Chen Gang
On 04/21/2014 11:09 PM, Eric Blake wrote: > On 04/20/2014 06:05 AM, Chen Gang wrote: >> After finish 'writeconfig' to stdout (with '-'), we want to copy/past >> the related information mannually, not for redirection ('readconfig' >> does not support '-'). >> >> So we can not close the stdout, or

Re: [Qemu-devel] [PATCH v25 11/31] change block layer to support both QemuOpts and QEMUOptionParamter

2014-04-21 Thread Eric Blake
On 04/10/2014 11:54 AM, Chunyan Liu wrote: > Change block layer to support both QemuOpts and QEMUOptionParameter. > After this patch, it will change backend drivers one by one. At the end, > QEMUOptionParameter will be removed and only QemuOpts is kept. > > Signed-off-by: Dong Xu Wang > Signed-of

[Qemu-devel] [PATCH] configure: Change --enable-tpm to --disable-tpm

2014-04-21 Thread Cole Robinson
I don't see why tpm is disabled by default: it doesn't have any external dependencies, or change default behavior. Leaving it disabled is just going to cause it to bit rot. Enable it by default, and change --enable-tpm to --disable-tpm if people still want an option to compile it out. Signed-off-

[Qemu-devel] [PATCH] sdl2: Support mouse wheel

2014-04-21 Thread Cole Robinson
In SDL2, wheel movement is its own event, not a button event. Wire it up similar to gtk.c Signed-off-by: Cole Robinson --- ui/sdl2.c | 44 ++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 7506e2e..5de62c9 100

[Qemu-devel] [V2 PATCH 29/37] target-ppc: Introduce DFP Convert to Long/Extended

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Convert to DFP Long (dctdp[.]) and Convert to DFP Extended (dctqpq[.]) instructions. Signed-off-by: Tom Musta --- V2: Modify post-processor handling per Richard Henderson's review. target-ppc/dfp_helper.c | 33 + target-ppc/helper.h

[Qemu-devel] [V2 PATCH 06/37] libdecnumber: Eliminate redundant declarations

2014-04-21 Thread Tom Musta
Eliminate redundant declarations of symbols DPD2BIN and BIN2DPD in various .c source files. These symbols are already declared in decDPD.h and thus will trigger 'redundant redeclaration of ?XXX?' warnings, which, of course, may fail QEMU compilation. Signed-off-by: Tom Musta --- libdecnumber/dp

[Qemu-devel] [V2 PATCH 23/37] target-ppc: Introduce DFP Test Data Group

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Test Data Group instructions dtstdg[q][.]. Signed-off-by: Tom Musta --- V2: Modifed post processor handling per Richard Henderson's review. target-ppc/dfp_helper.c | 55 +++ target-ppc/helper.h

[Qemu-devel] [V2 PATCH 07/37] libdecnumber: Eliminate Unused Variable in decSetSubnormal

2014-04-21 Thread Tom Musta
Eliminate an unused variable in the decSetSubnormal routine. The variable dnexp is declared and eventually set but never used, and thus may trigger an unused-but-set-variable warning. Signed-off-by: Tom Musta --- libdecnumber/decNumber.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(

Re: [Qemu-devel] Controlling SDL2 output with Ctrl+Alt+*

2014-04-21 Thread Cole Robinson
On 04/18/2014 02:28 PM, Michael Tokarev wrote: > SDL2 display apparently does not work with standard keyboard > shortcuts documented in the qemu manpage. In particular, > Ctrl+Alt+(123) does not switch between monitor, serial and > guest graphical conslole, Certainly seems intentional: notice the

[Qemu-devel] [V2 PATCH 15/37] target-ppc: Introduce DFP Helper Utilities

2014-04-21 Thread Tom Musta
Add a new file (dfp_helper.c) to the PowerPC implementation for Decimal Floating Point (DFP) emulation. This first version of the file declares a structure that will be used by DFP helpers. It also implements utilities that will initialize such a structure for either a long (64 bit) DFP instructi

Re: [Qemu-devel] [PATCH 0/3] target-arm: support setend instruction

2014-04-21 Thread Peter Maydell
On 21 April 2014 21:52, Peter Maydell wrote: > I think we get the various neon load/store insns right, but did you > check the pseudocode against our implementation or are you just > hoping that we never try to combine or split a load/store compared > to the pseudocode spec? Thinking more about t

[Qemu-devel] [V2 PATCH 34/37] target-ppc: Introduce DFP Encode BCD to DPD

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Encode Binary Coded Decimal to Densely Packed Decimal instructions denbcd[q][.]. Signed-off-by: Tom Musta --- target-ppc/dfp_helper.c | 72 +++ target-ppc/helper.h |2 + target-ppc/translate

[Qemu-devel] [V2 PATCH 37/37] target-ppc: Introduce DFP Shift Significand

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Shift Significand Left Immediate (dscli[q][.]) and DFP Shift Significant Right Immediate (dscri[q][.]) instructions. Signed-off-by: Tom Musta --- target-ppc/dfp_helper.c | 95 +++ target-ppc/helper.

[Qemu-devel] [V2 PATCH 05/37] libdecnumber: Change gstdint.h to stdint.h

2014-04-21 Thread Tom Musta
Replace the inclusion of gstdint.h with the standard stdint.h header file. Signed-off-by: Tom Musta --- include/libdecnumber/decContext.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/libdecnumber/decContext.h b/include/libdecnumber/decContext.h index 1a3f15e

[Qemu-devel] [V2 PATCH 20/37] target-ppc: Introduce DFP Divide

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Divide instructions ddiv[q][.] Signed-off-by: Tom Musta --- V2: Make post-processor list static const per Richard Henderson's review. target-ppc/dfp_helper.c | 38 ++ target-ppc/helper.h |2 ++ tar

[Qemu-devel] [V2 PATCH 16/37] target-ppc: Introduce DFP Post Processor Utilities

2014-04-21 Thread Tom Musta
Add post-processing utilities to the PowerPC Decimal Floating Point (DFP) helper code. Post-processors are small routines that execute after a preliminary DFP result is computed. They are used, among other things, to compute status bits. This change defines a function type for post processors as

[Qemu-devel] [V2 PATCH 27/37] target-ppc: Introduce DFP Reround

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Reround instructions drrnd[q][.]. Signed-off-by: Tom Musta --- V2: Modified post processor handling per Richard Henderson's review. target-ppc/dfp_helper.c | 97 +++ target-ppc/helper.h |2

[Qemu-devel] [V2 PATCH 35/37] target-ppc: Introduce DFP Extract Biased Exponent

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Extract Biased Exponent instructions dxex[q][.]. Signed-off-by: Tom Musta --- target-ppc/dfp_helper.c | 31 +++ target-ppc/helper.h |2 ++ target-ppc/translate.c |4 3 files changed, 37 insertions

[Qemu-devel] [V2 PATCH 31/37] target-ppc: Introduce DFP Convert to Fixed

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Convert to Fixed instructions dctfix[q][.]. Signed-off-by: Tom Musta --- V2: Make post-processor list static const per Richard Henderson's review. target-ppc/dfp_helper.c | 26 ++ target-ppc/helper.h |2 ++ ta

[Qemu-devel] [V2 PATCH 33/37] target-ppc: Introduce DFP Decode DPD to BCD

2014-04-21 Thread Tom Musta
Add emulation of the Power PC Decimal Floating Point Decode Densely Packed Decimal to Binary Coded Decimal instructions ddedpd[q][.]. Signed-off-by: Tom Musta --- target-ppc/dfp_helper.c | 66 +++ target-ppc/helper.h |2 + target-ppc/translat

[Qemu-devel] [V2 PATCH 36/37] target-ppc: Introduce DFP Insert Biased Exponent

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Insert Biased Exponent instructions diex[q][.]. Signed-off-by: Tom Musta --- target-ppc/dfp_helper.c | 68 +++ target-ppc/helper.h |2 + target-ppc/translate.c |4 +++ 3 files changed,

[Qemu-devel] [V2 PATCH 32/37] target-ppc: Introduce DFP Convert to Fixed

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Convert to Fixed instructions dctfix[q][.]. Signed-off-by: Tom Musta --- target-ppc/dfp_helper.c | 36 target-ppc/helper.h |2 ++ target-ppc/translate.c |4 3 files changed, 42 insertions

[Qemu-devel] [V2 PATCH 30/37] target-ppc: Introduce Round to DFP Short/Long

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Round to DFP Short (drsp[.]) and Round to DFP Long (drdpq[.]) instructions. Signed-off-by: Tom Musta --- V2: Modify post-processor handling per Richard Henderson's review. target-ppc/dfp_helper.c | 48 +++ target-ppc/hel

[Qemu-devel] [V2 PATCH 28/37] target-ppc: Introduce DFP Round to Integer

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point (DFP) Round to FP Integer With Inexact (drintx[q][.]) and DFP Round to FP Integer Without Inexact (drintn[q][.]) instructions. Signed-off-by: Tom Musta --- V2: Make post-processor list static const per Richard Henderson's review. target-ppc/df

[Qemu-devel] [V2 PATCH 26/37] target-ppc: Introduce DFP Quantize

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Quantize instructions dquai[q][.] and dqua[q][.]. Signed-off-by: Tom Musta --- V2: Make post-processor list static const per Richard Henderson's review. target-ppc/dfp_helper.c | 132 +++ target-ppc

[Qemu-devel] [V2 PATCH 19/37] target-ppc: Introduce DFP Multiply

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Multiply instructions dmul[q][.] Signed-off-by: Tom Musta --- V2: Make post-processor list static const per Richard Henderson's review. target-ppc/dfp_helper.c | 23 +++ target-ppc/helper.h |2 ++ target-ppc/trans

[Qemu-devel] [V2 PATCH 24/37] target-ppc: Introduce DFP Test Exponent

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Test Exponent instructions dtstex[q][.]. Signed-off-by: Tom Musta --- V2: Modified post processor handling per Richard Henderson's review. target-ppc/dfp_helper.c | 32 target-ppc/helper.h |2 ++ targ

[Qemu-devel] [V2 PATCH 13/37] target-ppc: Introduce Generator Macros for DFP Arithmetic Forms

2014-04-21 Thread Tom Musta
Add general support for generators of PowerPC Decimal Floating Point helpers. Some utilities are annotated with GCC attribute unused in order to preserve build bisection. These annotations will be removed in later patches. Signed-off-by: Tom Musta --- target-ppc/translate.c | 177

[Qemu-devel] [V2 PATCH 25/37] target-ppc: Introduce DFP Test Significance

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Test Significance instructions dtstsf[q][.]. Signed-off-by: Tom Musta --- V2: Modified post processor handling per Richard Henderson's review. target-ppc/dfp_helper.c | 35 +++ target-ppc/helper.h |2 +

[Qemu-devel] [V2 PATCH 22/37] target-ppc: Introduce DFP Test Data Class

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Test Data Class instructions dtstdc[q][.]. Signed-off-by: Tom Musta --- V2: Modify post-processor handlling per Richard Henderson's review. target-ppc/dfp_helper.c | 28 target-ppc/helper.h |2 ++ target-

[Qemu-devel] [V2 PATCH 12/37] target-ppc: Define FPR Pointer Type for Helpers

2014-04-21 Thread Tom Musta
Define a floating pointer register pointer type in the PowerPC helper header. The type will be used to pass FPR register operands to Decimal Floating Point (DFP) helpers. A pointer is used because the quad word forms of PowerPC DFP instructions operate on adjacent pairs of floating point register

[Qemu-devel] [V2 PATCH 14/37] target-ppc: Introduce Decoder Macros for DFP

2014-04-21 Thread Tom Musta
Add decoder macros for the various Decimal Floating Point instruction forms. Illegal instruction masks are used to not only guard against reserved instruction field use, but also to catch illegal quad word forms that use odd-numbered floating point registers. Signed-off-by: Tom Musta --- target

[Qemu-devel] [V2 PATCH 21/37] target-ppc: Introduce DFP Compares

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Compare instructions dcmpu[q] and dcmpo[q]. Signed-off-by: Tom Musta --- V2: Modified post-processor handling per Richard Henderson's review. target-ppc/dfp_helper.c | 58 +++ target-ppc/helper.h

[Qemu-devel] [V2 PATCH 08/37] target-ppc: Enable Building of libdecnumber

2014-04-21 Thread Tom Musta
Enable compilation of the newly added libdecnumber library code. Object file targets are added to Makefile.target using a newly introduced flag CONFIG_LIBDECNUMBER. The flag is added to the PowerPC targets (ppc[64]-linux-user, ppc[64]-softmmu). Signed-off-by: Tom Musta --- Makefile.target

[Qemu-devel] [V2 PATCH 18/37] target-ppc: Introduce DFP Subtract

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Subtract instructions dsub[q][.] Signed-off-by: Tom Musta --- V2: Modified post-processor handling per Richard Henderson's review. target-ppc/dfp_helper.c | 18 ++ target-ppc/helper.h |2 ++ target-ppc/translate.c |

[Qemu-devel] [V2 PATCH 04/37] libdecnumber: Modify dconfig.h to Integrate with QEMU

2014-04-21 Thread Tom Musta
Modify the dconfig.h header file so that libdecnumber code integrates QEMU configuration. Specifically: - the WORDS_BIGENDIAN preprocessor macro is used in libdecnumber code to determines endianness. It is derived from the existing QEMU macro HOST_WORDS_BIGENDIAN which is defined in c

[Qemu-devel] [V2 PATCH 10/37] libdecnumber: Introduce decNumberIntegralToInt64

2014-04-21 Thread Tom Musta
Introduce a new conversion function to the libdecnumber library. This function converts a decNumber to a signed 64-bit integer. In order to support 64-bit integers (which may have up to 19 decimal digits), the existing "powers of 10" array is expanded from 10 to 19 entries. Signed-off-by: Tom Must

[Qemu-devel] [V2 PATCH 02/37] libdecnumber: Eliminate #include *Symbols.h

2014-04-21 Thread Tom Musta
The various *Symbols.h files were not copied from the original GCC libdecnumber library; they are not necessary for use in QEMU. Remove all instances of #include "*Symbols.h" Signed-off-by: Tom Musta --- include/libdecnumber/decContext.h |1 - include/libdecnumber/decDPD.h

[Qemu-devel] [V2 PATCH 09/37] libdecnumber: Introduce decNumberFrom[U]Int64

2014-04-21 Thread Tom Musta
Introduce two conversion functions to the libdecnumber library. These conversions transform 64 bit integers to the internal decNumber representation. Both a signed and unsigned version is added. Signed-off-by: Tom Musta --- V2: Simplified negative integer handling in the signed converter per Ric

[Qemu-devel] [V2 PATCH 17/37] target-ppc: Introduce DFP Add

2014-04-21 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Add instructions dadd[q][.] Various GCC unused annotations are removed since it is now safe to remove them. Signed-off-by: Tom Musta --- V2: Modified post-processor handling per Richard Henderson's review. target-ppc/dfp_helper.c | 127 +

[Qemu-devel] [V2 PATCH 03/37] libdecnumber: Prepare libdecnumber for QEMU include structure

2014-04-21 Thread Tom Musta
Consistent with other libraries in QEMU, the libdecnumber header files were placed in include/libdecnumber, separate from the C code. This is different from the original libdecnumber source, where they were co-located. Change the libdecnumber source code so that it reflects this split. Specific

[Qemu-devel] [V2 PATCH 11/37] libdecnumber: Fix decNumberSetBCD

2014-04-21 Thread Tom Musta
Fix a simple bug in the decNumberSetBCD() function. This function encodes a decNumber with "n" BCD digits. The original code erroneously computed the number of declets from the dn argument, which is the output decNumber value, and hence may contain garbage. Instead, the input "n" value is used.

[Qemu-devel] [V2 PATCH 00/37] target-ppc: Decimal Floating Point

2014-04-21 Thread Tom Musta
This patch series adds emulation of the PowerPC Decimal Floating Point (DFP) instructions. The complete set of DFP instructions defined by the Power ISA is introduced. The foundation of the emulation code is libdecnumber, a software library that models DFP numbers and operations in a manner sim

Re: [Qemu-devel] [PATCH 0/3] target-arm: support setend instruction

2014-04-21 Thread Peter Maydell
On 21 April 2014 18:43, Paolo Bonzini wrote: > This series adds setend support by using the MO_BE/MO_LE that Richard > implemented. This is used by Raspbian's faster memcmp implementation. There are also "by hand" loads done in linux-user/main.c's implementation of ldrex/strex which need to hono

Re: [Qemu-devel] [PATCH 3/3] target-arm: implement setend

2014-04-21 Thread Peter Maydell
On 21 April 2014 18:43, Paolo Bonzini wrote: > Since this is not a high-performance path, just use a helper to > flip the E bit and force a lookup in the hash table since the > flags have changed. If we take an exception while the E bit is set we'll now incorrectly start executing the exception h

Re: [Qemu-devel] [PATCH v25 09/31] QemuOpts: add qemu_opts_append to replace append_option_parameters

2014-04-21 Thread Eric Blake
On 04/10/2014 11:54 AM, Chunyan Liu wrote: > For later merge .create_opts of drv and proto_drv in qemu-img commands. > > Reviewed-by: Leandro Dorileo > Signed-off-by: Chunyan Liu > --- > include/qemu/option.h | 5 > util/qemu-option.c| 65 > +++

Re: [Qemu-devel] [PATCH 2/3] target-arm: introduce be8 tbflag

2014-04-21 Thread Peter Maydell
On 21 April 2014 18:43, Paolo Bonzini wrote: > The tb flag for be8 mode comes from the CPSR E bit. This will let us > implement setend in the next patch. > > Signed-off-by: Paolo Bonzini > --- > linux-user/main.c | 1 + > target-arm/cpu.h | 7 +++ > target-arm/translate.c | 29

[Qemu-devel] [QEMU v7 PATCH 4/7] SMBIOS: Use bitmaps to prevent incompatible comand line options

2014-04-21 Thread Gabriel L. Somlo
Replace existing smbios_check_collision() functionality with a pair of bitmaps: have_binfile_bitmap and have_fields_bitmap. Bits corresponding to each smbios type are set by smbios_entry_add(), which also uses the bitmaps to ensure that binary blobs and field values are never accepted for the same

[Qemu-devel] [QEMU v7 PATCH 0/7] SMBIOS: build full tables in QEMU

2014-04-21 Thread Gabriel L. Somlo
New in version 7 of the patch set: - patch set now down to only 7 patches; - machine versions 2.0 and older currently unaffected by this patch set, will continue using field overrides as before - patches 1..6 are very small and simple, and set the stage for patch #7 - patch 7 introd

[Qemu-devel] [QEMU v7 PATCH 7/7] SMBIOS: Build aggregate smbios tables and entry point

2014-04-21 Thread Gabriel L. Somlo
Build an aggregate set of smbios tables and an entry point structure. Insert tables and entry point into fw_cfg respectively under "etc/smbios/smbios-tables" and "etc/smbios/smbios-anchor". Machine types <= 2.0 will for now continue using field-by-field overrides to SeaBIOS defaults, but for mach

[Qemu-devel] [QEMU v7 PATCH 5/7] E820: Add interface for accessing e820 table

2014-04-21 Thread Gabriel L. Somlo
Add the following two functions: - e820_get_num_entries() - query the size of the e820 table - e820_get_entry() - grab an entry matching a given set of criteria This interface is currently necessary for creating type 19 (memory array mapped address) structures in smbios. Signed-off-by: Gabri

[Qemu-devel] [QEMU v7 PATCH 1/7] SMBIOS: Rename symbols to better reflect future use

2014-04-21 Thread Gabriel L. Somlo
Rename the following symbols: - smbios_set_type1_defaults() to the more general smbios_set_defaults(); - bool smbios_type1_defaults to the more general smbios_defaults; - smbios_get_table() to smbios_get_table_legacy(); This patch contains no functional changes. Signed-off-by: Gabriel Soml

[Qemu-devel] [QEMU v7 PATCH 2/7] SMBIOS: Update header file definitions

2014-04-21 Thread Gabriel L. Somlo
Add definitions for smbios entry point (anchor), and for type 2 (base board) structure which is required by some versions of OS X. Remove definition for type 20 (memory device mapped address) structure, which is no longer required as of smbios spec v2.5. Update all other structure definitions to

[Qemu-devel] [QEMU v7 PATCH 6/7] PC: Add (empty) compat functions for machine version 2.0

2014-04-21 Thread Gabriel L. Somlo
This patch contains no functional changes. Signed-off-by: Gabriel Somlo --- hw/i386/pc_piix.c | 13 - hw/i386/pc_q35.c | 13 - 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index cca310b..3d3f4b7 100644 --- a/hw/i38

[Qemu-devel] [QEMU v7 PATCH 3/7] SMBIOS: Use macro to set smbios defaults

2014-04-21 Thread Gabriel L. Somlo
The function smbios_set_defaults() uses a repeating code pattern for each field. This patch replaces that pattern with a macro. This patch contains no functional changes. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 27 +-- 1 file changed, 13 insertions(+), 14 del

Re: [Qemu-devel] [PATCH v25 08/31] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts

2014-04-21 Thread Eric Blake
On 04/10/2014 11:54 AM, Chunyan Liu wrote: > Add two temp conversion functions between QEMUOptionParameter to QemuOpts, > so that next patch can use it. It will simplify later patch for easier > review. And will be finally removed after all backend drivers switch to > QemuOpts. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v25 07/31] QemuOpts: add qemu_opts_print_help to replace print_option_help

2014-04-21 Thread Eric Blake
On 04/10/2014 11:54 AM, Chunyan Liu wrote: > print_option_help takes QEMUOptionParameter as parameter, add > qemu_opts_print_help to take QemuOptsList as parameter for later > replace work. > > Reviewed-by: Leandro Dorileo > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > incl

Re: [Qemu-devel] [PATCH v25 06/31] QemuOpts: add qemu_opt_get_*_del functions for replace work

2014-04-21 Thread Eric Blake
On 04/10/2014 11:54 AM, Chunyan Liu wrote: > Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and > qemu_opt_get_size_del to replace the same handling of QEMUOptionParamter s/Paramter/Parameter/ > (get and delete). > > Several drivers are coded to parse a known subset of opti

Re: [Qemu-devel] [PATCH v25 04/31] QemuOpts: change opt->name|str from (const char *) to (char *)

2014-04-21 Thread Eric Blake
On 04/10/2014 11:54 AM, Chunyan Liu wrote: > qemu_opt_del() already assumes that all QemuOpt instances contain > malloc'd name and value; but it had to cast away const because > opts_start_struct() was doing its own thing and using static storage > instead. By using the correct type and malloced s

Re: [Qemu-devel] [PATCH 1/3] target-arm: pass DisasContext to gen_aa32_ld*/st*

2014-04-21 Thread Richard Henderson
On 04/21/2014 10:43 AM, Paolo Bonzini wrote: > Needed in the next patch to retrieve the desired endianness. > > Signed-off-by: Paolo Bonzini > --- > target-arm/translate.c | 256 > - > 1 file changed, 128 insertions(+), 128 deletions(-) Reviewed-

Re: [Qemu-devel] [PATCH v25 03/31] qapi: output def_value_str when query command line options

2014-04-21 Thread Eric Blake
On 04/10/2014 11:53 AM, Chunyan Liu wrote: > Change qapi interfaces to output the newly added def_value_str when querying > command line options. > > Reviewed-by: Eric Blake > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > changes: > * Following Leandro's comment: > upda

Re: [Qemu-devel] [PATCH 3/3] target-arm: implement setend

2014-04-21 Thread Richard Henderson
On 04/21/2014 10:43 AM, Paolo Bonzini wrote: > Since this is not a high-performance path, just use a helper to > flip the E bit and force a lookup in the hash table since the > flags have changed. > > Signed-off-by: Paolo Bonzini > --- > target-arm/helper.h| 1 + > target-arm/op_helper.c |

Re: [Qemu-devel] [PATCH 2/3] target-arm: introduce be8 tbflag

2014-04-21 Thread Richard Henderson
On 04/21/2014 10:43 AM, Paolo Bonzini wrote: > @@ -1157,6 +1161,9 @@ static inline void cpu_get_tb_cpu_state(CPUARMState > *env, target_ulong *pc, > if (privmode) { > *flags |= ARM_TBFLAG_PRIV_MASK; > } > +if (env->uncached_cpsr & CPSR_E) { > +*fl

Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive)

2014-04-21 Thread Juan Quintela
Peter Maydell wrote: > On 21 April 2014 18:25, Juan Quintela wrote: >> I can split the series at any point (they make sense even without the >> rest). >> >> What about: >> >> 1,7,8: bug fixes/simplification >> >> 2-6: massive Unneeded version_minimum_id_old removal, but trivial per se >> >> 9-47:

Re: [Qemu-devel] [PATCH v25 02/31] QemuOpts: add def_value_str to QemuOptDesc

2014-04-21 Thread Eric Blake
On 04/10/2014 11:53 AM, Chunyan Liu wrote: > Add def_value_str (default value) to QemuOptDesc, to replace function of the > default value in QEMUOptionParameter. > > Improve qemu_opts_get_* functions: if find opt, return opt->str; otherwise, > if desc->def_value_str is set, return desc->def_value_

[Qemu-devel] [PATCH 084/124] vmstate: Create VMSTATE_OPENCODED_UNSAFE

2014-04-21 Thread Juan Quintela
This is trick, to use devices that haven't been converted inside vmstate state. It was already used on the "wild", so create a macro and convert the users. Signed-off-by: Juan Quintela --- hw/pci/msix.c | 10 +- hw/scsi/scsi-bus.c | 10 +- hw/usb/redirect.

[Qemu-devel] [PATCH 046/124] vmstate: Test for VMSTATE_UINT16_2DARRAY.

2014-04-21 Thread Juan Quintela
Remove unused _V version. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 5 + tests/test-vmstate.c| 11 +++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index eeff224..5b03660 100644

Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive)

2014-04-21 Thread Paolo Bonzini
Il 21/04/2014 13:34, Peter Maydell ha scritto: Mostly just that I think that for vmstate definitions "this new field was added in version X" is natural and normal, whereas other test functions are odd and generally the exception. So a simple way to indicate minimum version for fields seems useful

[Qemu-devel] [PATCH 1/3] target-arm: pass DisasContext to gen_aa32_ld*/st*

2014-04-21 Thread Paolo Bonzini
Needed in the next patch to retrieve the desired endianness. Signed-off-by: Paolo Bonzini --- target-arm/translate.c | 256 - 1 file changed, 128 insertions(+), 128 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index fb

[Qemu-devel] [PATCH 041/124] vmstate: Test for VMSTATE_INT16_ARRAY

2014-04-21 Thread Juan Quintela
Remove unused VMSTATE_INT16_ARRAY_V Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 6 ++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 7c8bc54..db8f295

[Qemu-devel] [PATCH 0/3] target-arm: support setend instruction

2014-04-21 Thread Paolo Bonzini
This series adds setend support by using the MO_BE/MO_LE that Richard implemented. This is used by Raspbian's faster memcmp implementation. Paolo Bonzini (3): target-arm: pass DisasContext to gen_aa32_ld*/st* target-arm: introduce be8 tbflag target-arm: implement setend linux-user/main.c

[Qemu-devel] [PATCH 3/3] target-arm: implement setend

2014-04-21 Thread Paolo Bonzini
Since this is not a high-performance path, just use a helper to flip the E bit and force a lookup in the hash table since the flags have changed. Signed-off-by: Paolo Bonzini --- target-arm/helper.h| 1 + target-arm/op_helper.c | 5 + target-arm/translate.c | 12 ++-- 3 files c

[Qemu-devel] [PATCH 116/124] vmstate: Test VMSTATE_STRUCT_ARRAY

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 88 1 file changed, 88 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index c7ecaeb..3d8ba20 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1416,

[Qemu-devel] [PATCH 079/124] vmstate: Remove version parameter from VMSTATE_STRUCT_TEST

2014-04-21 Thread Juan Quintela
As we haven't yet moved everything that uses VMSTATE_STRUCT_TEST we create a temporary VMSTATE_STRUCT_INFO. This would allows us to not having to move fields to VMSTATE_STRUCT_TEST and then remove the version parameter. Signed-off-by: Juan Quintela --- hw/acpi/piix4.c | 2 +- includ

[Qemu-devel] [PATCH 2/3] target-arm: introduce be8 tbflag

2014-04-21 Thread Paolo Bonzini
The tb flag for be8 mode comes from the CPSR E bit. This will let us implement setend in the next patch. Signed-off-by: Paolo Bonzini --- linux-user/main.c | 1 + target-arm/cpu.h | 7 +++ target-arm/translate.c | 29 +++-- target-arm/translate.h | 1 +

Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive)

2014-04-21 Thread Peter Maydell
On 21 April 2014 18:25, Juan Quintela wrote: > I can split the series at any point (they make sense even without the > rest). > > What about: > > 1,7,8: bug fixes/simplification > > 2-6: massive Unneeded version_minimum_id_old removal, but trivial per se > > 9-47: New testing framework and tests f

[Qemu-devel] [PATCH 071/124] vmstate: Remove version field from VMSTATE_STRUCT_VARRAY_UINT32

2014-04-21 Thread Juan Quintela
No user of it. Signed-off-by: Juan Quintela --- hw/dma/pl330.c | 4 ++-- hw/timer/a9gtimer.c | 2 +- hw/timer/arm_mptimer.c | 2 +- hw/usb/hcd-xhci.c | 6 +++--- include/migration/vmstate.h | 3 +-- 5 files changed, 8 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 106/124] vmstate: Test for VMSTATE_BUFFER_UNSAFE_TEST

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 46 +- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index e1e2523..9f7256c 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c

[Qemu-devel] [PATCH 088/124] vmstate: Test for VMSTATE_UINT8_SUB_ARRAY

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 49 + 1 file changed, 49 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 308f94d..0a4f81a 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -802,6 +8

[Qemu-devel] [PATCH 048/124] vmstate: Remove unused VMSTATE_BUFFER_V

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 62552ab..c22f5db 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -654,

[Qemu-devel] [PATCH 030/124] vmstate: Test for VMSTATE_UINT32_EQUAL

2014-04-21 Thread Juan Quintela
Remove unused VMSTATE_UINT32_EQUAL_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 2 ++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 9a64315..c0b823d 10

Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive)

2014-04-21 Thread Juan Quintela
Peter Maydell wrote: > On 21 April 2014 17:31, Juan Quintela wrote: >> Patches are easy to review in sequence, any of them is very simple, and >> the few ones that are long (minimum_version_id_old) review is just >> looking that the previous line is minimum_version_id = . > > But there are simply

[Qemu-devel] [PULL 8/8] tcg-ia64: Convert to new ldst opcodes

2014-04-21 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ia64/tcg-target.c | 100 +- tcg/ia64/tcg-target.h | 2 +- 2 files changed, 35 insertions(+), 67 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index 76abb46..afcfd36 100644 --- a/t

[Qemu-devel] [PULL 6/8] tcg-ia64: Convert to new ldst helpers

2014-04-21 Thread Richard Henderson
Still inline, but updated to the new routines. Always use the LE helpers, reusing the bswap between the fast and slot paths. Signed-off-by: Richard Henderson --- tcg/ia64/tcg-target.c | 142 -- 1 file changed, 80 insertions(+), 62 deletions(-) di

[Qemu-devel] [PATCH 047/124] vmstate: Test for VMSTATE_UINT32_2DARRAY

2014-04-21 Thread Juan Quintela
Remove unused _V version. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 17 + 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 5b03660..6255

  1   2   3   >