On Wed, 16 Apr 2014 20:32:07 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Apr 16, 2014 at 05:42:22PM +0100, Peter Maydell wrote:
> > On 16 April 2014 17:34, Michael S. Tsirkin wrote:
> > > so it looks like virtio is currently compiled per-target.
> > > So why isn't it reasonable to keep it per-ta
Peter Crosthwaite writes:
> On Wed, Apr 16, 2014 at 6:05 PM, Markus Armbruster wrote:
>> Peter Crosthwaite writes:
>>
>>> Hi Markus,
>>>
>>> This series introduces qemu_get_boot_opts(), in much the same way as
>>> was done for qemu_get_machine_opts().
>>>
>>> As usual, I have out-of-scope and o
Andreas Färber writes:
> Am 16.04.2014 08:42, schrieb Markus Armbruster:
>> Peter Crosthwaite writes:
>>
>>> On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote:
Am 15.04.2014 04:21, schrieb Peter Crosthwaite:
> So clients can set the top level id string.
>
> Signed-off-by:
Andy Lutomirski writes:
> On Mon, Apr 14, 2014 at 1:15 AM, Markus Armbruster wrote:
>> Peter Crosthwaite writes:
>>
>>> Hi Andy,
>>>
>>> On Thu, Apr 10, 2014 at 5:55 AM, Andy Lutomirski
>>> wrote:
Currently, -M q35 boots linux quite a bit slower than the default
machine type. This
On 04/16/2014 07:52 PM, Michael S. Tsirkin wrote:
> On Wed, Apr 16, 2014 at 07:47:37PM +0200, Andreas Färber wrote:
>> Am 16.04.2014 19:40, schrieb Michael S. Tsirkin:
>>> On Wed, Apr 16, 2014 at 06:48:08PM +0200, Andreas Färber wrote:
Am 16.04.2014 18:32, schrieb Alexander Graf:
>
> O
On Wed, Apr 16, 2014 at 04:23:44PM +0200, Igor Mammedov wrote:
> On Wed, 16 Apr 2014 16:59:25 +0800
> Hu Tao wrote:
>
> > On Fri, Apr 04, 2014 at 03:36:38PM +0200, Igor Mammedov wrote:
> > > initialize and map hotplug memory address space container
> > > into guest's RAM address space.
> > >
> >
Hi, all
I’m trying to figure out how do_savevm works in QEMU. But there is one
thing has bothered me quite a lot. I found that vm_stop invoke
qemu_cpu_kick_thread to send SIG_IPI to a vcpu thread, and I have
understand that in TCG mode, the cpu_signal() function will be invoked as
the SIG_IPI hand
On 2014-04-17 07:46, Shiru Ren wrote:
> Hi, all
>
> I’m trying to figure out how do_savevm works in QEMU. But there is one
> thing has bothered me quite a lot. I found that vm_stop invoke
> qemu_cpu_kick_thread to send SIG_IPI to a vcpu thread, and I have
> understand that in TCG mode, the cpu_sig
A-ha, the reason is that this only triggers if the qemu window is
focused. Running the script while focusing does reproduce (and do other
weird things).
So perhaps this is happening in sdl_grab_start(), which exits early if
the app is not focused?
--
You received this bug notification because y
Maddeningly, I've not yet been able to reproduce this by doing
for i in `seq 1 100`; do
xdotool search --name qemu keydown ctrl+alt+2
xdotool search --name qemu keyup ctrl+alt+2
xdotool search --name qemu keydown ctrl+alt+1
xdotool search --name qemu keyup ctrl+alt+
Signed-off-by: Fam Zheng
---
block/vmdk.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index b69988d..938a183 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -640,7 +640,7 @@ static int vmdk_open_vmdk4(BlockDriverState *bs,
i
On Wed, Apr 16, 2014 at 1:27 AM, Peter Maydell wrote:
> On 4 April 2014 03:19, Peter Crosthwaite wrote:
>> The smlald (and probably smlsld) instruction was doing incorrect sign
>> extensions of the operands amongst 64bit result calculation. The
>> instruction psuedo-code is:
>>
>> operand2 = if
The smlald (and probably smlsld) instruction was doing incorrect sign
extensions of the operands amongst 64bit result calculation. The
instruction psuedo-code is:
operand2 = if m_swap then ROR(R[m],16) else R[m];
product1 = SInt(R[n]<15:0>) * SInt(operand2<15:0>);
product2 = SInt(R[n]<31:16>) *
> -Original Message-
> From: Alexander Graf [mailto:ag...@suse.de]
> Sent: Monday, April 14, 2014 6:01 AM
> To: Yoder Stuart-B08248
> Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org
> Subject: Re: [PATCH 1/2] QEMU: PPC: specify PVRs for all e500 cores
>
>
> On 14.02.14 20:22, Stuart Yode
Hi Peter,
On Tue, Apr 15, 2014 at 1:17 PM, Peter Crosthwaite
wrote:
>
> There is a utility helper for dealing with 8 bit fifos. This should be
> applicable to other integer widths as well. These two patches
> generalise this FIFO to work for 16, 32 and 64 bit ints.
>
> changed since v3:
> Initial
Sadly a bisect pointed to the unlikely commit 7a239e46.
Upstream git head is still affected.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1257352
Title:
kvm hangs occasionally when switching out
On Wed, Apr 16, 2014 at 6:05 PM, Markus Armbruster wrote:
> Peter Crosthwaite writes:
>
>> Hi Markus,
>>
>> This series introduces qemu_get_boot_opts(), in much the same way as
>> was done for qemu_get_machine_opts().
>>
>> As usual, I have out-of-scope and out-of-tree usages :) But P3 does
>> cl
> Hi, all
>
> I provide host's memory to guest by remap_pfn_range host page to qemu, and
> when guest access the page, host paniced.
>
I missed to set vma->vm_pgoff,
vma->vm_pgoff = virt_to_phys(test_mem) >> PAGE_SHIFT;
> Any ideas?
>
> Thanks,
> Zhang Haoyu
On Thu, Apr 17, 2014 at 3:20 AM, Andreas Färber wrote:
> Am 15.04.2014 23:39, schrieb Peter Crosthwaite:
>> On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote:
>>> Am 15.04.2014 04:21, schrieb Peter Crosthwaite:
So clients can set the top level id string.
Signed-off-by: Peter Cr
On Wed, 04/16 23:43, Max Reitz wrote:
> On 16.04.2014 03:48, Fam Zheng wrote:
> >On Sat, 04/12 20:57, Max Reitz wrote:
> >>Implement block_job_complete_sync() by doing the exact same thing as
> >>block_job_cancel_sync() does, only with calling block_job_complete()
> >>instead of block_job_cancel().
On Wed, 04/16 22:07, longguang.yue wrote:
> hi,all
> libvirt supply "default", "none", "writethrough", "writeback", "directsync",
> "unsafe" disk cache options
>
>
> 1.
> as for qemu, how qemu uses those options? and what are the differences?
> better tell me where are the codes correspond
On Fri, Apr 4, 2014 at 11:36 PM, Igor Mammedov wrote:
> Adds get_hotplug_handler() method to machine, and
> makes bus-less device to use it during hotplug
> as a means to discover hotplug handler controller.
> Returned controller is used to permorm a hotplug
> action.
>
> Signed-off-by: Igor Mamme
On Wed, 16 Apr 2014, Christopher Covington wrote:
> On 04/16/2014 03:14 PM, Nicolas Pitre wrote:
> > On Wed, 16 Apr 2014, Christopher Covington wrote:
> >
> >> It seems to me that if external/uncompressed image loaders could query the
> >> text offset in a straightforward manner, variance between
On 16.04.2014 23:48, Max Reitz wrote:
On 16.04.2014 17:00, Kevin Wolf wrote:
Am 12.04.2014 um 20:57 hat Max Reitz geschrieben:
Implement progress output for the commit command by querying the
progress of the block job.
Signed-off-by: Max Reitz
---
qemu-img-cmds.hx | 4 ++--
qemu-img.c
On Wed, Apr 16, 2014 at 10:36:11PM +0100, Peter Maydell wrote:
> On 16 April 2014 22:08, Christopher Covington wrote:
> > On 04/16/2014 03:14 PM, Nicolas Pitre wrote:
> >> But both QEMU and the boot-wrapper should deal with zImage. That's the
> >> only image format with documented load offset is g
On Wed, Apr 16, 2014 at 05:08:35PM -0400, Christopher Covington wrote:
> What I meant to ask about was variance from one kernel version and build to
> the next, given a single platform. Platform-to-platform variation can probably
> be abstracted where needed by the scripts controlling the external
On 16 April 2014 04:26, New B wrote:
> I hit these errors:
>
> 1- a pragma #error induced error in tcg/aarch64/tcg-target.c stating that
> "USE_DIRECT_JUMP required for aarch64”, line 1105.
> 2- a link failure:
> Undefined symbols for architecture x86_64:
> "_print_insn_i386", referenced from:
>
On 16.04.2014 15:08, Kevin Wolf wrote:
Insanely large requests could cause an integer overflow in
bdrv_rw_co() while converting sectors to bytes. This patch catches the
problem and returns an error (if we hadn't overflown the integer here,
bdrv_check_byte_request() would have rejected the request
On 15 April 2014 22:47, New B wrote:
> I keep getting this error: "must include QEMU headers” emitted from
> tcg/tcg-op.h. I have no idea how come this is happening.
>
> BTW, the same setup I have (build env + 1.7.1-stable qemu sources) to
> successfully build a functional qemu-system-arm for x86
On 16.04.2014 15:08, Kevin Wolf wrote:
Commit 8f4754ed intended to protect against integer overflow bugs in
block drivers by making sure that a single request that is passed to
drivers is no longer than INT_MAX bytes.
However, meanwhile there are some callers that don't use that code path
any mo
On Wed, 16 Apr 2014 15:29:35 +0200
Eric Auger wrote:
> On 04/11/2014 03:34 AM, Kim Phillips wrote:
> > On Wed, 9 Apr 2014 16:33:07 +0100
> > Eric Auger wrote:
> >> @@ -108,12 +108,13 @@ static const MemMapEntry a15memmap[] = {
> >> /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each
On 16.04.2014 15:08, Kevin Wolf wrote:
nb_sectors is signed, check for negative values.
Signed-off-by: Kevin Wolf
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Okay, why not.
Reviewed-by: Max Reitz
On 16.04.2014 15:09, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf
---
block.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz
On 16.04.2014 16:40, Kevin Wolf wrote:
Am 12.04.2014 um 20:57 hat Max Reitz geschrieben:
qemu-img should use QMP commands whenever possible in order to ensure
feature completeness of both online and offline image operations. As
qemu-img itself has no access to QMP (since this would basically req
On 16.04.2014 17:00, Kevin Wolf wrote:
Am 12.04.2014 um 20:57 hat Max Reitz geschrieben:
Implement progress output for the commit command by querying the
progress of the block job.
Signed-off-by: Max Reitz
---
qemu-img-cmds.hx | 4 ++--
qemu-img.c | 44 +++
On 16.04.2014 16:41, Kevin Wolf wrote:
Am 12.04.2014 um 20:57 hat Max Reitz geschrieben:
Implement block_job_complete_sync() by doing the exact same thing as
block_job_cancel_sync() does, only with calling block_job_complete()
instead of block_job_cancel().
Signed-off-by: Max Reitz
---
block
On 16.04.2014 03:48, Fam Zheng wrote:
On Sat, 04/12 20:57, Max Reitz wrote:
Implement block_job_complete_sync() by doing the exact same thing as
block_job_cancel_sync() does, only with calling block_job_complete()
instead of block_job_cancel().
Signed-off-by: Max Reitz
---
blockjob.c
On 16 April 2014 22:08, Christopher Covington wrote:
> On 04/16/2014 03:14 PM, Nicolas Pitre wrote:
>> But both QEMU and the boot-wrapper should deal with zImage. That's the
>> only image format with documented load offset is guaranteed not to
>> change i.e. it can be loaded at about any offset as
On 16.04.2014 03:34, Fam Zheng wrote:
bdrv_getlength could fail, check the return value before using it.
Return NULL and set errno if it fails. Callers are updated to handle
the error case.
Signed-off-by: Fam Zheng
---
v3: Fix errno (Max)
Signed-off-by: Fam Zheng
---
block-migration.c
Oh, my mistake.
It's really semicolon, not comma :)
Should I resend the patch with correct name?
16.04.2014 21:58, Peter Maydell пишет:
On 16 April 2014 18:32, Stefan Weil wrote:
Am 16.04.2014 15:43, schrieb Igor Ryzhov:
Signed-off-by: Igor Ryzhov
---
net/net.c | 2 +-
1 file changed, 1
Hi Nicolas,
Thanks for your response.
On 04/16/2014 03:14 PM, Nicolas Pitre wrote:
> On Wed, 16 Apr 2014, Christopher Covington wrote:
>
>> On 04/15/2014 06:44 AM, Daniel Thompson wrote:
>>> Hi Folks
>>>
>>> I've just been rebasing some of my development branches against v3.15rc1
>>> and observe
OK, so I have the "legacy" (field-by-field, types 0 and 1 only) code
back in, right next to the new aggregate-smbios-table-plus-entrypoint
code, tested and apparently working fine.
Before I get carried away with "git rebase", do we still want to go
through the whole patch sequence of generating ag
On 04/15/14 13:26, Beniamino Galvani wrote:
On Mon, Apr 14, 2014 at 08:18:56PM -0700, Peter Crosthwaite wrote:
Add support for 16, 32 and 64 bit width FIFOs. The push and pop
functions are replicated to accept all four different integer types.
The element width of the FIFO is set at creation tim
On 04/16/2014 01:39 PM, Eduardo Habkost wrote:
> Currently it is very easy to crash QEMU by issuing an object-add command
> using an abstract class or a class that doesn't support
> TYPE_USER_CREATABLE as parameter.
>
> Example: with the following QMP command:
>
> (QEMU) object-add qom-type=c
On Wed, 16 Apr 2014, Christopher Covington wrote:
> On 04/15/2014 06:44 AM, Daniel Thompson wrote:
> > Hi Folks
> >
> > I've just been rebasing some of my development branches against v3.15rc1
> > and observed some boot regressions due to TEXT_OFFSET changing from
> > 0x8000 to 0x208000.
> >
> >
On Thu, Apr 10, 2014 at 11:20:46AM +0800, Chunyan Liu wrote:
> 2014-04-08 9:12 GMT+08:00 Leandro Dorileo :
>
> > On Thu, Apr 03, 2014 at 05:54:18PM +0800, Chunyan Liu wrote:
> > > This patch series is to replace QEMUOptionParameter with QemuOpts, so
> > that only
> > > one Qemu Option structure is
On Thu, Apr 10, 2014 at 11:36:05AM +0800, Chunyan Liu wrote:
> 2014-04-08 9:31 GMT+08:00 Leandro Dorileo :
>
> > On Thu, Apr 03, 2014 at 05:54:20PM +0800, Chunyan Liu wrote:
> > > Add def_value_str (default value) to QemuOptDesc, to replace function of
> > the
> > > default value in QEMUOptionPara
APIC ver register is 1 but *IO*APIC ver register is 3... sorry for the
confusion/noise, qemu looks fine
neil
On 4/16/14 10:16 AM, Neil McGill wrote:
Seems there is a bug in qemu where the APIC version is being checked as
value 3. However, it should be 1.
static uint32_t apic_mem_readl(void
On Wed, Apr 16, 2014 at 04:22:32PM +0200, Andreas Färber wrote:
> Am 02.09.2013 13:31, schrieb Michael S. Tsirkin:
> > On Mon, Jul 29, 2013 at 02:27:01AM +0200, Andreas Färber wrote:
> >> Use it conditional on msix_present() and drop msix_{save,load}() calls
> >> following pci_device_{save,load}().
On 16 April 2014 18:32, Stefan Weil wrote:
> Am 16.04.2014 15:43, schrieb Igor Ryzhov:
>> Signed-off-by: Igor Ryzhov
>> ---
>> net/net.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/net.c b/net/net.c
>> index e3ef1e4..60a07f1 100644
>> --- a/net/net.c
>> +++ b/
On Wed, Apr 16, 2014 at 07:47:37PM +0200, Andreas Färber wrote:
> Am 16.04.2014 19:40, schrieb Michael S. Tsirkin:
> > On Wed, Apr 16, 2014 at 06:48:08PM +0200, Andreas Färber wrote:
> >> Am 16.04.2014 18:32, schrieb Alexander Graf:
> >>>
> >>> On 16.04.14 16:44, Hannes Reinecke wrote:
> MSI-X
Currently it is very easy to crash QEMU by issuing an object-add command
using an abstract class or a class that doesn't support
TYPE_USER_CREATABLE as parameter.
Example: with the following QMP command:
(QEMU) object-add qom-type=cpu id=foo
QEMU aborts at:
ERROR:qom/object.c:335:object
Am 16.04.2014 19:40, schrieb Michael S. Tsirkin:
> On Wed, Apr 16, 2014 at 06:48:08PM +0200, Andreas Färber wrote:
>> Am 16.04.2014 18:32, schrieb Alexander Graf:
>>>
>>> On 16.04.14 16:44, Hannes Reinecke wrote:
MSI-X support has been fixed in qemu, so we can enable it again.
Signed
Loading an qemu pointer as an immediate happens often. E.g.
- exit_tb $0x7fa8140013
+ exit_tb $0x7f81ee0013
...
- : d2800260mov x0, #0x13
- : f2b50280movkx0, #0xa814, lsl #16
- : f2c00fe0movkx0, #0x7f, lsl #32
+ : 90ff1000adrpx0, 0x7f81ee
+
On Wed, Apr 16, 2014 at 06:48:08PM +0200, Andreas Färber wrote:
> Am 16.04.2014 18:32, schrieb Alexander Graf:
> >
> > On 16.04.14 16:44, Hannes Reinecke wrote:
> >> MSI-X support has been fixed in qemu, so we can enable it again.
> >>
> >> Signed-off-by: Hannes Reinecke
> >> ---
> >> hw/scsi/m
On Wed, Apr 16, 2014 at 08:53:23AM +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > Currently it is very easy to crash QEMU by issuing an object-add command
> > using an abstract class or a class that doesn't support
> > TYPE_USER_CREATABLE as parameter.
> >
> > Example: with the f
Thanks for the patience during 5 iterations of this patch set,
but it's all reviewed now awaiting the opening of version 2.1.
r~
The following changes since commit 851627352c52b5beebf119785885391fa05a44c5:
Update version for v2.0.0-rc3 release (2014-04-14 17:45:11 +0100)
are available in th
Am 16.04.2014 15:43, schrieb Igor Ryzhov:
> Signed-off-by: Igor Ryzhov
> ---
> net/net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/net.c b/net/net.c
> index e3ef1e4..60a07f1 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -473,7 +473,7 @@ ssize_t qemu_deliver_p
On Wed, Apr 16, 2014 at 05:42:22PM +0100, Peter Maydell wrote:
> On 16 April 2014 17:34, Michael S. Tsirkin wrote:
> > so it looks like virtio is currently compiled per-target.
> > So why isn't it reasonable to keep it per-target for
> > purpose of this enhancement?
> > What am I missing?
>
> "vi
Cleaning up the implementation of REV and REV16 at the same time.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 57
1 file changed, 33 insertions(+), 24 deletions(-)
diff --git a/tcg/aarch64/tcg-tar
Am 15.04.2014 23:39, schrieb Peter Crosthwaite:
> On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote:
>> Am 15.04.2014 04:21, schrieb Peter Crosthwaite:
>>> So clients can set the top level id string.
>>>
>>> Signed-off-by: Peter Crosthwaite
>>
>> Anthony had nack'ed Paolo's attempt to general
Combines 4 other inline functions and tidies the prologue.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 100 ---
1 file changed, 33 insertions(+), 67 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b
Public bug reported:
In qemu_gluster_init, if the call to either glfs_set_volfile_server or
glfs_set_logging fails into the "out" case, glfs_fini is called without
having first calling glfs_init. This causes glfs_lock to spin forever
on this bit:
while (!fs->init)
pthread
Signed-off-by: Igor Ryzhov
---
net/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index e3ef1e4..60a07f1 100644
--- a/net/net.c
+++ b/net/net.c
@@ -473,7 +473,7 @@ ssize_t qemu_deliver_packet(NetClientState *sender,
if (ret == 0) {
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index c1d9895..a08f6c7 100644
--- a/tcg/aarch64/tcg-target.c
+++ b/tcg/aarch64/tcg-target
Now redundant with the type parameter to tcg_target_const_match.
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 40 ++--
1 file changed, 18 insertions(+), 22 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index
Instead of rolling a local TCG_TARGET_WORDS_BIGENDIAN.
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.h | 1 -
tcg/arm/tcg-target.h | 1 -
tcg/i386/tcg-target.h| 2 --
tcg/mips/tcg-target.c| 12 ++--
tcg/mips/tcg-target.h| 4
tcg/ppc/tcg-target.h
Now redundant with the type parameter to tcg_target_const_match.
Signed-off-by: Richard Henderson
---
tcg/s390/tcg-target.c | 43 +++
1 file changed, 19 insertions(+), 24 deletions(-)
diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c
index feeaf9
Signed-off-by: Richard Henderson
---
tcg/ppc64/tcg-target.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
index a533698..45b1c06 100644
--- a/tcg/ppc64/tcg-target.c
+++ b/tcg/ppc64/tcg-target.c
@@ -296,7 +296,15 @@ st
Rather than raw constants that could mean anything.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 73 +---
1 file changed, 38 insertions(+), 35 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aa
Signed-off-by: Richard Henderson
---
tcg/sparc/tcg-target.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c
index 73121e1..35089b8 100644
--- a/tcg/sparc/tcg-target.c
+++ b/tcg/sparc/tcg-target.c
@@ -334,7 +334,13 @@ stati
A few of these have been reviewed before, but didn't make the 2.0 cut.
The TCGType parameter to tcg_target_const_match patches arose out of
the review of one of my outstanding sparc backend patch sets.
The mulu2_i32 vs muluh_i32 patches arose out of some cleanup work I
am doing in the powerpc bac
Brown Bag sez, don't put the fallback code into the wrong function.
Also, check for muluh_i64 and use tcg_gen_mulu2_i64 instead of raw ops.
Signed-off-by: Richard Henderson
---
tcg/tcg-op.h | 38 ++
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git
Rather than hard-coding use of mulu2_i32, allow muluh_i32.
Signed-off-by: Richard Henderson
---
tcg/tcg-op.h | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
index 7eabf22..08dd09e 100644
--- a/tcg/tcg-op.h
+++ b/tcg/tcg-op.h
@@ -2437,14 +2437
By inspection, for a deposit(x, y, 0, 64), we'd have a shift of (1<<64)
and everything else falls apart. But we can reuse the existing deposit
logic to get this right.
Signed-off-by: Richard Henderson
---
tcg/optimize.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --gi
Most 64-bit targets need to be able to ignore the high bits
of a TCG_TYPE_I32 value.
Suggested-by: Stuart Brady
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 2 +-
tcg/arm/tcg-target.c | 2 +-
tcg/i386/tcg-target.c| 2 +-
tcg/ia64/tcg-target.c| 2 +-
tcg/mips/tcg-t
Instead require either mulu2_i32 or muluh_i32. The code in tcg-op.h
already supports looking for both. Previous incomplete conversion?
Signed-off-by: Richard Henderson
---
tcg/arm/tcg-target.h | 1 +
tcg/mips/tcg-target.h | 1 +
tcg/ppc/tcg-target.h | 1 +
tcg/tcg.h | 8 +++-
TCG now requires unspecified behavior rather than a potential crash,
bring the C shift within the letter of the law.
Signed-off-by: Richard Henderson
---
tci.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tci.c b/tci.c
index 0202ed9..6523ab8 100644
-
The TCG result would be undefined, but we can at least produce one
plausible result and avoid triggering the wrath of analysis tools.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
tcg/optimize.c | 35 ---
1 file changed, 20 insertions(+), 15 del
From: Stefan Weil
Static code analyzers complain about signed bitfields with only a single
bit. is_ld is used as a boolean value, so make it bool.
ppc64 already used bool for the 2nd argument is_ld of the local function
add_qemu_ldst_label. Modify all other TCG targets to do follow this
example.
Change the definition such that shifts are not allowed to crash
for any input.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
tcg/README | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/tcg/README b/tcg/README
index f178212..776e925 100644
Am 16.04.2014 18:32, schrieb Alexander Graf:
>
> On 16.04.14 16:44, Hannes Reinecke wrote:
>> MSI-X support has been fixed in qemu, so we can enable it again.
>>
>> Signed-off-by: Hannes Reinecke
>> ---
>> hw/scsi/megasas.c | 19 ++-
>> 1 file changed, 6 insertions(+), 13 delet
On 16 April 2014 17:34, Michael S. Tsirkin wrote:
> so it looks like virtio is currently compiled per-target.
> So why isn't it reasonable to keep it per-target for
> purpose of this enhancement?
> What am I missing?
"virtio" is more than one C file. Currently per-target:
hw/virtio/virtio.c
hw/vi
On Tue, Apr 15, 2014 at 03:22:56PM +0200, Greg Kurz wrote:
> On Tue, 15 Apr 2014 13:35:03 +0200
> Alexander Graf wrote:
>
> > On 04/15/2014 10:40 AM, Greg Kurz wrote:
> > > On Mon, 14 Apr 2014 15:08:23 +0200
> > > Alexander Graf wrote:
> > >
> > >> On 14.04.14 14:55, Michael S. Tsirkin wrote:
>
On 16.04.14 16:44, Hannes Reinecke wrote:
MSI-X support has been fixed in qemu, so we can enable it again.
Signed-off-by: Hannes Reinecke
---
hw/scsi/megasas.c | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
inde
The assembler seems to prefer them, perhaps we should too.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 3235824
On 16.04.14 16:44, Cornelia Huck wrote:
On Wed, 16 Apr 2014 13:29:05 +0200
Alexander Graf wrote:
On 14.04.14 18:48, Cornelia Huck wrote:
Make use of the new s390 adapter irq routing support to enable real
in-kernel irqfds for virtio-ccw with adapter interrupts.
Note that s390 doesn't provid
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 84 +++-
1 file changed, 69 insertions(+), 15 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 5cffe50..4414bd1 100644
---
Instead of passing them the "args" array.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 49 +---
1 file changed, 17 insertions(+), 32 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 89
tcg/aarch64/tcg-target.h | 2 +-
2 files changed, 31 insertions(+), 60 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
It's the more canonical interface.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 7ff4be7..73ed658 100644
--
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 34e477d..caaf8a2 100644
--- a/tcg/aarch64
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 4729d11..5d19e27 100644
--- a/tcg/aarch64/tcg-target.c
+++ b/tcg/aa
Replace aarch64_ldst_op_data with AArch64LdstType, as it wasn't encoded
for the proper shift for the field and was confusing.
Merge aarch64_ldst_op_data, AArch64LdstType, and a few stray opcode bits
into a single I3312_* argument, eliminating some magic numbers from the
helper functions.
Reviewed
On 04/15/2014 06:44 AM, Daniel Thompson wrote:
> Hi Folks
>
> I've just been rebasing some of my development branches against v3.15rc1
> and observed some boot regressions due to TEXT_OFFSET changing from
> 0x8000 to 0x208000.
>
> Now the boot regression turned out to be fault in the JTAG boot to
Rearrange code to put the compare and branch in the same place.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 34 ++
1 file changed, 14 insertions(+), 20 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarc
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 115 +--
1 file changed, 32 insertions(+), 83 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 0846835..7f72df5 100644
---
In some cases, a direct branch will be in range.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 5186311..4729d11 100644
Some guest env are small enough to reach the tlb with only a 12-bit addition.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/t
Making the bswap conditional on the memop instead of a compile-time test.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 131 +++
1 file changed, 63 insertions(+), 68 deletions(-)
diff --git a/tcg/aarch64
1 - 100 of 208 matches
Mail list logo
