Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-12 Thread Benjamin Herrenschmidt
On Sun, 2014-04-13 at 00:38 +0100, Peter Maydell wrote: > > From a design standpoint I find that totally retarded btw :-) > > I agree it's bonkers; it's just that fixing it requires a big pile > of design and implementation work from somebody; and in > the meantime "both ends must be configured id

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-04-12 Thread Alexey Kardashevskiy
On 04/13/2014 01:09 PM, Alexey Kardashevskiy wrote: > On 03/24/2014 08:26 PM, Peter Maydell wrote: >> On 24 March 2014 05:53, Alexey Kardashevskiy wrote: >>> On 03/23/2014 08:23 AM, Peter Maydell wrote: Oops, I hadn't noticed that; this patch is incorrect, then, because vmstate_ohci need

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-04-12 Thread Alexey Kardashevskiy
On 03/24/2014 08:26 PM, Peter Maydell wrote: > On 24 March 2014 05:53, Alexey Kardashevskiy wrote: >> On 03/23/2014 08:23 AM, Peter Maydell wrote: >>> Oops, I hadn't noticed that; this patch is incorrect, then, because >>> vmstate_ohci needs to include a line for the OHCIState, and we >>> need a s

Re: [Qemu-devel] [QEMU v5 PATCH 00/18] SMBIOS: build full tables in QEMU

2014-04-12 Thread Laszlo Ersek
On 04/13/14 02:55, Gabriel L. Somlo wrote: > Kevin, > > Thanks for the comments. I'll work your feedback (and any other > feedback I get by early next week) into another iteration of smbios > patches for both SeaBIOS and QEMU. > > In the mean time, there's one remaining "big picture" design quest

Re: [Qemu-devel] [QEMU v5 PATCH 00/18] SMBIOS: build full tables in QEMU

2014-04-12 Thread Gabriel L. Somlo
Kevin, Thanks for the comments. I'll work your feedback (and any other feedback I get by early next week) into another iteration of smbios patches for both SeaBIOS and QEMU. In the mean time, there's one remaining "big picture" design question: On Sat, Apr 12, 2014 at 11:56:08AM -0400, Kevin O'C

[Qemu-devel] iPXE timeout missing

2014-04-12 Thread Sebastian
Hi, when trying current qemu git, I noticed the iPXE timeout has been removed: commit 95ca557d5cfc1ef69ba9708ded552f389afe643d Author: Gerd Hoffmann Date: Mon Mar 25 09:07:40 2013 +0100 ipxe: disable two second timeout By removing the timeout, access to the iPXE command line is now imp

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-12 Thread Peter Maydell
On 12 April 2014 11:31, Benjamin Herrenschmidt wrote: > On Sat, 2014-04-12 at 09:25 +0200, Alexander Graf wrote: >> Exactly. We should try to migrate only state that the user doesn't >> specify on the command line. > > From a design standpoint I find that totally retarded btw :-) I agree it's bon

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-12 Thread Benjamin Herrenschmidt
On Sat, 2014-04-12 at 16:31 +0200, Alexander Graf wrote: > Don't we generate PHBs on the fly? How exactly is this going to help > with the problem at hand? We can still assign the interrupts as a fixed function of the PHB number... Cheers, Ben.

[Qemu-devel] [PATCH for 2.0] ide: Correct improper smart self test counter reset in ide core.

2014-04-12 Thread Benoît Canet
The counter being reseted to zero make the array index negative. Reset it to 1. Signed-off-by: Benoit Canet --- hw/ide/core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index e1dfe54..c943a4d 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c

Re: [Qemu-devel] qemu-binfmt-conf.sh

2014-04-12 Thread Sean Omalley
Thank you! That is why I asked.  I just thought it was odd to include the 8-9 if that was the case, but I have no way to test it. :) Sean On Saturday, April 12, 2014 4:35 AM, Peter Maydell wrote: On 12 April 2014 00:57, Sean Omalley wrote: > >> I was looking at  rc2 and /scripts/qemu-bi

[Qemu-devel] [PATCH v4 5/6] qemu-img: Specify backing file for commit

2014-04-12 Thread Max Reitz
Introduce a new parameter for qemu-img commit which may be used to explicitly specify the backing file into which an image should be committed if the backing chain has more than a single layer. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Fam Zheng --- qemu-img-cmds.hx | 4 ++

[Qemu-devel] [PATCH v4 3/6] qemu-img: Implement commit like QMP

2014-04-12 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. As qemu-img itself has no access to QMP (since this would basically require just everything being linked into qemu-img), imitate QMP's implementation of block-comm

[Qemu-devel] [PATCH v4 4/6] qemu-img: Enable progress output for commit

2014-04-12 Thread Max Reitz
Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 44 ++-- qemu-img.texi| 2 +- 3 files changed, 45 insertions(+), 5 deletions(-) di

[Qemu-devel] [PATCH v4 2/6] blockjob: Introduce block_job_complete_sync()

2014-04-12 Thread Max Reitz
Implement block_job_complete_sync() by doing the exact same thing as block_job_cancel_sync() does, only with calling block_job_complete() instead of block_job_cancel(). Signed-off-by: Max Reitz --- blockjob.c | 24 ++-- include/block/blockjob.h | 15

[Qemu-devel] [PATCH v4 1/6] block-commit: Expose granularity

2014-04-12 Thread Max Reitz
Allow QMP users to manipulate the granularity used in the block-commit command. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/commit.c| 16 +--- block/mirror.c| 4 ++-- blockdev.c| 22 -- include/block/block_i

[Qemu-devel] [PATCH v4 0/6] qemu-img: Implement commit like QMP

2014-04-12 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. For the "commit" command, this is relatively easy, so implement it first (in the hope that indeed others will follow). As qemu-img does not have access to QMP (du

Re: [Qemu-devel] [ceph-users] qemu + rbd block driver with cache=writeback, is live migration safe ?

2014-04-12 Thread Andrey Korolyov
Hello, AFAIK qemu calls bdrv_flush at the end of migration process so this is absolutely safe. Anyway it`s proven by our production systems very well too :) On Sat, Apr 12, 2014 at 7:01 PM, Alexandre DERUMIER wrote: > Hello, > > I known that qemu live migration with disk with cache=writeback are

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-12 Thread Michael S. Tsirkin
On Sat, Apr 12, 2014 at 08:52:47PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 11, 2014 at 06:37:03PM +0100, Peter Maydell wrote: > > On 10 April 2014 12:17, Peter Maydell wrote: > > > So far I know of at least three fixes which should probably > > > go into 2.0 > > > > Status update: > > Appl

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-12 Thread Michael S. Tsirkin
On Sat, Apr 12, 2014 at 06:50:49PM +0100, Peter Maydell wrote: > On 12 April 2014 18:48, Michael S. Tsirkin wrote: > > On Sat, Apr 12, 2014 at 12:48:41PM +0400, Michael Tokarev wrote: > >> 11.04.2014 21:37, Peter Maydell wrote: > >> > * vmxnet3 patches > >> > >> I think this is not dangerous to g

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-12 Thread Michael S. Tsirkin
On Fri, Apr 11, 2014 at 06:37:03PM +0100, Peter Maydell wrote: > On 10 April 2014 12:17, Peter Maydell wrote: > > So far I know of at least three fixes which should probably > > go into 2.0 > > Status update: > Applied: > * ACPI fixes (both sets) > * block queue > * SDL2 relative mode fixes >

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-12 Thread Peter Maydell
On 12 April 2014 18:48, Michael S. Tsirkin wrote: > On Sat, Apr 12, 2014 at 12:48:41PM +0400, Michael Tokarev wrote: >> 11.04.2014 21:37, Peter Maydell wrote: >> > * vmxnet3 patches >> >> I think this is not dangerous to go in before 2.0. We wont have more >> testing even if it were applied much

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-12 Thread Michael S. Tsirkin
On Sat, Apr 12, 2014 at 12:48:41PM +0400, Michael Tokarev wrote: > 11.04.2014 21:37, Peter Maydell wrote: > [] > > Patches on list but need review/ack and/or not sure whether to apply: > > * kvm_physical_sync_dirty_bitmap bug > > Paolo proposed to revert the change which lead to that bug, but it

Re: [Qemu-devel] [QEMU v5 PATCH 00/18] SMBIOS: build full tables in QEMU

2014-04-12 Thread Kevin O'Connor
On Fri, Apr 11, 2014 at 12:11:40PM -0400, Gabriel L. Somlo wrote: > Quick highlights: > > - after 10/18, we're generating tables 100% consistent with SeaBiOS > > - after 14/18, we use e820 to generate type 19 (memory area) tables > > - after 18/18, we expect SeaBIOS to check fw_cfg for a f

Re: [Qemu-devel] [PATCH v2 3/6] qemu-img: Implement commit like QMP

2014-04-12 Thread Max Reitz
On 11.04.2014 14:54, Kevin Wolf wrote: Am 10.04.2014 um 16:32 hat Max Reitz geschrieben: On 08.04.2014 17:14, Kevin Wolf wrote: Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offlin

Re: [Qemu-devel] [PATCH] block-commit: speed is an optional parameter

2014-04-12 Thread Max Reitz
On 11.04.2014 13:20, Kevin Wolf wrote: Am 10.04.2014 um 19:36 hat Max Reitz geschrieben: As speed is an optional parameter for the QMP block-commit command, it should be set to 0 if not given (as it is undefined if has_speed is false), that is, the speed should not be limited. Signed-off-by: Ma

Re: [Qemu-devel] [SeaBIOS v2 PATCH] SMBIOS: Check for full tables & entry point in fw_cfg

2014-04-12 Thread Kevin O'Connor
On Fri, Apr 11, 2014 at 12:42:52PM -0400, Gabriel L. Somlo wrote: > Check fw_cfg for the presence of a complete set of smbios tables > (etc/smbios/smbios-tables), and an entry point structure > (etc/smbios/smbios-anchor). If found, we no longer build smbios > tables locally; instead, we replace onl

[Qemu-devel] [PATCH v5] spapr: Add support for time base offset migration

2014-04-12 Thread Alexey Kardashevskiy
This allows guests to have a different timebase origin from the host. This is needed for migration, where a guest can migrate from one host to another and the two hosts might have a different timebase origin. However, the timebase seen by the guest must not go backwards, and should go forwards onl

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-12 Thread Alexey Kardashevskiy
On 04/11/2014 07:40 PM, Alexander Graf wrote: > > On 10.04.14 16:31, Alexey Kardashevskiy wrote: >> On 04/10/2014 10:34 PM, Alexander Graf wrote: >>> On 03.04.14 15:14, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from the host. This is needed f

[Qemu-devel] qemu + rbd block driver with cache=writeback, is live migration safe ?

2014-04-12 Thread Alexandre DERUMIER
Hello, I known that qemu live migration with disk with cache=writeback are not safe with storage like nfs,iscsi... Is it also true with rbd ? If yes, it is possible to disable manually writeback online with qmp ? Best Regards, Alexandre

Re: [Qemu-devel] [PATCH] migration: Increase default max_downtime from 30ms to 300ms

2014-04-12 Thread Alexey Kardashevskiy
On 03/27/2014 08:01 PM, Markus Armbruster wrote: > Adding Juan. Ping? > > Alexey Kardashevskiy writes: > >> The existing timeout is 30ms which on 100MB/s (1Gbit) gives us >> 3MB/s rate maximum. If we put some load on the guest, it is easy to >> get page dirtying rate too big so live migratio

Re: [Qemu-devel] [PATCH for-2.0] kvm_physical_sync_dirty_bitmap: ignore ENOENT from kvm_vm_ioctl

2014-04-12 Thread Serge E. Hallyn
Quoting Paolo Bonzini (pbonz...@redhat.com): > Il 11/04/2014 22:10, Serge Hallyn ha scritto: > >Quoting Paolo Bonzini (pbonz...@redhat.com): > >>Il 11/04/2014 04:31, Michael Tokarev ha scritto: > >>>ENOENT means the kernel has an empty dirty bitmap for this > >>>slot. Don't abort in that case. Th

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-12 Thread Alexander Graf
> Am 12.04.2014 um 12:31 schrieb Benjamin Herrenschmidt > : > >> On Sat, 2014-04-12 at 09:25 +0200, Alexander Graf wrote: >> Exactly. We should try to migrate only state that the user doesn't >> specify on the command line. > > From a design standpoint I find that totally retarded btw :-) > >

Re: [Qemu-devel] [PATCH for-2.0] kvm_physical_sync_dirty_bitmap: ignore ENOENT from kvm_vm_ioctl

2014-04-12 Thread Paolo Bonzini
Il 11/04/2014 22:10, Serge Hallyn ha scritto: Quoting Paolo Bonzini (pbonz...@redhat.com): Il 11/04/2014 04:31, Michael Tokarev ha scritto: ENOENT means the kernel has an empty dirty bitmap for this slot. Don't abort in that case. This appears to solve the bug reported at https://bugs.launch

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-12 Thread Benjamin Herrenschmidt
On Sat, 2014-04-12 at 09:25 +0200, Alexander Graf wrote: > Exactly. We should try to migrate only state that the user doesn't > specify on the command line. >From a design standpoint I find that totally retarded btw :-) The sensible thing to do would have been for the configuration to migrate alo

[Qemu-devel] [PATCH] mac99: Change memory layout to better match PowerMac3, 1

2014-04-12 Thread BALATON Zoltan
Bring the memory map closer to a PowerMac3,1 model by removing unused areas and adding the VGA and network cards after the macio to let the latter be mapped from 0x8000 like on real hardware. (On real hardware the graphics and network cards are on separate buses but we don't model that yet.) S

[Qemu-devel] [PATCH] kvm_physical_sync_dirty_bitmap: ignore ENOENT from kvm_vm_ioctl

2014-04-12 Thread Michael Tokarev
ENOENT means the kernel has an empty dirty bitmap for this slot. Don't abort in that case. This appears to solve the bug reported at https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1303926 which first showed up with commit b533f658a98325d: fix return check for KVM_GET_DIRTY_LOG ioctl Signe

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-12 Thread Michael Tokarev
11.04.2014 21:37, Peter Maydell wrote: [] > Patches on list but need review/ack and/or not sure whether to apply: > * kvm_physical_sync_dirty_bitmap bug Paolo proposed to revert the change which lead to that bug, but it seems wrong thing to do, since original code was clearly wrong. Maybe it is a

Re: [Qemu-devel] qemu-binfmt-conf.sh

2014-04-12 Thread Peter Maydell
On 12 April 2014 00:57, Sean Omalley wrote: > I was looking at rc2 and /scripts/qemu-binfmt-conf.sh briefly, > it has > > # probe cpu type > cpu=`uname -m` > case "$cpu" in > > Then there is no cpu for aarch64, but if you poke down further, > there is a if-then that uses a cpu=aarch64. > > Should

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-12 Thread Alexander Graf
> Am 12.04.2014 um 05:44 schrieb Alexey Kardashevskiy : > >> On 04/12/2014 07:55 AM, Benjamin Herrenschmidt wrote: >> On Fri, 2014-04-11 at 11:40 +0200, Alexander Graf wrote: And G5 uses . I really do not understand why it is bad to send-and-check timer frequency. Why? >>> >>>