[Qemu-devel] [PATCH v2 2/4] qdev-monitor: Implement three functions used to connect devices

2014-04-10 Thread Alistair Francis
These functions are used to attach devices that are passed in via the command line using the -device argument. The reason for using three functions is to allow a multi-pass approach. This can then be extended to allow devices to connect to other devices that are being connected via the command lin

Re: [Qemu-devel] [PATCH v2 0/4] Allow sysbus devices to be attached via commandline

2014-04-10 Thread Alistair Francis
CC Konstanty On Fri, Apr 11, 2014 at 4:34 PM, Alistair Francis wrote: > This patch allows sysbus devices to be attached via > command line arguments. > > This can be used to build an entire machine from the command > line or to just add devices that aren't in the machine_init > code. > > A periph

[Qemu-devel] [PATCH v2 3/4] vl.c: Enable adding devices to the system bus

2014-04-10 Thread Alistair Francis
This removes the old method to connect devices and replaces it with three calls to the three qdev-monitor functions added in the previous patch. This allows complete machines to be built via the command line as well as just attaching simple sysbus devices. Signed-off-by: Alistair Francis --- v

[Qemu-devel] [PATCH v2 0/4] Allow sysbus devices to be attached via commandline

2014-04-10 Thread Alistair Francis
This patch allows sysbus devices to be attached via command line arguments. This can be used to build an entire machine from the command line or to just add devices that aren't in the machine_init code. A peripheral can be added with the following syntax: -device cadence_uart,addr=0xE000,irq=

[Qemu-devel] [PATCH v2 1/4] qemu-option.c: Add qemu_opt functions that step over arguments

2014-04-10 Thread Alistair Francis
This adds two functions, qemu_opt_step() and qemu_opt_name_step() which iterate over the comma separated stings in the QemuOpts* argument. This allows accessing multiple arguments with the same name by iterating over all of the arguments Signed-off-by: Alistair Francis --- include/qemu/option.h

Re: [Qemu-devel] [RFC PATCH v2 10/12] mc: expose tunable parameter for checkpointing frequency

2014-04-10 Thread Michael R. Hines
On 04/04/2014 10:56 PM, Eric Blake wrote: On 04/03/2014 11:29 PM, Michael R. Hines wrote: I'm trying to thing of a back-compat method, which exploits the fact that we now have flat unions (something we didn't have when migrate-set-capabilities was first added). Maybe something like: { 'type':

[Qemu-devel] [PATCH v25 31/31] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList

2014-04-10 Thread Chunyan Liu
Now only qemu_opts_append uses 'allocated' to indicate free memory. For this function only, we can also let result list's (const char *) members point to input list's members, only if the input list has longer lifetime than result list. In current code, that is true. So, we can remove the 'allocate

[Qemu-devel] [PATCH v25 25/31] ssh.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/ssh.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index aa63c9d..3a5eead 100644 --- a/block/ssh.c +++ b/block/ssh.c

[Qemu-devel] [PATCH v25 30/31] cleanup QEMUOptionParameter

2014-04-10 Thread Chunyan Liu
Now that all backend drivers are using QemuOpts, remove all QEMUOptionParameter related codes. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block.c | 86 ++ block/cow.c | 4 +- block/gluster.c | 8 +- block/iscsi.c

[Qemu-devel] [PATCH v25 27/31] vhdx.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vhdx.c | 99 +--- block/vhdx.h | 1 + 2 files changed, 48 insertions(+), 52 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index a9fcf6b

[Qemu-devel] [PATCH v25 21/31] raw-win32.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/raw-win32.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index 48cb2c2..b00d7fc 100644 --- a/block/

[Qemu-devel] [PATCH v25 29/31] vpc.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vpc.c | 62 + 1 file changed, 34 insertions(+), 28 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 2e25f57..8ebf424 100644 --- a/b

[Qemu-devel] [PATCH v25 18/31] qcow2.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/qcow2.c | 265 +++--- include/qemu/option.h | 1 + util/qemu-option.c| 2 +- 3 files changed, 143 insertions(+), 125 deletions(-) diff --git a/block/qcow2.c b/block/qcow2

[Qemu-devel] [PATCH v25 28/31] vmdk.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vmdk.c | 123 ++- 1 file changed, 63 insertions(+), 60 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index d87c8f6..f9b68a0 100644 --- a

[Qemu-devel] [PATCH v25 24/31] sheepdog.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/sheepdog.c | 108 --- 1 file changed, 55 insertions(+), 53 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 0eb33ee..9f280f6 1006

[Qemu-devel] [PATCH v25 16/31] nfs.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- block/nfs.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 98aa363..664ceeb 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -357,20 +357,14 @@ static int nfs_file_open(BlockDriverState *bs, QDict *opti

[Qemu-devel] [PATCH v25 26/31] vdi.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vdi.c | 73 + 1 file changed, 35 insertions(+), 38 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 820cd37..950cf46 100644 --- a/block/vdi.c +++ b/block/vdi.c @

[Qemu-devel] [PATCH v25 19/31] qed.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
One extra change is to define QED_DEFAULT_CLUSTER_SIZE = 65536 instead of 64 * 1024; because: according to existing create_options, "cluster size" has default value = QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this has to be stringized and set to .def_value_str. That is, .def_value

[Qemu-devel] [PATCH v25 12/31] vvfat.c: handle cross_driver's create_options and create_opts

2014-04-10 Thread Chunyan Liu
vvfat shares create options of qcow driver. To avoid vvfat broken when qcow driver changes from QEMUOptionParameter to QemuOpts, let it able to handle both cases. Signed-off-by: Chunyan Liu --- block/vvfat.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] [PATCH v25 23/31] rbd.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/rbd.c | 63 + 1 file changed, 30 insertions(+), 33 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index dbc79f4..f878877 100644 --- a/b

[Qemu-devel] [PATCH v25 17/31] qcow.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/qcow.c | 72 ++-- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 9411aef..b4ce133 100644 --- a

[Qemu-devel] [PATCH v25 14/31] gluster.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/gluster.c | 81 ++--- 1 file changed, 42 insertions(+), 39 deletions(-) diff --git a/block/gluster.c b/block/gluster.c inde

[Qemu-devel] [PATCH v25 22/31] raw_bsd.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/raw_bsd.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 9ae5fc2..ee797fd 100644 --- a/block/raw_bsd.c +++ b/b

[Qemu-devel] [PATCH v25 11/31] change block layer to support both QemuOpts and QEMUOptionParamter

2014-04-10 Thread Chunyan Liu
Change block layer to support both QemuOpts and QEMUOptionParameter. After this patch, it will change backend drivers one by one. At the end, QEMUOptionParameter will be removed and only QemuOpts is kept. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block.c | 151

[Qemu-devel] [PATCH v25 15/31] iscsi.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/iscsi.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 64a509f..8544281 100644 --- a/block/iscsi.c +++ b/bl

[Qemu-devel] [PATCH v25 10/31] QemuOpts: check NULL input for qemu_opts_del

2014-04-10 Thread Chunyan Liu
To simplify later using of qemu_opts_del, accept NULL input. Reviewed-by: Eric Blake Signed-off-by: Chunyan Liu --- util/qemu-option.c | 4 1 file changed, 4 insertions(+) diff --git a/util/qemu-option.c b/util/qemu-option.c index d1e4d94..6222cd6 100644 --- a/util/qemu-option.c +++ b/uti

[Qemu-devel] [PATCH v25 07/31] QemuOpts: add qemu_opts_print_help to replace print_option_help

2014-04-10 Thread Chunyan Liu
print_option_help takes QEMUOptionParameter as parameter, add qemu_opts_print_help to take QemuOptsList as parameter for later replace work. Reviewed-by: Leandro Dorileo Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- include/qemu/option.h | 1 + util/qemu-option.c| 13

[Qemu-devel] [PATCH v25 06/31] QemuOpts: add qemu_opt_get_*_del functions for replace work

2014-04-10 Thread Chunyan Liu
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and qemu_opt_get_size_del to replace the same handling of QEMUOptionParamter (get and delete). Several drivers are coded to parse a known subset of options, then remove them from the list before handing all remaining options to a

[Qemu-devel] [PATCH v25 13/31] cow.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/cow.c | 54 ++ 1 file changed, 26 insertions(+), 28 deletions(-) diff --git a/block/cow.c b/block/cow.c index 26cf4a5..fb2c

[Qemu-devel] [PATCH v25 20/31] raw-posix.c: replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
Reviewed-by: Stefan Hajnoczi Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/raw-posix.c | 59 +-- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 1688e16..e72f449 10

[Qemu-devel] [PATCH v25 00/31] replace QEMUOptionParameter with QemuOpts

2014-04-10 Thread Chunyan Liu
This patch series is to replace QEMUOptionParameter with QemuOpts, so that only one Qemu Option structure is kept in QEMU code. --- Changes to v24: * fix Leandro's comments to v23 * add patch for block/nfs.c * rebase to latest code All patches are also available from: https://github.com/chu

[Qemu-devel] [PATCH v25 03/31] qapi: output def_value_str when query command line options

2014-04-10 Thread Chunyan Liu
Change qapi interfaces to output the newly added def_value_str when querying command line options. Reviewed-by: Eric Blake Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- changes: * Following Leandro's comment: update description of @default qapi-schema.json | 6 +- qmp

[Qemu-devel] [PATCH v25 08/31] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts

2014-04-10 Thread Chunyan Liu
Add two temp conversion functions between QEMUOptionParameter to QemuOpts, so that next patch can use it. It will simplify later patch for easier review. And will be finally removed after all backend drivers switch to QemuOpts. Signed-off-by: Chunyan Liu --- include/qemu/option.h | 8 +++ util

[Qemu-devel] [PATCH v25 09/31] QemuOpts: add qemu_opts_append to replace append_option_parameters

2014-04-10 Thread Chunyan Liu
For later merge .create_opts of drv and proto_drv in qemu-img commands. Reviewed-by: Leandro Dorileo Signed-off-by: Chunyan Liu --- include/qemu/option.h | 5 util/qemu-option.c| 65 +++ 2 files changed, 70 insertions(+) diff --git a/in

[Qemu-devel] [PATCH v25 05/31] QemuOpts: move qemu_opt_del ahead for later calling

2014-04-10 Thread Chunyan Liu
In later patch, qemu_opt_get_del functions will be added, they will first get the option value, then call qemu_opt_del to remove the option from opt list. To prepare for that purpose, move qemu_opt_del ahead first. Reviewed-by: Leandro Dorileo Reviewed-by: Eric Blake Signed-off-by: Chunyan Liu

[Qemu-devel] [PATCH v25 01/31] QemuOpts: move find_desc_by_name ahead for later calling

2014-04-10 Thread Chunyan Liu
Reviewed-by: Leandro Dorileo Reviewed-by: Eric Blake Signed-off-by: Chunyan Liu --- util/qemu-option.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/util/qemu-option.c b/util/qemu-option.c index 9d898af..e6d10bc 100644 --- a/util/qemu-option.

[Qemu-devel] [PATCH v25 02/31] QemuOpts: add def_value_str to QemuOptDesc

2014-04-10 Thread Chunyan Liu
Add def_value_str (default value) to QemuOptDesc, to replace function of the default value in QEMUOptionParameter. Improve qemu_opts_get_* functions: if find opt, return opt->str; otherwise, if desc->def_value_str is set, return desc->def_value_str; otherwise, return input defval. Improve qemu_op

[Qemu-devel] [PATCH v25 04/31] QemuOpts: change opt->name|str from (const char *) to (char *)

2014-04-10 Thread Chunyan Liu
qemu_opt_del() already assumes that all QemuOpt instances contain malloc'd name and value; but it had to cast away const because opts_start_struct() was doing its own thing and using static storage instead. By using the correct type and malloced strings everywhere, the usage of this struct becomes

Re: [Qemu-devel] [RFC v2 1/6] hw/arm/virt: add a xgmac device

2014-04-10 Thread Alistair Francis
On Thu, Apr 10, 2014 at 11:48 PM, Alexander Graf wrote: > > On 10.04.14 15:26, Peter Crosthwaite wrote: >> >> On Thu, Apr 10, 2014 at 1:33 AM, Eric Auger wrote: >>> >>> From: Kim Phillips >>> >>> This is a hack and only serves as an example of what needs to be >>> done to make the next RFC - add

Re: [Qemu-devel] [PATCH] iscsi: Remember to set ret for iscsi_open in error case

2014-04-10 Thread Fam Zheng
On Thu, 04/10 13:11, Kevin Wolf wrote: > Am 10.04.2014 um 03:33 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > Thanks, applied to the block branch. > Is this going into 2.0? Thanks, Fam

[Qemu-devel] [RFC PATCH] target-ppc: Relax use of generic CPU name for KVM

2014-04-10 Thread Alexey Kardashevskiy
At the moment generic version-less CPUs are supported via hardcoded aliases. For example, POWER7 is an alias for POWER7_v2.1. So when QEMU is started with -cpu POWER7, the POWER7_v2.1 class instance is created. This approach works for TCG and KVMs other than HV KVM. HV KVM cannot emulate PVR value

[Qemu-devel] [PATCH] exit qemu when unknown object type is specified by -object

2014-04-10 Thread Hu Tao
...to avoid assertion failure in object_new_with_type(). Can be reproduced by: qemu -object unknown-object,id=xxx Signed-off-by: Hu Tao --- qom/object.c | 5 + 1 file changed, 5 insertions(+) diff --git a/qom/object.c b/qom/object.c index f4de619..1e7445b 100644 --- a/qom/object.c +++ b/qom

[Qemu-devel] [PATCH RFC V2] virtio-net: announce self by guest

2014-04-10 Thread Jason Wang
It's hard to track all mac addresses and their configurations (e.g vlan or ipv6) in qemu. Without those informations, it's impossible to build proper garp packet after migration. The only possible solution to this is let guest (who knew all configurations) to do this. So, this patch introduces a n

Re: [Qemu-devel] [RFC v2 0/6] KVM platform device passthrough

2014-04-10 Thread Kim Phillips
On Wed, 9 Apr 2014 16:33:03 +0100 Eric Auger wrote: > some patches need to be applied on host linux to correct issues > not yet upstreamed. They can be found on vfio-dev branch of > git://git.linaro.org/people/eric.auger/linux.git > > - commit 997691b: enables unmapping stage2 entries on memory

Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized variables

2014-04-10 Thread Eric Blake
On 03/28/2014 08:19 AM, Peter Maydell wrote: > On 20 March 2014 19:21, Michael Roth wrote: >> Could it be as simple as this?: >> >> diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py >> index 9734ab0..a70482e 100644 >> --- a/scripts/qapi-commands.py >> +++ b/scripts/qapi-commands.py

Re: [Qemu-devel] [RFC v2 4/6] vfio: Add initial IRQ support in QEMU platform device

2014-04-10 Thread Kim Phillips
On Wed, 9 Apr 2014 16:33:07 +0100 Eric Auger wrote: > This work is inspired of PCI INTx. The code was prepared to support > multiple IRQs but this was not tested at that stage. Similarly to what > is done on PCI, the device register space is RAM unmapped on IRQ hit > in order to trap the end of i

Re: [Qemu-devel] [Qemu-stable] [PATCH] block-commit: speed is an optional parameter

2014-04-10 Thread Eric Blake
On 04/10/2014 07:09 PM, Fam Zheng wrote: > On Thu, 04/10 19:36, Max Reitz wrote: >> As speed is an optional parameter for the QMP block-commit command, it >> should be set to 0 if not given (as it is undefined if has_speed is >> false), that is, the speed should not be limited. >> >> Signed-off-by:

Re: [Qemu-devel] [Qemu-stable] [PATCH] block-commit: speed is an optional parameter

2014-04-10 Thread Fam Zheng
On Thu, 04/10 19:36, Max Reitz wrote: > As speed is an optional parameter for the QMP block-commit command, it > should be set to 0 if not given (as it is undefined if has_speed is > false), that is, the speed should not be limited. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- >

Re: [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames

2014-04-10 Thread Fam Zheng
On Thu, 04/10 14:09, Jeff Cody wrote: > On Thu, Apr 10, 2014 at 08:48:10AM -0600, Eric Blake wrote: > > On 04/10/2014 08:43 AM, Eric Blake wrote: > > > On 04/10/2014 06:53 AM, Jeff Cody wrote: > > > > > +++ b/tests/qemu-iotests/common.rc > > @@ -178,10 +178,10 @@ _rm_test_img() > >

Re: [Qemu-devel] [PATCH v1 1/1] vl.c: Allow sysbus devices to be attached via commandline

2014-04-10 Thread Peter Crosthwaite
cc Alex On Thu, Apr 10, 2014 at 10:54 AM, Alistair Francis wrote: > On Wed, Apr 9, 2014 at 6:02 PM, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> On Wed, Apr 9, 2014 at 11:28 AM, Peter Crosthwaite >>> wrote: On Wed, Mar 26, 2014 at 10:47 AM, Alistair Francis wrote: >>>

Re: [Qemu-devel] [PATCH v6 00/37] AArch64 system emulation

2014-04-10 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:14 AM, Peter Maydell wrote: > Here's v5 of the AArch64 system emulation patchset. > Still missing/TODO: > * SMP support (needs PSCI emulation in QEMU; being prototyped) > * save/restore (I have a patch which adds this but I think it will >look better if we consolida

Re: [Qemu-devel] [PULL for-2.0 v2 0/2] acpi: DSDT update

2014-04-10 Thread Peter Maydell
On 10 April 2014 17:12, Michael S. Tsirkin wrote: > The following changes since commit efcc87d9aedb590b8506cd1a7c8abe557c760f9e: > > Update version for v2.0.0-rc2 release (2014-04-08 18:52:06 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.

Re: [Qemu-devel] [PATCH for-2.0] configure: use do_cc when checking for -fstack-protector support

2014-04-10 Thread Peter Maydell
On 10 April 2014 18:51, Michael S. Tsirkin wrote: > Reviewed-by: Michael S. Tsirkin Thanks; patch applied to master. -- PMM

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-10 Thread Peter Maydell
On 10 April 2014 12:17, Peter Maydell wrote: > So far I know of at least three fixes which should probably > go into 2.0: > * my fix for the configure stack-protector checks on MacOSX > * MST's pull request updating the ACPI test blobs > * MST says we need to update the hex files for ACPI too >

Re: [Qemu-devel] [PATCH v4 21/21] hw/arm/virt: Add support for Cortex-A57

2014-04-10 Thread Peter Maydell
On 10 April 2014 20:41, Rob Herring wrote: > On Thu, Apr 10, 2014 at 10:02 AM, Peter Maydell > wrote: >> We could in theory write an a57mpcore_priv which was a >> carbon copy of a15mpcore_priv, but that seems a bit pointless. >> I think it's probably actually reasonable to use a15mpcore_priv >> h

Re: [Qemu-devel] [PATCH] Keyboard/Mouse Console for vfio with active function x-vga ans -vga none

2014-04-10 Thread qemu Mailinglist
Am 10.04.2014 22:29, schrieb Alex Williamson: > I don't think vfio is the one to be creating a dummy console, besides > there's no reason you can't have multiple vfio devices with x-vga=on. > There should probably be some dummy console driver so you can add > -device dummy-console to the commandli

[Qemu-devel] [PATCH v3 5/5] block: qemu-iotests: make test 019 and 086 work with spaced pathnames

2014-04-10 Thread Jeff Cody
Both tests 019 and 086 need proper quotations to work with pathnames that contain spaces. Reviewed-by: Benoit Canet Reviewed-by: Fam Zheng Signed-off-by: Jeff Cody --- tests/qemu-iotests/019 | 2 +- tests/qemu-iotests/086 | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --g

[Qemu-devel] [PATCH v3 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames

2014-04-10 Thread Jeff Cody
The _rm_test_img() function in common.rc did not quote the image file, which left droppings in the scratch directory (and performed a potentially unsafe rm -f). This adds the necessary quotes. Reviewed-by: Benoit Canet Signed-off-by: Jeff Cody --- tests/qemu-iotests/common.rc | 4 ++-- 1 file

[Qemu-devel] [PATCH v3 3/5] block: qemu-iotests - test for live migration

2014-04-10 Thread Jeff Cody
This is an initial, simple live migration test from one running VM to another, using monitor commands. This is also an example on using the new common.qemu functions for controlling multiple running qemu instances, for tests that need a live qemu vm. Signed-off-by: Jeff Cody --- tests/qemu-iote

[Qemu-devel] [PATCH v3 2/5] block: qemu-iotests - update 085 to use common.qemu

2014-04-10 Thread Jeff Cody
The new functionality of common.qemu implements the QEMU control and communication functionality that was originally in test 085. This removes that now-duplicate functionality, and uses the common.qemu functions. Reviewed-by: Benoit Canet Signed-off-by: Jeff Cody --- tests/qemu-iotests/085 | 7

[Qemu-devel] [PATCH v3 0/5] Add common QEMU control functionality to qemu-iotests

2014-04-10 Thread Jeff Cody
Changes from v2: Updated Reviewed-by for Fam and Benoit (Benoit's from the v1 patch, I forgot to add those to v2) Patch 1: * updated commit message (Thanks Fam) * Addded '-machine accel=qtest' to qemu launch args (Thanks Fam) Patch 3: * Moved from test 089 -> test 090 to avoi

[Qemu-devel] [PATCH v3 1/5] block: qemu-iotests - add common.qemu, for bash-controlled qemu tests

2014-04-10 Thread Jeff Cody
This creates some common functions for bash language qemu-iotests to control, and communicate with, a running QEMU process. 4 functions are introduced: 1. _launch_qemu() This launches the QEMU process(es), and sets up the file descriptors and fifos for communication. You can

Re: [Qemu-devel] [PATCH] Keyboard/Mouse Console for vfio with active function x-vga ans -vga none

2014-04-10 Thread Alex Williamson
On Thu, 2014-04-10 at 22:07 +0200, qemu Mailinglist wrote: > there are many discus about using keyboard and mouse with VGA passthru, > so I add a graphic_console to vfio.c, like puv3.c. > I test it with SDL and VNC Access, the Keyboard works, the mouse work > good without absolute version like "-us

[Qemu-devel] [PATCH] Keyboard/Mouse Console for vfio with active function x-vga ans -vga none

2014-04-10 Thread qemu Mailinglist
there are many discus about using keyboard and mouse with VGA passthru, so I add a graphic_console to vfio.c, like puv3.c. I test it with SDL and VNC Access, the Keyboard works, the mouse work good without absolute version like "-usbdevice mouse". Default it boot with "QEMU PS/2 Mouse", but this is

Re: [Qemu-devel] [PATCH v4 21/21] hw/arm/virt: Add support for Cortex-A57

2014-04-10 Thread Rob Herring
On Thu, Apr 10, 2014 at 10:02 AM, Peter Maydell wrote: > On 17 March 2014 07:12, Peter Crosthwaite > wrote: >> On Fri, Mar 7, 2014 at 5:33 AM, Peter Maydell >> wrote: >>> Support the Cortex-A57 in the virt machine model. >>> >>> Signed-off-by: Peter Maydell >>> --- >>> This should perhaps not

[Qemu-devel] [PATCH v3 02/12] check-qdict: Add test for qdict_join()

2014-04-10 Thread Max Reitz
Add some test cases for qdict_join(). Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Benoit Canet --- tests/check-qdict.c | 87 + 1 file changed, 87 insertions(+) diff --git a/tests/check-qdict.c b/tests/check-qdict.c index 2a

[Qemu-devel] [PATCH v3 00/12] block/json: Add JSON protocol driver

2014-04-10 Thread Max Reitz
This series adds a passthrough JSON protocol block driver. Its filenames are JSON objects prefixed by "json:". The objects are used as options for opening another block device which will be the child of the JSON device. Regarding this child device, the JSON driver behaves nearly the same as raw_bsd

Re: [Qemu-devel] [PATCH v2 2/5] block: qemu-iotests - update 085 to use common.qemu

2014-04-10 Thread Jeff Cody
On Thu, Apr 10, 2014 at 02:10:48PM +0800, Fam Zheng wrote: > On Wed, 04/09 22:41, Jeff Cody wrote: > > The new functionality of common.qemu implements the QEMU control > > and communication functionality that was originally in test 085. > > > > This removes that now-duplicate functionality, and us

[Qemu-devel] [PATCH v3 04/12] block/json: Add JSON protocol driver

2014-04-10 Thread Max Reitz
Add a JSON protocol driver which allows supplying block driver options through the filename rather than separately. Other than that, it is a pure passthrough driver which identifies itself as a filter. This patch implements the functions bdrv_parse_filename(), bdrv_file_open(), bdrv_close(), bdrv_

Re: [Qemu-devel] [PATCH for-2.0] qom: Fix crash with qom-list and link properties

2014-04-10 Thread Marcel Apfelbaum
On Thu, 2014-04-10 at 14:47 -0400, Cole Robinson wrote: > Commit 9561fda8d90e176bef598ba87c42a1bd6ad03ef7 changed the type of > 'opaque' for link properties, but missed updating this call site. > Reproducer: > > ./x86_64-softmmu/qemu-system-x86_64 -qmp unix:./qmp.sock,server & > ./scripts/qmp/qmp-

[Qemu-devel] [PATCH v3 03/12] block: Add "has_single_child" field for drivers

2014-04-10 Thread Max Reitz
This field should be used by block drivers acting as filters which have only a single child BDS which is referenced through the "file" field of the BDS. Setting this field allows other block functions to "access" the child BDS, for instance in bdrv_recurse_is_first_non_filter(). Therefore, it shou

Re: [Qemu-devel] [PATCH v2 1/5] block: qemu-iotests - add common.qemu, for bash-controlled qemu tests

2014-04-10 Thread Jeff Cody
On Thu, Apr 10, 2014 at 01:27:37PM +0800, Fam Zheng wrote: > On Wed, 04/09 22:41, Jeff Cody wrote: > > This creates some common functions for bash language qemu-iotests > > to control, and communicate with, a running QEMU process. > > > > 4 functions are introduced: > > > > 1. _launch_qemu()

Re: [Qemu-devel] [PATCH V6 1/2] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2014 at 09:55:21PM +0300, Marcel Apfelbaum wrote: > If a pci-2-pci bridge supports hot-plug functionality but there are no devices > connected to it, reserve IO/mem in order to be able to attach devices > later. Do not waste space, use minimum allowed. > > Reviewed-by: Michael S. T

Re: [Qemu-devel] [PATCH V6 2/2] hw/pci: check if pci2pci bridges implement optional limit registers

2014-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2014 at 09:55:22PM +0300, Marcel Apfelbaum wrote: > pair and > pair > are both optional. > Do not reserve ranges if the above registers are not implemented. > > Signed-off-by: Marcel Apfelbaum Acked-by: Michael S. Tsirkin > --- > src/fw/pciinit.c | 9 ++--- > src/hw/pc

[Qemu-devel] [PATCH v3 01/12] qdict: Add qdict_join()

2014-04-10 Thread Max Reitz
This function joins two QDicts by absorbing one into the other. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Reviewed-by: Eric Blake --- include/qapi/qmp/qdict.h | 3 +++ qobject/qdict.c | 32 2 files changed, 35 insertions(+) diff --git a/incl

Re: [Qemu-devel] [PATCH v3 07/12] block/json: Add bdrv_co_get_block_status()

2014-04-10 Thread Max Reitz
On 10.04.2014 20:58, Benoît Canet wrote: The Thursday 10 Apr 2014 à 20:43:38 (+0200), Max Reitz wrote : Implement this function by passing it through to bs->file. Signed-off-by: Max Reitz --- block/json.c | 8 1 file changed, 8 insertions(+) diff --git a/block/json.c b/block/json.

Re: [Qemu-devel] [PATCH v3 07/12] block/json: Add bdrv_co_get_block_status()

2014-04-10 Thread Benoît Canet
The Thursday 10 Apr 2014 à 20:43:38 (+0200), Max Reitz wrote : > Implement this function by passing it through to bs->file. > > Signed-off-by: Max Reitz > --- > block/json.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/block/json.c b/block/json.c > index cb83780..dfeec81 100

Re: [Qemu-devel] [PATCH v3 05/12] block/json: Add functions for cache control

2014-04-10 Thread Benoît Canet
The Thursday 10 Apr 2014 à 20:43:36 (+0200), Max Reitz wrote : > Add passthrough functions for bdrv_aio_flush() and > bdrv_invalidate_cache(). > > Signed-off-by: Max Reitz > --- > block/json.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/block/json.c b/block/json.c

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-10 Thread Cole Robinson
On 04/10/2014 07:17 AM, Peter Maydell wrote: > So far I know of at least three fixes which should probably > go into 2.0: > * my fix for the configure stack-protector checks on MacOSX > * MST's pull request updating the ACPI test blobs > * MST says we need to update the hex files for ACPI too >

[Qemu-devel] [PATCH V6 2/2] hw/pci: check if pci2pci bridges implement optional limit registers

2014-04-10 Thread Marcel Apfelbaum
pair and pair are both optional. Do not reserve ranges if the above registers are not implemented. Signed-off-by: Marcel Apfelbaum --- src/fw/pciinit.c | 9 ++--- src/hw/pci.c | 26 ++ src/hw/pci.h | 9 + 3 files changed, 37 insertions(+), 7 deleti

[Qemu-devel] [PATCH V6 0/2] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-10 Thread Marcel Apfelbaum
v5 -> v6: - Minor, fixed a typo in the subject v4 -> v5 - Addressed Michael S. Tsirkin's comments (patch 2/2): - Open-coded pci_config_is_reserved() method. v3 -> v4: - Addressed Kevin O'Connor's comments: - Refactored a for loop in patch 1/2. - Addressed Michael S. Tsirkin's comments (

[Qemu-devel] [PATCH V6 1/2] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-10 Thread Marcel Apfelbaum
If a pci-2-pci bridge supports hot-plug functionality but there are no devices connected to it, reserve IO/mem in order to be able to attach devices later. Do not waste space, use minimum allowed. Reviewed-by: Michael S. Tsirkin Signed-off-by: Marcel Apfelbaum --- src/fw/pciinit.c | 3 +++ src

[Qemu-devel] [PATCH v3 12/12] iotests: Add test for the JSON protocol

2014-04-10 Thread Max Reitz
Add a test for the JSON protocol driver. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- tests/qemu-iotests/089 | 123 + tests/qemu-iotests/089.out | 39 ++ tests/qemu-iotests/group | 1 + 3 files changed, 163 insertions(+)

Re: [Qemu-devel] qemu 2.0.0-rc2 crash

2014-04-10 Thread Marcel Apfelbaum
On Thu, 2014-04-10 at 14:38 -0400, Cole Robinson wrote: > On 04/10/2014 02:15 PM, Cole Robinson wrote: > > On 04/10/2014 12:39 PM, Marcel Apfelbaum wrote: > >> On Thu, 2014-04-10 at 18:24 +0200, Marcin Gibuła wrote: > >>> W dniu 2014-04-10 15:43, Marcel Apfelbaum pisze: > On Thu, 2014-04-10 at

[Qemu-devel] [PATCH v3 10/12] block/raw_bsd: Add bdrv_get_specific_info()

2014-04-10 Thread Max Reitz
Add a passthrough function for bdrv_get_specific_info(). Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/raw_bsd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 01ea692..e93ccd3 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @

[Qemu-devel] [PATCH v3 11/12] block/qapi: Ignore filters on top for format name

2014-04-10 Thread Max Reitz
bdrv_query_image_info() currently deduces the image filename and the format name from the top BDS. However, it is probably more reasonable to ignore as many filters as possible on top of the BDS chain since those neither change the type nor the filename of the underlying image. Filters like quorum

[Qemu-devel] [PATCH for-2.0] qom: Fix crash with qom-list and link properties

2014-04-10 Thread Cole Robinson
Commit 9561fda8d90e176bef598ba87c42a1bd6ad03ef7 changed the type of 'opaque' for link properties, but missed updating this call site. Reproducer: ./x86_64-softmmu/qemu-system-x86_64 -qmp unix:./qmp.sock,server & ./scripts/qmp/qmp-shell ./qmp.sock (QEMU) qom-list path=//machine/i440fx/pci.0/child[2

[Qemu-devel] [PATCH v3 07/12] block/json: Add bdrv_co_get_block_status()

2014-04-10 Thread Max Reitz
Implement this function by passing it through to bs->file. Signed-off-by: Max Reitz --- block/json.c | 8 1 file changed, 8 insertions(+) diff --git a/block/json.c b/block/json.c index cb83780..dfeec81 100644 --- a/block/json.c +++ b/block/json.c @@ -110,6 +110,13 @@ static coroutine_f

[Qemu-devel] [PATCH v3 09/12] block/json: Add bdrv_get_specific_info()

2014-04-10 Thread Max Reitz
Add a passthrough function for bdrv_get_specific_info(). Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/json.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/json.c b/block/json.c index 0c7d90d..d9348bc 100644 --- a/block/json.c +++ b/block/json.c @@ -181,6 +181,1

[Qemu-devel] [PATCH v3 06/12] block/json: Add functions for writing zeroes etc.

2014-04-10 Thread Max Reitz
Add passthrough functions for bdrv_aio_discard(), bdrv_co_write_zeroes(), bdrv_truncate() and bdrv_has_zero_init(). Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/json.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/block/json.c b/block/json.c

[Qemu-devel] [PATCH v3 08/12] block/json: Add ioctl etc.

2014-04-10 Thread Max Reitz
Add passthrough functions for bdrv_aio_ioctl(), bdrv_is_inserted(), bdrv_media_changed(), bdrv_eject(), bdrv_lock_medium() and bdrv_ioctl(). Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/json.c | 40 1 file changed, 40 insertions(+) diff

[Qemu-devel] [PATCH v3 05/12] block/json: Add functions for cache control

2014-04-10 Thread Max Reitz
Add passthrough functions for bdrv_aio_flush() and bdrv_invalidate_cache(). Signed-off-by: Max Reitz --- block/json.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/json.c b/block/json.c index 591bc47..0e2d518 100644 --- a/block/json.c +++ b/block/json.c @@ -88,6 +88,

Re: [Qemu-devel] qemu 2.0.0-rc2 crash

2014-04-10 Thread Cole Robinson
On 04/10/2014 02:15 PM, Cole Robinson wrote: > On 04/10/2014 12:39 PM, Marcel Apfelbaum wrote: >> On Thu, 2014-04-10 at 18:24 +0200, Marcin Gibuła wrote: >>> W dniu 2014-04-10 15:43, Marcel Apfelbaum pisze: On Thu, 2014-04-10 at 14:55 +0200, Marcin Gibuła wrote: > Hi, > > I've been

Re: [Qemu-devel] qemu 2.0.0-rc2 crash

2014-04-10 Thread Cole Robinson
On 04/10/2014 02:15 PM, Cole Robinson wrote: > On 04/10/2014 12:39 PM, Marcel Apfelbaum wrote: >> On Thu, 2014-04-10 at 18:24 +0200, Marcin Gibuła wrote: >>> W dniu 2014-04-10 15:43, Marcel Apfelbaum pisze: On Thu, 2014-04-10 at 14:55 +0200, Marcin Gibuła wrote: > Hi, > > I've been

Re: [Qemu-devel] [PATCH 1/1] kvm_physical_sync_dirty_bitmap: ignore ENOENT from kvm_vm_ioctl

2014-04-10 Thread Serge Hallyn
Quoting Michael Tokarev (m...@tls.msk.ru): > 09.04.2014 07:21, Serge Hallyn wrote: > > ENOENT (iiuc) means the kernel has an empty dirty bitmap for this > > slot. Don't abort in that case. This appears to solve the bug > > reported at > > > > https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1

Re: [Qemu-devel] [PATCH V4 2/2] hw/pci: check if pci2pci bridges implement optional limit registers

2014-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2014 at 08:44:18PM +0300, Marcel Apfelbaum wrote: > pair and > pair > are both optional. > Do not reserve ranges if the above registers are not implemented. > > Signed-off-by: Marcel Apfelbaum > --- > src/fw/pciinit.c | 9 ++--- > src/hw/pci.c | 34

[Qemu-devel] [PATCH V5 2/2] hw/pci: check if pci2pci bridges implement optional limit registers

2014-04-10 Thread Marcel Apfelbaum
pair and pair are both optional. Do not reserve ranges if the above registers are not implemented. Signed-off-by: Marcel Apfelbaum --- src/fw/pciinit.c | 9 ++--- src/hw/pci.c | 26 ++ src/hw/pci.h | 9 + 3 files changed, 37 insertions(+), 7 deleti

[Qemu-devel] [PATCH V5 1/2] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-10 Thread Marcel Apfelbaum
If a pci-2-pci bridge supports hot-plug functionality but there are no devices connected to it, reserve IO/mem in order to be able to attach devices later. Do not waste space, use minimum allowed. Reviewed-by: Michael S. Tsirkin Signed-off-by: Marcel Apfelbaum --- src/fw/pciinit.c | 3 +++ src

[Qemu-devel] [SeaBIOS [PATCH V5 0/2] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-10 Thread Marcel Apfelbaum
v4 -> v5 - Addressed Michael S. Tsirkin's comments (patch 2/2): - Open-coded pci_config_is_reserved() method. v3 -> v4: - Addressed Kevin O'Connor's comments: - Refactored a for loop in patch 1/2. - Addressed Michael S. Tsirkin's comments (patch 2/2): - Removed not needed method - T

[Qemu-devel] [PATCH v3 4/5] qemu-img: Specify backing file for commit

2014-04-10 Thread Max Reitz
Introduce a new parameter for qemu-img commit which may be used to explicitly specify the backing file into which an image should be committed if the backing chain has more than a single layer. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Fam Zheng --- qemu-img-cmds.hx | 4 ++

  1   2   3   >