Use the FIFO API to factor out the ring buffer implementation code.
Cleans up the somewhat verbose VMS description as well (version bump
required).
Signed-off-by: Peter Crosthwaite
---
hw/ssi/pl022.c | 101 -
1 file changed, 42 insertions(
Add support for 16, 32 and 64 bit width FIFOs. The push and pop
functions are replicated to accept all four different integer types.
The element width of the FIFO is set at creation time.
The backing storage for all element types is still uint8_t regardless of
element width so some save-load logic
To disentangle it from the monitor.
Signed-off-by: Peter Crosthwaite
---
hw/ssi/pl022.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ssi/pl022.c b/hw/ssi/pl022.c
index fd479ef..84bf87a 100644
--- a/hw/ssi/pl022.c
+++ b/hw/ssi/pl022.c
@@ -14,7 +14,7 @@
#ifdef DEBUG_P
Generalise the names of the FIFO API to not include the "8".
The exception is the push/pop functions for which we:
s/fifo8_pop/fifo_pop8
s/fifo8_push/fifo_push8
This prepares support for generalising FIFO support to more integer
widths. Most APIs will just share name and implementation. The push
There is a utility helper for dealing with 8 bit fifos. This should be
applicable to other integer widths as well. These two patches
generalise this FIFO to work for 16, 32 and 64 bit ints.
changed since v2:
Glueified hot paths to increase performance.
Addressed various minor review comments.
Add
On Wed, 04/09 22:41, Jeff Cody wrote:
> The new functionality of common.qemu implements the QEMU control
> and communication functionality that was originally in test 085.
>
> This removes that now-duplicate functionality, and uses the
> common.qemu functions.
>
Just a note.
A quick grep shows
After some additional investigating it looks like the XML format for the
trusty machine has changed. I created a new VM and got it to boot off my
MAAS cluster, The immediate change I see is:
new:
hvm
old:
hvm
None of the old XML machines were updated with this new machine flag.
--
You
Public bug reported:
I've created several kvm based machines using virtual machine manager.
They have operated well over the last 4 days without issue. I did an
apt-get upgrade, and qemu was in the list of updates.
After upgrading, I am unable to start any of the provisioned virtual
machines with
On Wed, 04/09 22:41, Jeff Cody wrote:
> This is an initial, simple live migration test from one
> running VM to another, using monitor commands.
>
> This is also an example on using the new common.qemu functions
> for controlling multiple running qemu instances, for tests that
> need a live qemu v
kvm.git + qemu.git:7cbb39d4_5913815a
after use "stop" , then migrate "exec:dd of=test.img", the test.img is about
250M, running time of save guest is less than 450s.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-m
On Wed, 04/09 22:41, Jeff Cody wrote:
> This creates some common functions for bash language qemu-iotests
> to control, and communicate with, a running QEMU process.
>
> 4 functions are introduced:
>
> 1. _launch_qemu()
> This launches the QEMU process(es), and sets up the file
>
Thanks for reporting this bug. We briefly had a 'trusty' machine type,
with a corresponding libvirt patch to handle it. When we renamed the
trusty machine type we dropped the libvirt patch to handle it.
We should either re-introduce the libvirt patch to handle the trusty
machine type for those w
Public bug reported:
calling the memsave function through hmp and qmp makes a different
results. it happened because hmp_memsave calls synchronization of cpu,
but qmp_marshal_input_memsave does not. so virDomainMemoryPeek (libvirt
api) does not work correctly
1) hmp:
void hmp_memsave(Monitor *mon
2014-04-08 9:31 GMT+08:00 Leandro Dorileo :
> On Thu, Apr 03, 2014 at 05:54:20PM +0800, Chunyan Liu wrote:
> > Add def_value_str (default value) to QemuOptDesc, to replace function of
> the
> > default value in QEMUOptionParameter.
> >
> > Improve qemu_opts_get_* functions: if find opt, return opt
2014-04-08 9:12 GMT+08:00 Leandro Dorileo :
> On Thu, Apr 03, 2014 at 05:54:18PM +0800, Chunyan Liu wrote:
> > This patch series is to replace QEMUOptionParameter with QemuOpts, so
> that only
> > one Qemu Option structure is kept in QEMU code.
> >
> > ---
> > Changes to v23:
> > * Improve conve
This drops BlockDriverState.in_use with op_blockers:
- Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1).
- Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0).
- Check bdrv_op_is_blocked() in place of bdrv_in_use(bs).
The specific types are used, e.g. in place of startin
Dropping intermediate could be useful both for commit and stream, and
BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs
to work with op blockers.
Signed-off-by: Fam Zheng
---
block.c| 139 -
block/commit.c |
On Thu, Apr 10, 2014 at 9:57 AM, Andy Lutomirski wrote:
> On Wed, Apr 9, 2014 at 4:53 PM, Peter Crosthwaite
> wrote:
>> Hi Andy,
>>
>> On Thu, Apr 10, 2014 at 5:55 AM, Andy Lutomirski wrote:
>>> Currently, -M q35 boots linux quite a bit slower than the default
>>> machine type. This seems to be
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX
elements. Each list is a list of blockers of an operation type
(BlockOpType), that marks this BDS as currently blocked for a certain
type of operation with reason errors stored in the list. The rule of
usage is:
* BDS user w
Signed-off-by: Fam Zheng
---
blockdev.c | 48
qapi-schema.json | 3 +++
2 files changed, 51 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index f241455..8a6ae0a 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1409,6 +1409,49 @@ static voi
Drive backup is a read only operation on source bs. We want to allow
this specific case to enable image-fleecing. Note that when
image-fleecing job starts, the job still add its blocker to source bs,
and any other operation on it will be blocked by that.
Signed-off-by: Fam Zheng
---
block.c | 2
It makes no sense to check for "any" blocker on bs, we are here only
because of the mechanical conversion from in_use to op_blockers. Remove
it now, and let the callers check specific operation types. Backup and
mirror already have it, add checker to stream and commit.
Signed-off-by: Fam Zheng
Re
Signed-off-by: Fam Zheng
---
block/mirror.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 22ec5be..c3d819e 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -490,14 +490,10 @@ immediate_exit:
if (bdrv_get_flags(s->t
This applies cases on drive-backup on blockdev-backup, except cases with
target format and mode.
Also add a case to check source == target.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/055 | 275 ++---
tests/qemu-iotests/055.out | 4 +-
2 files c
This tests the workflow of creating a lightweight point-in-time snapshot
with blockdev-backup command, and exporting it with built-in NBD server.
It's tested that any post-snapshot writing to the original device
doesn't change data seen in NBD target.
Signed-off-by: Fam Zheng
---
tests/qemu-iot
Similar to drive-backup, but this command uses a device id as target
instead of creating/opening an image file.
Also add blocker on target bs, since the target is also a named device
now.
Add check and report error for bs == target which became possible but is
an illegal case with introduction of
This makes use of op_blocker and blocks all the operations except for
commit target, on each BlockDriverState->backing_hd.
The asserts for op_blocker in bdrv_swap are removed because with this
change, the target of block commit has at least the backing blocker of
its child, so the assertion is not
Now it's safe to allow reference for backing_hd in the interface.
Signed-off-by: Fam Zheng
---
block.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 6f803fa..beacf09 100644
--- a/block.c
+++ b/block.c
@@ -1401,12 +1401,35
This reuses the new bdrv_drop_intermediate.
Signed-off-by: Fam Zheng
---
block/stream.c | 42 +-
1 file changed, 1 insertion(+), 41 deletions(-)
diff --git a/block/stream.c b/block/stream.c
index dd0b4ac..1b348a2 100644
--- a/block/stream.c
+++ b/block/st
This adds the enum of all the operations that can be taken on a block
device.
Signed-off-by: Fam Zheng
Reviewed-by: Benoit Canet
Reviewed-by: Jeff Cody
---
include/block/block.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/include/block/block.h b/include/block/block
v18: Address reviewing comments from Jeff and Eric. Rebased to current master.
Side by side diff from v17: http://bit.ly/1oO2Fvt
[01/15] block: Add BlockOpType enum
Add Jeff's reviewed-by.
[02/15] block: Introduce op_blockers to BlockDriverState
Ad
This is the common but non-trivial steps to assign or change the
backing_hd of BDS.
Signed-off-by: Fam Zheng
---
block.c | 37 +++--
include/block/block.h | 1 +
2 files changed, 24 insertions(+), 14 deletions(-)
diff --git a/block.c b/block.c
inde
Both tests 019 and 086 need proper quotations to work with pathnames
that contain spaces.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/019 | 2 +-
tests/qemu-iotests/086 | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/019 b/tests/qemu-iotests/01
The new functionality of common.qemu implements the QEMU control
and communication functionality that was originally in test 085.
This removes that now-duplicate functionality, and uses the
common.qemu functions.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/085 | 73 +
This is an initial, simple live migration test from one
running VM to another, using monitor commands.
This is also an example on using the new common.qemu functions
for controlling multiple running qemu instances, for tests that
need a live qemu vm.
Signed-off-by: Jeff Cody
---
tests/qemu-iote
Changes from v1:
Patch 1: * Fixed commit message, clarified comments (Thanks Benoît)
* Changed 'shift' line to be POSIX-friendly, instead of
relying on bashism (Thanks Eric)
* Added ability to repeat qmp or hmp commands an arbitrary
numbe
The _rm_test_img() function in common.rc did not quote the image
file, which left droppings in the scratch directory (and performed
a potentially unsafe rm -f).
This adds the necessary quotes.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/common.rc | 4 ++--
1 file changed, 2 insertions(+), 2
This creates some common functions for bash language qemu-iotests
to control, and communicate with, a running QEMU process.
4 functions are introduced:
1. _launch_qemu()
This launches the QEMU process(es), and sets up the file
descriptors and fifos for communication. You can
On Wed, 04/09 14:29, Jeff Cody wrote:
> On Mon, Mar 10, 2014 at 03:26:02PM +0800, Fam Zheng wrote:
> > This makes use of op_blocker and blocks all the operations except for
> > commit target, on each BlockDriverState->backing_hd.
> >
> > The asserts for op_blocker in bdrv_swap are removed because
> On Wed, Apr 09, 2014 at 10:56:57AM +, Gonglei (Arei) wrote:
> > Hi,
> >
> > > > QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in
> > > > assigned_dev_register_msix_mmio(), meanwhile the set the one
> > > > page memmory to zero, so the rest memory will be random value
> > > > (maybe
On Mon, 04/07 15:11, Eric Blake wrote:
> On 03/10/2014 01:26 AM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng
> > ---
> > blockdev.c | 48
> > qapi-schema.json | 1 +
> > 2 files changed, 49 insertions(+)
> >
>
> > +++ b/qapi-schema.json
> On 04/03/14 07:18, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in
> > assigned_dev_register_msix_mmio(), meanwhile the set the one
> > page memmory to zero, so the rest memory will be random value
> > (maybe etnry.data is not
On Mon, 03/17 21:24, Jeff Cody wrote:
> +# Launch a QEMU process.
> +#
> +# Input parameters:
> +# $qemu_comm_method: set this variable to 'monitor' (case insensitive)
> +#to use the QEMU HMP monitor for communication.
> +#Otherwise, the default of QMP is use
Signed-off-by: Fam Zheng
---
block/iscsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 64a509f..f425573 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1233,6 +1233,7 @@ static int iscsi_open(BlockDriverState *bs, QDict
*options, int flags,
isc
On Wed, Apr 9, 2014 at 6:02 PM, Markus Armbruster wrote:
> Alistair Francis writes:
>
>> On Wed, Apr 9, 2014 at 11:28 AM, Peter Crosthwaite
>> wrote:
>>> On Wed, Mar 26, 2014 at 10:47 AM, Alistair Francis
>>> wrote:
This patch introduces a new command line argument that allows
sysbus
On Wed, Apr 9, 2014 at 4:53 PM, Peter Crosthwaite
wrote:
> Hi Andy,
>
> On Thu, Apr 10, 2014 at 5:55 AM, Andy Lutomirski wrote:
>> Currently, -M q35 boots linux quite a bit slower than the default
>> machine type. This seems to be because it takes a few hundred ms to
>> determine that there's no
Hi Andy,
On Thu, Apr 10, 2014 at 5:55 AM, Andy Lutomirski wrote:
> Currently, -M q35 boots linux quite a bit slower than the default
> machine type. This seems to be because it takes a few hundred ms to
> determine that there's nothing attached to the AHCI controller.
>
> In virtio setups, there
On Tue, Apr 08, 2014 at 06:52:39PM -0700, Peter Crosthwaite wrote:
> From: Nathan Rossi
>
> Clear the BMCR Reset when writing to registers.
>
> Signed-off-by: Nathan Rossi
> [ PC:
> * Trivial style fixes to commit message
> ]
> Signed-off-by: Peter Crosthwaite
> ---
>
> hw/net/xilinx_axiene
Older Intel manuals (pre-2010) describe Z as undefined, but AMD and
newer Intel manuals describe Z as unchanged.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 40 +++-
1 file changed, 31 insertions(+), 9 deletions(-)
---
Clemens, your patch f
On Thu, Apr 03, 2014 at 11:55:19PM -0700, Peter Crosthwaite wrote:
> Phys must respond to address 0 by specification. Implement.
>
> Signed-off-by: Nathan Rossi
> Signed-off-by: Peter Crosthwaite
> ---
>
> hw/net/cadence_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> di
> Am 09.04.2014 um 21:33 schrieb Tom Musta :
>
>> On 4/8/2014 2:58 PM, Alexander Graf wrote:
>>> On 04/08/2014 09:56 PM, Tom Musta wrote:
>>> On 4/6/2014 3:55 PM, Alexander Graf wrote:
>>>
>>>
@@ -806,6 +838,10 @@ clk_setup_cb cpu_ppc_tb_init (CPUPPCState *env,
uint32_t freq)
Currently, -M q35 boots linux quite a bit slower than the default
machine type. This seems to be because it takes a few hundred ms to
determine that there's nothing attached to the AHCI controller.
In virtio setups, there will probably never be anything attached to
the AHCI controller. Would it
Fix disassembly in the QEMU monitor for Little Endian codes. Also fix the
comment
and tighten up a flag check in the closely related disassembler code for
tracing.
V2: Fixed target_disas comment and bit decoding.
V3: Make monitor_disas flag documentation refer to target_disas documentation.
V4:
The monitor support for disassembling instructions does not honor the MSR[LE]
bit for PowerPC processors.
This change enhances the monitor_disas() routine by supporting a flag bit
for Little Endian mode. Bit 16 is used since that bit was used in the
analagous guest disassembly routine target_disa
Inspect only bit 16 for the Little Endian test. Correct comment preceding
the target_disas() function. Correct grammar in comment for flags processing.
Signed-off-by: Tom Musta
Reviewed-by: Peter Maydell
---
V4: Correct grammar "definitions of the instructions set" ==> "definition of
the instr
On 4/8/2014 2:58 PM, Alexander Graf wrote:
> On 04/08/2014 09:56 PM, Tom Musta wrote:
>> On 4/6/2014 3:55 PM, Alexander Graf wrote:
>>
>>
>>> @@ -806,6 +838,10 @@ clk_setup_cb cpu_ppc_tb_init (CPUPPCState *env,
>>> uint32_t freq)
>>> tb_env = g_malloc0(sizeof(ppc_tb_t));
>>> env->tb_e
This bug was fixed in the package qemu - 2.0.0~rc1+dfsg-0ubuntu3
---
qemu (2.0.0~rc1+dfsg-0ubuntu3) trusty; urgency=medium
* d/p/ubuntu/kvm_physical_sync_dirty_bitmap-ignore-ENOENT-from-kv.patch
don't abort() just because the kernel has no dirty bitmap.
(LP: #1303926)
-- Se
On Mon, Mar 10, 2014 at 03:26:02PM +0800, Fam Zheng wrote:
> This makes use of op_blocker and blocks all the operations except for
> commit target, on each BlockDriverState->backing_hd.
>
> The asserts for op_blocker in bdrv_swap are removed because with this
> change, the target of block commit h
On Tue, Apr 08, 2014 at 05:07:38PM +0800, Fam Zheng wrote:
> On Tue, 04/08 10:15, Markus Armbruster wrote:
> > Jeff Cody writes:
> >
> > > On Mon, Mar 10, 2014 at 03:26:04PM +0800, Fam Zheng wrote:
> > >> Dropping intermediate could be useful both for commit and stream, and
> > >> BDS refcnt plus
Hi,
quick follow-up. *As always* you find a problem right after asking for help
:). The updated patch does not cause BSOD on Windows guests, but neither
does it fix the actual problem (of the program seg-faulting)
I would really appreciate any feedback on the proposed patch below - the
difference
I found this could be useful to have qemu-softmmu as a cross debugger (launch
with -s -S command line option), then if we can have a command to load guest
physical memory, we can use cross gdb to do some target debug which gdb cannot
do directly.
Many thanks to Eric Blake for review the patch and
No need to go through qemu_machine field. Use
MachineClass fields directly.
Signed-off-by: Marcel Apfelbaum
---
device-hotplug.c| 2 +-
hw/ppc/spapr.c | 26 --
include/hw/boards.h | 1 -
qmp.c | 4 +--
vl.c| 79 ---
In order to eliminate the QEMUMachine indirection,
add its fields directly to MachineClass.
Do not remove yet qemu_machine field because it is
still in use by sparpr.
Signed-off-by: Marcel Apfelbaum
---
include/hw/boards.h | 23 +++
vl.c| 23 ++
This field shouldn't be used any more since we
adopted the QOM way of iterating over the types.
The commit that obsoleted it is:
commit 261747f176f6f2d88f8268aaebfdd1a1afe887e2
vl: Use MachineClass instead of global QEMUMachine list
The machine registration flow is refactored to use the Q
QEMUMachine's fields are already in MachineClass. We can safely
make the switch because we copy them in machine_class_init.
Signed-off-by: Marcel Apfelbaum
---
include/hw/boards.h | 5 +++--
vl.c| 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/hw/boa
Cc: Andreas Färber
V2 -> V3:
- Addressed Andreas's comments:
- Dropped QEMUMachineInitArgs's 'next' obsoleted field
in a separate patch
- Revision the separation into patches:
- Started using MachineClass for .machine early (3/5).
- Merged hw/ppc changes with QEMUMachi
This minimizes QEMUMachine usage, as part of machine QOM-ification.
Signed-off-by: Marcel Apfelbaum
---
include/hw/xen/xen.h| 2 +-
include/qemu/typedefs.h | 1 +
include/sysemu/kvm.h| 2 +-
include/sysemu/qtest.h | 2 +-
kvm-all.c | 6 +++---
kvm-stub.c
Hi guys,
I have to revive a rather old thread [1,2]. A quick summary of the issue:
TCG emulates the BT (bit-test) instruction using a SAR to re-compute
eflags. While SAR affects all flags, BT only affects the C-flag and leaves
the Z-flag unaffected/unchanged [3].
According to the x86 manual, the
Hi All,
I am new to qemu-kvm.But have good knowledge about virtulization and cloud
computing.I would like to do some projects in qemu-kvm.Please let me know
how can I start.
Please suggest me some small projects which I can take up and finish in 2-3
weeks.
Regards,
Pradeep
* Markus Armbruster (arm...@redhat.com) wrote:
> I stumbled over this while trying to purge error_is_set() from the code.
> Here's how we commonly use the Error API:
>
> Error *err = NULL;
>
> foo(arg, &err)
> if (err) {
> goto out;
> }
> bar(arg, &err)
> if (err)
On 04/09/2014 05:54 AM, Claudio Fontana wrote:
> During testing I found this patch causes a regression for big endian targets
> (sparc).
>
> Can you take a look?
> I think it might be related to the extended form of the REV instruction
> needing
> an additional 0x400. See below.
You're right.
Thanks Eric's analysis and review firstly. As not so clear to the application
context, so the first patch can not cover symlink scenarios.
In this patch, will check the backing_filename is a symlink or not firstly,
then return the full(absolute) path via realpath.
If this patch has something not
On 04/09/2014 01:12 AM, Hu Tao wrote:
> This patch prepares for the subsequent patches.
>
> Reviewed-by: Fam Zheng
> Signed-off-by: Hu Tao
> ---
> block/qcow2.c| 8
> qapi-schema.json | 14 ++
> 2 files changed, 18 insertions(+), 4 deletions(-)
>
> +++ b/qapi-schema.
On 04/09/2014 10:54 AM, Baojun Wang wrote:
> Signed-off-by: Baojun Wang
You lost this part of your commit message, which gives more details
about the 'why' (the subject line covers the 'what', but it is often the
'why' that is most needed when reviewing a commit later). Your earlier
mail had:
I
Signed-off-by: Baojun Wang
---
cpus.c | 29 +
hmp-commands.hx | 13 +
hmp.c| 11 +++
hmp.h| 1 +
qapi-schema.json | 18 ++
qmp-commands.hx | 27 +++
6 files changed, 99 ins
On Wed, Apr 9, 2014 at 8:48 AM, Markus Armbruster wrote:
> I stumbled over this while trying to purge error_is_set() from the code.
>
>
> Here's how we commonly use the Error API:
>
> Error *err = NULL;
>
> foo(arg, &err)
> if (err) {
> goto out;
> }
> bar(arg, &err)
>
On 04/09/2014 09:48 AM, Markus Armbruster wrote:
> I stumbled over this while trying to purge error_is_set() from the code.
>
> But: is it a good idea to have both patterns in the code? Should we
> perhaps use the common pattern for visiting, too? Like this:
>
> visit_type_str(v, &foo, "fo
On Wed, 9 Apr 2014 17:53:40 +0200
Alexander Graf wrote:
>
>
> > Am 09.04.2014 um 17:35 schrieb Cornelia Huck :
> >
> > On Wed, 09 Apr 2014 16:30:33 +0200
> > Alexander Graf wrote:
> >
> >>
> >>> On 09.04.14 16:24, Cornelia Huck wrote:
> >>> On Wed, 09 Apr 2014 16:05:00 +0200
> >>> Alexander
This is an RFC about QEMU VFIO platform device implementation.
This work aims at enabling KVM platform device passthrough,
where a guest OS is directly assigned a platform device: meaning
it can access the register space without trapping, and receive IRQ
from the device. Also the system MMU downstr
> Am 09.04.2014 um 17:35 schrieb Cornelia Huck :
>
> On Wed, 09 Apr 2014 16:30:33 +0200
> Alexander Graf wrote:
>
>>
>>> On 09.04.14 16:24, Cornelia Huck wrote:
>>> On Wed, 09 Apr 2014 16:05:00 +0200
>>> Alexander Graf wrote:
>>>
> On 09.04.14 13:34, Cornelia Huck wrote:
> Register
I stumbled over this while trying to purge error_is_set() from the code.
Here's how we commonly use the Error API:
Error *err = NULL;
foo(arg, &err)
if (err) {
goto out;
}
bar(arg, &err)
if (err) {
goto out;
}
This ensures that err is null on entry,
On Wed, 09 Apr 2014 16:30:33 +0200
Alexander Graf wrote:
>
> On 09.04.14 16:24, Cornelia Huck wrote:
> > On Wed, 09 Apr 2014 16:05:00 +0200
> > Alexander Graf wrote:
> >
> >> On 09.04.14 13:34, Cornelia Huck wrote:
> >>> Register an I/O adapter interrupt source for when virtio-ccw devices start
this patch brings misc improvements:
- improve comments
- remove interrupt field in VFIODevice
- add IRQ disable routines used by new exitfn function
Signed-off-by: Eric Auger
---
hw/vfio/platform.c | 167 -
1 file changed, 127 insertions(+), 4
This work is inspired of PCI INTx. The code was prepared to support
multiple IRQs but this was not tested at that stage. Similarly to what
is done on PCI, the device register space is RAM unmapped on IRQ hit
in order to trap the end of interrupt (EOI). On mmap timer hit, if the
EOI was trapped, the
From: Kim Phillips
This is done in preparation for the addition of VFIO platform
device support.
Signed-off-by: Kim Phillips
---
LICENSE| 2 +-
MAINTAINERS| 2 +-
hw/Makefile.objs | 1 +
hw/misc/Makefile.objs | 1 -
hw/vfio/Mak
This patch aims at allowing the end-user to specify the device he
wants to directly assign to his virt VM in the QEMU command line.
The QEMU platform device becomes generic.
Current choice is to reuse the "-device" option.
For example when assigning Calxeda Midway xgmac device this option is
used
From: Kim Phillips
Functions for which PCI and platform device support share are moved
into common.c. The common vfio_{get,put}_group() get an additional
argument, a pointer to a vfio_reset_handler(), for which to pass on to
qemu_register_reset, but only if it exists (the platform device code
cu
From: Kim Phillips
This is a hack and only serves as an example of what needs to be
done to make the next RFC - add vfio-platform support - work
for development purposes on a Calxeda Midway system. We don't want
mach-virt to always create this ethernet device - DO NOT APPLY, etc.
Initial attemp
The following changes since commit efcc87d9aedb590b8506cd1a7c8abe557c760f9e:
Update version for v2.0.0-rc2 release (2014-04-08 18:52:06 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up to 50329d34
commit f2ccc311df55ec026a8f8ea9df998f26314f22b2
dsdt: tweak ACPI ID for hotplug resource device
changes the DSDT, update test expected files to match
Signed-off-by: Michael S. Tsirkin
Reported-by: Igor Mammedov
---
tests/acpi-test-data/pc/DSDT | Bin 4485 -> 4480 bytes
tests/acpi-test-data
On 09.04.14 16:24, Cornelia Huck wrote:
On Wed, 09 Apr 2014 16:05:00 +0200
Alexander Graf wrote:
On 09.04.14 13:34, Cornelia Huck wrote:
Register an I/O adapter interrupt source for when virtio-ccw devices start
using adapter interrupts.
Reviewed-by: Thomas Huth
Signed-off-by: Cornelia Huc
On Wed, 09 Apr 2014 16:05:00 +0200
Alexander Graf wrote:
>
> On 09.04.14 13:34, Cornelia Huck wrote:
> > Register an I/O adapter interrupt source for when virtio-ccw devices start
> > using adapter interrupts.
> >
> > Reviewed-by: Thomas Huth
> > Signed-off-by: Cornelia Huck
> > ---
> > hw/i
On Wed, 09 Apr 2014 15:58:55 +0200
Alexander Graf wrote:
>
> On 09.04.14 13:34, Cornelia Huck wrote:
> > Provide helper functions for enabling capabilities (on a vcpu and on a vm).
> >
> > Reviewed-by: Thomas Huth
> > Signed-off-by: Cornelia Huck
>
> I think it makes sense to convert all ENAB
On Thu, Apr 03, 2014 at 01:18:23PM +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> when map MSI-X table memory failed, the dev->msix_table not be
> set to NULL, the assigned_dev_unregister_msix_mmio() will case
> a segfault when munmap the failed dev->msix_table.
>
> Signed-off-by: Gon
On 04/03/14 07:18, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in
> assigned_dev_register_msix_mmio(), meanwhile the set the one
> page memmory to zero, so the rest memory will be random value
> (maybe etnry.data is not 0). In the as
On 09.04.14 13:34, Cornelia Huck wrote:
Register an I/O adapter interrupt source for when virtio-ccw devices start
using adapter interrupts.
Reviewed-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
hw/intc/s390_flic.c | 59 +
hw/s390x/cs
On 09.04.14 13:34, Cornelia Huck wrote:
Provide helper functions for enabling capabilities (on a vcpu and on a vm).
Reviewed-by: Thomas Huth
Signed-off-by: Cornelia Huck
I think it makes sense to convert all ENABLE_CAP callers of the code
base to this helper as well. Once you do that, you'
On Wed, Apr 09, 2014 at 10:56:57AM +, Gonglei (Arei) wrote:
> Hi,
>
> > > QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in
> > > assigned_dev_register_msix_mmio(), meanwhile the set the one
> > > page memmory to zero, so the rest memory will be random value
> > > (maybe etnry.data i
On 9 April 2014 13:42, Peter Crosthwaite wrote:
> Hi Peter,
>
> Im looking to do some cleanup around pl022 and I would like to use it
> as my lead example of code using the new generic FIFO (as I think I
> have test cases handy for it). But the VMSD description for this
> device is a bit ugly as i
On 04/09/14 13:14, Kevin Wolf wrote:
> The old check was off by a factor of 512 and didn't consider cases where
> we don't get an exact division. This could lead to an out-of-bounds
> array access in seek_to_sector().
>
> Signed-off-by: Kevin Wolf
> ---
> block/bochs.c | 14
1 - 100 of 144 matches
Mail list logo
