[Qemu-devel] [Bug 1297651] [NEW] KVM create a win7 guest with Qemu, it boots up fail

2014-03-25 Thread Robert Hu
Public bug reported: Environment: Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows):Windows kvm.git Commit:94b3ffcd41a90d2cb0b32ca23aa58a0d5dc0 qemu-kvm Commit:839a5547574e57cce62f49bfc50fe1f04b00589a Host Kernel Version:3.14.0-rc3 Hard

Re: [Qemu-devel] [PATCH v4 for 2.0] virtio-net: add vlan receive state to RxFilterInfo

2014-03-25 Thread Michael S. Tsirkin
On Wed, Mar 26, 2014 at 08:19:43AM +0800, Amos Kong wrote: > Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't > filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. Yes but that fix is unfortunately wrong as it tests guest_features on reset. How about p

Re: [Qemu-devel] [PATCH v23 08/32] add convert functions between QEMUOptionParameter to QemuOpts

2014-03-25 Thread Chunyan Liu
2014-03-26 5:35 GMT+08:00 Eric Blake : > On 03/21/2014 04:12 AM, Chunyan Liu wrote: > > Add two temp convert functions between QEMUOptionParameter to QemuOpts, > > s/convert/conversion/ here and in subject > > > so that next patch can use it. It will simplify later patch for easier > > review. And

[Qemu-devel] [PULL for 2.0] Support GTK without VTE

2014-03-25 Thread Stefan Weil
Hello Peter, I dropped the windows.h related patches from my last pull request. They are not needed for 2.0. This one is more important because it adds functionality for users of QEMU for Windows. Thanks Stefan The following changes since commit 7f6613cedc59fa849105668ae971dc31004bca1c: targe

[Qemu-devel] [PATCH] net: netmap_poll must update both read/write poll state

2014-03-25 Thread Stefan Hajnoczi
From: Prasad Joshi Signed-off-by: Prasad Joshi Signed-off-by: Stefan Hajnoczi --- net/netmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netmap.c b/net/netmap.c index 8213304..0c1772b 100644 --- a/net/netmap.c +++ b/net/netmap.c @@ -177,8 +177,8 @@ static void

Re: [Qemu-devel] [PATCH resend 0/3] QEMU/Xen: disentangle PV and HVM in QEMU

2014-03-25 Thread Paolo Bonzini
Il 25/03/2014 17:40, Stefano Stabellini ha scritto: > > Oops, sorry. I did this for first series but forgot about it when > resending. Updated diff stat attached. Much better, thanks. The patches are fine by me. Paolo, if you are OK with them, I'll send a pull request. I guess for 2.1? Or do

[Qemu-devel] [PATCH] uhci: Lower uhci timer freq when guest is idle

2014-03-25 Thread arei.gonglei
From: Gonglei UHCI emulation polls the device at a freq of 1000HZ, which consumes 12~13% CPU even though a Windows guest is completely idle when the guest was configed usb1.1 tablet devcie. This solution counts accumulated NAK packets. when it reaches to 64, then the guest is supposed to be idle

Re: [Qemu-devel] [PATCH v23 08/32] add convert functions between QEMUOptionParameter to QemuOpts

2014-03-25 Thread Chunyan Liu
2014-03-26 5:35 GMT+08:00 Eric Blake : > On 03/21/2014 04:12 AM, Chunyan Liu wrote: > > Add two temp convert functions between QEMUOptionParameter to QemuOpts, > > s/convert/conversion/ here and in subject > > > so that next patch can use it. It will simplify later patch for easier > > review. And

[Qemu-devel] [PATCH v1 1/1] zynq_slcr: Change the comma to a underscore

2014-03-25 Thread Alistair Francis
This patch changes the comma in the "xilinx,zynq_slcr" to an underscore. This matches every other xilinx* peripheral and also makes parsing the device via the command line possible. Signed-off-by: Alistair Francis --- hw/arm/xilinx_zynq.c |2 +- hw/misc/zynq_slcr.c |2 +- 2 files chang

Re: [Qemu-devel] [PATCH v23 07/32] add qemu_opts_print_help to replace print_option_help

2014-03-25 Thread Chunyan Liu
2014-03-26 4:43 GMT+08:00 Eric Blake : > On 03/21/2014 04:12 AM, Chunyan Liu wrote: > > print_option_help takes QEMUOptionParameter as parameter, add > > qemu_opts_print_help to take QemuOptsList as parameter for later > > replace work. > > > > Signed-off-by: Dong Xu Wang > > Signed-off-by: Chuny

Re: [Qemu-devel] [PATCH v4 20/21] target-arm: Add Cortex-A57 processor

2014-03-25 Thread Rob Herring
On Thu, Mar 6, 2014 at 1:33 PM, Peter Maydell wrote: > Add Cortex-A57 processor. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu64.c | 43 +++ > 1 file changed, 43 insertions(+) > > diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c > index d4fb1

[Qemu-devel] [PATCH] target-arm: support AArch32 ID registers in AArch64 mode

2014-03-25 Thread Rob Herring
From: Rob Herring ARMv8 has both AArch32 and AArch64 versions of ID registers. Both sets of registers are accessible in AArch64 state, but only . Update the definitions to allow AArch64 access. This fixes booting on recent (linux-next for 3.15) linux kernels which add access to ID_ISAR5. Signed

Re: [Qemu-devel] [PATCH 1/1] virtio-blk: Use a req pool instead of malloc/free

2014-03-25 Thread Li, ZhenHua
I am sorry that seems it was not sent out before I subscribed to the list. So I send this patch again. On 03/26/2014 10:02 AM, Li, Zhen-Hua wrote: From: "Li, ZhenHua" In virtio-blk module, when there is new request, new req structure will be created by malloc. Use a req pool instead of this,

[Qemu-devel] [PATCH 1/1] virtio-blk: Use a req pool instead of malloc/free

2014-03-25 Thread Li, Zhen-Hua
From: "Li, ZhenHua" In virtio-blk module, when there is new request, new req structure will be created by malloc. Use a req pool instead of this, will increase performance; Increacement: about 5% to 10%. Signed-off-by: Li, ZhenHua --- hw/block/virtio-blk.c | 87

Re: [Qemu-devel] [PATCH v4 for 2.0] virtio-net: add vlan receive state to RxFilterInfo

2014-03-25 Thread Eric Blake
On 03/25/2014 06:19 PM, Amos Kong wrote: > Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't > filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. > > This patch added a new field to @RxFilterInfo to indicate vlan receive > state ('normal', 'none', 'all

Re: [Qemu-devel] [PATCH] linux-user: Handle arches with llseek instead of _llseek

2014-03-25 Thread Jia Liu
Hi James, On Wed, Mar 26, 2014 at 5:51 AM, James Hogan wrote: > Recently merged kernel ports (such as OpenRISC and Meta) have an llseek > system call instead of _llseek. This is handled for the host > architecture by defining __NR__llseek as __NR_llseek, but not for the > target architecture. Th

[Qemu-devel] [PATCH v1 1/1] vl.c: Allow sysbus devices to be attached via commandline

2014-03-25 Thread Alistair Francis
This patch introduces a new command line argument that allows sysbus devices to be attached via the command line. This allows devices to be added after the machine init but before anything is booted The new argument is -sysbusdev A new argument is being used to avoid confusion and user errors th

Re: [Qemu-devel] [PATCH] linux-user: Correct DLINFO_ITEMS

2014-03-25 Thread James Hogan
On Tuesday 25 March 2014 23:51:39 Peter Maydell wrote: > On 25 March 2014 23:40, James Hogan wrote: > > I've already re-factored a bunch of this code to handle stacks which grow > > upwards (as used for HPPA and Meta arches) > > ...we don't support either of those currently, do you plan to submit

Re: [Qemu-devel] [PATCH v3 for 2.0] virtio-net: add vlan receive state to RxFilterInfo

2014-03-25 Thread Amos Kong
On Tue, Mar 25, 2014 at 10:24:33AM -0600, Eric Blake wrote: > On 03/25/2014 09:40 AM, Amos Kong wrote: > > Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't > > filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. > > > > This patch added a new field to

[Qemu-devel] [PATCH v4 for 2.0] virtio-net: add vlan receive state to RxFilterInfo

2014-03-25 Thread Amos Kong
Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. This patch added a new field to @RxFilterInfo to indicate vlan receive state ('normal', 'none', 'all'). If VIRTIO_NET_F_CTRL_VLAN isn't negotiated, vla

Re: [Qemu-devel] [PATCH] linux-user: Correct DLINFO_ITEMS

2014-03-25 Thread Peter Maydell
On 25 March 2014 23:40, James Hogan wrote: > I've already re-factored a bunch of this code to handle stacks which grow > upwards (as used for HPPA and Meta arches) ...we don't support either of those currently, do you plan to submit something? thanks -- PMM

Re: [Qemu-devel] [PATCH] linux-user: Correct DLINFO_ITEMS

2014-03-25 Thread James Hogan
On Tuesday 25 March 2014 22:20:04 Peter Maydell wrote: > On 25 March 2014 21:47, James Hogan wrote: > > Commit a07c67dfccb1 (Implement AT_CLKTCK.) back in March 2008 added a > > new auxvec entry but didn't increment DLINFO_ITEMS, so it's been out of > > sync ever since. > > > > Bump it up to 14 s

[Qemu-devel] [PATCH] linux-user: Assert stack used for auxvec, envp, argv

2014-03-25 Thread James Hogan
Assert that the amount of stack space used for auxvec, envp & argv exactly matches the amount allocated. This catches if DLINFO_ITEMS isn't updated when another NEW_AUX_ENT is added. Signed-off-by: James Hogan Cc: Riku Voipio Cc: Peter Maydell --- This should be applied after "linux-user: Corre

[Qemu-devel] [PATCH 0/5] remove QEMUMachine indirection from MachineClass

2014-03-25 Thread Marcel Apfelbaum
Note: this is a resend (I sent the series some time ago with no luck), sorry if you get this series twice. This is a continuation of 'QEMU Machine as QOM object' effort. The scope of this series is to allow machine QOM-ification of all machines gradually, by removing the need for QEMUMachine

Re: [Qemu-devel] [RFC]Two ideas to optimize updating irq routing table

2014-03-25 Thread Paolo Bonzini
Il 25/03/2014 04:19, Gonglei (Arei) ha scritto: Based on discussions in: http://lists.gnu.org/archive/html/qemu-devel/2013-11/threads.html#03322 About KVM_SET_GSI_ROUTING ioctl, I tested changing RCU to SRCU, but unfortunately it looks like SRCU's grace period is no better than RCU. Really?

Re: [Qemu-devel] [PATCH for-2.0] target-mips: fix MTHC1 and MFHC1 when FPU in FR=0 mode

2014-03-25 Thread Aurelien Jarno
On Tue, Mar 25, 2014 at 02:35:18PM +0100, Petar Jovanovic wrote: > From: Petar Jovanovic > > Previous implementation presumed that FPU registers are 64-bit and are > working in 64-bit mode. This change first checks MIPS_HFLAG_F64 and if not > set, it does load/store from the odd numbered register

Re: [Qemu-devel] [PATCH] linux-user: Correct DLINFO_ITEMS

2014-03-25 Thread Peter Maydell
On 25 March 2014 21:47, James Hogan wrote: > Commit a07c67dfccb1 (Implement AT_CLKTCK.) back in March 2008 added a > new auxvec entry but didn't increment DLINFO_ITEMS, so it's been out of > sync ever since. > > Bump it up to 14 so that it matches the number of NEW_AUX_ENT's that > need to be coun

[Qemu-devel] [RFC PATCH 13/16] BER Visitor: Create input visitor

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- include/qapi/qemu-file-ber-input-visitor.h | 26 + qapi/Makefile.objs |2 +- qapi/qemu-file-ber-input-visitor.c | 1163 3 files changed, 1190 insertions(+)

[Qemu-devel] Pause / Stop Notification on Guest display?

2014-03-25 Thread Erik Rull
Hi all, I would like to provide a possiblity to show the operator that his vm is currently not alive, but paused / stopped. Currently, I see this only when accessing the qemu monitor console. Is there a possibility to expose this information to the guest display so that the operator does not n

[Qemu-devel] [PATCH] linux-user: Handle arches with llseek instead of _llseek

2014-03-25 Thread James Hogan
Recently merged kernel ports (such as OpenRISC and Meta) have an llseek system call instead of _llseek. This is handled for the host architecture by defining __NR__llseek as __NR_llseek, but not for the target architecture. Handle it in the same way for these architectures, defining TARGET_NR__lls

[Qemu-devel] [PATCH] linux-user: Correct DLINFO_ITEMS

2014-03-25 Thread James Hogan
Commit a07c67dfccb1 (Implement AT_CLKTCK.) back in March 2008 added a new auxvec entry but didn't increment DLINFO_ITEMS, so it's been out of sync ever since. Bump it up to 14 so that it matches the number of NEW_AUX_ENT's that need to be counted in create_elf_tables(). Signed-off-by: James Hogan

Re: [Qemu-devel] [PATCH v23 10/32] check NULL input for qemu_opts_del

2014-03-25 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: > To simplify later using of qemu_opts_del, accept NULL input. > > Signed-off-by: Chunyan Liu > --- > util/qemu-option.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Eric Blake > > diff --git a/util/qemu-option.c b/util/qemu-option.c > i

Re: [Qemu-devel] [V2 PATCH] target-ppc: Bug: VSX Convert to Integer Should Truncate

2014-03-25 Thread Tom Musta
On 3/25/2014 1:06 PM, Peter Maydell wrote: > > Looking at this a little more closely, why aren't we > just using the _round_to_zero versions of the float > to int conversion softfloat functions? (This is how > we implement fctiwz vs fctiw, for instance.) > > thanks > -- PMM > Fair question, Pe

[Qemu-devel] [PATCH for-2.0] tcg-arm: Avoid ldrd/strd for user-only emulation

2014-03-25 Thread Richard Henderson
The arm ldrd/strd insns must cause alignment traps, whereas at least for armv7 ldr/str must handle unaligned operations. While this is hardly the only problem facing user-only emu, this solves one problem for i386 on armv7 emulation. Cc: Peter Maydell Cc: Andrzej Zaborowski Reported-by: Huw Dav

Re: [Qemu-devel] [PATCH v23 09/32] add qemu_opts_append to repalce append_option_parameters

2014-03-25 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: s/repalce/replace/ in subject Also, your overall series could probably use subject lines with a prefix that makes it obvious they are related to a common category; maybe "opts: ". > For later merge .create_opts of drv and proto_drv in qemu-img commands.

[Qemu-devel] [PATCH 3/5] machine: replace QEMUMachine by MachineClass in accelerator configuration

2014-03-25 Thread Marcel Apfelbaum
This minimizes QEMUMachine usage, as part of machine QOM-ification. Signed-off-by: Marcel Apfelbaum --- include/hw/xen/xen.h| 2 +- include/qemu/typedefs.h | 1 + include/sysemu/kvm.h| 2 +- include/sysemu/qtest.h | 2 +- kvm-all.c | 6 +++--- kvm-stub.c

Re: [Qemu-devel] [PATCH v23 08/32] add convert functions between QEMUOptionParameter to QemuOpts

2014-03-25 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: > Add two temp convert functions between QEMUOptionParameter to QemuOpts, s/convert/conversion/ here and in subject > so that next patch can use it. It will simplify later patch for easier > review. And will be finally removed after all backend drivers s

[Qemu-devel] [RFC PATCH 04/16] Header/constant/types fixes for visitors

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Move constants around and add types to allow file structure to move into visitors. Signed-off-by: Dr. David Alan Gilbert --- arch_init.c | 12 include/migration/migration.h | 15 +++ include/migration/vmstate.h | 20 ++

[Qemu-devel] [RFC PATCH 03/16] qemu-file: Add set/get tmp_visitor

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- include/migration/qemu-file.h | 4 qemu-file.c | 12 2 files changed, 16 insertions(+) diff --git a/include/migration/qemu-file.h b/include/migration/qemu-file.h index f066801..e36c03f

[Qemu-devel] [RFC PATCH 09/16] Visitor: Load path

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hacks in piix4.c, pci.c, spapr_vscsi.c for now Signed-off-by: Dr. David Alan Gilbert --- arch_init.c | 72 ++- hw/acpi/piix4.c | 5 +- hw/pci/pci.c| 3 +- hw/scsi/spapr_vscsi.c | 3 +- i

[Qemu-devel] [RFC PATCH 08/16] Visitor: Output path

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Replace QEMUFile by Visitor in most of the output path. There are still a few places that want a QEMUFile* and those are TODOs at the moment. Hacks in pci.c, spapr, spapr_vscsi.c for now where new visitor/qemufile boundaries have been added. Signed-off-by: Dr. Dav

[Qemu-devel] for 2.0: Re: [PATCH] qemu-img: Release refernece to BlockDriverState

2014-03-25 Thread Eric Blake
On 03/25/2014 02:25 PM, Prasad Joshi wrote: s/refernece/reference/ in the subject This is worth including in 2.0 > Signed-off-by: Prasad Joshi > --- > qemu-img.c | 1 + > 1 file changed, 1 insertion(+) With subject line fixed: Reviewed-by: Eric Blake Appears to have been introduced in commi

[Qemu-devel] [RFC PATCH 14/16] Start some BER format docs

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add information on the QEMUFile/Visitor/VMState split Describe how to verify a BER stream against the schema Signed-off-by: Dr. David Alan Gilbert --- docs/migration.txt | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) di

Re: [Qemu-devel] [PATCH 4/5] hw/ppc: remove QEMUMachine indirection

2014-03-25 Thread Marcel Apfelbaum
On Tue, 2014-03-25 at 15:00 +0100, Paolo Bonzini wrote: > Il 25/03/2014 14:46, Marcel Apfelbaum ha scritto: > > +mc->name = "pseries", > > +mc->desc = "pSeries Logical Partition (PAPR compliant)", > > +mc->is_default = 1, > > +mc->init = ppc_spapr_init, > > +mc->reset = ppc_spap

[Qemu-devel] [RFC PATCH 12/16] BER Visitor: Create output visitor

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert ber.h: Add VMSTATE_CPU_COMMON --- include/qapi/ber.h | 108 include/qapi/qemu-file-ber-output-visitor.h | 26 + qapi/Makefile.objs | 1 + qapi/qemu-file-ber-output-vis

[Qemu-devel] [RFC PATCH 06/16] Visitor: Debug output visitor

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" A migration visitor whose output is textual and purely for human consumption for debug. Signed-off-by: Dr. David Alan Gilbert --- include/qapi/qemu-file-debug-output-visitor.h | 26 ++ qapi/Makefile.objs| 1 + qapi/qemu-file-debug-o

[Qemu-devel] [RFC PATCH 01/16] Visitor: Add methods for migration format use

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" array types From https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg02465.html str256 type For the upto 256byte strings QEMU commonly uses for IDs buffer type For a blob of data that the caller wants to deliver whole (e.g. a page of RAM or b

Re: [Qemu-devel] [RFC PATCH 00/16] visitor+BER migration format

2014-03-25 Thread Michael S. Tsirkin
On Tue, Mar 25, 2014 at 08:17:11PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This is a work in progress cut of my visitor+BER format migration > world; there's lots to do but it's starting to get there. > I'd appreciate if anyone who has more experience with

Re: [Qemu-devel] [PATCH v23 07/32] add qemu_opts_print_help to replace print_option_help

2014-03-25 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: > print_option_help takes QEMUOptionParameter as parameter, add > qemu_opts_print_help to take QemuOptsList as parameter for later > replace work. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > include/qemu/option.h | 1 + > util

Re: [Qemu-devel] [PATCH v23 06/32] add qemu_opt_get_*_del functions for replace work

2014-03-25 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: > Add qemu_opt_get_del, qemu_opt_get_bool_del and qemu_opt_get_number_gel s/gel/del/ Any reason you don't mention qemu_opt_get_size_del here? > to replace the same handling of QEMUOptionParamter (get and delete). s/Paramter/Parameter/ > > get_*_del p

[Qemu-devel] [RFC PATCH 16/16] Wire in BER visitors

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" BER output visitor to be selected with env (as other output visitors) BER input visitor recognized by file header exec.c: Set cpu-common to use it's own type tag (as example) Signed-off-by: Dr. David Alan Gilbert --- exec.c| 2 ++ includ

[Qemu-devel] [PATCH] qemu-img: Release refernece to BlockDriverState

2014-03-25 Thread Prasad Joshi
Signed-off-by: Prasad Joshi --- qemu-img.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-img.c b/qemu-img.c index 2e40cc1..3d110d9 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1809,6 +1809,7 @@ static ImageInfoList *collect_image_info_list(const char *filename, if (err) {

[Qemu-devel] [RFC PATCH 05/16] Visitor: Binary compatible output visitor

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Binary compatible output visitor to write to a QEMUFile in current migration format. This is based on Michael Roth's series : https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg02466.html Signed-off-by: Dr. David Alan Gilbert --- include/qapi/qemu-file-bin

[Qemu-devel] [RFC PATCH 11/16] Choose output visitor based on env variable

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- savevm.c | 39 --- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/savevm.c b/savevm.c index 7431773..25e92f2 100644 --- a/savevm.c +++ b/savevm.c @@ -26,6 +26,7 @@ #incl

[Qemu-devel] [RFC PATCH 07/16] Visitor: Binary compatible input visitor

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" based on Michael Roth's https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg02470.html Signed-off-by: Dr. David Alan Gilbert --- include/qapi/qemu-file-binary-input-visitor.h | 27 + qapi/Makefile.objs| 2 +- qapi/qemu-file-bin

Re: [Qemu-devel] [PATCH v23 00/32] replace QEMUOptionParameter with QemuOpts

2014-03-25 Thread Leandro Dorileo
On Tue, Mar 25, 2014 at 06:09:40PM +, Leandro Dorileo wrote: > On Fri, Mar 21, 2014 at 06:12:11PM +0800, Chunyan Liu wrote: > > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > > only > > one Qemu Option structure is kept in QEMU code. > > > > --- > > Changes to v2

[Qemu-devel] [RFC PATCH 10/16] Visitor: Common types to use visitors

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Rework the common types in vmstate.c to use .visit rather than .get/.put and now call the correct visitor function. Signed-off-by: Dr. David Alan Gilbert --- vmstate.c | 376 -- 1 file changed, 73 insert

[Qemu-devel] [RFC PATCH 15/16] ASN.1 schema for new migration format

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- docs/specs/migration.schema | 113 1 file changed, 113 insertions(+) create mode 100644 docs/specs/migration.schema diff --git a/docs/specs/migration.schema b/docs/specs/migra

[Qemu-devel] [RFC PATCH 00/16] visitor+BER migration format

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is a work in progress cut of my visitor+BER format migration world; there's lots to do but it's starting to get there. I'd appreciate if anyone who has more experience with either the visitor code, or ASN.1/BER in general has a look to see if I'm doing anything

[Qemu-devel] [RFC PATCH 02/16] QEMUSizedBuffer/QEMUFile

2014-03-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Stefan Berger's to create a QEMUFile that goes to a memory buffer; from: http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg05036.html Using the QEMUFile interface, this patch adds support functions for operating on in-memory sized buffers that can be written

[Qemu-devel] [PATCH 2/5] machine: remove QEMUMachine indirection from MachineClass

2014-03-25 Thread Marcel Apfelbaum
No need to go through qemu_machine field. Use MachineClass fields directly. Signed-off-by: Marcel Apfelbaum --- device-hotplug.c | 2 +- qmp.c| 4 +-- vl.c | 103 --- 3 files changed, 63 insertions(+), 46 deletions(-

Re: [Qemu-devel] [PATCH v23 11/32] qemu_opts_print: change fprintf stderr to printf

2014-03-25 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 06:12:22PM +0800, Chunyan Liu wrote: > Currently this function is not used anywhere. In later patches, it will > replace print_option_parameters. print_option_parameters uses printf, > to avoid print info changes after switching to QemuOpts, change > qemu_opts_print from fpr

Re: [Qemu-devel] [PATCH v23 05/32] move qemu_opt_del ahead for later calling

2014-03-25 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: > In later patch, qemu_opt_get_del functions will be added, they will > first get the option value, then call qemu_opt_del to remove the option > from opt list. To prepare for that purpose, move qemu_opt_del ahead first. > > Signed-off-by: Chunyan Liu >

Re: [Qemu-devel] [RFC PATCH v2 08/12] introduce reverse execution mechanism.

2014-03-25 Thread Lluís Vilanova
fred konrad writes: [...] > diff --git a/reverse-execution.c b/reverse-execution.c > new file mode 100644 > index 000..44d1b80 > --- /dev/null > +++ b/reverse-execution.c > @@ -0,0 +1,326 @@ > +/* > + * reverse execution. > + * > + * Copyright (C) 2014 : GreenSocs Ltd > + * http://www.gr

[Qemu-devel] [maybe-for-2.0 0/2] hw/arm: Don't specify any default board

2014-03-25 Thread Peter Maydell
Currently for both qemu-system-arm and qemu-system-aarch64 the default board model if the user doesn't specify one is the 'integratorcp'. This is a totally arbitrary historical accident since it was the first board to be modelled. That board is now just one target among many for us, and is a very p

[Qemu-devel] [maybe-for-2.0 1/2] hw/arm: Stop specifying integratorcp as the default board

2014-03-25 Thread Peter Maydell
Currently for both qemu-system-arm and qemu-system-aarch64 the default board model if the user doesn't specify one is the 'integratorcp'. This is a totally arbitrary historical accident since it was the first board to be modelled. That board is now just one target among many for us, and is a very p

Re: [Qemu-devel] [PATCH v23 12/32] qcow2.c: remove 'assigned' check in amend

2014-03-25 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 06:12:23PM +0800, Chunyan Liu wrote: > In QEMUOptionParameter and QemuOptsList conversion, 'assigned' info > is lost. In current code, only qcow2 amend uses 'assigned' for a check. > It will be broken after next patch. So, remove 'assigned' check. If it's > really a must tha

[Qemu-devel] [maybe-for-2.0 2/2] vl.c: Improve message when no default machine is found

2014-03-25 Thread Peter Maydell
Improve the clarity of the message QEMU prints when the user doesn't specify a machine model to use and there is no default. Signed-off-by: Peter Maydell --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 2355227..9975e5a 100644 --- a/vl.c +++ b/vl.c

Re: [Qemu-devel] [PATCH v23 04/32] change opt->name and opt->str from (const char *) to (char *)

2014-03-25 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: Your subject says "what", but your commit message lacks a "why". Without a good reason, it's hard to see what this patch is good for. May I suggest: qemu_opt_del() already assumes that all QemuOpt instances contain malloc'd name and value; but it had to

Re: [Qemu-devel] [RFC PATCH v2 04/12] icount: introduce icount timer.

2014-03-25 Thread Lluís Vilanova
fred konrad writes: > From: KONRAD Frederic > This introduces a new timer based only on instruction counter and without any > compensation. > Signed-off-by: KONRAD Frederic > --- > cpus.c | 19 --- > include/qemu/timer.h | 9 - > qemu-timer.c

Re: [Qemu-devel] [PATCH v23 14/32] vvfat.c: handle cross_driver's create_options and create_opts

2014-03-25 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 06:12:25PM +0800, Chunyan Liu wrote: > vvfat shares create options of qcow driver. To avoid vvfat broken when > qcow driver changes from QEMUOptionParameter to QemuOpts, let it able > to handle both cases. > > Signed-off-by: Chunyan Liu > --- > block/vvfat.c | 19

Re: [Qemu-devel] [PATCH v23 09/32] add qemu_opts_append to repalce append_option_parameters

2014-03-25 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 06:12:20PM +0800, Chunyan Liu wrote: > For later merge .create_opts of drv and proto_drv in qemu-img commands. > > Signed-off-by: Chunyan Liu Reviewed-by: Leandro Dorileo > --- > Changes: > * Following Eric's suggestion, qemu_opts_append() will accept a pair of >

Re: [Qemu-devel] [PULL 0/2] vfio pull for QEMU 2.0

2014-03-25 Thread Peter Maydell
On 25 March 2014 18:30, Alex Williamson wrote: > Peter & Anthony, > > The following changes since commit 839a5547574e57cce62f49bfc50fe1f04b00589a: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20140324' into staging (2014-03-24 > 19:25:09 +) > > are available in

Re: [Qemu-devel] [V2 PATCH] target-ppc: Bug: VSX Convert to Integer Should Truncate

2014-03-25 Thread Peter Maydell
On 23 March 2014 21:52, Tom Musta wrote: > The various VSX Convert to Integer instructions should truncate the > mantissa. This fix forces the softfloat rounding mode to "round to > zero" prior to performing the conversion. After the conversion is > completed, the internal rounding mode is resto

Re: [Qemu-devel] [PATCH v23 07/32] add qemu_opts_print_help to replace print_option_help

2014-03-25 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 06:12:18PM +0800, Chunyan Liu wrote: > print_option_help takes QEMUOptionParameter as parameter, add > qemu_opts_print_help to take QemuOptsList as parameter for later > replace work. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu Reviewed-by: Leandro Dori

[Qemu-devel] [PULL 1/2] vfio: Correction in vfio_rom_read when attempting rom loading

2014-03-25 Thread Alex Williamson
From: Bandan Das commit e638073c569e801ce9de added a flag to track whether a previous rom read had failed. Accidentally, the code ended up adding vfio_load_option_rom twice. (Thanks to Alex for spotting it) Signed-off-by: Bandan Das Signed-off-by: Alex Williamson --- hw/misc/vfio.c |5 +--

Re: [Qemu-devel] [PATCH v23 04/32] change opt->name and opt->str from (const char *) to (char *)

2014-03-25 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 06:12:15PM +0800, Chunyan Liu wrote: > Signed-off-by: Chunyan Liu > --- > include/qemu/option_int.h | 4 ++-- > qapi/opts-visitor.c | 10 +++--- > util/qemu-option.c| 4 ++-- > 3 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/include/

Re: [Qemu-devel] aarch64: -device virtio-scsi-device, id=scsi: No 'virtio-bus' bus found for device 'virtio-scsi-device'

2014-03-25 Thread Peter Maydell
On 25 March 2014 14:13, Paolo Bonzini wrote: > Il 25/03/2014 15:04, Peter Maydell ha scritto: >> Yes, default for qemu-system-aarch64 is integratorcp, >> which even stupider than having that be the default >> for qemu-system-arm. >> >> For 2.1 when the system emulation stuff actually lands >> I th

[Qemu-devel] [PULL for-2.0 3/5] Fixed various typos

2014-03-25 Thread Stefan Hajnoczi
From: Deepak Kathayat Signed-off-by: Deepak Kathayat Reviewed-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- block/gluster.c | 2 +- block/qcow.c | 2 +- block/sheepdog.c | 8 block/vdi.c | 2 +- block/vhdx-log.c | 2 +- slirp/tftp.c | 2 +- 6 files changed, 9 in

Re: [Qemu-devel] aarch64: -device virtio-scsi-device, id=scsi: No 'virtio-bus' bus found for device 'virtio-scsi-device'

2014-03-25 Thread Paolo Bonzini
Il 25/03/2014 15:04, Peter Maydell ha scritto: Yes, default for qemu-system-aarch64 is integratorcp, which even stupider than having that be the default for qemu-system-arm. For 2.1 when the system emulation stuff actually lands I think I'll just remove the default and force users to specify a m

[Qemu-devel] [PULL for-2.0 2/5] qemu-img: mandate argument to 'qemu-img check --repair'

2014-03-25 Thread Stefan Hajnoczi
From: Prasad Joshi qemu-img check --repair option accepts an argument. The argument to --repair switch can either be 'all' or 'leak'. Fix the long option to mandate argument with --repair switch. The patch fixes following segmentation fault Core was generated by `qemu-img check -f qcow2 --repai

[Qemu-devel] [PATCH 1/5] hw/boards.h: add QEMUMachine's fields to MachineClass

2014-03-25 Thread Marcel Apfelbaum
In order to eliminate the QEMUMachine indirection, add its fields directly to MachineClass. Do not remove yet qemu_machine field because it is in use already by sparpr. Signed-off-by: Marcel Apfelbaum --- include/hw/boards.h | 23 +++ 1 file changed, 23 insertions(+) diff --

[Qemu-devel] [PATCH 4/5] hw/ppc: remove QEMUMachine indirection

2014-03-25 Thread Marcel Apfelbaum
No need for QEMUMachine anymore because its fields are passed to MachineClass. Signed-off-by: Marcel Apfelbaum --- hw/ppc/spapr.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index a11e121..4498fc2 100644 --- a/h

[Qemu-devel] [PATCH 3/5] machine: replace QEMUMachine by MachineClass in accelerator configuration

2014-03-25 Thread Marcel Apfelbaum
This minimizes QEMUMachine usage, as part of machine QOM-ification. Signed-off-by: Marcel Apfelbaum --- include/hw/xen/xen.h| 2 +- include/qemu/typedefs.h | 1 + include/sysemu/kvm.h| 2 +- include/sysemu/qtest.h | 2 +- kvm-all.c | 6 +++--- kvm-stub.c

Re: [Qemu-devel] [PATCH 4/5] hw/ppc: remove QEMUMachine indirection

2014-03-25 Thread Paolo Bonzini
Il 25/03/2014 14:46, Marcel Apfelbaum ha scritto: +mc->name = "pseries", +mc->desc = "pSeries Logical Partition (PAPR compliant)", +mc->is_default = 1, +mc->init = ppc_spapr_init, +mc->reset = ppc_spapr_reset, +mc->block_default_type = IF_SCSI, +mc->max_cpus = MAX_CPUS

[Qemu-devel] [PATCH 5/5] vl.c: Remove QEMUMachine usage

2014-03-25 Thread Marcel Apfelbaum
All the references of QEMUMachine are already replaced by MachineClass. Signed-off-by: Marcel Apfelbaum --- include/hw/boards.h | 7 +++ vl.c| 3 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/hw/boards.h b/include/hw/boards.h index 7cf1f07..66ee98

[Qemu-devel] [PULL 2/2] vfio: Cosmetic error reporting fixes

2014-03-25 Thread Alex Williamson
* Remove terminating newlines from hw_error() and error_report() calls * Fix cut-n-paste error in text (s/to/from/) Signed-off-by: Alex Williamson --- hw/misc/vfio.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/misc/vfio.c b/hw/misc/vfio

Re: [Qemu-devel] [PULL for-2.0 0/1] Net patches

2014-03-25 Thread Peter Maydell
On 25 March 2014 16:34, Stefan Hajnoczi wrote: > The following changes since commit 839a5547574e57cce62f49bfc50fe1f04b00589a: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20140324' into staging (2014-03-24 > 19:25:09 +) > > are available in the git repository a

[Qemu-devel] [PATCH 5/5] vl.c: Remove QEMUMachine usage

2014-03-25 Thread Marcel Apfelbaum
All the references of QEMUMachine are already replaced by MachineClass. Signed-off-by: Marcel Apfelbaum --- include/hw/boards.h | 7 +++ vl.c| 3 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/hw/boards.h b/include/hw/boards.h index 7cf1f07..66ee98

[Qemu-devel] [PATCH 4/5] hw/ppc: remove QEMUMachine indirection

2014-03-25 Thread Marcel Apfelbaum
No need for QEMUMachine anymore because its fields are passed to MachineClass. Signed-off-by: Marcel Apfelbaum --- hw/ppc/spapr.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index a11e121..4498fc2 100644 --- a/h

[Qemu-devel] [PULL 0/2] vfio pull for QEMU 2.0

2014-03-25 Thread Alex Williamson
Peter & Anthony, The following changes since commit 839a5547574e57cce62f49bfc50fe1f04b00589a: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140324' into staging (2014-03-24 19:25:09 +) are available in the git repository at: git://github.com/awilliam/qemu-vfio.

[Qemu-devel] [PATCH v5 6/7] allwinner-emac: set autonegotiation complete bit on link up

2014-03-25 Thread Beniamino Galvani
Signed-off-by: Beniamino Galvani Reviewed-by: Peter Crosthwaite --- hw/net/allwinner_emac.c |4 ++-- include/hw/net/allwinner_emac.h |1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c index 469f2f0..91931ac 10064

[Qemu-devel] [PATCH v5 5/7] allwinner-a10-pit: implement prescaler and source selection

2014-03-25 Thread Beniamino Galvani
This implements the prescaler and source fields of the timer control register. The source for each timer can be selected among 4 clock inputs whose frequencies are set through model properties. Signed-off-by: Beniamino Galvani Reviewed-by: Peter Crosthwaite --- hw/arm/cubieboard.c

[Qemu-devel] [PATCH v5 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

2014-03-25 Thread Beniamino Galvani
The model was generating interrupts for all enabled timers after the expiration of one of them. Avoid this by passing explicitly the timer index to the callback function. Signed-off-by: Beniamino Galvani Reviewed-by: Li Guang Reviewed-by: Peter Crosthwaite --- hw/timer/allwinner-a10-pit.c

[Qemu-devel] [PATCH v5 2/7] allwinner-a10-pic: fix behaviour of pending register

2014-03-25 Thread Beniamino Galvani
The pending register is read-only and the value returned upon a read reflects the state of irq input pins (interrupts are level triggered). This patch implements such behaviour. Signed-off-by: Beniamino Galvani Reviewed-by: Li Guang Reviewed-by: Peter Crosthwaite --- hw/intc/allwinner-a10-pic.

[Qemu-devel] [PATCH v5 4/7] allwinner-a10-pit: use level triggered interrupts

2014-03-25 Thread Beniamino Galvani
Convert the interrupt generation logic to the use of level triggered interrupts. Signed-off-by: Beniamino Galvani Reviewed-by: Peter Crosthwaite --- hw/timer/allwinner-a10-pit.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/timer/allwinner-a10-pit.c b/

[Qemu-devel] [PATCH v5 7/7] allwinner-emac: update irq status after writes to interrupt registers

2014-03-25 Thread Beniamino Galvani
The irq line status must be updated after writes to the INT_CTL and INT_STA registers. Signed-off-by: Beniamino Galvani Reviewed-by: Peter Crosthwaite --- hw/net/allwinner_emac.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c index 919

[Qemu-devel] [PATCH v5 0/7] Allwinner A10 fixes

2014-03-25 Thread Beniamino Galvani
This series introduces some fixes and missing features found while trying to run mainline Linux kernel on emulated Allwinner A10. The changes concern interrupt handling, timer and ethernet MAC. With these applied I'm able to boot Linux 3.14-rc2 using a NFS root: https://gist.github.com/anonymous

[Qemu-devel] [PATCH v5 1/7] allwinner-a10-pic: set vector address when an interrupt is pending

2014-03-25 Thread Beniamino Galvani
This patch implements proper updating of the vector register which should hold, according to the A10 user manual, the vector address for the interrupt currently active on the CPU IRQ input. Interrupt priority is not implemented at the moment and thus the first pending interrupt is returned. Signe

[Qemu-devel] [RFC PATCH v2 12/12] cexe: allow to enable reverse execution.

2014-03-25 Thread fred . konrad
From: KONRAD Frederic This creates QEMU options for reverse execution. Signed-off-by: KONRAD Frederic --- qemu-options.hx | 9 + vl.c| 16 2 files changed, 25 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index ee5437b..bd730f6 100644 --- a

  1   2   3   >