[Qemu-devel] Missing dependency checks in qemu build

2014-03-21 Thread Matthew Fernandez
Hi all, This only came to my attention when building qemu on a colleague's machine recently, but there are some dependencies for the build that are not detected during the standard `configure` process. In particular, missing autoconf was not detected until running `make` itself. Also missing li

Re: [Qemu-devel] [PATCH 01/26] qapi: output def_value_str when query command line options

2014-03-21 Thread Eric Blake
On 03/20/2014 06:13 PM, Leandro Dorileo wrote: > From: Chunyan Liu > > Change qapi interfaces to output the newly added def_value_str when querying > command line options. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > qapi-schema.json | 6 +- > qmp-commands.hx

[Qemu-devel] [PATCH v2 9/9] error: Remove some unused headers

2014-03-21 Thread Cole Robinson
Makes it a bit clear how the interdependencies work. Cc: Luiz Capitulino Cc: Markus Armbruster Signed-off-by: Cole Robinson --- include/qapi/qmp/qerror.h | 1 - util/error.c | 5 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/includ

[Qemu-devel] [PATCH v2 8/9] qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTED

2014-03-21 Thread Cole Robinson
The former is only used twice, the latter is used over 30 times, and has a nicer error message. Cc: Luiz Capitulino Cc: Markus Armbruster Signed-off-by: Cole Robinson --- blockjob.c | 2 +- include/qapi/qmp/qerror.h | 3 --- stubs/arch-query-cpu-def.c | 2 +- 3 files changed,

Re: [Qemu-devel] [PATCH v23 01/32] move find_desc_by_name ahead for later calling

2014-03-21 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: > Signed-off-by: Chunyan Liu > --- > util/qemu-option.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library

[Qemu-devel] [PATCH v2 2/9] vnc: Remove default_mon usage

2014-03-21 Thread Cole Robinson
These errors don't seem user initiated, so forcibly printing to the monitor doesn't seem right. Just use error_report. Cc: Anthony Liguori Cc: Gerd Hoffmann Signed-off-by: Cole Robinson --- v2: Use error_report instead of fprintf ui/vnc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[Qemu-devel] [PATCH v2 4/9] monitor: Remove unused monitor_print_filename

2014-03-21 Thread Cole Robinson
Cc: Luiz Capitulino Cc: Markus Armbruster Signed-off-by: Cole Robinson --- include/monitor/monitor.h | 1 - monitor.c | 27 --- stubs/Makefile.objs| 1 - stubs/mon-print-filename.c | 6 -- 4 files changed, 35 deletions(-) delete mode 100

[Qemu-devel] [PATCH v2 7/9] qerror.h: Remove QERR defines that are only used once

2014-03-21 Thread Cole Robinson
Just hardcode them in the callers Cc: Luiz Capitulino Cc: Markus Armbruster Signed-off-by: Cole Robinson --- block/commit.c| 2 +- blockdev.c| 9 --- hw/9pfs/virtio-9p.c | 5 ++-- hw/core/qdev-properties.c | 9 --- hw/misc/ivshmem.c | 4 +-

[Qemu-devel] [PATCH v2 5/9] error: Print error_report() to stderr if using qmp

2014-03-21 Thread Cole Robinson
monitor_printf will drop the requested output if cur_mon is qmp (for good reason). However these messages are often helpful for debugging issues with via libvirt. If we know the message won't hit the monitor, send it to stderr. Cc: Luiz Capitulino Cc: Markus Armbruster Signed-off-by: Cole Robin

[Qemu-devel] [PATCH v2 3/9] error: Privatize error_print_loc

2014-03-21 Thread Cole Robinson
Cc: Luiz Capitulino Cc: Markus Armbruster Signed-off-by: Cole Robinson --- include/qemu/error-report.h | 1 - util/qemu-error.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h index 3b098a9..000eae3 100644

[Qemu-devel] [PATCH v2 6/9] qerror.h: Remove unused error classes

2014-03-21 Thread Cole Robinson
Cc: Luiz Capitulino Cc: Markus Armbruster Signed-off-by: Cole Robinson --- include/qapi/qmp/qerror.h | 9 - 1 file changed, 9 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index da75abf..a72bbc9 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi

[Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements

2014-03-21 Thread Cole Robinson
Minor error API cleanups, and one error reporting improvement when connected to qmp (patch #5) v2: Dropped the error_printf_unless_qmp patch Added the last 4 patches, new cleanups Use error_report instead of fprintf in patch 1 and 2 Cc: Luiz Capitulino Cc: Markus Armbruster Cole Ro

[Qemu-devel] [PATCH v2 1/9] slirp: Remove default_mon usage

2014-03-21 Thread Cole Robinson
These errors don't seem user initiated, so forcibly printing to the monitor doesn't seem right. Just use error_report. Drop lprint since it's now unused. Cc: Jan Kiszka Signed-off-by: Cole Robinson --- v2: Use error_report instead of fprintf slirp/misc.c | 13 ++--- slirp/slirp

Re: [Qemu-devel] [PATCH 5/6] error: Remove redundant error_printf_unless_qmp

2014-03-21 Thread Cole Robinson
On 03/12/2014 04:56 AM, Markus Armbruster wrote: > Cole Robinson writes: > >> error_printf is just a wrapper around monitor_printf, which already >> drops the requested output if cur_mon is qmp. > > Since commit 74ee59a: > > monitor: drop unused monitor debug code > > In the old QM

Re: [Qemu-devel] [PATCH 02/14] tcg: Add INDEX_op_trunc_i32

2014-03-21 Thread Stuart Brady
On Fri, Mar 21, 2014 at 11:35:12PM +, Stuart Brady wrote: > On Mon, Mar 17, 2014 at 11:37:44AM -0700, Richard Henderson wrote: > > diff --git a/tcg/README b/tcg/README > > index f178212..160cbe8 100644 > > --- a/tcg/README > > +++ b/tcg/README > > @@ -306,6 +306,11 @@ This operation would be eq

Re: [Qemu-devel] [PATCH 02/14] tcg: Add INDEX_op_trunc_i32

2014-03-21 Thread Stuart Brady
On Mon, Mar 17, 2014 at 11:37:44AM -0700, Richard Henderson wrote: > diff --git a/tcg/README b/tcg/README > index f178212..160cbe8 100644 > --- a/tcg/README > +++ b/tcg/README > @@ -306,6 +306,11 @@ This operation would be equivalent to > >dest = (t1 & ~0x0f00) | ((t2 << 8) & 0x0f00) > > +*

Re: [Qemu-devel] [PATCH v23 03/32] qapi: output def_value_str when query command line options

2014-03-21 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: > Change qapi interfaces to output the newly added def_value_str when querying > command line options. > > Reviewed-by: Eric Blake > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > qapi-schema.json | 6 +- > qmp-commands.hx|

Re: [Qemu-devel] multihead & multiseat in qemu

2014-03-21 Thread Dave Airlie
On Fri, Mar 21, 2014 at 11:27 PM, Gerd Hoffmann wrote: > Hi, > > I'm thinking about how to handle multihead and multiseat in qemu best. > > On multihead: Mouse in virtual machines works best with absolute > coordinates, and the way this is done today is to assign a (virtual) usb > tablet to the

Re: [Qemu-devel] [PATCH] backends/baum.c: Fix compilation when SDL is not available.

2014-03-21 Thread Stefan Weil
Am 21.03.2014 22:29, schrieb Richard W.M. Jones: > backends/baum.c: In function ‘chr_baum_init’: > backends/baum.c:569:64: error: missing binary operator before token "(" > #if defined(CONFIG_SDL) && SDL_COMPILEDVERSION < SDL_VERSIONNUM(2, 0, 0) >

[Qemu-devel] [PATCH] backends/baum.c: Fix compilation when SDL is not available.

2014-03-21 Thread Richard W.M. Jones
backends/baum.c: In function ‘chr_baum_init’: backends/baum.c:569:64: error: missing binary operator before token "(" #if defined(CONFIG_SDL) && SDL_COMPILEDVERSION < SDL_VERSIONNUM(2, 0, 0) ^ backends/baum.c:598:64: error: missing bi

Re: [Qemu-devel] [PATCH for-2.0 v2] configure: add workaround for SystemTap PR13296

2014-03-21 Thread Frank Ch. Eigler
Hi - On Fri, Mar 21, 2014 at 04:28:24PM +0100, Stefan Hajnoczi wrote: > SystemTap sdt.h sometimes results in compiled probes without sufficient > information to extract arguments. See code comment for details on this > workaround. > > This patch fixes the apic_reset_irq_delivered() trace event on

Re: [Qemu-devel] [PATCH v2 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-21 Thread Eric Blake
On 03/21/2014 01:30 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Make qemu_peek_buffer repatedly call fill_buffer until it gets > all the data it requires, or until there is an error. > > At the moment, qemu_peek_buffer will try one qemu_fill_buffer if there >

Re: [Qemu-devel] [RFC PATCHv2] block: optimize zero writes with bdrv_write_zeroes

2014-03-21 Thread Peter Lieven
Am 21.03.2014 15:50, schrieb Eric Blake: > On 03/21/2014 08:36 AM, Peter Lieven wrote: >> this patch tries to optimize zero write requests >> by automatically using bdrv_write_zeroes if it is >> supported by the format. >> >> this should significantly speed up file system initialization and >> shou

[Qemu-devel] [RFC PATCH 03/12] migration: make qemu_savevm_state public.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic This makes qemu_savevm_state public for reverse-execution. Signed-off-by: KONRAD Frederic --- include/sysemu/sysemu.h | 1 + savevm.c| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h ind

Re: [Qemu-devel] [RFC PATCH 03/12] migration: make qemu_savevm_state public.

2014-03-21 Thread Dr. David Alan Gilbert
* fred.kon...@greensocs.com (fred.kon...@greensocs.com) wrote: > From: KONRAD Frederic > > This makes qemu_savevm_state public for reverse-execution. It's interesting that you're doing this repetitive snapshot; in some ways it's similar to Michael Hines's code for Fault tolerance ( http://lists

[Qemu-devel] [RFC PATCH 06/12] icount: make icount extra computed on icount clock as well.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic This takes icount clock in account for icount extra computation so icount clock's timers will be triggered at the exact time. Signed-off-by: KONRAD Frederic --- cpus.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/cpus.c b/cpus.c index 01c48e9..825d438 1

[Qemu-devel] [PATCH v3 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is a fix for a bug* triggered by a migration after hot unplugging a few virtio-net NICs, that caused migration never to converge, because 'migration_dirty_pages' is incorrectly initialised. 'migration_dirty_pages' is used as a tally of the number of outstandin

[Qemu-devel] [PATCH v2 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-21 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Make qemu_peek_buffer repatedly call fill_buffer until it gets all the data it requires, or until there is an error. At the moment, qemu_peek_buffer will try one qemu_fill_buffer if there isn't enough data waiting, however the kernel is entitled to return jus

[Qemu-devel] [RFC PATCH 10/12] cpu-exec: trigger a debug request when rexec stops.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic This allows QEMU to trigger a debug exception when cexe_dbg_requested is set. Signed-off-by: KONRAD Frederic --- cpu-exec.c | 13 + 1 file changed, 13 insertions(+) diff --git a/cpu-exec.c b/cpu-exec.c index 0914d3c..851d101 100644 --- a/cpu-exec.c +++ b/cpu-

[Qemu-devel] [RFC PATCH 12/12] cexe: allow to enable reverse execution.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic This creates QEMU options for reverse execution. Signed-off-by: KONRAD Frederic --- qemu-options.hx | 9 + vl.c| 16 2 files changed, 25 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index ee5437b..bd730f6 100644 --- a

[Qemu-devel] [RFC PATCH 04/12] icount: introduce icount timer.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic This introduces a new timer based only on instruction counter and without any compensation. Signed-off-by: KONRAD Frederic --- cpus.c | 28 +++- include/qemu/timer.h | 8 qemu-timer.c | 6 ++ stubs/cpu-get

[Qemu-devel] [RFC PATCH 05/12] icount: check for icount clock deadline when cpu loop exits.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic Notify events on icount clock when CPU loop exits. Signed-off-by: KONRAD Frederic --- cpus.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpus.c b/cpus.c index ba096a3..01c48e9 100644 --- a/cpus.c +++ b/cpus.c @@ -998,6 +998,11 @@ static void *qemu_tcg_cpu_thr

[Qemu-devel] [RFC PATCH 02/12] migration: migrate icount fields.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic This fixes a bug where qemu_icount and qemu_icount_bias are not migrated. Signed-off-by: KONRAD Frederic --- cpus.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index 687717f..bdbc431 100644 --- a/cpus.c +++ b

[Qemu-devel] [RFC PATCH 00/12] Reverse execution.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic Hi everybody, Those are the two first patch-set we have been worked on for reverse execution. The first series: icount: put icount variables into TimerState. migration: migrate icount fields. migration: make qemu_savevm_state public. icount: introduce icount timer.

[Qemu-devel] [RFC PATCH 09/12] gdbstub: allow reverse execution in gdb stub.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic This allows gdb to reverse step QEMU: reverse-stepi and reverse-cont commands are allowed. When step_backward is called, QEMU restores a snapshot before the actual instruction and stops (with a debug exit) when the previous instruction is reached. Signed-off-by: KONRAD Fre

[Qemu-devel] [RFC PATCH 07/12] timer: add cpu_icount_to_ns function.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic This adds cpu_icount_to_ns function which is needed for reverse execution. It returns the time for a specific instruction. Signed-off-by: KONRAD Frederic --- cpus.c | 9 +++-- include/qemu/timer.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-)

[Qemu-devel] [RFC PATCH 01/12] icount: put icount variables into TimerState.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic This puts qemu_icount and qemu_icount_bias into TimerState structure to allow them to be migrated. Signed-off-by: KONRAD Frederic --- cpus.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/cpus.c b/cpus.c index 1104d61..

[Qemu-devel] [RFC PATCH 08/12] introduce reverse execution mechanism.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic This introduces the basic reverse-execution mechanism. Signed-off-by: KONRAD Frederic --- Makefile.target | 1 + cpus.c | 6 + include/reverse-execution.h | 41 ++ reverse-execution.c | 326

[Qemu-devel] [RFC PATCH 11/12] cexe: synchronize icount on the next event.

2014-03-21 Thread fred . konrad
From: KONRAD Frederic We don't want to warp on host clock as it is not deterministic for replay. So this patch warp icount on the next QEMU_VIRTUAL_CLOCK event if reverse execution is enabled. The normal behaviour is kept when reverse execution is disabled. Signed-off-by: KONRAD Frederic ---

[Qemu-devel] [PATCH] target-arm: Load ELF images with the correct machine type for CPU

2014-03-21 Thread Peter Maydell
When trying to load an ELF file specified via -kernel, we need to pass load_elf() the ELF machine type corresponding to the CPU we're booting with, not the one corresponding to the softmmu binary we happen to be running. (The two are different in the case of loading a 32-bit ARM ELF file into a 32

[Qemu-devel] [PATCH for-2.0] spice: input: Fix absolute mouse y coordinates

2014-03-21 Thread Cole Robinson
Current tablet + spice is unusable. Regressed with the UI input rework. Signed-off-by: Cole Robinson --- ui/spice-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/spice-input.c b/ui/spice-input.c index 6dab23b..c342e0d 100644 --- a/ui/spice-input.c +++ b/ui/spice-in

Re: [Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

2014-03-21 Thread Eduardo Habkost
On Fri, Mar 21, 2014 at 07:04:08PM +0100, Fabien Chouteau wrote: > On 03/17/2014 07:26 PM, Eduardo Habkost wrote: > > We had an unwritten rule about declarations having to be at beginning of > > blocks. Make it a written rule. > > > > Hello Eduardo, > > Is it possible to check this rule in scrip

Re: [Qemu-devel] [PATCH v2 00/12] block/json: Add JSON protocol driver

2014-03-21 Thread Max Reitz
On 07.03.2014 23:55, Max Reitz wrote: This series adds a passthrough JSON protocol block driver. Its filenames are JSON objects prefixed by "json:". The objects are used as options for opening another block device which will be the child of the JSON device. Regarding this child device, the JSON d

Re: [Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

2014-03-21 Thread Fabien Chouteau
On 03/17/2014 07:26 PM, Eduardo Habkost wrote: > We had an unwritten rule about declarations having to be at beginning of > blocks. Make it a written rule. > Hello Eduardo, Is it possible to check this rule in script/checkpatch.pl? (or is it already?) Regards,

Re: [Qemu-devel] propose a new idea for GSOC 2014

2014-03-21 Thread Fabien Chouteau
On 03/19/2014 11:51 AM, Stefan Hajnoczi wrote: > On Tue, Mar 18, 2014 at 9:08 PM, Daniel Smith > wrote: >> I would like to propose a new idea for GSOC 2014 that I want to implement >> for QEMU. Since QEMU are widely used for binary analysis, dynamic binary >> code instrumentation and so on. >> Ca

Re: [Qemu-devel] [PATCH 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-21 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert" wrote: >> >> > +while (index >= f->buf_size) { >> >> > +int received = qemu_fill_buffer(f); >> >> > + >> >> > +if (received <= 0) { >> >> >> >> here, I don't know really

[Qemu-devel] [PATCH v2 1/1] Count used RAMBlock pages for migration_dirty_p

2014-03-21 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is a fix for a bug* triggered by a migration after hot unplugging a few virtio-net NICs, that caused migration never to converge, because 'migration_dirty_pages' is incorrectly initialised. 'migration_dirty_pages' is used as a tally of the number of outstandin

Re: [Qemu-devel] [PATCH] target-ppc: improve "info registers" by printing SPRs

2014-03-21 Thread Fabien Chouteau
On 03/19/2014 03:17 PM, Alexey Kardashevskiy wrote: > This adds printing of all SPR registers registered for a CPU. > > This removes "SPR_" prefix from SPR name to reduce the output. > > Signed-off-by: Alexey Kardashevskiy > --- > Very useful patch Alexey, I have few comments: > +for (i

Re: [Qemu-devel] [PATCH 2/5] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-03-21 Thread Anthony PERARD
On Fri, Feb 21, 2014 at 02:44:10PM +0800, Yang Zhang wrote: > From: Yang Zhang > > Some VBIOSs and drivers assume the IGD BDF (bus:device:function) is > always 00:02.0, so this patch reserves 00:02.0 for assigned IGD in > guest. > > The original patch is from Weidong Han > > Signed-off-by: Yan

Re: [Qemu-devel] migrating instances from qemu-kvm to qemu

2014-03-21 Thread Serge E. Hallyn
Quoting Cole Robinson (crobi...@redhat.com): > On 03/21/2014 01:00 PM, Serge E. Hallyn wrote: > > Quoting Cole Robinson (crobi...@redhat.com): > >> On 03/19/2014 12:16 PM, Serge E. Hallyn wrote: > >>> Quoting Serge E. Hallyn (se...@hallyn.com): > Quoting Paolo Bonzini (pbonz...@redhat.com): >

Re: [Qemu-devel] migrating instances from qemu-kvm to qemu

2014-03-21 Thread Cole Robinson
On 03/21/2014 01:00 PM, Serge E. Hallyn wrote: > Quoting Cole Robinson (crobi...@redhat.com): >> On 03/19/2014 12:16 PM, Serge E. Hallyn wrote: >>> Quoting Serge E. Hallyn (se...@hallyn.com): Quoting Paolo Bonzini (pbonz...@redhat.com): > Il 19/03/2014 16:42, Serge E. Hallyn ha scritto: >>

Re: [Qemu-devel] RFC - best way to organize a multiprotocol transport?

2014-03-21 Thread Anton Ivanov
On 21/03/14 15:27, Stefan Hajnoczi wrote: > On Fri, Mar 21, 2014 at 3:06 PM, Anton Ivanov > wrote: >> On 21/03/14 13:14, Stefan Hajnoczi wrote: >>> On Fri, Mar 21, 2014 at 10:01:09AM +, Anton Ivanov wrote: >> I will probably collect all common routines and merge them into a >> library. Once th

Re: [Qemu-devel] migrating instances from qemu-kvm to qemu

2014-03-21 Thread Serge E. Hallyn
Quoting Cole Robinson (crobi...@redhat.com): > On 03/19/2014 12:16 PM, Serge E. Hallyn wrote: > > Quoting Serge E. Hallyn (se...@hallyn.com): > >> Quoting Paolo Bonzini (pbonz...@redhat.com): > >>> Il 19/03/2014 16:42, Serge E. Hallyn ha scritto: > Hi, > > at https://bugs.launchpad.n

Re: [Qemu-devel] [PATCH v4 00/10] KVM Support for MIPS32 Processors

2014-03-21 Thread James Hogan
On 20/03/14 12:44, Paolo Bonzini wrote: > Il 20/03/2014 11:00, James Hogan ha scritto: >>> > Just a few comments. With what version of the kernel can this be >>> tested? >> KVM support was added in v3.10, including defconfigs and a >> CONFIG_KVM_GUEST to ensure the kernel is linked to the differen

[Qemu-devel] [PATCH 1/2] test-qapi: Make test-qapi.py spit useful error messages.

2014-03-21 Thread Benoît Canet
In case of exception str(e) with e being the exception is more detailled. Signed-off-by: Benoit Canet --- tests/qapi-schema/test-qapi.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py index b3d1e1d..ac6da13

Re: [Qemu-devel] [PATCH v2] QemuOpt: add unit tests

2014-03-21 Thread Leandro Dorileo
Hi Laszlo, On Fri, Mar 21, 2014 at 04:30:32PM +0100, Laszlo Ersek wrote: > On 03/21/14 15:56, Leandro Dorileo wrote: > > Hi Eric, > > > > On Fri, Mar 21, 2014 at 08:37:40AM -0600, Eric Blake wrote: > >> On 03/17/2014 05:10 PM, Leandro Dorileo wrote: > >>> Cover basic aspects and API usage for Qem

Re: [Qemu-devel] multihead & multiseat in qemu

2014-03-21 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > I'm thinking about how to handle multihead and multiseat in qemu best. > > On multihead: Mouse in virtual machines works best with absolute > coordinates, and the way this is done today is to assign a (virtual) usb > tablet to the guest. Wi

[Qemu-devel] [PATCH 2/2] qapi: Create an include directive for use in the JSON description files.

2014-03-21 Thread Benoît Canet
The new directive in the form { 'include': 'path/to/file.json' } will trigger the parsing of path/to/file.json. The directive will be replaced by the result of the parsing. This will allow for easy modularisation of qapi JSON descriptions files. The qapi commands now takes the input file path as

Re: [Qemu-devel] [PATCH 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-21 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > >> > +while (index >= f->buf_size) { > >> > +int received = qemu_fill_buffer(f); > >> > + > >> > +if (received <= 0) { > >> > >> here, I don't know really what to do. We just need one character,

Re: [Qemu-devel] [PATCH 1/5] xen, gfx passthrough: basic graphics passthrough support

2014-03-21 Thread Anthony PERARD
On Fri, Feb 21, 2014 at 02:44:09PM +0800, Yang Zhang wrote: > From: Yang Zhang > > basic gfx passthrough support: > - add a vga type for gfx passthrough > - retrieve VGA bios from host 0xC, then load it to guest 0xC > - register/unregister legacy VGA I/O ports and MMIOs for passthroughed

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Juan Quintela
Paolo Bonzini wrote: > Il 21/03/2014 16:45, Dr. David Alan Gilbert ha scritto: >>> > So it looks like your patch could also fix the problem Juan reported >>> > at http://article.gmane.org/gmane.comp.emulators.qemu/247462 -- but >>> > perhaps only on hosts where !KVM || TARGET_PAGE_SIZE==getpagesiz

[Qemu-devel] [PATCH for-2.0 v2] configure: add workaround for SystemTap PR13296

2014-03-21 Thread Stefan Hajnoczi
SystemTap sdt.h sometimes results in compiled probes without sufficient information to extract arguments. See code comment for details on this workaround. This patch fixes the apic_reset_irq_delivered() trace event on Fedora 20 with gcc-4.8.2-7.fc20 and systemtap-sdt-devel-2.4-2.fc20 on x86_64.

Re: [Qemu-devel] [PATCH 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-21 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: >> > +while (index >= f->buf_size) { >> > +int received = qemu_fill_buffer(f); >> > + >> > +if (received <= 0) { >> >> here, I don't know really what to do. We just need one character, so >> the 1st call to qemu_fill_buffer() gives it to us, or

[Qemu-devel] [PATCH 0/2] Create and include directive for QAPI JSON files

2014-03-21 Thread Benoît Canet
The first patch make an error path in the test more explicit. The second create an include directive for QAPI JSON files. The purpose of this series is to be able to add QMP to qemu-nbd in a not so distant future. Best regards Benoît Benoît Canet (2): test-qapi: Make test-qapi.py spit useful

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Paolo Bonzini
Il 21/03/2014 16:45, Dr. David Alan Gilbert ha scritto: > So it looks like your patch could also fix the problem Juan reported > at http://article.gmane.org/gmane.comp.emulators.qemu/247462 -- but > perhaps only on hosts where !KVM || TARGET_PAGE_SIZE==getpagesize(). Possibly yes; I think that w

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 21/03/2014 14:22, Dr. David Alan Gilbert ha scritto: > >I don't think they overlap, but I worry that the end of one block > >and the start of the next might be on the same page. > >The code that got me worried was migration_bitmap_sync_range > >that

Re: [Qemu-devel] [PATCH v2] QemuOpt: add unit tests

2014-03-21 Thread Laszlo Ersek
On 03/21/14 15:56, Leandro Dorileo wrote: > Hi Eric, > > On Fri, Mar 21, 2014 at 08:37:40AM -0600, Eric Blake wrote: >> On 03/17/2014 05:10 PM, Leandro Dorileo wrote: >>> Cover basic aspects and API usage for QemuOpt. The current implementation >>> covers the API's planned to be changed by Chunyan

Re: [Qemu-devel] RFC - best way to organize a multiprotocol transport?

2014-03-21 Thread Stefan Hajnoczi
On Fri, Mar 21, 2014 at 3:06 PM, Anton Ivanov wrote: > On 21/03/14 13:14, Stefan Hajnoczi wrote: >> On Fri, Mar 21, 2014 at 10:01:09AM +, Anton Ivanov wrote: > I will probably collect all common routines and merge them into a > library. Once that is done I will submit a revised patch that does

Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-21 Thread Richard Henderson
On 03/21/2014 12:07 AM, Mark Cave-Ayland wrote: > > This basic patch looks good to me. My only comment is that I suspect for > bisection purposes it may be better to split this into 2 patches - one to > perform the conversion of all existing constants to INT*_MAX and INT*_MIN, and > then a second

Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-21 Thread Richard Henderson
On 03/20/2014 06:25 PM, Olivier Danet wrote: > The signed integer division -0x8000___ / -1 must be handled > separately to avoid an overflow on the QEMU host. > > Negative overflow must be a negative number for correct sign > extension in Sparc64 mode. Use constants. > > Signed-off-b

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Paolo Bonzini
Il 21/03/2014 14:22, Dr. David Alan Gilbert ha scritto: I don't think they overlap, but I worry that the end of one block and the start of the next might be on the same page. The code that got me worried was migration_bitmap_sync_range that seemd to be general; but actually that's worrying about

Re: [Qemu-devel] [PATCH v2] QemuOpt: add unit tests

2014-03-21 Thread Leandro Dorileo
Hi Eric, On Fri, Mar 21, 2014 at 08:37:40AM -0600, Eric Blake wrote: > On 03/17/2014 05:10 PM, Leandro Dorileo wrote: > > Cover basic aspects and API usage for QemuOpt. The current implementation > > covers the API's planned to be changed by Chunyan Liu in his > > QEMUOptionParameter > > replacem

Re: [Qemu-devel] [RFC PATCHv2] block: optimize zero writes with bdrv_write_zeroes

2014-03-21 Thread Eric Blake
On 03/21/2014 08:36 AM, Peter Lieven wrote: > this patch tries to optimize zero write requests > by automatically using bdrv_write_zeroes if it is > supported by the format. > > this should significantly speed up file system initialization and > should speed zero write test used to test backend st

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Dr. David Alan Gilbert
* (chenliang0...@icloud.com) wrote: > > > From: "Dr. David Alan Gilbert" > > > > This is a fix for a bug* triggered by a migration after hot unplugging > > a few virtio-net NICs, that caused migration never to converge, because > > 'migration_dirty_pages' is incorrectly initialised. > > >

Re: [Qemu-devel] [PATCH 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-21 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Make qemu_peek_buffer repatedly call fill_buffer until it gets > > all the data it requires, or until there is an error. > > > > At the moment, qemu_peek_buffer will t

Re: [Qemu-devel] [PATCH v2] QemuOpt: add unit tests

2014-03-21 Thread Eric Blake
On 03/17/2014 05:10 PM, Leandro Dorileo wrote: > Cover basic aspects and API usage for QemuOpt. The current implementation > covers the API's planned to be changed by Chunyan Liu in his > QEMUOptionParameter > replacement/cleanup job. > > Other APIs should be covered in future improvements. > >

[Qemu-devel] [RFC PATCHv2] block: optimize zero writes with bdrv_write_zeroes

2014-03-21 Thread Peter Lieven
this patch tries to optimize zero write requests by automatically using bdrv_write_zeroes if it is supported by the format. this should significantly speed up file system initialization and should speed zero write test used to test backend storage performance. the difference can simply be tested

Re: [Qemu-devel] [PATCH v5 07/11] vfio: Add guest side IOMMU support

2014-03-21 Thread Paolo Bonzini
Il 21/03/2014 15:17, Alex Williamson ha scritto: > > Is this possible? Assuming len is initially a power-of-2, would the > > translate function change it? Maybe worth a comment to explain. Oh. address_space_translate() actually changes @len to min(len, TARGET_PAGE_SIZE) and TARGET_PAGE_SIZE i

Re: [Qemu-devel] [PATCH v5 07/11] vfio: Add guest side IOMMU support

2014-03-21 Thread Alex Williamson
On Fri, 2014-03-21 at 18:59 +1100, Alexey Kardashevskiy wrote: > On 03/20/2014 06:57 AM, Alex Williamson wrote: > > On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: > >> From: David Gibson > >> > >> This patch uses the new IOMMU notifiers to allow VFIO pass through devices > >> to wo

Re: [Qemu-devel] [PATCH V2 for-2.0] vl.c: Fix OpenBSD compilation issue due to namespace collisions

2014-03-21 Thread Brad Smith
On 18/03/14 11:26 AM, Marcel Apfelbaum wrote: Machine rewriting added MACHINE macro which is already in use by other OpenBSD library. Since qemu/sockets.h exposes the OpenBSD namespace, the minimalistic approach is to add it as the first QEMU include. Reported-by: Brad Smith Signed-off-by: Marc

Re: [Qemu-devel] RFC - best way to organize a multiprotocol transport?

2014-03-21 Thread Anton Ivanov
On 21/03/14 13:14, Stefan Hajnoczi wrote: > On Fri, Mar 21, 2014 at 10:01:09AM +, Anton Ivanov wrote: >> I am wondering how to re-organize these so that the code is not >> duplicated across 3-4 drivers as well as allow people to easily add more >> encaps in the future. >> One way will be to pul

[Qemu-devel] [Bug 1295587] Re: Temporal freeze and slowdown while using emulated sb16

2014-03-21 Thread alvarez
** Description changed: I have been carrying around this bug since previous versions and on different machines: When I use the -soundhw sb16 option, while playing any sound on the virtual machine it temporally freezes the emulated machine and loops the last bit of such sound effect for 1-2

Re: [Qemu-devel] [PATCH 09/26] iscsi: migrate iscsi driver QemuOptionParameter usage

2014-03-21 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 02:42:35PM +0100, Peter Lieven wrote: > On 21.03.2014 14:31, Leandro Dorileo wrote: > >On Fri, Mar 21, 2014 at 07:43:44AM +0100, Peter Lieven wrote: > >>On 21.03.2014 01:13, Leandro Dorileo wrote: > >>>Do the directly migration from QemuOptionParameter to QemuOpts on > >>>is

[Qemu-devel] [Bug 1295587] [NEW] Temporal freeze and slowdown while using emulated sb16

2014-03-21 Thread alvarez
Public bug reported: I have been carrying around this bug since previous versions and on different machines: When I use the -soundhw sb16 option, while playing any sound on the virtual machine it temporally freezes the emulated machine and loops the last bit of such sound effect for 1-2 minutes, t

[Qemu-devel] [Bug 1295587] Re: Temporal freeze and slowdown while using emulated sb16

2014-03-21 Thread alvarez
** Description changed: I have been carrying around this bug since previous versions and on different machines: When I use the -soundhw sb16 option, while playing any sound on the virtual machine it temporally freezes the emulated machine and loops the last bit of such sound effect for 1-2

[Qemu-devel] emulating a display, instead of just a dumb graphics card

2014-03-21 Thread Olaf Hering
Right now qemu does appearently just emulate a graphics card (Cirrus for example), but not an attached monitor/display. The result is confusion in the guest OS. The current DRM drivers in upstream Linux seem to default to VESA modes. These are either provided by qemu, or Xorg uses a fixed intern

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread 陈梁
> From: "Dr. David Alan Gilbert" > > This is a fix for a bug* triggered by a migration after hot unplugging > a few virtio-net NICs, that caused migration never to converge, because > 'migration_dirty_pages' is incorrectly initialised. > > 'migration_dirty_pages' is used as a tally of the numbe

Re: [Qemu-devel] [PATCH 09/26] iscsi: migrate iscsi driver QemuOptionParameter usage

2014-03-21 Thread Peter Lieven
On 21.03.2014 14:31, Leandro Dorileo wrote: On Fri, Mar 21, 2014 at 07:43:44AM +0100, Peter Lieven wrote: On 21.03.2014 01:13, Leandro Dorileo wrote: Do the directly migration from QemuOptionParameter to QemuOpts on iscsi block driver. Signed-off-by: Leandro Dorileo --- block/iscsi.c | 32 +

Re: [Qemu-devel] [PATCH 09/26] iscsi: migrate iscsi driver QemuOptionParameter usage

2014-03-21 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 01:31:42PM +, Leandro Dorileo wrote: > On Fri, Mar 21, 2014 at 07:43:44AM +0100, Peter Lieven wrote: > > On 21.03.2014 01:13, Leandro Dorileo wrote: > > >Do the directly migration from QemuOptionParameter to QemuOpts on > > >iscsi block driver. > > > > > >Signed-off-by:

Re: [Qemu-devel] [PATCH 09/26] iscsi: migrate iscsi driver QemuOptionParameter usage

2014-03-21 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 07:43:44AM +0100, Peter Lieven wrote: > On 21.03.2014 01:13, Leandro Dorileo wrote: > >Do the directly migration from QemuOptionParameter to QemuOpts on > >iscsi block driver. > > > >Signed-off-by: Leandro Dorileo > >--- > > block/iscsi.c | 32 -

[Qemu-devel] multihead & multiseat in qemu

2014-03-21 Thread Gerd Hoffmann
Hi, I'm thinking about how to handle multihead and multiseat in qemu best. On multihead: Mouse in virtual machines works best with absolute coordinates, and the way this is done today is to assign a (virtual) usb tablet to the guest. With multihead this becomes a bit difficuilt. Today we try

Re: [Qemu-devel] [PATCH] migration: static variables will not be reset at second migration

2014-03-21 Thread Juan Quintela
wrote: > From: ChenLiang > > The static variables in migration_bitmap_sync will not be reset in > the case of a second attempted migration. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei Good catch. Applied.. > --- > arch_init.c | 15 --- > 1 file changed, 12 insertions(+

Re: [Qemu-devel] [PATCH] migration: static variables will not be reset at second migration

2014-03-21 Thread Juan Quintela
wrote: > From: ChenLiang > > The static variables in migration_bitmap_sync will not be reset in > the case of a second attempted migration. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei Good catch. Applied.. > --- > arch_init.c | 15 --- > 1 file changed, 12 insertions(+

Re: [Qemu-devel] [PATCH 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-21 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Make qemu_peek_buffer repatedly call fill_buffer until it gets > all the data it requires, or until there is an error. > > At the moment, qemu_peek_buffer will try one qemu_fill_buffer if there > isn't enough data wait

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > This is a fix for a bug* triggered by a migration after hot unplugging > > a few virtio-net NICs, that caused migration never to converge, because > > 'migration_dirty_p

Re: [Qemu-devel] RFC - best way to organize a multiprotocol transport?

2014-03-21 Thread Stefan Hajnoczi
On Fri, Mar 21, 2014 at 10:01:09AM +, Anton Ivanov wrote: > I am wondering how to re-organize these so that the code is not > duplicated across 3-4 drivers as well as allow people to easily add more > encaps in the future. > One way will be to pull all common routines into a common file and hav

Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages

2014-03-21 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > This is a fix for a bug* triggered by a migration after hot unplugging > a few virtio-net NICs, that caused migration never to converge, because > 'migration_dirty_pages' is incorrectly initialised. Good catch. > 'migrat

[Qemu-devel] [PATCH for-2.0 1/2] mirror: fix throttling delay calculation

2014-03-21 Thread Stefan Hajnoczi
From: Paolo Bonzini The throttling delay calculation was using an inaccurate sector count to calculate the time to sleep. This broke rate-limiting for the block mirror job. Move the delay calculation into mirror_iteration() where we know how many sectors were transferred. This lets us calculat

[Qemu-devel] [PATCH for-2.0 2/2] mirror: fix early wake from sleep due to aio

2014-03-21 Thread Stefan Hajnoczi
The mirror blockjob coroutine rate-limits itself by sleeping. The coroutine also performs I/O asynchronously so it's important that the aio callback doesn't wake the coroutine early as that breaks rate-limiting. Reported-by: Joaquim Barrera Signed-off-by: Stefan Hajnoczi --- block/mirror.c | 9

[Qemu-devel] [PATCH v3 4/5] s390x/virtio-ccw: reference-counted indicators

2014-03-21 Thread Cornelia Huck
Make code using the same indicators point to a single allocated structure that is freed when the last user goes away. This will be used by the irqfd code to unmap addresses after the last user is gone. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 80 +

  1   2   >