Re: [Qemu-devel] [PATCH v22 08/25] cow.c: replace QEMUOptionParameter with QemuOpts

2014-03-19 Thread Chunyan Liu
2014-03-11 23:28 GMT+08:00 Eric Blake : > On 03/10/2014 01:31 AM, Chunyan Liu wrote: > > Signed-off-by: Dong Xu Wang > > Signed-off-by: Chunyan Liu > > --- > > block/cow.c | 54 ++ > > 1 file changed, 26 insertions(+), 28 deletions(-) > > > >

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-19 Thread Michael S. Tsirkin
On Wed, Mar 19, 2014 at 11:04:19AM +1030, Rusty Russell wrote: > Dave Airlie writes: > > So I'm looking at how best to do virtio gpu device error reporting, > > and how to deal with illegal stuff, > > > > I've two levels of errors I want to support, > > > > a) unrecoverable or bad guest kernel pro

Re: [Qemu-devel] Windows XP Setup hangs on Fedora FC20 install

2014-03-19 Thread Gerhard Wiesinger
On 17.03.2014 13:31, Cole Robinson wrote: Works fine here but I'm using AMD. Please file a Fedora bug against qemu, and include: - full qemu command line (if using libvirt: /var/log/libvirt/qemu/$vmname.log) - Any qemu stdout/stderr output - Check dmesg for any kvm errors - Try booting an older

[Qemu-devel] [PATCH v2 2/3] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu()

2014-03-19 Thread Chen Fan
introduce x86_cpu_topo_ids_from_index() to calculate the cpu topology information, and the compat old mode mechanism moved into there. remove unused funciton x86_apicid_from_cpu_idx(). Unit tests included. Signed-off-by: Chen Fan --- hw/i386/pc.c | 22 --- target-i386/cpu.c

[Qemu-devel] [PATCH v2 3/3] i386: introduce cpu QOM hierarchy tree

2014-03-19 Thread Chen Fan
add cpu-topology.h cpu-topology.c files for prebuilding cpu qom tree "/machine/node[X]/socket[Y]/core[Z]->link cpu" Signed-off-by: Chen Fan --- hw/i386/pc.c | 3 + target-i386/Makefile.objs | 2 +- target-i386/cpu-topology.c | 199 +

[Qemu-devel] [PATCH v2 0/3] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu

2014-03-19 Thread Chen Fan
at present, after hotplug a discontinuous cpu id on source, then done migration, on target, it will fail to add the unoccupied cpu id which was skipped at source, this cause is on target Qemu prebuild CPU with continuous cpu_index. so after migration, the cpu infrastructure bewteen source and targ

[Qemu-devel] [PATCH v2 1/3] cpu: introduce CpuTopoInfo structure for argument simplification

2014-03-19 Thread Chen Fan
Signed-off-by: Chen Fan Reviewed-by: Eduardo Habkost --- target-i386/topology.h | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/target-i386/topology.h b/target-i386/topology.h index 07a6c5f..e9ff89c 100644 --- a/target-i386/topology.h +++ b

Re: [Qemu-devel] [PATCH v1 2/4] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu()

2014-03-19 Thread Chen Fan
On Wed, 2014-03-19 at 16:27 -0300, Eduardo Habkost wrote: > On Wed, Mar 19, 2014 at 04:53:41PM +0800, Chen Fan wrote: > > introduce x86_cpu_topo_ids_from_index() to calculate the cpu topology > > information, and the compat old mode mechanism moved into there. > > remove unused funciton x86_apicid_

Re: [Qemu-devel] [PULL for 2.0 0/5] MinGW related patches

2014-03-19 Thread Stefan Weil
Am 20.03.2014 07:25, schrieb Stefan Weil: > This includes a patch for GTK (needed for MinGW, but not restricted to it) > and most of the patches which restructure the includes for the Win API. > I ommitted the last optional block patch. > > Stefan > > [PULL for 2.0 1/5] gtk: Support GTK without V

[Qemu-devel] [PULL for 2.0 0/5] MinGW related patches

2014-03-19 Thread Stefan Weil
This includes a patch for GTK (needed for MinGW, but not restricted to it) and most of the patches which restructure the includes for the Win API. I ommitted the last optional block patch. Stefan [PULL for 2.0 1/5] gtk: Support GTK without VTE [PULL for 2.0 2/5] w32: Add and use intermediate incl

[Qemu-devel] [PULL for 2.0 5/5] w32: Replace Windows specific data types in common header files

2014-03-19 Thread Stefan Weil
These header files are used by most QEMU source files. If they depend on windows.h, all those source files do so, too. All Windows specific data types which are replaced use identical definitions for the 32 and 64 bit Windows APIs. HANDLE, LONG and CRITICAL_SECTION are replaced by the compatible t

[Qemu-devel] [PULL for 2.0 1/5] gtk: Support GTK without VTE

2014-03-19 Thread Stefan Weil
GTK without VTE is needed for hosts which don't support VTE (for example all variants of MinGW), but it can also be reasonable for other hosts. Signed-off-by: Stefan Weil --- configure | 54 +- ui/gtk.c | 17 - 2 files chan

[Qemu-devel] [PULL for 2.0 4/5] w32: Reduce dependencies in sysemu/os-win32.h

2014-03-19 Thread Stefan Weil
Most *.o files depend on that file, but many of them don't need windows.h or winsock2.h. sysemu/os-win32.h only needs some definitions from winerror.h. After that change, all files which depend on windows.h or winsock2.h and which no longer get it indirectly have to be fixed. Use qemu/sockets.h to

[Qemu-devel] [PULL for 2.0 2/5] w32: Add and use intermediate include file for windows.h

2014-03-19 Thread Stefan Weil
Including windows.h from the new file include/qemu/winapi.h allows better tracking of the files which depend on the Windows API. 1864 *.o files depend on windows.h in a typical build, only 88 *.o files don't. The windows.h specific macro WIN32_LEAN_AND_MEAN is now defined in the new file and no l

[Qemu-devel] [PULL for 2.0 3/5] w32: Move inline function from header file to C source

2014-03-19 Thread Stefan Weil
A lot of files depend on qemu/timer.h. We don't want that all these files depend on windows.h, too. Signed-off-by: Stefan Weil --- include/qemu/timer.h |8 +--- util/qemu-timer-common.c | 11 ++- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/include/qemu/t

Re: [Qemu-devel] [PATCH v5 07/11] vfio: Add guest side IOMMU support

2014-03-19 Thread David Gibson
On Wed, Mar 19, 2014 at 01:57:41PM -0600, Alex Williamson wrote: > On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: > > From: David Gibson [snip] > > +if (!memory_region_is_ram(mr)) { > > +DPRINTF("iommu map to non memory area %"HWADDR_PRIx"\n", > > +xlat)

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-19 Thread Rusty Russell
Markus Armbruster writes: > Rusty Russell writes: >> The litmus test: does *your* guest handle failures other than by giving >> up on the device? If so, sure, you need to have a sane error-reporting >> strategy. > > Err, isn't this a circular argument? No need for QEMU to report the > failure,

Re: [Qemu-devel] [PATCH] spapr: Clear LPCR_ILE during reset

2014-03-19 Thread Alexey Kardashevskiy
On 03/20/2014 12:08 PM, Andreas Färber wrote: > Am 06.03.2014 05:06, schrieb Anton Blanchard: >> >> Since an OS can set LPCR_ILE we must clear it during reset. Otherwise >> if we reset into an OS with a different endian we die when we take >> the first exception. >> >> This fixes an issue seen on b

Re: [Qemu-devel] [PATCH v7 for 2.0 1/4] qapi: introduce PreallocMode and a new PreallocMode full.

2014-03-19 Thread Hu Tao
On Mon, Mar 17, 2014 at 08:58:48AM -0600, Eric Blake wrote: > On 03/17/2014 12:53 AM, Hu Tao wrote: > > This patch prepares for the subsequent patches. > > > > Reviewed-by: Fam Zheng > > Signed-off-by: Hu Tao > > --- > > block/qcow2.c| 8 > > qapi-schema.json | 14 ++ >

[Qemu-devel] [PULL for-2.0 13/13] spapr: Implement interface to fix device pathname

2014-03-19 Thread Andreas Färber
From: Alexey Kardashevskiy This extends the pseries machine type with the interface to fix firmware pathnames for devices which have @bootindex property. This fixes SCSI disks' device node names (which are wildcard nodes in the device-tree), for spapr-vscsi, virtio-scsi and usb-storage. This fi

[Qemu-devel] [PULL for-2.0 12/13] spapr: QOM'ify pseries machine

2014-03-19 Thread Andreas Färber
From: Alexey Kardashevskiy Signed-off-by: Alexey Kardashevskiy Signed-off-by: Andreas Färber --- hw/ppc/spapr.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 5c9a154..170e083 100644 --- a/hw/ppc/spapr.c +++ b/h

[Qemu-devel] [PULL for-2.0 11/13] spapr_vio: Fix firmware names

2014-03-19 Thread Andreas Färber
From: Alexey Kardashevskiy This changes VIO bridge fw name from spapr-vio-bridge to vdevice and vscsi/veth node names from QEMU object names to VIO specific device tree names. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Andreas Färber --- hw/ppc/spapr_vio.c | 3 +++ 1 file changed, 3 i

[Qemu-devel] [PULL for-2.0 10/13] spapr_llan: Add to boot device list

2014-03-19 Thread Andreas Färber
From: Alexey Kardashevskiy Signed-off-by: Alexey Kardashevskiy Signed-off-by: Andreas Färber --- hw/net/spapr_llan.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c index f6fbcb5..c47 100644 --- a/hw/net/spapr_llan.c +++ b/hw/net/spapr_llan.

[Qemu-devel] [PULL for-2.0 02/13] spapr_hcall: Fix h_enter to loop correctly

2014-03-19 Thread Andreas Färber
From: "Aneesh Kumar K.V" We wanted to loop till index is 8. On 8 we return with H_PTEG_FULL. If we are successful in loading hpte with any other index, we continue with that index value. Reported-by: Paolo Bonzini Signed-off-by: Aneesh Kumar K.V Reviewed-by: Paolo Bonzini Signed-off-by: Andre

[Qemu-devel] [PULL for-2.0 07/13] spapr_hcall: Fix little-endian resource handling in H_SET_MODE

2014-03-19 Thread Andreas Färber
From: Alexey Kardashevskiy This changes resource code definitions to ones used in the host kernel. This fixes H_SET_MODE_RESOURCE_LE (switch between big endian and little endian) to sync registers from KVM before changing LPCR value. This adds a set_spr() helper to update an SPR in a CPU's cont

[Qemu-devel] [PULL for-2.0 05/13] target-ppc: Force CPU threads count to be a power of 2

2014-03-19 Thread Andreas Färber
From: Bharata B Rao PowerPC kernel expects the number of SMT threads in a core to be a power of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel crash if invalid threads count is specified. Prevent this crash and make it a graceful exit from QEMU itself by validating the use

[Qemu-devel] [PULL for-2.0 01/13] target-ppc: Add missing 'static' and 'const' attributes

2014-03-19 Thread Andreas Färber
From: Stefan Weil This fixes warnings from the static code analysis (smatch). Signed-off-by: Stefan Weil Signed-off-by: Andreas Färber --- target-ppc/arch_dump.c | 6 +++--- target-ppc/int_helper.c | 2 +- target-ppc/machine.c| 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) di

[Qemu-devel] [PULL for-2.0 03/13] target-ppc: Reset SPRs on CPU reset

2014-03-19 Thread Andreas Färber
From: Alexey Kardashevskiy This resets SPR values to defaults on CPU reset. This should help with little-endian guests reboot issues. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Greg Kurz Signed-off-by: Andreas Färber --- target-ppc/cpu.h| 1 + target-ppc/translate_init.c |

[Qemu-devel] [PULL for-2.0 08/13] vl.c: Extend get_boot_devices_list() to ignore suffixes

2014-03-19 Thread Andreas Färber
From: Alexey Kardashevskiy As suffixes do not make sense for sPAPR's device tree and there is no way to filter them out on the BusState::get_fw_dev_path() level, let's add an ability for the external caller to specify whether to apply suffixes or not. We could handle suffixes in SLOF (ignored fo

[Qemu-devel] [PULL for-2.0 06/13] target-ppc: Introduce powerisa-207-server flag

2014-03-19 Thread Andreas Färber
From: Alexey Kardashevskiy This flag will be used to decide whether to emulate some bits of H_SET_MODE hypercall because some are POWER8-only. While we are here, add 2.05 flag to POWER8 family too. POWER7/7+ already have it. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Greg Kurz Signed-of

[Qemu-devel] [PULL for-2.0 04/13] target-ppc: Fix overallocation of opcode tables

2014-03-19 Thread Andreas Färber
From: Stuart Brady create_new_table() should allocate 0x20 opc_handler_t pointers, but actually allocates 0x20 opc_handler_t structs. Fix this. Signed-off-by: Stuart Brady Reviewed-by: Tom Musta Tested-by: Tom Musta Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 2 +- 1 fi

[Qemu-devel] [PULL for-2.0 09/13] qdev: Introduce FWPathProvider interface

2014-03-19 Thread Andreas Färber
From: Paolo Bonzini QEMU supports firmware names for all devices in the QEMU tree but some architectures expect some parts of firmware path names in different format. This introduces a firmware-pathname-change interface definition. If some machines needs to redefine the firmware path format, it

[Qemu-devel] [PULL for-2.0-rc1 00/13] PowerPC patch queue 2014-03-20 #2

2014-03-19 Thread Andreas Färber
Hello Peter, Please pull the PowerPC queue into qemu.git master. Regards, Andreas Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: Alexander Graf Cc: Alexey Kardashevskiy Cc: Paolo Bonzini The following changes since commit 4c8821d13405056776d0255bb78925dac91996c3: Merge remote-tracking bra

Re: [Qemu-devel] [PATCH 0/8] spapr: fix IOMMU and XICS/IRQs migration

2014-03-19 Thread Andreas Färber
Am 14.03.2014 05:18, schrieb Alexey Kardashevskiy: > This initial problem came form libvirt - it does not preserve > the device order when running QEMU. So it is easy to get source QEMU with: > -device spapr-vscsi,id=scsi1,reg=0x2000 -device > spapr-vscsi,id=scsi0,reg=0x3000 > and destination QEMU

Re: [Qemu-devel] [PATCH 1/1] target-ppc: Adding Functionality to rtas_ibm_get_system_parameter.

2014-03-19 Thread Andreas Färber
Hi, Am 14.03.2014 17:10, schrieb Tomo Berry: > This patch adds the functionality for > rtas_ibm_get_system_parameter to return a string containing > the values for partition_max_entitled_capacity and > system_potential_processors. Unintentionally indented? > > Signed-off-by: Tomo Berry

Re: [Qemu-devel] [PATCH v1 0/4] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu

2014-03-19 Thread Chen Fan
On Wed, 2014-03-19 at 06:00 -0600, Eric Blake wrote: > On 03/19/2014 02:53 AM, Chen Fan wrote: > > at present, after hotplug a discontinuous cpu id on source, then done > > migration, > > on target, it will fail to add the unoccupied cpu id which was skipped at > > source, > > this cause is on ta

Re: [Qemu-devel] [PATCH] target-ppc: Add missing 'static' and 'const' attributes

2014-03-19 Thread Andreas Färber
Am 16.03.2014 14:49, schrieb Stefan Weil: > This fixes warnings from the static code analysis (smatch). > > Signed-off-by: Stefan Weil > --- > target-ppc/arch_dump.c |6 +++--- > target-ppc/int_helper.c |2 +- > target-ppc/machine.c|4 ++-- > 3 files changed, 6 insertions(+), 6

Re: [Qemu-devel] [PATCH] spapr: Clear LPCR_ILE during reset

2014-03-19 Thread Andreas Färber
Am 06.03.2014 05:06, schrieb Anton Blanchard: > > Since an OS can set LPCR_ILE we must clear it during reset. Otherwise > if we reset into an OS with a different endian we die when we take > the first exception. > > This fixes an issue seen on both full emulation and KVM. > > Signed-off-by: Anto

[Qemu-devel] [PATCH RFT for-2.0-rc1] make-release: Record SeaBIOS version

2014-03-19 Thread Andreas Färber
Before deleting .git, determine the version and save it in .version file. Cc: Gerd Hoffmann Signed-off-by: Andreas Färber --- scripts/make-release | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/make-release b/scripts/make-release index 186358d..fa6323f 100755 --- a/scripts/make-rel

Re: [Qemu-devel] [PATCH v7 5/6] spapr: QOM'fy machine

2014-03-19 Thread Andreas Färber
Am 17.03.2014 03:40, schrieb Alexey Kardashevskiy: > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v8: > * QOM'ed according to the latest rules from 2.0-rc0. Fixing up as follows: diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 43b9fcb..170e083 100644 --- a/hw/ppc/spapr.c +++ b/hw/pp

Re: [Qemu-devel] [PULL for-2.0-rc1 0/7] PReP patch queue 2014-03-20

2014-03-19 Thread Peter Maydell
On 19 March 2014 23:35, Andreas Färber wrote: > Hello Peter, > > Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: Alexander Graf > Cc: Hervé Poussineau > Cc: Mark Cave-Ayland > Cc: Artyom

Re: [Qemu-devel] [PATCH v5 0/3] spapr: fix H_SET_MODE

2014-03-19 Thread Andreas Färber
Am 20.03.2014 01:03, schrieb Alexey Kardashevskiy: > This fixes H_SET_MODE. > Changes: > v5: > * fixed code style > > v4: > * rebased on top of current ppc-next. > * changed PPC2_ISA207S flag value > > > Alexey Kardashevskiy (3): > target-ppc: introduce powerisa-207-server flag > spapr_hcall

[Qemu-devel] [PULL for-2.0 2/7] raven: Implement non-contiguous I/O region

2014-03-19 Thread Andreas Färber
From: Hervé Poussineau Remove now duplicated code from prep board. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/pci-host/prep.c | 85 hw/ppc/prep.c | 94 ++ 2 file

Re: [Qemu-devel] migrating instances from qemu-kvm to qemu

2014-03-19 Thread Cole Robinson
On 03/19/2014 12:16 PM, Serge E. Hallyn wrote: > Quoting Serge E. Hallyn (se...@hallyn.com): >> Quoting Paolo Bonzini (pbonz...@redhat.com): >>> Il 19/03/2014 16:42, Serge E. Hallyn ha scritto: Hi, at https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1291321 it was found th

[Qemu-devel] [PULL for-2.0 3/7] raven: Set a correct PCI I/O memory region

2014-03-19 Thread Andreas Färber
From: Hervé Poussineau PCI I/O region is 0x3f80 bytes starting at 0x8000. Do not use global QEMU I/O region, which is only 64KB. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/pci-host/prep.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions

[Qemu-devel] [PATCH v5 2/3] spapr_hcall: fix little-endian resource handling in H_SET_MODE

2014-03-19 Thread Alexey Kardashevskiy
This changes resource code definitions to ones used in the host kernel. This fixes H_SET_MODE_RESOURCE_LE (switch between big endian and little endian) to sync registers from KVM before changing LPCR value. This adds a set_spr() helper to update an SPR in a CPU's context to avoid possible races a

[Qemu-devel] [PATCH v5 0/3] spapr: fix H_SET_MODE

2014-03-19 Thread Alexey Kardashevskiy
This fixes H_SET_MODE. Changes: v5: * fixed code style v4: * rebased on top of current ppc-next. * changed PPC2_ISA207S flag value Alexey Kardashevskiy (3): target-ppc: introduce powerisa-207-server flag spapr_hcall: fix little-endian resource handling in H_SET_MODE spapr_hcall: add addres

[Qemu-devel] [PATCH v5 3/3] spapr_hcall: add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-03-19 Thread Alexey Kardashevskiy
This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from the H_SET_MODE, for POWER8 (PowerISA 2.07) only. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_hcall.c | 26 ++ target-ppc/cpu.h | 2 ++ 2 files changed, 28 insertions(+) diff --git a/hw/ppc/spa

[Qemu-devel] [PATCH v5 1/3] target-ppc: introduce powerisa-207-server flag

2014-03-19 Thread Alexey Kardashevskiy
This flag will be used to decide whether to emulate some bits of H_SET_MODE hypercall because some are POWER8-only. While we are here, add 2.05 flag to POWER8 family too. POWER7/7+ already have it. Signed-off-by: Alexey Kardashevskiy --- target-ppc/cpu.h| 2 ++ target-ppc/translate_

[Qemu-devel] [PULL for-2.0 5/7] raven: Add PCI bus mastering address space

2014-03-19 Thread Andreas Färber
From: Hervé Poussineau This has been tested on Linux 2.4/PPC with the lsi53c895a SCSI adapter. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/pci-host/prep.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/pci-host/prep.c b/hw/pci-host/pr

[Qemu-devel] [Bug 1294898] [NEW] gtk: menubar visible in fullscreen mode with gtk3

2014-03-19 Thread Cole Robinson
Public bug reported: Using the gtk UI, compiled with gtk3, the menu bar is fully visible in full screen mode. On gtk2 it's hidden. The set_size_request call isn't abided on gtk3 it seems. Simple fix is: diff --git a/ui/gtk.c b/ui/gtk.c index 66e886f..7b3bd3d 100644 --- a/ui/gtk.c +++ b/ui/gtk.c

[Qemu-devel] [PULL for-2.0 6/7] raven: Fix PCI bus accesses with size > 1

2014-03-19 Thread Andreas Färber
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Reviewed-by: Artyom Tarasenko Signed-off-by: Andreas Färber --- hw/pci-host/prep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 8109625..e452a91 100644 --- a/hw/

[Qemu-devel] [PULL for-2.0 7/7] raven: Use raven_ for all function prefixes

2014-03-19 Thread Andreas Färber
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/pci-host/prep.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index e452a91..d3e746c 100644 --- a

[Qemu-devel] [PULL for-2.0 4/7] raven: Set a correct PCI memory region

2014-03-19 Thread Andreas Färber
From: Hervé Poussineau PCI memory region is 0x3f00 bytes starting at 0xc000. However, keep compatibility with Open Hack'Ware expectations by adding a hack for Open Hack'Ware display. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/pci-host/prep.c | 9 ++--- h

[Qemu-devel] [PULL for-2.0 1/7] raven: Rename intack region to pci_intack

2014-03-19 Thread Andreas Färber
From: Hervé Poussineau Regions added subsequently will also have the pci_ prefix. Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/pci-host/prep.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 94fdf

[Qemu-devel] [PULL for-2.0-rc1 0/7] PReP patch queue 2014-03-20

2014-03-19 Thread Andreas Färber
Hello Peter, Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. Regards, Andreas Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: Alexander Graf Cc: Hervé Poussineau Cc: Mark Cave-Ayland Cc: Artyom Tarasenko The following changes since commit d1a1451cd3a60df7dbfd4fb

[Qemu-devel] [Bug 1224414] Re: dtc/.git file included in release tarball

2014-03-19 Thread Cole Robinson
Fixed upstream: commit 379e21c258d5faf0cd7c6f9208347726e14ae241 Author: Cole Robinson Date: Fri Mar 14 12:49:13 2014 -0400 scripts/make-release: Don't distribute .git directories ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you a

Re: [Qemu-devel] [PULL for-2.0-rc1 0/1] QOM CPUState patch queue 2014-03-19 #2

2014-03-19 Thread Peter Maydell
On 19 March 2014 21:53, Andreas Färber wrote: > Hello Peter, > > This is my current QOM CPU patch queue. Please pull. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: Anthony Liguori > > The following changes since commit f71e769d0754dc9a593a9e17ec6693a261b29f82: > > Merge remote-tracking br

Re: [Qemu-devel] [PATCH v4 4/7] raven: set a correct PCI memory region

2014-03-19 Thread Andreas Färber
Am 17.03.2014 23:00, schrieb Hervé Poussineau: > PCI memory region is 0x3f00 bytes starting at 0xc000. > > However, keep compatibility with Open Hack'Ware expectations > by adding a hack for Open Hack'Ware display. Have you taken a look whether we can fix this on the OHW side? I don't fee

Re: [Qemu-devel] [PATCH v4 2/7] raven: implement non-contiguous I/O region

2014-03-19 Thread Andreas Färber
Am 17.03.2014 23:00, schrieb Hervé Poussineau: > +static uint64_t raven_io_read(void *opaque, hwaddr addr, > + unsigned int size) > +{ > +PREPPCIState *s = opaque; > +uint8_t buf[4]; > + > +addr = raven_io_address(s, addr); > +address_space_read(&s->pci_

Re: [Qemu-devel] [PATCH v2] ppc: Force CPU threads count to be a power of 2.

2014-03-19 Thread Andreas Färber
Am 19.03.2014 03:47, schrieb Bharata B Rao: > On Wed, Mar 05, 2014 at 06:59:29AM -0700, Eric Blake wrote: >> On 03/05/2014 01:32 AM, Bharata B Rao wrote: >>> PowerPC kernel expects the number of SMT threads in a core to be a power >>> of 2. Since QEMU doesn't enforce this, it leads to an early gues

Re: [Qemu-devel] Multiple pci buses

2014-03-19 Thread Andreas Färber
Am 17.03.2014 23:14, schrieb BALATON Zoltan: > On Mon, 17 Mar 2014, Andreas Färber wrote: >> In earlier times QEMU did not properly support multiple PCI bus domains. >> Some code in >> http://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci-host/uninorth.c;h=e72fe2a70b954bf5675ad0c8735fea6bad665be6;hb=HEAD

Re: [Qemu-devel] [PATCH v3 09/10] raven: fix PCI bus accesses with size > 1

2014-03-19 Thread Andreas Färber
Am 17.03.2014 22:55, schrieb Artyom Tarasenko: > Hi Andreas, > > On Mon, Mar 17, 2014 at 8:59 PM, Andreas Färber > wrote: >>> this patch seems still be missing in master. Is it causing any problems? >> >> It does not apply without the preceding patches. Here's my cherry-pick >> result: >> [...]

Re: [Qemu-devel] [PATCH v3 09/10] raven: fix PCI bus accesses with size > 1

2014-03-19 Thread Andreas Färber
Am 17.03.2014 23:25, schrieb Hervé Poussineau: > Hi, > Le lun. 17 mars 2014 22:55:37 CET, Artyom Tarasenko a écrit : > [...] >>> BTW another unresolved issue that's been discussed is whether we should >>> change the default CPU for -M prep. I've been open to doing so for 2.0 >>> but would like some

Re: [Qemu-devel] [PULL for-2.0-rc1 0/7] QOM devices patch queue 2014-03-19

2014-03-19 Thread Peter Maydell
On 19 March 2014 21:45, Andreas Färber wrote: > Hello Peter, > > This is my QOM (devices) patch queue. Please pull. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: Anthony Liguori > > Cc: Stefan Hajnoczi > > The following changes since commit f71e769d0754dc9a593a9e17ec6693a261b29f82: > > M

Re: [Qemu-devel] [PATCH] virtio-net: Do not filter VLANs without F_CTRL_VLAN

2014-03-19 Thread Stefan Fritsch
Hi, Am Dienstag, 25. Februar 2014, 11:06:33 schrieb Amos Kong: > > > On Wed, Feb 12, 2014 at 10:46:28PM +0100, Stefan Fritsch wrote: > > > > If VIRTIO_NET_F_CTRL_VLAN is not negotiated, do not filter out > > > > all > > > > VLAN-tagged packets but send them to the guest. AFAICS, no fix has been

[Qemu-devel] [PATCH v2] sparc32 : Signed integer division overflow

2014-03-19 Thread Olivier Danet
The signed integer division -0x8000___ / -1 must be handled separately to avoid an overflow on the QEMU host. Signed-off-by: Olivier Danet --- target-sparc/helper.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target-sparc/helper.c b/target-sparc/

[Qemu-devel] USB passthru of hub

2014-03-19 Thread Stuart Yoder
Hi Gerd, In the "USB 2.0 Quick Start" write-up you said about USB passthrough: > (2) hostbus+hostport -- match for a specific physical port in the > host, any device which is plugged in there gets passed to the > guest A customer is asking what happens if a USB hub is plugged into the

[Qemu-devel] [PULL for-2.0 1/7] vl.c: Fix memory leak in qemu_register_machine()

2014-03-19 Thread Andreas Färber
From: Christian Borntraeger Since commit 261747f176f6 (vl: Use MachineClass instead of global QEMUMachine list) valgrind complains about the following: ==54082== 57 bytes in 3 blocks are definitely lost in loss record 365 of 729 ==54082==at 0x4031AFE: malloc (vg_replace_malloc.c:292) ==54082

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Fix overallocation of opcode tables

2014-03-19 Thread Andreas Färber
Am 19.03.2014 16:14, schrieb Tom Musta: > On 3/19/2014 9:07 AM, Stuart Brady wrote: >> create_new_table() should allocate 0x20 opc_handler_t pointers, but >> actually allocates 0x20 opc_handler_t structs. Fix this. >> >> Signed-off-by: Stuart Brady > > Reviewed-by: Tom Musta > Tested-by: Tom Mu

Re: [Qemu-devel] [PATCH] cpu: Move tcg_exit_req to the end of CPUState

2014-03-19 Thread Richard Henderson
On 03/19/2014 02:13 PM, Andreas Färber wrote: > Am 19.03.2014 22:04, schrieb Richard Henderson: >> Ping? This is a significant TCG code size regression >> for ARM, AArch64, and Sparc hosts. It helps x86 too, >> though that's not as severe. > > Sorry, applied to qom-cpu now: > https://github.com/

[Qemu-devel] [PULL for-2.0-rc1 0/7] QOM devices patch queue 2014-03-19

2014-03-19 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. Regards, Andreas Cc: Peter Maydell Cc: Anthony Liguori Cc: Stefan Hajnoczi The following changes since commit f71e769d0754dc9a593a9e17ec6693a261b29f82: Merge remote-tracking branch 'remotes/afaerber/tags/qom-cpu-for-2.0' int

Re: [Qemu-devel] [PATCH v2 for-2.0] target-i386: x86_cpu_get_phys_page_debug(): support 1GB page translation

2014-03-19 Thread Andreas Färber
Am 19.03.2014 22:03, schrieb Luiz Capitulino: > Linux guests, when using more than 4GB of RAM, may end up using 1GB pages > to store (kernel) data. When this happens, we're unable to debug a running > Linux kernel with GDB: > > (gdb) p node_data[0]->node_id > Cannot access memory at address 0x

[Qemu-devel] [PULL for-2.0 2/7] vl.c: Fix OpenBSD compilation issue due to namespace collisions

2014-03-19 Thread Andreas Färber
From: Marcel Apfelbaum Machine rewriting added MACHINE() macro which is already in use by other OpenBSD library. Since qemu/sockets.h exposes the OpenBSD namespace, the minimalistic approach is to add it as the first QEMU include. Reported-by: Brad Smith Signed-off-by: Marcel Apfelbaum Signed-

[Qemu-devel] [PULL for-2.0 7/7] virtio-rng: Avoid default_backend refcount leak

2014-03-19 Thread Andreas Färber
From: Stefan Hajnoczi QOM child properties take a reference to the object and release it when the property is deleted. Therefore we should unref the default_backend after we have added it as a child property. Cc: KONRAD Frederic Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Signe

[Qemu-devel] [PULL for-2.0 1/1] cpu: Move tcg_exit_req to the end of CPUState

2014-03-19 Thread Andreas Färber
From: Richard Henderson Reverse an increase in the size of generated code. Signed-off-by: Richard Henderson Signed-off-by: Andreas Färber --- include/qom/cpu.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 06ee263..f99885

[Qemu-devel] [PULL for-2.0-rc1 0/1] QOM CPUState patch queue 2014-03-19 #2

2014-03-19 Thread Andreas Färber
Hello Peter, This is my current QOM CPU patch queue. Please pull. Regards, Andreas Cc: Peter Maydell Cc: Anthony Liguori The following changes since commit f71e769d0754dc9a593a9e17ec6693a261b29f82: Merge remote-tracking branch 'remotes/afaerber/tags/qom-cpu-for-2.0' into staging (2014-03-

[Qemu-devel] [PULL for-2.0 6/7] qom: Add check() argument to object_property_add_link()

2014-03-19 Thread Andreas Färber
From: Stefan Hajnoczi There are currently three types of object_property_add_link() callers: 1. The link property may be set at any time. 2. The link property of a DeviceState instance may only be set before realize. 3. The link property may never be set, it is read-only. Something similar c

[Qemu-devel] [PULL for-2.0 4/7] qom: Don't make link NULL on object_property_set_link() failure

2014-03-19 Thread Andreas Färber
From: Stefan Hajnoczi The error behavior of object_property_set_link() is dangerous. It sets the link property object to NULL if an error occurs. A setter function should either succeed or fail, it shouldn't leave the value NULL on failure. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bo

[Qemu-devel] [PULL for-2.0 3/7] qom: Split object_property_set_link()

2014-03-19 Thread Andreas Färber
From: Stefan Hajnoczi The path resolution logic in object_property_set_link() should be a separate function. This makes the code easier to read and maintain. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- qom/object.c | 60 +++

[Qemu-devel] [PULL for-2.0 5/7] qom: Make QOM link property unref optional

2014-03-19 Thread Andreas Färber
From: Stefan Hajnoczi Some object_property_add_link() callers expect property deletion to unref the link property object. Other callers expect to manage the refcount themselves. The former are currently broken and therefore leak the link property object. This patch adds a flags argument to obj

Re: [Qemu-devel] [PATCH RESEND v4 0/5] qom: link property fixes

2014-03-19 Thread Andreas Färber
Am 19.03.2014 16:55, schrieb Paolo Bonzini: > Il 19/03/2014 08:58, Stefan Hajnoczi ha scritto: >> [Due to a horrible accident, the subject line was chopped off while >> sending >> this series. This is a resend, I have glued the subject line back on >> so patch >> management tools can make sense of

Re: [Qemu-devel] [PATCH RESEND v4 4/5] qom: add check() argument to object_property_add_link()

2014-03-19 Thread Andreas Färber
Am 19.03.2014 08:58, schrieb Stefan Hajnoczi: > diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h > index 3c000ee..68aaed6 100644 > --- a/include/hw/qdev-properties.h > +++ b/include/hw/qdev-properties.h > @@ -204,4 +204,15 @@ void qdev_property_add_static(DeviceState *dev, P

[Qemu-devel] [RFC 3/5] virtio: use child aliases for virtio-blk transport properties

2014-03-19 Thread Stefan Hajnoczi
PCI, CCW, and legacy s390 virtio kept their own copy of VirtIOBlkConf and duplicated qdev properties from the virtio-blk device. The conf struct was then memcpy into the VirtIOBlock object's VirtIOBlkConf. This risks double-free since the same 'serial' property char* would be duplicated and freed

Re: [Qemu-devel] [PATCH RESEND v4 1/5] qom: split object_property_set_link()

2014-03-19 Thread Andreas Färber
Am 19.03.2014 08:58, schrieb Stefan Hajnoczi: > The path resolution logic in object_property_set_link() should be a > separate function. This makes the code easier to read and maintain. > > Signed-off-by: Stefan Hajnoczi > --- > qom/object.c | 59 +++-

Re: [Qemu-devel] [PATCH] cpu: Move tcg_exit_req to the end of CPUState

2014-03-19 Thread Andreas Färber
Am 19.03.2014 22:04, schrieb Richard Henderson: > Ping? This is a significant TCG code size regression > for ARM, AArch64, and Sparc hosts. It helps x86 too, > though that's not as severe. Sorry, applied to qom-cpu now: https://github.com/afaerber/qemu-cpu/commits/qom-cpu How did you find this?

[Qemu-devel] [PATCH] target-arm: Implement XScale cache lockdown operations as NOPs

2014-03-19 Thread Peter Maydell
XScale defines some implementation-specific coprocessor registers for doing cache lockdown operations. Since QEMU doesn't model a cache no proper implementation is possible, but NOP out the registers so that guest code like u-boot that tries to use them doesn't crash. Reported-by: Signed-off-by:

Re: [Qemu-devel] [PATCH] cpu: Move tcg_exit_req to the end of CPUState

2014-03-19 Thread Richard Henderson
Ping? This is a significant TCG code size regression for ARM, AArch64, and Sparc hosts. It helps x86 too, though that's not as severe. r~ On 03/14/2014 03:30 PM, Richard Henderson wrote: > Reverse an increase in the size of generated code. > > Cc: Andreas Färber > Signed-off-by: Richard Hend

[Qemu-devel] [PATCH v2 for-2.0] target-i386: x86_cpu_get_phys_page_debug(): support 1GB page translation

2014-03-19 Thread Luiz Capitulino
Linux guests, when using more than 4GB of RAM, may end up using 1GB pages to store (kernel) data. When this happens, we're unable to debug a running Linux kernel with GDB: (gdb) p node_data[0]->node_id Cannot access memory at address 0x88013fffd3a0 (gdb) GDB returns this error because x86_cpu

Re: [Qemu-devel] qemu freezes while writing into coprocessor register

2014-03-19 Thread Peter Maydell
On 19 March 2014 08:29, wrote: >> Od: Peter Maydell >>That said, we don't implement whatever 0, c9, c1, 1 is on PXA261 >>(and so we will UNDEF it, resulting probably in the effects listed >>above). What do you expect it to do? > > This is the piece of code with comments: > /* > * Enable MMU to

Re: [Qemu-devel] [PATCH v5 05/11] vfio: Introduce VFIO address spaces

2014-03-19 Thread Alex Williamson
On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: > From: David Gibson > > The only model so far supported for VFIO passthrough devices is the model > usually used on x86, where all of the guest's RAM is mapped into the > (host) IOMMU and there is no IOMMU visible in the guest. > >

Re: [Qemu-devel] [PATCH v5 00/11] vfio on spapr-ppc64

2014-03-19 Thread Alex Williamson
On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: > Yet another try with VFIO on SPAPR (server PPC64). > As the previous try was too long time ago, I did not bother with > the change log much as all of this requires review again. Also, > it depends on these 2 patchsets which I cannot g

Re: [Qemu-devel] [PATCHv2] vl.c: Fix memory leak in qemu_register_machine

2014-03-19 Thread Andreas Färber
Am 19.03.2014 14:21, schrieb Michael S. Tsirkin: > On Wed, Mar 19, 2014 at 12:24:27PM +0100, Christian Borntraeger wrote: >> since commit 261747f176f6 (vl: Use MachineClass instead of global >> QEMUMachine list) valgrind complains about the following: >> >> ==54082== 57 bytes in 3 blocks are defini

Re: [Qemu-devel] [PATCH v5 06/11] vfio: Create VFIOAddressSpace objects as needed

2014-03-19 Thread Alex Williamson
On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: > From: David Gibson > > So far, VFIO has a notion of different logical DMA address spaces, but > only ever uses one (system memory). This patch extends this, creating > new VFIOAddressSpace objects as necessary, according to the Add

Re: [Qemu-devel] [PATCH v5 10/11] spapr-vfio: add spapr-pci-vfio-host-bridge to support vfio

2014-03-19 Thread Alex Williamson
On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: > The patch adds a spapr-pci-vfio-host-bridge device type > which is a PCI Host Bridge with VFIO support. The new device > inherits from the spapr-pci-host-bridge device and adds > the following properties: > iommu - IOMMU group I

Re: [Qemu-devel] [PATCH v5 07/11] vfio: Add guest side IOMMU support

2014-03-19 Thread Alex Williamson
On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: > From: David Gibson > > This patch uses the new IOMMU notifiers to allow VFIO pass through devices > to work with guest side IOMMUs, as long as the host-side VFIO iommu has > sufficient capability and granularity to match the guest s

Re: [Qemu-devel] [PATCH v5 11/11] spapr-vfio: enable for spapr

2014-03-19 Thread Alex Williamson
On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: > This turns the sPAPR support on and enables VFIO container use > in the kernel. > > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v5: > * multiple returns converted to gotos > > v4: > * fixed format string to use %m which

Re: [Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-19 Thread Paolo Bonzini
Il 19/03/2014 18:32, Eric Blake ha scritto: + * + * Copyright (C) 2014 Red Hat, Inc. + * + * Authors: + * Markus Armbruster + * Paolo Bonzini + * + * This work is licensed under the terms of the GNU GPL, version 2 or, at your + * option, any later version. See the COPYING file in the top-lev

Re: [Qemu-devel] migrating instances from qemu-kvm to qemu

2014-03-19 Thread Paolo Bonzini
Il 19/03/2014 18:46, Dr. David Alan Gilbert ha scritto: * Serge E. Hallyn (se...@hallyn.com) wrote: Quoting Dr. David Alan Gilbert (dgilb...@redhat.com): * Serge E. Hallyn (se...@hallyn.com) wrote: Although, some people are using newer qemu with '-M pc-1.0'. So we'd be stopping thing from mi

Re: [Qemu-devel] [PULL for-2.0-rc1 0/1] QOM CPUState patch queue 2014-03-19

2014-03-19 Thread Peter Maydell
On 19 March 2014 18:52, Andreas Färber wrote: > Hello Peter, > > This is my current QOM CPU patch queue. Please pull. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: Anthony Liguori > > Cc: Eduardo Habkost > Cc: Igor Mammedov > > The following changes since commit ec864874bd1c1e13c82f4096fd

  1   2   3   >