[Qemu-devel] [PATCH RFC] virtio-net: announce self by guest

2014-03-12 Thread Jason Wang
It's hard to track all mac addresses and their configurations (e.g vlan or ipv6)in qemu. Without those information, it's impossible to build proper garp packet after migration. The only possible solution to this is let guest ( who knew all configurations) to do this. So, this patch introduces a ne

[Qemu-devel] [Bug 1290370] Re: FreeBSD 9.2 shell crashes when run with -smp 4 option

2014-03-12 Thread prajeeth
** Description changed: This is a bug that i have noticed in qemu 1.7.50 as well as 1.1.50. It was the latter that forced me to clone the repository to check if this is the case with the resent version as well . The latest commit on which the bug is found is f53f3d0a00b6df39ce8dfca942608e5

[Qemu-devel] [PATCH] spapr: add ibm, chip-id property in device tree

2014-03-12 Thread Alexey Kardashevskiy
This adds a "ibm,chip-id" property for CPU nodes which should be the same for all cores in the same CPU socket. The recent guest kernels use this information to associate threads with sockets. Refer to the kernel commit 256f2d4b463d3030ebc8d2b54f427543814a2bdc for more details. Signed-off-by: Ale

Re: [Qemu-devel] [PATCH v22 05/25] add some QemuOpts functions for replace work

2014-03-12 Thread Chunyan Liu
2014-03-12 20:40 GMT+08:00 Eric Blake : > On 03/11/2014 09:10 PM, Chunyan Liu wrote: > > > >>> Could be if changing qemu_opt_get return value type, but just as said > >>> before, > >>> that will affect many codes. > >> > >> Also, changing an existing function that returns 'const char *' into

Re: [Qemu-devel] [PATCH v5 2/6] qdev: introduce FWPathProvider interface

2014-03-12 Thread Alexey Kardashevskiy
On 03/13/2014 05:07 AM, Andreas Färber wrote: > Am 20.02.2014 14:50, schrieb Alexey Kardashevskiy: >> QEMU supports firmware names for all devices in the QEMU tree but >> some architectures expect some parts of firmware path names in different >> format. >> >> This introduces a firmware-pathname-ch

Re: [Qemu-devel] [PATCH v5 1/6] boot: extend get_boot_devices_list() to ignore suffixes

2014-03-12 Thread Alexey Kardashevskiy
On 02/21/2014 01:05 AM, Paolo Bonzini wrote: > Il 20/02/2014 15:03, Alexey Kardashevskiy ha scritto: >> On 02/21/2014 12:55 AM, Paolo Bonzini wrote: >>> Il 20/02/2014 14:50, Alexey Kardashevskiy ha scritto: As suffixes do not make sense for sPAPR's device tree and there is no way to filte

[Qemu-devel] [PULL for-2.0-rc0 6/6] spapr-pci: Convert fprintf() to error_report()

2014-03-12 Thread Andreas Färber
From: Alexey Kardashevskiy Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day Signed-off-by: Andreas Färber --- hw/ppc/spapr_pci.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index f737493..3c54399 100644 --- a/hw

[Qemu-devel] [PULL for-2.0-rc0 5/6] spapr-pci: Convert to QOM realize

2014-03-12 Thread Andreas Färber
From: Alexey Kardashevskiy This converts the old-style SysBusDevice::init() callback to a new-style DeviceClass::realize() callback. As a part of conversion, this replaces fprintf(stderr) with error_setg() as realize() does not "return" any value, instead it puts the extended error into **errp.

[Qemu-devel] [PULL for-2.0-rc0 2/6] Move QEMUMachine typedef to qemu/typedefs.h

2014-03-12 Thread Andreas Färber
As reported in commit 9c06a1f79f959fffd09bfb7efc3d76051a6cd2da, xen.h is not self-contained with regards to its use of QEMUMachine. Fix this. Reported-by: Alexander Graf Suggested-by: Paolo Bonzini Signed-off-by: Andreas Färber --- include/hw/boards.h | 2 -- include/qemu/typedefs.h | 1 +

[Qemu-devel] [PULL for-2.0-rc0 4/6] xics-kvm: Fix reset function

2014-03-12 Thread Andreas Färber
From: Alexey Kardashevskiy Currently interrupt priorities are set to 0 (highest) at the very beginning of the guest execution which is not correct and makes the guest produce random interrupt error messages such as: "Interrupt 0x1001 (real) is invalid, disabling it". This also prevents interrupt

[Qemu-devel] [PULL for-2.0-rc0 1/6] Revert "KVM: Split QEMUMachine typedef into separate header"

2014-03-12 Thread Andreas Färber
This reverts commit 9c06a1f79f959fffd09bfb7efc3d76051a6cd2da. The new header sysemu/qemumachine.h is undesired. Suggested-by: Paolo Bonzini Signed-off-by: Andreas Färber --- include/hw/boards.h | 3 ++- include/hw/xen/xen.h | 1 - include/sysemu/kvm.h | 1 - include/

[Qemu-devel] [PULL for-2.0-rc0 0/6] PowerPC patch queue 2014-03-13

2014-03-12 Thread Andreas Färber
Hello Peter, Please pull the PowerPC queue into qemu.git master. Regards, Andreas Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: Alexander Graf Cc: Alexey Kardashevskiy Cc: Paolo Bonzini The following changes since commit 2c3445bb850fbfb4481e9487d8852f10e8c74e4c: Merge remote-tracking bra

Re: [Qemu-devel] [PATCH v22 01/25] add def_value_str to QemuOptDesc

2014-03-12 Thread Chunyan Liu
2014-03-12 16:27 GMT+08:00 Stefan Hajnoczi : > On Wed, Mar 12, 2014 at 10:45:57AM +0800, Chunyan Liu wrote: > > 2014-03-11 21:29 GMT+08:00 Stefan Hajnoczi : > > > > > On Mon, Mar 10, 2014 at 03:31:37PM +0800, Chunyan Liu wrote: > > > > Add def_value_str (default value) to QemuOptDesc, to replace >

Re: [Qemu-devel] [PATCH 2/2] tests-ppc64: test for -device spapr-pci-host-bridge

2014-03-12 Thread Andreas Färber
Am 06.03.2014 02:59, schrieb Alexey Kardashevskiy: > On 03/06/2014 07:42 AM, Andreas Färber wrote: >> Am 14.02.2014 05:05, schrieb Alexey Kardashevskiy: >>> On 02/11/2014 02:48 AM, Andreas Färber wrote: Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy: > This adds a test if SPAPR PHB can

Re: [Qemu-devel] [PATCH 2/4] spapr-pci: introduce a finish_realize() callback

2014-03-12 Thread Andreas Färber
Am 21.11.2013 05:08, schrieb Alexey Kardashevskiy: > The spapr-pci PHB initializes IOMMU for emulataed devices only. "emulated" > The upcoming VFIO support will do it different. However both emulated > and VFIO PHB types share most of the initialization code. > For the type specific things a new

Re: [Qemu-devel] [PATCH 4/4] spapr-pci: converts fprintf to error_report

2014-03-12 Thread Andreas Färber
Am 21.11.2013 05:08, schrieb Alexey Kardashevskiy: > Signed-off-by: Alexey Kardashevskiy > --- > hw/ppc/spapr_pci.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, applied to ppc-next with the #include: https://github.com/afaerber/qemu-cpu/commits/ppc-next Andreas -- S

Re: [Qemu-devel] [PATCH 3/4] spapr-pci: add spapr_pci trace

2014-03-12 Thread Andreas Färber
Am 21.11.2013 05:08, schrieb Alexey Kardashevskiy: > Signed-off-by: Alexey Kardashevskiy > --- > trace-events | 1 + > 1 file changed, 1 insertion(+) Unused trace event? Andreas > > diff --git a/trace-events b/trace-events > index 8695e9e..ba5f76c 100644 > --- a/trace-events > +++ b/trace-eve

Re: [Qemu-devel] [PATCH 1/4] spapr-pci: convert init() callback to realize()

2014-03-12 Thread Andreas Färber
Am 21.11.2013 05:08, schrieb Alexey Kardashevskiy: > This converts the old-style init() callback to a new style realize() > callback as init() now is supposed to do only trivial initialization. > > As a part of convertion, this replaces fprintf(stderr) with error_setg() > as realize() does not "re

Re: [Qemu-devel] [PATCH v5 2/6] qdev: introduce FWPathProvider interface

2014-03-12 Thread Alexey Kardashevskiy
On 03/13/2014 10:38 AM, Andreas Färber wrote: > Am 13.03.2014 00:02, schrieb Alexey Kardashevskiy: >> On 03/13/2014 05:07 AM, Andreas Färber wrote: >>> Am 20.02.2014 14:50, schrieb Alexey Kardashevskiy: QEMU supports firmware names for all devices in the QEMU tree but some architectures e

Re: [Qemu-devel] [PATCH qom-cpu v2 34/40] exec: Change cpu_abort() argument to CPUState

2014-03-12 Thread Andreas Färber
Am 13.03.2014 00:28, schrieb Andreas Färber: > Am 10.03.2014 01:15, schrieb Andreas Färber: >> Signed-off-by: Andreas Färber > > The m68k assert patch requires the following on top: > > diff --git a/target-m68k/translate.c b/target-m68k/translate.c > index dff1e58..cd66289 100644 > --- a/target-

Re: [Qemu-devel] [PATCH qom-cpu v2 16/40] cpu: Move exception_index field from CPU_COMMON to CPUState

2014-03-12 Thread Andreas Färber
Am 11.03.2014 23:29, schrieb Andreas Färber: > Am 10.03.2014 01:15, schrieb Andreas Färber: >> Signed-off-by: Andreas Färber > > Needs: > > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c > index 8434f6e..931536e 100644 > --- a/target-arm/op_helper.c > +++ b/target-arm/op_helper.c >

Re: [Qemu-devel] [PATCH qom-cpu v2 19/40] cpu: Move breakpoints field from CPU_COMMON to CPUState

2014-03-12 Thread Stuart Brady
On Thu, Mar 13, 2014 at 12:59:01AM +0100, Andreas Färber wrote: > Am 13.03.2014 00:08, schrieb Stuart Brady: > > On Mon, Mar 10, 2014 at 01:15:28AM +0100, Andreas Färber wrote: > >> Most targets were using offsetof(CPUFooState, breakpoints) to determine > >> how much of CPUFooState to clear on rese

Re: [Qemu-devel] [PATCH v2 4/4] pc: Refuse max_cpus if it results in too large APIC ID

2014-03-12 Thread Eduardo Habkost
On Wed, Mar 12, 2014 at 11:07:38PM +0100, Laszlo Ersek wrote: > comments below > > On 03/12/14 19:28, Eduardo Habkost wrote: > > This changes the PC initialization code to reject max_cpus if it results > > in an APIC ID that's too large, instead of aborting or erroring out when > > it is already t

Re: [Qemu-devel] [PATCH qom-cpu v2 37/40] cputlb: Change tlb_flush_page() argument to CPUState

2014-03-12 Thread Andreas Färber
Am 11.03.2014 16:05, schrieb Max Filippov: > On Mon, Mar 10, 2014 at 4:15 AM, Andreas Färber wrote: >> diff --git a/target-xtensa/op_helper.c b/target-xtensa/op_helper.c >> index 624ef54..612d3bf 100644 >> --- a/target-xtensa/op_helper.c >> +++ b/target-xtensa/op_helper.c >> @@ -730,21 +730,24 @@

Re: [Qemu-devel] [PATCH v2 1/4] acpi: Add ACPI_CPU_HOTPLUG_ID_LIMIT macro

2014-03-12 Thread Laszlo Ersek
On 03/13/14 01:12, Eduardo Habkost wrote: > On Wed, Mar 12, 2014 at 10:18:56PM +0100, Laszlo Ersek wrote: >> On 03/12/14 22:17, Laszlo Ersek wrote: >>> On 03/12/14 19:28, Eduardo Habkost wrote: The new macro will be helpful to allow us to detect too large SMP limits before it is too late.

[Qemu-devel] [PULL for-2.0-rc0 v2 00/31] QOM devices patch queue 2014-03-12

2014-03-12 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. v2 changes qom-test. Regards, Andreas Cc: Peter Maydell Cc: Anthony Liguori Cc: Markus Armbruster Cc: Peter Crosthwaite Cc: Alexander Graf Cc: Stefan Hajnoczi Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Bandan Das The f

Re: [Qemu-devel] [PULL for-2.0-rc0 00/31] QOM devices patch queue 2014-03-12

2014-03-12 Thread Andreas Färber
Am 12.03.2014 23:42, schrieb Peter Maydell: > On 12 March 2014 21:09, Andreas Färber wrote: >> Hello Peter, >> >> This is my QOM (devices) patch queue. Please pull. > > Hi. I'm afraid this fails make check: > CCtests/qom-test.o > /home/petmay01/linaro/qemu-for-merges/tests/qom-test.c: In fu

Re: [Qemu-devel] [PATCH v2 1/4] acpi: Add ACPI_CPU_HOTPLUG_ID_LIMIT macro

2014-03-12 Thread Eduardo Habkost
On Wed, Mar 12, 2014 at 10:18:56PM +0100, Laszlo Ersek wrote: > On 03/12/14 22:17, Laszlo Ersek wrote: > > On 03/12/14 19:28, Eduardo Habkost wrote: > >> The new macro will be helpful to allow us to detect too large SMP limits > >> before it is too late. > >> > >> Signed-off-by: Eduardo Habkost >

Re: [Qemu-devel] [PATCH qom-cpu v2 19/40] cpu: Move breakpoints field from CPU_COMMON to CPUState

2014-03-12 Thread Andreas Färber
Am 13.03.2014 00:08, schrieb Stuart Brady: > On Mon, Mar 10, 2014 at 01:15:28AM +0100, Andreas Färber wrote: >> Most targets were using offsetof(CPUFooState, breakpoints) to determine >> how much of CPUFooState to clear on reset. Use the next field after >> CPU_COMMON instead, if any, or sizeof(CPU

Re: [Qemu-devel] [PATCH qom-cpu v2 04/40] target-ppc: Clean up ENV_GET_CPU() usage

2014-03-12 Thread Andreas Färber
Am 12.03.2014 23:56, schrieb Stuart Brady: > On Mon, Mar 10, 2014 at 01:15:13AM +0100, Andreas Färber wrote: >> Commits fdfba1a298ae26dd44bcfdb0429314139a0bc55a, >> ab1da85791340e504d10487e1add81b9988afa98, >> f606604f1c10b60ef294f1b9b229426521a365e3 and >> 2c17449b3022ca9623c4a7e2a504a4150ac4ad30

Re: [Qemu-devel] [PATCH] xics-kvm: fix reset function

2014-03-12 Thread Andreas Färber
Am 13.03.2014 00:00, schrieb Alexey Kardashevskiy: > On 03/13/2014 01:42 AM, Andreas Färber wrote: >> Am 04.03.2014 08:03, schrieb Alexey Kardashevskiy: >>> On 02/13/2014 12:08 PM, Alexey Kardashevskiy wrote: Currently interrupt priorities are set to 0 (highest) at the very beginning of t

Re: [Qemu-devel] [PATCH v5 2/6] qdev: introduce FWPathProvider interface

2014-03-12 Thread Andreas Färber
Am 13.03.2014 00:02, schrieb Alexey Kardashevskiy: > On 03/13/2014 05:07 AM, Andreas Färber wrote: >> Am 20.02.2014 14:50, schrieb Alexey Kardashevskiy: >>> QEMU supports firmware names for all devices in the QEMU tree but >>> some architectures expect some parts of firmware path names in different

Re: [Qemu-devel] Request for openhackware.git mirror

2014-03-12 Thread Mark Cave-Ayland
On 12/03/14 17:23, Andreas Färber wrote: So if I then apply the same trick to the .text section (patch attached) then I get a successful link and an output image. Mark, can you sign off .text part of the patch please for me to pick up? Never mind, pushed a minor variation with a Reported-by.

Re: [Qemu-devel] [PATCH v2 1/1] char/serial: Fix emptyness handling

2014-03-12 Thread Don Slutz
Ping. On 02/26/14 21:48, Don Slutz wrote: The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 char/serial: Fix emptyness check Still causes extra NULL byte(s) to be sent. So if the fifo is empty, do not send an extra NULL byte. Do full state change on fifo8_is_empty. Signed-off-by: Don Slutz

Re: [Qemu-devel] [PATCH qom-cpu v2 34/40] exec: Change cpu_abort() argument to CPUState

2014-03-12 Thread Andreas Färber
Am 10.03.2014 01:15, schrieb Andreas Färber: > Signed-off-by: Andreas Färber The m68k assert patch requires the following on top: diff --git a/target-m68k/translate.c b/target-m68k/translate.c index dff1e58..cd66289 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -2084,12 +

Re: [Qemu-devel] [PATCH] hw/i386: Use unaligned store functions building acpi tables

2014-03-12 Thread Peter Maydell
On 12 March 2014 22:25, Richard Henderson wrote: > Hosts that don't support native unaligned stores will SIGBUS > without additional help. > > Signed-off-by: Richard Henderson > --- > hw/i386/acpi-build.c | 29 +++-- > 1 file changed, 15 insertions(+), 14 deletions(-) > >

Re: [Qemu-devel] spapr-pci: convert init() callback to realize()

2014-03-12 Thread Alexey Kardashevskiy
On 03/13/2014 12:56 AM, Mike Day wrote: > On 21/11/13 15:08 +1100, Alexey Kardashevskiy wrote: >> This converts the old-style init() callback to a new style realize() >> callback as init() now is supposed to do only trivial initialization. >> >> As a part of convertion, this replaces fprintf(stderr

Re: [Qemu-devel] [PATCH qom-cpu v2 19/40] cpu: Move breakpoints field from CPU_COMMON to CPUState

2014-03-12 Thread Stuart Brady
On Mon, Mar 10, 2014 at 01:15:28AM +0100, Andreas Färber wrote: > Most targets were using offsetof(CPUFooState, breakpoints) to determine > how much of CPUFooState to clear on reset. Use the next field after > CPU_COMMON instead, if any, or sizeof(CPUFooState) otherwise. Would it not be easier and

Re: [Qemu-devel] [PATCH v5 2/6] qdev: introduce FWPathProvider interface

2014-03-12 Thread Alexey Kardashevskiy
On 03/13/2014 05:07 AM, Andreas Färber wrote: > Am 20.02.2014 14:50, schrieb Alexey Kardashevskiy: >> QEMU supports firmware names for all devices in the QEMU tree but >> some architectures expect some parts of firmware path names in different >> format. >> >> This introduces a firmware-pathname-ch

[Qemu-devel] [PULL for-2.0-rc0 08/31] misc/max111x: QOM casting sweep

2014-03-12 Thread Andreas Färber
From: Peter Crosthwaite Define and use QOM cast macro. Removes some usages of legacy casting systems. Signed-off-by: Peter Crosthwaite [AF: Rename parent field] Signed-off-by: Andreas Färber --- hw/misc/max111x.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] xics-kvm: fix reset function

2014-03-12 Thread Alexey Kardashevskiy
On 03/13/2014 01:42 AM, Andreas Färber wrote: > Am 04.03.2014 08:03, schrieb Alexey Kardashevskiy: >> On 02/13/2014 12:08 PM, Alexey Kardashevskiy wrote: >>> Currently interrupt priorities are set to 0 (highest) at the very >>> beginning of the guest execution which is not correct and makes the gue

[Qemu-devel] [PULL for-2.0-rc0 16/31] hw/boards: Convert current_machine to MachineState

2014-03-12 Thread Andreas Färber
From: Marcel Apfelbaum In order to allow attaching machine options to a machine instance, current_machine is converted into MachineState. As a first step of deprecating QEMUMachine, some of the functions were modified to return MachineClass. Signed-off-by: Marcel Apfelbaum Signed-off-by: Andrea

[Qemu-devel] [PULL for-2.0-rc0 11/31] spapr-pci: Change the default PCI bus naming

2014-03-12 Thread Andreas Färber
From: Alexey Kardashevskiy Previously libvirt required the first/default PCI bus to have name "pci". Since QEMU can support multiple buses now, libvirt wants "pci.0" now. This removes custom bus name and lets QEMU make up default names. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Andrea

[Qemu-devel] [PULL for-2.0-rc0 13/31] qdev-monitor-test: Don't test human-readable error message

2014-03-12 Thread Andreas Färber
From: Markus Armbruster Test the error class instead. Expecting a specific message is fragile. In fact, it broke once already, in commit 75884af. Restore the test of error member "class" dropped there, and drop the test of error member "desc". There are no other tests of "desc" as far as I ca

Re: [Qemu-devel] [PATCH v2 3/4] acpi: Assert sts array limit on AcpiCpuHotplug_add()

2014-03-12 Thread Laszlo Ersek
On 03/12/14 19:28, Eduardo Habkost wrote: > AcpiCpuHotplug_add() can't handle vCPU arch IDs larger than > ACPI_CPU_HOTPLUG_ID_LIMIT. Instead of corrupting memory in case the vCPU > ID is too large, use g_assert() to ensure we are not over the limit. > > Signed-off-by: Eduardo Habkost > --- > hw/

Re: [Qemu-devel] [PATCH qom-cpu v2 04/40] target-ppc: Clean up ENV_GET_CPU() usage

2014-03-12 Thread Stuart Brady
On Mon, Mar 10, 2014 at 01:15:13AM +0100, Andreas Färber wrote: > Commits fdfba1a298ae26dd44bcfdb0429314139a0bc55a, > ab1da85791340e504d10487e1add81b9988afa98, > f606604f1c10b60ef294f1b9b229426521a365e3 and > 2c17449b3022ca9623c4a7e2a504a4150ac4ad30 added usages of ENV_GET_CPU() > macro in target-i

[Qemu-devel] [PULL for-2.0-rc0 23/31] tests: Add virtio-serial qtest

2014-03-12 Thread Andreas Färber
Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/virtio-serial-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/virtio-serial-test.c diff --git a/tests/Makefile b/tests/Makefile index 75b4659..179667f 100644 --

[Qemu-devel] [PULL for-2.0-rc0 10/31] block/m25p80: Remove FROM_SSI_SLAVE() usages

2014-03-12 Thread Andreas Färber
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite [AF: Rename parent field] Signed-off-by: Andreas Färber --- hw/block/m25p80.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 02a1544..e29a738 100644 --- a/hw/block

[Qemu-devel] [PULL for-2.0-rc0 02/31] qdev: Set DeviceClass::hotpluggable default in class_init()

2014-03-12 Thread Andreas Färber
From: Igor Mammedov Move setting DeviceClass::hotpluggable default from device's class_base_init() to device's class_init(). Reported-by: Andreas Färber Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/core/qdev.c | 16 1 file changed, 8 insertions(+), 8 del

[Qemu-devel] [PULL for-2.0-rc0 03/31] qdev-monitor: Set properties after parent is assigned in device_add

2014-03-12 Thread Andreas Färber
From: Amos Kong Test steps: (qemu) device_add e1000,addr=adsf Property 'e1000.addr' doesn't take value 'adsf' (qemu) info qtree Then qemu crashed. Currently we set a link to the new device from its parent bus, but the device hasn't been added to QOM tree yet. When it fails to set propertie

Re: [Qemu-devel] [PATCH v2 1/4] acpi: Add ACPI_CPU_HOTPLUG_ID_LIMIT macro

2014-03-12 Thread Laszlo Ersek
On 03/12/14 19:28, Eduardo Habkost wrote: > The new macro will be helpful to allow us to detect too large SMP limits > before it is too late. > > Signed-off-by: Eduardo Habkost > --- > include/hw/acpi/cpu_hotplug_defs.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/include/hw

[Qemu-devel] [PULL for-2.0-rc0 22/31] tests: Add virtio-scsi qtest

2014-03-12 Thread Andreas Färber
Acked-by: Paolo Bonzini Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/virtio-scsi-test.c | 35 +++ 2 files changed, 38 insertions(+) create mode 100644 tests/virtio-scsi-test.c diff --git a/tests/Makefile b/tests/Makefile index 308a5

[Qemu-devel] qemu patch for adding functionality to rtas_ibm_get_system_parameter

2014-03-12 Thread Tomohiro B Berry
Hi all, rtas_ibm_get_system_parameter did not previously have the functionality to return the appropriate string when called with the SPLPAR_CHARACTERISTICS_TOKEN. I am proposing the following patch to add that functionality. I am including the cases for CMO_CHARACTERISTICS_TOKEN and CEDE_LA

[Qemu-devel] [PATCH] sparc32 : Signed integer division overflow

2014-03-12 Thread Olivier Danet
I wanted to test an integer divider for SPARC32, and tried the stress test program on QEMU, which choked on the division -0x8000___ / -1 (QEMU compiled on x86_64). Excerpt from the test program : --- #include typedef u

[Qemu-devel] [PULL for-2.0-rc0 18/31] tests: Clean up IndustryPack TPCI200 gcov paths

2014-03-12 Thread Andreas Färber
Signed-off-by: Andreas Färber --- tests/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index e146f81..1dc24c8 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -87,9 +87,9 @@ gcov-files-pci-y += hw/net/ne2000.c check-qtest-pci-y

[Qemu-devel] [PULL for-2.0-rc0 28/31] qdev: Prepare realize/unrealize hooks for BusState

2014-03-12 Thread Andreas Färber
From: Bandan Das Add a "realized" property calling realize/unrealize hooks as for devices. Signed-off-by: Bandan Das Signed-off-by: Andreas Färber --- hw/core/qdev.c | 41 + include/hw/qdev-core.h | 6 ++ 2 files changed, 47 insertions(+)

Re: [Qemu-devel] [PULL for-2.0-rc0 00/31] QOM devices patch queue 2014-03-12

2014-03-12 Thread Peter Maydell
On 12 March 2014 21:09, Andreas Färber wrote: > Hello Peter, > > This is my QOM (devices) patch queue. Please pull. Hi. I'm afraid this fails make check: CCtests/qom-test.o /home/petmay01/linaro/qemu-for-merges/tests/qom-test.c: In function ‘qmp’: /home/petmay01/linaro/qemu-for-merges/tests

Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions

2014-03-12 Thread Richard Henderson
On 03/10/2014 12:04 PM, Tom Musta wrote: > This patch series addresses concerns raised by Richard Henderson regarding > redundant > copies of Advanced Encryption Standard (AES) data and code (see > http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html). > > The patches declare com

[Qemu-devel] [Bug 1251470] Re: Guest not working in KVM mode but does in TCG mode

2014-03-12 Thread Serge Hallyn
For what it's worth, with 1.7.0+dfsg-3ubuntu6 and using the image FreeBSD-9.2-RELEASE-amd64-bootonly.iso kvm is working for me. ** Also affects: qemu (Ubuntu Saucy) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: New => Fix Released -- You received this b

[Qemu-devel] [PULL for-2.0-rc0 00/31] QOM devices patch queue 2014-03-12

2014-03-12 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. Regards, Andreas Cc: Peter Maydell Cc: Anthony Liguori Cc: Markus Armbruster Cc: Peter Crosthwaite Cc: Alexander Graf Cc: Stefan Hajnoczi Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Bandan Das The following changes since

Re: [Qemu-devel] [PATCH 5/6] target-arm: Use Common Tables in AES Instructions

2014-03-12 Thread Richard Henderson
On 03/10/2014 12:05 PM, Tom Musta wrote: > +static uint8_t const *sbox[2] = { AES_sbox, AES_isbox }; Missing const: static uint8_t const * const sbox[2] = ... r~

[Qemu-devel] [PULL for-2.0-rc0 01/31] qdev: Fix bus dependency of DeviceState::hotpluggable getter

2014-03-12 Thread Andreas Färber
Commit 1a37eca107cece3ed454bae29eef0bd1fac4a244 (qdev: add "hotpluggable" property to Device) added a property "hotpluggable" to each device, with its getter accessing parent_bus->allow_hotplug. Add a NULL check. Cc: Igor Mammedov Signed-off-by: Andreas Färber --- hw/core/qdev.c | 3 ++- 1 fil

[Qemu-devel] [PULL for-2.0-rc0 29/31] qdev: Realize buses on device realization

2014-03-12 Thread Andreas Färber
From: Bandan Das Integrate (un)realization of child buses with realization/unrealization of the device hosting them. Code in device_unparent() is reordered for unrealization of buses to work as part of device unrealization. That way no changes need to be made to bus instantiation. Signed-off-by

[Qemu-devel] [PULL for-2.0-rc0 14/31] hw/core: Introduce QEMU machine as QOM object

2014-03-12 Thread Andreas Färber
From: Marcel Apfelbaum The main functional change is to convert QEMUMachine into MachineClass and QEMUMachineInitArgs into MachineState, instance of MachineClass. As a first step, in order to make possible an incremental development, both QEMUMachine and QEMUMachineInitArgs are being embedded in

Re: [Qemu-devel] [PATCH v2 2/4] pc: Refuse CPU hotplug if the resulting APIC ID is too large

2014-03-12 Thread Laszlo Ersek
On 03/12/14 19:28, Eduardo Habkost wrote: > The ACPI CPU hotplug code requires APIC IDs to be smaller than > ACPI_CPU_HOTPLUG_ID_LIMIT, so enforce the limit before trying to hotplug > a new vCPU, returning an error instead of crashing. > > Signed-off-by: Eduardo Habkost > --- > hw/i386/pc.c | 8

[Qemu-devel] [PULL for-2.0-rc0 21/31] tests: Add virtio-rng qtest

2014-03-12 Thread Andreas Färber
Cc: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/virtio-rng-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/virtio-rng-test.c diff --git a/tests/Makefile b/te

[Qemu-devel] [PULL for-2.0-rc0 24/31] tests: Add virtio-console qtest

2014-03-12 Thread Andreas Färber
Signed-off-by: Andreas Färber --- tests/Makefile | 6 ++ tests/virtio-console-test.c | 34 ++ 2 files changed, 40 insertions(+) create mode 100644 tests/virtio-console-test.c diff --git a/tests/Makefile b/tests/Makefile index 179667f..76a2468 10

[Qemu-devel] [PATCH] hw/i386: Use unaligned store functions building acpi tables

2014-03-12 Thread Richard Henderson
Hosts that don't support native unaligned stores will SIGBUS without additional help. Signed-off-by: Richard Henderson --- hw/i386/acpi-build.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b1

Re: [Qemu-devel] [PATCH v2 1/4] acpi: Add ACPI_CPU_HOTPLUG_ID_LIMIT macro

2014-03-12 Thread Laszlo Ersek
On 03/12/14 22:17, Laszlo Ersek wrote: > On 03/12/14 19:28, Eduardo Habkost wrote: >> The new macro will be helpful to allow us to detect too large SMP limits >> before it is too late. >> >> Signed-off-by: Eduardo Habkost >> --- >> include/hw/acpi/cpu_hotplug_defs.h | 8 >> 1 file change

Re: [Qemu-devel] [PATCH 2/2] acpi-build: don't access unaligned addresses

2014-03-12 Thread Richard Henderson
On 03/10/2014 12:43 PM, Michael S. Tsirkin wrote: > casting an unaligned address to e.g. > uint32_t can trigger undefined behaviour in C. > Replace cast + assignment with memcpy. > > Reported-by: Peter Maydell > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/acpi-build.c | 31 +++

[Qemu-devel] [PULL for-2.0-rc0 04/31] qom: Avoid leaking str and bool properties on failure

2014-03-12 Thread Andreas Färber
From: Stefan Hajnoczi When object_property_add_str() and object_property_add_bool() fail, they leak their internal StringProperty and BoolProperty structs. Remember to free the structs on error. Luckily this is a low-impact memory leak since most QOM properties are static qdev properties that w

Re: [Qemu-devel] [PATCH 1/2] bswap.h: export bswap_le

2014-03-12 Thread Richard Henderson
On 03/10/2014 12:43 PM, Michael S. Tsirkin wrote: > it's a handy API for cases where we want to > get size in bits as a parameter. > > Signed-off-by: Michael S. Tsirkin > --- > include/qemu/bswap.h | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/include/qemu/bswap.h b/include/qemu/

[Qemu-devel] [PULL for-2.0-rc0 26/31] virtio-serial-port: Convert to QOM realize/unrealize

2014-03-12 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/virtio-console.c | 28 ++--- hw/char/virtio-serial-bus.c | 51 --- include/hw/virtio/virtio-serial.h | 8 +++--- 3 files changed, 43 insertions(+), 44 deletions(-) diff --git a/hw/char/v

Re: [Qemu-devel] [PATCH] input: sdl: fix guest_cursor logic.

2014-03-12 Thread Richard Henderson
On 03/10/2014 01:23 AM, Gerd Hoffmann wrote: > +if (guest_cursor) { > +x -= guest_x; > +y -= guest_y; > +guest_x += x; > +guest_y += y; > +dx = x; > +dy = y; > +} Why write it in this funny way? Surely better

Re: [Qemu-devel] [PATCH v2 4/4] pc: Refuse max_cpus if it results in too large APIC ID

2014-03-12 Thread Laszlo Ersek
comments below On 03/12/14 19:28, Eduardo Habkost wrote: > This changes the PC initialization code to reject max_cpus if it results > in an APIC ID that's too large, instead of aborting or erroring out when > it is already too late. > > Currently there are two limits we need to check: the CPU hot

[Qemu-devel] [PULL for-2.0-rc0 05/31] ssi: Convert legacy SSI_SLAVE -> DEVICE casts

2014-03-12 Thread Andreas Färber
From: Peter Crosthwaite Convert legacy ->qdev style casts from TYPE_SSI_SLAVE to TYPE_DEVICE. Signed-off-by: Peter Crosthwaite [AF: Introduce local DeviceState variable for transition to QOM realize] Signed-off-by: Andreas Färber --- hw/arm/spitz.c | 13 +++-- hw/display/ads7846

[Qemu-devel] [PULL for-2.0-rc0 25/31] virtio-console: QOM cast cleanup for VirtConsole

2014-03-12 Thread Andreas Färber
Introduce type constant, cast macro and rename parent field. Signed-off-by: Andreas Färber --- hw/char/virtio-console.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c index 2e00ad2..73e18

[Qemu-devel] SMBIOS vs. NUMA (was: Build full type 19 tables)

2014-03-12 Thread Gabriel L. Somlo
On Wed, Mar 12, 2014 at 02:24:54PM +0100, Gerd Hoffmann wrote: > On Mi, 2014-03-12 at 09:05 -0400, Gabriel L. Somlo wrote: > > On Wed, Mar 12, 2014 at 09:27:18AM +0100, Gerd Hoffmann wrote: > > > I think we should just use e820_table (see pc.c) here. Loop over it and > > > add a type 19 table for

[Qemu-devel] [PULL for-2.0-rc0 06/31] ssi: Convert legacy SSI_BUS -> BUS casts

2014-03-12 Thread Andreas Färber
From: Peter Crosthwaite Remove two legacy ->qbus style casts from TYPE_SSI_BUS to TYPE_BUS in ssi.c. Signed-off-by: Peter Crosthwaite [AF: Convert one missing ->qbus and rename parent field] Signed-off-by: Andreas Färber --- hw/ssi/ssi.c | 9 + 1 file changed, 5 insertions(+), 4 delet

[Qemu-devel] [PULL for-2.0-rc0 07/31] misc/max111x: Create abstract max111x type

2014-03-12 Thread Andreas Färber
From: Peter Crosthwaite Create an abstract class that encompasses both max111x variants. This is needed for QOM cast macro creation (and is the right thing to do anyway). Macroify type-names in the process. Signed-off-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/misc/max111x.c |

[Qemu-devel] [PULL for-2.0-rc0 31/31] libqtest: Fix possible deadlock in qtest initialization

2014-03-12 Thread Andreas Färber
From: Marcel Apfelbaum 'socket_accept' waits for QEMU to init its unix socket. If QEMU encounters an error during command line parsing, it can exit before initializing the communication channel. Using a timeout for sockets fixes the issue. Reviewed-by: Eric Blake Signed-off-by: Marcel Apfelbau

[Qemu-devel] [PULL for-2.0-rc0 19/31] tests: Add virtio-blk qtest

2014-03-12 Thread Andreas Färber
Cc: Kevin Wolf Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/virtio-blk-test.c | 34 ++ 2 files changed, 37 insertions(+) create mode 100644 tests/virtio-blk-test.c diff --git a/tests/Makefile b/tests/Mak

[Qemu-devel] [PULL for-2.0-rc0 17/31] qom-test: Test QOM properties

2014-03-12 Thread Andreas Färber
Recursively walk all properties under /machine and try to retrieve their value. This is a regression test for link<> properties and the DeviceState::hotpluggable property. Cf. be2f78b6b062eec5170e2612299fb8953046993f and 1a37eca107cece3ed454bae29eef0bd1fac4a244 Signed-off-by: Andreas Färber

[Qemu-devel] [PULL for-2.0-rc0 09/31] ssi: Remove SSI_SLAVE_FROM_QDEV() macro

2014-03-12 Thread Andreas Färber
From: Peter Crosthwaite There are no usages left of this legacy cast. Delete. Signed-off-by: Peter Crosthwaite [AF: Rename SSISlave parent field] Signed-off-by: Andreas Färber ssi: Rename parent field --- include/hw/ssi.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PULL for-2.0-rc0 30/31] pci: Move VMState registration/unregistration to QOM realize/unrealize

2014-03-12 Thread Andreas Färber
From: Bandan Das Use the realize and unrealize hooks to register and unregister vmstate_pcibus respectively. Relocate some stuff to avoid forward declarations. Signed-off-by: Bandan Das Acked-by: Michael S. Tsirkin [AF: Keep using PCI_BUS() cast macro] Signed-off-by: Andreas Färber --- hw/p

[Qemu-devel] [PULL for-2.0-rc0 20/31] tests: Add virtio-balloon qtest

2014-03-12 Thread Andreas Färber
Cc: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/virtio-balloon-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/virtio-balloon-test.c diff --git a/tests/M

[Qemu-devel] [PULL for-2.0-rc0 27/31] tests: Add spapr-pci-host-bridge qtest

2014-03-12 Thread Andreas Färber
From: Alexey Kardashevskiy This adds a test whether sPAPR PHB can be added via the command line. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/spapr-phb-test.c | 35 +++ 2 files changed, 38 insertio

[Qemu-devel] [PULL for-2.0-rc0 12/31] qdev-monitor-test: Simplify using g_assert_cmpstr()

2014-03-12 Thread Andreas Färber
From: Stefan Hajnoczi Use g_assert_cmpstr() instead of combining g_assert() and strcmp(3). This simplifies the code since we no longer have to play games to distinguish NULL from "" using "(null)". gcc extension haters will also be happy that ?: was dropped. Suggested-by: Markus Armbruster Sig

[Qemu-devel] [PULL for-2.0-rc0 15/31] vl: Use MachineClass instead of global QEMUMachine list

2014-03-12 Thread Andreas Färber
From: Marcel Apfelbaum The machine registration flow is refactored to use the QOM functionality. Instead of linking the machines into a list, each machine has a type and the types can be traversed in the QOM way. Reviewed-by: Michael S. Tsirkin Signed-off-by: Marcel Apfelbaum Signed-off-by: An

[Qemu-devel] [PATCH 4/6] gtk: Use ctrl+alt+q for quit accelerator

2014-03-12 Thread Cole Robinson
Using the standard ctrl+q makes it too easy to kill the whole VM. Using ctrl+alt+FOO is consistent with our other accelerators. https://bugzilla.redhat.com/show_bug.cgi?id=1062393 Signed-off-by: Cole Robinson --- ui/gtk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/gtk

[Qemu-devel] [Bug 1251470] Re: Guest not working in KVM mode but does in TCG mode

2014-03-12 Thread Serge Hallyn
** Changed in: qemu (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1251470 Title: Guest not working in KVM mode but does in TCG mode Status in QEMU: Ne

Re: [Qemu-devel] [PATCH v2] trace: Multi-backend tracing

2014-03-12 Thread Lluís Vilanova
Lluís Vilanova writes: > Adds support to compile QEMU with multiple tracing backends at the same time. > For example, you can compile QEMU with: > $ ./configure --enable-trace-backends=ftrace,dtrace > Where 'ftrace' can be handy for having an in-flight record of events, and > 'dtrace' can be

[Qemu-devel] [PATCH 1/6] gtk: Don't use deprecated gtk_image_menu_item_new_with_mnemonic

2014-03-12 Thread Cole Robinson
In these cases we weren't using an image in the menu item anyways, so just do as the suggestion says. Should be fine for all qemu supported gtk versions. ui/gtk.c: In function ‘gd_create_menu_machine’: ui/gtk.c:1284:5: error: ‘gtk_image_menu_item_new_with_mnemonic’ is deprecated (declared at /usr

[Qemu-devel] [PATCH 6/6] gtk: Don't warp absolute pointer

2014-03-12 Thread Cole Robinson
This matches the behavior of SDL, and makes the mouse usable when using -display gtk -vga qxl https://bugzilla.redhat.com/show_bug.cgi?id=1051724 Signed-off-by: Cole Robinson --- ui/gtk.c | 8 1 file changed, 8 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index 3930f40..4b77590 10064

[Qemu-devel] [PATCH 3/6] gtk: Remove use of deprecated stock items

2014-03-12 Thread Cole Robinson
Stock items are deprecated. As are ImageMenuItems. Convert everything to text only MenuItems, with the same text content as mentioned in the conversion guide: https://docs.google.com/spreadsheet/pub?key=0AsPAM3pPwxagdGF4THNMMUpjUW5xMXZfdUNzMXhEa2c&output=html gtk2 users lose their menu icons as w

[Qemu-devel] [PATCH 2/6] gtk: Don't use deprecated vte_terminal_get_adjustment

2014-03-12 Thread Cole Robinson
Guard this with a VTE version check, since I'm not sure if this is backwards compatible. ui/gtk.c: In function ‘gd_vc_init’: ui/gtk.c:1176:5: error: ‘vte_terminal_get_adjustment’ is deprecated (declared at /usr/include/vte-2.90/vte/vtedeprecated.h:101) [-Werror=deprecated-declarations] Signed-o

[Qemu-devel] [PATCH 0/6] gtk: A few bug fixes

2014-03-12 Thread Cole Robinson
First 3 patches fix deprecation warnings on gtk 3.10, the remaining patches are bug fixes. Cole Robinson (6): gtk: Don't use deprecated gtk_image_menu_item_new_with_mnemonic gtk: Don't use deprecated vte_terminal_get_adjustment gtk: Remove use of deprecated stock items gtk: Use ctrl+alt+q

[Qemu-devel] [PATCH 5/6] gtk: Fix mouse warping with gtk3

2014-03-12 Thread Cole Robinson
We were using the wrong coordinates, this fixes things to match the original gtk2 implementation. You can see this error in action by using -vga qxl, however even after this patch the mouse warps in small increments up and to the left, -7x and -3y pixels at a time, until the pointer is warped off

Re: [Qemu-devel] [RFC PATCH 0/3] Add realize unrealize interfaces for BusState

2014-03-12 Thread Andreas Färber
Am 11.12.2013 16:27, schrieb Bandan Das: > Bandan Das writes: > >> These patches add realize and unrealize interfaces to BusState just >> like we have for DeviceState. 1/3 and 2/3 implement the interface and >> attempt to integrate it to the existing DeviceState call path. >> 3/3 is an example

Re: [Qemu-devel] [RFC PATCH 3/3] pci: move vmstate_pcibus registration/unregistration to realize and unrealize interfaces

2014-03-12 Thread Michael S. Tsirkin
On Mon, Nov 25, 2013 at 05:48:42PM -0500, Bandan Das wrote: > Relocate some stuff to avoid forward declarations and use the > realize and unrealize hooks to call into register and unregister > vmstate_pcibus > respectively > > Signed-off-by: Bandan Das Acked-by: Michael S. Tsirkin > --- > h

  1   2   3   4   >