Re: [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure

2014-03-07 Thread Stefan Weil
Am 07.03.2014 22:42, schrieb Andreas Färber: > In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head > to index to qemu consoles.) graphic_console_init() was extended to take > an additional argument, but xenfb was not updated accordingly. Fix it. > > Cc: Gerd Hoffmann > Signed-of

[Qemu-devel] [PATCH 4/5] migration: extend section_start/end traces

2014-03-07 Thread Juan Quintela
From: Alexey Kardashevskiy This adds @idstr to savevm_section_start and savevm_section_end tracepoints. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Amit Shah Signed-off-by: Juan Quintela --- savevm.c | 12 ++-- trace-events | 4 ++-- 2 files changed, 8 insertions(+), 8 de

[Qemu-devel] [PATCH 5/5] migration: add more traces

2014-03-07 Thread Juan Quintela
From: Alexey Kardashevskiy This replaces DPRINTF macro with tracepoints. This moves some messages from migration.c to savevm.c. This adds tracepoint to signal about fields failed to migrate. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Amit Shah Signed-off-by: Juan Quintela --- migra

[Qemu-devel] [PATCH 3/5] vl: add system_wakeup_request tracepoint

2014-03-07 Thread Juan Quintela
From: Alexey Kardashevskiy It might be useful for tracing migration. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Amit Shah Signed-off-by: Juan Quintela --- trace-events | 1 + vl.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/trace-events b/trace-events index aec4202

[Qemu-devel] [PATCH 2/5] qemu_file: Fix mismerge of "use fwrite() correctly"

2014-03-07 Thread Juan Quintela
From: Markus Armbruster Reviewers accepted v2 of the patch, but what got committed was v1, with the R-bys for v2. This is the v1->v2 followup fix. [Amit: This fixes commit aded6539d983280212e08d09f14157b1cb4d58cc ] Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Amit S

[Qemu-devel] [PATCH 1/5] XBZRLE: Fix qemu crash when resize the xbzrle cache

2014-03-07 Thread Juan Quintela
From: Gonglei Resizing the xbzrle cache during migration causes qemu-crash, because the main-thread and migration-thread modify the xbzrle cache size concurrently without lock-protection. Signed-off-by: ChenLiang Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Q

[Qemu-devel] [PULL 0/5] migration queue

2014-03-07 Thread Juan Quintela
Hi Please pull - Fix missmerge of fwrite patch (armbru) - FIX XBZRLE crash: Gonglei - Add more traces for migration (Alexey) Especial thanks to Amit for getting the patches together. Later, Juan. The following changes since commit 6fc0303b95c873d9e384d7fb51e412ac2e53b9c1: Merge remote-trac

Re: [Qemu-devel] [PATCH v2 02/12] check-qdict: Add test for qdict_join()

2014-03-07 Thread Eric Blake
On 03/07/2014 03:55 PM, Max Reitz wrote: > Add some test cases for qdict_join(). > > Signed-off-by: Max Reitz > --- > tests/check-qdict.c | 87 > + > 1 file changed, 87 insertions(+) Reviewed-by: Eric Blake > +/* Test everything once wi

[Qemu-devel] [PATCH v2 5/5] block/raw-win32: bdrv_parse_filename() for hdev

2014-03-07 Thread Max Reitz
The "host_device" protocol driver should strip the "host_device:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/raw-win32.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/raw-win32.c b/block/raw-win32.c index 9954748..48cb2

[Qemu-devel] [PATCH v2 3/5] block/raw-posix: bdrv_parse_filename() for cdrom

2014-03-07 Thread Max Reitz
The "host_cdrom" protocol drivers should strip the "host_cdrom:" prefix from filenames if present. Signed-off-by: Max Reitz --- block/raw-posix.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index 4b8c183..697cd2e 100644 --- a/block/r

[Qemu-devel] [PATCH v2 4/5] block/raw-posix: Strip protocol prefix on creation

2014-03-07 Thread Max Reitz
The hdev_create() implementation in block/raw-posix.c is used by the "host_device", "host_cdrom" and "host_floppy" protocol block drivers together. Thus, any of the associated prefixes may occur and exactly one should should be stripped, if it does (thus, "host_device:host_cdrom:/dev/cdrom" is not

[Qemu-devel] [PATCH v2 2/5] block/raw-posix: bdrv_parse_filename() for floppy

2014-03-07 Thread Max Reitz
The "host_floppy" protocol driver should strip the "host_floppy:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/raw-posix.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index ab32ff9..4b8c1

[Qemu-devel] [PATCH v2 1/5] block/raw-posix: bdrv_parse_filename() for hdev

2014-03-07 Thread Max Reitz
The "host_device" protocol driver should strip the "host_device:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/raw-posix.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index e6b4c1f..ab32f

[Qemu-devel] [PATCH v2 0/5] block: Strip protocol prefixes from filenames

2014-03-07 Thread Max Reitz
As some kind of follow-up to the "block: Strip 'file:' prefix from filenames" series, this series does the same thing for other protocol drivers. All protocol drivers which implement bdrv_probe() may rely on them being selected based on that function returning success alone. However, they may have

[Qemu-devel] [PATCH v2 11/12] block/qapi: Ignore filters on top for format name

2014-03-07 Thread Max Reitz
bdrv_query_image_info() currently deduces the image filename and the format name from the top BDS. However, it is probably more reasonable to ignore as many filters as possible on top of the BDS chain since those neither change the type nor the filename of the underlying image. Filters like quorum

[Qemu-devel] [PATCH v2 10/12] block/raw_bsd: Add bdrv_get_specific_info()

2014-03-07 Thread Max Reitz
Add a passthrough function for bdrv_get_specific_info(). Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/raw_bsd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 01ea692..e93ccd3 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @

[Qemu-devel] [PATCH v2 06/12] block/json: Add functions for writing zeroes etc.

2014-03-07 Thread Max Reitz
Add passthrough functions for bdrv_aio_discard(), bdrv_co_write_zeroes(), bdrv_truncate() and bdrv_has_zero_init(). Signed-off-by: Max Reitz --- block/json.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/block/json.c b/block/json.c index f40343e..e4cdb68 100

[Qemu-devel] [PATCH v2 05/12] block/json: Add functions for cache control

2014-03-07 Thread Max Reitz
Add passthrough functions for bdrv_aio_flush() and bdrv_invalidate_cache(). Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/json.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/json.c b/block/json.c index 591bc47..f40343e 100644 --- a/block/json.c +++ b

[Qemu-devel] [PATCH v2 04/12] block/json: Add JSON protocol driver

2014-03-07 Thread Max Reitz
Add a JSON protocol driver which allows supplying block driver options through the filename rather than separately. Other than that, it is a pure passthrough driver which identifies itself as a filter. This patch implements the functions bdrv_parse_filename(), bdrv_file_open(), bdrv_close(), bdrv_

[Qemu-devel] [PATCH v2 12/12] iotests: Add test for the JSON protocol

2014-03-07 Thread Max Reitz
Add a test for the JSON protocol driver. Signed-off-by: Max Reitz --- tests/qemu-iotests/084 | 123 + tests/qemu-iotests/084.out | 39 ++ tests/qemu-iotests/group | 1 + 3 files changed, 163 insertions(+) create mode 100755 tests/

[Qemu-devel] [PATCH v2 03/12] block: Add "has_single_child" field for drivers

2014-03-07 Thread Max Reitz
This field should be used by block drivers acting as filters which have only a single child BDS which is referenced through the "file" field of the BDS. Setting this field allows other block functions to "access" the child BDS, for instance in bdrv_recurse_is_first_non_filter(). Therefore, it shou

[Qemu-devel] [PATCH v2 09/12] block/json: Add bdrv_get_specific_info()

2014-03-07 Thread Max Reitz
Add a passthrough function for bdrv_get_specific_info(). Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/json.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/json.c b/block/json.c index f21b7e3..1bb3956 100644 --- a/block/json.c +++ b/block/json.c @@ -183,6 +183,1

[Qemu-devel] [PATCH v2 02/12] check-qdict: Add test for qdict_join()

2014-03-07 Thread Max Reitz
Add some test cases for qdict_join(). Signed-off-by: Max Reitz --- tests/check-qdict.c | 87 + 1 file changed, 87 insertions(+) diff --git a/tests/check-qdict.c b/tests/check-qdict.c index 2ad0f78..a9296f0 100644 --- a/tests/check-qdict.c +++

[Qemu-devel] [PATCH v2 08/12] block/json: Add ioctl etc.

2014-03-07 Thread Max Reitz
Add passthrough functions for bdrv_aio_ioctl(), bdrv_is_inserted(), bdrv_media_changed(), bdrv_eject(), bdrv_lock_medium() and bdrv_ioctl(). Signed-off-by: Max Reitz Reviewed-by: Benoit Canet --- block/json.c | 40 1 file changed, 40 insertions(+) diff

[Qemu-devel] [PATCH v2 01/12] qdict: Add qdict_join()

2014-03-07 Thread Max Reitz
This function joins two QDicts by absorbing one into the other. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Reviewed-by: Eric Blake --- include/qapi/qmp/qdict.h | 3 +++ qobject/qdict.c | 32 2 files changed, 35 insertions(+) diff --git a/incl

[Qemu-devel] [PATCH v2 07/12] block/json: Add bdrv_co_get_block_status()

2014-03-07 Thread Max Reitz
Implement this function in the same way as raw_bsd does: Acknowledge that this is a passthrough driver (always return BDRV_BLOCK_OFFSET_VALID and BDRV_BLOCK_DATA and derive the offset directly from the sector index) and add BDRV_BLOCK_RAW to the returned value. Signed-off-by: Max Reitz --- block

[Qemu-devel] [PATCH v2 00/12] block/json: Add JSON protocol driver

2014-03-07 Thread Max Reitz
This series adds a passthrough JSON protocol block driver. Its filenames are JSON objects prefixed by "json:". The objects are used as options for opening another block device which will be the child of the JSON device. Regarding this child device, the JSON driver behaves nearly the same as raw_bsd

[Qemu-devel] [BUGFIX][PATCH 1/1] xenfb.c: fix compile error on graphic_console_init

2014-03-07 Thread Don Slutz
commit 5643706a095044d75df1c0588aac553a595b972b console: add head to index to qemu consoles. Breaks Xen builds. Signed-off-by: Don Slutz --- hw/display/xenfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index cb9d456..032eb7a 1006

Re: [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure

2014-03-07 Thread Don Slutz
I just found the same thing: http://lists.xen.org/archives/html/xen-devel/2014-03/msg00678.html So you can add my: Reviewed-by: Don Slutz -Don Slutz On 03/07/14 16:42, Andreas Färber wrote: In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head to index to qemu consoles.)

Re: [Qemu-devel] [PATCH 1/2] block: Add node-name and to-replace-node-name arguments to drive-mirror.

2014-03-07 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 13:54:44 (-0700), Eric Blake wrote : > On 03/05/2014 08:18 AM, Benoît Canet wrote: > > node-name give a name to the created BDS and register it in the node graph. > > s/give/gives/ s/register/registers/ > > > > > to-replace-node-name can be used when drive-mirror is c

Re: [Qemu-devel] [BUGFIX][PATCH 1/1] xenfb.c: fix compile error on graphic_console_init

2014-03-07 Thread Don Slutz
Better commit message in: http://lists.nongnu.org/archive/html/qemu-devel/2014-03/msg01469.html So I will withdraw this patch request. -Don Slutz On 03/07/14 17:27, Don Slutz wrote: commit 5643706a095044d75df1c0588aac553a595b972b console: add head to index to qemu consoles. Breaks Xen bui

[Qemu-devel] [PATCH v2 4/5] w32: Replace Windows specific data types in common header files

2014-03-07 Thread Stefan Weil
These header files are used by most QEMU source files. If they depend on windows.h, all those source files do so, too. All Windows specific data types which are replaced use identical definitions for the 32 and 64 bit Windows APIs. HANDLE, LONG and CRITICAL_SECTION are replaced by the compatible t

[Qemu-devel] [PATCH v2 2/5] w32: Move inline function from header file to C source

2014-03-07 Thread Stefan Weil
A lot of files depend on qemu/timer.h. We don't want that all these files depend on windows.h, too. Signed-off-by: Stefan Weil --- include/qemu/timer.h |8 +--- util/qemu-timer-common.c | 11 ++- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/include/qemu/t

[Qemu-devel] [PATCH v2 5/5] block: Review include statements for winioctl.h

2014-03-07 Thread Stefan Weil
block/win32-aio.c does not need it. Add a comment why it is needed to block/raw-win32.c. Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Stefan Weil --- block/raw-win32.c |2 +- block/win32-aio.c |1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/block/raw-win32.c b/

[Qemu-devel] [PATCH v2 1/5] w32: Add and use intermediate include file for windows.h

2014-03-07 Thread Stefan Weil
Including windows.h from the new file include/qemu/winapi.h allows better tracking of the files which depend on the Windows API. 1864 *.o files depend on windows.h in a typical build, only 88 *.o files don't. The windows.h specific macro WIN32_LEAN_AND_MEAN is now defined in the new file and no l

[Qemu-devel] [PATCH v2 0/5] w32: Reduce dependency on Windows API

2014-03-07 Thread Stefan Weil
The first 4 patches reduce the number of files which depend on windows.h by about 90 percent. This reduces the compilation time, allows removing some hacks and avoids name space pollution. Patch 5 is optional and new here. Changes in v2: * Change name of new include file include/qemu/winapi.h

[Qemu-devel] [PATCH v2 3/5] w32: Reduce dependencies in sysemu/os-win32.h

2014-03-07 Thread Stefan Weil
Most *.o files depend on that file, but many of them don't need windows.h or winsock2.h. sysemu/os-win32.h only needs some definitions from winerror.h. After that change, all files which depend on windows.h or winsock2.h and which no longer get it indirectly have to be fixed. Use qemu/sockets.h to

[Qemu-devel] [PATCH] qcow2-refcount: Sanitize refcount table entry

2014-03-07 Thread Max Reitz
When reading the refcount table entry in get_refcount(), only bits which are actually significant for the refcount block offset should be taken into account. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/qcow2-refc

Re: [Qemu-devel] [PATCH] libvixl: Fix format strings for several int64_t values

2014-03-07 Thread Andreas Färber
Am 07.03.2014 21:01, schrieb Stefan Weil: > Am 07.03.2014 20:42, schrieb Andreas Färber: >> Am 07.03.2014 20:15, schrieb Stefan Weil: >>> "%d" or "%x" won't work on hosts where int values are smaller than 64 bit. >>> >>> Signed-off-by: Stefan Weil >>> --- >>> disas/libvixl/a64/disasm-a64.cc | 2

[Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure

2014-03-07 Thread Andreas Färber
In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head to index to qemu consoles.) graphic_console_init() was extended to take an additional argument, but xenfb was not updated accordingly. Fix it. Cc: Gerd Hoffmann Signed-off-by: Andreas Färber --- hw/display/xenfb.c | 2 +- 1 f

Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass

2014-03-07 Thread Marcel Apfelbaum
On Fri, 2014-03-07 at 18:30 +0100, Andreas Färber wrote: > Am 07.03.2014 17:22, schrieb Marcel Apfelbaum: > > On Fri, 2014-03-07 at 12:27 +0100, Andreas Färber wrote: > >> Am 07.03.2014 06:32, schrieb Marcel Apfelbaum: > >>> On Fri, 2014-03-07 at 00:44 +0100, Andreas Färber wrote: > Am 05.03.2

Re: [Qemu-devel] [PATCH] libvixl: Fix format strings for several int64_t values

2014-03-07 Thread Stefan Weil
Am 07.03.2014 20:42, schrieb Andreas Färber: > Am 07.03.2014 20:15, schrieb Stefan Weil: >> "%d" or "%x" won't work on hosts where int values are smaller than 64 bit. >> >> Signed-off-by: Stefan Weil >> --- >> disas/libvixl/a64/disasm-a64.cc | 20 ++-- >> 1 file changed, 10 inse

Re: [Qemu-devel] [PULL v4 00/38] rework input handling, sdl2 support

2014-03-07 Thread Andreas Färber
Am 07.03.2014 20:23, schrieb Peter Maydell: > On 5 March 2014 11:53, Gerd Hoffmann wrote: >> Hi, >> >> The input layer moves to a model modeled roughly after the linux >> event layer. It also uses qapi to create all the data types needed. >> First, because it is convinient to have all the suppo

Re: [Qemu-devel] [PATCH] libvixl: Fix format strings for several int64_t values

2014-03-07 Thread Andreas Färber
Am 07.03.2014 20:15, schrieb Stefan Weil: > "%d" or "%x" won't work on hosts where int values are smaller than 64 bit. > > Signed-off-by: Stefan Weil > --- > disas/libvixl/a64/disasm-a64.cc | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) Patch looks correct, but

Re: [Qemu-devel] [PULL v4 00/38] rework input handling, sdl2 support

2014-03-07 Thread Peter Maydell
On 5 March 2014 11:53, Gerd Hoffmann wrote: > Hi, > > The input layer moves to a model modeled roughly after the linux > event layer. It also uses qapi to create all the data types needed. > First, because it is convinient to have all the support code generated, > and also to make it easier to

[Qemu-devel] [PATCH] libvixl: Fix format strings for several int64_t values

2014-03-07 Thread Stefan Weil
"%d" or "%x" won't work on hosts where int values are smaller than 64 bit. Signed-off-by: Stefan Weil --- disas/libvixl/a64/disasm-a64.cc | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/disas/libvixl/a64/disasm-a64.cc b/disas/libvixl/a64/disasm-a64.cc

Re: [Qemu-devel] [PATCH] misc: Fix typos in comments

2014-03-07 Thread Andreas Färber
Am 07.03.2014 19:48, schrieb Stefan Weil: > Codespell found and fixed these new typos: > > * doesnt -> doesn't > * funtion -> function > * perfomance -> performance > * remaing -> remaining > > A code style issue (line too long) was fixed manually. "coding style"? > > Signed-off-by: Stefan Wei

[Qemu-devel] [PATCH] misc: Fix typos in comments

2014-03-07 Thread Stefan Weil
Codespell found and fixed these new typos: * doesnt -> doesn't * funtion -> function * perfomance -> performance * remaing -> remaining A code style issue (line too long) was fixed manually. Signed-off-by: Stefan Weil --- hw/intc/arm_gic_kvm.c|2 +- hw/net/fsl_etsec/rings.c |4 ++--

[Qemu-devel] [PATCH] qdev: Fix bus dependency of DeviceState::hotpluggable getter

2014-03-07 Thread Andreas Färber
Commit 1a37eca107cece3ed454bae29eef0bd1fac4a244 (qdev: add "hotpluggable" property to Device) added a property "hotpluggable" to each device, with its getter accessing parent_bus->allow_hotplug. Add a NULL check. Cc: Igor Mammedov Signed-off-by: Andreas Färber --- hw/core/qdev.c | 3 ++- 1 fil

Re: [Qemu-devel] [PULL 13/20] qdev: add "hotpluggable" property to Device

2014-03-07 Thread Andreas Färber
Am 10.02.2014 17:48, schrieb Michael S. Tsirkin: > From: Igor Mammedov > > Currently it's possible to make PCIDevice not hotpluggable > by using no_hotplug field of PCIDeviceClass. However it > limits this only to PCI devices and prevents from > generalizing hotplug code. > > So add similar fiel

Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass

2014-03-07 Thread Andreas Färber
Am 07.03.2014 17:22, schrieb Marcel Apfelbaum: > On Fri, 2014-03-07 at 12:27 +0100, Andreas Färber wrote: >> Am 07.03.2014 06:32, schrieb Marcel Apfelbaum: >>> On Fri, 2014-03-07 at 00:44 +0100, Andreas Färber wrote: Am 05.03.2014 18:30, schrieb Marcel Apfelbaum: > In order to allow attach

Re: [Qemu-devel] [PULL 00/130] ppc patch queue 2014-03-05

2014-03-07 Thread Peter Maydell
On 6 March 2014 23:32, Alexander Graf wrote: > Hi Blue / Aurelien / Anthony / Peter, > > This is my current patch queue for ppc. Please pull. > > This pull request includes: > > - VSX emulation support > - book3s pr/hv selection > - some bug fixes > - qdev stable numbering > - eTSEC emu

Re: [Qemu-devel] [PATCH 5/5] hw/9pfs: Include virtio-9p-device.o in build

2014-03-07 Thread Aneesh Kumar K.V
Andreas Färber writes: > Am 07.03.2014 16:16, schrieb Aneesh Kumar K.V: >> From: "Aneesh Kumar K.V" >> >> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including >> hw/Makefile.objs directly from Makefile.target. Make sure hw/Makefile.objs >> rules doesn't depend on variable defi

Re: [Qemu-devel] [PATCH 1/1] s390-cpu: qom interface for S390 cpu states array

2014-03-07 Thread Paolo Bonzini
Il 07/03/2014 17:29, Jason J. Herne ha scritto: From: "Jason J. Herne" Rename the S390 ipi_states array to cpu_states to better reflect its contents. Create machine/cpu[cpu_addr] links within the qom tree when creating a new cpu. Encapsulate the qom tree linking process and the management of

[Qemu-devel] WIP: Migration format: ASN.1/BER schema

2014-03-07 Thread Dr. David Alan Gilbert
Hi, I've been looking at reviving the migration-as-ber work that Michael and Stefan looked at a while ago, and have stuff starting to work, but not ready yet, so I thought I'd start by posting my current view of an ASN.1 schema. Note this is my 1st attempt at ASN.1 so feel free to pick holes! T

[Qemu-devel] [PULL] migration patches

2014-03-07 Thread Amit Shah
Hi, These are some patches that have received reviews and have been on the list. Please pick them up. The following changes since commit 4c288acbd6b9eccb13076103e59a426af3d15030: configure: Always build with -fno-common (2014-03-06 21:26:44 +) are available in the git repository at: g

Re: [Qemu-devel] [PULL 0/1] virtio-ccw: adapter interrupts

2014-03-07 Thread Peter Maydell
On 5 March 2014 09:14, Cornelia Huck wrote: > The following changes since commit f55ea6297cc0224fe4934b90ff5343b620b14669: > > block/gluster: Add missing argument to qemu_gluster_init() call (2014-03-04 > 20:20:57 +) > > are available in the git repository at: > > git://github.com/cohuck/

Re: [Qemu-devel] [PATCH] tests: Fix 'make test' for i686 hosts (buildregression))

2014-03-07 Thread Peter Maydell
On 7 March 2014 16:17, Alex Bennée wrote: > Peter Maydell writes: >> I think TCG x86 FPU emulation has been a bit dodgy since >> forever; it's a fair amount of work to go through and >> fix everything up to be bitwise exact results versus >> hardware and I think that nobody's cared enough about x

[Qemu-devel] [PATCH 1/1] s390-cpu: qom interface for S390 cpu states array

2014-03-07 Thread Jason J. Herne
From: "Jason J. Herne" Rename the S390 ipi_states array to cpu_states to better reflect its contents. Create machine/cpu[cpu_addr] links within the qom tree when creating a new cpu. Encapsulate the qom tree linking process and the management of the cpu_states array into helper functions. Signe

[Qemu-devel] [PATCH 0/1] s390-cpu: qom interface for S390 cpu states array

2014-03-07 Thread Jason J. Herne
From: "Jason J. Herne" This patch is a result of changes requested by Andreas Färber during the S390 cpu hotplug code review. Andreas, I am unsure if you were asking for the complete removal of the ipi_states array, or the removal of the set/get functions used to encapsulate access to the arra

Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass

2014-03-07 Thread Paolo Bonzini
Il 07/03/2014 17:22, Marcel Apfelbaum ha scritto: There is a problem with it: 'make check fails' on test-qdev-global-props. - 'qdev_get_machine()' is called by 'device_set_realized()' because static_prop_type has TYPE_DEVICE as parent. - The machine is added to the QOM tree *only in vl's main*

Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass

2014-03-07 Thread Marcel Apfelbaum
On Fri, 2014-03-07 at 12:27 +0100, Andreas Färber wrote: > Am 07.03.2014 06:32, schrieb Marcel Apfelbaum: > > On Fri, 2014-03-07 at 00:44 +0100, Andreas Färber wrote: > >> Am 05.03.2014 18:30, schrieb Marcel Apfelbaum: > >>> In order to allow attaching machine options to a machine instance, > >>> c

Re: [Qemu-devel] [PATCH] tests: Fix 'make test' for i686 hosts (buildregression))

2014-03-07 Thread Alex Bennée
Peter Maydell writes: > On 7 March 2014 13:19, Stefan Weil wrote: >> test-i386 does some calculations and prints the results (see source code >> tests/tcg/test-i386.c). If the user mode emulation of QEMU works, it >> should not matter whether that executable runs native or emulated and >> both

Re: [Qemu-devel] [PATCH qom-test] qom-test: Test QOM properties

2014-03-07 Thread Andreas Färber
Am 07.02.2014 15:39, schrieb Andreas Färber: > Recursively walk all properties under /machine and try to retrieve their > value. This is a regression test for link<> properties. > > Cf. be2f78b6b062eec5170e2612299fb8953046993f > > Signed-off-by: Andreas Färber > --- > tests/qom-test.c | 38

Re: [Qemu-devel] [PATCH v4 12/21] target-arm: A64: Implement DC ZVA

2014-03-07 Thread Richard Henderson
On 03/07/2014 07:11 AM, Peter Maydell wrote: >> > As a bonus, you'll have accurate exceptions should the access throw, so you >> > don't need to force the save of PC before calling the helper. Which... I >> > don't >> > see you doing, so perhaps there's a bug here at the moment. > Mmm. (In system

Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size

2014-03-07 Thread Eric Blake
On 03/07/2014 08:13 AM, Marcelo Tosatti wrote: > On Thu, Mar 06, 2014 at 09:21:10PM -0700, Eric Blake wrote: >> On 03/06/2014 05:40 PM, Marcelo Tosatti wrote: >>> >>> Failing initialization in case hugepage path has >>> hugepage smaller than specified. >>> >>> Signed-off-by: Marcelo Tosatti >>> >

Re: [Qemu-devel] [PATCH 5/5] hw/9pfs: Include virtio-9p-device.o in build

2014-03-07 Thread Andreas Färber
Am 07.03.2014 16:16, schrieb Aneesh Kumar K.V: > From: "Aneesh Kumar K.V" > > After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including > hw/Makefile.objs directly from Makefile.target. Make sure hw/Makefile.objs > rules doesn't depend on variable defined in Makefile.objs > > Tested

[Qemu-devel] [Bug 1252270] Re: installing NT4 on MIPS Magnum/Jazz asserts

2014-03-07 Thread Andreas Färber
We're about to release 2.0, so it would be more interesting to know whether it still happens in latest qemu.git. And since this seems to depend on .iso and nvram.bin files that we don't have available for reproducing, some tracing on your part might help narrow down whether this is caused by a bug

Re: [Qemu-devel] [PATCH v4 12/21] target-arm: A64: Implement DC ZVA

2014-03-07 Thread Richard Henderson
On 03/07/2014 07:11 AM, Peter Maydell wrote: >> > cpu_stb_data doesn't take into account user vs kernel mode accesses. > ...so what does it use for the mmu index? > Oops, read the macro garbage incorrectly. It does make its way back to cpu_mmu_index. r~

Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size

2014-03-07 Thread Marcelo Tosatti
On Fri, Mar 07, 2014 at 08:53:50AM +0100, Paolo Bonzini wrote: > Il 07/03/2014 01:40, Marcelo Tosatti ha scritto: > > > >Failing initialization in case hugepage path has > >hugepage smaller than specified. > > > >Signed-off-by: Marcelo Tosatti > > > Why is this needed? Isn't it just operator er

Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size

2014-03-07 Thread Marcelo Tosatti
On Thu, Mar 06, 2014 at 09:21:10PM -0700, Eric Blake wrote: > On 03/06/2014 05:40 PM, Marcelo Tosatti wrote: > > > > Failing initialization in case hugepage path has > > hugepage smaller than specified. > > > > Signed-off-by: Marcelo Tosatti > > > > diff --git a/exec.c b/exec.c > > index b69fd

[Qemu-devel] [PATCH 3/5] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-07 Thread Aneesh Kumar K.V
From: Chen Gang 'ctx->fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so need use snprintf() instead of sprintf() just like another area have done in 9pfs. This could possibly result in the truncation of pathname, which we address in the follow up patch. Signed-off-by: Chen Gang

[Qemu-devel] [PATCH 1/5] fsdev: Fix overrun after readlink() fills buffer completely

2014-03-07 Thread Aneesh Kumar K.V
From: Markus Armbruster readlink() returns the number of bytes written to the buffer, and it doesn't write a terminating null byte. do_readlink() writes it itself. Overruns the buffer when readlink() filled it completely. Fix by reserving space for the null byte when calling readlink(), like w

[Qemu-devel] [PULL] VirtFS update

2014-03-07 Thread Aneesh Kumar K.V
Hi, Please pull the below update for VirtFS The following changes since commit d5001cf787ad0514839a81d0f2e771e01e076e21: xilinx: Delete hw/include/xilinx.h (2014-02-26 14:54:45 +1000) are available in the git repository at: https://github.com/kvaneesh/qemu.git for-upstream for you to fet

[Qemu-devel] [PATCH 4/5] hw/9pfs: use g_strdup_printf() instead of PATH_MAX limitation

2014-03-07 Thread Aneesh Kumar K.V
From: Chen Gang When path is truncated by PATH_MAX limitation, it causes QEMU to access incorrect file. So use original full path instead of PATH_MAX within 9pfs (need check/process ENOMEM for related memory allocation). The related test: - Environments (for qemu-devel): - Host is under fe

[Qemu-devel] [PATCH 2/5] hw/9pfs/virtio-9p-local.c: move v9fs_string_free() to below "err_out:"

2014-03-07 Thread Aneesh Kumar K.V
From: Chen Gang When "goto err_out", 'v9fs_string' already was allocated, so still need free 'v9fs_string' before return. Signed-off-by: Chen Gang Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-local.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9

[Qemu-devel] [PATCH 5/5] hw/9pfs: Include virtio-9p-device.o in build

2014-03-07 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including hw/Makefile.objs directly from Makefile.target. Make sure hw/Makefile.objs rules doesn't depend on variable defined in Makefile.objs Tested-by: Serge Hallyn Signed-off-by: Aneesh Kumar K.V --- Make

Re: [Qemu-devel] [PATCH v4 12/21] target-arm: A64: Implement DC ZVA

2014-03-07 Thread Peter Maydell
On 7 March 2014 14:51, Richard Henderson wrote: > On 03/06/2014 11:32 AM, Peter Maydell wrote: >> +/** >> + * tlb_vaddr_to_host: >> + * @env: CPUArchState >> + * @addr: guest virtual address to look up >> + * @mmu_idx: MMU index to use for lookup >> + * >> + * Look up the specified guest virtual i

Re: [Qemu-devel] pcie

2014-03-07 Thread Serge Hallyn
Quoting Paolo Bonzini (pbonz...@redhat.com): > Il 07/03/2014 04:31, Serge Hallyn ha scritto: > >Hi, > > > >At https://bugs.launchpad.net/bugs/1284793 it was found that commit > >a66e657e: "pci/pcie: convert PCIE hotplug to use hotplug-handler API" > >seems to break vga passthrough. Reverting that

[Qemu-devel] [PULL 08/19] block: mirror - remove code cruft that has no function

2014-03-07 Thread Kevin Wolf
From: Jeff Cody Originally, this built up the error message with the backing filename, so that errp was set as follows: error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename); However, we now propagate the local_error from the bdrv_open_backing_file() call instead, making these 2 lines use

[Qemu-devel] [PULL 09/19] block: Keep "filename" option after parsing

2014-03-07 Thread Kevin Wolf
From: Max Reitz Currently, bdrv_file_open() always removes the "filename" option from the options QDict after bdrv_parse_filename() has been (successfully) called. However, for drivers with bdrv_needs_filename, it makes more sense for bdrv_parse_filename() to overwrite the "filename" option and f

Re: [Qemu-devel] [PATCH 2.1 00/28] Current state of NUMA series, and hostmem improvements

2014-03-07 Thread Igor Mammedov
On Fri, 07 Mar 2014 14:35:09 +0100 Paolo Bonzini wrote: > Il 07/03/2014 13:56, Igor Mammedov ha scritto: > >> However, I'd still like it to be mostly a container, and that is why I > >> liked the idea of having /node[n] with "flat" links to the actual > >> CPUStates (and also memdevs). > > > > Is

[Qemu-devel] [PULL 16/19] qemu-iotests: Test a few blockdev-add error cases

2014-03-07 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Benoit Canet --- tests/qemu-iotests/087 | 122 + tests/qemu-iotests/087.out | 40 +++ tests/qemu-iotests/group | 1 + 3 files changed, 163 insertions(+) create mode 100755 tests/qemu-iotests/

[Qemu-devel] [PULL 03/19] qemu-img convert: Fix progress output

2014-03-07 Thread Kevin Wolf
Initialise progress output only when the -p and -q options have already been parsed, otherwise it's always disabled. Reported-by: Peter Lieven Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- qemu-img.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --gi

[Qemu-devel] [PULL 19/19] block: qemu-iotests 085 - live snapshots tests

2014-03-07 Thread Kevin Wolf
From: Jeff Cody This adds tests for live snapshots, both through the single snapshot command, and the transaction group snapshot command. The snapshots are done through the QMP interface, using the following commands for snapshots: Single snapshot: { 'execute': 'blockdev-snapshot-sync', 'argume

Re: [Qemu-devel] [PATCH v4 12/21] target-arm: A64: Implement DC ZVA

2014-03-07 Thread Richard Henderson
On 03/06/2014 11:32 AM, Peter Maydell wrote: > +/** > + * tlb_vaddr_to_host: > + * @env: CPUArchState > + * @addr: guest virtual address to look up > + * @mmu_idx: MMU index to use for lookup > + * > + * Look up the specified guest virtual index in the TCG softmmu TLB. > + * If the TLB contains a h

Re: [Qemu-devel] [PATCH 07/10] qapi script: support enum type as discriminator in union

2014-03-07 Thread Markus Armbruster
Wenchao Xia writes: > By default, any union will automatically generate a enum type as > "[UnionName]Kind" in C code, and it is duplicated when the discriminator > is specified as a pre-defined enum type in schema. After this patch, > the pre-defined enum type will be really used as the switch ca

[Qemu-devel] [PULL 05/19] iscsi: Use bs->sg for everything else than disks

2014-03-07 Thread Kevin Wolf
The current iscsi block driver code makes the rather arbitrary decision that TYPE_MEDIUM_CHANGER and TYPE_TAPE devices have bs->sg = 1 and all other device types are disks. Instead of this, check for TYPE_DISK to expose the disk interface and make everything else bs->sg = 1. In particular, this in

[Qemu-devel] [Bug 1245924] Re: mips64el magnum emulation broken

2014-03-07 Thread Paolo Bonzini
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1245924 Title: mips64el magnum emulation broken Status in QEMU: Fix Released Bug description

[Qemu-devel] [PATCH] linux-user: implement F_[GS]ETOWN_EX

2014-03-07 Thread Andreas Schwab
F_GETOWN is replaced by F_GETOWN_EX inside the glibc fcntl wrapper Signed-off-by: Andreas Schwab --- Only tested so far with the gnulib test-fcntl module, which mainly tests proper error handling only. --- linux-user/syscall.c | 36 linux-user/syscall_de

[Qemu-devel] [PULL 06/19] block: Fix bs->request_alignment assertion for bs->sg=1

2014-03-07 Thread Kevin Wolf
For sg backends, bs->request_alignment is meaningless and may be 0. Signed-off-by: Kevin Wolf Reviewed-by: Benoit Canet Acked-by: Paolo Bonzini --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 38bbdf3..f01b91c 100644 --- a/block.c +++ b/bl

[Qemu-devel] [Bug 1245924] Re: mips64el magnum emulation broken

2014-03-07 Thread Darkstar
This bug is apparently fixed in 1.7.0 and can be closed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1245924 Title: mips64el magnum emulation broken Status in QEMU: New Bug description: I'm

Re: [Qemu-devel] [PATCH V9 00/10] qapi script: support enum as discriminator and better enum name

2014-03-07 Thread Luiz Capitulino
On Tue, 4 Mar 2014 18:44:30 -0800 Wenchao Xia wrote: > This series address two issues: > > 1. support using enum as discriminator in union. > For example, if we have following define in qapi schema: > { 'enum': 'EnumOne', > 'data': [ 'value1', 'value2', 'value3' ] } > > { 'type': 'UserDefBas

Re: [Qemu-devel] [PATCH V9 00/10] qapi script: support enum as discriminator and better enum name

2014-03-07 Thread Luiz Capitulino
On Thu, 06 Mar 2014 13:21:21 +0100 Markus Armbruster wrote: > Wenchao Xia writes: > > > This series address two issues: > > > > 1. support using enum as discriminator in union. > > For example, if we have following define in qapi schema: > > { 'enum': 'EnumOne', > > 'data': [ 'value1', 'value

[Qemu-devel] [Bug 1252270] Re: installing NT4 on MIPS Magnum/Jazz asserts

2014-03-07 Thread Darkstar
This bug is still present in qemu 1.7.0: qemu-system-mips64el: g364: invalid read at [00102000] qemu-system-mips64el: hw/scsi/scsi-bus.c:1578: scsi_req_data: Assertion `req->cmd.mode != SCSI_XFER_NONE' failed. ./nt4mips.sh: line 3: 26409 Aborted (core dumped) ./qemu-syste

[Qemu-devel] [PULL 14/19] blockdev: Fail blockdev-add with encrypted images

2014-03-07 Thread Kevin Wolf
Encrypted images need a password before they can be used, and we don't want blockdev-add to create BDSes that aren't fully initialised. So for now simply forbid encrypted images; we can come back to it later if we need the functionality. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- blo

[Qemu-devel] [PULL 15/19] blockdev: Fix NULL pointer dereference in blockdev-add

2014-03-07 Thread Kevin Wolf
If aio=native, we check that cache.direct is set as well. If however cache wasn't specified at all, qemu just segfaulted. The old condition didn't make any sense anyway because it effectively only checked for the default cache mode case, but not for an explicitly set cache.direct=off mode. Signed

[Qemu-devel] [PULL 11/19] block/raw-posix: Strip "file:" prefix on creation

2014-03-07 Thread Kevin Wolf
From: Max Reitz The bdrv_create() implementation of the block/raw-posix "file" protocol driver should strip the "file:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf --- block/raw-posix.c | 2 ++ 1 file

Re: [Qemu-devel] [PATCH] tests: Fix 'make test' for i686 hosts (buildregression))

2014-03-07 Thread Peter Maydell
On 7 March 2014 13:19, Stefan Weil wrote: > test-i386 does some calculations and prints the results (see source code > tests/tcg/test-i386.c). If the user mode emulation of QEMU works, it > should not matter whether that executable runs native or emulated and > both outputs be identical. They aren

Re: [Qemu-devel] [PATCH 2/2 V4] spaces around '<<' everywhere

2014-03-07 Thread Eric Blake
On 03/07/2014 06:20 AM, Romain Dolbeau wrote: > Signed-off-by: Romain Dolbeau > --- > hw/net/e1000.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > if (++s->eecd_state.bitnum_in == 9 && !s->eecd_state.reading) { > -s->eecd_state.bitnum_out = ((s->eecd

  1   2   >