[Qemu-devel] [PATCH v19 03/11] pc: pass QEMUMachineInitArgs to pc_memory_init

2014-03-03 Thread Hu Tao
From: Paolo Bonzini Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 11 +-- hw/i386/pc_piix.c| 8 +++- hw/i386/pc_q35.c | 4 +--- include/hw/i386/pc.h | 7 +++ 4 files changed, 12 insertions(+), 18 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 4

[Qemu-devel] [PULL 12/13] qga: Remove unneeded include file

2014-03-03 Thread Michael Tokarev
From: Stefan Weil This file does not depend on windows.h. Signed-off-by: Stefan Weil Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Michael Tokarev --- qga/main.c |1 - 1 file changed, 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index cfca291..d838c3e 1006

[Qemu-devel] [PULL 06/13] stubs: Optimize dependencies for gdbstub.c

2014-03-03 Thread Michael Tokarev
From: Stefan Weil It does not need qemu-common.h. Including exec/gdbstub.h fixes a warning from static code analyzers and avoids mismatching declarations for xml_builtin. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- stubs/gdbstub.c |4 +++- 1 file changed, 3 insertions(+)

[Qemu-devel] [PULL 10/13] exec: Remove unneeded include files

2014-03-03 Thread Michael Tokarev
From: Stefan Weil This file does not depend on windows.h. Signed-off-by: Stefan Weil Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Michael Tokarev --- exec.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/exec.c b/exec.c index b69fd29..6802

[Qemu-devel] [PULL 03/13] bswap: Modify prototype of stb_p (avoid type conversions)

2014-03-03 Thread Michael Tokarev
From: Stefan Weil The function uses an uint8_t value, so show this in the function prototype. Non-optimizing compilers will avoid unnecessary type conversions from (u)int8_t to int and back to uint8_t when generating calls of this inline function. stw_p, stl_p and stq_p already use similar proto

Re: [Qemu-devel] git build from clean broken?

2014-03-03 Thread Paolo Bonzini
Il 04/03/2014 07:57, Stefan Weil ha scritto: Simply take the version without confusing review comments: http://patchwork.ozlabs.org/patch/324909/. :-) To be honest: the other patch fixes one build regression and introduces a new one, so it would not improve the situation. Paolo noticed that Mak

[Qemu-devel] [PULL 00/13] Trivial patches for 2014-03-04

2014-03-03 Thread Michael Tokarev
Here's another pull request for trivial-patches tree. There's nothing exciting in there, small things here and there. Please consider pulling/applying. Thanks, /mjt The following changes since commit d844a7b6569fb2b5252773444b18841426e5b906: modules: Fix building with --enable-modules (2014-0

[Qemu-devel] [PULL 13/13] vl: Remove unneeded include file

2014-03-03 Thread Michael Tokarev
From: Stefan Weil This file does not depend on windows.h. Cc: Anthony Liguori Signed-off-by: Stefan Weil Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Michael Tokarev --- vl.c |4 1 file changed, 4 deletions(-) diff --git a/vl.c b/vl.c index 1d27b34..bf619

[Qemu-devel] [PULL 09/13] util/iov: Use qemu/sockets.h instead of conditional code

2014-03-03 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Michael Tokarev --- util/iov.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/util/iov.c b/util/iov.c index 03934da..6569b5a 100644 --- a/util/io

Re: [Qemu-devel] [PATCH] xics-kvm: fix reset function

2014-03-03 Thread Alexey Kardashevskiy
On 02/13/2014 12:08 PM, Alexey Kardashevskiy wrote: > Currently interrupt priorities are set to 0 (highest) at the very > beginning of the guest execution which is not correct and makes the guest > produce random interrupt error messages such as: > "Interrupt 0x1001 (real) is invalid, disabling it"

[Qemu-devel] [PULL 04/13] bswap: Modify prototypes of st[wl]_{le, be}_p (avoid type conversions)

2014-03-03 Thread Michael Tokarev
From: Stefan Weil The functions use uint16_t or uint32_t values, so show this in the function prototypes. Non-optimizing compilers will avoid unnecessary type conversions when generating calls of these inline functions. stq_le_p, stq_be_p already use similar prototypes. Signed-off-by: Stefan We

Re: [Qemu-devel] git build from clean broken?

2014-03-03 Thread Stefan Weil
Am 04.03.2014 00:50, schrieb Peter Maydell: > > Do we have a definite version of this fix which everybody is happy > with yet? I've got confused with the various versions and review > comments on them. I'd like to apply the buildfix before I apply > any further pull requests... > > thanks > -- PM

[Qemu-devel] [PULL 07/13] tests/test-int128: Don't use __noclone__ attribute on clang

2014-03-03 Thread Michael Tokarev
From: Peter Maydell clang doesn't support the __noclone__ attribute and emits a warning about it. Fortunately clang also implements a mechanism for asking if a particular attribute is implemented; use it. We assume that if the compiler doesn't support __has_attribute() then it must be GCC and mus

[Qemu-devel] [PULL 02/13] object: Report type in error when not user creatable.

2014-03-03 Thread Michael Tokarev
From: Hani Benhabiles Signed-off-by: Hani Benhabiles Reviewed-by: Hu Tao Acked-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- qmp.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qmp.c b/qmp.c index d0d98e7..f556a04 100644 --- a/qmp.c +++ b/qmp.c @@ -556,8 +

[Qemu-devel] [PATCH v3 0/2] fix query-command-line-options

2014-03-03 Thread Amos Kong
This patchset fixed some issues of query-command-line-options: * some new options that haven't argument can't be queried. (eg: -enable-fips) * some legacy options that have argument can't be queried. (eg: -vnc display) More discussion: http://marc.info/?l=qemu-devel&m=139081830416684&w=2 V2: r

[Qemu-devel] [PULL 01/13] include/qemu/host-utils.h: Trivial typo: ctz->cto

2014-03-03 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Michael Tokarev --- include/qemu/host-utils.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/host-utils.h b/include/qemu/host-utils.h index de85d28..285c5fb 100644 --- a/inc

[Qemu-devel] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-03 Thread Amos Kong
vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will be lost. We have some macros in qemu-options.hx

[Qemu-devel] [PULL 08/13] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration

2014-03-03 Thread Michael Tokarev
From: Peter Maydell The function qobject_from_json() doesn't actually allow its argument to be a format string -- it passes a NULL va_list* to qobject_from_jsonv(), and the parser code will then never actually interpret %-escape sequences (it tests whether the va_list pointer is NULL and will sto

[Qemu-devel] [PULL 05/13] tcg: Fix typo in comment (dependancies -> dependencies)

2014-03-03 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- tcg/tcg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index ffc851e..f1e0763 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -41,7 +41,7 @@ #include "qemu/host-utils.h"

[Qemu-devel] [PULL 11/13] qemu-img: Remove unneeded include files

2014-03-03 Thread Michael Tokarev
From: Stefan Weil There is no dependency on windows.h, and the standard include files are already included by qemu-common.h. Signed-off-by: Stefan Weil Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Michael Tokarev --- qemu-img.c |6 -- 1 file changed, 6 delet

Re: [Qemu-devel] [PCTCH v2 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-03 Thread Amos Kong
On Mon, Mar 03, 2014 at 05:37:57PM -0700, Eric Blake wrote: > > --- > > qapi-schema.json | 8 ++-- > > util/qemu-config.c | 52 > > ++-- > > 2 files changed, 52 insertions(+), 8 deletions(-) > > > > diff --git a/qapi-schema.json b/qapi-sche

[Qemu-devel] [PATCH v3 1/2] qmp: rename query_option_descs() to get_param_infolist()

2014-03-03 Thread Amos Kong
Signed-off-by: Amos Kong --- util/qemu-config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/qemu-config.c b/util/qemu-config.c index 9298f55..d624d92 100644 --- a/util/qemu-config.c +++ b/util/qemu-config.c @@ -39,7 +39,7 @@ QemuOptsList *qemu_find_opts(const

Re: [Qemu-devel] [Discussion 00/10] about API hierarchy

2014-03-03 Thread Xuebing wang
Hi Andreas, thank you very much for your reply. Would you please help review/correct doc/api-hierarchy too? On 03/04/2014 11:45 AM, Andreas Färber wrote: Hi Xuebing, Am 04.03.2014 03:47, schrieb Xuebing Wang: Q2) Does it make sense to remove NEED_CPU_H from qemu-common.h? IMO not in this wa

Re: [Qemu-devel] [RFC PATCH v0] ppc: Force CPU threads count to be a power of 2.

2014-03-03 Thread Stewart Smith
Bharata B Rao writes: > @@ -7987,6 +7989,12 @@ static void ppc_cpu_realizefn(DeviceState *dev, Error > **errp) > max_smt, kvm_enabled() ? "KVM" : "TCG"); > return; > } > +threads_shift = log2(smp_threads); > +if (smp_threads != (1 << threads_shift)) { > +

[Qemu-devel] [RFC PATCH v0] ppc: Force CPU threads count to be a power of 2.

2014-03-03 Thread Bharata B Rao
PowerPC kernel expects the number of SMT threads in a core to be a power of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel crash if invalid threads count is specified. Prevent this crash and make it a graceful exit from QEMU itself by validating the user supplied threads cou

[Qemu-devel] -smp question

2014-03-03 Thread Alexey Kardashevskiy
Hi! -smp 8,sockets=1,cores=3,threads=4 does not produce an error and the actual CPU topology is -smp 8,threads=2 which is not really the same. Also the user actually expected 1*3*4=12 CPUs, conflict again. What would the correct fix be? Or there is yet another SMP QOM rework coming and it will fi

[Qemu-devel] [PATCH v2 1/3] vl: add system_wakeup_request tracepoint

2014-03-03 Thread Alexey Kardashevskiy
It might be useful for tracing migration. Signed-off-by: Alexey Kardashevskiy --- trace-events | 1 + vl.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/trace-events b/trace-events index 3713063..dbbaa04 100644 --- a/trace-events +++ b/trace-events @@ -486,6 +486,7 @@ runstate_s

[Qemu-devel] [PATCH v2 0/3] migration: add more traces

2014-03-03 Thread Alexey Kardashevskiy
This reworks/adds traces for migration. v2 is rework of an original single patch with the same subject. Alexey Kardashevskiy (3): vl: add system_wakeup_request tracepoint migration: extend section_start/end traces migration: add more traces migration.c | 30 ++

[Qemu-devel] [Discussion 04/10] memory_mapping: make this architecture-independent

2014-03-03 Thread Xuebing Wang
Use vaddr (instead of target_ulong) for virtual address. See document HACKING for more information about vaddr and target_ulong. Signed-off-by: Xuebing Wang --- include/sysemu/memory_mapping.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/sysemu/memory_mapping.

[Qemu-devel] [PATCH v2 2/3] migration: extend section_start/end traces

2014-03-03 Thread Alexey Kardashevskiy
This adds @idstr to savevm_section_start and savevm_section_end tracepoints. Signed-off-by: Alexey Kardashevskiy --- savevm.c | 12 ++-- trace-events | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/savevm.c b/savevm.c index 7329fc5..d094fbb 100644 --- a/save

[Qemu-devel] [PATCH v2 3/3] migration: add more traces

2014-03-03 Thread Alexey Kardashevskiy
This replaces DPRINTF macro with tracepoints. This moves some messages from migration.c to savevm.c. This adds tracepoint to signal about fileds failed to migrate. Signed-off-by: Alexey Kardashevskiy --- migration.c | 30 ++ qemu-file.c | 2 ++ savevm.c | 8

[Qemu-devel] [Bug 1287195] [NEW] validate_guest_space incorrectly enabled on AArch64

2014-03-03 Thread Amanieu d'Antras
Public bug reported: When running linux-user targetting AArch64, validate_guest_space() in elfload.c reserves space in the guest address space for the ARM commpage. Since there is no commpage on AArch64, this function should be disable on that target. ** Affects: qemu Importance: Undecided

[Qemu-devel] [PATCH 4/4] linux-user: remove configure option for setting uname release

2014-03-03 Thread riku . voipio
From: Riku Voipio The --enable-uname-release is rather heavyweight hammer, as it allows providing values less that UNAME_MINIMUM_RELEASE. Also, it affects all built linux-user targets, which in most cases not what you want. Now that we have UNAME_MINIMUM_RELEASE for all linux-user platforms, we

Re: [Qemu-devel] [Discussion 00/10] about API hierarchy

2014-03-03 Thread Andreas Färber
Hi Xuebing, Am 04.03.2014 03:47, schrieb Xuebing Wang: > Q2) Does it make sense to remove NEED_CPU_H from qemu-common.h? IMO not in this way. Work has been ongoing to obsolete NEED_CPU_H by introducing CPUState in addition to CPUArchState and moving fields into CPUState, so that less files need t

[Qemu-devel] [PATCH 3/4] linux-user: set minimum kernel version to 2.6.32

2014-03-03 Thread riku . voipio
From: Riku Voipio Popular glibc based distributions[1] require minimum 2.6.32 as kernel version. For some targets 2.6.18 would be enough, but dropping so low would mean some suboptimal system calls could get used. Set the minimum kernel advertized to 2.6.32 for all architectures but aarch64 to e

[Qemu-devel] [PATCH 0/4] linux-user: uname release cleanup

2014-03-03 Thread riku . voipio
From: Riku Voipio Currently some distributors use --enable-uname-release=2.6.32 or something similar to allow running new target binaries on old host systems. In 4a24a758101ff726c9bd3b867e12d5580c793af0 and more flexible solution was created. However, if you continue to compile with the --enab

[Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of "exec-all.h"

2014-03-03 Thread Xuebing Wang
include/exec/exec-all.h should ONLY be included in target-xxx/* - 'git grep -nw exec-all.h' confirms this Signed-off-by: Xuebing Wang --- cputlb.c |1 - tcg/README |2 +- tci.c |2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/cputlb.c b/cputlb.c index 72

[Qemu-devel] [Discussion 03/10] NEED_CPU_H: remove unnecessary use of NEED_CPU_H

2014-03-03 Thread Xuebing Wang
Note: there is a FIXME to be addressed in this patch. For every appearance of NEED_CPU_H, there must be '#include "cpu.h"' to include "target-xxx/cpu.h", because the code below NEED_CPU_H depends on architecture-specific information. Signed-off-by: Xuebing Wang --- include/exec/cpu-common.h |

Re: [Qemu-devel] [PATCH V2] virtio-net: calculate proper msix vectors on init

2014-03-03 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Jason Wang > Sent: Friday, February 21, 2014 5:05 PM > To: aligu...@amazon.com; m...@redhat.com; qemu-devel@nongnu.org > Cc: Pao

[Qemu-devel] [Discussion 10/10] translate: remove file translate-all.h

2014-03-03 Thread Xuebing Wang
This patch does below: - Move the declaration of 2 translate functions from translate-all.h into include/exec/translate.h - remove file translate-all.h Signed-off-by: Xuebing Wang --- exec.c |2 -- include/exec/translate.h |4 translate-all.c |

[Qemu-devel] [PATCH 1/4] linux-user: rename cpu-uname -> uname

2014-03-03 Thread riku . voipio
From: Riku Voipio To move more uname related functions out of syscall.c, rename cpu-uname.{c,h} to uname.{c.h} Signed-off-by: Riku Voipio --- linux-user/Makefile.objs | 2 +- linux-user/cpu-uname.c | 72 linux-user/cpu-uname.h | 1 - linux

[Qemu-devel] [PATCH 2/4] linux-user: move uname functions to uname.c

2014-03-03 Thread riku . voipio
From: Riku Voipio Make syscall.c slightly smaller by moving uname-related functions to uname.c. Signed-off-by: Riku Voipio --- linux-user/syscall.c | 102 --- linux-user/uname.c | 101 ++ linux-us

[Qemu-devel] [PATCH qom-cpu 6/6] cpu: Factor out cpu_generic_init()

2014-03-03 Thread Andreas Färber
All targets using it gain the ability to set -cpu name,key=value,... options via the default TYPE_CPU CPUClass::parse_features() implementation. Signed-off-by: Andreas Färber --- include/qom/cpu.h | 11 +++ qom/cpu.c | 41 ++

[Qemu-devel] [PATCH qom-cpu 2/6] target-sparc: Use error_report() for CPU error reporting

2014-03-03 Thread Andreas Färber
Replace non-debug fprintf() with error_report(). Signed-off-by: Andreas Färber --- target-sparc/cpu.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c index e91a2f3..ed005b2 100644 --- a/target-sparc/cpu.c +++ b/target-

[Qemu-devel] [PATCH qom-cpu 3/6] target-sparc: Implement CPUClass::parse_features() for SPARCCPU

2014-03-03 Thread Andreas Färber
Factor cpu_model parsing out of cpu_sparc_find_by_name() by passing cpu_sparc_find_by_name() the name portion only and calling CPUClass::parse_features() from cpu_sparc_register() afterwards. Signed-off-by: Andreas Färber --- target-sparc/cpu.c | 82 --

[Qemu-devel] [PATCH qom-cpu 4/6] target-sparc: Defer SPARCCPU feature inference to QOM realize

2014-03-03 Thread Andreas Färber
Gets it out of cpu_sparc_register() and aligns with target-arm. Signed-off-by: Andreas Färber --- target-sparc/cpu.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c index c948b49..42c6de9 100644 --- a/target-sparc/cpu.c ++

[Qemu-devel] [PATCH qom-cpu 5/6] cpu: Implement CPUClass::parse_features() for the rest of CPUs

2014-03-03 Thread Andreas Färber
CPUs who do not provide their own implementation of feature parsing will treat each option as a QOM property and set it to the supplied value. Signed-off-by: Andreas Färber --- qom/cpu.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/qom/cpu.c

[Qemu-devel] [PATCH qom-cpu 1/6] cpu: Introduce CPUClass::parse_features() hook

2014-03-03 Thread Andreas Färber
Adapt the X86CPU implementation to suit the generic hook. This involves a cleanup of error handling to cope with NULL errp. Signed-off-by: Andreas Färber --- include/qom/cpu.h | 3 +++ target-i386/cpu.c | 36 +--- 2 files changed, 24 insertions(+), 15 deletions(-

[Qemu-devel] [PATCH qom-cpu 0/6] cpu: Unifying features parsing

2014-03-03 Thread Andreas Färber
Hello, Prompted by Alexey's desire for tweakable PowerPCCPU properties but also by Peter's wish for ARMCPU properties, this series sets out to align cpu_model parsing across targets. QemuOpts would've been nice to use, but on the one hand x86 and sparc use QemuOpts-incompatible +foo and -foo synt

[Qemu-devel] [Discussion 06/10] memory: move contents in include/exec/address-spaces.h => memory.h

2014-03-03 Thread Xuebing Wang
In preparation for removing include/exec/address-spaces.h Signed-off-by: Xuebing Wang --- include/exec/address-spaces.h | 29 - include/exec/memory.h | 19 +++ include/hw/sh4/sh_intc.h |1 + 3 files changed, 16 insertions(+), 33 de

[Qemu-devel] [Discussion 07/10] memory: remove file include/exec/address-spaces.h

2014-03-03 Thread Xuebing Wang
Remove '#include "exec/address-spaces.h"' is done by: git grep -w "exec\/address-spaces.h" | cut -d: -f1 | xargs sed -i '/exec\/address-spaces.h/d' Signed-off-by: Xuebing Wang --- arch_init.c |1 - cputlb.c |1 - exec.c

[Qemu-devel] [Discussion 08/10] exec: move TranslationBlock API from exec-all.h => translate.h

2014-03-03 Thread Xuebing Wang
Signed-off-by: Xuebing Wang --- include/exec/exec-all.h | 302 + include/exec/translate.h | 306 ++ 2 files changed, 307 insertions(+), 301 deletions(-) create mode 100644 include/exec/translate.h diff --

[Qemu-devel] [Discussion 05/10] NEED_CPU_H: remove unnecessary inclusion of "cpu.h" in root

2014-03-03 Thread Xuebing Wang
Enforce the strict associativity between NEED_CPU_H and "inclusion of cpu.h", for every appearance of '#include "cpu.h"', there must have the check of NEED_CPU_H, and conversely. This patch only checks file in qemu root directory by: grep -nw "cpu.h" *.[ch] . Note: remove unnecessary inclusion of

[Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include "cpu.h"' from include/qemu-common.h

2014-03-03 Thread Xuebing Wang
Note: there is a FIXME to be addressed in this patch. This patch handles NEED_CPU_H (thus "target-xxx/cpu.h") only. The changes are: - Remove inclusion of "cpu.h" from qemu-common.h - CPU_SAVE_VERSION is defined in target-xxx/cpu.h as well, thus move it out of qemu-common.h, and move it in

[Qemu-devel] [Discussion 01/10] docs: add docs/api-hierarchy.txt

2014-03-03 Thread Xuebing Wang
Signed-off-by: Xuebing Wang --- docs/api-hierarchy.txt | 93 1 file changed, 93 insertions(+) create mode 100644 docs/api-hierarchy.txt diff --git a/docs/api-hierarchy.txt b/docs/api-hierarchy.txt new file mode 100644 index 000..9982f51 ---

[Qemu-devel] [Discussion 00/10] about API hierarchy

2014-03-03 Thread Xuebing Wang
Hi Community, Q1) Is it helpful for the document docs/api_hierarchy.txt I wrote? Would you please help review/correct it? Q2) Does it make sense to remove NEED_CPU_H from qemu-common.h? Q3) In include/sysemu/kvm.h, CONFIG_KVM is used thus considering dependency we should include "config-

Re: [Qemu-devel] [PATCH v18 10/14] numa: add -numa node, memdev= option

2014-03-03 Thread Hu Tao
On Mon, Mar 03, 2014 at 05:10:20PM -0700, Eric Blake wrote: > On 02/19/2014 12:54 AM, Hu Tao wrote: > > From: Paolo Bonzini > > > > This option provides the infrastructure for binding guest NUMA nodes > > to host NUMA nodes. For example: > > > > -object memory-ram,size=1024M,policy=membind,hos

Re: [Qemu-devel] [PATCH v21 02/25] qapi: output def_value_str when query command line options

2014-03-03 Thread Chunyan Liu
2014-03-04 8:02 GMT+08:00 Eric Blake : > On 02/21/2014 03:35 AM, Chunyan Liu wrote: > > Change qapi interfaces to output the newly added def_value_str when > querying > > command line options. > > > > Signed-off-by: Dong Xu Wang > > Signed-off-by: Chunyan Liu > > --- > > qapi-schema.json |

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-03 Thread Huangpeng (Peter)
> Hi Paolo, > > On Mon, Mar 03, 2014 at 02:47:31PM +0100, Paolo Bonzini wrote: > > I'm not sure what's the status of the kernel infrastructure for > > post-copy. Andrea? > > sys_userfaultfd is still work in progress but it shouldn't be much work left > to > completion. madvise(MADV_USERFAUL

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-03 Thread Huangpeng (Peter)
> > I think this is different in the same way that block-backup and > > block-mirror are different. Huangpeng's proposal would let you make a > > consistent snapshot of disks and RAM. > > Right. Though the point isn't about consistency (doing the disk snapshot when > memory has converged would be

Re: [Qemu-devel] [PATCH v7 0/2] target-ppc: CPU device tree id

2014-03-03 Thread Alexey Kardashevskiy
On 03/04/2014 11:29 AM, Alexander Graf wrote: > Alexey Kardashevskiy wrote: >> This is some cleanup. Please, comment. Thanks! >> > > Thanks, applied to ppc-next. Please bear in mind that your target CPU > finding loop doesn't scale. So make sure you don't call your new dt > index helper in any

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-03 Thread Huangpeng (Peter)
> > > Here I have another proposal, based on the live-migration scheme, > > > add consistent memory state tracking and saving. > > > The idea is simple: > > > 1.First round use live-migration to save all memory to a snapshot file. > > > 2.intercept the action of memory-modify, save old pages to a

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-03 Thread Huangpeng (Peter)
> Yes, this is the tricky part. To be honest, I think this is the reason no > one has > submitted patches - it's a hard task and the win isn't that great (you can > already migrate to file). > Yes, lots of places have to be considered. Though scenarios are limited, users like library experimen

Re: [Qemu-devel] [PATCH 0/3] hw/9pfs: fix 3 issues which related with path string

2014-03-03 Thread Chen Gang
On 03/04/2014 01:43 AM, Eric Blake wrote: > On 03/01/2014 10:33 AM, Chen Gang wrote: >> Patch 1/3: move v9fs_string_free() to below "err_out:" >> >> Patch 2/3: use snprintf() instead of sprintf() >>(which will be replaced of by Path 3/3) >> >> Patch 3/3: use g_strdup_printf() instead of

Re: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-03 Thread Chen Gang
On 03/03/2014 10:42 PM, Markus Armbruster wrote: > Chen Gang writes: > >> On 03/03/2014 04:34 PM, Markus Armbruster wrote: >>> Turns a buffer overrun bug into a truncation bug. The next commit fixes >>> truncation bugs including this one. Would be nice to spell this out in >>> the commit messag

Re: [Qemu-devel] [PCTCH v2 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-03 Thread Eric Blake
On 03/03/2014 10:41 AM, Amos Kong wrote: s/PCTCH/PATCH/ in the subject, although it doesn't affect patch application. > vm_config_groups[] only contains part of the options which have > argument, and all options which have no argument isn't added to s/isn't/aren't/ > vm_config_groups[]. Current

Re: [Qemu-devel] [PATCH v7 0/2] target-ppc: CPU device tree id

2014-03-03 Thread Alexander Graf
Alexey Kardashevskiy wrote: > This is some cleanup. Please, comment. Thanks! > Thanks, applied to ppc-next. Please bear in mind that your target CPU finding loop doesn't scale. So make sure you don't call your new dt index helper in any code path where you care about performance. Or when you do

Re: [Qemu-devel] [PATCH 3/3] hw/9pfs: use g_strdup_printf() instead of PATH_MAX limitation

2014-03-03 Thread Chen Gang
On 03/04/2014 03:29 AM, Aneesh Kumar K.V wrote: > "Aneesh Kumar K.V" writes: > >> Chen Gang writes: >> Can we keep this as >> v9fs_co_run_in_worker( >> { >> >>buf->data = __readlink(&s->ctx, path); >> >> } >> >> I can do that change f

Re: [Qemu-devel] [PCTCH v2 1/2] qmp: rename query_option_descs() to get_param_infolist()

2014-03-03 Thread Eric Blake
On 03/03/2014 10:41 AM, Amos Kong wrote: > Signed-off-by: Amos Kong > --- > util/qemu-config.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Purely mechanical. Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http:/

Re: [Qemu-devel] [PATCH 1/3] hw/9pfs/virtio-9p-local.c: move v9fs_string_free() to below "err_out:"

2014-03-03 Thread Chen Gang
On 03/03/2014 11:29 PM, Aneesh Kumar K.V wrote: > Chen Gang writes: > >> When "goto err_out", 'v9fs_string' already was allocated, so still need >> free 'v9fs_string' before return. >> >> Signed-off-by: Chen Gang > > Reviewed-by: Aneesh Kumar K.V > Thanks. -- Chen Gang Open, share, and a

Re: [Qemu-devel] [PULL v2 33/37] block: vhdx - add .bdrv_create() support

2014-03-03 Thread Alexander Graf
> Am 04.03.2014 um 03:58 schrieb Jeff Cody : > >> On Fri, Feb 21, 2014 at 01:06:43PM +0100, Alexander Graf wrote: >> >>> On 08.11.2013, at 11:12, Stefan Hajnoczi wrote: >>> >>> From: Jeff Cody >>> >>> This adds support for VHDX image creation, for images of type "Fixed" >>> and "Dynamic".

Re: [Qemu-devel] [PATCH v18 10/14] numa: add -numa node, memdev= option

2014-03-03 Thread Eric Blake
On 02/19/2014 12:54 AM, Hu Tao wrote: > From: Paolo Bonzini > > This option provides the infrastructure for binding guest NUMA nodes > to host NUMA nodes. For example: > > -object memory-ram,size=1024M,policy=membind,host-nodes=0,id=ram-node0 \ > -numa node,nodeid=0,cpus=0,memdev=ram-node0 \

Re: [Qemu-devel] [PATCH v21 02/25] qapi: output def_value_str when query command line options

2014-03-03 Thread Eric Blake
On 02/21/2014 03:35 AM, Chunyan Liu wrote: > Change qapi interfaces to output the newly added def_value_str when querying > command line options. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > qapi-schema.json |8 ++-- > qmp-commands.hx|2 ++ > util/qemu-

Re: [Qemu-devel] git build from clean broken?

2014-03-03 Thread Peter Maydell
On 27 February 2014 22:17, Peter Maydell wrote: > Can you either post that to the list as a proper patch or alternatively > just add a reviewed-by tag to the patch Stefan sent earlier, depending > which you think is the better fix? Then I'll apply it... Do we have a definite version of this fix

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-03 Thread Peter Maydell
On 3 March 2014 20:32, Aneesh Kumar K.V wrote: > BTW where do i find docs for land/lnot etc ? Best we have is the comments in rules.mak where they're defined... thanks -- PMM

Re: [Qemu-devel] [PATCH 01/17] QAPI: introduce migration capability x_unix_page_flipping

2014-03-03 Thread Eric Blake
On 12/02/2013 02:19 AM, Lei Li wrote: > Introduce x_unix_page_flipping to MigrationCapability for > localhost migration. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Lei Li > --- > qapi-schema.json | 12 +++- > 1 files changed, 11 insertions(+), 1 deletions(-) I don't see this i

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-03 Thread Serge E. Hallyn
Quoting Aneesh Kumar K.V (aneesh.ku...@linux.vnet.ibm.com): > Paolo Bonzini writes: > > > Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto: > >> From: "Aneesh Kumar K.V" > >> > >> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including > >> hw/Makefile.objs directly from Makefile.

Re: [Qemu-devel] e1000 memory corruption in guest OS

2014-03-03 Thread Alexey Kardashevskiy
On 03/04/2014 08:33 AM, Don Slutz wrote: > On 03/03/14 05:47, Alexey Kardashevskiy wrote: >> On 03/03/2014 07:33 PM, Paolo Bonzini wrote: >>> Il 03/03/2014 02:58, Alexey Kardashevskiy ha scritto: On 03/02/2014 08:31 AM, Paolo Bonzini wrote: > Il 01/03/2014 13:30, Alexey Kardashevskiy ha sc

Re: [Qemu-devel] [PATCH v7 2/2] target-ppc: spapr: e500: fix to use cpu_dt_id

2014-03-03 Thread Alexey Kardashevskiy
On 03/04/2014 06:57 AM, Mike Day wrote: > On Sat, Feb 1, 2014 at 9:45 AM, Alexey Kardashevskiy wrote: >> This makes use of @cpu_dt_id and related API in: >> 1. emulated XICS hypercall handlers as they receive fixed CPU indexes; >> 2. XICS-KVM to enable in-kernel XICS on right CPU; >> 3. device-tre

Re: [Qemu-devel] [PATCH v2 5/7] allwinner-a10-pit: implement prescaler and source selection

2014-03-03 Thread Beniamino Galvani
On Mon, Mar 03, 2014 at 08:57:33PM +1000, Peter Crosthwaite wrote: > On Mon, Mar 3, 2014 at 12:06 AM, Beniamino Galvani > wrote: > > This implements the prescaler and source fields of the timer control > > register as described in the A10 user manual. > > > > Signed-off-by: Beniamino Galvani > >

Re: [Qemu-devel] [PATCH v2 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

2014-03-03 Thread Beniamino Galvani
On Mon, Mar 03, 2014 at 09:08:27PM +1000, Peter Crosthwaite wrote: > On Mon, Mar 3, 2014 at 12:06 AM, Beniamino Galvani > wrote: > > The model was generating interrupts for all enabled timers after the > > expiration of one of them. Avoid this by passing to the timer callback > > function a struc

Re: [Qemu-devel] [PATCH v2 1/7] allwinner-a10-pic: set vector address when an interrupt is pending

2014-03-03 Thread Beniamino Galvani
On Mon, Mar 03, 2014 at 09:16:13PM +1000, Peter Crosthwaite wrote: > On Mon, Mar 3, 2014 at 12:06 AM, Beniamino Galvani > wrote: > > This patch implements proper updating of the vector register which > > should hold, according to the A10 user manual, the vector address for > > the interrupt curre

Re: [Qemu-devel] [PATCH v2 2/7] allwinner-a10-pic: update pending register when an irq is cleared

2014-03-03 Thread Beniamino Galvani
On Mon, Mar 03, 2014 at 09:56:07PM +1000, Peter Crosthwaite wrote: > On Mon, Mar 3, 2014 at 12:06 AM, Beniamino Galvani > wrote: > > The value of pending register was updated only when an irq was raised > > from a device; it should also be updated when an interrupt is cleared. > > So the reason

[Qemu-devel] [Bug 1243287] Re: [KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail

2014-03-03 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/cloud-init -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1243287 Title: [KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail Status in QEMU: Fix Comm

Re: [Qemu-devel] [PATCH 0/2] PC: improve emulation correctness

2014-03-03 Thread Hervé Poussineau
Ping. QEMU crash at reboot is due to not resetting PAM registers at i440fx reset, but a patch has already been rejected on ML: http://lists.gnu.org/archive/html/qemu-devel/2013-02/msg02928.html Hervé Hervé Poussineau a écrit : With those two patches, I'm able to run a real BIOS in QEMU (Iwi

Re: [Qemu-devel] [RFC 4/4] Relevant changes to enable KVM to TCG migration

2014-03-03 Thread Peter Maydell
On 26 February 2014 10:02, alvise rigo wrote: > I agree that this is a sort of workaround, but it seems to me that a > proper solution is not possible without changing the ideas contemplated > now in the migration code. > Are we willing to accept some major changes in the code to embrace > this ty

Re: [Qemu-devel] e1000 memory corruption in guest OS

2014-03-03 Thread Don Slutz
On 03/03/14 05:47, Alexey Kardashevskiy wrote: On 03/03/2014 07:33 PM, Paolo Bonzini wrote: Il 03/03/2014 02:58, Alexey Kardashevskiy ha scritto: On 03/02/2014 08:31 AM, Paolo Bonzini wrote: Il 01/03/2014 13:30, Alexey Kardashevskiy ha scritto: Corrupted DMA buffer is 0x e0 -- 0x7f15c313f

Re: [Qemu-devel] [PATCH] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-03 Thread Paolo Bonzini
Il 03/03/2014 20:13, Benoît Canet ha scritto: Hmm I did not even though it was a bug, I merely rewrote the code to adapt to the new way of doing. Should I mention the bugfix and repost ? Up to Kevin. Paolo

Re: [Qemu-devel] [PATCH 0/5] linux-user: various fixes for AArch64

2014-03-03 Thread Riku Voipio
On Sun, Mar 02, 2014 at 07:36:37PM +, Peter Maydell wrote: > Riku: do you want to take these via linux-user or should I > put them in via target-arm? linux-user seems like it makes more > sense to me; there's no dependency on target-arm patches and > some of the patches are generic fixes. Eithe

Re: [Qemu-devel] [PATCH 2/7] KVM: s390: virtio-ccw adapter interrupt support.

2014-03-03 Thread Christian Borntraeger
On 25/02/14 18:24, Cornelia Huck wrote: > Implement the new CCW_CMD_SET_IND_ADAPTER command and try to enable > adapter interrupts for every device on the first startup. If the host > does not support adapter interrupts, fall back to normal I/O interrupts. > > virtio-ccw adapter interrupts use the

Re: [Qemu-devel] [PATCH] seccomp: add shmctl(), mlock(), and munlock() to the syscall whitelist

2014-03-03 Thread Paul Moore
On Wednesday, February 26, 2014 10:25:01 AM Paul Moore wrote: > Additional testing reveals that PulseAudio requires shmctl() and the > mlock()/munlock() syscalls on some systems/configurations. As before, > on systems that do require these syscalls, the problem can be seen with > the following com

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-03 Thread Aneesh Kumar K.V
Paolo Bonzini writes: > Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto: >> From: "Aneesh Kumar K.V" >> >> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including >> hw/Makefile.objs directly from Makefile.target. Hence we need to define >> the config in Makefile.target too to in

Re: [Qemu-devel] Live migration results in non-working virtio-net device (sometimes)

2014-03-03 Thread Neil Skrypuch
On Saturday 01 March 2014 10:34:03 陈梁 wrote: > > On Thursday 30 January 2014 13:23:04 Neil Skrypuch wrote: > >> First, let me briefly outline the way we use live migration, as it is > >> probably not typical. We use live migration (with block migration) to > >> make > >> backups of VMs with zero do

Re: [Qemu-devel] [Bug 1286253] [NEW] virtio-net acceleration features not set when plugged into backend dynamically

2014-03-03 Thread Mario Smarduch
I don't have an x86 setup handy, but looking through the code 'virtio-net-pci' will work but not 'virtio-net-device'. My understanding was the goal is for any backend to plug into any transport on any platform. I'll try an x86 test with 'virtio-net-device' option and see what happens. Ye

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-03 Thread Aneesh Kumar K.V
"Aneesh Kumar K.V" writes: > Paolo Bonzini writes: > >> Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto: >>> From: "Aneesh Kumar K.V" >>> >>> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including >>> hw/Makefile.objs directly from Makefile.target. Hence we need to define >>> t

Re: [Qemu-devel] [PULL v2 33/37] block: vhdx - add .bdrv_create() support

2014-03-03 Thread Jeff Cody
On Fri, Feb 21, 2014 at 01:06:43PM +0100, Alexander Graf wrote: > > On 08.11.2013, at 11:12, Stefan Hajnoczi wrote: > > > From: Jeff Cody > > > > This adds support for VHDX image creation, for images of type "Fixed" > > and "Dynamic". "Differencing" types (i.e., VHDX images with backing > > f

Re: [Qemu-devel] [PATCH v7 2/2] target-ppc: spapr: e500: fix to use cpu_dt_id

2014-03-03 Thread Mike Day
On Sat, Feb 1, 2014 at 9:45 AM, Alexey Kardashevskiy wrote: > This makes use of @cpu_dt_id and related API in: > 1. emulated XICS hypercall handlers as they receive fixed CPU indexes; > 2. XICS-KVM to enable in-kernel XICS on right CPU; > 3. device-tree renderer. > > This removes @cpu_index fixup

Re: [Qemu-devel] [PATCH RFC V2 2/9] vl: use qemu machine QOM class instead of global machines list

2014-03-03 Thread Marcel Apfelbaum
On Mon, 2014-03-03 at 19:12 +0100, Andreas Färber wrote: > Am 02.03.2014 14:07, schrieb Marcel Apfelbaum: > > The machine registration flow is refactored to use the QOM functionality. > > Instead of linking the machines into a list, each machine has a type > > and the types can be traversed in the

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-03 Thread Andrea Arcangeli
Hi Paolo, On Mon, Mar 03, 2014 at 02:47:31PM +0100, Paolo Bonzini wrote: > I'm not sure what's the status of the kernel infrastructure for > post-copy. Andrea? sys_userfaultfd is still work in progress but it shouldn't be much work left to completion. madvise(MADV_USERFAULT) and remap_anon_pa

Re: [Qemu-devel] [PATCH v7 1/2] target-ppc: add PowerPCCPU::cpu_dt_id

2014-03-03 Thread Mike Day
On Sat, Feb 1, 2014 at 9:45 AM, Alexey Kardashevskiy wrote: > Normally CPUState::cpu_index is used to pick the right CPU for various > operations. However default consecutive numbering does not always work > for POWERPC. > > These indexes are reflected in /proc/device-tree/cpus/PowerPC,POWER7@XX >

  1   2   3   >