Re: [Qemu-devel] [PATCH] configure: Make C++ test work with --enable-werror

2014-02-24 Thread Thomas Huth
On Mon, 24 Feb 2014 19:08:18 + Peter Maydell wrote: > gcc's C++ compiler complains about being passed some -W options > which make sense for C but not for C++. This means we mustn't try > a C++ compile with QEMU_CFLAGS, but only with a filtered version > that removes the offending options. Th

Re: [Qemu-devel] [PATCH 1/2 v3] qdev-monitor: set DeviceState opts before calling realize

2014-02-24 Thread Andreas Färber
Am 25.02.2014 05:34, schrieb Bandan Das: > Setting opts before the realize property is set allows the > following patch to make decisions based on whether the user > specified "rombar". This also avoids having to create a new > tristate property especially for this purpose > > Signed-off-by: Banda

[Qemu-devel] [PATCH qom-cpu v10 1/2] target-i386: Prepare CPUClass::class_by_name for X86CPU

2014-02-24 Thread Andreas Färber
Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- target-i386/cpu.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index a8b8e88..1c009bb 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@

[Qemu-devel] [PATCH qom-cpu v10 2/2] target-i386: X86CPU model subclasses

2014-02-24 Thread Andreas Färber
From: Eduardo Habkost Register separate QOM types for each x86 CPU model. This will allow management code to more easily probe what each CPU model provides, by simply creating objects using the appropriate class name, without having to restart QEMU. This also allows us to eliminate the qdev_pro

[Qemu-devel] [PATCH qom-cpu v10 0/2] target-i386: X86CPU subclasses

2014-02-24 Thread Andreas Färber
Hello, Here's my cleaned up version of slim x86 CPU subclasses. Second patch didn't get a lot of testing yet. Loading cpudef is still in main initfn since otherwise the host type would need to be relocated. Can be cleaned up as follow-ups. I wonder whether we are intentionally registering the ho

[Qemu-devel] [PATCH 1/3] target-i386: Fix CC_OP_CLR vs PF

2014-02-24 Thread Richard Henderson
Parity should be set for a zero result. Cc: qemu-sta...@nongnu.org Signed-off-by: Richard Henderson --- target-i386/cc_helper.c | 2 +- target-i386/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/cc_helper.c b/target-i386/cc_helper.c index ee04092..

[Qemu-devel] [PATCH 3/3] target-i386: Fix ucomis and comis memory access

2014-02-24 Thread Richard Henderson
We were loading 16 bytes for both single and double-precision scalar comparisons. Reported-by: Alexander Bluhm Signed-off-by: Richard Henderson --- The original Bluhm patch didn't fix [u]comiss, but was focused on [u]comisd. r~ --- target-i386/translate.c | 46

[Qemu-devel] [PATCH 0/3] target-i386 updates

2014-02-24 Thread Richard Henderson
The first patch has been seen before. The others are tweeks of a couple of patches I found hanging around my inbox from way back. Another pair of eyes would be helpful. r~ Richard Henderson (3): target-i386: Fix CC_OP_CLR vs PF target-i386: Fix SSE status flag corruption target-i386: Fi

[Qemu-devel] [PATCH 2/3] target-i386: Fix SSE status flag corruption

2014-02-24 Thread Richard Henderson
When we restore the mxcsr register with FXRSTOR, or set it with gdb, we need to update the various SSE status flags in CPUX86State Reported-by: Richard Purdie Signed-off-by: Richard Henderson --- Differs from Purdie's patch primarily in fixing gdb too. And that required exporting update_sse_sta

[Qemu-devel] [PATCH] qerror: Improve QERR_DEVICE_NOT_ACTIVE message

2014-02-24 Thread Hani Benhabiles
The error message as currently used is confusing as there are no "balloon" or "spice" devices. (qemu) balloon 1024 balloon: Device 'balloon' has not been activated With this patch: (qemu) balloon 1024 balloon: No balloon device has been activated Signed-off-by: Hani Benhabiles Suggested-by: Ma

[Qemu-devel] Question

2014-02-24 Thread Atlas Khan
Plz someone guide me that how I can add new virtual hardware in QEMU? I tried t get help from already made hardware but it gives me no idea...Plz someone guide me and tell me detailed process.

Re: [Qemu-devel] [PATCH 0/9] w32: Reduce dependency on Windows API

2014-02-24 Thread Stefan Weil
Am 23.02.2014 18:02, schrieb Stefan Weil: > Today, most .o files depend on windows.h when QEMU is built with MinGW or > MinGW-w64 (32 and 64 bit builds). These patches reduce the number of such > files from more than 1800 to less than 180. They also allow removing some > hacks which were needed bec

Re: [Qemu-devel] [PATCH v5 RESEND 4/4] qcow2: Add full image preallocation option

2014-02-24 Thread Hu Tao
On Tue, Feb 11, 2014 at 03:07:10PM +0800, Hu Tao wrote: > This adds a preallocation=full mode to qcow2 image creation, which > creates a non-sparse image file. Ping. This is the major part of the patchset that needs review, especially the calculation of metadata size. > > Signed-off-by: Hu Tao

[Qemu-devel] [PATCH 2/2 v3] vfio: blacklist loading of unstable roms

2014-02-24 Thread Bandan Das
Certain cards such as the Broadcom BCM57810 have rom quirks that exhibit unstable system behavior duing device assignment. In the particular case of 57810, rom execution hangs and if a FLR follows, the device becomes inoperable until a power cycle. This change blacklists loading of rom for such car

[Qemu-devel] [PATCH 0/2 v3] vfio: blacklist loading of unstable roms

2014-02-24 Thread Bandan Das
v3: 1. Change the "force" logic to depend on whether the user specified rombar, eliminate dependence on multiple values of rom_bar 2. Avoid printing the informational message if there's no rom 3. Minor changes to commit messages v2: 1. Break up into two patches separating the infrastructural chang

[Qemu-devel] [PATCH 1/2 v3] qdev-monitor: set DeviceState opts before calling realize

2014-02-24 Thread Bandan Das
Setting opts before the realize property is set allows the following patch to make decisions based on whether the user specified "rombar". This also avoids having to create a new tristate property especially for this purpose Signed-off-by: Bandan Das --- qdev-monitor.c | 4 +++- 1 file changed,

Re: [Qemu-devel] Error compiling qemu from source on Ubuntu 12.10

2014-02-24 Thread Jobin Raju George
On Mon, Feb 24, 2014 at 5:54 PM, Peter Maydell wrote: > On 21 February 2014 21:41, Jobin Raju George wrote: > > To fix this issue: > > > > I cloned dtc from its repository and extracted the tarball to qemu/dtc/. > > Why not just do the git submodule command that the error message > from configure

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among

2014-02-24 Thread Gabriel L. Somlo
On Mon, 24 Feb 2014 15:08:17 -0500 Romain Dolbeau wrote: > This patch adds this ability to select a specific variant of > the e1000 virtual ethernet from the command-line. Previously > only a single device was available, selected at compile time. > This helps for guests with limited hardware suppo

Re: [Qemu-devel] [PATCH] virtio-net: Do not filter VLANs without F_CTRL_VLAN

2014-02-24 Thread Amos Kong
On Sun, Feb 23, 2014 at 09:27:33AM +0100, Stefan Fritsch wrote: > On Fri, 21 Feb 2014, Amos Kong wrote: > > > On Wed, Feb 12, 2014 at 10:46:28PM +0100, Stefan Fritsch wrote: > > > If VIRTIO_NET_F_CTRL_VLAN is not negotiated, do not filter out all > > > VLAN-tagged packets but send them to the gues

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Use Additional Temporary in stqcx Case

2014-02-24 Thread Alexander Graf
Tom Musta wrote: > Per Alex Graf's suggestion, the recently added case to gen_conditional_store > for stqcx should use an additional temporary when accessing the second > doubleword. This avoids the mutation of the EA argument to the function, > which is counter intuitive. > > Signed-off-by: Tom M

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Fix Compiler Warnings Due to 64-Bit Constants Declared as UL

2014-02-24 Thread Alexander Graf
Tom Musta wrote: > This patch fixes 64 bit constants that were erroneously declared as "ul" > instead of > "ull". The preferred form "ULL" is used. > > Signed-off-by: Tom Musta > Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour

2014-02-24 Thread Li Guang
Beniamino Galvani wrote: On Mon, Feb 24, 2014 at 02:45:06PM +0800, Li Guang wrote: Beniamino Galvani wrote: On Wed, Feb 19, 2014 at 10:02:36AM +0800, Li Guang wrote: Beniamino Galvani wrote: On Tue, Feb 18, 2014 at 11:49:51AM +0800, Li Guang wrote: Ben

Re: [Qemu-devel] [PATCH 1/1] char/serial: Fix emptyness handling

2014-02-24 Thread Don Slutz
On 02/19/14 13:30, Don Slutz wrote: The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 char/serial: Fix emptyness check Still causes extra NULL byte(s) to be sent. So if the fifo is empty, do not send an extra NULL byte. Signed-off-by: Don Slutz --- hw/char/serial.c | 5 +++-- 1 file chan

Re: [Qemu-devel] [PATCH 1/2] target-arm: make MPIDR a property

2014-02-24 Thread Peter Maydell
On 24 February 2014 23:13, Rob Herring wrote: > On Mon, Feb 24, 2014 at 4:28 PM, Peter Maydell > wrote: >> On 24 February 2014 22:14, Rob Herring wrote: >>> From: Rob Herring >>> MPIDR register is a machine configurable option and current kernels require >>> the value to match with DT cpu reg

Re: [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files

2014-02-24 Thread Stefan Weil
Am 24.02.2014 11:17, schrieb Kevin Wolf: > Am 23.02.2014 um 18:02 hat Stefan Weil geschrieben: >> These header files are used by most QEMU source files. If they >> depend on windows.h, all those source files do so, too. >> >> All Windows specific data types which are replaced use identical >> defin

Re: [Qemu-devel] [PATCH 1/2] target-arm: make MPIDR a property

2014-02-24 Thread Rob Herring
On Mon, Feb 24, 2014 at 4:28 PM, Peter Maydell wrote: > On 24 February 2014 22:14, Rob Herring wrote: >> From: Rob Herring >> MPIDR register is a machine configurable option and current kernels require >> the value to match with DT cpu reg properties. So add a property for MPIDR >> value and all

Re: [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files

2014-02-24 Thread Stefan Weil
Am 24.02.2014 14:51, schrieb Peter Maydell: > On 24 February 2014 13:44, Kevin Wolf wrote: >> Am 24.02.2014 um 14:24 hat Peter Maydell geschrieben: >>> On 24 February 2014 10:17, Kevin Wolf wrote: Not sure if I understand the problem. Why is it bad to depend on windows.h? >>> >>> It dra

Re: [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files

2014-02-24 Thread Stefan Weil
Am 24.02.2014 14:07, schrieb Andreas Färber: > Am 23.02.2014 18:02, schrieb Stefan Weil: >> These header files are used by most QEMU source files. If they >> depend on windows.h, all those source files do so, too. >> [...] > > First of all, why was I not CC'ed on this change? > File is listed unde

Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h

2014-02-24 Thread Stefan Weil
Am 24.02.2014 11:26, schrieb Paolo Bonzini: > Il 23/02/2014 18:02, Stefan Weil ha scritto: >> diff --git a/qga/channel-win32.c b/qga/channel-win32.c >> index 8a303f3..3a0bf13 100644 >> --- a/qga/channel-win32.c >> +++ b/qga/channel-win32.c >> @@ -2,7 +2,7 @@ >> #include >> #include >> #include

Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour

2014-02-24 Thread Beniamino Galvani
On Mon, Feb 24, 2014 at 02:45:06PM +0800, Li Guang wrote: > Beniamino Galvani wrote: > >On Wed, Feb 19, 2014 at 10:02:36AM +0800, Li Guang wrote: > >>Beniamino Galvani wrote: > >>>On Tue, Feb 18, 2014 at 11:49:51AM +0800, Li Guang wrote: > Beniamino Galvani wrote: > >According to this mail

Re: [Qemu-devel] [libvirt-users] Adjust disk image migration (NBD)

2014-02-24 Thread Paolo Bonzini
> Thanks for raising this. > > I noticed that mirror_run() does not throttle the first loop where it > populates the dirty bitmap using bdrv_is_allocated_above(). This is on purpose. Does it causes a noticeable stall in the guest? > The main > copy loop does take the speed limit into account bu

Re: [Qemu-devel] [PATCH 1/2] target-arm: make MPIDR a property

2014-02-24 Thread Peter Maydell
On 24 February 2014 22:14, Rob Herring wrote: > From: Rob Herring > MPIDR register is a machine configurable option and current kernels require > the value to match with DT cpu reg properties. So add a property for MPIDR > value and allow platforms to override. > > ARM_FEATURE_MPIDR is not used h

[Qemu-devel] [PATCH 2/2] arm: highbank: setup custom MPIDR value

2014-02-24 Thread Rob Herring
From: Rob Herring Calxeda highbank platform uses a cluster id of 9 which makes MPIDR register be 0x890n where n is the core number. This causes problems on current kernels expecting the MPIDR to match DT cpu reg property. Midway is "normal" and has a cluster id of 0, so it does not need this

[Qemu-devel] [PATCH 1/2] target-arm: make MPIDR a property

2014-02-24 Thread Rob Herring
From: Rob Herring MPIDR register is a machine configurable option and current kernels require the value to match with DT cpu reg properties. So add a property for MPIDR value and allow platforms to override. ARM_FEATURE_MPIDR is not used here because it is set too late. Signed-off-by: Rob Herri

[Qemu-devel] [PATCH v2 4/5] virtio-ccw: Include standby memory when calculating storage increment

2014-02-24 Thread Matthew Rosato
When determining the memory increment size, use the maxmem size if it was specified. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 42 ++ target-s390x/cpu.h |3 +++ 2 files changed, 37 insertions(+), 8 deletions(-) diff --gi

[Qemu-devel] [PATCH v2 5/5] sclp-s390: Add memory hotplug SCLPs

2014-02-24 Thread Matthew Rosato
Add memory information to read SCP info and add handlers for Read Storage Element Information, Attach Storage Element, Assign Storage and Unassign Storage. Signed-off-by: Matthew Rosato --- hw/s390x/sclp.c| 244 ++-- target-s390x/cpu.h | 15

[Qemu-devel] [PATCH v2 2/5] vl.c: extend -m option to support options for memory hotplug

2014-02-24 Thread Matthew Rosato
From: Igor Mammedov Add following parameters: "slots" - total number of hotplug memory slots "maxmem" - maximum possible memory "slots" and "maxmem" should go in pair and "maxmem" should be greater than "mem" for memory hotplug to be enabled. Signed-off-by: Igor Mammedov --- qemu-options.

[Qemu-devel] [PATCH v2 1/5] vl: convert -m to QemuOpts

2014-02-24 Thread Matthew Rosato
From: Igor Mammedov Adds option to -m "mem" - startup memory amount For compatibility with legacy CLI if suffix-less number is passed, it assumes amount in Mb. Otherwise user is free to use suffixed number using suffixes b,k/K,M,G Signed-off-by: Igor Mammedov --- qemu-options.hx |7

[Qemu-devel] [PATCH v2 3/5] sclp-s390: Add device to manage s390 memory hotplug

2014-02-24 Thread Matthew Rosato
Add sclpMemoryHotplugDev to contain associated data structures, etc. Signed-off-by: Matthew Rosato --- hw/s390x/sclp.c | 32 include/hw/s390x/sclp.h | 19 +++ 2 files changed, 51 insertions(+) diff --git a/hw/s390x/sclp.c b/hw/s390x/s

[Qemu-devel] [PATCH v2 0/5] s390: Support for Hotplug of Standby Memory

2014-02-24 Thread Matthew Rosato
This patchset adds support in s390 for a pool of standby memory, which can be set online/offline by the guest (ie, via chmem). New options, maxmem and slots, are added to the QEMU command line memory parameter to specify the total amount of memory available to the guest as well as the number of me

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-24 Thread Dann Frazier
On Mon, Feb 17, 2014 at 6:40 AM, Alex Bennée wrote: > Hi, Thanks to all involved for your work here! > After a solid few months of work the QEMU master branch [1] has now reached > instruction feature parity with the suse-1.6 [6] tree that a lot of people > have been using to build various aarch

[Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-24 Thread Romain Dolbeau
Hello, This patch adds this ability to select a specific variant of the e1000 virtual ethernet from the command-line. Previously only a single device was available, selected at compile time. This helps for guests with limited hardware support, as with this patch not all guests are required to use

[Qemu-devel] [PATCH 2/4] realview-pbx-a9: Set reset-cbar property for CPUs

2014-02-24 Thread Peter Maydell
If the CPU is a Cortex-A9 then we should set its reset-cbar property so that the guest can read the correct PERIPHBASE/CBAR register value; newer versions of the Linux kernel (as of commit bc41b8724 in 3.12) will otherwise assume the CPU is a buggy single core A9 SoC. The realview-pbx-a9 is the onl

[Qemu-devel] [PATCH 3/4] exynos4210: Set reset-cbar property of Cortex-A9 CPUs

2014-02-24 Thread Peter Maydell
Set the reset-cbar property of the Exynos4210 SoC's Cortex-A9 CPUs, so that Linux doesn't misrecognize them as a broken uniprocessor SoC. Signed-off-by: Peter Maydell --- hw/arm/exynos4210.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/hw/arm/exyno

[Qemu-devel] [PATCH 1/4] vexpress: Set reset-cbar property for CPUs

2014-02-24 Thread Peter Maydell
Newer versions of the Linux kernel (as of commit bc41b8724 in 3.12) now assume that if the CPU is a Cortex-A9 and the reset value of the PERIPHBASE/CBAR register is zero then the CPU is a specific buggy single core A9 SoC, and will not try to start other cores. Since we now have a CPU property for

[Qemu-devel] [PATCH 4/4] virt: Set reset-cbar on CPUs

2014-02-24 Thread Peter Maydell
Set the reset-cbar property on CPUs used by the virt board, if they have it. This isn't necessary for correct functioning under Linux (since the A9 isn't a valid CPU for the virt board), but it is the correct behaviour. Signed-off-by: Peter Maydell --- hw/arm/virt.c | 11 +++ 1 file chan

[Qemu-devel] [PATCH 0/4] ARM: Set reset-cbar property for A9 and A15 boards

2014-02-24 Thread Peter Maydell
These patches set the reset-cbar property for all the A9 and A15 board models which haven't already had that fix. This is necessary for A9 so that Linux doesn't misdetect the CPU as a specific broken A9 uniprocessor SoC; it's not strictly necessary for A15 but it is a more accurate emulation. The

Re: [Qemu-devel] compressed VMDKs and BDRV_BLOCK_OFFSET_VALID

2014-02-24 Thread Peter Lieven
Am 24.02.2014 17:39, schrieb Paolo Bonzini: > Il 24/02/2014 15:37, Fam Zheng ha scritto: >> On Mon, 02/24 14:48, Peter Lieven wrote: >>> Hi, >>> >>> I wonder if the current output of get_block_status for compressed VMDKs is >>> correct or >>> if we need this patch?: >>> >>> diff --git a/block/vmdk

Re: [Qemu-devel] [PATCHv2 00/18] qemu-iotests: adjust tests to work with the NFS protocol

2014-02-24 Thread Peter Lieven
Am 24.02.2014 13:54, schrieb Stefan Hajnoczi: > On Sun, Jan 05, 2014 at 06:21:50PM +0100, Peter Lieven wrote: >> In order to proceed with the integration of the NFS protocol driver into >> qemu I was asked by Stefan to add integration for NFS into the qemu-iotests. >> >> Unfortunately, this became

[Qemu-devel] QEMU accepted for Google Summer of Code 2014

2014-02-24 Thread Stefan Hajnoczi
Great news: the organizations for Google Summer of Code 2014 have been announced and QEMU is participating again this year! If you are a student who is interested in a 12-week full-time project working on QEMU, KVM, or libvirt this summer, head over to our project ideas page: http://qemu-project.o

Re: [Qemu-devel] [snabb-devel] Re: Make virtio-net.c ring size configurable?

2014-02-24 Thread Luke Gorrie
On 24 February 2014 16:20, Stefan Hajnoczi wrote: > On Fri, Feb 14, 2014 at 02:43:14PM +0100, Luke Gorrie wrote: > > In Snabb Switch we are creating a 1:1 mapping between Virtio-net > > descriptors and VMDq hardware receive descriptors. The VMDq queues > support > > 32768 buffers and I'd like to

[Qemu-devel] [PATCH] configure: Make C++ test work with --enable-werror

2014-02-24 Thread Peter Maydell
gcc's C++ compiler complains about being passed some -W options which make sense for C but not for C++. This means we mustn't try a C++ compile with QEMU_CFLAGS, but only with a filtered version that removes the offending options. This filtering was already being done for uses of C++ in the build i

Re: [Qemu-devel] [PATCH] balloon: Fix device name in error message.

2014-02-24 Thread Hani Benhabiles
On Mon, Feb 24, 2014 at 10:04:05AM +0100, Markus Armbruster wrote: > I agree the error message is bad, but I'm afraid your patch makes it > worse :) > > qemu_balloon() returns zero when balloon_event_fn has not been set with > qemu_add_balloon_handler(). > > Right now, the only device that calls

Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers

2014-02-24 Thread Andreas Färber
Am 24.02.2014 17:02, schrieb Peter Maydell: > On 24 February 2014 15:55, Andreas Färber wrote: >> Jan/Peter, is there any other outstanding work on musicpal that I should >> be aware of? If not, I'd like to base the long-planned file splitup on >> Peter's next pull. Hopefully we can still get that

Re: [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES Instructions

2014-02-24 Thread Richard Henderson
On 02/24/2014 10:11 AM, Peter Maydell wrote: > On 24 February 2014 17:59, Richard Henderson wrote: >> I'll also note that arm contains a second copy of the aes_{i,}shifts arrays. >> So after those are moved to common code, we avoid that duplication too. > > AIUI this duplication was because the u

Re: [Qemu-devel] [PATCH] qmp: Check for returned data from __json_read in get_events

2014-02-24 Thread Stefan Hajnoczi
On Mon, Feb 24, 2014 at 01:45:01PM +0800, Fam Zheng wrote: > When QEMU process aborts and socket is closed, qmp client will not > detect it. When this happens, some qemu-iotests scripts will enter an > endless loop waiting for qmp events. > > It's better we raise an exception in qmp.py to catch th

Re: [Qemu-devel] A problem of VM with nbd network disk

2014-02-24 Thread Stefan Hajnoczi
On Sun, Feb 23, 2014 at 01:16:33AM +, Caizhifeng wrote: > I've been tring to use QEMU-1.5.0 and Libvirt-1.1.0 to run a VM with a nbd > network disk, the VM is created by Libvirt as follow(Please attention to the > red words): Thanks for reporting this problem. I am writing tests to reproduc

Re: [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES Instructions

2014-02-24 Thread Peter Maydell
On 24 February 2014 17:59, Richard Henderson wrote: > I'll also note that arm contains a second copy of the aes_{i,}shifts arrays. > So after those are moved to common code, we avoid that duplication too. AIUI this duplication was because the utils/ code wasn't suitable for ARM; Ard's rationale i

Re: [Qemu-devel] [PATCH 24/28] target-ppc: Altivec 2.07: Vector Polynomial Multiply Sum

2014-02-24 Thread Richard Henderson
On 02/12/2014 01:23 PM, Tom Musta wrote: > +#define PMSUM(name, srcfld, trgfld, trgtyp) \ > +void helper_##name(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) \ > +{ \ > +int i, j;

Re: [Qemu-devel] [PATCH] Add a command to QMP to list the supported devices

2014-02-24 Thread Paolo Bonzini
> You are correct. I need "-device ?" functionality for porting libguestfs to > mingw Interesting! Why is "-device ?" not enough? I think that libguestfs should not need anything that qom-list-types does not provide. Paolo

Re: [Qemu-devel] [PATCH] Support NBD client under win32/MinGW

2014-02-24 Thread Paolo Bonzini
> I never used/tested sheepdog under windows with my patch, so I wouldnt know > if it doesnt have any additional bugs under windows. If it compiles, you can include it. Worst of all, people will find bugs. It used to be enabled for Windows when NBD was also enabled (before the introduction of as

Re: [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES Instructions

2014-02-24 Thread Richard Henderson
On 02/12/2014 01:23 PM, Tom Musta wrote: > +static uint8_t SBOX[256] = { I'm not keen on yet another copy of AES data. Please reuse "qemu/aes.h" as much as possible. Please see how we use those in target-i386; from a quick reading, these insns should match up: aesencvcipher aesencla

Re: [Qemu-devel] [PATCH v2 0/2] Two buffer overruns in device assignment

2014-02-24 Thread Alex Williamson
On Mon, 2014-02-24 at 17:40 +, Peter Maydell wrote: > On 24 February 2014 17:39, Alex Williamson wrote: > > On Mon, 2014-02-24 at 14:51 +0100, Markus Armbruster wrote: > >> v2: > >> * Treat readlink() filling buffer as error (Alex) > >> * Use sizeof() rather than PATH_MAX (Peter) > >> * PATCH

Re: [Qemu-devel] [PATCH v2 0/2] Two buffer overruns in device assignment

2014-02-24 Thread Peter Maydell
On 24 February 2014 17:39, Alex Williamson wrote: > On Mon, 2014-02-24 at 14:51 +0100, Markus Armbruster wrote: >> v2: >> * Treat readlink() filling buffer as error (Alex) >> * Use sizeof() rather than PATH_MAX (Peter) >> * PATCH 2/2 unchanged >> >> Markus Armbruster (2): >> vfio: Fix overrun af

Re: [Qemu-devel] [PATCH v2 0/2] Two buffer overruns in device assignment

2014-02-24 Thread Alex Williamson
On Mon, 2014-02-24 at 14:51 +0100, Markus Armbruster wrote: > v2: > * Treat readlink() filling buffer as error (Alex) > * Use sizeof() rather than PATH_MAX (Peter) > * PATCH 2/2 unchanged > > Markus Armbruster (2): > vfio: Fix overrun after readlink() fills buffer completely > pci-assign: Fix

Re: [Qemu-devel] [PATCH 23/28] target-ppc: Altivec 2.07: Vector Gather Bits by Bytes

2014-02-24 Thread Richard Henderson
On 02/12/2014 01:23 PM, Tom Musta wrote: > +uint64_t VGBBD_MASKS[256] = { static const r~

Re: [Qemu-devel] [PATCH 1/2] iothread: stash thread ID away

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 16:53, Stefan Hajnoczi ha scritto: > >+qemu_cond_destroy(&init_info.init_done_cond); > >+qemu_mutex_destroy(&init_info.init_done_lock); > > Destroying the mutex here is racy. You need to keep it until the > iothread is destroyed. I don't think so: qemu_cond_signal() is c

[Qemu-devel] [PATCH v3] xen_disk: add discard support

2014-02-24 Thread Olaf Hering
Implement discard support for xen_disk. It makes use of the existing discard code in qemu. The discard support is enabled unconditionally. The tool stack may provide a property "discard-enable" in the backend node to optionally disable discard support. This is helpful in case the backing file was

Re: [Qemu-devel] [PATCH v5 3/3] KVM: x86: Enable Intel MPX for guest

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 16:37, Liu, Jinsong ha scritto: So patch v5 would be applied except you will remove the incorrect hunk, and you will send a patch strengthenning guest_supported_xcr0? Yes. Paolo

Re: [Qemu-devel] compressed VMDKs and BDRV_BLOCK_OFFSET_VALID

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 15:37, Fam Zheng ha scritto: On Mon, 02/24 14:48, Peter Lieven wrote: Hi, I wonder if the current output of get_block_status for compressed VMDKs is correct or if we need this patch?: diff --git a/block/vmdk.c b/block/vmdk.c index ff6f5ee..5fa29b0 100644 --- a/block/vmdk.c +++ b

Re: [Qemu-devel] [PATCH v2] xen_disk: add discard support

2014-02-24 Thread Olaf Hering
On Sun, Feb 23, Stefano Stabellini wrote: > Given that 4.2 is the first Xen release to have BLKIF_OP_DISCARD, maybe > we could just #define BLKIF_OP_DISCARD 5 in that case? > Do we actually need to #ifndef BLKIF_OP_DISCARD? I will do just the #define and resend with that change. Olaf

Re: [Qemu-devel] [snabb-devel] Re: Make virtio-net.c ring size configurable?

2014-02-24 Thread Luke Gorrie
On 24 February 2014 16:20, Stefan Hajnoczi wrote: > Do you want the 1:1 mapping to achieve best performance or just to > simplify the coding? > We want to keep the real-time constraints on the data plane comfortable. The question I ask myself is: How long can I buffer packets during processing

Re: [Qemu-devel] memory allocation of migration changed?

2014-02-24 Thread Eric Blake
On 02/24/2014 08:00 AM, Stefan Hajnoczi wrote: >> What is the right way to check for enough free memory and memory >> usage of a specific vm? > > I would approach it in terms of guest RAM allocation plus QEMU overhead: > > host_ram >= num_guests * guest_ram_size + num_guests * qemu_overhead >

Re: [Qemu-devel] [PULL respin 00/12] Build system changes for 2014-02-20

2014-02-24 Thread Peter Maydell
On 20 February 2014 12:28, Paolo Bonzini wrote: > Anthony, Peter, > > The following changes since commit 89e4a51ca9546a7bbe1998c4e3d4a3ac3a0c19be: > > Merge remote-tracking branch 'stefanha/tags/tracing-pull-request' into > staging (2014-01-31 11:13:08 +) > > are available in the git reposi

Re: [Qemu-devel] QOM vs QAPI for QMP APIs

2014-02-24 Thread Eric Blake
On 02/24/2014 01:29 AM, Markus Armbruster wrote: >> >> The other burden is documenting what QOM paths to be queried, and >> knowing where to find that documentation. That is, it's another layer >> of complexity, but it's also a more powerful expression. >> >> I'm comparing this situation somewhat

Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers

2014-02-24 Thread Peter Maydell
On 24 February 2014 15:55, Andreas Färber wrote: > Jan/Peter, is there any other outstanding work on musicpal that I should > be aware of? If not, I'd like to base the long-planned file splitup on > Peter's next pull. Hopefully we can still get that done for 2.0. I have a trivial patch on list fo

Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers

2014-02-24 Thread Andreas Färber
Am 24.02.2014 16:45, schrieb Peter Maydell: > On 21 February 2014 07:15, Jan Kiszka wrote: >> On 2014-02-18 16:28, Peter Maydell wrote: >>> The ethernet device in the musicpal only has two tx queues, >>> but we modelled it with four CTDP registers, presumably a >>> cut and paste from the rx queue

Re: [Qemu-devel] [PATCH 2/2] qmp: add query-iothreads command

2014-02-24 Thread Stefan Hajnoczi
On Fri, Feb 21, 2014 at 08:27:22AM -0700, Eric Blake wrote: > On 02/21/2014 07:51 AM, Stefan Hajnoczi wrote: > > The "query-iothreads" command returns a list of information about > > iothreads. See the patch for API documentation. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > > +++ b/qapi-

Re: [Qemu-devel] [PATCH 1/2] iothread: stash thread ID away

2014-02-24 Thread Stefan Hajnoczi
On Fri, Feb 21, 2014 at 04:18:30PM +0100, Paolo Bonzini wrote: > Il 21/02/2014 15:51, Stefan Hajnoczi ha scritto: > >Keep the thread ID around so we can report it via QMP. > > > >There's only one problem: qemu_get_thread_id() (gettid() wrapper on > >Linux) must be called from the thread itself. Th

Re: [Qemu-devel] [PATCH] qemu-iotests: add more tests to the "quick" group

2014-02-24 Thread Stefan Hajnoczi
On Thu, Feb 20, 2014 at 06:28:03PM +0100, Paolo Bonzini wrote: > None of these needs QEMU_PROG, and they all take but a few seconds. > We need to point the launching script to qemu-nbd, though. > > Signed-off-by: Paolo Bonzini > --- > tests/qemu-iotests-quick.sh | 1 + > tests/qemu-iotests/grou

Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers

2014-02-24 Thread Peter Maydell
On 21 February 2014 07:15, Jan Kiszka wrote: > On 2014-02-18 16:28, Peter Maydell wrote: >> The ethernet device in the musicpal only has two tx queues, >> but we modelled it with four CTDP registers, presumably a >> cut and paste from the rx queue registers. Since the tx_queue[] >> array is only 2

Re: [Qemu-devel] [PATCH] hw/intc/exynos4210_combiner: Don't overrun output_irq array in init

2014-02-24 Thread Peter Maydell
On 18 February 2014 01:17, Andreas Färber wrote: > Am 17.02.2014 18:53, schrieb Peter Maydell: >> The Exynos4210 combiner has IIC_NIRQ inputs and IIC_NGRP outputs; >> use the correct constant in the loop initializing our output >> sysbus IRQs so that we don't overrun the output_irq[] array. >> >>

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-24 Thread Peter Maydell
On 17 February 2014 14:37, Peter Maydell wrote: > Three random easy patches fixing issues reported by Coverity Scan. > > Peter Maydell (3): > hw/misc/arm_sysctl: Fix bad boundary check on mb clock accesses > hw/net/stellaris_enet: Avoid unintended sign extension > hw/timer/arm_timer: Avoid a

Re: [Qemu-devel] [PATCH] Add a command to QMP to list the supported devices

2014-02-24 Thread Eric Blake
On 02/24/2014 02:23 AM, Or Goshen wrote: > From: Or Goshen > > Was done on behalf of Intel Corp. > > --- > +++ b/qapi-schema.json > @@ -526,6 +526,32 @@ > { 'command': 'query-commands', 'returns': ['CommandInfo'] } > > ## > +# @DeviceInfo: > +# > +# Information about a device > +# > +# @nam

Re: [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing

2014-02-24 Thread Stefan Hajnoczi
On Thu, Feb 20, 2014 at 03:37:12PM +, alex.ben...@linaro.org wrote: > From: Alex Bennée > > Hi, > > I've now enabled Travis testing on the "official" QEMU GitHub mirror. > > Of the following patches two expand the testing, one is a cosmetic > whitespace fix and the final one enabled IRC not

Re: [Qemu-devel] [PATCH] configure: check that C++ compiler actually works

2014-02-24 Thread Peter Maydell
On 20 February 2014 15:10, Peter Maydell wrote: > Check that the C++ compiler works with the C compiler; if it > does not, then don't pass CXX to the build process. This > fixes a regression where QEMU was no longer building if the > build environment didn't have a C++ compiler (introduced > in co

Re: [Qemu-devel] [PATCH v5 3/3] KVM: x86: Enable Intel MPX for guest

2014-02-24 Thread Liu, Jinsong
Paolo Bonzini wrote: > Il 24/02/2014 11:58, Liu, Jinsong ha scritto: >> @@ -599,6 +599,9 @@ int __kvm_set_xcr(struct kvm_vcpu *vcpu, u32 >> index, u64 xcr) u64 old_xcr0 = vcpu->arch.xcr0; >> u64 valid_bits; >> >> +if (!kvm_x86_ops->mpx_supported || !kvm_x86_ops->mpx_supported()) >> +

Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: Fix GIC_SET_LEVEL

2014-02-24 Thread Peter Maydell
On 23 February 2014 16:32, Christoffer Dall wrote: > On 21 February 2014 17:03, Christoffer Dall > wrote: >> The GIC_SET_LEVEL macro unfortunately overwrote the entire level >> bitmask instead of just or'ing on the necessary bits, causing active >> level PPIs on a core to clear PPIs on other cor

Re: [Qemu-devel] device_del id missing after blockdev-add

2014-02-24 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 04:36:42PM +0100, William Dauchy wrote: > I'm starting qemu with the following config in order to test drive > hotremove and hotadd: > > [drive "disk1"] > if = "none" > id = "disk1" > cache = "none" > aio = "native" > format = "raw" > file = "/dev/sda" > > [dev

Re: [Qemu-devel] Make virtio-net.c ring size configurable?

2014-02-24 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 02:43:14PM +0100, Luke Gorrie wrote: > Observation: virtio-net.c hard-codes the vring size to 256 buffers. > > Could this reasonably be made configurable, or would that be likely to > cause a problem? > > In Snabb Switch we are creating a 1:1 mapping between Virtio-net > d

Re: [Qemu-devel] [libvirt-users] Adjust disk image migration (NBD)

2014-02-24 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 11:58:56AM +0100, Michal Privoznik wrote: > On 14.02.2014 10:40, Joaquim Barrera wrote: > > Hi all, > > > > As I am doing some tests with qemu, I realized that the way it does > > 'migrate -i tcp:DEST:444' is not the same as 'libvirt migrate > > --copy-storage-inc'. Basic

Re: [Qemu-devel] memory allocation of migration changed?

2014-02-24 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 07:16:17PM +0100, Stefan Priebe wrote: > > Am 14.02.2014 16:03, schrieb Stefan Hajnoczi: > >On Tue, Feb 11, 2014 at 07:30:54PM +0100, Stefan Priebe wrote: > >>Am 11.02.2014 16:44, schrieb Stefan Hajnoczi: > >>>On Tue, Feb 11, 2014 at 3:54 PM, Stefan Priebe - Profihost AG >

[Qemu-devel] [Bug 1284090] [NEW] RFE: QMP: report error reason in BLOCK_IO_ERROR message

2014-02-24 Thread Francesco Romani
Public bug reported: when a disk drive is configured with the error policy enospc for write errors, the monitoring client needs a way to distinguish betwwen generic I/O error and the I/O error for space exausted. The JSON QMP protocol lacks this information: the BLOCK_IO_ERROR message does not p

[Qemu-devel] Neat 'patches' trick: mark obsolete or committed patch series as read

2014-02-24 Thread Stefan Hajnoczi
I use Anthony's 'patches' tool for tracking patch series on the mailing list (http://github.com/aliguori/patches). Patches knows which email threads have been obsoleted by newer patch revisions and which have been committed to qemu.git. If you use notmuch to index your email, the following comman

Re: [Qemu-devel] compressed VMDKs and BDRV_BLOCK_OFFSET_VALID

2014-02-24 Thread Fam Zheng
On Mon, 02/24 14:48, Peter Lieven wrote: > Hi, > > I wonder if the current output of get_block_status for compressed VMDKs is > correct or > if we need this patch?: > > diff --git a/block/vmdk.c b/block/vmdk.c > index ff6f5ee..5fa29b0 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -1146,7

Re: [Qemu-devel] e1000 memory corruption in guest OS

2014-02-24 Thread Hoyer, David
Yes - we found this late last week and it did fix our issue. Thanks! -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Monday, February 24, 2014 8:02 AM To: Hoyer, David; Qemu-devel@nongnu.org Cc: Moyer, Keith; Best, Tish Subject: Re

[Qemu-devel] [PATCH] target-ppc: Use Additional Temporary in stqcx Case

2014-02-24 Thread Tom Musta
Per Alex Graf's suggestion, the recently added case to gen_conditional_store for stqcx should use an additional temporary when accessing the second doubleword. This avoids the mutation of the EA argument to the function, which is counter intuitive. Signed-off-by: Tom Musta --- target-ppc/transl

[Qemu-devel] [PATCH] target-ppc: Fix Compiler Warnings Due to 64-Bit Constants Declared as UL

2014-02-24 Thread Tom Musta
This patch fixes 64 bit constants that were erroneously declared as "ul" instead of "ull". The preferred form "ULL" is used. Signed-off-by: Tom Musta --- target-ppc/fpu_helper.c | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/2] vfio: Fix overrun after readlink() fills buffer completely

2014-02-24 Thread Markus Armbruster
Alex Williamson writes: > On Fri, 2014-02-21 at 17:42 +0100, Markus Armbruster wrote: >> readlink() returns the number of bytes written to the buffer, and it >> doesn't write a terminating null byte. vfio_init() writes it itself. >> Overruns the buffer when readlink() filled it completely. >> >

Re: [Qemu-devel] e1000 memory corruption in guest OS

2014-02-24 Thread Paolo Bonzini
Il 16/02/2014 05:29, Hoyer, David ha scritto: > We are using Qemu-1.7.0 with Xen-4.3.0 and Debian jessie. We are > noticing that when we transfer large files from our network to the > guestOS via the e1000 virtual network device that we experience memory > corruption on the guestOS. We have deb

  1   2   3   >