Re: [Qemu-devel] [PATCH v20 13/26] qed.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Chunyan Liu
2014-02-18 2:01 GMT+08:00 Eric Blake : > On 02/11/2014 11:33 PM, Chunyan Liu wrote: > > qed.c: replace QEMUOptionParameter with QemuOpts > > > > Signed-off-by: Dong Xu Wang > > Signed-off-by: Chunyan Liu > > --- > > block/qed.c | 89 > +-

Re: [Qemu-devel] [PATCH v20 07/26] cow.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Chunyan Liu
2014-02-13 8:19 GMT+08:00 Eric Blake : > On 02/11/2014 11:33 PM, Chunyan Liu wrote: > > cow.c: replace QEMUOptionParameter with QemuOpts > > > > Signed-off-by: Dong Xu Wang > > Signed-off-by: Chunyan Liu > > --- > > block/cow.c | 46 ++ > > 1 files

Re: [Qemu-devel] [PATCH v20 01/26] add def_value_str to QemuOptDesc

2014-02-17 Thread Chunyan Liu
2014-02-13 7:00 GMT+08:00 Eric Blake : > On 02/11/2014 11:33 PM, Chunyan Liu wrote: > > Add def_value_str (default value) to QemuOptDesc, to replace function of > the > > default value in QEMUOptionParameter. And improved related functions. > > > > Signed-off-by: Dong Xu Wang > > Signed-off-by: C

Re: [Qemu-devel] [PATCH v20 06/26] change block layer to support both QemuOpts and QEMUOptionParameter

2014-02-17 Thread Chunyan Liu
2014-02-13 8:12 GMT+08:00 Eric Blake : > On 02/11/2014 11:33 PM, Chunyan Liu wrote: > > Change block layer to support both QemuOpts and QEMUOptionParameter. > > After this patch, it will change backend drivers one by one. At the end, > > QEMUOptionParameter will be removed and only QemuOpts is kep

Re: [Qemu-devel] [PATCH v20 04/26] add some QemuOpts functions for replace work

2014-02-17 Thread Chunyan Liu
2014-02-13 7:31 GMT+08:00 Eric Blake : > On 02/11/2014 11:33 PM, Chunyan Liu wrote: > > Add some qemu_opt functions to replace the same functionality of > > QEMUOptionParameter handling. > > > > Signed-off-by: Dong Xu Wang > > Signed-off-by: Chunyan Liu > > --- > > include/qemu/option.h |9

Re: [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages

2014-02-17 Thread Fam Zheng
On Mon, 02/17 14:43, Paolo Bonzini wrote: > Most of the block drivers are not using the Error** argument to bdrv_open, > and instead just printing errors to stderr. This series improves that, > and as a consequence it also avoids abuse of errno numbers. > > The only hurdle (caught by qemu-iotests

Re: [Qemu-devel] [PATCH v2 19/20] block: do not abuse EMEDIUMTYPE

2014-02-17 Thread Fam Zheng
On Tue, 02/11 18:03, Paolo Bonzini wrote: > Returning "Wrong medium type" for an image that does not have a valid > header is a bit weird. Improve the error by mentioning what format > was trying to open it. > > Signed-off-by: Paolo Bonzini > --- > block/bochs.c | 3 ++- > block/cow.c

Re: [Qemu-devel] [PATCH v20 03/26] improve some functions in qemu-option.c

2014-02-17 Thread Chunyan Liu
2014-02-13 7:22 GMT+08:00 Eric Blake : > On 02/11/2014 11:33 PM, Chunyan Liu wrote: > > Improve opt_get and opt_set group of functions. For opt_get, check and > handle > > NUlL input; for opt_set, when set to an existing option, rewrite the > option > > s/NUlL/NULL/ > > > with new value. > > > > S

[Qemu-devel] [PATCH v9 11/14] dump: add API to write dump pages

2014-02-17 Thread qiaonuohan
functions are used to write page to vmcore. vmcore is written page by page. page desc is used to store the information of a page, including a page's size, offset, compression format, etc. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dump.c| 231 +

[Qemu-devel] [PATCH v9 10/14] dump: add APIs to operate DataCache

2014-02-17 Thread qiaonuohan
DataCache is used to store data temporarily, then the data will be written to vmcore. These functions will be called later when writing data of page to vmcore. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dump.c| 47 +++

[Qemu-devel] [PATCH v9 06/14] dump: add support for lzo/snappy

2014-02-17 Thread qiaonuohan
kdump-compressed format supports three compression format, zlib/lzo/snappy. Currently, only zlib is available. This patch is used to support lzo/snappy. '--enable-lzo/--enable-snappy' is needed to be specified with configure to make lzo/snappy available for qemu Signed-off-by: Qiao Nuohan Reviewe

[Qemu-devel] [PATCH v9 12/14] dump: make kdump-compressed format available for 'dump-guest-memory'

2014-02-17 Thread qiaonuohan
Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'elf': ELF format, without compression 2. 'kdump-zlib': kdump-compressed forma

Re: [Qemu-devel] [PATCH v8 00/13] Make 'dump-guest-memory' dump in kdump-compressed format

2014-02-17 Thread Qiao Nuohan
On 02/18/2014 01:51 AM, Luiz Capitulino wrote: On Tue, 11 Feb 2014 12:00:56 -0500 Luiz Capitulino wrote: On Tue, 28 Jan 2014 14:21:53 +0800 qiaonuohan wrote: Hi, all The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg00209.html Command 'dump-guest-memory'

[Qemu-devel] [PATCH v9 01/14] dump: const-qualify the buf of WriteCoreDumpFunction

2014-02-17 Thread qiaonuohan
WriteCoreDumpFunction is a function pointer that points to the function used to write content in "buf" into core file, so "buf" should be const-qualify. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dump.c|2 +- include/qom/cpu.h |3 ++- 2 files changed, 3 inserti

[Qemu-devel] [PATCH v9 04/14] dump: add API to write vmcore

2014-02-17 Thread qiaonuohan
Function is used to write vmcore in flatten format. In flatten format, data is written block by block, and in front of each block, a struct MakedumpfileDataHeader is stored there to indicate the offset and size of the data block. struct MakedumpfileDataHeader { int64_t offset; int64_t buf_

[Qemu-devel] [PATCH v9 07/14] dump: add members to DumpState and init some of them

2014-02-17 Thread qiaonuohan
add some members to DumpState that will be used in writing vmcore in kdump-compressed format. some of them, like page_size, will be initialized in the patch. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dump.c| 28 include/sysemu/dump.h

[Qemu-devel] [PATCH v9 03/14] dump: add API to write header of flatten format

2014-02-17 Thread qiaonuohan
flatten format will be used when writing kdump-compressed format. The format is also used by makedumpfile, you can refer to the following URL to get more detailed information about flatten format of kdump-compressed format: http://sourceforge.net/projects/makedumpfile/ The two functions here are u

[Qemu-devel] [PATCH v9 09/14] dump: add API to write dump_bitmap

2014-02-17 Thread qiaonuohan
functions are used to write 1st and 2nd dump_bitmap of kdump-compressed format, which is used to indicate whether the corresponded page is existed in vmcore. 1st and 2nd dump_bitmap are same, because dump level is specified to 1 here. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dum

[Qemu-devel] [PATCH v9 05/14] dump: add API to write elf notes to buffer

2014-02-17 Thread qiaonuohan
the function can be used by write_elf32_notes/write_elf64_notes to write notes to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes will write elf notes to vmcore directly. Instead, if buf_write_note is used, elf notes will be written to opaque->note_buf at first. Signed-of

[Qemu-devel] [PATCH v9 08/14] dump: add API to write dump header

2014-02-17 Thread qiaonuohan
the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only elf notes here Signed-off-by: Qiao Nuohan Re

[Qemu-devel] [PATCH v9 14/14] dump: add 'query-dump-guest-memory-capability' command

2014-02-17 Thread qiaonuohan
'query-dump-guest-memory-capability' is used to query the available formats for 'dump-guest-memory'. The output of the command will be like: -> { "execute": "query-dump-guest-memory-capability" } <- { "return": { "formats": ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"] }

[Qemu-devel] [PATCH v9 13/14] Define the architecture for compressed dump format

2014-02-17 Thread qiaonuohan
Signed-off-by: Ekaterina Tumanova Reviewed-by: Laszlo Ersek Reviewed-by: Qiao Nuohan --- dump.c |7 +-- target-i386/cpu.h |2 ++ target-s390x/cpu.h |1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index fb0c896..2c81318 100644 ---

[Qemu-devel] [PATCH v9 02/14] dump: add argument to write_elfxx_notes

2014-02-17 Thread qiaonuohan
write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to vmcore. Adding parameter "WriteCoreDumpFunction f" makes it available to choose the method of writing elf notes Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dump.c | 16 1 files changed,

[Qemu-devel] [PATCH v9 00/14] Make 'dump-guest-memory' dump in kdump-compressed format

2014-02-17 Thread qiaonuohan
Hi, all The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg03669.html Command 'dump-guest-memory' was introduced to dump guest's memory. But the vmcore's format is only elf32 or elf64. The message is here: http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg0

Re: [Qemu-devel] [PATCH v20 17/26] rbd.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Chunyan Liu
2014-02-18 2:57 GMT+08:00 Eric Blake : > On 02/11/2014 11:33 PM, Chunyan Liu wrote: > > rbd.c: replace QEMUOptionParameter with QemuOpts > > > > Signed-off-by: Dong Xu Wang > > Signed-off-by: Chunyan Liu > > --- > > block/rbd.c | 63 > +-

[Qemu-devel] [RFC PATCH v1 3/3] provenance: expose the serialization save/load functions for migration

2014-02-17 Thread mrhines
From: "Michael R. Hines" Expose the prototypes of the serialization code and register the save/load functions during QEMU startup so that they can take effect. Signed-off-by: Michael R. Hines --- include/migration/migration.h | 8 vl.c | 2 ++ 2 files changed,

[Qemu-devel] [RFC PATCH v1 1/3] provenance: QMP command to store MigrationInfo from JSON

2014-02-17 Thread mrhines
From: "Michael R. Hines" This is the QMP documentation and schema for a command that allows the migration protocol on the destination side to 'install' a whole MigrationInfo json structure as received in-tact from the source into the MigrationState struct so that query-migrate can print the infor

[Qemu-devel] [RFC PATCH v1 2/3] provenance: serialize MigrationInfo across the wire

2014-02-17 Thread mrhines
From: "Michael R. Hines" At the end of the migration, we use the existing QMP json manipulation functions and the query-migrate QMP function to serialize the MigrationInfo structure that was populated in the 'COMPLETED' state of the migration. This code does not need to know anything about the a

[Qemu-devel] [RFC PATCH v1 0/3] provenance: save migration stats after completion to destination

2014-02-17 Thread mrhines
From: "Michael R. Hines" This series allows us to send the contents of the entire MigrationInfo structure to the destination once the migration is over. This is very useful for analyzing the result of a migration, and particularly useful for management software and policy. Normally, the informat

Re: [Qemu-devel] question about patch "send the gratuitous by guest"

2014-02-17 Thread Jason Wang
On 02/18/2014 12:25 PM, Weidong Huang wrote: > On 2014/2/18 10:48, Jason Wang wrote: > >> > On 02/15/2014 11:01 AM, Weidong Huang wrote: >>> >> it >>> >> configure vlan or alias on the virtio net. >>> >> >>> >> But bridge or bond do not send arp. what's your opinion? >> > >> > Do you mean bridge o

Re: [Qemu-devel] question about patch "send the gratuitous by guest"

2014-02-17 Thread Weidong Huang
On 2014/2/18 10:48, Jason Wang wrote: > On 02/15/2014 11:01 AM, Weidong Huang wrote: >> it >> configure vlan or alias on the virtio net. >> >> But bridge or bond do not send arp. what's your opinion? > > Do you mean bridge or bond in guest? yes. >> >> BTW,this feature need modify the driver of

Re: [Qemu-devel] [PATCH 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

2014-02-17 Thread Li Guang
did you detect spurious? didn't by my limited test, code will disable any expired timer, unless be re-armed, so it will never generate interrupt any more. Thanks! Beniamino Galvani wrote: The model was generating interrupts for all enabled timers after the expiration of one of them. Avoid this

Re: [Qemu-devel] [PATCH V17 11/12] quorum: Add quorum_open() and quorum_close().

2014-02-17 Thread Fam Zheng
On Thu, 02/13 10:09, Benoît Canet wrote: > The Wednesday 12 Feb 2014 à 23:06:38 (+0100), Benoît Canet wrote : > > +static void quorum_close(BlockDriverState *bs) > > +{ > > +BDRVQuorumState *s = bs->opaque; > > +int i; > > + > > +for (i = 0; i < s->num_children; i++) { > > +bdrv

Re: [Qemu-devel] [PATCH 4/7] allwinner-a10-pit: use level triggered interrupts

2014-02-17 Thread Li Guang
Beniamino Galvani wrote: Converts the interrupt generation logic to the use of level triggered interrupts. any real difference, or block something? Signed-off-by: Beniamino Galvani --- hw/timer/allwinner-a10-pit.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour

2014-02-17 Thread Li Guang
pending registers are also clear registers by a10 datasheet, also you found bits are marked as 'R', so, ..., contradict itself. Beniamino Galvani wrote: According to this mail thread [1], writing to pending register seems to have no effect on actual pending status of interrupts. This means that

Re: [Qemu-devel] [PATCH 1/7] allwinner-a10-pic: set vector address when an interrupt is pending

2014-02-17 Thread Li Guang
Hi, Beniamino Galvani wrote: This patch implements proper updating of the vector register which should hold, according to the A10 user manual, the vector address for the interrupt currently active on the CPU IRQ input. Interrupt priority is not implemented at the moment and thus the first pendi

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-17 Thread Fam Zheng
On Mon, 02/17 15:59, Markus Armbruster wrote: > Fam Zheng writes: > > On Sat, 02/15 11:01, Markus Armbruster wrote: > > Does this mean that error_is_set() is always used by programmer to check a > > non-NULL error pointer? Is there any case to call error_is_set(errp) without > > knowing if errp is

Re: [Qemu-devel] [PATCH] trace-events: Fix typo in "offset"

2014-02-17 Thread Fam Zheng
On Mon, 02/17 10:03, Kevin Wolf wrote: > s/offet/offset/ > > Signed-off-by: Kevin Wolf > --- > trace-events | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/trace-events b/trace-events > index ab11f97..3713063 100644 > --- a/trace-events > +++ b/trace-events > @@

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-17 Thread Fam Zheng
On Mon, 02/17 14:20, Paolo Bonzini wrote: > Il 17/02/2014 14:15, Fam Zheng ha scritto: > >Does this mean that error_is_set() is always used by programmer to check a > >non-NULL error pointer? Is there any case to call error_is_set(errp) without > >knowing if errp is NULL or not? If no, should we en

Re: [Qemu-devel] question about patch "send the gratuitous by guest"

2014-02-17 Thread Jason Wang
On 02/15/2014 11:01 AM, Weidong Huang wrote: > it > configure vlan or alias on the virtio net. > > But bridge or bond do not send arp. what's your opinion? Do you mean bridge or bond in guest? > > BTW,this feature need modify the driver of virtio net. > > Only the newest linux kernel support it. S

[Qemu-devel] [PATCH v6 resend] rdma: rename 'x-rdma' => 'rdma'

2014-02-17 Thread mrhines
From: "Michael R. Hines" Changes since v5: 1. Rebased against master 2. Added review tags As far as we can tell, all known bugs have been fixed: 1. Parallel migrations are working 2. IPv6 migration is working 3. virt-test is working Preliminary versions of libvirt support are in review, I've

[Qemu-devel] hotplug: VM got stuck when attaching a pass-through device to the non-pass-through VM for the first time

2014-02-17 Thread Zhanghaoyu (A)
Hi, all The VM will get stuck for a while(about 6s for a VM with 20GB memory) when attaching a pass-through PCI card to the non-pass-through VM for the first time. The reason is that the host will build the whole VT-d GPA->HPA DMAR page-table, which needs a lot of time, and during this time, t

[Qemu-devel] [PATCH] rdma: bug fixes

2014-02-17 Thread mrhines
From: "Michael R. Hines" 1. Fix small memory leak in parsing inet address from command line in data_init() 2. Fix ibv_post_send() return value check and pass error code back up correctly. 3. Fix rdma_destroy_qp() segfault after failure to connect to destination. Reported-by: frank.yang...@gmail

Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress

2014-02-17 Thread Michael R. Hines
On 02/16/2014 10:33 AM, Michael Roth wrote: Quoting Frank (2013-09-12 08:51:56) It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init(). From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001 From: Frank Yang Date: Thu, 12 Sep 2013 21:37:56

[Qemu-devel] [PULL 01/15] TCG: Fix 32-bit host allocation typo

2014-02-17 Thread Richard Henderson
The second half register of a 64-bit temp on a 32-bit host was allocated with the wrong base_type. The base_type of the second half register is never checked, but for consistency it should be the same as the first half. Signed-off-by: Richard Henderson --- tcg/tcg.c | 2 +- 1 file changed, 1 in

Re: [Qemu-devel] [RFC 2/3] target-i386: add -smp X,apics=0x option

2014-02-17 Thread Chen Fan
On Mon, 2014-02-17 at 11:37 -0700, Eric Blake wrote: > On 01/14/2014 02:27 AM, Chen Fan wrote: > > This option provides the infrastructure for specifying apicids when > > boot VM, For example: > > > > #boot with apicid 0 and 2: > > -smp 2,apics=0xA,maxcpus=4 /* 1010 */ > > #boot with apicid 1

Re: [Qemu-devel] qemu_rdma_cleanup seg - related to 5a91337?

2014-02-17 Thread Michael R. Hines
On 02/17/2014 05:06 PM, Dr. David Alan Gilbert wrote: * Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: On 02/06/2014 08:26 PM, Dr. David Alan Gilbert wrote: Hi Isaku, I hit a seg in qemu_rdma_cleanup in the code changed by your '[PATCH] rdma: clean up of qemu_rdma_cleanup()' migratio

[Qemu-devel] [PATCH v7] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2014-02-17 Thread Christoffer Dall
Save and restore the ARM KVM VGIC state from the kernel. We rely on QEMU to marshal the GICState data structure and therefore simply synchronize the kernel state with the QEMU emulated state in both directions. We take some care on the restore path to check the VGIC has been configured with enoug

[Qemu-devel] [PATCH v6 4/4] arm: vgic device control api support

2014-02-17 Thread Christoffer Dall
Support creating the ARM vgic device through the device control API and setting the base address for the distributor and cpu interfaces in KVM VMs using this API. Because the older KVM_CREATE_IRQCHIP interface needs the irq chip to be created prior to creating the VCPUs, we first test if we can us

[Qemu-devel] [PATCH v6 2/4] kvm: Introduce kvm_arch_irqchip_create

2014-02-17 Thread Christoffer Dall
Introduce kvm_arch_irqchip_create an arch-specific hook in preparation for architecture-specific use of the device control API to create IRQ chips. Following patches will implement the ARM irqchip create method to prefer the device control API over the older KVM_CREATE_IRQCHIP API. Reviewed-by: P

[Qemu-devel] [PATCH v6 0/4] Create ARM KVM VGIC with device control API

2014-02-17 Thread Christoffer Dall
This patch series adds generic support for issuing device control related ioctls and supports creating the ARM KVM-accelerated VGIC using the device control API while maintaining backwards compatibility for older kernels. Changelogs in the individual patches. This last series is identical to v5,

[Qemu-devel] [PATCH v6 1/4] linux-headers: Update from v3.14-rc3

2014-02-17 Thread Christoffer Dall
Update to tag v3.14-rc3 (6d0abeca3242a88cab8232e4acd7e2bf088f3bc2) Signed-off-by: Christoffer Dall --- linux-headers/asm-arm/kvm.h | 28 linux-headers/asm-arm64/kvm.h | 30 +- linux-headers/asm-powerpc/kvm.h | 3 +++ linux-headers/a

[Qemu-devel] [PATCH v6 3/4] kvm: Common device control API functions

2014-02-17 Thread Christoffer Dall
Introduces two simple functions: int kvm_device_ioctl(int fd, int type, ...); int kvm_create_device(KVMState *s, uint64_t type, bool test); These functions wrap the basic ioctl-based interactions with KVM in a way similar to other KVM ioctl wrappers. Reviewed-by: Peter Maydell Signed-off

[Qemu-devel] [PULL 14/15] tcg/i386: Use ANDN instruction

2014-02-17 Thread Richard Henderson
Note that the optimizer cannot simplify ANDC X,Y,C to AND X,Y,~C so we must handle constants in the implementation of andc. Reviewed-by: Paolo Bonzini Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 52 --- tcg/i386/tcg-target.h | 6

[Qemu-devel] [PULL 15/15] tcg/i386: Use SHLX/SHRX/SARX instructions

2014-02-17 Thread Richard Henderson
These three-operand shift instructions do not require the shift count to be placed into ECX. This reduces the number of mov insns required, with the mere addition of a new register constraint. Don't attempt to get rid of the matching constraint, as that's impossible to manipulate with just a new

[Qemu-devel] [PULL 07/15] tcg/optimize: Handle known-zeros masks for ANDC

2014-02-17 Thread Richard Henderson
Reviewed-by: Paolo Bonzini Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/optimize.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 1b9fea5..4bea8a5 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -727,6 +727,17 @

[Qemu-devel] [PULL 13/15] tcg/i386: Add tcg_out_vex_modrm

2014-02-17 Thread Richard Henderson
Prepare for emitting BMI insns which require VEX encoding. Reviewed-by: Paolo Bonzini Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 41 ++--- 1 file changed, 38 insertions(+), 3 deletions(-) diff --git a/tcg/i386/t

[Qemu-devel] [PULL 05/15] tcg/optimize: improve known-zero bits for 32-bit ops

2014-02-17 Thread Richard Henderson
From: Aurelien Jarno The shl_i32 op might set some bits of the unused 32 high bits of the mask. Fix that by clearing the unused 32 high bits for all 32-bit ops except load/store which operate on tl values. Reviewed-by: Paolo Bonzini Signed-off-by: Aurelien Jarno Signed-off-by: Richard Henderso

[Qemu-devel] [PULL 11/15] disas/i386: Disassemble ANDN/SHLX/SHRX/SHAX

2014-02-17 Thread Richard Henderson
Reviewed-by: Paolo Bonzini Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- disas/i386.c | 146 +-- 1 file changed, 132 insertions(+), 14 deletions(-) diff --git a/disas/i386.c b/disas/i386.c index 044e02c..00ceca9 100644

[Qemu-devel] [PULL 10/15] tcg/optimize: Add more identity simplifications

2014-02-17 Thread Richard Henderson
Recognize 0 operand to andc, and -1 operands to and, orc, eqv. Reviewed-by: Paolo Bonzini Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/optimize.c | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/tcg/optimize.c

Re: [Qemu-devel] [PATCH] hw/intc/exynos4210_combiner: Don't overrun output_irq array in init

2014-02-17 Thread Andreas Färber
Am 17.02.2014 18:53, schrieb Peter Maydell: > The Exynos4210 combiner has IIC_NIRQ inputs and IIC_NGRP outputs; > use the correct constant in the loop initializing our output > sysbus IRQs so that we don't overrun the output_irq[] array. > > Signed-off-by: Peter Maydell > --- > hw/intc/exynos421

[Qemu-devel] [PULL 03/15] tcg/optimize: fix known-zero bits for right shift ops

2014-02-17 Thread Richard Henderson
From: Aurelien Jarno 32-bit versions of sar and shr ops should not propagate known-zero bits from the unused 32 high bits. For sar it could even lead to wrong code being generated. Cc: qemu-sta...@nongnu.org Reviewed-by: Paolo Bonzini Signed-off-by: Aurelien Jarno Signed-off-by: Richard Hender

[Qemu-devel] [PULL 12/15] tcg/i386: Move TCG_CT_CONST_* to tcg-target.c

2014-02-17 Thread Richard Henderson
These are not needed by users of tcg-target.h. No need to recompile when we adjust them. Reviewed-by: Paolo Bonzini Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 4 tcg/i386/tcg-target.h | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-)

[Qemu-devel] [PULL 04/15] tcg/optimize: fix known-zero bits optimization

2014-02-17 Thread Richard Henderson
From: Aurelien Jarno Known-zero bits optimization is a great idea that helps to generate more optimized code. However the current implementation only works in very few cases as the computed mask is not saved. Fix this to make it really working. Reviewed-by: Paolo Bonzini Signed-off-by: Aurelie

[Qemu-devel] [PULL 09/15] tcg/optimize: Optmize ANDC X, Y, Y to MOV X, 0

2014-02-17 Thread Richard Henderson
Like we already do for SUB and XOR. Reviewed-by: Paolo Bonzini Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/optimize.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 0b1dd13..c1b9284 100644 --- a/tcg/optimize.c +++ b/tcg/optimi

[Qemu-devel] [PULL 06/15] tcg/optimize: add known-zero bits compute for load ops

2014-02-17 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Paolo Bonzini Signed-off-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/optimize.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 1cf017a..1b9fea5 100644 --- a/

[Qemu-devel] [PULL 00/15] tcg updates

2014-02-17 Thread Richard Henderson
Contains two patch sets, recently reviewed. Plus two other unrelated patches that probably weren't going to get in via any other tree. r~ The following changes since commit 0dbcf95a1ea5a5ca6222765ff8813c2cc17e8abd: libvixl: fix 64bit constants usage (2014-02-15 20:26:30 +) are availabl

[Qemu-devel] [PULL 08/15] tcg/optimize: Simply some logical ops to NOT

2014-02-17 Thread Richard Henderson
Given, of course, an appropriate constant. These could be generated from the "canonical" operation for inversion on the guest, or via other optimizations. Reviewed-by: Paolo Bonzini Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/optimize.c | 57 ++

[Qemu-devel] [PULL 02/15] tcg-arm: The shift count of op_rotl_i32 is in args[2] not args[1].

2014-02-17 Thread Richard Henderson
From: Huw Davies It's this that should be subtracted from 0x20 when converting to a right rotate. Cc: qemu-sta...@nongnu.org Signed-off-by: Huw Davies Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/arm/tcg-targ

Re: [Qemu-devel] Cortex-M3: reading NVIC registers causes segfaults

2014-02-17 Thread Andreas Färber
Am 17.02.2014 16:18, schrieb Peter Maydell: > On 17 February 2014 14:52, Andreas Galauner wrote: >> I'm currently trying to emulate an ARM Cortex-M3 and I need to debug the >> system using GDB and IDA Pro. The platform is an STM32 and I'm using a >> port from github [1] based on qemu 1.5.1 for tha

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-17 Thread Andreas Färber
Am 17.02.2014 19:59, schrieb Paolo Bonzini: > Il 17/02/2014 15:37, Peter Maydell ha scritto: >> Three random easy patches fixing issues reported by Coverity Scan. >> >> Peter Maydell (3): >> hw/misc/arm_sysctl: Fix bad boundary check on mb clock accesses >> hw/net/stellaris_enet: Avoid unintend

Re: [Qemu-devel] RFC: ioapic polarity vs. qemu os-x guest

2014-02-17 Thread Gabriel L. Somlo
On Mon, Feb 17, 2014 at 02:38:09PM -0500, Gabriel L. Somlo wrote: > Oh, I think I'm starting to comprehend the problem here. The bits of > "*irq_state" are indexed by "irq_source_id", which is dynamically > assigned by kvm_request_irq_source_id(). > > So, doing the OR thing when assuming always-ac

Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs

2014-02-17 Thread Brad Smith
On 17/02/14 11:20 AM, Peter Maydell wrote: On 16 February 2014 22:00, Brad Smith wrote: On 26/01/14 1:06 PM, Paolo Bonzini wrote: Il 26/01/2014 02:37, Brad Smith ha scritto: Reviewed-by: Stefan Hajnoczi Is there some sort of process I am missing to have build fixes commited so that Q

[Qemu-devel] [PULL v2 24/49] tests: Add eepro100 qtest

2014-02-17 Thread Andreas Färber
Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile| 3 +++ tests/eepro100-test.c | 63 +++ 2 files changed, 66 insertions(+) create mode 100644 tests/eepro100-test.c diff --git a/tests/Makefile b/tests/Makefile

[Qemu-devel] [PULL v2 26/49] tests: Add virtio-net qtest

2014-02-17 Thread Andreas Färber
Cc: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 7 +++ tests/virtio-net-test.c | 33 + 2 files changed, 40 insertions(+) create mode 100644 tests/virtio-net-test.c diff --git a/tests/Makefile

[Qemu-devel] [PULL v2 25/49] tests: Add ne2000 qtest

2014-02-17 Thread Andreas Färber
Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/ne2000-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/ne2000-test.c diff --git a/tests/Makefile b/tests/Makefile index 3617e63..8ece028

[Qemu-devel] [PULL v2 27/49] tests: Add tpci200 qtest

2014-02-17 Thread Andreas Färber
Acked-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/tpci200-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/tpci200-test.c diff --git a/tests/Makefile b/tests/Mak

[Qemu-devel] [PULL v2 20/49] tests: Add e1000 qtest

2014-02-17 Thread Andreas Färber
Cc: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 7 +++ tests/e1000-test.c | 33 + 2 files changed, 40 insertions(+) create mode 100644 tests/e1000-test.c diff --git a/tests/Makefile b/tests/Makefil

[Qemu-devel] [PULL v2 13/49] wm8750: QOM'ify

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() and direct parent field accesses with QOM cast macro. Rename parent field. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/audio/wm8750.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git

[Qemu-devel] [PULL v2 07/49] tests: Run qom-test for every architecture

2014-02-17 Thread Andreas Färber
From: Peter Maydell Rather than requiring every new architecture to remember to add a line to the Makefile to say that qom-test will work on it, autogenerate the list of supported architectures by looking at the files in default-configs (as configure does), and add qom-test to the test list for a

[Qemu-devel] [PULL v2 01/49] qtest: don't report signals if qtest driver enabled

2014-02-17 Thread Andreas Färber
From: "Michael S. Tsirkin" qtest driver always uses signals to kill qemu no need to report it, whatever the accelerator state. Add API to detect qtest driver, and suppress reporting signals in this case. Reported-by: Andreas Färber Signed-off-by: Michael S. Tsirkin Signed-off-by: Andreas Färb

[Qemu-devel] [PULL v2 11/49] tosa: QOM'ify DAC

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Use type constant in tosa_tg_init(). Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/arm/tosa.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/arm/tosa.c b/

Re: [Qemu-devel] [PATCH v20 20/26] vdi.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > vdi.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/vdi.c | 71 -- > 1 files changed, 34 insertions(+), 37 deletions(-)

[Qemu-devel] [PULL v2 10/49] pxa2xx: QOM'ify I2C slave

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() and direct parent field accesses with QOM cast macro. Rename parent field to assure we caught all. Reuse type constant in pxa2xx_i2c_init(). Add some missing braces while at it. Signed-off-by: Andreas Färber --- hw/arm/pxa2xx.c | 38 +--

[Qemu-devel] [PULL v2 12/49] z2: QOM'ify AER915

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename the parent field. Reuse the type constant in z2_init(). Reviewed-by: Peter Crosthwaite [AF: Use TYPE_AER915 in z2_init() too] Signed-off-by: Andreas Färber --- hw/arm/z2.c | 20 +--- 1 file changed, 13 insertions(+),

[Qemu-devel] [PULL v2 08/49] nand: Don't use qdev_create() in nand_init()

2014-02-17 Thread Andreas Färber
Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit from Sysbus) changed the parent type of TYPE_NAND but continued to use qdev_create(), which handled a NULL BusState as SysBus. Use object_new() instead, and reuse the TYPE_NAND define while at it. Reported-by: Markus Armbruster

[Qemu-devel] [PULL v2 02/49] ppcemb-softmmu: Drop Mac and e500 emulation

2014-02-17 Thread Andreas Färber
They are still available in ppc-softmmu and ppc64-softmmu. Signed-off-by: Andreas Färber --- default-configs/ppc-softmmu.mak| 1 + default-configs/ppc64-softmmu.mak | 1 + default-configs/ppcemb-softmmu.mak | 20 hw/ppc/Makefile.objs | 4 ++-- 4 files c

[Qemu-devel] [PULL v2 00/49] QOM devices patch queue 2014-02-17

2014-02-17 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. v2 is rebased to fix a merge conflict, fixes some gcov warnings and adds 2 Acked-bys and 2 qtest patches. Regards, Andreas Cc: Peter Maydell Cc: Anthony Liguori Cc: Markus Armbruster Cc: Alexander Graf Cc: Stefan Hajnoczi Cc:

[Qemu-devel] [PULL v2 05/49] qom-test: Run for all available machines

2014-02-17 Thread Andreas Färber
From: Markus Armbruster Get available machines via QMP instead of hardcoding a list that's perpetually out of date. Xen machines can work only when running under the Xen hypervisor. Blacklist them. Signed-off-by: Markus Armbruster Signed-off-by: Andreas Färber --- tests/qom-test.c | 274

[Qemu-devel] [PULL v2 04/49] tests: Fix gcov paths for relocated device sources

2014-02-17 Thread Andreas Färber
Commit 49ab747f668f421138d5b40d83fa279c4c5e278d moved fdc.c, hd-geometry.c, m48t59.c, tmp105.c into hw/ subdirectories; commit 0ddfaf7fe4c8453446730328bf348b7c6438e4f8 did for mc146818rtc.c. Cc: Paolo Bonzini Signed-off-by: Andreas Färber --- tests/Makefile | 12 ++-- 1 file changed, 6

[Qemu-devel] [PULL v2 09/49] i2c: Rename i2c_bus to I2CBus

2014-02-17 Thread Andreas Färber
Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/acpi/piix4.c | 6 +++--- hw/arm/exynos4210.c | 2 +- hw/arm/musicpal.c | 4 ++-- hw/arm/nseries.c| 2 +- hw/arm/pxa2xx.c | 6 +++--- hw/arm/realview.c | 4 ++-

[Qemu-devel] [PULL v2 44/49] qdev: Remove hex8/32/64 property types

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Replace them with uint8/32/64. Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/audio/adlib.c | 2 +- hw/audio/cs4231a.c | 2 +- hw/audio/gus.c | 2 +- hw/audio/pcs

[Qemu-devel] [PULL v2 15/49] max7310: QOM'ify

2014-02-17 Thread Andreas Färber
Replace FROM_I2C_SLAVE() usages with QOM cast macro. Rename parent field. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/gpio/max7310.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c index 5

[Qemu-devel] [PULL v2 47/49] qdev: Use QAPI type names for properties

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Use "drive", "chr", etc. only for legacy_name (which shows up in -device foo,? output). Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev-properties-system.c | 12 hw/core/qdev-prop

[Qemu-devel] [PULL v2 22/49] tests: Add rtl8139 qtest

2014-02-17 Thread Andreas Färber
Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/rtl8139-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/rtl8139-test.c diff --git a/tests/Makefile b/tests/Makefile index 8c06abb..d7993

[Qemu-devel] [PULL v2 28/49] tests: Add ipoctal232 qtest

2014-02-17 Thread Andreas Färber
Acked-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 7 +++ tests/ipoctal232-test.c | 33 + 2 files changed, 40 insertions(+) create mode 100644 tests/ipoctal232-test.c diff --git a/tests/Makefil

[Qemu-devel] [PULL v2 41/49] qapi: Add human mode to StringOutputVisitor

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini This will be used by "info qtree". For numbers it prints both the decimal and hex values. For sizes it rounds to the nearest power of 2^10. For strings, it puts quotes around the string and separates NULL and empty string. Reviewed-by: Igor Mammedov Reviewed-by: Eric Blak

[Qemu-devel] [PULL v2 14/49] ssd0303: QOM'ify

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/display/ssd0303.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/display/ssd0303.c b/hw/display/ssd0303.c

Re: [Qemu-devel] [PATCH v20 19/26] ssh.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > ssh.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/ssh.c | 31 +++ > 1 files changed, 15 insertions(+), 16 deletions(-) > > .bdrv_getlength

Re: [Qemu-devel] [PATCH v8 00/13] Make 'dump-guest-memory' dump in kdump-compressed format

2014-02-17 Thread Luiz Capitulino
On Tue, 11 Feb 2014 12:00:56 -0500 Luiz Capitulino wrote: > On Tue, 28 Jan 2014 14:21:53 +0800 > qiaonuohan wrote: > > > Hi, all > > > > The last version is here: > > http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg00209.html > > > > Command 'dump-guest-memory' was introduced to du

  1   2   3   4   >