[Qemu-devel] [PATCH v3 1/8] block: Change BDS parameter of bdrv_open() to **

2014-02-14 Thread Max Reitz
Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is not NULL, that existing BDS will be reused (in the same way as bdrv_open() already did). Signed-off-

[Qemu-devel] [PATCH v3 8/8] block: Remove bdrv_open_image()'s force_raw option

2014-02-14 Thread Max Reitz
This option is now unnecessary since specifying BDRV_O_PROTOCOL as flag will do exactly the same. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Reviewed-by: Kevin Wolf --- block.c | 27 --- block/blkdebug.c | 2 +- block/blkverify.c | 4 ++-

[Qemu-devel] [PATCH v3 7/8] block: Reuse success path from bdrv_open()

2014-02-14 Thread Max Reitz
The fail and success paths of bdrv_file_open() may be further shortened by reusing code already existent in bdrv_open(). This includes bdrv_file_open() not taking the reference to options which allows the removal of QDECREF(options) in that function. Signed-off-by: Max Reitz --- block.c | 63 +++

[Qemu-devel] [PATCH v3 6/8] block: Handle bs->options in bdrv_open() only

2014-02-14 Thread Max Reitz
The fail paths of bdrv_file_open() and bdrv_open() naturally exhibit similarities, thus it is possible to reuse the one from bdrv_open() and shorten the one in bdrv_file_open() accordingly. Also, setting bs->options in bdrv_file_open() is not necessary if it is already done in bdrv_open(). Signed

[Qemu-devel] [PATCH v3 4/8] block: Reuse reference handling from bdrv_open()

2014-02-14 Thread Max Reitz
Remove the reference parameter and the related handling code from bdrv_file_open(), since it exists in bdrv_open() now as well. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Reviewed-by: Kevin Wolf --- block.c | 33 +++-- 1 file changed, 7 insertions(+), 26 del

[Qemu-devel] [PATCH v3 3/8] block: Make bdrv_file_open() static

2014-02-14 Thread Max Reitz
Add the bdrv_open() option BDRV_O_PROTOCOL which results in passing the call to bdrv_file_open(). Additionally, make bdrv_file_open() static and therefore bdrv_open() the only way to call it. Consequently, all existing calls to bdrv_file_open() have to be adjusted to use bdrv_open() with the BDRV_

[Qemu-devel] [PATCH v3 5/8] block: Remove bdrv_new() from bdrv_file_open()

2014-02-14 Thread Max Reitz
Change bdrv_file_open() to take a simple pointer to an already existing BDS instead of an indirect one. The BDS will be created in bdrv_open() if necessary. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Reviewed-by: Kevin Wolf --- block.c | 24 +--- 1 file changed, 13

[Qemu-devel] [PATCH v3 2/8] block: Add reference parameter to bdrv_open()

2014-02-14 Thread Max Reitz
Allow bdrv_open() to handle references to existing block devices just as bdrv_file_open() is already capable of. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Reviewed-by: Kevin Wolf --- block.c | 45 ++--- block/qcow2.c | 4 +

[Qemu-devel] [PATCH v3 0/8] block: Integrate bdrv_file_open() into bdrv_open()

2014-02-14 Thread Max Reitz
bdrv_file_open() is now nearly a subset of bdrv_open(), except for the fact that bdrv_file_open() is for protocols and bdrv_open() for block drivers. It is possible to use bdrv_file_open() with a block driver, but in that case that block driver must be explicitly specified. Due to these great simi

Re: [Qemu-devel] [PATCH V17 00/12] quorum block filter

2014-02-14 Thread Max Reitz
On 15.02.2014 02:15, Max Reitz wrote: On 12.02.2014 23:06, Benoît Canet wrote: I post this for review in prevision of 2.0 feature freeze. Even if the series look correct please wait before merging because: The QMP events in the "Add quorum mechanism" definitively needs to be reviewed by Eric

Re: [Qemu-devel] [PATCH V17 11/12] quorum: Add quorum_open() and quorum_close().

2014-02-14 Thread Max Reitz
On 12.02.2014 23:06, Benoît Canet wrote: From: Benoît Canet Example of command line: -drive if=virtio,file.driver=quorum,\ file.children.0.file.filename=1.raw,\ file.children.0.node-name=1.raw,\ file.children.0.driver=raw,\ file.children.1.file.filename=2.raw,\ file.children.1.node-name=2.raw,\

Re: [Qemu-devel] [PATCH V17 09/12] quorum: Add quorum_co_flush().

2014-02-14 Thread Max Reitz
On 12.02.2014 23:06, Benoît Canet wrote: From: Benoît Canet Makes a vote to select error if any. Signed-off-by: Benoit Canet --- block/quorum.c | 28 1 file changed, 28 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH V17 06/12] quorum: Add quorum mechanism.

2014-02-14 Thread Max Reitz
On 12.02.2014 23:06, Benoît Canet wrote: From: Benoît Canet This patchset enable the core of the quorum mechanism. "enables" The num_children reads are compared to get the majority version and if this version exist more than threshold time the guest won't see the error at all. "exists", "

Re: [Qemu-devel] [PATCH V17 05/12] quorum: Add quorum_aio_readv.

2014-02-14 Thread Max Reitz
On 12.02.2014 23:06, Benoît Canet wrote: From: Benoît Canet Add code to do num_children reads in parallel and cleanup the structures afterward. "afterwards" Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 39 ++- 1 file change

Re: [Qemu-devel] [PATCH V17 04/12] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2014-02-14 Thread Max Reitz
On 12.02.2014 23:06, Benoît Canet wrote: From: Benoît Canet qemu_iovec_compare() will be used to compare IOs vectors in quorum blkverify mode. The patch extract these functions in order to factorize the code. "extracts" (just a sidenode: If I'm correcting (or thinking I'm correcting) spellin

Re: [Qemu-devel] [PATCH V17 03/12] quorum: Add quorum_aio_writev and its dependencies.

2014-02-14 Thread Max Reitz
On 12.02.2014 23:06, Benoît Canet wrote: From: Benoît Canet Writes are mirrored num_children times on num_children devices. Signed-off-by: Benoit Canet --- block/quorum.c | 103 + 1 file changed, 103 insertions(+) Reviewed-by: Max R

Re: [Qemu-devel] [PATCH V17 02/12] quorum: Create BDRVQuorumState and BlkDriver and do init.

2014-02-14 Thread Max Reitz
On 12.02.2014 23:06, Benoît Canet wrote: From: Benoît Canet Create the structure holding the quorum settings and write the minimal block driver instanciation boilerplate. Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 31 +++ 1 file cha

Re: [Qemu-devel] [PATCH V17 01/12] quorum: Create quorum.c, add QuorumChildRequest and QuorumAIOCB.

2014-02-14 Thread Max Reitz
On 12.02.2014 23:06, Benoît Canet wrote: From: Benoît Canet Quorum is a block filter mirroring writes to num_children children. For reads quorum reads each children and does a vote. If more than vote_threshold versions are identicals the quorum is reached and -pedantic: "identical", without "

Re: [Qemu-devel] [PATCH V17 00/12] quorum block filter

2014-02-14 Thread Max Reitz
On 12.02.2014 23:06, Benoît Canet wrote: I post this for review in prevision of 2.0 feature freeze. Even if the series look correct please wait before merging because: The QMP events in the "Add quorum mechanism" definitively needs to be reviewed by Eric as they where changed. I did not found a

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-14 Thread Peter Maydell
CCing the virtio maintainers. thanks -- PMM On 13 February 2014 21:13, Mario Smarduch wrote: > virtio: set virtio-net/virtio-mmio host features > > Patch sets 'virtio-net/virtio-mmio' host features to enable network > features based on peer capabilities. Currently host features turn > of all fea

Re: [Qemu-devel] [PATCH v2 09/35] target-arm: A64: Implement MSR (immediate) instructions

2014-02-14 Thread Peter Crosthwaite
On Sat, Feb 15, 2014 at 2:41 AM, Peter Maydell wrote: > On 5 February 2014 06:23, Peter Crosthwaite > wrote: >> On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell >> wrote: >>> +switch (op) { >>> +case 0x05: /* SPSel */ >>> +env->pstate = deposit32(env->pstate, 0, 1, imm); >> >> "0",

Re: [Qemu-devel] [Qemu-ppc] PowerPC Decimal Floating Point

2014-02-14 Thread Tom Musta
On 2/14/2014 3:22 PM, Richard Henderson wrote: > On 02/11/2014 11:38 PM, Alexander Graf wrote: My proposal is to incorporate the libdecnumber component of libdfp (http://www.eglibc.org/cgi-bin/viewvc.cgi/libdfp/trunk/) in a manner analogous to how softfloat is used for binary f

Re: [Qemu-devel] RFC: ioapic polarity vs. qemu os-x guest

2014-02-14 Thread Alexander Graf
On 14.02.2014, at 23:06, Gabriel L. Somlo wrote: > On Fri, Feb 14, 2014 at 10:21:09PM +0100, Alexander Graf wrote: >> >> Can't you just turn the polarity around in the pci host adapter? > > I tried this: > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 1221f32..0e86d21 100644 > --- a/hw/p

Re: [Qemu-devel] RFC: ioapic polarity vs. qemu os-x guest

2014-02-14 Thread Gabriel L. Somlo
On Fri, Feb 14, 2014 at 10:21:09PM +0100, Alexander Graf wrote: > > Can't you just turn the polarity around in the pci host adapter? I tried this: diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 1221f32..0e86d21 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -118,13 +118,13 @@ static int pci_bar

Re: [Qemu-devel] [PATCH 0/5] tcg/i386 support for bmi

2014-02-14 Thread Richard Henderson
Ping. On 01/31/2014 06:43 AM, Richard Henderson wrote: > There are three separate architecture extensions for logical operations, > BMI, BMI2, and TBM. The first two are supported on Intel Haswell and > AMD Excavator, while slightly earlier AMD support only BMI and TBM. > > The following adds su

Re: [Qemu-devel] [PATCH 0/8] tcg optimization improvements

2014-02-14 Thread Richard Henderson
Ping. On 01/31/2014 06:46 AM, Richard Henderson wrote: > The first 4 of these are ones that Aurelien posted some time ago, > and I reviewed, but never seemed to get committed. > > The second 4 address optimization issues that I noticed with the > BMI instruction set extension, adding ANDC support

Re: [Qemu-devel] [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-14 Thread Cedric Bosdonnat
On Fri, 2014-02-14 at 09:16 +0100, Jan Kiszka wrote: > > I need to submit our organization application (including our project > > ideas) on Friday. > > Hope it's not too late: just added the VT-d emulation proposal. It's not too late. Ideas page must be ready when students will discover the list

Re: [Qemu-devel] [Qemu-ppc] PowerPC Decimal Floating Point

2014-02-14 Thread Richard Henderson
On 02/11/2014 11:38 PM, Alexander Graf wrote: >> > My proposal is to incorporate the libdecnumber component of libdfp >> > (http://www.eglibc.org/cgi-bin/viewvc.cgi/libdfp/trunk/) in a manner >> > analogous to how >> > softfloat is used for binary floating point. So, for example, the helper >> >

Re: [Qemu-devel] RFC: ioapic polarity vs. qemu os-x guest

2014-02-14 Thread Alexander Graf
> Am 14.02.2014 um 22:13 schrieb "Gabriel L. Somlo" : > >> On Tue, Feb 11, 2014 at 09:54:44PM +0200, Michael S. Tsirkin wrote: >>> On Tue, Feb 11, 2014 at 01:23:31PM -0500, Gabriel L. Somlo wrote: >>> 1. Regarding KVM and the polarity xor line in the patch above: Does >>> anyone have experience

Re: [Qemu-devel] RFC: ioapic polarity vs. qemu os-x guest

2014-02-14 Thread Gabriel L. Somlo
On Tue, Feb 11, 2014 at 09:54:44PM +0200, Michael S. Tsirkin wrote: > On Tue, Feb 11, 2014 at 01:23:31PM -0500, Gabriel L. Somlo wrote: > > 1. Regarding KVM and the polarity xor line in the patch above: Does > > anyone have experience with any *other* guests which insist on setting > > level-trigge

Re: [Qemu-devel] [PATCH v2 02/20] nbd: correctly propagate errors

2014-02-14 Thread Jeff Cody
On Tue, Feb 11, 2014 at 06:03:35PM +0100, Paolo Bonzini wrote: > Before: > $ ./qemu-io-old > qemu-io-old> open -r -o file.driver=nbd > one of path and host must be specified. > qemu-io-old: can't open device (null): Could not open image: Invalid > argument > $ ./qemu-io-old >

Re: [Qemu-devel] [PATCH v2 01/20] nbd: produce a better error if neither host nor port is passed

2014-02-14 Thread Jeff Cody
On Fri, Feb 14, 2014 at 11:54:34AM -0500, Jeff Cody wrote: > On Tue, Feb 11, 2014 at 06:03:34PM +0100, Paolo Bonzini wrote: > > Before: > > $ qemu-io-old > > qemu-io-old> open -r -o file.driver=nbd > > qemu-io-old: can't open device (null): Could not open image: Invalid > > argument >

Re: [Qemu-devel] [PULL 33/48] ipack: Move IndustryPack out of hw/char/

2014-02-14 Thread Paolo Bonzini
Il 14/02/2014 21:13, Andreas Färber ha scritto: hw/Makefile.objs | 1 + hw/char/Makefile.objs | 2 +- hw/char/ipoctal232.c | 2 +- hw/ipack/Makefile.objs| 2 ++ hw/{char => ipack}/ipack.c| 2 +- hw/{char => ipack}/

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-14 Thread Paolo Bonzini
Il 14/02/2014 19:19, Kevin Wolf ha scritto: Eventually this function will return void; having both a -errno return and the errp argument is just an intermediate step (as probably in all other cases). So I still think this is going in the wrong direction and will make the conversion harder than ne

Re: [Qemu-devel] [PULL 33/48] ipack: Move IndustryPack out of hw/char/

2014-02-14 Thread Andreas Färber
Am 10.02.2014 19:36, schrieb Andreas Färber: > Move the header defining an IPackBus and IPackDevice base class into > a new include/ directory and move their implementation and a > PCI-IndustryPack bridge out of hw/char/ directory into a new hw/ipack/. > > Acked-by: Alberto Garcia > Signed-off-by

Re: [Qemu-devel] [PULL 28/48] tests: Add ipoctal232 qtest

2014-02-14 Thread Andreas Färber
Am 10.02.2014 19:36, schrieb Andreas Färber: > Cc: Alberto Garcia > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Andreas Färber > --- > tests/Makefile | 7 +++ > tests/ipoctal232-test.c | 33 + > 2 files changed, 40 insertions(+) > create mode 100

Re: [Qemu-devel] [PULL 26/48] tests: Add virtio-net qtest

2014-02-14 Thread Andreas Färber
Am 10.02.2014 19:36, schrieb Andreas Färber: > Cc: Michael S. Tsirkin > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Andreas Färber > --- > tests/Makefile | 7 +++ > tests/virtio-net-test.c | 33 + > 2 files changed, 40 insertions(+) > create mode

Re: [Qemu-devel] [PULL 25/48] tests: Add ne2000 qtest

2014-02-14 Thread Andreas Färber
Am 10.02.2014 19:36, schrieb Andreas Färber: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Andreas Färber > --- > tests/Makefile | 1 + > tests/ne2000-test.c | 33 + > 2 files changed, 34 insertions(+) > create mode 100644 tests/ne2000-test.c > > diff --

Re: [Qemu-devel] Make virtio-net.c ring size configurable?

2014-02-14 Thread Mario Smarduch
On 02/14/2014 05:43 AM, Luke Gorrie wrote: > Howdy! > > Observation: virtio-net.c hard-codes the vring size to 256 buffers. > > Could this reasonably be made configurable, or would that be likely to > cause a problem? > > In Snabb Switch we are creating a 1:1 mapping between Virtio-net > descrip

[Qemu-devel] [PATCH] qemu-options.hx: improve -numa doc

2014-02-14 Thread Luiz Capitulino
The -numa option documentation in qemu's manpage lacks the command-line options and some information regarding how it relates to options -m and -smp. This commit fills in the missing text. Signed-off-by: Luiz Capitulino --- qemu-options.hx | 9 ++--- 1 file changed, 6 insertions(+), 3 deleti

[Qemu-devel] [PATCH 2/2] QEMU: PPC: set default cpu type to be 'host'

2014-02-14 Thread Stuart Yoder
From: Stuart Yoder -for KVM we always want the cpu to be that of the host system, so make that the default -for TGC mode, the emulated cpu type should be explicitly set Signed-off-by: Stuart Yoder --- hw/ppc/e500.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PATCH 1/2] QEMU: PPC: specify PVRs for all e500 cores

2014-02-14 Thread Stuart Yoder
From: Stuart Yoder Signed-off-by: Stuart Yoder --- target-ppc/cpu-models.c | 64 +-- target-ppc/cpu-models.h | 30 -- 2 files changed, 90 insertions(+), 4 deletions(-) diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-mode

Re: [Qemu-devel] [PATCH v2] RFC: Add blockdev-del QMP command

2014-02-14 Thread Ian Main
On Thu, Feb 13, 2014 at 09:59:40AM +0100, Kevin Wolf wrote: > Am 12.02.2014 um 18:36 hat Ian Main geschrieben: > > This is the sister command to blockdev-add. In Fam's example he uses > > the drive_del HMP command to clean up but it would be much nicer to > > have a way to do this via QMP. > > >

[Qemu-devel] [Bug 1262081] Re: qemu-system-sparc in qemu 1.7.0 fails to boot with Sun ROM

2014-02-14 Thread Mark Cave-Ayland
Hi Peter, Just to add that the updated OpenBIOS images attached above are now in QEMU git master. I've CC'd qemu-stable so they should get merged into the next 1.7.x release too. ATB, Mark. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

[Qemu-devel] [Bug 1278977] Re: qemu-system-sparc64 crash when initializing disk

2014-02-14 Thread Mark Cave-Ayland
Hi Waldemar, The bug you are seeing is related to the Linux cmd646 driver which happens to cause an illegal access in the kernel under qemu-system- sparc64. It is most likely due to the lack of IOMMU emulation, however I haven't had a chance to dig into it in much detail yet. The good news is tha

[Qemu-devel] Thank You to our contributors

2014-02-14 Thread Andreas Färber
Hello, I'd like to use #ilovefs day [1] to say a big Thank You to all QEMU contributors. Especially all that don't work on QEMU as their main job but still take the time to send in occasional bug fixes or to implement cool new features. QEMU has grown from a hobby project of a small group of peop

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-14 Thread Kevin Wolf
Am 14.02.2014 um 18:02 hat Paolo Bonzini geschrieben: > Il 14/02/2014 17:45, Kevin Wolf ha scritto: > >>> -ret = bdrv_file_open(&cow_bs, filename, NULL, NULL, BDRV_O_RDWR, > >>> - &local_err); > >>> +ret = bdrv_file_open(&cow_bs, filename, NULL, NULL, BDRV_O_RDWR, >

Re: [Qemu-devel] memory allocation of migration changed?

2014-02-14 Thread Stefan Priebe
Am 14.02.2014 16:03, schrieb Stefan Hajnoczi: On Tue, Feb 11, 2014 at 07:30:54PM +0100, Stefan Priebe wrote: Am 11.02.2014 16:44, schrieb Stefan Hajnoczi: On Tue, Feb 11, 2014 at 3:54 PM, Stefan Priebe - Profihost AG wrote: in the past (Qemu 1.5) a migration failed if there was not enogh mem

Re: [Qemu-devel] memory allocation of migration changed?

2014-02-14 Thread Stefan Priebe
Am 14.02.2014 15:59, schrieb Stefan Hajnoczi: On Tue, Feb 11, 2014 at 07:32:46PM +0100, Stefan Priebe wrote: Am 11.02.2014 17:22, schrieb Peter Lieven: Am 11.02.2014 um 16:44 schrieb Stefan Hajnoczi : On Tue, Feb 11, 2014 at 3:54 PM, Stefan Priebe - Profihost AG wrote: in the past (Qemu 1

Re: [Qemu-devel] [PATCH v2] qcow2: Set zero flag for discarded clusters

2014-02-14 Thread Kevin Wolf
Am 14.02.2014 um 18:05 hat Stefan Hajnoczi geschrieben: > On Sat, Feb 08, 2014 at 05:50:02PM +0100, Kevin Wolf wrote: > > Instead of making the backing file contents visible again after a discard > > request, set the zero flag if possible (i.e. on version >= 3). > > > > Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 10/11] block: Relax bdrv_lookup_bs constraints.

2014-02-14 Thread Stefan Hajnoczi
From: Benoît Canet The following patch will reuse bdrv_lookup_bs in order to open images by references so the rules of usage of bdrv_lookup_bs must be relaxed a bit. Signed-off-by: Benoit Canet Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi --- block.c | 26 +++---

[Qemu-devel] [PULL 08/11] block: mirror - use local_err to avoid NULL errp

2014-02-14 Thread Stefan Hajnoczi
From: Jeff Cody When starting a block job, commit_active_start() relies on whether *errp is set by mirror_start_job. This allows it to determine if the mirror job start failed, so that it can clean up any changes to open flags from the bdrv_reopen(). If errp is NULL, then it will not be able to

[Qemu-devel] [PULL 11/11] block: Open by reference will try device then node_name.

2014-02-14 Thread Stefan Hajnoczi
From: Benoît Canet Since we introduced node_name for named bs of the graph modify the opening by reference to use it as a fallback. This patch also enforce the separation of the device id and graph node namespaces. Signed-off-by: Benoit Canet Reviewed-by: Max Reitz Signed-off-by: Stefan Hajno

[Qemu-devel] [PULL 09/11] blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close.

2014-02-14 Thread Stefan Hajnoczi
From: Benoît Canet As bdrv_open() documentation states: "The reference to the QDict belongs to the block layer * after the call (even on failure), so if the caller intends to reuse the * dictionary, it needs to use QINCREF() before calling bdrv_open." the optional options dict will not be reus

[Qemu-devel] [PULL 04/11] block: Don't throw away errno via error_setg

2014-02-14 Thread Stefan Hajnoczi
From: Jeff Cody There are a handful of places in the block layer where a failure path has a valid -errno value, yet error_setg() is used. Those instances should instead use error_setg_errno(), to preserve as much error information as possible. This patch replaces those instances with error_setg

[Qemu-devel] [PULL 06/11] block: qemu-iotests - add vhdx log replay tests for qemu-img

2014-02-14 Thread Stefan Hajnoczi
From: Jeff Cody VHDX logs can now be replayed via 'qemu-img check -r all'. Add tests to verify that the log replay is successful when using qemu-img. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/070 | 10 ++ tests/qemu-iotests/070.out | 11 ++

[Qemu-devel] [PULL 03/11] block: Add notes to iSCSI's .bdrv_open and .bdrv_reopen_prepare

2014-02-14 Thread Stefan Hajnoczi
From: Jeff Cody iSCSI currently does not need to do any actions to support the current usage of bdrv_reopen(). However, it is important to note a couple of things: 1.) A connection will not be re-established to an iSCSI target, and 2.) If iscsi_open() is changed to parse 'flags', then iscsi_reop

[Qemu-devel] [PULL 07/11] qemu-iotests: Don't run 005 on vmdk split formats

2014-02-14 Thread Stefan Hajnoczi
From: Fam Zheng There would be too many extents that VMDK driver can't open all of them: 005 0s ... - output mismatch (see 005.out.bad) --- 005.out 2013-12-24 09:27:27.608181030 +0800 +++ 005.out.bad 2014-02-13 10:00:15.282184557 +0800 @@ -4,10 +4,10 @@ Formatting 'TEST_

[Qemu-devel] [PULL 05/11] block: qemu-iotests - fix test 070 (vhdx)

2014-02-14 Thread Stefan Hajnoczi
From: Jeff Cody VHDX test 070 failed, due to different output from qemu-io / qemu when opening an image read-only that contains a log file. Filter the output, and update the expected results to match the correct output. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- tests/qemu-i

[Qemu-devel] [PULL 00/11] Block patches

2014-02-14 Thread Stefan Hajnoczi
The following changes since commit 0888a29caac6e1b668e498a0ad4d1fea15de012b: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2014-02-13 15:02:04 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to

[Qemu-devel] [PULL 02/11] blockdev: Remove 'type' parameter from blockdev_init()

2014-02-14 Thread Stefan Hajnoczi
From: Kevin Wolf blockdev-add doesn't know about the device that the backend will be attached to, this is a legacy -drive concept. Move the remaining checks that use it to drive_init(). [Fam Zheng suggested line-wrapping to 80 chars as required by the coding standard. I have fixed this. --Stef

[Qemu-devel] [PULL 01/11] sdhci: Drop unnecessary #include

2014-02-14 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Reviewed-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- hw/sd/sdhci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 0906a1d..a0b90ba 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -26,7 +26,6 @@ #include

Re: [Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Fabien Chouteau
On 02/14/2014 04:33 PM, Andreas Färber wrote: > As for the other one you'll need to sort our who sends a pull if Blue > doesn't resurface - I didn't see any message about this. Does anyone know why he's not around? > I note that qemu-trivial is not CC'ed here and the > patch probably isn't anyway

Re: [Qemu-devel] [PATCH v2] qcow2: Set zero flag for discarded clusters

2014-02-14 Thread Stefan Hajnoczi
On Sat, Feb 08, 2014 at 05:50:02PM +0100, Kevin Wolf wrote: > Instead of making the backing file contents visible again after a discard > request, set the zero flag if possible (i.e. on version >= 3). > > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > block/qcow2-cluster.c | 22

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-14 Thread Paolo Bonzini
Il 14/02/2014 17:45, Kevin Wolf ha scritto: > -ret = bdrv_file_open(&cow_bs, filename, NULL, NULL, BDRV_O_RDWR, > - &local_err); > +ret = bdrv_file_open(&cow_bs, filename, NULL, NULL, BDRV_O_RDWR, errp); > if (ret < 0) { > -qerror_report_err(local_err)

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-14 Thread Jeff Cody
On Fri, Feb 14, 2014 at 05:45:40PM +0100, Kevin Wolf wrote: > Am 11.02.2014 um 18:03 hat Paolo Bonzini geschrieben: > > Signed-off-by: Paolo Bonzini > > --- > > block/cow.c | 12 +++- > > 1 file changed, 3 insertions(+), 9 deletions(-) > > > > diff --git a/block/cow.c b/block/cow.c > > i

Re: [Qemu-devel] [PATCH v2 01/20] nbd: produce a better error if neither host nor port is passed

2014-02-14 Thread Jeff Cody
On Tue, Feb 11, 2014 at 06:03:34PM +0100, Paolo Bonzini wrote: > Before: > $ qemu-io-old > qemu-io-old> open -r -o file.driver=nbd > qemu-io-old: can't open device (null): Could not open image: Invalid > argument > $ ./qemu-io-old > qemu-io-old> open -r -o file.driver=nbd,file.

Re: [Qemu-devel] [PATCH v2 00/20] Improve bdrv_open error messages

2014-02-14 Thread Paolo Bonzini
Il 14/02/2014 17:31, Stefan Hajnoczi ha scritto: > 19 files changed, 302 insertions(+), 297 deletions(-) Looks good except for the memory leak that I commented on. Thanks! I sent v3 of that one patch. Paolo

[Qemu-devel] [PATCH v3 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-14 Thread Paolo Bonzini
Before: $ ./qemu-io-old qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo Failed to parse URL : foo qemu-io-old: can't open device (null): Could not open 'foo': Invalid argument After: $ ./qemu-io qemu-io> open -r -o file.driver=iscsi,file.filename=foo qemu-i

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-14 Thread Kevin Wolf
Am 11.02.2014 um 18:03 hat Paolo Bonzini geschrieben: > Signed-off-by: Paolo Bonzini > --- > block/cow.c | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/block/cow.c b/block/cow.c > index 7fc0b12..43a2150 100644 > --- a/block/cow.c > +++ b/block/cow.c > @@ -8

[Qemu-devel] [PATCH] net: Disable netmap backend when not supported

2014-02-14 Thread Vincenzo Maffione
This patch fixes configure so that netmap is not compiled in if the host doesn't support an API version >= 11. Moreover, some modifications have been done to net/netmap.c in order to reflect the current netmap API (11). Signed-off-by: Vincenzo Maffione --- configure| 3 +++ net/netmap.c |

Re: [Qemu-devel] Trying to write a new device / virtio-i2c ?

2014-02-14 Thread Paolo Bonzini
Il 14/02/2014 17:31, Andreas Färber ha scritto: While that is certainly possible in case host passthrough was desired, maybe virtio was mixed up with VFIO? I don't think so, VFIO is mostly about IOMMUs and protecting from DMA. Paolo

Re: [Qemu-devel] [PATCH v2 09/35] target-arm: A64: Implement MSR (immediate) instructions

2014-02-14 Thread Peter Maydell
On 5 February 2014 06:23, Peter Crosthwaite wrote: > On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell > wrote: >> +switch (op) { >> +case 0x05: /* SPSel */ >> +env->pstate = deposit32(env->pstate, 0, 1, imm); > > "0","1" hardcoded constants are a bit unfriendly. I guess the current

Re: [Qemu-devel] [PATCH v2 00/20] Improve bdrv_open error messages

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 11, 2014 at 06:03:33PM +0100, Paolo Bonzini wrote: > Most of the block drivers are not using the Error** argument to > bdrv_open, and instead just printing errors to stderr. This series > improves that, using Error** instead of abusing errno numbers too. > > The only hurdle (caught by

Re: [Qemu-devel] Trying to write a new device / virtio-i2c ?

2014-02-14 Thread Andreas Färber
Am 14.02.2014 16:58, schrieb Paolo Bonzini: > Il 13/02/2014 14:26, Alex David ha scritto: >> After reading code, documentation and available things, I've been trying >> to write something like a "virtio-i2c" : I wrote a virtio-i2c module for >> my kernel (I used some examples from virtio-pci and vi

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Kevin Wolf
Am 14.02.2014 um 15:41 hat Jeff Cody geschrieben: > On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: > > On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: > > > @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs, > > > QDict *options, > > > > > >

Re: [Qemu-devel] [PATCH v4] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Andreas Färber
Am 14.02.2014 17:06, schrieb Sebastian Huber: > The LEON3 processor has support for the CASA instruction which is > normally only available for SPARC V9 processors. Binutils 2.24 > and GCC 4.9 will support this instruction for LEON3. GCC uses it to > generate C11 atomic operations. > > The CAS s

Re: [Qemu-devel] [PATCH v2 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 11, 2014 at 06:03:39PM +0100, Paolo Bonzini wrote: > @@ -1349,14 +1350,15 @@ static int iscsi_reopen_prepare(BDRVReopenState > *state, > static int iscsi_truncate(BlockDriverState *bs, int64_t offset) > { > IscsiLun *iscsilun = bs->opaque; > -int ret = 0; > +Error *local

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Jeff Cody
On Fri, Feb 14, 2014 at 04:38:03PM +0100, Stefan Hajnoczi wrote: > On Fri, Feb 14, 2014 at 09:41:46AM -0500, Jeff Cody wrote: > > On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: > > > On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: > > > > @@ -291,23 +311,17 @@ static in

[Qemu-devel] [PATCH v4] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Sebastian Huber
The LEON3 processor has support for the CASA instruction which is normally only available for SPARC V9 processors. Binutils 2.24 and GCC 4.9 will support this instruction for LEON3. GCC uses it to generate C11 atomic operations. The CAS synthetic instruction uses an ASI of 0x80. If TARGET_SPARC

Re: [Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Andreas Färber
Am 14.02.2014 16:43, schrieb Sebastian Huber: > On 2014-02-14 16:33, Andreas Färber wrote: >>> @@ -5120,6 +5119,20 @@ static void disas_sparc_insn(DisasContext * >>> dc, unsigned int insn) >>> > case 0x37: /* stdc */ >>> > goto ncp_insn; >>> > #endif >>> >+#if

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Vincenzo Maffione
Ok, this patch should preferably go in before the offloadings. 2014-02-14 16:40 GMT+01:00 Stefan Hajnoczi : > On Fri, Feb 14, 2014 at 02:41:24PM +0100, Vincenzo Maffione wrote: > > It is ok for you if I prepare a patch (touching configure and > > net/netmap.c) that makes sure the host kernel h

Re: [Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Sebastian Huber
On 2014-02-14 16:33, Andreas Färber wrote: @@ -5120,6 +5119,20 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) > case 0x37: /* stdc */ > goto ncp_insn; > #endif >+#if !defined(CONFIG_USER_ONLY) || defined(TARGET_SPARC64) >+

Re: [Qemu-devel] [PATCH 0/2] Make open by reference use id then node-name

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 05:15:05PM +0100, Benoît Canet wrote: > This series was asked by Kevin. > It sit on top of the snapshot fix patch and max openv2 series. > > I have done the following tests. > > check qemu-iotest ok > snapshot blockbackend by id ok > open quorum by node-name reference and

Re: [Qemu-devel] [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 03:22:04PM +0100, Cedric Bosdonnat wrote: > On Fri, 2014-02-14 at 09:16 +0100, Jan Kiszka wrote: > > > I need to submit our organization application (including our project > > > ideas) on Friday. > > > > Hope it's not too late: just added the VT-d emulation proposal. > > I

Re: [Qemu-devel] Trying to write a new device / virtio-i2c ?

2014-02-14 Thread Paolo Bonzini
Il 13/02/2014 14:26, Alex David ha scritto: After reading code, documentation and available things, I've been trying to write something like a "virtio-i2c" : I wrote a virtio-i2c module for my kernel (I used some examples from virtio-pci and virtio-console), it seems that it created a "i2c-1" dev

Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

2014-02-14 Thread Thomas Huth
On Fri, 14 Feb 2014 10:38:02 +0100 Greg Kurz wrote: > On Thu, 17 Oct 2013 14:23:35 +1030 > Rusty Russell wrote: > > This is a re-transmit of the core of the virtio endian code. Since > > there seems to be some interest in ARM BE virtio, I've separated this from > > the direct problem I was solv

Re: [Qemu-devel] [PATCH] qtest: include system headers before user headers

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 03:42:41PM +0100, Andreas Färber wrote: > Am 14.02.2014 15:32, schrieb Stefan Hajnoczi: > > On Sat, Feb 08, 2014 at 11:41:07AM +0100, Stefan Hajnoczi wrote: > > Is anyone willing to be qtest maintainer, i.e. you understand qtest, can > > review patches, and will send pull re

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 02:41:24PM +0100, Vincenzo Maffione wrote: > It is ok for you if I prepare a patch (touching configure and > net/netmap.c) that makes sure the host kernel has the minimum netmap > version required for QEMU to work (and if not just --disable-netmap)? Absolutely. Stefan

Re: [Qemu-devel] [PATCH] qtest: Unlink pid file before reading from QMP

2014-02-14 Thread Andreas Färber
Am 14.02.2014 15:43, schrieb Stefan Hajnoczi: > On Sun, Feb 09, 2014 at 12:21:41PM +0100, Andreas Färber wrote: >> Despite 1ad3c6abc0d67e00b84abaa5527bc64b70ca2205, supplying invalid >> arguments to the QEMU process still leaked a /tmp/qtest-*.pid file. >> >> Fix this by reordering the reading and

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 09:41:46AM -0500, Jeff Cody wrote: > On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: > > On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: > > > @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs, > > > QDict *options, > > >

Re: [Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Andreas Färber
Am 14.02.2014 16:16, schrieb Sebastian Huber: > The LEON3 processor has support for the CASA instruction which is > normally only available for SPARC V9 processors. Binutils 2.24 > and GCC 4.9 will support this instruction for LEON3. GCC uses it to > generate C11 atomic operations. > > The CAS s

Re: [Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close.

2014-02-14 Thread Stefan Hajnoczi
On Thu, Feb 13, 2014 at 05:22:33PM +0100, Benoît Canet wrote: > As bdrv_open() documentation states: > "The reference to the QDict belongs to the block layer > * after the call (even on failure), so if the caller intends to reuse the > * dictionary, it needs to use QINCREF() before calling bdrv_o

Re: [Qemu-devel] [PATCH v2] block: mirror - use local_err to avoid NULL errp

2014-02-14 Thread Stefan Hajnoczi
On Thu, Feb 13, 2014 at 09:23:38AM -0500, Jeff Cody wrote: > When starting a block job, commit_active_start() relies on whether *errp > is set by mirror_start_job. This allows it to determine if the mirror > job start failed, so that it can clean up any changes to open flags from > the bdrv_reopen

Re: [Qemu-devel] Trying to write a new device / virtio-i2c ?

2014-02-14 Thread Stefan Hajnoczi
On Thu, Feb 13, 2014 at 02:26:16PM +0100, Alex David wrote: > I'm new to QEMU and kinda new to driver & QEMU programming in general, so > please excuse my questions... > > I want to develop a new QEMU i2c device (qemu x86), that would get/send > data to an application running on the guest. Thing i

[Qemu-devel] [Bug 1279500] Re: system_powerdown causes SMP OpenBSD guest to freeze

2014-02-14 Thread Robert Urban
If someone needs to coordinate with someone from the OpenBSD team, please talk to Mike Larkin . He expressed an intention to look into this problem from the OpenBSD side. I would be delighted if I could supply Mike with a qemu contact person, of if someone could contact him directly (and copy me, p

Re: [Qemu-devel] [PATCH 0/2] qemu-iotest fixes and updates for 070

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 04:30:51PM -0500, Jeff Cody wrote: > This fixes a bug with test 070 (incorrect output expectation), > and adds additional test for log replay. > > > Jeff Cody (2): > block: qemu-iotests - fix test 070 (vhdx) > block: qemu-iotests - add vhdx log replay tests for qemu-im

Re: [Qemu-devel] [PATCH] block: mirror - insure that errp is not NULL

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 02:46:47PM -0500, Jeff Cody wrote: It doesn't really matter, but: http://public.wsu.edu/~brians/errors/assure.html “ensure” that something happens is to make certain that it does, and to “insure” is to issue an insurance policy. Other authorities, however, consider “

[Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Sebastian Huber
The LEON3 processor has support for the CASA instruction which is normally only available for SPARC V9 processors. Binutils 2.24 and GCC 4.9 will support this instruction for LEON3. GCC uses it to generate C11 atomic operations. The CAS synthetic instruction uses an ASI of 0x80. If TARGET_SPARC

Re: [Qemu-devel] [PATCH] block: mirror - insure that errp is not NULL

2014-02-14 Thread Stefan Hajnoczi
On Thu, Feb 13, 2014 at 09:41:45AM +0100, Kevin Wolf wrote: > Am 12.02.2014 um 20:46 hat Jeff Cody geschrieben: > > When starting a block job, commit_active_start() relies on whether *errp > > is set by mirror_start_job. This allows it to determine if the mirror > > job start failed, so that it ca

  1   2   >