Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

2014-02-13 Thread Paolo Bonzini
Il 14/02/2014 07:56, Alexey Kardashevskiy ha scritto: > Subject: [PATCH V17 04/11] NUMA: convert -numa option to use OptsVisitor > Message-Id: <1386143939-19142-5-git-send-email-gaowanl...@cn.fujitsu.com> > http://article.gmane.org/gmane.comp.emulators.qemu/244826 Any progress with this?

Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support

2014-02-13 Thread Paolo Bonzini
Il 14/02/2014 04:25, Alexey Kardashevskiy ha scritto: Nobody seems picking up the bits I am interested in from this :-/ What can I possibly do to get this in upstream?... I feel I am doing something systematically wrong but nobody is telling me what exactly. Thanks. No, you're not. Ping agraf

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

2014-02-13 Thread Alexey Kardashevskiy
On 12/04/2013 11:48 PM, Eduardo Habkost wrote: > On Wed, Dec 04, 2013 at 04:50:59PM +1100, Alexey Kardashevskiy wrote: >> On 12/04/2013 01:47 AM, Eduardo Habkost wrote: >>> On Tue, Dec 03, 2013 at 02:30:48PM +0100, Andreas Färber wrote: Am 03.12.2013 00:03, schrieb Alexey Kardashevskiy: >

Re: [Qemu-devel] [PATCH v4 06/22] cpu: Add per-cpu address space

2014-02-13 Thread Edgar E. Iglesias
On Tue, Feb 11, 2014 at 08:52:11PM +0100, Andreas Färber wrote: > Edgar, > > Am 03.02.2014 10:44, schrieb Edgar E. Iglesias: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > cpus.c | 2 ++ > > cputlb.c| 7

Re: [Qemu-devel] [PATCH 2/2] tests-ppc64: test for -device spapr-pci-host-bridge

2014-02-13 Thread Alexey Kardashevskiy
On 02/11/2014 02:48 AM, Andreas Färber wrote: > Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy: >> This adds a test if SPAPR PHB can be added via the command line. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> tests/Makefile | 2 ++ >> tests/spapr-phb-test.c | 28 +++

Re: [Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule

2014-02-13 Thread Alexey Kardashevskiy
On 02/11/2014 07:32 AM, Andreas Färber wrote: > Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy: >> This adds $(check-qtest-ppc64-y) to the check-clean rule. >> >> Signed-off-by: Alexey Kardashevskiy > > Nice catch! > >> --- >> tests/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 delet

Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py

2014-02-13 Thread Wenchao Xia
于 2014/1/7 11:24, Wenchao Xia 写道: + + +# Following are the functions that generate event behavior control functions. +# Those functions are put here in the qapi-event.c, since it need to include +# qapi-event.h for the event enum type declaration, put them in other file +# requiring other file in

Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support

2014-02-13 Thread Alexey Kardashevskiy
On 01/22/2014 11:17 PM, Alexey Kardashevskiy wrote: > On 01/22/2014 09:16 PM, Paolo Bonzini wrote: >> Il 22/01/2014 05:19, Alexey Kardashevskiy ha scritto: >>> On 12/11/2013 09:22 PM, Alexey Kardashevskiy wrote: With the great help from Paolo, I am presenting yet another try of bootindex

Re: [Qemu-devel] [PATCH V6 00/10] qapi script: support enum as discriminator and better enum name

2014-02-13 Thread Wenchao Xia
于 2014/2/13 23:23, Markus Armbruster 写道: > Wenchao Xia writes: > >> This series address two issues: >> >> 1. support using enum as discriminator in union. >> For example, if we have following define in qapi schema: >> { 'enum': 'EnumOne', >>'data': [ 'value1', 'value2', 'value3' ] } >> >> { '

Re: [Qemu-devel] [PATCH V6 09/10] tests: add cases for inherited struct and union with discriminator

2014-02-13 Thread Wenchao Xia
于 2014/2/13 23:11, Luiz Capitulino 写道: On Thu, 13 Feb 2014 15:53:30 +0100 Markus Armbruster wrote: Wenchao Xia writes: Test for inherit and complex union. This patch conflicts badly with my test coverage work in "[PATCH v2 00/13] qapi: Test coverage & clean up generated code". My series

Re: [Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union

2014-02-13 Thread Wenchao Xia
于 2014/2/13 23:14, Markus Armbruster 写道: > Wenchao Xia writes: > >> It will check whether the values specified are written correctly, >> and whether all enum values are covered, when discriminator is a >> pre-defined enum type >> >> Signed-off-by: Wenchao Xia >> Reviewed-by: Eric Blake >> --- >

Re: [Qemu-devel] [PATCH V6 02/10] qapi script: add check for duplicated key

2014-02-13 Thread Wenchao Xia
于 2014/2/13 23:14, Markus Armbruster 写道: > Wenchao Xia writes: > >> It is bad that same key was specified twice, especially when a union have >> two branches with same condition. This patch can prevent it. >> >> Signed-off-by: Wenchao Xia >> Reviewed-by: Eric Blake >> --- >> scripts/qapi.py |

[Qemu-devel] [PATCH] spapr-vlan: flush queue whenever can_receive can go from false to true

2014-02-13 Thread Alexey Kardashevskiy
When the guests adds buffers to receive queue, the network device should flush its queue of pending packets. This is done with qemu_flush_queued_packets. This adds a call to qemu_flush_queued_packets() which wakes up the main loop and let QEMU update the network device status which now is "can rec

Re: [Qemu-devel] Multi GPU passthrough via VFIO

2014-02-13 Thread Alex Williamson
On Fri, 2014-02-14 at 01:01 +0100, Maik Broemme wrote: > Hi Alex, > > Maik Broemme wrote: > > Hi Alex, > > > > Alex Williamson wrote: > > > On Fri, 2014-02-07 at 01:22 +0100, Maik Broemme wrote: > > > > Interesting is the diff between 1st and 2nd boot, so if I do the lspci > > > > prior to the

Re: [Qemu-devel] Multi GPU passthrough via VFIO

2014-02-13 Thread Maik Broemme
Hi Alex, Maik Broemme wrote: > Hi Alex, > > Alex Williamson wrote: > > On Fri, 2014-02-07 at 01:22 +0100, Maik Broemme wrote: > > > Interesting is the diff between 1st and 2nd boot, so if I do the lspci > > > prior to the booting. The only difference between 1st start and 2nd > > > start are: >

Re: [Qemu-devel] [PATCH] hw/arm/vexpress: Set reset-cbar property for CPUs

2014-02-13 Thread Peter Maydell
On 13 February 2014 23:39, Peter Crosthwaite wrote: > I've been thinking about the CPU-mpcore problem, and perhaps the most > annoying part of it is propagating the user -cpu argument through to > change to CPU model. On several occasions however we have declared > this to be largely bogus for ARM

Re: [Qemu-devel] [PATCH] hw/arm/vexpress: Set reset-cbar property for CPUs

2014-02-13 Thread Peter Crosthwaite
On Fri, Feb 14, 2014 at 7:45 AM, Peter Maydell wrote: > On 13 February 2014 21:31, Rob Herring wrote: >> On Thu, Feb 13, 2014 at 8:26 AM, Peter Maydell >> wrote: >>> Newer versions of the Linux kernel (as of commit bc41b8724 in 3.12) >>> now assume that if the CPU is a Cortex-A9 and the reset v

Re: [Qemu-devel] [PATCH] hw/arm/vexpress: Set reset-cbar property for CPUs

2014-02-13 Thread Peter Maydell
On 13 February 2014 21:31, Rob Herring wrote: > On Thu, Feb 13, 2014 at 8:26 AM, Peter Maydell > wrote: >> Newer versions of the Linux kernel (as of commit bc41b8724 in 3.12) >> now assume that if the CPU is a Cortex-A9 and the reset value of the >> PERIPHBASE/CBAR register is zero then the CPU

[Qemu-devel] [PATCH/RFC] clear bss memory of ROMS

2014-02-13 Thread Christian Borntraeger
On 13/02/14 20:39, Christian Borntraeger wrote: > On 13/02/14 16:15, Richard Henderson wrote: >> On 02/13/2014 01:17 AM, Christian Borntraeger wrote: >>> The current code does not initialize next_idx as the qemu >>> elf loader does not zero the bss section. >>> Make the initialization explicit. >>>

Re: [Qemu-devel] [PATCH] hw/arm/vexpress: Set reset-cbar property for CPUs

2014-02-13 Thread Rob Herring
On Thu, Feb 13, 2014 at 8:26 AM, Peter Maydell wrote: > Newer versions of the Linux kernel (as of commit bc41b8724 in 3.12) > now assume that if the CPU is a Cortex-A9 and the reset value of the > PERIPHBASE/CBAR register is zero then the CPU is a specific buggy > single core A9 SoC, and will not

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-13 Thread Stefan Priebe
Am 13.02.2014 21:06, schrieb Dr. David Alan Gilbert: * Stefan Priebe (s.pri...@profihost.ag) wrote: Am 10.02.2014 17:07, schrieb Dr. David Alan Gilbert: * Stefan Priebe (s.pri...@profihost.ag) wrote: i could fix it by explicitly disable xbzrle - it seems its automatically on if i do not set t

[Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-13 Thread Mario Smarduch
virtio: set virtio-net/virtio-mmio host features Patch sets 'virtio-net/virtio-mmio' host features to enable network features based on peer capabilities. Currently host features turn of all features by default. Signed-off-by: Mario Smarduch --- hw/virtio/virtio-mmio.c | 29 +++

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-13 Thread Stefan Priebe
got it here: http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg02341.html will try asap Am 13.02.2014 21:06, schrieb Dr. David Alan Gilbert: * Stefan Priebe (s.pri...@profihost.ag) wrote: Am 10.02.2014 17:07, schrieb Dr. David Alan Gilbert: * Stefan Priebe (s.pri...@profihost.ag) wro

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-13 Thread Stefan Priebe
Am 13.02.2014 21:06, schrieb Dr. David Alan Gilbert: * Stefan Priebe (s.pri...@profihost.ag) wrote: Am 10.02.2014 17:07, schrieb Dr. David Alan Gilbert: * Stefan Priebe (s.pri...@profihost.ag) wrote: i could fix it by explicitly disable xbzrle - it seems its automatically on if i do not set t

Re: [Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts

2014-02-13 Thread Laszlo Ersek
On 02/13/14 18:45, Eric Blake wrote: > On 02/13/2014 09:13 AM, Igor Mammedov wrote: >> Adds option to -m >> "mem" - startup memory amount >> >> For compatibility with legacy CLI if suffix-less number is passed, >> it assumes amount in MiB. >> >> Otherwise user is free to use suffixed number using

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-13 Thread Dr. David Alan Gilbert
* Stefan Priebe (s.pri...@profihost.ag) wrote: > Am 10.02.2014 17:07, schrieb Dr. David Alan Gilbert: > >* Stefan Priebe (s.pri...@profihost.ag) wrote: > >>i could fix it by explicitly disable xbzrle - it seems its > >>automatically on if i do not set the migration caps to false. > >> > >>So it see

Re: [Qemu-devel] [PATCH 0/2] Use g_new() & friends where that makes obvious sense

2014-02-13 Thread Markus Armbruster
Peter Maydell writes: > On 13 February 2014 16:36, Markus Armbruster wrote: >> I started splitting the patch, and it bores me to tears. >> >> Peter, any chance for applying as is, with all conflicting hunks >> summarily dropped? > > I'm afraid that sounds like too much manual effort on my part.

[Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Push zero'd pages into the XBZRLE cache A page that was cached by XBZRLE, zero'd and then XBZRLE'd again was being compared against a stale cache value Don't use 'qemu_put_buffer_async' to put pages from the XBZRLE cache Since the cache might change bef

Re: [Qemu-devel] [PULL 1/3] s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx

2014-02-13 Thread Christian Borntraeger
On 13/02/14 16:15, Richard Henderson wrote: > On 02/13/2014 01:17 AM, Christian Borntraeger wrote: >> The current code does not initialize next_idx as the qemu >> elf loader does not zero the bss section. >> Make the initialization explicit. >> >> Signed-off-by: Christian Borntraeger >> --- >> pc

Re: [Qemu-devel] [PATCH RFC] char: fix avail_connections init in qemu_chr_open_eventfd()

2014-02-13 Thread Cam Macdonell
Hi David, I'm not sure which is the correct approach. You could either do what you did or you could simply remove the qemu_chr_fe_claim_no_fail() from ivshmem.c. I'm not sure how your change impacts other devices. Sincerely, Cam On Tue, Feb 4, 2014 at 2:17 PM, David Marchand wrote: > Hello,

Re: [Qemu-devel] [PATCH 2/2] block: Open by reference will try device then node_name.

2014-02-13 Thread Max Reitz
On 12.02.2014 17:15, Benoît Canet wrote: Since we introduced node_name for named bs of the graph modify the opening by reference to use it as a fallback. This patch also enforce the separation of the device id and graph node namespaces. Signed-off-by: Benoit Canet --- block.c| 10 +++

Re: [Qemu-devel] [PATCH 1/2] block: Relax bdrv_lookup_bs constraints.

2014-02-13 Thread Max Reitz
On 12.02.2014 17:15, Benoît Canet wrote: The following patch will reuse bdrv_lookup_bs in order to open images by references so the rules of usage of bdrv_lookup_bs must be relaxed a bit. Signed-off-by: Benoit Canet --- block.c | 26 +++--- 1 file changed, 11 insertions(+

Re: [Qemu-devel] Open by references and close on exit

2014-02-13 Thread Max Reitz
Hi Benoît, Hm, opening a reference should only result in the refcount of the respective BDS being incremented through bdrv_ref(). Since no new BDS is created, nothing should be added to bdrv_states. When the BDS “closed” through bdrv_unref(), it is only actually closed/deleted if the refcount

[Qemu-devel] [Bug 1279500] Re: system_powerdown causes SMP OpenBSD guest to freeze

2014-02-13 Thread Robert Urban
hoping to increase the OpenBSD developers' inclination to investigate this bug, I reproduced it using OpenBSD 5.4 as the host. I used the stock qemu-1.5.1 that is available as an OpenBSD package. Booting the GENERIC.MP kernel in the VM was painfully slow, but it eventually came up to multi-user mo

Re: [Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts

2014-02-13 Thread Eric Blake
On 02/13/2014 09:13 AM, Igor Mammedov wrote: > Adds option to -m > "mem" - startup memory amount > > For compatibility with legacy CLI if suffix-less number is passed, > it assumes amount in MiB. > > Otherwise user is free to use suffixed number using suffixes b,k/K,M,G > > Signed-off-by: Igor

Re: [Qemu-devel] [PATCH v2] qga: Don't require 'time' argument in guest-set-time command

2014-02-13 Thread Michal Privoznik
On 31.01.2014 19:12, Eric Blake wrote: On 01/31/2014 03:29 AM, Michal Privoznik wrote: As the description to the guest-set-time states, the command is there to ease time synchronization after resume. If guest was suspended for longer period of time, its system time can go off so badly, that even

[Qemu-devel] Get the dirty bitmap of a whole VM

2014-02-13 Thread Vincent KHERBACHE
Hi all, I'm trying to calculate the dirty bytes rate of a VM by traveling the corresponding memory dirty bitmaps. I get a bitmap from KVM kernel space using the following ioctl call : kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d); Also, I'm getting the bitmap for each memory slot inside the KVMState ob

Re: [Qemu-devel] timer issue on 1.7.0 and later

2014-02-13 Thread Peter Maydell
On 13 February 2014 16:31, Alex Bligh wrote: > The current code (timer_mod_ns_locked) runs the rearm code > if the modified timer is at the front of the timer queue > (only). So if you modify B (in your example above) whether > you extend or reduce the time, it will only 'rearm' if > B now occurs

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: fix 32 bit build break in the page table lookup code

2014-02-13 Thread Greg Kurz
On Thu, 13 Feb 2014 15:53:16 +0100 Alexander Graf wrote: > > On 13.02.2014, at 04:00, Aneesh Kumar K.V > wrote: > > > Greg Kurz writes: > > > >> The 396bb9874 commit reworked page table lookup to support kvm. > >> Unfortunately this breaks 32 bit build: > >> > >> target-ppc/mmu-hash64.h: In

Re: [Qemu-devel] [PATCH 0/2] Use g_new() & friends where that makes obvious sense

2014-02-13 Thread Peter Maydell
On 13 February 2014 16:36, Markus Armbruster wrote: > I started splitting the patch, and it bores me to tears. > > Peter, any chance for applying as is, with all conflicting hunks > summarily dropped? I'm afraid that sounds like too much manual effort on my part. thanks -- PMM

Re: [Qemu-devel] [PATCH 0/2] Use g_new() & friends where that makes obvious sense

2014-02-13 Thread Markus Armbruster
Peter Maydell writes: > On 3 February 2014 08:40, Markus Armbruster wrote: >> Peter Maydell writes: >>> On 31 January 2014 15:53, Markus Armbruster wrote: 186 files changed, 376 insertions(+), 415 deletions(-) >>> >>> No objection in principle, but I think this is going to be >>> hideous

[Qemu-devel] [PULL 16/22] dump: make kdump-compressed format available for 'dump-guest-memory'

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'elf': ELF format, without compression 2. 'kdump-zlib': kdu

Re: [Qemu-devel] timer issue on 1.7.0 and later

2014-02-13 Thread Alex Bligh
On 13 Feb 2014, at 16:20, Peter Maydell wrote: > On 13 February 2014 16:09, Alex Bligh wrote: >> I suspect the issue is not walking the lists, but calling >> qemu_notify, breaking out of mainloop select etc. etc.; that >> happens on a timer_modify but not on a timer_del. We could >> fix this so

Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements

2014-02-13 Thread Peter Maydell
On 10 February 2014 16:47, Michael S. Tsirkin wrote: > The following changes since commit 2b2449f7e467957778ca006904471b231dc0ac8e: > > Merge remote-tracking branch 'remotes/borntraeger/tags/kvm-s390-20140131' > into staging (2014-02-04 18:46:33 +) > > are available in the git repository at

Re: [Qemu-devel] [PATCH v2 1/4] target-mips: add CPU definition for MIPS32R5

2014-02-13 Thread Petar Jovanovic
From: Andreas Färber [afaer...@suse.de] Sent: Thursday, February 13, 2014 5:11 PM To: Peter Maydell; Petar Jovanovic Cc: QEMU Developers; Petar Jovanovic; Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH v2 1/4] target-mips: add CPU definition for MIPS32R5

[Qemu-devel] [PULL 11/22] dump: add members to DumpState and init some of them

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan add some members to DumpState that will be used in writing vmcore in kdump-compressed format. some of them, like page_size, will be initialized in the patch. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c| 28 ++

[Qemu-devel] [PATCH] Fix: remove bogus QDECREF()

2014-02-13 Thread Benoît Canet
This extra QDECREF() was causing quorum_close() to crash while doing bdrv_unref(). As the optional options qdict should belong to the block layer so do not use QDECREF() on it. I tested the following inti and qemu exit sequences. tested regular snapshots on device=virtio0 ok tested command line

[Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close.

2014-02-13 Thread Benoît Canet
As bdrv_open() documentation states: "The reference to the QDict belongs to the block layer * after the call (even on failure), so if the caller intends to reuse the * dictionary, it needs to use QINCREF() before calling bdrv_open." the optional options dict will not be reused after bdrv_open()

[Qemu-devel] [PULL 17/22] dump: Define the architecture for compressed dump format.

2014-02-13 Thread Luiz Capitulino
From: Ekaterina Tumanova Signed-off-by: Ekaterina Tumanova Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c | 7 +-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index 2eb

Re: [Qemu-devel] timer issue on 1.7.0 and later

2014-02-13 Thread Peter Maydell
On 13 February 2014 16:09, Alex Bligh wrote: > I suspect the issue is not walking the lists, but calling > qemu_notify, breaking out of mainloop select etc. etc.; that > happens on a timer_modify but not on a timer_del. We could > fix this so that it only happened if the timer's expiry > time was

[Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts

2014-02-13 Thread Igor Mammedov
Adds option to -m "mem" - startup memory amount For compatibility with legacy CLI if suffix-less number is passed, it assumes amount in MiB. Otherwise user is free to use suffixed number using suffixes b,k/K,M,G Signed-off-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- v3: - fixes sugges

Re: [Qemu-devel] [PATCH v2 1/4] target-mips: add CPU definition for MIPS32R5

2014-02-13 Thread Andreas Färber
Am 13.02.2014 15:51, schrieb Peter Maydell: > On 10 February 2014 15:42, Peter Maydell wrote: >> On 10 February 2014 13:51, Andreas Färber wrote: >>> Am 24.01.2014 17:18, schrieb Petar Jovanovic: From: Petar Jovanovic --- a/target-mips/translate_init.c +++ b/target-mips/translate_

Re: [Qemu-devel] timer issue on 1.7.0 and later

2014-02-13 Thread Alex Bligh
On 13 Feb 2014, at 15:36, Peter Maydell wrote: > On 10 February 2014 17:15, Rob Herring wrote: >> This doesn't appear to be too useful. The AvgLength is large because >> INT64_MAX / GTIMER_SCALE is used as the next timer value when no timer >> is needed. > > The code already uses timer_del() wh

[Qemu-devel] [PULL 10/22] dump: add support for lzo/snappy

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan kdump-compressed format supports three compression format, zlib/lzo/snappy. Currently, only zlib is available. This patch is used to support lzo/snappy. '--enable-lzo/--enable-snappy' is needed to be specified with configure to make lzo/snappy available for qemu Signed-off-by: Q

[Qemu-devel] [PULL 14/22] dump: add APIs to operate DataCache

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan DataCache is used to store data temporarily, then the data will be written to vmcore. These functions will be called later when writing data of page to vmcore. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c| 47

Re: [Qemu-devel] [PULL 0/4] user-mode FR switch support for MIPS32r5

2014-02-13 Thread Petar Jovanovic
> g...@github.com:petar-jovanovic/qemu.git mips-ufrp > I can fix things up manually, so you don't need to resend, but > this isn't a valid git remote URL (at least, it doesn't work > for me). True, for the above link you need ssh key in-place, it's valid for me only. Sorry! > You probably wante

[Qemu-devel] [PULL 21/22] monitor: Add object_del id argument completion.

2014-02-13 Thread Luiz Capitulino
From: Hani Benhabiles Signed-off-by: Hani Benhabiles Signed-off-by: Luiz Capitulino --- monitor.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/monitor.c b/monitor.c index 4ffe44d..5b863c9 100644 --- a/monitor.c +++ b/monitor.c @@ -4294,6 +4294,27 @@ static void

[Qemu-devel] [PULL 20/22] monitor: Add device_add device argument completion.

2014-02-13 Thread Luiz Capitulino
From: Hani Benhabiles Signed-off-by: Hani Benhabiles Signed-off-by: Luiz Capitulino --- monitor.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/monitor.c b/monitor.c index c90fc1d..4ffe44d 100644 --- a/monitor.c +++ b/monitor.c @@ -4254,6 +4254,27 @@ static co

Re: [Qemu-devel] [PATCH v2] SPARC: Add and use CPU_FEATURE_CASA

2014-02-13 Thread Fabien Chouteau
On 02/13/2014 03:55 PM, Fabien Chouteau wrote: > On 02/13/2014 02:00 PM, Sebastian Huber wrote: >> On 2014-02-13 13:01, Fabien Chouteau wrote: >>> On 02/13/2014 10:52 AM, Sebastian Huber wrote: The LEON3 processor has support for the CASA instruction which is normally only available for S

Re: [Qemu-devel] timer issue on 1.7.0 and later

2014-02-13 Thread Peter Maydell
On 10 February 2014 17:15, Rob Herring wrote: > This doesn't appear to be too useful. The AvgLength is large because > INT64_MAX / GTIMER_SCALE is used as the next timer value when no timer > is needed. The code already uses timer_del() when no next timer is needed (that's the "timer disabled" ca

[Qemu-devel] [PULL 18/22] dump: add 'query-dump-guest-memory-capability' command

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan 'query-dump-guest-memory-capability' is used to query the available formats for 'dump-guest-memory'. The output of the command will be like: -> { "execute": "query-dump-guest-memory-capability" } <- { "return": { "formats": ["elf", "kdump-zlib", "kdump-lzo",

[Qemu-devel] [PULL 12/22] dump: add API to write dump header

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only elf notes here Signed-off-

[Qemu-devel] [PULL 22/22] monitor: Add object_add class argument completion.

2014-02-13 Thread Luiz Capitulino
From: Hani Benhabiles Signed-off-by: Hani Benhabiles Signed-off-by: Luiz Capitulino --- monitor.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/monitor.c b/monitor.c index 5b863c9..de90fba 100644 --- a/monitor.c +++ b/monitor.c @@ -56,6 +56,7 @@ #include "qapi/q

[Qemu-devel] [PULL 06/22] dump: add argument to write_elfxx_notes

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to vmcore. Adding parameter "WriteCoreDumpFunction f" makes it available to choose the method of writing elf notes Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --

[Qemu-devel] [PULL 13/22] dump: add API to write dump_bitmap

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan functions are used to write 1st and 2nd dump_bitmap of kdump-compressed format, which is used to indicate whether the corresponded page is existed in vmcore. 1st and 2nd dump_bitmap are same, because dump level is specified to 1 here. Signed-off-by: Qiao Nuohan Reviewed-by: Las

[Qemu-devel] [PULL 19/22] monitor: Add device_del id argument completion.

2014-02-13 Thread Luiz Capitulino
From: Hani Benhabiles Signed-off-by: Hani Benhabiles Signed-off-by: Luiz Capitulino --- monitor.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/monitor.c b/monitor.c index 690c152..c90fc1d 100644 --- a/monitor.c +++ b/monitor.c @@ -4254,6 +4254,25 @@ static const

[Qemu-devel] [PULL 15/22] dump: add API to write dump pages

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan functions are used to write page to vmcore. vmcore is written page by page. page desc is used to store the information of a page, including a page's size, offset, compression format, etc. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino ---

[Qemu-devel] [PULL 05/22] dump: const-qualify the buf of WriteCoreDumpFunction

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan WriteCoreDumpFunction is a function pointer that points to the function used to write content in "buf" into core file, so "buf" should be const-qualify. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c| 2 +- include/

[Qemu-devel] [PULL 04/22] qmp: expose list of supported character device backends

2014-02-13 Thread Luiz Capitulino
From: Martin Kletzander Introduce 'query-chardev-backends' QMP command which lists all supported character device backends. Signed-off-by: Martin Kletzander Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- qapi-schema.json | 22 ++ qemu-char.c | 19

[Qemu-devel] [PULL 08/22] dump: add API to write vmcore

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan Function is used to write vmcore in flatten format. In flatten format, data is written block by block, and in front of each block, a struct MakedumpfileDataHeader is stored there to indicate the offset and size of the data block. struct MakedumpfileDataHeader { int64_t offse

[Qemu-devel] [PULL 02/22] QMP: allow JSON dict arguments in qmp-shell

2014-02-13 Thread Luiz Capitulino
From: Stefan Hajnoczi qmp-shell hides the QMP wire protocol JSON encoding from the user. Most of the time this is helpful and makes the command-line human-friendly. Some QMP commands take a dict as an argument. In order to express this we need to revert back to JSON notation. This patch allow

[Qemu-devel] [PULL 09/22] dump: add API to write elf notes to buffer

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan the function can be used by write_elf32_notes/write_elf64_notes to write notes to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes will write elf notes to vmcore directly. Instead, if buf_write_note is used, elf notes will be written to opaque->note_buf a

[Qemu-devel] [PULL 00/22] QMP queue

2014-02-13 Thread Luiz Capitulino
The following changes since commit 9d74f6fef0801ca2ce5c9d38d59b85bf03c27669: Merge remote-tracking branch 'remotes/alon/pull-libcacard.glusterfs' into staging (2014-02-12 17:53:31 +) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fe

[Qemu-devel] [PULL 07/22] dump: add API to write header of flatten format

2014-02-13 Thread Luiz Capitulino
From: qiaonuohan flatten format will be used when writing kdump-compressed format. The format is also used by makedumpfile, you can refer to the following URL to get more detailed information about flatten format of kdump-compressed format: http://sourceforge.net/projects/makedumpfile/ The two f

[Qemu-devel] [PULL 01/22] hmp: migrate command (without -d) now blocks correctly

2014-02-13 Thread Luiz Capitulino
From: Soramichi AKIYAMA This patch fixes a timing issue that migrate command (without -d) does not block in some cases. The original version of hmp.c:hmp_migrate_status_cb checks if the migration status is 'active' or not to detect the completion of a migration. However, if this function is exe

Re: [Qemu-devel] [PATCH V6 00/10] qapi script: support enum as discriminator and better enum name

2014-02-13 Thread Markus Armbruster
Wenchao Xia writes: > This series address two issues: > > 1. support using enum as discriminator in union. > For example, if we have following define in qapi schema: > { 'enum': 'EnumOne', > 'data': [ 'value1', 'value2', 'value3' ] } > > { 'type': 'UserDefBase0', > 'data': { 'base-string0': '

Re: [Qemu-devel] [PATCH V6 00/10] qapi script: support enum as discriminator and better enum name

2014-02-13 Thread Luiz Capitulino
On Tue, 11 Feb 2014 14:13:19 -0500 Luiz Capitulino wrote: > On Tue, 11 Feb 2014 05:48:31 +0800 > Wenchao Xia wrote: > > > This series address two issues: > > > > 1. support using enum as discriminator in union. > > For example, if we have following define in qapi schema: > > { 'enum': 'EnumOne

Re: [Qemu-devel] [PATCH V6 08/10] qapi script: do not allow string discriminator

2014-02-13 Thread Markus Armbruster
Wenchao Xia writes: > Signed-off-by: Wenchao Xia > --- > docs/qapi-code-gen.txt |8 +++- > scripts/qapi-visit.py |6 ++ > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt > index a2e7921..c92add9 100644 > --- a/do

Re: [Qemu-devel] [PATCH V6 09/10] tests: add cases for inherited struct and union with discriminator

2014-02-13 Thread Luiz Capitulino
On Thu, 13 Feb 2014 15:53:30 +0100 Markus Armbruster wrote: > Wenchao Xia writes: > > > Test for inherit and complex union. > > This patch conflicts badly with my test coverage work in "[PATCH v2 > 00/13] qapi: Test coverage & clean up generated code". My series > systematically covers code g

Re: [Qemu-devel] [PULL 1/3] s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx

2014-02-13 Thread Richard Henderson
On 02/13/2014 01:17 AM, Christian Borntraeger wrote: > The current code does not initialize next_idx as the qemu > elf loader does not zero the bss section. > Make the initialization explicit. > > Signed-off-by: Christian Borntraeger > --- > pc-bios/s390-ccw/virtio.c | 1 + > 1 file changed, 1 i

Re: [Qemu-devel] [PATCH v2 2/2] vl: convert -m to QemuOpts

2014-02-13 Thread Eric Blake
On 02/13/2014 06:50 AM, Igor Mammedov wrote: > Adds option to -m > "mem" - startup memory amount > > For compatibility with legacy CLI if suffix-less number is passed, > it assumes amount in Mb. > > Otherwise user is free to use suffixed number using suffixes b,k/K,M,G > > Signed-off-by: Igor M

Re: [Qemu-devel] [PATCH V6 02/10] qapi script: add check for duplicated key

2014-02-13 Thread Markus Armbruster
Wenchao Xia writes: > It is bad that same key was specified twice, especially when a union have > two branches with same condition. This patch can prevent it. > > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake > --- > scripts/qapi.py |2 ++ > 1 files changed, 2 insertions(+), 0 delet

Re: [Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union

2014-02-13 Thread Markus Armbruster
Wenchao Xia writes: > It will check whether the values specified are written correctly, > and whether all enum values are covered, when discriminator is a > pre-defined enum type > > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake > --- > scripts/qapi-visit.py | 17 + >

Re: [Qemu-devel] [PATCH v2] block: mirror - use local_err to avoid NULL errp

2014-02-13 Thread Eric Blake
On 02/13/2014 07:23 AM, Jeff Cody wrote: > When starting a block job, commit_active_start() relies on whether *errp > is set by mirror_start_job. This allows it to determine if the mirror > job start failed, so that it can clean up any changes to open flags from > the bdrv_reopen(). If errp is NU

Re: [Qemu-devel] [PULL 0/3] PReP patch queue 2014-02-10

2014-02-13 Thread Peter Maydell
On 10 February 2014 16:22, Andreas Färber wrote: > Hello Peter, > > Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. Applied, thanks. -- PMM

Re: [Qemu-devel] [PATCH] tcg-arm: The shift count of op_rotl_i32 is in args[2] not args[1].

2014-02-13 Thread Richard Henderson
On 02/13/2014 02:26 AM, Huw Davies wrote: > It's this that should be subtracted from 0x20 when converting to a right > rotate. > > Signed-off-by: Huw Davies > --- > tcg/arm/tcg-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PULL 0/4] user-mode FR switch support for MIPS32r5

2014-02-13 Thread Peter Maydell
On 10 February 2014 16:19, Petar Jovanovic wrote: > The following changes since commit 1f6b12f75f2c22f861d0202374033a7594c91707: > > Merge remote-tracking branch 'remotes/mwalle/tags/lm32-fixes/20140204' into > staging (2014-02-08 15:57:51 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] target-ppc: fix 32 bit build break in the page table lookup code

2014-02-13 Thread Alexander Graf
On 13.02.2014, at 04:00, Aneesh Kumar K.V wrote: > Greg Kurz writes: > >> The 396bb9874 commit reworked page table lookup to support kvm. >> Unfortunately this breaks 32 bit build: >> >> target-ppc/mmu-hash64.h: In function ‘ppc_hash64_load_hpte0’: >> target-ppc/mmu-hash64.h:90:23: error: ca

[Qemu-devel] [PATCH 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

2014-02-13 Thread Takashi Iwai
The GDK motion-notify-event isn't generated when the pointer goes out of the target window even if the pointer is grabbed, which essentially means to lose the pointer tracking in gtk-ui. Meanwhile the generic "event" signal is sent when the pointer is grabbed, so we can use this and pick the motio

[Qemu-devel] [PATCH 0/4] Fix relative pointer tracking on Gtk UI

2014-02-13 Thread Takashi Iwai
Hi, this is a series of patches to fix / improve the behavior of Gtk UI in the relative pointer tracking mode. Most people didn't notice the bug likely because it doesn't appear as long as the aboslute mode is used, e.g. when vmmouse input driver is enabled. But I hit this annoying behavior beca

Re: [Qemu-devel] [PATCH v2] SPARC: Add and use CPU_FEATURE_CASA

2014-02-13 Thread Fabien Chouteau
On 02/13/2014 02:00 PM, Sebastian Huber wrote: > On 2014-02-13 13:01, Fabien Chouteau wrote: >> On 02/13/2014 10:52 AM, Sebastian Huber wrote: >>> The LEON3 processor has support for the CASA instruction which is >>> normally only available for SPARC V9 processors. Binutils 2.24 >>> and GCC 4.9 wi

[Qemu-devel] [PATCH 4/4] gtk: Add "Grab On Click" option

2014-02-13 Thread Takashi Iwai
I simply like it better, you don't? :) Signed-off-by: Takashi Iwai --- ui/gtk.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index e04f0781ae6c..4942c8330505 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -133,6 +133,7 @@ typedef struct GtkDisplayState G

[Qemu-devel] [PATCH 3/4] gtk: Remember the last grabbed pointer position

2014-02-13 Thread Takashi Iwai
It's pretty annoying that the pointer reappears at a random place once after grabbing and ungrabbing the input. Better to restore to the original position where the pointer was grabbed. Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 Signed-off-by: Takashi Iwai --- ui/gtk.c | 16 +

Re: [Qemu-devel] [PATCH V6 09/10] tests: add cases for inherited struct and union with discriminator

2014-02-13 Thread Markus Armbruster
Wenchao Xia writes: > Test for inherit and complex union. This patch conflicts badly with my test coverage work in "[PATCH v2 00/13] qapi: Test coverage & clean up generated code". My series systematically covers code generation in scripts/qapi*py, and that takes me seven patches. If I put you

[Qemu-devel] [PATCH 2/4] gtk: Fix the relative pointer tracking mode

2014-02-13 Thread Takashi Iwai
The relative pointer tracking mode was still buggy even after the previous fix of the motion-notify-event since the events are filtered out when the pointer moves outside the drawing window due to the boundary check for the absolute mode. This patch fixes the issue by moving the unnecessary bounda

Re: [Qemu-devel] [PATCH] target-ppc: fix warn_unused_result build break with in-kernel HTAB support

2014-02-13 Thread Alexander Graf
On 13.02.2014, at 04:00, Aneesh Kumar K.V wrote: > Greg Kurz writes: > >> The 7029677e4 commit introduced the following build break: >> >> target-ppc/kvm.c: In function ‘kvmppc_hash64_write_pte’: >> target-ppc/kvm.c:2017:10: error: ignoring return value of ‘write’, declared >> with attribute

Re: [Qemu-devel] [PATCH v2 1/4] target-mips: add CPU definition for MIPS32R5

2014-02-13 Thread Peter Maydell
On 10 February 2014 15:42, Peter Maydell wrote: > On 10 February 2014 13:51, Andreas Färber wrote: >> Am 24.01.2014 17:18, schrieb Petar Jovanovic: >>> From: Petar Jovanovic >>> --- a/target-mips/translate_init.c >>> +++ b/target-mips/translate_init.c >>> @@ -333,6 +333,31 @@ static const mips_d

Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation

2014-02-13 Thread Alexander Graf
On 13.02.2014, at 11:40, Greg Kurz wrote: > On Thu, 13 Feb 2014 08:29:28 +0530 > "Aneesh Kumar K.V" wrote: > >> From: "Aneesh Kumar K.V" >> >> Correctly update the htab_mask using the return value of >> KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1 >> on GET_SREGS for HV. We check f

Re: [Qemu-devel] [PATCH RFC] char: fix avail_connections init in qemu_chr_open_eventfd()

2014-02-13 Thread David Marchand
Hello, Can someone take a look at my previous email and tell me if my patch is just wrong ? Thank you. -- David Marchand On Tue, Feb 4, 2014 at 10:17 PM, David Marchand wrote: > Hello, > > First of all, this is a pure RFC patch, I did not take too much time to > dig into > qemu source code

Re: [Qemu-devel] [PATCH v10 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-13 Thread Luiz Capitulino
On Thu, 13 Feb 2014 09:48:33 +0800 Qiao Nuohan wrote: > On 02/12/2014 10:49 PM, Luiz Capitulino wrote: > > On Wed, 12 Feb 2014 14:34:19 +0800 > > Qiao Nuohan wrote: > > > >> 'query-dump-guest-memory-capability' is used to query the available > >> formats for > >> 'dump-guest-memory'. The output

  1   2   >