Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-09 Thread Peter Crosthwaite
On Wed, Jan 8, 2014 at 11:47 PM, Paolo Bonzini wrote: > Il 08/01/2014 14:40, Andreas Färber ha scritto: >> > Either you fix "info qtree" to cope with your change to the device >> > graph, or the change needs to be reverted until somebody fixes it or it >> > goes away. >> Sharing a backtrace would

[Qemu-devel] [PATCH] KVM: fix addr type for KVM_IOEVENTFD

2014-01-09 Thread Alexey Kardashevskiy
The @addr here is a guest physical address and can easily be bigger than 4G. This changes uint32_t to hwaddr. Cc: Michael S. Tsirkin Signed-off-by: Alexey Kardashevskiy --- This was found during investigation why vhost is not always working on PPC64-spapr. It turned out that KVM_IOEVENTFD was

Re: [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary

2014-01-09 Thread Riku Voipio
Hi, On Thu, Jan 09, 2014 at 01:03:06PM +0100, Andreas Färber wrote: > "... of load_elf_binary() and load_flt_binary()" - Riku can you fix pls? Changed and added to queque. Riku > Am 09.01.2014 10:10, schrieb Will Newton: > > The regs parameter is not used anywhere, so remove it. > > > > Signed

Re: [Qemu-devel] QEMU detachable overlays and Union Mounts

2014-01-09 Thread kausik pal
Hi stefan, Thanks a lot for the elaborate explanation. >2. The backing chain actually doesn't make sense: >win-base <- vm01 <- firefox <- winscp >win-base <- vm02 <- winscp <- 7zip >The topmost image file must be read-write so the guest can persist >data to disk. That means vm01, vm02 should b

Re: [Qemu-devel] vhost-net issue: does not survive reboot on ppc64

2014-01-09 Thread Alexey Kardashevskiy
On 01/08/2014 12:18 AM, Alexey Kardashevskiy wrote: > On 12/25/2013 02:43 AM, Michael S. Tsirkin wrote: >> On Wed, Dec 25, 2013 at 01:15:29AM +1100, Alexey Kardashevskiy wrote: >>> On 12/24/2013 08:40 PM, Michael S. Tsirkin wrote: On Tue, Dec 24, 2013 at 02:09:07PM +1100, Alexey Kardashevskiy

Re: [Qemu-devel] [PATCH target-arm v4 0/3] Reset and Halting modifications + Zynq SMP

2014-01-09 Thread Peter Crosthwaite
Ping! On Thu, Jan 2, 2014 at 5:30 PM, Peter Crosthwaite wrote: > Hi All, > > The clock controller module in the Zynq platform has the ability to halt > and reset arbitrary devices, including the CPU. We use this feature to > implement > SMP Linux - the kernel halts CPU1 then rewrites the vector

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-09 Thread Peter Feiner
On Thu, Jan 9, 2014 at 5:59 AM, Kevin Wolf wrote: > I think if there is no bs->backing_hd->file, we should get the filename > from bs->backing_hd->filename instead of leaving it empty. > > In fact, can we always do that or does bs->backing_hd normally lack the > filename? If so, perhaps that is wh

Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed

2014-01-09 Thread Wenchao Xia
于 2014/1/10 0:25, Peter Lieven 写道: > Am 09.01.2014 09:29, schrieb Wenchao Xia: >> 于 2014/1/8 17:08, Peter Lieven 写道: >>> Signed-off-by: Peter Lieven >>> --- >>>ui/vnc.c |9 + >>>1 file changed, 9 insertions(+) >>> >>> diff --git a/ui/vnc.c b/ui/vnc.c >>> index da552fe..a742d32 1

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2014-01-09 Thread Amos Kong
On Wed, Jan 08, 2014 at 09:53:02PM +0530, Amit Shah wrote: > On (Wed) 08 Jan 2014 [17:14:41], Amos Kong wrote: > > On Wed, Dec 18, 2013 at 11:05:14AM +0100, Giuseppe Scrivano wrote: > > > Markus Armbruster writes: > > > > > > > Amos Kong writes: > > > > > > > >> Bugzilla: https://bugs.launchpad.

[Qemu-devel] [RFC v2 4/6] qdev: add get_pointer_and_free() for temporary strings

2014-01-09 Thread Stefan Hajnoczi
get_pointer() assumes the string has unspecified lifetime (at least as long as the object is alive). In some cases we can only produce a temporary string that should be freed when get_pointer() is done. Signed-off-by: Stefan Hajnoczi --- hw/core/qdev-properties-system.c | 14 ++ 1 f

[Qemu-devel] [RFC v2 6/6] dataplane: replace internal thread with IOThread

2014-01-09 Thread Stefan Hajnoczi
Today virtio-blk dataplane uses a 1:1 device-per-thread model. Now that IOThreads have been introduced we can generalize this to N:M devices per threads. This patch drops thread code from dataplane in favor of running inside an IOThread AioContext. As a bonus we solve the case where a guest keep

[Qemu-devel] [RFC v2 1/6] rfifolock: add recursive FIFO lock

2014-01-09 Thread Stefan Hajnoczi
QemuMutex does not guarantee fairness and cannot be acquired recursively: Fairness means each locker gets a turn and the scheduler cannot cause starvation. Recursive locking is useful for composition, it allows a sequence of locking operations to be invoked atomically by acquiring the lock around

[Qemu-devel] [RFC v2 3/6] iothread: add I/O thread object

2014-01-09 Thread Stefan Hajnoczi
This is a stand-in for Michael Roth's QContext. I expect this to be replaced once QContext is completed. The IOThread object is an AioContext event loop thread. This patch adds the concept of multiple event loop threads, allowing users to define them. When SMP guests run on SMP hosts it makes s

[Qemu-devel] [RFC v2 5/6] iothread: add "iothread" qdev property type

2014-01-09 Thread Stefan Hajnoczi
Add a "iothread" qdev property type so devices can be hooked up to an IOThread from the comand-line: qemu -object iothread,id=iothread0 \ -device some-device,iothread=iothread0 Signed-off-by: Stefan Hajnoczi --- hw/core/qdev-properties-system.c | 51

[Qemu-devel] [RFC v2 2/6] aio: add aio_context_acquire() and aio_context_release()

2014-01-09 Thread Stefan Hajnoczi
It can be useful to run an AioContext from a thread which normally does not "own" the AioContext. For example, request draining can be implemented by acquiring the AioContext and looping aio_poll() until all requests have been completed. The following pattern should work: /* Event loop thread

Re: [Qemu-devel] [PATCH 5/5] -object/object-add: use custom default object location if provided

2014-01-09 Thread Stefan Hajnoczi
On Wed, Jan 08, 2014 at 05:09:42PM +0100, Igor Mammedov wrote: > @@ -603,13 +606,18 @@ out: > void qmp_object_del(const char *id, Error **errp) > { > Object *container; This local is now unused, please delete it to prevent a compiler warning.

[Qemu-devel] [RFC v2 0/6] dataplane: switch to N:M devices-per-thread model

2014-01-09 Thread Stefan Hajnoczi
This series moves the event loop thread out of dataplane code. It makes -object iothread,id=foo a separate concept. This makes it possible to bind several devices to the same iothread. Syntax: qemu -object iothread,id=iothread0 \ -device virtio-blk-pci,iothread=iothread0,x-data-plane=o

Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of threads per core

2014-01-09 Thread Alexey Kardashevskiy
On 01/10/2014 10:40 AM, Alexander Graf wrote: > > >> Am 09.01.2014 um 23:12 schrieb Alexey Kardashevskiy : >> >>> On 01/10/2014 08:00 AM, Mike Day wrote: >>> >>> Alexey Kardashevskiy writes: >>> /* compute missing values, prefer sockets over cores over threads */

Re: [Qemu-devel] QEMU detachable overlays and Union Mounts

2014-01-09 Thread Stefan Hajnoczi
On Thu, Jan 9, 2014 at 7:45 PM, kausik pal wrote: > From an Administrator's perspective the software/package layering and VM > operation should go like the following:- > > 1. Administrator install Windows as a Base QEMU/KVM vm (Say win-base). > 2. Using qemu-img create with -b option create an ove

Re: [Qemu-devel] [PATCH 04/13] mxs/imx23: Add DMA driver

2014-01-09 Thread Peter Crosthwaite
On Fri, Jan 10, 2014 at 10:52 AM, Peter Crosthwaite wrote: > On Tue, Jan 7, 2014 at 1:35 AM, Peter Maydell > wrote: >> On 11 December 2013 13:56, Michel Pollet wrote: >>> This driver works sufficiently well that linux can use it to access >>> the SD card using the SD->DMA->SSI->SD. It hasn't be

Re: [Qemu-devel] [PATCH 04/13] mxs/imx23: Add DMA driver

2014-01-09 Thread Peter Crosthwaite
On Tue, Jan 7, 2014 at 1:35 AM, Peter Maydell wrote: > On 11 December 2013 13:56, Michel Pollet wrote: >> This driver works sufficiently well that linux can use it to access >> the SD card using the SD->DMA->SSI->SD. It hasn't been tested for >> much else. >> >> Signed-off-by: Michel Pollet >> -

Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of threads per core

2014-01-09 Thread Alexander Graf
> Am 09.01.2014 um 23:12 schrieb Alexey Kardashevskiy : > >> On 01/10/2014 08:00 AM, Mike Day wrote: >> >> Alexey Kardashevskiy writes: >> >>> /* compute missing values, prefer sockets over cores over threads */ >>> if (cpus == 0 || sockets == 0) { >>> sockets = so

Re: [Qemu-devel] [PATCH 3/3] Makefile: add bios-256k.bin to BLOBS

2014-01-09 Thread Peter Maydell
On 9 January 2014 21:55, Steven Noonan wrote: > From: Steven Noonan > > Signed-off-by: Steven Noonan > Cc: Anthony Liguori > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index bdff4e4..807054b 100644 > --- a/Makefile > +++ b/Make

Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags

2014-01-09 Thread Brad Smith
On 09/01/14 5:40 PM, Paolo Bonzini wrote: Il 09/01/2014 22:55, Steven Noonan ha scritto: From: Steven Noonan The -fstack-protector flag family is useful for ensuring safety and for debugging, but has a performance impact. Here's a boot time comparison between a QEMU build of qemu-system-arm wi

[Qemu-devel] Enabling vhost-net cause insane high memory usage.

2014-01-09 Thread Piotr Karbowski
Hello, kernel 3.12.5, qemu-1.7.0. With vhost=on, qemu shortly after start uses all its assigned memory (2G for example), without vhost-net enabled it does not go to more than 200 MB on my idling test virtual machine. 100% reproducable. I think its not how it should be. Full command: /usr/bi

Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of threads per core

2014-01-09 Thread Scott Wood
On Thu, 2014-01-09 at 16:34 +1100, Alexey Kardashevskiy wrote: > On POWERPC, only a whole CPU core can be assigned to a KVM. s/POWERPC/POWER/ -Scott

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-09 Thread Alex Williamson
On Thu, 2014-01-09 at 23:56 +0200, Michael S. Tsirkin wrote: > On Thu, Jan 09, 2014 at 12:03:26PM -0700, Alex Williamson wrote: > > On Thu, 2014-01-09 at 11:47 -0700, Alex Williamson wrote: > > > On Thu, 2014-01-09 at 20:00 +0200, Michael S. Tsirkin wrote: > > > > On Thu, Jan 09, 2014 at 10:24:47AM

Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags

2014-01-09 Thread Paolo Bonzini
Il 09/01/2014 22:55, Steven Noonan ha scritto: > From: Steven Noonan > > The -fstack-protector flag family is useful for ensuring safety and for > debugging, but has a performance impact. Here's a boot time comparison between > a QEMU build of qemu-system-arm with and without the -fstack-protecto

Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags

2014-01-09 Thread Peter Maydell
On 9 January 2014 21:55, Steven Noonan wrote: > From: Steven Noonan > > The -fstack-protector flag family is useful for ensuring safety and for > debugging, but has a performance impact. Here's a boot time comparison between > a QEMU build of qemu-system-arm with and without the -fstack-protector

Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of threads per core

2014-01-09 Thread Alexey Kardashevskiy
On 01/10/2014 08:00 AM, Mike Day wrote: > > Alexey Kardashevskiy writes: > >> /* compute missing values, prefer sockets over cores over threads */ >> if (cpus == 0 || sockets == 0) { >> sockets = sockets > 0 ? sockets : 1; >> cores = cores > 0 ? cores

Re: [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386

2014-01-09 Thread Gabriel L. Somlo
On Thu, Jan 09, 2014 at 11:33:59PM +0200, Michael S. Tsirkin wrote: > Except XP doesn't support ConcatenateResTemplate so need to write > it differently. I tried this: Device(HPET) { ... Field(HPTM, DWordAcc, Lock, Preserve) { VEND, 32, PRD, 32, UNU

[Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags

2014-01-09 Thread Steven Noonan
From: Steven Noonan The -fstack-protector flag family is useful for ensuring safety and for debugging, but has a performance impact. Here's a boot time comparison between a QEMU build of qemu-system-arm with and without the -fstack-protector-all flag: # WITHOUT -fstack-protector-all [roo

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 12:03:26PM -0700, Alex Williamson wrote: > On Thu, 2014-01-09 at 11:47 -0700, Alex Williamson wrote: > > On Thu, 2014-01-09 at 20:00 +0200, Michael S. Tsirkin wrote: > > > On Thu, Jan 09, 2014 at 10:24:47AM -0700, Alex Williamson wrote: > > > > On Wed, 2013-12-11 at 20:30 +0

[Qemu-devel] [PATCH 2/3] virtfs-proxy-helper.c: fix compile error

2014-01-09 Thread Steven Noonan
From: Steven Noonan This is caused by a linux/xattr.h and sys/xattr.h incompatibility: In file included from /home/snoonan/Development/qemu/include/qemu/xattr.h:27:0, from fsdev/virtfs-proxy-helper.c:25: /usr/include/sys/xattr.h:31:3: error: expected identifier befo

[Qemu-devel] [PATCH 3/3] Makefile: add bios-256k.bin to BLOBS

2014-01-09 Thread Steven Noonan
From: Steven Noonan Signed-off-by: Steven Noonan Cc: Anthony Liguori --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index bdff4e4..807054b 100644 --- a/Makefile +++ b/Makefile @@ -290,7 +290,7 @@ common de-ch es fo fr-ca hu ja

Re: [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386

2014-01-09 Thread Gabriel L. Somlo
Hi Paolo, On Thu, Jan 09, 2014 at 09:12:22PM +0100, Paolo Bonzini wrote: > See > http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg02815.html > for some ideas. I remember saving that email for a closer examination after I took care of the AppleSMC patch, and then I forgot all about it --

Re: [Qemu-devel] Missing vhost=on support on -netdev bridge.

2014-01-09 Thread Piotr Karbowski
On 01/09/2014 10:33 PM, Piotr Karbowski wrote: On 01/09/2014 06:09 PM, Corey Bryant wrote: You should be able to pass a command line like this: -net tap,helper="/usr/local/libexec/qemu-bridge-helper --br=br0" Qemu treat it as one, single command as a whole. :< sh: /usr/libexec/qemu-bridg

Re: [Qemu-devel] [PULL 00/01] seccomp: exit if seccomp_init() fails

2014-01-09 Thread Paul Moore
On Tuesday, January 07, 2014 05:30:32 PM Markus Armbruster wrote: > Eduardo Otubo writes: > > The following changes since commit 2a13f991123fa16841e6d94b02a9cc2c76d91725: > > seccomp: exit if seccomp_init() fails (2013-12-20 16:38:29 -0200) > > > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386

2014-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 09:12:22PM +0100, Paolo Bonzini wrote: > Il 09/01/2014 19:51, Gabriel L. Somlo ha scritto: > > panic(cpu 2 caller 0xff7f80864f8b): "No HPETs available...CPU(s) > > configured > > incorrectly\n"@/SourceCache/AppleIntelCPUPowerManagement/ > > AppleIntelCPUP

Re: [Qemu-devel] Missing vhost=on support on -netdev bridge.

2014-01-09 Thread Piotr Karbowski
On 01/09/2014 06:09 PM, Corey Bryant wrote: You should be able to pass a command line like this: -net tap,helper="/usr/local/libexec/qemu-bridge-helper --br=br0" Qemu treat it as one, single command as a whole. :< sh: /usr/libexec/qemu-bridge-helper --br=lebridge0: not found failed to lau

Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of threads per core

2014-01-09 Thread Mike Day
Alexey Kardashevskiy writes: > /* compute missing values, prefer sockets over cores over threads */ > if (cpus == 0 || sockets == 0) { > sockets = sockets > 0 ? sockets : 1; > cores = cores > 0 ? cores : 1; > -threads = threads > 0 ? thread

Re: [Qemu-devel] [PATCH 0/2] acpi: Fix PCI hole handling on SRAT table

2014-01-09 Thread Laszlo Ersek
On 01/09/14 20:12, Eduardo Habkost wrote: > The original SeaBIOS code used the RamSize variable, that was used by > SeaBIOS for the size of RAM below 4GB, not for all RAM. When copied to > QEMU, the code was changed to use the full RAM size, and this broke the > build_srat() code that handles the P

Re: [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386

2014-01-09 Thread Paolo Bonzini
Il 09/01/2014 19:51, Gabriel L. Somlo ha scritto: > panic(cpu 2 caller 0xff7f80864f8b): "No HPETs available...CPU(s) > configured > incorrectly\n"@/SourceCache/AppleIntelCPUPowerManagement/ > AppleIntelCPUPowerManagement-142.6/pmThread.c:157 > Debugger called: > > > Whatev

[Qemu-devel] [PATCH 1/2] pc: Save size of RAM below 4GB

2014-01-09 Thread Eduardo Habkost
The ram_below_4g value will be useful in other places, such as the ACPI table code, and other code that currently requires passing below_4g_mem_size around in function arguments. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 1 + include/hw/i386/pc.h | 2 +- 2 files changed, 2 insert

[Qemu-devel] [PATCH 0/2] acpi: Fix PCI hole handling on SRAT table

2014-01-09 Thread Eduardo Habkost
The original SeaBIOS code used the RamSize variable, that was used by SeaBIOS for the size of RAM below 4GB, not for all RAM. When copied to QEMU, the code was changed to use the full RAM size, and this broke the build_srat() code that handles the PCI hole. This series fixes the problem by restori

[Qemu-devel] [PATCH 2/2] acpi: Fix PCI hole handling on build_srat()

2014-01-09 Thread Eduardo Habkost
The original SeaBIOS code used the RamSize variable, that was used by SeaBIOS for the size of RAM below 4GB, not for all RAM. When copied to QEMU, the code was changed to use the full RAM size, and this broke the build_srat() code that handles the PCI hole. Change build_srat() to use ram_size_belo

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-09 Thread Alex Williamson
On Thu, 2014-01-09 at 11:47 -0700, Alex Williamson wrote: > On Thu, 2014-01-09 at 20:00 +0200, Michael S. Tsirkin wrote: > > On Thu, Jan 09, 2014 at 10:24:47AM -0700, Alex Williamson wrote: > > > On Wed, 2013-12-11 at 20:30 +0200, Michael S. Tsirkin wrote: > > > > From: Paolo Bonzini > > > > > >

[Qemu-devel] [Bug 1267520] [NEW] Keyboard input not working when the "-k en-us" argument is specified.

2014-01-09 Thread Mofi Taiwo
Public bug reported: This bug occurs on qemu compiled with i386_softmmu and x86-64_softmmu on linux kernel 3.5.0. Whenever I run qemu (both i386 and x86_64) to use the en-us language (even though it is the default), I get "Warning: no scancode found for keysym X" (X is an integer). In the disk

[Qemu-devel] [Bug 1267520] Re: Keyboard input not working when the "-k en-us" argument is specified.

2014-01-09 Thread Mofi Taiwo
** Description changed: This bug occurs on qemu compiled with i386_softmmu and x86-64_softmmu on linux kernel 3.5.0 (64-bit). Whenever I run qemu (both i386 and x86_64) to use the en-us language (even though it is the default), I get "Warning: no scancode found for keysym X" (X is an intege

[Qemu-devel] [Bug 1267520] Re: Keyboard input not working when the "-k en-us" argument is specified.

2014-01-09 Thread Mofi Taiwo
** Description changed: This bug occurs on qemu compiled with i386_softmmu and x86-64_softmmu on linux kernel 3.5.0. Whenever I run qemu (both i386 and x86_64) to use the en-us language (even though it is the default), I get "Warning: no scancode found for keysym X" (X is an integer). - In

[Qemu-devel] [Bug 1267520] Re: Keyboard input not working when the "-k en-us" argument is specified.

2014-01-09 Thread Mofi Taiwo
** Description changed: This bug occurs on qemu compiled with i386_softmmu and x86-64_softmmu on linux kernel 3.5.0 (64-bit). Whenever I run qemu (both i386 and x86_64) to use the en-us language (even though it is the default), I get "Warning: no scancode found for keysym X" (X is an intege

Re: [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386

2014-01-09 Thread Gabriel L. Somlo
On Thu, Jan 09, 2014 at 03:51:17AM +0200, Michael S. Tsirkin wrote: > I was hoping we can figure out a configuration that makes > os x work without hurting xp *and* without just rudely > detecting os x through the SMC._STA hack. Sadly, uncommenting "IRQNoFlags() {2, 8}" in HPET._CRS still causes X

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-09 Thread Alex Williamson
On Thu, 2014-01-09 at 20:00 +0200, Michael S. Tsirkin wrote: > On Thu, Jan 09, 2014 at 10:24:47AM -0700, Alex Williamson wrote: > > On Wed, 2013-12-11 at 20:30 +0200, Michael S. Tsirkin wrote: > > > From: Paolo Bonzini > > > > > > As an alternative to commit 818f86b (exec: limit system memory > >

[Qemu-devel] [PATCH] net: Use g_strdup_printf instead of snprintf.

2014-01-09 Thread Hani Benhabiles
assign_name() in net/net.c is using snprintf + g_strdup to get the same result as g_strdup_printf. Signed-off-by: Hani Benhabiles --- net/net.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/net.c b/net/net.c index 9db88cc..9363b35 100644 --- a/net/net.c +++ b/net/ne

Re: [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is provided.

2014-01-09 Thread Paolo Bonzini
Il 09/01/2014 19:18, Hani Benhabiles ha scritto: > On Wed, Jan 08, 2014 at 06:34:01PM +0100, Paolo Bonzini wrote: >> Il 08/01/2014 18:17, Hani Benhabiles ha scritto: >>> For this reason, the loop in assign_device_name() specifically check that >>> the ID >>> doesn't exist already and uses the next

Re: [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is provided.

2014-01-09 Thread Hani Benhabiles
On Wed, Jan 08, 2014 at 06:34:01PM +0100, Paolo Bonzini wrote: > Il 08/01/2014 18:17, Hani Benhabiles ha scritto: > > For this reason, the loop in assign_device_name() specifically check that > > the ID > > doesn't exist already and uses the next value if it does. > > > > How would something like

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 10:24:47AM -0700, Alex Williamson wrote: > On Wed, 2013-12-11 at 20:30 +0200, Michael S. Tsirkin wrote: > > From: Paolo Bonzini > > > > As an alternative to commit 818f86b (exec: limit system memory > > size, 2013-11-04) let's just make all address spaces 64-bit wide. > >

[Qemu-devel] [PATCH 3/9] pc: make: fix dependencies: rebuild when included file is changed

2014-01-09 Thread Igor Mammedov
some *.dsl files include another *.dsl files but there weren't any dependicies and when included file changed target table wasn't rebuild. Fix this by using the same auto dependency generation as for C files. Signed-off-by: Igor Mammedov --- hw/i386/Makefile.objs |2 +- 1 files changed, 1 in

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-09 Thread Alex Williamson
On Wed, 2013-12-11 at 20:30 +0200, Michael S. Tsirkin wrote: > From: Paolo Bonzini > > As an alternative to commit 818f86b (exec: limit system memory > size, 2013-11-04) let's just make all address spaces 64-bit wide. > This eliminates problems with phys_page_find ignoring bits above > TARGET_PHY

[Qemu-devel] [PATCH 6/9] pc: Q35 DSDT: exclude CPU hotplug IO range from PCI bus resources

2014-01-09 Thread Igor Mammedov
... for range defined at hw/acpi/ich9.c:ICH9_PROC_BASE Signed-off-by: Igor Mammedov --- v2: * add comment about hole origin for CPU hotplug --- hw/i386/acpi-dsdt-pci-crs.dsl |7 --- hw/i386/acpi-dsdt.dsl |7 +++ hw/i386/q35-acpi-dsdt.dsl |8 3 files chan

Re: [Qemu-devel] [V5 PATCH 00/14] [V5 PATCH 00/14] target-ppc: VSX Stage 4

2014-01-09 Thread Tom Musta
Arggh. I relied on Power ISA Book I Section 7.6.1 as a definitive list of VSX instructions. Unfortunately it is not complete. I will publish soon V6 of this series to add in some ISA 2.07 VSX instructions that I missed: - mfvsr*, mtvsr* - fmrg[eo]w - xsrsp - xscvdpspn, xscvspdpn

Re: [Qemu-devel] Missing vhost=on support on -netdev bridge.

2014-01-09 Thread Corey Bryant
On 01/09/2014 11:20 AM, Piotr Karbowski wrote: Hi On 01/08/2014 05:29 AM, Stefan Hajnoczi wrote: On Sun, Dec 22, 2013 at 08:59:56PM +0100, Piotr Karbowski wrote: Looks like netdev bridge have no support for vhost=on switch. Would be ince if that could be added. Try -netdev tap,helper=/path

[Qemu-devel] Emulated Guest TLB flush IPIs in qemu-kvm

2014-01-09 Thread Hu Yaohui
Hi all. If the hardware does not support APIC virtualization: kvm_vcpu_kick sends an host-IPI to the remote vcpu if that vcpu is in guest mode, a VM-exit (exit reason: external interrupt) will be triggered due to the host-IPI. Then on VM-entry (inject_pending_event) the guest-IPI is injected. If th

[Qemu-devel] [PATCH 8/9] pc: ACPI: unify source of CPU hotplug IO base/len

2014-01-09 Thread Igor Mammedov
use C headers defines as source of IO base/len for respective values in ASL code. Signed-off-by: Igor Mammedov --- v2: * add cpu_hotplug_defs.h for sharing defines to reduce ifdeffenery --- hw/acpi/piix4.c|5 ++--- hw/i386/Makefile.objs |2 +- hw/i386/ac

[Qemu-devel] [PATCH 0/9 v3] pc: CPU hotplug support for Q35

2014-01-09 Thread Igor Mammedov
Changes since v2: * use dependency auto generation for *.dsl files * hide DEVICE(PRES) from UI * add comments to document holes punched in CRES * reduce ifdeffenery by moving CPU hotplug defines to a dedicated header shared between C and ASL files * other odd changes requested by "Mic

[Qemu-devel] [PATCH 4/9] pc: set PRST base in DSDT depending on chipset

2014-01-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt-cpu-hotplug.dsl |2 +- hw/i386/acpi-dsdt.dsl |1 + hw/i386/q35-acpi-dsdt.dsl |1 + 3 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.d

[Qemu-devel] [PATCH 9/9] pc: ACPI: update acpi-dsdt.hex.generated q35-acpi-dsdt.hex.generated

2014-01-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt.hex.generated | 333 +++ hw/i386/q35-acpi-dsdt.hex.generated | 138 -- 2 files changed, 374 insertions(+), 97 deletions(-) diff --git a/hw/i386/acpi-dsdt.hex.generated b/hw/i386/acpi-dsdt.hex.gen

[Qemu-devel] [PATCH 5/9] pc: PIIX DSDT: exclude CPU/PCI hotplug & GPE0 IO range from PCI bus resources

2014-01-09 Thread Igor Mammedov
.. so that they might not be used by PCI devices. Note: Resort to concatenating templates with preprocessor help, because 1.0b spec isn't supporting ConcatenateResTemplate, as result Windows XP fails to execute PCI0._CRS method if ConcatenateResTemplate() is used. Signed-off-by: Igor Mammedov --

[Qemu-devel] [PATCH 7/9] pc: ACPI: expose PRST IO range via _CRS

2014-01-09 Thread Igor Mammedov
.. so OSPM could notice resource conflict if there is any. Signed-off-by: Igor Mammedov --- v2: * use define for DEVICE name to make it more descriptive * define _STA as present,functioning, decoding, not shown in UI --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 14 +- 1 files change

[Qemu-devel] [PATCH 2/9] acpi: ich9: add CPU hotplug handling to Q35 machine

2014-01-09 Thread Igor Mammedov
.. use IO port 0cd8-0xcf7 range for CPU present bitmap Signed-off-by: Igor Mammedov --- docs/specs/acpi_cpu_hotplug.txt|4 +++- hw/acpi/ich9.c | 14 ++ include/hw/acpi/cpu_hotplug_defs.h |1 + include/hw/acpi/ich9.h |4 4 files c

[Qemu-devel] [PATCH 1/9] acpi: factor out common cpu hotplug code for PIIX4/Q35

2014-01-09 Thread Igor Mammedov
.. so it could be used for adding CPU hotplug to Q35 machine Add an additional header with that will be shared between C and ASL code: include/hw/acpi/cpu_hotplug_defs.h Signed-off-by: Igor Mammedov --- hw/acpi/Makefile.objs |2 +- hw/acpi/cpu_hotplug.c | 64

Re: [Qemu-devel] [PATCH v6 11/11] Add 'query-dump-guest-memory-capability' command

2014-01-09 Thread Laszlo Ersek
comments below On 01/05/14 08:27, Qiao Nuohan wrote: > 'query-dump-guest-memory-capability' is used to query whether option 'format' > is available for 'dump-guest-memory' and the available format. The output > of the command will be like: > > -> { "execute": "query-dump-guest-memory-capability"

Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed

2014-01-09 Thread Peter Lieven
Am 09.01.2014 09:29, schrieb Wenchao Xia: > 于 2014/1/8 17:08, Peter Lieven 写道: >> Signed-off-by: Peter Lieven >> --- >> ui/vnc.c |9 + >> 1 file changed, 9 insertions(+) >> >> diff --git a/ui/vnc.c b/ui/vnc.c >> index da552fe..a742d32 100644 >> --- a/ui/vnc.c >> +++ b/ui/vnc.c >> @@

Re: [Qemu-devel] [PATCH v5 7/7] Add vhost-user reconnection

2014-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 04:00:01PM +0100, Antonios Motakis wrote: > At runtime vhost-user netdev will detect if the vhost backend is up or down. > Upon disconnection it will set link_down accordingly and notify virtio-net. And then what happens? > > Signed-off-by: Antonios Motakis > Signed-off-

Re: [Qemu-devel] Missing vhost=on support on -netdev bridge.

2014-01-09 Thread Piotr Karbowski
Hi On 01/08/2014 05:29 AM, Stefan Hajnoczi wrote: On Sun, Dec 22, 2013 at 08:59:56PM +0100, Piotr Karbowski wrote: Looks like netdev bridge have no support for vhost=on switch. Would be ince if that could be added. Try -netdev tap,helper=/path/to/qemu-bridge-helper,vhost=on,... Sadly, -netd

Re: [Qemu-devel] [PATCH v5 6/7] Add new vhost-user netdev backend

2014-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 04:00:00PM +0100, Antonios Motakis wrote: > Add a new QEMU netdev backend that is intended to invoke vhost_net > with the vhost-user backend. Also decouple virtio-net from the tap > backend. > > Signed-off-by: Antonios Motakis > Signed-off-by: Nikolay Nikolaev > --- > hm

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-09 Thread Peter Lieven
Am 09.01.2014 15:13, schrieb Kevin Wolf: > Am 26.12.2013 um 13:48 hat Peter Lieven geschrieben: >> This patch adds native support for accessing images on NFS shares without >> the requirement to actually mount the entire NFS share on the host. >> >> NFS Images can simply be specified by an url of t

Re: [Qemu-devel] [PATCH v5 0/7] Vhost and vhost-net support for userspace based backends

2014-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 03:59:54PM +0100, Antonios Motakis wrote: > In this patch series we would like to introduce our approach for putting a > virtio-net backend in an external userspace process. Our eventual target is to > run the network backend in the Snabbswitch ethernet switch, while receivi

Re: [Qemu-devel] [PATCH -V8 3/3] target-ppc: Fix page table lookup with kvm enabled

2014-01-09 Thread Alexander Graf
On 09.01.2014, at 16:46, Aneesh Kumar K.V wrote: > Alexander Graf writes: > >> On 23.12.2013, at 18:23, Aneesh Kumar K.V >> wrote: >> >>> From: "Aneesh Kumar K.V" >>> >>> With kvm enabled, we store the hash page table information in the >>> hypervisor. >>> Use ioctl to read the htab con

Re: [Qemu-devel] [PATCH v5 1/7] Convert -mem-path to QemuOpts and add prealloc, share and unlink properties

2014-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 03:59:55PM +0100, Antonios Motakis wrote: > Extend -mem-path with additional properties: > > - prealloc=on|off - default off, same as -mem-prealloc > - share=on|off - default off, memory is mmapped with MAP_SHARED flag > - unlink=on|off - default on, inlink the file afte

Re: [Qemu-devel] [PATCH v5 5/7] Add vhost-user calls implementation

2014-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 03:59:59PM +0100, Antonios Motakis wrote: > Each ioctl request of vhost-kernel has a vhost-user message equivalent, > which is sent it over the control socket. > > The general approach is to copy the data from the supplied argument > pointer to a designated field in the mes

Re: [Qemu-devel] [PATCH v6 10/11] dump: Make kdump-compressed format available for 'dump-guest-memory'

2014-01-09 Thread Laszlo Ersek
comments below On 01/05/14 08:27, Qiao Nuohan wrote: > Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed > format. The command's usage: > > dump [-p] protocol [begin] [length] [format] > > 'format' is used to specified the format of vmcore and can be: > 1. 'elf': ELF

Re: [Qemu-devel] [PATCH -V8 1/3] target-ppc: Fix htab_mask calculation

2014-01-09 Thread Aneesh Kumar K.V
Alexander Graf writes: > On 23.12.2013, at 18:22, Aneesh Kumar K.V > wrote: > >> From: "Aneesh Kumar K.V" >> >> Correctly update the htab_mask using the return value of >> KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1 >> on GET_SREGS for HV. So don't update htab_mask if sdr1 >> is fo

Re: [Qemu-devel] [PATCH -V8 3/3] target-ppc: Fix page table lookup with kvm enabled

2014-01-09 Thread Aneesh Kumar K.V
Alexander Graf writes: > On 23.12.2013, at 18:23, Aneesh Kumar K.V > wrote: > >> From: "Aneesh Kumar K.V" >> >> With kvm enabled, we store the hash page table information in the hypervisor. >> Use ioctl to read the htab contents. Without this we get the below error when >> trying to read the

Re: [Qemu-devel] [PATCH] virtio-balloon: don't hardcode config size value

2014-01-09 Thread Peter Crosthwaite
On Fri, Jan 10, 2014 at 12:58 AM, Luiz Capitulino wrote: > Use sizeof(strucy virtio_balloon_config) instead. > "struct". > Signed-off-by: Luiz capitulino Otherwise: Reviewed-by: Peter Crosthwaite > --- > > I have no idea which queue this should go through... > Trivial? Regards, Peter >

Re: [Qemu-devel] [PATCH v5 4/7] Add domain socket communication for vhost-user backend

2014-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 03:59:58PM +0100, Antonios Motakis wrote: > Add structures for passing vhost-user messages over a unix domain socket. > This is the equivalent of the existing vhost-kernel ioctls. > > Connect to the named unix domain socket. The system call sendmsg > is used for communicati

[Qemu-devel] [PATCH v5 5/7] Add vhost-user calls implementation

2014-01-09 Thread Antonios Motakis
Each ioctl request of vhost-kernel has a vhost-user message equivalent, which is sent it over the control socket. The general approach is to copy the data from the supplied argument pointer to a designated field in the message. If a file descriptor is to be passed it should be placed also in the f

[Qemu-devel] [PATCH v5 2/7] Decouple vhost from kernel interface

2014-01-09 Thread Antonios Motakis
We introduce the concept of vhost-backend, which can be either vhost-kernel or vhost-user. The existing vhost interface to the kernel is abstracted behind the vhost-kernel backend. We replace all direct ioctls to the kernel with a vhost_call to the backend. vhost dev->control is referenced only in

[Qemu-devel] [PATCH v5 7/7] Add vhost-user reconnection

2014-01-09 Thread Antonios Motakis
At runtime vhost-user netdev will detect if the vhost backend is up or down. Upon disconnection it will set link_down accordingly and notify virtio-net. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c| 16 +++ hw/virtio/vhost-backen

[Qemu-devel] [PATCH v5 0/7] Vhost and vhost-net support for userspace based backends

2014-01-09 Thread Antonios Motakis
In this patch series we would like to introduce our approach for putting a virtio-net backend in an external userspace process. Our eventual target is to run the network backend in the Snabbswitch ethernet switch, while receiving traffic from a guest inside QEMU/KVM which runs an unmodified virtio-

[Qemu-devel] [PATCH v5 3/7] Add vhost-user skeleton

2014-01-09 Thread Antonios Motakis
Add empty vhost_call, init and cleanup for the vhost-user backend. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c| 57 ++- hw/virtio/vhost-backend.c | 35 include/hw/virt

[Qemu-devel] [PATCH v5 6/7] Add new vhost-user netdev backend

2014-01-09 Thread Antonios Motakis
Add a new QEMU netdev backend that is intended to invoke vhost_net with the vhost-user backend. Also decouple virtio-net from the tap backend. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hmp-commands.hx | 4 +- hw/net/vhost_net.c | 66 ++

[Qemu-devel] [PATCH v5 4/7] Add domain socket communication for vhost-user backend

2014-01-09 Thread Antonios Motakis
Add structures for passing vhost-user messages over a unix domain socket. This is the equivalent of the existing vhost-kernel ioctls. Connect to the named unix domain socket. The system call sendmsg is used for communication. To be able to pass file descriptors between processes - we use SCM_RIGHT

[Qemu-devel] [PATCH v5 1/7] Convert -mem-path to QemuOpts and add prealloc, share and unlink properties

2014-01-09 Thread Antonios Motakis
Extend -mem-path with additional properties: - prealloc=on|off - default off, same as -mem-prealloc - share=on|off - default off, memory is mmapped with MAP_SHARED flag - unlink=on|off - default on, inlink the file after openinng it Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikol

[Qemu-devel] [PATCH] virtio-balloon: don't hardcode config size value

2014-01-09 Thread Luiz Capitulino
Use sizeof(strucy virtio_balloon_config) instead. Signed-off-by: Luiz capitulino --- I have no idea which queue this should go through... hw/virtio/virtio-balloon.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.

[Qemu-devel] [PATCH] trace: [simple] Do not include "trace/simple.h" in generated tracer headers

2014-01-09 Thread Lluís Vilanova
The header is not necessary, given that the simple backend does not define any inlined tracing routines. Signed-off-by: Lluís Vilanova -- Cc: Stefan Hajnoczi --- scripts/tracetool/backend/simple.py |3 --- trace/simple.c |2 ++ 2 files changed, 2 insertions(+), 3 de

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-09 Thread Kevin Wolf
Am 26.12.2013 um 13:48 hat Peter Lieven geschrieben: > This patch adds native support for accessing images on NFS shares without > the requirement to actually mount the entire NFS share on the host. > > NFS Images can simply be specified by an url of the form: > nfs: > > For example: > qemu-i

Re: [Qemu-devel] [PATCH 1/1] qtest:Fix the bug about disabling vnc causes "make check" hang

2014-01-09 Thread Markus Armbruster
Andreas Färber writes: > Am 07.01.2014 11:35, schrieb Markus Armbruster: >> Stefan Hajnoczi writes: >>> On Tue, Dec 31, 2013 at 01:19:02AM +0100, Andreas Färber wrote: Am 30.12.2013 09:46, schrieb Kewei Yu: > diff --git a/tests/fdc-test.c b/tests/fdc-test.c > index 38b5b17..80dbdfb

Re: [Qemu-devel] [Qemu-ppc] [RFC] PPC: KVM: add support for LPCR

2014-01-09 Thread Alexander Graf
On 06.01.2014, at 19:23, Greg Kurz wrote: > The LPCR special purpose register was introduced with the PowerPC 970MP > family. > > This patch initializes LPCR for the following families: > - 970 MP > - POWER5+ > - POWER7 > - POWER8 > > Signed-off-by: Greg Kurz Very nice and simple. Thanks, a

Re: [Qemu-devel] [PATCH 0/2] PPC: KVM: fix set_one_reg

2014-01-09 Thread Alexander Graf
On 06.01.2014, at 06:36, Alexey Kardashevskiy wrote: > This fixes set-one-register mechanism in KVM and a bug with AMR occured after > fixing it. Thanks, applied to ppc-next (with fixed commit message for 2/2). Alex

  1   2   >