Re: [Qemu-devel] [PATCH v4 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
Sorry, I don't know something wrong happened to my git or gmail, My patch v4 doesn't use the new title, The two patch v4 are same at all, reviewers just review the first patch_v4. Regard Kewei 2014/1/6 Kewei Yu > When we disable vnc from "./configure", QEMU can't use the vnc option. > So qtest

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Peter Crosthwaite
On Mon, Jan 6, 2014 at 5:41 PM, Peter Maydell wrote: > On 2 January 2014 05:50, Peter Crosthwaite > wrote: >> I'm wondering whether blob loading is actually a reset step not an >> init. > > load_image_targphys() uses the rom blob loader code from hw/core/loader.c, > which already supports reload

Re: [Qemu-devel] [PATCH v3 2/3] qapi: change qapi to convert schema json

2014-01-05 Thread Fam Zheng
On 2014年01月05日 20:02, Amos Kong wrote: QMP schema is defined in a json file, it will be parsed by qapi scripts and generate C files. We want to return the schema information to management, this patch converts the json file to a string table in a C head file, then we can use the json content in Q

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Peter Maydell
On 2 January 2014 05:50, Peter Crosthwaite wrote: > I'm wondering whether blob loading is actually a reset step not an > init. load_image_targphys() uses the rom blob loader code from hw/core/loader.c, which already supports reloading the blob on machine reset if necessary. That raises some more

[Qemu-devel] [PATCH v4 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
When we disable vnc from "./configure", QEMU can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" fails. If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it. Signed-off-by: Kewei Yu --- v2: Consolidate VNC macro's #ifdef'ery to on

Re: [Qemu-devel] [RFC PATCH v4 0/4] qemu-img: add preallocation=full

2014-01-05 Thread Hu Tao
ping...

[Qemu-devel] qemu vm big network latency when met heavy io

2014-01-05 Thread ??????
hi, all: There is a problem when I use ceph rbd for qemu storage. I launch 4 virtual machines, and start 5G random write test at the same time. Under such heavy I/O, the network to virtual machine almost unusable, the network latency is extremely big. I had test another situation, when I use

Re: [Qemu-devel] [PATCHv3 2/6] ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT

2014-01-05 Thread Wenchao Xia
Reviewed-by: Wenchao Xia

Re: [Qemu-devel] [PATCHv3 1/6] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro

2014-01-05 Thread Wenchao Xia
> @@ -781,10 +784,10 @@ static void vnc_dpy_copy(DisplayChangeListener *dcl, > if ((s = w - w_lim) == 0) > break; > } else if (!x) { > -s = (16 - (dst_x % 16)); > +s = (16 - (dst_x % VNC_DIRTY_PIXELS_PER_BIT)); S

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-05 Thread Peter Lieven
On 06.01.2014 02:18, Stefan Hajnoczi wrote: On Fri, Jan 03, 2014 at 12:28:31PM +0100, Peter Lieven wrote: On 03.01.2014 11:37, Stefan Hajnoczi wrote: Looks good. In order to merge this new block driver qemu-iotests support for nfs is required. That way the block driver can be exercised and ch

Re: [Qemu-devel] [PATCHv2 05/18] qemu-iotests: fix tests 014 and 023 to work with any protocol

2014-01-05 Thread Peter Lieven
On 06.01.2014 06:40, Fam Zheng wrote: On 2014年01月06日 01:21, Peter Lieven wrote: Signed-off-by: Peter Lieven --- tests/qemu-iotests/014|4 ++-- tests/qemu-iotests/014.out|2 +- tests/qemu-iotests/023| 11 +-- tests/qemu-iotests/023.out

Re: [Qemu-devel] [PATCHv2 04/18] qemu-iotests: fix test 013 to work with any protocol

2014-01-05 Thread Peter Lieven
On 06.01.2014 06:31, Fam Zheng wrote: On 2014年01月06日 01:21, Peter Lieven wrote: Signed-off-by: Peter Lieven --- tests/qemu-iotests/013 |9 - tests/qemu-iotests/013.out |2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/013 b/tests/qe

[Qemu-devel] [PATCH v2] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
this blob loader will be used to load a specified blob into a specified RAM address. Signed-off-by: Li Guang Suggested-by: Peter Crosthwaite --- hw/misc/Makefile.objs |2 + hw/misc/blob-loader.c | 112 + include/hw/misc/blob-loader.h

Re: [Qemu-devel] [PATCH 2/2] PPC: KVM: fix "set one register"

2014-01-05 Thread Alexey Kardashevskiy
On 01/06/2014 04:36 PM, Alexey Kardashevskiy wrote: > Due to missing @one_reg_id assignment in _spr_register(), > the kvm_get_one_reg/kvm_set_one_reg API has never really been working. > > This enabled the API and removes use of the API for LPCR as > kvm_arch_get_registers/kvm_arch_put_registers r

Re: [Qemu-devel] [PATCHv2 17/18] qemu-iotests: blacklist test 020 for NFS protocol

2014-01-05 Thread Peter Lieven
On 06.01.2014 06:51, Fam Zheng wrote: On 2014年01月06日 01:22, Peter Lieven wrote: reopening is currently not supported. Signed-off-by: Peter Lieven For curiosity, is anything specific to nfs stopping the support of reopen? I think commit will work with host NFS mounted images. The driver has

Re: [Qemu-devel] qemu-iotests: test 051 fails

2014-01-05 Thread Fam Zheng
On 2014年01月06日 14:14, Stefan Hajnoczi wrote: On Mon, Jan 06, 2014 at 09:44:30AM +0800, Fam Zheng wrote: On 2014年01月05日 02:39, Peter Lieven wrote: ~/git/qemu/tests/qemu-iotests$ ./check -qcow2 51 QEMU -- ./qemu QEMU_IMG -- ./qemu-img QEMU_IO -- ./qemu-io QEMU_NBD -- /usr

Re: [Qemu-devel] [PATCH] qemu-iotests: Remove duplicated error message line in 051.out

2014-01-05 Thread Stefan Hajnoczi
On Mon, Jan 06, 2014 at 09:49:07AM +0800, Fam Zheng wrote: > Since 75884af (virtio-blk: Convert to QOM realize), the duplication of > error message is gone. Fix the test reference output to match this. > > Reported-by: Peter Lieven > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/051.out |

Re: [Qemu-devel] qemu-iotests: test 051 fails

2014-01-05 Thread Stefan Hajnoczi
On Mon, Jan 06, 2014 at 09:44:30AM +0800, Fam Zheng wrote: > On 2014年01月05日 02:39, Peter Lieven wrote: > >~/git/qemu/tests/qemu-iotests$ ./check -qcow2 51 > >QEMU -- ./qemu > >QEMU_IMG -- ./qemu-img > >QEMU_IO -- ./qemu-io > >QEMU_NBD -- /usr/local/bin/qemu-nbd > >IMGFMT

Re: [Qemu-devel] [PATCH 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-05 Thread Stefan Hajnoczi
On Mon, Jan 06, 2014 at 01:46:54PM +1000, Peter Crosthwaite wrote: > On Mon, Jan 6, 2014 at 1:27 PM, Stefan Hajnoczi wrote: > > On Thu, Jan 02, 2014 at 08:25:10PM +1000, Peter Crosthwaite wrote: > >> Hi Beniamino, > >> > >> On Thu, Jan 2, 2014 at 7:18 PM, Beniamino Galvani > >> wrote: > >> > Thi

[Qemu-devel] [PATCH v4 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
When we disable vnc from "./configure", QEMU can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" fails. If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it. Signed-off-by: Kewei Yu --- v2: Consolidate VNC macro's #ifdef'ery to on

Re: [Qemu-devel] [PATCHv2 17/18] qemu-iotests: blacklist test 020 for NFS protocol

2014-01-05 Thread Fam Zheng
On 2014年01月06日 01:22, Peter Lieven wrote: reopening is currently not supported. Signed-off-by: Peter Lieven For curiosity, is anything specific to nfs stopping the support of reopen? I think commit will work with host NFS mounted images. Fam

Re: [Qemu-devel] [PATCHv2 06/18] qemu-iotests: fix test 018 to work with any protocol

2014-01-05 Thread Fam Zheng
On 2014年01月06日 01:21, Peter Lieven wrote: Signed-off-by: Peter Lieven --- tests/qemu-iotests/018 | 22 +- tests/qemu-iotests/018.out |4 ++-- 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/tests/qemu-iotests/018 b/tests/qemu-iotests/018 index a

Re: [Qemu-devel] [PATCHv2 05/18] qemu-iotests: fix tests 014 and 023 to work with any protocol

2014-01-05 Thread Fam Zheng
On 2014年01月06日 01:21, Peter Lieven wrote: Signed-off-by: Peter Lieven --- tests/qemu-iotests/014|4 ++-- tests/qemu-iotests/014.out|2 +- tests/qemu-iotests/023| 11 +-- tests/qemu-iotests/023.out| 16 tests/qemu-

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 3:24 PM, Li Guang wrote: Li Guang wrote: Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 2:22 PM, Li Guang wrote: Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 1:55 PM, Li Guang wrote:

[Qemu-devel] [PATCH 0/2] PPC: KVM: fix set_one_reg

2014-01-05 Thread Alexey Kardashevskiy
This fixes set-one-register mechanism in KVM and a bug with AMR occured after fixing it. Alexey Kardashevskiy (2): target-ppc: fix Authority Mask Register init value PPC: KVM: fix "set one register" target-ppc/translate_init.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- 1

[Qemu-devel] [PATCH 1/2] target-ppc: fix Authority Mask Register init value

2014-01-05 Thread Alexey Kardashevskiy
The existing default value (-1) of the AMR register forbids data access to all 32 classes. Since the guest linux does not change this register, we end up with the guest hanging right after switching from the real to protected mode. This sets the default AMR value to zero what enables data access f

[Qemu-devel] [PATCH 2/2] PPC: KVM: fix "set one register"

2014-01-05 Thread Alexey Kardashevskiy
Due to missing @one_reg_id assignment in _spr_register(), the kvm_get_one_reg/kvm_set_one_reg API has never really been working. This enabled the API and removes use of the API for LPCR as kvm_arch_get_registers/kvm_arch_put_registers run a loop for all 1024 SPR and LPCR is one of them. Signed-of

Re: [Qemu-devel] [PATCHv2 04/18] qemu-iotests: fix test 013 to work with any protocol

2014-01-05 Thread Fam Zheng
On 2014年01月06日 01:21, Peter Lieven wrote: Signed-off-by: Peter Lieven --- tests/qemu-iotests/013 |9 - tests/qemu-iotests/013.out |2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/013 b/tests/qemu-iotests/013 index ea3cab9..0dbc934 1

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Peter Crosthwaite
On Mon, Jan 6, 2014 at 3:24 PM, Li Guang wrote: > Li Guang wrote: >> >> Peter Crosthwaite wrote: >>> >>> On Mon, Jan 6, 2014 at 2:22 PM, Li Guang wrote: Peter Crosthwaite wrote: > > On Mon, Jan 6, 2014 at 1:55 PM, Li Guang > wrote: > >> Li Guang wrote: >> >>>

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Li Guang wrote: Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 2:22 PM, Li Guang wrote: Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 1:55 PM, Li Guang wrote: Li Guang wrote: Paolo Bonzini wrote: Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: No, please use "realize" and avoi

Re: [Qemu-devel] [PATCH V8 0/8] qcow2: rollback the modification on fail in snapshot creation

2014-01-05 Thread Stefan Hajnoczi
On Fri, Jan 03, 2014 at 11:08:44AM +0800, Wenchao Xia wrote: > V2: > 1: all fail case will goto fail section. > 2: add the goto code. > > v3: > Address Stefan's comments: > 2: don't goto fail after allocation failure. > 3: use sn->l1size correctly in qcow2_free_cluster(). > 4-7: add te

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 2:22 PM, Li Guang wrote: Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 1:55 PM, Li Guang wrote: Li Guang wrote: Paolo Bonzini wrote: Il 02/01/2014 11:51, Peter Crosthwaite ha scritto:

[Qemu-devel] [PATCH] docs: qcow2 compat=1.1 is now the default

2014-01-05 Thread Stefan Hajnoczi
Commit 9117b47717ad208b12786ce88eacb013f9b3dd1c ("qcow2: Change default for new images to compat=1.1") changed the default qcow2 image format version but forgot to update qemu-doc.texi and qemu-img.texi. Signed-off-by: Stefan Hajnoczi --- qemu-doc.texi | 8 qemu-img.texi | 8 2

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] smp: autodetect numbers of threads per core

2014-01-05 Thread Alexey Kardashevskiy
On 12/25/2013 01:42 AM, Alexey Kardashevskiy wrote: > On 12/17/2013 05:37 PM, Alexey Kardashevskiy wrote: >> On 12/04/2013 04:34 PM, Alexey Kardashevskiy wrote: >>> On 11/16/2013 03:58 AM, Alexey Kardashevskiy wrote: On 16.11.2013 0:15, Alexander Graf wrote: > > > Am 15.11.2013 um

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Peter Crosthwaite
On Mon, Jan 6, 2014 at 2:22 PM, Li Guang wrote: > Peter Crosthwaite wrote: >> >> On Mon, Jan 6, 2014 at 1:55 PM, Li Guang wrote: >> >>> >>> Li Guang wrote: >>> Paolo Bonzini wrote: > > Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: > No, please use

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2014-01-05 Thread Kewei Yu
2014/1/3 Paolo Bonzini > Il 02/01/2014 15:45, Andreas Färber ha scritto: > >>> >> v2: Consolidate VNC macro's #ifdef'ery to one central point > (tests/libqtest.c). > >> > > >> > What happens if qtest instead uses "-display none"? > > It does use that, since the commit I pointed to in v1. :) > >

Re: [Qemu-devel] qemu-iotests: test 051 fails

2014-01-05 Thread Stefan Hajnoczi
On Sat, Jan 04, 2014 at 07:39:08PM +0100, Peter Lieven wrote: > ~/git/qemu/tests/qemu-iotests$ ./check -qcow2 51 > QEMU -- ./qemu > QEMU_IMG -- ./qemu-img > QEMU_IO -- ./qemu-io > QEMU_NBD -- /usr/local/bin/qemu-nbd > IMGFMT-- qcow2 (compat=1.1) > IMGPROTO -- f

[Qemu-devel] [PATCH V9 1/8] snapshot: add parameter *errp in snapshot create

2014-01-05 Thread Wenchao Xia
The return value is only used for error report before this patch, so change the function protype to return void. Signed-off-by: Wenchao Xia --- block/qcow2-snapshot.c| 30 +- block/qcow2.h |4 +++- block/rbd.c | 19 ++-

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 1:55 PM, Li Guang wrote: Li Guang wrote: Paolo Bonzini wrote: Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: No, please use "realize" and avoid init. This way you can use an Error* to report the error. Also, th

Re: [Qemu-devel] [PATCH] sheepdog: fix clone operation by 'qemu-img create -b'

2014-01-05 Thread Stefan Hajnoczi
On Fri, Jan 03, 2014 at 08:13:12PM +0800, Liu Yuan wrote: > We should pass base_inode->vdi_id to base_vdi_id of SheepdogVdiReq so that > sheep > can create a clone instead a fresh volume. > > This fixes following command: > > qemu-create -b sheepdog:base sheepdog:clone > > so users can boot she

[Qemu-devel] [PATCH V9 3/8] util: add error_append()

2014-01-05 Thread Wenchao Xia
Some old code in error_set() is factored out, so this function can call it. Signed-off-by: Wenchao Xia --- include/qapi/error.h |6 ++ util/error.c | 44 +++- 2 files changed, 45 insertions(+), 5 deletions(-) diff --git a/include/qapi/er

[Qemu-devel] [PATCH V9 0/8] qcow2: rollback the modification on fail in snapshot creation

2014-01-05 Thread Wenchao Xia
V2: 1: all fail case will goto fail section. 2: add the goto code. v3: Address Stefan's comments: 2: don't goto fail after allocation failure. 3: use sn->l1size correctly in qcow2_free_cluster(). 4-7: add test case to verify the error paths. Other: 1: new patch fix a existing bug,

Re: [Qemu-devel] [PATCH 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-05 Thread Peter Crosthwaite
On Mon, Jan 6, 2014 at 1:27 PM, Stefan Hajnoczi wrote: > On Thu, Jan 02, 2014 at 08:25:10PM +1000, Peter Crosthwaite wrote: >> Hi Beniamino, >> >> On Thu, Jan 2, 2014 at 7:18 PM, Beniamino Galvani >> wrote: >> > This patch adds support for the Fast Ethernet MAC found on Allwinner >> > SoCs, toge

[Qemu-devel] [PATCH V9 4/8] qcow2: return int for qcow2_free_clusters()

2014-01-05 Thread Wenchao Xia
The return value can help caller check whether error happens, and it does not need to have *errp since the return value already tips what happend. Signed-off-by: Wenchao Xia --- block/qcow2-refcount.c |8 +--- block/qcow2.h |6 +++--- 2 files changed, 8 insertions(+), 6 dele

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Peter Crosthwaite
On Mon, Jan 6, 2014 at 1:55 PM, Li Guang wrote: > Li Guang wrote: >> >> Paolo Bonzini wrote: >>> >>> Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: >> >> No, please use "realize" and avoid init. This way you can use an >> Error* >> to report the error. >> >> Also, the

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Li Guang wrote: Paolo Bonzini wrote: Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: No, please use "realize" and avoid init. This way you can use an Error* to report the error. Also, the actual load_image_targphys call probably should be done in a reset handler, not at realize time.

[Qemu-devel] [PATCH V9 8/8] qemu-iotests: add test for qcow2 snapshot

2014-01-05 Thread Wenchao Xia
This test will focus on the low level procedure of qcow2 snapshot operations, now it covers only the create operation. Overlap error paths are not checked since no good way to trigger those errors. Signed-off-by: Wenchao Xia --- tests/qemu-iotests/075 | 216 +++

[Qemu-devel] [PATCH V9 7/8] blkdebug: add debug events for snapshot

2014-01-05 Thread Wenchao Xia
Some code in qcow2-snapshot.c directly accesses bs->file, so in those places errors can't be injected by other events. Since the code in qcow2-snapshot.c is similar to the other qcow2 internal code (in regards to e.g. the L1 table), add some debug events. Signed-off-by: Wenchao Xia Reviewed-by: M

[Qemu-devel] [PATCH V9 6/8] qcow2: rollback on fail in qcow2_snapshot_create()

2014-01-05 Thread Wenchao Xia
A new variable *err_rollback is added to detect sub function's rollback failure. If one step in rollback procedure fails, following steps will be skipped, and the error message will be appended to errp. Signed-off-by: Wenchao Xia --- block/qcow2-snapshot.c | 37

[Qemu-devel] [PATCH V9 2/8] qcow2: add error message in qcow2_write_snapshots()

2014-01-05 Thread Wenchao Xia
The function still returns int since qcow2_snapshot_delete() will return the number. Signed-off-by: Wenchao Xia --- block/qcow2-snapshot.c | 43 +-- 1 files changed, 37 insertions(+), 6 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snap

[Qemu-devel] [PATCH V9 5/8] qcow2: full rollback on fail in qcow2_write_snapshots()

2014-01-05 Thread Wenchao Xia
Header restore step is added, and old code section "fail" is renamed to "dealloc_sn_table" to tip better, now "fail" section does not rollback anything on disk. When one step in rollback fails, following steps will be skipped, to make sure no dangling pointer is left. A new parameter "*errp_rollba

Re: [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-05 Thread Erik de Castro Lopo
Hi André, This looks ok, except that scripts/checkpatch.pl says: WARNING: braces {} are necessary for all arms of this statement #36: FILE: linux-user/syscall.c:2254: +if (get_user_ual(sockfd, vptr) [...] total: 0 errors, 1 warnings, 30 lines checked Fix that and

Re: [Qemu-devel] [PATCH 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-05 Thread Stefan Hajnoczi
On Thu, Jan 02, 2014 at 08:25:10PM +1000, Peter Crosthwaite wrote: > Hi Beniamino, > > On Thu, Jan 2, 2014 at 7:18 PM, Beniamino Galvani wrote: > > This patch adds support for the Fast Ethernet MAC found on Allwinner > > SoCs, together with a basic emulation of Realtek RTL8201CP PHY. > > > > Mor

Re: [Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
OK, I'm viewing the code about the two parameters. Thanks for your reply. Faithfully yours Kewei Yu 2014/1/6 Peter Crosthwaite > Hi Kewei, > > On Mon, Jan 6, 2014 at 12:22 PM, Kewei Yu wrote: > > Ping. > > > > Paolo's latest query on the other thread is still an open question. > Does simply s

Re: [Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Andreas Färber
Am 06.01.2014 04:13, schrieb Peter Crosthwaite: > Hi Kewei, > > On Mon, Jan 6, 2014 at 12:22 PM, Kewei Yu wrote: >> Ping. >> > > Paolo's latest query on the other thread is still an open question. > Does simply substituting "-display none" for "-vnc none" resolve the > problem? If not why not?

Re: [Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Peter Crosthwaite
Hi Kewei, On Mon, Jan 6, 2014 at 12:22 PM, Kewei Yu wrote: > Ping. > Paolo's latest query on the other thread is still an open question. Does simply substituting "-display none" for "-vnc none" resolve the problem? If not why not? Regards, Peter > Faithfully yours > Kewei Yu > > > 2014/1/2 Kew

Re: [Qemu-devel] TRIM/DISCARD/UNMAP support on qemu-nbd

2014-01-05 Thread Stefan Hajnoczi
On Mon, Dec 30, 2013 at 07:58:29PM +0800, Teng-Feng Yang wrote: > I have been studying QCOW2 file format for a couple of days, and I am > a little bit confused about whether QCOW2 supports UNMAP or not. Discard is an area that has seen a lot of development activity over the past year or two. That

Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2014-01-05 Thread Stefan Hajnoczi
On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote: > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc > index 28ba0d9..af66bbd 100644 > --- a/tests/qemu-iotests/common.rc > +++ b/tests/qemu-iotests/common.rc > @@ -189,7 +189,11 @@ _cleanup_test_img() >

Re: [Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
Ping. Faithfully yours Kewei Yu 2014/1/2 Kewei Yu > When we disable vnc from "./configure", QEMU can't use the vnc option. > So qtest can't use the "vnc -none ", otherwise "make check" fails. > > Signed-off-by: Kewei Yu > --- > v2: Consolidate VNC macro's #ifdef'ery to one central point > (t

Re: [Qemu-devel] Communication between Windows 7 host and Linux guest

2014-01-05 Thread Stefan Hajnoczi
On Sun, Dec 22, 2013 at 07:15:18PM +, Gripon Sébastien wrote: > I have the need to communicate efficiently between Windows 7 host and linux > guest. I tried first to use an IP socket communication using TAP driver on > Windows. Unfortunately, we reach a maximum of 4 Mbits/s where I would need

Re: [Qemu-devel] [PATCH v2 0/3] gluster: conversion to coroutines and supporting write_zeroes

2014-01-05 Thread Stefan Hajnoczi
On Sat, Dec 21, 2013 at 02:51:23PM +0530, Bharata B Rao wrote: > Hi, > > This series is about converting all the bdrv_aio* implementations in gluster > driver to coroutine based implementations. Read, write, flush and discard > routines are converted. > > This also adds support for .bdrv_co_write

Re: [Qemu-devel] [PATCH V5 07/10] qapi: convert BlockdevOptions to use enum discriminator

2014-01-05 Thread Wenchao Xia
于 2013/12/20 13:23, Wenchao Xia 写道: > After this patch, hidden enum type BlockdevOptionsKind will not > be generated, and other API can use enum BlockdevDriver. > > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake > --- > qapi-schema.json | 14 +- > 1 files changed, 13 inser

Re: [Qemu-devel] [PATCH V8 3/8] util: add error_append()

2014-01-05 Thread Wenchao Xia
于 2014/1/3 23:32, Peter Crosthwaite 写道: On Fri, Jan 3, 2014 at 1:08 PM, Wenchao Xia wrote: Signed-off-by: Wenchao Xia --- include/qapi/error.h |6 ++ util/error.c | 21 + 2 files changed, 27 insertions(+), 0 deletions(-) diff --git a/include/qapi/erro

[Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-05 Thread André Hentschel
From: André Hentschel Cc: Riku Voipio Signed-off-by: André Hentschel --- See https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/net.h for the values. Not entirely sure how to implement recvmmsg and sendmmsg... linux-user/syscall.c | 15 +

[Qemu-devel] [PATCH] qemu-iotests: Remove duplicated error message line in 051.out

2014-01-05 Thread Fam Zheng
Since 75884af (virtio-blk: Convert to QOM realize), the duplication of error message is gone. Fix the test reference output to match this. Reported-by: Peter Lieven Signed-off-by: Fam Zheng --- tests/qemu-iotests/051.out | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemu-iotests/051.

Re: [Qemu-devel] qemu-iotests: test 051 fails

2014-01-05 Thread Fam Zheng
On 2014年01月05日 02:39, Peter Lieven wrote: ~/git/qemu/tests/qemu-iotests$ ./check -qcow2 51 QEMU -- ./qemu QEMU_IMG -- ./qemu-img QEMU_IO -- ./qemu-io QEMU_NBD -- /usr/local/bin/qemu-nbd IMGFMT-- qcow2 (compat=1.1) IMGPROTO -- file PLATFORM -- Linux/x86_6

Re: [Qemu-devel] [PATCHv5] block: add native support for NFS

2014-01-05 Thread Stefan Hajnoczi
On Fri, Jan 03, 2014 at 12:28:31PM +0100, Peter Lieven wrote: > On 03.01.2014 11:37, Stefan Hajnoczi wrote: > >Looks good. In order to merge this new block driver qemu-iotests > >support for nfs is required. That way the block driver can be exercised > >and checked for regressions (I guess you pe

Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader

2014-01-05 Thread Li Guang
Paolo Bonzini wrote: Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: No, please use "realize" and avoid init. This way you can use an Error* to report the error. Also, the actual load_image_targphys call probably should be done in a reset handler, not at realize time. Ok I t

[Qemu-devel] [PATCH 1/2] ppc: tcg: add nap insn support

2014-01-05 Thread Liu Ping Fan
Add the emulation of insn "nap" for hypervisor Signed-off-by: Liu Ping Fan --- target-ppc/excp_helper.c | 4 target-ppc/helper.h | 1 + target-ppc/translate.c | 6 ++ 3 files changed, 11 insertions(+) diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c index c959460

[Qemu-devel] [PATCH 2/2] ppc: tcg: implement helper_nap

2014-01-05 Thread Liu Ping Fan
When nap, clear no persistent register as ISA spec says. Signed-off-by: Liu Ping Fan --- target-ppc/excp_helper.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c index a9712bc..5dbb166 100644 --- a/target-ppc/excp_helper.c +

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-05 Thread Li Guang
Hi, please use prefix AwA10 for names instead of Aw, also PATCH 1/2. Thanks for your effort on this! Beniamino Galvani wrote: Signed-off-by: Beniamino Galvani --- hw/arm/allwinner-a10.c | 20 include/hw/arm/allwinner-a10.h |4 2 files changed, 24 inser

[Qemu-devel] [Bug 1265998] Re: vfio-pci passed Radeon 7870XT is unstable on first boot of a Windows 8.1 guest

2014-01-05 Thread Michał Węgrzynek
It seems everything works ok without hugepages (without -mem-prealloc and -mem-path qemu parameters and with transparent_hugepage, hugepagesz, hugepages, default_hugepagesz removed form kernel command line). Setting transparent_hugepage=never hugepagesz=2M hugepages=3000 default_hugepagesz=2M at t

[Qemu-devel] [PATCHv3 4/6] ui/vnc: optimize clearing in find_and_clear_dirty_height()

2014-01-05 Thread Peter Lieven
The following artifical test (just the bitmap operation part) running vnc_update_client 65536 times on a 2560x2048 surface illustrates the performance difference: All bits clean - vnc_update_client_new: 0.07 secs vnc_update_client_new2: 0.07 secs vnc_update_client

[Qemu-devel] [PATCHv3 6/6] ui/vnc: disable adaptive update calculations if not needed

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- ui/vnc.c |9 + 1 file changed, 9 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 805c47a..cdb1f4f 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3171,7 +3171,9 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) a

[Qemu-devel] [PATCHv3 5/6] ui/vnc: optimize setting in vnc_dpy_update()

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- ui/vnc.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 980df34..805c47a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -430,7 +430,6 @@ static int vnc_refresh_server_surface(VncDisplay *vd); static void vnc_dpy_upd

[Qemu-devel] [PATCHv3 2/6] ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT

2014-01-05 Thread Peter Lieven
this allows for setting VNC_DIRTY_PIXELS_PER_BIT to different values than 16 if desired. Signed-off-by: Peter Lieven --- ui/vnc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 1ca6021..1d2aa1a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2697,7 +269

[Qemu-devel] [PATCHv3 3/6] ui/vnc: optimize dirty bitmap tracking

2014-01-05 Thread Peter Lieven
vnc_update_client currently scans the dirty bitmap of each client bitwise which is a very costly operation if only few bits are dirty. vnc_refresh_server_surface does almost the same. this patch optimizes both by utilizing the heavily optimized function find_next_bit to find the offset of the next

[Qemu-devel] [PATCHv3 1/6] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- ui/vnc.c | 61 ++--- ui/vnc.h |6 +- 2 files changed, 43 insertions(+), 24 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5601cc3..1ca6021 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -442,17 +442,1

[Qemu-devel] [PATCHv3 0/6] ui/vnc: update optimizations

2014-01-05 Thread Peter Lieven
this series includes several optimizations for the ui/vnc guest to server and server to client update cycles. comments/reviews appreciated. v2->v3: - fixed checkpatch warnings [Stefan] - fixed an old coding style violation [Stefan] v1->v2: - new patches 2,4,5 - patch3: added perfo

[Qemu-devel] [PATCHv2 17/18] qemu-iotests: blacklist test 020 for NFS protocol

2014-01-05 Thread Peter Lieven
reopening is currently not supported. Signed-off-by: Peter Lieven --- tests/qemu-iotests/020 |5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020 index 55358ac..2144463 100755 --- a/tests/qemu-iotests/020 +++ b/tests/qemu-iotests/020 @@ -46,

[Qemu-devel] [PATCHv2 07/18] qemu-iotests: fix test 019 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/019 | 30 ++ tests/qemu-iotests/019.out |4 ++-- 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/tests/qemu-iotests/019 b/tests/qemu-iotests/019 index d75d125..5638611 100755 --- a/tests/qemu

[Qemu-devel] [PATCHv2 15/18] qemu-iotests: fix test 046 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/046 |9 +++-- tests/qemu-iotests/046.out |2 +- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046 index 2d44bbb..2a69a11 100755 --- a/tests/qemu-iotests/046 +++ b/tests/

[Qemu-devel] [PATCHv2 18/18] qemu-iotests: test 026 store blkdebug.cfg locally

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/026 | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/026 b/tests/qemu-iotests/026 index df2884b..fe268e4 100755 --- a/tests/qemu-iotests/026 +++ b/tests/qemu-iotests/026 @@ -28,10 +28,

[Qemu-devel] [PATCHv2 09/18] qemu-iotests: fix test 024 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/024 | 12 +--- tests/qemu-iotests/024.out |4 ++-- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/tests/qemu-iotests/024 b/tests/qemu-iotests/024 index 9bf99e1..1db42df 100755 --- a/tests/qemu-iotests/024 +++ b/t

[Qemu-devel] [PATCHv2 10/18] qemu-iotests: fix test 028 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/028 |9 - tests/qemu-iotests/028.out |2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/028 b/tests/qemu-iotests/028 index a99e4fa..4c7644d 100755 --- a/tests/qemu-iotests/028 +++ b/tests/

[Qemu-devel] [PATCHv2 16/18] qemu-iotests: fix expected output of test 067

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/067.out |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/067.out b/tests/qemu-iotests/067.out index 8d271cc..79ed90f 100644 --- a/tests/qemu-iotests/067.out +++ b/tests/qemu-iotests/067.out @@ -12,

[Qemu-devel] [PATCHv2 14/18] qemu-iotests: fix test 043 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/043 | 24 ++-- tests/qemu-iotests/043.out | 12 ++-- 2 files changed, 16 insertions(+), 20 deletions(-) diff --git a/tests/qemu-iotests/043 b/tests/qemu-iotests/043 index b316b97..4c9e930 100755 --- a/tests/qe

[Qemu-devel] [PATCHv2 06/18] qemu-iotests: fix test 018 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/018 | 22 +- tests/qemu-iotests/018.out |4 ++-- 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/tests/qemu-iotests/018 b/tests/qemu-iotests/018 index aa9d3cb..fecf281 100755 --- a/tests/qemu-iotests

[Qemu-devel] [PATCHv2 12/18] qemu-iotests: fix test 037 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/037 |9 +++-- tests/qemu-iotests/037.out |2 +- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/037 b/tests/qemu-iotests/037 index cbe2647..d7c9cee 100755 --- a/tests/qemu-iotests/037 +++ b/tests/

[Qemu-devel] [PATCHv2 08/18] qemu-iotests: fix test 020 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/020 | 24 +++- tests/qemu-iotests/020.out |2 +- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020 index a42f32f..55358ac 100755 --- a/tests/qemu-iotests

[Qemu-devel] [PATCHv2 11/18] qemu-iotests: fix test 034 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/034 |7 +++ tests/qemu-iotests/034.out |2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/034 b/tests/qemu-iotests/034 index e911d6f..0f95379 100755 --- a/tests/qemu-iotests/034 +++ b/tests/qe

[Qemu-devel] [PATCHv2 13/18] qemu-iotests: fix test 038 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/038 |9 - tests/qemu-iotests/038.out |2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/038 b/tests/qemu-iotests/038 index cfaf00a..2b8318f 100755 --- a/tests/qemu-iotests/038 +++ b/tests/

[Qemu-devel] [PATCHv2 02/18] qemu-iotests: enable support for NFS protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/common| 22 +++--- tests/qemu-iotests/common.rc |3 +++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index 8b4e22c..e19673b 100644 --- a/tests/qemu

[Qemu-devel] [PATCHv2 05/18] qemu-iotests: fix tests 014 and 023 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/014|4 ++-- tests/qemu-iotests/014.out|2 +- tests/qemu-iotests/023| 11 +-- tests/qemu-iotests/023.out| 16 tests/qemu-iotests/common.pattern |7 +++ 5 files ch

[Qemu-devel] [PATCHv2 00/18] qemu-iotests: adjust tests to work with the NFS protocol

2014-01-05 Thread Peter Lieven
In order to proceed with the integration of the NFS protocol driver into qemu I was asked by Stefan to add integration for NFS into the qemu-iotests. Unfortunately, this became more complex than I had expected because most of the tests for non RAW formats only work with the file protocol because t

[Qemu-devel] [PATCHv2 04/18] qemu-iotests: fix test 013 to work with any protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/013 |9 - tests/qemu-iotests/013.out |2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/013 b/tests/qemu-iotests/013 index ea3cab9..0dbc934 100755 --- a/tests/qemu-iotests/013 +++ b/tests/

[Qemu-devel] [PATCHv2 03/18] qemu-iotests: enable test 016 and 025 to work with NFS protocol

2014-01-05 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/016 |2 +- tests/qemu-iotests/025 |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/016 b/tests/qemu-iotests/016 index b87a32b..7ea9e94 100755 --- a/tests/qemu-iotests/016 +++ b/tests/qemu-iotests/01

[Qemu-devel] [PATCHv2 01/18] qemu-iotests: change _supported_proto to file for various tests

2014-01-05 Thread Peter Lieven
all these tests do anything of the following and thus fail with any protocol other than file: - the tests use rm, cp or mv shell commands which only work on file - the tests use qcow2.py - the images construct new filenames (e.g. backing file names) and the logic is broken for anything else t

[Qemu-devel] [PATCH] qemu-ga: isa-serial support on Windows

2014-01-05 Thread Miki Mishael
Add support for isa-serial method for qemu-ga on Windows, Added -p command line parameter for serial port name specification, e.g. "-p COM15". Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- qga/channel-win32.c | 27 +-- qga/main.c | 14 ++

[Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-05 Thread Miki Mishael
Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- docs/qemupciserial.inf | 227 ++---

  1   2   >