[Qemu-devel] [PATCH v2 2/2] target-i386: Intel MPX

2013-12-03 Thread Liu, Jinsong
>From 256484fd75d4eb4d248e5e0f493f16182da59dc2 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Wed, 4 Dec 2013 16:56:49 +0800 Subject: [PATCH v2 2/2] target-i386: Intel MPX Add some MPX related definiation, and hardcode sizes and offsets of xsave features 3 and 4. It also add corresponding part

[Qemu-devel] [PATCH v2 1/2] target-i386: fix cpuid leaf 0x0d

2013-12-03 Thread Liu, Jinsong
>From cb3b12dd9873929b3a03214e3aa0ee5297e75119 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Tue, 3 Dec 2013 04:17:50 +0800 Subject: [PATCH v2 1/2] target-i386: fix cpuid leaf 0x0d Fix cpuid leaf 0x0d which incorrectly parsed eax and ebx. However, before this patch the CPUID worked fine -- th

[Qemu-devel] [PATCH v2 0/2]

2013-12-03 Thread Liu, Jinsong
Intel has released Memory Protection Extensions (MPX) recently. Please refer to http://download-software.intel.com/sites/default/files/319433-015.pdf These 2 patches are version2 to support Intel MPX at qemu side. Version 1: * Fix cpuid leaf 0x0d bug which incorrectly parsed eax and ebx; * Expose

Re: [Qemu-devel] [PATCH 2/2] target-i386: Intel MPX

2013-12-03 Thread Liu, Jinsong
Paolo Bonzini wrote: > Il 02/12/2013 17:42, Liu, Jinsong ha scritto: >> From 1a199d68265ffeb0234530f29d92a00a5edeff75 Mon Sep 17 00:00:00 >> 2001 From: Liu Jinsong >> Date: Tue, 3 Dec 2013 05:08:19 +0800 >> Subject: [PATCH 2/2] target-i386: Intel MPX >> >> Add some MPX related definiation, and ha

Re: [Qemu-devel] [PATCH] target-arm: add support for v8 AES instructions

2013-12-03 Thread Ard Biesheuvel
On 2 December 2013 17:06, Peter Maydell wrote: > On 6 November 2013 14:21, Ard Biesheuvel wrote: >> This adds support for the AESE/AESD/AESMC/AESIMC instructions that >> are available on some v8 implementations of Aarch32. >> >> Signed-off-by: Ard Biesheuvel > > Hi; thanks for this patch. I have

Re: [Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots.

2013-12-03 Thread Fam Zheng
On 2013年12月04日 14:34, Benoît Canet wrote: Le Wednesday 04 Dec 2013 à 14:12:19 (+0800), Fam Zheng a écrit : On 2013年12月04日 13:20, Benoît Canet wrote: Le Wednesday 04 Dec 2013 à 11:47:22 (+0800), Fam Zheng a écrit : On 2013年12月03日 21:26, Benoît Canet wrote: --- block.c | 64

[Qemu-devel] gpu and console chicken and egg

2013-12-03 Thread Dave Airlie
So I've hit a bit of a init ordering issue that I'm not sure how best to solve, Just some background: In order for the virt GPU and the UI layer (SDL or GTK etc) to interact properly over OpenGL use, I have created and OpenGL provider in the console, and the UI layer can register callbacks for a s

Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:42 PM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> This is a boiler-plate _nofail variant of qemu_opts_create. Remove and >> use error_abort in call sites. >> >> A null argument needs to be added for the id field in affected callsites >> due to inconsistency

[Qemu-devel] [PATCH arm-devs v2 12/14] net/cadence_gem: Fix register w1c logic

2013-12-03 Thread Peter Crosthwaite
This write-1-clear logic was incorrect. It was always clearing w1c bits regardless of whether the written value was 1 or not. i.e. it was implementing a write-anything-to-clear strategy. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/net/cadence_gem.c | 13 ++--- 1

[Qemu-devel] [PATCH arm-devs v2 05/14] net/cadence_gem: Prefetch rx descriptors ASAP

2013-12-03 Thread Peter Crosthwaite
The real hardware prefetches rx buffer descriptors ASAP and potentially throws relevant interrupts following the fetch even in the absence of a received packet. Reported-by: Deepika Dhamija Signed-off-by: Peter Crosthwaite --- changed since v1: Fixed function indentation (PMM review). hw/net/c

Re: [Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots.

2013-12-03 Thread Benoît Canet
Le Wednesday 04 Dec 2013 à 14:12:19 (+0800), Fam Zheng a écrit : > On 2013年12月04日 13:20, Benoît Canet wrote: > >Le Wednesday 04 Dec 2013 à 11:47:22 (+0800), Fam Zheng a écrit : > >>On 2013年12月03日 21:26, Benoît Canet wrote: > >>>--- > >>> block.c | 64 > >>> ++

Re: [Qemu-devel] [PATCH] eeprom93xx: fix coding style

2013-12-03 Thread Stefan Weil
Am 04.12.2013 07:27, schrieb Antony Pavlov: > scripts/checkpatch.pl reports about some style problems, > this commit fixes some of them: Reviewed-by: Stefan Weil

[Qemu-devel] [PATCH arm-devs v2 14/14] net/cadence_gem: Don't rx packets when no rx buffer available

2013-12-03 Thread Peter Crosthwaite
Return false from can_receive() when no valid buffer descriptor is available. Ensures against mass packet droppage in some applications. Signed-off-by: Peter Crosthwaite --- changed since v1: Typos ("dont" "cant" "recieve") (PMM review) hw/net/cadence_gem.c | 11 ++- 1 file changed, 10

[Qemu-devel] [PATCH arm-devs v2 08/14] net/cadence_gem: Implement SAR (de)activation

2013-12-03 Thread Peter Crosthwaite
The Specific address registers can be enabled or disabled by software. QEMU was assuming they were always enabled. Implement the disable/enable feature. SARs are disabled by writing to the lower half register. They are re-enabled by then writing the upper half. Reported-by: Deepika Dhamija Signed

[Qemu-devel] [PATCH arm-devs v2 10/14] net/cadence_gem: Fix rx multi-fragment packets

2013-12-03 Thread Peter Crosthwaite
Bytes_to_copy was being updated before its final use where it advances the rx buffer pointer. This was causing total mayhem, where packet data for any subsequent fragments was being fetched from the wrong place. Reported-by: Deepika Dhamija Signed-off-by: Peter Crosthwaite Reviewed-by: Peter May

[Qemu-devel] [PATCH arm-devs v2 09/14] net/cadence_gem: Add missing VMSTATE_END_OF_LIST

2013-12-03 Thread Peter Crosthwaite
Signed-off-by: Peter Crosthwaite --- hw/net/cadence_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 07e6fe7..8cfad04 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c @@ -1246,6 +1246,7 @@ static const VMStateDescription vmst

Re: [Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots.

2013-12-03 Thread Fam Zheng
On 2013年12月04日 13:20, Benoît Canet wrote: Le Wednesday 04 Dec 2013 à 11:47:22 (+0800), Fam Zheng a écrit : On 2013年12月03日 21:26, Benoît Canet wrote: --- block.c | 64 +-- block/blkverify.c | 2 +- include/block/block.h

[Qemu-devel] [PATCH arm-devs v2 13/14] net/cadence_gem: Improve can_receive debug printfery

2013-12-03 Thread Peter Crosthwaite
Currently this just floods indicating that can_receive has been called by the net framework. Instead, save the result of the most recent can_receive callback as state and only print a message if the result changes (indicating some sort of actual state change in GEM). Make said debug message more me

[Qemu-devel] [PATCH arm-devs v2 11/14] net/cadence_gem: Fix small packet FCS stripping

2013-12-03 Thread Peter Crosthwaite
The minimum packet size is 64, however this is before FCS stripping occurs. So when FCS stripping the minimum packet size is 60. Fix. Reported-by: Deepika Dhamija Signed-off-by: Peter Crosthwaite --- changed since v1: Setup bytes_to_copy before minimum size padding. hw/net/cadence_gem.c | 13 +

[Qemu-devel] [PATCH arm-devs v2 07/14] net/cadence_gem: Implement SAR match bit in rx desc

2013-12-03 Thread Peter Crosthwaite
Bit 27 of the RX buffer desc word 1 should be set when the packet was accepted due to specific address register match. Implement. This feature is absent from the Xilinx documentation (UG585) but the behaviour is tested as accurate on real hardware. Reported-by: Deepika Dhamija Signed-off-by: Pet

[Qemu-devel] [PATCH arm-devs v2 06/14] net/cadence_gem: Implement RX descriptor match mode flags

2013-12-03 Thread Peter Crosthwaite
The various Rx packet address matching mode flags were not being set in the rx descriptor. Implement. Reported-by: Deepika Dhamija Signed-off-by: Peter Crosthwaite --- changed since v1: s/PROM_ACCEPT/PROMISCUOUS_ACCEPT to be more self documenting Add full return code comment on accept function (

[Qemu-devel] [PATCH arm-devs v2 04/14] net/cadence_gem: simplify rx buf descriptor walking

2013-12-03 Thread Peter Crosthwaite
There was a replication of the rx descriptor address walking logic. Reorder the flow control to remove. This refactoring also obsoletes the local variables packet_desc_addr and last_desc_addr. Signed-off-by: Peter Crosthwaite --- hw/net/cadence_gem.c | 37 +

[Qemu-devel] [PATCH arm-devs v2 03/14] net/cadence_gem: Don't assert against 0 buffer address

2013-12-03 Thread Peter Crosthwaite
This has no real hardware analog and asserting correctness of DMA addresses is not a perhiperal level problem. Delete. Signed-off-by: Peter Crosthwaite --- changed since v1: Delete the check completely hw/net/cadence_gem.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/net/caden

[Qemu-devel] [PATCH arm-devs v2 02/14] net/cadence_gem: Update DMA rx descriptors as we process them

2013-12-03 Thread Peter Crosthwaite
From: "Edgar E. Iglesias" We were updating the ownership bit of all descriptors if packets get split and written through several descriptors. Signed-off-by: Edgar E. Iglesias Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/net/cadence_gem.c | 33 --

[Qemu-devel] [PATCH arm-devs v2 01/14] net/cadence_gem: Implement mac level loopback mode

2013-12-03 Thread Peter Crosthwaite
Cadence GEM has a MAC level loopback mode. Implement. Use the same basic operation as the already implemented PHY loopback. Reported-by: Deepika Dhamija Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/net/cadence_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PATCH arm-devs v2 00/14] Cadence GEM Bugfixes and missing features

2013-12-03 Thread Peter Crosthwaite
Hi Peter, This series updated cadence GEM (ethernet in Zynq) with a number of bugfixes and enhancements. Most of this has come out of some stress testing we have done internally. I have also testing briefly using mainline Linux GEM driver. root@zynq:~# wget http://people.debian.org/~aurel32/qemu

Re: [Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during object_class_foreach

2013-12-03 Thread Peter Crosthwaite
On Wed, Dec 4, 2013 at 1:42 AM, Paolo Bonzini wrote: > From: Hervé Poussineau > > We should not modify the type hash table while it is being iterated on. > Assert that it does not happen. > > Signed-off-by: Hervé Poussineau > Signed-off-by: Paolo Bonzini > --- > qom/object.c | 4 > 1 file

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

2013-12-03 Thread Alexey Kardashevskiy
On 12/04/2013 01:47 AM, Eduardo Habkost wrote: > On Tue, Dec 03, 2013 at 02:30:48PM +0100, Andreas Färber wrote: >> Am 03.12.2013 00:03, schrieb Alexey Kardashevskiy: >>> On 12/03/2013 09:09 AM, Andreas Färber wrote: Am 02.12.2013 18:06, schrieb Michael Tokarev: > 25.11.2013 07:39, Alexey

Re: [Qemu-devel] [PATCH arm-devs v1 10/13] net/cadence_gem: Fix small packet FCS stripping

2013-12-03 Thread Peter Crosthwaite
On Mon, Dec 2, 2013 at 10:26 PM, Peter Maydell wrote: > On 2 December 2013 07:14, Peter Crosthwaite > wrote: >> The minimum packet size is 64, however this is before FCS stripping >> occurs. So when FCS stripping the minimum packet size is 60. Fix. >> >> Reported-by: Deepika Dhamija >> Signed-of

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] smp: autodetect numbers of threads per core

2013-12-03 Thread Alexey Kardashevskiy
On 11/16/2013 03:58 AM, Alexey Kardashevskiy wrote: > On 16.11.2013 0:15, Alexander Graf wrote: >> >> >> Am 15.11.2013 um 00:12 schrieb Alexey Kardashevskiy : >> >>> At the moment only a whole CPU core can be assigned to a KVM. Since >>> POWER7/8 support several threads per core, we want all thread

Re: [Qemu-devel] [PATCH v6 5/6] qemu-iotests: Clean up spaces in usage output

2013-12-03 Thread Benoît Canet
Le Wednesday 04 Dec 2013 à 09:07:02 (+0800), Fam Zheng a écrit : > Whitespace changes to align columns. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/common | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/tests/qemu-iotests/common b/tests/qemu

Re: [Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots.

2013-12-03 Thread Benoît Canet
Le Wednesday 04 Dec 2013 à 11:35:51 (+0800), Fam Zheng a écrit : > On 2013年12月03日 21:26, Benoît Canet wrote: > >--- > > block.c | 64 > > +-- > > block/blkverify.c | 2 +- > > include/block/block.h | 16 +--- > > i

Re: [Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots.

2013-12-03 Thread Benoît Canet
Le Wednesday 04 Dec 2013 à 11:47:22 (+0800), Fam Zheng a écrit : > On 2013年12月03日 21:26, Benoît Canet wrote: > >--- > > block.c | 64 > > +-- > > block/blkverify.c | 2 +- > > include/block/block.h | 16 +--- > > i

Re: [Qemu-devel] [RFC V3 7/7] qmp: Allow to take external snapshots on bs graphs node.

2013-12-03 Thread Benoît Canet
Le Wednesday 04 Dec 2013 à 11:51:26 (+0800), Fam Zheng a écrit : > On 2013年12月03日 21:26, Benoît Canet wrote: > >Signed-off-by: Benoit Canet > >--- > > blockdev.c | 49 + > > hmp.c| 4 +++- > > qapi-schema.json | 13 ++--- >

[Qemu-devel] [PATCH 0/3] scsi: eject fixed

2013-12-03 Thread Alexey Kardashevskiy
The initial problem was if the user ejects a ISO/DVD mounted in Fedora19, the block device went into weird state when QEMU's monitor reported that it is locked, has medium but tray open (some debug output is below). Please comment. Thanks! [root@localhost ~]# mount /dev/cdrom /mnt mount: /dev/sr

[Qemu-devel] [PATCH 2/3] scsi-disk: check for meduim on ALLOW_MEDIUM_REMOVAL

2013-12-03 Thread Alexey Kardashevskiy
This prevents the guest from preventing DVD medium removal when there is no medium. Without this, if the user has ejected a DVD, it is possible to have a block device with an open tray, no media but locked. Signed-off-by: Alexey Kardashevskiy --- hw/scsi/scsi-disk.c | 1 - 1 file changed, 1 del

[Qemu-devel] [PATCH 3/3] scsi debug: print command name in debug

2013-12-03 Thread Alexey Kardashevskiy
This makes scsi_command_name() public. This makes use of scsi_command_name() in debug output for scsi-disk and spapr-vscsi host bus adapter. Signed-off-by: Alexey Kardashevskiy --- hw/scsi/scsi-bus.c| 5 - hw/scsi/scsi-disk.c | 3 ++- hw/scsi/spapr_vscsi.c | 5 +++-- include/block/scs

[Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP

2013-12-03 Thread Alexey Kardashevskiy
Normally the user is expected to eject DVD if it is not locked by the guest. eject_device() makes few checks and calls bdrv_close() if DVD is not in use. However it is still possible to eject DVD even if it is in use. For that, QEMU sets "eject requested" flag, the guest reads it, issues ALLOW_MED

Re: [Qemu-devel] [PATCH arm-devs v1 13/13] net/cadence_gem: Dont rx packets when no rx buffer available

2013-12-03 Thread Peter Crosthwaite
On Mon, Dec 2, 2013 at 10:31 PM, Peter Maydell wrote: > On 2 December 2013 07:16, Peter Crosthwaite > wrote: > > Missing apostrophe in Subject. > >> Return false from can_recieve() when no valid buffer descriptor is > > "can_receive" > >> available. Ensures against mass packet droppage in some ap

Re: [Qemu-devel] [PATCH arm-devs v1 12/13] net/cadence_gem: Improve can_receive debug printfery

2013-12-03 Thread Peter Crosthwaite
On Mon, Dec 2, 2013 at 10:30 PM, Peter Maydell wrote: > On 2 December 2013 07:15, Peter Crosthwaite > wrote: >> Currently this just floods indicating that can_receive has been called >> by the net framework. Instead, save the result of the most recent >> can_recieve callback as state and only pri

Re: [Qemu-devel] [PATCH arm-devs v1 05/13] net/cadence_gem: Prefetch rx descriptors ASAP

2013-12-03 Thread Peter Crosthwaite
On Mon, Dec 2, 2013 at 10:14 PM, Peter Maydell wrote: > On 2 December 2013 07:11, Peter Crosthwaite > wrote: >> The real hardware prefetches rx buffer descriptors ASAP and >> potentially throws relevant interrupts following the fetch >> even in the absence of a recieved packet. >> >> Reported-by:

Re: [Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots.

2013-12-03 Thread Fam Zheng
On 2013年12月03日 21:26, Benoît Canet wrote: --- block.c | 64 +-- block/blkverify.c | 2 +- include/block/block.h | 16 +--- include/block/block_int.h | 9 --- 4 files changed, 75 insertions(+), 16 deletio

Re: [Qemu-devel] [RFC V3 7/7] qmp: Allow to take external snapshots on bs graphs node.

2013-12-03 Thread Fam Zheng
On 2013年12月03日 21:26, Benoît Canet wrote: Signed-off-by: Benoit Canet --- blockdev.c | 49 + hmp.c| 4 +++- qapi-schema.json | 13 ++--- qmp-commands.hx | 11 ++- 4 files changed, 64 insertions(+), 13 delet

Re: [Qemu-devel] [PATCH arm-devs v1 08/13] net/cadence_gem: Implement SAR (de)activation

2013-12-03 Thread Peter Crosthwaite
On Mon, Dec 2, 2013 at 10:23 PM, Peter Maydell wrote: > On 2 December 2013 07:13, Peter Crosthwaite > wrote: >> The Specific address registers can be enabled or disabled by software. >> QEMU was assuming they where always enabled. Implement the > > "were" > Fixed >> disable/enable feature. SARs

Re: [Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots.

2013-12-03 Thread Fam Zheng
On 2013年12月03日 21:26, Benoît Canet wrote: --- block.c | 64 +-- block/blkverify.c | 2 +- include/block/block.h | 16 +--- include/block/block_int.h | 9 --- 4 files changed, 75 insertions(+), 16 deletio

Re: [Qemu-devel] [PATCH arm-devs v1 06/13] net/cadence_gem: Implement RX descriptor match mode flags

2013-12-03 Thread Peter Crosthwaite
On Mon, Dec 2, 2013 at 10:19 PM, Peter Maydell wrote: > On 2 December 2013 07:12, Peter Crosthwaite > wrote: >> The various Rx packet address matching mode flags were not being set in >> the rx descriptor. Implement. > >> -#define GEM_RX_REJECT 1 >> -#define GEM_RX_ACCEPT 0 >> +#define GEM_RX_R

Re: [Qemu-devel] [PATCH arm-devs v1 04/13] net/cadence_gem: simplify rx buf descriptor walking

2013-12-03 Thread Peter Crosthwaite
On Mon, Dec 2, 2013 at 10:12 PM, Peter Maydell wrote: > On 2 December 2013 07:11, Peter Crosthwaite > wrote: >> There was a replication of the rx descriptor address walking logic. >> Reorder the flow control to remove. This refactoring also obsoletes >> the local variables packet_desc_addr and la

Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph.

2013-12-03 Thread Fam Zheng
On 2013年12月03日 21:26, Benoît Canet wrote: --- blockdev.c | 8 qapi-schema.json | 32 2 files changed, 40 insertions(+) diff --git a/blockdev.c b/blockdev.c index a474bb5..824e718 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1940,6 +1940,14 @@

Re: [Qemu-devel] [PATCH V6 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2013-12-03 Thread Wenchao Xia
于 2013/12/3 21:45, Stefan Hajnoczi 写道: On Fri, Nov 22, 2013 at 12:27:09PM +0800, Wenchao Xia wrote: +nbd_snapshot_port=10850 +nbd_snapshot_img="nbd:127.0.0.1:$nbd_snapshot_port" + +_export_nbd_snapshot() +{ +$QEMU_NBD -v -t -b 127.0.0.1 -p $nbd_snapshot_port "$TEST_IMG" -l $1 & Please use

Re: [Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for snapshot in convert

2013-12-03 Thread Wenchao Xia
于 2013/12/3 19:02, Stefan Hajnoczi 写道: On Fri, Nov 22, 2013 at 12:27:10PM +0800, Wenchao Xia wrote: diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index da1d965..9a8153b 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img-cmds.hx @@ -34,7 +34,7 @@ STEXI ETEXI DEF("convert", img_convert, -"co

Re: [Qemu-devel] [RFC qom-cpu v4 10/10] cpus: reclaim allocated vCPU objects

2013-12-03 Thread Chen Fan
On Thu, 2013-11-28 at 15:48 +0100, Igor Mammedov wrote: > On Wed, 9 Oct 2013 17:43:18 +0800 > Chen Fan wrote: > > > After ACPI get a signal to eject a vCPU, then it will notify > > the vCPU thread to exit in KVM, and the vCPU must be removed from CPU list, > > before the vCPU really removed, ther

Re: [Qemu-devel] [RFC qom-cpu v4 00/10] i386: add cpu hot remove support

2013-12-03 Thread Chen Fan
On Thu, 2013-11-28 at 15:41 +0100, Igor Mammedov wrote: > On Wed, 9 Oct 2013 17:43:08 +0800 > Chen Fan wrote: > > > Via implementing ACPI standard methods _EJ0 in bios, after Guest OS hot > > remove > > one vCPU, it is able to send a signal to QEMU, then QEMU could notify > > the assigned vCPU o

Re: [Qemu-devel] [PATCH 2/5] hw/timer: add allwinner a10 timer

2013-12-03 Thread Li Guang
Peter Crosthwaite wrote: On Tue, Dec 3, 2013 at 7:11 PM, liguang wrote: Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |2 + hw/timer/allwinner-a10_pit.c | 253 ++ Mix of _

Re: [Qemu-devel] [PATCH v4] cpu: add suboptions support

2013-12-03 Thread Alexey Kardashevskiy
On 12/03/2013 10:09 PM, Igor Mammedov wrote: > On Tue, 3 Dec 2013 14:42:48 +1100 > Alexey Kardashevskiy wrote: > >> This adds suboptions support for -cpu. This keeps @cpu_model in order not >> to break the existing architectures/machines. >> >> Cc: Andreas Färber >> Signed-off-by: Alexey Kardas

[Qemu-devel] [PATCH v6 6/6] qemu-iotests: Split qcow2 only cases in 048

2013-12-03 Thread Fam Zheng
Format "raw" doesn't always work on certain file systems (e.g. tmpfs). Use qcow2 to make the allocation status explicit and split into a new case. Signed-off-by: Fam Zheng Reviewed-by: Wenchao Xia --- tests/qemu-iotests/048 | 27 --- tests/qemu-iotests/048.out | 16 - te

[Qemu-devel] [PATCH v6 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback"

2013-12-03 Thread Fam Zheng
This series adds cache mode option in the iotests framework. Test cases are updated to make use of cache mode and mask supported modes. v6: [05] Recover disappeared two lines. (Benoît) Added Wenchao's reviewed-by lines to other patches. v5: Fix help test for "-c mode". (Wenchao) v4: Address

Re: [Qemu-devel] [PATCH v3] block: Close backing file early in bdrv_img_create

2013-12-03 Thread Wenchao Xia
Reviewed-by: Wenchao Xia

Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0

2013-12-03 Thread Michael Roth
Quoting Peter Maydell (2013-12-03 18:38:54) > On 4 December 2013 00:33, Michael Roth wrote: > > In any case, ping? :) > > Who are you directing that ping at? This patch is commit 45d285abd7028 in > master (Paolo put it in his pull request for 1.7, and kindly humoured my > laziness by adding the C

[Qemu-devel] [PATCH v6 1/6] qemu-iotests: Add "-c " option

2013-12-03 Thread Fam Zheng
The option sets cache mode used in the tests. "-nocache" is changed to an alias to "-c none", and internally passes "-t none" to qemu-io. Python scripts will make use of option this in the next commit. Signed-off-by: Fam Zheng Reviewed-by: Wenchao Xia --- tests/qemu-iotests/check | 2 +- tes

Re: [Qemu-devel] [Bug 1257099] [NEW] QEMU fails to build on CentOS 5.10 with relocation R_X86_64_PC32 error

2013-12-03 Thread Don Slutz
On 12/03/13 12:15, Paolo Bonzini wrote: > Il 03/12/2013 14:25, Stefano Stabellini ha scritto: >> CC'ing Paolo and xen-devel. >> The original thread is here: >> >> http://marc.info/?l=xen-devel&m=135718999710640 >> >> On Mon, 2 Dec 2013, Don Slutz wrote: >>> Public bug reported: >>> >>>lt LINK l

[Qemu-devel] [PATCH v6 4/6] qemu-iotests: Change default cache mode to "writeback"

2013-12-03 Thread Fam Zheng
So that the tests can run faster. Signed-off-by: Fam Zheng Reviewed-by: Wenchao Xia --- tests/qemu-iotests/common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index 4743c9e..b2a0944 100644 --- a/tests/qemu-iotests/comm

[Qemu-devel] [PATCH v6 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Fam Zheng
This replaces _unsupported_qemu_io_options and check for support of current cache mode, and allow to provide a default if user didn't specify. Signed-off-by: Fam Zheng Reviewed-by: Wenchao Xia --- tests/qemu-iotests/026 | 3 ++- tests/qemu-iotests/039 | 3 ++- tests/qemu-iotests/0

[Qemu-devel] [PATCH v6 5/6] qemu-iotests: Clean up spaces in usage output

2013-12-03 Thread Fam Zheng
Whitespace changes to align columns. Signed-off-by: Fam Zheng --- tests/qemu-iotests/common | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index b2a0944..8b4e22c 100644 --- a/tests/qemu-iotests/common +++

[Qemu-devel] [PATCH v6 2/6] qemu-iotests: Honour cache mode in iotests.py

2013-12-03 Thread Fam Zheng
This will allow overriding cache mode from the "-c mode" option. Signed-off-by: Fam Zheng Reviewed-by: Wenchao Xia --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index fb10ff4.

Re: [Qemu-devel] [PATCH v5 5/6] qemu-iotests: Clean up spaces in usage output

2013-12-03 Thread Fam Zheng
On 2013年12月03日 22:31, Benoît Canet wrote: Le Tuesday 03 Dec 2013 à 16:25:26 (+0800), Fam Zheng a écrit : -o options -o options to pass to qemu-img create/convert --Toutput timestamps --r randomize test order These two lines

Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm

2013-12-03 Thread Richard Henderson
On 12/04/2013 01:32 PM, Peter Maydell wrote: > You're right that we can just make this function return the TCGv > temp rather than making the caller pass one in. Are you suggesting > the 64-bit case should return cpu_X[reg] rather than a copy of it, > though? I think it would be pretty hard to reas

Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0

2013-12-03 Thread Peter Maydell
On 4 December 2013 00:33, Michael Roth wrote: > In any case, ping? :) Who are you directing that ping at? This patch is commit 45d285abd7028 in master (Paolo put it in his pull request for 1.7, and kindly humoured my laziness by adding the CC: stable line in the process). If you intended to ping

Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0

2013-12-03 Thread Michael Roth
Quoting Peter Maydell (2013-11-05 13:36:57) > On 5 November 2013 19:31, Andreas Färber wrote: > > Am 05.11.2013 20:09, schrieb Peter Maydell: > >> I don't think there's any need to respin a patch > >> just because somebody thinks it might be worth > >> applying to stable. > > > > Point is, if you

Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm

2013-12-03 Thread Peter Maydell
On 4 December 2013 00:10, Richard Henderson wrote: > On 12/04/2013 10:51 AM, Peter Maydell wrote: >> @@ -184,6 +184,18 @@ static TCGv_i64 cpu_reg(DisasContext *s, int reg) >> } >> } >> >> +/* read a cpu register in 32bit/64bit mode to dst */ >> +static void read_cpu_reg(DisasContext *s, TCGv

Re: [Qemu-devel] [V3 PATCH 00/14] target-ppc: VSX Stage 4

2013-12-03 Thread Richard Henderson
On 12/04/2013 04:58 AM, Tom Musta wrote: > This is the fourth and final series of patches that add emulation support > to QEMU for the PowerPC Vector Scalar Extension (VSX). > > This series adds the instructions that were newly introduced with Power ISA > V2.07. This includes 3 scalar load instru

Re: [Qemu-devel] [V3 PATCH 12/14] target-ppc: VSX Stage 4: Add Scalar SP Fused Multiply-Adds

2013-12-03 Thread Richard Henderson
On 12/04/2013 04:58 AM, Tom Musta wrote: > This patch adds the Single Precision VSX Scalar Fused Multiply-Add > instructions: xsmaddasp, xsmaddmsp, xssubasp, xssubmsp, xsnmaddasp, > xsnmaddmsp, xsnmsubasp, xsnmsubmsp. > > The existing VSX_MADD() macro is modified to support rounding of the > inter

Re: [Qemu-devel] [PATCH 10/12] target-arm: A64: add support for conditional branches

2013-12-03 Thread Peter Maydell
On 4 December 2013 00:03, Richard Henderson wrote: > On 12/04/2013 10:51 AM, Peter Maydell wrote: >> +if (cond < 0x0e) { >> +/* genuinely conditional branches */ >> +int label_nomatch = gen_new_label(); >> +arm_gen_test_cc(cond ^ 1, label_nomatch); >> +gen_goto_

Re: [Qemu-devel] [PATCH 11/12] target-arm: A64: add support for 'test and branch' imm

2013-12-03 Thread Peter Maydell
On 4 December 2013 00:07, Richard Henderson wrote: > On 12/04/2013 10:51 AM, Peter Maydell wrote: >> +label_nomatch = gen_new_label(); >> +if (op) { /* TBNZ */ >> +tcg_gen_brcondi_i64(TCG_COND_EQ, tcg_cmp, 0, label_nomatch); >> +} else { /* TBZ */ >> +tcg_gen_brcondi_i6

Re: [Qemu-devel] [PATCH 07/12] target-arm: A64: expand decoding skeleton for system instructions

2013-12-03 Thread Peter Maydell
On 3 December 2013 23:15, Christopher Covington wrote: > Hi Claudio, Peter, > > On 12/03/2013 04:51 PM, Peter Maydell wrote: >> From: Claudio Fontana >> >> Decode the various kinds of system instructions: >> hints (HINT), which include NOP, YIELD, WFE, WFI, SEV, SEL >> sync instructions, which

Re: [Qemu-devel] [PATCH arm-devs v1 03/13] net/cadence_gem: Don't assert against 0 buffer address

2013-12-03 Thread Peter Crosthwaite
On Mon, Dec 2, 2013 at 10:04 PM, Peter Maydell wrote: > On 2 December 2013 07:10, Peter Crosthwaite > wrote: >> This has no real hardware analog. Leave the error message in is as >> it is almost certainly a guest error, but fallthrough to the expected >> behaviour. > > Maybe we should qemu_log_ma

Re: [Qemu-devel] [PATCH 5/5] hw/arm: add cubieboard support

2013-12-03 Thread Li Guang
Andreas Färber wrote: Am 03.12.2013 13:01, schrieb Peter Crosthwaite: On Tue, Dec 3, 2013 at 7:11 PM, liguang wrote: Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 33 + 2 files changed, 34 insertions(+), 1 dele

Re: [Qemu-devel] [PATCH 5/5] hw/arm: add cubieboard support

2013-12-03 Thread Li Guang
Peter Crosthwaite wrote: On Tue, Dec 3, 2013 at 7:11 PM, liguang wrote: Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 33 + 2 files changed, 34 insertions(+), 1 deletions(-) create mode 100644 hw/arm/cubieboard.c d

Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > @@ -184,6 +184,18 @@ static TCGv_i64 cpu_reg(DisasContext *s, int reg) > } > } > > +/* read a cpu register in 32bit/64bit mode to dst */ > +static void read_cpu_reg(DisasContext *s, TCGv_i64 dst, int reg, int sf) > +{ > +if (reg == 31) { >

Re: [Qemu-devel] [PATCH 11/12] target-arm: A64: add support for 'test and branch' imm

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > +label_nomatch = gen_new_label(); > +if (op) { /* TBNZ */ > +tcg_gen_brcondi_i64(TCG_COND_EQ, tcg_cmp, 0, label_nomatch); > +} else { /* TBZ */ > +tcg_gen_brcondi_i64(TCG_COND_NE, tcg_cmp, 0, label_nomatch); > +} > +

Re: [Qemu-devel] [PATCH 10/12] target-arm: A64: add support for conditional branches

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > +if (cond < 0x0e) { > +/* genuinely conditional branches */ > +int label_nomatch = gen_new_label(); > +arm_gen_test_cc(cond ^ 1, label_nomatch); > +gen_goto_tb(s, 0, addr); > +gen_set_label(label_nomatch); >

Re: [Qemu-devel] [PATCH 09/12] target-arm: A64: add support for BR, BLR and RET insns

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > From: Alexander Graf > > Implement BR, BLR and RET. This is all of the 'unconditional > branch (register)' instruction category except for ERET > and DPRS (which are system mode only). > > Signed-off-by: Alexander Graf > [claudio: reimplemented on

Re: [Qemu-devel] [PATCH 01/12] target-arm: Split A64 from A32/T32 gen_intermediate_code_internal()

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > The A32/T32 gen_intermediate_code_internal() is complicated because it > has to deal with: > * conditionally executed instructions > * Thumb IT blocks > * kernel helper page > * M profile exception-exit special casing > > None of these apply to A6

Re: [Qemu-devel] [PATCH 07/12] target-arm: A64: expand decoding skeleton for system instructions

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > From: Claudio Fontana > > Decode the various kinds of system instructions: > hints (HINT), which include NOP, YIELD, WFE, WFI, SEV, SEL > sync instructions, which include CLREX, DSB, DMB, ISB > msr_i, which move immediate to processor state field

Re: [Qemu-devel] [PATCH 06/12] target-arm: A64: provide skeleton for a64 insn decoding

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > From: Claudio Fontana > > Provide a skeleton for a64 instruction decoding in translate-a64.c, > by dividing instructions into the classes defined by the > ARM Architecture Reference Manual(DDI0487A_a) section C3. > > Signed-off-by: Claudio Fontana

Re: [Qemu-devel] [PATCH 05/12] target-arm: A64: add stubs for a64 specific helpers

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > From: Alexander Graf > > We will need helpers that only make sense with AArch64. Add > helper-a64.{c,h} files as stubs that we can fill with these > helpers in the following patches. > > Signed-off-by: Alexander Graf > Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 04/12] target-arm: Support fp registers in gdb stub

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > Register the aarch64-fpu XML and implement the necessary > read/write handlers so we can support reading and writing > of FP registers in the gdb stub. > > Signed-off-by: Peter Maydell > --- > configure |2 +- > gdb-xml/aarch64-fpu

Re: [Qemu-devel] [PATCH 03/12] target-arm: A64: provide functions for accessing FPCR and FPSR

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > The information which AArch32 holds in the FPSCR is split for > AArch64 into two logically distinct registers, FPSR and FPCR. > Since they are carefully arranged to use non-overlapping bits, > we leave the underlying state in the same place, and provid

Re: [Qemu-devel] [PATCH 02/12] target-arm: A64: add set_pc cpu method

2013-12-03 Thread Richard Henderson
On 12/04/2013 10:51 AM, Peter Maydell wrote: > From: Alexander Graf > > When executing translation blocks we need to be able to recover > our program counter. Add a method to set it for AArch64 CPUs. > This covers user-mode, but for system mode emulation we will > need to check if the CPU is in a

Re: [Qemu-devel] [PATCH 07/12] target-arm: A64: expand decoding skeleton for system instructions

2013-12-03 Thread Christopher Covington
Hi Claudio, Peter, On 12/03/2013 04:51 PM, Peter Maydell wrote: > From: Claudio Fontana > > Decode the various kinds of system instructions: > hints (HINT), which include NOP, YIELD, WFE, WFI, SEV, SEL > sync instructions, which include CLREX, DSB, DMB, ISB > msr_i, which move immediate to pr

[Qemu-devel] [PATCH 03/12] target-arm: A64: provide functions for accessing FPCR and FPSR

2013-12-03 Thread Peter Maydell
The information which AArch32 holds in the FPSCR is split for AArch64 into two logically distinct registers, FPSR and FPCR. Since they are carefully arranged to use non-overlapping bits, we leave the underlying state in the same place, and provide accessor functions which just update the appropriat

[Qemu-devel] [PATCH 05/12] target-arm: A64: add stubs for a64 specific helpers

2013-12-03 Thread Peter Maydell
From: Alexander Graf We will need helpers that only make sense with AArch64. Add helper-a64.{c,h} files as stubs that we can fill with these helpers in the following patches. Signed-off-by: Alexander Graf Signed-off-by: Peter Maydell --- target-arm/Makefile.objs |2 +- target-arm/helper-a

[Qemu-devel] [PATCH 08/12] target-arm: A64: add support for B and BL insns

2013-12-03 Thread Peter Maydell
From: Alexander Graf Implement the B and BL instructions (PC relative branches and calls). For convenience in managing TCG temporaries which might be generated if a source register is the zero-register XZR, we provide a simple mechanism for creating a new temp which is automatically freed at the

[Qemu-devel] [PATCH 04/12] target-arm: Support fp registers in gdb stub

2013-12-03 Thread Peter Maydell
Register the aarch64-fpu XML and implement the necessary read/write handlers so we can support reading and writing of FP registers in the gdb stub. Signed-off-by: Peter Maydell --- configure |2 +- gdb-xml/aarch64-fpu.xml | 86 +++

[Qemu-devel] [PATCH 01/12] target-arm: Split A64 from A32/T32 gen_intermediate_code_internal()

2013-12-03 Thread Peter Maydell
The A32/T32 gen_intermediate_code_internal() is complicated because it has to deal with: * conditionally executed instructions * Thumb IT blocks * kernel helper page * M profile exception-exit special casing None of these apply to A64, so putting the "this is A64 so call the A64 decoder" check

[Qemu-devel] [PATCH 00/12] target-arm: A64 decoder, foundation plus branches

2013-12-03 Thread Peter Maydell
Hi; this patchset represents the first bit of output of the work we've been doing in Linaro to help get the SuSE A64 instruction emulation upstream. Since code review on the 60-patch set Alex posted suggested that we should rework the decoder skeleton to more closely match the ARM ARM documentation

[Qemu-devel] [PATCH 10/12] target-arm: A64: add support for conditional branches

2013-12-03 Thread Peter Maydell
From: Alexander Graf This patch adds emulation for the conditional branch (b.cond) instruction. Signed-off-by: Alexander Graf [claudio: adapted to new decoder structure, reused arm infrastructure for checking the flags] Signed-off-by: Claudio Fontana Signed-off-by: Peter Maydell ---

Re: [Qemu-devel] [PATCH v2] hw/i386/pc_sysfw: support two flash drives

2013-12-03 Thread Laszlo Ersek
On 12/03/13 18:23, Markus Armbruster wrote: > Laszlo Ersek writes: > >> This patch allows the user to usefully specify >> >> -drive file=img_1,if=pflash,format=raw,readonly \ >> -drive file=img_2,if=pflash,format=raw >> >> on the command line. The flash images will be mapped under 4G in their

[Qemu-devel] [PATCH 02/12] target-arm: A64: add set_pc cpu method

2013-12-03 Thread Peter Maydell
From: Alexander Graf When executing translation blocks we need to be able to recover our program counter. Add a method to set it for AArch64 CPUs. This covers user-mode, but for system mode emulation we will need to check if the CPU is in an AArch32 execution state. Signed-off-by: Alexander Graf

Re: [Qemu-devel] [Qemu-stable] [PATCH 1/2] audio: honor QEMU_AUDIO_TIMER_PERIOD instead of waking up every *nano* second

2013-12-03 Thread Michael Roth
Quoting Alex Bligh (2013-12-03 15:17:11) > --On 3 December 2013 14:03:04 -0600 Michael Roth > wrote: > > >> Note this will not apply to 1.5 and 1.6 as is. > > > > What needs to be changed? Wouldn't this patch also restore the 250hz > > frequency for 1.6, as it was pre-0.14? > > The function nam

[Qemu-devel] [PATCH 06/12] target-arm: A64: provide skeleton for a64 insn decoding

2013-12-03 Thread Peter Maydell
From: Claudio Fontana Provide a skeleton for a64 instruction decoding in translate-a64.c, by dividing instructions into the classes defined by the ARM Architecture Reference Manual(DDI0487A_a) section C3. Signed-off-by: Claudio Fontana Signed-off-by: Peter Maydell --- target-arm/translate-a64

  1   2   3   4   >