Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-29 Thread Zhanghaoyu (A)
>On Tue, Nov 26, 2013 at 06:14:27PM +0200, Gleb Natapov wrote: >> On Tue, Nov 26, 2013 at 06:05:37PM +0200, Michael S. Tsirkin wrote: >> > On Tue, Nov 26, 2013 at 02:56:10PM +0200, Gleb Natapov wrote: >> > > On Tue, Nov 26, 2013 at 01:47:03PM +0100, Paolo Bonzini wrote: >> > > > Il 26/11/2013 13:40

Re: [Qemu-devel] [PATCH v2] block: Close backing file early in bdrv_img_create

2013-11-29 Thread Benoît Canet
Le Friday 29 Nov 2013 à 21:41:29 (+0100), Max Reitz a écrit : > Leaving the backing file open although it is not needed anymore can > cause problems if it is opened through a block driver which allows > exclusive access only and if the create function of the block driver > used for the top image (t

[Qemu-devel] [Bug 1256432] [NEW] qemu mingw 32bit windows crash

2013-11-29 Thread therock247uk
Public bug reported: is it a known bug that in windows that even if you do ./configure --disable-coroutine-pool it still builds the coroutine stuff so when you try and run the build after its compiled it crashses? you have to actually edit config-host.mak and change the c flags around. ** Affects

Re: [Qemu-devel] [PATCH V6 6/6] qemu-iotests: add test for qcow2 snapshot

2013-11-29 Thread Max Reitz
On 11.11.2013 00:56, Wenchao Xia wrote: This test will focus on the low level procedure of qcow2 snapshot operations, now it covers only the create operation. Overlap error paths are not checked since no good way to trigger those errors. Signed-off-by: Wenchao Xia Aside from the fact that I/O

[Qemu-devel] [PULL 5/6] util: Use qemu_getauxval in linux qemu_cache_utils_init

2013-11-29 Thread Richard Henderson
With this we no longer pass down envp, and thus all systems can have the same void prototype. So also eliminate a useless thunk. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/qemu/cache-utils.h | 4 ++-- linux-user/main.c | 2 +- util/cache-utils.c

[Qemu-devel] [PULL 6/6] linux-user: Use qemu_getauxval for AT_EXECFD

2013-11-29 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/main.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 50db755..54f71fe 100644 --- a/linux-user/main.c +++ b/linux-user/mai

[Qemu-devel] [PULL 3/6] tcg-arm: Use qemu_getauxval

2013-11-29 Thread Richard Henderson
Allow host detection on linux systems without glibc 2.16 or later. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/elf.h| 25 + tcg/arm/tcg-target.c | 14 +- 2 files changed, 30 insertions(+), 9 deletions(-) diff --git a/inclu

[Qemu-devel] [PULL 2/6] tcg-ppc64: Use qemu_getauxval

2013-11-29 Thread Richard Henderson
Allow host detection on linux systems without glibc 2.16 or later. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/elf.h | 34 ++ tcg/ppc64/tcg-target.c | 11 ++- 2 files changed, 36 insertions(+), 9 deletions(-) diff --g

[Qemu-devel] [PULL 4/6] tcg-s390: Use qemu_getauxval in query_facilities

2013-11-29 Thread Richard Henderson
No need to set up a SIGILL signal handler for detection anymore. Remove a ton of sanity checks that must be true, given that we're requiring a 64-bit build (the note about 31-bit KVM is satisfied by configuring with TCI). Signed-off-by: Richard Henderson --- include/elf.h | 14

[Qemu-devel] [PULL 1/6] osdep: Create qemu_getauxval and qemu_init_auxval

2013-11-29 Thread Richard Henderson
Abstract away dependence on a system implementation of getauxval. Signed-off-by: Richard Henderson --- include/qemu/osdep.h | 25 ++ linux-user/main.c| 1 + util/Makefile.objs | 1 + util/getauxval.c | 74 vl.c

[Qemu-devel] [PULL 0/6] getauxval improvements

2013-11-29 Thread Richard Henderson
This patch set has been floating around since June. Peter Maydell has reviewed most of it. r~ The following changes since commit 7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e: Open 2.0 development tree (2013-11-27 14:02:45 -0800) are available in the git repository at: git://github.com/rth768

[Qemu-devel] [PATCH v2] block: Close backing file early in bdrv_img_create

2013-11-29 Thread Max Reitz
Leaving the backing file open although it is not needed anymore can cause problems if it is opened through a block driver which allows exclusive access only and if the create function of the block driver used for the top image (the one being created) tries to close and reopen the image file (which

Re: [Qemu-devel] [PATCH] block: Close backing file early in bdrv_img_create

2013-11-29 Thread Max Reitz
On 28.11.2013 11:28, Kevin Wolf wrote: Am 27.11.2013 um 21:05 hat Max Reitz geschrieben: Leaving the backing file open although it is not needed anymore can cause problems if it is opened through a block driver which allows exclusive access only and if the create function of the block driver use

[Qemu-devel] [PATCH 5/5] Add vhost-user calls implementation

2013-11-29 Thread Antonios Motakis
Each ioctl request of vhost-kernel has a vhost-user message equivalent, which is sent it over the control socket. The general approach is to copy the data from the supplied argument pointer to a designated field in the message. If a file descriptor is to be passed it should be placed also in the f

[Qemu-devel] [PATCH 3/5] Add vhostsock option

2013-11-29 Thread Antonios Motakis
Adding a new tap network backend option - vhostsock. It points to a named unix domain socket, that will be used to communicate with vhost-user backend. This is a temporary work around; in future versions of this series vhost-user will be made independent from the tap network backend. Signed-off-by

[Qemu-devel] [PATCH 2/5] Add vhost-kernel and the vhost-user skeleton

2013-11-29 Thread Antonios Motakis
Introduce the backend type - vhost-kernel and vhost-user. Add basic ioctl, open, close multiplexing depending on selected backend. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c| 3 +-- hw/scsi/vhost-scsi.c | 4 ++-- hw/virt

[Qemu-devel] [PATCH 1/5] Decouple vhost from kernel interface

2013-11-29 Thread Antonios Motakis
We introduce the concept of vhost-backend, which can be either vhost-kernel or vhost-user. The existing vhost interface to the kernel is abstracted behind the vhost-kernel backend. We replace all direct ioctls to the kernel with a vhost_call to the backend. vhost dev->control is referenced only in

[Qemu-devel] [PATCH 4/5] Add domain socket communication for vhost-user backend

2013-11-29 Thread Antonios Motakis
Add structures for passing vhost-user messages over a unix domain socket. This is the equivalent of the existing vhost-kernel ioctls. Connect to the named unix domain socket. The system call sendmsg is used for communication. To be able to pass file descriptors between processes - we use SCM_RIGHT

[Qemu-devel] [RFC 0/5] Vhost and vhost-net support for userspace based backends

2013-11-29 Thread Antonios Motakis
In this patch series we would like to introduce our approach for putting a virtio-net backend in an external userspace process. Our eventual target is to run the network backend in the Snabbswitch ethernet switch, while receiving traffic from a guest inside QEMU/KVM which runs an unmodified virtio-

Re: [Qemu-devel] seavgabios resolutions, win8

2013-11-29 Thread Michael Tokarev
29.11.2013 22:57, Kevin O'Connor wrote: > On Fri, Nov 29, 2013 at 06:58:59PM +0400, Michael Tokarev wrote: >> I tried switching from plex/bochs vgabios to seavgabios, >> and made this switch for qemu-1.7 package in debian, at >> least to see how it goes. >> >> And almost immediately got a complain

Re: [Qemu-devel] seavgabios resolutions, win8

2013-11-29 Thread Kevin O'Connor
On Fri, Nov 29, 2013 at 06:58:59PM +0400, Michael Tokarev wrote: > I tried switching from plex/bochs vgabios to seavgabios, > and made this switch for qemu-1.7 package in debian, at > least to see how it goes. > > And almost immediately got a complain that with new qemu > (which uses seavgabios no

Re: [Qemu-devel] [SeaBIOS] seavgabios resolutions, win8

2013-11-29 Thread Kevin O'Connor
On Fri, Nov 29, 2013 at 07:59:25PM +0400, Michael Tokarev wrote: > 29.11.2013 19:23, Gerd Hoffmann wrote: > > Hi, > > > >> +{ 0x18d, { MM_DIRECT, 1920, 1080, 16, 8, 16, SEG_GRAPH } }, > >> +{ 0x18e, { MM_DIRECT, 1920, 1080, 24, 8, 16, SEG_GRAPH } }, > >> +{ 0x18f, { MM_DIRECT, 1920,

Re: [Qemu-devel] [SeaBIOS] seabios release planning

2013-11-29 Thread Kevin O'Connor
On Fri, Nov 29, 2013 at 04:13:35PM +0100, Gerd Hoffmann wrote: > Hi, > > qemu 1.7 is almost out of the door. I want update seabios early in the > 1.8 devel cycle. Time to do resume the release planning since we've > scratched the idea to do a last-minute bios update for 1.7. > > I'd like to s

[Qemu-devel] [PULL 25/41] COW: Extend checking allocated bits to beyond one sector

2013-11-29 Thread Kevin Wolf
From: Charlie Shepherd cow_co_is_allocated() only checks one sector's worth of allocated bits before returning. This is allowed but (slightly) inefficient, so extend it to check all of the file's metadata sectors. Signed-off-by: Charlie Shepherd Reviewed-by: Paolo Bonzini Signed-off-by: Stefan

[Qemu-devel] [PULL 35/41] block: Enable BDRV_O_SNAPSHOT with driver-specific options

2013-11-29 Thread Kevin Wolf
In the case of snapshot=on, don't rely on the backing file path in the temporary image any more, but override the backing file with the given set of options. This way, block drivers that don't use a file name can be accessed with snapshot=on, for example: -drive file.driver=nbd,file.host=local

[Qemu-devel] [PULL 38/41] qemu-iotests: Filter qemu-io output in 025

2013-11-29 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/025 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/025 b/tests/qemu-iotests/025 index a7241cc..9426c93 100755 --- a/tests/qemu-iotests/025

[Qemu-devel] [PULL 22/41] block: per caller dirty bitmap

2013-11-29 Thread Kevin Wolf
From: Fam Zheng Previously a BlockDriverState has only one dirty bitmap, so only one caller (e.g. a block job) can keep track of writing. This changes the dirty bitmap to a list and creates a BdrvDirtyBitmap for each caller, the lifecycle is managed with these new functions: bdrv_create_dirt

[Qemu-devel] [PULL 18/41] util/error: Save errno from clobbering

2013-11-29 Thread Kevin Wolf
From: Max Reitz There may be calls to error_setg() and especially error_setg_errno() which blindly (and until now wrongly) assume these functions not to clobber errno (e.g., they pass errno to error_setg_errno() and return -errno afterwards). Instead of trying to find and fix all of these constru

Re: [Qemu-devel] [PATCH v2 0/4] i440fx-test: check firmware visibility

2013-11-29 Thread Laszlo Ersek
On 11/29/13 18:12, Andreas Färber wrote: > Am 28.11.2013 19:18, schrieb Laszlo Ersek: >> On 11/28/13 19:09, Laszlo Ersek wrote: >> >>> Changes in v2: >>> - Rebased ("-display none" is the default now). >>> >>> - I looked into memory management prudence in qtest, and I can see that >>> we don't ca

[Qemu-devel] [PATCH v3 4/4] i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash

2013-11-29 Thread Laszlo Ersek
Check whether the firmware is not hidden by other memory regions. Qemu is started in paused mode: it shouldn't try to interpret generated garbage. Signed-off-by: Laszlo Ersek --- tests/i440fx-test.c | 81 + 1 file changed, 75 insertions(+), 6

Re: [Qemu-devel] [PATCH v2 0/4] i440fx-test: check firmware visibility

2013-11-29 Thread Andreas Färber
Am 28.11.2013 19:18, schrieb Laszlo Ersek: > On 11/28/13 19:09, Laszlo Ersek wrote: > >> Changes in v2: >> - Rebased ("-display none" is the default now). >> >> - I looked into memory management prudence in qtest, and I can see that >> we don't care about leaking small objects at all. (See for e

[Qemu-devel] [PATCH v3 1/4] i440fx-test: qtest_start() should be paired with qtest_end()

2013-11-29 Thread Laszlo Ersek
Similarly to commit 1d9358e6 ("libqtest: New qtest_end() to go with qtest_start()"). Signed-off-by: Laszlo Ersek --- tests/i440fx-test.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c index 65c786c..6ac46bf 100644 --- a/te

[Qemu-devel] [PATCH v3 3/4] i440fx-test: generate temporary firmware blob

2013-11-29 Thread Laszlo Ersek
The blob is 64K in size and contains 0x00..0xFF repeatedly. The client code added to main() wouldn't make much sense in the long term. It helps with debugging and it silences gcc about create_blob_file() being unused, and we'll replace it in the next patch anyway. Signed-off-by: Laszlo Ersek ---

[Qemu-devel] [PATCH v3 0/4] i440fx-test: check firmware visibility

2013-11-29 Thread Laszlo Ersek
v3 [Markus]: - FW_SIZE -> BLOB_SIZE - create_firmware() -> create_blob_file() - detach create_blob_file() comment block from firmware & temporariness - same in filename and error messages there - char unsigned -> uint8_t Laszlo Ersek (4): i440fx-test: qtest_start() should be paired with qtest_en

[Qemu-devel] [PATCH v3 2/4] i440fx-test: give each GTest case its own qtest

2013-11-29 Thread Laszlo Ersek
The current two GTest cases, /i440fx/defaults and /i440fx/pam can share a qemu process, but the next two cases will need dedicated instances. It is messy (and order-dependent) to dynamically configure GTest cases one by one to start, stop, or keep the current qtest (*); let's just have each GTest w

Re: [Qemu-devel] [PATCH for 1.7] target-mips: fix 64-bit FPU config for user-mode emulation

2013-11-29 Thread Andreas Färber
Am 29.11.2013 17:27, schrieb Petar Jovanovic: > From: Petar Jovanovic > > FR bit should be initialized to 1 for MIPS64, under condition that this > bit is writable and that CPU has an FPU unit. It should be initialized to > zero for MIPS32. > This fixes different MIPS32 issues with FPU instructio

[Qemu-devel] [PULL 40/41] vmdk: Allow read only open of VMDK version 3

2013-11-29 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/vmdk.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index 5fb6c81..88d09e3 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -605,13 +605,20 @@ static int vmdk_

[Qemu-devel] [PULL 37/41] block: Use BDRV_O_NO_BACKING where appropriate

2013-11-29 Thread Kevin Wolf
If you open an image temporarily just because you want to check its size or get it flushed, there's no real reason to open the whole backing file chain. Signed-off-by: Kevin Wolf Reviewed-by: Fam Zheng Reviewed-by: Benoit Canet --- block.c | 3 ++- block/qcow2.c | 3 ++- block/vmdk.c |

[Qemu-devel] [PULL 30/41] sheepdog: support user-defined redundancy option

2013-11-29 Thread Kevin Wolf
From: Liu Yuan Sheepdog support two kinds of redundancy, full replication and erasure coding. # create a fully replicated vdi with x copies -o redundancy=x (1 <= x <= SD_MAX_COPIES) # create a erasure coded vdi with x data strips and y parity strips -o redundancy=x:y (x must be one of {2,4,8,

[Qemu-devel] [PULL 31/41] qemu-iotests: Drop local version of cancel_and_wait from 040

2013-11-29 Thread Kevin Wolf
From: Fam Zheng iotests.py already has one. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/040 | 15 --- 1 file changed, 15 deletions(-) diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040 index a2e18c5..0e85136 100755 --- a/tests/qemu-iot

Re: [Qemu-devel] [Bug 1038136] Re: lack of keycode 89 for br-abnt2 keyboards

2013-11-29 Thread Gilcio Amaral Martins
Thanks I will test it Gilcio Em 27/11/2013, às 07:25, rslemos escreveu: > I've managed to resolve it applying the following patch (without "-k pt- > br"): > > --- qemu-1.6.0+dfsg.orig/ui/x_keymap.c > +++ qemu-1.6.0+dfsg/ui/x_keymap.c > @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_key >

[Qemu-devel] [PULL 27/41] qdict: Fix memory leak in qdict_do_flatten()

2013-11-29 Thread Kevin Wolf
Reported-by: Laszlo Ersek Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- qobject/qdict.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qobject/qdict.c b/qobject/qdict.c index 0f3e0a6..60d6cd5 100644 --- a/qobject/qdict.c +++ b/qobject/qdict.c @@ -481,7 +48

[Qemu-devel] [PULL 23/41] qapi: Change BlockDirtyInfo to list

2013-11-29 Thread Kevin Wolf
From: Fam Zheng We have multiple dirty bitmaps in BDS now, switch QAPI to allow query it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block.c | 20 block/qapi.c | 5 + incl

[Qemu-devel] [PULL 41/41] qemu-iotests: Add sample image and test for VMDK version 3

2013-11-29 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/059| 5 + tests/qemu-iotests/059.out| 5 + tests/qemu-iotests/sample_images/iotest-version3.vmdk.bz2 | Bin 0 -> 414 bytes 3

[Qemu-devel] [PULL 36/41] qemu-iotests: Test snapshot mode

2013-11-29 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- tests/qemu-iotests/051 | 17 +++ tests/qemu-iotests/051.out | 54 +- 2 files changed, 66 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 i

[Qemu-devel] [PULL 21/41] block/stream: Don't stream unbacked devices

2013-11-29 Thread Kevin Wolf
From: Max Reitz If a block device is unbacked, a streaming blockjob should immediately finish instead of beginning to try to stream, then noticing the backing file does not contain even the first sector (since it does not exist) and then finishing normally. Signed-off-by: Max Reitz Reviewed-by:

[Qemu-devel] [PULL 33/41] qemu-iotest: Add pause_drive and resume_drive methods

2013-11-29 Thread Kevin Wolf
From: Fam Zheng They wrap blkdebug "break" and "remove_break". Add optional argument "resume" to cancel_and_wait(). Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/iotests.py | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a

[Qemu-devel] [PULL 32/41] blkdebug: add "remove_break" command

2013-11-29 Thread Kevin Wolf
From: Fam Zheng This adds "remove_break" command which is the reverse of blkdebug command "break": it removes all breakpoints with given tag and resumes all the requests. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block.c | 13 + block/blkdebug.c

[Qemu-devel] [PULL 20/41] sheepdog: implement .bdrv_get_allocated_file_size

2013-11-29 Thread Kevin Wolf
From: Liu Yuan With this patch, qemu-img info sheepdog:image will show disk size for sheepdog images. Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: MORITA Kazutaka Signed-off-by: Liu Yuan Reviewed-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c | 19 +++ 1 file

[Qemu-devel] [PULL 34/41] qemu-iotests: Make test case 030, 040 and 055 deterministic

2013-11-29 Thread Kevin Wolf
From: Fam Zheng Pause the drive and start the block job, so we won't miss the block job. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/030 | 16 +++- tests/qemu-iotests/040 | 4 +++- tests/qemu-iotests/055 | 14 +++--- 3 files changed, 25

[Qemu-devel] [PULL 28/41] qdict: Optimise qdict_do_flatten()

2013-11-29 Thread Kevin Wolf
Nested QDicts used to be both entered recursively in order to move their entries to the target QDict and also be moved themselves to the target QDict like all other objects. This is harmless because for the top level, qdict_do_flatten() will encounter the (now empty) QDict for a second time and the

[Qemu-devel] [PULL 26/41] MAINTAINERS: add sheepdog development mailing list

2013-11-29 Thread Kevin Wolf
From: Liu Yuan This will help people find mailing list relevant to sheepdog. Cc: Stefan Hajnoczi Cc: Kevin Wolf Signed-off-by: Liu Yuan Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c19133f..3e61ac8 100644

[Qemu-devel] [PULL 16/41] qemu-img: add support for fully allocated images

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- qemu-img.c| 10 +++--- qemu-img.texi | 6 ++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index b6b5644..cc3fed7 100644 --- a/qemu-img.c +++ b/qemu-img.c @@

[Qemu-devel] [PULL 29/41] sheepdog: refactor do_sd_create()

2013-11-29 Thread Kevin Wolf
From: Liu Yuan We can actually use BDRVSheepdogState *s to pass most of the parameters. Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 37 +++-- 1 file changed, 15 insertions(+), 22 deletions(-

[Qemu-devel] [PULL 24/41] COW: Speed up writes

2013-11-29 Thread Kevin Wolf
From: Charlie Shepherd Process a whole sector's worth of COW bits by reading a sector, setting the bits after skipping any already set bits, then writing it out again. Make sure we only flush once before writing metadata, and only if we need to write metadata. Signed-off-by: Charlie Shepherd Si

[Qemu-devel] [PULL 19/41] Test coroutine execution order

2013-11-29 Thread Kevin Wolf
From: Charlie Shepherd This patch adds a test for coroutine execution order in test-coroutine - this catches a bug in the CPC coroutine implementation. Signed-off-by: Charlie Shepherd Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- tests/test-coroutine.c | 54 ++

[Qemu-devel] [PULL 13/41] iscsi: add bdrv_co_write_zeroes

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block/iscsi.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index f91134e..b7b5238 100644 --- a/block/iscsi.c +++ b

[Qemu-devel] [PULL 15/41] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-11-29 Thread Kevin Wolf
From: Peter Lieven this patch does 2 things: a) only do additional call outs if BDRV_BLOCK_ZERO is not already set. b) use the newly introduced bdrv_unallocated_blocks_are_zero() to return the zero state of an unallocated block. the used callout to bdrv_has_zero_init() is only valid right a

[Qemu-devel] [PULL 11/41] iscsi: set limits in BlockDriverState

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Reviewed-by: Eric Blake Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block/iscsi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 3095887..1cafa78 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1

[Qemu-devel] [PULL 08/41] block/raw: copy BlockLimits on raw_open

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block/raw_bsd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index fb5181b..978ae7a 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @@ -150,6 +150,7 @@ static int raw_o

[Qemu-devel] [PULL 14/41] block: introduce bdrv_make_zero

2013-11-29 Thread Kevin Wolf
From: Peter Lieven this patch adds a call to completely zero out a block device. the operation is sped up by checking the block status and only writing zeroes to the device if they currently do not return zeroes. optionally the zero writing can be sped up by setting the flag BDRV_REQ_MAY_UNMAP to

[Qemu-devel] [PULL 10/41] block: honour BlockLimits in bdrv_co_discard

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Reviewed-by: Eric Blake Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index b4194da..df5a603 100644 --- a/block.c +++ b/block

[Qemu-devel] [PULL 17/41] qemu-img: conditionally zero out target on convert

2013-11-29 Thread Kevin Wolf
From: Peter Lieven If the target has_zero_init = 0, but supports efficiently writing zeroes by unmapping we call bdrv_make_zero to avoid fully allocating the target. This currently works only for iscsi. It can be extended to raw with BLKDISCARDZEROES for example. Reviewed-by: Eric Blake Signed

[Qemu-devel] [PULL 06/41] block/iscsi: add .bdrv_get_info

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block/iscsi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index a2d578c..3095887 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1506,6 +1506,14 @@ out: retu

[Qemu-devel] [PULL 05/41] block: add wrappers for logical block provisioning information

2013-11-29 Thread Kevin Wolf
From: Peter Lieven This adds 2 wrappers to read the unallocated_blocks_are_zero and can_write_zeroes_with_unmap info from the BDI. The wrappers are required to check for the existence of a backing_hd and if the devices are opened with the correct flags. Reviewed-by: Eric Blake Signed-off-by: Pe

[Qemu-devel] [PULL 12/41] iscsi: simplify iscsi_co_discard

2013-11-29 Thread Kevin Wolf
From: Peter Lieven now that bdrv_co_discard can handle limits we do not need the request split logic here anymore. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block/iscsi.c | 67 ++- 1 file cha

[Qemu-devel] [PULL 03/41] block: introduce BDRV_REQ_MAY_UNMAP request flag

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Reviewed-by: Eric Blake Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block-migration.c | 3 ++- block.c | 4 block/backup.c| 2 +- include/block/block.h | 7 +++ 4 files changed, 14 insertions(+), 2 deletions(-) diff --g

[Qemu-devel] [PULL 09/41] block: honour BlockLimits in bdrv_co_do_write_zeroes

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Reviewed-by: Eric Blake Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block.c | 65 + 1 file changed, 49 insertions(+), 16 deletions(-) diff --git a/block.c b/block.c index 3759582..b4194da 10

[Qemu-devel] [PULL 01/41] block: make BdrvRequestFlags public

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Reviewed-by: Eric Blake Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block.c | 5 - include/block/block.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 382ea71..3dc6c12 100644 --- a/bloc

[Qemu-devel] [PULL 07/41] block: add BlockLimits structure to BlockDriverState

2013-11-29 Thread Kevin Wolf
From: Peter Lieven this patch adds BlockLimits which introduces discard and write_zeroes limits and alignment information to the BlockDriverState. Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- include/block/block_int.h | 17 + 1 file changed, 17 insertions(+)

[Qemu-devel] [PULL 02/41] block: add flags to bdrv_*_write_zeroes

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Reviewed-by: Eric Blake Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block-migration.c | 2 +- block.c | 20 +++- block/backup.c| 3 ++- block/qcow2-cluster.c | 2 +- block/qcow2.c |

[Qemu-devel] [PULL 00/41] Block patches for 2.0 (flushing block-next)

2013-11-29 Thread Kevin Wolf
The following changes since commit 7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e: Open 2.0 development tree (2013-11-27 14:02:45 -0800) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-anthony for you to fetch changes up to 981cbf59b5360647e908186e7306ee9013a58c88

[Qemu-devel] [PULL 04/41] block: add logical block provisioning info to BlockDriverInfo

2013-11-29 Thread Kevin Wolf
From: Peter Lieven Reviewed-by: Eric Blake Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- include/block/block.h | 16 1 file changed, 16 insertions(+) diff --git a/include/block/block.h b/include/block/block.h index 1f30a56..9c76967 100644 --- a/include/block

[Qemu-devel] [PATCH for 1.7] target-mips: fix 64-bit FPU config for user-mode emulation

2013-11-29 Thread Petar Jovanovic
From: Petar Jovanovic FR bit should be initialized to 1 for MIPS64, under condition that this bit is writable and that CPU has an FPU unit. It should be initialized to zero for MIPS32. This fixes different MIPS32 issues with FPU instructions whose behaviour defaulted to 64-bit FPU mode. Signed-o

Re: [Qemu-devel] [PATCH v2 4/4] i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 16:30, Laszlo Ersek ha scritto: >> > Zero-fill immediately followed by read. Suggest to drop memset(). > Same as above. memread() is unable to report errors. Some C library > functions also require you to set errno to zero first, then call the > function, then check errno, because so

Re: [Qemu-devel] [PATCH v2 3/4] i440fx-test: generate temporary firmware blob

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 16:07, Laszlo Ersek ha scritto: > I think that the way I did it here matches this situation well. After > the g_file_open_tmp() call succeeds, we must close fd in any case > (independently of whether as a whole the function succeeds or not). > Optionally, we must also unlink the file,

Re: [Qemu-devel] seavgabios resolutions, win8

2013-11-29 Thread Michael Tokarev
29.11.2013 19:59, Michael Tokarev wrote: [] >>> And while at it, there's another bugreport against vgabios package in >>> Debian, see http://bugs.debian.org/685097 . It looks like windows8 >>> isn't happy with vgabios-provided modes and does not let to change >>> resolution at all, sticking at 102

Re: [Qemu-devel] [PATCH 27/30] virtio-rng: Convert to QOM realize

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 17:10, Andreas Färber ha scritto: >> > +#define VIRTIO_RNG_GET_PARENT_CLASS(obj) \ >> > +OBJECT_GET_PARENT_CLASS(obj, TYPE_VIRTIO_RNG) >> > >> > /* The Virtio ID for the virtio rng device */ >> > #define VIRTIO_ID_RNG4 > This hunk seems a leftover from v2. How to proce

Re: [Qemu-devel] [PATCH 27/30] virtio-rng: Convert to QOM realize

2013-11-29 Thread Andreas Färber
Am 29.11.2013 11:17, schrieb Paolo Bonzini: > From: Andreas Färber > > Signed-off-by: Andreas Färber > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio-rng.c | 24 +++- > include/hw/virtio/virtio-rng.h | 2 ++ > 2 files changed, 13 insertions(+), 13 deletions(

Re: [Qemu-devel] [PATCH 23/30] virtio-blk: Convert to QOM realize

2013-11-29 Thread Andreas Färber
Am 29.11.2013 11:17, schrieb Paolo Bonzini: > diff --git a/tests/qdev-monitor-test.c b/tests/qdev-monitor-test.c > index 33a8ea4..ba7f9cc 100644 > --- a/tests/qdev-monitor-test.c > +++ b/tests/qdev-monitor-test.c > @@ -32,10 +32,8 @@ static void test_device_add(void) > "}}"); >

Re: [Qemu-devel] [PATCH v6 2/4] target-arm: Implement ARMv8 VSEL instruction.

2013-11-29 Thread Peter Maydell
On 28 November 2013 17:07, Will Newton wrote: > > This adds support for the VSEL floating point selection instruction > which was added in ARMv8. > > Signed-off-by: Will Newton > --- > target-arm/translate.c | 130 > - > 1 file changed, 129 insert

Re: [Qemu-devel] seavgabios resolutions, win8

2013-11-29 Thread Michael Tokarev
29.11.2013 19:23, Gerd Hoffmann wrote: > Hi, > >> +{ 0x18d, { MM_DIRECT, 1920, 1080, 16, 8, 16, SEG_GRAPH } }, >> +{ 0x18e, { MM_DIRECT, 1920, 1080, 24, 8, 16, SEG_GRAPH } }, >> +{ 0x18f, { MM_DIRECT, 1920, 1080, 32, 8, 16, SEG_GRAPH } }, > >> I'm not sure I understand how list of m

[Qemu-devel] [PATCH 02/13] vscclient: do not add a socket watch if there is not data to send

2013-11-29 Thread Marc-André Lureau
From: Marc-André Lureau Fixes the following error: ** (process:780): CRITICAL **: do_socket_send: assertion `socket_to_send->len != 0' failed Signed-off-by: Marc-André Lureau --- libcacard/vscclient.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libcacard/vscc

[Qemu-devel] [PATCH 10/13] nbd: pass export name as init argument

2013-11-29 Thread Marc-André Lureau
From: Marc-André Lureau There is no need to keep the export name around, and it seems a better fit as an argument in the init() call. Signed-off-by: Marc-André Lureau --- block/nbd-client.c | 10 -- block/nbd-client.h | 5 ++--- block/nbd.c| 13 - 3 files changed,

Re: [Qemu-devel] [PATCH 2/2] target-i386: Intel MPX support

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 15:50, Liu, Jinsong ha scritto: > > There is no reason to get the size and offset from the host. Peter > > Anvin confirmed that the sizes and offsets will never change (as > > should be the case for migration to work across different CPU > > versions). In fact, the size and offset i

Re: [Qemu-devel] [PATCH v2 2/4] i440fx-test: give each GTest case its own qtest

2013-11-29 Thread Laszlo Ersek
On 11/29/13 15:53, Eduardo Habkost wrote: > On Thu, Nov 28, 2013 at 07:09:13PM +0100, Laszlo Ersek wrote: >> The current two GTest cases, /i440fx/defaults and /i440fx/pam can share a >> qemu process, but the next two cases will need dedicated instances. It is >> messy (and order-dependent) to dynam

Re: [Qemu-devel] [PATCH] block: Use BDRV_O_NO_BACKING where appropriate

2013-11-29 Thread Benoît Canet
Le Thursday 28 Nov 2013 à 12:02:27 (+0100), Kevin Wolf a écrit : > If you open an image temporarily just because you want to check its size > or get it flushed, there's no real reason to open the whole backing file > chain. > > Signed-off-by: Kevin Wolf > --- > block.c | 3 ++- > block/qco

Re: [Qemu-devel] [PATCH 00/13] Spice block device, ready-to-go patches

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 15:58, Marc-André Lureau ha scritto: > Hi, > > This patch series is a split-off from the Spice block device RFC. > http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02024.html > > It should include only non-controversial or simple patches. The most > important change is the NB

Re: [Qemu-devel] [PATCH v6 4/4] target-arm: Implement ARMv8 SIMD VMAXNM and VMINNM instructions.

2013-11-29 Thread Peter Maydell
On 28 November 2013 17:07, Will Newton wrote: > +uint32_t HELPER(neon_maxnm_f32)(uint32_t a, uint32_t b, void *fpstp) > +{ > +float_status *fpst = fpstp; > +float32 af = make_float32(a); > +float32 bf = make_float32(b); > +if (float32_is_quiet_nan(af) && !float32_is_quiet_nan(bf))

Re: [Qemu-devel] [PATCH v2 4/4] i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash

2013-11-29 Thread Laszlo Ersek
On 11/29/13 15:09, Markus Armbruster wrote: > Laszlo Ersek writes: >> +/* check below 4G */ >> +buf = g_malloc0(FW_SIZE); >> +memread(0x1ULL - FW_SIZE, buf, FW_SIZE); > > Zero-fill immediately followed by read. Suggest g_malloc(). This was intentional. Please see the preexi

Re: [Qemu-devel] [PATCH 08/13] Split nbd block client code

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 15:58, Marc-André Lureau ha scritto: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > block/Makefile.objs | 2 +- > block/nbd-client.c | 372 +++ > block/nbd-client.h | 51 +++ > block/nbd.c | 3

Re: [Qemu-devel] [PATCH v6 1/4] target-arm: Move call to disas_vfp_insn out of disas_coproc_insn.

2013-11-29 Thread Will Newton
On 29 November 2013 15:26, Peter Maydell wrote: > On 28 November 2013 17:07, Will Newton wrote: >> >> Floating point is an extension to the instruction set rather than >> a coprocessor, so call it directly from the ARM and Thumb decode >> functions. > > Hi; thanks for these patches. A minor proce

Re: [Qemu-devel] [PATCH 11/13] nbd: make session_close() idempotent

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 15:58, Marc-André Lureau ha scritto: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > block/nbd-client.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/block/nbd-client.c b/block/nbd-client.c > index e29227b..c0ad2c2 100644 > --- a/block/nbd-c

Re: [Qemu-devel] [PATCH 13/13] nbd: avoid uninitialized warnings

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 15:58, Marc-André Lureau ha scritto: > ==15815== Thread 1: > ==15815== Syscall param socketcall.sendto(msg) points to uninitialised byte(s) > ==15815==at 0x65AD5CB: send (send.c:31) > ==15815==by 0x37F84B: nbd_wr_sync (nbd.c:145) > ==15815==by 0x37F94B: write_sync (nbd.c:1

Re: [Qemu-devel] [PATCH 12/13] nbd: finish any pending coroutine

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 15:58, Marc-André Lureau ha scritto: > closesocket(client->sock); > +/* finish any pending coroutines */ > +client->reply.handle = 0; > +client->reply.error = EIO; > +nbd_recv_coroutines_enter_all(client); What about using the same shutdown(2) trick as the server

Re: [Qemu-devel] [PATCH 10/13] nbd: pass export name as init argument

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 15:58, Marc-André Lureau ha scritto: > From: Marc-André Lureau > > There is no need to keep the export name around, and it seems a better > fit as an argument in the init() call. > > Signed-off-by: Marc-André Lureau > --- > block/nbd-client.c | 10 -- > block/nbd-client.h

Re: [Qemu-devel] [PATCH v6 1/4] target-arm: Move call to disas_vfp_insn out of disas_coproc_insn.

2013-11-29 Thread Peter Maydell
On 28 November 2013 17:07, Will Newton wrote: > > Floating point is an extension to the instruction set rather than > a coprocessor, so call it directly from the ARM and Thumb decode > functions. Hi; thanks for these patches. A minor process note: for future versions, can you make sure you send p

Re: [Qemu-devel] seavgabios resolutions, win8

2013-11-29 Thread Gerd Hoffmann
Hi, > +{ 0x18d, { MM_DIRECT, 1920, 1080, 16, 8, 16, SEG_GRAPH } }, > +{ 0x18e, { MM_DIRECT, 1920, 1080, 24, 8, 16, SEG_GRAPH } }, > +{ 0x18f, { MM_DIRECT, 1920, 1080, 32, 8, 16, SEG_GRAPH } }, > I'm not sure I understand how list of modes is maintained/used in > seavgabios. The abo

[Qemu-devel] [PATCH 03/13] spice-char: remove unused field

2013-11-29 Thread Marc-André Lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- spice-qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 6d147a7..e074d9e 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c @@ -11,7 +11,6 @@ typedef struct SpiceCharDriver

Re: [Qemu-devel] [PATCH v6 4/4] target-arm: Implement ARMv8 SIMD VMAXNM and VMINNM instructions.

2013-11-29 Thread Peter Maydell
On 28 November 2013 17:07, Will Newton wrote: > > This adds support for the ARMv8 Advanced SIMD VMAXNM and VMINNM > instructions. > > Signed-off-by: Will Newton > --- > target-arm/helper.h | 3 +++ > target-arm/neon_helper.c | 24 > target-arm/translate.c | 23 ++

  1   2   3   >