Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-27 Thread Markus Armbruster
Peter Crosthwaite writes: > Hi, > > On Thu, Nov 28, 2013 at 11:24 AM, Igor Mammedov wrote: >> in case if caller setting property doesn't care about error and >> passes in NULL as errp argument but error occurs in property setter, >> it is silently discarded leaving object in undefined state. >>

Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event

2013-11-27 Thread Wenchao Xia
于 2013/11/28 8:48, Luiz Capitulino 写道: On Wed, 13 Nov 2013 09:44:52 +0800 Wenchao Xia wrote: Nested structure is not supported now, so following define is not valid: { 'event': 'EVENT_C', 'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' } I think your general approach is reasonab

Re: [Qemu-devel] [PULL v2 00/11] target-lm32 updates

2013-11-27 Thread Antony Pavlov
On Mon, 14 Oct 2013 19:20:45 +0200 Michael Walle wrote: > > Am Montag, 14. Oktober 2013, 18:29:24 schrieb Michael Walle: > > This is a pull for various updates and fixes for the LatticeMico32 target. > > > > Please pull. > > > > changes since v1: > > - rebased > > - dropped patch "target-lm3

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-27 Thread Zhanghaoyu (A)
> > >>I understood the proposal was also to eliminate the > > >>synchronize_rcu(), so while new interrupts would see the new > > >>routing table, interrupts already in flight could pick up the old one. > >Isn't that always the case with RCU? (See my answer above: "the > >v

[Qemu-devel] [PATCH 2/2] hw/mips: use sizes.h macros

2013-11-27 Thread Antony Pavlov
Signed-off-by: Antony Pavlov Reviewed-by: Richard Henderson --- hw/mips/mips_malta.c | 25 + include/hw/mips/bios.h | 3 ++- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index 05c8771..604832f 100644 --- a

[Qemu-devel] [PATCH arm-devs v3 3/4] hw/timer: Introduce ARM A9 Global Timer.

2013-11-27 Thread Peter Crosthwaite
The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore. The timer is shared but each CPU has a private independent comparator and interrupt. Based on version contributed by Francois LEGAL. Signed-off-by: François LEGAL [PC changes: * New commit message * Re-implemented as singl

[Qemu-devel] [PATCH arm-devs v3 4/4] cpu/a9mpcore: Add Global Timer

2013-11-27 Thread Peter Crosthwaite
From: François LEGAL Add the global timer to A9 MPCore. Signed-off-by: François LEGAL [PC Changes: * new commit message * split off original version as a separate patch * Rebased against new mpcore implementation (with struct embedding) ] Signed-off-by: Peter Crosthwaite --- changed from v2

[Qemu-devel] [PATCH 1/2] include/qemu: introduce sizes.h

2013-11-27 Thread Antony Pavlov
The header file sizes.h is used in linux kernel, barebox bootloader and u-boot bootloader. It provides the short and easy-to-read names for power-of-two numbers. The numbers like this are othen used for memory range sizes. Signed-off-by: Antony Pavlov Reviewed-by: Richard Henderson --- include/

[Qemu-devel] [PATCH 0/2] use sizes.h macros for power-of-two sizes

2013-11-27 Thread Antony Pavlov
[PATCH 1/2] include/qemu: introduce sizes.h [PATCH 2/2] hw/mips: use sizes.h macros The sizes.h macros is a easy-to-read method of power-of-two memory sizes representation. The sizes.h macros are actively used in linux kernel and other projects, so let's use them in QEMU too.

[Qemu-devel] [PATCH arm-devs v3 2/4] cpu/a9mpcore: reorder operations/declarations

2013-11-27 Thread Peter Crosthwaite
To make it consistent for easier code reading. The order in which variables are defined and functions are called is set to match the address map ordering. The new consistent order of doing stuff is: SCU -> GIC -> MPTimer -> WDT. 0 functional change. Signed-off-by: Peter Crosthwaite --- hw/c

[Qemu-devel] [PATCH arm-devs v3 0/4] A9 global timer + mpcore trivials

2013-11-27 Thread Peter Crosthwaite
Hi Peter, Another spin of the ARM MPCore global timer work. Patches 1 & 2 are some trivial cleanup to MPCore I did along the way. Regards, Peter François LEGAL (1): cpu/a9mpcore: Add Global Timer Peter Crosthwaite (3): cpu/a9mpcore: rename timerbusdev variable cpu/a9mpcore: reorder opera

[Qemu-devel] [PATCH arm-devs v3 1/4] cpu/a9mpcore: rename timerbusdev variable

2013-11-27 Thread Peter Crosthwaite
Rename this variable for consistency with the above defined mptimerdev variable. Signed-off-by: Peter Crosthwaite --- hw/cpu/a9mpcore.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index 918a7d1..1123101 100644 --- a/hw/cpu/a9

Re: [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name

2013-11-27 Thread Wenchao Xia
于 2013/11/26 0:47, Luiz Capitulino 写道: On Wed, 13 Nov 2013 06:25:00 +0800 Wenchao Xia wrote: This series is respined from RFC series at: http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg00363.html Patch 1-6 add support for enum as discriminator. Patch 7 improve enum name generation,

Re: [Qemu-devel] Patch v3 : POSIX timer implementation for linux-user.

2013-11-27 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > Erik de Castro Lopo wrote: > > > mle...@mega-nerd.com wrote: > > > > > > > > Changes from original: > > > > > > * Call host's libc functions directly rather than _syscall*() (as > > > suggested > > > by Peter Maydell). > > > * Remove un-needed #defines. > > > >

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-27 Thread Peter Crosthwaite
Hi, On Thu, Nov 28, 2013 at 11:24 AM, Igor Mammedov wrote: > in case if caller setting property doesn't care about error and > passes in NULL as errp argument but error occurs in property setter, > it is silently discarded leaving object in undefined state. > > As result it leads to hard to find

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-27 Thread Eric Blake
On 11/27/2013 06:24 PM, Igor Mammedov wrote: > in case if caller setting property doesn't care about error and > passes in NULL as errp argument but error occurs in property setter, > it is silently discarded leaving object in undefined state. > > As result it leads to hard to find bugs, so if cal

[Qemu-devel] [PATCH qom v1 1/1] qom/object.c: Split out object and class caches.

2013-11-27 Thread Peter Crosthwaite
The object-cast and class-cast caches cannot be shared because class caching is conditional on the target type not being an interface and object caching is unconditional. Leads to a bug when a class cast to an interface follows an object cast to the same interface type: FooObject = FOO(obj); FooCl

Re: [Qemu-devel] outlined TLB lookup on x86

2013-11-27 Thread Xin Tong
On Wed, Nov 27, 2013 at 6:12 PM, Richard Henderson wrote: > On 11/27/2013 08:41 PM, Xin Tong wrote: > > I am trying to implement a out-of-line TLB lookup for QEMU > softmmu-x86-64 on > > x86-64 machine, potentially for better instruction cache performance, I > have a > > few questions. > > > > 1

Re: [Qemu-devel] [PATCH V6 0/6] qcow2: rollback the modification on fail in snapshot creation

2013-11-27 Thread Wenchao Xia
Hi, Any comments for it? respin?

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-27 Thread Zhanghaoyu (A)
>> > I don't think a workqueue is even needed. You just need to use >> > call_rcu to free "old" after releasing kvm->irq_lock. >> > >> > What do you think? >> >> It should be rate limited somehow. Since it guest triggarable guest >> may cause host to allocate a lot of memory this way. > Why do

Re: [Qemu-devel] [PATCH v5 4/7] block: Add checks of blocker in block operations

2013-11-27 Thread Fam Zheng
On 2013年11月27日 00:13, Paolo Bonzini wrote: Il 26/11/2013 05:05, Fam Zheng ha scritto: --- a/blockdev.c +++ b/blockdev.c @@ -1001,6 +1001,11 @@ SnapshotInfo *qmp_blockdev_snapshot_delete_internal_sync(const char *device, return NULL; } +if (bdrv_op_is_blocked(bs, BLOCK_OP_TY

[Qemu-devel] [PATCH arm-devs v2 8/8] arm/highbank.c: Fix MPCore periphbase name

2013-11-27 Thread Peter Crosthwaite
GIC_BASE_ADDR is not the base address of the GIC. Its clear from the code that this is the base address of the MPCore. Rename to MPCORE_PERIPHBASE accordingly. Signed-off-by: Peter Crosthwaite --- hw/arm/highbank.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --gi

[Qemu-devel] [PATCH arm-devs v2 7/8] arm/xilinx_zynq: Implement CBAR intialisation

2013-11-27 Thread Peter Crosthwaite
Fix the CBAR initialisation by using the newly defined static property. Zynq will now correctly init the CBAR to the SCU base address. Needed to boot Linux on the xilinx_zynq machine model. Signed-off-by: Peter Crosthwaite --- changed since v1: use error report rather than fprintf(stderr rename

[Qemu-devel] [PATCH arm-devs v2 6/8] arm/xilinx_zynq: Use object_new() rather than cpu_arm_init()

2013-11-27 Thread Peter Crosthwaite
To allow the machine model to set device properties before CPU realization. Signed-off-by: Peter Crosthwaite --- changed since v1: use error report rather than fprintf(stderr hw/arm/xilinx_zynq.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/arm/xilinx_zynq

[Qemu-devel] [PATCH arm-devs v2 5/8] arm/highbank: Fix CBAR intialisation

2013-11-27 Thread Peter Crosthwaite
Fix the CBAR initialisation by using the newly defined static property. CBAR is now set before realization, so the intended value is now actually used. So I have kinda tested this. I booted an ARM kernel on Highbank with the stock Highbank DTB. It doesnt boot (and I will be doing something wrong),

[Qemu-devel] [PATCH arm-devs v2 3/8] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Peter Crosthwaite
The reset Value of the CP15 CBAR is a vendor (machine) configurable property. If ARM_FEATURE_CBAR is set, add it as a property at post_init time. Signed-off-by: Peter Crosthwaite --- Change since v1: Re-implement as dynamic property target-arm/cpu.c | 14 ++ 1 file changed, 14 inser

[Qemu-devel] [PATCH arm-devs v2 4/8] arm/highbank: Use object_new() rather than cpu_arm_init()

2013-11-27 Thread Peter Crosthwaite
To allow the machine model to set device properties before CPU realization. Signed-off-by: Peter Crosthwaite --- changed since v1: use error_report rather than fprintf(stderr hw/arm/highbank.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/arm/highbank.c b/h

[Qemu-devel] [PATCH arm-devs v2 2/8] target-arm: Define and use ARM_FEATURE_CBAR

2013-11-27 Thread Peter Crosthwaite
Some processors (notably A9 within Highbank) define and use the CP15 configuration base address (CBAR). This is vendor specific so its best implemented as a CPU property (otherwise we would need vendor specific child classes for every ARM implementation). This patch prepares support for converting

[Qemu-devel] [PATCH arm-devs v2 1/8] qom/object: Make uintXX added properties writable

2013-11-27 Thread Peter Crosthwaite
Currently the uintXX property adders make a read only property. This is not useful for devices that want to create board (or container) configurable dynamic device properties. Fix by trivally adding property setters to object_property_add_uintXX. Signed-off-by: Peter Crosthwaite --- qom/object.

[Qemu-devel] [PATCH arm-devs v2 0/8] Fix Support for ARM A9 CBAR

2013-11-27 Thread Peter Crosthwaite
Hi Peter, This patch series fixed the Configuration base address init logic for ARM CPUs, most notably for A9. Fixes both Zynq and Highbank which both had broken CBAR. Regards, Peter Changed since v1: Fix QOM to support writeable dynamic properties Use dynamic props instead (PMM/AF discussion) U

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2013-11-27 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/739785 Title: qemu-i386 user mode can't fork (bash: fork: Invalid argument) Stat

[Qemu-devel] [Bug 1239008] Re: qemu fails to scroll screen on ^Vidmem output

2013-11-27 Thread Serge Hallyn
Thanks for reporting this bug. Is there any other reproducer you can give us? ** No longer affects: kvm (Ubuntu) ** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: New => Incomplete ** Changed in: qemu Status: New => In

[Qemu-devel] usecase for QEMU

2013-11-27 Thread Xin Tong
I am wondering what are some of the use cases for QEMU as an instruction set emulator(not KVM). I know QEMU is used for the android emulator and QEMU is used to host a few cycle accurate simulators ? what else ? Thank you, Xin

Re: [Qemu-devel] outlined TLB lookup on x86

2013-11-27 Thread Richard Henderson
On 11/27/2013 08:41 PM, Xin Tong wrote: > I am trying to implement a out-of-line TLB lookup for QEMU softmmu-x86-64 on > x86-64 machine, potentially for better instruction cache performance, I have a > few questions. > > 1. I see that tcg_out_qemu_ld_slow_path/tcg_out_qemu_st_slow_path are > gen

Re: [Qemu-devel] outlined TLB lookup on x86

2013-11-27 Thread Xin Tong
Hi LIuis we can probably generate vector intrinsics using the tcg, e.g. add support to tcg to emit vector instructions directly in code cache why would a larger TLB make some operations slower, the TLB is a direct-mapped hash and lookup should be O(1) there. In the cputlb, the CPU_TLB_SIZE is a

[Qemu-devel] [PATCH v2 2/2] qemu-iotests: Add sample image and test for VMDK version 3

2013-11-27 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/059| 5 + tests/qemu-iotests/059.out| 5 + tests/qemu-iotests/sample_images/iotest-version3.vmdk.bz2 | Bin 0 -> 414 bytes 3 files changed, 10 insertions(+) create mode

Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Peter Crosthwaite
On Wed, Nov 27, 2013 at 9:47 PM, Peter Maydell wrote: > On 27 November 2013 11:39, Peter Crosthwaite > wrote: >> Is the "periphbase" ever runtime configurable? If not I'm not sure we >> need the "reset". > > You can't runtime configure it (it's a bunch of signals into the > core that determine wh

[Qemu-devel] [PATCH v2 1/2] vmdk: Allow read only open of VMDK version 3

2013-11-27 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/vmdk.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index a7ebd0f..6fd20dc 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -605,13 +605,20 @@ static int vmdk_open_vmdk4(BlockDriverState *bs, hea

[Qemu-devel] [PATCH v2 0/2] vmdk: Allow version 3 read only open

2013-11-27 Thread Fam Zheng
According to an update on VMware Knowledge Base [KB 2064959], we should be safe to open version 3 as read only. This is meaningful as an compatibility improvement, so let's enable it. v2: [01] Parentheses around "flags & BDRV_O_RDWR". (Paolo) Add comments. (Stefan) Fam Zheng (2): vmdk

Re: [Qemu-devel] [PATCH 0/5] qemu-io: readline command completion

2013-11-27 Thread Luiz Capitulino
On Thu, 14 Nov 2013 11:54:13 +0100 Stefan Hajnoczi wrote: > This series decouples readline.c from the QEMU monitor and then reuses it in > qemu-io. This adds history and command completion to the qemu-io interactive > prompt. I don't know what's the state of this series, but I reviewed the HMP

[Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-27 Thread Igor Mammedov
in case if caller setting property doesn't care about error and passes in NULL as errp argument but error occurs in property setter, it is silently discarded leaving object in undefined state. As result it leads to hard to find bugs, so if caller doesn't care about error it must be sure that prope

Re: [Qemu-devel] [RFC qom-cpu v4 05/10] qmp: add 'cpu-del' command support

2013-11-27 Thread Chen Fan
On Wed, 2013-11-27 at 07:00 -0700, Eric Blake wrote: > On 10/09/2013 03:43 AM, Chen Fan wrote: > > Signed-off-by: Chen Fan > > --- > > hw/i386/pc.c | 6 ++ > > hw/i386/pc_piix.c| 3 ++- > > include/hw/boards.h | 2 ++ > > include/hw/i386/pc.h | 1 + > > qapi-schema.json |

Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event

2013-11-27 Thread Luiz Capitulino
On Wed, 13 Nov 2013 09:44:52 +0800 Wenchao Xia wrote: > Nested structure is not supported now, so following define is not valid: > { 'event': 'EVENT_C', > 'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' } I think your general approach is reasonable, but there are a number of details

[Qemu-devel] [PATCH v2] hw/i386/pc_sysfw: support two flash drives

2013-11-27 Thread Laszlo Ersek
This patch allows the user to usefully specify -drive file=img_1,if=pflash,format=raw,readonly \ -drive file=img_2,if=pflash,format=raw on the command line. The flash images will be mapped under 4G in their reverse unit order -- that is, with their base addresses progressing downwards, in inc

[Qemu-devel] [PATCH 07/16] target-i386: cpu: convert 'stepping' to static property

2013-11-27 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v3: - cpu_x86_properties changed to x86_cpu_properties, upstream rebase on top of it. v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) dif

[Qemu-devel] [PATCH 02/16] target-i386: cleanup 'foo=val' feature handling

2013-11-27 Thread Igor Mammedov
features family, model, stepping, level, hv_spinlocks are treated similarly when passed from command line, so it's not necessary to handle each of them individually. Collapse them to one catch-all branch which will treat any not explicitly handled feature in format 'foo=val'. PS: Any unknown featu

[Qemu-devel] [PATCH 09/16] target-i386: cpu: convert 'model-id' to static property

2013-11-27 Thread Igor Mammedov
* check "if (model_id == NULL)" looks unnecessary now, since all builtin model-ids are not NULL and user shouldn't be able to set it NULL (cpumodel string parsing code takes care of it, if feature is specified as "model-id=" on command line, its parsing will result in an empty string as value). Si

[Qemu-devel] [PATCH 10/16] target-i386: cpu: convert 'tsc-frequency' to static property

2013-11-27 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v3: - cpu_x86_properties changed to x86_cpu_properties upstream, rebase on top of it. v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) d

[Qemu-devel] [PATCH 04/16] target-i386: cpu: convert 'xlevel' to static property

2013-11-27 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v22: - cpu_x86_properties changed to x86_cpu_properties, upstream rebase on top of it. --- target-i386/cpu.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 0f1066a..8a1f786 1

[Qemu-devel] [PATCH 16/16] target-i386: cpu: fix invalid use of error_is_set(errp) if errp == NULL

2013-11-27 Thread Igor Mammedov
in generic case errp may be NULL and if an Error gets raised in visitor but not set to *errp for the lack of pointer, value might be uninitialized: object_property_parse(obj, "invalid value", "foo", NULL); and accessed futher in property setter leading to incorrect property value of object instance

[Qemu-devel] [PATCH] Fix QEMU build on OpenBSD on x86 archs

2013-11-27 Thread Brad Smith
This resolves the build issue with building the ROMs on OpenBSD on x86 archs. As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the whole OS/packages and so forth. The ROMs need to have PIE disabled. This is my initial attempt at trying to get somehting upstream so that QEMU bo

[Qemu-devel] [PATCH 01/16] target-i386: cleanup 'foo' feature handling'

2013-11-27 Thread Igor Mammedov
features check, enforce, hv_relaxed and hv_vapic are treated as boolean set to 'on' when passed from command line, so it's not neccessary to handle each of them separetly. Collapse them to one catch-all branch which will treat any feature in format 'foo' as boolean set to 'on'. PS: Any unknown fe

[Qemu-devel] [PATCH 03/16] target-i386: cpu: convert 'level' to static property

2013-11-27 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: - cpu_x86_properties changed to x86_cpu_properties, upstream rebase on top of it. --- target-i386/cpu.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 34d3968..0f1066a 10

[Qemu-devel] [PATCH 15/16] target-i386: remove unused *_feature_name arrays

2013-11-27 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: fix conflict when removing kvm_feature_name[] with "kvm_pv_unhalt" added by f010bc6 "target-i386: add feature kvm_pv_unhalt", earlier patch "target-i386: set [+-]feature using static properties" were ammended to include "feat-kvm-pv-unhalt" as static proper

[Qemu-devel] [PATCH 14/16] target-i386: use static properties to list CPUID features

2013-11-27 Thread Igor Mammedov
- it breaks compatibility with previous output format by printing all features in one string with "feat-" prefixes and all "_" replaced by "-" Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 44 ++-- 1 file changed, 10 insertions(+), 34 deletions(-)

[Qemu-devel] [PATCH 12/16] qdev: introduce qdev_prop_find_bit()

2013-11-27 Thread Igor Mammedov
helper to find a static property corresponding to a specific bit in a specified field. Signed-off-by: Igor Mammedov --- hw/core/qdev-properties.c| 15 +++ include/hw/qdev-properties.h | 13 + 2 files changed, 28 insertions(+) diff --git a/hw/core/qdev-properties.c b/

[Qemu-devel] [PATCH 11/16] target-i386: set [+-]feature using static properties

2013-11-27 Thread Igor Mammedov
* Define static properties for cpuid feature bits * property names of CPUID feature bits are changed to have "feat-" prefix, so that it would be easy to distinguish them from other properties. * Convert [+-]cpuid_features to a set(QDict) of key, value pairs, where +foo => (f

[Qemu-devel] [PATCH 13/16] target-i386: use static properties in check_features_against_host() to print CPUID feature names

2013-11-27 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 1503e9a..5c3455f 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1119,24 +1119,6 @@ sta

[Qemu-devel] [PATCH 06/16] target-i386: cpu: convert 'model' to static property

2013-11-27 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v3: - cpu_x86_properties changed to x86_cpu_properties, upstream rebase on top of it. v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 08/16] target-i386: cpu: convert 'vendor' to static property

2013-11-27 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v4: - fix invalid use of error_is_set(errp) if errp == NULL v3: - cpu_x86_properties changed to x86_cpu_properties upstream, rebase on top of it. v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 29 +

[Qemu-devel] [PATCH 05/16] target-i386: cpu: convert 'family' to static property

2013-11-27 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v3: - cpu_x86_properties changed to x86_cpu_properties, upstream rebase on top of it. v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) d

[Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU features into properties

2013-11-27 Thread Igor Mammedov
Changes since v9: * rebased on top of https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next based on v1.7.0-rc2 release, fixing several conflicts * skipped patches already commited to qom-cpu-next * fixed conflit introduced by f010bc6 "target-i386: add feature kvm_pv_unhalt", patc

Re: [Qemu-devel] [PATCH for-1.7] Fix QEMU build on OpenBSD on x86 archs

2013-11-27 Thread Brad Smith
On Wed, Nov 27, 2013 at 11:32:51AM -0800, Anthony Liguori wrote: > Brad Smith writes: > > > This resolves the build issue with building the ROMs on OpenBSD on x86 > > archs. > > As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the > > whole OS/packages and so forth. The ROM

Re: [Qemu-devel] [Bug 1253777] Re: OpenBSD VM running on OpenBSD host has sleep calls taking twice as long as they should

2013-11-27 Thread Martin van den Nieuwelaar
I downloaded 1.7.0-rc2 and compiled it. Running it, I see the version number reported as 1.6.92!? In any case, I don't see any improvement, ie. the bug is still there. Regards, -Martin On 28/11/13 01:58, Paolo Bonzini wrote: > Hi, please test qemu 1.7.0-rc. There were several changes to the

Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation

2013-11-27 Thread Richard Henderson
On 11/27/2013 12:56 AM, Claudio Fontana wrote: > On 09/27/2013 09:42 PM, Richard Henderson wrote: >> On 09/26/2013 05:48 PM, Alexander Graf wrote: >>> +if (setflags) { >>> +tcg_dst = cpu_reg(dest); >>> +} else { >>> +tcg_dst = cpu_reg_sp(dest); >>> +} >> >> Never sp for

[Qemu-devel] [Bug 1254672] Re: ps segfaults with qemu-{arm, armel, mips, powerpc}-static

2013-11-27 Thread Ken Sharp
** Summary changed: - ps segfaults with qemu-arm-static + ps segfaults with qemu-{arm,armel,mips,powerpc}-static -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1254672 Title: ps segfaults with qemu

Re: [Qemu-devel] [PATCH 02/20] target-i386: convert 'hv_spinlocks' to static property

2013-11-27 Thread Igor Mammedov
On Wed, 27 Nov 2013 18:55:57 +0100 Andreas Färber wrote: > Am 16.07.2013 00:25, schrieb Igor Mammedov: > > Signed-off-by: Igor Mammedov > > --- > > v2: > > - rebase on top of hyperv_spinlock_attempts in X86CPU > > --- > > target-i386/cpu.c | 48 +++-

Re: [Qemu-devel] [Bug 1253777] Re: OpenBSD VM running on OpenBSD host has sleep calls taking twice as long as they should

2013-11-27 Thread Martin van den Nieuwelaar
I'll have a look at it now. Regards, -Martin On 28/11/13 01:58, Paolo Bonzini wrote: > Hi, please test qemu 1.7.0-rc. There were several changes to the timer > machinery that can help this bug. > -- R A Ward Ltd. | We take the privacy of our customers seriously. Christchurch | All sensitiv

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-27 Thread Markus Armbruster
Laszlo Ersek writes: > On 11/27/13 18:22, Markus Armbruster wrote: > >> Perhaps the proper way to back partially writable flash contents isn't >> splitting it into two devices, but backing a single device with a COW. >> The backing file has initial contents (say BIOS image), the delta may >> have

[Qemu-devel] [PATCH] block: Close backing file early in bdrv_img_create

2013-11-27 Thread Max Reitz
Leaving the backing file open although it is not needed anymore can cause problems if it is opened through a block driver which allows exclusive access only and if the create function of the block driver used for the top image (the one being created) tries to close and reopen the image file (which

[Qemu-devel] [PATCH 3/7] target-i386: Move KVM default-vendor hack to instance_init

2013-11-27 Thread Eduardo Habkost
As we will not have a cpu_x86_find_by_name() function anymore, move the KVM default-vendor hack to instance_init. Unfortunately we can't move that code to class_init because it depends on KVM being initialized. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 32 +++---

[Qemu-devel] [RFC 7/7] target-i386: CPU model subclasses

2013-11-27 Thread Eduardo Habkost
Register separate QOM classes for each x86 CPU model. This will allow management code to more easily probe what each CPU model provides, by simply creating objects using the appropriate class name, without having to restart QEMU. This also allows us to eliminate the qdev_prop_set_globals_for_type

[Qemu-devel] [PATCH 5/7] target-i386: Call x86_cpu_load_def() earlier

2013-11-27 Thread Eduardo Habkost
As we will initialize the X86CPU fields on instance_init eventually, move the code that initializes the X86CPU data based on the CPU model name closer to the object_new() call. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH 6/7] target-i386: Rename x86_def_t to X86CPUDefinition

2013-11-27 Thread Eduardo Habkost
As the new X86CPU subclass code is going to change lots of the code invoving x86_def_t, let's rename the struct to match coding style first. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/targe

[Qemu-devel] [PATCH 4/7] target-i386: Rename cpu_x86_register() to x86_cpu_load_def()

2013-11-27 Thread Eduardo Habkost
There isn't any kind of "registration" involved in cpu_x86_register() anymore: it is simply looking up a CPU model name and loading the model definition data into the X86CPU object. Rename it to x86_cpu_load_def() to reflect what it does. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 6

[Qemu-devel] [PATCH 2/7] target-i386: Don't change x86_def_t struct on cpu_x86_register()

2013-11-27 Thread Eduardo Habkost
As eventually the x86_def_t data is going to be provided by the CPU class, it's better to not touch it, and handle the special cases on the X86CPU object itself. Current behavior of the code should stay exactly the same. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 11 ++- 1 f

[Qemu-devel] [PATCH 0/7] x86 CPU subclasses, take 6

2013-11-27 Thread Eduardo Habkost
I want to try to get this in 1.8, because I have found one additional use-case for the new subclasses: libvirt needs to be able to query details about the existing CPU models, and it can't do that today without restarting QEMU every time. Having separate classes for each CPU model allows libvirt t

Re: [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none

2013-11-27 Thread Anthony Liguori
Kevin Wolf writes: > Am 26.11.2013 um 19:02 hat Anthony Liguori geschrieben: >> Max Reitz writes: >> >> > This series fixes the drive-mirror blockjob in case of "none" sync mode >> > to always use the old (current) image file as the backing file of the >> > newly created mirrored file (in case

[Qemu-devel] [PATCH 1/7] target-i386: Eliminate CONFIG_KVM #ifdefs

2013-11-27 Thread Eduardo Habkost
The compiler is capable of eliminating the KVM-specific function calls as long as the calling function has an assert(kvm_enabled()) line, so we don't need to wrap all KVM-specific inside #ifdefs. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 13 ++--- 1 file changed, 2 insertion

Re: [Qemu-devel] [PATCH for-1.7] Fix QEMU build on OpenBSD on x86 archs

2013-11-27 Thread Anthony Liguori
Brad Smith writes: > This resolves the build issue with building the ROMs on OpenBSD on x86 archs. > As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the > whole OS/packages and so forth. The ROMs need to have PIE disabled. This > is my initial attempt at trying to get someh

[Qemu-devel] [PATCH] coroutine: remove qemu_co_queue_wait_insert_head

2013-11-27 Thread Marc-André Lureau
qemu_co_queue_wait_insert_head() is unused in qemu code base now. Signed-off-by: Marc-André Lureau --- include/block/coroutine.h | 6 -- qemu-coroutine-lock.c | 8 2 files changed, 14 deletions(-) diff --git a/include/block/coroutine.h b/include/block/coroutine.h index 4d5c0cf.

[Qemu-devel] [PATCH v3] i386: Add _PXM ACPI method to CPU objects

2013-11-27 Thread Vasilis Liaskovitis
This patch adds a _PXM method to ACPI CPU objects for the pc machine. The _PXM value is derived from the passed in guest info, same way as CPU SRAT entries. Currently, CPU SRAT entries are only enabled for cpus that are already present in the system. The SRAT entries for hotpluggable processors ar

Re: [Qemu-devel] [PATCH 02/20] target-i386: convert 'hv_spinlocks' to static property

2013-11-27 Thread Igor Mammedov
On Wed, 27 Nov 2013 18:55:57 +0100 Andreas Färber wrote: > Am 16.07.2013 00:25, schrieb Igor Mammedov: > > Signed-off-by: Igor Mammedov > > --- > > v2: > > - rebase on top of hyperv_spinlock_attempts in X86CPU > > --- > > target-i386/cpu.c | 48 +++-

Re: [Qemu-devel] [PATCH 02/20] target-i386: convert 'hv_spinlocks' to static property

2013-11-27 Thread Paolo Bonzini
Il 27/11/2013 18:55, Andreas Färber ha scritto: > Am 16.07.2013 00:25, schrieb Igor Mammedov: >> Signed-off-by: Igor Mammedov >> --- >> v2: >> - rebase on top of hyperv_spinlock_attempts in X86CPU >> --- >> target-i386/cpu.c | 48 +++- >> 1 file change

Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-27 Thread Eric Blake
On 11/20/2013 07:38 PM, Igor Mammedov wrote: > - implements QEMU hardware part of memory hotplug protocol > described at "docs/specs/acpi_mem_hotplug.txt" > - handles only memory add notification event for now > > Signed-off-by: Igor Mammedov > --- > +0xa00: > + read access: > + [0x0-0x3

Re: [Qemu-devel] [PATCH 02/20] target-i386: convert 'hv_spinlocks' to static property

2013-11-27 Thread Andreas Färber
Am 16.07.2013 00:25, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > --- > v2: > - rebase on top of hyperv_spinlock_attempts in X86CPU > --- > target-i386/cpu.c | 48 +++- > 1 file changed, 47 insertions(+), 1 deletion(-) > > diff --git a/targ

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-27 Thread Laszlo Ersek
On 11/27/13 18:22, Markus Armbruster wrote: > Perhaps the proper way to back partially writable flash contents isn't > splitting it into two devices, but backing a single device with a COW. > The backing file has initial contents (say BIOS image), the delta may > have additional contents (say non-

Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-27 Thread Markus Armbruster
Igor Mammedov writes: > On Wed, 27 Nov 2013 15:35:09 +0100 > Markus Armbruster wrote: > >> Igor Mammedov writes: >> >> > On Tue, 26 Nov 2013 15:49:05 +0100 >> > Markus Armbruster wrote: >> > >> >> Igor Mammedov writes: >> >> >> >> > On Thu, 21 Nov 2013 11:12:43 +0100 >> >> > Markus Armbrust

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-27 Thread Markus Armbruster
Laszlo Ersek writes: > On 11/27/13 15:45, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> On 11/27/13 14:52, Markus Armbruster wrote: Jordan Justen writes: > On Tue, Nov 26, 2013 at 5:32 AM, Laszlo Ersek wrote: >> On 11/26/13 13:36, Markus Armbruster wrote: >> >>

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-11-27 Thread Paolo Bonzini
Il 27/11/2013 18:02, Markus Armbruster ha scritto: > I have to admit I can't tell offhand what the heck QMP's netdev_add > accepts, because I don't understand what "'*props:': '**'" means in > qapi-schema.json. Even today, we permit code to serve as documentation > and specification for new featur

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > Il 27/11/2013 15:15, Markus Armbruster ha scritto: >> This is unfortunately a counter-example to the rule that HMP commands >> should always be implemented in terms of their QMP counterparts. I do >> not believe this is really a problem. It can be fixed la

Re: [Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-27 Thread Andrea Arcangeli
On Tue, Nov 26, 2013 at 12:17:09PM +0100, Paolo Bonzini wrote: > Il 26/11/2013 12:07, Lei Li ha scritto: > > For this, I am not quite sure I understand it correctly, seems the latest > > update of post copy migration was sent on last Oct, would you please give > > some insights on what else could I

Re: [Qemu-devel] [PATCH V16 09/11] NUMA: set guest numa nodes memory policy

2013-11-27 Thread Andrew Jones
On Wed, Nov 27, 2013 at 03:35:53PM +0100, Paolo Bonzini wrote: > > + > > +len = numa_info[nodeid].node_mem; > > +bind_mode = node_parse_bind_mode(nodeid); > > +unsigned long *nodes = numa_info[nodeid].host_mem; > > + > > +/* This is a workaround for a long standing bug in Linux' > >

Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure

2013-11-27 Thread Igor Mammedov
On Wed, 27 Nov 2013 08:25:22 -0700 Eric Blake wrote: > On 11/20/2013 07:38 PM, Igor Mammedov wrote: > > Provides framework for splitting host RAM allocation/ > > policies into a separate backend that could be used > > by devices. It would allow to separate host specific > > options from device mo

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-11-27 Thread Paolo Bonzini
Il 27/11/2013 15:15, Markus Armbruster ha scritto: >>> >> This is unfortunately a counter-example to the rule that HMP commands >>> >> should always be implemented in terms of their QMP counterparts. I do >>> >> not believe this is really a problem. It can be fixed later; for now, I >>> >> think

Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure

2013-11-27 Thread Paolo Bonzini
Il 27/11/2013 15:37, Igor Mammedov ha scritto: > It looks like "realize" for -object / object-add implemented via > an interface. It does---but without unrealize and with the additional get_base_path. > Maybe it should be renamed from QOMCommandLineIface to QOMRealizeIface > and s/complete/realiz

Re: [Qemu-devel] [RFC PATCH v2] i386: Add _PXM ACPI method to CPU objects

2013-11-27 Thread Paolo Bonzini
Il 27/11/2013 16:53, Igor Mammedov ha scritto: > Patch looks good, > Please add patch to update hw/i386/ssdt-proc.hex.generated for hosts without > iasl > for completness Also please rename PXM to CPXM or CPPX for consistency. Paolo >> > >> > --- >> > hw/i386/acpi-build.c |5 + >> >

Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure

2013-11-27 Thread Igor Mammedov
On Wed, 27 Nov 2013 16:21:23 +0100 Paolo Bonzini wrote: > Il 27/11/2013 15:37, Igor Mammedov ha scritto: > > It looks like "realize" for -object / object-add implemented via > > an interface. > > It does---but without unrealize and with the additional get_base_path. > > > Maybe it should be ren

Re: [Qemu-devel] [RFC PATCH v2] i386: Add _PXM ACPI method to CPU objects

2013-11-27 Thread Igor Mammedov
On Wed, 27 Nov 2013 14:02:43 +0100 Vasilis Liaskovitis wrote: > This patch adds a _PXM method to ACPI CPU objects for the pc machine. The _PXM > value is derived from the passed in guest info, same way as CPU SRAT entries. > > Currently, CPU SRAT entries are only enabled for cpus that are alread

Re: [Qemu-devel] [PATCH 0/2] vmdk: Allow version 3 read only open

2013-11-27 Thread Stefan Hajnoczi
On Wed, Nov 27, 2013 at 10:06:29AM +0800, Fam Zheng wrote: > According to an update on VMware Knowledge Base [KB 2064959], we should be > safe > to open version 3 as read only. This is meaningful as an compatibility > improvement, so let's enable it. Acked-by: Stefan Hajnoczi But please add a c

  1   2   >