Re: [Qemu-devel] [PATCH 1.7 0/2] PPC: Fix BookE timer performance regression

2013-11-22 Thread Stefan Weil
Am 23.11.2013 05:08, schrieb Stefan Weil: > Good morning Alexander, > > I have two small remarks: > > Patch 1: Could you please use 'QemuTimer' instead of 'struct QEMUTimer' > in the modified lines of code? Sorry, QEMUTimer, of course. The 'struct' keyword is redundant and should be avoided.

Re: [Qemu-devel] [PATCH 1.7 0/2] PPC: Fix BookE timer performance regression

2013-11-22 Thread Stefan Weil
Am 23.11.2013 04:53, schrieb Alexander Graf: > Thanks to the new timer infrastructure we are now able to trigger timer events > and ridiculous granularities in sub-microsecond orders. > > However, the BookE targets were quite unhappy about that change, showing up > to x10 slowdown on a simple Linux

[Qemu-devel] [PATCH 1.7 0/2] PPC: Fix BookE timer performance regression

2013-11-22 Thread Alexander Graf
Thanks to the new timer infrastructure we are now able to trigger timer events and ridiculous granularities in sub-microsecond orders. However, the BookE targets were quite unhappy about that change, showing up to x10 slowdown on a simple Linux guest bootup test. This patch set makes the constant

[Qemu-devel] [PATCH 2/2] PPC: BookE: Make FIT/WDT timers at best microsecond grained

2013-11-22 Thread Alexander Graf
The default granularity for the FIT timer on 440 is on every 0x1000th transition of TB from 0 to 1. Translated that means 48828 times a second. Since interrupts are quite expensive for 440 and we don't really care about the accuracy of the FIT to that significance, let's force FIT and WDT to at be

[Qemu-devel] [PATCH 1/2] PPC: Make BookE FIT/WDT timers more lazy

2013-11-22 Thread Alexander Graf
Today we fire FIT and WDT timer events every time the respective bit position in TB flips from 0 -> 1. However, there is no need to do this if the end result would be that we're changing a TSR bit that is set to 1 to 1 again. No guest visible change would have occured. So whenever we see that the

Re: [Qemu-devel] [PULL for-1.7 5/5] Revert "e1000/rtl8139: update HMP NIC when every bit is written"

2013-11-22 Thread Amos Kong
On Thu, Nov 21, 2013 at 05:14:36PM +0200, Michael S. Tsirkin wrote: > This reverts commit cd5be5829c1ce87aa6b3a7806524fac07ac9a757. > Digging into hardware specs shows this does not > actually make QEMU behave more like hardware: > > There are valid arguments backed by the spec to indicate why the

Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Laszlo Ersek
On 11/22/13 21:51, Jordan Justen wrote: > Many of these scenarios were discussed in the past on qemu-devel, but > a single -pflash was the only thing that stuck. This has made me just > focus on making the single file pflash work. I almost forgot to reflect on this -- I'm extremely grateful to yo

Re: [Qemu-devel] [edk2 PATCH 1/1] OvmfPkg/AcpiPlatformDxe: download ACPI tables from QEMU

2013-11-22 Thread Jordan Justen
On Fri, Nov 22, 2013 at 10:49 AM, Laszlo Ersek wrote: > On 11/22/13 19:10, Jordan Justen wrote: >> Do we need to print all those fields? >> >> Anyway, maybe a better centralized place for this would be: >> MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c >> >> Also, I think we try to k

Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Laszlo Ersek
On 11/22/13 21:51, Jordan Justen wrote: > On Fri, Nov 22, 2013 at 10:43 AM, Laszlo Ersek wrote: >> OTOH building all three FDs per default might be confusing for >> end-users. We know for a fact that they usually don't read the README >> (or not thoroughly enough). If we only give them one output

Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Jordan Justen
On Fri, Nov 22, 2013 at 12:54 PM, Eric Blake wrote: > On 11/22/2013 01:51 PM, Jordan Justen wrote: > >> Tangentially related idea: if the user specifies -pflash to a >> non-existent file, then QEMU could copy 'pflash-$(arch).bin' from the >> roms folder into that file, and then the use it for the

Re: [Qemu-devel] [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service

2013-11-22 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-11-01 16:47:25) > Currently, qemu-ga for Windows fails to execute guset-fsfreeze-freeze when > no user is logging in to Windows, with an error message: > {"error":{"class":"GenericError", > "desc":"failed to add C:\\ to snapshotset: (error: 8004230f)"}}

[Qemu-devel] [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service

2013-11-22 Thread Michael Roth
From: Tomoki Sekiyama Currently, qemu-ga for Windows fails to execute guset-fsfreeze-freeze when no user is logging in to Windows, with an error message: {"error":{"class":"GenericError", "desc":"failed to add C:\\ to snapshotset: (error: 8004230f)"}} To enable guest-fsfreeze-free

[Qemu-devel] [PULL 0/1 for-1.7] qemu-ga fsfreeze fix for Windows

2013-11-22 Thread Michael Roth
Hi Anthony, Please pull the following fix, which allows guest-freeze-fsfreeze to be executed while a user is not logged in to the guest. The following changes since commit 607bb022f2a44797cbf40e85e84da4134e2f0e01: Update version for 1.7.0-rc1 release (2013-11-21 08:11:47 -0800) are available

Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Eric Blake
On 11/22/2013 01:51 PM, Jordan Justen wrote: > Tangentially related idea: if the user specifies -pflash to a > non-existent file, then QEMU could copy 'pflash-$(arch).bin' from the > roms folder into that file, and then the use it for the flash. It > could make using a flash almost as easy as usin

Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Jordan Justen
On Fri, Nov 22, 2013 at 10:43 AM, Laszlo Ersek wrote: > OTOH building all three FDs per default might be confusing for > end-users. We know for a fact that they usually don't read the README > (or not thoroughly enough). If we only give them one output file per > default, that's less potential for

Re: [Qemu-devel] [PATCH v4 6/7] qmp: add command 'blockdev-backup'

2013-11-22 Thread Eric Blake
On 11/21/2013 10:24 PM, Fam Zheng wrote: > Similar to drive-backup, but this command uses a device id as target > instead of creating/opening an image file. > > Also add blocker on target bs, since the target is also a named device > now. > > Signed-off-by: Fam Zheng > --- > +++ b/qapi-schema.j

Re: [Qemu-devel] [PATCH v4 1/7] qapi: Add BlockOperationType enum

2013-11-22 Thread Eric Blake
On 11/21/2013 10:24 PM, Fam Zheng wrote: > This adds the enum of all the operations that can be taken on a block > device. > > Signed-off-by: Fam Zheng > --- > qapi-schema.json | 25 + > 1 file changed, 25 insertions(+) > > ## > +# @BlockOperationType > +# Type of a

Re: [Qemu-devel] GIT master fails compilation for ACPI

2013-11-22 Thread Erik Rull
Paolo Bonzini wrote: Il 22/11/2013 12:16, Erik Rull ha scritto: It's getting more and more complex to build qemu, is there a reason why everyone needs to build the acpi stuff by himself? It is only attempted if iasl is installed but as you said below, your version is too old. Please run "make

Re: [Qemu-devel] [RFC PATCH v3 0/2] Point-in-time snapshot exporting over NBD

2013-11-22 Thread Ian Main
On Fri, Nov 22, 2013 at 01:47:26PM +0800, Fam Zheng wrote: > On 2013年11月20日 10:32, Ian Main wrote: > >On Thu, Oct 17, 2013 at 01:36:41PM +0800, Fam Zheng wrote: > >>This series adds for point-in-time snapshot NBD exporting based on > >>blockdev-backup (variant of drive-backup with existing device a

Re: [Qemu-devel] [PATCH] vfio-pci: Release all MSI-X vectors when disabled

2013-11-22 Thread Bandan Das
Alex Williamson writes: > We were relying on msix_unset_vector_notifiers() to release all the > vectors when we disable MSI-X, but this only happens when MSI-X is > still enabled on the device. Perform further cleanup by releasing > any remaining vectors listed as in-use after this call. This c

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-22 Thread Laszlo Ersek
On 11/22/13 13:21, Markus Armbruster wrote: > Laszlo Ersek writes: > >> This patch allows the user to usefully specify >> >> -drive file=img_1,if=pflash,format=raw,readonly \ >> -drive file=img_2,if=pflash,format=raw >> >> on the command line. The flash images will be mapped under 4G in their

[Qemu-devel] [PATCH] kvm: Query KVM for available memory slots

2013-11-22 Thread Alex Williamson
KVM reports the number of available memory slots (KVM_CAP_NR_MEMSLOTS) using the extension interface. Both x86 and s390 implement this, ARM and powerpc do not yet enable it. Convert the static slots array to be dynamically allocated, supporting more slots when available. Default to 32 when KVM_CA

Re: [Qemu-devel] [PATCH v9 10/11] target-arm: Provide '-cpu host' when running KVM

2013-11-22 Thread Christoffer Dall
On Fri, Nov 22, 2013 at 06:50:47PM +, Peter Maydell wrote: > On 22 November 2013 18:25, Christoffer Dall > wrote: > > On Fri, Nov 22, 2013 at 05:17:17PM +, Peter Maydell wrote: > >> +bool kvm_arm_create_scratch_host_vcpu(const uint32_t *cpus_to_try, > >> +

Re: [Qemu-devel] [PATCH v9 10/11] target-arm: Provide '-cpu host' when running KVM

2013-11-22 Thread Peter Maydell
On 22 November 2013 18:25, Christoffer Dall wrote: > On Fri, Nov 22, 2013 at 05:17:17PM +, Peter Maydell wrote: >> +bool kvm_arm_create_scratch_host_vcpu(const uint32_t *cpus_to_try, >> + int *fdarray, >> + struct kvm_vc

Re: [Qemu-devel] [edk2 PATCH 1/1] OvmfPkg/AcpiPlatformDxe: download ACPI tables from QEMU

2013-11-22 Thread Laszlo Ersek
On 11/22/13 19:10, Jordan Justen wrote: > On Tue, Nov 12, 2013 at 7:11 AM, Laszlo Ersek wrote: >> Qemu v1.7.0-rc0 features an ACPI linker/loader interface, available over >> fw_cfg, written by Michael Tsirkin. >> >> Qemu composes all ACPI tables on the host side, according to the target >> hardwar

Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Laszlo Ersek
On 11/22/13 18:37, Jordan Justen wrote: > On Thu, Nov 21, 2013 at 2:21 PM, Laszlo Ersek wrote: >> Split the variable store off to a separate file when SPLIT_VARSTORE is >> defined. > > Is the goal to allow the central OVMF to be updated so the VM will > automatically be running the newest firmwar

Re: [Qemu-devel] [PATCH v9 10/11] target-arm: Provide '-cpu host' when running KVM

2013-11-22 Thread Christoffer Dall
On Fri, Nov 22, 2013 at 05:17:17PM +, Peter Maydell wrote: > Implement '-cpu host' for ARM when we're using KVM, broadly > in line with other KVM-supporting architectures. > > Signed-off-by: Peter Maydell > --- > target-arm/helper.c |6 ++ > target-arm/kvm.c | 224 > ++

Re: [Qemu-devel] [PATCH v9 00/11] target-arm: mach virt and -cpu host support

2013-11-22 Thread Christoffer Dall
On Fri, Nov 22, 2013 at 05:17:07PM +, Peter Maydell wrote: > This patchset combines the 'virt' machine definition and > -cpu host support patchsets I've posted previous versions > of. I think these are now ready to go in once 1.8 opens > up; review appreciated. > > Changes since previous versi

Re: [Qemu-devel] [PATCH v9 07/11] hw/arm: Add 'virt' platform

2013-11-22 Thread Christoffer Dall
On Fri, Nov 22, 2013 at 06:17:51PM +, Peter Maydell wrote: > On 22 November 2013 18:11, Christoffer Dall > wrote: > > On Fri, Nov 22, 2013 at 05:17:14PM +, Peter Maydell wrote: > >> + * Emulate a virtual board which works by passing Linux all the > >> information > >> + * it needs about

Re: [Qemu-devel] [PATCH v9 07/11] hw/arm: Add 'virt' platform

2013-11-22 Thread Peter Maydell
On 22 November 2013 18:11, Christoffer Dall wrote: > On Fri, Nov 22, 2013 at 05:17:14PM +, Peter Maydell wrote: >> + * Emulate a virtual board which works by passing Linux all the information >> + * it needs about what devices are present via the device tree. >> + * There are some restrictions

Re: [Qemu-devel] [edk2 PATCH 1/1] OvmfPkg/AcpiPlatformDxe: download ACPI tables from QEMU

2013-11-22 Thread Jordan Justen
On Tue, Nov 12, 2013 at 7:11 AM, Laszlo Ersek wrote: > Qemu v1.7.0-rc0 features an ACPI linker/loader interface, available over > fw_cfg, written by Michael Tsirkin. > > Qemu composes all ACPI tables on the host side, according to the target > hardware configuration, and makes the tables available

Re: [Qemu-devel] [PATCH v9 07/11] hw/arm: Add 'virt' platform

2013-11-22 Thread Christoffer Dall
On Fri, Nov 22, 2013 at 05:17:14PM +, Peter Maydell wrote: > Add 'virt' platform support corresponding to arch/arm/mach-virt > in the Linux kernel tree. This has no platform-specific code but > can use any device whose kernel driver is is able to work purely > from a device tree node. We use th

Re: [Qemu-devel] [PATCH v9 04/11] target-arm: Provide PSCI constants to generic QEMU code

2013-11-22 Thread Christoffer Dall
On Fri, Nov 22, 2013 at 05:17:11PM +, Peter Maydell wrote: > Provide versions of the KVM PSCI constants to non-KVM code; > this will allow us to avoid an ifdef in boards which set up > a PSCI node in the device tree. > > Signed-off-by: Peter Maydell > --- > target-arm/kvm-consts.h | 12 +++

[Qemu-devel] [PATCH v9 04/11] target-arm: Provide PSCI constants to generic QEMU code

2013-11-22 Thread Peter Maydell
Provide versions of the KVM PSCI constants to non-KVM code; this will allow us to avoid an ifdef in boards which set up a PSCI node in the device tree. Signed-off-by: Peter Maydell --- target-arm/kvm-consts.h | 12 1 file changed, 12 insertions(+) diff --git a/target-arm/kvm-cons

[Qemu-devel] [PATCH v9 11/11] hw/arm/virt: Support -cpu host

2013-11-22 Thread Peter Maydell
Support -cpu host in virt machine (treating it like an A15, ie with a GIC v2 and the A15's private peripherals.) Signed-off-by: Peter Maydell --- hw/arm/virt.c |8 1 file changed, 8 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 1e42cc2..9531b5a 100644 --- a/hw/arm/

Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Jordan Justen
On Thu, Nov 21, 2013 at 2:21 PM, Laszlo Ersek wrote: > Split the variable store off to a separate file when SPLIT_VARSTORE is > defined. Is the goal to allow the central OVMF to be updated so the VM will automatically be running the newest firmware? (While preserving variables) I think in your s

[Qemu-devel] virtio-net: network stops responding in Win2k3 server

2013-11-22 Thread Mario De Chenno
Hi all. We are facing some network issues on some Windows Server 2003 machines. In short, network seems to lock up and stops responding even to ping requests. From TCPdump on the tap interface on the server I only see arp request to the gateway, without replies. Increased tx overruns on the some in

[Qemu-devel] [PATCH v9 07/11] hw/arm: Add 'virt' platform

2013-11-22 Thread Peter Maydell
Add 'virt' platform support corresponding to arch/arm/mach-virt in the Linux kernel tree. This has no platform-specific code but can use any device whose kernel driver is is able to work purely from a device tree node. We use this to instantiate a minimal set of devices: a GIC and some virtio-mmio

[Qemu-devel] [PATCH v9 06/11] target-arm: Allow secondary KVM CPUs to be booted via PSCI

2013-11-22 Thread Peter Maydell
New ARM boards are generally expected to boot their secondary CPUs via the PSCI interface, rather than ad-hoc "loop around in holding pen code" as hw/arm/boot.c implements. In particular this is necessary for mach-virt kernels. For KVM we achieve this by creating the VCPUs with a feature flag marki

[Qemu-devel] [PATCH v9 01/11] target-arm: Provide mechanism for getting KVM constants even if not CONFIG_KVM

2013-11-22 Thread Peter Maydell
There are a number of places where it would be convenient for ARM code to have working definitions of KVM constants even in code which is compiled with CONFIG_KVM not set. In this situation we can't simply include the kernel KVM headers (which might conflict with host header definitions or not even

[Qemu-devel] [PATCH v9 05/11] target-arm: Add ARMCPU field for Linux device-tree 'compatible' string

2013-11-22 Thread Peter Maydell
Linux requires device tree CPU nodes to include a 'compatible' string describing the CPU. Add a field in the ARMCPU struct for this so that boards which construct a device tree can insert the correct CPU nodes. Note that there is currently no officially specified 'compatible' string for the TI925T

[Qemu-devel] [PATCH v9 08/11] linux-headers: Update from mainline

2013-11-22 Thread Peter Maydell
Update Linux KVM headers from mainline commit 5d6e63323fe779. Signed-off-by: Peter Maydell --- linux-headers/asm-arm/kvm.h |3 +- linux-headers/asm-powerpc/epapr_hcalls.h |4 +- linux-headers/asm-powerpc/kvm.h | 86 -- linux-headers/asm

[Qemu-devel] [PATCH v9 03/11] hw/arm/boot: Allow boards to provide an fdt blob

2013-11-22 Thread Peter Maydell
From: John Rigby If no fdt is provided on command line and the new field get_dtb in struct arm_boot_info is set then call it to get a device tree blob. Signed-off-by: John Rigby [PMM: minor tweaks and cleanup] Signed-off-by: Peter Maydell --- hw/arm/boot.c| 32 --

[Qemu-devel] [PATCH v9 09/11] target-arm: Don't hardcode KVM target CPU to be A15

2013-11-22 Thread Peter Maydell
Instead of assuming that a KVM target CPU must always be a Cortex-A15 and hardcoding this in kvm_arch_init_vcpu(), store the KVM_ARM_TARGET_* value in the ARMCPU class, and use that. Signed-off-by: Peter Maydell --- target-arm/cpu-qom.h|5 + target-arm/cpu.c|2 ++ target-

[Qemu-devel] [PATCH v9 00/11] target-arm: mach virt and -cpu host support

2013-11-22 Thread Peter Maydell
This patchset combines the 'virt' machine definition and -cpu host support patchsets I've posted previous versions of. I think these are now ready to go in once 1.8 opens up; review appreciated. Changes since previous versions: * added in -cpu host patchset, since it really only makes sense wi

[Qemu-devel] [PATCH v9 10/11] target-arm: Provide '-cpu host' when running KVM

2013-11-22 Thread Peter Maydell
Implement '-cpu host' for ARM when we're using KVM, broadly in line with other KVM-supporting architectures. Signed-off-by: Peter Maydell --- target-arm/helper.c |6 ++ target-arm/kvm.c | 224 ++ target-arm/kvm_arm.h | 55 +

[Qemu-devel] [PATCH v9 02/11] device_tree.c: Terminate the empty reservemap in create_device_tree()

2013-11-22 Thread Peter Maydell
Device trees created with create_device_tree() may not have any entries in their reservemap, because the FDT API requires that the reservemap is completed before any FDT nodes are added, and create_device_tree() itself creates a node. However we were not calling fdt_finish_reservemap(), which mean

Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-22 Thread Igor Mammedov
On Thu, 21 Nov 2013 16:38:47 +0200 "Michael S. Tsirkin" wrote: > On Thu, Nov 21, 2013 at 03:21:37PM +0100, Igor Mammedov wrote: > > On Thu, 21 Nov 2013 11:42:02 +0200 > > "Michael S. Tsirkin" wrote: [...] > > > > + [0x14] highest memory hot-plug interface version supported by > > > > QEMU

Re: [Qemu-devel] [PATCH v3 for-1.7 resend] rdma: rename 'x-rdma' => 'rdma'

2013-11-22 Thread Michael R. Hines
On 11/23/2013 12:37 AM, Daniel P. Berrange wrote: On Sat, Nov 23, 2013 at 12:29:51AM +0800, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As far as we can tell, all known bugs have been fixed: 3. Libvirt patches are ready Please stop claiming this. A proof of concept was posted a

Re: [Qemu-devel] GIT master fails compilation for ACPI

2013-11-22 Thread Paolo Bonzini
Il 22/11/2013 12:16, Erik Rull ha scritto: > It's getting more and more complex to build qemu, is there a reason why > everyone > needs to build the acpi stuff by himself? It is only attempted if iasl is installed but as you said below, your version is too old. Please run "make V=1" so that we c

Re: [Qemu-devel] [PATCH v4 0/7] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 01:24:47PM +0800, Fam Zheng wrote: > This series adds for point-in-time snapshot NBD exporting based on > blockdev-backup (variant of drive-backup with existing device as target). > > We get a thin point-in-time snapshot by COW mechanism of drive-backup, and > export it thr

Re: [Qemu-devel] [PATCH v3 for-1.7] rdma: rename 'x-rdma' => 'rdma'

2013-11-22 Thread Paolo Bonzini
Il 16/11/2013 11:32, Daniel P. Berrange ha scritto: > There's also an SELinux question to deal with there. If multiple QEMUs > need concurrent access we can't do a selective grant of the device just > when migration is running - we would have to give all QEMU's access > all the time. This would be

Re: [Qemu-devel] [PATCH v3 for-1.7 resend] rdma: rename 'x-rdma' => 'rdma'

2013-11-22 Thread Daniel P. Berrange
On Sat, Nov 23, 2013 at 12:29:51AM +0800, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > As far as we can tell, all known bugs have been fixed: > 3. Libvirt patches are ready Please stop claiming this. A proof of concept was posted and got some review feedback. AFAIK, no follo

[Qemu-devel] [PATCH v3 for-1.7 resend] rdma: rename 'x-rdma' => 'rdma'

2013-11-22 Thread mrhines
From: "Michael R. Hines" As far as we can tell, all known bugs have been fixed: 1. Parallel RDMA migrations are working 2. IPv6 migration is working 3. Libvirt patches are ready 4. virt-test is working Objections? Reviewed-by: Eric Blake Signed-off-by: Michael R. Hines --- docs/rdma.txt

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 01:24:49PM +0800, Fam Zheng wrote: > +bool bdrv_op_is_blocked(BlockDriverState *bs, BlockOpType op, Error **errp) > +{ > +BdrvOpBlocker *blocker; > +assert(op >=0 && op < BLOCK_OP_TYPE_MAX); > +if (!QLIST_EMPTY(&bs->op_blockers[op])) { > +blocker = QLIST_

[Qemu-devel] [PATCH v2 7/7] blkverify: Don't require protocol filename

2013-11-22 Thread Max Reitz
If the filename is not prefixed by "blkverify:" in blkverify_parse_filename(), the blkverify driver was not selected through that protocol prefix, but by an explicit command line option (like file.driver=blkverify). Contrary to the current reaction, this is not really a problem; the whole filename

[Qemu-devel] [PATCH v2 6/7] blkdebug: Use command-line in read_config()

2013-11-22 Thread Max Reitz
Use qemu_config_parse_qdict() to parse the command-line options in addition to the config file. Signed-off-by: Max Reitz --- block/blkdebug.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 1db999b..58bf05a 100644 ---

[Qemu-devel] [PATCH v2 4/7] qemu-option: Add qemu_config_parse_qdict()

2013-11-22 Thread Max Reitz
This function basically parses command-line options given as a QDict replacing a config file. For instance, the QDict {"section.opt1": 42, "section.opt2": 23} corresponds to the config file: [section] opt1 = 42 opt2 = 23 It is possible to specify multiple sections and also multiple sections of t

[Qemu-devel] [PATCH v2 5/7] blkdebug: Always call read_config()

2013-11-22 Thread Max Reitz
Move the check whether there actually is a config file into the read_config() function. Signed-off-by: Max Reitz --- block/blkdebug.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index b50db9d..

[Qemu-devel] [PATCH v2 3/7] qdict: Add qdict_array_split()

2013-11-22 Thread Max Reitz
This function splits a QDict consisting of entries prefixed by incrementally enumerated indices into a QList of QDicts. Signed-off-by: Max Reitz --- include/qapi/qmp/qdict.h | 1 + qobject/qdict.c | 36 2 files changed, 37 insertions(+) diff --git

[Qemu-devel] [PATCH v2 1/7] blkdebug: Use errp for read_config()

2013-11-22 Thread Max Reitz
Use an Error variable in the read_config() function. Signed-off-by: Max Reitz --- block/blkdebug.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 16d2b91..9dfa712 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -

[Qemu-devel] [PATCH v2 2/7] blkdebug: Don't require sophisticated filename

2013-11-22 Thread Max Reitz
If the filename is not prefixed by "blkdebug:" in blkdebug_parse_filename(), the blkdebug driver was not selected through that protocol prefix, but by an explicit command line option (file.driver=blkdebug or something similar). Contrary to the current reaction, this is not a problem at all; we just

[Qemu-devel] [PATCH v2 0/7] blkdebug/blkverify: Allow command-line configuration

2013-11-22 Thread Max Reitz
Currently, the configuration of blkdebug and blkverify is done through the "filename" alone. There is now way of manually choosing blkdebug or blkverify as a driver and using a normal image filename. In the case of blkdebug, the filename starts with the protocol prefix, follows up with the name of

Re: [Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space

2013-11-22 Thread Edgar E. Iglesias
Hi, no I actually had it in cpustate first but had to do env-get-cpu all over so i moved it to env. Iiuc env-get-cpu involves a dyn typecheck. I havent meassured the perf impact though. Sorry for phone email... Cheers --- Sent from my phone On Nov 22, 2013 4:51 PM, "Peter Maydell" wrote: > On

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-22 Thread Paul Moore
On Friday, November 22, 2013 04:48:41 PM Stefan Hajnoczi wrote: > On Fri, Nov 22, 2013 at 09:44:42AM -0500, Paul Moore wrote: > > On Friday, November 22, 2013 11:39:31 AM Stefan Hajnoczi wrote: > > > On Thu, Nov 21, 2013 at 10:48:58AM -0500, Paul Moore wrote: > > > > I'm always open to suggestions

Re: [Qemu-devel] GIT master fails compilation for ACPI

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 12:16:37PM +0100, Erik Rull wrote: > > On November 22, 2013 at 11:56 AM Stefan Hajnoczi wrote: > > > > > > On Thu, Nov 21, 2013 at 09:44:29PM +0100, Erik Rull wrote: > > > Hu Tao wrote: > > > >On Thu, Nov 21, 2013 at 09:06:43AM +0100, Erik Rull wrote: > > > >>Hi all, > > >

Re: [Qemu-devel] [PATCH v3 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback"

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 10:30:30AM +0100, Kevin Wolf wrote: > Am 22.11.2013 um 09:57 hat Stefan Hajnoczi geschrieben: > > On Thu, Nov 21, 2013 at 03:16:23PM +0100, Kevin Wolf wrote: > > > Am 21.11.2013 um 13:43 hat Stefan Hajnoczi geschrieben: > > > > On Wed, Nov 20, 2013 at 03:44:11PM +0800, Fam Z

Re: [Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space

2013-11-22 Thread Peter Maydell
On 22 November 2013 15:15, wrote: > @@ -176,6 +176,9 @@ typedef struct CPUWatchpoint { > sigjmp_buf jmp_env; \ > int exception_index;\ >

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 09:44:42AM -0500, Paul Moore wrote: > On Friday, November 22, 2013 11:39:31 AM Stefan Hajnoczi wrote: > > On Thu, Nov 21, 2013 at 10:48:58AM -0500, Paul Moore wrote: > > > I'm always open to suggestions on how to improve the development/debugging > > > process, so if you hav

[Qemu-devel] [RFC PATCH 7/8] exec: On AS changes, only flush affected CPU TLBs

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- exec.c |5 + 1 file changed, 5 insertions(+) diff --git a/exec.c b/exec.c index acbd2e6..f273a46 100644 --- a/exec.c +++ b/exec.c @@ -1715,6 +1715,11 @@ static void tcg_commit(MemoryListener *listener) reset the mod

[Qemu-devel] [RFC PATCH 8/8] exec: Make ldl_*_phys input an AddressSpace

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- cpu-exec.c|5 +- exec.c| 19 --- hw/dma/pl080.c|9 ++-- hw/dma/sun4m_iommu.c |3 +- hw/net/vmware_utils.h |2 +-

[Qemu-devel] [RFC PATCH 5/8] memory: Add MemoryListener to typedefs

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- include/qemu/typedefs.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h index a4c1b84..425ca1a 100644 --- a/include/qemu/typedefs.h +++ b/include/qemu/typedefs.h @@ -24,6 +24,

[Qemu-devel] [RFC PATCH 1/8] exec: Make tb_invalidate_phys_addr input an AS

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" No functional change. Signed-off-by: Edgar E. Iglesias --- exec.c|3 ++- include/exec/exec-all.h |2 +- target-xtensa/op_helper.c |3 ++- translate-all.c |4 ++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --

[Qemu-devel] [RFC PATCH 3/8] exec: Always initialize MemorySection address spaces

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- exec.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/exec.c b/exec.c index 5e17110..05df217 100644 --- a/exec.c +++ b/exec.c @@ -806,6 +806,7 @@ static void register_subpage(AddressSpaceDispatch *d, MemoryRegionSection *

[Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- cputlb.c|4 ++-- exec.c | 31 +++ include/exec/cpu-defs.h |3 +++ include/exec/exec-all.h |1 + include/exec/softmmu_template

[Qemu-devel] [RFC PATCH 0/8] Steps towards per CPU address-spaces

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Hi, I'm looking at modelling a system where multiple CPUs co-exist with different views of their attached buses/devs. With this RFC series I'm trying to take small steps towards having an address-space per CPU. This is still incomplete but I would like to get comments

[Qemu-devel] [RFC PATCH 2/8] exec: Make iotlb_to_region input an AS

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- cputlb.c|2 +- exec.c |4 ++-- include/exec/exec-all.h |2 +- include/exec/softmmu_template.h |5 +++-- 4 files changed, 7 insertions(+), 6 deletions(-) diff

[Qemu-devel] [RFC PATCH 4/8] exec: Make memory_region_section_get_iotlb use section AS

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- exec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 05df217..0162eb3 100644 --- a/exec.c +++ b/exec.c @@ -709,7 +709,7 @@ hwaddr memory_region_section_get_iotlb(CPUArchState *env,

[Qemu-devel] [RFC] hw/net: add DEC Tulip NIC emulation

2013-11-22 Thread Dmitry Smagin
From: Antony Pavlov This patch adds emulation of DEC/Intel Tulip 21143 with some external chips: * Intel LXT971A 10/100 Mbps PHY MII Tranceiver; * Microchip 93LC46B 1K Microwire Compatible Serial EEPROM. Restrictions and TODOs: - Tulip always work in promisc-mode with no packet filtering

[Qemu-devel] [RFC][PATCH] qemu-img: add support for skipping zeroes in input during convert

2013-11-22 Thread Peter Lieven
Signed-off-by: Peter Lieven --- qemu-img.c | 52 ++-- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index b6b5644..808f8f8 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1121,8 +1121,9 @@ out3: static int

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-22 Thread Paul Moore
On Friday, November 22, 2013 11:39:31 AM Stefan Hajnoczi wrote: > On Thu, Nov 21, 2013 at 10:48:58AM -0500, Paul Moore wrote: > > I'm always open to suggestions on how to improve the development/debugging > > process, so if you have any ideas please let me know. > > The failure mode is terrible:

Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane

2013-11-22 Thread Andreas Färber
Am 22.11.2013 12:20, schrieb Paolo Bonzini: > Il 22/11/2013 12:13, Peter Lieven ha scritto: >>> I see where you come from, but I think the potential for this patch to >>> break some working configuration (for some definition of working) is too >>> high. Can you split out the fixes to the "fill in

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-22 Thread Paul Moore
On Friday, November 22, 2013 11:34:41 AM Stefan Hajnoczi wrote: > IMO this seccomp approach is doomed since QEMU does not practice > privilege separation. QEMU is monolithic so it's really hard to create > a meaningful sets of system calls. I'm a big fan of decomposing QEMU, but based on previous

Re: [Qemu-devel] [RFC PATCH 1/2] e1000: Use Address_Available bit as HW latch

2013-11-22 Thread Vlad Yasevich
On 11/22/2013 04:47 AM, Jason Wang wrote: > On 11/22/2013 04:04 AM, Vlad Yasevich wrote: >> e1000 provides a E1000_RAH_AV bit on every complete write >> to the Receive Address Register. We can use this bit >> 2 ways: >> 1) To trigger HMP notifications. When the bit is set the >> mac address

[Qemu-devel] [RESENT PATCH for-1.7] curses: fixup SIGWINCH handler mess

2013-11-22 Thread Gerd Hoffmann
Don't run code in the signal handler, only set a flag. Use sigaction(2) to avoid non-portable signal(2) semantics. Make #ifdefs less messy. Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek --- ui/curses.c | 44 1 file changed, 28 insertions(+),

Re: [Qemu-devel] [PATCH RFC 0/3] add direct support of event in qapi schema

2013-11-22 Thread Luiz Capitulino
On Fri, 22 Nov 2013 10:03:44 +0800 Wenchao Xia wrote: > 于 2013/11/13 9:44, Wenchao Xia 写道: > > This series add support for tag/keyword 'event' in qapi-schema. > > The implemention doesn't generate a struture and visit function > > in the background for every event, so it doesn't support nested >

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-22 Thread Gerd Hoffmann
On Do, 2013-11-21 at 03:38 +0100, Igor Mammedov wrote: > Add DimmBus for memory hotplug below 4Gb or above 4Gb depending > on initial memory size and hotplug memory size. > > * if ram_size is less than 32-bit PCI hole start, reserve > hotplug memory region as [ram_size,32bit-PCIhole-start) > i

[Qemu-devel] [PATCH] vl.c: clean up missing parameters calculation in smp_parse

2013-11-22 Thread Peter Lieven
Signed-off-by: Peter Lieven --- vl.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/vl.c b/vl.c index 8d5d874..470a8d1 100644 --- a/vl.c +++ b/vl.c @@ -1385,35 +1385,33 @@ static QemuOptsList qemu_smp_opts = { static void smp_parse(QemuOpts *

Re: [Qemu-devel] [PATCH 3/6] qemu-option: Add qemu_config_parse_qdict()

2013-11-22 Thread Max Reitz
On 22.11.2013 09:08, Fam Zheng wrote: On 2013年11月22日 03:05, Max Reitz wrote: This function basically parses command-line options given as a QDict replacing a config file. For instance, the QDict {"section.opt1": 42, "section.opt2": 23} corresponds to the config file: [section] opt1 = 42 opt2 =

Re: [Qemu-devel] [PATCH 00/21] RFCv2: add Spice block device

2013-11-22 Thread Marc-André Lureau
Hi there, Even though there is no rush to review this series, it would be nice to get the first ~10 patches. It would make the next rebase easier, and the review smaller. cheers On Mon, Nov 18, 2013 at 1:25 PM, Marc-André Lureau wrote: > Hi, > > The following patch series implement a Spice bloc

[Qemu-devel] [PATCH v3 08/19] block drivers: add discard/write_zeroes properties to bdrv_get_info implementation

2013-11-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/qcow2.c | 2 ++ block/qed.c | 2 ++ block/vdi.c | 1 + block/vhdx.c | 3 +++ block/vpc.c | 1 + 5 files changed, 9 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 2fe37ed..1542750 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1892

Re: [Qemu-devel] Buildbot failure: MinGW (was: qga/vss-win32/requester.h compile error)

2013-11-22 Thread Gerd Hoffmann
Hi, > > 'make check' for MinGW cross builds needs an installation of wine to run > > the resulting exe files. I don't think it is a good idea to run tests for cross builds by default. cheers, Gerd

[Qemu-devel] [PATCH v3 17/19] scsi-disk: catch write protection errors in UNMAP

2013-11-22 Thread Paolo Bonzini
This is the same that is already done for WRITE SAME. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 74e6a14..4138268 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -154

[Qemu-devel] [PATCH v3 16/19] qemu-iotests: 033 is fast

2013-11-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index b63b18c..303e0f3 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -39,7 +39,7 @@ 030 rw a

[Qemu-devel] [PATCH v3 06/19] block: make bdrv_co_do_write_zeroes stricter in producing aligned requests

2013-11-22 Thread Paolo Bonzini
Right now, bdrv_co_do_write_zeroes will only try to align the beginning of the request. However, it is simpler for many formats to expect the block layer to separate both the head *and* the tail. This makes sure that the format's bdrv_co_write_zeroes function will be called with aligned sector_nu

[Qemu-devel] [PATCH v3 19/19] scsi-disk: correctly implement WRITE SAME

2013-11-22 Thread Paolo Bonzini
Fetch the data to be written from the input buffer. If it is all zeroes, we can use the write_zeroes call (possibly with the new MAY_UNMAP flag). Otherwise, do as many write cycles as needed, writing 512k at a time. Strictly speaking, this is still incorrect because a zero cluster should only be

[Qemu-devel] [PATCH v3 14/19] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

2013-11-22 Thread Paolo Bonzini
See the next commit for the description of the Linux kernel problem that is worked around in raw_open_common. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 37 + 1 file changed, 37 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index

[Qemu-devel] [PATCH v3 13/19] raw-posix: implement write_zeroes with MAY_UNMAP for files

2013-11-22 Thread Paolo Bonzini
Writing zeroes to a file can be done by punching a hole if MAY_UNMAP is set. Note that in this case ENOTSUP is not ignored, but makes the block layer fall back to the generic implementation. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 66

[Qemu-devel] [PATCH v3 10/19] block/iscsi: remove .bdrv_has_zero_init

2013-11-22 Thread Paolo Bonzini
From: Peter Lieven since commit 3ac21627 the default value changed to 0. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index b7b5238..b6b62aa 100644 --- a/block/iscsi.c +++ b/b

[Qemu-devel] [PATCH v3 12/19] block/iscsi: check WRITE SAME support differently depending on MAY_UNMAP

2013-11-22 Thread Paolo Bonzini
The current check is right for MAY_UNMAP=1. For MAY_UNMAP=0, just try and fall back to regular writes as soon as a WRITE SAME command fails. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/bl

  1   2   >