Re: [Qemu-devel] question about VM kernel parameter idle=

2013-11-20 Thread Gleb Natapov
On Thu, Nov 21, 2013 at 09:01:39AM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 21, 2013 at 03:45:28AM +, Zhanghaoyu (A) wrote: > > Hi, all > > > > What's the difference of the linux guest kernel parameter > > idle=, especially in performance? > > > > Taking the performance into account, w

Re: [Qemu-devel] [PATCH 25/27] pc: ACPI BIOS: use enum for defining memory affinity flags

2013-11-20 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:38:46AM +0100, Igor Mammedov wrote: > replace magic numbers with enum describing Flags field of > memory affinity in SRAT table. > > MemoryAffinityFlags enum will define flags decribed by: > ACPI spec 5.0, "5.2.16.2 Memory Affinity Structure", > "Table 5-69 Flags - Mem

Re: [Qemu-devel] [PATCH 26/27] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2013-11-20 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:38:47AM +0100, Igor Mammedov wrote: > Needed for Windows to use hotplugged memory device, otherwise > it complains that server is not configured for memory hotplug. > Tests shows that aftewards it uses dynamically provided > proximity value from _PXM() method if available

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-20 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote: > it fixes IRQ storm since guest isn't able to lower SCI IRQ > after it has been handled when it clears GPE event. > > Signed-off-by: Igor Mammedov The storm is only on memory hotplug right? But memory hotplug support is only added b

Re: [Qemu-devel] question about VM kernel parameter idle=

2013-11-20 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:45:28AM +, Zhanghaoyu (A) wrote: > Hi, all > > What's the difference of the linux guest kernel parameter > idle=, especially in performance? > > Taking the performance into account, which one is best? > > In my opinion, if the number of all VMs' vcpus is far more

Re: [Qemu-devel] [PATCH 00/27 RFC v7] ACPI memory hotplug

2013-11-20 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:38:21AM +0100, Igor Mammedov wrote: > --- > What's new since v6: > > * DIMM device is split to backend and frontend. Therefore following > command/options were added for supporting it: > > For memdev backend: > CLI: -memdev-add > Monitor/QMP: memdev-add

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-11-20 Thread Paolo Bonzini
Il 21/11/2013 04:12, Dave Airlie ha scritto: > I'm not sure what that buys me here, I need the virtio-vga to attach > the vga ops the first console that the virtio-gpu registers, it can't > be a separate console, and since virtio-gpu initialises before > virtio-vga I can't tell it to not register t

Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-20 Thread Li Guang
Igor Mammedov wrote: Along with conversion extend -m option to support following parameters ... +if (!opts) { exit(1); } -sz = QEMU_ALIGN_UP((uint64_t)value, 8192); + +/* fixup legacy sugffix-less format

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-20 Thread Li Guang
Hi, Igor Igor Mammedov wrote: Add DimmBus for memory hotplug below 4Gb or above 4Gb depending on initial memory size and hotplug memory size. ... +static +void pc_hotplug_memory_init_impl(Object *owner, + MemoryRegion *system_memory, +

Re: [Qemu-devel] [PATCH for 1.7] target-i386: yield to another VCPU on PAUSE

2013-11-20 Thread Richard Henderson
On 11/20/2013 09:54 PM, Paolo Bonzini wrote: > The fix is to make the pause instruction do "cpu_loop_exit". > > Cc: Richard Henderson > Reported-by: Luigi Rizzo > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH 2/4] spapr-pci: introduce a finish_realize() callback

2013-11-20 Thread Alexey Kardashevskiy
The spapr-pci PHB initializes IOMMU for emulataed devices only. The upcoming VFIO support will do it different. However both emulated and VFIO PHB types share most of the initialization code. For the type specific things a new finish_realize() callback is introduced. This introduces sPAPRPHBClass

[Qemu-devel] [PATCH 4/4] spapr-pci: converts fprintf to error_report

2013-11-20 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 963841c..d102d82 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -293,7 +293,7 @@ static void rtas_ibm_c

[Qemu-devel] [PATCH 0/4] spapr-pci: prepare for vfio

2013-11-20 Thread Alexey Kardashevskiy
Here are few reworks for spapr-pci PHB which I'd like to have to support VFIO. QOM, errors printing, traces, nothing really serious. Thanks! Alexey Kardashevskiy (4): spapr-pci: convert init() callback to realize() spapr-pci: introduce a finish_realize() callback spapr-pci: add spapr_pci tra

[Qemu-devel] [PATCH 3/4] spapr-pci: add spapr_pci trace

2013-11-20 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- trace-events | 1 + 1 file changed, 1 insertion(+) diff --git a/trace-events b/trace-events index 8695e9e..ba5f76c 100644 --- a/trace-events +++ b/trace-events @@ -1114,6 +1114,7 @@ qxl_render_guest_primary_resized(int32_t width, int32_t height, int32_t s

[Qemu-devel] [PATCH 1/4] spapr-pci: convert init() callback to realize()

2013-11-20 Thread Alexey Kardashevskiy
This converts the old-style init() callback to a new style realize() callback as init() now is supposed to do only trivial initialization. As a part of convertion, this replaces fprintf(stderr) with error_setg() as realize() does not "return" any value, instead it puts the extended error into **er

[Qemu-devel] [PATCH V2 2/4] hw/intc: add sunxi interrupt controller device

2013-11-20 Thread liguang
Signed-off-by: liguang --- default-configs/arm-softmmu.mak |1 + hw/intc/Makefile.objs |1 + hw/intc/sunxi-pic.c | 297 +++ include/hw/intc/sunxi-pic.h | 27 4 files changed, 326 insertions(+), 0 deletions(-) create mo

[Qemu-devel] [PATCH V2 4/4] MAINTAINERS: add myself to maintain sunxi machine

2013-11-20 Thread liguang
Signed-off-by: liguang --- MAINTAINERS |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 77edacf..232e1a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -284,6 +284,15 @@ M: Peter Maydell S: Maintained F: hw/*/stellaris* +Sunxi +M

[Qemu-devel] [PATCH V2 0/4] add sunxi machine type

2013-11-20 Thread liguang
this patch-set implemented a device-reduced machine type for Allwinner's sunxi series SoC, like sunxi-4i/5i/7i ... now, It can support sunxi-4i with a cortex-a8 processor. and will support more later, like sunxi-7i with cortex-a7, and will add more devices. V2: split timer and interrupt controll

[Qemu-devel] [PATCH V2 1/4] hw/timer: add sunxi timer device

2013-11-20 Thread liguang
Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |1 + hw/timer/sunxi-pit.c| 218 +++ include/hw/timer/sunxi-pit.h| 25 + 4 files changed, 246 insertions(+), 0 deletions(-) create m

[Qemu-devel] [PATCH V2 3/4] hw/arm: add sunxi machine type

2013-11-20 Thread liguang
Signed-off-by: liguang --- hw/arm/Makefile.objs |1 + hw/arm/sunxi-soc.c | 113 ++ 2 files changed, 114 insertions(+), 0 deletions(-) create mode 100644 hw/arm/sunxi-soc.c diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs index 3671b

[Qemu-devel] question about VM kernel parameter idle=

2013-11-20 Thread Zhanghaoyu (A)
Hi, all What's the difference of the linux guest kernel parameter idle=, especially in performance? Taking the performance into account, which one is best? In my opinion, if the number of all VMs' vcpus is far more than that of pcpus, e.g. SPECVirt test, idle=halt is better for server's total

Re: [Qemu-devel] [PATCH] qemu-img create: add -o nocow option

2013-11-20 Thread Chunyan Liu
2013/11/20 Stefan Hajnoczi > On Wed, Nov 20, 2013 at 04:50:29PM +0800, Chunyan Liu wrote: > > block/cow.c | 22 ++ > > block/qcow.c | 22 ++ > > block/qcow2.c | 22 ++ > > I think you can avoi

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-11-20 Thread Dave Airlie
On Wed, Nov 20, 2013 at 10:02 PM, Gerd Hoffmann wrote: > On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> This is a virtio-vga device built on top of the virtio-gpu device. > > Ah, I see what you use the wrapping for. Hmm. I think you should use a > common base cl

[Qemu-devel] [PATCH 19/27] acpi: piix4/ich9: add optional vmstate field for MemHotplugState migration

2013-11-20 Thread Igor Mammedov
it should not be present for machine versions that do not support memory hotplug. Signed-off-by: Igor Mammedov --- hw/acpi/core.c | 27 +++ hw/acpi/ich9.c |7 +++ hw/acpi/piix4.c|7 +++ include/hw/acpi/acpi.h |8 4 fi

[Qemu-devel] [PATCH 24/27] pc: ACPI BIOS: add ssdt-mem.hex.generated and update ssdt-misc.hex.generated

2013-11-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/ssdt-mem.hex.generated | 197 + hw/i386/ssdt-misc.hex.generated | 881 ++- 2 files changed, 1074 insertions(+), 4 deletions(-) create mode 100644 hw/i386/ssdt-mem.hex.generated diff --git a/hw/i386/ssdt-mem.

[Qemu-devel] [PATCH 26/27] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2013-11-20 Thread Igor Mammedov
Needed for Windows to use hotplugged memory device, otherwise it complains that server is not configured for memory hotplug. Tests shows that aftewards it uses dynamically provided proximity value from _PXM() method if available. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 33 +

[Qemu-devel] [PATCH 27/27] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines

2013-11-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt.dsl |5 - hw/i386/q35-acpi-dsdt.dsl |5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-dsdt.dsl b/hw/i386/acpi-dsdt.dsl index 084a22e..2980deb 100644 --- a/hw/i386/acpi-dsdt.dsl +++ b/hw/i386/acp

[Qemu-devel] [PATCH 25/27] pc: ACPI BIOS: use enum for defining memory affinity flags

2013-11-20 Thread Igor Mammedov
replace magic numbers with enum describing Flags field of memory affinity in SRAT table. MemoryAffinityFlags enum will define flags decribed by: ACPI spec 5.0, "5.2.16.2 Memory Affinity Structure", "Table 5-69 Flags - Memory Affinity Structure" Signed-off-by: Igor Mammedov --- hw/i386/acpi-bu

[Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory hotplug interface

2013-11-20 Thread Igor Mammedov
- provides static SSDT object for memory hotplug - SSDT template for memory devices and runtime generator of them in SSDT table. Signed-off-by: Vasilis Liaskovitis Signed-off-by: Igor Mammedov --- mst/pci tree specific change: acpi-build: s/build_append_notify/build_append_notify_method/ in

[Qemu-devel] [PATCH 20/27] pc: piix: make PCII440FXState type public

2013-11-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/pci-host/piix.c | 22 +- include/hw/pci-host/piix.h | 27 +++ 2 files changed, 28 insertions(+), 21 deletions(-) create mode 100644 include/hw/pci-host/piix.h diff --git a/hw/pci-host/piix.c b/hw/pci-hos

[Qemu-devel] [PATCH 22/27] pc: add memory hotplug Q35 machine

2013-11-20 Thread Igor Mammedov
Add DimmBus to q35 machine, initialize memory hotplug window and plumb in ACPI callback (ich9_pm) for communicating hotplug event to guest. Signed-off-by: Igor Mammedov --- hw/i386/pc_q35.c |3 +++ hw/pci-host/q35.c | 18 +- include/hw/pci-host/q35.h |1

[Qemu-devel] [PATCH 12/27] dimm: add hotplug callback to DimmBus

2013-11-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 11 +++ hw/mem/dimm.c |4 include/hw/i386/pc.h |6 ++ include/hw/mem/dimm.h |4 4 files changed, 25 insertions(+), 0 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index ba82c67..85d0862

[Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-20 Thread Igor Mammedov
Add DimmBus for memory hotplug below 4Gb or above 4Gb depending on initial memory size and hotplug memory size. * if ram_size is less than 32-bit PCI hole start, reserve hotplug memory region as [ram_size,32bit-PCIhole-start) if hotplug memory region fits there, otherwise reserve hotplug mem

[Qemu-devel] [PATCH 17/27] acpi: initialize memory hotplug ACPI ICH9 hardware

2013-11-20 Thread Igor Mammedov
to be used by Q35 machine for handling hardware ACPI part of memory hotplug interface with guest. Signed-off-by: Igor Mammedov --- hw/acpi/ich9.c | 15 +++ include/hw/acpi/ich9.h |6 ++ 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/hw/acpi/ich9.c b

[Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-20 Thread Igor Mammedov
- implements QEMU hardware part of memory hotplug protocol described at "docs/specs/acpi_mem_hotplug.txt" - handles only memory add notification event for now Signed-off-by: Igor Mammedov --- docs/specs/acpi_mem_hotplug.txt | 38 ++ hw/acpi/core.c | 144

[Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-20 Thread Igor Mammedov
it fixes IRQ storm since guest isn't able to lower SCI IRQ after it has been handled when it clears GPE event. Signed-off-by: Igor Mammedov --- hw/acpi/ich9.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index e59688b..fb88162 100644 --

[Qemu-devel] [PATCH 15/27] acpi: piix4: add memory-hotplug-io-base property to piix4_pm

2013-11-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/piix4.c| 14 +- include/hw/acpi/acpi.h |2 ++ 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index e0d9270..a835981 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -18,6 +18

[Qemu-devel] [PATCH 14/27] acpi: initialize memory hotplug ACPI PIIX4 hardware

2013-11-20 Thread Igor Mammedov
to be used by i440fx machine for handling hardware ACPI part of memory hotplug interface with guest. Signed-off-by: Igor Mammedov --- hw/acpi/piix4.c | 16 include/hw/acpi/piix4.h |2 ++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/acpi/piix4.

[Qemu-devel] [PATCH 10/27] dimm: add busy slot check and slot auto-allocation

2013-11-20 Thread Igor Mammedov
- if slot property is not specified on -device/device_add command, treat default value as request for assigning DimmDevice to the first free slot. - if slot is provided with -device/device_add command, attempt to use it or fail command if it's already occupied. Signed-off-by: Igor Mammedov --- v

[Qemu-devel] [PATCH 18/27] acpi: ich9: add memory-hotplug-io-base property to ich9_pm

2013-11-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/ich9.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 0efb875..ab76cc6 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -226,6 +226,14 @@ static void ich9_pm_get_gpe0_blk(Object

[Qemu-devel] [PATCH 11/27] dimm: add busy address check and address auto-allocation

2013-11-20 Thread Igor Mammedov
- if 'start' property is not specified on -device/device_add command, treat default value as request for assigning DimmDevice to the first free memory region. - if 'start' is provided with -device/device_add command, attempt to use it or fail command if it's already occupied or falls inside of an

[Qemu-devel] [PATCH 07/27] add memdev backend infrastructure

2013-11-20 Thread Igor Mammedov
Provides framework for splitting host RAM allocation/ policies into a separate backend that could be used by devices. It would allow to separate host specific options from device model like it's done for netdev & co. It adds new: -memdev CLI option and corresponding memdev-add QMP/HMP comma

[Qemu-devel] [PATCH 09/27] dimm: map DimmDevice into DimBus provided address space

2013-11-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/mem/dimm.c | 13 + include/hw/mem/dimm.h | 15 +++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/hw/mem/dimm.c b/hw/mem/dimm.c index fe81226..b3d6fda 100644 --- a/hw/mem/dimm.c +++ b/hw/mem/dimm.c @@ -28,12

[Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-11-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- qapi/string-input-visitor.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index 8f1bc41..a152f5d 100644 --- a/qapi/string-input-visitor.c +++ b/qapi/string-input

[Qemu-devel] [PATCH 03/27] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS

2013-11-20 Thread Igor Mammedov
'etc/reserved-memory-end' will allow QEMU to tell BIOS where PCI BARs mapping could safely start in high memory. Allowing BIOS to start mapping 64-bit PCI BARs at address where it wouldn't conflict with other mappings QEMU might place before it. That permits QEMU to reserve extra address space be

[Qemu-devel] [PATCH 08/27] dimm: implement dimm device abstraction

2013-11-20 Thread Igor Mammedov
From: Vasilis Liaskovitis Each hotplug-able memory slot is a DimmDevice. All DimmDevices are attached to a new bus called DimmBus. A hot-add operation for a DIMM: - creates a new DimmDevice and attaches it to the DimmBus Hotplug operations are done through normal device_add commands. For migrat

[Qemu-devel] [PATCH 06/27] get reference to /backend container via qemu_get_backend()

2013-11-20 Thread Igor Mammedov
... API, so it could be reused later using qemu_get_backend() without duplicating "/backend" everywhere. Signed-off-by: Igor Mammedov --- include/sysemu/sysemu.h |3 +++ ui/console.c|3 ++- vl.c| 11 +++ 3 files changed, 16 insertions(+), 1 delet

[Qemu-devel] [PATCH 02/27] rename pci_hotplug_fn to hotplug_fn and make it available for other devices

2013-11-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- resolving conflict with pcihp: s/PCIHotplugState/HotplugState/ perhaps this patch should go before pcihp patches to avoid unnecessary code churn?? --- hw/acpi/pcihp.c |6 +++--- hw/acpi/piix4.c | 22 -- hw/pci/pci.c

[Qemu-devel] [PATCH 00/27 RFC v7] ACPI memory hotplug

2013-11-20 Thread Igor Mammedov
--- What's new since v6: * DIMM device is split to backend and frontend. Therefore following command/options were added for supporting it: For memdev backend: CLI: -memdev-add Monitor/QMP: memdev-add with options: 'id' and 'size' For dimm frontend: option "size"

[Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-20 Thread Igor Mammedov
Along with conversion extend -m option to support following parameters: "mem" - startup memory amount "slots" - total number of hotplug memory slots "maxmem" - maximum possible memory "slots" and "maxmem" should go in pair and "maxmem" should be greater than "mem" for memory hotplug to be us

[Qemu-devel] [PATCH 01/27] acpi: factor out common pm_update_sci() into acpi core

2013-11-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- perhaps this patch sholud go before "piix4: add acpi pci hotplug support" so that there were no need in this rename in piix4_acpi_pci_hotplug() here. s/pm_update_sci/acpi_update_sci/ --- hw/acpi/core.c | 18 ++ hw/acpi/ich9.c |

Re: [Qemu-devel] [PATCH 0/4] tpm: Provide a software vTPM

2013-11-20 Thread Anthony Liguori
On Wed, Nov 20, 2013 at 2:01 PM, Stefan Berger wrote: > On 11/19/2013 06:03 PM, Anthony Liguori wrote: >> >> On Tue, Nov 19, 2013 at 1:32 PM, Corey Bryant >> wrote: >>> >>> On 11/19/2013 02:50 PM, Anthony Liguori wrote: On Wed, Nov 6, 2013 at 6:38 AM, Corey Bryant wrote: > >>>

Re: [Qemu-devel] console muti-head some more design input

2013-11-20 Thread Dave Airlie
On Thu, Nov 21, 2013 at 1:14 AM, Gerd Hoffmann wrote: > On Mi, 2013-11-20 at 09:32 -0500, John Baboval wrote: >> On 11/20/2013 03:12 AM, Gerd Hoffmann wrote: >> >Hi, >> > >> >> I think you are only considering output here, for input we definitely >> >> need some idea of screen layout, and this

Re: [Qemu-devel] [PATCH 0/4] add sunxi machine

2013-11-20 Thread Li Guang
Hi, Peter Peter Maydell wrote: On 20 November 2013 07:53, liguang wrote: this patch-set implemented a device-reduced machine type for Allwinner's sunxi series SoC, like sunxi-4i/5i/7i ... Li Guang (4) hw/arm: add new machine type sunxi hw/arm/sunxi-soc: add i

[Qemu-devel] [Bug 1253465] [NEW] qemu-img: 'image' uses a vmdk feature which is not supported by this qemu version: VMDK version 3

2013-11-20 Thread adrelanos
Public bug reported: qemu-img convert in.vmdk -O RAW out.img Fails with: qemu-img: 'image' uses a vmdk feature which is not supported by this qemu version: VMDK version 3 qemu-img version 1.6.1 ** Affects: qemu Importance: Undecided Status: New -- You received this bug notific

Re: [Qemu-devel] [PATCH 0/4] tpm: Provide a software vTPM

2013-11-20 Thread Stefan Berger
On 11/19/2013 06:03 PM, Anthony Liguori wrote: On Tue, Nov 19, 2013 at 1:32 PM, Corey Bryant wrote: On 11/19/2013 02:50 PM, Anthony Liguori wrote: On Wed, Nov 6, 2013 at 6:38 AM, Corey Bryant wrote: This patch series provides support for a software Trusted Platform Module (otherwise known as

[Qemu-devel] a bug in qemu-retranslator with Windows7 x64 Zero Page Thread

2013-11-20 Thread Anna Melekhova
Dear Sirs, I've run into a curious bug in qemu retranslator that looks like a code self-modification from Zero Page Thread. Test case: Win7 x64 on installation while running w/o KVM gives a BSOD. 45/45 - 100% reproduction. I've tried to analyze dumps but it is installation stage and qemu has

[Qemu-devel] pcm.c:7843:(snd_pcm_recover) underrun occurred

2013-11-20 Thread Francesco Turco
Hello. I'm not sure if asking in qemu-devel is the right thing to do, as I'm not a QEMU developer, but stefanha in the #qemu IRC channel told me to do so. :-) I'm running QEMU 1.6.1 on a 64-bit Gentoo Linux system. The guest operating system is Windows 7 32-bit. I get multiple identical warn

Re: [Qemu-devel] [PATCH for-1.7] mips jazz: do not raise data bus exception when accessing invalid addresses

2013-11-20 Thread Hervé Poussineau
Ping again for 1.7. This fixes a regression introduced in 1.6.0, reported by some people on mailing list ([1] Hervé [1] http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02055.html Hervé Poussineau a écrit : Ping for 1.7 Paolo Bonzini a écrit : Il 04/11/2013 23:26, Hervé Poussineau h

Re: [Qemu-devel] [PATCH for 1.7] kvm: Fix uninitialized cpuid_data

2013-11-20 Thread Stefan Weil
Am 07.11.2013 12:15, schrieb Gleb Natapov: > On Wed, Nov 06, 2013 at 10:35:27PM +0100, Stefan Weil wrote: >> This error was reported by valgrind when running qemu-system-x86_64 >> with kvm: >> >> ==975== Conditional jump or move depends on uninitialised value(s) >> ==975==at 0x521C38: cpuid_fin

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

2013-11-20 Thread Stefan Weil
Am 20.11.2013 18:40, schrieb Tomoki Sekiyama: > Hi Stefan, > > > On 11/20/13 4:16 , "Stefan Hajnoczi" wrote: >> Sorry, I forgot to CC qemu-devel on this: >> >> On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi >> wrote: >>> Hi, >>> The mingw32 build is failing as follows: >>> >>> In file included

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

2013-11-20 Thread Tomoki Sekiyama
Hi Stefan, On 11/20/13 4:16 , "Stefan Hajnoczi" wrote: >Sorry, I forgot to CC qemu-devel on this: > >On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi >wrote: >> Hi, >> The mingw32 build is failing as follows: >> >> In file included from qga/vss-win32.c:17: >> ./qga/vss-win32/requester.h:31: er

Re: [Qemu-devel] [PATCH v6 RESENT 0/2] sheepdog: add user-defined redundancy option

2013-11-20 Thread Liu Yuan
On Mon, Nov 18, 2013 at 01:58:50PM +0800, Liu Yuan wrote: > On Thu, Nov 07, 2013 at 10:56:36PM +0800, Liu Yuan wrote: > > v6: > > - update comment typo > > - remove is_number() > > Anyone pick this set up? Ping again. Without this two patches, qemu-img can't create|convert erasure coded images

[Qemu-devel] virtio-net: network stops responding in Win2k3 server

2013-11-20 Thread ing. Mario De Chenno
Hi all. We are facing some network issues on some Windows Server 2003 machines. In short, network seems to lock up and stops responding even to ping requests. From TCPdump on the tap interface on the server I only see arp request to the gateway, without replies. Increased tx overruns on the some in

Re: [Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

2013-11-20 Thread Andreas Färber
Am 20.11.2013 16:16, schrieb Stefan Hajnoczi: > On Wed, Nov 20, 2013 at 01:38:31PM +0100, Gerd Hoffmann wrote: >> On Mi, 2013-11-20 at 10:00 +0100, Stefan Hajnoczi wrote: >>> Hi Gerd, >>> make check is failing on kraxel_rhel61 due to the following: >>> >>> ERROR:tests/libqtest.c:71:init_socket: ass

Re: [Qemu-devel] [PATCH 0/2] qdict_flatten() fixes

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 01:09:19PM +0100, Kevin Wolf wrote: > Kevin Wolf (2): > qdict: Fix memory leak in qdict_do_flatten() > qdict: Optimise qdict_do_flatten() > > qobject/qdict.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) Thanks, applied to my block-next tree:

Re: [Qemu-devel] console muti-head some more design input

2013-11-20 Thread John Baboval
On 11/20/2013 10:14 AM, Gerd Hoffmann wrote: On Mi, 2013-11-20 at 09:32 -0500, John Baboval wrote: On 11/20/2013 03:12 AM, Gerd Hoffmann wrote: Hi, I think you are only considering output here, for input we definitely need some idea of screen layout, and this needs to be stored somewhere.

Re: [Qemu-devel] ARM cpu object, setting properties from board model

2013-11-20 Thread Peter Maydell
On 20 November 2013 15:19, Andreas Färber wrote: > My first thought without reviewing the code is to just inline > object_new() followed by object_property_set_bool() in the machine - > that's what I've done for my downstream rl78, where I needed to postpone > realizing the CPU until the firmware

Re: [Qemu-devel] ARM cpu object, setting properties from board model

2013-11-20 Thread Andreas Färber
Am 19.11.2013 21:01, schrieb Peter Maydell: > I find myself with a use case where I would like to set > a CPU object property from the board model init function > (specifically, I'd like the board model to be able to say > "this CPU will boot via PSCI so if you're KVM then start > it appropriately"

[Qemu-devel] [PATCH 1/6] ehci: implement port wakeup

2013-11-20 Thread Gerd Hoffmann
Update portsc register and raise irq in case a suspended port is woken up, so remote wakeup works on our ehci ports. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 18 -- trace-events | 3 +++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-

[Qemu-devel] [PULL 2/7] target-openrisc: Remove unnecessary code generated by jump instructions

2013-11-20 Thread Jia Liu
From: Sebastian Macke The sr_f variable is only used for the l.bf and l.bnf instructions. For clarity the code is also rewritten using a switch statement instead of if chaining. Signed-off-by: Sebastian Macke Reviewed-by: Jia Liu Signed-off-by: Jia Liu --- target-openrisc/translate.c | 45 ++

Re: [Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 01:38:31PM +0100, Gerd Hoffmann wrote: > On Mi, 2013-11-20 at 10:00 +0100, Stefan Hajnoczi wrote: > > Hi Gerd, > > make check is failing on kraxel_rhel61 due to the following: > > > > ERROR:tests/libqtest.c:71:init_socket: assertion failed (ret != -1): (-1 != > > -1) > >

[Qemu-devel] [PATCH 3/6] usb: add vendor request defines

2013-11-20 Thread Gerd Hoffmann
Add defines for vendor specific usb control requests. Group defines by Device / Interface / Endpoint while being at it. Signed-off-by: Gerd Hoffmann --- include/hw/usb.h | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/include/hw/usb.h b/include/hw/usb.h ind

Re: [Qemu-devel] [PATCH] qemu-img create: add -o nocow option

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 04:50:29PM +0800, Chunyan Liu wrote: > block/cow.c | 22 ++ > block/qcow.c | 22 ++ > block/qcow2.c | 22 ++ I think you can avoid modifying all the image formats: .bdr

Re: [Qemu-devel] console muti-head some more design input

2013-11-20 Thread Gerd Hoffmann
On Mi, 2013-11-20 at 09:32 -0500, John Baboval wrote: > On 11/20/2013 03:12 AM, Gerd Hoffmann wrote: > >Hi, > > > >> I think you are only considering output here, for input we definitely > >> need some idea of screen layout, and this needs to be stored > >> somewhere. > > Oh yea, input. That n

[Qemu-devel] [PULL 1/7] target-openrisc: Speed up move instruction

2013-11-20 Thread Jia Liu
From: Sebastian Macke The OpenRISC architecture does not have its own move register instruction. Instead it uses either "l.addi rd, r0, x" or "l.ori rd, rs, 0" or "l.or rd, rx, r0" The l.ori instruction is automatically optimized but not the l.addi instruction. This patch optimizes for this spec

[Qemu-devel] [PATCH 4/6] usb: move usb_{hi, lo} helpers to header file.

2013-11-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/desc.c | 10 -- hw/usb/desc.h | 11 +++ 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/usb/desc.c b/hw/usb/desc.c index 5dbe754..f18a043 100644 --- a/hw/usb/desc.c +++ b/hw/usb/desc.c @@ -6,16 +6,6 @@ /* -

[Qemu-devel] [PULL 0/7] OpenRISC patch queue for 1.7

2013-11-20 Thread Jia Liu
Hi Anthony, Hi Blue, This is my OpenRISC patch queue for 1.7, it have been well tested, please pull. Thanks to Sebastian Macke, it made move optimization and fix some bugs. The following changes since commit 394cfa39ba24dd838ace1308ae24961243947fb8: Merge remote-tracking branch 'quintela/mi

Re: [Qemu-devel] [PATCH 50/60] AArch64: Add "Floating-point<->fixed-point

2013-11-20 Thread Michael Matz
Hi, On Tue, 19 Nov 2013, Janne Grunau wrote: > > +static void handle_fpfpconv(DisasContext *s, uint32_t insn) > > +{ > > +int opcode = get_bits(insn, 16, 3); > > +int rmode = get_bits(insn, 20, 2); > > rmode is at 19 > > > +case 0x1: /* [S|U]CVTF (scalar->float) */ > > and it's cas

Re: [Qemu-devel] [PATCH 26/60] AArch64: Add ADR instruction emulation

2013-11-20 Thread Michael Matz
Hi, On Tue, 19 Nov 2013, Claudio Fontana wrote: > > +uint64_t imm; > > +uint64_t base; > > + > > +imm = get_sbits(insn, 5, 19) << 2; > > +imm |= get_bits(insn, 29, 2); > > does this work with negative values? Yes. get_sbits returns a sign extended (32bit) int, the shift doesn't

[Qemu-devel] [PULL 6/7] target-openrisc: Correct memory bounds checking for the tlb buffers

2013-11-20 Thread Jia Liu
From: Sebastian Macke The mtspr and mfspr routines didn't check for the correct memory boundaries. This fixes a segmentation fault while booting Linux. Signed-off-by: Sebastian Macke Reviewed-by: Jia Liu Signed-off-by: Jia Liu --- target-openrisc/sys_helper.c | 16 1 file ch

[Qemu-devel] [PULL 3/7] target-openrisc: Remove executable flag for every page

2013-11-20 Thread Jia Liu
From: Sebastian Macke Pages should be flagged executable only if the tlb executable flag is set or the mmu is off. Signed-off-by: Sebastian Macke Reviewed-by: Jia Liu Signed-off-by: Jia Liu --- target-openrisc/mmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/targ

[Qemu-devel] [PULL 7/7] target-openrisc: Correct carry flag check of l.addc and l.addic test cases

2013-11-20 Thread Jia Liu
From: Sebastian Macke The test cases did not correctly test for the carry flag. Signed-off-by: Sebastian Macke Reviewed-by: Jia Liu Signed-off-by: Jia Liu --- tests/tcg/openrisc/test_addc.c | 8 +--- tests/tcg/openrisc/test_addic.c | 10 ++ 2 files changed, 11 insertions(+), 7

[Qemu-devel] [PULL 4/7] target-openrisc: Correct wrong epcr register in interrupt handler

2013-11-20 Thread Jia Liu
From: Sebastian Macke This patch corrects several misbehaviors during an interrupt process. Most of the time the pc is already correct and therefore no special treatment of the exceptions is necessary. Tested by checking crashing programs which otherwise work in or1ksim. Signed-off-by: Sebastia

[Qemu-devel] [PULL 5/7] openrisc-timer: Reduce overhead, Separate clock update functions

2013-11-20 Thread Jia Liu
From: Sebastian Macke The clock value is only evaluated when really necessary reducing the overhead of the timer handling. This also solves a problem in the way the Linux kernel handles the timer and the expected accuracy. The old version could lead to inaccurate timings. Signed-off-by: Sebasti

[Qemu-devel] [PATCH 0/6] usb: remote wakeup improvements

2013-11-20 Thread Gerd Hoffmann
Hi, USB patch series from the ReduceWakeupRate department. Patch #1 implements remote wakeup support to the ehci emulation. Patch #2 reverts a workaround for lacking ehci remote wakeup support in the highspeed version of the usb tablet. Patches #3 + #4 are small preparations for #5. P

[Qemu-devel] [PATCH 5/6] usb: add support for microsoft os descriptors

2013-11-20 Thread Gerd Hoffmann
This patch adds support for special usb descriptors used by microsoft windows. They allow more fine-grained control over driver binding and adding entries to the registry for configuration. Signed-off-by: Gerd Hoffmann --- hw/usb/Makefile.objs | 2 +- hw/usb/desc-msos.c | 234 ++

[Qemu-devel] [PATCH v2] curses: fixup SIGWINCH handler mess

2013-11-20 Thread Gerd Hoffmann
Don't run code in the signal handler, only set a flag. Use sigaction(2) to avoid non-portable signal(2) semantics. Make #ifdefs less messy. Signed-off-by: Gerd Hoffmann --- ui/curses.c | 44 1 file changed, 28 insertions(+), 16 deletions(-) diff --gi

[Qemu-devel] [PATCH 2/6] Revert "usb-tablet: Don't claim wakeup capability for USB-2 version"

2013-11-20 Thread Gerd Hoffmann
This reverts commit aa1c9e971e80d25b92908dce3dec7c38b49480ea. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 5956720..5e667f0 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @@ -

[Qemu-devel] [PATCH 6/6] usb-tablet: add microsoft os descriptor support

2013-11-20 Thread Gerd Hoffmann
Set SelectiveSuspendEnabled registy entry to one. This makes Windows use remote suspend by default, without manual registry fiddeling. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hid.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c

Re: [Qemu-devel] console muti-head some more design input

2013-11-20 Thread John Baboval
On 11/20/2013 03:12 AM, Gerd Hoffmann wrote: Hi, I think you are only considering output here, for input we definitely need some idea of screen layout, and this needs to be stored somewhere. Oh yea, input. That needs quite some work for multihead / multiseat. I think we should *not* try t

Re: [Qemu-devel] [PATCH v2 06/20] block: make bdrv_co_do_write_zeroes stricter in producing aligned requests

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 12:01:46PM +0100, Paolo Bonzini wrote: > Il 20/11/2013 11:22, Stefan Hajnoczi ha scritto: > >> > +&& num > bs->bl.write_zeroes_alignment) { > > Here '>' is used... > > > >> > +if (sector_num % bs->bl.write_zeroes_alignment != 0) { > >> > +

Re: [Qemu-devel] [PATCH 0/4 v4] block, arm: Fix buffered flash writes on VExpress

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 09:27:22AM +, Peter Maydell wrote: > On 20 November 2013 09:22, Stefan Hajnoczi wrote: > > On Tue, Oct 22, 2013 at 09:35:52AM -0700, Roy Franz wrote: > >> This patchset fixes buffered flash writes on the VExpress > >> platform. Buffered writes should now work properly

Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 15:18, Stefan Hajnoczi ha scritto: >> > +if (buffer_is_zero(inbuf, s->qdev.blocksize)) { > Where is inbuf's size checked? It must be s->qdev.blocksize for this > code to be correct. > See scsi_req_length: case WRITE_SAME_10: case WRITE_SAME_16: cmd->xfer = dev-

Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME

2013-11-20 Thread Stefan Hajnoczi
On Tue, Nov 19, 2013 at 06:07:43PM +0100, Paolo Bonzini wrote: > +static void scsi_disk_emulate_write_same(SCSIDiskReq *r, uint8_t *inbuf) > +{ > +SCSIRequest *req = &r->req; > +SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, req->dev); > +uint32_t nb_sectors = scsi_data_cdb_length(r-

Re: [Qemu-devel] [PATCH for 1.7] target-i386: yield to another VCPU on PAUSE

2013-11-20 Thread Luigi Rizzo
On Wed, Nov 20, 2013 at 12:54:02PM +0100, Paolo Bonzini wrote: > After commit b1bbfe7 (aio / timers: On timer modification, qemu_notify > or aio_notify, 2013-08-21) FreeBSD guests report a huge slowdown. > > The problem shows up as soon as FreeBSD turns out its periodic (~1 ms) > tick, but the tim

Re: [Qemu-devel] [PATCH for 1.7] target-i386: do not override nr_cores for -cpu host

2013-11-20 Thread Eduardo Habkost
On Tue, Nov 19, 2013 at 05:49:46PM +0100, Paolo Bonzini wrote: > Commit 787aaf5 (target-i386: forward CPUID cache leaves when -cpu host is > used, 2013-09-02) brings bits 31..26 of CPUID leaf 04h out of sync with > the APIC IDs that QEMU reserves for each package. This number must come > from "-sm

Re: [Qemu-devel] commit b1bbfe72 causes huge slowdown with no kvm

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 14:47, Alex Bligh ha scritto: > I think you are saying this sounds like another underlying bug > (no pause instruction) uncovered by the timer patches rather than > a bug in the timer patches. > > Reading > http://software.intel.com/file/27087 > perhaps the answer is for pause to yi

Re: [Qemu-devel] commit b1bbfe72 causes huge slowdown with no kvm

2013-11-20 Thread Alex Bligh
Paolo, On 20 Nov 2013, at 11:19, Paolo Bonzini wrote: > Before Alex's patch, setting a timer did a timer_settime system call. > > After, setting the timer exits QEMU's event loop (which uses poll) and > reenters it with a new deadline. This wouldn't be a problem; the > difference is between one

Re: [Qemu-devel] [PATCH v2 07/20] vpc, vhdx: add get_info

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 13:39, Stefan Hajnoczi ha scritto: >> > + >> > +bdi->cluster_size = >> > +(s->logical_sector_size / BDRV_SECTOR_SIZE) * s->block_size; > I thought s->block_size is in bytes. Why multiply by the logical block > size in 512-byte sectors? My mistake. Paolo

  1   2   >