Re: [Qemu-devel] [PATCH v7 4/4] PC: differentiate hpet's interrupt capability on piix and q35

2013-10-16 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 02:27:43PM +0800, liu ping fan wrote: > On Thu, Oct 17, 2013 at 1:44 PM, Michael S. Tsirkin wrote: > > On Thu, Oct 17, 2013 at 11:16:05AM +0800, Liu Ping Fan wrote: > >> For pc-piix-*, hpet's intcap is always hard coded as IRQ2. > >> For q35, if it is pc-q35-1.7 and earlier

Re: [Qemu-devel] [PATCH] qemu-iotests: fix 030 for faster machines

2013-10-16 Thread Fam Zheng
On Wed, 10/16 20:45, Max Reitz wrote: > On 2013-10-15 04:41, Fam Zheng wrote: > >If the block job completes too fast, the test can fail. Change the > >numbers so the qmp events are more stably captured by the script. > > > >A sleep is removed for the same reason. > > > >Signed-off-by: Fam Zheng >

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-16 Thread Gleb Natapov
On Wed, Oct 16, 2013 at 10:46:53PM +0300, Michael S. Tsirkin wrote: > Old GCC didn't let you reference variable by > number if it is listed with a specific register > constraint, on the assumption you can just > use the register name explicitly. > > Build fails with errors like this: > a.c:6: erro

Re: [Qemu-devel] [PATCH v7 4/4] PC: differentiate hpet's interrupt capability on piix and q35

2013-10-16 Thread liu ping fan
On Thu, Oct 17, 2013 at 1:44 PM, Michael S. Tsirkin wrote: > On Thu, Oct 17, 2013 at 11:16:05AM +0800, Liu Ping Fan wrote: >> For pc-piix-*, hpet's intcap is always hard coded as IRQ2. >> For q35, if it is pc-q35-1.7 and earlier, we use IRQ2 for compat >> reason, otherwise IRQ2, IRQ8, and IRQ16~23

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Gleb Natapov
On Thu, Oct 17, 2013 at 08:32:14AM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 17, 2013 at 12:25:32AM +0200, Paolo Bonzini wrote: > > Il 17/10/2013 00:03, Michael S. Tsirkin ha scritto: > > > On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: > > >> Il 16/10/2013 20:37, Michael S. Ts

Re: [Qemu-devel] [PATCH v7 4/4] PC: differentiate hpet's interrupt capability on piix and q35

2013-10-16 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 11:16:05AM +0800, Liu Ping Fan wrote: > For pc-piix-*, hpet's intcap is always hard coded as IRQ2. > For q35, if it is pc-q35-1.7 and earlier, we use IRQ2 for compat > reason, otherwise IRQ2, IRQ8, and IRQ16~23 are allowed. > > Signed-off-by: Liu Ping Fan > --- > hw/i386/

Re: [Qemu-devel] [PATCH v7 0/4] bugs fix for hpet

2013-10-16 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 11:16:01AM +0800, Liu Ping Fan wrote: > v7: > use macro to define "intcap" in pc.h > (as to 3/4 and 4/4, I am not sure about whether to merge them or not, so > keep them separate") > Yes, please smash 2 3 and 4 together. There's no need to waste time reviewing code th

[Qemu-devel] [RFC PATCH v3 2/2] qmp: add command 'blockdev-backup'

2013-10-16 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Signed-off-by: Fam Zheng --- blockdev.c | 63 qapi-schema.json | 49 +++ qmp-comm

[Qemu-devel] [RFC PATCH v3 1/2] block: parse "backing" option to reference existing BDS

2013-10-16 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index fd05a80..38b3e80 100644 --- a/block.c +++ b/block.c @@ -1158,11 +1158,28 @@ int bdrv_open(BlockDriverState *bs, const char *filename, QDic

[Qemu-devel] [RFC PATCH v3 0/2] Point-in-time snapshot exporting over NBD

2013-10-16 Thread Fam Zheng
This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time snapshot by COW mechanism of drive-backup, and export it through built in NBD server. The steps are as below: 1. (SHELL) qemu-i

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 12:25:32AM +0200, Paolo Bonzini wrote: > >> qtest could at best host some sanity checks on the ACPI tables, which > >> would catch the MCFG problems that Gerd reported on v5. > > > > Depends on how deep the test understands ACPI - the signature > > was wrong I think. > > >

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 12:25:32AM +0200, Paolo Bonzini wrote: > Il 17/10/2013 00:03, Michael S. Tsirkin ha scritto: > > On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: > >> Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto: > >>> Gleb, Paolo, what do you think? OK to merge kvm unit

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Wed, Oct 16, 2013 at 04:52:35PM -0700, Anthony Liguori wrote: > On Wed, Oct 16, 2013 at 3:25 PM, Paolo Bonzini wrote: > > Il 17/10/2013 00:03, Michael S. Tsirkin ha scritto: > >> On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: > >>> Il 16/10/2013 20:37, Michael S. Tsirkin ha scri

Re: [Qemu-devel] [Bug 1240669] Re: sd_init() generates SIGSEGV when passed NULL

2013-10-16 Thread Stefan Weil
Am 16.10.2013 22:10, schrieb Devin Boyer: > ** Description changed: > > Ran into a bug following the following tutorial: > - http://balau82.wordpress.com/2010/03/10/u-boot-for-arm-on-qemu/ > + http://balau82.wordpress.com/2010/03/10/u-boot-for-arm-on-qemu/ > > I built QEMU from a clone of m

[Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

2013-10-16 Thread Rusty Russell
This is a re-transmit of the core of the virtio endian code. Since there seems to be some interest in ARM BE virtio, I've separated this from the direct problem I was solving: PowerPC LE. Please apply! Rusty. Rusty Russell (7): virtio_get_byteswap: function for endian-ambivalent targets using

[Qemu-devel] [PATCH 3/7] hw/net/virtio-net: use virtio wrappers to access headers.

2013-10-16 Thread Rusty Russell
Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori --- hw/net/virtio-net.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 22dbd05..431a4b6 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -23

[Qemu-devel] [PATCH 6/7] hw/scsi/virtio-scsi: use virtio wrappers to access headers.

2013-10-16 Thread Rusty Russell
Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori --- hw/scsi/virtio-scsi.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/

[Qemu-devel] [PATCH 4/7] hw/net/virtio-balloon: use virtio wrappers to access page frame numbers.

2013-10-16 Thread Rusty Russell
Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori --- hw/virtio/virtio-balloon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 9504877..97c4ac5 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/vi

[Qemu-devel] [PATCH 2/7] virtio: allow byte swapping for vring and config access

2013-10-16 Thread Rusty Russell
This is based on a simpler patch by Anthony Liguouri, which only handled the vring accesses. We also need some drivers to access these helpers, eg. for data which contains headers. Signed-off-by: Rusty Russell --- hw/virtio/virtio.c | 28 ++-- 1 file changed, 14 insertio

[Qemu-devel] [PATCH 5/7] hw/block/virtio-blk: use virtio wrappers to access headers.

2013-10-16 Thread Rusty Russell
Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori --- hw/block/virtio-blk.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/blo

[Qemu-devel] [PATCH 1/7] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-10-16 Thread Rusty Russell
virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's platform-specific. The OASIS virtio 1.0 spec will fix this. Meanwhile, create a hook for little endian ppc (and potentially ARM). This is called at device reset time (whi

[Qemu-devel] [PATCH 7/7] hw/char/virtio-serial-bus: use virtio wrappers to access headers.

2013-10-16 Thread Rusty Russell
Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori --- hw/char/virtio-serial-bus.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 703f026..2dc0ccf 100644 --- a/hw/char

Re: [Qemu-devel] qemu-system-or32 is not working on OS X, ask for help.

2013-10-16 Thread Jia Liu
Hi all, On Fri, Oct 11, 2013 at 10:41 AM, Jia Liu wrote: > Hi all, > > I'm not sure about why qemu-system-or32 is not working on OS X, is it > a AREG0 problem? May you please give me some suggestion, I want to > test it on OS X, not Ubuntu any longer. GCC on OS X is OK, it looks like a Clang and

[Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-16 Thread Mike Qiu
Change to v1: remove '[not inserted]' line instead of adding '\n' Output of 'info block' scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2) [not inserted] scsi0-cd2: [not inserted] Removable device: not locked, tray closed floppy0: [not inserted] Removable device: not locked, tray close

[Qemu-devel] [PATCH v7 2/4] hpet: enable to entitle more irq pins for hpet

2013-10-16 Thread Liu Ping Fan
On q35, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23 of ioapic can be dynamically assigned to hpet as guest chooses. So we introduce intcap property to do that. (currently, its value is IRQ2. Later, it should be set by board.) Signed-off-by: Liu Ping Fan --- hw/timer/hpet.c | 12

[Qemu-devel] [PATCH v7 4/4] PC: differentiate hpet's interrupt capability on piix and q35

2013-10-16 Thread Liu Ping Fan
For pc-piix-*, hpet's intcap is always hard coded as IRQ2. For q35, if it is pc-q35-1.7 and earlier, we use IRQ2 for compat reason, otherwise IRQ2, IRQ8, and IRQ16~23 are allowed. Signed-off-by: Liu Ping Fan --- hw/i386/pc.c | 20 +++- hw/i386/pc_piix.c| 7 ++- h

[Qemu-devel] [PATCH v7 1/4] hpet: inverse polarity when pin above ISA_NUM_IRQS

2013-10-16 Thread Liu Ping Fan
According to hpet spec, hpet irq is high active. But according to ICH spec, there is inversion before the input of ioapic. So the OS will expect low active on this IRQ line. (On bare metal, if OS driver claims high active on this line, spurious irq is generated) We fold the emulation of this inver

[Qemu-devel] [PATCH v7 3/4] PC: use qdev_xx to create hpet instead of sysbus_create_xx

2013-10-16 Thread Liu Ping Fan
sysbus_create_xx func does not allow us to set a device's extra properties. While hpet need to set its compat property before initialization, so we abandon the wrapper function, and spread its logic "inline" Signed-off-by: Liu Ping Fan --- hw/i386/pc.c| 11 +-- hw/timer/hpet.c | 4

[Qemu-devel] [PATCH v7 0/4] bugs fix for hpet

2013-10-16 Thread Liu Ping Fan
v7: use macro to define "intcap" in pc.h (as to 3/4 and 4/4, I am not sure about whether to merge them or not, so keep them separate") v6: move the setting of intcap to board, and keep the init value as zero. (thanks for the discussion from Paolo and Michael) introduce an extra hpet prop

Re: [Qemu-devel] [PATCH v14 0/8] Shared Library Module Support

2013-10-16 Thread Fam Zheng
On Wed, 10/16 18:20, Paolo Bonzini wrote: > Il 16/10/2013 05:26, Fam Zheng ha scritto: > > This series implements feature of shared object building as described in: > > > > http://wiki.qemu.org/Features/Modules > > > > The main idea behind modules is to isolate dependencies on third party > > lib

Re: [Qemu-devel] [RFC PATCH v3 3/5] Adapt Makefiles to the new LTTng ust interface.

2013-10-16 Thread Mohamad Gebai
On 13-10-16 08:08 AM, Alex Bennée wrote: Add generation of new files for LTTng ust. Signed-off-by: Mohamad Gebai I did run into problems with the first build which were solved with a make clean. But I suspect making the Makefile robust to that is more effort than it's worth. I always start

Re: [Qemu-devel] [RFC PATCH v3 4/5] Update documentation for LTTng ust tracing

2013-10-16 Thread Mohamad Gebai
On 13-10-16 08:05 AM, Alex Bennée wrote: Running this gives me: UST events: - None Before or after running qemu. What is the mechanism lttng expects to find out all these events? Either the user should belong the group "tracing", or launch the lttng-sessiond daemon (lttng-session

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Anthony Liguori
On Wed, Oct 16, 2013 at 3:25 PM, Paolo Bonzini wrote: > Il 17/10/2013 00:03, Michael S. Tsirkin ha scritto: >> On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: >>> Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto: Gleb, Paolo, what do you think? OK to merge kvm unit test

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Paolo Bonzini
Il 17/10/2013 00:03, Michael S. Tsirkin ha scritto: > On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: >> Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto: >>> Gleb, Paolo, what do you think? OK to merge kvm unit test >>> into qemu? It depends on qemu anyway, in-tree will make it ea

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: > Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto: > > Gleb, Paolo, what do you think? OK to merge kvm unit test > > into qemu? It depends on qemu anyway, in-tree will make it easier. > > Maybe someone's looking at this already? > >

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Paolo Bonzini
Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto: > Gleb, Paolo, what do you think? OK to merge kvm unit test > into qemu? It depends on qemu anyway, in-tree will make it easier. > Maybe someone's looking at this already? I think merging KVM unit tests doesn't make much sense because, with some

[Qemu-devel] [PATCH V2] Fix float64_to_uint64

2013-10-16 Thread Tom Musta
The comment preceding the float64_to_uint64 routine suggests that the implementation is broken. And this is, indeed, the case. This patch properly implements the conversion of a 64-bit floating point number to an unsigned, 64 bit integer. Note that the patch does not pass scripts/checkpatch.pl

Re: [Qemu-devel] [PATCH] Fix float64_to_uint64

2013-10-16 Thread Peter Maydell
On 16 October 2013 15:19, Tom Musta wrote: > The comment preceding the float64_to_uint64 routine suggests that > the implementation is broken. And this is, indeed, the case. > > This patch properly implements the conversion of a 64-bit floating > point number to an unsigned, 64 bit integer. This

Re: [Qemu-devel] [PATCH] Fix float64_to_uint64

2013-10-16 Thread Richard Henderson
On 10/16/2013 07:19 AM, Tom Musta wrote: > The comment preceding the float64_to_uint64 routine suggests that > the implementation is broken. And this is, indeed, the case. > > This patch properly implements the conversion of a 64-bit floating > point number to an unsigned, 64 bit integer. > > No

[Qemu-devel] [Bug 1240669] Re: sd_init() generates SIGSEGV when passed NULL

2013-10-16 Thread Devin Boyer
** Description changed: Ran into a bug following the following tutorial: - http://balau82.wordpress.com/2010/03/10/u-boot-for-arm-on-qemu/ + http://balau82.wordpress.com/2010/03/10/u-boot-for-arm-on-qemu/ I built QEMU from a clone of master and became stuck at the beginning part of the t

[Qemu-devel] [Bug 1240669] [NEW] sd_init() generates SIGSEGV when passed NULL

2013-10-16 Thread Devin Boyer
Public bug reported: Ran into a bug following the following tutorial: http://balau82.wordpress.com/2010/03/10/u-boot-for-arm-on-qemu/ I built QEMU from a clone of master and became stuck at the beginning part of the tutorial where only u-boot.bin is exectuted. http://git.qemu.org/?p=qemu.git;a=

Re: [Qemu-devel] [PATCH 00/60] AArch64 TCG emulation support

2013-10-16 Thread Edgar E. Iglesias
On Fri, Sep 27, 2013 at 02:47:54AM +0200, Alexander Graf wrote: > Howdy, > > This is the first batch of patches to implement AArch64 instruction > emulation in QEMU. It implements enough to execute simple AArch64 > programs in linux-user mode. > > We still have quite a big number of patches outst

Re: [Qemu-devel] RFC: KVM _CREATE_DEVICE considered harmful?

2013-10-16 Thread Christian Borntraeger
On 16/10/13 17:44, Gleb Natapov wrote: > On Wed, Oct 16, 2013 at 02:59:47PM +0200, Christian Borntraeger wrote: >> Folks, >> >> from time to time I update valgrind or qemu to work reasonably well >> with KVM. >> >> Now, newer KVMs have the ability to create subdevices of a KVM guest (e.g. >> an in

[Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-16 Thread Michael S. Tsirkin
Old GCC didn't let you reference variable by number if it is listed with a specific register constraint, on the assumption you can just use the register name explicitly. Build fails with errors like this: a.c:6: error: invalid 'asm': invalid operand code 'd' To fix, let's just use %eax %al etc.

Re: [Qemu-devel] [PATCH 0/9] Remove legacy unaligned bswap functions

2013-10-16 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 02:36:58PM +0100, Peter Maydell wrote: > Ping^2, seven weeks after initial post and code review. > > Frankly, our mechanism for committing patches which aren't > obviously localised to a specific subsystem sucks :-( > It seems like pretty much every time it takes multiple >

Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete

2013-10-16 Thread Max Reitz
On 2013-10-15 04:23, Fam Zheng wrote: There is errp passed in, so no need for local_err and error_propagate. Also drop the backing_filename which is set but unused since 34b5d2c. I approve of dropping the backing_filename code, but I don't know if I like removing the error_propagate. I perso

Re: [Qemu-devel] [PATCH] qemu-iotests: fix 030 for faster machines

2013-10-16 Thread Max Reitz
On 2013-10-15 04:41, Fam Zheng wrote: If the block job completes too fast, the test can fail. Change the numbers so the qmp events are more stably captured by the script. A sleep is removed for the same reason. Signed-off-by: Fam Zheng --- tests/qemu-iotests/030 | 11 +-- 1 file cha

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Wed, Oct 16, 2013 at 11:18:42AM -0700, Anthony Liguori wrote: > On Wed, Oct 16, 2013 at 11:18 AM, Michael S. Tsirkin wrote: > > On Wed, Oct 16, 2013 at 09:38:29AM -0700, Anthony Liguori wrote: > >> On Tue, Oct 15, 2013 at 1:17 PM, Michael S. Tsirkin > >> wrote: > >> > On Tue, Oct 15, 2013 at

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Anthony Liguori
On Wed, Oct 16, 2013 at 11:18 AM, Michael S. Tsirkin wrote: > On Wed, Oct 16, 2013 at 09:38:29AM -0700, Anthony Liguori wrote: >> On Tue, Oct 15, 2013 at 1:17 PM, Michael S. Tsirkin wrote: >> > On Tue, Oct 15, 2013 at 09:27:33AM -0700, Anthony Liguori wrote: >> >> Paolo Bonzini writes: >> >> >>

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Wed, Oct 16, 2013 at 09:38:29AM -0700, Anthony Liguori wrote: > On Tue, Oct 15, 2013 at 1:17 PM, Michael S. Tsirkin wrote: > > On Tue, Oct 15, 2013 at 09:27:33AM -0700, Anthony Liguori wrote: > >> Paolo Bonzini writes: > >> > >> > Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto: > >> >> On

Re: [Qemu-devel] Which functions of southbridges should be no-user?

2013-10-16 Thread Anthony Liguori
On Wed, Oct 16, 2013 at 3:00 AM, Markus Armbruster wrote: > Anthony Liguori writes: > >> On Tue, Oct 15, 2013 at 7:41 AM, Kevin Wolf wrote: >>> Am 15.10.2013 um 15:31 hat Andreas Färber geschrieben: Am 15.10.2013 15:21, schrieb Markus Armbruster: > Andreas, > > To go beyond R

Re: [Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock

2013-10-16 Thread Daniel P. Berrange
On Wed, Oct 16, 2013 at 07:17:08PM +0200, Paolo Bonzini wrote: > This lock does not protect anything that the BQL does not already > protect. Furthermore, with -nodefaults and no monitor, the mutex > is not initialized but monitor_protocol_event_queue is called > anyway, which causes a crash under

Re: [Qemu-devel] [ANNOUNCE] Key Signing Party at KVM Forum 2013

2013-10-16 Thread Asias He
On Mon, Oct 14, 2013 at 7:14 PM, Stefan Hajnoczi wrote: > > On Wed, Jul 24, 2013 at 2:50 PM, Anthony Liguori > wrote: > > > > I will be hosting a key signing party at this year's KVM Forum. > > > > http://wiki.qemu.org/KeySigningParty2013 > > keyserver.cryptnet.net seems broken. I get connectio

[Qemu-devel] RFC: KVM _CREATE_DEVICE considered harmful?

2013-10-16 Thread Christian Borntraeger
Folks, from time to time I update valgrind or qemu to work reasonably well with KVM. Now, newer KVMs have the ability to create subdevices of a KVM guest (e.g. an in kernel kvm interrupt controller) with the following ioctl: #define KVM_CREATE_DEVICE _IOWR(KVMIO, 0xe0, struct kvm_creat

[Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock

2013-10-16 Thread Paolo Bonzini
This lock does not protect anything that the BQL does not already protect. Furthermore, with -nodefaults and no monitor, the mutex is not initialized but monitor_protocol_event_queue is called anyway, which causes a crash under mingw (and only works by luck. under Linux or other POSIX OSes). Repo

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Anthony Liguori
On Tue, Oct 15, 2013 at 1:17 PM, Michael S. Tsirkin wrote: > On Tue, Oct 15, 2013 at 09:27:33AM -0700, Anthony Liguori wrote: >> Paolo Bonzini writes: >> >> > Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto: >> >> On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote: >> >>> Il 14/10/2

Re: [Qemu-devel] [PATCH 04/18] bsd-user: move target arch and host OSdependent code out of main.cc

2013-10-16 Thread Peter Maydell
On 16 October 2013 16:46, Stacey Son wrote: > The arm code came from another source as noted in the cover letter. It could > use a lot more work. Possibly better to leave it out of this initial patch set and submit it separately later then? -- PMM

Re: [Qemu-devel] [PATCH 18/18] bsd-user: add arm, mips and mips64 options to configure target-listt

2013-10-16 Thread Peter Maydell
On 16 October 2013 16:22, Alex Bennée wrote: > Given how little is typically in the -user .mak fragments I wonder what > the point of them is. Should the build fall-back to a generic .mak > fragment if there is no special config for a given build target? At the moment our list of "targets that yo

Re: [Qemu-devel] [PATCH 00/18] bsd-user: Add system call and mips/arm support.

2013-10-16 Thread Peter Maydell
On 16 October 2013 15:36, Stacey Son wrote: > This patch series adds a significant number of system calls and mips/arm > support for bsd-user. In its current state it can emulate most > FreeBSD mips/mips64 and arm target binaries on a x86 host in a simple > chroot environment. (see https://wiki.f

Re: [Qemu-devel] Should the i8259 devices remain no-user?

2013-10-16 Thread BALATON Zoltan
On Wed, 16 Oct 2013, Paolo Bonzini wrote: Il 16/10/2013 11:51, Markus Armbruster ha scritto: Let me try to elaborate, to make sure I understand. Unlike ordinary ISA devices, the i8259 devices need additional wiring, done by code. For instance, board code like pc_q35_init(), pc_piix.c's pc_init

Re: [Qemu-devel] [PATCH 18/18] bsd-user: add arm, mips and mips64 options to configure target-list

2013-10-16 Thread Peter Maydell
On 16 October 2013 15:37, Stacey Son wrote: > This change adds arm-bsd-user, mips-bsd-user, mips64-bsd-user, > mips64el-bsd-user, and mipsel-bsd-user as --target-list options to configure. > diff --git a/default-configs/arm-bsd-user.mak > b/default-configs/arm-bsd-user.mak > new file mode 100644

Re: [Qemu-devel] Should the i8259 devices remain no-user?

2013-10-16 Thread Paolo Bonzini
Il 16/10/2013 18:21, BALATON Zoltan ha scritto: > On Wed, 16 Oct 2013, Paolo Bonzini wrote: >> Il 16/10/2013 11:51, Markus Armbruster ha scritto: >>> Let me try to elaborate, to make sure I understand. >>> >>> Unlike ordinary ISA devices, the i8259 devices need additional wiring, >>> done by code.

Re: [Qemu-devel] [PATCH v14 0/8] Shared Library Module Support

2013-10-16 Thread Paolo Bonzini
Il 16/10/2013 05:26, Fam Zheng ha scritto: > This series implements feature of shared object building as described in: > > http://wiki.qemu.org/Features/Modules > > The main idea behind modules is to isolate dependencies on third party > libraries from qemu executables, such as libglusterfs or li

Re: [Qemu-devel] Should the i8259 devices remain no-user?

2013-10-16 Thread Markus Armbruster
Paolo Bonzini writes: > Il 16/10/2013 11:51, Markus Armbruster ha scritto: >> Let me try to elaborate, to make sure I understand. >> >> Unlike ordinary ISA devices, the i8259 devices need additional wiring, >> done by code. >> >> For instance, board code like pc_q35_init(), pc_piix.c's pc_init1

Re: [Qemu-devel] [PATCH 18/18] bsd-user: add arm, mips and mips64 options to configure target-listt

2013-10-16 Thread Stacey Son
On Oct 16, 2013, at 10:22 AM, Alex Bennée wrote: > > s...@freebsd.org writes: > >> This change adds arm-bsd-user, mips-bsd-user, mips64-bsd-user, >> mips64el-bsd-user, and mipsel-bsd-user as --target-list options to configure. >> >> Signed-off-by: Stacey Son >> --- > >> new file mode 100644

[Qemu-devel] [PATCH] Fix VNC SASL authentication when using a QXL device

2013-10-16 Thread Christophe Fergeau
ui/vnc.c:vnc_display_open() and spice-server/server/reds.c:do_spice_init() are both calling sasl_server_init(). If spice_server_set_sasl_appname() hasn't been called, spice-server will call it with "spice" as an appname, causing cyrus-sasl to try to use a /etc/sasl2/spice.conf config file rather th

Re: [Qemu-devel] [PATCH 04/18] bsd-user: move target arch and host OSdependent code out of main.cc

2013-10-16 Thread Alex Bennée
s...@freebsd.org writes: > This change moves the cpu initialization and main loop code from > main.c to the OS and arch dependent directories. This eliminates > many of the #ifdef's in main.c. The cpu initialization and loop > code is now located in the arch directory along with target arch > sup

Re: [Qemu-devel] [PATCH 04/18] bsd-user: move target arch and host OSdependent code out of main.cc

2013-10-16 Thread Stacey Son
The arm code came from another source as noted in the cover letter. It could use a lot more work. -stacey. On Oct 16, 2013, at 10:38 AM, Alex Bennée wrote: > > s...@freebsd.org writes: > >> This change moves the cpu initialization and main loop code from >> main.c to the OS and arch depen

Re: [Qemu-devel] RFC: KVM _CREATE_DEVICE considered harmful?

2013-10-16 Thread Gleb Natapov
On Wed, Oct 16, 2013 at 02:59:47PM +0200, Christian Borntraeger wrote: > Folks, > > from time to time I update valgrind or qemu to work reasonably well > with KVM. > > Now, newer KVMs have the ability to create subdevices of a KVM guest (e.g. an > in kernel > kvm interrupt controller) with the f

Re: [Qemu-devel] [PATCH 00/18] bsd-user: Add system call and mips/armsupport..

2013-10-16 Thread Stacey Son
On Oct 16, 2013, at 10:27 AM, Alex Bennée wrote: > > s...@freebsd.org writes: > >> This patch series adds a significant number of system calls and mips/arm >> support for bsd-user. In its current state it can emulate most >> FreeBSD mips/mips64 and arm target binaries on a x86 host in a simpl

Re: [Qemu-devel] [PATCH 00/18] bsd-user: Add system call and mips/armsupport..

2013-10-16 Thread Alex Bennée
s...@freebsd.org writes: > This patch series adds a significant number of system calls and mips/arm > support for bsd-user. In its current state it can emulate most > FreeBSD mips/mips64 and arm target binaries on a x86 host in a simple > chroot environment. (see https://wiki.freebsd.org/QemuUse

Re: [Qemu-devel] [PATCH 18/18] bsd-user: add arm, mips and mips64 options to configure target-listt

2013-10-16 Thread Alex Bennée
s...@freebsd.org writes: > This change adds arm-bsd-user, mips-bsd-user, mips64-bsd-user, > mips64el-bsd-user, and mipsel-bsd-user as --target-list options to configure. > > Signed-off-by: Stacey Son > --- > new file mode 100644 > index 000..46d4aa2 > --- /dev/null > +++ b/default-configs/a

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Paolo Bonzini
Il 15/10/2013 22:17, Michael S. Tsirkin ha scritto: > OK so I can interpret this in 2 ways wrt bridge hotplug: > - it's in shape for 1.7 except the migration which should use > subsections (and needs cross-version testing) > - it's not in shape for 1.7 > > Can you tell me which it is please? >

Re: [Qemu-devel] RFC: KVM _CREATE_DEVICE considered harmful?

2013-10-16 Thread Paolo Bonzini
Il 16/10/2013 16:23, Christian Borntraeger ha scritto: > That would work, but it would change the ioctl number of KVM_*_DEVICE_ADDR, > due to the changed size of struct kvm_device_attr. We would then need compat > handlers in the kernel. Actually I did that on purpose :) but perhaps you're right

Re: [Qemu-devel] BUG: RTC issue when Windows guest is idle

2013-10-16 Thread Matthew Anderson
Hi Xiangyouxie, I personally haven't tried to solve the problem as yet but I've been in contact with Anders Fudali who was able to find the issue with the help of one of his developers. See below for his comments. I've love to hear from any of the devs that can explain the issue further becau

[Qemu-devel] [PATCH 16/18] bsd-user: add support for extended attribute and ACL related syscalls

2013-10-16 Thread Stacey Son
This change add support for extended attribute and Access Control List (ACL) related system calls including extattrctl(), extattr_set_file(2), extattr_delete_file(2), extattr_set_fd(2), extattr_get_fd(2), extattr_delete_fd(2), extattr_get_link(2), extattr_set_link(2), extattr_delete_link(2), extatt

[Qemu-devel] [PATCH 13/18] bsd-user: add support for socket related system calls

2013-10-16 Thread Stacey Son
This change adds support or stubs for socket related system calls including accept(2), bind(2), connect(2), getpeername(2), getsockname(2), getsockopt(2), setsockopt(2), listen(2), recvfrom(2), recvmsg(2), sendmsg(2), sendto(2), socket(2), socketpair(2), shutdown(2), setfib(2), sctp_peeloff(2), sct

[Qemu-devel] [PATCH 18/18] bsd-user: add arm, mips and mips64 options to configure target-list

2013-10-16 Thread Stacey Son
This change adds arm-bsd-user, mips-bsd-user, mips64-bsd-user, mips64el-bsd-user, and mipsel-bsd-user as --target-list options to configure. Signed-off-by: Stacey Son --- default-configs/arm-bsd-user.mak |3 +++ default-configs/mips-bsd-user.mak |1 + default-configs/mips64-bsd-

[Qemu-devel] [PATCH 12/18] bsd-user: add support for memory management related system calls

2013-10-16 Thread Stacey Son
This change adds support or stubs for memory management related system calls including mmap(2), munmap(2), mprotect(2), msync(2), mlock(2), munlock(2), mlockall(2), munlockall(2), madvise(2), minherit(2), mincore(2), shm_open(2), shm_unlink(2), shmget(2), shmctl(2), shmat(2), shmdt(2), vadvise(), s

[Qemu-devel] [PATCH 11/18] bsd-user: add support for stat, directory, and file control related system calls

2013-10-16 Thread Stacey Son
This change adds support or stubs for stat, directory, and file control related system calls including stat(2), lstat(2), fstat(2), fstatat(2), nstat(), nfstat(), nlstat(), getfh(2), lgetfh(2), fhopen(2), fhstat(2), fhstatfs(2), statfs(2), fstatfs(2), getfsstat(2), getdents(2), getdirentries(2), a

[Qemu-devel] [PATCH 02/18] bsd-user: add HOST_ABI_DIR for the various *BSD dependent code.

2013-10-16 Thread Stacey Son
This change adds HOST_ABI_DIR (similar to TARGET_ABI_DIR) so the various BSD OS dependent code can be seperated into its own directories rather than using #ifdef's. Signed-off-by: Stacey Son --- Makefile.target |3 ++- configure | 11 +++ 2 files changed, 13 insertions(+), 1

[Qemu-devel] [PATCH 10/18] bsd-user: add support for file system related system calls

2013-10-16 Thread Stacey Son
This change adds support or stubs for file system (except stat) related system calls including read(2), pread(2), readv(2), write(2), pwrite(2), writev(2), pwritev(2), open(2), openat(2), close(2), closefrom(2), revoke(2), access(2), eaccess(2), faccessat(2), chdir(2), fchdir(2), rename(2), rename

[Qemu-devel] [PATCH 05/18] bsd-user: move target arch and host OS dependent code out of syscall.c

2013-10-16 Thread Stacey Son
This change moves the system call handler for sysctl(2) and sysarch(2) from syscall.c to the OS and arch dependent directories. This eliminates many of the #ifdef's in syscall.c. These system call handlers are now located in the host os and target arch directories. Signed-off-by: Stacey Son ---

[Qemu-devel] [PATCH 03/18] bsd-user: move OS/arch dependent code for strace into separate directories

2013-10-16 Thread Stacey Son
This change moves host OS and arch dependent code for the sysarch system call related to the -strace functionality into the appropriate HOST_ABI_DIR and TARGET_ABI_DIR directories. Signed-off-by: Stacey Son --- bsd-user/arm/syscall.h | 36 +++ bsd-user/arm/target_arch_sysar

[Qemu-devel] [PATCH 01/18] bsd-user: refresh freebsd system call numbers

2013-10-16 Thread Stacey Son
Update FreeBSD system call numbers in freebsd/syscall_nr.h. Signed-off-by: Stacey Son --- bsd-user/freebsd/syscall_nr.h | 813 ++--- 1 files changed, 445 insertions(+), 368 deletions(-) diff --git a/bsd-user/freebsd/syscall_nr.h b/bsd-user/freebsd/syscall_nr

[Qemu-devel] [PATCH 00/18] bsd-user: Add system call and mips/arm support.

2013-10-16 Thread Stacey Son
This patch series adds a significant number of system calls and mips/arm support for bsd-user. In its current state it can emulate most FreeBSD mips/mips64 and arm target binaries on a x86 host in a simple chroot environment. (see https://wiki.freebsd.org/QemuUserModeHowTo for the details.) Besid

Re: [Qemu-devel] [PATCH] tcg-hppa: Remove tcg backend

2013-10-16 Thread Richard Henderson
On 10/16/2013 06:59 AM, Rob Landley wrote: > But there's no qemu system emulation for hppa or parisc. Bootstrapping a > system > doesn't help if qemu can't actually emulate a board to run it on. (Am I > missing > something?) A cross-compile of qemu would have made sure that there are no compilat

Re: [Qemu-devel] RFC: KVM _CREATE_DEVICE considered harmful?

2013-10-16 Thread Christian Borntraeger
dropping valgrind devel since its subscribers only... On 16/10/13 15:06, Paolo Bonzini wrote: > Il 16/10/2013 14:59, Christian Borntraeger ha scritto: >> >> Now, newer KVMs have the ability to create subdevices of a KVM guest (e.g. >> an in kernel >> kvm interrupt controller) with the following i

[Qemu-devel] [PATCH] Fix float64_to_uint64

2013-10-16 Thread Tom Musta
The comment preceding the float64_to_uint64 routine suggests that the implementation is broken. And this is, indeed, the case. This patch properly implements the conversion of a 64-bit floating point number to an unsigned, 64 bit integer. Note that the patch does not pass scripts/checkpatch.pl

Re: [Qemu-devel] [PATCH] tcg-hppa: Remove tcg backend

2013-10-16 Thread Rob Landley
On 10/01/2013 12:19:51 PM, Richard Henderson wrote: On 09/25/2013 12:27 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > > Since the GCC compile farm took their hppa machine off-line, I have no way > to test this port anymore. Worse, I can't find any distributions tha

Re: [Qemu-devel] [PATCH 4/4] pc: add 'etc/pcimem64-minimum-address' fw_cfg interface to SeaBIOS

2013-10-16 Thread Michael S. Tsirkin
On Wed, Oct 16, 2013 at 02:19:13PM +0200, Igor Mammedov wrote: > On Wed, 16 Oct 2013 12:29:48 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Oct 16, 2013 at 10:49:14AM +0200, Igor Mammedov wrote: > > > 'etc/pcimem64-minimum-address' will allow QEMU to communicate to BIOS > > > where PCI memory

[Qemu-devel] [PATCH] sd: Avoid access to NULL BlockDriverState

2013-10-16 Thread Andreas Färber
Commit 4f8a066b5fc254eeaabbbde56ba4f5b29cc68fdf (blockdev: Remove IF_* check for read-only blockdev_init) added a usage of bdrv_is_read_only() to sd_init(), which is called for versatilepb, versatileab and xilinx-zynq-a9 machines among others with NULL argument by default, causing the new qom-test

Re: [Qemu-devel] RFC: KVM _CREATE_DEVICE considered harmful?

2013-10-16 Thread Paolo Bonzini
Il 16/10/2013 14:59, Christian Borntraeger ha scritto: > > Now, newer KVMs have the ability to create subdevices of a KVM guest (e.g. an > in kernel > kvm interrupt controller) with the following ioctl: > > #define KVM_CREATE_DEVICE _IOWR(KVMIO, 0xe0, struct > kvm_create_device) > > q

[Qemu-devel] [PATCH v2 1/4] qemu-char: add Czech characters to VNC keysyms

2013-10-16 Thread Jan Krupa
This patch adds missing Czech characters to the VNC keysym table. Signed-off-by: Jan Krupa --- ui/vnc_keysym.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/ui/vnc_keysym.h b/ui/vnc_keysym.h index 6250bec..72c01d1 100644 --- a/ui/vnc_keysym.h +++ b/ui/vnc_keysym

[Qemu-devel] [PATCH v2 0/4] qemu-char: keymap changes for Czech and Unicode support

2013-10-16 Thread Jan Krupa
I tried to create keymap for Czech keyboard for QEMU. I found out that some of the keysyms are missing. I added those specific symbols to QEMU VNC header files plus wrote the whole keyboard layout. I also added missing symbols for already existing keymaps in QEMU. Another issue I hit during keyboa

[Qemu-devel] [PATCH v2 4/4] qemu-char: add missing characters used in keymaps

2013-10-16 Thread Jan Krupa
This patch adds all missing characters used in regional keymap files which already exist in QEMU. I checked for the missing characters by going through all of the keymaps and matching that with records in vnc_keysym.h. If the key wasn't found I looked it up in libxkbcommon library [1]. If I underst

[Qemu-devel] [PATCH v2 2/4] qemu-char: add Czech keymap file

2013-10-16 Thread Jan Krupa
This patch adds Czech keyboard layout to available keymap files and Makefile. Signed-off-by: Jan Krupa --- Makefile |2 +- pc-bios/keymaps/cz | 94 2 files changed, 95 insertions(+), 1 deletions(-) create mode 100644 pc-bios/k

[Qemu-devel] [PATCH v2 3/4] qemu-char: add support for U-prefixed symbols

2013-10-16 Thread Jan Krupa
This patch adds support for Unicode symbols in keymap files. This feature was already used in some keyboard layouts in QEMU generated from XKB (e.g. Arabic) but it wasn't implemented in QEMU source code. There is no need for check of validity of the hex string after U character because strtol retu

Re: [Qemu-devel] [PATCH RFC 04/11] s390/qemu: cpu model cpu facilitiy support

2013-10-16 Thread Michael Mueller
On Tue, 15 Oct 2013 15:46:57 -0700 Richard Henderson wrote: > On 10/07/2013 03:47 AM, Michael Mueller wrote: > > A second reason for using 2k of memory here is to fully represent the > > facilities as defined > > in the s390x architecture. The SIE state needs it and I want to represent > > it i

Re: [Qemu-devel] [PATCH 4/4] pc: add 'etc/pcimem64-minimum-address' fw_cfg interface to SeaBIOS

2013-10-16 Thread Igor Mammedov
On Wed, 16 Oct 2013 12:29:48 +0300 "Michael S. Tsirkin" wrote: > On Wed, Oct 16, 2013 at 10:49:14AM +0200, Igor Mammedov wrote: > > 'etc/pcimem64-minimum-address' will allow QEMU to communicate to BIOS > > where PCI memory address space mapping starts in high memory. > > > > Allowing BIOS start

  1   2   >