Re: [Qemu-devel] [PATCH 1/2] Mostly revert "qemu-help: Sort devices by logical functionality"

2013-10-10 Thread Markus Armbruster
Marcel Apfelbaum writes: > On Thu, 2013-10-10 at 15:00 +0200, arm...@redhat.com wrote: >> From: Markus Armbruster >> >> This reverts most of commit 3d1237fb2ab4edb926c717767bb5e31d6053a7c5. >> >> The commit claims to sort the output of "-device help" "by >> functionality rather than alphabetic

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

2013-10-10 Thread Gerd Hoffmann
On Do, 2013-10-10 at 21:17 +0200, Sebastian Herbszt wrote: > Andreas Färber wrote: > > Same for http://patchwork.ozlabs.org/patch/273758/ - vgabios seems to > > be falling through the cracks... > > > > Andreas > > > > Is this patch still required? > I was under the impression that no patch is nee

Re: [Qemu-devel] [PATCH] Use qemu-project.org domain name

2013-10-10 Thread Markus Armbruster
Stefan Weil writes: > Am 10.10.2013 11:39, schrieb Stefan Hajnoczi: >> qemu.org is held by a third-party and no core community contributor has >> access to the DNS configuration. This leaves the website exposed to >> outages due to DNS issues or IP address changes. For example, if the >> web se

Re: [Qemu-devel] [RFC] map 64-bit PCI devices after all possible RAM

2013-10-10 Thread Gerd Hoffmann
Hi, > Ok, then would "etc/pcimem64-start" be suitable or maybe you have a > suggestion? Looks good to me. cheers, Gerd

Re: [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message

2013-10-10 Thread Markus Armbruster
Cole Robinson writes: > Using multiple calls to error_report here means every line is > prefaced with the (potentially long) pci-assign command line > arguments. Use a single error_report to preserve the intended > formatting. The orthodox way to do this is to use error_report() for the (single-

Re: [Qemu-devel] [PATCH RFC 5/9] ich9: Document why cannot_instantiate_with_device_add_yet

2013-10-10 Thread Markus Armbruster
Paolo Bonzini writes: > Il 10/10/2013 18:01, Paolo Bonzini ha scritto: >> Il 10/10/2013 16:42, arm...@redhat.com ha scritto: >>> From: Markus Armbruster >>> >>> An ICH9 southbridge contains several PCI devices, some of them with >>> multiple functions. We model each function as a separate qdev.

Re: [Qemu-devel] [PATCH] Spelling fixes

2013-10-10 Thread Stefan Weil
Am 11.10.2013 03:34, schrieb Peter Maydell: > On 11 October 2013 04:11, Stefan Weil wrote: >> Am 08.07.2013 17:14, schrieb Corentin Chary: >>> The comments (and most of the code) are from libvncserver (and, >>> earlier, from "THE 'ZYWRLE' VNC CODEC SOURCE CODE. " as described in >>> the header): >

[Qemu-devel] [PATCH] vmdk: Fix vmdk_parse_extents

2013-10-10 Thread Fam Zheng
An extra 'p++' after while loop when *p == '\n' will move p to unknown data position, risking parsing junk data or memory access violation. Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng --- block/vmdk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c

[Qemu-devel] [RFC PATCH] spapr: add ibmveth to the supported network adapters list

2013-10-10 Thread Alexey Kardashevskiy
The problem is that "-net nic,model=?" does not print "ibmveth" in the list while it is actually supported. Most of the QEMU emulated network devices are PCI but "ibmveth" (a.k.a. spapr-vlan) is not. However with "-net nic,model=?", QEMU prints only PCI devices in the list, even if it does not say

[Qemu-devel] [PATCH] spapr: add vio-bus devices to categories

2013-10-10 Thread Alexey Kardashevskiy
In order to get devices appear in output of "./qemu-system-ppc64 -device ?", they must be assigned to one of DEVICE_CATEGORY_. This puts VIO devices classes to corresponding categories. Signed-off-by: Alexey Kardashevskiy --- hw/char/spapr_vty.c| 1 + hw/net/spapr_llan.c| 1 + hw/nv

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-10 Thread liu ping fan
On Thu, Oct 10, 2013 at 5:11 PM, Paolo Bonzini wrote: > Il 10/10/2013 09:56, Liu Ping Fan ha scritto: >> On q35, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23 >> of ioapic can be dynamically assigned to hpet as guest chooses. >> So we introduce intcap property to do that. (currently, it

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-10 Thread liu ping fan
On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin wrote: > On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote: >> Il 10/10/2013 11:41, Michael S. Tsirkin ha scritto: >> >> > Are you sure? This is not done for any other compat property. >> >> > >> >> > Paolo >> > It's done if we use t

Re: [Qemu-devel] [RFC] SPAPR-PCI Hotplug Support in Qemu

2013-10-10 Thread Benjamin Herrenschmidt
On Thu, 2013-10-10 at 18:30 -0400, Mike Day wrote: > Adding Anthony's corrected address. > > > On Thu, Oct 10, 2013 at 6:25 PM, Mike Day wrote: > [RFC] SPAPR-PCI Hotplug Support in Qemu > > > > Background: > > ppc64 has a unique bus structure for PCI slots: each slot is connected > > to its PHB

[Qemu-devel] qemu-system-or32 is not working on OS X, ask for help.

2013-10-10 Thread Jia Liu
Hi all, I'm not sure about why qemu-system-or32 is not working on OS X, is it a AREG0 problem? May you please give me some suggestion, I want to test it on OS X, not Ubuntu any longer. Thank you. Regards, Jia

[Qemu-devel] [PATCH v13 0/8] Shared Library Module Support

2013-10-10 Thread Fam Zheng
This series implements feature of shared object building as described in: http://wiki.qemu.org/Features/Modules The main idea behind modules is to isolate dependencies on third party libraries from qemu executables, such as libglusterfs or librbd, so that the end users can install core qemu packa

[Qemu-devel] [PATCH v13 4/8] build-sys: introduce common-obj-m and block-obj-m for DSO

2013-10-10 Thread Fam Zheng
Add necessary rules and flags for shared object generation. $(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does for $(block-obj-y). The new rules introduced here are: 0) For all %.so compiling: QEMU_CFLAGS += -fPIC 1) %.o in $(common-obj-m) is compiled to %.o, then linked

Re: [Qemu-devel] [PATCH] Spelling fixes

2013-10-10 Thread Peter Maydell
On 11 October 2013 04:11, Stefan Weil wrote: > Am 08.07.2013 17:14, schrieb Corentin Chary: >> The comments (and most of the code) are from libvncserver (and, >> earlier, from "THE 'ZYWRLE' VNC CODEC SOURCE CODE. " as described in >> the header): >> >> http://fastdroid-vnc.googlecode.com/svn-histo

[Qemu-devel] [PATCH v13 1/8] ui/Makefile.objs: delete unnecessary cocoa.o dependency

2013-10-10 Thread Fam Zheng
From: Peter Maydell Delete an unnecessary dependency for cocoa.o; we already have a general rule that tells Make that we can build a .o file from a .m source using an ObjC compiler, so this specific rule is unnecessary. Further, it is using the dubious construct "$(SRC_PATH)/$(obj)" to get at the

[Qemu-devel] [PATCH v13 8/8] block: convert block drivers linked with libs to modules

2013-10-10 Thread Fam Zheng
The converted block drivers are: curl iscsi rbd ssh glusterfs no longer adds flags and libs for them to global variables, instead create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is used as per object cflags and libs. Signed-off-by: Fam Zheng --- block/M

[Qemu-devel] [PATCH v13 6/8] Makefile: install modules with "make install"

2013-10-10 Thread Fam Zheng
Install all the modules to ${MODDIR}. Signed-off-by: Fam Zheng --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index 51de298..356ff5c 100644 --- a/Makefile +++ b/Makefile @@ -365,6 +365,12 @@ install-datadir install-localstatedir ifneq ($(TOOLS),)

[Qemu-devel] [PATCH v13 5/8] module: implement module loading

2013-10-10 Thread Fam Zheng
This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as __attribute__((constructor)) in static linked version, it is called only after passed the checking of presense of stamp symbol: qemu_stamp_$(date +%s$$$RA

[Qemu-devel] [PATCH v13 3/8] rule.mak: allow per object cflags and libs

2013-10-10 Thread Fam Zheng
Adds extract-libs in LINK to expand any "per object libs", the syntax to define such a libs options is like: foo.o-libs := $(CURL_LIBS) in block/Makefile.objs. Similarly, foo.o-cflags := $(FOO_CFLAGS) is also supported. "foo.o" must be listed a nested var (e.g. common-obj-y) t

[Qemu-devel] [PATCH v13 7/8] .gitignore: ignore module related files (dll, so, mo)

2013-10-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 8e1b73f..ac679ea 100644 --- a/.gitignore +++ b/.gitignore @@ -63,6 +63,9 @@ fsdev/virtfs-proxy-helper.pod *.cp *.dvi *.exe +*.dll +*.so +*.mo *.fn *.ky *.log -- 1.8.

[Qemu-devel] [PATCH v13 2/8] make.rule: fix $(obj) to a real relative path

2013-10-10 Thread Fam Zheng
Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't hurt compiling bec

Re: [Qemu-devel] [PATCH v12 5/8] module: implement module loading

2013-10-10 Thread Fam Zheng
On Thu, 10/10 15:40, Paolo Bonzini wrote: > Il 10/10/2013 14:34, Fam Zheng ha scritto: > > Hmm, basically an analogue to bindir and libdir. > > > > I'm not sure why wasn't that libdir/bindir always be ${prefix}/lib and > > ${prefix}/bin as well. So why are they needed? > > > > AFAICT it is not a

[Qemu-devel] [PATCH] rdma: fix multiple VMs parallel migration

2013-10-10 Thread Zhanghaoyu (A)
When several VMs migrate with RDMA at the same time, the increased pressure cause packet loss probabilistically and make source and destination wait for each other. There might be some of VMs blocked during the migration. Fix the bug by using two completion queues, for sending and receiving resp

[Qemu-devel] [PATCH v2] vfio-pci: Disallow device from using NoSnoop transactions

2013-10-10 Thread Alex Williamson
NoSnoop is a PCIe attribute that allows devices to issue transactions that bypass cache. If devices are allowed to do this then the hypervisor must emulate instructions like WBINVD or else drivers in the guest have no way to synchronize RAM for the device. Instead of forcing WBINVD when a device

[Qemu-devel] [PULL 12/17] tcg: Add tcg-be-null.h

2013-10-10 Thread Richard Henderson
This is a no-op backend data implementation, for those targets that are not currently using the load/store optimization path. This is prepatory to always requiring these functions in all backends. Signed-off-by: Richard Henderson --- tcg/ia64/tcg-target.c | 2 ++ tcg/mips/tcg-target.c | 2 +

[Qemu-devel] [PULL 08/17] tcg: Add tcg-runtime.c helpers to all_helpers

2013-10-10 Thread Richard Henderson
For the few targets that actually use these, we'd not report them symbolicly in the tcg opcode logs. Signed-off-by: Richard Henderson --- tcg/tcg.c | 16 1 file changed, 16 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index 81218dc..154ae5b 100644 --- a/tcg/tcg.c +++ b/tcg/

Re: [Qemu-devel] [RFC] SPAPR-PCI Hotplug Support in Qemu

2013-10-10 Thread Mike Day
Adding Anthony's corrected address. On Thu, Oct 10, 2013 at 6:25 PM, Mike Day wrote: [RFC] SPAPR-PCI Hotplug Support in Qemu > > Background: > ppc64 has a unique bus structure for PCI slots: each slot is connected > to its PHB by a pci switch. This is true in some IBM hardware as well as > paravi

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-10 Thread Brian Murray
Hello Mark, or anyone else affected, Accepted qemu-kvm into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/qemu-kvm/1.0+noroms- 0ubuntu14.12 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Qemu-devel] [PULL 02/17] tcg: Delete tcg_helper_get_name declaration

2013-10-10 Thread Richard Henderson
The function was deleted in 4dc81f2822187f4503d4bdb76785cafa5b28db0b. Reviewed-by: Stefan Weil Signed-off-by: Richard Henderson --- tcg/tcg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 902c751..20543f6 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -681,7 +681,6 @

[Qemu-devel] PPC: Timer issues with git master

2013-10-10 Thread Mark Cave-Ayland
Hi all, I've just upgraded my git repository from around the 1.6 release timeframe to git master and I'm seeing some strange timing issues running through my OpenBIOS test suite which weren't there before my git update. The two most noticeable changes are in FreeBSD and HelenOS; the countdo

[Qemu-devel] [PULL 00/17] TCG 2013-10-10

2013-10-10 Thread Richard Henderson
This is a combination of 3.5 patch sets posted over the last month: delete hppa, move helper registrations to tcg.c, move a configure flag to tcg backends, and the first half of conversion to new ldst opcodes. Once applied, I'll follow up with tcg backend specific pull requests that ought to be co

[Qemu-devel] [RFC] SPAPR-PCI Hotplug Support in Qemu

2013-10-10 Thread Mike Day
[RFC] SPAPR-PCI Hotplug Support in Qemu Background: ppc64 has a unique bus structure for PCI slots: each slot is connected to its PHB by a pci switch. This is true in some IBM hardware as well as paravirtual hardware (PAPR). SLOF firmware normally scans the hardware bus and creates the correct s

[Qemu-devel] QEMU/CPC project: an experience report

2013-10-10 Thread Gabriel Kerneis
Dear all, We were so excited about our QEMU/CPC GSoC project that we have decided to write a 12-page article to share our experience: QEMU/CPC: static analysis and CPS conversion for safe, portable, and efficient coroutines http://gabriel.kerneis.info/research/files/q

Re: [Qemu-devel] [PATCH] mm: hugetlb: initialize PG_reserved for tail pages of gigantig compound pages

2013-10-10 Thread Rafael Aquini
On Thu, Oct 10, 2013 at 06:12:41PM +0200, Andrea Arcangeli wrote: > 11feeb498086a3a5907b8148bdf1786a9b18fc55 introduced a memory leak when > KVM is run on gigantic compound pages. > > 11feeb498086a3a5907b8148bdf1786a9b18fc55 depends on the assumption > that PG_reserved is identical for all head an

[Qemu-devel] [PULL 10/17] tcg-aarch64: Update to helper_ret_*_mmu routines

2013-10-10 Thread Richard Henderson
A minimal update to use the new helpers with the return address argument. Tested-by: Claudio Fontana Reviewed-by: Claudio Fontana Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 18 -- tcg/aarch64/tcg-target.c | 28 2 files changed,

[Qemu-devel] [PULL 03/17] tcg: Use a GHashTable for tcg_find_helper

2013-10-10 Thread Richard Henderson
Slightly changes the interface, in that we now return name instead of a TCGHelperInfo structure, which goes away. Reviewed-by: Stefan Weil Signed-off-by: Richard Henderson --- tcg/tcg.c | 74 --- tcg/tcg.h | 10 + 2 files chang

[Qemu-devel] [PULL 06/17] tcg: Remove stray semi-colons from target-*/helper.h

2013-10-10 Thread Richard Henderson
During GEN_HELPER=1, these are actually stray top-level semi-colons which are technically invalid ISO C, but GCC accepts as an extension. If we added enough __extension__ markers that we could dare use -Wpedantic, we'd see warning: ISO C does not allow extra ‘;’ outside of a function This will

[Qemu-devel] [PULL 05/17] tcg: Move helper registration into tcg_context_init

2013-10-10 Thread Richard Henderson
No longer needs to be done on a per-target basis. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 4 target-arm/translate.c| 3 --- target-cris/translate.c | 3 --- target-i386/translate.c | 4 target-m68k/translate.c | 3 --- target-micro

[Qemu-devel] [PULL 17/17] exec: Add both big- and little-endian memory helpers

2013-10-10 Thread Richard Henderson
Step three in the transition: helpers not tied to the target "default" endianness. To be used when the guest uses a memory operation with non-default endianness. Signed-off-by: Richard Henderson --- include/exec/softmmu_template.h | 286 +++- tcg/tcg.h

[Qemu-devel] [PULL 14/17] configure: Remove CONFIG_QEMU_LDST_OPTIMIZATION

2013-10-10 Thread Richard Henderson
No longer used. Signed-off-by: Richard Henderson --- configure | 8 1 file changed, 8 deletions(-) diff --git a/configure b/configure index aeb6bbf..57ee62a 100755 --- a/configure +++ b/configure @@ -3791,14 +3791,6 @@ echo "libs_softmmu=$libs_softmmu" >> $config_host_mak echo "ARCH

[Qemu-devel] [PULL 16/17] tcg: Add qemu_ld_st_i32/64

2013-10-10 Thread Richard Henderson
Step two in the transition, adding the new ldst opcodes. Keep the old opcodes around until all backends support the new opcodes. Signed-off-by: Richard Henderson --- tcg/README | 43 - tcg/aarch64/tcg-target.h | 2 + tcg/arm/tcg-target.h | 2 + tcg/i386/tcg-target

[Qemu-devel] [PULL 11/17] exec: Delete is_tcg_gen_code and GETRA_EXT

2013-10-10 Thread Richard Henderson
All implementations now boil down to GETRA. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 12 include/exec/softmmu_template.h | 4 ++-- translate-all.c | 12 3 files changed, 2 insertions(+), 26 deletions(-) diff --git a/includ

[Qemu-devel] [PULL 09/17] tcg: Merge tcg_register_helper into tcg_context_init

2013-10-10 Thread Richard Henderson
Eliminates the repeated checks for having created the s->helpers hash table. Signed-off-by: Richard Henderson --- tcg/tcg.c | 21 ++--- tcg/tcg.h | 1 - 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 154ae5b..3b88c56 100644 --- a/tcg/

[Qemu-devel] [PULL 15/17] tcg: Add TCGMemOp

2013-10-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.h | 54 ++ 1 file changed, 54 insertions(+) diff --git a/tcg/tcg.h b/tcg/tcg.h index 7d0c652..db0abc3 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -197,6 +197,60 @@ typedef enum TCGType { #endif } TCG

[Qemu-devel] [PULL 13/17] tcg: Add tcg-be-ldst.h

2013-10-10 Thread Richard Henderson
Move TCGLabelQemuLdst and related stuff out of tcg.h. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 23 ++--- tcg/arm/tcg-target.c | 27 ++- tcg/i386/tcg-target.c| 30 ++-- tcg/ppc/tcg-target.c | 28 ++- tcg/ppc64/tcg-targ

[Qemu-devel] [PULL 07/17] tcg: Put target helper data into an array.

2013-10-10 Thread Richard Henderson
One call inside of a loop to tcg_register_helper instead of hundreds of sequential calls. Presumably more icache and branch prediction friendly; resulting binary size mostly unchanged on x86_64, as we're trading 32-bit rip-relative references in .text for full 64-bit pointers in .rodata. Signed-o

[Qemu-devel] [PULL 04/17] target-m68k: Rename helpers.h to helper.h

2013-10-10 Thread Richard Henderson
This brings the m68k target in line with all other targets. Reviewed-by: Stefan Weil Signed-off-by: Richard Henderson --- target-m68k/helper.c| 2 +- target-m68k/{helpers.h => helper.h} | 0 target-m68k/op_helper.c | 2 +- target-m68k/translate.c | 6 +++-

Re: [Qemu-devel] [PATCH 2/4] vring: factor common code for error exits

2013-10-10 Thread Richard Henderson
On 10/10/2013 08:07 AM, Paolo Bonzini wrote: > return head; > + > +out: > +assert(ret < 0); > +if (ret == -EFAULT) { > +vring->broken = true; > +} > +return ret; If this is only the error path, can we call the label something other than "out"? r~

[Qemu-devel] [PULL 0/3] qemu-ga: fsfreeze fix and guest-info extensions

2013-10-10 Thread Michael Roth
Hi Anthony, The following patches add support for indicating whether a guest agent command returns a response, as well as a fix to unfreeze filesystems LIFO order to avoid deadlocks in some cases where images are loopback-mounted to frozen filesystem. The following changes since commit f2c6bcfc2e

[Qemu-devel] [PATCH 3/3] qemu-ga: Extend 'guest-info' command to expose flag 'success-response'

2013-10-10 Thread Michael Roth
From: Mark Wu Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this change, the clients can handle the command response more flexib

[Qemu-devel] [PATCH 2/3] qemu-ga: Add interface to traverse the qmp command list by QmpCommand

2013-10-10 Thread Michael Roth
From: Mark Wu In the original code, qmp_get_command_list is used to construct a list of all commands' name. To get the information of all qga commands, it traverses the name list and search the command info with its name. So it can cause O(n^2) in the number of commands. This patch adds an inte

[Qemu-devel] [PATCH 1/3] qemu-ga: execute fsfreeze-freeze in reverse order of mounts

2013-10-10 Thread Michael Roth
From: Tomoki Sekiyama Currently, fsfreeze-freeze may cause deadlock if a guest has loopback mounts of image files in its disk; e.g.: # mount | grep ^/ /dev/vda1 / type ext4 (rw,noatime,seclabel,data=ordered) /tmp/disk.img on /mnt type ext4 (rw,relatime,seclabel) To avoid the deadloc

[Qemu-devel] [PULL v2 5/8] vfio-pci: Implement PCI hot reset

2013-10-10 Thread Alex Williamson
Now that VFIO has a PCI hot reset interface, take advantage of it. There are two modes that we need to consider. The first is when only one device within the set of devices affected is actually assigned to the guest. In this case the other devices are are just held by VFIO for isolation and we ca

[Qemu-devel] [PULL v2 6/8] vfio: Fix debug output for int128 values

2013-10-10 Thread Alex Williamson
From: Alexey Kardashevskiy Memory regions can easily be 2^64 byte long and therefore overflow for just a bit but that is enough for int128_get64() to assert. This takes care of debug printing of huge section sizes. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Alex Williamson --- hw/mis

[Qemu-devel] [PULL v2 3/8] vfio-pci: Lazy PCI option ROM loading

2013-10-10 Thread Alex Williamson
During vfio-pci initfn, the device is not always in a state where the option ROM can be read. In the case of graphics cards, there's often no per function reset, which means we have host driver state affecting whether the option ROM is usable. Ideally we want to move reading the option ROM past a

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

2013-10-10 Thread Sebastian Herbszt
Andreas Färber wrote: > Same for http://patchwork.ozlabs.org/patch/273758/ - vgabios seems to > be falling through the cracks... > > Andreas > Is this patch still required? I was under the impression that no patch is needed for Win 8 after reading the thread on SeaBIOS list. Sebastian

Re: [Qemu-devel] [PATCH] Spelling fixes

2013-10-10 Thread Stefan Weil
Am 08.07.2013 17:14, schrieb Corentin Chary: > The comments (and most of the code) are from libvncserver (and, > earlier, from "THE 'ZYWRLE' VNC CODEC SOURCE CODE. " as described in > the header): > > http://fastdroid-vnc.googlecode.com/svn-history/r3/trunk/LibVNCServer-0.9.7/libvncserver/zywrletem

[Qemu-devel] [PATCH] misc: New spelling fixes in comments

2013-10-10 Thread Stefan Weil
compatiblity -> compatibility continously -> continuously existance -> existence usefull -> useful shoudl -> should Signed-off-by: Stefan Weil --- block/iscsi.c|2 +- hw/ppc/spapr.c |2 +- target-alpha/translate.c |2 +- tests/test-throttle.c|4 ++-- 4 f

[Qemu-devel] [PULL v2 7/8] vfio-pci: Add dummy PCI ROM write accessor

2013-10-10 Thread Alex Williamson
Just to be sure we don't jump off any NULL pointer cliffs. Signed-off-by: Alex Williamson Reported-by: Paolo Bonzini --- hw/misc/vfio.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 68e25bd..1fbc40b 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/v

[Qemu-devel] [PULL v2 8/8] vfio-pci: Fix endian issues in vfio_pci_size_rom()

2013-10-10 Thread Alex Williamson
VFIO is always little endian so do byte swapping of our mask on the way in and byte swapping of the size on the way out. Signed-off-by: Alex Williamson Reported-by: Alexey Kardashevskiy --- hw/misc/vfio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/vfio.c

[Qemu-devel] [PULL v2 4/8] vfio-pci: Cleanup error_reports

2013-10-10 Thread Alex Williamson
Remove carriage returns and tweak formatting for error_reports. Signed-off-by: Alex Williamson --- hw/misc/vfio.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 730dec5..a73e7f5 100644 --- a/hw/misc/vfio.c ++

[Qemu-devel] [PULL v2 1/8] vfio-pci: Add support for MSI affinity

2013-10-10 Thread Alex Williamson
When MSI is accelerated through KVM the vectors are only programmed when the guest first enables MSI support.  Subsequent writes to the vector address or data fields are ignored.  Unfortunately that means we're ignore updates done to adjust SMP affinity of the vectors. MSI SMP affinity already work

[Qemu-devel] [PULL v2 2/8] vfio-pci: Test device reset capabilities

2013-10-10 Thread Alex Williamson
Not all resets are created equal. PM reset is not very reliable, especially for GPUs, so we might want to opt for a bus reset if a standard reset will only do a D3hot->D0 transition. We can also use this to tell if the standard reset will do a bus reset (if neither has_pm_reset or has_flr is prob

[Qemu-devel] [PULL v2 0/8] VFIO updates for QEMU

2013-10-10 Thread Alex Williamson
The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-pci-for-qemu-20131010.0 for

Re: [Qemu-devel] [PATCH] mm: hugetlb: initialize PG_reserved for tail pages of gigantig compound pages

2013-10-10 Thread Rik van Riel
On 10/10/2013 12:12 PM, Andrea Arcangeli wrote: 11feeb498086a3a5907b8148bdf1786a9b18fc55 introduced a memory leak when KVM is run on gigantic compound pages. 11feeb498086a3a5907b8148bdf1786a9b18fc55 depends on the assumption that PG_reserved is identical for all head and tail pages of a compound

Re: [Qemu-devel] [PATCH] Use qemu-project.org domain name

2013-10-10 Thread Stefan Weil
Am 10.10.2013 11:39, schrieb Stefan Hajnoczi: > qemu.org is held by a third-party and no core community contributor has > access to the DNS configuration. This leaves the website exposed to > outages due to DNS issues or IP address changes. For example, if the > web server IP address needs to cha

Re: [Qemu-devel] NBD support for mingw32 (windows)

2013-10-10 Thread Stefan Weil
Am 10.10.2013 10:52, schrieb Goshen, OrX: > > Hi, > > > > This patch adds support for NBD under mingw32. > > It contains a small hack with the use of Sleep(). > > > > signed-off-by: Goshen, OrX orx.gos...@intel.com > , Ocheretny, Pavel > pavel.ochere...@intel.com

Re: [Qemu-devel] lsi_soft_reset: Assertion `!s->current' failed with Windows XP setup

2013-10-10 Thread Claudio Bley
At Mon, 29 Jul 2013 16:17:35 +0200, Paolo Bonzini wrote: > > Il 29/07/2013 15:31, Claudio Bley ha scritto: > > Hi. > > > > At Thu, 02 May 2013 19:20:58 +0200, > > Paolo Bonzini wrote: > >> > >> Il 30/04/2013 14:59, Claudio Bley ha scritto: > >>> At Mon, 29 Apr 2013 17:54:37 +0200, > >>> Paolo Bo

Re: [Qemu-devel] [PATCH 0/5] block: Employ error parameter

2013-10-10 Thread Eric Blake
On 10/10/2013 07:43 AM, Max Reitz wrote: > The series "block: Error parameter for opening/creating images" > introduced exactly that. However, right now, this parameter is in fact > only used by qcow2. This series adds support to some additional block > drivers for which it was basically trivial. M

Re: [Qemu-devel] [PATCH 3/5] block/raw-win32: Employ error parameter

2013-10-10 Thread Eric Blake
On 10/10/2013 07:44 AM, Max Reitz wrote: > Make use of the error parameter in the opening and creating functions in > block/raw-win32.c. > > Signed-off-by: Max Reitz > --- > block/raw-win32.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > @@ -586,8 +590,10 @@ static

Re: [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message

2013-10-10 Thread Alex Williamson
On Thu, 2013-10-10 at 12:58 -0400, Cole Robinson wrote: > Using multiple calls to error_report here means every line is > prefaced with the (potentially long) pci-assign command line > arguments. Use a single error_report to preserve the intended > formatting. > > Signed-off-by: Cole Robinson > -

[Qemu-devel] [PATCH] Update email address

2013-10-10 Thread Anthony Liguori
From: Anthony Liguori Amazon is now funding my work as QEMU maintainer so update addresses accordingly. Signed-off-by: Anthony Liguori --- MAINTAINERS | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index ab8166a..fbe1fd9 100644 ---

[Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message

2013-10-10 Thread Cole Robinson
Using multiple calls to error_report here means every line is prefaced with the (potentially long) pci-assign command line arguments. Use a single error_report to preserve the intended formatting. Signed-off-by: Cole Robinson --- hw/i386/kvm/pci-assign.c | 34 +++---

[Qemu-devel] [PATCH] mm: hugetlb: initialize PG_reserved for tail pages of gigantig compound pages

2013-10-10 Thread Andrea Arcangeli
11feeb498086a3a5907b8148bdf1786a9b18fc55 introduced a memory leak when KVM is run on gigantic compound pages. 11feeb498086a3a5907b8148bdf1786a9b18fc55 depends on the assumption that PG_reserved is identical for all head and tail pages of a compound page. So that if get_user_pages returns a tail pa

[Qemu-devel] [PATCH] initialize PG_reserved for tail pages of gigantig compound pages

2013-10-10 Thread Andrea Arcangeli
Hi, large CC list because the below patch is important to merge before 3.12 final, either that or 11feeb498086a3a5907b8148bdf1786a9b18fc55 should be reverted ASAP. The optimization 11feeb498086a3a5907b8148bdf1786a9b18fc55 avoids deferefencing the head page during KVM mmio vmexit, and it is a wort

Re: [Qemu-devel] [PATCH RFC 5/9] ich9: Document why cannot_instantiate_with_device_add_yet

2013-10-10 Thread Paolo Bonzini
Il 10/10/2013 18:01, Paolo Bonzini ha scritto: > Il 10/10/2013 16:42, arm...@redhat.com ha scritto: >> From: Markus Armbruster >> >> An ICH9 southbridge contains several PCI devices, some of them with >> multiple functions. We model each function as a separate qdev. Two >> of them need some spec

Re: [Qemu-devel] [PATCH RFC 5/9] ich9: Document why cannot_instantiate_with_device_add_yet

2013-10-10 Thread Paolo Bonzini
Il 10/10/2013 16:42, arm...@redhat.com ha scritto: > From: Markus Armbruster > > An ICH9 southbridge contains several PCI devices, some of them with > multiple functions. We model each function as a separate qdev. Two > of them need some special wiring set up in pc_q35_init() to work: the > LPC

[Qemu-devel] [PATCH 2/4] vring: factor common code for error exits

2013-10-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/block/dataplane/virtio-blk.c | 1 + hw/virtio/dataplane/vring.c | 34 +- 2 files changed, 22 insertions(+), 13 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index f2d7350..319a2

[Qemu-devel] [PATCH 0/4] dataplane: use more of the generic virtio data structures, drop hostmem

2013-10-10 Thread Paolo Bonzini
Now that the memory API is thread-safe, we can use it in virtio-blk-dataplane and replace hostmem.[ch]. This series does this, and also changes the vring API to use VirtQueueElement (with an eye towards migration). With this change, virtio-blk-dataplane is also safe against memory hot-unplug. Th

Re: [Qemu-devel] [PATCH] Use qemu-project.org domain name

2013-10-10 Thread Peter Maydell
On 11 October 2013 00:06, Stefan Hajnoczi wrote: > On Thu, Oct 10, 2013 at 2:52 PM, Peter Maydell > wrote: >> I agree we need to make this change -- but do you know if >> an existing checkout with the submodule checked out will >> automatically do the Right Thing on git update or if manual >> in

Re: [Qemu-devel] [patch 0/2] force -mem-path RAM allocation

2013-10-10 Thread Marcelo Tosatti
On Wed, Oct 09, 2013 at 11:27:37PM +0200, Paolo Bonzini wrote: > Il 09/10/2013 22:05, Marcelo Tosatti ha scritto: > >>> > > Can the new option format for memory be created incrementally on > >>> > > top of -mem-path-force? (agree its a good thing, it avoids > >>> > > proliferation > >>> > > of ne

Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually

2013-10-10 Thread Marcelo Tosatti
On Wed, Oct 09, 2013 at 11:26:58PM +0200, Paolo Bonzini wrote: > Il 09/10/2013 21:41, Marcelo Tosatti ha scritto: > >> > How was that tested? For BUS_MCEERR_AO it can work, but BUS_MCEERR_AR > >> > calls force_sig_info which does this: > >> > > >> > ignored = action->sa.sa_handler == SIG_

[Qemu-devel] [PATCH 4/4] dataplane: replace hostmem with memory_region_find

2013-10-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/virtio/dataplane/Makefile.objs | 2 +- hw/virtio/dataplane/hostmem.c | 183 -- hw/virtio/dataplane/vring.c | 74 -- include/hw/virtio/dataplane/hostmem.h | 58 --- include/hw/virtio/d

[Qemu-devel] [PATCH 1/4] vring: create a common function to parse descriptors

2013-10-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/virtio/dataplane/vring.c | 113 1 file changed, 51 insertions(+), 62 deletions(-) diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c index 351a343..8294f36 100644 --- a/hw/virtio/dataplane/vring.

[Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-10-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/block/dataplane/virtio-blk.c | 85 ++--- hw/virtio/dataplane/vring.c | 51 +- include/hw/virtio/dataplane/vring.h | 6 +-- 3 files changed, 66 insertions(+), 76 deletions(-) diff --git a/hw/block

Re: [Qemu-devel] [PATCH] Use qemu-project.org domain name

2013-10-10 Thread Stefan Hajnoczi
On Thu, Oct 10, 2013 at 2:52 PM, Peter Maydell wrote: > On 10 October 2013 18:39, Stefan Hajnoczi wrote: >> --- a/.gitmodules >> +++ b/.gitmodules >> @@ -1,27 +1,27 @@ >> [submodule "roms/vgabios"] >> path = roms/vgabios >> - url = git://git.qemu.org/vgabios.git/ >> + url = g

Re: [Qemu-devel] [PATCH 0/2] Improve -device command line help some more

2013-10-10 Thread Marcel Apfelbaum
On Thu, 2013-10-10 at 15:00 +0200, arm...@redhat.com wrote: > From: Markus Armbruster > > Marcel's recent improvements (commit dbd94f8..125ee0e) go in the right > direction, but there are issues (see PATCH 1/2), and I find the > resulting help output still hard to read. > > This series redoes th

Re: [Qemu-devel] [PATCH 1/2] Mostly revert "qemu-help: Sort devices by logical functionality"

2013-10-10 Thread Marcel Apfelbaum
On Thu, 2013-10-10 at 15:00 +0200, arm...@redhat.com wrote: > From: Markus Armbruster > > This reverts most of commit 3d1237fb2ab4edb926c717767bb5e31d6053a7c5. > > The commit claims to sort the output of "-device help" "by > functionality rather than alphabetical". Issues: > > * The output was

[Qemu-devel] [PATCH RFC 7/9] vt82c686: Document why cannot_instantiate_with_device_add_yet

2013-10-10 Thread armbru
From: Markus Armbruster A VT82C686B southbridge has multiple functions. We model each function as a separate qdev. One of them need some special wiring set up in mips_fulong2e_init() to work: the ISA bridge at 05.0. Additionally, the IDE controller at 05.1 has always had cannot_instantiate_wit

[Qemu-devel] [PATCH RFC 5/9] ich9: Document why cannot_instantiate_with_device_add_yet

2013-10-10 Thread armbru
From: Markus Armbruster An ICH9 southbridge contains several PCI devices, some of them with multiple functions. We model each function as a separate qdev. Two of them need some special wiring set up in pc_q35_init() to work: the LPC controller at 00:1f.0, and the SMBus controller at 00:1f.3. S

[Qemu-devel] [PATCH RFC 1/9] qdev: Replace no_user by cannot_instantiate_with_device_add_yet

2013-10-10 Thread armbru
From: Markus Armbruster DeviceClass member no_user used to make device models unavailable with -device / device_add, but that regressed in commit 18b6dad. All that's left is the device model is still omitted from help. Attempts to fix the regression have been rejected with the argument that the

[Qemu-devel] [PATCH RFC 8/9] isa: Clean up use of cannot_instantiate_with_device_add_yet

2013-10-10 Thread armbru
From: Markus Armbruster Drop it when there's no obvious reason why device_add could not work. Else keep and document why. * isa-fdc, port92, i8042, m48t59_isa, mc146818rtc, isa-pit, kvm-pit: drop (the last two by dropping it from their abstract base pit-common) * pcspk: keep because of poin

[Qemu-devel] [PATCH RFC 6/9] piix3 piix4: Document why cannot_instantiate_with_device_add_yet

2013-10-10 Thread armbru
From: Markus Armbruster A PIIX3/PIIX4 southbridge has multiple functions. We model each function as a separate qdev. Two of them need some special wiring set up in pc_init1() or mips_malta_init() to work: the ISA bridge at 01.0, and the SMBus controller at 01.3. Additionally, the IDE controlle

[Qemu-devel] [PATCH RFC 3/9] apic: Document why cannot_instantiate_with_device_add_yet

2013-10-10 Thread armbru
From: Markus Armbruster Signed-off-by: Markus Armbruster --- hw/intc/apic_common.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index ea420c7..aaef054 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -38

[Qemu-devel] [PULL 0/2] Xen 2013-10-10

2013-10-10 Thread Stefano Stabellini
The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2013-10-10 Matthew Da

[Qemu-devel] [PATCH RFC 0/9] Clean up and fix no_user

2013-10-10 Thread armbru
From: Markus Armbruster Note: this series is on top of my "Improve -device command line help some more" series. You can also get it from branch no-user at git://repo.or.cz/qemu/armbru.git In an ideal world, machines can be built by wiring devices together with configuration, not code. Unfortun

[Qemu-devel] [PATCH RFC 9/9] qdev: Do not let the user try to device_add when it cannot work

2013-10-10 Thread armbru
From: Markus Armbruster Such devices have always been unavailable and omitted from the list of available devices shown by device_add help. Until commit 18b6dad silently broke the former, setting up nasty traps for unwary users, like this one: $ qemu-system-x86_64 -nodefaults -monitor stdio

  1   2   3   >