[Qemu-devel] [PATCH v4] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-10-07 Thread Mark Wu
Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this change, the clients can handle the command response more flexibly. Signed-off-

[Qemu-devel] [PATCH v2] Add interface to traverse the qmp command list by QmpCommand

2013-10-07 Thread Mark Wu
In the original code, qmp_get_command_list is used to construct a list of all commands' name. To get the information of all qga commands, it traverses the name list and search the command info with its name. So it can cause O(n^2) in the number of commands. This patch adds an interface to travers

[Qemu-devel] [patch 0/2] force -mem-path RAM allocation

2013-10-07 Thread Marcelo Tosatti
See individual patches for details.

[Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually

2013-10-07 Thread Marcelo Tosatti
MAP_POPULATE mmap flag does not cause mmap to fail if allocation of the entire area is not performed. HugeTLBfs performs reservation of pages on a global basis: any further restriction to the reserved memory such as cpusets placement or numa node policy is performed at fault time only. Manually

[Qemu-devel] [patch 2/2] qemu: add -mem-path-force option to force RAM allocation via -mem-path

2013-10-07 Thread Marcelo Tosatti
Default behaviour is to fallback for standard RAM allocation if -mem-path allocation fails. Add an option to force -mem-path RAM allocation (failing otherwise). Signed-off-by: Marcelo Tosatti Index: qemu/exec.c === --- qemu.orig/ex

Re: [Qemu-devel] Update the id of Vexpress Cortex-A9 from r0p0 to r0p1?

2013-10-07 Thread Peter Maydell
On 8 October 2013 05:17, Mian Yousaf Kaukab wrote: > On Sun, Oct 6, 2013 at 2:10 PM, Peter Maydell > wrote: >> If we're updating, why would we update only to r0p1 and not to the most >> recent rev/patchlevel? > > Does ARM provide physical vexpress platform with newer revisions of > A9? If yes, t

Re: [Qemu-devel] [PATCH] Fix pc migration from qemu <= 1.5

2013-10-07 Thread Cole Robinson
On 10/07/2013 05:43 PM, Bandan Das wrote: > Hi Cole, > > Cole Robinson writes: > >> The following commit introduced a migration incompatibility: >> >> commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe >> Author: David Gibson >> Date: Thu Jun 6 18:48:49 2013 +1000 >> >> pci: Replace pci_find

Re: [Qemu-devel] [PATCH] Fix pc migration from qemu <= 1.5

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 22:57, Cole Robinson ha scritto: > The following commit introduced a migration incompatibility: > > commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe > Author: David Gibson > Date: Thu Jun 6 18:48:49 2013 +1000 > > pci: Replace pci_find_domain() with more general pci_root_bus_p

Re: [Qemu-devel] [PATCH] Fix pc migration from qemu <= 1.5

2013-10-07 Thread Bandan Das
Hi Cole, Cole Robinson writes: > The following commit introduced a migration incompatibility: > > commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe > Author: David Gibson > Date: Thu Jun 6 18:48:49 2013 +1000 > > pci: Replace pci_find_domain() with more general pci_root_bus_path() > > The i

[Qemu-devel] [PATCH] Fix pc migration from qemu <= 1.5

2013-10-07 Thread Cole Robinson
The following commit introduced a migration incompatibility: commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe Author: David Gibson Date: Thu Jun 6 18:48:49 2013 +1000 pci: Replace pci_find_domain() with more general pci_root_bus_path() The issue is that i440fx savevm idstr went from :0

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Chris J Arges
** Description changed: SRU Justification [Impact]  * Users of QEMU that save their memory states using savevm/loadvm or migrate experience worse performance after the migration/loadvm. To workaround these issues VMs must be completely rebooted. Optimally we should be able to restore a VM

Re: [Qemu-devel] Update the id of Vexpress Cortex-A9 from r0p0 to r0p1?

2013-10-07 Thread Mian Yousaf Kaukab
Hi, On Sun, Oct 6, 2013 at 2:10 PM, Peter Maydell wrote: >> So what will it take to update the id of Cortex-A9 in qemu from r0p0 to r0p1? > > If we're updating, why would we update only to r0p1 and not to the most > recent rev/patchlevel? Does ARM provide physical vexpress platform with newer re

Re: [Qemu-devel] [PATCH v2 0/2] KVM: s390: add floating irq controller

2013-10-07 Thread Christian Borntraeger
On 05/10/13 01:54, Alexander Graf wrote: > > On 06.09.2013, at 15:30, Christian Borntraeger wrote: > >> On 06/09/13 14:19, Jens Freimann wrote:> This series adds a kvm_device that >> acts as a irq controller for floating >>> interrupts. As a first step it implements functionality to retrieve an

Re: [Qemu-devel] [PATCH] linux-user: define ipc_perm and shmid_ds per arch and fix shmctl issue

2013-10-07 Thread Petar Jovanovic
From: Peter Maydell [peter.mayd...@linaro.org] Sent: Monday, October 07, 2013 6:08 PM To: Petar Jovanovic Cc: QEMU Developers; Riku Voipio; Petar Jovanovic; Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] linux-user: define ipc_perm and shmid_ds per arch

[Qemu-devel] Speed up Guest clock

2013-10-07 Thread Vishal Verma
I'm trying to modify QEMU to speed up the guest clock to conduct some long running experiments. Is this feasible? One thing I have thought of: Modify icount_time_shift related stuff to make things happen faster. But I'm unsure if it will have the desired effect.

Re: [Qemu-devel] [PATCH v9 00/27] qemu: generate acpi tables for the guest

2013-10-07 Thread Andreas Färber
Am 07.10.2013 11:34, schrieb Michael S. Tsirkin: > Patches 1-3 are QOM patches really. > Included here for completeness. [...] > Igor Mammedov (1): > cleanup object.h: include error.h directly > > Michael S. Tsirkin (26): > qom: cleanup struct Error references > qom: add pointer to int prope

Re: [Qemu-devel] [PATCH qom-next 0/2] qdev-monitor: Reference counting follow-ups

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 18:43, Andreas Färber ha scritto: > Hello, > > I have queued bug fixes by Igor and Stefan for device_add on qom-next and > am rearranging the following changes of mine on top. > > 1) Further naming cleanups, now rebased on the bugfixes for easier > backporting. > 2) Inlining of qde

[Qemu-devel] [PATCH] kvm: Add a new machine property kvm_type

2013-10-07 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Targets like ppc64 support different typed of KVM, one which use hypervisor mode and the other which doesn't. Add a new machine property kvm_type that helps in selecting the respective ones We also add a new QEMUMachine callback get_vm_type that helps in mapping the strin

[Qemu-devel] [PATCH qom-next 1/2] qdev-monitor: Avoid qdev as variable name

2013-10-07 Thread Andreas Färber
Prepares for bringing error cleanup code into canonical QOM form. Includes a whitespace removal after curly brace by Stefan. Signed-off-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- qdev-monitor.c | 32 1 file changed, 16 insertions(+), 16 deletions(-)

[Qemu-devel] [PATCH qom-next 2/2] qdev-monitor: Inline qdev_init() for device_add

2013-10-07 Thread Andreas Färber
For historic reasons, qdev_init() unparents the device on failure. Inline this to make the error paths clearer and consistent. Signed-off-by: Andreas Färber --- qdev-monitor.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index f259e07.

[Qemu-devel] [PATCH qom-next 0/2] qdev-monitor: Reference counting follow-ups

2013-10-07 Thread Andreas Färber
Hello, I have queued bug fixes by Igor and Stefan for device_add on qom-next and am rearranging the following changes of mine on top. 1) Further naming cleanups, now rebased on the bugfixes for easier backporting. 2) Inlining of qdev_init(), so that we always have unparent+unref pairs. If there'

Re: [Qemu-devel] [PATCH v9 27/27] don't post me: update bios

2013-10-07 Thread Michael S. Tsirkin
On Tue, Oct 08, 2013 at 01:10:56AM +0900, Peter Maydell wrote: > On 7 October 2013 18:36, Michael S. Tsirkin wrote: > > update bios binaries to 55480e81704fa46429ac5bb4f8f452fadc9c0416 > > Subject: line doesn't match your actual behaviour :-) > > -- PMM Yes, I keep it around to simplify testing

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-10-07 Thread Mike Day
Paolo Bonzini writes: > Il 30/09/2013 15:34, Alex Bligh ha scritto: >> >> I think the most likely change here is that the walkers might >> move outside the BQL. Given modification of this list is so rare, >> the lock would be very very read heavy, so RCU is probably a >> sensible option. > > I

Re: [Qemu-devel] [PATCH v9 27/27] don't post me: update bios

2013-10-07 Thread Peter Maydell
On 7 October 2013 18:36, Michael S. Tsirkin wrote: > update bios binaries to 55480e81704fa46429ac5bb4f8f452fadc9c0416 Subject: line doesn't match your actual behaviour :-) -- PMM

Re: [Qemu-devel] [PATCH] linux-user: define ipc_perm and shmid_ds per arch and fix shmctl issue

2013-10-07 Thread Peter Maydell
On 8 October 2013 00:54, Petar Jovanovic wrote: > From: Petar Jovanovic > > Structs ipc_perm and shmid_ds are specific for each architecture and should > be defined accordingly. This change does that, and it also fix shmctl issue > by passing correct parameter buf to do_shmctl(). Please can you

[Qemu-devel] [PATCH] linux-user: define ipc_perm and shmid_ds per arch and fix shmctl issue

2013-10-07 Thread Petar Jovanovic
From: Petar Jovanovic Structs ipc_perm and shmid_ds are specific for each architecture and should be defined accordingly. This change does that, and it also fix shmctl issue by passing correct parameter buf to do_shmctl(). Signed-off-by: Petar Jovanovic --- linux-user/syscall.c | 78 +++

[Qemu-devel] sniffing traffic between VMs

2013-10-07 Thread Alexander Binun
Hello Friends, My name is Alex Binun and I am a researcher in the group of Prof. Shlomi Dolev, Ben-Gurion University of the Negev, Israel, http://www.cs.bgu.ac.il/~dolev/. The group investigates security in virtualization environments and implements a prototype on the top of KVM. Searching f

[Qemu-devel] [PATCH 0/2] [RFC] qemu-ga: add support for guest command execution

2013-10-07 Thread srinath reddy
Hi, Can someone help me in finding the status of this RFC here http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg00722.html I need a similar functionality. Thanks, Srinath. -- good day

[Qemu-devel] [PATCH 2/2] virtio: refresh registers at reset time

2013-10-07 Thread Greg Kurz
We need to support the guest endianness as soon as a virtio device shows up. Alex suggested this can achieved by calling cpu_synchronize_state(). To have it working on PowerPC, we need to add LPCR in the sync register functions. Signed-off-by: Greg Kurz --- hw/virtio/virtio.c |5 + targ

Re: [Qemu-devel] [PATCH RFC 04/11] s390/qemu: cpu model cpu facilitiy support

2013-10-07 Thread Michael Mueller
On Mon, 7 Oct 2013 12:47:53 +0200 Michael Mueller wrote: > On Thu, 03 Oct 2013 07:53:02 -0700 > Richard Henderson wrote: > > > On 10/02/2013 04:33 AM, Michael Mueller wrote: > > > +/* set a specific bit in facility set */ > > > +static void set_facility(unsigned int nr, void *facilities) > > >

[Qemu-devel] [PATCH 1/2] linux-headers: POWER8 partial update

2013-10-07 Thread Greg Kurz
Add definition for KVM_REG_PPC_LPCR, taken from: https://github.com/agraf/linux-2.6/commit/1a87967d4c Signed-off-by: Greg Kurz --- linux-headers/asm-powerpc/kvm.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-headers/asm-powerpc/kvm.h b/linux-headers/asm-powerpc/kvm.h index 0f

[Qemu-devel] [PATCH 0/2] virtio: guest endianness support

2013-10-07 Thread Greg Kurz
This patchset is a followup to Rusty's "virtio for endian curious guests" serie: https://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg01502.html It brings guest endianness knowledge to the virtio drivers when running in KVM mode, on PowerPC. The first patch is only here to have KVM_REG_PP

Re: [Qemu-devel] ChrEMU - Virtualization in the Browser

2013-10-07 Thread Paolo Bonzini
Il 25/09/2013 16:02, Stefan Hajnoczi ha scritto: >>> I'm pretty sure coroutines would provide difficult to port too. >>> >> >>> >> The gthread backend should work since it doesn't use stack-switching. >> > >> > ...except that the gthread backend doesn't work for anything >> > except some nebul

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-10-07 Thread Fabien Chouteau
On 10/07/2013 03:29 PM, Peter Maydell wrote: > On 7 October 2013 22:06, Fabien Chouteau wrote: >> On 10/07/2013 01:45 PM, Peter Maydell wrote: >>> On 7 October 2013 19:11, Fabien Chouteau wrote: On 10/04/2013 07:49 PM, Peter Maydell wrote: > On 5 October 2013 01:57, Fabien Chouteau wrot

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Chris J Arges
** Description changed: SRU Justification - [Impact] - * Users of QEMU that save their memory states using savevm/loadvm or migrate experience worse performance after the migration/loadvm. To workaround these issues VMs must be completely rebooted. Optimally we should be able to restore a V

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Chris J Arges
** Description changed: + SRU Justification + [Impact] + * Users of QEMU that save their memory states using savevm/loadvm or migrate experience worse performance after the migration/loadvm. To workaround these issues VMs must be completely rebooted. Optimally we should be able to restore a V

Re: [Qemu-devel] [PATCH -V4 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-10-07 Thread Alexander Graf
On 07.10.2013, at 15:58, Aneesh Kumar K.V wrote: > Alexander Graf writes: > >> On 01.10.2013, at 03:27, Aneesh Kumar K.V wrote: >> >>> Alexander Graf writes: >>> On 09/05/2013 10:16 AM, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > > > >>> >>> Can you explai

Re: [Qemu-devel] [PATCH v2 1/4] target-ppc: Fill in OpenFirmware names for some PowerPCCPU families

2013-10-07 Thread Alexey Kardashevskiy
On 10/01/2013 03:55 AM, Alexander Graf wrote: > On 09/25/2013 11:01 AM, Alexey Kardashevskiy wrote: >> On 09/17/2013 12:16 AM, Alexey Kardashevskiy wrote: >>> On 09/10/2013 02:15 PM, Alexey Kardashevskiy wrote: On 08/16/2013 08:35 AM, Andreas Färber wrote: > Set the expected values for POW

Re: [Qemu-devel] [PATCH -V4 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-10-07 Thread Aneesh Kumar K.V
Alexander Graf writes: > On 01.10.2013, at 03:27, Aneesh Kumar K.V wrote: > >> Alexander Graf writes: >> >>> On 09/05/2013 10:16 AM, Aneesh Kumar K.V wrote: From: "Aneesh Kumar K.V" >> >> Can you explain this better ? > > You're basically doing > > hwaddr ppc_hash64_pteg_se

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Chris J Arges
I found that two patches need to be backported to solve this issue: ad0b5321f1f797274603ebbe20108b0750baee94 211ea74022f51164a7729030b28eec90b6c99a08 I've added the necessary bits into precise and tried a few tests: 1) Measure performance before and after savevm/loadvm. 2) Measure performance bef

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-10-07 Thread Peter Maydell
On 7 October 2013 22:06, Fabien Chouteau wrote: > On 10/07/2013 01:45 PM, Peter Maydell wrote: >> On 7 October 2013 19:11, Fabien Chouteau wrote: >>> On 10/04/2013 07:49 PM, Peter Maydell wrote: On 5 October 2013 01:57, Fabien Chouteau wrote: > +extern const MonitorDef i386_monitor_defs

Re: [Qemu-devel] [PATCH v9 00/27] qemu: generate acpi tables for the guest

2013-10-07 Thread Igor Mammedov
On Mon, 7 Oct 2013 12:34:46 +0300 "Michael S. Tsirkin" wrote: > This code can also be found here: > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi > > While this patch still uses info not available in QOM, I think it's reasonable > to merge it and then refactor as QOM properties cover m

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-10-07 Thread Fabien Chouteau
On 10/07/2013 01:45 PM, Peter Maydell wrote: > On 7 October 2013 19:11, Fabien Chouteau wrote: >> On 10/04/2013 07:49 PM, Peter Maydell wrote: >>> On 5 October 2013 01:57, Fabien Chouteau wrote: > @@ -47,7 +48,9 @@ #include "hw/xen/xen.h" #include "hw/i386/apic_internal.h" #

[Qemu-devel] [Bug 1234179] Re: QEMU segfaults during Windows 7 unattended install

2013-10-07 Thread Lucas Meneghel Rodrigues
The problem showed up this morning again, same top commit: 10/07 01:34:42 INFO | git:0150| git commit ID is a684f3cf9b9b9c3cb82be87aafc463de8974610c (tag v1.4.0-4237-ga684f3c) This time around, debug symbols were enabled on the configure line: 10/07 01:35:31 DEBUG|build_help:0588| Enablin

Re: [Qemu-devel] [RFC PATCH v2 0/3] Fix UST backend for LTTng 2.x

2013-10-07 Thread Alex Bennée
mohamad.ge...@gmail.com writes: > Version 2 > > * Fix tracepoint generation error in first version. > * Avoid warnings and errors specific to LTTng ust 2.0. > * If using LTTng ust 2.0, we can't avoid getting warnings because of the > --warn-common option given to the linker. This is fixed in m

Re: [Qemu-devel] [PATCH v5 0/4] timers thread-safe stuff

2013-10-07 Thread Paolo Bonzini
Stefan, will you pick this up next week or shall I? I have patches for thread-safe icount almost ready to post, and I am not sure through whom they are going to go. Paolo Il 25/09/2013 08:20, Liu Ping Fan ha scritto: > v5: > fine rename some variable in patch2&4. > fix commit log for patch1

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-10-07 Thread Paolo Bonzini
Il 30/09/2013 15:34, Alex Bligh ha scritto: > > I think the most likely change here is that the walkers might > move outside the BQL. Given modification of this list is so rare, > the lock would be very very read heavy, so RCU is probably a > sensible option. I agree. Keeping the write side on t

[Qemu-devel] [PULL 8/8] block: use correct filename

2013-10-07 Thread Stefan Hajnoczi
From: Dunrong Huang The content filename point to may be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv->bdrv_file_open() So it's better to use bs->filename. Signed-off-by: Dunrong Huang Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi --- block.c | 4 ++-- 1 file chang

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-10-07 Thread Peter Maydell
On 7 October 2013 19:11, Fabien Chouteau wrote: > On 10/04/2013 07:49 PM, Peter Maydell wrote: >> On 5 October 2013 01:57, Fabien Chouteau wrote: >> >> @@ -47,7 +48,9 @@ >>> #include "hw/xen/xen.h" >>> #include "hw/i386/apic_internal.h" >>> #endif >>> +#include "monitor/monitor_def.h" >>> >>>

[Qemu-devel] [PULL 3/8] block: use correct filename for error report

2013-10-07 Thread Stefan Hajnoczi
From: Dunrong Huang The content filename point to will be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv->bdrv_file_open() So it's better to use bs->filename. Signed-off-by: Dunrong Huang Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi --- block.c | 4 ++-- 1 file chan

[Qemu-devel] [PULL 6/8] qcow2: Free allocated L2 cluster on error

2013-10-07 Thread Stefan Hajnoczi
From: Max Reitz If an error occurs in l2_allocate, the allocated (but unused) L2 cluster should be freed. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block/qcow2-cluster.c | 4 1 file changed, 4 insertions(+) diff --git a/block/qcow2-cluster.c

[Qemu-devel] [PULL 5/8] qcow2: Switch L1 table in a single sequence

2013-10-07 Thread Stefan Hajnoczi
From: Max Reitz Switching the L1 table in memory should be an atomic operation, as far as possible. Calling qcow2_free_clusters on the old L1 table on disk is not a good idea when the old L1 table is no longer valid and the address to the new one hasn't yet been written into the corresponding BDR

[Qemu-devel] [PULL 4/8] block: vhdx - add migration blocker

2013-10-07 Thread Stefan Hajnoczi
From: Jeff Cody This blocks migration for VHDX image files, until the functionality can be supported. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- block/vhdx.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/vhdx.c b/block/vhdx.c index b8aa49c..6cb0412 100

[Qemu-devel] [PULL 2/8] qcow2: CHECK_OFLAG_COPIED is obsolete

2013-10-07 Thread Stefan Hajnoczi
From: Max Reitz CHECK_OFLAG_COPIED as a parameter to check_refcounts_l1 and check_refcounts_l2 is obselete now, since the OFLAG_COPIED consistency check is actually no longer performed by these functions (but by check_oflag_copied). Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-b

[Qemu-devel] [PULL 7/8] qemu-iotests: Correct 026 output

2013-10-07 Thread Stefan Hajnoczi
From: Max Reitz Because l2_allocate now frees the unused L2 cluster on error, the according test cases in 026 don't result in one leaked cluster anymore. Signed-off-by: Max Reitz Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/026.out | 32 tests

[Qemu-devel] [PULL 0/8] Block patches

2013-10-07 Thread Stefan Hajnoczi
The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch changes up to d4cea

[Qemu-devel] [PULL 1/8] qcow2: Correct endianness in overlap check

2013-10-07 Thread Stefan Hajnoczi
From: Max Reitz If an inactive L1 table is loaded from disk, its entries are in big endian and have to be converted to host byte order before using them. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 4 ++-- 1 file changed, 2 ins

Re: [Qemu-devel] [PATCH RFC 04/11] s390/qemu: cpu model cpu facilitiy support

2013-10-07 Thread Michael Mueller
On Thu, 03 Oct 2013 07:53:02 -0700 Richard Henderson wrote: > On 10/02/2013 04:33 AM, Michael Mueller wrote: > > +/* set a specific bit in facility set */ > > +static void set_facility(unsigned int nr, void *facilities) > > +{ > > +unsigned char *ptr; > > + > > +if (nr >= MAX_S390_FACILIT

Re: [Qemu-devel] [PATCHv3 00/20] block: logical block provisioning enhancements

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 10:42, Stefan Hajnoczi ha scritto: > Could you make bdrv_co_write_zeroes() always use UNMAP, if possible, and > avoid adding the new BDRV_REQ_MAY_UNMAP flag? While reading the first > few patches in this series I wondered why there is a need to expose > flags at all... > > Sometimes

[Qemu-devel] [PATCH v9 01/27] cleanup object.h: include error.h directly

2013-10-07 Thread Michael S. Tsirkin
From: Igor Mammedov qapi/error.h is simple enough to be included in qom/object.h direcly and prepares qom/object.h to use Error typedef. Signed-off-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands

2013-10-07 Thread Fabien Chouteau
On 10/04/2013 07:52 PM, Peter Maydell wrote: >> +#include "monitor/monitor_def.h" >> + >> +const MonitorDef arm_monitor_defs[] = { >> +{ "r0", offsetof(CPUARMState, regs[0]) }, >> +{ "r1", offsetof(CPUARMState, regs[1]) }, > > These fields are all 32 bits, not target_long, > so t

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-10-07 Thread Fabien Chouteau
On 10/04/2013 07:49 PM, Peter Maydell wrote: > On 5 October 2013 01:57, Fabien Chouteau wrote: > >> @@ -47,7 +48,9 @@ >> #include "hw/xen/xen.h" >> #include "hw/i386/apic_internal.h" >> #endif >> +#include "monitor/monitor_def.h" >> >> +extern const MonitorDef i386_monitor_defs[]; > > Declare

Re: [Qemu-devel] [PATCH v3 0/8] hw/pci: set irq without selecting INTx pin

2013-10-07 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 10:36:33AM +0300, Marcel Apfelbaum wrote: > Interrupt pin is selected and saved into PCI_INTERRUPT_PIN > register during device initialization. Devices should not call > directly qemu_set_irq and specify the INTx pin. > > Added pci_* wrappers to replace qemu_set_irq, qemu_i

Re: [Qemu-devel] [PATCH] migration: drop MADVISE_DONT_NEED for incoming zero pages

2013-10-07 Thread Andreas Färber
Am 07.10.2013 11:22, schrieb Peter Lieven: > The madvise for zeroed out pages was introduced when every transferred > zero page was memset to zero and thus allocated. Since commit > 211ea740 we check for zeroness of a target page before we memset > it to zero. Additionally we memmap target memory s

Re: [Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 11:49, Peter Lieven ha scritto: >> It's in general not easy to do this if you take non-x86 targets into >> account. > What about the dirty way to zero out all non zero pages at the beginning of > ram_load? I'm not sure I follow? Paolo

[Qemu-devel] [PATCH v9 26/27] ssdt-proc: update generated file

2013-10-07 Thread Michael S. Tsirkin
Update generated ssdt proc hex file (used for systems lacking IASL) after P_BLK length change. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-proc.hex.generated | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Peter Lieven
On 07.10.2013 11:37, Paolo Bonzini wrote: Il 07/10/2013 08:38, Peter Lieven ha scritto: On 06.10.2013 15:57, Zhang Haoyu wrote: >From my testing this has been fixed in the saucy version (1.5.0) of qemu. It is fixed by this patch: f1c72795af573b24a7da5eb52375c9aba8a37972 However later in the

[Qemu-devel] [Bug 1235306] Re: Wrong memory viewer in 16 bit mode (Debugging BIOS OptionROM)

2013-10-07 Thread Leonid Myravjev
I apologize for the stupid ticket. Problem with a bad GDB configuration. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1235306 Title: Wrong memor

Re: [Qemu-devel] [PATCH] migration: drop MADVISE_DONT_NEED for incoming zero pages

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 11:22, Peter Lieven ha scritto: > The madvise for zeroed out pages was introduced when every transferred > zero page was memset to zero and thus allocated. Since commit > 211ea740 we check for zeroness of a target page before we memset > it to zero. Additionally we memmap target memor

[Qemu-devel] [PATCH v9 22/27] pvpanic: add API to access io port

2013-10-07 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 1 + hw/misc/pvpanic.c| 13 - 2 files changed, 13 insertions(+), 1

[Qemu-devel] [PATCH v9 21/27] ich9: APIs for pc guest info

2013-10-07 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in acpi tables, implemented using QOM, to various ich9 components. Some information is still missing in QOM, so we fall back on lookups by type instead. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw

[Qemu-devel] [PATCH v9 20/27] piix: APIs for pc guest info

2013-10-07 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest acpi tables. Some required information is still lacking in QOM, so we fall back on lookups by type and returning explicit types. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/piix4.h |

[Qemu-devel] [PATCH v9 19/27] acpi/piix: add macros for acpi property names

2013-10-07 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 10 ++ hw/acpi/piix4.c | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 085a621..5aefc5b 10

[Qemu-devel] [PATCH v9 18/27] i386: define pc guest info

2013-10-07 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Reviewed-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 9 + hw/i386/pc.c

[Qemu-devel] [PATCH v9 17/27] loader: allow adding ROMs in done callbacks

2013-10-07 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/loader.h | 1 + hw/core/loader.c| 6 +- vl.c| 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/includ

[Qemu-devel] [PATCH v9 16/27] i386: add bios linker/loader

2013-10-07 Thread Michael S. Tsirkin
This adds a dynamic bios linker/loader. This will be used by acpi table generation code to: - load each table in the appropriate memory segment - link tables to each other - fix up checksums after said linking Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael

[Qemu-devel] [PATCH v9 14/27] acpi: ssdt pcihp: updat generated file

2013-10-07 Thread Michael S. Tsirkin
update generated file, not sure what changed Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-pcihp.hex.generated | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/ssdt-pcihp.hex.generated b/hw/i386/ssdt-pc

Re: [Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 08:38, Peter Lieven ha scritto: > On 06.10.2013 15:57, Zhang Haoyu wrote: >>> >From my testing this has been fixed in the saucy version (1.5.0) of >> qemu. It is fixed by this patch: >>> f1c72795af573b24a7da5eb52375c9aba8a37972 >>> >>> However later in the history this commit was reve

[Qemu-devel] [PATCH v9 25/27] ssdt: fix PBLK length

2013-10-07 Thread Michael S. Tsirkin
We don't really support CPU throttling, so supply 0 PBLK length. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-proc.dsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/ssdt-proc.dsl b/hw/i386/ssdt-proc.dsl ind

[Qemu-devel] [PATCH v9 23/27] hpet: add API to find it

2013-10-07 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/timer/hpet.h | 2 ++ hw/timer/hpet.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h index 75

[Qemu-devel] [PATCH v9 09/27] q35: use macro for MCFG property name

2013-10-07 Thread Michael S. Tsirkin
Useful to make it accessible through QOM. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 2 ++ hw/pci-host/q35.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pcie_host.h b/i

[Qemu-devel] [PATCH v9 15/27] loader: use file path size from fw_cfg.h

2013-10-07 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/nvram/fw_cfg.h | 4 +++- hw/core/loader.c | 2 +- 2 files changed, 4 insertions(+), 2

[Qemu-devel] [PATCH v9 08/27] pcie_host: expose address format

2013-10-07 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 21 + hw/pci/pcie_host.c | 21 - 2 files changed,

[Qemu-devel] [PATCH v9 12/27] acpi: add rules to compile ASL source

2013-10-07 Thread Michael S. Tsirkin
Detect presence of IASL compiler and use it to process ASL source. If not there, use pre-compiled files in-tree. Add script to update the in-tree files. Note: distros are known to silently update iasl so detect correct iasl flags for the installed version on each run as opposed to at configure tim

[Qemu-devel] [PATCH v9 05/27] fw_cfg: interface to trigger callback on read

2013-10-07 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c | 33 - 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/include/hw/nvram/fw_cfg.h b/include/hw

[Qemu-devel] [PATCH v9 07/27] pcie_host: expose UNMAPPED macro

2013-10-07 Thread Michael S. Tsirkin
Make it possible to test unmapped status through QMP. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 3 +++ hw/pci/pcie_host.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/pci/

[Qemu-devel] [PATCH v9 10/27] q35: expose mmcfg size as a property

2013-10-07 Thread Michael S. Tsirkin
Address is already exposed, expose size for symmetry. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 1 + hw/pci-host/q35.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/hw/pci/pcie

[Qemu-devel] [PATCH v9 04/27] pci: fix up w64 size calculation helper

2013-10-07 Thread Michael S. Tsirkin
BAR base was calculated incorrectly. Use existing pci_bar_address to get it right. Tested-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin --- hw/pci/pci.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 00554a0..c3f

[Qemu-devel] [PATCH v9 03/27] qom: add pointer to int property helpers

2013-10-07 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 21 ++ qom/object.c | 60 +

[Qemu-devel] [PATCH v9 06/27] loader: support for unmapped ROM blobs

2013-10-07 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: same as ROM files really but use caller's buffer. Support invoking callback on access and return memory pointer making it easier for caller to update memory if necessary. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Reviewed-by: Laszlo Erse

[Qemu-devel] [PATCH v9 02/27] qom: cleanup struct Error references

2013-10-07 Thread Michael S. Tsirkin
now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 50 +---

[Qemu-devel] [PATCH v9 00/27] qemu: generate acpi tables for the guest

2013-10-07 Thread Michael S. Tsirkin
This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I think it's reasonable to merge it and then refactor as QOM properties cover more ground. In particular, merging this patchset blocks other projects so

Re: [Qemu-devel] [PATCH] spice: replace use of deprecated API

2013-10-07 Thread Gerd Hoffmann
On Fr, 2013-10-04 at 13:10 +0200, Marc-André Lureau wrote: > hose API are deprecated since 0.11, and qemu depends on 0.12 already. Added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices

2013-10-07 Thread Peter Lieven
On 07.10.2013 10:25, Paolo Bonzini wrote: Il 07/10/2013 07:59, Peter Lieven ha scritto: if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs->file. Signed-off-by: Peter Lieven --- v5: add a generic get_lba_

[Qemu-devel] [PATCH] migration: drop MADVISE_DONT_NEED for incoming zero pages

2013-10-07 Thread Peter Lieven
The madvise for zeroed out pages was introduced when every transferred zero page was memset to zero and thus allocated. Since commit 211ea740 we check for zeroness of a target page before we memset it to zero. Additionally we memmap target memory so it is essentially zero initalized (except for e.g

Re: [Qemu-devel] [PATCH 1/5] tcg-aarch64: Update to helper_ret_*_mmu routines

2013-10-07 Thread Claudio Fontana
On 10/05/13 09:37, Richard Henderson wrote: > On 10/04/2013 02:15 PM, Claudio Fontana wrote: >> At first glance I think we should add X4 to the list of restrictions in >> function `target_parse_constraint': > > No, we've consumed all of the inputs at this point. We only > need list those registe

[Qemu-devel] [PATCH v3 4/4] acpi-build: enable hotplug for PCI bridges

2013-10-07 Thread Michael S. Tsirkin
This enables support for device hotplug behind pci bridges. Bridge devices themselves need to be pre-configured on qemu command line. Design: - at machine init time, assign "bsel" property to bridges with hotplug support - dynamically (At ACPI table read) generate ACPI code to handle

[Qemu-devel] [PATCH V14 01/11] NUMA: move numa related code to new file numa.c

2013-10-07 Thread Wanlong Gao
Signed-off-by: Wanlong Gao --- Makefile.target | 2 +- cpus.c | 14 include/sysemu/cpus.h | 1 - include/sysemu/sysemu.h | 3 + numa.c | 182 vl.c| 139 +---

[Qemu-devel] [PATCH v3 2/4] pcihp: generalization of piix4 acpi

2013-10-07 Thread Michael S. Tsirkin
Add ACPI based PCI hotplug library with bridge hotplug support. Design - each bus gets assigned "bsel" property. - ACPI code writes this number to a new BNUM register, then uses existing UP/DOWN registers to probe slot status; to eject, write number to BNUM register, then

[Qemu-devel] [PATCH v3 3/4] piix4: add acpi pci hotplug support

2013-10-07 Thread Michael S. Tsirkin
Add support for acpi pci hotplug using the new infrastructure. PIIX4 legacy interface is maintained as is for machine types 1.6 and older. Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 5 hw/acpi/piix4.c | 75 +--- 2 files

  1   2   >